ipv6: use a stronger hash for tcp
authorEric Dumazet <edumazet@google.com>
Thu, 21 Feb 2013 12:18:52 +0000 (12:18 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Feb 2013 13:38:41 +0000 (05:38 -0800)
commit7e122d3c7c52acfa96c2939db26e7fd3cc96a651
tree42f0867b3cac491059b18d0c1c3663fe26543508
parent8044a3d3e58dc531791752ea593a76414d769479
ipv6: use a stronger hash for tcp

[ Upstream commit 08dcdbf6a7b9d14c2302c5bd0c5390ddf122f664 ]

It looks like its possible to open thousands of TCP IPv6
sessions on a server, all landing in a single slot of TCP hash
table. Incoming packets have to lookup sockets in a very
long list.

We should hash all bits from foreign IPv6 addresses, using
a salt and hash mix, not a simple XOR.

inet6_ehashfn() can also separately use the ports, instead
of xoring them.

Reported-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/net/inet6_hashtables.h
include/net/inet_sock.h
include/net/ipv6.h
net/ipv4/af_inet.c