n_gsm: memory leak in uplink error path
authorRuss Gorby <russ.gorby@intel.com>
Mon, 13 Aug 2012 12:45:30 +0000 (13:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 7 Oct 2012 15:32:27 +0000 (08:32 -0700)
commit1168fb4bf41d55b04c07d82cb5c1e0fde9be3cf9
tree78fe3837e57bdef54a6f68aa99bdc369fc96589c
parent119bd47785006d185e8247f63f44c43eaf345ed9
n_gsm: memory leak in uplink error path

commit 88ed2a60610974443335c924d7cb8e5dcf9dbdc1 upstream.

Uplink (TX) network data will go through gsm_dlci_data_output_framed
there is a bug where if memory allocation fails, the skb which
has already been pulled off the list will be lost.

In addition TX skbs were being processed in LIFO order

Fixed the memory leak, and changed to FIFO order processing

Signed-off-by: Russ Gorby <russ.gorby@intel.com>
Tested-by: Kappel, LaurentX <laurentx.kappel@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_gsm.c