From eb0b7518954b8cdc7f04d45d9aa197c13a9ca583 Mon Sep 17 00:00:00 2001 From: Murray Cumming Date: Tue, 4 Dec 2012 23:22:53 +0100 Subject: [PATCH] DetailsActivity: Check for authentication here too. * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Call checkAuthentication to deal with a TODO here. --- ChangeLog | 7 +++++++ src/main/java/org/glom/web/client/activity/DetailsActivity.java | 2 +- .../java/org/glom/web/client/activity/TableSelectionActivity.java | 4 ++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 0bfcf4d..5633209 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2012-12-04 Murray Cumming + DetailsActivity: Check for authentication here too. + + * src/main/java/org/glom/web/client/activity/DetailsActivity.java: + Call checkAuthentication to deal with a TODO here. + +2012-12-04 Murray Cumming + Authentication: Reduce some copy/paste by moving code to base class. * src/main/java/org/glom/web/client/activity/HasTableActivity.java: diff --git a/src/main/java/org/glom/web/client/activity/DetailsActivity.java b/src/main/java/org/glom/web/client/activity/DetailsActivity.java index c8d5371..1d4c93d 100644 --- a/src/main/java/org/glom/web/client/activity/DetailsActivity.java +++ b/src/main/java/org/glom/web/client/activity/DetailsActivity.java @@ -134,7 +134,7 @@ public class DetailsActivity extends HasTableActivity { // register this class as the presenter detailsView.setPresenter(this); - // TODO here's where we should check for database authentication - see ListActivity.start() for how to do this + checkAuthentication(eventBus); // set the change handler for the table selection widget // TODO: Why don't we just use goTo() in the TableSelectionActivity that fired this event? diff --git a/src/main/java/org/glom/web/client/activity/TableSelectionActivity.java b/src/main/java/org/glom/web/client/activity/TableSelectionActivity.java index 4e3a3c0..0ab773c 100644 --- a/src/main/java/org/glom/web/client/activity/TableSelectionActivity.java +++ b/src/main/java/org/glom/web/client/activity/TableSelectionActivity.java @@ -77,6 +77,10 @@ public class TableSelectionActivity extends AbstractActivity implements View.Pre final TableSelectionView tableSelectionView = clientFactory.getTableSelectionView(); tableSelectionView.setPresenter(this); + + // TODO: Check for authentication here? + // Or just let it fail to retrieve the list of tables, + // and let the other activity on the page ask for authentication. // For table changes with the tableSelector: final HasChangeHandlers tableSelector = tableSelectionView.getTableSelector(); -- 2.1.4