1 2012-11-14 Murray Cumming <murrayc@murrayc.com>
3 Document: Add and use public constants for layout names.
5 * src/main/java/org/glom/web/server/libglom/Document.java:
6 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
7 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
8 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
9 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
10 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
11 them here instead of hard-coded the strings repeatedly.
13 2012-11-13 Murray Cumming <murrayc@murrayc.com>
15 Document: Load static text and image items too.
17 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
18 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
19 New LayoutItem classes to represent these layout items.
20 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
21 main text of a LayoutItemText.
22 * src/main/java/org/glom/web/server/libglom/Document.java:
23 load_after_layout_group(): Handle the node types and instantiate the
25 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
26 Add testLayoutItemText() to check that the text is loaded properly.
28 2012-11-13 Murray Cumming <murrayc@murrayc.com>
30 Do not use client.GWT for shared code.
32 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
33 Import shared.GWT instead of client.GWT, which seems to be appropriate.
35 2012-11-12 Murray Cumming <murrayc@murrayc.com>
37 Use image data when recreating databases for testing.
39 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
40 for use locally (not acrosss the network) when recreating databases
42 getValue(): Use it here instead of getImageDataUrl(), noting that
43 this method is only for use when recreating databases.
44 * src/main/java/org/glom/web/server/libglom/Document.java:
45 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
47 2012-11-09 Murray Cumming <murrayc@murrayc.com>
49 OnlineGlomImages: Detect the mime-type (content type).
51 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
52 doGet(): Instead of hard-coding image/png.
54 2012-11-09 Murray Cumming <murrayc@murrayc.com>
56 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
59 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
60 Java Compiler and Java Build path settings in the UI.
62 2012-11-09 Murray Cumming <murrayc@murrayc.com>
64 Use the latest (now stable) version of GWT.
66 * pom.xml: And the latest version of the gwt-maven-plugin.
68 2012-11-08 Murray Cumming <murrayc@murrayc.com>
70 Added an Indonesian translation.
72 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
73 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
74 This is from the new translation in Glom.
76 2012-07-23 Murray Cumming <murrayc@murrayc.com>
80 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
82 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
84 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
85 for serving image data.
86 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
88 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
89 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
90 setData(): For image field types, add a GWT Image widget,
91 with the URL that was set in the DataItem.
93 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
94 * src/main/java/org/glom/web/server/database/DBAccess.java:
95 convertResultSetToDTO(): Set the URL for image data, so the client browser
96 can retrieve the image from our new servlet. This uses UriBuilder.
97 Move getPrimaryKeyField to:
98 * src/main/java/org/glom/web/server/libglom/Document.java:
99 Added getTablePrimaryKeyField().
101 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
102 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
103 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
106 2012-07-22 Murray Cumming <murrayc@murrayc.com>
110 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
111 * src/main/java/org/glom/web/client/OnlineGlomService.java:
112 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
113 to gwtGlom, which is more appropriate.
114 This servlet name does not seem to be visible to the client side anyway.
116 2012-07-22 Murray Cumming <murrayc@murrayc.com>
118 Tests: Make the imports of assert*() consistent.
120 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
121 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
122 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
123 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
124 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
125 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
126 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
127 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
128 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
129 * src/test/java/org/glom/web/shared/DataItemTest.java:
131 import static org.junit.Assert.*;
132 which seems fairly common.
136 2012-07-21 Murray Cumming <murrayc@murrayc.com>
138 tests: Move a test that needs a database connection.
140 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
141 Move testGetListViewLayoutGroup() to
142 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
143 because it needs a database connection.
145 2012-07-21 Murray Cumming <murrayc@murrayc.com>
147 tests: Use @BeforeClass on tearDown().
149 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
150 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
151 This avoids leaking a postgres process in SelfHostExampleTest.
153 2012-07-21 Murray Cumming <murrayc@murrayc.com>
155 tests: Test translations more.
157 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
158 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
159 Test titles in the non-default locale.
161 2012-07-21 Murray Cumming <murrayc@murrayc.com>
163 tests: Add SelfHostConfiguredDocumentTest
165 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
166 username and password, for use by ConfiguredDocument.
167 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
168 This tests some of the ConfiguredDocument API that requires a database connection.
170 2012-07-21 Murray Cumming <murrayc@murrayc.com>
172 Document: Load title translations and test them.
174 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
175 of titles. I am surprised that we do not do this yet.
176 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
177 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
178 Test translations more.
180 2012-07-20 Murray Cumming <murrayc@murrayc.com>
184 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
185 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
186 Set the timeout here too.
188 2012-07-20 Murray Cumming <murrayc@murrayc.com>
190 tests: ConfiguredDocumentTest: Make this pass.
192 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
193 Disable tests that need a database connection.
195 2012-07-20 Murray Cumming <murrayc@murrayc.com>
197 Use Java 1.7 instead of Java 1.6.
199 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
200 to do this twice, at least for Eclipse.
201 This seems OK because it is the current version.
203 2012-07-20 Murray Cumming <murrayc@murrayc.com>
207 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
208 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
209 Avoid using a null Connection.
211 2012-07-20 Murray Cumming <murrayc@murrayc.com>
213 tests: Add a ConfiguredDocument test.
215 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
218 2012-07-20 Murray Cumming <murrayc@murrayc.com>
220 LayoutItemFIeld: getName(): Use the Field if it is set.
222 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
223 getName(): If the full field details have been set, return its name, so that
224 callers do not need to set the name separately.
225 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
226 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
227 so we can count the rows.
229 2012-07-20 Murray Cumming <murrayc@murrayc.com>
231 tests: SelfHoster: Test SqlUtils too.
233 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
234 Retrieve some data and check it too, as in the regular Glom
235 test_selfhosting_new_from_example.cc test.
236 * src/test/java/org/glom/web/server/SelfHoster.java:
237 createConnection(): Make this public.
239 2012-07-20 Murray Cumming <murrayc@murrayc.com>
241 tests: SelfHoster: createConnection(): Do not warn about expected failures.
243 Let the caller say if the connection is expected to fail, to avoid
244 irrelevant error output.
246 2012-07-20 Murray Cumming <murrayc@murrayc.com>
248 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
250 * src/test/java/org/glom/web/server/SelfHoster.java:
251 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
252 due to the inevitable need to retry the connection while the database server
255 2012-07-20 Murray Cumming <murrayc@murray.com>
257 tests: SelfHoster: createConnection(): Set a timeout.
259 * src/test/java/org/glom/web/server/SelfHoster.java:
260 createConnection(): Use setLoginTimeout() because it otherwise seems to take
261 ages to actually return when it fails.
263 2012-07-20 Murray Cumming <murrayc@murrayc.com>
265 tests: SelfHoster: selfHost(): Close the test connection.
267 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
268 When we check that the connection works, close the connection. This seems
269 to not be closed automatically otherwise.
271 2012-07-20 Murray Cumming <murrayc@murrayc.com>
273 Use slf4j-simple to see JDBC errors.
275 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
277 2012-07-19 Murray Cumming <murrayc@murrayc.com>
279 SelfHoster.discoverFirstFreePort(): Close the socket.
281 * src/test/java/org/glom/web/server/SelfHoster.java:
282 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
284 2012-07-19 Murray Cumming <murrayc@murrayc.com>
286 Avoid another code warning in Eclipse Juno.
288 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
289 Do instanceof checks on the FileUtils.listFiles() result and its
292 2012-07-13 Murray Cumming <murrayc@murrayc.com>
294 Avoid some code warnings in Eclipse Juno
296 * src/main/java/org/glom/web/server/libglom/Document.java:
297 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
298 * src/test/java/org/glom/web/server/SelfHoster.java
299 createTextFile(): Make sure that the FileOutputStream is closed.
301 2012-06-22 Murray Cumming <murrayc@murrayc.com>
303 Added OnlineGlomPropertiesTest.
305 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
306 Make sure we never return a null string.
307 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
308 Added tests of the OnlineGlomProperties API, using our sample file.
310 2012-06-20 Murray Cumming <murrayc@murrayc.com>
312 Make OnlineGlomProperties be a normal class.
314 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
315 Move OnlineGlomProperties into its own file to be a regular class:
316 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
317 This makes testing simpler.
319 2012-06-15 Murray Cumming <murrayc@murrayc.com>
321 OnlineGlomServiceImpl.init(): Move some code into a new method.
323 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
324 Create addDocument().
326 2012-06-15 Murray Cumming <murrayc@murrayc.com>
328 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
330 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
331 OnlineGlomProperties.getKey(): Make this more robust by moving the
332 check for *.*.filename to here.
334 2012-06-15 Murray Cumming <murrayc@murrayc.com>
336 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
338 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
339 init(): Move knowledge of the config file format into the
340 OnlineGlomProperties inner class.
342 2012-06-15 Murray Cumming <murrayc@murrayc.com>
344 SelfHostExampleTest: Make sure we cleanup on failure.
346 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
347 the use of cleanup() to a tearDown() JUnit method.
351 2012-06-12 Murray Cumming <murrayc@murrayc.com>
353 ConfiguredDocument: Add a primary key to portals at least once.
355 * src/main/java/org/glom/web/server/ConfiguredDocument.java
356 updatePortalsExtras): Fix a typo so that we add the primary key
357 column at least once.
358 This is a fix for the previous commit:
359 ConfiguredDocument: Do not add a primary key to portals each time.
361 2012-06-08 Murray Cumming <murrayc@murrayc.com>
363 SelfHoster: Avoid some compiler warnings.
365 * src/test/java/org/glom/web/server/SelfHoster.java
366 executeCommandLineAndWait():
367 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
368 the now-unused streams for stdout and stderr from the command Processes.
369 These are not used because readln() hangs while waiting for a new line,
370 where there may be no next line. The commented out code is still there
371 to help us figure out how to do this properly.
373 2012-06-08 Murray Cumming <murrayc@murrayc.com>
375 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
377 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
378 Make this actually test the cloning again, though it is not very useful
379 now that we do not use the part that had a problem with cloning before.
381 2012-06-08 Murray Cumming <murrayc@murrayc.com>
383 SelfHoster: Keep trying pg_ctl after starting postgres.
385 * src/test/java/org/glom/web/server/SelfHoster.java
386 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
387 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
388 regular Glom. This seems mad but it seems to work because the first
389 command would fail if pg_ctl would eventually fail.
391 2012-06-08 Murray Cumming <murrayc@murrayc.com>
393 SelfHoster: Wait until the server is really ready.
395 * src/test/java/org/glom/web/server/SelfHoster.java
396 selfHost(): Attempt the connection after starting the server, retrying
397 a few times if necessary, so that the server is really ready already when
398 we return from this method.
399 The regular Glom code does this too because pg_ctl reports success too soon.
401 2012-06-08 Murray Cumming <murrayc@murrayc.com>
403 ConfiguredDocument: Do not add a primary key to portals each time.
405 * src/main/java/org/glom/web/server/ConfiguredDocument.java
406 updatePortalsExtras(): Only add an extra primary key field if there is
407 none, to avoid adding one each time we retrieve the details layout from the
409 This should fix bug #676986 (Ben Konrath)
411 2012-05-25 Murray Cumming <murrayc@murrayc.com>
413 Document.load(): Support version 7 documents.
415 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
416 database_title attribute if the title attribute is not there.
419 2012-05-24 Ben Konrath <ben@bagu.org>
421 Add configuration for auto-generating mvn:i18n from with Eclipse.
423 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
425 2012-05-24 Murray Cumming <murrayc@murrayc.com>
427 Update translations, adding French.
429 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
430 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
431 Add a French translation, using the translation from Glom.
433 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
434 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
435 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
436 Update these based on the translations from Glom.
438 2012-05-24 Murray Cumming <murrayc@murrayc.com>
440 SelfHoster: Add some debug println messages to help when things fail.
442 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
443 System.out.println() lines.
445 2012-05-23 Murray Cumming <murrayc@murrayc.com>
447 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
449 * src/test/java/org/glom/web/server/SelfHoster.java:
450 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
451 instance) instead of just /usr/bin (as on Fedora). Check the result when
454 2012-05-23 Murray Cumming <murrayc@murrayc.com>
456 Remove LayoutItemPortal.get/setNavigationTable().
458 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
459 Remove get/setNavigationTable(), which is only a cache, because it is not
460 used, and does not need to be used, because that decision should be made on
462 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
463 updatePortalsExtras():
464 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
465 getNavigationRecord():
466 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
469 2012-05-21 Murray Cumming <murrayc@murrayc.com>
471 Initial self-hosting for tests.
473 * pom.xml: Change the scope for log4j, to hopefully make it
474 available to the test code which uses it indirectly via jOOQ.
475 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
476 self-hosting, though we only use it for testing.
478 * src/main/java/org/glom/web/server/libglom/Document.java:
479 example rows: Use a map instead of a list for each row of values,
480 so we know what field they are for, instead of relying on the sequence
481 being correct. This is not very efficient, but it does not really need
483 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
484 testReadTableExampleRows(): Adapted.
486 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
487 that returns an Object, for generic use. Note that Object seems to be
488 the implicit base even of double.
489 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
490 for use in CREATE TABLE SQL queries.
491 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
492 to do self-hosting of PostgreSQL databases via its command-line
493 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
494 backends/postgres_self.cc. This is incomplete - it needs more
495 warnings about failures and it needs to clean up properly when things
497 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
498 test of this new class.
500 2012-05-21 Murray Cumming <murrayc@murrayc.com>
502 Document: loading example data: Handle exceptions.
504 * src/main/java/org/glom/web/server/libglom/Document.java:
505 DateFormat.parse() and Double.valueOf() can throw exceptions, though
506 Eclipse did not warn about that.
508 2012-05-20 Murray Cumming <murrayc@murrayc.com>
510 Document: load(), save(): Handle the example rows.
512 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
514 * src/main/java/org/glom/web/server/libglom/Document.java:
515 load(), save(): Load and save the example rows, though the date, time
516 and image types are not handled properly yet.
517 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
518 Add testReadTableExampleRows() just to check that something is read.
520 2012-05-20 Murray Cumming <murrayc@murrayc.com>
522 Document: Add save().
524 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
525 Added getTranslationsMap() for use while saving.
526 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
527 Adedd getUseDefaultFormatting() for use while saving.
528 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
529 and several private methods that it uses.
531 This will be useful while testing via self-hosting.
532 It is not complete, but should be complete enough for testing.
534 2012-05-17 Murray Cumming <murrayc@murrayc.com>
536 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
538 * src/main/java/org/glom/web/client/OnlineGlomService.java
539 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
540 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
541 Remove getSortedListViewData() and getSortedRelatedListData(), adding
542 the sort column index and ascending bool to the regular method.
543 Instead, a sort column index of -1 now means no sort.
544 This is less explicit, but it's fairly simple, reduces the amount of
545 code, and makes the OnlineGlomService API slightly smaller.
546 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
547 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
549 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
550 getListViewData(), getRelatedListData():
551 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
552 getListViewData(), getRelatedListData():
553 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
555 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
557 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
562 2012-05-16 Murray Cumming <murrayc@murrayc.com>
564 Use translations for top-level groups too.
566 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
567 updateTitlesForLocale(): Use the translation for the group
568 as well as for child items.
572 Just recompiled to fix a problem in the released .tar.gz file.
576 2012-05-15 Murray Cumming <murrayc@murrayc.com>
578 Corrections to navigation to related records.
580 * src/main/java/org/glom/web/client/OnlineGlomService.java:
581 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
582 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
583 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
584 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
585 relationship name, because the relationship name is not necessarily unique
587 TOOD: This is inefficient, because it passes the whole list of
588 child field items back to the server, but it is more correct, and happens
589 to fix a bug with the primary key being lost after a few navigations.
590 There is probably a chance to make this more efficient anyway in some
593 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
594 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
595 * src/main/java/org/glom/web/server/ConfiguredDocument.java
596 * src/main/java/org/glom/web/server/database/DBAccess.java
597 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
598 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
601 2012-05-15 Murray Cumming <murrayc@murrayc.com>
603 Fix the use of translations.
605 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
606 Add updateTitlesForLocale().
607 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
608 Call it to discard unwanted translations and to make getTitle() return
609 the wanted translation wihout the need for the client code to specify a locale.
610 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
611 getTitle(): Fallback to the original title, as libglom does.
613 2012-05-15 Murray Cumming <murrayc@murrayc.com>
615 Document: Correctly report the number of available translation locales.
617 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
618 the available locale IDs list.
619 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
620 testLocales: Test this.
622 2012-05-15 Murray Cumming <murrayc@murrayc.com>
624 SqlUtils: Use camelCase.
626 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
627 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
628 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
629 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
630 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
631 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
633 2012-05-15 Murray Cumming <murrayc@murrayc.com>
635 Use jOOQ's tableByName() and fieldByName.
637 * pom.xml: Use jOOQ 2.3.1 to get the new API.
638 * src/main/java/org/glom/web/server/SqlUtils.java:
639 build_sql_select_step_with_where_clause(), .createField(),
640 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
641 so we can get correct quoting and escaping. Thanks to Lukas Eder for
642 adding this, and other things, to jOOQ.
644 2012-05-15 Murray Cumming <murrayc@murrayc.com>
646 SqlUtils: Remove the Connection parameters.
648 * src/main/java/org/glom/web/server/SqlUtils.java:
649 build_sql_select_with_key(), build_sql_select_with_where_clause(),
650 createSelect(), build_sql_select_step_with_where_clause(),
651 build_sql_count_select_with_where_clause(),
652 build_sql_select_count_rows(): Remove the Connection parameter because
653 jOOQ does not actually need a connectionwhen it is just used to build
655 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
657 * src/main/java/org/glom/web/server/ReportGenerator.java:
659 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
661 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
662 Constructor, getListData(), getResultSizeOfSQLQuery():
663 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
664 getSelectQuery(), getCountQuery():
665 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
666 getSelectQuery(), getCountQuery():
667 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
668 getNavigationRecord(): Adapted.
670 2012-05-14 Murray Cumming <murrayc@murrayc.com>
674 * src/main/java/org/glom/web/server/SqlUtils.java:
675 get_find_where_clause_quick(): Use a comparison of
676 lowercase values, instead of a simple equals. Regular Glom
677 uses the PostgreSQL ILIKE operator but jOOQ does not
678 support that just yet, though it will soon.
680 2012-05-14 Murray Cumming <murrayc@murrayc.com>
682 TableToViewDetails: Use a real serialization ID.
684 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
685 Though this does not fix the serialization problem.
687 2012-05-12 Murray Cumming <murrayc@murrayc.com>
689 Added LayoutItemPortalDeepCloneTest.
691 2012-05-11 Murray Cumming <murrayc@murrayc.com>
693 Make navigation work again.
695 * src/main/java/org/glom/web/server/libglom/Document.java:
696 Add getLayoutItemFieldShouldHaveNavigation().
697 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
698 Replace get/setAddNavigation() with the partly-existing
699 get/setNavigationTableName(), with an empty string being no navigation,
700 because this is simpler. Use the new
701 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
703 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
704 Add updateFieldsExtras() and call setNavigationTableName in it.
705 getDetailsLayoutGroup(),
706 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
707 createLayout(): Adapted.
708 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
709 Constructor: Adapted.
711 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
712 Replace get/setAddNavigation() with get/setNavigation(), returning a
713 TableToViewDetails class with both the table name and UsesRelationship,
714 because both are need. The previous code used java-libglom's output
715 variable (strangely, via sharedptr) to return both, but we cannot really
717 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
718 getNavigationRecord(): Adapt. However, we cannot actually use the cache
719 here because it somehow gets set to null during deepCopy(). I must test this.
720 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
721 testGetSuitableTableToViewDetails(): Adapted.
723 TODO: Find out why deepClone() is not quite working.
725 2012-05-11 Murray Cumming <murrayc@murrayc.com>
727 DBAccess: Simplify the retrievel of full field details.
729 * src/main/java/org/glom/web/server/database/DBAccess.java
730 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
731 because the Document loading should have done this.
733 2012-05-11 Murray Cumming <murrayc@murrayc.com>
735 Document: Correct loading of doubly-related layout fields.
737 * src/main/java/org/glom/web/server/libglom/Document.java:
738 loadUsesRelationship(): Actually set the related relationship, instead
739 of only setting it if it's not found.
741 2012-05-09 Murray Cumming <murrayc@murrayc.com>
743 Replace all appearances of Colour with color.
745 Because US English is dominant.
747 2012-05-09 Murray Cumming <murrayc@murrayc.com>
749 Use colors in HTML format, solving a warning about an unused function.
751 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
752 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
753 Add *asHTMLColor() versions of methods.
754 TODO: However, we should create and cache the results on the server.
755 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
756 * src/main/java/org/glom/web/client/ui/list/ListTable.java
757 * src/main/java/org/glom/web/server/ConfiguredDocument.java
758 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
759 Use the asHTMLcolor() versions.
761 2012-05-09 Murray Cumming <murrayc@murrayc.com>
763 ListViewTable: Constructor: Take the table name as a parameter.
765 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
766 Constructor: Take the tableName, and set the member variable, because
768 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
769 setCellTable(): Pass the table name.
770 This makes navigation to non-default tables work again. I don't know
771 why it worked before in the master branch.
773 2012-05-07 Murray Cumming <murrayc@murrayc.com>
775 ConfiguredDocument: Restore correct addition of hidden primary key items.
777 * src/main/java/org/glom/web/client/ui/list/ListTable.java
778 (ListTable.createCellTable): Uncomment out the check for the hidden
780 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
781 add primary key items for top-level lists and portals, as before,
782 instead of adding them to each group.
783 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
784 Actually implement the extra methods such as setHiddenPrimaryKey() and
785 comment that these are used only for top-level list groups and in portals.
786 This strangeness suggests even more that this should not be squeezed
787 into the LayoutGroup class.
789 2012-05-07 Murray Cumming <murrayc@murrayc.com>
791 Fix Formatting loading.
793 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
794 getFormattingUsed(): Remove the duplicate Formatting member variable
795 in favour of the one from the base class.
796 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
797 Initialize a new Formatting instead of using null by default, so we
798 have some defaults, instead of having to initialize one later just to
799 get the same defaults. This also makes loading of formatting from the
800 document work, because that expected a non-null.
802 2012-05-07 Murray Cumming <murrayc@murrayc.com>
804 RelatedListTable: Make sure that the tableName is set.
806 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
807 Constructor: Take the tableName so it is available later. Otherwise,
808 the server assumes that we mean the default table and cannot find the
810 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
811 setData(): Pass the tableName to the RelatedListTable constructor.
813 2012-05-07 Murray Cumming <murrayc@murrayc.com>
817 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
818 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
819 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
821 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
823 * src/main/java/org/glom/web/server/database/DBAccess.java:
824 convertResultSetToDTO(), getPortal():
825 * src/main/java/org/glom/web/server/database/ListDBAccess.java
827 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
828 Add checks for null objects and out of range access, with log messages to
829 give hints so we can fix these properly.
831 2012-05-07 Murray Cumming <murrayc@murrayc.com>
833 Portals: some corrections.
835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
837 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
838 constructor: Use getRelationshipNameUsed() instead of getName(), because
839 that is what is meant.
840 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
841 getFromField(): Fix a typo, to get the field name, not the table name.
842 * src/main/java/org/glom/web/server/database/DBAccess.java:
843 getPortal(): Fix a typo that stopped this from working.
845 2012-05-07 Murray Cumming <murrayc@murrayc.com>
847 LayoutItemPortal: Also override getTitleOriginal().
849 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
850 This lets the base getTitle() with no parameters work.
851 TODO: Test this properly.
853 2012-05-06 Murray Cumming <murrayc@murrayc.com>
855 LayoutItemPortal: getTitle*(): Use the relationship title.
857 2012-05-06 Murray Cumming <murrayc@murrayc.com>
859 LayoutItemField: Fix loading of custom titles.
861 * src/main/java/org/glom/web/server/libglom/Document.java
862 loadDataLayoutItemField(): The title, if any, instead of the field
863 title, is stored in a title_custom node. Load it from there.
864 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
866 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
867 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
868 getTitle*() overrides.
869 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
872 2012-05-06 Murray Cumming <murrayc@murrayc.com>
874 LayoutItemField: Fall back to field titles, so some are really shown.
876 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
877 Override getTitleOriginal() and getTitle(), as in java-libglom.
878 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
881 2012-05-06 Murray Cumming <murrayc@murrayc.com>
883 Correct use of setExpectedResultSize().
885 * src/main/java/org/glom/web/server/ConfiguredDocument.java
886 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
887 Use setExpectedResultSize only on top-level groups (for instance, the
888 list layout) or on child portals (in details views).
889 Use the correct table name for portals to avoid SQL errors.
890 Update the expected counts when returning cached layouts.
892 2012-05-06 Murray Cumming <murrayc@murrayc.com>
894 Document: Interpret no group column count as 1.
896 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
897 default, though we now check for this in the UI code anyway.
899 2012-05-06 Murray Cumming <murrayc@murrayc.com>
903 2012-05-06 Murray Cumming <murrayc@murrayc.com>
905 Translatable: Use Hashmap instead of Treemap because GWT supports it.
907 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
908 The use of Treemap lead to this error from async methods, with no
910 "The response could not be deserialized"
912 2012-05-06 Murray Cumming <murrayc@murrayc.com>
914 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
916 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
917 when using the Google -> GWT Compile, or
918 g toolbar button -> GWT Compile Project... feature in Eclipse.
920 2012-05-06 Murray Cumming <murrayc@murrayc.com>
922 ListTable.addColumn(): Protect against a null Formatting.
924 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
925 Create a default Formatting if it is null, because that is the simplest
928 2012-05-06 Murray Cumming <murrayc@murrayc.com>
930 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
932 * src/main/java/org/glom/web/server/ConfiguredDocument.java
933 updateLayoutGroup(): Check that the field is not null.
935 2012-05-06 Murray Cumming <murrayc@murrayc.com>
937 ListViewImpl: Protected against a bad cast error.
939 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
940 onEnterKeyDown(): Do not cast without an instanceof check.
942 2012-05-06 Murray Cumming <murrayc@murrayc.com>
944 ListTable: Protect against an out of range error.
946 * src/main/java/org/glom/web/client/ui/list/ListTable.java
947 createCellTable(): This is unlikely, but can happen while debugging.
949 2012-05-06 Murray Cumming <murrayc@murrayc.com>
951 AsyncMessage onFailure() callbacks: Log the exception message.
953 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
954 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
955 * src/main/java/org/glom/web/client/activity/ListActivity.java:
956 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
957 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
958 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
959 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
960 These are useful clues when something is wrong.
962 2012-05-06 Murray Cumming <murrayc@murrayc.com>
964 ConfiguredDocument: Avoid a null dereference.
966 * src/main/java/org/glom/web/server/ConfiguredDocument.java
967 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
968 details maps are created.
970 2012-05-06 Murray Cumming <murrayc@murrayc.com>
972 Document: Correct the port number parsing.
974 * src/main/java/org/glom/web/server/libglom/Document.java:
975 This lets us actually connect to the database and show the document.
977 2012-05-05 Murray Cumming <murrayc@murrayc.com>
981 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
982 user-interaction, asking us to load a temporary URL in a browser.s
983 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
984 which is apparently necessary for testing the service. See the comment.
985 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
986 Show the exception, if any. This is how I saw the 404 in the HTML in
989 2012-05-05 Murray Cumming <murrayc@murrayc.com>
991 DocumentTest: Move the .glom files into the resources directory.
993 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
994 URI via getResource().
996 2012-05-05 Murray Cumming <murrayc@murrayc.com>
998 Document: Remove the FieldIdentifies inner class.
1000 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1001 use the Relationship (though the same function in libglom is maybe
1002 used in other ways) and so this removes a compiler warning.
1004 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1006 Document.load() Remove the error code parameter.
1008 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1009 Remove the parameter. We do not set it yet and it could never have
1010 worked as an output parameter (though maybe it did in java-libglom).
1011 We could use an exception if we really want the failure reason.
1012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1014 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1015 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1017 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1019 Make some inner classes static.
1021 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1023 * src/main/java/org/glom/web/server/ReportGenerator.java
1024 * src/main/java/org/glom/web/server/libglom/Document.java
1025 Make all inner classes static that can be static.
1027 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1029 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1031 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1032 init(): We do not use java-libglom any more.
1034 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1036 Remove mentions of java-libglom.
1038 * README: Remove mention of java-libglom, because it no longer needed.
1039 * utils/build-onlineglom-war.sh:
1040 * utils/check-and-recover-tomcat.py:
1041 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1042 useful. Building is now far easier, with no need for jhbuild.
1044 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1046 Fix the build (mvn package)
1048 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1049 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1050 Otherwise the GWT Java->Javascript compilation fails with just this
1051 error, during mvn package or when attempting to view in a browser,
1052 in the GWT developer mode in Eclipse.
1054 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1055 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1056 [INFO] Compiling module org.glom.web.OnlineGlom
1057 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1058 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1059 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1060 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1061 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1062 [INFO] [ERROR] Cannot proceed due to previous errors
1064 It has taken me 2 days to find out what was causing that. After reducing
1065 the code, the compiler eventually showed me the full error message.
1067 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1069 ConfiguredDocument: Cache the cloned and stripped layouts.
1071 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1072 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1073 layout in a map, so we can retrieve it again without rebuilding it.
1075 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1077 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1079 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1081 libglom classes: Implement some auto-generated emthods.
1083 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1085 Add GwtTestOnlineGlomService.
1087 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1088 However, this (and the other GwtTest*) does not seem to run during
1091 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1093 Remove use of unsupported features from client code.
1095 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1096 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1097 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1098 Use our client version of StringUtils instead of the apache commons one.
1100 However, the GWT Javascript compliation still fails.
1102 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1104 Add a Field class and implement some loading of it in Document.
1106 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1108 Initial Document loading implementation, instead of libglom.
1110 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1111 and Translatable classes, and adapt the rest of the code to use them.
1112 However, this is still missing Layout and Field classes and loading.
1114 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1116 Use of jOOQ: Move Field creation into a utility method.
1118 * src/main/java/org/glom/web/server/SqlUtils.java:
1119 This lets us improve it more easily.
1121 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1123 Use of jOOQ: Improve the code to COUNT a sub-select.
1125 * src/main/java/org/glom/web/server/SqlUtils.java:
1126 Move initial query creation into
1127 build_sql_select_step_with_where_clause().
1128 build_sql_select_count_rows(): Use the jOOQ API instead of
1129 concatentating text, because a jOOQ Select*Step is a TableLike,
1130 which is what from() takes.
1132 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1134 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1136 * pom.xml: Depend on jooq.
1137 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1138 methods with jOOQ, based on the C++ implementations in libglom,
1139 with some changes to the logic required by jooQ.
1140 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1142 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1143 * src/main/java/org/glom/web/server/ReportGenerator.java:
1144 * src/main/java/org/glom/web/server/SqlUtils.java:
1145 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1146 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1147 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1148 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1149 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1150 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1151 because jOOQ needs that, though it seems unnecessary.
1153 This is not quite finished. Ideally jOOQ would help us to build
1154 table_name.field_name names, quoting and escaping them properly.
1155 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1157 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1159 Move use of Glom.build_sql*() into a new SqlUtils class.
1161 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1162 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1163 but this will make it easier to start using something other than
1164 libglom or SqlBuilder.
1166 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1168 Update the project URL.
1170 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1172 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1174 Main layout: Use a FlowTable instead of absolute positioning.
1176 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1177 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1178 child panels/widgets must have an absolute position. But that is annoying, so
1179 this adds a FlowTable and puts the child panels in there.
1181 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1183 GwtTestOnlineGlom: Comment out unused code.
1185 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1186 Eclipse has started to say that some code is unused.
1188 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1190 Update to the latest versions of dependencies.
1192 * pom.xml: Update version numbers of dependencies to the latest
1194 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1195 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1196 * src/main/java/org/glom/web/server/ReportGenerator.java:
1197 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1198 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1199 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1201 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1202 Modify the imports where necessary.
1204 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1206 Style: Remove overflow:hidden from searchbox
1208 * src/main/webapp/style.css: Because this pushes the Back To Link
1209 label/link on to the next row, which is then hidden due to the
1210 hard-coded (in ems) height.
1212 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1214 Remove some duplicate code.
1216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1217 getDocumentInfo(): This must have been duplicated during the merge from the
1222 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1224 Reports: Localize the waiting for report message.
1226 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1227 start(): Get the message from the contants.
1228 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1229 Add the string here.
1230 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1231 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1232 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1233 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1234 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1235 Update these files with the English text for newer strings for now.
1237 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1239 Reports: Show a message while waiting for the report.
1241 * src/main/java/org/glom/web/client/ui/ReportView.java
1242 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1243 Add setWaitingText(), to show a message saying that we are
1244 waiting for the report to be ready.
1245 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1246 start(): Call setWaitingText() before calling the async
1249 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1251 ReportGenerator: Specify date and time formats.
1253 * src/main/java/org/glom/web/server/ReportGenerator.java:
1254 createFieldValueElement(): Use the default (and localized)
1255 short formats, though we still need a way to show 4-digit
1256 years without providing the format for every locale.
1257 * src/main/java/org/glom/web/server/database/DBAccess.java:
1258 convertResultSetToDTO(): Use the short formats here too.
1260 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1262 ReportGenerator: Use the correct numeric formatting.
1264 * src/main/java/org/glom/web/server/ReportGenerator.java
1265 createFieldExpression(), createFieldValueElement(): Take the
1266 whole LayoutItem_Field instead of just the field name, so
1267 we have access to the formatting.
1268 createFieldValueElement(): Use JRTextField.setPattern() to
1269 specify the numeric formatting, with the help of a
1270 regular DecimalFormat.
1272 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1274 ReportGenerator: Avoid showing null for group by titles.
1276 * src/main/java/org/glom/web/server/ReportGenerator.java
1277 generateReport(): Use setBlankWhenNull() on the field title
1278 style too, because this is used for values in group by
1281 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1283 ReportGenerator: Add a colon to titles in vertical groups.
1285 * src/main/java/org/glom/web/server/ReportGenerator.java
1286 addFieldToDetailBandVertical(): Pass true for the withColon
1289 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1291 ReportGenerator: Simplify the code by using Position more.
1293 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1295 Reports: Support vertical groups, roughly.
1297 * src/main/java/org/glom/web/server/ReportGenerator.java:
1298 addToReport(): Rename to addGroupToReport() and, if necessary,
1299 call the new addVerticalGroupToReport() method.
1300 createFieldValueElement(): Let the caller specify the Y position
1303 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1305 Reports: Allow a second report to be shown.
1307 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1308 clear(): Do not remove the HTML widget, which broke the whole layout.
1310 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1312 Locales drop-down: Show that we use English by default.
1314 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1315 fillView(): When we use English, just because that is the default, when
1316 no locale is specified, show that in the Locales drop-down instead of
1317 just showing the first item.
1319 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1321 Unselect the Report/Locale/Table combo item when appropriate.
1323 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1324 setPlace(): clear reportName if this is not a ReportPlace.
1325 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1326 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1327 When the provided name is empty, unselect all items, so that none are
1328 indicated. This uses a for loop because I cannot find a single method
1331 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1333 Report: Give the user a way to get back to the list.
1335 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1336 start(), setPlace(): Show the Back To List link on reports, and also
1337 interpret selecting the empty report item as back to list.
1339 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1341 Really show the selected Report name.
1343 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1344 setPlace(): Store the reportName here, if it is that kind of Place.
1345 fillView(): Set the selected Report after filling the list of reports.
1346 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1347 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1348 null Strings, though we need some way to unselect all ListBox items
1351 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1353 ReportGenerator: Try to avoid some problems.
1355 * src/main/java/org/glom/web/server/ReportGenerator.java
1356 addField(): Try to avoid duplicates, and avoid using a null
1359 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1361 Reports: Use quickFind.
1363 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1364 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1365 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1366 getReportHTML(): Add a quickFind parameter.
1367 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1368 start(): Pass the quickFind parameter.
1369 * src/main/java/org/glom/web/server/ReportGenerator.java
1370 generateReport(): Take a quickFind parameter.
1372 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1374 ReportPlace: Actually use the report name.
1376 * src/main/java/org/glom/web/client/place/ReportPlace.java
1377 getPlace(): Do not assign the report name to the quickfind.
1379 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1381 Show java.library.path when complaining.
1383 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1384 init(): When telling us to check java.library.path, show the
1387 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1389 ReportGenerator: Do not show nulls.
1391 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1393 ReportGenerator: Make the title font larger.
1395 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1397 ReportGenerator: Put field titles inside groups, if there are groups.
1399 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1401 ReportGenerator: Take the Report itself instead of the name and group.
1403 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1404 Remove getReportLayoutGroup().
1405 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1406 getReportHTML(): Pass the report instead
1407 of its name and layout group.
1408 * src/main/java/org/glom/web/server/ReportGenerator.java
1409 generateReport(): Use the report object to use the title
1410 instead of the name.
1412 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1414 ReportGenerator: Remove designBand parameters.
1416 * src/main/java/org/glom/web/server/ReportGenerator.java:
1417 Make designBand a class member instead of passing it to all
1420 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1422 ReportGenerator: Add lines, a bit like in the desktop version.
1424 * src/main/java/org/glom/web/server/ReportGenerator.java
1425 addToReport(): Use JRDesignLine.
1427 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1429 ReportGenerator: Correct the title positions and use some bold style.
1431 * src/main/java/org/glom/web/server/ReportGenerator.java:
1432 Break the code up into reusable functions, correct the placement of
1433 titles, and use normal/bold styles as in the reports in the desktop
1436 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1438 ReportGenerator: Add a header band to show the field titles.
1440 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1441 getReportHTML(): Pass the localeId to the ReportGenerator
1443 * src/main/java/org/glom/web/server/ReportGenerator.java
1444 constructor: Take the localeID so we can get translated field
1446 generateReport(), addToReport(), addFieldToBand(): Add field
1447 titles in a column header band.
1449 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1451 Reports drop-down list: Some improvement.
1453 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1454 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1455 Adedd setSelectedReport(),
1456 setReportList(): Add a blank line so that the user can select the
1458 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1459 start(): Show the current report by calling setSelectedReport().
1460 This does not seem to work yet.
1462 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1464 DetailsActivity, ListActivity: Move some variables into a base class.
1466 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1467 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1468 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1469 the clientFactory, documentID, tableName and authenticationPopup into
1470 a base class, to avoid duplication.
1472 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1474 Translate the Reports label.
1476 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1477 Get the "Reports" label string from the constants.
1478 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1479 perties: Add Reports to the constants.
1481 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1483 Reports: Implement grouping.
1485 * src/main/java/org/glom/web/server/ReportGenerator.java:
1486 Handle LayoutItem_GroupBy items and try to do the right thing
1487 with JRDesignGroup. It seems to work.
1489 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1491 Actually show some data with JasperReports.
1493 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1494 getReportHTML(): Move most code into a ReportGenerator class.
1495 * src/main/java/org/glom/web/server/ReportGenerator.java:
1496 Recurse into sub-groups, adding fields to the JasperDesign's details
1497 band. Note that we must set an arbitrary width and height, or it just
1498 will not show any data.
1500 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1502 Reports Chooser: Show the titles, not the names.
1504 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1505 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1506 and the names as the values.
1507 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1508 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1509 group now that we provide the report name, so it should always
1512 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1514 Depend on jasperreports.
1516 * pom.xml: Add the dependency. My plan is to use this on the
1519 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1521 Implement navigation to report places.
1523 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1524 start(): Do not bother to handle all events here.
1525 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1526 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1527 Added getSelectedReport().
1528 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1529 .java: start(): When handling a change to the reports chooser,
1530 call getSelectedReport() and goTo() its ReportPlace.
1531 * src/main/java/org/glom/web/client/ui/ReportView.java
1532 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1533 Added setReportHTML() which puts the html in a gwt HTML widget.
1534 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1535 getReportHTML(): Return "TODO" just to show that this works.
1537 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1539 Make ReportPlace usable.
1541 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1542 Mention ReportPlace.
1543 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1544 Correct the @prefix annotation.
1546 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1548 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1550 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1551 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1552 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1553 Change getReportLayout() to getReportHMTL() because we will not need to
1554 parse or render the report layout on the client side.
1555 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1556 getReportLayout(): Return the libglom LayoutGroup type because we will
1557 not need to convert to a shared type, because this will not be used on
1559 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1562 Note that there is still no implementation for this.
1565 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1567 Add a (empty) Report Place, View, and Activity.
1569 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1571 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1572 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1573 this into a superclass:
1574 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1575 and also use it as the base of this new ReportPlace:
1576 * src/main/java/org/glom/web/client/place/ReportPlace.java
1578 * src/main/java/org/glom/web/client/ui/ReportView.java
1579 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1580 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1581 Add these, containing mostly boiler-plate for now.
1583 * src/main/java/org/glom/web/client/OnlineGlomService.java
1584 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1585 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1586 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1587 Add API to get the LayoutGroup for the report.
1589 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1591 Add and fill a Reports drop-down list box.
1593 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1595 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1596 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1597 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1598 Added getReports(document, table, localeID), calling
1599 ConfiguredDocument.getReports().
1600 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1601 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1602 Added setReportsList() and a list widget.
1603 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1604 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1609 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1611 Translations: Add Esperanto.
1613 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1614 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1615 properties: Add this translation because someone took the time to make it.
1617 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1619 Adapt to the java-libglom 1.21.7 API.
1621 * src/main/java/org/glom/web/server/ReportGenerator.java:
1622 addToReport(): get_group_secondary_fields() is now
1623 get_secondary_fields().
1626 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1628 Use the latest java-libglom version.
1630 * pom.xml: Use java-libglom 1.21.7.
1632 2012-03-03 Ben Konrath <ben@bagu.org>
1634 Display date and time in details view.
1636 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1638 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1640 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1642 Require the latest java-libglom.
1644 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1646 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1648 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1650 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1651 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1652 an empty quickfind string. I also corrected libglom to create only
1653 empty where clauses for empty quickfind strings, but this avoids the
1656 2012-02-24 Ben Konrath <ben@bagu.org>
1658 Improve the tabs in the Notebook widget.
1662 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1664 Translations: Try to translate the strings.
1666 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1667 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1668 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1669 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1670 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1671 Take the Open translation from GTK+'s .po files.
1672 Take the Details translation from Glom's po files.
1673 I have added the other strings to Glom so we can get translations that way:
1674 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1676 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1678 TableSelectionViewImpl: Put the search label and entry in a div.
1680 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1681 Put the search widgets in a FlowTable so that the CSS can be used to
1682 style them while keeping them together.
1683 * src/main/webapp/style.css: Mention the new div.
1685 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1687 Translate more strings in more locales.
1689 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1690 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1691 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1692 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1693 Translate the "Details" and "Open" string too.
1695 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1696 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1697 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1698 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1699 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1700 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1701 Add these new locales as placeholders though they currently contain English.
1703 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1705 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1707 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1708 Check the ConfiguredDocument* for null before using it.
1710 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1712 Tell Eclipse about the generated java files.
1714 * .classpath: This lets it find OnlineGlomConstants.java.
1715 It would be nice if Eclipse just used the maven build files.
1717 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1719 Prevent a crash when no locale is specified in the URL.
1721 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1722 Avoid returning a null string, obtained from
1723 Window.Location.getParameter(). This caused a crash when it was
1724 later passed to libglom's API.
1725 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1726 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1727 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1728 guard against future null strings.
1730 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1732 Use the ?locale= query param instead of the &lang= token param.
1734 * src/main/java/org/glom/web/client/place/ListPlace.java
1735 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1736 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1737 Remove the lang token key and value.
1739 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1740 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1741 When the user selects a different locale from the chooser, use
1742 Window.Location.assign() to change the URL, which then causes a reload.
1744 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1745 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1746 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1747 * src/main/java/org/glom/web/client/activity/ListActivity.java
1748 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1749 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1750 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1751 * src/main/java/org/glom/web/client/ui/ListView.java:
1752 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1754 Remove localeID member variables and method/constructor parameters, instead
1755 using Utils.getCurrentLocaleID() when we need a localID to pass to
1758 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1760 Internationalize the UI strings.
1762 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1763 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1764 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1765 because it is unused. Messages are apparently strings that can have
1766 parameters, but we do not need that yet, so Contants will be enough for now.
1767 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1768 to say that we support the en and de locales.
1769 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1770 The original English strings.
1771 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1772 Some German translations of the English strings.
1773 The i18n goal then uses the .properties file to generate an
1774 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1775 returns an implementation that returns the translated strings.
1776 The documentation suggests putting these in src/java/*/client/, but it seems
1777 best to put it in src/resources/*/client/.
1778 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1779 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1780 instead of hard-coding them.
1781 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1782 but that does not seem to stop the build, though it confuses Eclipse.
1784 You can see the translated string by adding ?locale=de to the URL, like so:
1785 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1787 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1789 Improve null/empty String checks.
1791 * pom.xml: Add a dependency on commons-lang, to use
1792 org.apache.commons.lang.StringUtils.
1793 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1794 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1795 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1796 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1797 Use StringUtils.isEmpty().
1799 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1800 StringUtils class with a static isEmpty() function because we
1801 cannot use org.apache.commons.lang.StringUtils in client-side
1802 GWT code because it (apparently) cannot be compiled to javascript.
1803 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1804 * src/main/java/org/glom/web/client/activity/ListActivity.java
1805 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1806 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1807 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1808 * src/main/java/org/glom/web/client/place/ListPlace.java
1809 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1810 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1811 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1812 * src/main/java/org/glom/web/client/ui/details/Group.java
1813 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1814 our StringUtils.isEmpty() function.
1816 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1818 Update to the latest java-libglom API.
1820 * pom.xml: Require java-libglom 1.21.4.
1821 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1822 getDocumentInfo(), getListViewLayoutGroup():
1823 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1825 * src/main/java/org/glom/web/server/database/DBAccess.java
1826 getFieldsToShowForSQLQueryAddGroup(),
1827 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1828 with either get_database_title_original() or
1829 get_database_title(localeID).
1831 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1833 ConfiguredDocument: Avoid a null pointer exception.
1835 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1836 Initialize localeID to "" to avoid returning a null String which
1837 causes a crash in java-libglom's swing-generated code.
1839 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1841 Some simple renaming.
1843 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1844 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1845 for localeChooser. This seems more appropriate and is less ambiguous
1846 particularly in the .css file.
1848 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1850 ConfiguredDocument: Rename the localedID private member variable.
1852 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1854 Adapt to the latest java-libglom API from git master.
1856 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1857 libglom now uses only Vector instead of List, which uses add() instead of
1860 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1862 ConfiguredDocument: Rename the localedID private member variable.
1864 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1866 Build a source tarball with mvn assembly:single
1868 * assembly.xml: Add this file.
1869 * pom.xml: Use the maven-assembly-plugin and tell it to use
1870 our assembly.xml file.
1872 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1874 OnlineGlomServiceImpl: Get .glom files recursively.
1876 * pom.xml: Depend on commons-io from org.apache.commons.
1877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1878 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1879 files recursively, and with the easier filter for the extension.
1880 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1881 simplify that code too.
1883 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1885 README: Mention that you must install java-libglom packages separately.
1887 But then it works, because java-libglom is now in the central maven
1890 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1892 locales drop-down: Show the correct selected locale when the URL changes.
1894 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1895 .java: setPlace(): Move some code into fillView().
1897 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1899 locales drop-down: Do not lose the primary key.
1901 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1902 start(): onLocaleChange(): Pass the current primary key value,
1903 instead of an empty value.
1905 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1907 locales drop-down: Do not lose the drop-down selection.
1909 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1910 .java (TableSelectionActivity.fillView): Set the selected locale
1911 after changing the drop-down items (though we do not really need
1912 to change them just because the locale changes.)
1914 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1916 locales drop-down: Change the tables list when this changes.
1918 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1919 .java: TableSelectionActivity.start(): Move the async table titles
1920 retrieval into a private fillView() method and also call this when
1921 the chosen locale changes.
1922 Note that the document title is not actually translatable yet, but
1923 that is a problem that I should fix soon in libglom.
1925 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1927 Improve the placement of the locales drop-down.
1929 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1930 Put the title and locales drop-down in a div (gwt.FlowTable).
1931 * src/main/webapp/style.css: Add magic css properties to make this work.
1932 Also remove the left margin from the title so that it lines up with the
1935 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1937 locales selector: Show human-readable locale titles.
1939 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1940 getDocumentInfo(): Use java.util.Locale to show a real title of
1941 each locale, in the locale's own language.
1943 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1945 Add a language/locale selector drop-down.
1947 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1948 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1949 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1950 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1951 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1952 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1953 Add a ListBox to show the available locales. Add getLocaleSelector(),
1954 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1955 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1956 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1957 java: Add these classes.
1958 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1959 start(): Fill the locales ListBox. Handle its change event, firing a
1961 setPlace(): Show the selected locale as specified by the URL token.
1962 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1963 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1964 Handle LocaleChangeEvent, going to a new *Place with that locale.
1966 The placement of the ListBox is not pretty, and it currently uses the ID
1967 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1971 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1973 Search box: Show the search text from the URL token.
1975 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1976 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1977 Add setQuickFindText().
1978 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1979 .java: setPlace(): Store the queryText if the place is a ListPlace,
1980 and call TableSelectionView.setQuickFindText().
1982 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1984 Allow use of translations via, for instance, &lang=de in the URL.
1986 * pom.xml: Use the unstable java-libglom 1.21 version.
1988 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1989 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1991 init(): Instead of calling TranslatableItem.set_current_locale()
1992 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1993 However, this is only for default locales, which are not needed to
1994 change the locale in the URL.
1995 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1996 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1997 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1998 layout for a particular locale.
1999 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2000 Add get/setDefaultLocaleID().
2001 getDocumentInfo(), getListViewData(), getRelatedListData(),
2002 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2003 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2004 localeID parameter, so we can get the layout for a particular locale.
2006 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2007 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2008 * src/main/java/org/glom/web/client/place/ListPlace.java:
2009 Parse and construct a lang parameter too.
2011 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2012 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2013 passed to subsequent methods and constructors.
2014 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2015 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2016 Store the localeID from the *Place and pass it to other constructors
2017 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2019 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2020 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2021 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2022 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2023 * src/main/java/org/glom/web/client/ui/ListView.java:
2024 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2025 Take localeID parameters and pass them to subsequent constructors and
2026 methods, so that the layout is always retrieved for that locale.
2028 This is rather repetitive.
2030 Note that "" means the original (default) locale of the Glom document,
2031 which is usually English.
2033 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2035 Documents: Remove final keyword to fix startup configuration.
2037 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2038 final keywords on the private member variables because that breaks
2039 the startup, apparently (there are warnings) because it stops them
2040 from being serialized. I added these in the previous commit.
2042 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2044 Documents: Add some final keywords.
2046 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2049 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2051 OnlineGlomServiceImpl: Add to overview comments.
2053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2054 Note that this is where all the document are loaded. They are not
2055 loaded freshly for each page.
2057 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2061 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2062 Add a TextBox for the text of a quick find.
2063 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2065 setBackLink(): Add a String quickFind parameter.
2066 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2067 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2068 to the base interface, because that is how TableSelectionViewImpl is used.
2069 * src/main/webapp/style.css: Add style for the search box and its label.
2071 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2072 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2073 Add these files, based on the existing TableChangeEvent and
2074 TableChangeEventHandlers.
2075 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2076 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2077 a ListPlace() that the user should be taken to.
2078 * src/main/java/org/glom/web/client/activity/ListActivity.java
2079 start(): Handle it here too and adapt the TableChangeEvent handler to
2080 pass the extra "" quickFind parameter to ListPlace.
2081 * src/main/java/org/glom/web/client/place/ListPlace.java:
2082 Constructor: Take an extra String quickFind parameter and store it,
2083 returning it from a new getQuickFind() method.
2084 getToken(): Put the quickFind text in the URL token.
2085 getPlace(): Parse the quickFind text from the URL token.
2086 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2087 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2088 ListPlace constructor.
2089 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2090 .java: start(): Add a Change handler for the TableSelectionView's
2091 TextBox (via its base HasChangeHandlers interface), firing the new
2092 QuickFindChangeEvent.
2093 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2094 pass the extra "" quickFind parameter.
2096 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2097 setCellTable(): Add a String quickFind parameter and pass it to
2098 the ListViewTable() constructor.
2099 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2100 setCellTable() in the base interface, because that is how ListViewImpl
2103 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2104 Add a String quickFind member variable.
2105 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2106 Constructor: Add a String quickFind parameter, storing it in the
2107 base ListTable's member variable.
2108 onRangeChanged(): Pass quickFind to the
2109 OnlineGlomServiceAsync.getSortedListViewData() and
2110 OnlineGlomServiceAsync.getListViewData() methods.
2112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2113 getListViewData(), getSortedListViewData(): Add a String quickFind
2114 parameter, passing it to ConfiguredDocument.getListViewData().
2115 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2116 Change getListViewData(), getSortedListViewData() in the base interface,
2117 because that is how OnlineGlomServiceImpl is used, via this:
2118 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2119 Change getListViewData(), getSortedListViewData() here too.
2120 This class can apparently be used to asynchronously call methods on
2121 OnlineGlomService, and GWT seems to implement that after recognizing
2122 just the *Async name convention and the extra AsyncCallback parameters.
2124 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2125 getListViewData(): Add a String quickFind parameter, and pass it to
2126 ListViewDBAccess.getData().
2127 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2128 getListData(): Add a String quickFind parameter and pass it to
2130 getSelectQuery(): Add a String quickFind parameter.
2131 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2132 getSelectQuery(): Add a String quickFind parameter and use it with
2133 Glom.get_find_where_clause_quick() to pass a where_clause to
2134 Glom.build_sql_select_with_where_clause(), to actually filter the
2136 getData(): Add a String quickFind parameter, passing it to getListData().
2137 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2138 va: getData(): Pass an empty string to getListData() for the
2139 quickFind parameter.
2141 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2143 ListTable: Minor change.
2145 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2146 createCellTable(): Make this protected instead of public.
2148 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2150 Many files: Use final for the parameters and use the @override attribute.
2152 2012-01-22 Ben Konrath <ben@bagu.org>
2154 Add anchor links for single line text that starts with http, ftp and www.
2158 2012-01-22 Ben Konrath <ben@bagu.org>
2160 Add ellipsis to single line text in details view.
2164 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2166 Remove all javadoc author tags.
2168 Because they are awkward and meaningless when many people touch
2170 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2172 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2174 Revert the COPYING.LESSER to COPYING rename.
2176 Apparently both should be there if it is LGPL.
2178 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2180 *View: Remove unused imports.
2182 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2183 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2184 * src/main/java/org/glom/web/client/ui/ListView.java:
2185 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2186 Remove unused imports, as suggested by Eclipse.
2188 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2190 Move the *View::Presenter types, and some API into one base View.
2192 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2193 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2194 * src/main/java/org/glom/web/client/ui/ListView.java:
2195 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2196 Presenter, setPresenter() and clear() into a shared base interface,
2197 to avoid the unnecessary duplicate Presenter types and to more clearly
2198 show how the *Views share the same structure, even if they are not
2199 used polymorphically.
2201 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2202 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2204 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2205 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2206 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2208 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2211 Feel free to revert this if there is a good reason for the duplicate
2214 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2216 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2218 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2219 a class member instead of a local variable in the method.
2220 This lets us use it to get the view instances, for use in tests.
2221 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2222 beforeOnlineGlom(): Test some more details of the initial view.
2223 Again, this is not very useful.
2225 To really test gwt-glom we will need to start a local postgresql
2226 instance with local data, like the Glom tests in C++.
2228 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2230 pom.xml: Mention the LGPL license.
2232 * pom.xml: Add a licenses section.
2233 * COPYING.LESSER: Move this to COPYING, which
2234 previously contained the GPL. But gwt-glom is all LGPL.
2236 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2238 Add project information to README and pom.xml.
2240 * README: Add a brief description and mention some mvn
2242 * pom.xml: This extra information shows up in mvn site
2245 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2247 Use the latest java-libglom version.
2249 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2251 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2253 GwtTestOnlineGlom: Test a little more.
2255 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2256 protected rather than private, as suggested by the gwt-test-utils
2258 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2259 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2260 Test the initial visibility of the panels.
2262 However, this is not a very useful test.
2263 And I wonder how we should generally test using this idea for an
2264 activity/places app like ours where the real changes happen implicitly
2265 based on the history token/URL.
2267 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2269 Slight modification to *Mapper comments.
2271 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2272 (DataActivityMapper)
2273 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2275 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2277 Remove comments mentioning GIN because they are just copied from
2278 the example code and are apparently not helpful:
2279 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2280 Also change the mention of a class that is only in the example code.
2282 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2284 GwtTestOnlineGlom test: Minor changes.
2286 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2287 Avoid the long qualified class name and modify the comment
2288 because it is now obvious to me that the mocked class is the only
2289 custom one created via GWT.create().
2291 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2293 Tests: Added the beginnings of a test using gwt-test-utils.
2295 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2296 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2297 which tells gwt-test-utils what class will be tested.
2298 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2299 Add a simple (but empty) test case. One class, used by the OnlineGlom
2300 class, is mocked so that it can be created. However, I am not sure
2301 why only this class needs to be mocked.
2303 Note that mockito seems more popular, and clearer, than easymock,
2304 but I have not got that working yet. It might be a matter of the
2307 This test is run during mvn integration-test.
2309 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2311 Tests: Use junit4-style syntax instead of junit3-style.
2313 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2314 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2315 * src/test/java/org/glom/web/shared/DataItemTest.java:
2316 Use the @Test annotation rather than relying on the test*() prefix.
2317 Also no longer implement TestCase, to avoid triggering support for
2318 the junit3-way, which stops the annotations from working.
2319 Change the imports from import junit.framework.* to
2320 import org.junit.*, which is apparently the new way.
2322 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2324 Added a test for ListPlace token parsing and creation.
2326 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2327 This is much the same as DetailsPlaceTest.
2329 I wonder how we could test the other parts of the *Place API.
2331 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2333 DetailsPlace test: Also test getToken() and recreation via getPlace().
2335 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2336 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2337 recreate it, testing the recreated DetailsPlace for the same parameter
2340 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2342 Use the surefire-report plugin.
2344 * pom.xml: This generates a HTML report about the tests in
2345 target/site/surefire-report.html
2346 when you do mvn surefire-report:report. It seems to be popular/normal.
2348 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2350 Added a test for DetailsPlace.
2352 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2353 Test the getPlace() token parsing.
2355 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2357 Added a first unit test.
2359 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2360 * src/test/java/org/glom/web/shared/DataItemTest.java:
2361 This is a silly test but it is just to get things started. Note that
2362 maven/junit finds the test because it looks in src/test by default.
2364 2011-12-22 Ben Konrath <ben@bagu.org>
2366 Change charsetName to "UTF-8" when replacing line breaks.
2368 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2369 that work in Java (such as "UTF8") will not work when compiled to
2372 This fixes a problem with multi-line details view fields that have hard
2373 line breaks. The "License Text" field on this page demonstrates the
2376 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2378 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2380 2011-12-22 Ben Konrath <ben@bagu.org>
2382 Fix another bug with related list navigation.
2384 I've tested all the navigation buttons in all of the related lists
2385 so things should be good now.
2387 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2389 2011-12-22 Ben Konrath <ben@bagu.org>
2391 Fix a crasher when refreshing the list view with the default table.
2393 This crash will also happen when loading the list view with the default
2394 table from a link or bookmark.
2396 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2397 to the main document selection page when the document id hasn't been
2399 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2400 the main document selection page when the document id hasn't been
2402 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2403 values for the details place when the document id hasn't been set.
2404 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2405 values for the list place when the document id hasn't been set.
2407 2011-12-21 Ben Konrath <ben@bagu.org>
2409 Protect against NPE when glom.document.locale is not in config.
2411 This patch protects against an NPE when glom.document.locale is not in
2412 the config file. This NPE will also happen if glom.document.locale is
2415 The patch also updates the error message to display the class name when
2416 the getMessage() returns null. This was happening when the NPE was
2417 thrown and I had "Configuration Error: null". If an NPE is encountered
2418 with this patch, "Configuration Error: NullPointerException " will be
2421 This commit closes this bug:
2423 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2425 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2427 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2429 Rename onlineglom.properties to onlineglom.properties.sample.
2431 * src/main/resources/onlineglom.properties: Rename to:
2432 * src/main/resources/onlineglom.properties.sample:
2433 * src/main/resources/README: And add this file explaining that people
2434 should rename it back when deploying.
2436 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2438 Allow choosing the translation in the .properties file.
2440 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2441 init(): Read a glom.document.locale value from the configuration file
2442 and call Glom's TransatableItem::set_current_locale() method.
2443 * src/main/resources/onlineglom.properties: Add a commented-out
2444 example of this new setting.
2446 It would be better to add &lang=de_DE to the URL, but the current
2447 libglom API does not allow us to do this easily. I am working on that.
2449 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2451 Avoid a crash in parsing of token parameters.
2453 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2454 ava: getTokenParams(): Do not crash if a parameter has a key but no
2455 value, and ignore parameters with neither.
2457 2011-12-17 Murray Cumming <murrayc@murayc.com>
2459 History token building/handling: Improve use of token parameters.
2461 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2462 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2463 and buildParamsToken(HashMap), for use by derived classes.
2464 Make the separator private because it is no longer be needed.
2465 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2466 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2467 instead of manual string concatenation.
2468 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2469 of hardcoded indices and awkward splitting code.
2470 * src/main/java/org/glom/web/client/place/ListPlace.java
2471 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2472 instead of manual string concatenation.
2473 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2474 of hardcoded indices and awkward splitting code.
2475 This should fix bug #666420
2477 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2479 Fix a Navgiation->Navigation typo in the code.
2481 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2482 Rename processNavgiation() to processNavigation().
2484 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2486 Fix a seperator->separator typo in the code.
2488 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2489 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2490 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2493 2011-12-15 Ben Konrath <ben@bagu.org>
2495 Cleanup some comments.
2497 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2499 2011-12-14 Ben Konrath <ben@bagu.org>
2501 Replace \n with <br/> for multiline text in the details view.
2503 Vertical scrollbars are added when needed as well.
2505 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2507 2011-12-14 Ben Konrath <ben@bagu.org>
2509 Specify the font for document selection links.
2511 * src/main/webapp/style.css:
2513 2011-12-14 Ben Konrath <ben@bagu.org>
2515 Fix bouncy CellTable while paging.
2517 This doesn't currently work with related list tables in unselected
2520 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2522 2011-12-14 Ben Konrath <ben@bagu.org>
2524 Revamp the appearance of the document selection page.
2526 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2527 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2528 * src/main/webapp/style.css:
2530 2011-12-13 Ben Konrath <ben@bagu.org>
2532 Set navigation button column to the smallest size possible.
2534 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2536 2011-12-13 Ben Konrath <ben@bagu.org>
2538 Change OpenButton nomenclature to NavigationButton.
2540 Using NavigtionButton makes things more generic. Classes, methods and
2541 variables have been changed.
2543 This is a rename-only refactor.
2545 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2546 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2547 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2548 Renamed from OpenButtonCell.
2549 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2550 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2551 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2553 2011-12-12 Ben Konrath <ben@bagu.org>
2555 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2557 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2558 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2559 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2560 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2562 2011-12-12 Ben Konrath <ben@bagu.org>
2564 Update variable names and comments.
2566 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2567 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2569 2011-12-12 Ben Konrath <ben@bagu.org>
2571 Properly initialize numNonEmptyRows variable to zero.
2573 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2574 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2576 2011-12-05 Ben Konrath <ben@bagu.org>
2578 Add latest mockup with HTML tables.
2580 Features of this mockup:
2582 -> HTML table for flowtable
2583 -> HTML table for flowtable column
2584 -> Example of how related lists would look
2585 -> Not using text entries for data items
2587 The current version of Online Glom doesn't use HTML tables for the
2590 This mockup has been sent to the glom-devel mailing list but it's good
2591 to have it here as well.
2593 * mockups/details-view-html-tables.html:
2595 2011-12-05 Ben Konrath <ben@bagu.org>
2597 Remove unnecessary getPrimaryKeyField() method.
2599 getPrimaryKeyFieldForTable(String) has been renamed to
2600 getPrimaryKeyField(String).
2602 * src/main/java/org/glom/web/server/database/DBAccess.java:
2603 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2604 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2606 2011-12-05 Ben Konrath <ben@bagu.org>
2608 Add string representation of TypedDataItem value to conversion error message.
2610 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2611 message was extracted into its own method to avoid duplication.
2613 2011-12-05 Ben Konrath <ben@bagu.org>
2615 Add type checking to navigation primary key value creation.
2617 Create navigation primary key only if the expected type from the Glom
2618 document matches the type returned by the SQL query.
2620 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2622 2011-12-05 Ben Konrath <ben@bagu.org>
2624 Rename a couple of variables in RelatedListNavigation.
2626 This is a rename-only refactor.
2628 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2630 2011-12-05 Ben Konrath <ben@bagu.org>
2632 Move getListLayoutGroup() into getListViewLayoutGroup().
2634 This removes getListLayoutGroup(). It was only being called by
2635 getListViewLayoutGroup().
2637 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2639 2011-12-05 Ben Konrath <ben@bagu.org>
2641 Remove check for LayoutItem_Portal in list table method.
2643 This check is no longer necessary because the method isn't being used
2644 to create the LayoutItemPortal DTO.
2646 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2648 2011-12-05 Ben Konrath <ben@bagu.org>
2650 Properly support related list navigation.
2652 Navigation from the "Repository Analyzer -> Package Scans ->
2653 Dependencies" related table wasn't working because the primary key for
2654 related tables wasn't being set properly. This commit fixes the
2657 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2658 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2659 doesn't set the primary key properly for related list tables.
2660 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2661 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2662 useful for getting the primary key for list view tables and for related
2664 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2665 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2666 Move code to set the primary key for the table from the abstract
2667 ListDBAccess class to ListViewDBAccess as it's only correct for list
2669 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2670 Properly add primary key to related list tables.
2672 2011-12-02 Ben Konrath <ben@bagu.org>
2674 Properly set the horizontal alignment of fields.
2676 This fix is for both the list tables and the details view.
2678 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2679 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2680 to set the horizontal alignment of fields.
2682 2011-12-02 Ben Konrath <ben@bagu.org>
2684 Display currency codes in the details view.
2686 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2688 2011-12-02 Ben Konrath <ben@bagu.org>
2690 Avoid duplicate JNI call.
2692 JNI is not as efficient as pure Java and this is an easy (and small)
2695 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2696 Use previously retrieved value for whereClauseToTableName instead of
2699 2011-12-02 Ben Konrath <ben@bagu.org>
2701 Rename a couple of variables in RelatedListNavigation.
2703 This is a rename-only refactor.
2705 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2707 2011-12-02 Ben Konrath <ben@bagu.org>
2709 Indicate clearly that a mismatched primary key type is a bug.
2711 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2712 warning to error. Add 'This is a bug.' to message.
2714 2011-12-02 Ben Konrath <ben@bagu.org>
2716 Update / fix some comments.
2718 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2720 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2722 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2723 Fix comments. Add some TODOs.
2725 2011-12-02 Ben Konrath <ben@bagu.org>
2727 Enable navigation to details view with string primary key from related list.
2729 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2730 Create a text primary key value when return type of result is
2731 java.sql.Types.VARCHAR.
2733 2011-12-02 Ben Konrath <ben@bagu.org>
2735 Use checkboxes for booleans in the details view.
2737 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2739 2011-12-01 Ben Konrath <ben@bagu.org>
2741 Improve performance of related list height calculation.
2743 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2744 Put code to calculate the expected height in a static initializer so
2745 that that it's only called once.
2747 2011-12-01 Ben Konrath <ben@bagu.org>
2749 Show related list tables in notebooks (again).
2751 Calculate the height of the related list tables so the Notebook can be
2752 set the correct height. The height of the related list table is also needed by
2753 FlowTable to be able decide how to create the layout.
2755 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2756 and set the Portal height based on the height of the related list
2757 table and the Portal container.
2758 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2759 Add method to calculate the height of the related list tables.
2760 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2761 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2762 calculate the height of the Pager widget.
2764 2011-12-01 Ben Konrath <ben@bagu.org>
2766 Use CellTable API for table property instead of setting style on Element.
2768 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2770 2011-12-01 Ben Konrath <ben@bagu.org>
2772 Make ListViewTable and RelatedListTable a consistent height.
2774 The tables are now a consistent height regardless of the contents of
2775 the table. A hidden button is added to empty rows to ensure that the
2776 height of these rows will match the height of rows with data.
2778 A navigation button column is now added to every table. The width of
2779 the navigation column is set to 0px when a RelatedListTable shouldn't
2780 have navigation buttons. This maintains the a consistent row height in
2781 tables that don't show the navigation buttons.
2783 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2784 navigation column when not needed.
2785 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2786 arguments for navigation button to constructor of ListViewTable.
2787 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2788 hidden button for empty data rows.
2789 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2790 arguments for navigation button to constructor.
2791 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2792 create navigation buttons. Add hideNavigationButtons() method.
2793 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2794 arguments for navigation button to constructor.
2796 2011-12-01 Ben Konrath <ben@bagu.org>
2798 Use 'visibility: hidden' in Utils.getWidgetHeight().
2800 This is better choice because hidden elements are invisible, don't
2801 respond to events and are not part of the tab order. They will,