1 2012-06-15 Murray Cumming <murrayc@murrayc.com>
3 SelfHostExampleTest: Make sure we cleanup on failure.
5 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
6 the use of cleanup() to a tearDown() JUnit method.
8 2012-06-12 Murray Cumming <murrayc@murrayc.com>
10 ConfiguredDocument: Add a primary key to portals at least once.
12 * src/main/java/org/glom/web/server/ConfiguredDocument.java
13 updatePortalsExtras): Fix a typo so that we add the primary key
15 This is a fix for the previous commit:
16 ConfiguredDocument: Do not add a primary key to portals each time.
18 2012-06-08 Murray Cumming <murrayc@murrayc.com>
20 SelfHoster: Avoid some compiler warnings.
22 * src/test/java/org/glom/web/server/SelfHoster.java
23 executeCommandLineAndWait():
24 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
25 the now-unused streams for stdout and stderr from the command Processes.
26 These are not used because readln() hangs while waiting for a new line,
27 where there may be no next line. The commented out code is still there
28 to help us figure out how to do this properly.
30 2012-06-08 Murray Cumming <murrayc@murrayc.com>
32 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
34 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
35 Make this actually test the cloning again, though it is not very useful
36 now that we do not use the part that had a problem with cloning before.
38 2012-06-08 Murray Cumming <murrayc@murrayc.com>
40 SelfHoster: Keep trying pg_ctl after starting postgres.
42 * src/test/java/org/glom/web/server/SelfHoster.java
43 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
44 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
45 regular Glom. This seems mad but it seems to work because the first
46 command would fail if pg_ctl would eventually fail.
48 2012-06-08 Murray Cumming <murrayc@murrayc.com>
50 SelfHoster: Wait until the server is really ready.
52 * src/test/java/org/glom/web/server/SelfHoster.java
53 selfHost(): Attempt the connection after starting the server, retrying
54 a few times if necessary, so that the server is really ready already when
55 we return from this method.
56 The regular Glom code does this too because pg_ctl reports success too soon.
58 2012-06-08 Murray Cumming <murrayc@murrayc.com>
60 ConfiguredDocument: Do not add a primary key to portals each time.
62 * src/main/java/org/glom/web/server/ConfiguredDocument.java
63 updatePortalsExtras(): Only add an extra primary key field if there is
64 none, to avoid adding one each time we retrieve the details layout from the
66 This should fix bug #676986 (Ben Konrath)
68 2012-05-25 Murray Cumming <murrayc@murrayc.com>
70 Document.load(): Support version 7 documents.
72 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
73 database_title attribute if the title attribute is not there.
76 2012-05-24 Ben Konrath <ben@bagu.org>
78 Add configuration for auto-generating mvn:i18n from with Eclipse.
80 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
82 2012-05-24 Murray Cumming <murrayc@murrayc.com>
84 Update translations, adding French.
86 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
87 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
88 Add a French translation, using the translation from Glom.
90 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
91 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
92 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
93 Update these based on the translations from Glom.
95 2012-05-24 Murray Cumming <murrayc@murrayc.com>
97 SelfHoster: Add some debug println messages to help when things fail.
99 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
100 System.out.println() lines.
102 2012-05-23 Murray Cumming <murrayc@murrayc.com>
104 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
106 * src/test/java/org/glom/web/server/SelfHoster.java:
107 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
108 instance) instead of just /usr/bin (as on Fedora). Check the result when
111 2012-05-23 Murray Cumming <murrayc@murrayc.com>
113 Remove LayoutItemPortal.get/setNavigationTable().
115 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
116 Remove get/setNavigationTable(), which is only a cache, because it is not
117 used, and does not need to be used, because that decision should be made on
119 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
120 updatePortalsExtras():
121 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
122 getNavigationRecord():
123 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
126 2012-05-21 Murray Cumming <murrayc@murrayc.com>
128 Initial self-hosting for tests.
130 * pom.xml: Change the scope for log4j, to hopefully make it
131 available to the test code which uses it indirectly via jOOQ.
132 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
133 self-hosting, though we only use it for testing.
135 * src/main/java/org/glom/web/server/libglom/Document.java:
136 example rows: Use a map instead of a list for each row of values,
137 so we know what field they are for, instead of relying on the sequence
138 being correct. This is not very efficient, but it does not really need
140 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
141 testReadTableExampleRows(): Adapted.
143 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
144 that returns an Object, for generic use. Note that Object seems to be
145 the implicit base even of double.
146 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
147 for use in CREATE TABLE SQL queries.
148 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
149 to do self-hosting of PostgreSQL databases via its command-line
150 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
151 backends/postgres_self.cc. This is incomplete - it needs more
152 warnings about failures and it needs to clean up properly when things
154 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
155 test of this new class.
157 2012-05-21 Murray Cumming <murrayc@murrayc.com>
159 Document: loading example data: Handle exceptions.
161 * src/main/java/org/glom/web/server/libglom/Document.java:
162 DateFormat.parse() and Double.valueOf() can throw exceptions, though
163 Eclipse did not warn about that.
165 2012-05-20 Murray Cumming <murrayc@murrayc.com>
167 Document: load(), save(): Handle the example rows.
169 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
171 * src/main/java/org/glom/web/server/libglom/Document.java:
172 load(), save(): Load and save the example rows, though the date, time
173 and image types are not handled properly yet.
174 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
175 Add testReadTableExampleRows() just to check that something is read.
177 2012-05-20 Murray Cumming <murrayc@murrayc.com>
179 Document: Add save().
181 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
182 Added getTranslationsMap() for use while saving.
183 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
184 Adedd getUseDefaultFormatting() for use while saving.
185 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
186 and several private methods that it uses.
188 This will be useful while testing via self-hosting.
189 It is not complete, but should be complete enough for testing.
191 2012-05-17 Murray Cumming <murrayc@murrayc.com>
193 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
195 * src/main/java/org/glom/web/client/OnlineGlomService.java
196 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
198 Remove getSortedListViewData() and getSortedRelatedListData(), adding
199 the sort column index and ascending bool to the regular method.
200 Instead, a sort column index of -1 now means no sort.
201 This is less explicit, but it's fairly simple, reduces the amount of
202 code, and makes the OnlineGlomService API slightly smaller.
203 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
204 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
206 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
207 getListViewData(), getRelatedListData():
208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
209 getListViewData(), getRelatedListData():
210 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
212 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
214 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
219 2012-05-16 Murray Cumming <murrayc@murrayc.com>
221 Use translations for top-level groups too.
223 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
224 updateTitlesForLocale(): Use the translation for the group
225 as well as for child items.
229 Just recompiled to fix a problem in the released .tar.gz file.
233 2012-05-15 Murray Cumming <murrayc@murrayc.com>
235 Corrections to navigation to related records.
237 * src/main/java/org/glom/web/client/OnlineGlomService.java:
238 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
239 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
240 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
241 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
242 relationship name, because the relationship name is not necessarily unique
244 TOOD: This is inefficient, because it passes the whole list of
245 child field items back to the server, but it is more correct, and happens
246 to fix a bug with the primary key being lost after a few navigations.
247 There is probably a chance to make this more efficient anyway in some
250 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
251 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
252 * src/main/java/org/glom/web/server/ConfiguredDocument.java
253 * src/main/java/org/glom/web/server/database/DBAccess.java
254 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
255 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
258 2012-05-15 Murray Cumming <murrayc@murrayc.com>
260 Fix the use of translations.
262 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
263 Add updateTitlesForLocale().
264 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
265 Call it to discard unwanted translations and to make getTitle() return
266 the wanted translation wihout the need for the client code to specify a locale.
267 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
268 getTitle(): Fallback to the original title, as libglom does.
270 2012-05-15 Murray Cumming <murrayc@murrayc.com>
272 Document: Correctly report the number of available translation locales.
274 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
275 the available locale IDs list.
276 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
277 testLocales: Test this.
279 2012-05-15 Murray Cumming <murrayc@murrayc.com>
281 SqlUtils: Use camelCase.
283 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
284 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
285 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
286 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
287 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
288 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
290 2012-05-15 Murray Cumming <murrayc@murrayc.com>
292 Use jOOQ's tableByName() and fieldByName.
294 * pom.xml: Use jOOQ 2.3.1 to get the new API.
295 * src/main/java/org/glom/web/server/SqlUtils.java:
296 build_sql_select_step_with_where_clause(), .createField(),
297 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
298 so we can get correct quoting and escaping. Thanks to Lukas Eder for
299 adding this, and other things, to jOOQ.
301 2012-05-15 Murray Cumming <murrayc@murrayc.com>
303 SqlUtils: Remove the Connection parameters.
305 * src/main/java/org/glom/web/server/SqlUtils.java:
306 build_sql_select_with_key(), build_sql_select_with_where_clause(),
307 createSelect(), build_sql_select_step_with_where_clause(),
308 build_sql_count_select_with_where_clause(),
309 build_sql_select_count_rows(): Remove the Connection parameter because
310 jOOQ does not actually need a connectionwhen it is just used to build
312 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
314 * src/main/java/org/glom/web/server/ReportGenerator.java:
316 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
318 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
319 Constructor, getListData(), getResultSizeOfSQLQuery():
320 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
321 getSelectQuery(), getCountQuery():
322 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
323 getSelectQuery(), getCountQuery():
324 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
325 getNavigationRecord(): Adapted.
327 2012-05-14 Murray Cumming <murrayc@murrayc.com>
331 * src/main/java/org/glom/web/server/SqlUtils.java:
332 get_find_where_clause_quick(): Use a comparison of
333 lowercase values, instead of a simple equals. Regular Glom
334 uses the PostgreSQL ILIKE operator but jOOQ does not
335 support that just yet, though it will soon.
337 2012-05-14 Murray Cumming <murrayc@murrayc.com>
339 TableToViewDetails: Use a real serialization ID.
341 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
342 Though this does not fix the serialization problem.
344 2012-05-12 Murray Cumming <murrayc@murrayc.com>
346 Added LayoutItemPortalDeepCloneTest.
348 2012-05-11 Murray Cumming <murrayc@murrayc.com>
350 Make navigation work again.
352 * src/main/java/org/glom/web/server/libglom/Document.java:
353 Add getLayoutItemFieldShouldHaveNavigation().
354 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
355 Replace get/setAddNavigation() with the partly-existing
356 get/setNavigationTableName(), with an empty string being no navigation,
357 because this is simpler. Use the new
358 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
360 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
361 Add updateFieldsExtras() and call setNavigationTableName in it.
362 getDetailsLayoutGroup(),
363 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
364 createLayout(): Adapted.
365 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
366 Constructor: Adapted.
368 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
369 Replace get/setAddNavigation() with get/setNavigation(), returning a
370 TableToViewDetails class with both the table name and UsesRelationship,
371 because both are need. The previous code used java-libglom's output
372 variable (strangely, via sharedptr) to return both, but we cannot really
374 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
375 getNavigationRecord(): Adapt. However, we cannot actually use the cache
376 here because it somehow gets set to null during deepCopy(). I must test this.
377 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
378 testGetSuitableTableToViewDetails(): Adapted.
380 TODO: Find out why deepClone() is not quite working.
382 2012-05-11 Murray Cumming <murrayc@murrayc.com>
384 DBAccess: Simplify the retrievel of full field details.
386 * src/main/java/org/glom/web/server/database/DBAccess.java
387 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
388 because the Document loading should have done this.
390 2012-05-11 Murray Cumming <murrayc@murrayc.com>
392 Document: Correct loading of doubly-related layout fields.
394 * src/main/java/org/glom/web/server/libglom/Document.java:
395 loadUsesRelationship(): Actually set the related relationship, instead
396 of only setting it if it's not found.
398 2012-05-09 Murray Cumming <murrayc@murrayc.com>
400 Replace all appearances of Colour with color.
402 Because US English is dominant.
404 2012-05-09 Murray Cumming <murrayc@murrayc.com>
406 Use colors in HTML format, solving a warning about an unused function.
408 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
409 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
410 Add *asHTMLColor() versions of methods.
411 TODO: However, we should create and cache the results on the server.
412 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
413 * src/main/java/org/glom/web/client/ui/list/ListTable.java
414 * src/main/java/org/glom/web/server/ConfiguredDocument.java
415 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
416 Use the asHTMLcolor() versions.
418 2012-05-09 Murray Cumming <murrayc@murrayc.com>
420 ListViewTable: Constructor: Take the table name as a parameter.
422 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
423 Constructor: Take the tableName, and set the member variable, because
425 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
426 setCellTable(): Pass the table name.
427 This makes navigation to non-default tables work again. I don't know
428 why it worked before in the master branch.
430 2012-05-07 Murray Cumming <murrayc@murrayc.com>
432 ConfiguredDocument: Restore correct addition of hidden primary key items.
434 * src/main/java/org/glom/web/client/ui/list/ListTable.java
435 (ListTable.createCellTable): Uncomment out the check for the hidden
437 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
438 add primary key items for top-level lists and portals, as before,
439 instead of adding them to each group.
440 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
441 Actually implement the extra methods such as setHiddenPrimaryKey() and
442 comment that these are used only for top-level list groups and in portals.
443 This strangeness suggests even more that this should not be squeezed
444 into the LayoutGroup class.
446 2012-05-07 Murray Cumming <murrayc@murrayc.com>
448 Fix Formatting loading.
450 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
451 getFormattingUsed(): Remove the duplicate Formatting member variable
452 in favour of the one from the base class.
453 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
454 Initialize a new Formatting instead of using null by default, so we
455 have some defaults, instead of having to initialize one later just to
456 get the same defaults. This also makes loading of formatting from the
457 document work, because that expected a non-null.
459 2012-05-07 Murray Cumming <murrayc@murrayc.com>
461 RelatedListTable: Make sure that the tableName is set.
463 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
464 Constructor: Take the tableName so it is available later. Otherwise,
465 the server assumes that we mean the default table and cannot find the
467 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
468 setData(): Pass the tableName to the RelatedListTable constructor.
470 2012-05-07 Murray Cumming <murrayc@murrayc.com>
474 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
475 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
476 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
478 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
480 * src/main/java/org/glom/web/server/database/DBAccess.java:
481 convertResultSetToDTO(), getPortal():
482 * src/main/java/org/glom/web/server/database/ListDBAccess.java
484 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
485 Add checks for null objects and out of range access, with log messages to
486 give hints so we can fix these properly.
488 2012-05-07 Murray Cumming <murrayc@murrayc.com>
490 Portals: some corrections.
492 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
494 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
495 constructor: Use getRelationshipNameUsed() instead of getName(), because
496 that is what is meant.
497 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
498 getFromField(): Fix a typo, to get the field name, not the table name.
499 * src/main/java/org/glom/web/server/database/DBAccess.java:
500 getPortal(): Fix a typo that stopped this from working.
502 2012-05-07 Murray Cumming <murrayc@murrayc.com>
504 LayoutItemPortal: Also override getTitleOriginal().
506 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
507 This lets the base getTitle() with no parameters work.
508 TODO: Test this properly.
510 2012-05-06 Murray Cumming <murrayc@murrayc.com>
512 LayoutItemPortal: getTitle*(): Use the relationship title.
514 2012-05-06 Murray Cumming <murrayc@murrayc.com>
516 LayoutItemField: Fix loading of custom titles.
518 * src/main/java/org/glom/web/server/libglom/Document.java
519 loadDataLayoutItemField(): The title, if any, instead of the field
520 title, is stored in a title_custom node. Load it from there.
521 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
523 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
524 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
525 getTitle*() overrides.
526 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
529 2012-05-06 Murray Cumming <murrayc@murrayc.com>
531 LayoutItemField: Fall back to field titles, so some are really shown.
533 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
534 Override getTitleOriginal() and getTitle(), as in java-libglom.
535 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
538 2012-05-06 Murray Cumming <murrayc@murrayc.com>
540 Correct use of setExpectedResultSize().
542 * src/main/java/org/glom/web/server/ConfiguredDocument.java
543 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
544 Use setExpectedResultSize only on top-level groups (for instance, the
545 list layout) or on child portals (in details views).
546 Use the correct table name for portals to avoid SQL errors.
547 Update the expected counts when returning cached layouts.
549 2012-05-06 Murray Cumming <murrayc@murrayc.com>
551 Document: Interpret no group column count as 1.
553 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
554 default, though we now check for this in the UI code anyway.
556 2012-05-06 Murray Cumming <murrayc@murrayc.com>
560 2012-05-06 Murray Cumming <murrayc@murrayc.com>
562 Translatable: Use Hashmap instead of Treemap because GWT supports it.
564 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
565 The use of Treemap lead to this error from async methods, with no
567 "The response could not be deserialized"
569 2012-05-06 Murray Cumming <murrayc@murrayc.com>
571 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
573 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
574 when using the Google -> GWT Compile, or
575 g toolbar button -> GWT Compile Project... feature in Eclipse.
577 2012-05-06 Murray Cumming <murrayc@murrayc.com>
579 ListTable.addColumn(): Protect against a null Formatting.
581 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
582 Create a default Formatting if it is null, because that is the simplest
585 2012-05-06 Murray Cumming <murrayc@murrayc.com>
587 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
589 * src/main/java/org/glom/web/server/ConfiguredDocument.java
590 updateLayoutGroup(): Check that the field is not null.
592 2012-05-06 Murray Cumming <murrayc@murrayc.com>
594 ListViewImpl: Protected against a bad cast error.
596 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
597 onEnterKeyDown(): Do not cast without an instanceof check.
599 2012-05-06 Murray Cumming <murrayc@murrayc.com>
601 ListTable: Protect against an out of range error.
603 * src/main/java/org/glom/web/client/ui/list/ListTable.java
604 createCellTable(): This is unlikely, but can happen while debugging.
606 2012-05-06 Murray Cumming <murrayc@murrayc.com>
608 AsyncMessage onFailure() callbacks: Log the exception message.
610 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
611 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
612 * src/main/java/org/glom/web/client/activity/ListActivity.java:
613 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
614 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
615 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
616 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
617 These are useful clues when something is wrong.
619 2012-05-06 Murray Cumming <murrayc@murrayc.com>
621 ConfiguredDocument: Avoid a null dereference.
623 * src/main/java/org/glom/web/server/ConfiguredDocument.java
624 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
625 details maps are created.
627 2012-05-06 Murray Cumming <murrayc@murrayc.com>
629 Document: Correct the port number parsing.
631 * src/main/java/org/glom/web/server/libglom/Document.java:
632 This lets us actually connect to the database and show the document.
634 2012-05-05 Murray Cumming <murrayc@murrayc.com>
638 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
639 user-interaction, asking us to load a temporary URL in a browser.s
640 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
641 which is apparently necessary for testing the service. See the comment.
642 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
643 Show the exception, if any. This is how I saw the 404 in the HTML in
646 2012-05-05 Murray Cumming <murrayc@murrayc.com>
648 DocumentTest: Move the .glom files into the resources directory.
650 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
651 URI via getResource().
653 2012-05-05 Murray Cumming <murrayc@murrayc.com>
655 Document: Remove the FieldIdentifies inner class.
657 * src/main/java/org/glom/web/server/libglom/Document.java: We only
658 use the Relationship (though the same function in libglom is maybe
659 used in other ways) and so this removes a compiler warning.
661 2012-05-05 Murray Cumming <murrayc@murrayc.com>
663 Document.load() Remove the error code parameter.
665 * src/main/java/org/glom/web/server/libglom/Document.java: load():
666 Remove the parameter. We do not set it yet and it could never have
667 worked as an output parameter (though maybe it did in java-libglom).
668 We could use an exception if we really want the failure reason.
669 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
671 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
672 setUp(), testGetSuitableTableToViewDetails(): Adapt.
674 2012-05-05 Murray Cumming <murrayc@murrayc.com>
676 Make some inner classes static.
678 * src/main/java/org/glom/web/server/ConfiguredDocument.java
679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
680 * src/main/java/org/glom/web/server/ReportGenerator.java
681 * src/main/java/org/glom/web/server/libglom/Document.java
682 Make all inner classes static that can be static.
684 2012-05-05 Murray Cumming <murrayc@murrayc.com>
686 OnlineGlomServiceImpl: Do not load and check for java-libglom.
688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
689 init(): We do not use java-libglom any more.
691 2012-05-05 Murray Cumming <murrayc@murrayc.com>
693 Remove mentions of java-libglom.
695 * README: Remove mention of java-libglom, because it no longer needed.
696 * utils/build-onlineglom-war.sh:
697 * utils/check-and-recover-tomcat.py:
698 * utils/install-onlineglom-war.sh: Remove these as they are no longer
699 useful. Building is now far easier, with no need for jhbuild.
701 2012-05-05 Murray Cumming <murrayc@murrayc.com>
703 Fix the build (mvn package)
705 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
706 (LayoutGroup): Make the LayoutItemList inner class static and protected.
707 Otherwise the GWT Java->Javascript compilation fails with just this
708 error, during mvn package or when attempting to view in a browser,
709 in the GWT developer mode in Eclipse.
711 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
712 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
713 [INFO] Compiling module org.glom.web.OnlineGlom
714 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
715 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
716 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
717 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
718 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
719 [INFO] [ERROR] Cannot proceed due to previous errors
721 It has taken me 2 days to find out what was causing that. After reducing
722 the code, the compiler eventually showed me the full error message.
724 2012-05-04 Murray Cumming <murrayc@murrayc.com>
726 ConfiguredDocument: Cache the cloned and stripped layouts.
728 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
729 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
730 layout in a map, so we can retrieve it again without rebuilding it.
732 2012-05-04 Murray Cumming <murrayc@murrayc.com>
734 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
736 2012-05-04 Murray Cumming <murrayc@murrayc.com>
738 libglom classes: Implement some auto-generated emthods.
740 2012-05-04 Murray Cumming <murrayc@murrayc.com>
742 Add GwtTestOnlineGlomService.
744 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
745 However, this (and the other GwtTest*) does not seem to run during
748 2012-05-04 Murray Cumming <murrayc@murrayc.com>
750 Remove use of unsupported features from client code.
752 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
753 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
754 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
755 Use our client version of StringUtils instead of the apache commons one.
757 However, the GWT Javascript compliation still fails.
759 2012-04-25 Murray Cumming <murrayc@murrayc.com>
761 Add a Field class and implement some loading of it in Document.
763 2012-04-25 Murray Cumming <murrayc@murrayc.com>
765 Initial Document loading implementation, instead of libglom.
767 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
768 and Translatable classes, and adapt the rest of the code to use them.
769 However, this is still missing Layout and Field classes and loading.
771 2012-04-24 Murray Cumming <murrayc@murrayc.com>
773 Use of jOOQ: Move Field creation into a utility method.
775 * src/main/java/org/glom/web/server/SqlUtils.java:
776 This lets us improve it more easily.
778 2012-04-24 Murray Cumming <murrayc@murrayc.com>
780 Use of jOOQ: Improve the code to COUNT a sub-select.
782 * src/main/java/org/glom/web/server/SqlUtils.java:
783 Move initial query creation into
784 build_sql_select_step_with_where_clause().
785 build_sql_select_count_rows(): Use the jOOQ API instead of
786 concatentating text, because a jOOQ Select*Step is a TableLike,
787 which is what from() takes.
789 2012-04-23 Murray Cumming <murrayc@murrayc.com>
791 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
793 * pom.xml: Depend on jooq.
794 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
795 methods with jOOQ, based on the C++ implementations in libglom,
796 with some changes to the logic required by jooQ.
797 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
799 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
800 * src/main/java/org/glom/web/server/ReportGenerator.java:
801 * src/main/java/org/glom/web/server/SqlUtils.java:
802 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
803 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
804 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
805 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
806 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
807 Adapt. In particular, the SqlUtils methods now need to take a Connection,
808 because jOOQ needs that, though it seems unnecessary.
810 This is not quite finished. Ideally jOOQ would help us to build
811 table_name.field_name names, quoting and escaping them properly.
812 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
814 2012-04-21 Murray Cumming <murrayc@murrayc.com>
816 Move use of Glom.build_sql*() into a new SqlUtils class.
818 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
819 to wrap Glom.build_sql*(). The parameter types are still Glom one,
820 but this will make it easier to start using something other than
821 libglom or SqlBuilder.
823 2012-04-21 Murray Cumming <murrayc@murrayc.com>
825 Update the project URL.
827 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
829 2012-04-21 Murray Cumming <murrayc@murrayc.com>
831 Main layout: Use a FlowTable instead of absolute positioning.
833 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
834 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
835 child panels/widgets must have an absolute position. But that is annoying, so
836 this adds a FlowTable and puts the child panels in there.
838 2012-04-21 Murray Cumming <murrayc@murrayc.com>
840 GwtTestOnlineGlom: Comment out unused code.
842 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
843 Eclipse has started to say that some code is unused.
845 2012-04-21 Murray Cumming <murrayc@murrayc.com>
847 Update to the latest versions of dependencies.
849 * pom.xml: Update version numbers of dependencies to the latest
851 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
853 * src/main/java/org/glom/web/server/ReportGenerator.java:
854 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
855 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
856 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
858 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
859 Modify the imports where necessary.
861 2012-04-17 Murray Cumming <murrayc@murrayc.com>
863 Style: Remove overflow:hidden from searchbox
865 * src/main/webapp/style.css: Because this pushes the Back To Link
866 label/link on to the next row, which is then hidden due to the
867 hard-coded (in ems) height.
869 2012-04-20 Murray Cumming <murrayc@murrayc.com>
871 Remove some duplicate code.
873 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
874 getDocumentInfo(): This must have been duplicated during the merge from the
879 2012-04-19 Murray Cumming <murrayc@murrayc.com>
881 Reports: Localize the waiting for report message.
883 * src/main/java/org/glom/web/client/activity/ReportActivity.java
884 start(): Get the message from the contants.
885 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
887 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
888 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
889 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
890 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
891 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
892 Update these files with the English text for newer strings for now.
894 2012-04-19 Murray Cumming <murrayc@murrayc.com>
896 Reports: Show a message while waiting for the report.
898 * src/main/java/org/glom/web/client/ui/ReportView.java
899 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
900 Add setWaitingText(), to show a message saying that we are
901 waiting for the report to be ready.
902 * src/main/java/org/glom/web/client/activity/ReportActivity.java
903 start(): Call setWaitingText() before calling the async
906 2012-04-19 Murray Cumming <murrayc@murrayc.com>
908 ReportGenerator: Specify date and time formats.
910 * src/main/java/org/glom/web/server/ReportGenerator.java:
911 createFieldValueElement(): Use the default (and localized)
912 short formats, though we still need a way to show 4-digit
913 years without providing the format for every locale.
914 * src/main/java/org/glom/web/server/database/DBAccess.java:
915 convertResultSetToDTO(): Use the short formats here too.
917 2012-04-18 Murray Cumming <murrayc@murrayc.com>
919 ReportGenerator: Use the correct numeric formatting.
921 * src/main/java/org/glom/web/server/ReportGenerator.java
922 createFieldExpression(), createFieldValueElement(): Take the
923 whole LayoutItem_Field instead of just the field name, so
924 we have access to the formatting.
925 createFieldValueElement(): Use JRTextField.setPattern() to
926 specify the numeric formatting, with the help of a
927 regular DecimalFormat.
929 2012-04-18 Murray Cumming <murrayc@murrayc.com>
931 ReportGenerator: Avoid showing null for group by titles.
933 * src/main/java/org/glom/web/server/ReportGenerator.java
934 generateReport(): Use setBlankWhenNull() on the field title
935 style too, because this is used for values in group by
938 2012-04-18 Murray Cumming <murrayc@murrayc.com>
940 ReportGenerator: Add a colon to titles in vertical groups.
942 * src/main/java/org/glom/web/server/ReportGenerator.java
943 addFieldToDetailBandVertical(): Pass true for the withColon
946 2012-04-18 Murray Cumming <murrayc@murrayc.com>
948 ReportGenerator: Simplify the code by using Position more.
950 2012-04-18 Murray Cumming <murrayc@murrayc.com>
952 Reports: Support vertical groups, roughly.
954 * src/main/java/org/glom/web/server/ReportGenerator.java:
955 addToReport(): Rename to addGroupToReport() and, if necessary,
956 call the new addVerticalGroupToReport() method.
957 createFieldValueElement(): Let the caller specify the Y position
960 2012-04-17 Murray Cumming <murrayc@murrayc.com>
962 Reports: Allow a second report to be shown.
964 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
965 clear(): Do not remove the HTML widget, which broke the whole layout.
967 2012-04-17 Murray Cumming <murrayc@murrayc.com>
969 Locales drop-down: Show that we use English by default.
971 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
972 fillView(): When we use English, just because that is the default, when
973 no locale is specified, show that in the Locales drop-down instead of
974 just showing the first item.
976 2012-04-17 Murray Cumming <murrayc@murrayc.com>
978 Unselect the Report/Locale/Table combo item when appropriate.
980 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
981 setPlace(): clear reportName if this is not a ReportPlace.
982 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
983 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
984 When the provided name is empty, unselect all items, so that none are
985 indicated. This uses a for loop because I cannot find a single method
988 2012-04-17 Murray Cumming <murrayc@murrayc.com>
990 Report: Give the user a way to get back to the list.
992 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
993 start(), setPlace(): Show the Back To List link on reports, and also
994 interpret selecting the empty report item as back to list.
996 2012-04-13 Murray Cumming <murrayc@murrayc.com>
998 Really show the selected Report name.
1000 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1001 setPlace(): Store the reportName here, if it is that kind of Place.
1002 fillView(): Set the selected Report after filling the list of reports.
1003 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1004 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1005 null Strings, though we need some way to unselect all ListBox items
1008 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1010 ReportGenerator: Try to avoid some problems.
1012 * src/main/java/org/glom/web/server/ReportGenerator.java
1013 addField(): Try to avoid duplicates, and avoid using a null
1016 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1018 Reports: Use quickFind.
1020 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1021 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1023 getReportHTML(): Add a quickFind parameter.
1024 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1025 start(): Pass the quickFind parameter.
1026 * src/main/java/org/glom/web/server/ReportGenerator.java
1027 generateReport(): Take a quickFind parameter.
1029 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1031 ReportPlace: Actually use the report name.
1033 * src/main/java/org/glom/web/client/place/ReportPlace.java
1034 getPlace(): Do not assign the report name to the quickfind.
1036 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1038 Show java.library.path when complaining.
1040 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1041 init(): When telling us to check java.library.path, show the
1044 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1046 ReportGenerator: Do not show nulls.
1048 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1050 ReportGenerator: Make the title font larger.
1052 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1054 ReportGenerator: Put field titles inside groups, if there are groups.
1056 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1058 ReportGenerator: Take the Report itself instead of the name and group.
1060 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1061 Remove getReportLayoutGroup().
1062 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1063 getReportHTML(): Pass the report instead
1064 of its name and layout group.
1065 * src/main/java/org/glom/web/server/ReportGenerator.java
1066 generateReport(): Use the report object to use the title
1067 instead of the name.
1069 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1071 ReportGenerator: Remove designBand parameters.
1073 * src/main/java/org/glom/web/server/ReportGenerator.java:
1074 Make designBand a class member instead of passing it to all
1077 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1079 ReportGenerator: Add lines, a bit like in the desktop version.
1081 * src/main/java/org/glom/web/server/ReportGenerator.java
1082 addToReport(): Use JRDesignLine.
1084 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1086 ReportGenerator: Correct the title positions and use some bold style.
1088 * src/main/java/org/glom/web/server/ReportGenerator.java:
1089 Break the code up into reusable functions, correct the placement of
1090 titles, and use normal/bold styles as in the reports in the desktop
1093 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1095 ReportGenerator: Add a header band to show the field titles.
1097 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1098 getReportHTML(): Pass the localeId to the ReportGenerator
1100 * src/main/java/org/glom/web/server/ReportGenerator.java
1101 constructor: Take the localeID so we can get translated field
1103 generateReport(), addToReport(), addFieldToBand(): Add field
1104 titles in a column header band.
1106 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1108 Reports drop-down list: Some improvement.
1110 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1111 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1112 Adedd setSelectedReport(),
1113 setReportList(): Add a blank line so that the user can select the
1115 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1116 start(): Show the current report by calling setSelectedReport().
1117 This does not seem to work yet.
1119 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1121 DetailsActivity, ListActivity: Move some variables into a base class.
1123 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1124 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1125 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1126 the clientFactory, documentID, tableName and authenticationPopup into
1127 a base class, to avoid duplication.
1129 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1131 Translate the Reports label.
1133 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1134 Get the "Reports" label string from the constants.
1135 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1136 perties: Add Reports to the constants.
1138 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1140 Reports: Implement grouping.
1142 * src/main/java/org/glom/web/server/ReportGenerator.java:
1143 Handle LayoutItem_GroupBy items and try to do the right thing
1144 with JRDesignGroup. It seems to work.
1146 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1148 Actually show some data with JasperReports.
1150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1151 getReportHTML(): Move most code into a ReportGenerator class.
1152 * src/main/java/org/glom/web/server/ReportGenerator.java:
1153 Recurse into sub-groups, adding fields to the JasperDesign's details
1154 band. Note that we must set an arbitrary width and height, or it just
1155 will not show any data.
1157 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1159 Reports Chooser: Show the titles, not the names.
1161 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1162 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1163 and the names as the values.
1164 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1165 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1166 group now that we provide the report name, so it should always
1169 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1171 Depend on jasperreports.
1173 * pom.xml: Add the dependency. My plan is to use this on the
1176 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1178 Implement navigation to report places.
1180 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1181 start(): Do not bother to handle all events here.
1182 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1183 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1184 Added getSelectedReport().
1185 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1186 .java: start(): When handling a change to the reports chooser,
1187 call getSelectedReport() and goTo() its ReportPlace.
1188 * src/main/java/org/glom/web/client/ui/ReportView.java
1189 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1190 Added setReportHTML() which puts the html in a gwt HTML widget.
1191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1192 getReportHTML(): Return "TODO" just to show that this works.
1194 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1196 Make ReportPlace usable.
1198 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1199 Mention ReportPlace.
1200 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1201 Correct the @prefix annotation.
1203 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1205 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1207 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1208 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1210 Change getReportLayout() to getReportHMTL() because we will not need to
1211 parse or render the report layout on the client side.
1212 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1213 getReportLayout(): Return the libglom LayoutGroup type because we will
1214 not need to convert to a shared type, because this will not be used on
1216 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1219 Note that there is still no implementation for this.
1222 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1224 Add a (empty) Report Place, View, and Activity.
1226 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1228 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1229 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1230 this into a superclass:
1231 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1232 and also use it as the base of this new ReportPlace:
1233 * src/main/java/org/glom/web/client/place/ReportPlace.java
1235 * src/main/java/org/glom/web/client/ui/ReportView.java
1236 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1237 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1238 Add these, containing mostly boiler-plate for now.
1240 * src/main/java/org/glom/web/client/OnlineGlomService.java
1241 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1242 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1243 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1244 Add API to get the LayoutGroup for the report.
1246 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1248 Add and fill a Reports drop-down list box.
1250 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1252 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1253 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1255 Added getReports(document, table, localeID), calling
1256 ConfiguredDocument.getReports().
1257 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1258 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1259 Added setReportsList() and a list widget.
1260 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1261 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1266 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1268 Translations: Add Esperanto.
1270 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1271 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1272 properties: Add this translation because someone took the time to make it.
1274 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1276 Adapt to the java-libglom 1.21.7 API.
1278 * src/main/java/org/glom/web/server/ReportGenerator.java:
1279 addToReport(): get_group_secondary_fields() is now
1280 get_secondary_fields().
1283 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1285 Use the latest java-libglom version.
1287 * pom.xml: Use java-libglom 1.21.7.
1289 2012-03-03 Ben Konrath <ben@bagu.org>
1291 Display date and time in details view.
1293 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1295 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1297 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1299 Require the latest java-libglom.
1301 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1303 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1305 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1307 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1308 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1309 an empty quickfind string. I also corrected libglom to create only
1310 empty where clauses for empty quickfind strings, but this avoids the
1313 2012-02-24 Ben Konrath <ben@bagu.org>
1315 Improve the tabs in the Notebook widget.
1319 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1321 Translations: Try to translate the strings.
1323 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1324 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1325 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1326 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1327 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1328 Take the Open translation from GTK+'s .po files.
1329 Take the Details translation from Glom's po files.
1330 I have added the other strings to Glom so we can get translations that way:
1331 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1333 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1335 TableSelectionViewImpl: Put the search label and entry in a div.
1337 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1338 Put the search widgets in a FlowTable so that the CSS can be used to
1339 style them while keeping them together.
1340 * src/main/webapp/style.css: Mention the new div.
1342 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1344 Translate more strings in more locales.
1346 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1347 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1348 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1349 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1350 Translate the "Details" and "Open" string too.
1352 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1353 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1354 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1355 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1356 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1357 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1358 Add these new locales as placeholders though they currently contain English.
1360 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1362 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1364 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1365 Check the ConfiguredDocument* for null before using it.
1367 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1369 Tell Eclipse about the generated java files.
1371 * .classpath: This lets it find OnlineGlomConstants.java.
1372 It would be nice if Eclipse just used the maven build files.
1374 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1376 Prevent a crash when no locale is specified in the URL.
1378 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1379 Avoid returning a null string, obtained from
1380 Window.Location.getParameter(). This caused a crash when it was
1381 later passed to libglom's API.
1382 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1383 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1384 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1385 guard against future null strings.
1387 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1389 Use the ?locale= query param instead of the &lang= token param.
1391 * src/main/java/org/glom/web/client/place/ListPlace.java
1392 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1393 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1394 Remove the lang token key and value.
1396 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1397 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1398 When the user selects a different locale from the chooser, use
1399 Window.Location.assign() to change the URL, which then causes a reload.
1401 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1402 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1403 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1404 * src/main/java/org/glom/web/client/activity/ListActivity.java
1405 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1406 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1407 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1408 * src/main/java/org/glom/web/client/ui/ListView.java:
1409 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1411 Remove localeID member variables and method/constructor parameters, instead
1412 using Utils.getCurrentLocaleID() when we need a localID to pass to
1415 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1417 Internationalize the UI strings.
1419 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1420 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1421 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1422 because it is unused. Messages are apparently strings that can have
1423 parameters, but we do not need that yet, so Contants will be enough for now.
1424 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1425 to say that we support the en and de locales.
1426 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1427 The original English strings.
1428 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1429 Some German translations of the English strings.
1430 The i18n goal then uses the .properties file to generate an
1431 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1432 returns an implementation that returns the translated strings.
1433 The documentation suggests putting these in src/java/*/client/, but it seems
1434 best to put it in src/resources/*/client/.
1435 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1436 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1437 instead of hard-coding them.
1438 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1439 but that does not seem to stop the build, though it confuses Eclipse.
1441 You can see the translated string by adding ?locale=de to the URL, like so:
1442 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1444 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1446 Improve null/empty String checks.
1448 * pom.xml: Add a dependency on commons-lang, to use
1449 org.apache.commons.lang.StringUtils.
1450 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1451 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1452 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1453 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1454 Use StringUtils.isEmpty().
1456 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1457 StringUtils class with a static isEmpty() function because we
1458 cannot use org.apache.commons.lang.StringUtils in client-side
1459 GWT code because it (apparently) cannot be compiled to javascript.
1460 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1461 * src/main/java/org/glom/web/client/activity/ListActivity.java
1462 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1463 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1464 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1465 * src/main/java/org/glom/web/client/place/ListPlace.java
1466 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1467 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1468 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1469 * src/main/java/org/glom/web/client/ui/details/Group.java
1470 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1471 our StringUtils.isEmpty() function.
1473 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1475 Update to the latest java-libglom API.
1477 * pom.xml: Require java-libglom 1.21.4.
1478 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1479 getDocumentInfo(), getListViewLayoutGroup():
1480 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1482 * src/main/java/org/glom/web/server/database/DBAccess.java
1483 getFieldsToShowForSQLQueryAddGroup(),
1484 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1485 with either get_database_title_original() or
1486 get_database_title(localeID).
1488 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1490 ConfiguredDocument: Avoid a null pointer exception.
1492 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1493 Initialize localeID to "" to avoid returning a null String which
1494 causes a crash in java-libglom's swing-generated code.
1496 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1498 Some simple renaming.
1500 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1501 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1502 for localeChooser. This seems more appropriate and is less ambiguous
1503 particularly in the .css file.
1505 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1507 ConfiguredDocument: Rename the localedID private member variable.
1509 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1511 Adapt to the latest java-libglom API from git master.
1513 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1514 libglom now uses only Vector instead of List, which uses add() instead of
1517 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1519 ConfiguredDocument: Rename the localedID private member variable.
1521 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1523 Build a source tarball with mvn assembly:single
1525 * assembly.xml: Add this file.
1526 * pom.xml: Use the maven-assembly-plugin and tell it to use
1527 our assembly.xml file.
1529 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1531 OnlineGlomServiceImpl: Get .glom files recursively.
1533 * pom.xml: Depend on commons-io from org.apache.commons.
1534 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1535 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1536 files recursively, and with the easier filter for the extension.
1537 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1538 simplify that code too.
1540 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1542 README: Mention that you must install java-libglom packages separately.
1544 But then it works, because java-libglom is now in the central maven
1547 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1549 locales drop-down: Show the correct selected locale when the URL changes.
1551 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1552 .java: setPlace(): Move some code into fillView().
1554 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1556 locales drop-down: Do not lose the primary key.
1558 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1559 start(): onLocaleChange(): Pass the current primary key value,
1560 instead of an empty value.
1562 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1564 locales drop-down: Do not lose the drop-down selection.
1566 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1567 .java (TableSelectionActivity.fillView): Set the selected locale
1568 after changing the drop-down items (though we do not really need
1569 to change them just because the locale changes.)
1571 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1573 locales drop-down: Change the tables list when this changes.
1575 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1576 .java: TableSelectionActivity.start(): Move the async table titles
1577 retrieval into a private fillView() method and also call this when
1578 the chosen locale changes.
1579 Note that the document title is not actually translatable yet, but
1580 that is a problem that I should fix soon in libglom.
1582 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1584 Improve the placement of the locales drop-down.
1586 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1587 Put the title and locales drop-down in a div (gwt.FlowTable).
1588 * src/main/webapp/style.css: Add magic css properties to make this work.
1589 Also remove the left margin from the title so that it lines up with the
1592 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1594 locales selector: Show human-readable locale titles.
1596 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1597 getDocumentInfo(): Use java.util.Locale to show a real title of
1598 each locale, in the locale's own language.
1600 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1602 Add a language/locale selector drop-down.
1604 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1605 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1606 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1607 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1608 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1609 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1610 Add a ListBox to show the available locales. Add getLocaleSelector(),
1611 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1612 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1613 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1614 java: Add these classes.
1615 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1616 start(): Fill the locales ListBox. Handle its change event, firing a
1618 setPlace(): Show the selected locale as specified by the URL token.
1619 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1620 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1621 Handle LocaleChangeEvent, going to a new *Place with that locale.
1623 The placement of the ListBox is not pretty, and it currently uses the ID
1624 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1628 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1630 Search box: Show the search text from the URL token.
1632 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1633 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1634 Add setQuickFindText().
1635 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1636 .java: setPlace(): Store the queryText if the place is a ListPlace,
1637 and call TableSelectionView.setQuickFindText().
1639 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1641 Allow use of translations via, for instance, &lang=de in the URL.
1643 * pom.xml: Use the unstable java-libglom 1.21 version.
1645 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1646 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1647 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1648 init(): Instead of calling TranslatableItem.set_current_locale()
1649 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1650 However, this is only for default locales, which are not needed to
1651 change the locale in the URL.
1652 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1653 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1654 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1655 layout for a particular locale.
1656 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1657 Add get/setDefaultLocaleID().
1658 getDocumentInfo(), getListViewData(), getRelatedListData(),
1659 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1660 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1661 localeID parameter, so we can get the layout for a particular locale.
1663 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1664 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1665 * src/main/java/org/glom/web/client/place/ListPlace.java:
1666 Parse and construct a lang parameter too.
1668 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1669 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1670 passed to subsequent methods and constructors.
1671 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1672 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1673 Store the localeID from the *Place and pass it to other constructors
1674 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1676 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1677 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1678 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1679 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1680 * src/main/java/org/glom/web/client/ui/ListView.java:
1681 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1682 Take localeID parameters and pass them to subsequent constructors and
1683 methods, so that the layout is always retrieved for that locale.
1685 This is rather repetitive.
1687 Note that "" means the original (default) locale of the Glom document,
1688 which is usually English.
1690 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1692 Documents: Remove final keyword to fix startup configuration.
1694 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1695 final keywords on the private member variables because that breaks
1696 the startup, apparently (there are warnings) because it stops them
1697 from being serialized. I added these in the previous commit.
1699 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1701 Documents: Add some final keywords.
1703 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1706 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1708 OnlineGlomServiceImpl: Add to overview comments.
1710 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1711 Note that this is where all the document are loaded. They are not
1712 loaded freshly for each page.
1714 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1718 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1719 Add a TextBox for the text of a quick find.
1720 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1722 setBackLink(): Add a String quickFind parameter.
1723 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1724 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1725 to the base interface, because that is how TableSelectionViewImpl is used.
1726 * src/main/webapp/style.css: Add style for the search box and its label.
1728 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1729 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1730 Add these files, based on the existing TableChangeEvent and
1731 TableChangeEventHandlers.
1732 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1733 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1734 a ListPlace() that the user should be taken to.
1735 * src/main/java/org/glom/web/client/activity/ListActivity.java
1736 start(): Handle it here too and adapt the TableChangeEvent handler to
1737 pass the extra "" quickFind parameter to ListPlace.
1738 * src/main/java/org/glom/web/client/place/ListPlace.java:
1739 Constructor: Take an extra String quickFind parameter and store it,
1740 returning it from a new getQuickFind() method.
1741 getToken(): Put the quickFind text in the URL token.
1742 getPlace(): Parse the quickFind text from the URL token.
1743 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1744 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1745 ListPlace constructor.
1746 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1747 .java: start(): Add a Change handler for the TableSelectionView's
1748 TextBox (via its base HasChangeHandlers interface), firing the new
1749 QuickFindChangeEvent.
1750 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1751 pass the extra "" quickFind parameter.
1753 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1754 setCellTable(): Add a String quickFind parameter and pass it to
1755 the ListViewTable() constructor.
1756 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1757 setCellTable() in the base interface, because that is how ListViewImpl
1760 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1761 Add a String quickFind member variable.
1762 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1763 Constructor: Add a String quickFind parameter, storing it in the
1764 base ListTable's member variable.
1765 onRangeChanged(): Pass quickFind to the
1766 OnlineGlomServiceAsync.getSortedListViewData() and
1767 OnlineGlomServiceAsync.getListViewData() methods.
1769 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1770 getListViewData(), getSortedListViewData(): Add a String quickFind
1771 parameter, passing it to ConfiguredDocument.getListViewData().
1772 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1773 Change getListViewData(), getSortedListViewData() in the base interface,
1774 because that is how OnlineGlomServiceImpl is used, via this:
1775 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1776 Change getListViewData(), getSortedListViewData() here too.
1777 This class can apparently be used to asynchronously call methods on
1778 OnlineGlomService, and GWT seems to implement that after recognizing
1779 just the *Async name convention and the extra AsyncCallback parameters.
1781 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1782 getListViewData(): Add a String quickFind parameter, and pass it to
1783 ListViewDBAccess.getData().
1784 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1785 getListData(): Add a String quickFind parameter and pass it to
1787 getSelectQuery(): Add a String quickFind parameter.
1788 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1789 getSelectQuery(): Add a String quickFind parameter and use it with
1790 Glom.get_find_where_clause_quick() to pass a where_clause to
1791 Glom.build_sql_select_with_where_clause(), to actually filter the
1793 getData(): Add a String quickFind parameter, passing it to getListData().
1794 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1795 va: getData(): Pass an empty string to getListData() for the
1796 quickFind parameter.
1798 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1800 ListTable: Minor change.
1802 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1803 createCellTable(): Make this protected instead of public.
1805 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1807 Many files: Use final for the parameters and use the @override attribute.
1809 2012-01-22 Ben Konrath <ben@bagu.org>
1811 Add anchor links for single line text that starts with http, ftp and www.
1815 2012-01-22 Ben Konrath <ben@bagu.org>
1817 Add ellipsis to single line text in details view.
1821 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1823 Remove all javadoc author tags.
1825 Because they are awkward and meaningless when many people touch
1827 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1829 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1831 Revert the COPYING.LESSER to COPYING rename.
1833 Apparently both should be there if it is LGPL.
1835 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1837 *View: Remove unused imports.
1839 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1840 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1841 * src/main/java/org/glom/web/client/ui/ListView.java:
1842 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1843 Remove unused imports, as suggested by Eclipse.
1845 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1847 Move the *View::Presenter types, and some API into one base View.
1849 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1850 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1851 * src/main/java/org/glom/web/client/ui/ListView.java:
1852 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1853 Presenter, setPresenter() and clear() into a shared base interface,
1854 to avoid the unnecessary duplicate Presenter types and to more clearly
1855 show how the *Views share the same structure, even if they are not
1856 used polymorphically.
1858 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1859 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1861 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1862 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1863 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1865 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1868 Feel free to revert this if there is a good reason for the duplicate
1871 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1873 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1875 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1876 a class member instead of a local variable in the method.
1877 This lets us use it to get the view instances, for use in tests.
1878 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1879 beforeOnlineGlom(): Test some more details of the initial view.
1880 Again, this is not very useful.
1882 To really test gwt-glom we will need to start a local postgresql
1883 instance with local data, like the Glom tests in C++.
1885 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1887 pom.xml: Mention the LGPL license.
1889 * pom.xml: Add a licenses section.
1890 * COPYING.LESSER: Move this to COPYING, which
1891 previously contained the GPL. But gwt-glom is all LGPL.
1893 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1895 Add project information to README and pom.xml.
1897 * README: Add a brief description and mention some mvn
1899 * pom.xml: This extra information shows up in mvn site
1902 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1904 Use the latest java-libglom version.
1906 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1908 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1910 GwtTestOnlineGlom: Test a little more.
1912 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1913 protected rather than private, as suggested by the gwt-test-utils
1915 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1916 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1917 Test the initial visibility of the panels.
1919 However, this is not a very useful test.
1920 And I wonder how we should generally test using this idea for an
1921 activity/places app like ours where the real changes happen implicitly
1922 based on the history token/URL.
1924 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1926 Slight modification to *Mapper comments.
1928 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1929 (DataActivityMapper)
1930 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1932 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1934 Remove comments mentioning GIN because they are just copied from
1935 the example code and are apparently not helpful:
1936 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1937 Also change the mention of a class that is only in the example code.
1939 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1941 GwtTestOnlineGlom test: Minor changes.
1943 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1944 Avoid the long qualified class name and modify the comment
1945 because it is now obvious to me that the mocked class is the only
1946 custom one created via GWT.create().
1948 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1950 Tests: Added the beginnings of a test using gwt-test-utils.
1952 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1953 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1954 which tells gwt-test-utils what class will be tested.
1955 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1956 Add a simple (but empty) test case. One class, used by the OnlineGlom
1957 class, is mocked so that it can be created. However, I am not sure
1958 why only this class needs to be mocked.
1960 Note that mockito seems more popular, and clearer, than easymock,
1961 but I have not got that working yet. It might be a matter of the
1964 This test is run during mvn integration-test.
1966 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1968 Tests: Use junit4-style syntax instead of junit3-style.
1970 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1971 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1972 * src/test/java/org/glom/web/shared/DataItemTest.java:
1973 Use the @Test annotation rather than relying on the test*() prefix.
1974 Also no longer implement TestCase, to avoid triggering support for
1975 the junit3-way, which stops the annotations from working.
1976 Change the imports from import junit.framework.* to
1977 import org.junit.*, which is apparently the new way.
1979 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1981 Added a test for ListPlace token parsing and creation.
1983 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1984 This is much the same as DetailsPlaceTest.
1986 I wonder how we could test the other parts of the *Place API.
1988 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1990 DetailsPlace test: Also test getToken() and recreation via getPlace().
1992 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1993 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1994 recreate it, testing the recreated DetailsPlace for the same parameter
1997 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1999 Use the surefire-report plugin.
2001 * pom.xml: This generates a HTML report about the tests in
2002 target/site/surefire-report.html
2003 when you do mvn surefire-report:report. It seems to be popular/normal.
2005 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2007 Added a test for DetailsPlace.
2009 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2010 Test the getPlace() token parsing.
2012 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2014 Added a first unit test.
2016 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2017 * src/test/java/org/glom/web/shared/DataItemTest.java:
2018 This is a silly test but it is just to get things started. Note that
2019 maven/junit finds the test because it looks in src/test by default.
2021 2011-12-22 Ben Konrath <ben@bagu.org>
2023 Change charsetName to "UTF-8" when replacing line breaks.
2025 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2026 that work in Java (such as "UTF8") will not work when compiled to
2029 This fixes a problem with multi-line details view fields that have hard
2030 line breaks. The "License Text" field on this page demonstrates the
2033 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2035 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2037 2011-12-22 Ben Konrath <ben@bagu.org>
2039 Fix another bug with related list navigation.
2041 I've tested all the navigation buttons in all of the related lists
2042 so things should be good now.
2044 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2046 2011-12-22 Ben Konrath <ben@bagu.org>
2048 Fix a crasher when refreshing the list view with the default table.
2050 This crash will also happen when loading the list view with the default
2051 table from a link or bookmark.
2053 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2054 to the main document selection page when the document id hasn't been
2056 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2057 the main document selection page when the document id hasn't been
2059 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2060 values for the details place when the document id hasn't been set.
2061 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2062 values for the list place when the document id hasn't been set.
2064 2011-12-21 Ben Konrath <ben@bagu.org>
2066 Protect against NPE when glom.document.locale is not in config.
2068 This patch protects against an NPE when glom.document.locale is not in
2069 the config file. This NPE will also happen if glom.document.locale is
2072 The patch also updates the error message to display the class name when
2073 the getMessage() returns null. This was happening when the NPE was
2074 thrown and I had "Configuration Error: null". If an NPE is encountered
2075 with this patch, "Configuration Error: NullPointerException " will be
2078 This commit closes this bug:
2080 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2084 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2086 Rename onlineglom.properties to onlineglom.properties.sample.
2088 * src/main/resources/onlineglom.properties: Rename to:
2089 * src/main/resources/onlineglom.properties.sample:
2090 * src/main/resources/README: And add this file explaining that people
2091 should rename it back when deploying.
2093 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2095 Allow choosing the translation in the .properties file.
2097 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2098 init(): Read a glom.document.locale value from the configuration file
2099 and call Glom's TransatableItem::set_current_locale() method.
2100 * src/main/resources/onlineglom.properties: Add a commented-out
2101 example of this new setting.
2103 It would be better to add &lang=de_DE to the URL, but the current
2104 libglom API does not allow us to do this easily. I am working on that.
2106 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2108 Avoid a crash in parsing of token parameters.
2110 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2111 ava: getTokenParams(): Do not crash if a parameter has a key but no
2112 value, and ignore parameters with neither.
2114 2011-12-17 Murray Cumming <murrayc@murayc.com>
2116 History token building/handling: Improve use of token parameters.
2118 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2119 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2120 and buildParamsToken(HashMap), for use by derived classes.
2121 Make the separator private because it is no longer be needed.
2122 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2123 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2124 instead of manual string concatenation.
2125 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2126 of hardcoded indices and awkward splitting code.
2127 * src/main/java/org/glom/web/client/place/ListPlace.java
2128 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2129 instead of manual string concatenation.
2130 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2131 of hardcoded indices and awkward splitting code.
2132 This should fix bug #666420
2134 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2136 Fix a Navgiation->Navigation typo in the code.
2138 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2139 Rename processNavgiation() to processNavigation().
2141 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2143 Fix a seperator->separator typo in the code.
2145 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2146 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2147 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2150 2011-12-15 Ben Konrath <ben@bagu.org>
2152 Cleanup some comments.
2154 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2156 2011-12-14 Ben Konrath <ben@bagu.org>
2158 Replace \n with <br/> for multiline text in the details view.
2160 Vertical scrollbars are added when needed as well.
2162 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2164 2011-12-14 Ben Konrath <ben@bagu.org>
2166 Specify the font for document selection links.
2168 * src/main/webapp/style.css:
2170 2011-12-14 Ben Konrath <ben@bagu.org>
2172 Fix bouncy CellTable while paging.
2174 This doesn't currently work with related list tables in unselected
2177 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2179 2011-12-14 Ben Konrath <ben@bagu.org>
2181 Revamp the appearance of the document selection page.
2183 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2184 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2185 * src/main/webapp/style.css:
2187 2011-12-13 Ben Konrath <ben@bagu.org>
2189 Set navigation button column to the smallest size possible.
2191 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2193 2011-12-13 Ben Konrath <ben@bagu.org>
2195 Change OpenButton nomenclature to NavigationButton.
2197 Using NavigtionButton makes things more generic. Classes, methods and
2198 variables have been changed.
2200 This is a rename-only refactor.
2202 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2203 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2204 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2205 Renamed from OpenButtonCell.
2206 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2207 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2208 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2210 2011-12-12 Ben Konrath <ben@bagu.org>
2212 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2214 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2215 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2216 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2217 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2219 2011-12-12 Ben Konrath <ben@bagu.org>
2221 Update variable names and comments.
2223 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2224 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2226 2011-12-12 Ben Konrath <ben@bagu.org>
2228 Properly initialize numNonEmptyRows variable to zero.
2230 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2231 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2233 2011-12-05 Ben Konrath <ben@bagu.org>
2235 Add latest mockup with HTML tables.
2237 Features of this mockup:
2239 -> HTML table for flowtable
2240 -> HTML table for flowtable column
2241 -> Example of how related lists would look
2242 -> Not using text entries for data items
2244 The current version of Online Glom doesn't use HTML tables for the
2247 This mockup has been sent to the glom-devel mailing list but it's good
2248 to have it here as well.
2250 * mockups/details-view-html-tables.html:
2252 2011-12-05 Ben Konrath <ben@bagu.org>
2254 Remove unnecessary getPrimaryKeyField() method.
2256 getPrimaryKeyFieldForTable(String) has been renamed to
2257 getPrimaryKeyField(String).
2259 * src/main/java/org/glom/web/server/database/DBAccess.java:
2260 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2261 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2263 2011-12-05 Ben Konrath <ben@bagu.org>
2265 Add string representation of TypedDataItem value to conversion error message.
2267 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2268 message was extracted into its own method to avoid duplication.
2270 2011-12-05 Ben Konrath <ben@bagu.org>
2272 Add type checking to navigation primary key value creation.
2274 Create navigation primary key only if the expected type from the Glom
2275 document matches the type returned by the SQL query.
2277 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2279 2011-12-05 Ben Konrath <ben@bagu.org>
2281 Rename a couple of variables in RelatedListNavigation.
2283 This is a rename-only refactor.
2285 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2287 2011-12-05 Ben Konrath <ben@bagu.org>
2289 Move getListLayoutGroup() into getListViewLayoutGroup().
2291 This removes getListLayoutGroup(). It was only being called by
2292 getListViewLayoutGroup().
2294 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2296 2011-12-05 Ben Konrath <ben@bagu.org>
2298 Remove check for LayoutItem_Portal in list table method.
2300 This check is no longer necessary because the method isn't being used
2301 to create the LayoutItemPortal DTO.
2303 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2305 2011-12-05 Ben Konrath <ben@bagu.org>
2307 Properly support related list navigation.
2309 Navigation from the "Repository Analyzer -> Package Scans ->
2310 Dependencies" related table wasn't working because the primary key for
2311 related tables wasn't being set properly. This commit fixes the
2314 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2315 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2316 doesn't set the primary key properly for related list tables.
2317 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2318 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2319 useful for getting the primary key for list view tables and for related
2321 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2322 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2323 Move code to set the primary key for the table from the abstract
2324 ListDBAccess class to ListViewDBAccess as it's only correct for list
2326 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2327 Properly add primary key to related list tables.
2329 2011-12-02 Ben Konrath <ben@bagu.org>
2331 Properly set the horizontal alignment of fields.
2333 This fix is for both the list tables and the details view.
2335 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2336 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2337 to set the horizontal alignment of fields.
2339 2011-12-02 Ben Konrath <ben@bagu.org>
2341 Display currency codes in the details view.
2343 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2345 2011-12-02 Ben Konrath <ben@bagu.org>
2347 Avoid duplicate JNI call.
2349 JNI is not as efficient as pure Java and this is an easy (and small)
2352 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2353 Use previously retrieved value for whereClauseToTableName instead of
2356 2011-12-02 Ben Konrath <ben@bagu.org>
2358 Rename a couple of variables in RelatedListNavigation.
2360 This is a rename-only refactor.
2362 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2364 2011-12-02 Ben Konrath <ben@bagu.org>
2366 Indicate clearly that a mismatched primary key type is a bug.
2368 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2369 warning to error. Add 'This is a bug.' to message.
2371 2011-12-02 Ben Konrath <ben@bagu.org>
2373 Update / fix some comments.
2375 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2377 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2379 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2380 Fix comments. Add some TODOs.
2382 2011-12-02 Ben Konrath <ben@bagu.org>
2384 Enable navigation to details view with string primary key from related list.
2386 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2387 Create a text primary key value when return type of result is
2388 java.sql.Types.VARCHAR.
2390 2011-12-02 Ben Konrath <ben@bagu.org>
2392 Use checkboxes for booleans in the details view.
2394 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2396 2011-12-01 Ben Konrath <ben@bagu.org>
2398 Improve performance of related list height calculation.
2400 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2401 Put code to calculate the expected height in a static initializer so
2402 that that it's only called once.
2404 2011-12-01 Ben Konrath <ben@bagu.org>
2406 Show related list tables in notebooks (again).
2408 Calculate the height of the related list tables so the Notebook can be
2409 set the correct height. The height of the related list table is also needed by
2410 FlowTable to be able decide how to create the layout.
2412 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2413 and set the Portal height based on the height of the related list
2414 table and the Portal container.
2415 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2416 Add method to calculate the height of the related list tables.
2417 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2418 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2419 calculate the height of the Pager widget.
2421 2011-12-01 Ben Konrath <ben@bagu.org>
2423 Use CellTable API for table property instead of setting style on Element.
2425 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2427 2011-12-01 Ben Konrath <ben@bagu.org>
2429 Make ListViewTable and RelatedListTable a consistent height.
2431 The tables are now a consistent height regardless of the contents of
2432 the table. A hidden button is added to empty rows to ensure that the
2433 height of these rows will match the height of rows with data.
2435 A navigation button column is now added to every table. The width of
2436 the navigation column is set to 0px when a RelatedListTable shouldn't
2437 have navigation buttons. This maintains the a consistent row height in
2438 tables that don't show the navigation buttons.
2440 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2441 navigation column when not needed.
2442 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2443 arguments for navigation button to constructor of ListViewTable.
2444 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2445 hidden button for empty data rows.
2446 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2447 arguments for navigation button to constructor.
2448 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2449 create navigation buttons. Add hideNavigationButtons() method.
2450 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2451 arguments for navigation button to constructor.
2453 2011-12-01 Ben Konrath <ben@bagu.org>
2455 Use 'visibility: hidden' in Utils.getWidgetHeight().
2457 This is better choice because hidden elements are invisible, don't
2458 respond to events and are not part of the tab order. They will,
2459 however, take up space which is required to be able to calculate the
2460 height of the widget.
2462 * src/main/java/org/glom/web/client/Utils.java:
2464 2011-12-01 Ben Konrath <ben@bagu.org>
2466 Use Utils.getWidgetHeight() in FlowTable.
2468 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2470 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2472 2011-12-01 Ben Konrath <ben@bagu.org>
2474 Put the details css class name on the correct table column.
2476 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2478 2011-11-30 Ben Konrath <ben@bagu.org>
2480 Update for java-libglom API change.
2482 The getters and setters on FieldFormatting and NumericFormat were
2483 changed to remove the 'M'.
2485 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2487 2011-11-29 Ben Konrath <ben@bagu.org>
2489 Only allow RelatedListTables in Portals.
2491 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2493 2011-11-29 Ben Konrath <ben@bagu.org>
2495 Only create a contents panel for Portals when title is being set.
2497 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2499 2011-11-29 Ben Konrath <ben@bagu.org>
2501 Set TabLayoutPanel height based on calculated height its widgets.
2503 This is a potential fix for this bug:
2505 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2507 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2509 2011-11-29 Ben Konrath <ben@bagu.org>
2511 Align details field labels and data with the Open buttons.
2513 * src/main/webapp/style.css:
2515 2011-11-29 Ben Konrath <ben@bagu.org>
2517 Remove unnecessary <div> in the Notebook widget.
2519 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2520 method to get container FlowPanel (<div>).
2521 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2522 initWidget() method directly on the TabLayoutPanel widget instead of
2523 Group's container widget.
2525 2011-11-29 Ben Konrath <ben@bagu.org>
2527 Don't add group titles for Portals in Notebooks.
2529 This reverts the previous patch and fixes a bug I introduced with
2530 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2532 * src/main/java/org/glom/web/client/ui/details/Group.java:
2533 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2535 2011-11-28 Ben Konrath <ben@bagu.org>
2537 Remove unused boolean argument in Portal constructor.
2539 Just a code cleanup.
2541 * src/main/java/org/glom/web/client/ui/details/Group.java:
2542 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2544 2011-11-28 Ben Konrath <ben@bagu.org>
2546 Remove hack for glom 1.18 style glom files.
2548 * src/main/java/org/glom/web/client/ui/details/Group.java:
2549 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2550 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2552 2011-11-28 Ben Konrath <ben@bagu.org>
2554 Use Gda Value version of primary key to log result too large error.
2556 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2558 2011-11-28 Ben Konrath <ben@bagu.org>
2560 Don't use TypedDataItem.getText() for Unknown types from the URL.
2562 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2563 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2564 instead of getText().
2565 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2566 String field and getUnknown() method.
2568 2011-11-28 Ben Konrath <ben@bagu.org>
2570 Log an error message when the java-libglom .so is not present.
2572 The error message was being set in the exception but not logged.
2574 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2576 2011-11-28 Ben Konrath <ben@bagu.org>
2578 Ignore LayoutItem_CalendarPortals.
2580 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2581 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2583 2011-11-28 Ben Konrath <ben@bagu.org>
2585 Extract method for creating the LayoutItemPortal DTO.
2587 Just breaking the code up into smaller chunks.
2589 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2591 2011-11-28 Ben Konrath <ben@bagu.org>
2595 This should have been added with the refactor. Oops!
2597 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2599 2011-11-28 Ben Konrath <ben@bagu.org>
2601 Create primary key value from URL string using type from Glom document.
2603 See this bug, comments 19 - 25:
2605 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2607 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2608 create a TypeDataItem for the primary key here when loading from a
2609 URL. Show the same string for the primary key value as was received
2610 from the URL string (when loading from a URL).
2611 * src/main/java/org/glom/web/server/Utils.java: Update method for
2612 creating the Gda Value from the TypeDataItem to properly deal with
2613 creating a Gda Value based on the Glom document type for the primary
2614 key value string when loading from a URL.
2615 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2616 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2617 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2618 Update for changed method name.
2620 2011-11-27 Ben Konrath <ben@bagu.org>
2622 Rename PrimaryKeyItem to TypedDataItem.
2624 The name PrimaryKeyItem suggests what the class should be used for.
2625 TypedDataItem is a neutral name that describes the class better.
2627 This is a rename-only refactor.
2629 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2630 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2631 * src/main/java/org/glom/web/client/Utils.java:
2632 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2633 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2634 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2635 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2636 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2637 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2639 * src/main/java/org/glom/web/server/Utils.java:
2640 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2641 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2642 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2643 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2645 2011-11-25 Ben Konrath <ben@bagu.org>
2647 Improve Gda Value conversion from PrimaryKeyItem.
2649 The value from the PrimaryKeyItem is only used if its type match the
2650 type from the glom document.
2652 * src/main/java/org/glom/web/server/Utils.java:
2654 2011-11-25 Ben Konrath <ben@bagu.org>
2656 Manually check if the java-liblgom .so is visible to the JVM.
2658 It seems that Tomcat has problems when a static initializer throws an
2659 exception. This check is done before the first method call into
2660 java-libglom so that execution doesn't continue if the .so is not
2663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2665 2011-11-25 Ben Konrath <ben@bagu.org>
2667 Improve browser configuration error messages.
2671 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2673 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2674 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2675 getConfigurationErrorMessage() method.
2676 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2677 Get and display a specific configuration error message when no Glom
2678 documents are found.
2679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2680 Implement getConfigurationErrorMessage() method. Surround configuration
2681 code in the init() method with a try/catch block. This allows the
2682 errors to be caught while keeping the servlet available to retrieve the
2683 configuration error message.
2685 2011-11-25 Ben Konrath <ben@bagu.org>
2687 Don't use Strings to hold primary key values.
2689 The primary key values are now held in a new data object
2690 (PrimaryKeyItem) that holds type information and the primary key value
2691 using the correct type.
2693 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2694 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2696 PrimaryKeyItem instead of String to hold the primary key value.
2697 * src/main/java/org/glom/web/client/Utils.java: Remove
2698 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2699 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2700 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2701 PrimaryKeyItem instead of String to hold the primary key value. Load
2702 document selection page when the documentID has not been set correctly.
2703 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2704 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2706 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2707 Return empty string for URL instead of "null".
2708 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2709 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2710 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2711 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2712 PrimaryKeyItem instead of String to hold primary key values.
2713 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2714 PrimaryKeyValue to a Gda Value.
2715 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2716 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2717 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2718 Replace temporary database access code that uses the PrimaryKeyValue to
2719 Gda Value conversion.
2720 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2721 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2722 PrimaryKeyItem instead of String.
2723 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2724 hold primary key values.
2726 2011-11-24 Ben Konrath <ben@bagu.org>
2728 Use newly added java-libglom API to create queries.
2730 This isn't finished. I still need to stop using Strings for primary key
2731 values in the client code.
2733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2734 libglom to use fake connections so that retrieving the query string will
2736 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2737 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2738 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2739 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2740 Use the newly added libglom sql methods and classes to create the
2741 query. Add temporary hack to convert primary value strings to Gda
2744 2011-11-23 Ben Konrath <ben@bagu.org>
2746 Don't explicitly set the height of Portals.
2748 See comments 6 - 10 of this bug for details:
2750 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2752 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2754 2011-11-23 Ben Konrath <ben@bagu.org>
2756 Use an HTML table instead of CSS for the FlowTable layout.
2758 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2759 GWT's FlexTable to implement the FlowTable.
2760 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2762 2011-11-18 Ben Konrath <ben@bagu.org>
2764 Add boolean example to HTML table mockup.
2766 * mockups/details-view-html-tables-text-entries.html:
2768 2011-11-17 Ben Konrath <ben@bagu.org>
2770 Ensure the pager buttons are always visible for related lists.
2772 To accomplish this, I've turned off text wrapping in the list view and
2773 related list tables for both the header and data text. The related list
2774 table now has a fixed layout so the it doesn't overflow its container.
2775 This is required to ensure that the cell text is clipped when it
2776 overflows the cell and an ellipsis is added to the right side of the
2777 cell when text is clipped.
2779 A fixed table layout for the related list table in the details view
2780 seems what we want for the details view anyway, so the side-effect is
2783 The ellipsis will only be displayed in Firefox >= 7.
2787 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2789 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2790 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2791 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2793 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2794 Set the 'table-layout: fixed' CSS property to the related list table.
2795 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2796 'white-space: nowrap;' CSS property on both the list view and the
2797 related list tables.
2799 2011-11-16 Ben Konrath <ben@bagu.org>
2801 Rework the fix for empty notebook tab labels.
2803 Setting the empty group titles with its name caused problems for the
2804 details layout. Instead of using libglom's
2805 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2806 to the client when the title is empty. This allows the Notebook to use
2807 the name when the title is empty without affecting anything else.
2809 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2810 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2812 2011-11-16 Ben Konrath <ben@bagu.org>
2814 Set group titles with name when title is empty.
2816 This fixes a problem with an empty notebook tab label in the Lesson
2817 Planner document. The forth tab in the notebook should be "Internet":
2819 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2821 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2822 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2825 2011-11-16 Ben Konrath <ben@bagu.org>
2827 Remove whitespace from the configured username properties.
2829 This assumes that usernames won't have whitespace at the beginning
2830 or end. But I think this is a reasonable assumption.
2832 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2833 String.trim() to remove the whitespace from the username properties.
2835 2011-11-15 Ben Konrath <ben@bagu.org>
2837 Add details view mockup with HTML tables and text entries.
2839 This is from the attachment on this bug:
2841 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2843 * mockups/details-view-html-tables-text-entries.html:
2845 2011-11-15 Ben Konrath <ben@bagu.org>
2847 Add space between the columns of the flow table.
2851 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2853 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2854 space between columns in the flow table.
2856 2011-11-15 Ben Konrath <ben@bagu.org>
2858 Add backup files to the .gitignore.
2860 * .gitignore: Ignore files that end with ~.
2862 2011-11-09 Ben Konrath <ben@bagu.org>
2864 Use latest release of gwt-log.
2866 Gwt-log releases are now being submitted to the maven central
2867 repository so manual installation of the jar is no longer required.
2869 * pom.xml: Update version and groupId of gwt-log dependency.
2871 2011-10-31 Ben Konrath <ben@bagu.org>
2873 Don't use GWT numeric formatting to override the glom currency formatting.
2875 Currencies are now displayed like they are in Glom. See this bug:
2877 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2879 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2881 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2882 currency code to constructor and set it when the cell is rendered.
2883 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2884 currency code to the constructor of the NumericCell.
2886 2011-10-27 Ben Konrath <ben@bagu.org>
2888 Require the latest release of java-libglom (1.17.4).
2892 2011-10-26 Ben Konrath <ben@bagu.org>
2894 Add style to Notebook that matches current theme.
2896 It's not the best style in the world but it's better than the default.
2898 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2899 padding at the bottom of the child widgets.
2900 * src/main/webapp/style.css: Add style for the Notebook.
2902 2011-10-26 Ben Konrath <ben@bagu.org>
2904 Move servlet initialization code to overridden init method.
2906 This is half of the solution to getting proper error messages
2907 displayed when configuration errors occur. Here's the relevant bug:
2909 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2911 The rest of the solution involves surrounding the init method with a
2912 try/catch block and setting a global variable with the error /
2913 exception. A new async method should be created to retrieve and display
2914 the error message / exception.
2916 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2917 code from constructor to init method adding exceptions as needed.
2919 2011-10-26 Ben Konrath <ben@bagu.org>
2921 Add script to monitor and restart tomcat if required.
2923 * utils/check-and-recover-tomcat.py: New file.
2925 2011-10-26 Ben Konrath <ben@bagu.org>
2927 Display the correct number of data items in the pager.
2931 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2933 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2934 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2935 The implementation is the same for both tables: Keep track of the
2936 number of non-empty rows and fire and RowCountChangeEvent after the data has
2938 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2939 custom Pager class that subclasses SimplePager to handle displaying
2940 the correct number when empty rows have been added.
2942 2011-10-26 Ben Konrath <ben@bagu.org>
2944 Correct error in previous commit.
2946 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2947 eventBus parameter from listView.setCellTable().
2949 2011-10-26 Ben Konrath <ben@bagu.org>
2951 Fix error in TODO comment.
2953 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2955 2011-10-24 Ben Konrath <ben@bagu.org>
2957 Create Notebook widgets to the details view.
2959 This isn't finished just yet - I still need to create a reasonable
2960 style to match the current theme.
2962 * src/main/java/org/glom/web/client/Utils.java: Add method for
2963 calculating the height of a widget. This is used in the Notebook class.
2964 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2965 new constructor method in Group.
2966 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2967 method for creating child widget that can be used by subclasses
2968 like Notebook. New constructor that allows disabling the group
2969 titles - Notebooks don't set a group title for their child groups.
2970 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2971 to make Notebooks using GWT's TabLayoutPanel.
2972 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2973 constructor that allows disabling the group titles.
2974 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2975 LayoutItemNotebook DTO.
2976 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2977 DTO for Notebooks. It's just an empty class for now but we might need
2978 it to transfer some specific information in the future.
2980 2011-10-21 Ben Konrath <ben@bagu.org>
2982 Add navigation buttons to related list tables.
2984 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2985 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2987 method getSuitableRecordToViewDetails() for getting the table name
2988 and primary key value for related list navigation buttons.
2989 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2990 private cell renderer class to get the navigation information for
2991 related list tables from the server. Extract the navigation
2992 processing code from the details cell navigation and use it for the
2993 related list navigation as well.
2994 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2995 cell renderer class for the details open buttons. This was needed
2996 because the related list navigation buttons and the list view
2997 navigation buttons need to react differently when clicked.
2998 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2999 the onEnterKeyDown() method because it's now overriden in the
3000 subclasses that are specific to the related list tables and the list
3002 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
3003 the vertical size a little because the buttons add a bit of vertical
3004 space to table. This is not a perfect solution because the vertical
3005 size of with table fewer than 5 rows will be a little smaller.
3006 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
3007 changes in how navigation buttons are handled.
3008 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
3009 getSuitableRecordToViewDetails() using the new RelatedListNavigation
3010 database access object.
3011 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
3012 to find the portal for a given relationship name from
3013 RelatedListDBAccess. Add method to find a primary key field for a
3015 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3016 Move code to find the portal for a given relationship name to
3018 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
3019 New file: database access object for getting the related list
3020 navigation information (the table name and the primary key value).
3021 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
3022 DTO for transferring a table name to navigate to and a primary key
3024 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3025 boolean and getter/setter to specifies if the related list should add
3028 2011-10-24 Murray Cumming <murrayc@murrayc.com>
3030 Use the master branch of java-libglom
3032 * pom.xml: Depend on java-libglom 1.19 instead.
3034 This is the master branch. See also the libglom-1-18 branch.
3036 2011-10-11 Ben Konrath <ben@bagu.org>
3038 Enable the open navigation button when the data has been set.
3040 This avoids having active buttons that don't do anything when the data
3043 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3045 2011-10-11 Ben Konrath <ben@bagu.org>
3047 Use IsWidget interface for FlowTableItem.
3049 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
3050 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
3052 2011-10-11 Ben Konrath <ben@bagu.org>
3054 Remove GWT styling from open button in details view.
3056 There are still some issues with how the details cell is arranged but
3057 this should be made to match Glom 1.20. I'm going to leave fixing this
3058 until I have Glom 1.20 up and running.
3060 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
3061 style name on open button.
3062 * src/main/webapp/style.css: Move and edit details-navigation class.
3063 Re-arrange some classes to make them appear in the same order as the
3066 2011-10-07 Ben Konrath <ben@bagu.org>
3068 Update to GWT 2.4.0.
3070 * .gitignore: Ignore new cache directory.
3071 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3072 * pom.xml: Change GWT and maven plugin to 2.4.0.
3073 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3075 * src/main/java/org/glom/web/client/ClientFactory.java:
3076 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3077 * src/main/java/org/glom/web/client/OnlineGlom.java:
3078 Update source for API changes.
3079 * utils/build-onlineglom-war.sh: Remove cache directory before the
3082 2011-10-07 Ben Konrath <ben@bagu.org>
3084 Add navigation buttons in the details view.
3086 This isn't finished but I thought I'd commit what I have as it's a
3087 pretty good start. I still need to:
3089 1. Change the style so that it fits better into the current theme
3090 2. Adjust the details cell to expand as much as possible.
3092 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3093 click handlers to navigation buttons in the DetailsCells. Create a
3094 refreshData() method to get just the data from the server without the
3096 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3097 Update the tableSelector and browser title when the table name
3098 changes without using the tableSelector.
3099 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3100 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3101 getDetailsCells() to getCells(). Update variable names.
3102 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3103 method to set click handler on navigation button. Rename a few
3104 variables. Add navigation buttons where needed.
3105 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3106 variables and methods.
3107 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3108 navigation boolean and navigation table as required in the
3109 LayoutItemField DTO.
3110 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3111 variables for navigation along with getter/setter methods.
3113 2011-10-07 Ben Konrath <ben@bagu.org>
3115 Rename Field to DetailsCell.
3117 This is a refactor-only commit. No functionality has been added or
3120 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3121 Update variable and method names.
3122 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3123 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3124 variable and method names.
3125 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3127 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3128 variable and method names.
3130 2011-10-07 Ben Konrath <ben@bagu.org>
3132 Create separate methods for layout and data the details view.
3134 This is a refactor-only commit. No functionality has been added or
3137 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3138 private methods: setData(), createLayout().
3140 2011-10-07 Ben Konrath <ben@bagu.org>
3142 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3144 This is part of a change to get navigation buttons in the details view
3145 but it should have been done this way from the start.
3147 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3148 for method name change in TableSelectionView.
3149 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3150 Create TableChangeEvent and set the browser title using the
3151 TableSelectionView API.
3152 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3153 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3154 Change getSelectedTable() to getSelectedTableName(). Add
3155 getSelectedTableTitle().
3157 2011-10-07 Ben Konrath <ben@bagu.org>
3159 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3161 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3163 2011-10-07 Ben Konrath <ben@bagu.org>
3165 Update TableChangeEvent to use newTableName naming convention.
3167 This makes the class more consistent with GWT naming conventions.
3169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3170 Update for method name change in TableChangeEvent.
3171 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3172 for method name change in TableChangeEvent.
3173 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3174 newTableName variable and getter method. Make toDebugString()
3177 2011-09-30 Ben Konrath <ben@bagu.org>
3179 Disable the pager in the list tables when the data row count is less than the minimum.
3181 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3182 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3184 2011-09-30 Ben Konrath <ben@bagu.org>
3186 Add empty rows to the end of related list and list view tables.
3188 I also extracted the cell rendering classes from the ListTable because
3189 the code was becoming a little crazy with all the anonymous inner
3190 classes. My plan is to use these cell rendering classes in the details
3191 view as well so this refactor will be needed for that change.
3193 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3194 set the row count in related list tables if the data has more rows
3195 than the minimum number of rows visible.
3196 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3197 row count in list view tables if the data has more rows than the
3198 minimum number of rows visible.
3199 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3200 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3202 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3203 for rendering TYPE_NUMERIC cells. The code was extracted from the
3205 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3206 class for rendering cells with buttons in list views. The code was
3207 extracted from the ListTable class.
3208 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3209 for rendering TYPE_TEXT cells. The code was extracted from the
3211 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3212 Add empty rows to the end of the data if required. Implement
3213 ListTable.getMinNumVisibleRows().
3214 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3215 cell renderer code to public classes. Return null in
3216 Column.getValue() for empty rows. Add new abstract method:
3217 getMinNumVisibleRows(). Move code to set the row count of the list view
3218 table to ListViewImpl.
3219 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3220 empty rows to the end of the data if required. Implement
3221 ListTable.getMinNumVisibleRows().
3224 2011-09-27 Ben Konrath <ben@bagu.org>
3226 Use GWT.log for client-side debugging statements.
3228 These are optimized out when deployed so I should have used this method
3229 in the first place. These statements will eventually be replaced with some sort
3230 of notification in the browser.
3232 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3233 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3234 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3235 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3236 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3238 2011-09-27 Ben Konrath <ben@bagu.org>
3240 Put tableselector on the right, back to list link on right.
3242 The idea is that the table selector is acting like a label for the
3243 currently displayed table so it should be placed below the document title. This
3244 puts the table title in a similar position to where it is in Glom.
3246 * mockups/details-contacts.html:
3247 * mockups/details-projects.html:
3248 * mockups/listview-contacts.html:
3249 * mockups/listview-projects.html:
3250 * mockups/style.css:
3251 Update mockups to match how the interfaces currently look.
3252 * src/main/webapp/style.css: Swap positions of backlink with the table
3253 selector. Add some space on the left side of the table selector to
3254 line things up with the document title.
3256 2011-09-27 Ben Konrath <ben@bagu.org>
3258 Add field colouring to details view.
3260 This change re-works how field colouring works. The colour formatting
3261 information is now set to the client with the layout information instead of
3262 with the data. This eliminates the need to send the same colour strings for
3263 data in list view column when colour information is set.
3265 In order to set an alternate colour for negative numeric values, the
3266 number is now sent to client and formatted with&nb