1 2012-05-20 Murray Cumming <murrayc@murrayc.com>
5 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
6 Added getTranslationsMap() for use while saving.
7 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
8 Adedd getUseDefaultFormatting() for use while saving.
9 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
10 and several private methods that it uses.
12 This will be useful while testing via self-hosting.
13 It is not complete, but should be complete enough for testing.
15 2012-05-17 Murray Cumming <murrayc@murrayc.com>
17 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
19 * src/main/java/org/glom/web/client/OnlineGlomService.java
20 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
21 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
22 Remove getSortedListViewData() and getSortedRelatedListData(), adding
23 the sort column index and ascending bool to the regular method.
24 Instead, a sort column index of -1 now means no sort.
25 This is less explicit, but it's fairly simple, reduces the amount of
26 code, and makes the OnlineGlomService API slightly smaller.
27 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
28 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
30 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
31 getListViewData(), getRelatedListData():
32 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
33 getListViewData(), getRelatedListData():
34 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
36 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
38 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
43 2012-05-16 Murray Cumming <murrayc@murrayc.com>
45 Use translations for top-level groups too.
47 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
48 updateTitlesForLocale(): Use the translation for the group
49 as well as for child items.
53 Just recompiled to fix a problem in the released .tar.gz file.
57 2012-05-15 Murray Cumming <murrayc@murrayc.com>
59 Corrections to navigation to related records.
61 * src/main/java/org/glom/web/client/OnlineGlomService.java:
62 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
63 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
64 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
65 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
66 relationship name, because the relationship name is not necessarily unique
68 TOOD: This is inefficient, because it passes the whole list of
69 child field items back to the server, but it is more correct, and happens
70 to fix a bug with the primary key being lost after a few navigations.
71 There is probably a chance to make this more efficient anyway in some
74 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
75 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
76 * src/main/java/org/glom/web/server/ConfiguredDocument.java
77 * src/main/java/org/glom/web/server/database/DBAccess.java
78 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
79 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
82 2012-05-15 Murray Cumming <murrayc@murrayc.com>
84 Fix the use of translations.
86 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
87 Add updateTitlesForLocale().
88 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
89 Call it to discard unwanted translations and to make getTitle() return
90 the wanted translation wihout the need for the client code to specify a locale.
91 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
92 getTitle(): Fallback to the original title, as libglom does.
94 2012-05-15 Murray Cumming <murrayc@murrayc.com>
96 Document: Correctly report the number of available translation locales.
98 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
99 the available locale IDs list.
100 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
101 testLocales: Test this.
103 2012-05-15 Murray Cumming <murrayc@murrayc.com>
105 SqlUtils: Use camelCase.
107 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
108 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
109 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
110 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
111 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
112 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
114 2012-05-15 Murray Cumming <murrayc@murrayc.com>
116 Use jOOQ's tableByName() and fieldByName.
118 * pom.xml: Use jOOQ 2.3.1 to get the new API.
119 * src/main/java/org/glom/web/server/SqlUtils.java:
120 build_sql_select_step_with_where_clause(), .createField(),
121 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
122 so we can get correct quoting and escaping. Thanks to Lukas Eder for
123 adding this, and other things, to jOOQ.
125 2012-05-15 Murray Cumming <murrayc@murrayc.com>
127 SqlUtils: Remove the Connection parameters.
129 * src/main/java/org/glom/web/server/SqlUtils.java:
130 build_sql_select_with_key(), build_sql_select_with_where_clause(),
131 createSelect(), build_sql_select_step_with_where_clause(),
132 build_sql_count_select_with_where_clause(),
133 build_sql_select_count_rows(): Remove the Connection parameter because
134 jOOQ does not actually need a connectionwhen it is just used to build
136 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
138 * src/main/java/org/glom/web/server/ReportGenerator.java:
140 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
142 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
143 Constructor, getListData(), getResultSizeOfSQLQuery():
144 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
145 getSelectQuery(), getCountQuery():
146 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
147 getSelectQuery(), getCountQuery():
148 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
149 getNavigationRecord(): Adapted.
151 2012-05-14 Murray Cumming <murrayc@murrayc.com>
155 * src/main/java/org/glom/web/server/SqlUtils.java:
156 get_find_where_clause_quick(): Use a comparison of
157 lowercase values, instead of a simple equals. Regular Glom
158 uses the PostgreSQL ILIKE operator but jOOQ does not
159 support that just yet, though it will soon.
161 2012-05-14 Murray Cumming <murrayc@murrayc.com>
163 TableToViewDetails: Use a real serialization ID.
165 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
166 Though this does not fix the serialization problem.
168 2012-05-12 Murray Cumming <murrayc@murrayc.com>
170 Added LayoutItemPortalDeepCloneTest.
172 2012-05-11 Murray Cumming <murrayc@murrayc.com>
174 Make navigation work again.
176 * src/main/java/org/glom/web/server/libglom/Document.java:
177 Add getLayoutItemFieldShouldHaveNavigation().
178 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
179 Replace get/setAddNavigation() with the partly-existing
180 get/setNavigationTableName(), with an empty string being no navigation,
181 because this is simpler. Use the new
182 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
184 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
185 Add updateFieldsExtras() and call setNavigationTableName in it.
186 getDetailsLayoutGroup(),
187 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
188 createLayout(): Adapted.
189 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
190 Constructor: Adapted.
192 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
193 Replace get/setAddNavigation() with get/setNavigation(), returning a
194 TableToViewDetails class with both the table name and UsesRelationship,
195 because both are need. The previous code used java-libglom's output
196 variable (strangely, via sharedptr) to return both, but we cannot really
198 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
199 getNavigationRecord(): Adapt. However, we cannot actually use the cache
200 here because it somehow gets set to null during deepCopy(). I must test this.
201 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
202 testGetSuitableTableToViewDetails(): Adapted.
204 TODO: Find out why deepClone() is not quite working.
206 2012-05-11 Murray Cumming <murrayc@murrayc.com>
208 DBAccess: Simplify the retrievel of full field details.
210 * src/main/java/org/glom/web/server/database/DBAccess.java
211 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
212 because the Document loading should have done this.
214 2012-05-11 Murray Cumming <murrayc@murrayc.com>
216 Document: Correct loading of doubly-related layout fields.
218 * src/main/java/org/glom/web/server/libglom/Document.java:
219 loadUsesRelationship(): Actually set the related relationship, instead
220 of only setting it if it's not found.
222 2012-05-09 Murray Cumming <murrayc@murrayc.com>
224 Replace all appearances of Colour with color.
226 Because US English is dominant.
228 2012-05-09 Murray Cumming <murrayc@murrayc.com>
230 Use colors in HTML format, solving a warning about an unused function.
232 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
233 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
234 Add *asHTMLColor() versions of methods.
235 TODO: However, we should create and cache the results on the server.
236 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
237 * src/main/java/org/glom/web/client/ui/list/ListTable.java
238 * src/main/java/org/glom/web/server/ConfiguredDocument.java
239 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
240 Use the asHTMLcolor() versions.
242 2012-05-09 Murray Cumming <murrayc@murrayc.com>
244 ListViewTable: Constructor: Take the table name as a parameter.
246 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
247 Constructor: Take the tableName, and set the member variable, because
249 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
250 setCellTable(): Pass the table name.
251 This makes navigation to non-default tables work again. I don't know
252 why it worked before in the master branch.
254 2012-05-07 Murray Cumming <murrayc@murrayc.com>
256 ConfiguredDocument: Restore correct addition of hidden primary key items.
258 * src/main/java/org/glom/web/client/ui/list/ListTable.java
259 (ListTable.createCellTable): Uncomment out the check for the hidden
261 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
262 add primary key items for top-level lists and portals, as before,
263 instead of adding them to each group.
264 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
265 Actually implement the extra methods such as setHiddenPrimaryKey() and
266 comment that these are used only for top-level list groups and in portals.
267 This strangeness suggests even more that this should not be squeezed
268 into the LayoutGroup class.
270 2012-05-07 Murray Cumming <murrayc@murrayc.com>
272 Fix Formatting loading.
274 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
275 getFormattingUsed(): Remove the duplicate Formatting member variable
276 in favour of the one from the base class.
277 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
278 Initialize a new Formatting instead of using null by default, so we
279 have some defaults, instead of having to initialize one later just to
280 get the same defaults. This also makes loading of formatting from the
281 document work, because that expected a non-null.
283 2012-05-07 Murray Cumming <murrayc@murrayc.com>
285 RelatedListTable: Make sure that the tableName is set.
287 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
288 Constructor: Take the tableName so it is available later. Otherwise,
289 the server assumes that we mean the default table and cannot find the
291 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
292 setData(): Pass the tableName to the RelatedListTable constructor.
294 2012-05-07 Murray Cumming <murrayc@murrayc.com>
298 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
299 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
300 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
302 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
304 * src/main/java/org/glom/web/server/database/DBAccess.java:
305 convertResultSetToDTO(), getPortal():
306 * src/main/java/org/glom/web/server/database/ListDBAccess.java
308 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
309 Add checks for null objects and out of range access, with log messages to
310 give hints so we can fix these properly.
312 2012-05-07 Murray Cumming <murrayc@murrayc.com>
314 Portals: some corrections.
316 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
318 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
319 constructor: Use getRelationshipNameUsed() instead of getName(), because
320 that is what is meant.
321 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
322 getFromField(): Fix a typo, to get the field name, not the table name.
323 * src/main/java/org/glom/web/server/database/DBAccess.java:
324 getPortal(): Fix a typo that stopped this from working.
326 2012-05-07 Murray Cumming <murrayc@murrayc.com>
328 LayoutItemPortal: Also override getTitleOriginal().
330 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
331 This lets the base getTitle() with no parameters work.
332 TODO: Test this properly.
334 2012-05-06 Murray Cumming <murrayc@murrayc.com>
336 LayoutItemPortal: getTitle*(): Use the relationship title.
338 2012-05-06 Murray Cumming <murrayc@murrayc.com>
340 LayoutItemField: Fix loading of custom titles.
342 * src/main/java/org/glom/web/server/libglom/Document.java
343 loadDataLayoutItemField(): The title, if any, instead of the field
344 title, is stored in a title_custom node. Load it from there.
345 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
347 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
348 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
349 getTitle*() overrides.
350 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
353 2012-05-06 Murray Cumming <murrayc@murrayc.com>
355 LayoutItemField: Fall back to field titles, so some are really shown.
357 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
358 Override getTitleOriginal() and getTitle(), as in java-libglom.
359 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
362 2012-05-06 Murray Cumming <murrayc@murrayc.com>
364 Correct use of setExpectedResultSize().
366 * src/main/java/org/glom/web/server/ConfiguredDocument.java
367 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
368 Use setExpectedResultSize only on top-level groups (for instance, the
369 list layout) or on child portals (in details views).
370 Use the correct table name for portals to avoid SQL errors.
371 Update the expected counts when returning cached layouts.
373 2012-05-06 Murray Cumming <murrayc@murrayc.com>
375 Document: Interpret no group column count as 1.
377 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
378 default, though we now check for this in the UI code anyway.
380 2012-05-06 Murray Cumming <murrayc@murrayc.com>
384 2012-05-06 Murray Cumming <murrayc@murrayc.com>
386 Translatable: Use Hashmap instead of Treemap because GWT supports it.
388 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
389 The use of Treemap lead to this error from async methods, with no
391 "The response could not be deserialized"
393 2012-05-06 Murray Cumming <murrayc@murrayc.com>
395 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
397 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
398 when using the Google -> GWT Compile, or
399 g toolbar button -> GWT Compile Project... feature in Eclipse.
401 2012-05-06 Murray Cumming <murrayc@murrayc.com>
403 ListTable.addColumn(): Protect against a null Formatting.
405 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
406 Create a default Formatting if it is null, because that is the simplest
409 2012-05-06 Murray Cumming <murrayc@murrayc.com>
411 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
413 * src/main/java/org/glom/web/server/ConfiguredDocument.java
414 updateLayoutGroup(): Check that the field is not null.
416 2012-05-06 Murray Cumming <murrayc@murrayc.com>
418 ListViewImpl: Protected against a bad cast error.
420 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
421 onEnterKeyDown(): Do not cast without an instanceof check.
423 2012-05-06 Murray Cumming <murrayc@murrayc.com>
425 ListTable: Protect against an out of range error.
427 * src/main/java/org/glom/web/client/ui/list/ListTable.java
428 createCellTable(): This is unlikely, but can happen while debugging.
430 2012-05-06 Murray Cumming <murrayc@murrayc.com>
432 AsyncMessage onFailure() callbacks: Log the exception message.
434 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
435 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
436 * src/main/java/org/glom/web/client/activity/ListActivity.java:
437 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
438 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
439 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
440 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
441 These are useful clues when something is wrong.
443 2012-05-06 Murray Cumming <murrayc@murrayc.com>
445 ConfiguredDocument: Avoid a null dereference.
447 * src/main/java/org/glom/web/server/ConfiguredDocument.java
448 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
449 details maps are created.
451 2012-05-06 Murray Cumming <murrayc@murrayc.com>
453 Document: Correct the port number parsing.
455 * src/main/java/org/glom/web/server/libglom/Document.java:
456 This lets us actually connect to the database and show the document.
458 2012-05-05 Murray Cumming <murrayc@murrayc.com>
462 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
463 user-interaction, asking us to load a temporary URL in a browser.s
464 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
465 which is apparently necessary for testing the service. See the comment.
466 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
467 Show the exception, if any. This is how I saw the 404 in the HTML in
470 2012-05-05 Murray Cumming <murrayc@murrayc.com>
472 DocumentTest: Move the .glom files into the resources directory.
474 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
475 URI via getResource().
477 2012-05-05 Murray Cumming <murrayc@murrayc.com>
479 Document: Remove the FieldIdentifies inner class.
481 * src/main/java/org/glom/web/server/libglom/Document.java: We only
482 use the Relationship (though the same function in libglom is maybe
483 used in other ways) and so this removes a compiler warning.
485 2012-05-05 Murray Cumming <murrayc@murrayc.com>
487 Document.load() Remove the error code parameter.
489 * src/main/java/org/glom/web/server/libglom/Document.java: load():
490 Remove the parameter. We do not set it yet and it could never have
491 worked as an output parameter (though maybe it did in java-libglom).
492 We could use an exception if we really want the failure reason.
493 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
495 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
496 setUp(), testGetSuitableTableToViewDetails(): Adapt.
498 2012-05-05 Murray Cumming <murrayc@murrayc.com>
500 Make some inner classes static.
502 * src/main/java/org/glom/web/server/ConfiguredDocument.java
503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
504 * src/main/java/org/glom/web/server/ReportGenerator.java
505 * src/main/java/org/glom/web/server/libglom/Document.java
506 Make all inner classes static that can be static.
508 2012-05-05 Murray Cumming <murrayc@murrayc.com>
510 OnlineGlomServiceImpl: Do not load and check for java-libglom.
512 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
513 init(): We do not use java-libglom any more.
515 2012-05-05 Murray Cumming <murrayc@murrayc.com>
517 Remove mentions of java-libglom.
519 * README: Remove mention of java-libglom, because it no longer needed.
520 * utils/build-onlineglom-war.sh:
521 * utils/check-and-recover-tomcat.py:
522 * utils/install-onlineglom-war.sh: Remove these as they are no longer
523 useful. Building is now far easier, with no need for jhbuild.
525 2012-05-05 Murray Cumming <murrayc@murrayc.com>
527 Fix the build (mvn package)
529 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
530 (LayoutGroup): Make the LayoutItemList inner class static and protected.
531 Otherwise the GWT Java->Javascript compilation fails with just this
532 error, during mvn package or when attempting to view in a browser,
533 in the GWT developer mode in Eclipse.
535 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
536 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
537 [INFO] Compiling module org.glom.web.OnlineGlom
538 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
539 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
540 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
541 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
542 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
543 [INFO] [ERROR] Cannot proceed due to previous errors
545 It has taken me 2 days to find out what was causing that. After reducing
546 the code, the compiler eventually showed me the full error message.
548 2012-05-04 Murray Cumming <murrayc@murrayc.com>
550 ConfiguredDocument: Cache the cloned and stripped layouts.
552 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
553 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
554 layout in a map, so we can retrieve it again without rebuilding it.
556 2012-05-04 Murray Cumming <murrayc@murrayc.com>
558 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
560 2012-05-04 Murray Cumming <murrayc@murrayc.com>
562 libglom classes: Implement some auto-generated emthods.
564 2012-05-04 Murray Cumming <murrayc@murrayc.com>
566 Add GwtTestOnlineGlomService.
568 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
569 However, this (and the other GwtTest*) does not seem to run during
572 2012-05-04 Murray Cumming <murrayc@murrayc.com>
574 Remove use of unsupported features from client code.
576 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
577 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
578 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
579 Use our client version of StringUtils instead of the apache commons one.
581 However, the GWT Javascript compliation still fails.
583 2012-04-25 Murray Cumming <murrayc@murrayc.com>
585 Add a Field class and implement some loading of it in Document.
587 2012-04-25 Murray Cumming <murrayc@murrayc.com>
589 Initial Document loading implementation, instead of libglom.
591 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
592 and Translatable classes, and adapt the rest of the code to use them.
593 However, this is still missing Layout and Field classes and loading.
595 2012-04-24 Murray Cumming <murrayc@murrayc.com>
597 Use of jOOQ: Move Field creation into a utility method.
599 * src/main/java/org/glom/web/server/SqlUtils.java:
600 This lets us improve it more easily.
602 2012-04-24 Murray Cumming <murrayc@murrayc.com>
604 Use of jOOQ: Improve the code to COUNT a sub-select.
606 * src/main/java/org/glom/web/server/SqlUtils.java:
607 Move initial query creation into
608 build_sql_select_step_with_where_clause().
609 build_sql_select_count_rows(): Use the jOOQ API instead of
610 concatentating text, because a jOOQ Select*Step is a TableLike,
611 which is what from() takes.
613 2012-04-23 Murray Cumming <murrayc@murrayc.com>
615 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
617 * pom.xml: Depend on jooq.
618 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
619 methods with jOOQ, based on the C++ implementations in libglom,
620 with some changes to the logic required by jooQ.
621 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
623 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
624 * src/main/java/org/glom/web/server/ReportGenerator.java:
625 * src/main/java/org/glom/web/server/SqlUtils.java:
626 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
627 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
628 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
629 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
630 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
631 Adapt. In particular, the SqlUtils methods now need to take a Connection,
632 because jOOQ needs that, though it seems unnecessary.
634 This is not quite finished. Ideally jOOQ would help us to build
635 table_name.field_name names, quoting and escaping them properly.
636 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
638 2012-04-21 Murray Cumming <murrayc@murrayc.com>
640 Move use of Glom.build_sql*() into a new SqlUtils class.
642 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
643 to wrap Glom.build_sql*(). The parameter types are still Glom one,
644 but this will make it easier to start using something other than
645 libglom or SqlBuilder.
647 2012-04-21 Murray Cumming <murrayc@murrayc.com>
649 Update the project URL.
651 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
653 2012-04-21 Murray Cumming <murrayc@murrayc.com>
655 Main layout: Use a FlowTable instead of absolute positioning.
657 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
658 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
659 child panels/widgets must have an absolute position. But that is annoying, so
660 this adds a FlowTable and puts the child panels in there.
662 2012-04-21 Murray Cumming <murrayc@murrayc.com>
664 GwtTestOnlineGlom: Comment out unused code.
666 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
667 Eclipse has started to say that some code is unused.
669 2012-04-21 Murray Cumming <murrayc@murrayc.com>
671 Update to the latest versions of dependencies.
673 * pom.xml: Update version numbers of dependencies to the latest
675 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
677 * src/main/java/org/glom/web/server/ReportGenerator.java:
678 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
679 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
680 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
682 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
683 Modify the imports where necessary.
685 2012-04-17 Murray Cumming <murrayc@murrayc.com>
687 Style: Remove overflow:hidden from searchbox
689 * src/main/webapp/style.css: Because this pushes the Back To Link
690 label/link on to the next row, which is then hidden due to the
691 hard-coded (in ems) height.
693 2012-04-20 Murray Cumming <murrayc@murrayc.com>
695 Remove some duplicate code.
697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
698 getDocumentInfo(): This must have been duplicated during the merge from the
703 2012-04-19 Murray Cumming <murrayc@murrayc.com>
705 Reports: Localize the waiting for report message.
707 * src/main/java/org/glom/web/client/activity/ReportActivity.java
708 start(): Get the message from the contants.
709 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
711 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
712 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
713 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
714 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
715 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
716 Update these files with the English text for newer strings for now.
718 2012-04-19 Murray Cumming <murrayc@murrayc.com>
720 Reports: Show a message while waiting for the report.
722 * src/main/java/org/glom/web/client/ui/ReportView.java
723 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
724 Add setWaitingText(), to show a message saying that we are
725 waiting for the report to be ready.
726 * src/main/java/org/glom/web/client/activity/ReportActivity.java
727 start(): Call setWaitingText() before calling the async
730 2012-04-19 Murray Cumming <murrayc@murrayc.com>
732 ReportGenerator: Specify date and time formats.
734 * src/main/java/org/glom/web/server/ReportGenerator.java:
735 createFieldValueElement(): Use the default (and localized)
736 short formats, though we still need a way to show 4-digit
737 years without providing the format for every locale.
738 * src/main/java/org/glom/web/server/database/DBAccess.java:
739 convertResultSetToDTO(): Use the short formats here too.
741 2012-04-18 Murray Cumming <murrayc@murrayc.com>
743 ReportGenerator: Use the correct numeric formatting.
745 * src/main/java/org/glom/web/server/ReportGenerator.java
746 createFieldExpression(), createFieldValueElement(): Take the
747 whole LayoutItem_Field instead of just the field name, so
748 we have access to the formatting.
749 createFieldValueElement(): Use JRTextField.setPattern() to
750 specify the numeric formatting, with the help of a
751 regular DecimalFormat.
753 2012-04-18 Murray Cumming <murrayc@murrayc.com>
755 ReportGenerator: Avoid showing null for group by titles.
757 * src/main/java/org/glom/web/server/ReportGenerator.java
758 generateReport(): Use setBlankWhenNull() on the field title
759 style too, because this is used for values in group by
762 2012-04-18 Murray Cumming <murrayc@murrayc.com>
764 ReportGenerator: Add a colon to titles in vertical groups.
766 * src/main/java/org/glom/web/server/ReportGenerator.java
767 addFieldToDetailBandVertical(): Pass true for the withColon
770 2012-04-18 Murray Cumming <murrayc@murrayc.com>
772 ReportGenerator: Simplify the code by using Position more.
774 2012-04-18 Murray Cumming <murrayc@murrayc.com>
776 Reports: Support vertical groups, roughly.
778 * src/main/java/org/glom/web/server/ReportGenerator.java:
779 addToReport(): Rename to addGroupToReport() and, if necessary,
780 call the new addVerticalGroupToReport() method.
781 createFieldValueElement(): Let the caller specify the Y position
784 2012-04-17 Murray Cumming <murrayc@murrayc.com>
786 Reports: Allow a second report to be shown.
788 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
789 clear(): Do not remove the HTML widget, which broke the whole layout.
791 2012-04-17 Murray Cumming <murrayc@murrayc.com>
793 Locales drop-down: Show that we use English by default.
795 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
796 fillView(): When we use English, just because that is the default, when
797 no locale is specified, show that in the Locales drop-down instead of
798 just showing the first item.
800 2012-04-17 Murray Cumming <murrayc@murrayc.com>
802 Unselect the Report/Locale/Table combo item when appropriate.
804 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
805 setPlace(): clear reportName if this is not a ReportPlace.
806 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
807 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
808 When the provided name is empty, unselect all items, so that none are
809 indicated. This uses a for loop because I cannot find a single method
812 2012-04-17 Murray Cumming <murrayc@murrayc.com>
814 Report: Give the user a way to get back to the list.
816 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
817 start(), setPlace(): Show the Back To List link on reports, and also
818 interpret selecting the empty report item as back to list.
820 2012-04-13 Murray Cumming <murrayc@murrayc.com>
822 Really show the selected Report name.
824 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
825 setPlace(): Store the reportName here, if it is that kind of Place.
826 fillView(): Set the selected Report after filling the list of reports.
827 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
828 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
829 null Strings, though we need some way to unselect all ListBox items
832 2012-04-13 Murray Cumming <murrayc@murrayc.com>
834 ReportGenerator: Try to avoid some problems.
836 * src/main/java/org/glom/web/server/ReportGenerator.java
837 addField(): Try to avoid duplicates, and avoid using a null
840 2012-04-13 Murray Cumming <murrayc@murrayc.com>
842 Reports: Use quickFind.
844 * src/main/java/org/glom/web/client/OnlineGlomService.java;
845 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
846 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
847 getReportHTML(): Add a quickFind parameter.
848 * src/main/java/org/glom/web/client/activity/ReportActivity.java
849 start(): Pass the quickFind parameter.
850 * src/main/java/org/glom/web/server/ReportGenerator.java
851 generateReport(): Take a quickFind parameter.
853 2012-04-13 Murray Cumming <murrayc@murrayc.com>
855 ReportPlace: Actually use the report name.
857 * src/main/java/org/glom/web/client/place/ReportPlace.java
858 getPlace(): Do not assign the report name to the quickfind.
860 2012-04-13 Murray Cumming <murrayc@murrayc.com>
862 Show java.library.path when complaining.
864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
865 init(): When telling us to check java.library.path, show the
868 2012-03-06 Murray Cumming <murrayc@murrayc.com>
870 ReportGenerator: Do not show nulls.
872 2012-03-06 Murray Cumming <murrayc@murrayc.com>
874 ReportGenerator: Make the title font larger.
876 2012-03-06 Murray Cumming <murrayc@murrayc.com>
878 ReportGenerator: Put field titles inside groups, if there are groups.
880 2012-03-06 Murray Cumming <murrayc@murrayc.com>
882 ReportGenerator: Take the Report itself instead of the name and group.
884 * src/main/java/org/glom/web/server/ConfiguredDocument.java
885 Remove getReportLayoutGroup().
886 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
887 getReportHTML(): Pass the report instead
888 of its name and layout group.
889 * src/main/java/org/glom/web/server/ReportGenerator.java
890 generateReport(): Use the report object to use the title
893 2012-03-06 Murray Cumming <murrayc@murrayc.com>
895 ReportGenerator: Remove designBand parameters.
897 * src/main/java/org/glom/web/server/ReportGenerator.java:
898 Make designBand a class member instead of passing it to all
901 2012-03-06 Murray Cumming <murrayc@murrayc.com>
903 ReportGenerator: Add lines, a bit like in the desktop version.
905 * src/main/java/org/glom/web/server/ReportGenerator.java
906 addToReport(): Use JRDesignLine.
908 2012-03-06 Murray Cumming <murrayc@murrayc.com>
910 ReportGenerator: Correct the title positions and use some bold style.
912 * src/main/java/org/glom/web/server/ReportGenerator.java:
913 Break the code up into reusable functions, correct the placement of
914 titles, and use normal/bold styles as in the reports in the desktop
917 2012-03-06 Murray Cumming <murrayc@murrayc.com>
919 ReportGenerator: Add a header band to show the field titles.
921 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
922 getReportHTML(): Pass the localeId to the ReportGenerator
924 * src/main/java/org/glom/web/server/ReportGenerator.java
925 constructor: Take the localeID so we can get translated field
927 generateReport(), addToReport(), addFieldToBand(): Add field
928 titles in a column header band.
930 2012-03-05 Murray Cumming <murrayc@murrayc.com>
932 Reports drop-down list: Some improvement.
934 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
935 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
936 Adedd setSelectedReport(),
937 setReportList(): Add a blank line so that the user can select the
939 * src/main/java/org/glom/web/client/activity/ReportActivity.java
940 start(): Show the current report by calling setSelectedReport().
941 This does not seem to work yet.
943 2012-03-05 Murray Cumming <murrayc@murrayc.com>
945 DetailsActivity, ListActivity: Move some variables into a base class.
947 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
948 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
949 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
950 the clientFactory, documentID, tableName and authenticationPopup into
951 a base class, to avoid duplication.
953 2012-03-05 Murray Cumming <murrayc@murrayc.com>
955 Translate the Reports label.
957 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
958 Get the "Reports" label string from the constants.
959 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
960 perties: Add Reports to the constants.
962 2012-03-05 Murray Cumming <murrayc@murrayc.com>
964 Reports: Implement grouping.
966 * src/main/java/org/glom/web/server/ReportGenerator.java:
967 Handle LayoutItem_GroupBy items and try to do the right thing
968 with JRDesignGroup. It seems to work.
970 2012-03-04 Murray Cumming <murrayc@murrayc.com>
972 Actually show some data with JasperReports.
974 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
975 getReportHTML(): Move most code into a ReportGenerator class.
976 * src/main/java/org/glom/web/server/ReportGenerator.java:
977 Recurse into sub-groups, adding fields to the JasperDesign's details
978 band. Note that we must set an arbitrary width and height, or it just
979 will not show any data.
981 2012-03-04 Murray Cumming <murrayc@murrayc.com>
983 Reports Chooser: Show the titles, not the names.
985 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
986 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
987 and the names as the values.
988 * src/main/java/org/glom/web/server/ConfiguredDocument.java
989 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
990 group now that we provide the report name, so it should always
993 2012-02-15 Murray Cumming <murrayc@murrayc.com>
995 Depend on jasperreports.
997 * pom.xml: Add the dependency. My plan is to use this on the
1000 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1002 Implement navigation to report places.
1004 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1005 start(): Do not bother to handle all events here.
1006 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1007 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1008 Added getSelectedReport().
1009 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1010 .java: start(): When handling a change to the reports chooser,
1011 call getSelectedReport() and goTo() its ReportPlace.
1012 * src/main/java/org/glom/web/client/ui/ReportView.java
1013 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1014 Added setReportHTML() which puts the html in a gwt HTML widget.
1015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1016 getReportHTML(): Return "TODO" just to show that this works.
1018 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1020 Make ReportPlace usable.
1022 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1023 Mention ReportPlace.
1024 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1025 Correct the @prefix annotation.
1027 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1029 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1031 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1032 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1034 Change getReportLayout() to getReportHMTL() because we will not need to
1035 parse or render the report layout on the client side.
1036 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1037 getReportLayout(): Return the libglom LayoutGroup type because we will
1038 not need to convert to a shared type, because this will not be used on
1040 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1043 Note that there is still no implementation for this.
1046 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1048 Add a (empty) Report Place, View, and Activity.
1050 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1052 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1053 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1054 this into a superclass:
1055 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1056 and also use it as the base of this new ReportPlace:
1057 * src/main/java/org/glom/web/client/place/ReportPlace.java
1059 * src/main/java/org/glom/web/client/ui/ReportView.java
1060 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1061 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1062 Add these, containing mostly boiler-plate for now.
1064 * src/main/java/org/glom/web/client/OnlineGlomService.java
1065 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1066 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1067 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1068 Add API to get the LayoutGroup for the report.
1070 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1072 Add and fill a Reports drop-down list box.
1074 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1076 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1077 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1079 Added getReports(document, table, localeID), calling
1080 ConfiguredDocument.getReports().
1081 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1082 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1083 Added setReportsList() and a list widget.
1084 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1085 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1090 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1092 Translations: Add Esperanto.
1094 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1095 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1096 properties: Add this translation because someone took the time to make it.
1098 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1100 Adapt to the java-libglom 1.21.7 API.
1102 * src/main/java/org/glom/web/server/ReportGenerator.java:
1103 addToReport(): get_group_secondary_fields() is now
1104 get_secondary_fields().
1107 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1109 Use the latest java-libglom version.
1111 * pom.xml: Use java-libglom 1.21.7.
1113 2012-03-03 Ben Konrath <ben@bagu.org>
1115 Display date and time in details view.
1117 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1119 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1121 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1123 Require the latest java-libglom.
1125 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1127 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1129 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1131 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1132 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1133 an empty quickfind string. I also corrected libglom to create only
1134 empty where clauses for empty quickfind strings, but this avoids the
1137 2012-02-24 Ben Konrath <ben@bagu.org>
1139 Improve the tabs in the Notebook widget.
1143 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1145 Translations: Try to translate the strings.
1147 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1148 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1149 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1150 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1151 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1152 Take the Open translation from GTK+'s .po files.
1153 Take the Details translation from Glom's po files.
1154 I have added the other strings to Glom so we can get translations that way:
1155 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1157 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1159 TableSelectionViewImpl: Put the search label and entry in a div.
1161 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1162 Put the search widgets in a FlowTable so that the CSS can be used to
1163 style them while keeping them together.
1164 * src/main/webapp/style.css: Mention the new div.
1166 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1168 Translate more strings in more locales.
1170 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1171 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1172 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1173 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1174 Translate the "Details" and "Open" string too.
1176 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1177 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1178 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1179 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1180 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1181 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1182 Add these new locales as placeholders though they currently contain English.
1184 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1186 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1188 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1189 Check the ConfiguredDocument* for null before using it.
1191 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1193 Tell Eclipse about the generated java files.
1195 * .classpath: This lets it find OnlineGlomConstants.java.
1196 It would be nice if Eclipse just used the maven build files.
1198 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1200 Prevent a crash when no locale is specified in the URL.
1202 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1203 Avoid returning a null string, obtained from
1204 Window.Location.getParameter(). This caused a crash when it was
1205 later passed to libglom's API.
1206 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1207 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1208 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1209 guard against future null strings.
1211 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1213 Use the ?locale= query param instead of the &lang= token param.
1215 * src/main/java/org/glom/web/client/place/ListPlace.java
1216 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1217 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1218 Remove the lang token key and value.
1220 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1221 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1222 When the user selects a different locale from the chooser, use
1223 Window.Location.assign() to change the URL, which then causes a reload.
1225 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1226 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1227 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1228 * src/main/java/org/glom/web/client/activity/ListActivity.java
1229 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1230 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1231 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1232 * src/main/java/org/glom/web/client/ui/ListView.java:
1233 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1235 Remove localeID member variables and method/constructor parameters, instead
1236 using Utils.getCurrentLocaleID() when we need a localID to pass to
1239 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1241 Internationalize the UI strings.
1243 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1244 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1245 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1246 because it is unused. Messages are apparently strings that can have
1247 parameters, but we do not need that yet, so Contants will be enough for now.
1248 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1249 to say that we support the en and de locales.
1250 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1251 The original English strings.
1252 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1253 Some German translations of the English strings.
1254 The i18n goal then uses the .properties file to generate an
1255 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1256 returns an implementation that returns the translated strings.
1257 The documentation suggests putting these in src/java/*/client/, but it seems
1258 best to put it in src/resources/*/client/.
1259 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1260 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1261 instead of hard-coding them.
1262 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1263 but that does not seem to stop the build, though it confuses Eclipse.
1265 You can see the translated string by adding ?locale=de to the URL, like so:
1266 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1268 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1270 Improve null/empty String checks.
1272 * pom.xml: Add a dependency on commons-lang, to use
1273 org.apache.commons.lang.StringUtils.
1274 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1275 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1276 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1277 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1278 Use StringUtils.isEmpty().
1280 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1281 StringUtils class with a static isEmpty() function because we
1282 cannot use org.apache.commons.lang.StringUtils in client-side
1283 GWT code because it (apparently) cannot be compiled to javascript.
1284 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1285 * src/main/java/org/glom/web/client/activity/ListActivity.java
1286 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1287 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1288 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1289 * src/main/java/org/glom/web/client/place/ListPlace.java
1290 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1291 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1292 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1293 * src/main/java/org/glom/web/client/ui/details/Group.java
1294 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1295 our StringUtils.isEmpty() function.
1297 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1299 Update to the latest java-libglom API.
1301 * pom.xml: Require java-libglom 1.21.4.
1302 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1303 getDocumentInfo(), getListViewLayoutGroup():
1304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1306 * src/main/java/org/glom/web/server/database/DBAccess.java
1307 getFieldsToShowForSQLQueryAddGroup(),
1308 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1309 with either get_database_title_original() or
1310 get_database_title(localeID).
1312 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1314 ConfiguredDocument: Avoid a null pointer exception.
1316 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1317 Initialize localeID to "" to avoid returning a null String which
1318 causes a crash in java-libglom's swing-generated code.
1320 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1322 Some simple renaming.
1324 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1325 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1326 for localeChooser. This seems more appropriate and is less ambiguous
1327 particularly in the .css file.
1329 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1331 ConfiguredDocument: Rename the localedID private member variable.
1333 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1335 Adapt to the latest java-libglom API from git master.
1337 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1338 libglom now uses only Vector instead of List, which uses add() instead of
1341 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1343 ConfiguredDocument: Rename the localedID private member variable.
1345 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1347 Build a source tarball with mvn assembly:single
1349 * assembly.xml: Add this file.
1350 * pom.xml: Use the maven-assembly-plugin and tell it to use
1351 our assembly.xml file.
1353 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1355 OnlineGlomServiceImpl: Get .glom files recursively.
1357 * pom.xml: Depend on commons-io from org.apache.commons.
1358 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1359 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1360 files recursively, and with the easier filter for the extension.
1361 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1362 simplify that code too.
1364 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1366 README: Mention that you must install java-libglom packages separately.
1368 But then it works, because java-libglom is now in the central maven
1371 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1373 locales drop-down: Show the correct selected locale when the URL changes.
1375 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1376 .java: setPlace(): Move some code into fillView().
1378 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1380 locales drop-down: Do not lose the primary key.
1382 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1383 start(): onLocaleChange(): Pass the current primary key value,
1384 instead of an empty value.
1386 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1388 locales drop-down: Do not lose the drop-down selection.
1390 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1391 .java (TableSelectionActivity.fillView): Set the selected locale
1392 after changing the drop-down items (though we do not really need
1393 to change them just because the locale changes.)
1395 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1397 locales drop-down: Change the tables list when this changes.
1399 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1400 .java: TableSelectionActivity.start(): Move the async table titles
1401 retrieval into a private fillView() method and also call this when
1402 the chosen locale changes.
1403 Note that the document title is not actually translatable yet, but
1404 that is a problem that I should fix soon in libglom.
1406 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1408 Improve the placement of the locales drop-down.
1410 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1411 Put the title and locales drop-down in a div (gwt.FlowTable).
1412 * src/main/webapp/style.css: Add magic css properties to make this work.
1413 Also remove the left margin from the title so that it lines up with the
1416 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1418 locales selector: Show human-readable locale titles.
1420 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1421 getDocumentInfo(): Use java.util.Locale to show a real title of
1422 each locale, in the locale's own language.
1424 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1426 Add a language/locale selector drop-down.
1428 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1429 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1430 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1431 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1432 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1433 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1434 Add a ListBox to show the available locales. Add getLocaleSelector(),
1435 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1436 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1437 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1438 java: Add these classes.
1439 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1440 start(): Fill the locales ListBox. Handle its change event, firing a
1442 setPlace(): Show the selected locale as specified by the URL token.
1443 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1444 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1445 Handle LocaleChangeEvent, going to a new *Place with that locale.
1447 The placement of the ListBox is not pretty, and it currently uses the ID
1448 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1452 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1454 Search box: Show the search text from the URL token.
1456 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1457 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1458 Add setQuickFindText().
1459 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1460 .java: setPlace(): Store the queryText if the place is a ListPlace,
1461 and call TableSelectionView.setQuickFindText().
1463 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1465 Allow use of translations via, for instance, &lang=de in the URL.
1467 * pom.xml: Use the unstable java-libglom 1.21 version.
1469 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1470 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1471 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1472 init(): Instead of calling TranslatableItem.set_current_locale()
1473 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1474 However, this is only for default locales, which are not needed to
1475 change the locale in the URL.
1476 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1477 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1478 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1479 layout for a particular locale.
1480 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1481 Add get/setDefaultLocaleID().
1482 getDocumentInfo(), getListViewData(), getRelatedListData(),
1483 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1484 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1485 localeID parameter, so we can get the layout for a particular locale.
1487 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1488 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1489 * src/main/java/org/glom/web/client/place/ListPlace.java:
1490 Parse and construct a lang parameter too.
1492 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1493 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1494 passed to subsequent methods and constructors.
1495 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1496 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1497 Store the localeID from the *Place and pass it to other constructors
1498 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1500 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1501 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1502 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1503 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1504 * src/main/java/org/glom/web/client/ui/ListView.java:
1505 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1506 Take localeID parameters and pass them to subsequent constructors and
1507 methods, so that the layout is always retrieved for that locale.
1509 This is rather repetitive.
1511 Note that "" means the original (default) locale of the Glom document,
1512 which is usually English.
1514 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1516 Documents: Remove final keyword to fix startup configuration.
1518 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1519 final keywords on the private member variables because that breaks
1520 the startup, apparently (there are warnings) because it stops them
1521 from being serialized. I added these in the previous commit.
1523 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1525 Documents: Add some final keywords.
1527 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1530 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1532 OnlineGlomServiceImpl: Add to overview comments.
1534 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1535 Note that this is where all the document are loaded. They are not
1536 loaded freshly for each page.
1538 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1542 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1543 Add a TextBox for the text of a quick find.
1544 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1546 setBackLink(): Add a String quickFind parameter.
1547 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1548 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1549 to the base interface, because that is how TableSelectionViewImpl is used.
1550 * src/main/webapp/style.css: Add style for the search box and its label.
1552 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1553 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1554 Add these files, based on the existing TableChangeEvent and
1555 TableChangeEventHandlers.
1556 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1557 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1558 a ListPlace() that the user should be taken to.
1559 * src/main/java/org/glom/web/client/activity/ListActivity.java
1560 start(): Handle it here too and adapt the TableChangeEvent handler to
1561 pass the extra "" quickFind parameter to ListPlace.
1562 * src/main/java/org/glom/web/client/place/ListPlace.java:
1563 Constructor: Take an extra String quickFind parameter and store it,
1564 returning it from a new getQuickFind() method.
1565 getToken(): Put the quickFind text in the URL token.
1566 getPlace(): Parse the quickFind text from the URL token.
1567 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1568 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1569 ListPlace constructor.
1570 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1571 .java: start(): Add a Change handler for the TableSelectionView's
1572 TextBox (via its base HasChangeHandlers interface), firing the new
1573 QuickFindChangeEvent.
1574 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1575 pass the extra "" quickFind parameter.
1577 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1578 setCellTable(): Add a String quickFind parameter and pass it to
1579 the ListViewTable() constructor.
1580 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1581 setCellTable() in the base interface, because that is how ListViewImpl
1584 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1585 Add a String quickFind member variable.
1586 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1587 Constructor: Add a String quickFind parameter, storing it in the
1588 base ListTable's member variable.
1589 onRangeChanged(): Pass quickFind to the
1590 OnlineGlomServiceAsync.getSortedListViewData() and
1591 OnlineGlomServiceAsync.getListViewData() methods.
1593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1594 getListViewData(), getSortedListViewData(): Add a String quickFind
1595 parameter, passing it to ConfiguredDocument.getListViewData().
1596 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1597 Change getListViewData(), getSortedListViewData() in the base interface,
1598 because that is how OnlineGlomServiceImpl is used, via this:
1599 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1600 Change getListViewData(), getSortedListViewData() here too.
1601 This class can apparently be used to asynchronously call methods on
1602 OnlineGlomService, and GWT seems to implement that after recognizing
1603 just the *Async name convention and the extra AsyncCallback parameters.
1605 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1606 getListViewData(): Add a String quickFind parameter, and pass it to
1607 ListViewDBAccess.getData().
1608 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1609 getListData(): Add a String quickFind parameter and pass it to
1611 getSelectQuery(): Add a String quickFind parameter.
1612 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1613 getSelectQuery(): Add a String quickFind parameter and use it with
1614 Glom.get_find_where_clause_quick() to pass a where_clause to
1615 Glom.build_sql_select_with_where_clause(), to actually filter the
1617 getData(): Add a String quickFind parameter, passing it to getListData().
1618 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1619 va: getData(): Pass an empty string to getListData() for the
1620 quickFind parameter.
1622 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1624 ListTable: Minor change.
1626 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1627 createCellTable(): Make this protected instead of public.
1629 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1631 Many files: Use final for the parameters and use the @override attribute.
1633 2012-01-22 Ben Konrath <ben@bagu.org>
1635 Add anchor links for single line text that starts with http, ftp and www.
1639 2012-01-22 Ben Konrath <ben@bagu.org>
1641 Add ellipsis to single line text in details view.
1645 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1647 Remove all javadoc author tags.
1649 Because they are awkward and meaningless when many people touch
1651 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1653 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1655 Revert the COPYING.LESSER to COPYING rename.
1657 Apparently both should be there if it is LGPL.
1659 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1661 *View: Remove unused imports.
1663 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1664 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1665 * src/main/java/org/glom/web/client/ui/ListView.java:
1666 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1667 Remove unused imports, as suggested by Eclipse.
1669 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1671 Move the *View::Presenter types, and some API into one base View.
1673 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1674 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1675 * src/main/java/org/glom/web/client/ui/ListView.java:
1676 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1677 Presenter, setPresenter() and clear() into a shared base interface,
1678 to avoid the unnecessary duplicate Presenter types and to more clearly
1679 show how the *Views share the same structure, even if they are not
1680 used polymorphically.
1682 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1683 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1685 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1686 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1687 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1689 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1692 Feel free to revert this if there is a good reason for the duplicate
1695 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1697 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1699 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1700 a class member instead of a local variable in the method.
1701 This lets us use it to get the view instances, for use in tests.
1702 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1703 beforeOnlineGlom(): Test some more details of the initial view.
1704 Again, this is not very useful.
1706 To really test gwt-glom we will need to start a local postgresql
1707 instance with local data, like the Glom tests in C++.
1709 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1711 pom.xml: Mention the LGPL license.
1713 * pom.xml: Add a licenses section.
1714 * COPYING.LESSER: Move this to COPYING, which
1715 previously contained the GPL. But gwt-glom is all LGPL.
1717 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1719 Add project information to README and pom.xml.
1721 * README: Add a brief description and mention some mvn
1723 * pom.xml: This extra information shows up in mvn site
1726 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1728 Use the latest java-libglom version.
1730 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1732 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1734 GwtTestOnlineGlom: Test a little more.
1736 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1737 protected rather than private, as suggested by the gwt-test-utils
1739 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1740 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1741 Test the initial visibility of the panels.
1743 However, this is not a very useful test.
1744 And I wonder how we should generally test using this idea for an
1745 activity/places app like ours where the real changes happen implicitly
1746 based on the history token/URL.
1748 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1750 Slight modification to *Mapper comments.
1752 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1753 (DataActivityMapper)
1754 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1756 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1758 Remove comments mentioning GIN because they are just copied from
1759 the example code and are apparently not helpful:
1760 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1761 Also change the mention of a class that is only in the example code.
1763 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1765 GwtTestOnlineGlom test: Minor changes.
1767 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1768 Avoid the long qualified class name and modify the comment
1769 because it is now obvious to me that the mocked class is the only
1770 custom one created via GWT.create().
1772 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1774 Tests: Added the beginnings of a test using gwt-test-utils.
1776 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1777 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1778 which tells gwt-test-utils what class will be tested.
1779 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1780 Add a simple (but empty) test case. One class, used by the OnlineGlom
1781 class, is mocked so that it can be created. However, I am not sure
1782 why only this class needs to be mocked.
1784 Note that mockito seems more popular, and clearer, than easymock,
1785 but I have not got that working yet. It might be a matter of the
1788 This test is run during mvn integration-test.
1790 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1792 Tests: Use junit4-style syntax instead of junit3-style.
1794 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1795 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1796 * src/test/java/org/glom/web/shared/DataItemTest.java:
1797 Use the @Test annotation rather than relying on the test*() prefix.
1798 Also no longer implement TestCase, to avoid triggering support for
1799 the junit3-way, which stops the annotations from working.
1800 Change the imports from import junit.framework.* to
1801 import org.junit.*, which is apparently the new way.
1803 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1805 Added a test for ListPlace token parsing and creation.
1807 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1808 This is much the same as DetailsPlaceTest.
1810 I wonder how we could test the other parts of the *Place API.
1812 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1814 DetailsPlace test: Also test getToken() and recreation via getPlace().
1816 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1817 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1818 recreate it, testing the recreated DetailsPlace for the same parameter
1821 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1823 Use the surefire-report plugin.
1825 * pom.xml: This generates a HTML report about the tests in
1826 target/site/surefire-report.html
1827 when you do mvn surefire-report:report. It seems to be popular/normal.
1829 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1831 Added a test for DetailsPlace.
1833 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1834 Test the getPlace() token parsing.
1836 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1838 Added a first unit test.
1840 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1841 * src/test/java/org/glom/web/shared/DataItemTest.java:
1842 This is a silly test but it is just to get things started. Note that
1843 maven/junit finds the test because it looks in src/test by default.
1845 2011-12-22 Ben Konrath <ben@bagu.org>
1847 Change charsetName to "UTF-8" when replacing line breaks.
1849 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1850 that work in Java (such as "UTF8") will not work when compiled to
1853 This fixes a problem with multi-line details view fields that have hard
1854 line breaks. The "License Text" field on this page demonstrates the
1857 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1859 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1861 2011-12-22 Ben Konrath <ben@bagu.org>
1863 Fix another bug with related list navigation.
1865 I've tested all the navigation buttons in all of the related lists
1866 so things should be good now.
1868 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1870 2011-12-22 Ben Konrath <ben@bagu.org>
1872 Fix a crasher when refreshing the list view with the default table.
1874 This crash will also happen when loading the list view with the default
1875 table from a link or bookmark.
1877 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1878 to the main document selection page when the document id hasn't been
1880 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1881 the main document selection page when the document id hasn't been
1883 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1884 values for the details place when the document id hasn't been set.
1885 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1886 values for the list place when the document id hasn't been set.
1888 2011-12-21 Ben Konrath <ben@bagu.org>
1890 Protect against NPE when glom.document.locale is not in config.
1892 This patch protects against an NPE when glom.document.locale is not in
1893 the config file. This NPE will also happen if glom.document.locale is
1896 The patch also updates the error message to display the class name when
1897 the getMessage() returns null. This was happening when the NPE was
1898 thrown and I had "Configuration Error: null". If an NPE is encountered
1899 with this patch, "Configuration Error: NullPointerException " will be
1902 This commit closes this bug:
1904 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1906 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1908 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1910 Rename onlineglom.properties to onlineglom.properties.sample.
1912 * src/main/resources/onlineglom.properties: Rename to:
1913 * src/main/resources/onlineglom.properties.sample:
1914 * src/main/resources/README: And add this file explaining that people
1915 should rename it back when deploying.
1917 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1919 Allow choosing the translation in the .properties file.
1921 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1922 init(): Read a glom.document.locale value from the configuration file
1923 and call Glom's TransatableItem::set_current_locale() method.
1924 * src/main/resources/onlineglom.properties: Add a commented-out
1925 example of this new setting.
1927 It would be better to add &lang=de_DE to the URL, but the current
1928 libglom API does not allow us to do this easily. I am working on that.
1930 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1932 Avoid a crash in parsing of token parameters.
1934 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1935 ava: getTokenParams(): Do not crash if a parameter has a key but no
1936 value, and ignore parameters with neither.
1938 2011-12-17 Murray Cumming <murrayc@murayc.com>
1940 History token building/handling: Improve use of token parameters.
1942 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1943 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1944 and buildParamsToken(HashMap), for use by derived classes.
1945 Make the separator private because it is no longer be needed.
1946 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1947 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1948 instead of manual string concatenation.
1949 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1950 of hardcoded indices and awkward splitting code.
1951 * src/main/java/org/glom/web/client/place/ListPlace.java
1952 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1953 instead of manual string concatenation.
1954 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1955 of hardcoded indices and awkward splitting code.
1956 This should fix bug #666420
1958 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1960 Fix a Navgiation->Navigation typo in the code.
1962 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1963 Rename processNavgiation() to processNavigation().
1965 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1967 Fix a seperator->separator typo in the code.
1969 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1970 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1971 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1974 2011-12-15 Ben Konrath <ben@bagu.org>
1976 Cleanup some comments.
1978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1980 2011-12-14 Ben Konrath <ben@bagu.org>
1982 Replace \n with <br/> for multiline text in the details view.
1984 Vertical scrollbars are added when needed as well.
1986 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1988 2011-12-14 Ben Konrath <ben@bagu.org>
1990 Specify the font for document selection links.
1992 * src/main/webapp/style.css:
1994 2011-12-14 Ben Konrath <ben@bagu.org>
1996 Fix bouncy CellTable while paging.
1998 This doesn't currently work with related list tables in unselected
2001 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2003 2011-12-14 Ben Konrath <ben@bagu.org>
2005 Revamp the appearance of the document selection page.
2007 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2008 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2009 * src/main/webapp/style.css:
2011 2011-12-13 Ben Konrath <ben@bagu.org>
2013 Set navigation button column to the smallest size possible.
2015 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2017 2011-12-13 Ben Konrath <ben@bagu.org>
2019 Change OpenButton nomenclature to NavigationButton.
2021 Using NavigtionButton makes things more generic. Classes, methods and
2022 variables have been changed.
2024 This is a rename-only refactor.
2026 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2027 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2028 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2029 Renamed from OpenButtonCell.
2030 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2031 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2032 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2034 2011-12-12 Ben Konrath <ben@bagu.org>
2036 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2038 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2039 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2040 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2041 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2043 2011-12-12 Ben Konrath <ben@bagu.org>
2045 Update variable names and comments.
2047 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2048 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2050 2011-12-12 Ben Konrath <ben@bagu.org>
2052 Properly initialize numNonEmptyRows variable to zero.
2054 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2055 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2057 2011-12-05 Ben Konrath <ben@bagu.org>
2059 Add latest mockup with HTML tables.
2061 Features of this mockup:
2063 -> HTML table for flowtable
2064 -> HTML table for flowtable column
2065 -> Example of how related lists would look
2066 -> Not using text entries for data items
2068 The current version of Online Glom doesn't use HTML tables for the
2071 This mockup has been sent to the glom-devel mailing list but it's good
2072 to have it here as well.
2074 * mockups/details-view-html-tables.html:
2076 2011-12-05 Ben Konrath <ben@bagu.org>
2078 Remove unnecessary getPrimaryKeyField() method.
2080 getPrimaryKeyFieldForTable(String) has been renamed to
2081 getPrimaryKeyField(String).
2083 * src/main/java/org/glom/web/server/database/DBAccess.java:
2084 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2085 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2087 2011-12-05 Ben Konrath <ben@bagu.org>
2089 Add string representation of TypedDataItem value to conversion error message.
2091 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2092 message was extracted into its own method to avoid duplication.
2094 2011-12-05 Ben Konrath <ben@bagu.org>
2096 Add type checking to navigation primary key value creation.
2098 Create navigation primary key only if the expected type from the Glom
2099 document matches the type returned by the SQL query.
2101 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2103 2011-12-05 Ben Konrath <ben@bagu.org>
2105 Rename a couple of variables in RelatedListNavigation.
2107 This is a rename-only refactor.
2109 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2111 2011-12-05 Ben Konrath <ben@bagu.org>
2113 Move getListLayoutGroup() into getListViewLayoutGroup().
2115 This removes getListLayoutGroup(). It was only being called by
2116 getListViewLayoutGroup().
2118 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2120 2011-12-05 Ben Konrath <ben@bagu.org>
2122 Remove check for LayoutItem_Portal in list table method.
2124 This check is no longer necessary because the method isn't being used
2125 to create the LayoutItemPortal DTO.
2127 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2129 2011-12-05 Ben Konrath <ben@bagu.org>
2131 Properly support related list navigation.
2133 Navigation from the "Repository Analyzer -> Package Scans ->
2134 Dependencies" related table wasn't working because the primary key for
2135 related tables wasn't being set properly. This commit fixes the
2138 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2139 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2140 doesn't set the primary key properly for related list tables.
2141 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2142 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2143 useful for getting the primary key for list view tables and for related
2145 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2146 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2147 Move code to set the primary key for the table from the abstract
2148 ListDBAccess class to ListViewDBAccess as it's only correct for list
2150 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2151 Properly add primary key to related list tables.
2153 2011-12-02 Ben Konrath <ben@bagu.org>
2155 Properly set the horizontal alignment of fields.
2157 This fix is for both the list tables and the details view.
2159 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2160 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2161 to set the horizontal alignment of fields.
2163 2011-12-02 Ben Konrath <ben@bagu.org>
2165 Display currency codes in the details view.
2167 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2169 2011-12-02 Ben Konrath <ben@bagu.org>
2171 Avoid duplicate JNI call.
2173 JNI is not as efficient as pure Java and this is an easy (and small)
2176 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2177 Use previously retrieved value for whereClauseToTableName instead of
2180 2011-12-02 Ben Konrath <ben@bagu.org>
2182 Rename a couple of variables in RelatedListNavigation.
2184 This is a rename-only refactor.
2186 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2188 2011-12-02 Ben Konrath <ben@bagu.org>
2190 Indicate clearly that a mismatched primary key type is a bug.
2192 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2193 warning to error. Add 'This is a bug.' to message.
2195 2011-12-02 Ben Konrath <ben@bagu.org>
2197 Update / fix some comments.
2199 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2201 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2203 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2204 Fix comments. Add some TODOs.
2206 2011-12-02 Ben Konrath <ben@bagu.org>
2208 Enable navigation to details view with string primary key from related list.
2210 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2211 Create a text primary key value when return type of result is
2212 java.sql.Types.VARCHAR.
2214 2011-12-02 Ben Konrath <ben@bagu.org>
2216 Use checkboxes for booleans in the details view.
2218 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2220 2011-12-01 Ben Konrath <ben@bagu.org>
2222 Improve performance of related list height calculation.
2224 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2225 Put code to calculate the expected height in a static initializer so
2226 that that it's only called once.
2228 2011-12-01 Ben Konrath <ben@bagu.org>
2230 Show related list tables in notebooks (again).
2232 Calculate the height of the related list tables so the Notebook can be
2233 set the correct height. The height of the related list table is also needed by
2234 FlowTable to be able decide how to create the layout.
2236 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2237 and set the Portal height based on the height of the related list
2238 table and the Portal container.
2239 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2240 Add method to calculate the height of the related list tables.
2241 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2242 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2243 calculate the height of the Pager widget.
2245 2011-12-01 Ben Konrath <ben@bagu.org>
2247 Use CellTable API for table property instead of setting style on Element.
2249 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2251 2011-12-01 Ben Konrath <ben@bagu.org>
2253 Make ListViewTable and RelatedListTable a consistent height.
2255 The tables are now a consistent height regardless of the contents of
2256 the table. A hidden button is added to empty rows to ensure that the
2257 height of these rows will match the height of rows with data.
2259 A navigation button column is now added to every table. The width of
2260 the navigation column is set to 0px when a RelatedListTable shouldn't
2261 have navigation buttons. This maintains the a consistent row height in
2262 tables that don't show the navigation buttons.
2264 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2265 navigation column when not needed.
2266 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2267 arguments for navigation button to constructor of ListViewTable.
2268 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2269 hidden button for empty data rows.
2270 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2271 arguments for navigation button to constructor.
2272 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2273 create navigation buttons. Add hideNavigationButtons() method.
2274 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2275 arguments for navigation button to constructor.
2277 2011-12-01 Ben Konrath <ben@bagu.org>
2279 Use 'visibility: hidden' in Utils.getWidgetHeight().
2281 This is better choice because hidden elements are invisible, don't
2282 respond to events and are not part of the tab order. They will,
2283 however, take up space which is required to be able to calculate the
2284 height of the widget.
2286 * src/main/java/org/glom/web/client/Utils.java:
2288 2011-12-01 Ben Konrath <ben@bagu.org>
2290 Use Utils.getWidgetHeight() in FlowTable.
2292 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2294 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2296 2011-12-01 Ben Konrath <ben@bagu.org>
2298 Put the details css class name on the correct table column.
2300 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2302 2011-11-30 Ben Konrath <ben@bagu.org>
2304 Update for java-libglom API change.
2306 The getters and setters on FieldFormatting and NumericFormat were
2307 changed to remove the 'M'.
2309 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2311 2011-11-29 Ben Konrath <ben@bagu.org>
2313 Only allow RelatedListTables in Portals.
2315 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2317 2011-11-29 Ben Konrath <ben@bagu.org>
2319 Only create a contents panel for Portals when title is being set.
2321 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2323 2011-11-29 Ben Konrath <ben@bagu.org>
2325 Set TabLayoutPanel height based on calculated height its widgets.
2327 This is a potential fix for this bug:
2329 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2331 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2333 2011-11-29 Ben Konrath <ben@bagu.org>
2335 Align details field labels and data with the Open buttons.
2337 * src/main/webapp/style.css:
2339 2011-11-29 Ben Konrath <ben@bagu.org>
2341 Remove unnecessary <div> in the Notebook widget.
2343 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2344 method to get container FlowPanel (<div>).
2345 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2346 initWidget() method directly on the TabLayoutPanel widget instead of
2347 Group's container widget.
2349 2011-11-29 Ben Konrath <ben@bagu.org>
2351 Don't add group titles for Portals in Notebooks.
2353 This reverts the previous patch and fixes a bug I introduced with
2354 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2356 * src/main/java/org/glom/web/client/ui/details/Group.java:
2357 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2359 2011-11-28 Ben Konrath <ben@bagu.org>
2361 Remove unused boolean argument in Portal constructor.
2363 Just a code cleanup.
2365 * src/main/java/org/glom/web/client/ui/details/Group.java:
2366 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2368 2011-11-28 Ben Konrath <ben@bagu.org>
2370 Remove hack for glom 1.18 style glom files.
2372 * src/main/java/org/glom/web/client/ui/details/Group.java:
2373 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2374 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2376 2011-11-28 Ben Konrath <ben@bagu.org>
2378 Use Gda Value version of primary key to log result too large error.
2380 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2382 2011-11-28 Ben Konrath <ben@bagu.org>
2384 Don't use TypedDataItem.getText() for Unknown types from the URL.
2386 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2387 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2388 instead of getText().
2389 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2390 String field and getUnknown() method.
2392 2011-11-28 Ben Konrath <ben@bagu.org>
2394 Log an error message when the java-libglom .so is not present.
2396 The error message was being set in the exception but not logged.
2398 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2400 2011-11-28 Ben Konrath <ben@bagu.org>
2402 Ignore LayoutItem_CalendarPortals.
2404 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2405 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2407 2011-11-28 Ben Konrath <ben@bagu.org>
2409 Extract method for creating the LayoutItemPortal DTO.
2411 Just breaking the code up into smaller chunks.
2413 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2415 2011-11-28 Ben Konrath <ben@bagu.org>
2419 This should have been added with the refactor. Oops!
2421 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2423 2011-11-28 Ben Konrath <ben@bagu.org>
2425 Create primary key value from URL string using type from Glom document.
2427 See this bug, comments 19 - 25:
2429 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2431 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2432 create a TypeDataItem for the primary key here when loading from a
2433 URL. Show the same string for the primary key value as was received
2434 from the URL string (when loading from a URL).
2435 * src/main/java/org/glom/web/server/Utils.java: Update method for
2436 creating the Gda Value from the TypeDataItem to properly deal with
2437 creating a Gda Value based on the Glom document type for the primary
2438 key value string when loading from a URL.
2439 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2440 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2441 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2442 Update for changed method name.
2444 2011-11-27 Ben Konrath <ben@bagu.org>
2446 Rename PrimaryKeyItem to TypedDataItem.
2448 The name PrimaryKeyItem suggests what the class should be used for.
2449 TypedDataItem is a neutral name that describes the class better.
2451 This is a rename-only refactor.
2453 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2454 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2455 * src/main/java/org/glom/web/client/Utils.java:
2456 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2457 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2458 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2459 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2460 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2461 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2462 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2463 * src/main/java/org/glom/web/server/Utils.java:
2464 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2465 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2466 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2467 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2469 2011-11-25 Ben Konrath <ben@bagu.org>
2471 Improve Gda Value conversion from PrimaryKeyItem.
2473 The value from the PrimaryKeyItem is only used if its type match the
2474 type from the glom document.
2476 * src/main/java/org/glom/web/server/Utils.java:
2478 2011-11-25 Ben Konrath <ben@bagu.org>
2480 Manually check if the java-liblgom .so is visible to the JVM.
2482 It seems that Tomcat has problems when a static initializer throws an
2483 exception. This check is done before the first method call into
2484 java-libglom so that execution doesn't continue if the .so is not
2487 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2489 2011-11-25 Ben Konrath <ben@bagu.org>
2491 Improve browser configuration error messages.
2495 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2497 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2498 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2499 getConfigurationErrorMessage() method.
2500 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2501 Get and display a specific configuration error message when no Glom
2502 documents are found.
2503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2504 Implement getConfigurationErrorMessage() method. Surround configuration
2505 code in the init() method with a try/catch block. This allows the
2506 errors to be caught while keeping the servlet available to retrieve the
2507 configuration error message.
2509 2011-11-25 Ben Konrath <ben@bagu.org>
2511 Don't use Strings to hold primary key values.
2513 The primary key values are now held in a new data object
2514 (PrimaryKeyItem) that holds type information and the primary key value
2515 using the correct type.
2517 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2518 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2519 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2520 PrimaryKeyItem instead of String to hold the primary key value.
2521 * src/main/java/org/glom/web/client/Utils.java: Remove
2522 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2523 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2524 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2525 PrimaryKeyItem instead of String to hold the primary key value. Load
2526 document selection page when the documentID has not been set correctly.
2527 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2528 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2530 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2531 Return empty string for URL instead of "null".
2532 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2533 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2534 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2535 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2536 PrimaryKeyItem instead of String to hold primary key values.
2537 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2538 PrimaryKeyValue to a Gda Value.
2539 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2540 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2541 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2542 Replace temporary database access code that uses the PrimaryKeyValue to
2543 Gda Value conversion.
2544 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2545 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2546 PrimaryKeyItem instead of String.
2547 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2548 hold primary key values.
2550 2011-11-24 Ben Konrath <ben@bagu.org>
2552 Use newly added java-libglom API to create queries.
2554 This isn't finished. I still need to stop using Strings for primary key
2555 values in the client code.
2557 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2558 libglom to use fake connections so that retrieving the query string will
2560 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2561 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2562 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2563 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2564 Use the newly added libglom sql methods and classes to create the
2565 query. Add temporary hack to convert primary value strings to Gda
2568 2011-11-23 Ben Konrath <ben@bagu.org>
2570 Don't explicitly set the height of Portals.
2572 See comments 6 - 10 of this bug for details:
2574 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2576 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2578 2011-11-23 Ben Konrath <ben@bagu.org>
2580 Use an HTML table instead of CSS for the FlowTable layout.
2582 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2583 GWT's FlexTable to implement the FlowTable.
2584 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2586 2011-11-18 Ben Konrath <ben@bagu.org>
2588 Add boolean example to HTML table mockup.
2590 * mockups/details-view-html-tables-text-entries.html:
2592 2011-11-17 Ben Konrath <ben@bagu.org>
2594 Ensure the pager buttons are always visible for related lists.
2596 To accomplish this, I've turned off text wrapping in the list view and
2597 related list tables for both the header and data text. The related list
2598 table now has a fixed layout so the it doesn't overflow its container.
2599 This is required to ensure that the cell text is clipped when it
2600 overflows the cell and an ellipsis is added to the right side of the
2601 cell when text is clipped.
2603 A fixed table layout for the related list table in the details view
2604 seems what we want for the details view anyway, so the side-effect is
2607 The ellipsis will only be displayed in Firefox >= 7.
2611 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2613 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2614 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2615 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2617 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2618 Set the 'table-layout: fixed' CSS property to the related list table.
2619 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2620 'white-space: nowrap;' CSS property on both the list view and the
2621 related list tables.
2623 2011-11-16 Ben Konrath <ben@bagu.org>
2625 Rework the fix for empty notebook tab labels.
2627 Setting the empty group titles with its name caused problems for the
2628 details layout. Instead of using libglom's
2629 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2630 to the client when the title is empty. This allows the Notebook to use
2631 the name when the title is empty without affecting anything else.
2633 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2634 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2636 2011-11-16 Ben Konrath <ben@bagu.org>
2638 Set group titles with name when title is empty.
2640 This fixes a problem with an empty notebook tab label in the Lesson
2641 Planner document. The forth tab in the notebook should be "Internet":
2643 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2645 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2646 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2649 2011-11-16 Ben Konrath <ben@bagu.org>
2651 Remove whitespace from the configured username properties.
2653 This assumes that usernames won't have whitespace at the beginning
2654 or end. But I think this is a reasonable assumption.
2656 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2657 String.trim() to remove the whitespace from the username properties.
2659 2011-11-15 Ben Konrath <ben@bagu.org>
2661 Add details view mockup with HTML tables and text entries.
2663 This is from the attachment on this bug:
2665 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2667 * mockups/details-view-html-tables-text-entries.html:
2669 2011-11-15 Ben Konrath <ben@bagu.org>
2671 Add space between the columns of the flow table.
2675 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2677 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2678 space between columns in the flow table.
2680 2011-11-15 Ben Konrath <ben@bagu.org>
2682 Add backup files to the .gitignore.
2684 * .gitignore: Ignore files that end with ~.
2686 2011-11-09 Ben Konrath <ben@bagu.org>
2688 Use latest release of gwt-log.
2690 Gwt-log releases are now being submitted to the maven central
2691 repository so manual installation of the jar is no longer required.
2693 * pom.xml: Update version and groupId of gwt-log dependency.
2695 2011-10-31 Ben Konrath <ben@bagu.org>
2697 Don't use GWT numeric formatting to override the glom currency formatting.
2699 Currencies are now displayed like they are in Glom. See this bug:
2701 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2703 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2705 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2706 currency code to constructor and set it when the cell is rendered.
2707 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2708 currency code to the constructor of the NumericCell.
2710 2011-10-27 Ben Konrath <ben@bagu.org>
2712 Require the latest release of java-libglom (1.17.4).
2716 2011-10-26 Ben Konrath <ben@bagu.org>
2718 Add style to Notebook that matches current theme.
2720 It's not the best style in the world but it's better than the default.
2722 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2723 padding at the bottom of the child widgets.
2724 * src/main/webapp/style.css: Add style for the Notebook.
2726 2011-10-26 Ben Konrath <ben@bagu.org>
2728 Move servlet initialization code to overridden init method.
2730 This is half of the solution to getting proper error messages
2731 displayed when configuration errors occur. Here's the relevant bug:
2733 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2735 The rest of the solution involves surrounding the init method with a
2736 try/catch block and setting a global variable with the error /
2737 exception. A new async method should be created to retrieve and display
2738 the error message / exception.
2740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2741 code from constructor to init method adding exceptions as needed.
2743 2011-10-26 Ben Konrath <ben@bagu.org>
2745 Add script to monitor and restart tomcat if required.
2747 * utils/check-and-recover-tomcat.py: New file.
2749 2011-10-26 Ben Konrath <ben@bagu.org>
2751 Display the correct number of data items in the pager.
2755 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2757 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2758 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2759 The implementation is the same for both tables: Keep track of the
2760 number of non-empty rows and fire and RowCountChangeEvent after the data has
2762 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2763 custom Pager class that subclasses SimplePager to handle displaying
2764 the correct number when empty rows have been added.
2766 2011-10-26 Ben Konrath <ben@bagu.org>
2768 Correct error in previous commit.
2770 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2771 eventBus parameter from listView.setCellTable().
2773 2011-10-26 Ben Konrath <ben@bagu.org>
2775 Fix error in TODO comment.
2777 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2779 2011-10-24 Ben Konrath <ben@bagu.org>
2781 Create Notebook widgets to the details view.
2783 This isn't finished just yet - I still need to create a reasonable
2784 style to match the current theme.
2786 * src/main/java/org/glom/web/client/Utils.java: Add method for
2787 calculating the height of a widget. This is used in the Notebook class.
2788 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2789 new constructor method in Group.
2790 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2791 method for creating child widget that can be used by subclasses
2792 like Notebook. New constructor that allows disabling the group
2793 titles - Notebooks don't set a group title for their child groups.
2794 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2795 to make Notebooks using GWT's TabLayoutPanel.
2796 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2797 constructor that allows disabling the group titles.
2798 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2799 LayoutItemNotebook DTO.
2800 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2801 DTO for Notebooks. It's just an empty class for now but we might need
2802 it to transfer some specific information in the future.
2804 2011-10-21 Ben Konrath <ben@bagu.org>
2806 Add navigation buttons to related list tables.
2808 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2809 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2810 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2811 method getSuitableRecordToViewDetails() for getting the table name
2812 and primary key value for related list navigation buttons.
2813 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2814 private cell renderer class to get the navigation information for
2815 related list tables from the server. Extract the navigation
2816 processing code from the details cell navigation and use it for the
2817 related list navigation as well.
2818 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2819 cell renderer class for the details open buttons. This was needed
2820 because the related list navigation buttons and the list view
2821 navigation buttons need to react differently when clicked.
2822 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2823 the onEnterKeyDown() method because it's now overriden in the
2824 subclasses that are specific to the related list tables and the list
2826 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2827 the vertical size a little because the buttons add a bit of vertical
2828 space to table. This is not a perfect solution because the vertical
2829 size of with table fewer than 5 rows will be a little smaller.
2830 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2831 changes in how navigation buttons are handled.
2832 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2833 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2834 database access object.
2835 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2836 to find the portal for a given relationship name from
2837 RelatedListDBAccess. Add method to find a primary key field for a
2839 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2840 Move code to find the portal for a given relationship name to
2842 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2843 New file: database access object for getting the related list
2844 navigation information (the table name and the primary key value).
2845 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2846 DTO for transferring a table name to navigate to and a primary key
2848 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2849 boolean and getter/setter to specifies if the related list should add
2852 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2854 Use the master branch of java-libglom
2856 * pom.xml: Depend on java-libglom 1.19 instead.
2858 This is the master branch. See also the libglom-1-18 branch.
2860 2011-10-11 Ben Konrath <ben@bagu.org>
2862 Enable the open navigation button when the data has been set.
2864 This avoids having active buttons that don't do anything when the data
2867 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2869 2011-10-11 Ben Konrath <ben@bagu.org>
2871 Use IsWidget interface for FlowTableItem.
2873 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2874 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2876 2011-10-11 Ben Konrath <ben@bagu.org>
2878 Remove GWT styling from open button in details view.
2880 There are still some issues with how the details cell is arranged but
2881 this should be made to match Glom 1.20. I'm going to leave fixing this
2882 until I have Glom 1.20 up and running.
2884 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2885 style name on open button.
2886 * src/main/webapp/style.css: Move and edit details-navigation class.
2887 Re-arrange some classes to make them appear in the same order as the
2890 2011-10-07 Ben Konrath <ben@bagu.org>
2892 Update to GWT 2.4.0.
2894 * .gitignore: Ignore new cache directory.
2895 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2896 * pom.xml: Change GWT and maven plugin to 2.4.0.
2897 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2899 * src/main/java/org/glom/web/client/ClientFactory.java:
2900 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2901 * src/main/java/org/glom/web/client/OnlineGlom.java:
2902 Update source for API changes.
2903 * utils/build-onlineglom-war.sh: Remove cache directory before the
2906 2011-10-07 Ben Konrath <ben@bagu.org>
2908 Add navigation buttons in the details view.
2910 This isn't finished but I thought I'd commit what I have as it's a
2911 pretty good start. I still need to:
2913 1. Change the style so that it fits better into the current theme
2914 2. Adjust the details cell to expand as much as possible.
2916 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2917 click handlers to navigation buttons in the DetailsCells. Create a
2918 refreshData() method to get just the data from the server without the
2920 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2921 Update the tableSelector and browser title when the table name
2922 changes without using the tableSelector.
2923 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2924 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2925 getDetailsCells() to getCells(). Update variable names.
2926 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2927 method to set click handler on navigation button. Rename a few
2928 variables. Add navigation buttons where needed.
2929 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2930 variables and methods.
2931 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2932 navigation boolean and navigation table as required in the
2933 LayoutItemField DTO.
2934 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2935 variables for navigation along with getter/setter methods.
2937 2011-10-07 Ben Konrath <ben@bagu.org>
2939 Rename Field to DetailsCell.
2941 This is a refactor-only commit. No functionality has been added or
2944 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2945 Update variable and method names.
2946 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2947 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2948 variable and method names.
2949 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2951 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2952 variable and method names.
2954 2011-10-07 Ben Konrath <ben@bagu.org>
2956 Create separate methods for layout and data the details view.
2958 This is a refactor-only commit. No functionality has been added or
2961 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2962 private methods: setData(), createLayout().
2964 2011-10-07 Ben Konrath <ben@bagu.org>
2966 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2968 This is part of a change to get navigation buttons in the details view
2969 but it should have been done this way from the start.
2971 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2972 for method name change in TableSelectionView.
2973 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2974 Create TableChangeEvent and set the browser title using the
2975 TableSelectionView API.
2976 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2977 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2978 Change getSelectedTable() to getSelectedTableName(). Add
2979 getSelectedTableTitle().
2981 2011-10-07 Ben Konrath <ben@bagu.org>
2983 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2985 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2987 2011-10-07 Ben Konrath <ben@bagu.org>
2989 Update TableChangeEvent to use newTableName naming convention.
2991 This makes the class more consistent with GWT naming conventions.
2993 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2994 Update for method name change in TableChangeEvent.
2995 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2996 for method name change in TableChangeEvent.
2997 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2998 newTableName variable and getter method. Make toDebugString()
3001 2011-09-30 Ben Konrath <ben@bagu.org>
3003 Disable the pager in the list tables when the data row count is less than the minimum.
3005 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3006 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3008 2011-09-30 Ben Konrath <ben@bagu.org>
3010 Add empty rows to the end of related list and list view tables.
3012 I also extracted the cell rendering classes from the ListTable because
3013 the code was becoming a little crazy with all the anonymous inner
3014 classes. My plan is to use these cell rendering classes in the details
3015 view as well so this refactor will be needed for that change.
3017 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3018 set the row count in related list tables if the data has more rows
3019 than the minimum number of rows visible.
3020 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3021 row count in list view tables if the data has more rows than the
3022 minimum number of rows visible.
3023 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3024 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3026 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3027 for rendering TYPE_NUMERIC cells. The code was extracted from the
3029 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3030 class for rendering cells with buttons in list views. The code was
3031 extracted from the ListTable class.
3032 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3033 for rendering TYPE_TEXT cells. The code was extracted from the
3035 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3036 Add empty rows to the end of the data if required. Implement
3037 ListTable.getMinNumVisibleRows().
3038 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3039 cell renderer code to public classes. Return null in
3040 Column.getValue() for empty rows. Add new abstract method:
3041 getMinNumVisibleRows(). Move code to set the row count of the list view
3042 table to ListViewImpl.
3043 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3044 empty rows to the end of the data if required. Implement
3045 ListTable.getMinNumVisibleRows().
3048 2011-09-27 Ben Konrath <ben@bagu.org>
3050 Use GWT.log for client-side debugging statements.
3052 These are optimized out when deployed so I should have used this method
3053 in the first place. These statements will eventually be replaced with some sort
3054 of notification in the browser.
3056 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3057 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3058 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3059 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3060 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3062 2011-09-27 Ben Konrath <ben@bagu.org>
3064 Put tableselector on the right, back to list link on right.
3066 The idea is that the table selector is acting like a label for the
3067 currently displayed table so it should be placed below the document title. This
3068 puts the table title in a similar position to where it is in Glom.
3070 * mockups/details-contacts.html:
3071 * mockups/details-projects.html:
3072 * mockups/listview-contacts.html:
3073 * mockups/listview-projects.html:
3074 * mockups/style.css:
3075 Update mockups to match how the interfaces currently look.
3076 * src/main/webapp/style.css: Swap positions of backlink with the table
3077 selector. Add some space on the left side of the table selector to
3078 line things up with the document title.
3080 2011-09-27 Ben Konrath <ben@bagu.org>
3082 Add field colouring to details view.
3084 This change re-works how field colouring works. The colour formatting
3085 information is now set to the client with the layout information instead of
3086 with the data. This eliminates the need to send the same colour strings for
3087 data in list view column when colour information is set.
3089 In order to set an alternate colour for negative numeric values, the
3090 number is now sent to client and formatted with the GWT NumberFormat class.
3092 This change also fixes:
3094 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3096 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3097 internationalization framework which is needed for client side numeric
3099 * src/main/java/org/glom/web/client/Utils.java: New file for some
3100 client static utility methods.
3101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3102 the DataItem object to the Field class. Use a utility method to
3103 create the foreignKeyValue string.
3104 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3105 alignment and text colours in the constructor. Add setData(DataItem)
3106 method. Remove setText(String) method.
3107 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3108 colour information to GlomTextCell. Create and use GlomNumberCell for
3109 rendering numbers. Use utility method to get the string for the
3110 primary key of the key provider. Re-work how the horizontal alignment
3112 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3113 formatting to layout information. Methods for converting the libglom
3114 formatting information were moved from DBAccess.
3115 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3116 numeric formatting (it's now done on the client side). Don't set text
3117 colours in DataItem. Move libglom formatting conversion methods to
3119 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3120 getters/setters for text colour information.
3121 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3122 for transferring the libglom NumericFormat information to the client.
3123 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3124 and getters/setters for: GlomNumericFormat, background colour and
3125 foreground colour strings.
3127 2011-09-26 Ben Konrath <ben@bagu.org>
3129 Simplify code that iterates through the LayoutGroup.
3131 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3133 2011-09-26 Ben Konrath <ben@bagu.org>
3135 Accept Eclipse formatting for OnlineGlomServiceAsync.
3137 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3139 2011-09-26 Ben Konrath <ben@bagu.org>
3141 Don't use the ListDBAccess classes to get the primary key layout information.
3143 This was causing a bug where the wrong index for the hidden primary key
3144 was being sent to the client.
3146 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3147 primary key while creating the LayoutGroup DTO. Create a
3148 LayoutItemField DTO for hidden primary keys. Don't use the
3149 RelatedListDBAccess because it was only used for getting the primary
3151 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3152 access modifier from public to protected for getPrimaryKeyField() and
3153 getPrimaryKeyLayoutItemField().
3154 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3155 abstract method getExpectedResultSize() because RelatedListDBAccess
3156 doesn't have enough info to implement it.
3157 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3158 Remove @Override for getExpectedResultSize().
3159 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3160 Remove method getExpectedResultSize().
3162 2011-09-23 Ben Konrath <ben@bagu.org>
3164 Log which layout (list or details) the ignored item is from.
3166 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3168 2011-09-23 Ben Konrath <ben@bagu.org>
3170 Remove annotations that turn off code formatting in DataItem.
3172 * src/main/java/org/glom/web/shared/DataItem.java:
3174 2011-09-23 Ben Konrath <ben@bagu.org>
3176 Rename GlomField to DataItem and update associated methods.
3178 This is a rename-only refactor. No functionality has been added or
3181 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3182 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3183 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3184 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3185 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3186 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3187 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3188 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3189 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3190 * src/main/java/org/glom/web/server/database/DBAccess.java:
3191 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3192 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3193 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3194 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3195 * src/main/java/org/glom/web/shared/DataItem.java:
3196 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3197 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3199 2011-09-23 Ben Konrath <ben@bagu.org>
3201 Rename GlomDocument to DocumentInfo and update associated methods.
3203 This is a rename-only refactor. No functionality has been added or
3206 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3207 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3208 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3209 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3210 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3212 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3214 2011-09-20 Ben Konrath <ben@bagu.org>
3216 Require java-libglom 1.17.3.
3218 This picks up the fix for the seg fault problem with the Scenes table
3219 in the Openismus Film Manager example.
3223 2011-09-20 Ben Konrath <ben@bagu.org>
3225 Change the way sort clause is added for primary key when no sort clause is requested.
3227 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3228 before the sort clause is created. When a sort clause is not requested, the
3229 sort clause is created by finding the primary key in the LayoutFieldVector
3232 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3234 2011-09-20 Ben Konrath <ben@bagu.org>
3236 Log error message if no documents are found in the configured directory.
3238 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3239 Extract the glom file extension string to a private static final class
3240 variable (mostly as syntactic sugar). Accept a minor formatting change.
3241 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3242 the example glom.document.directory configuration property to make it
3243 more clear that it can any directory, not just the home directory.
3245 2011-09-18 Ben Konrath <ben@bagu.org>
3247 Add related lists to details view.
3249 The related list table has support for paging and sorting just like the
3250 table in the list view.
3252 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3253 SQL queries for the related list tables.
3254 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3255 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3256 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3257 Rename getList methods to getListView and add comments. Remove
3258 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3259 it being unused. Add methods: getDetailsLayoutAndData(),
3260 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3261 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3262 Create the layout and set the data for the fields in one async call
3263 instead of two. Create related lists where appropriate.