1 2012-12-04 Murray Cumming <murrayc@murrayc.com>
3 Authentication: Reduce some copy/paste by moving code to base class.
5 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
6 Add checkAuthentication().
7 * src/main/java/org/glom/web/client/activity/ListActivity.java:
8 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
9 Call it here instead of copy/pasting the code.
11 2012-12-04 Murray Cumming <murrayc@murrayc.com>
13 GwtTestOnlineGlomService: Add some assertions.
15 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
16 However, these assertions will never be run because we have no
17 way to set up the test conditions (specifying documents and their
18 databases) for the OnlineGlom service.
19 See https://groups.google.com/forum/?hl=en&fromgroups=#!topic/google-web-toolkit/Z6rPWG4kcKQ
21 2012-12-04 Murray Cumming <murrayc@murrayc.com>
23 Add client-side tests for StringUtils and Utils.
25 * src/test/java/org/glom/web/client/GwtTestStringUtils.java: Added.
26 * src/test/java/org/glom/web/client/GwtTestUtils.java: Added.
27 This is mostly just to catch java->javascript compilation problems.
29 2012-12-02 Murray Cumming <murrayc@murrayc.com>
31 Add GwtTestReportPlace.
33 * src/test/java/org/glom/web/client/place/GwtTestReportPlace.java:
34 This is like the existing GwtTest*Place tests.
35 It would be nice if we could just test that all client and shared
36 code can be compiled to Javascript without creating a test for it.
37 Currently, we only discover problems when starting it in a browser.
39 2012-12-02 Murray Cumming <murrayc@murrayc.com>
41 Add GwtTestDetailsPlace to test the same code as client-side.
43 * src/test/java/org/glom/web/client/place/GwtTestDetailsPlace.java:
44 See the comment about the awkward client-side-only Date API.
45 Ignoring this Date API issue, it would be nice if we could test
46 the same code as both Java (server) and generated Javascript (client)
47 without duplicating most of the test code.
49 2012-12-02 Murray Cumming <murrayc@murrayc.com>
51 DataItemTest: Test the date type too, and improve the asserts.
53 * src/test/java/org/glom/web/shared/DataItemTest.java:
54 Add testdate(). See the comment about the awkward server-side-only
57 2012-12-02 Murray Cumming <murrayc@murrayc.com>
59 DetailsPlace: Use a date-formatting API available in GWT client code.
61 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
62 getStringForData(): Use DateTimeFormat.getFormat(), because that works
63 on the client side (but not the server side) instead of String.format()
64 with Date.getYear()/getMonth()/getDate(), because they work only on the
65 server side (but not on the client side). Rather annoying.
66 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java: Rename to
68 * src/test/java/org/glom/web/client/place/ListPlaceTest.java: Rename to
69 GwtTestListPlaceTest, so we can run these as client-side (generated
70 Javascript) code so we can catch these problems sooner.
71 It is unfortunate that the code cannot run on the server-side as Java,
72 but it does not need to.
74 2012-12-02 Murray Cumming <murrayc@murrayc.com>
76 In the UI, allow primary keys to be any type, and test it.
78 * src/main/java/org/glom/web/shared/TypedDataItem.java:
79 Added isUnknownType() for convenience.
80 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
81 getToken(): Move some code into getStringForData() and handle
83 * src/main/java/org/glom/web/server/Utils.java:
84 Added transformUnknownToActualType(), to parse the unknown string
85 as a particular type of data. This should correspond with
86 getStringForData() above.
87 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
88 Add setDataItemType() to set the type of data for primary
90 getDetailsData(), getSuitableRecordToViewDetails():
91 Call it, to have the correctly-typed primary key value.
92 We do it here, on the server, instead of before, because it
93 is only here that we can know the field type that is in the
95 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
96 Added testGetPlaceParametersNumericPrimaryKey(),
97 testGetPlaceParametersBooleanPrimaryKey() and
98 testGetPlaceParametersDatePrimaryKey).
100 2012-11-30 Murray Cumming <murrayc@murrayc.com>
102 Allow primary keys to be any type, and test it.
104 * src/main/java/org/glom/web/shared/TypedDataItem.java:
105 Add overrides for the other set*() methods, to set the type.
106 Added getValue() which returns a generic Object.
107 * src/main/java/org/glom/web/server/SqlUtils.java:
108 buildSimpleWhereExpression(): Use TypedDataItem.getValue() instead of
110 * src/test/java/org/glom/web/server/SelfHostExampleNonNumericPrimaryKeysTest.java:
111 Added this test, which is much like SelfHostExampleTest, but which uses this
112 test file, take from Glom:
113 * src/test/resources/org/glom/web/server/test_example_music_collection_text_pk_fields.glom:
114 which has all the primary keys changes to text instead of numbers.
116 However, parts of the UI code still assume that primary keys are numbers.
118 2012-11-28 Murray Cumming <murrayc@murrayc.com>
120 SelfHostExampleTest: Move some checks into a utility function.
122 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
123 Move the data checks into a new file:
124 * src/test/java/org/glom/web/server/SelfHostTestUtils.java:
125 SelfHostTestUtils.java: so we can use it in some other
126 tests, with different documents.
128 2012-11-28 Murray Cumming <murrayc@murrayc.com>
130 SelfHosting test: Also try using a relationship.
132 * src/main/java/org/glom/web/server/database/DBAccess.java:
133 convertResultSetToDTO(): Move some code into a public
135 * src/main/java/org/glom/web/server/SqlUtils.java:
136 fillDataItemFromResultSet(): This takes a DataItem and
137 sets it from a value from a datbase recordset.
138 * src/main/java/org/glom/web/server/libglom/Document.java:
139 Make getDocument() public, so we can use it in a test.
140 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
141 Add testExampleMusiccollectionDataRelated() and call it from
142 testExampleMusiccollectionData(), to do a basic test of using
145 2012-11-22 Murray Cumming <murrayc@murrayc.com>
147 Build: Specify the source encoding.
149 * pom.xml: Set project.build.sourceEncoding
150 This should fix this build problem on some systems:
151 [ERROR] /var/lib/jenkins/workspace/OnlineGlom/src/test/java/org/glom/web/server/libglom/DocumentTest.java:[139,72] error: unmappable character for encoding ASCII
155 2012-11-20 Murray Cumming <murrayc@murrayc.com>
157 Update the jasperreports version.
159 * pom.xml: This was shown by
160 mvn versions:display-dependency-updates
162 2012-11-20 Murray Cumming <murrayc@murrayc.com>
164 Eclipse: Reorder the Java Build Path to fix the build in Eclipse.
166 * .classpath: This prevents an error saying that getTextContent()
168 See http://mergetag.com/the-method-gettextcontent-is-undefined-for-the-type-node/
170 2012-11-20 Murray Cumming <murrayc@murrayc.com>
172 Explicitly declare some dependencies (and scopes) that we use.
174 * pom.xml: The dependency report showed what we use.
176 2012-11-20 Murray Cumming <murrayc@murrayc.com>
178 Update the gwt-test-utils version.
180 * pom.xml: gwt-test-utils 0.43 uses GWT 2.5.0, not GWT 2.4.0.
181 Using both in the same project was causing gwt-log to fail in GWTBrige,
183 testOutOfBounds(org.glom.web.server.libglom.DocumentLayoutPathTest):
184 (class: com/google/gwt/core/client/GWT, method: setBridge signature: (Lcom/google/gwt/core/client/GWTBridge;)V) Incompatible argument to function
186 2012-11-19 Murray Cumming <murrayc@murrayc.com>
188 DocumentTest: testLocales(): Update for the latest example version.
190 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
191 The .glom file, updated in the previous commit, now has more translations.
193 2012-11-19 Murray Cumming <murrayc@murrayc.com>
195 Update the .glom files used for tests.
197 * src/test/resources/org/glom/web/server/example_film_manager.glom:
198 * src/test/resources/org/glom/web/server/example_music_collection.glom:
199 * src/test/resources/org/glom/web/server/libglom/example_film_manager.glom:
200 * src/test/resources/org/glom/web/server/libglom/example_music_collection.glom:
201 Copy them from git master of Glom.
203 2012-11-18 Murray Cumming <murrayc@murrayc.com>
205 Update versions of dependencies.
207 * pom.xml: Increase some version numbers based on the output of
208 , using mvn versions:display-dependency-updates.
209 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
210 Use the annotation instead of getModuleName().
211 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
212 Do not use deprecated assert() classes/methods.
214 2012-11-18 Murray Cumming <murrayc@murrayc.com>
216 Document: Correct an import to use the correct Log API.
218 * src/main/java/org/glom/web/server/libglom/Document.java:
219 Use our Utils.Log API rather than the jfree one that Eclipse
220 must have suggested at some time.
222 2012-11-15 Murray Cumming <murrayc@murrayc.com>
224 Details: Get static image data from our images services.
226 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
227 Add constructors for LayoutItemText and LayoutItemImage and
228 deal with their common type instead of just LayoutItemField.
230 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
232 * src/main/java/org/glom/web/client/ui/details/Group.java:
233 createChildWidget(): Use the other DetailsCell constructors for
234 these layout items, and do not add them to the list of
235 cells with data from the database.
236 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
237 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
238 Remove the image data when cloning the layout and storing it in the
239 cache. Clients will instead get it via the URL, from
241 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
242 doGet(): Depending on the URI parameters, optionally get
243 image data from a layout_item_image in the document,
245 * src/main/java/org/glom/web/server/database/DBAccess.java:
246 convertResultSetToDTO(): Move some URIBuilder code to:
247 * src/main/java/org/glom/web/server/Utils.java:
248 Add buildImageDataUrl() taking the primary key, etc, to
249 get data from the database.
251 2012-11-15 Murray Cumming <murrayc@murrayc.com>
253 Document: Static image items: Store an image URL, using the layout path.
255 * src/main/java/org/glom/web/server/Utils.java: Add buildImageDataUrl().
256 * src/main/java/org/glom/web/server/libglom/Document.java:
257 Add a constructor that takes the documentID, for use in the
259 loadLayoutNode(): Pass a Path object to the helper methods, so we
260 can use it to create a URL for LayoutItemImage items.
261 This seems as good a way as any to specify a layout item in the document.
262 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
263 Pass the documentID to the constructor, for use in the LayoutItemImage
266 2012-11-15 Murray Cumming <murrayc@murrayc.com>
268 Document: Add getLayoutItemByPath().
270 * src/main/java/org/glom/web/server/Utils.java:
271 Add buildLayoutPath() and parseLayoutPath().
272 * src/test/java/org/glom/web/server/LayoutPathTest.java: Test that these
273 utility methods work.
274 * src/main/java/org/glom/web/server/libglom/Document.java:
275 Add Add getLayoutItemByPath().
276 * src/test/java/org/glom/web/server/libglom/DocumentLayoutPathTest.java: Test
279 This will be useful in subsequent commits.
281 2012-11-15 Murray Cumming <murrayc@murrayc.com>
283 Document: Use a better base64 decoder to read static image data.
285 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
286 getNodeTextChildAsValue(): Use the apache commons base64 decoder
287 instead of the gwt one, because it correctly decodes the strings
288 from g_base64_encode(). It is probably more correct.
289 The newlines might be confusing the gwt decoder.
291 2012-11-14 Murray Cumming <murrayc@murrayc.com>
293 Document: Do not use == to compare strings. Use equals().
295 * src/main/java/org/glom/web/server/libglom/Document.java:
296 == only checks that they are the same object, so it can
299 2012-11-14 Murray Cumming <murrayc@murrayc.com>
301 Document: Add and use public constants for layout names.
303 * src/main/java/org/glom/web/server/libglom/Document.java:
304 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
305 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
306 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
307 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
308 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
309 them here instead of hard-coded the strings repeatedly.
311 2012-11-13 Murray Cumming <murrayc@murrayc.com>
313 Document: Load static text and image items too.
315 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
316 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
317 New LayoutItem classes to represent these layout items.
318 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
319 main text of a LayoutItemText.
320 * src/main/java/org/glom/web/server/libglom/Document.java:
321 load_after_layout_group(): Handle the node types and instantiate the
323 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
324 Add testLayoutItemText() to check that the text is loaded properly.
326 2012-11-13 Murray Cumming <murrayc@murrayc.com>
328 Do not use client.GWT for shared code.
330 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
331 Import shared.GWT instead of client.GWT, which seems to be appropriate.
333 2012-11-12 Murray Cumming <murrayc@murrayc.com>
335 Use image data when recreating databases for testing.
337 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
338 for use locally (not acrosss the network) when recreating databases
340 getValue(): Use it here instead of getImageDataUrl(), noting that
341 this method is only for use when recreating databases.
342 * src/main/java/org/glom/web/server/libglom/Document.java:
343 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
345 2012-11-09 Murray Cumming <murrayc@murrayc.com>
347 OnlineGlomImages: Detect the mime-type (content type).
349 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
350 doGet(): Instead of hard-coding image/png.
352 2012-11-09 Murray Cumming <murrayc@murrayc.com>
354 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
357 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
358 Java Compiler and Java Build path settings in the UI.
360 2012-11-09 Murray Cumming <murrayc@murrayc.com>
362 Use the latest (now stable) version of GWT.
364 * pom.xml: And the latest version of the gwt-maven-plugin.
366 2012-11-08 Murray Cumming <murrayc@murrayc.com>
368 Added an Indonesian translation.
370 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
371 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
372 This is from the new translation in Glom.
374 2012-07-23 Murray Cumming <murrayc@murrayc.com>
376 Details: Show images.
378 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
380 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
381 so it can be used in:
382 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
383 for serving image data.
384 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
386 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
387 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
388 setData(): For image field types, add a GWT Image widget,
389 with the URL that was set in the DataItem.
391 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
392 * src/main/java/org/glom/web/server/database/DBAccess.java:
393 convertResultSetToDTO(): Set the URL for image data, so the client browser
394 can retrieve the image from our new servlet. This uses UriBuilder.
395 Move getPrimaryKeyField to:
396 * src/main/java/org/glom/web/server/libglom/Document.java:
397 Added getTablePrimaryKeyField().
399 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
400 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
401 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
404 2012-07-22 Murray Cumming <murrayc@murrayc.com>
408 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
409 * src/main/java/org/glom/web/client/OnlineGlomService.java:
410 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
411 to gwtGlom, which is more appropriate.
412 This servlet name does not seem to be visible to the client side anyway.
414 2012-07-22 Murray Cumming <murrayc@murrayc.com>
416 Tests: Make the imports of assert*() consistent.
418 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
419 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
420 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
421 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
422 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
423 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
424 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
425 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
426 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
427 * src/test/java/org/glom/web/shared/DataItemTest.java:
429 import static org.junit.Assert.*;
430 which seems fairly common.
434 2012-07-21 Murray Cumming <murrayc@murrayc.com>
436 tests: Move a test that needs a database connection.
438 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
439 Move testGetListViewLayoutGroup() to
440 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
441 because it needs a database connection.
443 2012-07-21 Murray Cumming <murrayc@murrayc.com>
445 tests: Use @BeforeClass on tearDown().
447 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
448 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
449 This avoids leaking a postgres process in SelfHostExampleTest.
451 2012-07-21 Murray Cumming <murrayc@murrayc.com>
453 tests: Test translations more.
455 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
456 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
457 Test titles in the non-default locale.
459 2012-07-21 Murray Cumming <murrayc@murrayc.com>
461 tests: Add SelfHostConfiguredDocumentTest
463 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
464 username and password, for use by ConfiguredDocument.
465 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
466 This tests some of the ConfiguredDocument API that requires a database connection.
468 2012-07-21 Murray Cumming <murrayc@murrayc.com>
470 Document: Load title translations and test them.
472 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
473 of titles. I am surprised that we do not do this yet.
474 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
475 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
476 Test translations more.
478 2012-07-20 Murray Cumming <murrayc@murrayc.com>
482 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
483 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
484 Set the timeout here too.
486 2012-07-20 Murray Cumming <murrayc@murrayc.com>
488 tests: ConfiguredDocumentTest: Make this pass.
490 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
491 Disable tests that need a database connection.
493 2012-07-20 Murray Cumming <murrayc@murrayc.com>
495 Use Java 1.7 instead of Java 1.6.
497 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
498 to do this twice, at least for Eclipse.
499 This seems OK because it is the current version.
501 2012-07-20 Murray Cumming <murrayc@murrayc.com>
505 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
506 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
507 Avoid using a null Connection.
509 2012-07-20 Murray Cumming <murrayc@murrayc.com>
511 tests: Add a ConfiguredDocument test.
513 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
516 2012-07-20 Murray Cumming <murrayc@murrayc.com>
518 LayoutItemFIeld: getName(): Use the Field if it is set.
520 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
521 getName(): If the full field details have been set, return its name, so that
522 callers do not need to set the name separately.
523 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
524 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
525 so we can count the rows.
527 2012-07-20 Murray Cumming <murrayc@murrayc.com>
529 tests: SelfHoster: Test SqlUtils too.
531 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
532 Retrieve some data and check it too, as in the regular Glom
533 test_selfhosting_new_from_example.cc test.
534 * src/test/java/org/glom/web/server/SelfHoster.java:
535 createConnection(): Make this public.
537 2012-07-20 Murray Cumming <murrayc@murrayc.com>
539 tests: SelfHoster: createConnection(): Do not warn about expected failures.
541 Let the caller say if the connection is expected to fail, to avoid
542 irrelevant error output.
544 2012-07-20 Murray Cumming <murrayc@murrayc.com>
546 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
548 * src/test/java/org/glom/web/server/SelfHoster.java:
549 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
550 due to the inevitable need to retry the connection while the database server
553 2012-07-20 Murray Cumming <murrayc@murray.com>
555 tests: SelfHoster: createConnection(): Set a timeout.
557 * src/test/java/org/glom/web/server/SelfHoster.java:
558 createConnection(): Use setLoginTimeout() because it otherwise seems to take
559 ages to actually return when it fails.
561 2012-07-20 Murray Cumming <murrayc@murrayc.com>
563 tests: SelfHoster: selfHost(): Close the test connection.
565 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
566 When we check that the connection works, close the connection. This seems
567 to not be closed automatically otherwise.
569 2012-07-20 Murray Cumming <murrayc@murrayc.com>
571 Use slf4j-simple to see JDBC errors.
573 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
575 2012-07-19 Murray Cumming <murrayc@murrayc.com>
577 SelfHoster.discoverFirstFreePort(): Close the socket.
579 * src/test/java/org/glom/web/server/SelfHoster.java:
580 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
582 2012-07-19 Murray Cumming <murrayc@murrayc.com>
584 Avoid another code warning in Eclipse Juno.
586 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
587 Do instanceof checks on the FileUtils.listFiles() result and its
590 2012-07-13 Murray Cumming <murrayc@murrayc.com>
592 Avoid some code warnings in Eclipse Juno
594 * src/main/java/org/glom/web/server/libglom/Document.java:
595 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
596 * src/test/java/org/glom/web/server/SelfHoster.java
597 createTextFile(): Make sure that the FileOutputStream is closed.
599 2012-06-22 Murray Cumming <murrayc@murrayc.com>
601 Added OnlineGlomPropertiesTest.
603 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
604 Make sure we never return a null string.
605 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
606 Added tests of the OnlineGlomProperties API, using our sample file.
608 2012-06-20 Murray Cumming <murrayc@murrayc.com>
610 Make OnlineGlomProperties be a normal class.
612 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
613 Move OnlineGlomProperties into its own file to be a regular class:
614 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
615 This makes testing simpler.
617 2012-06-15 Murray Cumming <murrayc@murrayc.com>
619 OnlineGlomServiceImpl.init(): Move some code into a new method.
621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
622 Create addDocument().
624 2012-06-15 Murray Cumming <murrayc@murrayc.com>
626 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
629 OnlineGlomProperties.getKey(): Make this more robust by moving the
630 check for *.*.filename to here.
632 2012-06-15 Murray Cumming <murrayc@murrayc.com>
634 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
636 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
637 init(): Move knowledge of the config file format into the
638 OnlineGlomProperties inner class.
640 2012-06-15 Murray Cumming <murrayc@murrayc.com>
642 SelfHostExampleTest: Make sure we cleanup on failure.
644 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
645 the use of cleanup() to a tearDown() JUnit method.
649 2012-06-12 Murray Cumming <murrayc@murrayc.com>
651 ConfiguredDocument: Add a primary key to portals at least once.
653 * src/main/java/org/glom/web/server/ConfiguredDocument.java
654 updatePortalsExtras): Fix a typo so that we add the primary key
655 column at least once.
656 This is a fix for the previous commit:
657 ConfiguredDocument: Do not add a primary key to portals each time.
659 2012-06-08 Murray Cumming <murrayc@murrayc.com>
661 SelfHoster: Avoid some compiler warnings.
663 * src/test/java/org/glom/web/server/SelfHoster.java
664 executeCommandLineAndWait():
665 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
666 the now-unused streams for stdout and stderr from the command Processes.
667 These are not used because readln() hangs while waiting for a new line,
668 where there may be no next line. The commented out code is still there
669 to help us figure out how to do this properly.
671 2012-06-08 Murray Cumming <murrayc@murrayc.com>
673 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
675 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
676 Make this actually test the cloning again, though it is not very useful
677 now that we do not use the part that had a problem with cloning before.
679 2012-06-08 Murray Cumming <murrayc@murrayc.com>
681 SelfHoster: Keep trying pg_ctl after starting postgres.
683 * src/test/java/org/glom/web/server/SelfHoster.java
684 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
685 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
686 regular Glom. This seems mad but it seems to work because the first
687 command would fail if pg_ctl would eventually fail.
689 2012-06-08 Murray Cumming <murrayc@murrayc.com>
691 SelfHoster: Wait until the server is really ready.
693 * src/test/java/org/glom/web/server/SelfHoster.java
694 selfHost(): Attempt the connection after starting the server, retrying
695 a few times if necessary, so that the server is really ready already when
696 we return from this method.
697 The regular Glom code does this too because pg_ctl reports success too soon.
699 2012-06-08 Murray Cumming <murrayc@murrayc.com>
701 ConfiguredDocument: Do not add a primary key to portals each time.
703 * src/main/java/org/glom/web/server/ConfiguredDocument.java
704 updatePortalsExtras(): Only add an extra primary key field if there is
705 none, to avoid adding one each time we retrieve the details layout from the
707 This should fix bug #676986 (Ben Konrath)
709 2012-05-25 Murray Cumming <murrayc@murrayc.com>
711 Document.load(): Support version 7 documents.
713 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
714 database_title attribute if the title attribute is not there.
717 2012-05-24 Ben Konrath <ben@bagu.org>
719 Add configuration for auto-generating mvn:i18n from with Eclipse.
721 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
723 2012-05-24 Murray Cumming <murrayc@murrayc.com>
725 Update translations, adding French.
727 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
728 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
729 Add a French translation, using the translation from Glom.
731 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
732 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
733 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
734 Update these based on the translations from Glom.
736 2012-05-24 Murray Cumming <murrayc@murrayc.com>
738 SelfHoster: Add some debug println messages to help when things fail.
740 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
741 System.out.println() lines.
743 2012-05-23 Murray Cumming <murrayc@murrayc.com>
745 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
747 * src/test/java/org/glom/web/server/SelfHoster.java:
748 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
749 instance) instead of just /usr/bin (as on Fedora). Check the result when
752 2012-05-23 Murray Cumming <murrayc@murrayc.com>
754 Remove LayoutItemPortal.get/setNavigationTable().
756 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
757 Remove get/setNavigationTable(), which is only a cache, because it is not
758 used, and does not need to be used, because that decision should be made on
760 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
761 updatePortalsExtras():
762 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
763 getNavigationRecord():
764 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
767 2012-05-21 Murray Cumming <murrayc@murrayc.com>
769 Initial self-hosting for tests.
771 * pom.xml: Change the scope for log4j, to hopefully make it
772 available to the test code which uses it indirectly via jOOQ.
773 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
774 self-hosting, though we only use it for testing.
776 * src/main/java/org/glom/web/server/libglom/Document.java:
777 example rows: Use a map instead of a list for each row of values,
778 so we know what field they are for, instead of relying on the sequence
779 being correct. This is not very efficient, but it does not really need
781 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
782 testReadTableExampleRows(): Adapted.
784 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
785 that returns an Object, for generic use. Note that Object seems to be
786 the implicit base even of double.
787 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
788 for use in CREATE TABLE SQL queries.
789 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
790 to do self-hosting of PostgreSQL databases via its command-line
791 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
792 backends/postgres_self.cc. This is incomplete - it needs more
793 warnings about failures and it needs to clean up properly when things
795 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
796 test of this new class.
798 2012-05-21 Murray Cumming <murrayc@murrayc.com>
800 Document: loading example data: Handle exceptions.
802 * src/main/java/org/glom/web/server/libglom/Document.java:
803 DateFormat.parse() and Double.valueOf() can throw exceptions, though
804 Eclipse did not warn about that.
806 2012-05-20 Murray Cumming <murrayc@murrayc.com>
808 Document: load(), save(): Handle the example rows.
810 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
812 * src/main/java/org/glom/web/server/libglom/Document.java:
813 load(), save(): Load and save the example rows, though the date, time
814 and image types are not handled properly yet.
815 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
816 Add testReadTableExampleRows() just to check that something is read.
818 2012-05-20 Murray Cumming <murrayc@murrayc.com>
820 Document: Add save().
822 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
823 Added getTranslationsMap() for use while saving.
824 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
825 Adedd getUseDefaultFormatting() for use while saving.
826 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
827 and several private methods that it uses.
829 This will be useful while testing via self-hosting.
830 It is not complete, but should be complete enough for testing.
832 2012-05-17 Murray Cumming <murrayc@murrayc.com>
834 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
836 * src/main/java/org/glom/web/client/OnlineGlomService.java
837 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
838 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
839 Remove getSortedListViewData() and getSortedRelatedListData(), adding
840 the sort column index and ascending bool to the regular method.
841 Instead, a sort column index of -1 now means no sort.
842 This is less explicit, but it's fairly simple, reduces the amount of
843 code, and makes the OnlineGlomService API slightly smaller.
844 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
845 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
847 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
848 getListViewData(), getRelatedListData():
849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
850 getListViewData(), getRelatedListData():
851 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
853 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
855 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
860 2012-05-16 Murray Cumming <murrayc@murrayc.com>
862 Use translations for top-level groups too.
864 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
865 updateTitlesForLocale(): Use the translation for the group
866 as well as for child items.
870 Just recompiled to fix a problem in the released .tar.gz file.
874 2012-05-15 Murray Cumming <murrayc@murrayc.com>
876 Corrections to navigation to related records.
878 * src/main/java/org/glom/web/client/OnlineGlomService.java:
879 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
880 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
881 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
882 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
883 relationship name, because the relationship name is not necessarily unique
885 TOOD: This is inefficient, because it passes the whole list of
886 child field items back to the server, but it is more correct, and happens
887 to fix a bug with the primary key being lost after a few navigations.
888 There is probably a chance to make this more efficient anyway in some
891 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
892 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
893 * src/main/java/org/glom/web/server/ConfiguredDocument.java
894 * src/main/java/org/glom/web/server/database/DBAccess.java
895 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
896 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
899 2012-05-15 Murray Cumming <murrayc@murrayc.com>
901 Fix the use of translations.
903 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
904 Add updateTitlesForLocale().
905 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
906 Call it to discard unwanted translations and to make getTitle() return
907 the wanted translation wihout the need for the client code to specify a locale.
908 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
909 getTitle(): Fallback to the original title, as libglom does.
911 2012-05-15 Murray Cumming <murrayc@murrayc.com>
913 Document: Correctly report the number of available translation locales.
915 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
916 the available locale IDs list.
917 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
918 testLocales: Test this.
920 2012-05-15 Murray Cumming <murrayc@murrayc.com>
922 SqlUtils: Use camelCase.
924 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
925 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
926 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
927 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
928 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
929 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
931 2012-05-15 Murray Cumming <murrayc@murrayc.com>
933 Use jOOQ's tableByName() and fieldByName.
935 * pom.xml: Use jOOQ 2.3.1 to get the new API.
936 * src/main/java/org/glom/web/server/SqlUtils.java:
937 build_sql_select_step_with_where_clause(), .createField(),
938 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
939 so we can get correct quoting and escaping. Thanks to Lukas Eder for
940 adding this, and other things, to jOOQ.
942 2012-05-15 Murray Cumming <murrayc@murrayc.com>
944 SqlUtils: Remove the Connection parameters.
946 * src/main/java/org/glom/web/server/SqlUtils.java:
947 build_sql_select_with_key(), build_sql_select_with_where_clause(),
948 createSelect(), build_sql_select_step_with_where_clause(),
949 build_sql_count_select_with_where_clause(),
950 build_sql_select_count_rows(): Remove the Connection parameter because
951 jOOQ does not actually need a connectionwhen it is just used to build
953 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
955 * src/main/java/org/glom/web/server/ReportGenerator.java:
957 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
959 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
960 Constructor, getListData(), getResultSizeOfSQLQuery():
961 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
962 getSelectQuery(), getCountQuery():
963 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
964 getSelectQuery(), getCountQuery():
965 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
966 getNavigationRecord(): Adapted.
968 2012-05-14 Murray Cumming <murrayc@murrayc.com>
972 * src/main/java/org/glom/web/server/SqlUtils.java:
973 get_find_where_clause_quick(): Use a comparison of
974 lowercase values, instead of a simple equals. Regular Glom
975 uses the PostgreSQL ILIKE operator but jOOQ does not
976 support that just yet, though it will soon.
978 2012-05-14 Murray Cumming <murrayc@murrayc.com>
980 TableToViewDetails: Use a real serialization ID.
982 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
983 Though this does not fix the serialization problem.
985 2012-05-12 Murray Cumming <murrayc@murrayc.com>
987 Added LayoutItemPortalDeepCloneTest.
989 2012-05-11 Murray Cumming <murrayc@murrayc.com>
991 Make navigation work again.
993 * src/main/java/org/glom/web/server/libglom/Document.java:
994 Add getLayoutItemFieldShouldHaveNavigation().
995 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
996 Replace get/setAddNavigation() with the partly-existing
997 get/setNavigationTableName(), with an empty string being no navigation,
998 because this is simpler. Use the new
999 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
1001 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1002 Add updateFieldsExtras() and call setNavigationTableName in it.
1003 getDetailsLayoutGroup(),
1004 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1005 createLayout(): Adapted.
1006 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1007 Constructor: Adapted.
1009 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1010 Replace get/setAddNavigation() with get/setNavigation(), returning a
1011 TableToViewDetails class with both the table name and UsesRelationship,
1012 because both are need. The previous code used java-libglom's output
1013 variable (strangely, via sharedptr) to return both, but we cannot really
1015 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1016 getNavigationRecord(): Adapt. However, we cannot actually use the cache
1017 here because it somehow gets set to null during deepCopy(). I must test this.
1018 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
1019 testGetSuitableTableToViewDetails(): Adapted.
1021 TODO: Find out why deepClone() is not quite working.
1023 2012-05-11 Murray Cumming <murrayc@murrayc.com>
1025 DBAccess: Simplify the retrievel of full field details.
1027 * src/main/java/org/glom/web/server/database/DBAccess.java
1028 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
1029 because the Document loading should have done this.
1031 2012-05-11 Murray Cumming <murrayc@murrayc.com>
1033 Document: Correct loading of doubly-related layout fields.
1035 * src/main/java/org/glom/web/server/libglom/Document.java:
1036 loadUsesRelationship(): Actually set the related relationship, instead
1037 of only setting it if it's not found.
1039 2012-05-09 Murray Cumming <murrayc@murrayc.com>
1041 Replace all appearances of Colour with color.
1043 Because US English is dominant.
1045 2012-05-09 Murray Cumming <murrayc@murrayc.com>
1047 Use colors in HTML format, solving a warning about an unused function.
1049 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
1050 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
1051 Add *asHTMLColor() versions of methods.
1052 TODO: However, we should create and cache the results on the server.
1053 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1054 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1055 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1056 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1057 Use the asHTMLcolor() versions.
1059 2012-05-09 Murray Cumming <murrayc@murrayc.com>
1061 ListViewTable: Constructor: Take the table name as a parameter.
1063 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1064 Constructor: Take the tableName, and set the member variable, because
1066 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1067 setCellTable(): Pass the table name.
1068 This makes navigation to non-default tables work again. I don't know
1069 why it worked before in the master branch.
1071 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1073 ConfiguredDocument: Restore correct addition of hidden primary key items.
1075 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1076 (ListTable.createCellTable): Uncomment out the check for the hidden
1078 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
1079 add primary key items for top-level lists and portals, as before,
1080 instead of adding them to each group.
1081 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
1082 Actually implement the extra methods such as setHiddenPrimaryKey() and
1083 comment that these are used only for top-level list groups and in portals.
1084 This strangeness suggests even more that this should not be squeezed
1085 into the LayoutGroup class.
1087 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1089 Fix Formatting loading.
1091 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1092 getFormattingUsed(): Remove the duplicate Formatting member variable
1093 in favour of the one from the base class.
1094 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
1095 Initialize a new Formatting instead of using null by default, so we
1096 have some defaults, instead of having to initialize one later just to
1097 get the same defaults. This also makes loading of formatting from the
1098 document work, because that expected a non-null.
1100 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1102 RelatedListTable: Make sure that the tableName is set.
1104 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1105 Constructor: Take the tableName so it is available later. Otherwise,
1106 the server assumes that we mean the default table and cannot find the
1108 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1109 setData(): Pass the tableName to the RelatedListTable constructor.
1111 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1115 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1116 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
1117 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1119 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1121 * src/main/java/org/glom/web/server/database/DBAccess.java:
1122 convertResultSetToDTO(), getPortal():
1123 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1125 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1126 Add checks for null objects and out of range access, with log messages to
1127 give hints so we can fix these properly.
1129 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1131 Portals: some corrections.
1133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1135 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1136 constructor: Use getRelationshipNameUsed() instead of getName(), because
1137 that is what is meant.
1138 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1139 getFromField(): Fix a typo, to get the field name, not the table name.
1140 * src/main/java/org/glom/web/server/database/DBAccess.java:
1141 getPortal(): Fix a typo that stopped this from working.
1143 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1145 LayoutItemPortal: Also override getTitleOriginal().
1147 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1148 This lets the base getTitle() with no parameters work.
1149 TODO: Test this properly.
1151 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1153 LayoutItemPortal: getTitle*(): Use the relationship title.
1155 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1157 LayoutItemField: Fix loading of custom titles.
1159 * src/main/java/org/glom/web/server/libglom/Document.java
1160 loadDataLayoutItemField(): The title, if any, instead of the field
1161 title, is stored in a title_custom node. Load it from there.
1162 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
1164 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
1165 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
1166 getTitle*() overrides.
1167 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1170 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1172 LayoutItemField: Fall back to field titles, so some are really shown.
1174 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1175 Override getTitleOriginal() and getTitle(), as in java-libglom.
1176 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1177 Test this behaviour.
1179 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1181 Correct use of setExpectedResultSize().
1183 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1184 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
1185 Use setExpectedResultSize only on top-level groups (for instance, the
1186 list layout) or on child portals (in details views).
1187 Use the correct table name for portals to avoid SQL errors.
1188 Update the expected counts when returning cached layouts.
1190 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1192 Document: Interpret no group column count as 1.
1194 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
1195 default, though we now check for this in the UI code anyway.
1197 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1201 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1203 Translatable: Use Hashmap instead of Treemap because GWT supports it.
1205 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
1206 The use of Treemap lead to this error from async methods, with no
1208 "The response could not be deserialized"
1210 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1212 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
1214 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
1215 when using the Google -> GWT Compile, or
1216 g toolbar button -> GWT Compile Project... feature in Eclipse.
1218 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1220 ListTable.addColumn(): Protect against a null Formatting.
1222 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
1223 Create a default Formatting if it is null, because that is the simplest
1226 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1228 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
1230 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1231 updateLayoutGroup(): Check that the field is not null.
1233 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1235 ListViewImpl: Protected against a bad cast error.
1237 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1238 onEnterKeyDown(): Do not cast without an instanceof check.
1240 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1242 ListTable: Protect against an out of range error.
1244 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1245 createCellTable(): This is unlikely, but can happen while debugging.
1247 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1249 AsyncMessage onFailure() callbacks: Log the exception message.
1251 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1252 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1253 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1254 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1255 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1256 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1257 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1258 These are useful clues when something is wrong.
1260 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1262 ConfiguredDocument: Avoid a null dereference.
1264 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1265 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
1266 details maps are created.
1268 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1270 Document: Correct the port number parsing.
1272 * src/main/java/org/glom/web/server/libglom/Document.java:
1273 This lets us actually connect to the database and show the document.
1275 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1279 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1280 user-interaction, asking us to load a temporary URL in a browser.s
1281 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1282 which is apparently necessary for testing the service. See the comment.
1283 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1284 Show the exception, if any. This is how I saw the 404 in the HTML in
1287 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1289 DocumentTest: Move the .glom files into the resources directory.
1291 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1292 URI via getResource().
1294 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1296 Document: Remove the FieldIdentifies inner class.
1298 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1299 use the Relationship (though the same function in libglom is maybe
1300 used in other ways) and so this removes a compiler warning.
1302 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1304 Document.load() Remove the error code parameter.
1306 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1307 Remove the parameter. We do not set it yet and it could never have
1308 worked as an output parameter (though maybe it did in java-libglom).
1309 We could use an exception if we really want the failure reason.
1310 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1312 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1313 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1315 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1317 Make some inner classes static.
1319 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1320 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1321 * src/main/java/org/glom/web/server/ReportGenerator.java
1322 * src/main/java/org/glom/web/server/libglom/Document.java
1323 Make all inner classes static that can be static.
1325 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1327 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1329 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1330 init(): We do not use java-libglom any more.
1332 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1334 Remove mentions of java-libglom.
1336 * README: Remove mention of java-libglom, because it no longer needed.
1337 * utils/build-onlineglom-war.sh:
1338 * utils/check-and-recover-tomcat.py:
1339 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1340 useful. Building is now far easier, with no need for jhbuild.
1342 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1344 Fix the build (mvn package)
1346 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1347 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1348 Otherwise the GWT Java->Javascript compilation fails with just this
1349 error, during mvn package or when attempting to view in a browser,
1350 in the GWT developer mode in Eclipse.
1352 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1353 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1354 [INFO] Compiling module org.glom.web.OnlineGlom
1355 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1356 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1357 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1358 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1359 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1360 [INFO] [ERROR] Cannot proceed due to previous errors
1362 It has taken me 2 days to find out what was causing that. After reducing
1363 the code, the compiler eventually showed me the full error message.
1365 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1367 ConfiguredDocument: Cache the cloned and stripped layouts.
1369 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1370 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1371 layout in a map, so we can retrieve it again without rebuilding it.
1373 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1375 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1377 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1379 libglom classes: Implement some auto-generated emthods.
1381 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1383 Add GwtTestOnlineGlomService.
1385 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1386 However, this (and the other GwtTest*) does not seem to run during
1389 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1391 Remove use of unsupported features from client code.
1393 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1394 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1395 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1396 Use our client version of StringUtils instead of the apache commons one.
1398 However, the GWT Javascript compliation still fails.
1400 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1402 Add a Field class and implement some loading of it in Document.
1404 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1406 Initial Document loading implementation, instead of libglom.
1408 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1409 and Translatable classes, and adapt the rest of the code to use them.
1410 However, this is still missing Layout and Field classes and loading.
1412 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1414 Use of jOOQ: Move Field creation into a utility method.
1416 * src/main/java/org/glom/web/server/SqlUtils.java:
1417 This lets us improve it more easily.
1419 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1421 Use of jOOQ: Improve the code to COUNT a sub-select.
1423 * src/main/java/org/glom/web/server/SqlUtils.java:
1424 Move initial query creation into
1425 build_sql_select_step_with_where_clause().
1426 build_sql_select_count_rows(): Use the jOOQ API instead of
1427 concatentating text, because a jOOQ Select*Step is a TableLike,
1428 which is what from() takes.
1430 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1432 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1434 * pom.xml: Depend on jooq.
1435 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1436 methods with jOOQ, based on the C++ implementations in libglom,
1437 with some changes to the logic required by jooQ.
1438 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1440 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1441 * src/main/java/org/glom/web/server/ReportGenerator.java:
1442 * src/main/java/org/glom/web/server/SqlUtils.java:
1443 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1444 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1445 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1446 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1447 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1448 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1449 because jOOQ needs that, though it seems unnecessary.
1451 This is not quite finished. Ideally jOOQ would help us to build
1452 table_name.field_name names, quoting and escaping them properly.
1453 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1455 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1457 Move use of Glom.build_sql*() into a new SqlUtils class.
1459 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1460 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1461 but this will make it easier to start using something other than
1462 libglom or SqlBuilder.
1464 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1466 Update the project URL.
1468 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1470 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1472 Main layout: Use a FlowTable instead of absolute positioning.
1474 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1475 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1476 child panels/widgets must have an absolute position. But that is annoying, so
1477 this adds a FlowTable and puts the child panels in there.
1479 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1481 GwtTestOnlineGlom: Comment out unused code.
1483 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1484 Eclipse has started to say that some code is unused.
1486 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1488 Update to the latest versions of dependencies.
1490 * pom.xml: Update version numbers of dependencies to the latest
1492 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1493 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1494 * src/main/java/org/glom/web/server/ReportGenerator.java:
1495 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1496 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1497 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1499 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1500 Modify the imports where necessary.
1502 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1504 Style: Remove overflow:hidden from searchbox
1506 * src/main/webapp/style.css: Because this pushes the Back To Link
1507 label/link on to the next row, which is then hidden due to the
1508 hard-coded (in ems) height.
1510 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1512 Remove some duplicate code.
1514 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1515 getDocumentInfo(): This must have been duplicated during the merge from the
1520 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1522 Reports: Localize the waiting for report message.
1524 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1525 start(): Get the message from the contants.
1526 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1527 Add the string here.
1528 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1529 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1530 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1531 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1532 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1533 Update these files with the English text for newer strings for now.
1535 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1537 Reports: Show a message while waiting for the report.
1539 * src/main/java/org/glom/web/client/ui/ReportView.java
1540 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1541 Add setWaitingText(), to show a message saying that we are
1542 waiting for the report to be ready.
1543 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1544 start(): Call setWaitingText() before calling the async
1547 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1549 ReportGenerator: Specify date and time formats.
1551 * src/main/java/org/glom/web/server/ReportGenerator.java:
1552 createFieldValueElement(): Use the default (and localized)
1553 short formats, though we still need a way to show 4-digit
1554 years without providing the format for every locale.
1555 * src/main/java/org/glom/web/server/database/DBAccess.java:
1556 convertResultSetToDTO(): Use the short formats here too.
1558 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1560 ReportGenerator: Use the correct numeric formatting.
1562 * src/main/java/org/glom/web/server/ReportGenerator.java
1563 createFieldExpression(), createFieldValueElement(): Take the
1564 whole LayoutItem_Field instead of just the field name, so
1565 we have access to the formatting.
1566 createFieldValueElement(): Use JRTextField.setPattern() to
1567 specify the numeric formatting, with the help of a
1568 regular DecimalFormat.
1570 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1572 ReportGenerator: Avoid showing null for group by titles.
1574 * src/main/java/org/glom/web/server/ReportGenerator.java
1575 generateReport(): Use setBlankWhenNull() on the field title
1576 style too, because this is used for values in group by
1579 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1581 ReportGenerator: Add a colon to titles in vertical groups.
1583 * src/main/java/org/glom/web/server/ReportGenerator.java
1584 addFieldToDetailBandVertical(): Pass true for the withColon
1587 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1589 ReportGenerator: Simplify the code by using Position more.
1591 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1593 Reports: Support vertical groups, roughly.
1595 * src/main/java/org/glom/web/server/ReportGenerator.java:
1596 addToReport(): Rename to addGroupToReport() and, if necessary,
1597 call the new addVerticalGroupToReport() method.
1598 createFieldValueElement(): Let the caller specify the Y position
1601 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1603 Reports: Allow a second report to be shown.
1605 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1606 clear(): Do not remove the HTML widget, which broke the whole layout.
1608 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1610 Locales drop-down: Show that we use English by default.
1612 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1613 fillView(): When we use English, just because that is the default, when
1614 no locale is specified, show that in the Locales drop-down instead of
1615 just showing the first item.
1617 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1619 Unselect the Report/Locale/Table combo item when appropriate.
1621 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1622 setPlace(): clear reportName if this is not a ReportPlace.
1623 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1624 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1625 When the provided name is empty, unselect all items, so that none are
1626 indicated. This uses a for loop because I cannot find a single method
1629 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1631 Report: Give the user a way to get back to the list.
1633 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1634 start(), setPlace(): Show the Back To List link on reports, and also
1635 interpret selecting the empty report item as back to list.
1637 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1639 Really show the selected Report name.
1641 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1642 setPlace(): Store the reportName here, if it is that kind of Place.
1643 fillView(): Set the selected Report after filling the list of reports.
1644 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1645 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1646 null Strings, though we need some way to unselect all ListBox items
1649 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1651 ReportGenerator: Try to avoid some problems.
1653 * src/main/java/org/glom/web/server/ReportGenerator.java
1654 addField(): Try to avoid duplicates, and avoid using a null
1657 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1659 Reports: Use quickFind.
1661 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1662 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1664 getReportHTML(): Add a quickFind parameter.
1665 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1666 start(): Pass the quickFind parameter.
1667 * src/main/java/org/glom/web/server/ReportGenerator.java
1668 generateReport(): Take a quickFind parameter.
1670 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1672 ReportPlace: Actually use the report name.
1674 * src/main/java/org/glom/web/client/place/ReportPlace.java
1675 getPlace(): Do not assign the report name to the quickfind.
1677 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1679 Show java.library.path when complaining.
1681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1682 init(): When telling us to check java.library.path, show the
1685 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1687 ReportGenerator: Do not show nulls.
1689 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1691 ReportGenerator: Make the title font larger.
1693 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1695 ReportGenerator: Put field titles inside groups, if there are groups.
1697 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1699 ReportGenerator: Take the Report itself instead of the name and group.
1701 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1702 Remove getReportLayoutGroup().
1703 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1704 getReportHTML(): Pass the report instead
1705 of its name and layout group.
1706 * src/main/java/org/glom/web/server/ReportGenerator.java
1707 generateReport(): Use the report object to use the title
1708 instead of the name.
1710 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1712 ReportGenerator: Remove designBand parameters.
1714 * src/main/java/org/glom/web/server/ReportGenerator.java:
1715 Make designBand a class member instead of passing it to all
1718 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1720 ReportGenerator: Add lines, a bit like in the desktop version.
1722 * src/main/java/org/glom/web/server/ReportGenerator.java
1723 addToReport(): Use JRDesignLine.
1725 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1727 ReportGenerator: Correct the title positions and use some bold style.
1729 * src/main/java/org/glom/web/server/ReportGenerator.java:
1730 Break the code up into reusable functions, correct the placement of
1731 titles, and use normal/bold styles as in the reports in the desktop
1734 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1736 ReportGenerator: Add a header band to show the field titles.
1738 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1739 getReportHTML(): Pass the localeId to the ReportGenerator
1741 * src/main/java/org/glom/web/server/ReportGenerator.java
1742 constructor: Take the localeID so we can get translated field
1744 generateReport(), addToReport(), addFieldToBand(): Add field
1745 titles in a column header band.
1747 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1749 Reports drop-down list: Some improvement.
1751 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1752 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1753 Adedd setSelectedReport(),
1754 setReportList(): Add a blank line so that the user can select the
1756 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1757 start(): Show the current report by calling setSelectedReport().
1758 This does not seem to work yet.
1760 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1762 DetailsActivity, ListActivity: Move some variables into a base class.
1764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1765 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1766 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1767 the clientFactory, documentID, tableName and authenticationPopup into
1768 a base class, to avoid duplication.
1770 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1772 Translate the Reports label.
1774 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1775 Get the "Reports" label string from the constants.
1776 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1777 perties: Add Reports to the constants.
1779 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1781 Reports: Implement grouping.
1783 * src/main/java/org/glom/web/server/ReportGenerator.java:
1784 Handle LayoutItem_GroupBy items and try to do the right thing
1785 with JRDesignGroup. It seems to work.
1787 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1789 Actually show some data with JasperReports.
1791 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1792 getReportHTML(): Move most code into a ReportGenerator class.
1793 * src/main/java/org/glom/web/server/ReportGenerator.java:
1794 Recurse into sub-groups, adding fields to the JasperDesign's details
1795 band. Note that we must set an arbitrary width and height, or it just
1796 will not show any data.
1798 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1800 Reports Chooser: Show the titles, not the names.
1802 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1803 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1804 and the names as the values.
1805 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1806 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1807 group now that we provide the report name, so it should always
1810 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1812 Depend on jasperreports.
1814 * pom.xml: Add the dependency. My plan is to use this on the
1817 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1819 Implement navigation to report places.
1821 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1822 start(): Do not bother to handle all events here.
1823 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1824 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1825 Added getSelectedReport().
1826 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1827 .java: start(): When handling a change to the reports chooser,
1828 call getSelectedReport() and goTo() its ReportPlace.
1829 * src/main/java/org/glom/web/client/ui/ReportView.java
1830 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1831 Added setReportHTML() which puts the html in a gwt HTML widget.
1832 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1833 getReportHTML(): Return "TODO" just to show that this works.
1835 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1837 Make ReportPlace usable.
1839 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1840 Mention ReportPlace.
1841 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1842 Correct the @prefix annotation.
1844 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1846 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1848 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1849 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1851 Change getReportLayout() to getReportHMTL() because we will not need to
1852 parse or render the report layout on the client side.
1853 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1854 getReportLayout(): Return the libglom LayoutGroup type because we will
1855 not need to convert to a shared type, because this will not be used on
1857 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1860 Note that there is still no implementation for this.
1863 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1865 Add a (empty) Report Place, View, and Activity.
1867 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1869 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1870 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1871 this into a superclass:
1872 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1873 and also use it as the base of this new ReportPlace:
1874 * src/main/java/org/glom/web/client/place/ReportPlace.java
1876 * src/main/java/org/glom/web/client/ui/ReportView.java
1877 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1878 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1879 Add these, containing mostly boiler-plate for now.
1881 * src/main/java/org/glom/web/client/OnlineGlomService.java
1882 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1883 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1885 Add API to get the LayoutGroup for the report.
1887 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1889 Add and fill a Reports drop-down list box.
1891 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1893 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1894 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1895 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1896 Added getReports(document, table, localeID), calling
1897 ConfiguredDocument.getReports().
1898 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1899 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1900 Added setReportsList() and a list widget.
1901 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1902 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1907 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1909 Translations: Add Esperanto.
1911 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1912 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1913 properties: Add this translation because someone took the time to make it.
1915 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1917 Adapt to the java-libglom 1.21.7 API.
1919 * src/main/java/org/glom/web/server/ReportGenerator.java:
1920 addToReport(): get_group_secondary_fields() is now
1921 get_secondary_fields().
1924 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1926 Use the latest java-libglom version.
1928 * pom.xml: Use java-libglom 1.21.7.
1930 2012-03-03 Ben Konrath <ben@bagu.org>
1932 Display date and time in details view.
1934 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1936 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1938 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1940 Require the latest java-libglom.
1942 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1944 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1946 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1948 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1949 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1950 an empty quickfind string. I also corrected libglom to create only
1951 empty where clauses for empty quickfind strings, but this avoids the
1954 2012-02-24 Ben Konrath <ben@bagu.org>
1956 Improve the tabs in the Notebook widget.
1960 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1962 Translations: Try to translate the strings.
1964 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1965 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1966 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1967 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1968 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1969 Take the Open translation from GTK+'s .po files.
1970 Take the Details translation from Glom's po files.
1971 I have added the other strings to Glom so we can get translations that way:
1972 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1974 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1976 TableSelectionViewImpl: Put the search label and entry in a div.
1978 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1979 Put the search widgets in a FlowTable so that the CSS can be used to
1980 style them while keeping them together.
1981 * src/main/webapp/style.css: Mention the new div.
1983 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1985 Translate more strings in more locales.
1987 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1988 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1989 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1990 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1991 Translate the "Details" and "Open" string too.
1993 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1994 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1995 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1996 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1997 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1998 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1999 Add these new locales as placeholders though they currently contain English.
2001 2012-01-27 Murray Cumming <murrayc@murrayc.com>
2003 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
2005 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
2006 Check the ConfiguredDocument* for null before using it.
2008 2012-01-26 Murray Cumming <murrayc@murrayc.com>
2010 Tell Eclipse about the generated java files.
2012 * .classpath: This lets it find OnlineGlomConstants.java.
2013 It would be nice if Eclipse just used the maven build files.
2015 2012-01-26 Murray Cumming <murrayc@murrayc.com>
2017 Prevent a crash when no locale is specified in the URL.
2019 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
2020 Avoid returning a null string, obtained from
2021 Window.Location.getParameter(). This caused a crash when it was
2022 later passed to libglom's API.
2023 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2024 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
2025 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
2026 guard against future null strings.
2028 2012-01-26 Murray Cumming <murrayc@murrayc.com>
2030 Use the ?locale= query param instead of the &lang= token param.
2032 * src/main/java/org/glom/web/client/place/ListPlace.java
2033 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2034 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2035 Remove the lang token key and value.
2037 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2038 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2039 When the user selects a different locale from the chooser, use
2040 Window.Location.assign() to change the URL, which then causes a reload.
2042 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
2043 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2044 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
2045 * src/main/java/org/glom/web/client/activity/ListActivity.java
2046 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2047 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2048 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2049 * src/main/java/org/glom/web/client/ui/ListView.java:
2050 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2052 Remove localeID member variables and method/constructor parameters, instead
2053 using Utils.getCurrentLocaleID() when we need a localID to pass to
2056 2012-01-26 Murray Cumming <murrayc@murrayc.com>
2058 Internationalize the UI strings.
2060 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
2061 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
2062 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
2063 because it is unused. Messages are apparently strings that can have
2064 parameters, but we do not need that yet, so Contants will be enough for now.
2065 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
2066 to say that we support the en and de locales.
2067 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
2068 The original English strings.
2069 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
2070 Some German translations of the English strings.
2071 The i18n goal then uses the .properties file to generate an
2072 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
2073 returns an implementation that returns the translated strings.
2074 The documentation suggests putting these in src/java/*/client/, but it seems
2075 best to put it in src/resources/*/client/.
2076 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2077 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
2078 instead of hard-coding them.
2079 Note that we cannot import OnlineGlomConstants because it does not exist yet,
2080 but that does not seem to stop the build, though it confuses Eclipse.
2082 You can see the translated string by adding ?locale=de to the URL, like so:
2083 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
2085 2012-01-24 Murray Cumming <murrayc@murrayc.com>
2087 Improve null/empty String checks.
2089 * pom.xml: Add a dependency on commons-lang, to use
2090 org.apache.commons.lang.StringUtils.
2091 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2093 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
2094 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2095 Use StringUtils.isEmpty().
2097 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
2098 StringUtils class with a static isEmpty() function because we
2099 cannot use org.apache.commons.lang.StringUtils in client-side
2100 GWT code because it (apparently) cannot be compiled to javascript.
2101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2102 * src/main/java/org/glom/web/client/activity/ListActivity.java
2103 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
2104 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2105 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2106 * src/main/java/org/glom/web/client/place/ListPlace.java
2107 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
2108 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
2109 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
2110 * src/main/java/org/glom/web/client/ui/details/Group.java
2111 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
2112 our StringUtils.isEmpty() function.
2114 2012-01-24 Murray Cumming <murrayc@murrayc.com>
2116 Update to the latest java-libglom API.
2118 * pom.xml: Require java-libglom 1.21.4.
2119 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2120 getDocumentInfo(), getListViewLayoutGroup():
2121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2123 * src/main/java/org/glom/web/server/database/DBAccess.java
2124 getFieldsToShowForSQLQueryAddGroup(),
2125 getPrimaryKeyLayoutItemField(): Replace get_database_title()
2126 with either get_database_title_original() or
2127 get_database_title(localeID).
2129 2012-01-24 Murray Cumming <murrayc@murrayc.com>
2131 ConfiguredDocument: Avoid a null pointer exception.
2133 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2134 Initialize localeID to "" to avoid returning a null String which
2135 causes a crash in java-libglom's swing-generated code.
2137 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2139 Some simple renaming.
2141 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2142 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
2143 for localeChooser. This seems more appropriate and is less ambiguous
2144 particularly in the .css file.
2146 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2148 ConfiguredDocument: Rename the localedID private member variable.
2150 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2152 Adapt to the latest java-libglom API from git master.
2154 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2155 libglom now uses only Vector instead of List, which uses add() instead of
2158 2012-01-22 Murray Cumming <murrayc@murrayc.com>
2160 ConfiguredDocument: Rename the localedID private member variable.
2162 2012-01-20 Murray Cumming <murrayc@murrayc.com>
2164 Build a source tarball with mvn assembly:single
2166 * assembly.xml: Add this file.
2167 * pom.xml: Use the maven-assembly-plugin and tell it to use
2168 our assembly.xml file.
2170 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2172 OnlineGlomServiceImpl: Get .glom files recursively.
2174 * pom.xml: Depend on commons-io from org.apache.commons.
2175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2176 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
2177 files recursively, and with the easier filter for the extension.
2178 Use org.apache.commons.io.FilenameUtils.removeExtension() to
2179 simplify that code too.
2181 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2183 README: Mention that you must install java-libglom packages separately.
2185 But then it works, because java-libglom is now in the central maven
2188 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2190 locales drop-down: Show the correct selected locale when the URL changes.
2192 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2193 .java: setPlace(): Move some code into fillView().
2195 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2197 locales drop-down: Do not lose the primary key.
2199 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2200 start(): onLocaleChange(): Pass the current primary key value,
2201 instead of an empty value.
2203 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2205 locales drop-down: Do not lose the drop-down selection.
2207 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2208 .java (TableSelectionActivity.fillView): Set the selected locale
2209 after changing the drop-down items (though we do not really need
2210 to change them just because the locale changes.)
2212 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2214 locales drop-down: Change the tables list when this changes.
2216 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2217 .java: TableSelectionActivity.start(): Move the async table titles
2218 retrieval into a private fillView() method and also call this when
2219 the chosen locale changes.
2220 Note that the document title is not actually translatable yet, but
2221 that is a problem that I should fix soon in libglom.
2223 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2225 Improve the placement of the locales drop-down.
2227 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2228 Put the title and locales drop-down in a div (gwt.FlowTable).
2229 * src/main/webapp/style.css: Add magic css properties to make this work.
2230 Also remove the left margin from the title so that it lines up with the
2233 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2235 locales selector: Show human-readable locale titles.
2237 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2238 getDocumentInfo(): Use java.util.Locale to show a real title of
2239 each locale, in the locale's own language.
2241 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2243 Add a language/locale selector drop-down.
2245 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2246 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
2247 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
2248 getDocumentInfo(): Store the available Locales in the DocumentInfo.
2249 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2250 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2251 Add a ListBox to show the available locales. Add getLocaleSelector(),
2252 setLocaleList(), getSelectedLocale(), setSelectedLocale().
2253 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
2254 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
2255 java: Add these classes.
2256 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2257 start(): Fill the locales ListBox. Handle its change event, firing a
2259 setPlace(): Show the selected locale as specified by the URL token.
2260 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2261 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2262 Handle LocaleChangeEvent, going to a new *Place with that locale.
2264 The placement of the ListBox is not pretty, and it currently uses the ID
2265 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
2269 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2271 Search box: Show the search text from the URL token.
2273 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2274 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2275 Add setQuickFindText().
2276 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2277 .java: setPlace(): Store the queryText if the place is a ListPlace,
2278 and call TableSelectionView.setQuickFindText().
2280 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2282 Allow use of translations via, for instance, &lang=de in the URL.
2284 * pom.xml: Use the unstable java-libglom 1.21 version.
2286 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2287 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2288 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2289 init(): Instead of calling TranslatableItem.set_current_locale()
2290 (now removed), call ConfiguredDocument.setDefaultLocaleID().
2291 However, this is only for default locales, which are not needed to
2292 change the locale in the URL.
2293 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2294 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2295 getSortedRelatedListData(): Add a localeID parameter, so we can get the
2296 layout for a particular locale.
2297 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2298 Add get/setDefaultLocaleID().
2299 getDocumentInfo(), getListViewData(), getRelatedListData(),
2300 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2301 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2302 localeID parameter, so we can get the layout for a particular locale.
2304 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2305 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2306 * src/main/java/org/glom/web/client/place/ListPlace.java:
2307 Parse and construct a lang parameter too.
2309 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2310 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2311 passed to subsequent methods and constructors.
2312 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2313 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2314 Store the localeID from the *Place and pass it to other constructors
2315 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2317 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2318 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2319 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2320 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2321 * src/main/java/org/glom/web/client/ui/ListView.java:
2322 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2323 Take localeID parameters and pass them to subsequent constructors and
2324 methods, so that the layout is always retrieved for that locale.
2326 This is rather repetitive.
2328 Note that "" means the original (default) locale of the Glom document,
2329 which is usually English.
2331 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2333 Documents: Remove final keyword to fix startup configuration.
2335 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2336 final keywords on the private member variables because that breaks
2337 the startup, apparently (there are warnings) because it stops them
2338 from being serialized. I added these in the previous commit.
2340 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2342 Documents: Add some final keywords.
2344 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2347 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2349 OnlineGlomServiceImpl: Add to overview comments.
2351 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2352 Note that this is where all the document are loaded. They are not
2353 loaded freshly for each page.
2355 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2359 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2360 Add a TextBox for the text of a quick find.
2361 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2363 setBackLink(): Add a String quickFind parameter.
2364 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2365 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2366 to the base interface, because that is how TableSelectionViewImpl is used.
2367 * src/main/webapp/style.css: Add style for the search box and its label.
2369 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2370 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2371 Add these files, based on the existing TableChangeEvent and
2372 TableChangeEventHandlers.
2373 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2374 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2375 a ListPlace() that the user should be taken to.
2376 * src/main/java/org/glom/web/client/activity/ListActivity.java
2377 start(): Handle it here too and adapt the TableChangeEvent handler to
2378 pass the extra "" quickFind parameter to ListPlace.
2379 * src/main/java/org/glom/web/client/place/ListPlace.java:
2380 Constructor: Take an extra String quickFind parameter and store it,
2381 returning it from a new getQuickFind() method.
2382 getToken(): Put the quickFind text in the URL token.
2383 getPlace(): Parse the quickFind text from the URL token.
2384 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2385 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2386 ListPlace constructor.
2387 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2388 .java: start(): Add a Change handler for the TableSelectionView's
2389 TextBox (via its base HasChangeHandlers interface), firing the new
2390 QuickFindChangeEvent.
2391 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2392 pass the extra "" quickFind parameter.
2394 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2395 setCellTable(): Add a String quickFind parameter and pass it to
2396 the ListViewTable() constructor.
2397 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2398 setCellTable() in the base interface, because that is how ListViewImpl
2401 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2402 Add a String quickFind member variable.
2403 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2404 Constructor: Add a String quickFind parameter, storing it in the
2405 base ListTable's member variable.
2406 onRangeChanged(): Pass quickFind to the
2407 OnlineGlomServiceAsync.getSortedListViewData() and
2408 OnlineGlomServiceAsync.getListViewData() methods.
2410 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2411 getListViewData(), getSortedListViewData(): Add a String quickFind
2412 parameter, passing it to ConfiguredDocument.getListViewData().
2413 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2414 Change getListViewData(), getSortedListViewData() in the base interface,
2415 because that is how OnlineGlomServiceImpl is used, via this:
2416 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2417 Change getListViewData(), getSortedListViewData() here too.
2418 This class can apparently be used to asynchronously call methods on
2419 OnlineGlomService, and GWT seems to implement that after recognizing
2420 just the *Async name convention and the extra AsyncCallback parameters.
2422 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2423 getListViewData(): Add a String quickFind parameter, and pass it to
2424 ListViewDBAccess.getData().
2425 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2426 getListData(): Add a String quickFind parameter and pass it to
2428 getSelectQuery(): Add a String quickFind parameter.
2429 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2430 getSelectQuery(): Add a String quickFind parameter and use it with
2431 Glom.get_find_where_clause_quick() to pass a where_clause to
2432 Glom.build_sql_select_with_where_clause(), to actually filter the
2434 getData(): Add a String quickFind parameter, passing it to getListData().
2435 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2436 va: getData(): Pass an empty string to getListData() for the
2437 quickFind parameter.
2439 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2441 ListTable: Minor change.
2443 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2444 createCellTable(): Make this protected instead of public.
2446 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2448 Many files: Use final for the parameters and use the @override attribute.
2450 2012-01-22 Ben Konrath <ben@bagu.org>
2452 Add anchor links for single line text that starts with http, ftp and www.
2456 2012-01-22 Ben Konrath <ben@bagu.org>
2458 Add ellipsis to single line text in details view.
2462 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2464 Remove all javadoc author tags.
2466 Because they are awkward and meaningless when many people touch
2468 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2470 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2472 Revert the COPYING.LESSER to COPYING rename.
2474 Apparently both should be there if it is LGPL.
2476 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2478 *View: Remove unused imports.
2480 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2481 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2482 * src/main/java/org/glom/web/client/ui/ListView.java:
2483 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2484 Remove unused imports, as suggested by Eclipse.
2486 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2488 Move the *View::Presenter types, and some API into one base View.
2490 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2491 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2492 * src/main/java/org/glom/web/client/ui/ListView.java:
2493 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2494 Presenter, setPresenter() and clear() into a shared base interface,
2495 to avoid the unnecessary duplicate Presenter types and to more clearly
2496 show how the *Views share the same structure, even if they are not
2497 used polymorphically.
2499 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2500 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2502 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2503 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2504 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2506 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2509 Feel free to revert this if there is a good reason for the duplicate
2512 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2514 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2516 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2517 a class member instead of a local variable in the method.
2518 This lets us use it to get the view instances, for use in tests.
2519 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2520 beforeOnlineGlom(): Test some more details of the initial view.
2521 Again, this is not very useful.
2523 To really test gwt-glom we will need to start a local postgresql
2524 instance with local data, like the Glom tests in C++.
2526 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2528 pom.xml: Mention the LGPL license.
2530 * pom.xml: Add a licenses section.
2531 * COPYING.LESSER: Move this to COPYING, which
2532 previously contained the GPL. But gwt-glom is all LGPL.
2534 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2536 Add project information to README and pom.xml.
2538 * README: Add a brief description and mention some mvn
2540 * pom.xml: This extra information shows up in mvn site
2543 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2545 Use the latest java-libglom version.
2547 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2549 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2551 GwtTestOnlineGlom: Test a little more.
2553 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2554 protected rather than private, as suggested by the gwt-test-utils
2556 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2557 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2558 Test the initial visibility of the panels.
2560 However, this is not a very useful test.
2561 And I wonder how we should generally test using this idea for an
2562 activity/places app like ours where the real changes happen implicitly
2563 based on the history token/URL.
2565 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2567 Slight modification to *Mapper comments.
2569 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2570 (DataActivityMapper)
2571 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2573 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2575 Remove comments mentioning GIN because they are just copied from
2576 the example code and are apparently not helpful:
2577 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2578 Also change the mention of a class that is only in the example code.
2580 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2582 GwtTestOnlineGlom test: Minor changes.
2584 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2585 Avoid the long qualified class name and modify the comment
2586 because it is now obvious to me that the mocked class is the only
2587 custom one created via GWT.create().
2589 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2591 Tests: Added the beginnings of a test using gwt-test-utils.
2593 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2594 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2595 which tells gwt-test-utils what class will be tested.
2596 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2597 Add a simple (but empty) test case. One class, used by the OnlineGlom
2598 class, is mocked so that it can be created. However, I am not sure
2599 why only this class needs to be mocked.
2601 Note that mockito seems more popular, and clearer, than easymock,
2602 but I have not got that working yet. It might be a matter of the
2605 This test is run during mvn integration-test.
2607 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2609 Tests: Use junit4-style syntax instead of junit3-style.
2611 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2612 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2613 * src/test/java/org/glom/web/shared/DataItemTest.java:
2614 Use the @Test annotation rather than relying on the test*() prefix.
2615 Also no longer implement TestCase, to avoid triggering support for
2616 the junit3-way, which stops the annotations from working.
2617 Change the imports from import junit.framework.* to
2618 import org.junit.*, which is apparently the new way.
2620 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2622 Added a test for ListPlace token parsing and creation.
2624 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2625 This is much the same as DetailsPlaceTest.
2627 I wonder how we could test the other parts of the *Place API.
2629 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2631 DetailsPlace test: Also test getToken() and recreation via getPlace().
2633 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2634 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2635 recreate it, testing the recreated DetailsPlace for the same parameter
2638 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2640 Use the surefire-report plugin.
2642 * pom.xml: This generates a HTML report about the tests in
2643 target/site/surefire-report.html
2644 when you do mvn surefire-report:report. It seems to be popular/normal.
2646 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2648 Added a test for DetailsPlace.
2650 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2651 Test the getPlace() token parsing.
2653 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2655 Added a first unit test.
2657 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2658 * src/test/java/org/glom/web/shared/DataItemTest.java:
2659 This is a silly test but it is just to get things started. Note that
2660 maven/junit finds the test because it looks in src/test by default.
2662 2011-12-22 Ben Konrath <ben@bagu.org>
2664 Change charsetName to "UTF-8" when replacing line breaks.
2666 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2667 that work in Java (such as "UTF8") will not work when compiled to
2670 This fixes a problem with multi-line details view fields that have hard
2671 line breaks. The "License Text" field on this page demonstrates the
2674 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2676 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2678 2011-12-22 Ben Konrath <ben@bagu.org>
2680 Fix another bug with related list navigation.
2682 I've tested all the navigation buttons in all of the related lists
2683 so things should be good now.
2685 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2687 2011-12-22 Ben Konrath <ben@bagu.org>
2689 Fix a crasher when refreshing the list view with the default table.
2691 This crash will also happen when loading the list view with the default
2692 table from a link or bookmark.
2694 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2695 to the main document selection page when the document id hasn't been
2697 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2698 the main document selection page when the document id hasn't been
2700 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2701 values for the details place when the document id hasn't been set.
2702 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2703 values for the list place when the document id hasn't been set.
2705 2011-12-21 Ben Konrath <ben@bagu.org>
2707 Protect against NPE when glom.document.locale is not in config.
2709 This patch protects against an NPE when glom.document.locale is not in
2710 the config file. This NPE will also happen if glom.document.locale is
2713 The patch also updates the error message to display the class name when
2714 the getMessage() returns null. This was happening when the NPE was
2715 thrown and I had "Configuration Error: null". If an NPE is encountered
2716 with this patch, "Configuration Error: NullPointerException " will be
2719 This commit closes this bug:
2721 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2723 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2725 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2727 Rename onlineglom.properties to onlineglom.properties.sample.
2729 * src/main/resources/onlineglom.properties: Rename to:
2730 * src/main/resources/onlineglom.properties.sample:
2731 * src/main/resources/README: And add this file explaining that people
2732 should rename it back when deploying.
2734 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2736 Allow choosing the translation in the .properties file.
2738 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2739 init(): Read a glom.document.locale value from the configuration file
2740 and call Glom's TransatableItem::set_current_locale() method.
2741 * src/main/resources/onlineglom.properties: Add a commented-out
2742 example of this new setting.
2744 It would be better to add &lang=de_DE to the URL, but the current
2745 libglom API does not allow us to do this easily. I am working on that.
2747 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2749 Avoid a crash in parsing of token parameters.
2751 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2752 ava: getTokenParams(): Do not crash if a parameter has a key but no
2753 value, and ignore parameters with neither.
2755 2011-12-17 Murray Cumming <murrayc@murayc.com>
2757 History token building/handling: Improve use of token parameters.
2759 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2760 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2761 and buildParamsToken(HashMap), for use by derived classes.
2762 Make the separator private because it is no longer be needed.
2763 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2764 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2765 instead of manual string concatenation.
2766 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2767 of hardcoded indices and awkward splitting code.
2768 * src/main/java/org/glom/web/client/place/ListPlace.java
2769 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2770 instead of manual string concatenation.
2771 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2772 of hardcoded indices and awkward splitting code.
2773 This should fix bug #666420
2775 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2777 Fix a Navgiation->Navigation typo in the code.
2779 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2780 Rename processNavgiation() to processNavigation().
2782 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2784 Fix a seperator->separator typo in the code.
2786 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2787 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2788 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2791 2011-12-15 Ben Konrath <ben@bagu.org>
2793 Cleanup some comments.
2795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2797 2011-12-14 Ben Konrath <ben@bagu.org>
2799 Replace \n with <br/> for multiline text in the details view.
2801 Vertical scrollbars are added when needed as well.
2803 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2805 2011-12-14 Ben Konrath <ben@bagu.org>
2807 Specify the font for document selection links.
2809 * src/main/webapp/style.css:
2811 2011-12-14 Ben Konrath <ben@bagu.org>
2813 Fix bouncy CellTable while paging.
2815 This doesn't currently work with related list tables in unselected
2818 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2820 2011-12-14 Ben Konrath <ben@bagu.org>
2822 Revamp the appearance of the document selection page.
2824 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2825 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2826 * src/main/webapp/style.css:
2828 2011-12-13 Ben Konrath <ben@bagu.org>
2830 Set navigation button column to the smallest size possible.
2832 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2834 2011-12-13 Ben Konrath <ben@bagu.org>
2836 Change OpenButton nomenclature to NavigationButton.
2838 Using NavigtionButton makes things more generic. Classes, methods and
2839 variables have been changed.
2841 This is a rename-only refactor.
2843 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2844 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2845 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2846 Renamed from OpenButtonCell.
2847 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2848 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2849 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2851 2011-12-12 Ben Konrath <ben@bagu.org>
2853 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2855 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2856 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2857 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2858 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2860 2011-12-12 Ben Konrath <ben@bagu.org>
2862 Update variable names and comments.
2864 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2865 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2867 2011-12-12 Ben Konrath <ben@bagu.org>
2869 Properly initialize numNonEmptyRows variable to zero.
2871 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2872 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2874 2011-12-05 Ben Konrath <ben@bagu.org>
2876 Add latest mockup with HTML tables.
2878 Features of this mockup:
2880 -> HTML table for flowtable
2881 -> HTML table for flowtable column
2882 -> Example of how related lists would look
2883 -> Not using text entries for data items
2885 The current version of Online Glom doesn't use HTML tables for the
2888 This mockup has been sent to the glom-devel mailing list but it's good
2889 to have it here as well.
2891 * mockups/details-view-html-tables.html:
2893 2011-12-05 Ben Konrath <ben@bagu.org>
2895 Remove unnecessary getPrimaryKeyField() method.
2897 getPrimaryKeyFieldForTable(String) has been renamed to
2898 getPrimaryKeyField(String).
2900 * src/main/java/org/glom/web/server/database/DBAccess.java:
2901 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2902 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2904 2011-12-05 Ben Konrath <ben@bagu.org>
2906 Add string representation of TypedDataItem value to conversion error message.
2908 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2909 message was extracted into its own method to avoid duplication.
2911 2011-12-05 Ben Konrath <ben@bagu.org>
2913 Add type checking to navigation primary key value creation.
2915 Create navigation primary key only if the expected type from the Glom
2916 document matches the type returned by the SQL query.
2918 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2920 2011-12-05 Ben Konrath <ben@bagu.org>
2922 Rename a couple of variables in RelatedListNavigation.
2924 This is a rename-only refactor.
2926 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2928 2011-12-05 Ben Konrath <ben@bagu.org>
2930 Move getListLayoutGroup() into getListViewLayoutGroup().
2932 This removes getListLayoutGroup(). It was only being called by
2933 getListViewLayoutGroup().
2935 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2937 2011-12-05 Ben Konrath <ben@bagu.org>
2939 Remove check for LayoutItem_Portal in list table method.
2941 This check is no longer necessary because the method isn't being used
2942 to create the LayoutItemPortal DTO.
2944 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2946 2011-12-05 Ben Konrath <ben@bagu.org>
2948 Properly support related list navigation.
2950 Navigation from the "Repository Analyzer -> Package Scans ->
2951 Dependencies" related table wasn't working because the primary key for
2952 related tables wasn't being set properly. This commit fixes the
2955 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2956 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2957 doesn't set the primary key properly for related list tables.
2958 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2959 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2960 useful for getting the primary key for list view tables and for related
2962 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2963 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2964 Move code to set the primary key for the table from the abstract
2965 ListDBAccess class to ListViewDBAccess as it's only correct for list
2967 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2968 Properly add primary key to related list tables.
2970 2011-12-02 Ben Konrath <ben@bagu.org>
2972 Properly set the horizontal alignment of fields.
2974 This fix is for both the list tables and the details view.
2976 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2977 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2978 to set the horizontal alignment of fields.
2980 2011-12-02 Ben Konrath <ben@bagu.org>
2982 Display currency codes in the details view.
2984 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2986 2011-12-02 Ben Konrath <ben@bagu.org>
2988 Avoid duplicate JNI call.
2990 JNI is not as efficient as pure Java and this is an easy (and small)
2993 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2994 Use previously retrieved value for whereClauseToTableName instead of
2997 2011-12-02 Ben Konrath <ben@bagu.org>
2999 Rename a couple of variables in RelatedListNavigation.
3001 This is a rename-only refactor.
3003 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
3005 2011-12-02 Ben Konrath <ben@bagu.org>
3007 Indicate clearly that a mismatched primary key type is a bug.
3009 * src/main/java/org/glom/web/server/Utils.java: Change log level from
3010 warning to error. Add 'This is a bug.' to message.
3012 2011-12-02 Ben Konrath <ben@bagu.org>
3014 Update / fix some comments.
3016 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
3018 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
3020 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3021 Fix comments. Add some TODOs.
3023 2011-12-02 Ben Konrath <ben@bagu.org>
3025 Enable navigation to details view with string primary key from related list.
3027 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
3028 Create a text primary key value when return type of result is
3029 java.sql.Types.VARCHAR.
3031 2011-12-02 Ben Konrath <ben@bagu.org>
3033 Use checkboxes for booleans in the details view.
3035 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3037 2011-12-01 Ben Konrath <ben@bagu.org>
3039 Improve performance of related list height calculation.
3041 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3042 Put code to calculate the expected height in a static initializer so
3043 that that it's only called once.
3045 2011-12-01 Ben Konrath <ben@bagu.org>
3047 Show related list tables in notebooks (again).
3049 Calculate the height of the related list tables so the Notebook can be
3050 set the correct height. The height of the related list table is also needed by
3051 FlowTable to be able decide how to create the layout.
3053 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
3054 and set the Portal height based on the height of the related list
3055 table and the Portal container.
3056 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3057 Add method to calculate the height of the related list tables.
3058 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3059 * src/main/webapp/style.css: Add css class for Pager. This is needed to
3060 calculate the height of the Pager widget.
3062 2011-12-01 Ben Konrath <ben@bagu.org>
3064 Use CellTable API for table property instead of setting style on Element.
3066 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3068 2011-12-01 Ben Konrath <ben@bagu.org>
3070 Make ListViewTable and RelatedListTable a consistent height.
3072 The tables are now a consistent height regardless of the contents of
3073 the table. A hidden button is added to empty rows to ensure that the
3074 height of these rows will match the height of rows with data.
3076 A navigation button column is now added to every table. The width of
3077 the navigation column is set to 0px when a RelatedListTable shouldn't
3078 have navigation buttons. This maintains the a consistent row height in
3079 tables that don't show the navigation buttons.
3081 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
3082 navigation column when not needed.
3083 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
3084 arguments for navigation button to constructor of ListViewTable.
3085 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
3086 hidden button for empty data rows.
3087 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
3088 arguments for navigation button to constructor.
3089 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
3090 create navigation buttons. Add hideNavigationButtons() method.
3091 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
3092 arguments for navigation button to constructor.
3094 2011-12-01 Ben Konrath <ben@bagu.org>
3096 Use 'visibility: hidden' in Utils.getWidgetHeight().
3098 This is better choice because hidden elements are invisible, don't
3099 respond to events and are not part of the tab order. They will,