1 2012-05-14 Murray Cumming <murrayc@murrayc.com>
5 * src/main/java/org/glom/web/server/SqlUtils.java:
6 get_find_where_clause_quick(): Use a comparison of
7 lowercase values, instead of a simple equals. Regular Glom
8 uses the PostgreSQL ILIKE operator but jOOQ does not
9 support that just yet, though it will soon.
11 2012-05-14 Murray Cumming <murrayc@murrayc.com>
13 TableToViewDetails: Use a real serialization ID.
15 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
16 Though this does not fix the serialization problem.
18 2012-05-12 Murray Cumming <murrayc@murrayc.com>
20 Added LayoutItemPortalDeepCloneTest.
22 2012-05-11 Murray Cumming <murrayc@murrayc.com>
24 Make navigation work again.
26 * src/main/java/org/glom/web/server/libglom/Document.java:
27 Add getLayoutItemFieldShouldHaveNavigation().
28 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
29 Replace get/setAddNavigation() with the partly-existing
30 get/setNavigationTableName(), with an empty string being no navigation,
31 because this is simpler. Use the new
32 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
34 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
35 Add updateFieldsExtras() and call setNavigationTableName in it.
36 getDetailsLayoutGroup(),
37 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
38 createLayout(): Adapted.
39 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
42 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
43 Replace get/setAddNavigation() with get/setNavigation(), returning a
44 TableToViewDetails class with both the table name and UsesRelationship,
45 because both are need. The previous code used java-libglom's output
46 variable (strangely, via sharedptr) to return both, but we cannot really
48 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
49 getNavigationRecord(): Adapt. However, we cannot actually use the cache
50 here because it somehow gets set to null during deepCopy(). I must test this.
51 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
52 testGetSuitableTableToViewDetails(): Adapted.
54 TODO: Find out why deepClone() is not quite working.
56 2012-05-11 Murray Cumming <murrayc@murrayc.com>
58 DBAccess: Simplify the retrievel of full field details.
60 * src/main/java/org/glom/web/server/database/DBAccess.java
61 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
62 because the Document loading should have done this.
64 2012-05-11 Murray Cumming <murrayc@murrayc.com>
66 Document: Correct loading of doubly-related layout fields.
68 * src/main/java/org/glom/web/server/libglom/Document.java:
69 loadUsesRelationship(): Actually set the related relationship, instead
70 of only setting it if it's not found.
72 2012-05-09 Murray Cumming <murrayc@murrayc.com>
74 Replace all appearances of Colour with color.
76 Because US English is dominant.
78 2012-05-09 Murray Cumming <murrayc@murrayc.com>
80 Use colors in HTML format, solving a warning about an unused function.
82 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
83 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
84 Add *asHTMLColor() versions of methods.
85 TODO: However, we should create and cache the results on the server.
86 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
87 * src/main/java/org/glom/web/client/ui/list/ListTable.java
88 * src/main/java/org/glom/web/server/ConfiguredDocument.java
89 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
90 Use the asHTMLcolor() versions.
92 2012-05-09 Murray Cumming <murrayc@murrayc.com>
94 ListViewTable: Constructor: Take the table name as a parameter.
96 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
97 Constructor: Take the tableName, and set the member variable, because
99 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
100 setCellTable(): Pass the table name.
101 This makes navigation to non-default tables work again. I don't know
102 why it worked before in the master branch.
104 2012-05-07 Murray Cumming <murrayc@murrayc.com>
106 ConfiguredDocument: Restore correct addition of hidden primary key items.
108 * src/main/java/org/glom/web/client/ui/list/ListTable.java
109 (ListTable.createCellTable): Uncomment out the check for the hidden
111 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
112 add primary key items for top-level lists and portals, as before,
113 instead of adding them to each group.
114 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
115 Actually implement the extra methods such as setHiddenPrimaryKey() and
116 comment that these are used only for top-level list groups and in portals.
117 This strangeness suggests even more that this should not be squeezed
118 into the LayoutGroup class.
120 2012-05-07 Murray Cumming <murrayc@murrayc.com>
122 Fix Formatting loading.
124 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
125 getFormattingUsed(): Remove the duplicate Formatting member variable
126 in favour of the one from the base class.
127 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
128 Initialize a new Formatting instead of using null by default, so we
129 have some defaults, instead of having to initialize one later just to
130 get the same defaults. This also makes loading of formatting from the
131 document work, because that expected a non-null.
133 2012-05-07 Murray Cumming <murrayc@murrayc.com>
135 RelatedListTable: Make sure that the tableName is set.
137 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
138 Constructor: Take the tableName so it is available later. Otherwise,
139 the server assumes that we mean the default table and cannot find the
141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
142 setData(): Pass the tableName to the RelatedListTable constructor.
144 2012-05-07 Murray Cumming <murrayc@murrayc.com>
148 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
149 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
150 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
152 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
154 * src/main/java/org/glom/web/server/database/DBAccess.java:
155 convertResultSetToDTO(), getPortal():
156 * src/main/java/org/glom/web/server/database/ListDBAccess.java
158 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
159 Add checks for null objects and out of range access, with log messages to
160 give hints so we can fix these properly.
162 2012-05-07 Murray Cumming <murrayc@murrayc.com>
164 Portals: some corrections.
166 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
168 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
169 constructor: Use getRelationshipNameUsed() instead of getName(), because
170 that is what is meant.
171 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
172 getFromField(): Fix a typo, to get the field name, not the table name.
173 * src/main/java/org/glom/web/server/database/DBAccess.java:
174 getPortal(): Fix a typo that stopped this from working.
176 2012-05-07 Murray Cumming <murrayc@murrayc.com>
178 LayoutItemPortal: Also override getTitleOriginal().
180 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
181 This lets the base getTitle() with no parameters work.
182 TODO: Test this properly.
184 2012-05-06 Murray Cumming <murrayc@murrayc.com>
186 LayoutItemPortal: getTitle*(): Use the relationship title.
188 2012-05-06 Murray Cumming <murrayc@murrayc.com>
190 LayoutItemField: Fix loading of custom titles.
192 * src/main/java/org/glom/web/server/libglom/Document.java
193 loadDataLayoutItemField(): The title, if any, instead of the field
194 title, is stored in a title_custom node. Load it from there.
195 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
197 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
198 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
199 getTitle*() overrides.
200 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
203 2012-05-06 Murray Cumming <murrayc@murrayc.com>
205 LayoutItemField: Fall back to field titles, so some are really shown.
207 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
208 Override getTitleOriginal() and getTitle(), as in java-libglom.
209 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
212 2012-05-06 Murray Cumming <murrayc@murrayc.com>
214 Correct use of setExpectedResultSize().
216 * src/main/java/org/glom/web/server/ConfiguredDocument.java
217 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
218 Use setExpectedResultSize only on top-level groups (for instance, the
219 list layout) or on child portals (in details views).
220 Use the correct table name for portals to avoid SQL errors.
221 Update the expected counts when returning cached layouts.
223 2012-05-06 Murray Cumming <murrayc@murrayc.com>
225 Document: Interpret no group column count as 1.
227 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
228 default, though we now check for this in the UI code anyway.
230 2012-05-06 Murray Cumming <murrayc@murrayc.com>
234 2012-05-06 Murray Cumming <murrayc@murrayc.com>
236 Translatable: Use Hashmap instead of Treemap because GWT supports it.
238 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
239 The use of Treemap lead to this error from async methods, with no
241 "The response could not be deserialized"
243 2012-05-06 Murray Cumming <murrayc@murrayc.com>
245 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
247 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
248 when using the Google -> GWT Compile, or
249 g toolbar button -> GWT Compile Project... feature in Eclipse.
251 2012-05-06 Murray Cumming <murrayc@murrayc.com>
253 ListTable.addColumn(): Protect against a null Formatting.
255 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
256 Create a default Formatting if it is null, because that is the simplest
259 2012-05-06 Murray Cumming <murrayc@murrayc.com>
261 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
263 * src/main/java/org/glom/web/server/ConfiguredDocument.java
264 updateLayoutGroup(): Check that the field is not null.
266 2012-05-06 Murray Cumming <murrayc@murrayc.com>
268 ListViewImpl: Protected against a bad cast error.
270 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
271 onEnterKeyDown(): Do not cast without an instanceof check.
273 2012-05-06 Murray Cumming <murrayc@murrayc.com>
275 ListTable: Protect against an out of range error.
277 * src/main/java/org/glom/web/client/ui/list/ListTable.java
278 createCellTable(): This is unlikely, but can happen while debugging.
280 2012-05-06 Murray Cumming <murrayc@murrayc.com>
282 AsyncMessage onFailure() callbacks: Log the exception message.
284 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
285 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
286 * src/main/java/org/glom/web/client/activity/ListActivity.java:
287 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
288 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
289 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
290 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
291 These are useful clues when something is wrong.
293 2012-05-06 Murray Cumming <murrayc@murrayc.com>
295 ConfiguredDocument: Avoid a null dereference.
297 * src/main/java/org/glom/web/server/ConfiguredDocument.java
298 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
299 details maps are created.
301 2012-05-06 Murray Cumming <murrayc@murrayc.com>
303 Document: Correct the port number parsing.
305 * src/main/java/org/glom/web/server/libglom/Document.java:
306 This lets us actually connect to the database and show the document.
308 2012-05-05 Murray Cumming <murrayc@murrayc.com>
312 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
313 user-interaction, asking us to load a temporary URL in a browser.s
314 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
315 which is apparently necessary for testing the service. See the comment.
316 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
317 Show the exception, if any. This is how I saw the 404 in the HTML in
320 2012-05-05 Murray Cumming <murrayc@murrayc.com>
322 DocumentTest: Move the .glom files into the resources directory.
324 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
325 URI via getResource().
327 2012-05-05 Murray Cumming <murrayc@murrayc.com>
329 Document: Remove the FieldIdentifies inner class.
331 * src/main/java/org/glom/web/server/libglom/Document.java: We only
332 use the Relationship (though the same function in libglom is maybe
333 used in other ways) and so this removes a compiler warning.
335 2012-05-05 Murray Cumming <murrayc@murrayc.com>
337 Document.load() Remove the error code parameter.
339 * src/main/java/org/glom/web/server/libglom/Document.java: load():
340 Remove the parameter. We do not set it yet and it could never have
341 worked as an output parameter (though maybe it did in java-libglom).
342 We could use an exception if we really want the failure reason.
343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
345 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
346 setUp(), testGetSuitableTableToViewDetails(): Adapt.
348 2012-05-05 Murray Cumming <murrayc@murrayc.com>
350 Make some inner classes static.
352 * src/main/java/org/glom/web/server/ConfiguredDocument.java
353 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
354 * src/main/java/org/glom/web/server/ReportGenerator.java
355 * src/main/java/org/glom/web/server/libglom/Document.java
356 Make all inner classes static that can be static.
358 2012-05-05 Murray Cumming <murrayc@murrayc.com>
360 OnlineGlomServiceImpl: Do not load and check for java-libglom.
362 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
363 init(): We do not use java-libglom any more.
365 2012-05-05 Murray Cumming <murrayc@murrayc.com>
367 Remove mentions of java-libglom.
369 * README: Remove mention of java-libglom, because it no longer needed.
370 * utils/build-onlineglom-war.sh:
371 * utils/check-and-recover-tomcat.py:
372 * utils/install-onlineglom-war.sh: Remove these as they are no longer
373 useful. Building is now far easier, with no need for jhbuild.
375 2012-05-05 Murray Cumming <murrayc@murrayc.com>
377 Fix the build (mvn package)
379 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
380 (LayoutGroup): Make the LayoutItemList inner class static and protected.
381 Otherwise the GWT Java->Javascript compilation fails with just this
382 error, during mvn package or when attempting to view in a browser,
383 in the GWT developer mode in Eclipse.
385 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
386 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
387 [INFO] Compiling module org.glom.web.OnlineGlom
388 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
389 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
390 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
391 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
392 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
393 [INFO] [ERROR] Cannot proceed due to previous errors
395 It has taken me 2 days to find out what was causing that. After reducing
396 the code, the compiler eventually showed me the full error message.
398 2012-05-04 Murray Cumming <murrayc@murrayc.com>
400 ConfiguredDocument: Cache the cloned and stripped layouts.
402 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
403 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
404 layout in a map, so we can retrieve it again without rebuilding it.
406 2012-05-04 Murray Cumming <murrayc@murrayc.com>
408 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
410 2012-05-04 Murray Cumming <murrayc@murrayc.com>
412 libglom classes: Implement some auto-generated emthods.
414 2012-05-04 Murray Cumming <murrayc@murrayc.com>
416 Add GwtTestOnlineGlomService.
418 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
419 However, this (and the other GwtTest*) does not seem to run during
422 2012-05-04 Murray Cumming <murrayc@murrayc.com>
424 Remove use of unsupported features from client code.
426 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
427 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
428 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
429 Use our client version of StringUtils instead of the apache commons one.
431 However, the GWT Javascript compliation still fails.
433 2012-04-25 Murray Cumming <murrayc@murrayc.com>
435 Add a Field class and implement some loading of it in Document.
437 2012-04-25 Murray Cumming <murrayc@murrayc.com>
439 Initial Document loading implementation, instead of libglom.
441 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
442 and Translatable classes, and adapt the rest of the code to use them.
443 However, this is still missing Layout and Field classes and loading.
445 2012-04-24 Murray Cumming <murrayc@murrayc.com>
447 Use of jOOQ: Move Field creation into a utility method.
449 * src/main/java/org/glom/web/server/SqlUtils.java:
450 This lets us improve it more easily.
452 2012-04-24 Murray Cumming <murrayc@murrayc.com>
454 Use of jOOQ: Improve the code to COUNT a sub-select.
456 * src/main/java/org/glom/web/server/SqlUtils.java:
457 Move initial query creation into
458 build_sql_select_step_with_where_clause().
459 build_sql_select_count_rows(): Use the jOOQ API instead of
460 concatentating text, because a jOOQ Select*Step is a TableLike,
461 which is what from() takes.
463 2012-04-23 Murray Cumming <murrayc@murrayc.com>
465 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
467 * pom.xml: Depend on jooq.
468 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
469 methods with jOOQ, based on the C++ implementations in libglom,
470 with some changes to the logic required by jooQ.
471 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
473 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
474 * src/main/java/org/glom/web/server/ReportGenerator.java:
475 * src/main/java/org/glom/web/server/SqlUtils.java:
476 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
477 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
478 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
479 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
480 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
481 Adapt. In particular, the SqlUtils methods now need to take a Connection,
482 because jOOQ needs that, though it seems unnecessary.
484 This is not quite finished. Ideally jOOQ would help us to build
485 table_name.field_name names, quoting and escaping them properly.
486 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
488 2012-04-21 Murray Cumming <murrayc@murrayc.com>
490 Move use of Glom.build_sql*() into a new SqlUtils class.
492 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
493 to wrap Glom.build_sql*(). The parameter types are still Glom one,
494 but this will make it easier to start using something other than
495 libglom or SqlBuilder.
497 2012-04-21 Murray Cumming <murrayc@murrayc.com>
499 Update the project URL.
501 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
503 2012-04-21 Murray Cumming <murrayc@murrayc.com>
505 Main layout: Use a FlowTable instead of absolute positioning.
507 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
508 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
509 child panels/widgets must have an absolute position. But that is annoying, so
510 this adds a FlowTable and puts the child panels in there.
512 2012-04-21 Murray Cumming <murrayc@murrayc.com>
514 GwtTestOnlineGlom: Comment out unused code.
516 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
517 Eclipse has started to say that some code is unused.
519 2012-04-21 Murray Cumming <murrayc@murrayc.com>
521 Update to the latest versions of dependencies.
523 * pom.xml: Update version numbers of dependencies to the latest
525 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
526 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
527 * src/main/java/org/glom/web/server/ReportGenerator.java:
528 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
529 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
530 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
532 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
533 Modify the imports where necessary.
535 2012-04-17 Murray Cumming <murrayc@murrayc.com>
537 Style: Remove overflow:hidden from searchbox
539 * src/main/webapp/style.css: Because this pushes the Back To Link
540 label/link on to the next row, which is then hidden due to the
541 hard-coded (in ems) height.
543 2012-04-20 Murray Cumming <murrayc@murrayc.com>
545 Remove some duplicate code.
547 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
548 getDocumentInfo(): This must have been duplicated during the merge from the
553 2012-04-19 Murray Cumming <murrayc@murrayc.com>
555 Reports: Localize the waiting for report message.
557 * src/main/java/org/glom/web/client/activity/ReportActivity.java
558 start(): Get the message from the contants.
559 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
561 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
562 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
563 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
564 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
565 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
566 Update these files with the English text for newer strings for now.
568 2012-04-19 Murray Cumming <murrayc@murrayc.com>
570 Reports: Show a message while waiting for the report.
572 * src/main/java/org/glom/web/client/ui/ReportView.java
573 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
574 Add setWaitingText(), to show a message saying that we are
575 waiting for the report to be ready.
576 * src/main/java/org/glom/web/client/activity/ReportActivity.java
577 start(): Call setWaitingText() before calling the async
580 2012-04-19 Murray Cumming <murrayc@murrayc.com>
582 ReportGenerator: Specify date and time formats.
584 * src/main/java/org/glom/web/server/ReportGenerator.java:
585 createFieldValueElement(): Use the default (and localized)
586 short formats, though we still need a way to show 4-digit
587 years without providing the format for every locale.
588 * src/main/java/org/glom/web/server/database/DBAccess.java:
589 convertResultSetToDTO(): Use the short formats here too.
591 2012-04-18 Murray Cumming <murrayc@murrayc.com>
593 ReportGenerator: Use the correct numeric formatting.
595 * src/main/java/org/glom/web/server/ReportGenerator.java
596 createFieldExpression(), createFieldValueElement(): Take the
597 whole LayoutItem_Field instead of just the field name, so
598 we have access to the formatting.
599 createFieldValueElement(): Use JRTextField.setPattern() to
600 specify the numeric formatting, with the help of a
601 regular DecimalFormat.
603 2012-04-18 Murray Cumming <murrayc@murrayc.com>
605 ReportGenerator: Avoid showing null for group by titles.
607 * src/main/java/org/glom/web/server/ReportGenerator.java
608 generateReport(): Use setBlankWhenNull() on the field title
609 style too, because this is used for values in group by
612 2012-04-18 Murray Cumming <murrayc@murrayc.com>
614 ReportGenerator: Add a colon to titles in vertical groups.
616 * src/main/java/org/glom/web/server/ReportGenerator.java
617 addFieldToDetailBandVertical(): Pass true for the withColon
620 2012-04-18 Murray Cumming <murrayc@murrayc.com>
622 ReportGenerator: Simplify the code by using Position more.
624 2012-04-18 Murray Cumming <murrayc@murrayc.com>
626 Reports: Support vertical groups, roughly.
628 * src/main/java/org/glom/web/server/ReportGenerator.java:
629 addToReport(): Rename to addGroupToReport() and, if necessary,
630 call the new addVerticalGroupToReport() method.
631 createFieldValueElement(): Let the caller specify the Y position
634 2012-04-17 Murray Cumming <murrayc@murrayc.com>
636 Reports: Allow a second report to be shown.
638 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
639 clear(): Do not remove the HTML widget, which broke the whole layout.
641 2012-04-17 Murray Cumming <murrayc@murrayc.com>
643 Locales drop-down: Show that we use English by default.
645 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
646 fillView(): When we use English, just because that is the default, when
647 no locale is specified, show that in the Locales drop-down instead of
648 just showing the first item.
650 2012-04-17 Murray Cumming <murrayc@murrayc.com>
652 Unselect the Report/Locale/Table combo item when appropriate.
654 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
655 setPlace(): clear reportName if this is not a ReportPlace.
656 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
657 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
658 When the provided name is empty, unselect all items, so that none are
659 indicated. This uses a for loop because I cannot find a single method
662 2012-04-17 Murray Cumming <murrayc@murrayc.com>
664 Report: Give the user a way to get back to the list.
666 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
667 start(), setPlace(): Show the Back To List link on reports, and also
668 interpret selecting the empty report item as back to list.
670 2012-04-13 Murray Cumming <murrayc@murrayc.com>
672 Really show the selected Report name.
674 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
675 setPlace(): Store the reportName here, if it is that kind of Place.
676 fillView(): Set the selected Report after filling the list of reports.
677 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
678 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
679 null Strings, though we need some way to unselect all ListBox items
682 2012-04-13 Murray Cumming <murrayc@murrayc.com>
684 ReportGenerator: Try to avoid some problems.
686 * src/main/java/org/glom/web/server/ReportGenerator.java
687 addField(): Try to avoid duplicates, and avoid using a null
690 2012-04-13 Murray Cumming <murrayc@murrayc.com>
692 Reports: Use quickFind.
694 * src/main/java/org/glom/web/client/OnlineGlomService.java;
695 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
697 getReportHTML(): Add a quickFind parameter.
698 * src/main/java/org/glom/web/client/activity/ReportActivity.java
699 start(): Pass the quickFind parameter.
700 * src/main/java/org/glom/web/server/ReportGenerator.java
701 generateReport(): Take a quickFind parameter.
703 2012-04-13 Murray Cumming <murrayc@murrayc.com>
705 ReportPlace: Actually use the report name.
707 * src/main/java/org/glom/web/client/place/ReportPlace.java
708 getPlace(): Do not assign the report name to the quickfind.
710 2012-04-13 Murray Cumming <murrayc@murrayc.com>
712 Show java.library.path when complaining.
714 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
715 init(): When telling us to check java.library.path, show the
718 2012-03-06 Murray Cumming <murrayc@murrayc.com>
720 ReportGenerator: Do not show nulls.
722 2012-03-06 Murray Cumming <murrayc@murrayc.com>
724 ReportGenerator: Make the title font larger.
726 2012-03-06 Murray Cumming <murrayc@murrayc.com>
728 ReportGenerator: Put field titles inside groups, if there are groups.
730 2012-03-06 Murray Cumming <murrayc@murrayc.com>
732 ReportGenerator: Take the Report itself instead of the name and group.
734 * src/main/java/org/glom/web/server/ConfiguredDocument.java
735 Remove getReportLayoutGroup().
736 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
737 getReportHTML(): Pass the report instead
738 of its name and layout group.
739 * src/main/java/org/glom/web/server/ReportGenerator.java
740 generateReport(): Use the report object to use the title
743 2012-03-06 Murray Cumming <murrayc@murrayc.com>
745 ReportGenerator: Remove designBand parameters.
747 * src/main/java/org/glom/web/server/ReportGenerator.java:
748 Make designBand a class member instead of passing it to all
751 2012-03-06 Murray Cumming <murrayc@murrayc.com>
753 ReportGenerator: Add lines, a bit like in the desktop version.
755 * src/main/java/org/glom/web/server/ReportGenerator.java
756 addToReport(): Use JRDesignLine.
758 2012-03-06 Murray Cumming <murrayc@murrayc.com>
760 ReportGenerator: Correct the title positions and use some bold style.
762 * src/main/java/org/glom/web/server/ReportGenerator.java:
763 Break the code up into reusable functions, correct the placement of
764 titles, and use normal/bold styles as in the reports in the desktop
767 2012-03-06 Murray Cumming <murrayc@murrayc.com>
769 ReportGenerator: Add a header band to show the field titles.
771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
772 getReportHTML(): Pass the localeId to the ReportGenerator
774 * src/main/java/org/glom/web/server/ReportGenerator.java
775 constructor: Take the localeID so we can get translated field
777 generateReport(), addToReport(), addFieldToBand(): Add field
778 titles in a column header band.
780 2012-03-05 Murray Cumming <murrayc@murrayc.com>
782 Reports drop-down list: Some improvement.
784 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
785 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
786 Adedd setSelectedReport(),
787 setReportList(): Add a blank line so that the user can select the
789 * src/main/java/org/glom/web/client/activity/ReportActivity.java
790 start(): Show the current report by calling setSelectedReport().
791 This does not seem to work yet.
793 2012-03-05 Murray Cumming <murrayc@murrayc.com>
795 DetailsActivity, ListActivity: Move some variables into a base class.
797 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
798 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
799 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
800 the clientFactory, documentID, tableName and authenticationPopup into
801 a base class, to avoid duplication.
803 2012-03-05 Murray Cumming <murrayc@murrayc.com>
805 Translate the Reports label.
807 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
808 Get the "Reports" label string from the constants.
809 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
810 perties: Add Reports to the constants.
812 2012-03-05 Murray Cumming <murrayc@murrayc.com>
814 Reports: Implement grouping.
816 * src/main/java/org/glom/web/server/ReportGenerator.java:
817 Handle LayoutItem_GroupBy items and try to do the right thing
818 with JRDesignGroup. It seems to work.
820 2012-03-04 Murray Cumming <murrayc@murrayc.com>
822 Actually show some data with JasperReports.
824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
825 getReportHTML(): Move most code into a ReportGenerator class.
826 * src/main/java/org/glom/web/server/ReportGenerator.java:
827 Recurse into sub-groups, adding fields to the JasperDesign's details
828 band. Note that we must set an arbitrary width and height, or it just
829 will not show any data.
831 2012-03-04 Murray Cumming <murrayc@murrayc.com>
833 Reports Chooser: Show the titles, not the names.
835 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
836 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
837 and the names as the values.
838 * src/main/java/org/glom/web/server/ConfiguredDocument.java
839 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
840 group now that we provide the report name, so it should always
843 2012-02-15 Murray Cumming <murrayc@murrayc.com>
845 Depend on jasperreports.
847 * pom.xml: Add the dependency. My plan is to use this on the
850 2012-01-31 Murray Cumming <murrayc@murrayc.com>
852 Implement navigation to report places.
854 * src/main/java/org/glom/web/client/activity/ReportActivity.java
855 start(): Do not bother to handle all events here.
856 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
857 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
858 Added getSelectedReport().
859 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
860 .java: start(): When handling a change to the reports chooser,
861 call getSelectedReport() and goTo() its ReportPlace.
862 * src/main/java/org/glom/web/client/ui/ReportView.java
863 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
864 Added setReportHTML() which puts the html in a gwt HTML widget.
865 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
866 getReportHTML(): Return "TODO" just to show that this works.
868 2012-01-31 Murray Cumming <murrayc@murrayc.com>
870 Make ReportPlace usable.
872 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
874 * src/main/java/org/glom/web/client/place/ReportPlace.java:
875 Correct the @prefix annotation.
877 2012-01-31 Murray Cumming <murrayc@murrayc.com>
879 OnlineGlomService: Return report HTML rather than the LayoutGroup.
881 * src/main/java/org/glom/web/client/OnlineGlomService.java:
882 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
883 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
884 Change getReportLayout() to getReportHMTL() because we will not need to
885 parse or render the report layout on the client side.
886 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
887 getReportLayout(): Return the libglom LayoutGroup type because we will
888 not need to convert to a shared type, because this will not be used on
890 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
893 Note that there is still no implementation for this.
896 2012-01-27 Murray Cumming <murrayc@murrayc.com>
898 Add a (empty) Report Place, View, and Activity.
900 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
902 * src/main/java/org/glom/web/client/place/HasTablePlace.java
903 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
904 this into a superclass:
905 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
906 and also use it as the base of this new ReportPlace:
907 * src/main/java/org/glom/web/client/place/ReportPlace.java
909 * src/main/java/org/glom/web/client/ui/ReportView.java
910 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
911 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
912 Add these, containing mostly boiler-plate for now.
914 * src/main/java/org/glom/web/client/OnlineGlomService.java
915 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
916 * src/main/java/org/glom/web/server/ConfiguredDocument.java
917 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
918 Add API to get the LayoutGroup for the report.
920 2012-01-23 Murray Cumming <murrayc@murrayc.com>
922 Add and fill a Reports drop-down list box.
924 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
926 * src/main/java/org/glom/web/client/OnlineGlomService.java:
927 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
928 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
929 Added getReports(document, table, localeID), calling
930 ConfiguredDocument.getReports().
931 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
932 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
933 Added setReportsList() and a list widget.
934 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
935 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
940 2012-04-12 Murray Cumming <murrayc@murrayc.com>
942 Translations: Add Esperanto.
944 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
945 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
946 properties: Add this translation because someone took the time to make it.
948 2012-03-15 Murray Cumming <murrayc@murrayc.com>
950 Adapt to the java-libglom 1.21.7 API.
952 * src/main/java/org/glom/web/server/ReportGenerator.java:
953 addToReport(): get_group_secondary_fields() is now
954 get_secondary_fields().
957 2012-03-15 Murray Cumming <murrayc@murrayc.com>
959 Use the latest java-libglom version.
961 * pom.xml: Use java-libglom 1.21.7.
963 2012-03-03 Ben Konrath <ben@bagu.org>
965 Display date and time in details view.
967 https://bugzilla.gnome.org/show_bug.cgi?id=671257
969 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
971 2012-03-05 Murray Cumming <murrayc@murrayc.com>
973 Require the latest java-libglom.
975 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
977 2012-03-04 Murray Cumming <murrayc@murrayc.com>
979 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
981 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
982 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
983 an empty quickfind string. I also corrected libglom to create only
984 empty where clauses for empty quickfind strings, but this avoids the
987 2012-02-24 Ben Konrath <ben@bagu.org>
989 Improve the tabs in the Notebook widget.
993 2012-01-30 Murray Cumming <murrayc@murrayc.com>
995 Translations: Try to translate the strings.
997 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
998 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
999 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1000 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1001 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1002 Take the Open translation from GTK+'s .po files.
1003 Take the Details translation from Glom's po files.
1004 I have added the other strings to Glom so we can get translations that way:
1005 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1007 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1009 TableSelectionViewImpl: Put the search label and entry in a div.
1011 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1012 Put the search widgets in a FlowTable so that the CSS can be used to
1013 style them while keeping them together.
1014 * src/main/webapp/style.css: Mention the new div.
1016 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1018 Translate more strings in more locales.
1020 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1021 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1022 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1023 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1024 Translate the "Details" and "Open" string too.
1026 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1027 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1028 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1029 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1030 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1031 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1032 Add these new locales as placeholders though they currently contain English.
1034 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1036 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1038 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1039 Check the ConfiguredDocument* for null before using it.
1041 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1043 Tell Eclipse about the generated java files.
1045 * .classpath: This lets it find OnlineGlomConstants.java.
1046 It would be nice if Eclipse just used the maven build files.
1048 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1050 Prevent a crash when no locale is specified in the URL.
1052 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1053 Avoid returning a null string, obtained from
1054 Window.Location.getParameter(). This caused a crash when it was
1055 later passed to libglom's API.
1056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1057 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1058 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1059 guard against future null strings.
1061 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1063 Use the ?locale= query param instead of the &lang= token param.
1065 * src/main/java/org/glom/web/client/place/ListPlace.java
1066 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1067 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1068 Remove the lang token key and value.
1070 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1071 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1072 When the user selects a different locale from the chooser, use
1073 Window.Location.assign() to change the URL, which then causes a reload.
1075 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1076 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1077 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1078 * src/main/java/org/glom/web/client/activity/ListActivity.java
1079 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1080 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1081 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1082 * src/main/java/org/glom/web/client/ui/ListView.java:
1083 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1085 Remove localeID member variables and method/constructor parameters, instead
1086 using Utils.getCurrentLocaleID() when we need a localID to pass to
1089 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1091 Internationalize the UI strings.
1093 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1094 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1095 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1096 because it is unused. Messages are apparently strings that can have
1097 parameters, but we do not need that yet, so Contants will be enough for now.
1098 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1099 to say that we support the en and de locales.
1100 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1101 The original English strings.
1102 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1103 Some German translations of the English strings.
1104 The i18n goal then uses the .properties file to generate an
1105 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1106 returns an implementation that returns the translated strings.
1107 The documentation suggests putting these in src/java/*/client/, but it seems
1108 best to put it in src/resources/*/client/.
1109 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1110 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1111 instead of hard-coding them.
1112 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1113 but that does not seem to stop the build, though it confuses Eclipse.
1115 You can see the translated string by adding ?locale=de to the URL, like so:
1116 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1118 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1120 Improve null/empty String checks.
1122 * pom.xml: Add a dependency on commons-lang, to use
1123 org.apache.commons.lang.StringUtils.
1124 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1126 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1127 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1128 Use StringUtils.isEmpty().
1130 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1131 StringUtils class with a static isEmpty() function because we
1132 cannot use org.apache.commons.lang.StringUtils in client-side
1133 GWT code because it (apparently) cannot be compiled to javascript.
1134 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1135 * src/main/java/org/glom/web/client/activity/ListActivity.java
1136 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1137 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1138 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1139 * src/main/java/org/glom/web/client/place/ListPlace.java
1140 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1141 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1142 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1143 * src/main/java/org/glom/web/client/ui/details/Group.java
1144 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1145 our StringUtils.isEmpty() function.
1147 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1149 Update to the latest java-libglom API.
1151 * pom.xml: Require java-libglom 1.21.4.
1152 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1153 getDocumentInfo(), getListViewLayoutGroup():
1154 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1156 * src/main/java/org/glom/web/server/database/DBAccess.java
1157 getFieldsToShowForSQLQueryAddGroup(),
1158 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1159 with either get_database_title_original() or
1160 get_database_title(localeID).
1162 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1164 ConfiguredDocument: Avoid a null pointer exception.
1166 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1167 Initialize localeID to "" to avoid returning a null String which
1168 causes a crash in java-libglom's swing-generated code.
1170 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1172 Some simple renaming.
1174 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1175 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1176 for localeChooser. This seems more appropriate and is less ambiguous
1177 particularly in the .css file.
1179 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1181 ConfiguredDocument: Rename the localedID private member variable.
1183 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1185 Adapt to the latest java-libglom API from git master.
1187 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1188 libglom now uses only Vector instead of List, which uses add() instead of
1191 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1193 ConfiguredDocument: Rename the localedID private member variable.
1195 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1197 Build a source tarball with mvn assembly:single
1199 * assembly.xml: Add this file.
1200 * pom.xml: Use the maven-assembly-plugin and tell it to use
1201 our assembly.xml file.
1203 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1205 OnlineGlomServiceImpl: Get .glom files recursively.
1207 * pom.xml: Depend on commons-io from org.apache.commons.
1208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1209 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1210 files recursively, and with the easier filter for the extension.
1211 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1212 simplify that code too.
1214 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1216 README: Mention that you must install java-libglom packages separately.
1218 But then it works, because java-libglom is now in the central maven
1221 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1223 locales drop-down: Show the correct selected locale when the URL changes.
1225 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1226 .java: setPlace(): Move some code into fillView().
1228 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1230 locales drop-down: Do not lose the primary key.
1232 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1233 start(): onLocaleChange(): Pass the current primary key value,
1234 instead of an empty value.
1236 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1238 locales drop-down: Do not lose the drop-down selection.
1240 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1241 .java (TableSelectionActivity.fillView): Set the selected locale
1242 after changing the drop-down items (though we do not really need
1243 to change them just because the locale changes.)
1245 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1247 locales drop-down: Change the tables list when this changes.
1249 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1250 .java: TableSelectionActivity.start(): Move the async table titles
1251 retrieval into a private fillView() method and also call this when
1252 the chosen locale changes.
1253 Note that the document title is not actually translatable yet, but
1254 that is a problem that I should fix soon in libglom.
1256 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1258 Improve the placement of the locales drop-down.
1260 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1261 Put the title and locales drop-down in a div (gwt.FlowTable).
1262 * src/main/webapp/style.css: Add magic css properties to make this work.
1263 Also remove the left margin from the title so that it lines up with the
1266 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1268 locales selector: Show human-readable locale titles.
1270 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1271 getDocumentInfo(): Use java.util.Locale to show a real title of
1272 each locale, in the locale's own language.
1274 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1276 Add a language/locale selector drop-down.
1278 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1279 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1280 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1281 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1282 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1283 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1284 Add a ListBox to show the available locales. Add getLocaleSelector(),
1285 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1286 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1287 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1288 java: Add these classes.
1289 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1290 start(): Fill the locales ListBox. Handle its change event, firing a
1292 setPlace(): Show the selected locale as specified by the URL token.
1293 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1294 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1295 Handle LocaleChangeEvent, going to a new *Place with that locale.
1297 The placement of the ListBox is not pretty, and it currently uses the ID
1298 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1302 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1304 Search box: Show the search text from the URL token.
1306 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1307 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1308 Add setQuickFindText().
1309 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1310 .java: setPlace(): Store the queryText if the place is a ListPlace,
1311 and call TableSelectionView.setQuickFindText().
1313 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1315 Allow use of translations via, for instance, &lang=de in the URL.
1317 * pom.xml: Use the unstable java-libglom 1.21 version.
1319 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1320 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1321 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1322 init(): Instead of calling TranslatableItem.set_current_locale()
1323 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1324 However, this is only for default locales, which are not needed to
1325 change the locale in the URL.
1326 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1327 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1328 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1329 layout for a particular locale.
1330 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1331 Add get/setDefaultLocaleID().
1332 getDocumentInfo(), getListViewData(), getRelatedListData(),
1333 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1334 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1335 localeID parameter, so we can get the layout for a particular locale.
1337 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1338 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1339 * src/main/java/org/glom/web/client/place/ListPlace.java:
1340 Parse and construct a lang parameter too.
1342 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1343 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1344 passed to subsequent methods and constructors.
1345 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1346 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1347 Store the localeID from the *Place and pass it to other constructors
1348 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1350 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1351 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1352 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1353 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1354 * src/main/java/org/glom/web/client/ui/ListView.java:
1355 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1356 Take localeID parameters and pass them to subsequent constructors and
1357 methods, so that the layout is always retrieved for that locale.
1359 This is rather repetitive.
1361 Note that "" means the original (default) locale of the Glom document,
1362 which is usually English.
1364 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1366 Documents: Remove final keyword to fix startup configuration.
1368 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1369 final keywords on the private member variables because that breaks
1370 the startup, apparently (there are warnings) because it stops them
1371 from being serialized. I added these in the previous commit.
1373 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1375 Documents: Add some final keywords.
1377 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1380 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1382 OnlineGlomServiceImpl: Add to overview comments.
1384 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1385 Note that this is where all the document are loaded. They are not
1386 loaded freshly for each page.
1388 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1392 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1393 Add a TextBox for the text of a quick find.
1394 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1396 setBackLink(): Add a String quickFind parameter.
1397 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1398 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1399 to the base interface, because that is how TableSelectionViewImpl is used.
1400 * src/main/webapp/style.css: Add style for the search box and its label.
1402 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1403 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1404 Add these files, based on the existing TableChangeEvent and
1405 TableChangeEventHandlers.
1406 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1407 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1408 a ListPlace() that the user should be taken to.
1409 * src/main/java/org/glom/web/client/activity/ListActivity.java
1410 start(): Handle it here too and adapt the TableChangeEvent handler to
1411 pass the extra "" quickFind parameter to ListPlace.
1412 * src/main/java/org/glom/web/client/place/ListPlace.java:
1413 Constructor: Take an extra String quickFind parameter and store it,
1414 returning it from a new getQuickFind() method.
1415 getToken(): Put the quickFind text in the URL token.
1416 getPlace(): Parse the quickFind text from the URL token.
1417 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1418 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1419 ListPlace constructor.
1420 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1421 .java: start(): Add a Change handler for the TableSelectionView's
1422 TextBox (via its base HasChangeHandlers interface), firing the new
1423 QuickFindChangeEvent.
1424 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1425 pass the extra "" quickFind parameter.
1427 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1428 setCellTable(): Add a String quickFind parameter and pass it to
1429 the ListViewTable() constructor.
1430 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1431 setCellTable() in the base interface, because that is how ListViewImpl
1434 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1435 Add a String quickFind member variable.
1436 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1437 Constructor: Add a String quickFind parameter, storing it in the
1438 base ListTable's member variable.
1439 onRangeChanged(): Pass quickFind to the
1440 OnlineGlomServiceAsync.getSortedListViewData() and
1441 OnlineGlomServiceAsync.getListViewData() methods.
1443 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1444 getListViewData(), getSortedListViewData(): Add a String quickFind
1445 parameter, passing it to ConfiguredDocument.getListViewData().
1446 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1447 Change getListViewData(), getSortedListViewData() in the base interface,
1448 because that is how OnlineGlomServiceImpl is used, via this:
1449 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1450 Change getListViewData(), getSortedListViewData() here too.
1451 This class can apparently be used to asynchronously call methods on
1452 OnlineGlomService, and GWT seems to implement that after recognizing
1453 just the *Async name convention and the extra AsyncCallback parameters.
1455 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1456 getListViewData(): Add a String quickFind parameter, and pass it to
1457 ListViewDBAccess.getData().
1458 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1459 getListData(): Add a String quickFind parameter and pass it to
1461 getSelectQuery(): Add a String quickFind parameter.
1462 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1463 getSelectQuery(): Add a String quickFind parameter and use it with
1464 Glom.get_find_where_clause_quick() to pass a where_clause to
1465 Glom.build_sql_select_with_where_clause(), to actually filter the
1467 getData(): Add a String quickFind parameter, passing it to getListData().
1468 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1469 va: getData(): Pass an empty string to getListData() for the
1470 quickFind parameter.
1472 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1474 ListTable: Minor change.
1476 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1477 createCellTable(): Make this protected instead of public.
1479 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1481 Many files: Use final for the parameters and use the @override attribute.
1483 2012-01-22 Ben Konrath <ben@bagu.org>
1485 Add anchor links for single line text that starts with http, ftp and www.
1489 2012-01-22 Ben Konrath <ben@bagu.org>
1491 Add ellipsis to single line text in details view.
1495 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1497 Remove all javadoc author tags.
1499 Because they are awkward and meaningless when many people touch
1501 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1503 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1505 Revert the COPYING.LESSER to COPYING rename.
1507 Apparently both should be there if it is LGPL.
1509 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1511 *View: Remove unused imports.
1513 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1514 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1515 * src/main/java/org/glom/web/client/ui/ListView.java:
1516 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1517 Remove unused imports, as suggested by Eclipse.
1519 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1521 Move the *View::Presenter types, and some API into one base View.
1523 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1524 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1525 * src/main/java/org/glom/web/client/ui/ListView.java:
1526 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1527 Presenter, setPresenter() and clear() into a shared base interface,
1528 to avoid the unnecessary duplicate Presenter types and to more clearly
1529 show how the *Views share the same structure, even if they are not
1530 used polymorphically.
1532 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1533 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1535 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1536 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1537 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1539 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1542 Feel free to revert this if there is a good reason for the duplicate
1545 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1547 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1549 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1550 a class member instead of a local variable in the method.
1551 This lets us use it to get the view instances, for use in tests.
1552 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1553 beforeOnlineGlom(): Test some more details of the initial view.
1554 Again, this is not very useful.
1556 To really test gwt-glom we will need to start a local postgresql
1557 instance with local data, like the Glom tests in C++.
1559 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1561 pom.xml: Mention the LGPL license.
1563 * pom.xml: Add a licenses section.
1564 * COPYING.LESSER: Move this to COPYING, which
1565 previously contained the GPL. But gwt-glom is all LGPL.
1567 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1569 Add project information to README and pom.xml.
1571 * README: Add a brief description and mention some mvn
1573 * pom.xml: This extra information shows up in mvn site
1576 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1578 Use the latest java-libglom version.
1580 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1582 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1584 GwtTestOnlineGlom: Test a little more.
1586 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1587 protected rather than private, as suggested by the gwt-test-utils
1589 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1590 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1591 Test the initial visibility of the panels.
1593 However, this is not a very useful test.
1594 And I wonder how we should generally test using this idea for an
1595 activity/places app like ours where the real changes happen implicitly
1596 based on the history token/URL.
1598 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1600 Slight modification to *Mapper comments.
1602 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1603 (DataActivityMapper)
1604 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1606 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1608 Remove comments mentioning GIN because they are just copied from
1609 the example code and are apparently not helpful:
1610 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1611 Also change the mention of a class that is only in the example code.
1613 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1615 GwtTestOnlineGlom test: Minor changes.
1617 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1618 Avoid the long qualified class name and modify the comment
1619 because it is now obvious to me that the mocked class is the only
1620 custom one created via GWT.create().
1622 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1624 Tests: Added the beginnings of a test using gwt-test-utils.
1626 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1627 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1628 which tells gwt-test-utils what class will be tested.
1629 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1630 Add a simple (but empty) test case. One class, used by the OnlineGlom
1631 class, is mocked so that it can be created. However, I am not sure
1632 why only this class needs to be mocked.
1634 Note that mockito seems more popular, and clearer, than easymock,
1635 but I have not got that working yet. It might be a matter of the
1638 This test is run during mvn integration-test.
1640 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1642 Tests: Use junit4-style syntax instead of junit3-style.
1644 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1645 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1646 * src/test/java/org/glom/web/shared/DataItemTest.java:
1647 Use the @Test annotation rather than relying on the test*() prefix.
1648 Also no longer implement TestCase, to avoid triggering support for
1649 the junit3-way, which stops the annotations from working.
1650 Change the imports from import junit.framework.* to
1651 import org.junit.*, which is apparently the new way.
1653 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1655 Added a test for ListPlace token parsing and creation.
1657 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1658 This is much the same as DetailsPlaceTest.
1660 I wonder how we could test the other parts of the *Place API.
1662 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1664 DetailsPlace test: Also test getToken() and recreation via getPlace().
1666 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1667 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1668 recreate it, testing the recreated DetailsPlace for the same parameter
1671 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1673 Use the surefire-report plugin.
1675 * pom.xml: This generates a HTML report about the tests in
1676 target/site/surefire-report.html
1677 when you do mvn surefire-report:report. It seems to be popular/normal.
1679 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1681 Added a test for DetailsPlace.
1683 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1684 Test the getPlace() token parsing.
1686 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1688 Added a first unit test.
1690 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1691 * src/test/java/org/glom/web/shared/DataItemTest.java:
1692 This is a silly test but it is just to get things started. Note that
1693 maven/junit finds the test because it looks in src/test by default.
1695 2011-12-22 Ben Konrath <ben@bagu.org>
1697 Change charsetName to "UTF-8" when replacing line breaks.
1699 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1700 that work in Java (such as "UTF8") will not work when compiled to
1703 This fixes a problem with multi-line details view fields that have hard
1704 line breaks. The "License Text" field on this page demonstrates the
1707 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1709 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1711 2011-12-22 Ben Konrath <ben@bagu.org>
1713 Fix another bug with related list navigation.
1715 I've tested all the navigation buttons in all of the related lists
1716 so things should be good now.
1718 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1720 2011-12-22 Ben Konrath <ben@bagu.org>
1722 Fix a crasher when refreshing the list view with the default table.
1724 This crash will also happen when loading the list view with the default
1725 table from a link or bookmark.
1727 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1728 to the main document selection page when the document id hasn't been
1730 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1731 the main document selection page when the document id hasn't been
1733 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1734 values for the details place when the document id hasn't been set.
1735 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1736 values for the list place when the document id hasn't been set.
1738 2011-12-21 Ben Konrath <ben@bagu.org>
1740 Protect against NPE when glom.document.locale is not in config.
1742 This patch protects against an NPE when glom.document.locale is not in
1743 the config file. This NPE will also happen if glom.document.locale is
1746 The patch also updates the error message to display the class name when
1747 the getMessage() returns null. This was happening when the NPE was
1748 thrown and I had "Configuration Error: null". If an NPE is encountered
1749 with this patch, "Configuration Error: NullPointerException " will be
1752 This commit closes this bug:
1754 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1756 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1758 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1760 Rename onlineglom.properties to onlineglom.properties.sample.
1762 * src/main/resources/onlineglom.properties: Rename to:
1763 * src/main/resources/onlineglom.properties.sample:
1764 * src/main/resources/README: And add this file explaining that people
1765 should rename it back when deploying.
1767 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1769 Allow choosing the translation in the .properties file.
1771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1772 init(): Read a glom.document.locale value from the configuration file
1773 and call Glom's TransatableItem::set_current_locale() method.
1774 * src/main/resources/onlineglom.properties: Add a commented-out
1775 example of this new setting.
1777 It would be better to add &lang=de_DE to the URL, but the current
1778 libglom API does not allow us to do this easily. I am working on that.
1780 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1782 Avoid a crash in parsing of token parameters.
1784 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1785 ava: getTokenParams(): Do not crash if a parameter has a key but no
1786 value, and ignore parameters with neither.
1788 2011-12-17 Murray Cumming <murrayc@murayc.com>
1790 History token building/handling: Improve use of token parameters.
1792 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1793 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1794 and buildParamsToken(HashMap), for use by derived classes.
1795 Make the separator private because it is no longer be needed.
1796 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1797 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1798 instead of manual string concatenation.
1799 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1800 of hardcoded indices and awkward splitting code.
1801 * src/main/java/org/glom/web/client/place/ListPlace.java
1802 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1803 instead of manual string concatenation.
1804 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1805 of hardcoded indices and awkward splitting code.
1806 This should fix bug #666420
1808 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1810 Fix a Navgiation->Navigation typo in the code.
1812 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1813 Rename processNavgiation() to processNavigation().
1815 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1817 Fix a seperator->separator typo in the code.
1819 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1820 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1821 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1824 2011-12-15 Ben Konrath <ben@bagu.org>
1826 Cleanup some comments.
1828 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1830 2011-12-14 Ben Konrath <ben@bagu.org>
1832 Replace \n with <br/> for multiline text in the details view.
1834 Vertical scrollbars are added when needed as well.
1836 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1838 2011-12-14 Ben Konrath <ben@bagu.org>
1840 Specify the font for document selection links.
1842 * src/main/webapp/style.css:
1844 2011-12-14 Ben Konrath <ben@bagu.org>
1846 Fix bouncy CellTable while paging.
1848 This doesn't currently work with related list tables in unselected
1851 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1853 2011-12-14 Ben Konrath <ben@bagu.org>
1855 Revamp the appearance of the document selection page.
1857 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1858 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1859 * src/main/webapp/style.css:
1861 2011-12-13 Ben Konrath <ben@bagu.org>
1863 Set navigation button column to the smallest size possible.
1865 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1867 2011-12-13 Ben Konrath <ben@bagu.org>
1869 Change OpenButton nomenclature to NavigationButton.
1871 Using NavigtionButton makes things more generic. Classes, methods and
1872 variables have been changed.
1874 This is a rename-only refactor.
1876 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1877 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1878 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1879 Renamed from OpenButtonCell.
1880 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1881 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1882 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1884 2011-12-12 Ben Konrath <ben@bagu.org>
1886 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1888 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1889 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1890 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1891 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1893 2011-12-12 Ben Konrath <ben@bagu.org>
1895 Update variable names and comments.
1897 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1898 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1900 2011-12-12 Ben Konrath <ben@bagu.org>
1902 Properly initialize numNonEmptyRows variable to zero.
1904 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1905 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1907 2011-12-05 Ben Konrath <ben@bagu.org>
1909 Add latest mockup with HTML tables.
1911 Features of this mockup:
1913 -> HTML table for flowtable
1914 -> HTML table for flowtable column
1915 -> Example of how related lists would look
1916 -> Not using text entries for data items
1918 The current version of Online Glom doesn't use HTML tables for the
1921 This mockup has been sent to the glom-devel mailing list but it's good
1922 to have it here as well.
1924 * mockups/details-view-html-tables.html:
1926 2011-12-05 Ben Konrath <ben@bagu.org>
1928 Remove unnecessary getPrimaryKeyField() method.
1930 getPrimaryKeyFieldForTable(String) has been renamed to
1931 getPrimaryKeyField(String).
1933 * src/main/java/org/glom/web/server/database/DBAccess.java:
1934 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1935 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1937 2011-12-05 Ben Konrath <ben@bagu.org>
1939 Add string representation of TypedDataItem value to conversion error message.
1941 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1942 message was extracted into its own method to avoid duplication.
1944 2011-12-05 Ben Konrath <ben@bagu.org>
1946 Add type checking to navigation primary key value creation.
1948 Create navigation primary key only if the expected type from the Glom
1949 document matches the type returned by the SQL query.
1951 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1953 2011-12-05 Ben Konrath <ben@bagu.org>
1955 Rename a couple of variables in RelatedListNavigation.
1957 This is a rename-only refactor.
1959 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1961 2011-12-05 Ben Konrath <ben@bagu.org>
1963 Move getListLayoutGroup() into getListViewLayoutGroup().
1965 This removes getListLayoutGroup(). It was only being called by
1966 getListViewLayoutGroup().
1968 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1970 2011-12-05 Ben Konrath <ben@bagu.org>
1972 Remove check for LayoutItem_Portal in list table method.
1974 This check is no longer necessary because the method isn't being used
1975 to create the LayoutItemPortal DTO.
1977 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1979 2011-12-05 Ben Konrath <ben@bagu.org>
1981 Properly support related list navigation.
1983 Navigation from the "Repository Analyzer -> Package Scans ->
1984 Dependencies" related table wasn't working because the primary key for
1985 related tables wasn't being set properly. This commit fixes the
1988 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1989 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1990 doesn't set the primary key properly for related list tables.
1991 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1992 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1993 useful for getting the primary key for list view tables and for related
1995 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1996 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1997 Move code to set the primary key for the table from the abstract
1998 ListDBAccess class to ListViewDBAccess as it's only correct for list
2000 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2001 Properly add primary key to related list tables.
2003 2011-12-02 Ben Konrath <ben@bagu.org>
2005 Properly set the horizontal alignment of fields.
2007 This fix is for both the list tables and the details view.
2009 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2010 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2011 to set the horizontal alignment of fields.
2013 2011-12-02 Ben Konrath <ben@bagu.org>
2015 Display currency codes in the details view.
2017 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2019 2011-12-02 Ben Konrath <ben@bagu.org>
2021 Avoid duplicate JNI call.
2023 JNI is not as efficient as pure Java and this is an easy (and small)
2026 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2027 Use previously retrieved value for whereClauseToTableName instead of
2030 2011-12-02 Ben Konrath <ben@bagu.org>
2032 Rename a couple of variables in RelatedListNavigation.
2034 This is a rename-only refactor.
2036 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2038 2011-12-02 Ben Konrath <ben@bagu.org>
2040 Indicate clearly that a mismatched primary key type is a bug.
2042 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2043 warning to error. Add 'This is a bug.' to message.
2045 2011-12-02 Ben Konrath <ben@bagu.org>
2047 Update / fix some comments.
2049 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2051 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2053 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2054 Fix comments. Add some TODOs.
2056 2011-12-02 Ben Konrath <ben@bagu.org>
2058 Enable navigation to details view with string primary key from related list.
2060 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2061 Create a text primary key value when return type of result is
2062 java.sql.Types.VARCHAR.
2064 2011-12-02 Ben Konrath <ben@bagu.org>
2066 Use checkboxes for booleans in the details view.
2068 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2070 2011-12-01 Ben Konrath <ben@bagu.org>
2072 Improve performance of related list height calculation.
2074 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2075 Put code to calculate the expected height in a static initializer so
2076 that that it's only called once.
2078 2011-12-01 Ben Konrath <ben@bagu.org>
2080 Show related list tables in notebooks (again).
2082 Calculate the height of the related list tables so the Notebook can be
2083 set the correct height. The height of the related list table is also needed by
2084 FlowTable to be able decide how to create the layout.
2086 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2087 and set the Portal height based on the height of the related list
2088 table and the Portal container.
2089 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2090 Add method to calculate the height of the related list tables.
2091 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2092 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2093 calculate the height of the Pager widget.
2095 2011-12-01 Ben Konrath <ben@bagu.org>
2097 Use CellTable API for table property instead of setting style on Element.
2099 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2101 2011-12-01 Ben Konrath <ben@bagu.org>
2103 Make ListViewTable and RelatedListTable a consistent height.
2105 The tables are now a consistent height regardless of the contents of
2106 the table. A hidden button is added to empty rows to ensure that the
2107 height of these rows will match the height of rows with data.
2109 A navigation button column is now added to every table. The width of
2110 the navigation column is set to 0px when a RelatedListTable shouldn't
2111 have navigation buttons. This maintains the a consistent row height in
2112 tables that don't show the navigation buttons.
2114 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2115 navigation column when not needed.
2116 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2117 arguments for navigation button to constructor of ListViewTable.
2118 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2119 hidden button for empty data rows.
2120 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2121 arguments for navigation button to constructor.
2122 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2123 create navigation buttons. Add hideNavigationButtons() method.
2124 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2125 arguments for navigation button to constructor.
2127 2011-12-01 Ben Konrath <ben@bagu.org>
2129 Use 'visibility: hidden' in Utils.getWidgetHeight().
2131 This is better choice because hidden elements are invisible, don't
2132 respond to events and are not part of the tab order. They will,
2133 however, take up space which is required to be able to calculate the
2134 height of the widget.
2136 * src/main/java/org/glom/web/client/Utils.java:
2138 2011-12-01 Ben Konrath <ben@bagu.org>
2140 Use Utils.getWidgetHeight() in FlowTable.
2142 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2144 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2146 2011-12-01 Ben Konrath <ben@bagu.org>
2148 Put the details css class name on the correct table column.
2150 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2152 2011-11-30 Ben Konrath <ben@bagu.org>
2154 Update for java-libglom API change.
2156 The getters and setters on FieldFormatting and NumericFormat were
2157 changed to remove the 'M'.
2159 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2161 2011-11-29 Ben Konrath <ben@bagu.org>
2163 Only allow RelatedListTables in Portals.
2165 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2167 2011-11-29 Ben Konrath <ben@bagu.org>
2169 Only create a contents panel for Portals when title is being set.
2171 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2173 2011-11-29 Ben Konrath <ben@bagu.org>
2175 Set TabLayoutPanel height based on calculated height its widgets.
2177 This is a potential fix for this bug:
2179 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2181 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2183 2011-11-29 Ben Konrath <ben@bagu.org>
2185 Align details field labels and data with the Open buttons.
2187 * src/main/webapp/style.css:
2189 2011-11-29 Ben Konrath <ben@bagu.org>
2191 Remove unnecessary <div> in the Notebook widget.
2193 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2194 method to get container FlowPanel (<div>).
2195 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2196 initWidget() method directly on the TabLayoutPanel widget instead of
2197 Group's container widget.
2199 2011-11-29 Ben Konrath <ben@bagu.org>
2201 Don't add group titles for Portals in Notebooks.
2203 This reverts the previous patch and fixes a bug I introduced with
2204 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2206 * src/main/java/org/glom/web/client/ui/details/Group.java:
2207 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2209 2011-11-28 Ben Konrath <ben@bagu.org>
2211 Remove unused boolean argument in Portal constructor.
2213 Just a code cleanup.
2215 * src/main/java/org/glom/web/client/ui/details/Group.java:
2216 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2218 2011-11-28 Ben Konrath <ben@bagu.org>
2220 Remove hack for glom 1.18 style glom files.
2222 * src/main/java/org/glom/web/client/ui/details/Group.java:
2223 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2224 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2226 2011-11-28 Ben Konrath <ben@bagu.org>
2228 Use Gda Value version of primary key to log result too large error.
2230 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2232 2011-11-28 Ben Konrath <ben@bagu.org>
2234 Don't use TypedDataItem.getText() for Unknown types from the URL.
2236 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2237 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2238 instead of getText().
2239 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2240 String field and getUnknown() method.
2242 2011-11-28 Ben Konrath <ben@bagu.org>
2244 Log an error message when the java-libglom .so is not present.
2246 The error message was being set in the exception but not logged.
2248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2250 2011-11-28 Ben Konrath <ben@bagu.org>
2252 Ignore LayoutItem_CalendarPortals.
2254 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2255 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2257 2011-11-28 Ben Konrath <ben@bagu.org>
2259 Extract method for creating the LayoutItemPortal DTO.
2261 Just breaking the code up into smaller chunks.
2263 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2265 2011-11-28 Ben Konrath <ben@bagu.org>
2269 This should have been added with the refactor. Oops!
2271 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2273 2011-11-28 Ben Konrath <ben@bagu.org>
2275 Create primary key value from URL string using type from Glom document.
2277 See this bug, comments 19 - 25:
2279 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2281 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2282 create a TypeDataItem for the primary key here when loading from a
2283 URL. Show the same string for the primary key value as was received
2284 from the URL string (when loading from a URL).
2285 * src/main/java/org/glom/web/server/Utils.java: Update method for
2286 creating the Gda Value from the TypeDataItem to properly deal with
2287 creating a Gda Value based on the Glom document type for the primary
2288 key value string when loading from a URL.
2289 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2290 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2291 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2292 Update for changed method name.
2294 2011-11-27 Ben Konrath <ben@bagu.org>
2296 Rename PrimaryKeyItem to TypedDataItem.
2298 The name PrimaryKeyItem suggests what the class should be used for.
2299 TypedDataItem is a neutral name that describes the class better.
2301 This is a rename-only refactor.
2303 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2304 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2305 * src/main/java/org/glom/web/client/Utils.java:
2306 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2307 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2308 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2309 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2310 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2311 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2313 * src/main/java/org/glom/web/server/Utils.java:
2314 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2315 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2316 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2317 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2319 2011-11-25 Ben Konrath <ben@bagu.org>
2321 Improve Gda Value conversion from PrimaryKeyItem.
2323 The value from the PrimaryKeyItem is only used if its type match the
2324 type from the glom document.
2326 * src/main/java/org/glom/web/server/Utils.java:
2328 2011-11-25 Ben Konrath <ben@bagu.org>
2330 Manually check if the java-liblgom .so is visible to the JVM.
2332 It seems that Tomcat has problems when a static initializer throws an
2333 exception. This check is done before the first method call into
2334 java-libglom so that execution doesn't continue if the .so is not
2337 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2339 2011-11-25 Ben Konrath <ben@bagu.org>
2341 Improve browser configuration error messages.
2345 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2347 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2348 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2349 getConfigurationErrorMessage() method.
2350 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2351 Get and display a specific configuration error message when no Glom
2352 documents are found.
2353 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2354 Implement getConfigurationErrorMessage() method. Surround configuration
2355 code in the init() method with a try/catch block. This allows the
2356 errors to be caught while keeping the servlet available to retrieve the
2357 configuration error message.
2359 2011-11-25 Ben Konrath <ben@bagu.org>
2361 Don't use Strings to hold primary key values.
2363 The primary key values are now held in a new data object
2364 (PrimaryKeyItem) that holds type information and the primary key value
2365 using the correct type.
2367 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2368 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2370 PrimaryKeyItem instead of String to hold the primary key value.
2371 * src/main/java/org/glom/web/client/Utils.java: Remove
2372 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2373 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2374 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2375 PrimaryKeyItem instead of String to hold the primary key value. Load
2376 document selection page when the documentID has not been set correctly.
2377 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2378 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2380 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2381 Return empty string for URL instead of "null".
2382 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2383 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2384 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2385 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2386 PrimaryKeyItem instead of String to hold primary key values.
2387 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2388 PrimaryKeyValue to a Gda Value.
2389 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2390 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2391 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2392 Replace temporary database access code that uses the PrimaryKeyValue to
2393 Gda Value conversion.
2394 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2395 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2396 PrimaryKeyItem instead of String.
2397 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2398 hold primary key values.
2400 2011-11-24 Ben Konrath <ben@bagu.org>
2402 Use newly added java-libglom API to create queries.
2404 This isn't finished. I still need to stop using Strings for primary key
2405 values in the client code.
2407 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2408 libglom to use fake connections so that retrieving the query string will
2410 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2411 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2412 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2413 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2414 Use the newly added libglom sql methods and classes to create the
2415 query. Add temporary hack to convert primary value strings to Gda
2418 2011-11-23 Ben Konrath <ben@bagu.org>
2420 Don't explicitly set the height of Portals.
2422 See comments 6 - 10 of this bug for details:
2424 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2426 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2428 2011-11-23 Ben Konrath <ben@bagu.org>
2430 Use an HTML table instead of CSS for the FlowTable layout.
2432 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2433 GWT's FlexTable to implement the FlowTable.
2434 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2436 2011-11-18 Ben Konrath <ben@bagu.org>
2438 Add boolean example to HTML table mockup.
2440 * mockups/details-view-html-tables-text-entries.html:
2442 2011-11-17 Ben Konrath <ben@bagu.org>
2444 Ensure the pager buttons are always visible for related lists.
2446 To accomplish this, I've turned off text wrapping in the list view and
2447 related list tables for both the header and data text. The related list
2448 table now has a fixed layout so the it doesn't overflow its container.
2449 This is required to ensure that the cell text is clipped when it
2450 overflows the cell and an ellipsis is added to the right side of the
2451 cell when text is clipped.
2453 A fixed table layout for the related list table in the details view
2454 seems what we want for the details view anyway, so the side-effect is
2457 The ellipsis will only be displayed in Firefox >= 7.
2461 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2463 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2464 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2465 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2467 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2468 Set the 'table-layout: fixed' CSS property to the related list table.
2469 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2470 'white-space: nowrap;' CSS property on both the list view and the
2471 related list tables.
2473 2011-11-16 Ben Konrath <ben@bagu.org>
2475 Rework the fix for empty notebook tab labels.
2477 Setting the empty group titles with its name caused problems for the
2478 details layout. Instead of using libglom's
2479 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2480 to the client when the title is empty. This allows the Notebook to use
2481 the name when the title is empty without affecting anything else.
2483 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2484 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2486 2011-11-16 Ben Konrath <ben@bagu.org>
2488 Set group titles with name when title is empty.
2490 This fixes a problem with an empty notebook tab label in the Lesson
2491 Planner document. The forth tab in the notebook should be "Internet":
2493 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2495 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2496 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2499 2011-11-16 Ben Konrath <ben@bagu.org>
2501 Remove whitespace from the configured username properties.
2503 This assumes that usernames won't have whitespace at the beginning
2504 or end. But I think this is a reasonable assumption.
2506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2507 String.trim() to remove the whitespace from the username properties.
2509 2011-11-15 Ben Konrath <ben@bagu.org>
2511 Add details view mockup with HTML tables and text entries.
2513 This is from the attachment on this bug:
2515 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2517 * mockups/details-view-html-tables-text-entries.html:
2519 2011-11-15 Ben Konrath <ben@bagu.org>
2521 Add space between the columns of the flow table.
2525 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2527 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2528 space between columns in the flow table.
2530 2011-11-15 Ben Konrath <ben@bagu.org>
2532 Add backup files to the .gitignore.
2534 * .gitignore: Ignore files that end with ~.
2536 2011-11-09 Ben Konrath <ben@bagu.org>
2538 Use latest release of gwt-log.
2540 Gwt-log releases are now being submitted to the maven central
2541 repository so manual installation of the jar is no longer required.
2543 * pom.xml: Update version and groupId of gwt-log dependency.
2545 2011-10-31 Ben Konrath <ben@bagu.org>
2547 Don't use GWT numeric formatting to override the glom currency formatting.
2549 Currencies are now displayed like they are in Glom. See this bug:
2551 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2553 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2555 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2556 currency code to constructor and set it when the cell is rendered.
2557 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2558 currency code to the constructor of the NumericCell.
2560 2011-10-27 Ben Konrath <ben@bagu.org>
2562 Require the latest release of java-libglom (1.17.4).
2566 2011-10-26 Ben Konrath <ben@bagu.org>
2568 Add style to Notebook that matches current theme.
2570 It's not the best style in the world but it's better than the default.
2572 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2573 padding at the bottom of the child widgets.
2574 * src/main/webapp/style.css: Add style for the Notebook.
2576 2011-10-26 Ben Konrath <ben@bagu.org>
2578 Move servlet initialization code to overridden init method.
2580 This is half of the solution to getting proper error messages
2581 displayed when configuration errors occur. Here's the relevant bug:
2583 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2585 The rest of the solution involves surrounding the init method with a
2586 try/catch block and setting a global variable with the error /
2587 exception. A new async method should be created to retrieve and display
2588 the error message / exception.
2590 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2591 code from constructor to init method adding exceptions as needed.
2593 2011-10-26 Ben Konrath <ben@bagu.org>
2595 Add script to monitor and restart tomcat if required.
2597 * utils/check-and-recover-tomcat.py: New file.
2599 2011-10-26 Ben Konrath <ben@bagu.org>
2601 Display the correct number of data items in the pager.
2605 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2607 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2608 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2609 The implementation is the same for both tables: Keep track of the
2610 number of non-empty rows and fire and RowCountChangeEvent after the data has
2612 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2613 custom Pager class that subclasses SimplePager to handle displaying
2614 the correct number when empty rows have been added.
2616 2011-10-26 Ben Konrath <ben@bagu.org>
2618 Correct error in previous commit.
2620 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2621 eventBus parameter from listView.setCellTable().
2623 2011-10-26 Ben Konrath <ben@bagu.org>
2625 Fix error in TODO comment.
2627 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2629 2011-10-24 Ben Konrath <ben@bagu.org>
2631 Create Notebook widgets to the details view.
2633 This isn't finished just yet - I still need to create a reasonable
2634 style to match the current theme.
2636 * src/main/java/org/glom/web/client/Utils.java: Add method for
2637 calculating the height of a widget. This is used in the Notebook class.
2638 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2639 new constructor method in Group.
2640 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2641 method for creating child widget that can be used by subclasses
2642 like Notebook. New constructor that allows disabling the group
2643 titles - Notebooks don't set a group title for their child groups.
2644 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2645 to make Notebooks using GWT's TabLayoutPanel.
2646 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2647 constructor that allows disabling the group titles.
2648 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2649 LayoutItemNotebook DTO.
2650 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2651 DTO for Notebooks. It's just an empty class for now but we might need
2652 it to transfer some specific information in the future.
2654 2011-10-21 Ben Konrath <ben@bagu.org>
2656 Add navigation buttons to related list tables.
2658 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2659 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2660 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2661 method getSuitableRecordToViewDetails() for getting the table name
2662 and primary key value for related list navigation buttons.
2663 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2664 private cell renderer class to get the navigation information for
2665 related list tables from the server. Extract the navigation
2666 processing code from the details cell navigation and use it for the
2667 related list navigation as well.
2668 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2669 cell renderer class for the details open buttons. This was needed
2670 because the related list navigation buttons and the list view
2671 navigation buttons need to react differently when clicked.
2672 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2673 the onEnterKeyDown() method because it's now overriden in the
2674 subclasses that are specific to the related list tables and the list
2676 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2677 the vertical size a little because the buttons add a bit of vertical
2678 space to table. This is not a perfect solution because the vertical
2679 size of with table fewer than 5 rows will be a little smaller.
2680 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2681 changes in how navigation buttons are handled.
2682 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2683 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2684 database access object.
2685 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2686 to find the portal for a given relationship name from
2687 RelatedListDBAccess. Add method to find a primary key field for a
2689 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2690 Move code to find the portal for a given relationship name to
2692 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2693 New file: database access object for getting the related list
2694 navigation information (the table name and the primary key value).
2695 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2696 DTO for transferring a table name to navigate to and a primary key
2698 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2699 boolean and getter/setter to specifies if the related list should add
2702 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2704 Use the master branch of java-libglom
2706 * pom.xml: Depend on java-libglom 1.19 instead.
2708 This is the master branch. See also the libglom-1-18 branch.
2710 2011-10-11 Ben Konrath <ben@bagu.org>
2712 Enable the open navigation button when the data has been set.
2714 This avoids having active buttons that don't do anything when the data
2717 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2719 2011-10-11 Ben Konrath <ben@bagu.org>
2721 Use IsWidget interface for FlowTableItem.
2723 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2724 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2726 2011-10-11 Ben Konrath <ben@bagu.org>
2728 Remove GWT styling from open button in details view.
2730 There are still some issues with how the details cell is arranged but
2731 this should be made to match Glom 1.20. I'm going to leave fixing this
2732 until I have Glom 1.20 up and running.
2734 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2735 style name on open button.
2736 * src/main/webapp/style.css: Move and edit details-navigation class.
2737 Re-arrange some classes to make them appear in the same order as the
2740 2011-10-07 Ben Konrath <ben@bagu.org>
2742 Update to GWT 2.4.0.
2744 * .gitignore: Ignore new cache directory.
2745 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2746 * pom.xml: Change GWT and maven plugin to 2.4.0.
2747 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2749 * src/main/java/org/glom/web/client/ClientFactory.java:
2750 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2751 * src/main/java/org/glom/web/client/OnlineGlom.java:
2752 Update source for API changes.
2753 * utils/build-onlineglom-war.sh: Remove cache directory before the
2756 2011-10-07 Ben Konrath <ben@bagu.org>
2758 Add navigation buttons in the details view.
2760 This isn't finished but I thought I'd commit what I have as it's a
2761 pretty good start. I still need to:
2763 1. Change the style so that it fits better into the current theme
2764 2. Adjust the details cell to expand as much as possible.
2766 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2767 click handlers to navigation buttons in the DetailsCells. Create a
2768 refreshData() method to get just the data from the server without the
2770 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2771 Update the tableSelector and browser title when the table name
2772 changes without using the tableSelector.
2773 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2774 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2775 getDetailsCells() to getCells(). Update variable names.
2776 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2777 method to set click handler on navigation button. Rename a few
2778 variables. Add navigation buttons where needed.
2779 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2780 variables and methods.
2781 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2782 navigation boolean and navigation table as required in the
2783 LayoutItemField DTO.
2784 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2785 variables for navigation along with getter/setter methods.
2787 2011-10-07 Ben Konrath <ben@bagu.org>
2789 Rename Field to DetailsCell.
2791 This is a refactor-only commit. No functionality has been added or
2794 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2795 Update variable and method names.
2796 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2797 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2798 variable and method names.
2799 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2801 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2802 variable and method names.
2804 2011-10-07 Ben Konrath <ben@bagu.org>
2806 Create separate methods for layout and data the details view.
2808 This is a refactor-only commit. No functionality has been added or
2811 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2812 private methods: setData(), createLayout().
2814 2011-10-07 Ben Konrath <ben@bagu.org>
2816 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2818 This is part of a change to get navigation buttons in the details view
2819 but it should have been done this way from the start.
2821 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2822 for method name change in TableSelectionView.
2823 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2824 Create TableChangeEvent and set the browser title using the
2825 TableSelectionView API.
2826 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2827 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2828 Change getSelectedTable() to getSelectedTableName(). Add
2829 getSelectedTableTitle().
2831 2011-10-07 Ben Konrath <ben@bagu.org>
2833 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2835 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2837 2011-10-07 Ben Konrath <ben@bagu.org>
2839 Update TableChangeEvent to use newTableName naming convention.
2841 This makes the class more consistent with GWT naming conventions.
2843 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2844 Update for method name change in TableChangeEvent.
2845 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2846 for method name change in TableChangeEvent.
2847 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2848 newTableName variable and getter method. Make toDebugString()
2851 2011-09-30 Ben Konrath <ben@bagu.org>
2853 Disable the pager in the list tables when the data row count is less than the minimum.
2855 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2856 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2858 2011-09-30 Ben Konrath <ben@bagu.org>
2860 Add empty rows to the end of related list and list view tables.
2862 I also extracted the cell rendering classes from the ListTable because
2863 the code was becoming a little crazy with all the anonymous inner
2864 classes. My plan is to use these cell rendering classes in the details
2865 view as well so this refactor will be needed for that change.
2867 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2868 set the row count in related list tables if the data has more rows
2869 than the minimum number of rows visible.
2870 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2871 row count in list view tables if the data has more rows than the
2872 minimum number of rows visible.
2873 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2874 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2876 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2877 for rendering TYPE_NUMERIC cells. The code was extracted from the
2879 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2880 class for rendering cells with buttons in list views. The code was
2881 extracted from the ListTable class.
2882 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2883 for rendering TYPE_TEXT cells. The code was extracted from the
2885 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2886 Add empty rows to the end of the data if required. Implement
2887 ListTable.getMinNumVisibleRows().
2888 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2889 cell renderer code to public classes. Return null in
2890 Column.getValue() for empty rows. Add new abstract method:
2891 getMinNumVisibleRows(). Move code to set the row count of the list view
2892 table to ListViewImpl.
2893 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2894 empty rows to the end of the data if required. Implement
2895 ListTable.getMinNumVisibleRows().
2898 2011-09-27 Ben Konrath <ben@bagu.org>
2900 Use GWT.log for client-side debugging statements.
2902 These are optimized out when deployed so I should have used this method
2903 in the first place. These statements will eventually be replaced with some sort
2904 of notification in the browser.
2906 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2907 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2908 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2909 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2910 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2912 2011-09-27 Ben Konrath <ben@bagu.org>
2914 Put tableselector on the right, back to list link on right.
2916 The idea is that the table selector is acting like a label for the
2917 currently displayed table so it should be placed below the document title. This
2918 puts the table title in a similar position to where it is in Glom.
2920 * mockups/details-contacts.html:
2921 * mockups/details-projects.html:
2922 * mockups/listview-contacts.html:
2923 * mockups/listview-projects.html:
2924 * mockups/style.css:
2925 Update mockups to match how the interfaces currently look.
2926 * src/main/webapp/style.css: Swap positions of backlink with the table
2927 selector. Add some space on the left side of the table selector to
2928 line things up with the document title.
2930 2011-09-27 Ben Konrath <ben@bagu.org>
2932 Add field colouring to details view.
2934 This change re-works how field colouring works. The colour formatting
2935 information is now set to the client with the layout information instead of
2936 with the data. This eliminates the need to send the same colour strings for
2937 data in list view column when colour information is set.
2939 In order to set an alternate colour for negative numeric values, the
2940 number is now sent to client and formatted with the GWT NumberFormat class.
2942 This change also fixes:
2944 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2946 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2947 internationalization framework which is needed for client side numeric
2949 * src/main/java/org/glom/web/client/Utils.java: New file for some
2950 client static utility methods.
2951 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2952 the DataItem object to the Field class. Use a utility method to
2953 create the foreignKeyValue string.
2954 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2955 alignment and text colours in the constructor. Add setData(DataItem)
2956 method. Remove setText(String) method.
2957 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2958 colour information to GlomTextCell. Create and use GlomNumberCell for
2959 rendering numbers. Use utility method to get the string for the
2960 primary key of the key provider. Re-work how the horizontal alignment
2962 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2963 formatting to layout information. Methods for converting the libglom
2964 formatting information were moved from DBAccess.
2965 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2966 numeric formatting (it's now done on the client side). Don't set text
2967 colours in DataItem. Move libglom formatting conversion methods to
2969 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2970 getters/setters for text colour information.
2971 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2972 for transferring the libglom NumericFormat information to the client.
2973 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2974 and getters/setters for: GlomNumericFormat, background colour and
2975 foreground colour strings.
2977 2011-09-26 Ben Konrath <ben@bagu.org>
2979 Simplify code that iterates through the LayoutGroup.
2981 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2983 2011-09-26 Ben Konrath <ben@bagu.org>
2985 Accept Eclipse formatting for OnlineGlomServiceAsync.
2987 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2989 2011-09-26 Ben Konrath <ben@bagu.org>
2991 Don't use the ListDBAccess classes to get the primary key layout information.
2993 This was causing a bug where the wrong index for the hidden primary key
2994 was being sent to the client.
2996 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2997 primary key while creating the LayoutGroup DTO. Create a
2998 LayoutItemField DTO for hidden primary keys. Don't use the
2999 RelatedListDBAccess because it was only used for getting the primary
3001 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3002 access modifier from public to protected for getPrimaryKeyField() and
3003 getPrimaryKeyLayoutItemField().
3004 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3005 abstract method getExpectedResultSize() because RelatedListDBAccess
3006 doesn't have enough info to implement it.
3007 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3008 Remove @Override for getExpectedResultSize().
3009 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3010 Remove method getExpectedResultSize().
3012 2011-09-23 Ben Konrath <ben@bagu.org>
3014 Log which layout (list or details) the ignored item is from.
3016 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3018 2011-09-23 Ben Konrath <ben@bagu.org>
3020 Remove annotations that turn off code formatting in DataItem.
3022 * src/main/java/org/glom/web/shared/DataItem.java:
3024 2011-09-23 Ben Konrath <ben@bagu.org>
3026 Rename GlomField to DataItem and update associated methods.
3028 This is a rename-only refactor. No functionality has been added or
3031 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3032 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3033 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3034 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3035 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3036 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3037 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3038 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3039 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3040 * src/main/java/org/glom/web/server/database/DBAccess.java:
3041 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3042 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3043 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3044 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3045 * src/main/java/org/glom/web/shared/DataItem.java:
3046 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3047 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3049 2011-09-23 Ben Konrath <ben@bagu.org>
3051 Rename GlomDocument to DocumentInfo and update associated methods.
3053 This is a rename-only refactor. No functionality has been added or
3056 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3057 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3058 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3059 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3060 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3062 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3064 2011-09-20 Ben Konrath <ben@bagu.org>
3066 Require java-libglom 1.17.3.
3068 This picks up the fix for the seg fault problem with the Scenes table
3069 in the Openismus Film Manager example.
3073 2011-09-20 Ben Konrath <ben@bagu.org>
3075 Change the way sort clause is added for primary key when no sort clause is requested.
3077 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3078 before the sort clause is created. When a sort clause is not requested, the
3079 sort clause is created by finding the primary key in the LayoutFieldVector
3082 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3084 2011-09-20 Ben Konrath <ben@bagu.org>
3086 Log error message if no documents are found in the configured directory.
3088 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3089 Extract the glom file extension string to a private static final class
3090 variable (mostly as syntactic sugar). Accept a minor formatting change.
3091 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3092 the example glom.document.directory configuration property to make it
3093 more clear that it can any directory, not just the home directory.
3095 2011-09-18 Ben Konrath <ben@bagu.org>
3097 Add related lists to details view.
3099 The related list table has support for paging and sorting just like the
3100 table in the list view.
3102 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3103 SQL queries for the related list tables.
3104 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3105 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3106 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3107 Rename getList methods to getListView and add comments. Remove
3108 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3109 it being unused. Add methods: getDetailsLayoutAndData(),
3110 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3111 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3112 Create the layout and set the data for the fields in one async call
3113 instead of two. Create related lists where appropriate.
3114 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3115 for method name changes in OnlineGlomService.
3116 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3117 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3118 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3120 * src/main/java/org/glom/web/client/ui/ListView.java:
3121 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3122 tableName from setCellTable(). Create a ListViewTable instead of
3124 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3125 represent a data field in the details view.
3126 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3127 from addDetailsCell() to Field class. Keep track of the Fields and
3128 Portals in the details view.
3129 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3130 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3131 and add a method to get it. Add method to set the contents of the
3133 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3134 New class for related list tables. This class has the data provider
3135 for the related list table.
3136 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3137 abstract class which is the base class for the ListViewTable and the
3139 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3140 New class for list view tables. This class has the data provider for
3141 the list view table.
3142 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3143 methods for related list tables. Add more information to the
3144 LayoutItemField and LayoutItemPortal DTOs.
3145 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3146 Remove debugging print statement.
3147 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3148 Remove debugging print statements. Add primary key field to SQL count
3150 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3151 Remove unnecessary LayoutFieldVector parameter from
3152 getResultSizeOfSQLQuery() method.
3153 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3154 New class for related list table database access.
3155 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3156 class that is a wrapper DTO for details view layout and data.
3157 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3158 new 'fromField' string to this DTO.
3159 * src/main/webapp/style.css: Remove bottom margin and override top
3162 2011-09-15 Ben Konrath <ben@bagu.org>
3164 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3166 This sets things up to make it easier to add the data retrieval for
3167 related lists (portals). No user noticeable changes were made with
3170 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3171 class has the code to retrieve the layouts and access the
3172 database using the new database helper classes.
3173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3174 Most of the functionality has been removed from this class. This
3175 class now represents the public interface for the client side
3176 code. It also deals with configuring the servlet and cleaning
3177 things up when the servlet is stopped.
3178 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3179 of static methods into this utility class.
3180 * src/main/java/org/glom/web/server/database/DBAccess.java:
3181 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3182 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3183 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3184 These classes have the database retrieval code. The class hierarchy
3185 has been setup to make it easy to reuse code for similar
3188 2011-09-06 Ben Konrath <ben@bagu.org>
3190 Create separate classes for list table code and the data provider.
3192 As part of this refactor, I also split up the code a bit to make it
3195 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3196 table code to two new classes (below).
3197 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3198 with code from ListViewImpl.
3199 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3200 New file with code from ListViewImpl.
3202 2011-09-06 Ben Konrath <ben@bagu.org>
3204 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3206 This fixes the LayoutItemPortal DTO to match the libglom layout object
3209 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3211 2011-09-01 Ben Konrath <ben@bagu.org>
3213 Set title of Portals in the Details View.
3215 * pom.xml: Bump required version of java-libglom to 1.17.1.
3216 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3217 widget creation to its own class. Add comments to constructor.
3218 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3219 The code is mostly from the Group class with the title now set.
3220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3221 title of Portal. Update some comments. Fix some code formatting.
3223 2011-09-01 Ben Konrath <ben@bagu.org>
3225 Remove TODO comment for the flow table column width.
3227 The flow table column width is working correctly and doesn't need to be
3228 changed. See this mailing list post for more info:
3230 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3232 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3234 2011-08-27 Ben Konrath <ben@bagu.org>
3236 Add document title (database name) to top of the browser page.
3238 I added the document title to the TableSelecitonView but that will
3239 change if / when we add a view that doesn't require table selection.
3241 * mockups/details-contacts.html:
3242 * mockups/details-projects.html:
3243 * mockups/listview-contacts.html:
3244 * mockups/listview-projects.html:
3245 * mockups/style.css: Add document title to mockups to keep things
3247 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3248 sizes to account for the document title.
3249 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3250 Set the document title when it has been retrieved from the server.
3251 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3252 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3253 and implement setDocumentTitle(String) method.
3254 * src/main/webapp/style.css: Add ID for document title style.
3256 2011-08-25 Ben Konrath <ben@bagu.org>