1 2012-05-07 Murray Cumming <murrayc@murrayc.com>
5 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
6 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
7 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
9 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
11 * src/main/java/org/glom/web/server/database/DBAccess.java:
12 convertResultSetToDTO(), getPortal():
13 * src/main/java/org/glom/web/server/database/ListDBAccess.java
15 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
16 Add checks for null objects and out of range access, with log messages to
17 give hints so we can fix these properly.
19 2012-05-07 Murray Cumming <murrayc@murrayc.com>
21 Portals: some corrections.
23 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
25 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
26 constructor: Use getRelationshipNameUsed() instead of getName(), because
27 that is what is meant.
28 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
29 getFromField(): Fix a typo, to get the field name, not the table name.
30 * src/main/java/org/glom/web/server/database/DBAccess.java:
31 getPortal(): Fix a typo that stopped this from working.
33 2012-05-07 Murray Cumming <murrayc@murrayc.com>
35 LayoutItemPortal: Also override getTitleOriginal().
37 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
38 This lets the base getTitle() with no parameters work.
39 TODO: Test this properly.
41 2012-05-06 Murray Cumming <murrayc@murrayc.com>
43 LayoutItemPortal: getTitle*(): Use the relationship title.
45 2012-05-06 Murray Cumming <murrayc@murrayc.com>
47 LayoutItemField: Fix loading of custom titles.
49 * src/main/java/org/glom/web/server/libglom/Document.java
50 loadDataLayoutItemField(): The title, if any, instead of the field
51 title, is stored in a title_custom node. Load it from there.
52 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
54 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
55 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
56 getTitle*() overrides.
57 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
60 2012-05-06 Murray Cumming <murrayc@murrayc.com>
62 LayoutItemField: Fall back to field titles, so some are really shown.
64 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
65 Override getTitleOriginal() and getTitle(), as in java-libglom.
66 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
69 2012-05-06 Murray Cumming <murrayc@murrayc.com>
71 Correct use of setExpectedResultSize().
73 * src/main/java/org/glom/web/server/ConfiguredDocument.java
74 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
75 Use setExpectedResultSize only on top-level groups (for instance, the
76 list layout) or on child portals (in details views).
77 Use the correct table name for portals to avoid SQL errors.
78 Update the expected counts when returning cached layouts.
80 2012-05-06 Murray Cumming <murrayc@murrayc.com>
82 Document: Interpret no group column count as 1.
84 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
85 default, though we now check for this in the UI code anyway.
87 2012-05-06 Murray Cumming <murrayc@murrayc.com>
91 2012-05-06 Murray Cumming <murrayc@murrayc.com>
93 Translatable: Use Hashmap instead of Treemap because GWT supports it.
95 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
96 The use of Treemap lead to this error from async methods, with no
98 "The response could not be deserialized"
100 2012-05-06 Murray Cumming <murrayc@murrayc.com>
102 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
104 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
105 when using the Google -> GWT Compile, or
106 g toolbar button -> GWT Compile Project... feature in Eclipse.
108 2012-05-06 Murray Cumming <murrayc@murrayc.com>
110 ListTable.addColumn(): Protect against a null Formatting.
112 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
113 Create a default Formatting if it is null, because that is the simplest
116 2012-05-06 Murray Cumming <murrayc@murrayc.com>
118 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
120 * src/main/java/org/glom/web/server/ConfiguredDocument.java
121 updateLayoutGroup(): Check that the field is not null.
123 2012-05-06 Murray Cumming <murrayc@murrayc.com>
125 ListViewImpl: Protected against a bad cast error.
127 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
128 onEnterKeyDown(): Do not cast without an instanceof check.
130 2012-05-06 Murray Cumming <murrayc@murrayc.com>
132 ListTable: Protect against an out of range error.
134 * src/main/java/org/glom/web/client/ui/list/ListTable.java
135 createCellTable(): This is unlikely, but can happen while debugging.
137 2012-05-06 Murray Cumming <murrayc@murrayc.com>
139 AsyncMessage onFailure() callbacks: Log the exception message.
141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
142 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
143 * src/main/java/org/glom/web/client/activity/ListActivity.java:
144 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
145 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
146 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
147 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
148 These are useful clues when something is wrong.
150 2012-05-06 Murray Cumming <murrayc@murrayc.com>
152 ConfiguredDocument: Avoid a null dereference.
154 * src/main/java/org/glom/web/server/ConfiguredDocument.java
155 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
156 details maps are created.
158 2012-05-06 Murray Cumming <murrayc@murrayc.com>
160 Document: Correct the port number parsing.
162 * src/main/java/org/glom/web/server/libglom/Document.java:
163 This lets us actually connect to the database and show the document.
165 2012-05-05 Murray Cumming <murrayc@murrayc.com>
169 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
170 user-interaction, asking us to load a temporary URL in a browser.s
171 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
172 which is apparently necessary for testing the service. See the comment.
173 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
174 Show the exception, if any. This is how I saw the 404 in the HTML in
177 2012-05-05 Murray Cumming <murrayc@murrayc.com>
179 DocumentTest: Move the .glom files into the resources directory.
181 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
182 URI via getResource().
184 2012-05-05 Murray Cumming <murrayc@murrayc.com>
186 Document: Remove the FieldIdentifies inner class.
188 * src/main/java/org/glom/web/server/libglom/Document.java: We only
189 use the Relationship (though the same function in libglom is maybe
190 used in other ways) and so this removes a compiler warning.
192 2012-05-05 Murray Cumming <murrayc@murrayc.com>
194 Document.load() Remove the error code parameter.
196 * src/main/java/org/glom/web/server/libglom/Document.java: load():
197 Remove the parameter. We do not set it yet and it could never have
198 worked as an output parameter (though maybe it did in java-libglom).
199 We could use an exception if we really want the failure reason.
200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
202 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
203 setUp(), testGetSuitableTableToViewDetails(): Adapt.
205 2012-05-05 Murray Cumming <murrayc@murrayc.com>
207 Make some inner classes static.
209 * src/main/java/org/glom/web/server/ConfiguredDocument.java
210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
211 * src/main/java/org/glom/web/server/ReportGenerator.java
212 * src/main/java/org/glom/web/server/libglom/Document.java
213 Make all inner classes static that can be static.
215 2012-05-05 Murray Cumming <murrayc@murrayc.com>
217 OnlineGlomServiceImpl: Do not load and check for java-libglom.
219 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
220 init(): We do not use java-libglom any more.
222 2012-05-05 Murray Cumming <murrayc@murrayc.com>
224 Remove mentions of java-libglom.
226 * README: Remove mention of java-libglom, because it no longer needed.
227 * utils/build-onlineglom-war.sh:
228 * utils/check-and-recover-tomcat.py:
229 * utils/install-onlineglom-war.sh: Remove these as they are no longer
230 useful. Building is now far easier, with no need for jhbuild.
232 2012-05-05 Murray Cumming <murrayc@murrayc.com>
234 Fix the build (mvn package)
236 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
237 (LayoutGroup): Make the LayoutItemList inner class static and protected.
238 Otherwise the GWT Java->Javascript compilation fails with just this
239 error, during mvn package or when attempting to view in a browser,
240 in the GWT developer mode in Eclipse.
242 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
243 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
244 [INFO] Compiling module org.glom.web.OnlineGlom
245 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
246 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
247 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
248 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
249 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
250 [INFO] [ERROR] Cannot proceed due to previous errors
252 It has taken me 2 days to find out what was causing that. After reducing
253 the code, the compiler eventually showed me the full error message.
255 2012-05-04 Murray Cumming <murrayc@murrayc.com>
257 ConfiguredDocument: Cache the cloned and stripped layouts.
259 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
260 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
261 layout in a map, so we can retrieve it again without rebuilding it.
263 2012-05-04 Murray Cumming <murrayc@murrayc.com>
265 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
267 2012-05-04 Murray Cumming <murrayc@murrayc.com>
269 libglom classes: Implement some auto-generated emthods.
271 2012-05-04 Murray Cumming <murrayc@murrayc.com>
273 Add GwtTestOnlineGlomService.
275 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
276 However, this (and the other GwtTest*) does not seem to run during
279 2012-05-04 Murray Cumming <murrayc@murrayc.com>
281 Remove use of unsupported features from client code.
283 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
284 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
285 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
286 Use our client version of StringUtils instead of the apache commons one.
288 However, the GWT Javascript compliation still fails.
290 2012-04-25 Murray Cumming <murrayc@murrayc.com>
292 Add a Field class and implement some loading of it in Document.
294 2012-04-25 Murray Cumming <murrayc@murrayc.com>
296 Initial Document loading implementation, instead of libglom.
298 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
299 and Translatable classes, and adapt the rest of the code to use them.
300 However, this is still missing Layout and Field classes and loading.
302 2012-04-24 Murray Cumming <murrayc@murrayc.com>
304 Use of jOOQ: Move Field creation into a utility method.
306 * src/main/java/org/glom/web/server/SqlUtils.java:
307 This lets us improve it more easily.
309 2012-04-24 Murray Cumming <murrayc@murrayc.com>
311 Use of jOOQ: Improve the code to COUNT a sub-select.
313 * src/main/java/org/glom/web/server/SqlUtils.java:
314 Move initial query creation into
315 build_sql_select_step_with_where_clause().
316 build_sql_select_count_rows(): Use the jOOQ API instead of
317 concatentating text, because a jOOQ Select*Step is a TableLike,
318 which is what from() takes.
320 2012-04-23 Murray Cumming <murrayc@murrayc.com>
322 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
324 * pom.xml: Depend on jooq.
325 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
326 methods with jOOQ, based on the C++ implementations in libglom,
327 with some changes to the logic required by jooQ.
328 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
330 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
331 * src/main/java/org/glom/web/server/ReportGenerator.java:
332 * src/main/java/org/glom/web/server/SqlUtils.java:
333 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
334 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
335 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
336 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
337 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
338 Adapt. In particular, the SqlUtils methods now need to take a Connection,
339 because jOOQ needs that, though it seems unnecessary.
341 This is not quite finished. Ideally jOOQ would help us to build
342 table_name.field_name names, quoting and escaping them properly.
343 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
345 2012-04-21 Murray Cumming <murrayc@murrayc.com>
347 Move use of Glom.build_sql*() into a new SqlUtils class.
349 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
350 to wrap Glom.build_sql*(). The parameter types are still Glom one,
351 but this will make it easier to start using something other than
352 libglom or SqlBuilder.
354 2012-04-21 Murray Cumming <murrayc@murrayc.com>
356 Update the project URL.
358 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
360 2012-04-21 Murray Cumming <murrayc@murrayc.com>
362 Main layout: Use a FlowTable instead of absolute positioning.
364 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
365 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
366 child panels/widgets must have an absolute position. But that is annoying, so
367 this adds a FlowTable and puts the child panels in there.
369 2012-04-21 Murray Cumming <murrayc@murrayc.com>
371 GwtTestOnlineGlom: Comment out unused code.
373 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
374 Eclipse has started to say that some code is unused.
376 2012-04-21 Murray Cumming <murrayc@murrayc.com>
378 Update to the latest versions of dependencies.
380 * pom.xml: Update version numbers of dependencies to the latest
382 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
383 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
384 * src/main/java/org/glom/web/server/ReportGenerator.java:
385 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
386 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
387 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
389 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
390 Modify the imports where necessary.
392 2012-04-17 Murray Cumming <murrayc@murrayc.com>
394 Style: Remove overflow:hidden from searchbox
396 * src/main/webapp/style.css: Because this pushes the Back To Link
397 label/link on to the next row, which is then hidden due to the
398 hard-coded (in ems) height.
400 2012-04-20 Murray Cumming <murrayc@murrayc.com>
402 Remove some duplicate code.
404 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
405 getDocumentInfo(): This must have been duplicated during the merge from the
410 2012-04-19 Murray Cumming <murrayc@murrayc.com>
412 Reports: Localize the waiting for report message.
414 * src/main/java/org/glom/web/client/activity/ReportActivity.java
415 start(): Get the message from the contants.
416 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
418 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
419 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
420 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
421 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
422 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
423 Update these files with the English text for newer strings for now.
425 2012-04-19 Murray Cumming <murrayc@murrayc.com>
427 Reports: Show a message while waiting for the report.
429 * src/main/java/org/glom/web/client/ui/ReportView.java
430 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
431 Add setWaitingText(), to show a message saying that we are
432 waiting for the report to be ready.
433 * src/main/java/org/glom/web/client/activity/ReportActivity.java
434 start(): Call setWaitingText() before calling the async
437 2012-04-19 Murray Cumming <murrayc@murrayc.com>
439 ReportGenerator: Specify date and time formats.
441 * src/main/java/org/glom/web/server/ReportGenerator.java:
442 createFieldValueElement(): Use the default (and localized)
443 short formats, though we still need a way to show 4-digit
444 years without providing the format for every locale.
445 * src/main/java/org/glom/web/server/database/DBAccess.java:
446 convertResultSetToDTO(): Use the short formats here too.
448 2012-04-18 Murray Cumming <murrayc@murrayc.com>
450 ReportGenerator: Use the correct numeric formatting.
452 * src/main/java/org/glom/web/server/ReportGenerator.java
453 createFieldExpression(), createFieldValueElement(): Take the
454 whole LayoutItem_Field instead of just the field name, so
455 we have access to the formatting.
456 createFieldValueElement(): Use JRTextField.setPattern() to
457 specify the numeric formatting, with the help of a
458 regular DecimalFormat.
460 2012-04-18 Murray Cumming <murrayc@murrayc.com>
462 ReportGenerator: Avoid showing null for group by titles.
464 * src/main/java/org/glom/web/server/ReportGenerator.java
465 generateReport(): Use setBlankWhenNull() on the field title
466 style too, because this is used for values in group by
469 2012-04-18 Murray Cumming <murrayc@murrayc.com>
471 ReportGenerator: Add a colon to titles in vertical groups.
473 * src/main/java/org/glom/web/server/ReportGenerator.java
474 addFieldToDetailBandVertical(): Pass true for the withColon
477 2012-04-18 Murray Cumming <murrayc@murrayc.com>
479 ReportGenerator: Simplify the code by using Position more.
481 2012-04-18 Murray Cumming <murrayc@murrayc.com>
483 Reports: Support vertical groups, roughly.
485 * src/main/java/org/glom/web/server/ReportGenerator.java:
486 addToReport(): Rename to addGroupToReport() and, if necessary,
487 call the new addVerticalGroupToReport() method.
488 createFieldValueElement(): Let the caller specify the Y position
491 2012-04-17 Murray Cumming <murrayc@murrayc.com>
493 Reports: Allow a second report to be shown.
495 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
496 clear(): Do not remove the HTML widget, which broke the whole layout.
498 2012-04-17 Murray Cumming <murrayc@murrayc.com>
500 Locales drop-down: Show that we use English by default.
502 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
503 fillView(): When we use English, just because that is the default, when
504 no locale is specified, show that in the Locales drop-down instead of
505 just showing the first item.
507 2012-04-17 Murray Cumming <murrayc@murrayc.com>
509 Unselect the Report/Locale/Table combo item when appropriate.
511 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
512 setPlace(): clear reportName if this is not a ReportPlace.
513 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
514 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
515 When the provided name is empty, unselect all items, so that none are
516 indicated. This uses a for loop because I cannot find a single method
519 2012-04-17 Murray Cumming <murrayc@murrayc.com>
521 Report: Give the user a way to get back to the list.
523 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
524 start(), setPlace(): Show the Back To List link on reports, and also
525 interpret selecting the empty report item as back to list.
527 2012-04-13 Murray Cumming <murrayc@murrayc.com>
529 Really show the selected Report name.
531 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
532 setPlace(): Store the reportName here, if it is that kind of Place.
533 fillView(): Set the selected Report after filling the list of reports.
534 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
535 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
536 null Strings, though we need some way to unselect all ListBox items
539 2012-04-13 Murray Cumming <murrayc@murrayc.com>
541 ReportGenerator: Try to avoid some problems.
543 * src/main/java/org/glom/web/server/ReportGenerator.java
544 addField(): Try to avoid duplicates, and avoid using a null
547 2012-04-13 Murray Cumming <murrayc@murrayc.com>
549 Reports: Use quickFind.
551 * src/main/java/org/glom/web/client/OnlineGlomService.java;
552 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
554 getReportHTML(): Add a quickFind parameter.
555 * src/main/java/org/glom/web/client/activity/ReportActivity.java
556 start(): Pass the quickFind parameter.
557 * src/main/java/org/glom/web/server/ReportGenerator.java
558 generateReport(): Take a quickFind parameter.
560 2012-04-13 Murray Cumming <murrayc@murrayc.com>
562 ReportPlace: Actually use the report name.
564 * src/main/java/org/glom/web/client/place/ReportPlace.java
565 getPlace(): Do not assign the report name to the quickfind.
567 2012-04-13 Murray Cumming <murrayc@murrayc.com>
569 Show java.library.path when complaining.
571 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
572 init(): When telling us to check java.library.path, show the
575 2012-03-06 Murray Cumming <murrayc@murrayc.com>
577 ReportGenerator: Do not show nulls.
579 2012-03-06 Murray Cumming <murrayc@murrayc.com>
581 ReportGenerator: Make the title font larger.
583 2012-03-06 Murray Cumming <murrayc@murrayc.com>
585 ReportGenerator: Put field titles inside groups, if there are groups.
587 2012-03-06 Murray Cumming <murrayc@murrayc.com>
589 ReportGenerator: Take the Report itself instead of the name and group.
591 * src/main/java/org/glom/web/server/ConfiguredDocument.java
592 Remove getReportLayoutGroup().
593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
594 getReportHTML(): Pass the report instead
595 of its name and layout group.
596 * src/main/java/org/glom/web/server/ReportGenerator.java
597 generateReport(): Use the report object to use the title
600 2012-03-06 Murray Cumming <murrayc@murrayc.com>
602 ReportGenerator: Remove designBand parameters.
604 * src/main/java/org/glom/web/server/ReportGenerator.java:
605 Make designBand a class member instead of passing it to all
608 2012-03-06 Murray Cumming <murrayc@murrayc.com>
610 ReportGenerator: Add lines, a bit like in the desktop version.
612 * src/main/java/org/glom/web/server/ReportGenerator.java
613 addToReport(): Use JRDesignLine.
615 2012-03-06 Murray Cumming <murrayc@murrayc.com>
617 ReportGenerator: Correct the title positions and use some bold style.
619 * src/main/java/org/glom/web/server/ReportGenerator.java:
620 Break the code up into reusable functions, correct the placement of
621 titles, and use normal/bold styles as in the reports in the desktop
624 2012-03-06 Murray Cumming <murrayc@murrayc.com>
626 ReportGenerator: Add a header band to show the field titles.
628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
629 getReportHTML(): Pass the localeId to the ReportGenerator
631 * src/main/java/org/glom/web/server/ReportGenerator.java
632 constructor: Take the localeID so we can get translated field
634 generateReport(), addToReport(), addFieldToBand(): Add field
635 titles in a column header band.
637 2012-03-05 Murray Cumming <murrayc@murrayc.com>
639 Reports drop-down list: Some improvement.
641 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
642 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
643 Adedd setSelectedReport(),
644 setReportList(): Add a blank line so that the user can select the
646 * src/main/java/org/glom/web/client/activity/ReportActivity.java
647 start(): Show the current report by calling setSelectedReport().
648 This does not seem to work yet.
650 2012-03-05 Murray Cumming <murrayc@murrayc.com>
652 DetailsActivity, ListActivity: Move some variables into a base class.
654 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
655 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
656 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
657 the clientFactory, documentID, tableName and authenticationPopup into
658 a base class, to avoid duplication.
660 2012-03-05 Murray Cumming <murrayc@murrayc.com>
662 Translate the Reports label.
664 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
665 Get the "Reports" label string from the constants.
666 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
667 perties: Add Reports to the constants.
669 2012-03-05 Murray Cumming <murrayc@murrayc.com>
671 Reports: Implement grouping.
673 * src/main/java/org/glom/web/server/ReportGenerator.java:
674 Handle LayoutItem_GroupBy items and try to do the right thing
675 with JRDesignGroup. It seems to work.
677 2012-03-04 Murray Cumming <murrayc@murrayc.com>
679 Actually show some data with JasperReports.
681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
682 getReportHTML(): Move most code into a ReportGenerator class.
683 * src/main/java/org/glom/web/server/ReportGenerator.java:
684 Recurse into sub-groups, adding fields to the JasperDesign's details
685 band. Note that we must set an arbitrary width and height, or it just
686 will not show any data.
688 2012-03-04 Murray Cumming <murrayc@murrayc.com>
690 Reports Chooser: Show the titles, not the names.
692 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
693 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
694 and the names as the values.
695 * src/main/java/org/glom/web/server/ConfiguredDocument.java
696 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
697 group now that we provide the report name, so it should always
700 2012-02-15 Murray Cumming <murrayc@murrayc.com>
702 Depend on jasperreports.
704 * pom.xml: Add the dependency. My plan is to use this on the
707 2012-01-31 Murray Cumming <murrayc@murrayc.com>
709 Implement navigation to report places.
711 * src/main/java/org/glom/web/client/activity/ReportActivity.java
712 start(): Do not bother to handle all events here.
713 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
714 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
715 Added getSelectedReport().
716 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
717 .java: start(): When handling a change to the reports chooser,
718 call getSelectedReport() and goTo() its ReportPlace.
719 * src/main/java/org/glom/web/client/ui/ReportView.java
720 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
721 Added setReportHTML() which puts the html in a gwt HTML widget.
722 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
723 getReportHTML(): Return "TODO" just to show that this works.
725 2012-01-31 Murray Cumming <murrayc@murrayc.com>
727 Make ReportPlace usable.
729 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
731 * src/main/java/org/glom/web/client/place/ReportPlace.java:
732 Correct the @prefix annotation.
734 2012-01-31 Murray Cumming <murrayc@murrayc.com>
736 OnlineGlomService: Return report HTML rather than the LayoutGroup.
738 * src/main/java/org/glom/web/client/OnlineGlomService.java:
739 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
741 Change getReportLayout() to getReportHMTL() because we will not need to
742 parse or render the report layout on the client side.
743 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
744 getReportLayout(): Return the libglom LayoutGroup type because we will
745 not need to convert to a shared type, because this will not be used on
747 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
750 Note that there is still no implementation for this.
753 2012-01-27 Murray Cumming <murrayc@murrayc.com>
755 Add a (empty) Report Place, View, and Activity.
757 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
759 * src/main/java/org/glom/web/client/place/HasTablePlace.java
760 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
761 this into a superclass:
762 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
763 and also use it as the base of this new ReportPlace:
764 * src/main/java/org/glom/web/client/place/ReportPlace.java
766 * src/main/java/org/glom/web/client/ui/ReportView.java
767 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
768 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
769 Add these, containing mostly boiler-plate for now.
771 * src/main/java/org/glom/web/client/OnlineGlomService.java
772 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
773 * src/main/java/org/glom/web/server/ConfiguredDocument.java
774 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
775 Add API to get the LayoutGroup for the report.
777 2012-01-23 Murray Cumming <murrayc@murrayc.com>
779 Add and fill a Reports drop-down list box.
781 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
783 * src/main/java/org/glom/web/client/OnlineGlomService.java:
784 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
785 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
786 Added getReports(document, table, localeID), calling
787 ConfiguredDocument.getReports().
788 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
789 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
790 Added setReportsList() and a list widget.
791 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
792 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
797 2012-04-12 Murray Cumming <murrayc@murrayc.com>
799 Translations: Add Esperanto.
801 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
802 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
803 properties: Add this translation because someone took the time to make it.
805 2012-03-15 Murray Cumming <murrayc@murrayc.com>
807 Adapt to the java-libglom 1.21.7 API.
809 * src/main/java/org/glom/web/server/ReportGenerator.java:
810 addToReport(): get_group_secondary_fields() is now
811 get_secondary_fields().
814 2012-03-15 Murray Cumming <murrayc@murrayc.com>
816 Use the latest java-libglom version.
818 * pom.xml: Use java-libglom 1.21.7.
820 2012-03-03 Ben Konrath <ben@bagu.org>
822 Display date and time in details view.
824 https://bugzilla.gnome.org/show_bug.cgi?id=671257
826 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
828 2012-03-05 Murray Cumming <murrayc@murrayc.com>
830 Require the latest java-libglom.
832 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
834 2012-03-04 Murray Cumming <murrayc@murrayc.com>
836 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
838 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
839 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
840 an empty quickfind string. I also corrected libglom to create only
841 empty where clauses for empty quickfind strings, but this avoids the
844 2012-02-24 Ben Konrath <ben@bagu.org>
846 Improve the tabs in the Notebook widget.
850 2012-01-30 Murray Cumming <murrayc@murrayc.com>
852 Translations: Try to translate the strings.
854 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
855 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
856 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
857 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
858 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
859 Take the Open translation from GTK+'s .po files.
860 Take the Details translation from Glom's po files.
861 I have added the other strings to Glom so we can get translations that way:
862 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
864 2012-01-27 Murray Cumming <murrayc@murrayc.com>
866 TableSelectionViewImpl: Put the search label and entry in a div.
868 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
869 Put the search widgets in a FlowTable so that the CSS can be used to
870 style them while keeping them together.
871 * src/main/webapp/style.css: Mention the new div.
873 2012-01-27 Murray Cumming <murrayc@murrayc.com>
875 Translate more strings in more locales.
877 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
878 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
879 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
880 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
881 Translate the "Details" and "Open" string too.
883 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
884 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
885 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
886 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
887 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
888 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
889 Add these new locales as placeholders though they currently contain English.
891 2012-01-27 Murray Cumming <murrayc@murrayc.com>
893 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
895 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
896 Check the ConfiguredDocument* for null before using it.
898 2012-01-26 Murray Cumming <murrayc@murrayc.com>
900 Tell Eclipse about the generated java files.
902 * .classpath: This lets it find OnlineGlomConstants.java.
903 It would be nice if Eclipse just used the maven build files.
905 2012-01-26 Murray Cumming <murrayc@murrayc.com>
907 Prevent a crash when no locale is specified in the URL.
909 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
910 Avoid returning a null string, obtained from
911 Window.Location.getParameter(). This caused a crash when it was
912 later passed to libglom's API.
913 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
914 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
915 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
916 guard against future null strings.
918 2012-01-26 Murray Cumming <murrayc@murrayc.com>
920 Use the ?locale= query param instead of the &lang= token param.
922 * src/main/java/org/glom/web/client/place/ListPlace.java
923 * src/main/java/org/glom/web/client/place/DetailsPlace.java
924 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
925 Remove the lang token key and value.
927 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
928 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
929 When the user selects a different locale from the chooser, use
930 Window.Location.assign() to change the URL, which then causes a reload.
932 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
933 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
934 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
935 * src/main/java/org/glom/web/client/activity/ListActivity.java
936 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
937 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
938 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
939 * src/main/java/org/glom/web/client/ui/ListView.java:
940 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
942 Remove localeID member variables and method/constructor parameters, instead
943 using Utils.getCurrentLocaleID() when we need a localID to pass to
946 2012-01-26 Murray Cumming <murrayc@murrayc.com>
948 Internationalize the UI strings.
950 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
951 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
952 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
953 because it is unused. Messages are apparently strings that can have
954 parameters, but we do not need that yet, so Contants will be enough for now.
955 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
956 to say that we support the en and de locales.
957 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
958 The original English strings.
959 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
960 Some German translations of the English strings.
961 The i18n goal then uses the .properties file to generate an
962 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
963 returns an implementation that returns the translated strings.
964 The documentation suggests putting these in src/java/*/client/, but it seems
965 best to put it in src/resources/*/client/.
966 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
967 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
968 instead of hard-coding them.
969 Note that we cannot import OnlineGlomConstants because it does not exist yet,
970 but that does not seem to stop the build, though it confuses Eclipse.
972 You can see the translated string by adding ?locale=de to the URL, like so:
973 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
975 2012-01-24 Murray Cumming <murrayc@murrayc.com>
977 Improve null/empty String checks.
979 * pom.xml: Add a dependency on commons-lang, to use
980 org.apache.commons.lang.StringUtils.
981 * src/main/java/org/glom/web/server/ConfiguredDocument.java
982 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
983 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
984 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
985 Use StringUtils.isEmpty().
987 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
988 StringUtils class with a static isEmpty() function because we
989 cannot use org.apache.commons.lang.StringUtils in client-side
990 GWT code because it (apparently) cannot be compiled to javascript.
991 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
992 * src/main/java/org/glom/web/client/activity/ListActivity.java
993 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
994 * src/main/java/org/glom/web/client/place/DetailsPlace.java
995 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
996 * src/main/java/org/glom/web/client/place/ListPlace.java
997 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
998 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
999 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1000 * src/main/java/org/glom/web/client/ui/details/Group.java
1001 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1002 our StringUtils.isEmpty() function.
1004 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1006 Update to the latest java-libglom API.
1008 * pom.xml: Require java-libglom 1.21.4.
1009 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1010 getDocumentInfo(), getListViewLayoutGroup():
1011 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1013 * src/main/java/org/glom/web/server/database/DBAccess.java
1014 getFieldsToShowForSQLQueryAddGroup(),
1015 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1016 with either get_database_title_original() or
1017 get_database_title(localeID).
1019 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1021 ConfiguredDocument: Avoid a null pointer exception.
1023 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1024 Initialize localeID to "" to avoid returning a null String which
1025 causes a crash in java-libglom's swing-generated code.
1027 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1029 Some simple renaming.
1031 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1032 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1033 for localeChooser. This seems more appropriate and is less ambiguous
1034 particularly in the .css file.
1036 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1038 ConfiguredDocument: Rename the localedID private member variable.
1040 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1042 Adapt to the latest java-libglom API from git master.
1044 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1045 libglom now uses only Vector instead of List, which uses add() instead of
1048 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1050 ConfiguredDocument: Rename the localedID private member variable.
1052 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1054 Build a source tarball with mvn assembly:single
1056 * assembly.xml: Add this file.
1057 * pom.xml: Use the maven-assembly-plugin and tell it to use
1058 our assembly.xml file.
1060 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1062 OnlineGlomServiceImpl: Get .glom files recursively.
1064 * pom.xml: Depend on commons-io from org.apache.commons.
1065 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1066 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1067 files recursively, and with the easier filter for the extension.
1068 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1069 simplify that code too.
1071 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1073 README: Mention that you must install java-libglom packages separately.
1075 But then it works, because java-libglom is now in the central maven
1078 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1080 locales drop-down: Show the correct selected locale when the URL changes.
1082 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1083 .java: setPlace(): Move some code into fillView().
1085 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1087 locales drop-down: Do not lose the primary key.
1089 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1090 start(): onLocaleChange(): Pass the current primary key value,
1091 instead of an empty value.
1093 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1095 locales drop-down: Do not lose the drop-down selection.
1097 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1098 .java (TableSelectionActivity.fillView): Set the selected locale
1099 after changing the drop-down items (though we do not really need
1100 to change them just because the locale changes.)
1102 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1104 locales drop-down: Change the tables list when this changes.
1106 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1107 .java: TableSelectionActivity.start(): Move the async table titles
1108 retrieval into a private fillView() method and also call this when
1109 the chosen locale changes.
1110 Note that the document title is not actually translatable yet, but
1111 that is a problem that I should fix soon in libglom.
1113 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1115 Improve the placement of the locales drop-down.
1117 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1118 Put the title and locales drop-down in a div (gwt.FlowTable).
1119 * src/main/webapp/style.css: Add magic css properties to make this work.
1120 Also remove the left margin from the title so that it lines up with the
1123 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1125 locales selector: Show human-readable locale titles.
1127 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1128 getDocumentInfo(): Use java.util.Locale to show a real title of
1129 each locale, in the locale's own language.
1131 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1133 Add a language/locale selector drop-down.
1135 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1136 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1137 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1138 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1139 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1140 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1141 Add a ListBox to show the available locales. Add getLocaleSelector(),
1142 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1143 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1144 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1145 java: Add these classes.
1146 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1147 start(): Fill the locales ListBox. Handle its change event, firing a
1149 setPlace(): Show the selected locale as specified by the URL token.
1150 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1151 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1152 Handle LocaleChangeEvent, going to a new *Place with that locale.
1154 The placement of the ListBox is not pretty, and it currently uses the ID
1155 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1159 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1161 Search box: Show the search text from the URL token.
1163 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1164 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1165 Add setQuickFindText().
1166 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1167 .java: setPlace(): Store the queryText if the place is a ListPlace,
1168 and call TableSelectionView.setQuickFindText().
1170 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1172 Allow use of translations via, for instance, &lang=de in the URL.
1174 * pom.xml: Use the unstable java-libglom 1.21 version.
1176 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1177 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1179 init(): Instead of calling TranslatableItem.set_current_locale()
1180 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1181 However, this is only for default locales, which are not needed to
1182 change the locale in the URL.
1183 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1184 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1185 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1186 layout for a particular locale.
1187 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1188 Add get/setDefaultLocaleID().
1189 getDocumentInfo(), getListViewData(), getRelatedListData(),
1190 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1191 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1192 localeID parameter, so we can get the layout for a particular locale.
1194 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1195 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1196 * src/main/java/org/glom/web/client/place/ListPlace.java:
1197 Parse and construct a lang parameter too.
1199 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1200 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1201 passed to subsequent methods and constructors.
1202 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1203 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1204 Store the localeID from the *Place and pass it to other constructors
1205 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1207 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1208 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1209 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1210 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1211 * src/main/java/org/glom/web/client/ui/ListView.java:
1212 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1213 Take localeID parameters and pass them to subsequent constructors and
1214 methods, so that the layout is always retrieved for that locale.
1216 This is rather repetitive.
1218 Note that "" means the original (default) locale of the Glom document,
1219 which is usually English.
1221 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1223 Documents: Remove final keyword to fix startup configuration.
1225 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1226 final keywords on the private member variables because that breaks
1227 the startup, apparently (there are warnings) because it stops them
1228 from being serialized. I added these in the previous commit.
1230 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1232 Documents: Add some final keywords.
1234 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1237 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1239 OnlineGlomServiceImpl: Add to overview comments.
1241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1242 Note that this is where all the document are loaded. They are not
1243 loaded freshly for each page.
1245 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1249 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1250 Add a TextBox for the text of a quick find.
1251 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1253 setBackLink(): Add a String quickFind parameter.
1254 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1255 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1256 to the base interface, because that is how TableSelectionViewImpl is used.
1257 * src/main/webapp/style.css: Add style for the search box and its label.
1259 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1260 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1261 Add these files, based on the existing TableChangeEvent and
1262 TableChangeEventHandlers.
1263 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1264 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1265 a ListPlace() that the user should be taken to.
1266 * src/main/java/org/glom/web/client/activity/ListActivity.java
1267 start(): Handle it here too and adapt the TableChangeEvent handler to
1268 pass the extra "" quickFind parameter to ListPlace.
1269 * src/main/java/org/glom/web/client/place/ListPlace.java:
1270 Constructor: Take an extra String quickFind parameter and store it,
1271 returning it from a new getQuickFind() method.
1272 getToken(): Put the quickFind text in the URL token.
1273 getPlace(): Parse the quickFind text from the URL token.
1274 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1275 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1276 ListPlace constructor.
1277 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1278 .java: start(): Add a Change handler for the TableSelectionView's
1279 TextBox (via its base HasChangeHandlers interface), firing the new
1280 QuickFindChangeEvent.
1281 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1282 pass the extra "" quickFind parameter.
1284 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1285 setCellTable(): Add a String quickFind parameter and pass it to
1286 the ListViewTable() constructor.
1287 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1288 setCellTable() in the base interface, because that is how ListViewImpl
1291 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1292 Add a String quickFind member variable.
1293 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1294 Constructor: Add a String quickFind parameter, storing it in the
1295 base ListTable's member variable.
1296 onRangeChanged(): Pass quickFind to the
1297 OnlineGlomServiceAsync.getSortedListViewData() and
1298 OnlineGlomServiceAsync.getListViewData() methods.
1300 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1301 getListViewData(), getSortedListViewData(): Add a String quickFind
1302 parameter, passing it to ConfiguredDocument.getListViewData().
1303 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1304 Change getListViewData(), getSortedListViewData() in the base interface,
1305 because that is how OnlineGlomServiceImpl is used, via this:
1306 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1307 Change getListViewData(), getSortedListViewData() here too.
1308 This class can apparently be used to asynchronously call methods on
1309 OnlineGlomService, and GWT seems to implement that after recognizing
1310 just the *Async name convention and the extra AsyncCallback parameters.
1312 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1313 getListViewData(): Add a String quickFind parameter, and pass it to
1314 ListViewDBAccess.getData().
1315 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1316 getListData(): Add a String quickFind parameter and pass it to
1318 getSelectQuery(): Add a String quickFind parameter.
1319 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1320 getSelectQuery(): Add a String quickFind parameter and use it with
1321 Glom.get_find_where_clause_quick() to pass a where_clause to
1322 Glom.build_sql_select_with_where_clause(), to actually filter the
1324 getData(): Add a String quickFind parameter, passing it to getListData().
1325 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1326 va: getData(): Pass an empty string to getListData() for the
1327 quickFind parameter.
1329 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1331 ListTable: Minor change.
1333 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1334 createCellTable(): Make this protected instead of public.
1336 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1338 Many files: Use final for the parameters and use the @override attribute.
1340 2012-01-22 Ben Konrath <ben@bagu.org>
1342 Add anchor links for single line text that starts with http, ftp and www.
1346 2012-01-22 Ben Konrath <ben@bagu.org>
1348 Add ellipsis to single line text in details view.
1352 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1354 Remove all javadoc author tags.
1356 Because they are awkward and meaningless when many people touch
1358 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1360 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1362 Revert the COPYING.LESSER to COPYING rename.
1364 Apparently both should be there if it is LGPL.
1366 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1368 *View: Remove unused imports.
1370 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1371 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1372 * src/main/java/org/glom/web/client/ui/ListView.java:
1373 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1374 Remove unused imports, as suggested by Eclipse.
1376 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1378 Move the *View::Presenter types, and some API into one base View.
1380 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1381 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1382 * src/main/java/org/glom/web/client/ui/ListView.java:
1383 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1384 Presenter, setPresenter() and clear() into a shared base interface,
1385 to avoid the unnecessary duplicate Presenter types and to more clearly
1386 show how the *Views share the same structure, even if they are not
1387 used polymorphically.
1389 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1390 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1393 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1394 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1396 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1399 Feel free to revert this if there is a good reason for the duplicate
1402 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1404 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1406 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1407 a class member instead of a local variable in the method.
1408 This lets us use it to get the view instances, for use in tests.
1409 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1410 beforeOnlineGlom(): Test some more details of the initial view.
1411 Again, this is not very useful.
1413 To really test gwt-glom we will need to start a local postgresql
1414 instance with local data, like the Glom tests in C++.
1416 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1418 pom.xml: Mention the LGPL license.
1420 * pom.xml: Add a licenses section.
1421 * COPYING.LESSER: Move this to COPYING, which
1422 previously contained the GPL. But gwt-glom is all LGPL.
1424 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1426 Add project information to README and pom.xml.
1428 * README: Add a brief description and mention some mvn
1430 * pom.xml: This extra information shows up in mvn site
1433 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1435 Use the latest java-libglom version.
1437 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1439 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1441 GwtTestOnlineGlom: Test a little more.
1443 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1444 protected rather than private, as suggested by the gwt-test-utils
1446 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1447 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1448 Test the initial visibility of the panels.
1450 However, this is not a very useful test.
1451 And I wonder how we should generally test using this idea for an
1452 activity/places app like ours where the real changes happen implicitly
1453 based on the history token/URL.
1455 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1457 Slight modification to *Mapper comments.
1459 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1460 (DataActivityMapper)
1461 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1463 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1465 Remove comments mentioning GIN because they are just copied from
1466 the example code and are apparently not helpful:
1467 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1468 Also change the mention of a class that is only in the example code.
1470 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1472 GwtTestOnlineGlom test: Minor changes.
1474 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1475 Avoid the long qualified class name and modify the comment
1476 because it is now obvious to me that the mocked class is the only
1477 custom one created via GWT.create().
1479 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1481 Tests: Added the beginnings of a test using gwt-test-utils.
1483 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1484 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1485 which tells gwt-test-utils what class will be tested.
1486 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1487 Add a simple (but empty) test case. One class, used by the OnlineGlom
1488 class, is mocked so that it can be created. However, I am not sure
1489 why only this class needs to be mocked.
1491 Note that mockito seems more popular, and clearer, than easymock,
1492 but I have not got that working yet. It might be a matter of the
1495 This test is run during mvn integration-test.
1497 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1499 Tests: Use junit4-style syntax instead of junit3-style.
1501 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1502 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1503 * src/test/java/org/glom/web/shared/DataItemTest.java:
1504 Use the @Test annotation rather than relying on the test*() prefix.
1505 Also no longer implement TestCase, to avoid triggering support for
1506 the junit3-way, which stops the annotations from working.
1507 Change the imports from import junit.framework.* to
1508 import org.junit.*, which is apparently the new way.
1510 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1512 Added a test for ListPlace token parsing and creation.
1514 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1515 This is much the same as DetailsPlaceTest.
1517 I wonder how we could test the other parts of the *Place API.
1519 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1521 DetailsPlace test: Also test getToken() and recreation via getPlace().
1523 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1524 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1525 recreate it, testing the recreated DetailsPlace for the same parameter
1528 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1530 Use the surefire-report plugin.
1532 * pom.xml: This generates a HTML report about the tests in
1533 target/site/surefire-report.html
1534 when you do mvn surefire-report:report. It seems to be popular/normal.
1536 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1538 Added a test for DetailsPlace.
1540 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1541 Test the getPlace() token parsing.
1543 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1545 Added a first unit test.
1547 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1548 * src/test/java/org/glom/web/shared/DataItemTest.java:
1549 This is a silly test but it is just to get things started. Note that
1550 maven/junit finds the test because it looks in src/test by default.
1552 2011-12-22 Ben Konrath <ben@bagu.org>
1554 Change charsetName to "UTF-8" when replacing line breaks.
1556 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1557 that work in Java (such as "UTF8") will not work when compiled to
1560 This fixes a problem with multi-line details view fields that have hard
1561 line breaks. The "License Text" field on this page demonstrates the
1564 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1566 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1568 2011-12-22 Ben Konrath <ben@bagu.org>
1570 Fix another bug with related list navigation.
1572 I've tested all the navigation buttons in all of the related lists
1573 so things should be good now.
1575 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1577 2011-12-22 Ben Konrath <ben@bagu.org>
1579 Fix a crasher when refreshing the list view with the default table.
1581 This crash will also happen when loading the list view with the default
1582 table from a link or bookmark.
1584 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1585 to the main document selection page when the document id hasn't been
1587 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1588 the main document selection page when the document id hasn't been
1590 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1591 values for the details place when the document id hasn't been set.
1592 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1593 values for the list place when the document id hasn't been set.
1595 2011-12-21 Ben Konrath <ben@bagu.org>
1597 Protect against NPE when glom.document.locale is not in config.
1599 This patch protects against an NPE when glom.document.locale is not in
1600 the config file. This NPE will also happen if glom.document.locale is
1603 The patch also updates the error message to display the class name when
1604 the getMessage() returns null. This was happening when the NPE was
1605 thrown and I had "Configuration Error: null". If an NPE is encountered
1606 with this patch, "Configuration Error: NullPointerException " will be
1609 This commit closes this bug:
1611 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1613 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1615 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1617 Rename onlineglom.properties to onlineglom.properties.sample.
1619 * src/main/resources/onlineglom.properties: Rename to:
1620 * src/main/resources/onlineglom.properties.sample:
1621 * src/main/resources/README: And add this file explaining that people
1622 should rename it back when deploying.
1624 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1626 Allow choosing the translation in the .properties file.
1628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1629 init(): Read a glom.document.locale value from the configuration file
1630 and call Glom's TransatableItem::set_current_locale() method.
1631 * src/main/resources/onlineglom.properties: Add a commented-out
1632 example of this new setting.
1634 It would be better to add &lang=de_DE to the URL, but the current
1635 libglom API does not allow us to do this easily. I am working on that.
1637 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1639 Avoid a crash in parsing of token parameters.
1641 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1642 ava: getTokenParams(): Do not crash if a parameter has a key but no
1643 value, and ignore parameters with neither.
1645 2011-12-17 Murray Cumming <murrayc@murayc.com>
1647 History token building/handling: Improve use of token parameters.
1649 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1650 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1651 and buildParamsToken(HashMap), for use by derived classes.
1652 Make the separator private because it is no longer be needed.
1653 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1654 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1655 instead of manual string concatenation.
1656 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1657 of hardcoded indices and awkward splitting code.
1658 * src/main/java/org/glom/web/client/place/ListPlace.java
1659 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1660 instead of manual string concatenation.
1661 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1662 of hardcoded indices and awkward splitting code.
1663 This should fix bug #666420
1665 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1667 Fix a Navgiation->Navigation typo in the code.
1669 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1670 Rename processNavgiation() to processNavigation().
1672 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1674 Fix a seperator->separator typo in the code.
1676 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1677 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1678 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1681 2011-12-15 Ben Konrath <ben@bagu.org>
1683 Cleanup some comments.
1685 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1687 2011-12-14 Ben Konrath <ben@bagu.org>
1689 Replace \n with <br/> for multiline text in the details view.
1691 Vertical scrollbars are added when needed as well.
1693 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1695 2011-12-14 Ben Konrath <ben@bagu.org>
1697 Specify the font for document selection links.
1699 * src/main/webapp/style.css:
1701 2011-12-14 Ben Konrath <ben@bagu.org>
1703 Fix bouncy CellTable while paging.
1705 This doesn't currently work with related list tables in unselected
1708 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1710 2011-12-14 Ben Konrath <ben@bagu.org>
1712 Revamp the appearance of the document selection page.
1714 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1715 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1716 * src/main/webapp/style.css:
1718 2011-12-13 Ben Konrath <ben@bagu.org>
1720 Set navigation button column to the smallest size possible.
1722 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1724 2011-12-13 Ben Konrath <ben@bagu.org>
1726 Change OpenButton nomenclature to NavigationButton.
1728 Using NavigtionButton makes things more generic. Classes, methods and
1729 variables have been changed.
1731 This is a rename-only refactor.
1733 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1734 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1735 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1736 Renamed from OpenButtonCell.
1737 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1738 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1739 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1741 2011-12-12 Ben Konrath <ben@bagu.org>
1743 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1745 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1746 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1747 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1748 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1750 2011-12-12 Ben Konrath <ben@bagu.org>
1752 Update variable names and comments.
1754 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1755 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1757 2011-12-12 Ben Konrath <ben@bagu.org>
1759 Properly initialize numNonEmptyRows variable to zero.
1761 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1762 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1764 2011-12-05 Ben Konrath <ben@bagu.org>
1766 Add latest mockup with HTML tables.
1768 Features of this mockup:
1770 -> HTML table for flowtable
1771 -> HTML table for flowtable column
1772 -> Example of how related lists would look
1773 -> Not using text entries for data items
1775 The current version of Online Glom doesn't use HTML tables for the
1778 This mockup has been sent to the glom-devel mailing list but it's good
1779 to have it here as well.
1781 * mockups/details-view-html-tables.html:
1783 2011-12-05 Ben Konrath <ben@bagu.org>
1785 Remove unnecessary getPrimaryKeyField() method.
1787 getPrimaryKeyFieldForTable(String) has been renamed to
1788 getPrimaryKeyField(String).
1790 * src/main/java/org/glom/web/server/database/DBAccess.java:
1791 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1792 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1794 2011-12-05 Ben Konrath <ben@bagu.org>
1796 Add string representation of TypedDataItem value to conversion error message.
1798 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1799 message was extracted into its own method to avoid duplication.
1801 2011-12-05 Ben Konrath <ben@bagu.org>
1803 Add type checking to navigation primary key value creation.
1805 Create navigation primary key only if the expected type from the Glom
1806 document matches the type returned by the SQL query.
1808 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1810 2011-12-05 Ben Konrath <ben@bagu.org>
1812 Rename a couple of variables in RelatedListNavigation.
1814 This is a rename-only refactor.
1816 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1818 2011-12-05 Ben Konrath <ben@bagu.org>
1820 Move getListLayoutGroup() into getListViewLayoutGroup().
1822 This removes getListLayoutGroup(). It was only being called by
1823 getListViewLayoutGroup().
1825 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1827 2011-12-05 Ben Konrath <ben@bagu.org>
1829 Remove check for LayoutItem_Portal in list table method.
1831 This check is no longer necessary because the method isn't being used
1832 to create the LayoutItemPortal DTO.
1834 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1836 2011-12-05 Ben Konrath <ben@bagu.org>
1838 Properly support related list navigation.
1840 Navigation from the "Repository Analyzer -> Package Scans ->
1841 Dependencies" related table wasn't working because the primary key for
1842 related tables wasn't being set properly. This commit fixes the
1845 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1846 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1847 doesn't set the primary key properly for related list tables.
1848 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1849 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1850 useful for getting the primary key for list view tables and for related
1852 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1853 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1854 Move code to set the primary key for the table from the abstract
1855 ListDBAccess class to ListViewDBAccess as it's only correct for list
1857 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1858 Properly add primary key to related list tables.
1860 2011-12-02 Ben Konrath <ben@bagu.org>
1862 Properly set the horizontal alignment of fields.
1864 This fix is for both the list tables and the details view.
1866 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1867 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1868 to set the horizontal alignment of fields.
1870 2011-12-02 Ben Konrath <ben@bagu.org>
1872 Display currency codes in the details view.
1874 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1876 2011-12-02 Ben Konrath <ben@bagu.org>
1878 Avoid duplicate JNI call.
1880 JNI is not as efficient as pure Java and this is an easy (and small)
1883 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1884 Use previously retrieved value for whereClauseToTableName instead of
1887 2011-12-02 Ben Konrath <ben@bagu.org>
1889 Rename a couple of variables in RelatedListNavigation.
1891 This is a rename-only refactor.
1893 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1895 2011-12-02 Ben Konrath <ben@bagu.org>
1897 Indicate clearly that a mismatched primary key type is a bug.
1899 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1900 warning to error. Add 'This is a bug.' to message.
1902 2011-12-02 Ben Konrath <ben@bagu.org>
1904 Update / fix some comments.
1906 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1908 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1910 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1911 Fix comments. Add some TODOs.
1913 2011-12-02 Ben Konrath <ben@bagu.org>
1915 Enable navigation to details view with string primary key from related list.
1917 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1918 Create a text primary key value when return type of result is
1919 java.sql.Types.VARCHAR.
1921 2011-12-02 Ben Konrath <ben@bagu.org>
1923 Use checkboxes for booleans in the details view.
1925 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1927 2011-12-01 Ben Konrath <ben@bagu.org>
1929 Improve performance of related list height calculation.
1931 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1932 Put code to calculate the expected height in a static initializer so
1933 that that it's only called once.
1935 2011-12-01 Ben Konrath <ben@bagu.org>
1937 Show related list tables in notebooks (again).
1939 Calculate the height of the related list tables so the Notebook can be
1940 set the correct height. The height of the related list table is also needed by
1941 FlowTable to be able decide how to create the layout.
1943 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1944 and set the Portal height based on the height of the related list
1945 table and the Portal container.
1946 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1947 Add method to calculate the height of the related list tables.
1948 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1949 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1950 calculate the height of the Pager widget.
1952 2011-12-01 Ben Konrath <ben@bagu.org>
1954 Use CellTable API for table property instead of setting style on Element.
1956 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1958 2011-12-01 Ben Konrath <ben@bagu.org>
1960 Make ListViewTable and RelatedListTable a consistent height.
1962 The tables are now a consistent height regardless of the contents of
1963 the table. A hidden button is added to empty rows to ensure that the
1964 height of these rows will match the height of rows with data.
1966 A navigation button column is now added to every table. The width of
1967 the navigation column is set to 0px when a RelatedListTable shouldn't
1968 have navigation buttons. This maintains the a consistent row height in
1969 tables that don't show the navigation buttons.
1971 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1972 navigation column when not needed.
1973 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1974 arguments for navigation button to constructor of ListViewTable.
1975 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1976 hidden button for empty data rows.
1977 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1978 arguments for navigation button to constructor.
1979 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1980 create navigation buttons. Add hideNavigationButtons() method.
1981 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1982 arguments for navigation button to constructor.
1984 2011-12-01 Ben Konrath <ben@bagu.org>
1986 Use 'visibility: hidden' in Utils.getWidgetHeight().
1988 This is better choice because hidden elements are invisible, don't
1989 respond to events and are not part of the tab order. They will,
1990 however, take up space which is required to be able to calculate the
1991 height of the widget.
1993 * src/main/java/org/glom/web/client/Utils.java:
1995 2011-12-01 Ben Konrath <ben@bagu.org>
1997 Use Utils.getWidgetHeight() in FlowTable.
1999 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2001 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2003 2011-12-01 Ben Konrath <ben@bagu.org>
2005 Put the details css class name on the correct table column.
2007 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2009 2011-11-30 Ben Konrath <ben@bagu.org>
2011 Update for java-libglom API change.
2013 The getters and setters on FieldFormatting and NumericFormat were
2014 changed to remove the 'M'.
2016 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2018 2011-11-29 Ben Konrath <ben@bagu.org>
2020 Only allow RelatedListTables in Portals.
2022 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2024 2011-11-29 Ben Konrath <ben@bagu.org>
2026 Only create a contents panel for Portals when title is being set.
2028 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2030 2011-11-29 Ben Konrath <ben@bagu.org>
2032 Set TabLayoutPanel height based on calculated height its widgets.
2034 This is a potential fix for this bug:
2036 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2038 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2040 2011-11-29 Ben Konrath <ben@bagu.org>
2042 Align details field labels and data with the Open buttons.
2044 * src/main/webapp/style.css:
2046 2011-11-29 Ben Konrath <ben@bagu.org>
2048 Remove unnecessary <div> in the Notebook widget.
2050 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2051 method to get container FlowPanel (<div>).
2052 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2053 initWidget() method directly on the TabLayoutPanel widget instead of
2054 Group's container widget.
2056 2011-11-29 Ben Konrath <ben@bagu.org>
2058 Don't add group titles for Portals in Notebooks.
2060 This reverts the previous patch and fixes a bug I introduced with
2061 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2063 * src/main/java/org/glom/web/client/ui/details/Group.java:
2064 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2066 2011-11-28 Ben Konrath <ben@bagu.org>
2068 Remove unused boolean argument in Portal constructor.
2070 Just a code cleanup.
2072 * src/main/java/org/glom/web/client/ui/details/Group.java:
2073 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2075 2011-11-28 Ben Konrath <ben@bagu.org>
2077 Remove hack for glom 1.18 style glom files.
2079 * src/main/java/org/glom/web/client/ui/details/Group.java:
2080 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2081 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2083 2011-11-28 Ben Konrath <ben@bagu.org>
2085 Use Gda Value version of primary key to log result too large error.
2087 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2089 2011-11-28 Ben Konrath <ben@bagu.org>
2091 Don't use TypedDataItem.getText() for Unknown types from the URL.
2093 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2094 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2095 instead of getText().
2096 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2097 String field and getUnknown() method.
2099 2011-11-28 Ben Konrath <ben@bagu.org>
2101 Log an error message when the java-libglom .so is not present.
2103 The error message was being set in the exception but not logged.
2105 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2107 2011-11-28 Ben Konrath <ben@bagu.org>
2109 Ignore LayoutItem_CalendarPortals.
2111 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2112 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2114 2011-11-28 Ben Konrath <ben@bagu.org>
2116 Extract method for creating the LayoutItemPortal DTO.
2118 Just breaking the code up into smaller chunks.
2120 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2122 2011-11-28 Ben Konrath <ben@bagu.org>
2126 This should have been added with the refactor. Oops!
2128 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2130 2011-11-28 Ben Konrath <ben@bagu.org>
2132 Create primary key value from URL string using type from Glom document.
2134 See this bug, comments 19 - 25:
2136 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2138 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2139 create a TypeDataItem for the primary key here when loading from a
2140 URL. Show the same string for the primary key value as was received
2141 from the URL string (when loading from a URL).
2142 * src/main/java/org/glom/web/server/Utils.java: Update method for
2143 creating the Gda Value from the TypeDataItem to properly deal with
2144 creating a Gda Value based on the Glom document type for the primary
2145 key value string when loading from a URL.
2146 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2147 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2148 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2149 Update for changed method name.
2151 2011-11-27 Ben Konrath <ben@bagu.org>
2153 Rename PrimaryKeyItem to TypedDataItem.
2155 The name PrimaryKeyItem suggests what the class should be used for.
2156 TypedDataItem is a neutral name that describes the class better.
2158 This is a rename-only refactor.
2160 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2161 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2162 * src/main/java/org/glom/web/client/Utils.java:
2163 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2164 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2165 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2166 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2167 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2168 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2170 * src/main/java/org/glom/web/server/Utils.java:
2171 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2172 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2173 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2174 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2176 2011-11-25 Ben Konrath <ben@bagu.org>
2178 Improve Gda Value conversion from PrimaryKeyItem.
2180 The value from the PrimaryKeyItem is only used if its type match the
2181 type from the glom document.
2183 * src/main/java/org/glom/web/server/Utils.java:
2185 2011-11-25 Ben Konrath <ben@bagu.org>
2187 Manually check if the java-liblgom .so is visible to the JVM.
2189 It seems that Tomcat has problems when a static initializer throws an
2190 exception. This check is done before the first method call into
2191 java-libglom so that execution doesn't continue if the .so is not
2194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2196 2011-11-25 Ben Konrath <ben@bagu.org>
2198 Improve browser configuration error messages.
2202 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2204 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2205 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2206 getConfigurationErrorMessage() method.
2207 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2208 Get and display a specific configuration error message when no Glom
2209 documents are found.
2210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2211 Implement getConfigurationErrorMessage() method. Surround configuration
2212 code in the init() method with a try/catch block. This allows the
2213 errors to be caught while keeping the servlet available to retrieve the
2214 configuration error message.
2216 2011-11-25 Ben Konrath <ben@bagu.org>
2218 Don't use Strings to hold primary key values.
2220 The primary key values are now held in a new data object
2221 (PrimaryKeyItem) that holds type information and the primary key value
2222 using the correct type.
2224 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2225 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2227 PrimaryKeyItem instead of String to hold the primary key value.
2228 * src/main/java/org/glom/web/client/Utils.java: Remove
2229 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2230 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2231 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2232 PrimaryKeyItem instead of String to hold the primary key value. Load
2233 document selection page when the documentID has not been set correctly.
2234 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2235 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2237 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2238 Return empty string for URL instead of "null".
2239 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2240 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2241 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2242 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2243 PrimaryKeyItem instead of String to hold primary key values.
2244 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2245 PrimaryKeyValue to a Gda Value.
2246 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2247 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2248 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2249 Replace temporary database access code that uses the PrimaryKeyValue to
2250 Gda Value conversion.
2251 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2252 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2253 PrimaryKeyItem instead of String.
2254 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2255 hold primary key values.
2257 2011-11-24 Ben Konrath <ben@bagu.org>
2259 Use newly added java-libglom API to create queries.
2261 This isn't finished. I still need to stop using Strings for primary key
2262 values in the client code.
2264 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2265 libglom to use fake connections so that retrieving the query string will
2267 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2268 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2269 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2270 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2271 Use the newly added libglom sql methods and classes to create the
2272 query. Add temporary hack to convert primary value strings to Gda
2275 2011-11-23 Ben Konrath <ben@bagu.org>
2277 Don't explicitly set the height of Portals.
2279 See comments 6 - 10 of this bug for details:
2281 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2283 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2285 2011-11-23 Ben Konrath <ben@bagu.org>
2287 Use an HTML table instead of CSS for the FlowTable layout.
2289 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2290 GWT's FlexTable to implement the FlowTable.
2291 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2293 2011-11-18 Ben Konrath <ben@bagu.org>
2295 Add boolean example to HTML table mockup.
2297 * mockups/details-view-html-tables-text-entries.html:
2299 2011-11-17 Ben Konrath <ben@bagu.org>
2301 Ensure the pager buttons are always visible for related lists.
2303 To accomplish this, I've turned off text wrapping in the list view and
2304 related list tables for both the header and data text. The related list
2305 table now has a fixed layout so the it doesn't overflow its container.
2306 This is required to ensure that the cell text is clipped when it
2307 overflows the cell and an ellipsis is added to the right side of the
2308 cell when text is clipped.
2310 A fixed table layout for the related list table in the details view
2311 seems what we want for the details view anyway, so the side-effect is
2314 The ellipsis will only be displayed in Firefox >= 7.
2318 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2320 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2321 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2322 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2324 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2325 Set the 'table-layout: fixed' CSS property to the related list table.
2326 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2327 'white-space: nowrap;' CSS property on both the list view and the
2328 related list tables.
2330 2011-11-16 Ben Konrath <ben@bagu.org>
2332 Rework the fix for empty notebook tab labels.
2334 Setting the empty group titles with its name caused problems for the
2335 details layout. Instead of using libglom's
2336 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2337 to the client when the title is empty. This allows the Notebook to use
2338 the name when the title is empty without affecting anything else.
2340 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2341 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2343 2011-11-16 Ben Konrath <ben@bagu.org>
2345 Set group titles with name when title is empty.
2347 This fixes a problem with an empty notebook tab label in the Lesson
2348 Planner document. The forth tab in the notebook should be "Internet":
2350 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2352 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2353 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2356 2011-11-16 Ben Konrath <ben@bagu.org>
2358 Remove whitespace from the configured username properties.
2360 This assumes that usernames won't have whitespace at the beginning
2361 or end. But I think this is a reasonable assumption.
2363 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2364 String.trim() to remove the whitespace from the username properties.
2366 2011-11-15 Ben Konrath <ben@bagu.org>
2368 Add details view mockup with HTML tables and text entries.
2370 This is from the attachment on this bug:
2372 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2374 * mockups/details-view-html-tables-text-entries.html:
2376 2011-11-15 Ben Konrath <ben@bagu.org>
2378 Add space between the columns of the flow table.
2382 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2384 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2385 space between columns in the flow table.
2387 2011-11-15 Ben Konrath <ben@bagu.org>
2389 Add backup files to the .gitignore.
2391 * .gitignore: Ignore files that end with ~.
2393 2011-11-09 Ben Konrath <ben@bagu.org>
2395 Use latest release of gwt-log.
2397 Gwt-log releases are now being submitted to the maven central
2398 repository so manual installation of the jar is no longer required.
2400 * pom.xml: Update version and groupId of gwt-log dependency.
2402 2011-10-31 Ben Konrath <ben@bagu.org>
2404 Don't use GWT numeric formatting to override the glom currency formatting.
2406 Currencies are now displayed like they are in Glom. See this bug:
2408 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2410 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2412 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2413 currency code to constructor and set it when the cell is rendered.
2414 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2415 currency code to the constructor of the NumericCell.
2417 2011-10-27 Ben Konrath <ben@bagu.org>
2419 Require the latest release of java-libglom (1.17.4).
2423 2011-10-26 Ben Konrath <ben@bagu.org>
2425 Add style to Notebook that matches current theme.
2427 It's not the best style in the world but it's better than the default.
2429 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2430 padding at the bottom of the child widgets.
2431 * src/main/webapp/style.css: Add style for the Notebook.
2433 2011-10-26 Ben Konrath <ben@bagu.org>
2435 Move servlet initialization code to overridden init method.
2437 This is half of the solution to getting proper error messages
2438 displayed when configuration errors occur. Here's the relevant bug:
2440 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2442 The rest of the solution involves surrounding the init method with a
2443 try/catch block and setting a global variable with the error /
2444 exception. A new async method should be created to retrieve and display
2445 the error message / exception.
2447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2448 code from constructor to init method adding exceptions as needed.
2450 2011-10-26 Ben Konrath <ben@bagu.org>
2452 Add script to monitor and restart tomcat if required.
2454 * utils/check-and-recover-tomcat.py: New file.
2456 2011-10-26 Ben Konrath <ben@bagu.org>
2458 Display the correct number of data items in the pager.
2462 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2464 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2465 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2466 The implementation is the same for both tables: Keep track of the
2467 number of non-empty rows and fire and RowCountChangeEvent after the data has
2469 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2470 custom Pager class that subclasses SimplePager to handle displaying
2471 the correct number when empty rows have been added.
2473 2011-10-26 Ben Konrath <ben@bagu.org>
2475 Correct error in previous commit.
2477 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2478 eventBus parameter from listView.setCellTable().
2480 2011-10-26 Ben Konrath <ben@bagu.org>
2482 Fix error in TODO comment.
2484 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2486 2011-10-24 Ben Konrath <ben@bagu.org>
2488 Create Notebook widgets to the details view.
2490 This isn't finished just yet - I still need to create a reasonable
2491 style to match the current theme.
2493 * src/main/java/org/glom/web/client/Utils.java: Add method for
2494 calculating the height of a widget. This is used in the Notebook class.
2495 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2496 new constructor method in Group.
2497 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2498 method for creating child widget that can be used by subclasses
2499 like Notebook. New constructor that allows disabling the group
2500 titles - Notebooks don't set a group title for their child groups.
2501 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2502 to make Notebooks using GWT's TabLayoutPanel.
2503 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2504 constructor that allows disabling the group titles.
2505 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2506 LayoutItemNotebook DTO.
2507 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2508 DTO for Notebooks. It's just an empty class for now but we might need
2509 it to transfer some specific information in the future.
2511 2011-10-21 Ben Konrath <ben@bagu.org>
2513 Add navigation buttons to related list tables.
2515 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2516 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2518 method getSuitableRecordToViewDetails() for getting the table name
2519 and primary key value for related list navigation buttons.
2520 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2521 private cell renderer class to get the navigation information for
2522 related list tables from the server. Extract the navigation
2523 processing code from the details cell navigation and use it for the
2524 related list navigation as well.
2525 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2526 cell renderer class for the details open buttons. This was needed
2527 because the related list navigation buttons and the list view
2528 navigation buttons need to react differently when clicked.
2529 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2530 the onEnterKeyDown() method because it's now overriden in the
2531 subclasses that are specific to the related list tables and the list
2533 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2534 the vertical size a little because the buttons add a bit of vertical
2535 space to table. This is not a perfect solution because the vertical
2536 size of with table fewer than 5 rows will be a little smaller.
2537 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2538 changes in how navigation buttons are handled.
2539 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2540 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2541 database access object.
2542 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2543 to find the portal for a given relationship name from
2544 RelatedListDBAccess. Add method to find a primary key field for a
2546 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2547 Move code to find the portal for a given relationship name to
2549 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2550 New file: database access object for getting the related list
2551 navigation information (the table name and the primary key value).
2552 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2553 DTO for transferring a table name to navigate to and a primary key
2555 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2556 boolean and getter/setter to specifies if the related list should add
2559 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2561 Use the master branch of java-libglom
2563 * pom.xml: Depend on java-libglom 1.19 instead.
2565 This is the master branch. See also the libglom-1-18 branch.
2567 2011-10-11 Ben Konrath <ben@bagu.org>
2569 Enable the open navigation button when the data has been set.
2571 This avoids having active buttons that don't do anything when the data
2574 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2576 2011-10-11 Ben Konrath <ben@bagu.org>
2578 Use IsWidget interface for FlowTableItem.
2580 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2581 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2583 2011-10-11 Ben Konrath <ben@bagu.org>
2585 Remove GWT styling from open button in details view.
2587 There are still some issues with how the details cell is arranged but
2588 this should be made to match Glom 1.20. I'm going to leave fixing this
2589 until I have Glom 1.20 up and running.
2591 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2592 style name on open button.
2593 * src/main/webapp/style.css: Move and edit details-navigation class.
2594 Re-arrange some classes to make them appear in the same order as the
2597 2011-10-07 Ben Konrath <ben@bagu.org>
2599 Update to GWT 2.4.0.
2601 * .gitignore: Ignore new cache directory.
2602 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2603 * pom.xml: Change GWT and maven plugin to 2.4.0.
2604 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2606 * src/main/java/org/glom/web/client/ClientFactory.java:
2607 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2608 * src/main/java/org/glom/web/client/OnlineGlom.java:
2609 Update source for API changes.
2610 * utils/build-onlineglom-war.sh: Remove cache directory before the
2613 2011-10-07 Ben Konrath <ben@bagu.org>
2615 Add navigation buttons in the details view.
2617 This isn't finished but I thought I'd commit what I have as it's a
2618 pretty good start. I still need to:
2620 1. Change the style so that it fits better into the current theme
2621 2. Adjust the details cell to expand as much as possible.
2623 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2624 click handlers to navigation buttons in the DetailsCells. Create a
2625 refreshData() method to get just the data from the server without the
2627 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2628 Update the tableSelector and browser title when the table name
2629 changes without using the tableSelector.
2630 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2631 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2632 getDetailsCells() to getCells(). Update variable names.
2633 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2634 method to set click handler on navigation button. Rename a few
2635 variables. Add navigation buttons where needed.
2636 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2637 variables and methods.
2638 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2639 navigation boolean and navigation table as required in the
2640 LayoutItemField DTO.
2641 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2642 variables for navigation along with getter/setter methods.
2644 2011-10-07 Ben Konrath <ben@bagu.org>
2646 Rename Field to DetailsCell.
2648 This is a refactor-only commit. No functionality has been added or
2651 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2652 Update variable and method names.
2653 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2654 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2655 variable and method names.
2656 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2658 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2659 variable and method names.
2661 2011-10-07 Ben Konrath <ben@bagu.org>
2663 Create separate methods for layout and data the details view.
2665 This is a refactor-only commit. No functionality has been added or
2668 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2669 private methods: setData(), createLayout().
2671 2011-10-07 Ben Konrath <ben@bagu.org>
2673 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2675 This is part of a change to get navigation buttons in the details view
2676 but it should have been done this way from the start.
2678 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2679 for method name change in TableSelectionView.
2680 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2681 Create TableChangeEvent and set the browser title using the
2682 TableSelectionView API.
2683 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2684 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2685 Change getSelectedTable() to getSelectedTableName(). Add
2686 getSelectedTableTitle().
2688 2011-10-07 Ben Konrath <ben@bagu.org>
2690 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2692 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2694 2011-10-07 Ben Konrath <ben@bagu.org>
2696 Update TableChangeEvent to use newTableName naming convention.
2698 This makes the class more consistent with GWT naming conventions.
2700 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2701 Update for method name change in TableChangeEvent.
2702 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2703 for method name change in TableChangeEvent.
2704 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2705 newTableName variable and getter method. Make toDebugString()
2708 2011-09-30 Ben Konrath <ben@bagu.org>
2710 Disable the pager in the list tables when the data row count is less than the minimum.
2712 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2713 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2715 2011-09-30 Ben Konrath <ben@bagu.org>
2717 Add empty rows to the end of related list and list view tables.
2719 I also extracted the cell rendering classes from the ListTable because
2720 the code was becoming a little crazy with all the anonymous inner
2721 classes. My plan is to use these cell rendering classes in the details
2722 view as well so this refactor will be needed for that change.
2724 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2725 set the row count in related list tables if the data has more rows
2726 than the minimum number of rows visible.
2727 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2728 row count in list view tables if the data has more rows than the
2729 minimum number of rows visible.
2730 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2731 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2733 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2734 for rendering TYPE_NUMERIC cells. The code was extracted from the
2736 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2737 class for rendering cells with buttons in list views. The code was
2738 extracted from the ListTable class.
2739 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2740 for rendering TYPE_TEXT cells. The code was extracted from the
2742 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2743 Add empty rows to the end of the data if required. Implement
2744 ListTable.getMinNumVisibleRows().
2745 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2746 cell renderer code to public classes. Return null in
2747 Column.getValue() for empty rows. Add new abstract method:
2748 getMinNumVisibleRows(). Move code to set the row count of the list view
2749 table to ListViewImpl.
2750 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2751 empty rows to the end of the data if required. Implement
2752 ListTable.getMinNumVisibleRows().
2755 2011-09-27 Ben Konrath <ben@bagu.org>
2757 Use GWT.log for client-side debugging statements.
2759 These are optimized out when deployed so I should have used this method
2760 in the first place. These statements will eventually be replaced with some sort
2761 of notification in the browser.
2763 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2764 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2765 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2766 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2767 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2769 2011-09-27 Ben Konrath <ben@bagu.org>
2771 Put tableselector on the right, back to list link on right.
2773 The idea is that the table selector is acting like a label for the
2774 currently displayed table so it should be placed below the document title. This
2775 puts the table title in a similar position to where it is in Glom.
2777 * mockups/details-contacts.html:
2778 * mockups/details-projects.html:
2779 * mockups/listview-contacts.html:
2780 * mockups/listview-projects.html:
2781 * mockups/style.css:
2782 Update mockups to match how the interfaces currently look.
2783 * src/main/webapp/style.css: Swap positions of backlink with the table
2784 selector. Add some space on the left side of the table selector to
2785 line things up with the document title.
2787 2011-09-27 Ben Konrath <ben@bagu.org>
2789 Add field colouring to details view.
2791 This change re-works how field colouring works. The colour formatting
2792 information is now set to the client with the layout information instead of
2793 with the data. This eliminates the need to send the same colour strings for
2794 data in list view column when colour information is set.
2796 In order to set an alternate colour for negative numeric values, the
2797 number is now sent to client and formatted with the GWT NumberFormat class.
2799 This change also fixes:
2801 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2803 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2804 internationalization framework which is needed for client side numeric
2806 * src/main/java/org/glom/web/client/Utils.java: New file for some
2807 client static utility methods.
2808 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2809 the DataItem object to the Field class. Use a utility method to
2810 create the foreignKeyValue string.
2811 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2812 alignment and text colours in the constructor. Add setData(DataItem)
2813 method. Remove setText(String) method.
2814 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2815 colour information to GlomTextCell. Create and use GlomNumberCell for
2816 rendering numbers. Use utility method to get the string for the
2817 primary key of the key provider. Re-work how the horizontal alignment
2819 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2820 formatting to layout information. Methods for converting the libglom
2821 formatting information were moved from DBAccess.
2822 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2823 numeric formatting (it's now done on the client side). Don't set text
2824 colours in DataItem. Move libglom formatting conversion methods to
2826 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2827 getters/setters for text colour information.
2828 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2829 for transferring the libglom NumericFormat information to the client.
2830 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2831 and getters/setters for: GlomNumericFormat, background colour and
2832 foreground colour strings.
2834 2011-09-26 Ben Konrath <ben@bagu.org>
2836 Simplify code that iterates through the LayoutGroup.
2838 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2840 2011-09-26 Ben Konrath <ben@bagu.org>
2842 Accept Eclipse formatting for OnlineGlomServiceAsync.
2844 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2846 2011-09-26 Ben Konrath <ben@bagu.org>
2848 Don't use the ListDBAccess classes to get the primary key layout information.
2850 This was causing a bug where the wrong index for the hidden primary key
2851 was being sent to the client.
2853 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2854 primary key while creating the LayoutGroup DTO. Create a
2855 LayoutItemField DTO for hidden primary keys. Don't use the
2856 RelatedListDBAccess because it was only used for getting the primary
2858 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2859 access modifier from public to protected for getPrimaryKeyField() and
2860 getPrimaryKeyLayoutItemField().
2861 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2862 abstract method getExpectedResultSize() because RelatedListDBAccess
2863 doesn't have enough info to implement it.
2864 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2865 Remove @Override for getExpectedResultSize().
2866 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2867 Remove method getExpectedResultSize().
2869 2011-09-23 Ben Konrath <ben@bagu.org>
2871 Log which layout (list or details) the ignored item is from.
2873 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2875 2011-09-23 Ben Konrath <ben@bagu.org>
2877 Remove annotations that turn off code formatting in DataItem.
2879 * src/main/java/org/glom/web/shared/DataItem.java:
2881 2011-09-23 Ben Konrath <ben@bagu.org>
2883 Rename GlomField to DataItem and update associated methods.
2885 This is a rename-only refactor. No functionality has been added or
2888 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2889 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2890 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2891 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2892 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2893 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2894 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2895 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2897 * src/main/java/org/glom/web/server/database/DBAccess.java:
2898 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2899 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2900 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2901 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2902 * src/main/java/org/glom/web/shared/DataItem.java:
2903 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2904 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2906 2011-09-23 Ben Konrath <ben@bagu.org>
2908 Rename GlomDocument to DocumentInfo and update associated methods.
2910 This is a rename-only refactor. No functionality has been added or
2913 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2914 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2915 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2916 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2917 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2918 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2919 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2921 2011-09-20 Ben Konrath <ben@bagu.org>
2923 Require java-libglom 1.17.3.
2925 This picks up the fix for the seg fault problem with the Scenes table
2926 in the Openismus Film Manager example.
2930 2011-09-20 Ben Konrath <ben@bagu.org>
2932 Change the way sort clause is added for primary key when no sort clause is requested.
2934 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2935 before the sort clause is created. When a sort clause is not requested, the
2936 sort clause is created by finding the primary key in the LayoutFieldVector
2939 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2941 2011-09-20 Ben Konrath <ben@bagu.org>
2943 Log error message if no documents are found in the configured directory.
2945 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2946 Extract the glom file extension string to a private static final class
2947 variable (mostly as syntactic sugar). Accept a minor formatting change.
2948 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2949 the example glom.document.directory configuration property to make it
2950 more clear that it can any directory, not just the home directory.
2952 2011-09-18 Ben Konrath <ben@bagu.org>
2954 Add related lists to details view.
2956 The related list table has support for paging and sorting just like the
2957 table in the list view.
2959 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2960 SQL queries for the related list tables.
2961 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2962 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2963 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2964 Rename getList methods to getListView and add comments. Remove
2965 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2966 it being unused. Add methods: getDetailsLayoutAndData(),
2967 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2968 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2969 Create the layout and set the data for the fields in one async call
2970 instead of two. Create related lists where appropriate.
2971 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2972 for method name changes in OnlineGlomService.
2973 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2974 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2975 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2977 * src/main/java/org/glom/web/client/ui/ListView.java:
2978 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2979 tableName from setCellTable(). Create a ListViewTable instead of
2981 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2982 represent a data field in the details view.
2983 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2984 from addDetailsCell() to Field class. Keep track of the Fields and
2985 Portals in the details view.
2986 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2987 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2988 and add a method to get it. Add method to set the contents of the
2990 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2991 New class for related list tables. This class has the data provider
2992 for the related list table.
2993 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2994 abstract class which is the base class for the ListViewTable and the
2996 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2997 New class for list view tables. This class has the data provider for
2998 the list view table.
2999 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3000 methods for related list tables. Add more information to the
3001 LayoutItemField and LayoutItemPortal DTOs.
3002 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3003 Remove debugging print statement.
3004 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3005 Remove debugging print statements. Add primary key field to SQL count
3007 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3008 Remove unnecessary LayoutFieldVector parameter from
3009 getResultSizeOfSQLQuery() method.
3010 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3011 New class for related list table database access.
3012 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3013 class that is a wrapper DTO for details view layout and data.
3014 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3015 new 'fromField' string to this DTO.
3016 * src/main/webapp/style.css: Remove bottom margin and override top
3019 2011-09-15 Ben Konrath <ben@bagu.org>
3021 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3023 This sets things up to make it easier to add the data retrieval for
3024 related lists (portals). No user noticeable changes were made with
3027 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3028 class has the code to retrieve the layouts and access the
3029 database using the new database helper classes.
3030 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3031 Most of the functionality has been removed from this class. This
3032 class now represents the public interface for the client side
3033 code. It also deals with configuring the servlet and cleaning
3034 things up when the servlet is stopped.
3035 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3036 of static methods into this utility class.
3037 * src/main/java/org/glom/web/server/database/DBAccess.java:
3038 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3039 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3040 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3041 These classes have the database retrieval code. The class hierarchy
3042 has been setup to make it easy to reuse code for similar
3045 2011-09-06 Ben Konrath <ben@bagu.org>
3047 Create separate classes for list table code and the data provider.
3049 As part of this refactor, I also split up the code a bit to make it
3052 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3053 table code to two new classes (below).
3054 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3055 with code from ListViewImpl.
3056 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3057 New file with code from ListViewImpl.
3059 2011-09-06 Ben Konrath <ben@bagu.org>
3061 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3063 This fixes the LayoutItemPortal DTO to match the libglom layout object
3066 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3068 2011-09-01 Ben Konrath <ben@bagu.org>
3070 Set title of Portals in the Details View.
3072 * pom.xml: Bump required version of java-libglom to 1.17.1.
3073 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3074 widget creation to its own class. Add comments to constructor.
3075 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3076 The code is mostly from the Group class with the title now set.
3077 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3078 title of Portal. Update some comments. Fix some code formatting.
3080 2011-09-01 Ben Konrath <ben@bagu.org>
3082 Remove TODO comment for the flow table column width.
3084 The flow table column width is working correctly and doesn't need to be
3085 changed. See this mailing list post for more info:
3087 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3089 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3091 2011-08-27 Ben Konrath <ben@bagu.org>
3093 Add document title (database name) to top of the browser page.
3095 I added the document title to the TableSelecitonView but that will
3096 change if / when we add a view that doesn't require table selection.
3098 * mockups/details-contacts.html:
3099 * mockups/details-projects.html:
3100 * mockups/listview-contacts.html:
3101 * mockups/listview-projects.html:
3102 * mockups/style.css: Add document title to mockups to keep things
3104 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3105 sizes to account for the document title.
3106 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3107 Set the document title when it has been retrieved from the server.
3108 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3109 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3110 and implement setDocumentTitle(String) method.
3111 * src/main/webapp/style.css: Add ID for document title style.
3113 2011-08-25 Ben Konrath <ben@bagu.org>
3115 Add NavigationType enum to LayoutItemPortal DTO.
3117 This is the start of adding support for Portals to the Details View.
3119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3120 LayoutItem_Portal.navigation_type enum from libglom to
3121 LayoutItemPortal.NavigationType enum.
3122 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3123 NavigationType enum, field for storing the NavigationType and getter
3126 2011-08-25 Ben Konrath <ben@bagu.org>
3128 Implement the flow table layout in the Details View.
3130 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3131 FlowTable to Group to account for the renamed class.
3132 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3133 File. This is a container widget that implements the Glom details view
3134 flow table behaviour.
3135 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3136 org/glom/web/client/ui/FlowTable.java.
3137 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3138 so that the size of the subgroups are a closer match to the size of
3139 the Glom subgroups. This makes the flowtable layout match the layout
3140 in Glom for the Music Collection example file.
3142 2011-08-16 Ben Konrath <ben@bagu.org>
3144 Create container element for LayoutItemPortal in Details View.
3146 This will help me develop the layout for the FlowTable.
3148 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3149 fieldPanel variable to detailsCell.
3151 2011-08-15 Ben Konrath <ben@bagu.org>
3153 Set the height of the data element in the Details View.
3155 I changed the InlineLabels (text in a span element) to Labels (text in
3156 a div element) so that I could set the height of the details-data
3157 elements instead of the details-cell parent elements. This allows the
3158 the details-data element to display the correct height if style is
3159 applied that shows the height.
3161 This change has the added benefit of allowing the order of the labels
3162 and data elements to be changed for right-to-left languages.
3164 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3165 InlineLabels to Labels.
3166 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3167 InlineLabels to Labels. Set the height of the data element.
3168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3169 multiline text height in the Formatting DTO.
3170 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3171 for multiline height along with getter and setter methods.
3172 * src/main/webapp/style.css: Adjust style to account for the change
3173 from span elements to div elements in the details cell.
3175 2011-08-15 Ben Konrath <ben@bagu.org>
3177 Make the List View appearance match the mockups.
3179 It doesn't match exactly but it's much better than it was.
3181 * mockups/listview-contacts.html: Remove unused css classes.
3182 * mockups/listview-projects.html: Remove unused css classes.
3183 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3184 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3185 for mainPanel instead of VerticalPanel (table). Set style name on
3186 CellTable. Set style name on Details column. Right-align Details
3188 * src/main/webapp/style.css: Adjust properties to match the mockups.
3190 2011-08-12 Ben Konrath <ben@bagu.org>
3192 Add better support for subgroups in the details view.
3194 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3195 changed FlowTable constructor.
3196 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3197 support for subgroups and subgroup-titles.
3198 * src/main/webapp/style.css: Add CSS class for subgroups and
3201 2011-08-12 Ben Konrath <ben@bagu.org>
3203 Return the top level LayoutGroup title.
3205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3207 2011-08-11 Ben Konrath <ben@bagu.org>
3209 Make the TableSelector header match the mockup.
3211 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3212 the layout panel. Properly lineup the table selection header with
3213 the list and details view.
3214 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3215 margin around the details view.
3216 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3217 Rename listBox variable to tableSelector. Set id for the style sheet.
3218 Use a FlowPanel instead of a HorizontalPanel.
3219 * src/main/webapp/style.css: Add properties to make the TableSelector
3220 box match the mockups.
3222 2011-07-13 Ben Konrath <ben@bagu.org>
3224 Update install script for java-libglom version change.
3226 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3229 2011-07-13 Ben Konrath <ben@bagu.org>
3231 Add support sub-group in the details view.
3233 I also removed the code that special-cased the default details view
3236 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3238 I still have to make a proper flowtable.
3240 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3241 Don't special-case default details view layout.
3242 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3243 addLayoutField() as I'm going to use it.
3244 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3245 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3247 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3248 extracted from DetailsViewImpl.GroupPanel. Add support for
3250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3251 column count when getting the details layout.
3253 2011-07-12 Ben Konrath <ben@bagu.org>
3255 Set browser title with database and table titles.
3257 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3258 Set the browser title when the table changes and when the activity