1 2012-04-17 Murray Cumming <murrayc@murrayc.com>
3 Locales drop-down: Show that we use English by default.
5 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
6 fillView(): When we use English, just because that is the default, when
7 no locale is specified, show that in the Locales drop-down instead of
8 just showing the first item.
10 2012-04-17 Murray Cumming <murrayc@murrayc.com>
12 Unselect the Report/Locale/Table combo item when appropriate.
14 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
15 setPlace(): clear reportName if this is not a ReportPlace.
16 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
17 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
18 When the provided name is empty, unselect all items, so that none are
19 indicated. This uses a for loop because I cannot find a single method
22 2012-04-17 Murray Cumming <murrayc@murrayc.com>
24 Report: Give the user a way to get back to the list.
26 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
27 start(), setPlace(): Show the Back To List link on reports, and also
28 interpret selecting the empty report item as back to list.
30 2012-04-17 Murray Cumming <murrayc@murrayc.com>
32 Style: Remove overflow:hidden from searchbox
34 * src/main/webapp/style.css: Because this pushes the Back To Link
35 label/link on to the next row, which is then hidden due to the
36 hard-coded (in ems) height.
38 2012-04-13 Murray Cumming <murrayc@murrayc.com>
40 Really show the selected Report name.
42 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
43 setPlace(): Store the reportName here, if it is that kind of Place.
44 fillView(): Set the selected Report after filling the list of reports.
45 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
46 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
47 null Strings, though we need some way to unselect all ListBox items
50 2012-04-13 Murray Cumming <murrayc@murrayc.com>
52 ReportGenerator: Try to avoid some problems.
54 * src/main/java/org/glom/web/server/ReportGenerator.java
55 addField(): Try to avoid duplicates, and avoid using a null
58 2012-04-13 Murray Cumming <murrayc@murrayc.com>
60 Reports: Use quickFind.
62 * src/main/java/org/glom/web/client/OnlineGlomService.java;
63 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
64 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
65 getReportHTML(): Add a quickFind parameter.
66 * src/main/java/org/glom/web/client/activity/ReportActivity.java
67 start(): Pass the quickFind parameter.
68 * src/main/java/org/glom/web/server/ReportGenerator.java
69 generateReport(): Take a quickFind parameter.
71 2012-04-13 Murray Cumming <murrayc@murrayc.com>
73 ReportPlace: Actually use the report name.
75 * src/main/java/org/glom/web/client/place/ReportPlace.java
76 getPlace(): Do not assign the report name to the quickfind.
78 2012-04-13 Murray Cumming <murrayc@murrayc.com>
80 Show java.library.path when complaining.
82 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
83 init(): When telling us to check java.library.path, show the
86 2012-04-12 Murray Cumming <murrayc@murrayc.com>
88 Adapt to the java-libglom 1.21.8 API.
90 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
91 java-libglom's FieldFormatting is now Formatting.
93 2012-04-12 Murray Cumming <murrayc@murrayc.com>
95 Use the latest java-libglom version.
97 * pom.xml: Use java-libglom 1.21.8.
99 2012-03-15 Murray Cumming <murrayc@murrayc.com>
101 Adapt to the java-libglom 1.21.7 API.
103 * src/main/java/org/glom/web/server/ReportGenerator.java:
104 addToReport(): get_group_secondary_fields() is now
105 get_secondary_fields().
107 2012-03-15 Murray Cumming <murrayc@murrayc.com>
109 Use the latest java-libglom version.
111 * pom.xml: Use java-libglom 1.21.7.
113 2012-03-06 Murray Cumming <murrayc@murrayc.com>
115 ReportGenerator: Do not show nulls.
117 2012-03-06 Murray Cumming <murrayc@murrayc.com>
119 ReportGenerator: Make the title font larger.
121 2012-03-06 Murray Cumming <murrayc@murrayc.com>
123 ReportGenerator: Put field titles inside groups, if there are groups.
125 2012-03-06 Murray Cumming <murrayc@murrayc.com>
127 ReportGenerator: Take the Report itself instead of the name and group.
129 * src/main/java/org/glom/web/server/ConfiguredDocument.java
130 Remove getReportLayoutGroup().
131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
132 getReportHTML(): Pass the report instead
133 of its name and layout group.
134 * src/main/java/org/glom/web/server/ReportGenerator.java
135 generateReport(): Use the report object to use the title
138 2012-03-06 Murray Cumming <murrayc@murrayc.com>
140 ReportGenerator: Remove designBand parameters.
142 * src/main/java/org/glom/web/server/ReportGenerator.java:
143 Make designBand a class member instead of passing it to all
146 2012-03-06 Murray Cumming <murrayc@murrayc.com>
148 ReportGenerator: Add lines, a bit like in the desktop version.
150 * src/main/java/org/glom/web/server/ReportGenerator.java
151 addToReport(): Use JRDesignLine.
153 2012-03-06 Murray Cumming <murrayc@murrayc.com>
155 ReportGenerator: Correct the title positions and use some bold style.
157 * src/main/java/org/glom/web/server/ReportGenerator.java:
158 Break the code up into reusable functions, correct the placement of
159 titles, and use normal/bold styles as in the reports in the desktop
162 2012-03-06 Murray Cumming <murrayc@murrayc.com>
164 ReportGenerator: Add a header band to show the field titles.
166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
167 getReportHTML(): Pass the localeId to the ReportGenerator
169 * src/main/java/org/glom/web/server/ReportGenerator.java
170 constructor: Take the localeID so we can get translated field
172 generateReport(), addToReport(), addFieldToBand(): Add field
173 titles in a column header band.
175 2012-03-05 Murray Cumming <murrayc@murrayc.com>
177 Reports drop-down list: Some improvement.
179 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
180 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
181 Adedd setSelectedReport(),
182 setReportList(): Add a blank line so that the user can select the
184 * src/main/java/org/glom/web/client/activity/ReportActivity.java
185 start(): Show the current report by calling setSelectedReport().
186 This does not seem to work yet.
188 2012-03-05 Murray Cumming <murrayc@murrayc.com>
190 DetailsActivity, ListActivity: Move some variables into a base class.
192 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
193 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
194 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
195 the clientFactory, documentID, tableName and authenticationPopup into
196 a base class, to avoid duplication.
198 2012-03-05 Murray Cumming <murrayc@murrayc.com>
200 Translate the Reports label.
202 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
203 Get the "Reports" label string from the constants.
204 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
205 perties: Add Reports to the constants.
207 2012-03-03 Ben Konrath <ben@bagu.org>
209 Display date and time in details view.
211 https://bugzilla.gnome.org/show_bug.cgi?id=671257
213 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
215 2012-03-05 Murray Cumming <murrayc@murrayc.com>
217 Require the latest java-libglom.
219 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
221 2012-03-05 Murray Cumming <murrayc@murrayc.com>
223 Reports: Implement grouping.
225 * src/main/java/org/glom/web/server/ReportGenerator.java:
226 Handle LayoutItem_GroupBy items and try to do the right thing
227 with JRDesignGroup. It seems to work.
229 2012-03-04 Murray Cumming <murrayc@murrayc.com>
231 Actually show some data with JasperReports.
233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
234 getReportHTML(): Move most code into a ReportGenerator class.
235 * src/main/java/org/glom/web/server/ReportGenerator.java:
236 Recurse into sub-groups, adding fields to the JasperDesign's details
237 band. Note that we must set an arbitrary width and height, or it just
238 will not show any data.
240 2012-03-04 Murray Cumming <murrayc@murrayc.com>
242 Reports Chooser: Show the titles, not the names.
244 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
245 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
246 and the names as the values.
247 * src/main/java/org/glom/web/server/ConfiguredDocument.java
248 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
249 group now that we provide the report name, so it should always
252 2012-03-04 Murray Cumming <murrayc@murrayc.com>
254 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
256 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
257 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
258 an empty quickfind string. I also corrected libglom to create only
259 empty where clauses for empty quickfind strings, but this avoids the
262 2012-02-24 Ben Konrath <ben@bagu.org>
264 Improve the tabs in the Notebook widget.
268 2012-02-15 Murray Cumming <murrayc@murrayc.com>
270 Depend on jasperreports.
272 * pom.xml: Add the dependency. My plan is to use this on the
275 2012-01-31 Murray Cumming <murrayc@murrayc.com>
277 Implement navigation to report places.
279 * src/main/java/org/glom/web/client/activity/ReportActivity.java
280 start(): Do not bother to handle all events here.
281 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
282 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
283 Added getSelectedReport().
284 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
285 .java: start(): When handling a change to the reports chooser,
286 call getSelectedReport() and goTo() its ReportPlace.
287 * src/main/java/org/glom/web/client/ui/ReportView.java
288 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
289 Added setReportHTML() which puts the html in a gwt HTML widget.
290 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
291 getReportHTML(): Return "TODO" just to show that this works.
293 2012-01-31 Murray Cumming <murrayc@murrayc.com>
295 Make ReportPlace usable.
297 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
299 * src/main/java/org/glom/web/client/place/ReportPlace.java:
300 Correct the @prefix annotation.
302 2012-01-31 Murray Cumming <murrayc@murrayc.com>
304 OnlineGlomService: Return report HTML rather than the LayoutGroup.
306 * src/main/java/org/glom/web/client/OnlineGlomService.java:
307 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
308 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
309 Change getReportLayout() to getReportHMTL() because we will not need to
310 parse or render the report layout on the client side.
311 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
312 getReportLayout(): Return the libglom LayoutGroup type because we will
313 not need to convert to a shared type, because this will not be used on
315 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
318 Note that there is still no implementation for this.
320 2012-01-30 Murray Cumming <murrayc@murrayc.com>
322 Translations: Try to translate the strings.
324 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
325 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
326 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
327 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
328 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
329 Take the Open translation from GTK+'s .po files.
330 Take the Details translation from Glom's po files.
331 I have added the other strings to Glom so we can get translations that way:
332 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
334 2012-01-27 Murray Cumming <murrayc@murrayc.com>
336 Add a (empty) Report Place, View, and Activity.
338 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
340 * src/main/java/org/glom/web/client/place/HasTablePlace.java
341 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
342 this into a superclass:
343 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
344 and also use it as the base of this new ReportPlace:
345 * src/main/java/org/glom/web/client/place/ReportPlace.java
347 * src/main/java/org/glom/web/client/ui/ReportView.java
348 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
349 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
350 Add these, containing mostly boiler-plate for now.
352 * src/main/java/org/glom/web/client/OnlineGlomService.java
353 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
354 * src/main/java/org/glom/web/server/ConfiguredDocument.java
355 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
356 Add API to get the LayoutGroup for the report.
358 2012-01-27 Murray Cumming <murrayc@murrayc.com>
360 TableSelectionViewImpl: Put the search label and entry in a div.
362 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
363 Put the search widgets in a FlowTable so that the CSS can be used to
364 style them while keeping them together.
365 * src/main/webapp/style.css: Mention the new div.
367 2012-01-27 Murray Cumming <murrayc@murrayc.com>
369 Translate more strings in more locales.
371 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
372 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
373 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
374 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
375 Translate the "Details" and "Open" string too.
377 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
378 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
379 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
380 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
381 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
382 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
383 Add these new locales as placeholders though they currently contain English.
385 2012-01-27 Murray Cumming <murrayc@murrayc.com>
387 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
389 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
390 Check the ConfiguredDocument* for null before using it.
392 2012-01-26 Murray Cumming <murrayc@murrayc.com>
394 Tell Eclipse about the generated java files.
396 * .classpath: This lets it find OnlineGlomConstants.java.
397 It would be nice if Eclipse just used the maven build files.
399 2012-01-26 Murray Cumming <murrayc@murrayc.com>
401 Prevent a crash when no locale is specified in the URL.
403 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
404 Avoid returning a null string, obtained from
405 Window.Location.getParameter(). This caused a crash when it was
406 later passed to libglom's API.
407 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
408 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
409 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
410 guard against future null strings.
412 2012-01-26 Murray Cumming <murrayc@murrayc.com>
414 Use the ?locale= query param instead of the &lang= token param.
416 * src/main/java/org/glom/web/client/place/ListPlace.java
417 * src/main/java/org/glom/web/client/place/DetailsPlace.java
418 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
419 Remove the lang token key and value.
421 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
422 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
423 When the user selects a different locale from the chooser, use
424 Window.Location.assign() to change the URL, which then causes a reload.
426 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
427 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
428 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
429 * src/main/java/org/glom/web/client/activity/ListActivity.java
430 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
431 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
432 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
433 * src/main/java/org/glom/web/client/ui/ListView.java:
434 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
436 Remove localeID member variables and method/constructor parameters, instead
437 using Utils.getCurrentLocaleID() when we need a localID to pass to
440 2012-01-26 Murray Cumming <murrayc@murrayc.com>
442 Internationalize the UI strings.
444 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
445 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
446 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
447 because it is unused. Messages are apparently strings that can have
448 parameters, but we do not need that yet, so Contants will be enough for now.
449 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
450 to say that we support the en and de locales.
451 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
452 The original English strings.
453 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
454 Some German translations of the English strings.
455 The i18n goal then uses the .properties file to generate an
456 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
457 returns an implementation that returns the translated strings.
458 The documentation suggests putting these in src/java/*/client/, but it seems
459 best to put it in src/resources/*/client/.
460 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
461 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
462 instead of hard-coding them.
463 Note that we cannot import OnlineGlomConstants because it does not exist yet,
464 but that does not seem to stop the build, though it confuses Eclipse.
466 You can see the translated string by adding ?locale=de to the URL, like so:
467 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
469 2012-01-24 Murray Cumming <murrayc@murrayc.com>
471 Improve null/empty String checks.
473 * pom.xml: Add a dependency on commons-lang, to use
474 org.apache.commons.lang.StringUtils.
475 * src/main/java/org/glom/web/server/ConfiguredDocument.java
476 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
477 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
478 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
479 Use StringUtils.isEmpty().
481 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
482 StringUtils class with a static isEmpty() function because we
483 cannot use org.apache.commons.lang.StringUtils in client-side
484 GWT code because it (apparently) cannot be compiled to javascript.
485 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
486 * src/main/java/org/glom/web/client/activity/ListActivity.java
487 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
488 * src/main/java/org/glom/web/client/place/DetailsPlace.java
489 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
490 * src/main/java/org/glom/web/client/place/ListPlace.java
491 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
492 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
493 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
494 * src/main/java/org/glom/web/client/ui/details/Group.java
495 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
496 our StringUtils.isEmpty() function.
498 2012-01-24 Murray Cumming <murrayc@murrayc.com>
500 Update to the latest java-libglom API.
502 * pom.xml: Require java-libglom 1.21.4.
503 * src/main/java/org/glom/web/server/ConfiguredDocument.java
504 getDocumentInfo(), getListViewLayoutGroup():
505 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
507 * src/main/java/org/glom/web/server/database/DBAccess.java
508 getFieldsToShowForSQLQueryAddGroup(),
509 getPrimaryKeyLayoutItemField(): Replace get_database_title()
510 with either get_database_title_original() or
511 get_database_title(localeID).
513 2012-01-24 Murray Cumming <murrayc@murrayc.com>
515 ConfiguredDocument: Avoid a null pointer exception.
517 * src/main/java/org/glom/web/server/ConfiguredDocument.java
518 Initialize localeID to "" to avoid returning a null String which
519 causes a crash in java-libglom's swing-generated code.
521 2012-01-23 Murray Cumming <murrayc@murrayc.com>
523 Some simple renaming.
525 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
526 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
527 for localeChooser. This seems more appropriate and is less ambiguous
528 particularly in the .css file.
530 2012-01-23 Murray Cumming <murrayc@murrayc.com>
532 ConfiguredDocument: Rename the localedID private member variable.
534 2012-01-23 Murray Cumming <murrayc@murrayc.com>
536 Adapt to the latest java-libglom API from git master.
538 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
539 libglom now uses only Vector instead of List, which uses add() instead of
542 2012-01-23 Murray Cumming <murrayc@murrayc.com>
544 Add and fill a Reports drop-down list box.
546 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
548 * src/main/java/org/glom/web/client/OnlineGlomService.java:
549 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
550 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
551 Added getReports(document, table, localeID), calling
552 ConfiguredDocument.getReports().
553 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
554 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
555 Added setReportsList() and a list widget.
556 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
557 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
559 2012-01-22 Murray Cumming <murrayc@murrayc.com>
561 ConfiguredDocument: Rename the localedID private member variable.
563 2012-01-20 Murray Cumming <murrayc@murrayc.com>
565 Build a source tarball with mvn assembly:single
567 * assembly.xml: Add this file.
568 * pom.xml: Use the maven-assembly-plugin and tell it to use
569 our assembly.xml file.
571 2012-01-19 Murray Cumming <murrayc@murrayc.com>
573 OnlineGlomServiceImpl: Get .glom files recursively.
575 * pom.xml: Depend on commons-io from org.apache.commons.
576 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
577 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
578 files recursively, and with the easier filter for the extension.
579 Use org.apache.commons.io.FilenameUtils.removeExtension() to
580 simplify that code too.
582 2012-01-19 Murray Cumming <murrayc@murrayc.com>
584 README: Mention that you must install java-libglom packages separately.
586 But then it works, because java-libglom is now in the central maven
589 2012-01-18 Murray Cumming <murrayc@murrayc.com>
591 locales drop-down: Show the correct selected locale when the URL changes.
593 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
594 .java: setPlace(): Move some code into fillView().
596 2012-01-18 Murray Cumming <murrayc@murrayc.com>
598 locales drop-down: Do not lose the primary key.
600 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
601 start(): onLocaleChange(): Pass the current primary key value,
602 instead of an empty value.
604 2012-01-18 Murray Cumming <murrayc@murrayc.com>
606 locales drop-down: Do not lose the drop-down selection.
608 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
609 .java (TableSelectionActivity.fillView): Set the selected locale
610 after changing the drop-down items (though we do not really need
611 to change them just because the locale changes.)
613 2012-01-18 Murray Cumming <murrayc@murrayc.com>
615 locales drop-down: Change the tables list when this changes.
617 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
618 .java: TableSelectionActivity.start(): Move the async table titles
619 retrieval into a private fillView() method and also call this when
620 the chosen locale changes.
621 Note that the document title is not actually translatable yet, but
622 that is a problem that I should fix soon in libglom.
624 2012-01-18 Murray Cumming <murrayc@murrayc.com>
626 Improve the placement of the locales drop-down.
628 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
629 Put the title and locales drop-down in a div (gwt.FlowTable).
630 * src/main/webapp/style.css: Add magic css properties to make this work.
631 Also remove the left margin from the title so that it lines up with the
634 2012-01-18 Murray Cumming <murrayc@murrayc.com>
636 locales selector: Show human-readable locale titles.
638 * src/main/java/org/glom/web/server/ConfiguredDocument.java
639 getDocumentInfo(): Use java.util.Locale to show a real title of
640 each locale, in the locale's own language.
642 2012-01-17 Murray Cumming <murrayc@murrayc.com>
644 Add a language/locale selector drop-down.
646 * src/main/java/org/glom/web/shared/DocumentInfo.java:
647 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
648 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
649 getDocumentInfo(): Store the available Locales in the DocumentInfo.
650 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
651 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
652 Add a ListBox to show the available locales. Add getLocaleSelector(),
653 setLocaleList(), getSelectedLocale(), setSelectedLocale().
654 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
655 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
656 java: Add these classes.
657 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
658 start(): Fill the locales ListBox. Handle its change event, firing a
660 setPlace(): Show the selected locale as specified by the URL token.
661 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
662 * src/main/java/org/glom/web/client/activity/ListActivity.java:
663 Handle LocaleChangeEvent, going to a new *Place with that locale.
665 The placement of the ListBox is not pretty, and it currently uses the ID
666 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
670 2012-01-17 Murray Cumming <murrayc@murrayc.com>
672 Search box: Show the search text from the URL token.
674 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
675 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
676 Add setQuickFindText().
677 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
678 .java: setPlace(): Store the queryText if the place is a ListPlace,
679 and call TableSelectionView.setQuickFindText().
681 2012-01-17 Murray Cumming <murrayc@murrayc.com>
683 Allow use of translations via, for instance, &lang=de in the URL.
685 * pom.xml: Use the unstable java-libglom 1.21 version.
687 * src/main/java/org/glom/web/client/OnlineGlomService.java:
688 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
689 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
690 init(): Instead of calling TranslatableItem.set_current_locale()
691 (now removed), call ConfiguredDocument.setDefaultLocaleID().
692 However, this is only for default locales, which are not needed to
693 change the locale in the URL.
694 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
695 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
696 getSortedRelatedListData(): Add a localeID parameter, so we can get the
697 layout for a particular locale.
698 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
699 Add get/setDefaultLocaleID().
700 getDocumentInfo(), getListViewData(), getRelatedListData(),
701 getDetailsLayoutGroup(), getListViewLayoutGroup(),
702 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
703 localeID parameter, so we can get the layout for a particular locale.
705 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
706 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
707 * src/main/java/org/glom/web/client/place/ListPlace.java:
708 Parse and construct a lang parameter too.
710 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
711 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
712 passed to subsequent methods and constructors.
713 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
714 * src/main/java/org/glom/web/client/activity/ListActivity.java:
715 Store the localeID from the *Place and pass it to other constructors
716 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
718 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
719 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
720 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
721 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
722 * src/main/java/org/glom/web/client/ui/ListView.java:
723 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
724 Take localeID parameters and pass them to subsequent constructors and
725 methods, so that the layout is always retrieved for that locale.
727 This is rather repetitive.
729 Note that "" means the original (default) locale of the Glom document,
730 which is usually English.
732 2012-01-17 Murray Cumming <murrayc@murrayc.com>
734 Documents: Remove final keyword to fix startup configuration.
736 * src/main/java/org/glom/web/shared/Documents.java: Remove the
737 final keywords on the private member variables because that breaks
738 the startup, apparently (there are warnings) because it stops them
739 from being serialized. I added these in the previous commit.
741 2012-01-13 Murray Cumming <murrayc@murrayc.com>
743 Documents: Add some final keywords.
745 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
748 2012-01-13 Murray Cumming <murrayc@murrayc.com>
750 OnlineGlomServiceImpl: Add to overview comments.
752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
753 Note that this is where all the document are loaded. They are not
754 loaded freshly for each page.
756 2012-01-12 Murray Cumming <murrayc@murrayc.com>
760 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
761 Add a TextBox for the text of a quick find.
762 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
764 setBackLink(): Add a String quickFind parameter.
765 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
766 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
767 to the base interface, because that is how TableSelectionViewImpl is used.
768 * src/main/webapp/style.css: Add style for the search box and its label.
770 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
771 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
772 Add these files, based on the existing TableChangeEvent and
773 TableChangeEventHandlers.
774 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
775 start(): Handle QuickFindChangeEvent, passing its quickFind text to
776 a ListPlace() that the user should be taken to.
777 * src/main/java/org/glom/web/client/activity/ListActivity.java
778 start(): Handle it here too and adapt the TableChangeEvent handler to
779 pass the extra "" quickFind parameter to ListPlace.
780 * src/main/java/org/glom/web/client/place/ListPlace.java:
781 Constructor: Take an extra String quickFind parameter and store it,
782 returning it from a new getQuickFind() method.
783 getToken(): Put the quickFind text in the URL token.
784 getPlace(): Parse the quickFind text from the URL token.
785 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
786 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
787 ListPlace constructor.
788 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
789 .java: start(): Add a Change handler for the TableSelectionView's
790 TextBox (via its base HasChangeHandlers interface), firing the new
791 QuickFindChangeEvent.
792 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
793 pass the extra "" quickFind parameter.
795 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
796 setCellTable(): Add a String quickFind parameter and pass it to
797 the ListViewTable() constructor.
798 * src/main/java/org/glom/web/client/ui/ListView.java: Change
799 setCellTable() in the base interface, because that is how ListViewImpl
802 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
803 Add a String quickFind member variable.
804 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
805 Constructor: Add a String quickFind parameter, storing it in the
806 base ListTable's member variable.
807 onRangeChanged(): Pass quickFind to the
808 OnlineGlomServiceAsync.getSortedListViewData() and
809 OnlineGlomServiceAsync.getListViewData() methods.
811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
812 getListViewData(), getSortedListViewData(): Add a String quickFind
813 parameter, passing it to ConfiguredDocument.getListViewData().
814 * src/main/java/org/glom/web/client/OnlineGlomService.java:
815 Change getListViewData(), getSortedListViewData() in the base interface,
816 because that is how OnlineGlomServiceImpl is used, via this:
817 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
818 Change getListViewData(), getSortedListViewData() here too.
819 This class can apparently be used to asynchronously call methods on
820 OnlineGlomService, and GWT seems to implement that after recognizing
821 just the *Async name convention and the extra AsyncCallback parameters.
823 * src/main/java/org/glom/web/server/ConfiguredDocument.java
824 getListViewData(): Add a String quickFind parameter, and pass it to
825 ListViewDBAccess.getData().
826 * src/main/java/org/glom/web/server/database/ListDBAccess.java
827 getListData(): Add a String quickFind parameter and pass it to
829 getSelectQuery(): Add a String quickFind parameter.
830 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
831 getSelectQuery(): Add a String quickFind parameter and use it with
832 Glom.get_find_where_clause_quick() to pass a where_clause to
833 Glom.build_sql_select_with_where_clause(), to actually filter the
835 getData(): Add a String quickFind parameter, passing it to getListData().
836 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
837 va: getData(): Pass an empty string to getListData() for the
840 2012-01-12 Murray Cumming <murrayc@murrayc.com>
842 ListTable: Minor change.
844 * src/main/java/org/glom/web/client/ui/list/ListTable.java
845 createCellTable(): Make this protected instead of public.
847 2012-01-12 Murray Cumming <murrayc@murrayc.com>
849 Many files: Use final for the parameters and use the @override attribute.
851 2012-01-22 Ben Konrath <ben@bagu.org>
853 Add anchor links for single line text that starts with http, ftp and www.
857 2012-01-22 Ben Konrath <ben@bagu.org>
859 Add ellipsis to single line text in details view.
863 2012-01-04 Murray Cumming <murrayc@murrayc.com>
865 Remove all javadoc author tags.
867 Because they are awkward and meaningless when many people touch
869 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
871 2012-01-04 Murray Cumming <murrayc@murrayc.com>
873 Revert the COPYING.LESSER to COPYING rename.
875 Apparently both should be there if it is LGPL.
877 2012-01-03 Murray Cumming <murrayc@murrayc.com>
879 *View: Remove unused imports.
881 * src/main/java/org/glom/web/client/ui/DetailsView.java:
882 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
883 * src/main/java/org/glom/web/client/ui/ListView.java:
884 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
885 Remove unused imports, as suggested by Eclipse.
887 2012-01-02 Murray Cumming <murrayc@murrayc.com>
889 Move the *View::Presenter types, and some API into one base View.
891 * src/main/java/org/glom/web/client/ui/DetailsView.java:
892 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
893 * src/main/java/org/glom/web/client/ui/ListView.java:
894 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
895 Presenter, setPresenter() and clear() into a shared base interface,
896 to avoid the unnecessary duplicate Presenter types and to more clearly
897 show how the *Views share the same structure, even if they are not
898 used polymorphically.
900 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
901 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
903 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
904 * src/main/java/org/glom/web/client/activity/ListActivity.java:
905 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
907 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
910 Feel free to revert this if there is a good reason for the duplicate
913 2012-01-02 Murray Cumming <murrayc@murrayc.com>
915 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
917 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
918 a class member instead of a local variable in the method.
919 This lets us use it to get the view instances, for use in tests.
920 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
921 beforeOnlineGlom(): Test some more details of the initial view.
922 Again, this is not very useful.
924 To really test gwt-glom we will need to start a local postgresql
925 instance with local data, like the Glom tests in C++.
927 2012-01-02 Murray Cumming <murrayc@murrayc.com>
929 pom.xml: Mention the LGPL license.
931 * pom.xml: Add a licenses section.
932 * COPYING.LESSER: Move this to COPYING, which
933 previously contained the GPL. But gwt-glom is all LGPL.
935 2012-01-02 Murray Cumming <murrayc@murrayc.com>
937 Add project information to README and pom.xml.
939 * README: Add a brief description and mention some mvn
941 * pom.xml: This extra information shows up in mvn site
944 2011-01-02 Murray Cumming <murrayc@murrayc.com>
946 Use the latest java-libglom version.
948 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
950 2012-01-01 Murray Cumming <murrayc@murrayc.com>
952 GwtTestOnlineGlom: Test a little more.
954 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
955 protected rather than private, as suggested by the gwt-test-utils
957 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
958 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
959 Test the initial visibility of the panels.
961 However, this is not a very useful test.
962 And I wonder how we should generally test using this idea for an
963 activity/places app like ours where the real changes happen implicitly
964 based on the history token/URL.
966 2012-01-01 Murray Cumming <murrayc@murrayc.com>
968 Slight modification to *Mapper comments.
970 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
972 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
974 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
976 Remove comments mentioning GIN because they are just copied from
977 the example code and are apparently not helpful:
978 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
979 Also change the mention of a class that is only in the example code.
981 2012-01-01 Murray Cumming <murrayc@murrayc.com>
983 GwtTestOnlineGlom test: Minor changes.
985 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
986 Avoid the long qualified class name and modify the comment
987 because it is now obvious to me that the mocked class is the only
988 custom one created via GWT.create().
990 2012-01-01 Murray Cumming <murrayc@murrayc.com>
992 Tests: Added the beginnings of a test using gwt-test-utils.
994 * pom.xml: Add dependencies on gwt-test-utils and easymock.
995 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
996 which tells gwt-test-utils what class will be tested.
997 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
998 Add a simple (but empty) test case. One class, used by the OnlineGlom
999 class, is mocked so that it can be created. However, I am not sure
1000 why only this class needs to be mocked.
1002 Note that mockito seems more popular, and clearer, than easymock,
1003 but I have not got that working yet. It might be a matter of the
1006 This test is run during mvn integration-test.
1008 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1010 Tests: Use junit4-style syntax instead of junit3-style.
1012 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1013 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1014 * src/test/java/org/glom/web/shared/DataItemTest.java:
1015 Use the @Test annotation rather than relying on the test*() prefix.
1016 Also no longer implement TestCase, to avoid triggering support for
1017 the junit3-way, which stops the annotations from working.
1018 Change the imports from import junit.framework.* to
1019 import org.junit.*, which is apparently the new way.
1021 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1023 Added a test for ListPlace token parsing and creation.
1025 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1026 This is much the same as DetailsPlaceTest.
1028 I wonder how we could test the other parts of the *Place API.
1030 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1032 DetailsPlace test: Also test getToken() and recreation via getPlace().
1034 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1035 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1036 recreate it, testing the recreated DetailsPlace for the same parameter
1039 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1041 Use the surefire-report plugin.
1043 * pom.xml: This generates a HTML report about the tests in
1044 target/site/surefire-report.html
1045 when you do mvn surefire-report:report. It seems to be popular/normal.
1047 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1049 Added a test for DetailsPlace.
1051 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1052 Test the getPlace() token parsing.
1054 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1056 Added a first unit test.
1058 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1059 * src/test/java/org/glom/web/shared/DataItemTest.java:
1060 This is a silly test but it is just to get things started. Note that
1061 maven/junit finds the test because it looks in src/test by default.
1063 2011-12-22 Ben Konrath <ben@bagu.org>
1065 Change charsetName to "UTF-8" when replacing line breaks.
1067 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1068 that work in Java (such as "UTF8") will not work when compiled to
1071 This fixes a problem with multi-line details view fields that have hard
1072 line breaks. The "License Text" field on this page demonstrates the
1075 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1077 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1079 2011-12-22 Ben Konrath <ben@bagu.org>
1081 Fix another bug with related list navigation.
1083 I've tested all the navigation buttons in all of the related lists
1084 so things should be good now.
1086 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1088 2011-12-22 Ben Konrath <ben@bagu.org>
1090 Fix a crasher when refreshing the list view with the default table.
1092 This crash will also happen when loading the list view with the default
1093 table from a link or bookmark.
1095 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1096 to the main document selection page when the document id hasn't been
1098 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1099 the main document selection page when the document id hasn't been
1101 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1102 values for the details place when the document id hasn't been set.
1103 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1104 values for the list place when the document id hasn't been set.
1106 2011-12-21 Ben Konrath <ben@bagu.org>
1108 Protect against NPE when glom.document.locale is not in config.
1110 This patch protects against an NPE when glom.document.locale is not in
1111 the config file. This NPE will also happen if glom.document.locale is
1114 The patch also updates the error message to display the class name when
1115 the getMessage() returns null. This was happening when the NPE was
1116 thrown and I had "Configuration Error: null". If an NPE is encountered
1117 with this patch, "Configuration Error: NullPointerException " will be
1120 This commit closes this bug:
1122 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1124 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1126 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1128 Rename onlineglom.properties to onlineglom.properties.sample.
1130 * src/main/resources/onlineglom.properties: Rename to:
1131 * src/main/resources/onlineglom.properties.sample:
1132 * src/main/resources/README: And add this file explaining that people
1133 should rename it back when deploying.
1135 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1137 Allow choosing the translation in the .properties file.
1139 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1140 init(): Read a glom.document.locale value from the configuration file
1141 and call Glom's TransatableItem::set_current_locale() method.
1142 * src/main/resources/onlineglom.properties: Add a commented-out
1143 example of this new setting.
1145 It would be better to add &lang=de_DE to the URL, but the current
1146 libglom API does not allow us to do this easily. I am working on that.
1148 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1150 Avoid a crash in parsing of token parameters.
1152 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1153 ava: getTokenParams(): Do not crash if a parameter has a key but no
1154 value, and ignore parameters with neither.
1156 2011-12-17 Murray Cumming <murrayc@murayc.com>
1158 History token building/handling: Improve use of token parameters.
1160 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1161 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1162 and buildParamsToken(HashMap), for use by derived classes.
1163 Make the separator private because it is no longer be needed.
1164 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1165 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1166 instead of manual string concatenation.
1167 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1168 of hardcoded indices and awkward splitting code.
1169 * src/main/java/org/glom/web/client/place/ListPlace.java
1170 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1171 instead of manual string concatenation.
1172 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1173 of hardcoded indices and awkward splitting code.
1174 This should fix bug #666420
1176 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1178 Fix a Navgiation->Navigation typo in the code.
1180 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1181 Rename processNavgiation() to processNavigation().
1183 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1185 Fix a seperator->separator typo in the code.
1187 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1188 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1189 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1192 2011-12-15 Ben Konrath <ben@bagu.org>
1194 Cleanup some comments.
1196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1198 2011-12-14 Ben Konrath <ben@bagu.org>
1200 Replace \n with <br/> for multiline text in the details view.
1202 Vertical scrollbars are added when needed as well.
1204 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1206 2011-12-14 Ben Konrath <ben@bagu.org>
1208 Specify the font for document selection links.
1210 * src/main/webapp/style.css:
1212 2011-12-14 Ben Konrath <ben@bagu.org>
1214 Fix bouncy CellTable while paging.
1216 This doesn't currently work with related list tables in unselected
1219 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1221 2011-12-14 Ben Konrath <ben@bagu.org>
1223 Revamp the appearance of the document selection page.
1225 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1226 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1227 * src/main/webapp/style.css:
1229 2011-12-13 Ben Konrath <ben@bagu.org>
1231 Set navigation button column to the smallest size possible.
1233 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1235 2011-12-13 Ben Konrath <ben@bagu.org>
1237 Change OpenButton nomenclature to NavigationButton.
1239 Using NavigtionButton makes things more generic. Classes, methods and
1240 variables have been changed.
1242 This is a rename-only refactor.
1244 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1245 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1246 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1247 Renamed from OpenButtonCell.
1248 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1249 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1250 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1252 2011-12-12 Ben Konrath <ben@bagu.org>
1254 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1256 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1257 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1258 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1259 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1261 2011-12-12 Ben Konrath <ben@bagu.org>
1263 Update variable names and comments.
1265 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1266 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1268 2011-12-12 Ben Konrath <ben@bagu.org>
1270 Properly initialize numNonEmptyRows variable to zero.
1272 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1273 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1275 2011-12-05 Ben Konrath <ben@bagu.org>
1277 Add latest mockup with HTML tables.
1279 Features of this mockup:
1281 -> HTML table for flowtable
1282 -> HTML table for flowtable column
1283 -> Example of how related lists would look
1284 -> Not using text entries for data items
1286 The current version of Online Glom doesn't use HTML tables for the
1289 This mockup has been sent to the glom-devel mailing list but it's good
1290 to have it here as well.
1292 * mockups/details-view-html-tables.html:
1294 2011-12-05 Ben Konrath <ben@bagu.org>
1296 Remove unnecessary getPrimaryKeyField() method.
1298 getPrimaryKeyFieldForTable(String) has been renamed to
1299 getPrimaryKeyField(String).
1301 * src/main/java/org/glom/web/server/database/DBAccess.java:
1302 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1303 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1305 2011-12-05 Ben Konrath <ben@bagu.org>
1307 Add string representation of TypedDataItem value to conversion error message.
1309 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1310 message was extracted into its own method to avoid duplication.
1312 2011-12-05 Ben Konrath <ben@bagu.org>
1314 Add type checking to navigation primary key value creation.
1316 Create navigation primary key only if the expected type from the Glom
1317 document matches the type returned by the SQL query.
1319 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1321 2011-12-05 Ben Konrath <ben@bagu.org>
1323 Rename a couple of variables in RelatedListNavigation.
1325 This is a rename-only refactor.
1327 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1329 2011-12-05 Ben Konrath <ben@bagu.org>
1331 Move getListLayoutGroup() into getListViewLayoutGroup().
1333 This removes getListLayoutGroup(). It was only being called by
1334 getListViewLayoutGroup().
1336 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1338 2011-12-05 Ben Konrath <ben@bagu.org>
1340 Remove check for LayoutItem_Portal in list table method.
1342 This check is no longer necessary because the method isn't being used
1343 to create the LayoutItemPortal DTO.
1345 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1347 2011-12-05 Ben Konrath <ben@bagu.org>
1349 Properly support related list navigation.
1351 Navigation from the "Repository Analyzer -> Package Scans ->
1352 Dependencies" related table wasn't working because the primary key for
1353 related tables wasn't being set properly. This commit fixes the
1356 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1357 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1358 doesn't set the primary key properly for related list tables.
1359 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1360 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1361 useful for getting the primary key for list view tables and for related
1363 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1364 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1365 Move code to set the primary key for the table from the abstract
1366 ListDBAccess class to ListViewDBAccess as it's only correct for list
1368 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1369 Properly add primary key to related list tables.
1371 2011-12-02 Ben Konrath <ben@bagu.org>
1373 Properly set the horizontal alignment of fields.
1375 This fix is for both the list tables and the details view.
1377 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1378 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1379 to set the horizontal alignment of fields.
1381 2011-12-02 Ben Konrath <ben@bagu.org>
1383 Display currency codes in the details view.
1385 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1387 2011-12-02 Ben Konrath <ben@bagu.org>
1389 Avoid duplicate JNI call.
1391 JNI is not as efficient as pure Java and this is an easy (and small)
1394 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1395 Use previously retrieved value for whereClauseToTableName instead of
1398 2011-12-02 Ben Konrath <ben@bagu.org>
1400 Rename a couple of variables in RelatedListNavigation.
1402 This is a rename-only refactor.
1404 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1406 2011-12-02 Ben Konrath <ben@bagu.org>
1408 Indicate clearly that a mismatched primary key type is a bug.
1410 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1411 warning to error. Add 'This is a bug.' to message.
1413 2011-12-02 Ben Konrath <ben@bagu.org>
1415 Update / fix some comments.
1417 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1419 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1421 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1422 Fix comments. Add some TODOs.
1424 2011-12-02 Ben Konrath <ben@bagu.org>
1426 Enable navigation to details view with string primary key from related list.
1428 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1429 Create a text primary key value when return type of result is
1430 java.sql.Types.VARCHAR.
1432 2011-12-02 Ben Konrath <ben@bagu.org>
1434 Use checkboxes for booleans in the details view.
1436 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1438 2011-12-01 Ben Konrath <ben@bagu.org>
1440 Improve performance of related list height calculation.
1442 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1443 Put code to calculate the expected height in a static initializer so
1444 that that it's only called once.
1446 2011-12-01 Ben Konrath <ben@bagu.org>
1448 Show related list tables in notebooks (again).
1450 Calculate the height of the related list tables so the Notebook can be
1451 set the correct height. The height of the related list table is also needed by
1452 FlowTable to be able decide how to create the layout.
1454 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1455 and set the Portal height based on the height of the related list
1456 table and the Portal container.
1457 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1458 Add method to calculate the height of the related list tables.
1459 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1460 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1461 calculate the height of the Pager widget.
1463 2011-12-01 Ben Konrath <ben@bagu.org>
1465 Use CellTable API for table property instead of setting style on Element.
1467 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1469 2011-12-01 Ben Konrath <ben@bagu.org>
1471 Make ListViewTable and RelatedListTable a consistent height.
1473 The tables are now a consistent height regardless of the contents of
1474 the table. A hidden button is added to empty rows to ensure that the
1475 height of these rows will match the height of rows with data.
1477 A navigation button column is now added to every table. The width of
1478 the navigation column is set to 0px when a RelatedListTable shouldn't
1479 have navigation buttons. This maintains the a consistent row height in
1480 tables that don't show the navigation buttons.
1482 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1483 navigation column when not needed.
1484 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1485 arguments for navigation button to constructor of ListViewTable.
1486 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1487 hidden button for empty data rows.
1488 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1489 arguments for navigation button to constructor.
1490 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1491 create navigation buttons. Add hideNavigationButtons() method.
1492 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1493 arguments for navigation button to constructor.
1495 2011-12-01 Ben Konrath <ben@bagu.org>
1497 Use 'visibility: hidden' in Utils.getWidgetHeight().
1499 This is better choice because hidden elements are invisible, don't
1500 respond to events and are not part of the tab order. They will,
1501 however, take up space which is required to be able to calculate the
1502 height of the widget.
1504 * src/main/java/org/glom/web/client/Utils.java:
1506 2011-12-01 Ben Konrath <ben@bagu.org>
1508 Use Utils.getWidgetHeight() in FlowTable.
1510 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1512 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1514 2011-12-01 Ben Konrath <ben@bagu.org>
1516 Put the details css class name on the correct table column.
1518 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1520 2011-11-30 Ben Konrath <ben@bagu.org>
1522 Update for java-libglom API change.
1524 The getters and setters on FieldFormatting and NumericFormat were
1525 changed to remove the 'M'.
1527 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1529 2011-11-29 Ben Konrath <ben@bagu.org>
1531 Only allow RelatedListTables in Portals.
1533 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1535 2011-11-29 Ben Konrath <ben@bagu.org>
1537 Only create a contents panel for Portals when title is being set.
1539 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1541 2011-11-29 Ben Konrath <ben@bagu.org>
1543 Set TabLayoutPanel height based on calculated height its widgets.
1545 This is a potential fix for this bug:
1547 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1549 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1551 2011-11-29 Ben Konrath <ben@bagu.org>
1553 Align details field labels and data with the Open buttons.
1555 * src/main/webapp/style.css:
1557 2011-11-29 Ben Konrath <ben@bagu.org>
1559 Remove unnecessary <div> in the Notebook widget.
1561 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1562 method to get container FlowPanel (<div>).
1563 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1564 initWidget() method directly on the TabLayoutPanel widget instead of
1565 Group's container widget.
1567 2011-11-29 Ben Konrath <ben@bagu.org>
1569 Don't add group titles for Portals in Notebooks.
1571 This reverts the previous patch and fixes a bug I introduced with
1572 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1574 * src/main/java/org/glom/web/client/ui/details/Group.java:
1575 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1577 2011-11-28 Ben Konrath <ben@bagu.org>
1579 Remove unused boolean argument in Portal constructor.
1581 Just a code cleanup.
1583 * src/main/java/org/glom/web/client/ui/details/Group.java:
1584 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1586 2011-11-28 Ben Konrath <ben@bagu.org>
1588 Remove hack for glom 1.18 style glom files.
1590 * src/main/java/org/glom/web/client/ui/details/Group.java:
1591 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1592 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1594 2011-11-28 Ben Konrath <ben@bagu.org>
1596 Use Gda Value version of primary key to log result too large error.
1598 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1600 2011-11-28 Ben Konrath <ben@bagu.org>
1602 Don't use TypedDataItem.getText() for Unknown types from the URL.
1604 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1605 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1606 instead of getText().
1607 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1608 String field and getUnknown() method.
1610 2011-11-28 Ben Konrath <ben@bagu.org>
1612 Log an error message when the java-libglom .so is not present.
1614 The error message was being set in the exception but not logged.
1616 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1618 2011-11-28 Ben Konrath <ben@bagu.org>
1620 Ignore LayoutItem_CalendarPortals.
1622 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1623 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1625 2011-11-28 Ben Konrath <ben@bagu.org>
1627 Extract method for creating the LayoutItemPortal DTO.
1629 Just breaking the code up into smaller chunks.
1631 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1633 2011-11-28 Ben Konrath <ben@bagu.org>
1637 This should have been added with the refactor. Oops!
1639 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1641 2011-11-28 Ben Konrath <ben@bagu.org>
1643 Create primary key value from URL string using type from Glom document.
1645 See this bug, comments 19 - 25:
1647 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1649 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1650 create a TypeDataItem for the primary key here when loading from a
1651 URL. Show the same string for the primary key value as was received
1652 from the URL string (when loading from a URL).
1653 * src/main/java/org/glom/web/server/Utils.java: Update method for
1654 creating the Gda Value from the TypeDataItem to properly deal with
1655 creating a Gda Value based on the Glom document type for the primary
1656 key value string when loading from a URL.
1657 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1658 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1659 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1660 Update for changed method name.
1662 2011-11-27 Ben Konrath <ben@bagu.org>
1664 Rename PrimaryKeyItem to TypedDataItem.
1666 The name PrimaryKeyItem suggests what the class should be used for.
1667 TypedDataItem is a neutral name that describes the class better.
1669 This is a rename-only refactor.
1671 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1672 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1673 * src/main/java/org/glom/web/client/Utils.java:
1674 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1675 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1676 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1677 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1678 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1679 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1680 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1681 * src/main/java/org/glom/web/server/Utils.java:
1682 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1683 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1684 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1685 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1687 2011-11-25 Ben Konrath <ben@bagu.org>
1689 Improve Gda Value conversion from PrimaryKeyItem.
1691 The value from the PrimaryKeyItem is only used if its type match the
1692 type from the glom document.
1694 * src/main/java/org/glom/web/server/Utils.java:
1696 2011-11-25 Ben Konrath <ben@bagu.org>
1698 Manually check if the java-liblgom .so is visible to the JVM.
1700 It seems that Tomcat has problems when a static initializer throws an
1701 exception. This check is done before the first method call into
1702 java-libglom so that execution doesn't continue if the .so is not
1705 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1707 2011-11-25 Ben Konrath <ben@bagu.org>
1709 Improve browser configuration error messages.
1713 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1715 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1716 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1717 getConfigurationErrorMessage() method.
1718 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1719 Get and display a specific configuration error message when no Glom
1720 documents are found.
1721 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1722 Implement getConfigurationErrorMessage() method. Surround configuration
1723 code in the init() method with a try/catch block. This allows the
1724 errors to be caught while keeping the servlet available to retrieve the
1725 configuration error message.
1727 2011-11-25 Ben Konrath <ben@bagu.org>
1729 Don't use Strings to hold primary key values.
1731 The primary key values are now held in a new data object
1732 (PrimaryKeyItem) that holds type information and the primary key value
1733 using the correct type.
1735 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1736 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1737 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1738 PrimaryKeyItem instead of String to hold the primary key value.
1739 * src/main/java/org/glom/web/client/Utils.java: Remove
1740 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1741 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1742 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1743 PrimaryKeyItem instead of String to hold the primary key value. Load
1744 document selection page when the documentID has not been set correctly.
1745 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1746 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1748 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1749 Return empty string for URL instead of "null".
1750 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1751 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1752 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1753 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1754 PrimaryKeyItem instead of String to hold primary key values.
1755 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1756 PrimaryKeyValue to a Gda Value.
1757 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1758 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1759 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1760 Replace temporary database access code that uses the PrimaryKeyValue to
1761 Gda Value conversion.
1762 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1763 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1764 PrimaryKeyItem instead of String.
1765 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1766 hold primary key values.
1768 2011-11-24 Ben Konrath <ben@bagu.org>
1770 Use newly added java-libglom API to create queries.
1772 This isn't finished. I still need to stop using Strings for primary key
1773 values in the client code.
1775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1776 libglom to use fake connections so that retrieving the query string will
1778 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1779 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1780 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1781 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1782 Use the newly added libglom sql methods and classes to create the
1783 query. Add temporary hack to convert primary value strings to Gda
1786 2011-11-23 Ben Konrath <ben@bagu.org>
1788 Don't explicitly set the height of Portals.
1790 See comments 6 - 10 of this bug for details:
1792 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1794 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1796 2011-11-23 Ben Konrath <ben@bagu.org>
1798 Use an HTML table instead of CSS for the FlowTable layout.
1800 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1801 GWT's FlexTable to implement the FlowTable.
1802 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1804 2011-11-18 Ben Konrath <ben@bagu.org>
1806 Add boolean example to HTML table mockup.
1808 * mockups/details-view-html-tables-text-entries.html:
1810 2011-11-17 Ben Konrath <ben@bagu.org>
1812 Ensure the pager buttons are always visible for related lists.
1814 To accomplish this, I've turned off text wrapping in the list view and
1815 related list tables for both the header and data text. The related list
1816 table now has a fixed layout so the it doesn't overflow its container.
1817 This is required to ensure that the cell text is clipped when it
1818 overflows the cell and an ellipsis is added to the right side of the
1819 cell when text is clipped.
1821 A fixed table layout for the related list table in the details view
1822 seems what we want for the details view anyway, so the side-effect is
1825 The ellipsis will only be displayed in Firefox >= 7.
1829 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1831 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1832 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1833 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1835 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1836 Set the 'table-layout: fixed' CSS property to the related list table.
1837 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1838 'white-space: nowrap;' CSS property on both the list view and the
1839 related list tables.
1841 2011-11-16 Ben Konrath <ben@bagu.org>
1843 Rework the fix for empty notebook tab labels.
1845 Setting the empty group titles with its name caused problems for the
1846 details layout. Instead of using libglom's
1847 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1848 to the client when the title is empty. This allows the Notebook to use
1849 the name when the title is empty without affecting anything else.
1851 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1852 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1854 2011-11-16 Ben Konrath <ben@bagu.org>
1856 Set group titles with name when title is empty.
1858 This fixes a problem with an empty notebook tab label in the Lesson
1859 Planner document. The forth tab in the notebook should be "Internet":
1861 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1863 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1864 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1867 2011-11-16 Ben Konrath <ben@bagu.org>
1869 Remove whitespace from the configured username properties.
1871 This assumes that usernames won't have whitespace at the beginning
1872 or end. But I think this is a reasonable assumption.
1874 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1875 String.trim() to remove the whitespace from the username properties.
1877 2011-11-15 Ben Konrath <ben@bagu.org>
1879 Add details view mockup with HTML tables and text entries.
1881 This is from the attachment on this bug:
1883 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1885 * mockups/details-view-html-tables-text-entries.html:
1887 2011-11-15 Ben Konrath <ben@bagu.org>
1889 Add space between the columns of the flow table.
1893 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1895 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1896 space between columns in the flow table.
1898 2011-11-15 Ben Konrath <ben@bagu.org>
1900 Add backup files to the .gitignore.
1902 * .gitignore: Ignore files that end with ~.
1904 2011-11-09 Ben Konrath <ben@bagu.org>
1906 Use latest release of gwt-log.
1908 Gwt-log releases are now being submitted to the maven central
1909 repository so manual installation of the jar is no longer required.
1911 * pom.xml: Update version and groupId of gwt-log dependency.
1913 2011-10-31 Ben Konrath <ben@bagu.org>
1915 Don't use GWT numeric formatting to override the glom currency formatting.
1917 Currencies are now displayed like they are in Glom. See this bug:
1919 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1921 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1923 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1924 currency code to constructor and set it when the cell is rendered.
1925 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1926 currency code to the constructor of the NumericCell.
1928 2011-10-27 Ben Konrath <ben@bagu.org>
1930 Require the latest release of java-libglom (1.17.4).
1934 2011-10-26 Ben Konrath <ben@bagu.org>
1936 Add style to Notebook that matches current theme.
1938 It's not the best style in the world but it's better than the default.
1940 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1941 padding at the bottom of the child widgets.
1942 * src/main/webapp/style.css: Add style for the Notebook.
1944 2011-10-26 Ben Konrath <ben@bagu.org>
1946 Move servlet initialization code to overridden init method.
1948 This is half of the solution to getting proper error messages
1949 displayed when configuration errors occur. Here's the relevant bug:
1951 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1953 The rest of the solution involves surrounding the init method with a
1954 try/catch block and setting a global variable with the error /
1955 exception. A new async method should be created to retrieve and display
1956 the error message / exception.
1958 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1959 code from constructor to init method adding exceptions as needed.
1961 2011-10-26 Ben Konrath <ben@bagu.org>
1963 Add script to monitor and restart tomcat if required.
1965 * utils/check-and-recover-tomcat.py: New file.
1967 2011-10-26 Ben Konrath <ben@bagu.org>
1969 Display the correct number of data items in the pager.
1973 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1975 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1976 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1977 The implementation is the same for both tables: Keep track of the
1978 number of non-empty rows and fire and RowCountChangeEvent after the data has
1980 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1981 custom Pager class that subclasses SimplePager to handle displaying
1982 the correct number when empty rows have been added.
1984 2011-10-26 Ben Konrath <ben@bagu.org>
1986 Correct error in previous commit.
1988 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1989 eventBus parameter from listView.setCellTable().
1991 2011-10-26 Ben Konrath <ben@bagu.org>
1993 Fix error in TODO comment.
1995 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1997 2011-10-24 Ben Konrath <ben@bagu.org>
1999 Create Notebook widgets to the details view.
2001 This isn't finished just yet - I still need to create a reasonable
2002 style to match the current theme.
2004 * src/main/java/org/glom/web/client/Utils.java: Add method for
2005 calculating the height of a widget. This is used in the Notebook class.
2006 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2007 new constructor method in Group.
2008 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2009 method for creating child widget that can be used by subclasses
2010 like Notebook. New constructor that allows disabling the group
2011 titles - Notebooks don't set a group title for their child groups.
2012 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2013 to make Notebooks using GWT's TabLayoutPanel.
2014 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2015 constructor that allows disabling the group titles.
2016 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2017 LayoutItemNotebook DTO.
2018 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2019 DTO for Notebooks. It's just an empty class for now but we might need
2020 it to transfer some specific information in the future.
2022 2011-10-21 Ben Konrath <ben@bagu.org>
2024 Add navigation buttons to related list tables.
2026 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2027 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2028 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2029 method getSuitableRecordToViewDetails() for getting the table name
2030 and primary key value for related list navigation buttons.
2031 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2032 private cell renderer class to get the navigation information for
2033 related list tables from the server. Extract the navigation
2034 processing code from the details cell navigation and use it for the
2035 related list navigation as well.
2036 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2037 cell renderer class for the details open buttons. This was needed
2038 because the related list navigation buttons and the list view
2039 navigation buttons need to react differently when clicked.
2040 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2041 the onEnterKeyDown() method because it's now overriden in the
2042 subclasses that are specific to the related list tables and the list
2044 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2045 the vertical size a little because the buttons add a bit of vertical
2046 space to table. This is not a perfect solution because the vertical
2047 size of with table fewer than 5 rows will be a little smaller.
2048 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2049 changes in how navigation buttons are handled.
2050 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2051 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2052 database access object.
2053 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2054 to find the portal for a given relationship name from
2055 RelatedListDBAccess. Add method to find a primary key field for a
2057 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2058 Move code to find the portal for a given relationship name to
2060 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2061 New file: database access object for getting the related list
2062 navigation information (the table name and the primary key value).
2063 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2064 DTO for transferring a table name to navigate to and a primary key
2066 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2067 boolean and getter/setter to specifies if the related list should add
2070 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2072 Use the master branch of java-libglom
2074 * pom.xml: Depend on java-libglom 1.19 instead.
2076 This is the master branch. See also the libglom-1-18 branch.
2078 2011-10-11 Ben Konrath <ben@bagu.org>
2080 Enable the open navigation button when the data has been set.
2082 This avoids having active buttons that don't do anything when the data
2085 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2087 2011-10-11 Ben Konrath <ben@bagu.org>
2089 Use IsWidget interface for FlowTableItem.
2091 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2092 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2094 2011-10-11 Ben Konrath <ben@bagu.org>
2096 Remove GWT styling from open button in details view.
2098 There are still some issues with how the details cell is arranged but
2099 this should be made to match Glom 1.20. I'm going to leave fixing this
2100 until I have Glom 1.20 up and running.
2102 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2103 style name on open button.
2104 * src/main/webapp/style.css: Move and edit details-navigation class.
2105 Re-arrange some classes to make them appear in the same order as the
2108 2011-10-07 Ben Konrath <ben@bagu.org>
2110 Update to GWT 2.4.0.
2112 * .gitignore: Ignore new cache directory.
2113 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2114 * pom.xml: Change GWT and maven plugin to 2.4.0.
2115 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2117 * src/main/java/org/glom/web/client/ClientFactory.java:
2118 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2119 * src/main/java/org/glom/web/client/OnlineGlom.java:
2120 Update source for API changes.
2121 * utils/build-onlineglom-war.sh: Remove cache directory before the
2124 2011-10-07 Ben Konrath <ben@bagu.org>
2126 Add navigation buttons in the details view.
2128 This isn't finished but I thought I'd commit what I have as it's a
2129 pretty good start. I still need to:
2131 1. Change the style so that it fits better into the current theme
2132 2. Adjust the details cell to expand as much as possible.
2134 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2135 click handlers to navigation buttons in the DetailsCells. Create a
2136 refreshData() method to get just the data from the server without the
2138 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2139 Update the tableSelector and browser title when the table name
2140 changes without using the tableSelector.
2141 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2142 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2143 getDetailsCells() to getCells(). Update variable names.
2144 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2145 method to set click handler on navigation button. Rename a few
2146 variables. Add navigation buttons where needed.
2147 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2148 variables and methods.
2149 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2150 navigation boolean and navigation table as required in the
2151 LayoutItemField DTO.
2152 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2153 variables for navigation along with getter/setter methods.
2155 2011-10-07 Ben Konrath <ben@bagu.org>
2157 Rename Field to DetailsCell.
2159 This is a refactor-only commit. No functionality has been added or
2162 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2163 Update variable and method names.
2164 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2165 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2166 variable and method names.
2167 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2169 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2170 variable and method names.
2172 2011-10-07 Ben Konrath <ben@bagu.org>
2174 Create separate methods for layout and data the details view.
2176 This is a refactor-only commit. No functionality has been added or
2179 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2180 private methods: setData(), createLayout().
2182 2011-10-07 Ben Konrath <ben@bagu.org>
2184 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2186 This is part of a change to get navigation buttons in the details view
2187 but it should have been done this way from the start.
2189 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2190 for method name change in TableSelectionView.
2191 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2192 Create TableChangeEvent and set the browser title using the
2193 TableSelectionView API.
2194 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2195 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2196 Change getSelectedTable() to getSelectedTableName(). Add
2197 getSelectedTableTitle().
2199 2011-10-07 Ben Konrath <ben@bagu.org>
2201 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2203 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2205 2011-10-07 Ben Konrath <ben@bagu.org>
2207 Update TableChangeEvent to use newTableName naming convention.
2209 This makes the class more consistent with GWT naming conventions.
2211 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2212 Update for method name change in TableChangeEvent.
2213 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2214 for method name change in TableChangeEvent.
2215 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2216 newTableName variable and getter method. Make toDebugString()
2219 2011-09-30 Ben Konrath <ben@bagu.org>
2221 Disable the pager in the list tables when the data row count is less than the minimum.
2223 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2224 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2226 2011-09-30 Ben Konrath <ben@bagu.org>
2228 Add empty rows to the end of related list and list view tables.
2230 I also extracted the cell rendering classes from the ListTable because
2231 the code was becoming a little crazy with all the anonymous inner
2232 classes. My plan is to use these cell rendering classes in the details
2233 view as well so this refactor will be needed for that change.
2235 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2236 set the row count in related list tables if the data has more rows
2237 than the minimum number of rows visible.
2238 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2239 row count in list view tables if the data has more rows than the
2240 minimum number of rows visible.
2241 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2242 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2244 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2245 for rendering TYPE_NUMERIC cells. The code was extracted from the
2247 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2248 class for rendering cells with buttons in list views. The code was
2249 extracted from the ListTable class.
2250 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2251 for rendering TYPE_TEXT cells. The code was extracted from the
2253 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2254 Add empty rows to the end of the data if required. Implement
2255 ListTable.getMinNumVisibleRows().
2256 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2257 cell renderer code to public classes. Return null in
2258 Column.getValue() for empty rows. Add new abstract method:
2259 getMinNumVisibleRows(). Move code to set the row count of the list view
2260 table to ListViewImpl.
2261 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2262 empty rows to the end of the data if required. Implement
2263 ListTable.getMinNumVisibleRows().
2266 2011-09-27 Ben Konrath <ben@bagu.org>
2268 Use GWT.log for client-side debugging statements.
2270 These are optimized out when deployed so I should have used this method
2271 in the first place. These statements will eventually be replaced with some sort
2272 of notification in the browser.
2274 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2275 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2276 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2277 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2278 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2280 2011-09-27 Ben Konrath <ben@bagu.org>
2282 Put tableselector on the right, back to list link on right.
2284 The idea is that the table selector is acting like a label for the
2285 currently displayed table so it should be placed below the document title. This
2286 puts the table title in a similar position to where it is in Glom.
2288 * mockups/details-contacts.html:
2289 * mockups/details-projects.html:
2290 * mockups/listview-contacts.html:
2291 * mockups/listview-projects.html:
2292 * mockups/style.css:
2293 Update mockups to match how the interfaces currently look.
2294 * src/main/webapp/style.css: Swap positions of backlink with the table
2295 selector. Add some space on the left side of the table selector to
2296 line things up with the document title.
2298 2011-09-27 Ben Konrath <ben@bagu.org>
2300 Add field colouring to details view.
2302 This change re-works how field colouring works. The colour formatting
2303 information is now set to the client with the layout information instead of
2304 with the data. This eliminates the need to send the same colour strings for
2305 data in list view column when colour information is set.
2307 In order to set an alternate colour for negative numeric values, the
2308 number is now sent to client and formatted with the GWT NumberFormat class.
2310 This change also fixes:
2312 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2314 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2315 internationalization framework which is needed for client side numeric
2317 * src/main/java/org/glom/web/client/Utils.java: New file for some
2318 client static utility methods.
2319 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2320 the DataItem object to the Field class. Use a utility method to
2321 create the foreignKeyValue string.
2322 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2323 alignment and text colours in the constructor. Add setData(DataItem)
2324 method. Remove setText(String) method.
2325 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2326 colour information to GlomTextCell. Create and use GlomNumberCell for
2327 rendering numbers. Use utility method to get the string for the
2328 primary key of the key provider. Re-work how the horizontal alignment
2330 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2331 formatting to layout information. Methods for converting the libglom
2332 formatting information were moved from DBAccess.
2333 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2334 numeric formatting (it's now done on the client side). Don't set text
2335 colours in DataItem. Move libglom formatting conversion methods to
2337 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2338 getters/setters for text colour information.
2339 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2340 for transferring the libglom NumericFormat information to the client.
2341 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2342 and getters/setters for: GlomNumericFormat, background colour and
2343 foreground colour strings.
2345 2011-09-26 Ben Konrath <ben@bagu.org>
2347 Simplify code that iterates through the LayoutGroup.
2349 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2351 2011-09-26 Ben Konrath <ben@bagu.org>
2353 Accept Eclipse formatting for OnlineGlomServiceAsync.
2355 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2357 2011-09-26 Ben Konrath <ben@bagu.org>
2359 Don't use the ListDBAccess classes to get the primary key layout information.
2361 This was causing a bug where the wrong index for the hidden primary key
2362 was being sent to the client.
2364 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2365 primary key while creating the LayoutGroup DTO. Create a
2366 LayoutItemField DTO for hidden primary keys. Don't use the
2367 RelatedListDBAccess because it was only used for getting the primary
2369 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2370 access modifier from public to protected for getPrimaryKeyField() and
2371 getPrimaryKeyLayoutItemField().
2372 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2373 abstract method getExpectedResultSize() because RelatedListDBAccess
2374 doesn't have enough info to implement it.
2375 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2376 Remove @Override for getExpectedResultSize().
2377 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2378 Remove method getExpectedResultSize().
2380 2011-09-23 Ben Konrath <ben@bagu.org>
2382 Log which layout (list or details) the ignored item is from.
2384 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2386 2011-09-23 Ben Konrath <ben@bagu.org>
2388 Remove annotations that turn off code formatting in DataItem.
2390 * src/main/java/org/glom/web/shared/DataItem.java:
2392 2011-09-23 Ben Konrath <ben@bagu.org>
2394 Rename GlomField to DataItem and update associated methods.
2396 This is a rename-only refactor. No functionality has been added or
2399 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2400 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2401 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2402 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2403 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2404 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2405 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2406 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2407 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2408 * src/main/java/org/glom/web/server/database/DBAccess.java:
2409 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2410 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2411 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2412 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2413 * src/main/java/org/glom/web/shared/DataItem.java:
2414 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2415 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2417 2011-09-23 Ben Konrath <ben@bagu.org>
2419 Rename GlomDocument to DocumentInfo and update associated methods.
2421 This is a rename-only refactor. No functionality has been added or
2424 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2425 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2426 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2427 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2428 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2430 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2432 2011-09-20 Ben Konrath <ben@bagu.org>
2434 Require java-libglom 1.17.3.
2436 This picks up the fix for the seg fault problem with the Scenes table
2437 in the Openismus Film Manager example.
2441 2011-09-20 Ben Konrath <ben@bagu.org>
2443 Change the way sort clause is added for primary key when no sort clause is requested.
2445 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2446 before the sort clause is created. When a sort clause is not requested, the
2447 sort clause is created by finding the primary key in the LayoutFieldVector
2450 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2452 2011-09-20 Ben Konrath <ben@bagu.org>
2454 Log error message if no documents are found in the configured directory.
2456 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2457 Extract the glom file extension string to a private static final class
2458 variable (mostly as syntactic sugar). Accept a minor formatting change.
2459 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2460 the example glom.document.directory configuration property to make it
2461 more clear that it can any directory, not just the home directory.
2463 2011-09-18 Ben Konrath <ben@bagu.org>
2465 Add related lists to details view.
2467 The related list table has support for paging and sorting just like the
2468 table in the list view.
2470 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2471 SQL queries for the related list tables.
2472 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2473 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2474 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2475 Rename getList methods to getListView and add comments. Remove
2476 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2477 it being unused. Add methods: getDetailsLayoutAndData(),
2478 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2479 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2480 Create the layout and set the data for the fields in one async call
2481 instead of two. Create related lists where appropriate.
2482 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2483 for method name changes in OnlineGlomService.
2484 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2485 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2486 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2488 * src/main/java/org/glom/web/client/ui/ListView.java:
2489 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2490 tableName from setCellTable(). Create a ListViewTable instead of
2492 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2493 represent a data field in the details view.
2494 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2495 from addDetailsCell() to Field class. Keep track of the Fields and
2496 Portals in the details view.
2497 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2498 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2499 and add a method to get it. Add method to set the contents of the
2501 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2502 New class for related list tables. This class has the data provider
2503 for the related list table.
2504 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2505 abstract class which is the base class for the ListViewTable and the
2507 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2508 New class for list view tables. This class has the data provider for
2509 the list view table.
2510 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2511 methods for related list tables. Add more information to the
2512 LayoutItemField and LayoutItemPortal DTOs.
2513 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2514 Remove debugging print statement.
2515 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2516 Remove debugging print statements. Add primary key field to SQL count
2518 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2519 Remove unnecessary LayoutFieldVector parameter from
2520 getResultSizeOfSQLQuery() method.
2521 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2522 New class for related list table database access.
2523 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2524 class that is a wrapper DTO for details view layout and data.
2525 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2526 new 'fromField' string to this DTO.
2527 * src/main/webapp/style.css: Remove bottom margin and override top
2530 2011-09-15 Ben Konrath <ben@bagu.org>
2532 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2534 This sets things up to make it easier to add the data retrieval for
2535 related lists (portals). No user noticeable changes were made with
2538 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2539 class has the code to retrieve the layouts and access the
2540 database using the new database helper classes.
2541 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2542 Most of the functionality has been removed from this class. This
2543 class now represents the public interface for the client side
2544 code. It also deals with configuring the servlet and cleaning
2545 things up when the servlet is stopped.
2546 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2547 of static methods into this utility class.
2548 * src/main/java/org/glom/web/server/database/DBAccess.java:
2549 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2550 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2551 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2552 These classes have the database retrieval code. The class hierarchy
2553 has been setup to make it easy to reuse code for similar
2556 2011-09-06 Ben Konrath <ben@bagu.org>
2558 Create separate classes for list table code and the data provider.
2560 As part of this refactor, I also split up the code a bit to make it
2563 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2564 table code to two new classes (below).
2565 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2566 with code from ListViewImpl.
2567 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2568 New file with code from ListViewImpl.
2570 2011-09-06 Ben Konrath <ben@bagu.org>
2572 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2574 This fixes the LayoutItemPortal DTO to match the libglom layout object
2577 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2579 2011-09-01 Ben Konrath <ben@bagu.org>
2581 Set title of Portals in the Details View.
2583 * pom.xml: Bump required version of java-libglom to 1.17.1.
2584 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2585 widget creation to its own class. Add comments to constructor.
2586 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2587 The code is mostly from the Group class with the title now set.
2588 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2589 title of Portal. Update some comments. Fix some code formatting.
2591 2011-09-01 Ben Konrath <ben@bagu.org>
2593 Remove TODO comment for the flow table column width.
2595 The flow table column width is working correctly and doesn't need to be
2596 changed. See this mailing list post for more info:
2598 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2600 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2602 2011-08-27 Ben Konrath <ben@bagu.org>
2604 Add document title (database name) to top of the browser page.
2606 I added the document title to the TableSelecitonView but that will
2607 change if / when we add a view that doesn't require table selection.
2609 * mockups/details-contacts.html:
2610 * mockups/details-projects.html:
2611 * mockups/listview-contacts.html:
2612 * mockups/listview-projects.html:
2613 * mockups/style.css: Add document title to mockups to keep things
2615 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2616 sizes to account for the document title.
2617 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2618 Set the document title when it has been retrieved from the server.
2619 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2620 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2621 and implement setDocumentTitle(String) method.
2622 * src/main/webapp/style.css: Add ID for document title style.
2624 2011-08-25 Ben Konrath <ben@bagu.org>
2626 Add NavigationType enum to LayoutItemPortal DTO.
2628 This is the start of adding support for Portals to the Details View.
2630 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2631 LayoutItem_Portal.navigation_type enum from libglom to
2632 LayoutItemPortal.NavigationType enum.
2633 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2634 NavigationType enum, field for storing the NavigationType and getter
2637 2011-08-25 Ben Konrath <ben@bagu.org>
2639 Implement the flow table layout in the Details View.
2641 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2642 FlowTable to Group to account for the renamed class.
2643 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2644 File. This is a container widget that implements the Glom details view
2645 flow table behaviour.
2646 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2647 org/glom/web/client/ui/FlowTable.java.
2648 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2649 so that the size of the subgroups are a closer match to the size of
2650 the Glom subgroups. This makes the flowtable layout match the layout
2651 in Glom for the Music Collection example file.
2653 2011-08-16 Ben Konrath <ben@bagu.org>
2655 Create container element for LayoutItemPortal in Details View.
2657 This will help me develop the layout for the FlowTable.
2659 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2660 fieldPanel variable to detailsCell.
2662 2011-08-15 Ben Konrath <ben@bagu.org>
2664 Set the height of the data element in the Details View.
2666 I changed the InlineLabels (text in a span element) to Labels (text in
2667 a div element) so that I could set the height of the details-data
2668 elements instead of the details-cell parent elements. This allows the
2669 the details-data element to display the correct height if style is
2670 applied that shows the height.
2672 This change has the added benefit of allowing the order of the labels
2673 and data elements to be changed for right-to-left languages.
2675 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2676 InlineLabels to Labels.
2677 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2678 InlineLabels to Labels. Set the height of the data element.
2679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2680 multiline text height in the Formatting DTO.
2681 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2682 for multiline height along with getter and setter methods.
2683 * src/main/webapp/style.css: Adjust style to account for the change
2684 from span elements to div elements in the details cell.
2686 2011-08-15 Ben Konrath <ben@bagu.org>
2688 Make the List View appearance match the mockups.
2690 It doesn't match exactly but it's much better than it was.
2692 * mockups/listview-contacts.html: Remove unused css classes.
2693 * mockups/listview-projects.html: Remove unused css classes.
2694 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2695 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2696 for mainPanel instead of VerticalPanel (table). Set style name on
2697 CellTable. Set style name on Details column. Right-align Details
2699 * src/main/webapp/style.css: Adjust properties to match the mockups.
2701 2011-08-12 Ben Konrath <ben@bagu.org>
2703 Add better support for subgroups in the details view.
2705 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2706 changed FlowTable constructor.
2707 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2708 support for subgroups and subgroup-titles.
2709 * src/main/webapp/style.css: Add CSS class for subgroups and
2712 2011-08-12 Ben Konrath <ben@bagu.org>
2714 Return the top level LayoutGroup title.
2716 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2718 2011-08-11 Ben Konrath <ben@bagu.org>
2720 Make the TableSelector header match the mockup.
2722 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2723 the layout panel. Properly lineup the table selection header with
2724 the list and details view.
2725 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2726 margin around the details view.
2727 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2728 Rename listBox variable to tableSelector. Set id for the style sheet.
2729 Use a FlowPanel instead of a HorizontalPanel.
2730 * src/main/webapp/style.css: Add properties to make the TableSelector
2731 box match the mockups.
2733 2011-07-13 Ben Konrath <ben@bagu.org>
2735 Update install script for java-libglom version change.
2737 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2740 2011-07-13 Ben Konrath <ben@bagu.org>
2742 Add support sub-group in the details view.
2744 I also removed the code that special-cased the default details view
2747 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2749 I still have to make a proper flowtable.
2751 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2752 Don't special-case default details view layout.
2753 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2754 addLayoutField() as I'm going to use it.
2755 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2756 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2758 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2759 extracted from DetailsViewImpl.GroupPanel. Add support for
2761 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2762 column count when getting the details layout.
2764 2011-07-12 Ben Konrath <ben@bagu.org>
2766 Set browser title with database and table titles.
2768 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2769 Set the browser title when the table changes and when the activity
2771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2772 title when retrieving document info (the GlomDocument object).
2773 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2774 with getter and setter methods. Remove unused convenience constructor.
2775 Use default code formatting.
2777 2011-07-12 Ben Konrath <ben@bagu.org>
2779 Ignore LayoutItemPortals in the details view.
2781 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2784 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2785 LayoutItemPortal layout objects.
2786 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2787 LayoutItemPortal objects when retrieving the details layout.
2788 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2789 file. This is an empty class and just used to get type information for
2792 2011-07-12 Ben Konrath <ben@bagu.org>
2794 Use java-libglom 1.17.0.
2798 2011-07-11 Ben Konrath <ben@bagu.org>
2800 Remove "Table:" label from table selector.
2802 This matches a recent change in the Glom UI.
2804 * mockups/details-contacts.html:
2805 * mockups/details-projects.html:
2806 * mockups/listview-contacts.html:
2807 * mockups/listview-projects.html: Remove the "Table:" label from the
2809 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2811 2011-07-11 Ben Konrath <ben@bagu.org>
2813 Add main groups to the details view.
2815 This makes things look a little nicer in the details view. The next step
2816 is to implement the flowtable.
2818 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2819 resources from the standard gwt css theme. Standard.css is now
2820 included in OnlineGlom.html so that the online glom css rules have
2821 precedence over the gwt theme.
2822 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2823 the whole LayoutGroup to the DetailsView instead of just the titles.
2824 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2825 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2826 details layout with a helper class (GroupPanel). I might extract this
2827 class when I make the full flowtable.
2828 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2829 string as default so I don't have to worry about NPEs when processing
2831 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2832 note beside OnlineGlom.gwt.xml above).
2833 * src/main/webapp/style.css: Add default font-size to body to override
2834 the font-size set by the standard theme. Don't use h2 tags for
2835 group-title. Create new details-cell class.
2837 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2839 ConfiguredDocument: Set the port number too.
2841 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2842 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2843 Glom document. Presumably this worked sometimes so far because there is a
2844 default port number.
2846 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2848 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2850 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2851 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2852 correct, though we should throw an exception too.
2854 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2856 Fix a addDocuemnt typo.
2858 * src/main/java/org/glom/web/shared/Documents.java
2859 (Documents.addDocuemnt): Rename to addDocument().
2860 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2861 (OnlineGlomServiceImpl.getDocuments): Adapt.
2863 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2865 Slightly improved log output when connection fails.
2867 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2868 (ConfiguredDocument.setUsernameAndPassword):
2869 We don't know for sure if it' the username/password that's wrong, so
2870 rephrase the message.
2871 Also ouput the exception message, though it's generic in this case.
2873 2011-07-08 Ben Konrath <ben@bagu.org>
2877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2878 added braces to a one line if statement because the Eclipse formatter
2879 was getting confused.
2881 2011-07-07 Ben Konrath <ben@bagu.org>
2883 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2885 These should really be two separate tasks but I counldn't get things to
2886 work with GWT 2.2.0 and Eclipse 3.7.
2890 * .settings/org.eclipse.jdt.core.prefs:
2891 * .settings/org.eclipse.jdt.ui.prefs:
2892 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2893 * .settings/org.eclipse.m2e.core.prefs:
2894 Add new config files. Update current files. Remove references to the
2895 webtools plugins as we're not using any of the webtools features.
2896 * .gitignore: Add logs directory which is created when running with
2898 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2899 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2900 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2902 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2904 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2906 onlineglom.properties: Add explanatory comments.
2908 * src/main/resources/onlineglom.properties: Also change the default user
2909 from ben to someuser, to avoid the risk of people thinking we just
2910 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2912 2011-06-28 Ben Konrath <ben@bagu.org>
2914 Use filename in Log for incorrect passwords.
2916 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2917 getFileName(String) method to get the filename from the URI.
2919 2011-06-28 Ben Konrath <ben@bagu.org>
2921 Add the table name to the URL token for the ListPlace.
2923 This makes things consistent between the DetailsPlace and the
2924 ListPlace. It also allows the the ListPlace to be bookmarked.
2926 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2927 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2928 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2929 Remove getDefaultListLayout(). The default layout is now returned
2930 by the getListLayout() method when the table name is an empty string.
2931 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2932 Add table name field. Change to a new ListPlace when the table
2933 has been changed. Use getListLayout() for getting the default
2935 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2936 Add table name field. Set the correct table name in the list box
2937 when loading from bookmark. This corrects a problem for the
2939 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2940 Move table name to super-class (HasSelectableTable). Move document
2941 and table URL keys to super-class in HasSelectableTable.
2942 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2943 Add table name field. Add Tokenizer class with URL key common to
2944 the subclasses (DetailsPlace and ListPlace).
2945 * src/main/java/org/glom/web/client/place/ListPlace.java:
2946 Add table name. Add code to parse the URL token.
2947 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2948 Update ListPlace construction with empty table name string.
2949 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2950 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2951 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2952 Update ListPlace construction with table name string.
2953 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2954 Change defaultTableName field to tableName to reflect how it's now
2955 used. Update the getter and setter methods.
2957 2011-06-28 Ben Konrath <ben@bagu.org>
2959 Enable the table selector in the DetailsView.
2961 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2962 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2963 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2964 Remove getDefaultDetailsLayout(). The default layout is now returned
2965 by the getDetailsLayout() method when the table name is an empty
2967 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2968 event handler for table change event. Change to using
2969 getDetailsLayout() for the default details layout.
2970 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2972 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2973 when navigating to the details place.
2975 2011-06-27 Ben Konrath <ben@bagu.org>
2977 Use filename based unique document ID in URL and for RPC.
2979 The document ID is the glom document name with spaces (' ') replaced
2980 with pluses ('+') and without the .glom extension.
2982 This change is mostly a string substitution of 'documentTitle' for
2983 'documentID'. The only code change is the addition of a Documents DTO to get the
2984 filename to document title mappings as indicated below.
2986 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2987 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2988 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2989 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2990 Use Documents DTO to create the document links in the document
2992 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2993 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2994 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2995 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2996 * src/main/java/org/glom/web/client/place/ListPlace.java:
2997 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2998 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2999 * src/main/java/org/glom/web/client/ui/ListView.java:
3000 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3001 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3002 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3003 * src/main/java/org/glom/web/server/Log.java:
3004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3005 getDocumentTitles() to getDocuments() and return the Documents DTO.
3006 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3007 transferring the filename to document title mappings.
3009 2011-06-25 Ben Konrath <ben@bagu.org>
3011 Make the authentication popup work again.
3013 This bug was introduced when I extracted ConfiguredDocument to its own class.
3015 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3016 correct success / fail status in setUsernameAndPassword().
3018 2011-06-25 Ben Konrath <ben@bagu.org>
3020 Use filename as unique key for configuring database usernames and passwords.
3022 This replaces the use of the Glom document title which could change
3023 depending on the locale. Thanks to Murray Cumming for pointing out this
3026 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3027 * src/main/resources/onlineglom.properties:
3029 2011-06-24 Ben Konrath <ben@bagu.org>
3031 Pass primary key value to DetailsView.
3033 This enables the DetailsView to load the correct data.
3035 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3036 primary key value field and set in constructor. Pass primary key
3037 value to getDetailsData().
3038 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3039 variables for document title and primary key value.
3040 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3041 key value to the DetailsPlace.
3043 2011-06-24 Ben Konrath <ben@bagu.org>
3045 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3047 This allows the primary key to be retrieved by the Details button. This
3048 functionality has not been implemented yet but it's in the works.
3050 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3051 the LayoutGroup result to ListView.setCellTable instead of all of its
3052 fields individually.
3053 * src/main/java/org/glom/web/client/ui/ListView.java:
3054 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3055 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3056 get the primary key for the table.
3057 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3058 index of the primary key in the LayoutGroup accounting for hidden
3059 primary keys. Rename getJavaNumberFormat() to
3060 convertToJavaNumberFormat() for consistency. Cleanup / add some
3062 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3063 field for primary key index and a field to indicate whether the
3064 primary key is hidden or not.
3066 2011-06-23 Ben Konrath <ben@bagu.org>
3068 Rename getTableData methods to getListData.
3070 This is a rename refactor for consistency with other methods.
3072 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3073 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3074 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3077 2011-06-23 Ben Konrath <ben@bagu.org>
3079 Extract the ConfiguredDocument innerclass into its own class.
3081 This makes the servlet code more object oriented.
3083 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3084 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3085 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3086 new ConfiguredDocument class.
3088 2011-06-21 Ben Konrath <ben@bagu.org>
3090 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3092 This makes things more inline with how libglom works and reduces code
3093 duplication. This refactor lays the groundwork for adding the primary key to
3094 the LayoutGroup object.
3096 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3097 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3099 Change method names to getListLayout and getDefaultListLayout for
3100 consistency. Use LayoutGroup as the DTO for the list layout instead of
3101 ColumnInfo and LayoutListTable.
3102 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3103 new method names along with the LayoutGroup object for transferring the
3105 * src/main/java/org/glom/web/client/ui/ListView.java:
3106 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3107 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3108 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3110 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3111 Replaced with LayoutGroup.
3112 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3113 expectedResultSize and defaultTableName fields which are needed for
3115 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3116 type field which is needed for the list layout but will also be
3117 useful for the details layout as things progress.
3118 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3119 Make class abstract. Remove the unnecessary
3120 getFormattingHorizontalAlignment method. Add setFormatting method.
3122 2011-06-16 Ben Konrath <ben@bagu.org>
3124 Add scripts for building and installing war.
3126 These will help when updating OnlineGlom but they're also good
3127 supplemental documentation of the build and deployment proceeding.
3129 * utils/build-onlineglom-war.sh: New file.
3130 * utils/install-onlineglom-war.sh: New file.
3132 2011-06-16 Ben Konrath <ben@bagu.org>
3134 Create wrapper class to create consistent log messages.
3136 I wrapped methods in the Log class of gwt-log to add the method names
3137 from the servlet and create consistent formatting of the document title
3138 and table names in the log messages.
3140 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3141 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3142 log methods to use methods from wrapped Log class.
3144 2011-06-16 Ben Konrath <ben@bagu.org>
3146 Remove superfluous conditional return.
3148 Thanks to Murray Cumming for pointing this out!
3150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3152 2011-06-15 Ben Konrath <ben@bagu.org>
3154 Return an ArrayList of LayoutGroups for the Details layout.
3156 This corrects a problem with the details layout as it can have more
3157 than one top level LayoutGroup.
3159 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3160 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
3161 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
3162 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
3163 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
3164 with ArrayList of LayoutGroups for the details view layout.
3165 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3166 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
3167 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
3168 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
3169 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
3170 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
3172 2011-06-14 Ben Konrath <ben@bagu.org>
3174 Use cast_dynamic method to determine the libglom LayoutItem type.
3176 This is better than finding the LayoutItem type by using the string
3177 returned from the get_part_type_name() method.
3179 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3181 2011-06-14 Ben Konrath <ben@bagu.org>
3183 Add method names to log entries in the servlet.
3185 This helps when tracking down deployment problems.
3187 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3189 2011-06-14 Ben Konrath <ben@bagu.org>
3191 Add data to the DetailsView using a hard-coded primary key value.
3193 The layout and functionality of the DetailsView is not complete. This
3194 is just a checkpoint so the patch doesn't get too big.
3196 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3197 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3198 Add getDetailsData() servlet method.
3199 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3200 Add RPC to getDetailsData(). Change the way the LayoutGroups and
3201 LayoutFields are added to the DetailsView.
3202 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3203 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3204 Add setData() method. Change addLayoutGroup() and addLayoutField() to
3205 take the string for the title instead of the object.
3206 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3207 Add implementation getDetailsData() along with some private helper
3209 * src/main/webapp/style.css: Add padding to details-data class. Add a
3210 details-label class with the same padding as the details-data class.
3212 2011-06-03 Ben Konrath <ben@bagu.org>
3214 Use presenter.goTo() to change to the DetailsPlace.
3216 This will make things easier when we need to open the DetailsView with
3217 data specific to the row that was clicked.
3219 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3221 2011-06-02 Ben Konrath <ben@bagu.org>
3223 Add CSS file from mockups.
3225 I'm adding this now because it's going to be useful to have when
3226 developing the DetailsView. The TableSelectionView and ListView aren't
3229 * src/main/webapp/OnlineGlom.html:
3230 * src/main/webapp/style.css:
3232 2011-06-02 Ben Konrath <ben@bagu.org>
3234 Use String.isEmpty() to check for empty string.
3236 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3238 2011-06-02 Ben Konrath <ben@bagu.org>
3240 Display main layout group titles in the DetailsView.
3242 This is the start of the DetailsActivity/DetailsView implementation.
3244 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3245 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: