1 2012-04-19 Murray Cumming <murrayc@murrayc.com>
3 ReportGenerator: Specify date and time formats.
5 * src/main/java/org/glom/web/server/ReportGenerator.java:
6 createFieldValueElement(): Use the default (and localized)
7 short formats, though we still need a way to show 4-digit
8 years without providing the format for every locale.
9 * src/main/java/org/glom/web/server/database/DBAccess.java:
10 convertResultSetToDTO(): Use the short formats here too.
12 2012-04-18 Murray Cumming <murrayc@murrayc.com>
14 ReportGenerator: Use the correct numeric formatting.
16 * src/main/java/org/glom/web/server/ReportGenerator.java
17 createFieldExpression(), createFieldValueElement(): Take the
18 whole LayoutItem_Field instead of just the field name, so
19 we have access to the formatting.
20 createFieldValueElement(): Use JRTextField.setPattern() to
21 specify the numeric formatting, with the help of a
22 regular DecimalFormat.
24 2012-04-18 Murray Cumming <murrayc@murrayc.com>
26 ReportGenerator: Avoid showing null for group by titles.
28 * src/main/java/org/glom/web/server/ReportGenerator.java
29 generateReport(): Use setBlankWhenNull() on the field title
30 style too, because this is used for values in group by
33 2012-04-18 Murray Cumming <murrayc@murrayc.com>
35 ReportGenerator: Add a colon to titles in vertical groups.
37 * src/main/java/org/glom/web/server/ReportGenerator.java
38 addFieldToDetailBandVertical(): Pass true for the withColon
41 2012-04-18 Murray Cumming <murrayc@murrayc.com>
43 ReportGenerator: Simplify the code by using Position more.
45 2012-04-18 Murray Cumming <murrayc@murrayc.com>
47 Reports: Support vertical groups, roughly.
49 * src/main/java/org/glom/web/server/ReportGenerator.java:
50 addToReport(): Rename to addGroupToReport() and, if necessary,
51 call the new addVerticalGroupToReport() method.
52 createFieldValueElement(): Let the caller specify the Y position
55 2012-04-17 Murray Cumming <murrayc@murrayc.com>
57 Reports: Allow a second report to be shown.
59 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
60 clear(): Do not remove the HTML widget, which broke the whole layout.
62 2012-04-17 Murray Cumming <murrayc@murrayc.com>
64 Locales drop-down: Show that we use English by default.
66 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
67 fillView(): When we use English, just because that is the default, when
68 no locale is specified, show that in the Locales drop-down instead of
69 just showing the first item.
71 2012-04-17 Murray Cumming <murrayc@murrayc.com>
73 Unselect the Report/Locale/Table combo item when appropriate.
75 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
76 setPlace(): clear reportName if this is not a ReportPlace.
77 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
78 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
79 When the provided name is empty, unselect all items, so that none are
80 indicated. This uses a for loop because I cannot find a single method
83 2012-04-17 Murray Cumming <murrayc@murrayc.com>
85 Report: Give the user a way to get back to the list.
87 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
88 start(), setPlace(): Show the Back To List link on reports, and also
89 interpret selecting the empty report item as back to list.
91 2012-04-17 Murray Cumming <murrayc@murrayc.com>
93 Style: Remove overflow:hidden from searchbox
95 * src/main/webapp/style.css: Because this pushes the Back To Link
96 label/link on to the next row, which is then hidden due to the
97 hard-coded (in ems) height.
99 2012-04-13 Murray Cumming <murrayc@murrayc.com>
101 Really show the selected Report name.
103 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
104 setPlace(): Store the reportName here, if it is that kind of Place.
105 fillView(): Set the selected Report after filling the list of reports.
106 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
107 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
108 null Strings, though we need some way to unselect all ListBox items
111 2012-04-13 Murray Cumming <murrayc@murrayc.com>
113 ReportGenerator: Try to avoid some problems.
115 * src/main/java/org/glom/web/server/ReportGenerator.java
116 addField(): Try to avoid duplicates, and avoid using a null
119 2012-04-13 Murray Cumming <murrayc@murrayc.com>
121 Reports: Use quickFind.
123 * src/main/java/org/glom/web/client/OnlineGlomService.java;
124 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
126 getReportHTML(): Add a quickFind parameter.
127 * src/main/java/org/glom/web/client/activity/ReportActivity.java
128 start(): Pass the quickFind parameter.
129 * src/main/java/org/glom/web/server/ReportGenerator.java
130 generateReport(): Take a quickFind parameter.
132 2012-04-13 Murray Cumming <murrayc@murrayc.com>
134 ReportPlace: Actually use the report name.
136 * src/main/java/org/glom/web/client/place/ReportPlace.java
137 getPlace(): Do not assign the report name to the quickfind.
139 2012-04-13 Murray Cumming <murrayc@murrayc.com>
141 Show java.library.path when complaining.
143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
144 init(): When telling us to check java.library.path, show the
147 2012-04-12 Murray Cumming <murrayc@murrayc.com>
149 Adapt to the java-libglom 1.21.8 API.
151 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
152 java-libglom's FieldFormatting is now Formatting.
154 2012-04-12 Murray Cumming <murrayc@murrayc.com>
156 Use the latest java-libglom version.
158 * pom.xml: Use java-libglom 1.21.8.
160 2012-03-15 Murray Cumming <murrayc@murrayc.com>
162 Adapt to the java-libglom 1.21.7 API.
164 * src/main/java/org/glom/web/server/ReportGenerator.java:
165 addToReport(): get_group_secondary_fields() is now
166 get_secondary_fields().
168 2012-03-15 Murray Cumming <murrayc@murrayc.com>
170 Use the latest java-libglom version.
172 * pom.xml: Use java-libglom 1.21.7.
174 2012-03-06 Murray Cumming <murrayc@murrayc.com>
176 ReportGenerator: Do not show nulls.
178 2012-03-06 Murray Cumming <murrayc@murrayc.com>
180 ReportGenerator: Make the title font larger.
182 2012-03-06 Murray Cumming <murrayc@murrayc.com>
184 ReportGenerator: Put field titles inside groups, if there are groups.
186 2012-03-06 Murray Cumming <murrayc@murrayc.com>
188 ReportGenerator: Take the Report itself instead of the name and group.
190 * src/main/java/org/glom/web/server/ConfiguredDocument.java
191 Remove getReportLayoutGroup().
192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
193 getReportHTML(): Pass the report instead
194 of its name and layout group.
195 * src/main/java/org/glom/web/server/ReportGenerator.java
196 generateReport(): Use the report object to use the title
199 2012-03-06 Murray Cumming <murrayc@murrayc.com>
201 ReportGenerator: Remove designBand parameters.
203 * src/main/java/org/glom/web/server/ReportGenerator.java:
204 Make designBand a class member instead of passing it to all
207 2012-03-06 Murray Cumming <murrayc@murrayc.com>
209 ReportGenerator: Add lines, a bit like in the desktop version.
211 * src/main/java/org/glom/web/server/ReportGenerator.java
212 addToReport(): Use JRDesignLine.
214 2012-03-06 Murray Cumming <murrayc@murrayc.com>
216 ReportGenerator: Correct the title positions and use some bold style.
218 * src/main/java/org/glom/web/server/ReportGenerator.java:
219 Break the code up into reusable functions, correct the placement of
220 titles, and use normal/bold styles as in the reports in the desktop
223 2012-03-06 Murray Cumming <murrayc@murrayc.com>
225 ReportGenerator: Add a header band to show the field titles.
227 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
228 getReportHTML(): Pass the localeId to the ReportGenerator
230 * src/main/java/org/glom/web/server/ReportGenerator.java
231 constructor: Take the localeID so we can get translated field
233 generateReport(), addToReport(), addFieldToBand(): Add field
234 titles in a column header band.
236 2012-03-05 Murray Cumming <murrayc@murrayc.com>
238 Reports drop-down list: Some improvement.
240 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
241 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
242 Adedd setSelectedReport(),
243 setReportList(): Add a blank line so that the user can select the
245 * src/main/java/org/glom/web/client/activity/ReportActivity.java
246 start(): Show the current report by calling setSelectedReport().
247 This does not seem to work yet.
249 2012-03-05 Murray Cumming <murrayc@murrayc.com>
251 DetailsActivity, ListActivity: Move some variables into a base class.
253 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
254 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
255 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
256 the clientFactory, documentID, tableName and authenticationPopup into
257 a base class, to avoid duplication.
259 2012-03-05 Murray Cumming <murrayc@murrayc.com>
261 Translate the Reports label.
263 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
264 Get the "Reports" label string from the constants.
265 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
266 perties: Add Reports to the constants.
268 2012-03-03 Ben Konrath <ben@bagu.org>
270 Display date and time in details view.
272 https://bugzilla.gnome.org/show_bug.cgi?id=671257
274 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
276 2012-03-05 Murray Cumming <murrayc@murrayc.com>
278 Require the latest java-libglom.
280 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
282 2012-03-05 Murray Cumming <murrayc@murrayc.com>
284 Reports: Implement grouping.
286 * src/main/java/org/glom/web/server/ReportGenerator.java:
287 Handle LayoutItem_GroupBy items and try to do the right thing
288 with JRDesignGroup. It seems to work.
290 2012-03-04 Murray Cumming <murrayc@murrayc.com>
292 Actually show some data with JasperReports.
294 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
295 getReportHTML(): Move most code into a ReportGenerator class.
296 * src/main/java/org/glom/web/server/ReportGenerator.java:
297 Recurse into sub-groups, adding fields to the JasperDesign's details
298 band. Note that we must set an arbitrary width and height, or it just
299 will not show any data.
301 2012-03-04 Murray Cumming <murrayc@murrayc.com>
303 Reports Chooser: Show the titles, not the names.
305 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
306 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
307 and the names as the values.
308 * src/main/java/org/glom/web/server/ConfiguredDocument.java
309 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
310 group now that we provide the report name, so it should always
313 2012-03-04 Murray Cumming <murrayc@murrayc.com>
315 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
317 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
318 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
319 an empty quickfind string. I also corrected libglom to create only
320 empty where clauses for empty quickfind strings, but this avoids the
323 2012-02-24 Ben Konrath <ben@bagu.org>
325 Improve the tabs in the Notebook widget.
329 2012-02-15 Murray Cumming <murrayc@murrayc.com>
331 Depend on jasperreports.
333 * pom.xml: Add the dependency. My plan is to use this on the
336 2012-01-31 Murray Cumming <murrayc@murrayc.com>
338 Implement navigation to report places.
340 * src/main/java/org/glom/web/client/activity/ReportActivity.java
341 start(): Do not bother to handle all events here.
342 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
343 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
344 Added getSelectedReport().
345 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
346 .java: start(): When handling a change to the reports chooser,
347 call getSelectedReport() and goTo() its ReportPlace.
348 * src/main/java/org/glom/web/client/ui/ReportView.java
349 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
350 Added setReportHTML() which puts the html in a gwt HTML widget.
351 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
352 getReportHTML(): Return "TODO" just to show that this works.
354 2012-01-31 Murray Cumming <murrayc@murrayc.com>
356 Make ReportPlace usable.
358 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
360 * src/main/java/org/glom/web/client/place/ReportPlace.java:
361 Correct the @prefix annotation.
363 2012-01-31 Murray Cumming <murrayc@murrayc.com>
365 OnlineGlomService: Return report HTML rather than the LayoutGroup.
367 * src/main/java/org/glom/web/client/OnlineGlomService.java:
368 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
370 Change getReportLayout() to getReportHMTL() because we will not need to
371 parse or render the report layout on the client side.
372 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
373 getReportLayout(): Return the libglom LayoutGroup type because we will
374 not need to convert to a shared type, because this will not be used on
376 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
379 Note that there is still no implementation for this.
381 2012-01-30 Murray Cumming <murrayc@murrayc.com>
383 Translations: Try to translate the strings.
385 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
386 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
387 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
388 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
389 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
390 Take the Open translation from GTK+'s .po files.
391 Take the Details translation from Glom's po files.
392 I have added the other strings to Glom so we can get translations that way:
393 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
395 2012-01-27 Murray Cumming <murrayc@murrayc.com>
397 Add a (empty) Report Place, View, and Activity.
399 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
401 * src/main/java/org/glom/web/client/place/HasTablePlace.java
402 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
403 this into a superclass:
404 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
405 and also use it as the base of this new ReportPlace:
406 * src/main/java/org/glom/web/client/place/ReportPlace.java
408 * src/main/java/org/glom/web/client/ui/ReportView.java
409 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
410 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
411 Add these, containing mostly boiler-plate for now.
413 * src/main/java/org/glom/web/client/OnlineGlomService.java
414 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
415 * src/main/java/org/glom/web/server/ConfiguredDocument.java
416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
417 Add API to get the LayoutGroup for the report.
419 2012-01-27 Murray Cumming <murrayc@murrayc.com>
421 TableSelectionViewImpl: Put the search label and entry in a div.
423 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
424 Put the search widgets in a FlowTable so that the CSS can be used to
425 style them while keeping them together.
426 * src/main/webapp/style.css: Mention the new div.
428 2012-01-27 Murray Cumming <murrayc@murrayc.com>
430 Translate more strings in more locales.
432 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
433 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
434 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
435 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
436 Translate the "Details" and "Open" string too.
438 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
439 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
440 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
441 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
442 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
443 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
444 Add these new locales as placeholders though they currently contain English.
446 2012-01-27 Murray Cumming <murrayc@murrayc.com>
448 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
450 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
451 Check the ConfiguredDocument* for null before using it.
453 2012-01-26 Murray Cumming <murrayc@murrayc.com>
455 Tell Eclipse about the generated java files.
457 * .classpath: This lets it find OnlineGlomConstants.java.
458 It would be nice if Eclipse just used the maven build files.
460 2012-01-26 Murray Cumming <murrayc@murrayc.com>
462 Prevent a crash when no locale is specified in the URL.
464 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
465 Avoid returning a null string, obtained from
466 Window.Location.getParameter(). This caused a crash when it was
467 later passed to libglom's API.
468 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
469 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
470 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
471 guard against future null strings.
473 2012-01-26 Murray Cumming <murrayc@murrayc.com>
475 Use the ?locale= query param instead of the &lang= token param.
477 * src/main/java/org/glom/web/client/place/ListPlace.java
478 * src/main/java/org/glom/web/client/place/DetailsPlace.java
479 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
480 Remove the lang token key and value.
482 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
483 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
484 When the user selects a different locale from the chooser, use
485 Window.Location.assign() to change the URL, which then causes a reload.
487 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
488 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
489 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
490 * src/main/java/org/glom/web/client/activity/ListActivity.java
491 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
492 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
493 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
494 * src/main/java/org/glom/web/client/ui/ListView.java:
495 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
497 Remove localeID member variables and method/constructor parameters, instead
498 using Utils.getCurrentLocaleID() when we need a localID to pass to
501 2012-01-26 Murray Cumming <murrayc@murrayc.com>
503 Internationalize the UI strings.
505 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
506 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
507 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
508 because it is unused. Messages are apparently strings that can have
509 parameters, but we do not need that yet, so Contants will be enough for now.
510 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
511 to say that we support the en and de locales.
512 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
513 The original English strings.
514 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
515 Some German translations of the English strings.
516 The i18n goal then uses the .properties file to generate an
517 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
518 returns an implementation that returns the translated strings.
519 The documentation suggests putting these in src/java/*/client/, but it seems
520 best to put it in src/resources/*/client/.
521 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
522 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
523 instead of hard-coding them.
524 Note that we cannot import OnlineGlomConstants because it does not exist yet,
525 but that does not seem to stop the build, though it confuses Eclipse.
527 You can see the translated string by adding ?locale=de to the URL, like so:
528 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
530 2012-01-24 Murray Cumming <murrayc@murrayc.com>
532 Improve null/empty String checks.
534 * pom.xml: Add a dependency on commons-lang, to use
535 org.apache.commons.lang.StringUtils.
536 * src/main/java/org/glom/web/server/ConfiguredDocument.java
537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
538 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
539 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
540 Use StringUtils.isEmpty().
542 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
543 StringUtils class with a static isEmpty() function because we
544 cannot use org.apache.commons.lang.StringUtils in client-side
545 GWT code because it (apparently) cannot be compiled to javascript.
546 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
547 * src/main/java/org/glom/web/client/activity/ListActivity.java
548 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
549 * src/main/java/org/glom/web/client/place/DetailsPlace.java
550 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
551 * src/main/java/org/glom/web/client/place/ListPlace.java
552 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
553 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
554 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
555 * src/main/java/org/glom/web/client/ui/details/Group.java
556 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
557 our StringUtils.isEmpty() function.
559 2012-01-24 Murray Cumming <murrayc@murrayc.com>
561 Update to the latest java-libglom API.
563 * pom.xml: Require java-libglom 1.21.4.
564 * src/main/java/org/glom/web/server/ConfiguredDocument.java
565 getDocumentInfo(), getListViewLayoutGroup():
566 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
568 * src/main/java/org/glom/web/server/database/DBAccess.java
569 getFieldsToShowForSQLQueryAddGroup(),
570 getPrimaryKeyLayoutItemField(): Replace get_database_title()
571 with either get_database_title_original() or
572 get_database_title(localeID).
574 2012-01-24 Murray Cumming <murrayc@murrayc.com>
576 ConfiguredDocument: Avoid a null pointer exception.
578 * src/main/java/org/glom/web/server/ConfiguredDocument.java
579 Initialize localeID to "" to avoid returning a null String which
580 causes a crash in java-libglom's swing-generated code.
582 2012-01-23 Murray Cumming <murrayc@murrayc.com>
584 Some simple renaming.
586 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
587 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
588 for localeChooser. This seems more appropriate and is less ambiguous
589 particularly in the .css file.
591 2012-01-23 Murray Cumming <murrayc@murrayc.com>
593 ConfiguredDocument: Rename the localedID private member variable.
595 2012-01-23 Murray Cumming <murrayc@murrayc.com>
597 Adapt to the latest java-libglom API from git master.
599 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
600 libglom now uses only Vector instead of List, which uses add() instead of
603 2012-01-23 Murray Cumming <murrayc@murrayc.com>
605 Add and fill a Reports drop-down list box.
607 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
609 * src/main/java/org/glom/web/client/OnlineGlomService.java:
610 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
611 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
612 Added getReports(document, table, localeID), calling
613 ConfiguredDocument.getReports().
614 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
615 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
616 Added setReportsList() and a list widget.
617 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
618 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
620 2012-01-22 Murray Cumming <murrayc@murrayc.com>
622 ConfiguredDocument: Rename the localedID private member variable.
624 2012-01-20 Murray Cumming <murrayc@murrayc.com>
626 Build a source tarball with mvn assembly:single
628 * assembly.xml: Add this file.
629 * pom.xml: Use the maven-assembly-plugin and tell it to use
630 our assembly.xml file.
632 2012-01-19 Murray Cumming <murrayc@murrayc.com>
634 OnlineGlomServiceImpl: Get .glom files recursively.
636 * pom.xml: Depend on commons-io from org.apache.commons.
637 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
638 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
639 files recursively, and with the easier filter for the extension.
640 Use org.apache.commons.io.FilenameUtils.removeExtension() to
641 simplify that code too.
643 2012-01-19 Murray Cumming <murrayc@murrayc.com>
645 README: Mention that you must install java-libglom packages separately.
647 But then it works, because java-libglom is now in the central maven
650 2012-01-18 Murray Cumming <murrayc@murrayc.com>
652 locales drop-down: Show the correct selected locale when the URL changes.
654 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
655 .java: setPlace(): Move some code into fillView().
657 2012-01-18 Murray Cumming <murrayc@murrayc.com>
659 locales drop-down: Do not lose the primary key.
661 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
662 start(): onLocaleChange(): Pass the current primary key value,
663 instead of an empty value.
665 2012-01-18 Murray Cumming <murrayc@murrayc.com>
667 locales drop-down: Do not lose the drop-down selection.
669 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
670 .java (TableSelectionActivity.fillView): Set the selected locale
671 after changing the drop-down items (though we do not really need
672 to change them just because the locale changes.)
674 2012-01-18 Murray Cumming <murrayc@murrayc.com>
676 locales drop-down: Change the tables list when this changes.
678 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
679 .java: TableSelectionActivity.start(): Move the async table titles
680 retrieval into a private fillView() method and also call this when
681 the chosen locale changes.
682 Note that the document title is not actually translatable yet, but
683 that is a problem that I should fix soon in libglom.
685 2012-01-18 Murray Cumming <murrayc@murrayc.com>
687 Improve the placement of the locales drop-down.
689 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
690 Put the title and locales drop-down in a div (gwt.FlowTable).
691 * src/main/webapp/style.css: Add magic css properties to make this work.
692 Also remove the left margin from the title so that it lines up with the
695 2012-01-18 Murray Cumming <murrayc@murrayc.com>
697 locales selector: Show human-readable locale titles.
699 * src/main/java/org/glom/web/server/ConfiguredDocument.java
700 getDocumentInfo(): Use java.util.Locale to show a real title of
701 each locale, in the locale's own language.
703 2012-01-17 Murray Cumming <murrayc@murrayc.com>
705 Add a language/locale selector drop-down.
707 * src/main/java/org/glom/web/shared/DocumentInfo.java:
708 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
709 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
710 getDocumentInfo(): Store the available Locales in the DocumentInfo.
711 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
712 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
713 Add a ListBox to show the available locales. Add getLocaleSelector(),
714 setLocaleList(), getSelectedLocale(), setSelectedLocale().
715 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
716 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
717 java: Add these classes.
718 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
719 start(): Fill the locales ListBox. Handle its change event, firing a
721 setPlace(): Show the selected locale as specified by the URL token.
722 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
723 * src/main/java/org/glom/web/client/activity/ListActivity.java:
724 Handle LocaleChangeEvent, going to a new *Place with that locale.
726 The placement of the ListBox is not pretty, and it currently uses the ID
727 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
731 2012-01-17 Murray Cumming <murrayc@murrayc.com>
733 Search box: Show the search text from the URL token.
735 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
736 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
737 Add setQuickFindText().
738 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
739 .java: setPlace(): Store the queryText if the place is a ListPlace,
740 and call TableSelectionView.setQuickFindText().
742 2012-01-17 Murray Cumming <murrayc@murrayc.com>
744 Allow use of translations via, for instance, &lang=de in the URL.
746 * pom.xml: Use the unstable java-libglom 1.21 version.
748 * src/main/java/org/glom/web/client/OnlineGlomService.java:
749 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
750 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
751 init(): Instead of calling TranslatableItem.set_current_locale()
752 (now removed), call ConfiguredDocument.setDefaultLocaleID().
753 However, this is only for default locales, which are not needed to
754 change the locale in the URL.
755 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
756 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
757 getSortedRelatedListData(): Add a localeID parameter, so we can get the
758 layout for a particular locale.
759 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
760 Add get/setDefaultLocaleID().
761 getDocumentInfo(), getListViewData(), getRelatedListData(),
762 getDetailsLayoutGroup(), getListViewLayoutGroup(),
763 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
764 localeID parameter, so we can get the layout for a particular locale.
766 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
767 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
768 * src/main/java/org/glom/web/client/place/ListPlace.java:
769 Parse and construct a lang parameter too.
771 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
772 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
773 passed to subsequent methods and constructors.
774 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
775 * src/main/java/org/glom/web/client/activity/ListActivity.java:
776 Store the localeID from the *Place and pass it to other constructors
777 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
779 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
780 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
781 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
782 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
783 * src/main/java/org/glom/web/client/ui/ListView.java:
784 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
785 Take localeID parameters and pass them to subsequent constructors and
786 methods, so that the layout is always retrieved for that locale.
788 This is rather repetitive.
790 Note that "" means the original (default) locale of the Glom document,
791 which is usually English.
793 2012-01-17 Murray Cumming <murrayc@murrayc.com>
795 Documents: Remove final keyword to fix startup configuration.
797 * src/main/java/org/glom/web/shared/Documents.java: Remove the
798 final keywords on the private member variables because that breaks
799 the startup, apparently (there are warnings) because it stops them
800 from being serialized. I added these in the previous commit.
802 2012-01-13 Murray Cumming <murrayc@murrayc.com>
804 Documents: Add some final keywords.
806 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
809 2012-01-13 Murray Cumming <murrayc@murrayc.com>
811 OnlineGlomServiceImpl: Add to overview comments.
813 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
814 Note that this is where all the document are loaded. They are not
815 loaded freshly for each page.
817 2012-01-12 Murray Cumming <murrayc@murrayc.com>
821 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
822 Add a TextBox for the text of a quick find.
823 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
825 setBackLink(): Add a String quickFind parameter.
826 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
827 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
828 to the base interface, because that is how TableSelectionViewImpl is used.
829 * src/main/webapp/style.css: Add style for the search box and its label.
831 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
832 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
833 Add these files, based on the existing TableChangeEvent and
834 TableChangeEventHandlers.
835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
836 start(): Handle QuickFindChangeEvent, passing its quickFind text to
837 a ListPlace() that the user should be taken to.
838 * src/main/java/org/glom/web/client/activity/ListActivity.java
839 start(): Handle it here too and adapt the TableChangeEvent handler to
840 pass the extra "" quickFind parameter to ListPlace.
841 * src/main/java/org/glom/web/client/place/ListPlace.java:
842 Constructor: Take an extra String quickFind parameter and store it,
843 returning it from a new getQuickFind() method.
844 getToken(): Put the quickFind text in the URL token.
845 getPlace(): Parse the quickFind text from the URL token.
846 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
847 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
848 ListPlace constructor.
849 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
850 .java: start(): Add a Change handler for the TableSelectionView's
851 TextBox (via its base HasChangeHandlers interface), firing the new
852 QuickFindChangeEvent.
853 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
854 pass the extra "" quickFind parameter.
856 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
857 setCellTable(): Add a String quickFind parameter and pass it to
858 the ListViewTable() constructor.
859 * src/main/java/org/glom/web/client/ui/ListView.java: Change
860 setCellTable() in the base interface, because that is how ListViewImpl
863 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
864 Add a String quickFind member variable.
865 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
866 Constructor: Add a String quickFind parameter, storing it in the
867 base ListTable's member variable.
868 onRangeChanged(): Pass quickFind to the
869 OnlineGlomServiceAsync.getSortedListViewData() and
870 OnlineGlomServiceAsync.getListViewData() methods.
872 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
873 getListViewData(), getSortedListViewData(): Add a String quickFind
874 parameter, passing it to ConfiguredDocument.getListViewData().
875 * src/main/java/org/glom/web/client/OnlineGlomService.java:
876 Change getListViewData(), getSortedListViewData() in the base interface,
877 because that is how OnlineGlomServiceImpl is used, via this:
878 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
879 Change getListViewData(), getSortedListViewData() here too.
880 This class can apparently be used to asynchronously call methods on
881 OnlineGlomService, and GWT seems to implement that after recognizing
882 just the *Async name convention and the extra AsyncCallback parameters.
884 * src/main/java/org/glom/web/server/ConfiguredDocument.java
885 getListViewData(): Add a String quickFind parameter, and pass it to
886 ListViewDBAccess.getData().
887 * src/main/java/org/glom/web/server/database/ListDBAccess.java
888 getListData(): Add a String quickFind parameter and pass it to
890 getSelectQuery(): Add a String quickFind parameter.
891 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
892 getSelectQuery(): Add a String quickFind parameter and use it with
893 Glom.get_find_where_clause_quick() to pass a where_clause to
894 Glom.build_sql_select_with_where_clause(), to actually filter the
896 getData(): Add a String quickFind parameter, passing it to getListData().
897 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
898 va: getData(): Pass an empty string to getListData() for the
901 2012-01-12 Murray Cumming <murrayc@murrayc.com>
903 ListTable: Minor change.
905 * src/main/java/org/glom/web/client/ui/list/ListTable.java
906 createCellTable(): Make this protected instead of public.
908 2012-01-12 Murray Cumming <murrayc@murrayc.com>
910 Many files: Use final for the parameters and use the @override attribute.
912 2012-01-22 Ben Konrath <ben@bagu.org>
914 Add anchor links for single line text that starts with http, ftp and www.
918 2012-01-22 Ben Konrath <ben@bagu.org>
920 Add ellipsis to single line text in details view.
924 2012-01-04 Murray Cumming <murrayc@murrayc.com>
926 Remove all javadoc author tags.
928 Because they are awkward and meaningless when many people touch
930 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
932 2012-01-04 Murray Cumming <murrayc@murrayc.com>
934 Revert the COPYING.LESSER to COPYING rename.
936 Apparently both should be there if it is LGPL.
938 2012-01-03 Murray Cumming <murrayc@murrayc.com>
940 *View: Remove unused imports.
942 * src/main/java/org/glom/web/client/ui/DetailsView.java:
943 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
944 * src/main/java/org/glom/web/client/ui/ListView.java:
945 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
946 Remove unused imports, as suggested by Eclipse.
948 2012-01-02 Murray Cumming <murrayc@murrayc.com>
950 Move the *View::Presenter types, and some API into one base View.
952 * src/main/java/org/glom/web/client/ui/DetailsView.java:
953 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
954 * src/main/java/org/glom/web/client/ui/ListView.java:
955 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
956 Presenter, setPresenter() and clear() into a shared base interface,
957 to avoid the unnecessary duplicate Presenter types and to more clearly
958 show how the *Views share the same structure, even if they are not
959 used polymorphically.
961 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
962 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
964 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
965 * src/main/java/org/glom/web/client/activity/ListActivity.java:
966 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
968 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
971 Feel free to revert this if there is a good reason for the duplicate
974 2012-01-02 Murray Cumming <murrayc@murrayc.com>
976 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
978 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
979 a class member instead of a local variable in the method.
980 This lets us use it to get the view instances, for use in tests.
981 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
982 beforeOnlineGlom(): Test some more details of the initial view.
983 Again, this is not very useful.
985 To really test gwt-glom we will need to start a local postgresql
986 instance with local data, like the Glom tests in C++.
988 2012-01-02 Murray Cumming <murrayc@murrayc.com>
990 pom.xml: Mention the LGPL license.
992 * pom.xml: Add a licenses section.
993 * COPYING.LESSER: Move this to COPYING, which
994 previously contained the GPL. But gwt-glom is all LGPL.
996 2012-01-02 Murray Cumming <murrayc@murrayc.com>
998 Add project information to README and pom.xml.
1000 * README: Add a brief description and mention some mvn
1002 * pom.xml: This extra information shows up in mvn site
1005 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1007 Use the latest java-libglom version.
1009 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1011 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1013 GwtTestOnlineGlom: Test a little more.
1015 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1016 protected rather than private, as suggested by the gwt-test-utils
1018 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1019 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1020 Test the initial visibility of the panels.
1022 However, this is not a very useful test.
1023 And I wonder how we should generally test using this idea for an
1024 activity/places app like ours where the real changes happen implicitly
1025 based on the history token/URL.
1027 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1029 Slight modification to *Mapper comments.
1031 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1032 (DataActivityMapper)
1033 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1035 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1037 Remove comments mentioning GIN because they are just copied from
1038 the example code and are apparently not helpful:
1039 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1040 Also change the mention of a class that is only in the example code.
1042 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1044 GwtTestOnlineGlom test: Minor changes.
1046 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1047 Avoid the long qualified class name and modify the comment
1048 because it is now obvious to me that the mocked class is the only
1049 custom one created via GWT.create().
1051 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1053 Tests: Added the beginnings of a test using gwt-test-utils.
1055 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1056 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1057 which tells gwt-test-utils what class will be tested.
1058 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1059 Add a simple (but empty) test case. One class, used by the OnlineGlom
1060 class, is mocked so that it can be created. However, I am not sure
1061 why only this class needs to be mocked.
1063 Note that mockito seems more popular, and clearer, than easymock,
1064 but I have not got that working yet. It might be a matter of the
1067 This test is run during mvn integration-test.
1069 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1071 Tests: Use junit4-style syntax instead of junit3-style.
1073 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1074 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1075 * src/test/java/org/glom/web/shared/DataItemTest.java:
1076 Use the @Test annotation rather than relying on the test*() prefix.
1077 Also no longer implement TestCase, to avoid triggering support for
1078 the junit3-way, which stops the annotations from working.
1079 Change the imports from import junit.framework.* to
1080 import org.junit.*, which is apparently the new way.
1082 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1084 Added a test for ListPlace token parsing and creation.
1086 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1087 This is much the same as DetailsPlaceTest.
1089 I wonder how we could test the other parts of the *Place API.
1091 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1093 DetailsPlace test: Also test getToken() and recreation via getPlace().
1095 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1096 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1097 recreate it, testing the recreated DetailsPlace for the same parameter
1100 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1102 Use the surefire-report plugin.
1104 * pom.xml: This generates a HTML report about the tests in
1105 target/site/surefire-report.html
1106 when you do mvn surefire-report:report. It seems to be popular/normal.
1108 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1110 Added a test for DetailsPlace.
1112 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1113 Test the getPlace() token parsing.
1115 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1117 Added a first unit test.
1119 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1120 * src/test/java/org/glom/web/shared/DataItemTest.java:
1121 This is a silly test but it is just to get things started. Note that
1122 maven/junit finds the test because it looks in src/test by default.
1124 2011-12-22 Ben Konrath <ben@bagu.org>
1126 Change charsetName to "UTF-8" when replacing line breaks.
1128 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1129 that work in Java (such as "UTF8") will not work when compiled to
1132 This fixes a problem with multi-line details view fields that have hard
1133 line breaks. The "License Text" field on this page demonstrates the
1136 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1138 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1140 2011-12-22 Ben Konrath <ben@bagu.org>
1142 Fix another bug with related list navigation.
1144 I've tested all the navigation buttons in all of the related lists
1145 so things should be good now.
1147 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1149 2011-12-22 Ben Konrath <ben@bagu.org>
1151 Fix a crasher when refreshing the list view with the default table.
1153 This crash will also happen when loading the list view with the default
1154 table from a link or bookmark.
1156 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1157 to the main document selection page when the document id hasn't been
1159 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1160 the main document selection page when the document id hasn't been
1162 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1163 values for the details place when the document id hasn't been set.
1164 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1165 values for the list place when the document id hasn't been set.
1167 2011-12-21 Ben Konrath <ben@bagu.org>
1169 Protect against NPE when glom.document.locale is not in config.
1171 This patch protects against an NPE when glom.document.locale is not in
1172 the config file. This NPE will also happen if glom.document.locale is
1175 The patch also updates the error message to display the class name when
1176 the getMessage() returns null. This was happening when the NPE was
1177 thrown and I had "Configuration Error: null". If an NPE is encountered
1178 with this patch, "Configuration Error: NullPointerException " will be
1181 This commit closes this bug:
1183 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1185 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1187 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1189 Rename onlineglom.properties to onlineglom.properties.sample.
1191 * src/main/resources/onlineglom.properties: Rename to:
1192 * src/main/resources/onlineglom.properties.sample:
1193 * src/main/resources/README: And add this file explaining that people
1194 should rename it back when deploying.
1196 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1198 Allow choosing the translation in the .properties file.
1200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1201 init(): Read a glom.document.locale value from the configuration file
1202 and call Glom's TransatableItem::set_current_locale() method.
1203 * src/main/resources/onlineglom.properties: Add a commented-out
1204 example of this new setting.
1206 It would be better to add &lang=de_DE to the URL, but the current
1207 libglom API does not allow us to do this easily. I am working on that.
1209 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1211 Avoid a crash in parsing of token parameters.
1213 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1214 ava: getTokenParams(): Do not crash if a parameter has a key but no
1215 value, and ignore parameters with neither.
1217 2011-12-17 Murray Cumming <murrayc@murayc.com>
1219 History token building/handling: Improve use of token parameters.
1221 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1222 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1223 and buildParamsToken(HashMap), for use by derived classes.
1224 Make the separator private because it is no longer be needed.
1225 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1226 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1227 instead of manual string concatenation.
1228 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1229 of hardcoded indices and awkward splitting code.
1230 * src/main/java/org/glom/web/client/place/ListPlace.java
1231 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1232 instead of manual string concatenation.
1233 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1234 of hardcoded indices and awkward splitting code.
1235 This should fix bug #666420
1237 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1239 Fix a Navgiation->Navigation typo in the code.
1241 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1242 Rename processNavgiation() to processNavigation().
1244 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1246 Fix a seperator->separator typo in the code.
1248 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1249 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1250 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1253 2011-12-15 Ben Konrath <ben@bagu.org>
1255 Cleanup some comments.
1257 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1259 2011-12-14 Ben Konrath <ben@bagu.org>
1261 Replace \n with <br/> for multiline text in the details view.
1263 Vertical scrollbars are added when needed as well.
1265 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1267 2011-12-14 Ben Konrath <ben@bagu.org>
1269 Specify the font for document selection links.
1271 * src/main/webapp/style.css:
1273 2011-12-14 Ben Konrath <ben@bagu.org>
1275 Fix bouncy CellTable while paging.
1277 This doesn't currently work with related list tables in unselected
1280 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1282 2011-12-14 Ben Konrath <ben@bagu.org>
1284 Revamp the appearance of the document selection page.
1286 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1287 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1288 * src/main/webapp/style.css:
1290 2011-12-13 Ben Konrath <ben@bagu.org>
1292 Set navigation button column to the smallest size possible.
1294 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1296 2011-12-13 Ben Konrath <ben@bagu.org>
1298 Change OpenButton nomenclature to NavigationButton.
1300 Using NavigtionButton makes things more generic. Classes, methods and
1301 variables have been changed.
1303 This is a rename-only refactor.
1305 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1306 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1307 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1308 Renamed from OpenButtonCell.
1309 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1310 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1311 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1313 2011-12-12 Ben Konrath <ben@bagu.org>
1315 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1317 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1318 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1319 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1320 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1322 2011-12-12 Ben Konrath <ben@bagu.org>
1324 Update variable names and comments.
1326 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1327 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1329 2011-12-12 Ben Konrath <ben@bagu.org>
1331 Properly initialize numNonEmptyRows variable to zero.
1333 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1334 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1336 2011-12-05 Ben Konrath <ben@bagu.org>
1338 Add latest mockup with HTML tables.
1340 Features of this mockup:
1342 -> HTML table for flowtable
1343 -> HTML table for flowtable column
1344 -> Example of how related lists would look
1345 -> Not using text entries for data items
1347 The current version of Online Glom doesn't use HTML tables for the
1350 This mockup has been sent to the glom-devel mailing list but it's good
1351 to have it here as well.
1353 * mockups/details-view-html-tables.html:
1355 2011-12-05 Ben Konrath <ben@bagu.org>
1357 Remove unnecessary getPrimaryKeyField() method.
1359 getPrimaryKeyFieldForTable(String) has been renamed to
1360 getPrimaryKeyField(String).
1362 * src/main/java/org/glom/web/server/database/DBAccess.java:
1363 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1364 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1366 2011-12-05 Ben Konrath <ben@bagu.org>
1368 Add string representation of TypedDataItem value to conversion error message.
1370 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1371 message was extracted into its own method to avoid duplication.
1373 2011-12-05 Ben Konrath <ben@bagu.org>
1375 Add type checking to navigation primary key value creation.
1377 Create navigation primary key only if the expected type from the Glom
1378 document matches the type returned by the SQL query.
1380 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1382 2011-12-05 Ben Konrath <ben@bagu.org>
1384 Rename a couple of variables in RelatedListNavigation.
1386 This is a rename-only refactor.
1388 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1390 2011-12-05 Ben Konrath <ben@bagu.org>
1392 Move getListLayoutGroup() into getListViewLayoutGroup().
1394 This removes getListLayoutGroup(). It was only being called by
1395 getListViewLayoutGroup().
1397 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1399 2011-12-05 Ben Konrath <ben@bagu.org>
1401 Remove check for LayoutItem_Portal in list table method.
1403 This check is no longer necessary because the method isn't being used
1404 to create the LayoutItemPortal DTO.
1406 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1408 2011-12-05 Ben Konrath <ben@bagu.org>
1410 Properly support related list navigation.
1412 Navigation from the "Repository Analyzer -> Package Scans ->
1413 Dependencies" related table wasn't working because the primary key for
1414 related tables wasn't being set properly. This commit fixes the
1417 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1418 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1419 doesn't set the primary key properly for related list tables.
1420 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1421 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1422 useful for getting the primary key for list view tables and for related
1424 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1425 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1426 Move code to set the primary key for the table from the abstract
1427 ListDBAccess class to ListViewDBAccess as it's only correct for list
1429 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1430 Properly add primary key to related list tables.
1432 2011-12-02 Ben Konrath <ben@bagu.org>
1434 Properly set the horizontal alignment of fields.
1436 This fix is for both the list tables and the details view.
1438 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1439 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1440 to set the horizontal alignment of fields.
1442 2011-12-02 Ben Konrath <ben@bagu.org>
1444 Display currency codes in the details view.
1446 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1448 2011-12-02 Ben Konrath <ben@bagu.org>
1450 Avoid duplicate JNI call.
1452 JNI is not as efficient as pure Java and this is an easy (and small)
1455 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1456 Use previously retrieved value for whereClauseToTableName instead of
1459 2011-12-02 Ben Konrath <ben@bagu.org>
1461 Rename a couple of variables in RelatedListNavigation.
1463 This is a rename-only refactor.
1465 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1467 2011-12-02 Ben Konrath <ben@bagu.org>
1469 Indicate clearly that a mismatched primary key type is a bug.
1471 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1472 warning to error. Add 'This is a bug.' to message.
1474 2011-12-02 Ben Konrath <ben@bagu.org>
1476 Update / fix some comments.
1478 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1480 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1482 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1483 Fix comments. Add some TODOs.
1485 2011-12-02 Ben Konrath <ben@bagu.org>
1487 Enable navigation to details view with string primary key from related list.
1489 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1490 Create a text primary key value when return type of result is
1491 java.sql.Types.VARCHAR.
1493 2011-12-02 Ben Konrath <ben@bagu.org>
1495 Use checkboxes for booleans in the details view.
1497 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1499 2011-12-01 Ben Konrath <ben@bagu.org>
1501 Improve performance of related list height calculation.
1503 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1504 Put code to calculate the expected height in a static initializer so
1505 that that it's only called once.
1507 2011-12-01 Ben Konrath <ben@bagu.org>
1509 Show related list tables in notebooks (again).
1511 Calculate the height of the related list tables so the Notebook can be
1512 set the correct height. The height of the related list table is also needed by
1513 FlowTable to be able decide how to create the layout.
1515 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1516 and set the Portal height based on the height of the related list
1517 table and the Portal container.
1518 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1519 Add method to calculate the height of the related list tables.
1520 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1521 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1522 calculate the height of the Pager widget.
1524 2011-12-01 Ben Konrath <ben@bagu.org>
1526 Use CellTable API for table property instead of setting style on Element.
1528 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1530 2011-12-01 Ben Konrath <ben@bagu.org>
1532 Make ListViewTable and RelatedListTable a consistent height.
1534 The tables are now a consistent height regardless of the contents of
1535 the table. A hidden button is added to empty rows to ensure that the
1536 height of these rows will match the height of rows with data.
1538 A navigation button column is now added to every table. The width of
1539 the navigation column is set to 0px when a RelatedListTable shouldn't
1540 have navigation buttons. This maintains the a consistent row height in
1541 tables that don't show the navigation buttons.
1543 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1544 navigation column when not needed.
1545 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1546 arguments for navigation button to constructor of ListViewTable.
1547 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1548 hidden button for empty data rows.
1549 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1550 arguments for navigation button to constructor.
1551 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1552 create navigation buttons. Add hideNavigationButtons() method.
1553 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1554 arguments for navigation button to constructor.
1556 2011-12-01 Ben Konrath <ben@bagu.org>
1558 Use 'visibility: hidden' in Utils.getWidgetHeight().
1560 This is better choice because hidden elements are invisible, don't
1561 respond to events and are not part of the tab order. They will,
1562 however, take up space which is required to be able to calculate the
1563 height of the widget.
1565 * src/main/java/org/glom/web/client/Utils.java:
1567 2011-12-01 Ben Konrath <ben@bagu.org>
1569 Use Utils.getWidgetHeight() in FlowTable.
1571 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1573 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1575 2011-12-01 Ben Konrath <ben@bagu.org>
1577 Put the details css class name on the correct table column.
1579 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1581 2011-11-30 Ben Konrath <ben@bagu.org>
1583 Update for java-libglom API change.
1585 The getters and setters on FieldFormatting and NumericFormat were
1586 changed to remove the 'M'.
1588 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1590 2011-11-29 Ben Konrath <ben@bagu.org>
1592 Only allow RelatedListTables in Portals.
1594 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1596 2011-11-29 Ben Konrath <ben@bagu.org>
1598 Only create a contents panel for Portals when title is being set.
1600 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1602 2011-11-29 Ben Konrath <ben@bagu.org>
1604 Set TabLayoutPanel height based on calculated height its widgets.
1606 This is a potential fix for this bug:
1608 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1610 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1612 2011-11-29 Ben Konrath <ben@bagu.org>
1614 Align details field labels and data with the Open buttons.
1616 * src/main/webapp/style.css:
1618 2011-11-29 Ben Konrath <ben@bagu.org>
1620 Remove unnecessary <div> in the Notebook widget.
1622 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1623 method to get container FlowPanel (<div>).
1624 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1625 initWidget() method directly on the TabLayoutPanel widget instead of
1626 Group's container widget.
1628 2011-11-29 Ben Konrath <ben@bagu.org>
1630 Don't add group titles for Portals in Notebooks.
1632 This reverts the previous patch and fixes a bug I introduced with
1633 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1635 * src/main/java/org/glom/web/client/ui/details/Group.java:
1636 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1638 2011-11-28 Ben Konrath <ben@bagu.org>
1640 Remove unused boolean argument in Portal constructor.
1642 Just a code cleanup.
1644 * src/main/java/org/glom/web/client/ui/details/Group.java:
1645 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1647 2011-11-28 Ben Konrath <ben@bagu.org>
1649 Remove hack for glom 1.18 style glom files.
1651 * src/main/java/org/glom/web/client/ui/details/Group.java:
1652 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1653 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1655 2011-11-28 Ben Konrath <ben@bagu.org>
1657 Use Gda Value version of primary key to log result too large error.
1659 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1661 2011-11-28 Ben Konrath <ben@bagu.org>
1663 Don't use TypedDataItem.getText() for Unknown types from the URL.
1665 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1666 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1667 instead of getText().
1668 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1669 String field and getUnknown() method.
1671 2011-11-28 Ben Konrath <ben@bagu.org>
1673 Log an error message when the java-libglom .so is not present.
1675 The error message was being set in the exception but not logged.
1677 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1679 2011-11-28 Ben Konrath <ben@bagu.org>
1681 Ignore LayoutItem_CalendarPortals.
1683 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1684 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1686 2011-11-28 Ben Konrath <ben@bagu.org>
1688 Extract method for creating the LayoutItemPortal DTO.
1690 Just breaking the code up into smaller chunks.
1692 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1694 2011-11-28 Ben Konrath <ben@bagu.org>
1698 This should have been added with the refactor. Oops!
1700 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1702 2011-11-28 Ben Konrath <ben@bagu.org>
1704 Create primary key value from URL string using type from Glom document.
1706 See this bug, comments 19 - 25:
1708 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1710 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1711 create a TypeDataItem for the primary key here when loading from a
1712 URL. Show the same string for the primary key value as was received
1713 from the URL string (when loading from a URL).
1714 * src/main/java/org/glom/web/server/Utils.java: Update method for
1715 creating the Gda Value from the TypeDataItem to properly deal with
1716 creating a Gda Value based on the Glom document type for the primary
1717 key value string when loading from a URL.
1718 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1719 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1720 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1721 Update for changed method name.
1723 2011-11-27 Ben Konrath <ben@bagu.org>
1725 Rename PrimaryKeyItem to TypedDataItem.
1727 The name PrimaryKeyItem suggests what the class should be used for.
1728 TypedDataItem is a neutral name that describes the class better.
1730 This is a rename-only refactor.
1732 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1733 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1734 * src/main/java/org/glom/web/client/Utils.java:
1735 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1736 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1737 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1738 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1739 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1740 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1741 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1742 * src/main/java/org/glom/web/server/Utils.java:
1743 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1744 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1745 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1746 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1748 2011-11-25 Ben Konrath <ben@bagu.org>
1750 Improve Gda Value conversion from PrimaryKeyItem.
1752 The value from the PrimaryKeyItem is only used if its type match the
1753 type from the glom document.
1755 * src/main/java/org/glom/web/server/Utils.java:
1757 2011-11-25 Ben Konrath <ben@bagu.org>
1759 Manually check if the java-liblgom .so is visible to the JVM.
1761 It seems that Tomcat has problems when a static initializer throws an
1762 exception. This check is done before the first method call into
1763 java-libglom so that execution doesn't continue if the .so is not
1766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1768 2011-11-25 Ben Konrath <ben@bagu.org>
1770 Improve browser configuration error messages.
1774 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1776 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1777 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1778 getConfigurationErrorMessage() method.
1779 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1780 Get and display a specific configuration error message when no Glom
1781 documents are found.
1782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1783 Implement getConfigurationErrorMessage() method. Surround configuration
1784 code in the init() method with a try/catch block. This allows the
1785 errors to be caught while keeping the servlet available to retrieve the
1786 configuration error message.
1788 2011-11-25 Ben Konrath <ben@bagu.org>
1790 Don't use Strings to hold primary key values.
1792 The primary key values are now held in a new data object
1793 (PrimaryKeyItem) that holds type information and the primary key value
1794 using the correct type.
1796 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1797 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1798 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1799 PrimaryKeyItem instead of String to hold the primary key value.
1800 * src/main/java/org/glom/web/client/Utils.java: Remove
1801 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1802 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1803 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1804 PrimaryKeyItem instead of String to hold the primary key value. Load
1805 document selection page when the documentID has not been set correctly.
1806 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1807 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1809 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1810 Return empty string for URL instead of "null".
1811 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1812 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1813 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1814 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1815 PrimaryKeyItem instead of String to hold primary key values.
1816 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1817 PrimaryKeyValue to a Gda Value.
1818 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1819 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1820 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1821 Replace temporary database access code that uses the PrimaryKeyValue to
1822 Gda Value conversion.
1823 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1824 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1825 PrimaryKeyItem instead of String.
1826 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1827 hold primary key values.
1829 2011-11-24 Ben Konrath <ben@bagu.org>
1831 Use newly added java-libglom API to create queries.
1833 This isn't finished. I still need to stop using Strings for primary key
1834 values in the client code.
1836 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1837 libglom to use fake connections so that retrieving the query string will
1839 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1840 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1841 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1842 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1843 Use the newly added libglom sql methods and classes to create the
1844 query. Add temporary hack to convert primary value strings to Gda
1847 2011-11-23 Ben Konrath <ben@bagu.org>
1849 Don't explicitly set the height of Portals.
1851 See comments 6 - 10 of this bug for details:
1853 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1855 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1857 2011-11-23 Ben Konrath <ben@bagu.org>
1859 Use an HTML table instead of CSS for the FlowTable layout.
1861 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1862 GWT's FlexTable to implement the FlowTable.
1863 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1865 2011-11-18 Ben Konrath <ben@bagu.org>
1867 Add boolean example to HTML table mockup.
1869 * mockups/details-view-html-tables-text-entries.html:
1871 2011-11-17 Ben Konrath <ben@bagu.org>
1873 Ensure the pager buttons are always visible for related lists.
1875 To accomplish this, I've turned off text wrapping in the list view and
1876 related list tables for both the header and data text. The related list
1877 table now has a fixed layout so the it doesn't overflow its container.
1878 This is required to ensure that the cell text is clipped when it
1879 overflows the cell and an ellipsis is added to the right side of the
1880 cell when text is clipped.
1882 A fixed table layout for the related list table in the details view
1883 seems what we want for the details view anyway, so the side-effect is
1886 The ellipsis will only be displayed in Firefox >= 7.
1890 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1892 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1893 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1894 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1896 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1897 Set the 'table-layout: fixed' CSS property to the related list table.
1898 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1899 'white-space: nowrap;' CSS property on both the list view and the
1900 related list tables.
1902 2011-11-16 Ben Konrath <ben@bagu.org>
1904 Rework the fix for empty notebook tab labels.
1906 Setting the empty group titles with its name caused problems for the
1907 details layout. Instead of using libglom's
1908 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1909 to the client when the title is empty. This allows the Notebook to use
1910 the name when the title is empty without affecting anything else.
1912 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1913 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1915 2011-11-16 Ben Konrath <ben@bagu.org>
1917 Set group titles with name when title is empty.
1919 This fixes a problem with an empty notebook tab label in the Lesson
1920 Planner document. The forth tab in the notebook should be "Internet":
1922 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1924 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1925 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1928 2011-11-16 Ben Konrath <ben@bagu.org>
1930 Remove whitespace from the configured username properties.
1932 This assumes that usernames won't have whitespace at the beginning
1933 or end. But I think this is a reasonable assumption.
1935 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1936 String.trim() to remove the whitespace from the username properties.
1938 2011-11-15 Ben Konrath <ben@bagu.org>
1940 Add details view mockup with HTML tables and text entries.
1942 This is from the attachment on this bug:
1944 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1946 * mockups/details-view-html-tables-text-entries.html:
1948 2011-11-15 Ben Konrath <ben@bagu.org>
1950 Add space between the columns of the flow table.
1954 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1956 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1957 space between columns in the flow table.
1959 2011-11-15 Ben Konrath <ben@bagu.org>
1961 Add backup files to the .gitignore.
1963 * .gitignore: Ignore files that end with ~.
1965 2011-11-09 Ben Konrath <ben@bagu.org>
1967 Use latest release of gwt-log.
1969 Gwt-log releases are now being submitted to the maven central
1970 repository so manual installation of the jar is no longer required.
1972 * pom.xml: Update version and groupId of gwt-log dependency.
1974 2011-10-31 Ben Konrath <ben@bagu.org>
1976 Don't use GWT numeric formatting to override the glom currency formatting.
1978 Currencies are now displayed like they are in Glom. See this bug:
1980 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1982 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1984 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1985 currency code to constructor and set it when the cell is rendered.
1986 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1987 currency code to the constructor of the NumericCell.
1989 2011-10-27 Ben Konrath <ben@bagu.org>
1991 Require the latest release of java-libglom (1.17.4).
1995 2011-10-26 Ben Konrath <ben@bagu.org>
1997 Add style to Notebook that matches current theme.
1999 It's not the best style in the world but it's better than the default.
2001 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2002 padding at the bottom of the child widgets.
2003 * src/main/webapp/style.css: Add style for the Notebook.
2005 2011-10-26 Ben Konrath <ben@bagu.org>
2007 Move servlet initialization code to overridden init method.
2009 This is half of the solution to getting proper error messages
2010 displayed when configuration errors occur. Here's the relevant bug:
2012 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2014 The rest of the solution involves surrounding the init method with a
2015 try/catch block and setting a global variable with the error /
2016 exception. A new async method should be created to retrieve and display
2017 the error message / exception.
2019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2020 code from constructor to init method adding exceptions as needed.
2022 2011-10-26 Ben Konrath <ben@bagu.org>
2024 Add script to monitor and restart tomcat if required.
2026 * utils/check-and-recover-tomcat.py: New file.
2028 2011-10-26 Ben Konrath <ben@bagu.org>
2030 Display the correct number of data items in the pager.
2034 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2036 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2037 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2038 The implementation is the same for both tables: Keep track of the
2039 number of non-empty rows and fire and RowCountChangeEvent after the data has
2041 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2042 custom Pager class that subclasses SimplePager to handle displaying
2043 the correct number when empty rows have been added.
2045 2011-10-26 Ben Konrath <ben@bagu.org>
2047 Correct error in previous commit.
2049 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2050 eventBus parameter from listView.setCellTable().
2052 2011-10-26 Ben Konrath <ben@bagu.org>
2054 Fix error in TODO comment.
2056 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2058 2011-10-24 Ben Konrath <ben@bagu.org>
2060 Create Notebook widgets to the details view.
2062 This isn't finished just yet - I still need to create a reasonable
2063 style to match the current theme.
2065 * src/main/java/org/glom/web/client/Utils.java: Add method for
2066 calculating the height of a widget. This is used in the Notebook class.
2067 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2068 new constructor method in Group.
2069 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2070 method for creating child widget that can be used by subclasses
2071 like Notebook. New constructor that allows disabling the group
2072 titles - Notebooks don't set a group title for their child groups.
2073 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2074 to make Notebooks using GWT's TabLayoutPanel.
2075 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2076 constructor that allows disabling the group titles.
2077 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2078 LayoutItemNotebook DTO.
2079 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2080 DTO for Notebooks. It's just an empty class for now but we might need
2081 it to transfer some specific information in the future.
2083 2011-10-21 Ben Konrath <ben@bagu.org>
2085 Add navigation buttons to related list tables.
2087 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2088 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2089 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2090 method getSuitableRecordToViewDetails() for getting the table name
2091 and primary key value for related list navigation buttons.
2092 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2093 private cell renderer class to get the navigation information for
2094 related list tables from the server. Extract the navigation
2095 processing code from the details cell navigation and use it for the
2096 related list navigation as well.
2097 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2098 cell renderer class for the details open buttons. This was needed
2099 because the related list navigation buttons and the list view
2100 navigation buttons need to react differently when clicked.
2101 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2102 the onEnterKeyDown() method because it's now overriden in the
2103 subclasses that are specific to the related list tables and the list
2105 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2106 the vertical size a little because the buttons add a bit of vertical
2107 space to table. This is not a perfect solution because the vertical
2108 size of with table fewer than 5 rows will be a little smaller.
2109 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2110 changes in how navigation buttons are handled.
2111 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2112 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2113 database access object.
2114 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2115 to find the portal for a given relationship name from
2116 RelatedListDBAccess. Add method to find a primary key field for a
2118 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2119 Move code to find the portal for a given relationship name to
2121 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2122 New file: database access object for getting the related list
2123 navigation information (the table name and the primary key value).
2124 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2125 DTO for transferring a table name to navigate to and a primary key
2127 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2128 boolean and getter/setter to specifies if the related list should add
2131 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2133 Use the master branch of java-libglom
2135 * pom.xml: Depend on java-libglom 1.19 instead.
2137 This is the master branch. See also the libglom-1-18 branch.
2139 2011-10-11 Ben Konrath <ben@bagu.org>
2141 Enable the open navigation button when the data has been set.
2143 This avoids having active buttons that don't do anything when the data
2146 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2148 2011-10-11 Ben Konrath <ben@bagu.org>
2150 Use IsWidget interface for FlowTableItem.
2152 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2153 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2155 2011-10-11 Ben Konrath <ben@bagu.org>
2157 Remove GWT styling from open button in details view.
2159 There are still some issues with how the details cell is arranged but
2160 this should be made to match Glom 1.20. I'm going to leave fixing this
2161 until I have Glom 1.20 up and running.
2163 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2164 style name on open button.
2165 * src/main/webapp/style.css: Move and edit details-navigation class.
2166 Re-arrange some classes to make them appear in the same order as the
2169 2011-10-07 Ben Konrath <ben@bagu.org>
2171 Update to GWT 2.4.0.
2173 * .gitignore: Ignore new cache directory.
2174 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2175 * pom.xml: Change GWT and maven plugin to 2.4.0.
2176 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2178 * src/main/java/org/glom/web/client/ClientFactory.java:
2179 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2180 * src/main/java/org/glom/web/client/OnlineGlom.java:
2181 Update source for API changes.
2182 * utils/build-onlineglom-war.sh: Remove cache directory before the
2185 2011-10-07 Ben Konrath <ben@bagu.org>
2187 Add navigation buttons in the details view.
2189 This isn't finished but I thought I'd commit what I have as it's a
2190 pretty good start. I still need to:
2192 1. Change the style so that it fits better into the current theme
2193 2. Adjust the details cell to expand as much as possible.
2195 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2196 click handlers to navigation buttons in the DetailsCells. Create a
2197 refreshData() method to get just the data from the server without the
2199 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2200 Update the tableSelector and browser title when the table name
2201 changes without using the tableSelector.
2202 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2203 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2204 getDetailsCells() to getCells(). Update variable names.
2205 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2206 method to set click handler on navigation button. Rename a few
2207 variables. Add navigation buttons where needed.
2208 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2209 variables and methods.
2210 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2211 navigation boolean and navigation table as required in the
2212 LayoutItemField DTO.
2213 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2214 variables for navigation along with getter/setter methods.
2216 2011-10-07 Ben Konrath <ben@bagu.org>
2218 Rename Field to DetailsCell.
2220 This is a refactor-only commit. No functionality has been added or
2223 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2224 Update variable and method names.
2225 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2226 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2227 variable and method names.
2228 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2230 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2231 variable and method names.
2233 2011-10-07 Ben Konrath <ben@bagu.org>
2235 Create separate methods for layout and data the details view.
2237 This is a refactor-only commit. No functionality has been added or
2240 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2241 private methods: setData(), createLayout().
2243 2011-10-07 Ben Konrath <ben@bagu.org>
2245 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2247 This is part of a change to get navigation buttons in the details view
2248 but it should have been done this way from the start.
2250 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2251 for method name change in TableSelectionView.
2252 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2253 Create TableChangeEvent and set the browser title using the
2254 TableSelectionView API.
2255 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2256 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2257 Change getSelectedTable() to getSelectedTableName(). Add
2258 getSelectedTableTitle().
2260 2011-10-07 Ben Konrath <ben@bagu.org>
2262 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2264 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2266 2011-10-07 Ben Konrath <ben@bagu.org>
2268 Update TableChangeEvent to use newTableName naming convention.
2270 This makes the class more consistent with GWT naming conventions.
2272 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2273 Update for method name change in TableChangeEvent.
2274 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2275 for method name change in TableChangeEvent.
2276 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2277 newTableName variable and getter method. Make toDebugString()
2280 2011-09-30 Ben Konrath <ben@bagu.org>
2282 Disable the pager in the list tables when the data row count is less than the minimum.
2284 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2285 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2287 2011-09-30 Ben Konrath <ben@bagu.org>
2289 Add empty rows to the end of related list and list view tables.
2291 I also extracted the cell rendering classes from the ListTable because
2292 the code was becoming a little crazy with all the anonymous inner
2293 classes. My plan is to use these cell rendering classes in the details
2294 view as well so this refactor will be needed for that change.
2296 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2297 set the row count in related list tables if the data has more rows
2298 than the minimum number of rows visible.
2299 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2300 row count in list view tables if the data has more rows than the
2301 minimum number of rows visible.
2302 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2303 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2305 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2306 for rendering TYPE_NUMERIC cells. The code was extracted from the
2308 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2309 class for rendering cells with buttons in list views. The code was
2310 extracted from the ListTable class.
2311 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2312 for rendering TYPE_TEXT cells. The code was extracted from the
2314 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2315 Add empty rows to the end of the data if required. Implement
2316 ListTable.getMinNumVisibleRows().
2317 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2318 cell renderer code to public classes. Return null in
2319 Column.getValue() for empty rows. Add new abstract method:
2320 getMinNumVisibleRows(). Move code to set the row count of the list view
2321 table to ListViewImpl.
2322 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2323 empty rows to the end of the data if required. Implement
2324 ListTable.getMinNumVisibleRows().
2327 2011-09-27 Ben Konrath <ben@bagu.org>
2329 Use GWT.log for client-side debugging statements.
2331 These are optimized out when deployed so I should have used this method
2332 in the first place. These statements will eventually be replaced with some sort
2333 of notification in the browser.
2335 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2336 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2337 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2338 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2339 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2341 2011-09-27 Ben Konrath <ben@bagu.org>
2343 Put tableselector on the right, back to list link on right.
2345 The idea is that the table selector is acting like a label for the
2346 currently displayed table so it should be placed below the document title. This
2347 puts the table title in a similar position to where it is in Glom.
2349 * mockups/details-contacts.html:
2350 * mockups/details-projects.html:
2351 * mockups/listview-contacts.html:
2352 * mockups/listview-projects.html:
2353 * mockups/style.css:
2354 Update mockups to match how the interfaces currently look.
2355 * src/main/webapp/style.css: Swap positions of backlink with the table
2356 selector. Add some space on the left side of the table selector to
2357 line things up with the document title.
2359 2011-09-27 Ben Konrath <ben@bagu.org>
2361 Add field colouring to details view.
2363 This change re-works how field colouring works. The colour formatting
2364 information is now set to the client with the layout information instead of
2365 with the data. This eliminates the need to send the same colour strings for
2366 data in list view column when colour information is set.
2368 In order to set an alternate colour for negative numeric values, the
2369 number is now sent to client and formatted with the GWT NumberFormat class.
2371 This change also fixes:
2373 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2375 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2376 internationalization framework which is needed for client side numeric
2378 * src/main/java/org/glom/web/client/Utils.java: New file for some
2379 client static utility methods.
2380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2381 the DataItem object to the Field class. Use a utility method to
2382 create the foreignKeyValue string.
2383 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2384 alignment and text colours in the constructor. Add setData(DataItem)
2385 method. Remove setText(String) method.
2386 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2387 colour information to GlomTextCell. Create and use GlomNumberCell for
2388 rendering numbers. Use utility method to get the string for the
2389 primary key of the key provider. Re-work how the horizontal alignment
2391 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2392 formatting to layout information. Methods for converting the libglom
2393 formatting information were moved from DBAccess.
2394 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2395 numeric formatting (it's now done on the client side). Don't set text
2396 colours in DataItem. Move libglom formatting conversion methods to
2398 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2399 getters/setters for text colour information.
2400 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2401 for transferring the libglom NumericFormat information to the client.
2402 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2403 and getters/setters for: GlomNumericFormat, background colour and
2404 foreground colour strings.
2406 2011-09-26 Ben Konrath <ben@bagu.org>
2408 Simplify code that iterates through the LayoutGroup.
2410 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2412 2011-09-26 Ben Konrath <ben@bagu.org>
2414 Accept Eclipse formatting for OnlineGlomServiceAsync.
2416 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2418 2011-09-26 Ben Konrath <ben@bagu.org>
2420 Don't use the ListDBAccess classes to get the primary key layout information.
2422 This was causing a bug where the wrong index for the hidden primary key
2423 was being sent to the client.
2425 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2426 primary key while creating the LayoutGroup DTO. Create a
2427 LayoutItemField DTO for hidden primary keys. Don't use the
2428 RelatedListDBAccess because it was only used for getting the primary
2430 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2431 access modifier from public to protected for getPrimaryKeyField() and
2432 getPrimaryKeyLayoutItemField().
2433 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2434 abstract method getExpectedResultSize() because RelatedListDBAccess
2435 doesn't have enough info to implement it.
2436 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2437 Remove @Override for getExpectedResultSize().
2438 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2439 Remove method getExpectedResultSize().
2441 2011-09-23 Ben Konrath <ben@bagu.org>
2443 Log which layout (list or details) the ignored item is from.
2445 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2447 2011-09-23 Ben Konrath <ben@bagu.org>
2449 Remove annotations that turn off code formatting in DataItem.
2451 * src/main/java/org/glom/web/shared/DataItem.java:
2453 2011-09-23 Ben Konrath <ben@bagu.org>
2455 Rename GlomField to DataItem and update associated methods.
2457 This is a rename-only refactor. No functionality has been added or
2460 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2461 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2462 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2463 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2464 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2465 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2466 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2467 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2468 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2469 * src/main/java/org/glom/web/server/database/DBAccess.java:
2470 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2471 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2472 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2473 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2474 * src/main/java/org/glom/web/shared/DataItem.java:
2475 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2476 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2478 2011-09-23 Ben Konrath <ben@bagu.org>
2480 Rename GlomDocument to DocumentInfo and update associated methods.
2482 This is a rename-only refactor. No functionality has been added or
2485 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2486 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2487 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2488 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2489 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2490 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2491 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2493 2011-09-20 Ben Konrath <ben@bagu.org>
2495 Require java-libglom 1.17.3.
2497 This picks up the fix for the seg fault problem with the Scenes table
2498 in the Openismus Film Manager example.
2502 2011-09-20 Ben Konrath <ben@bagu.org>
2504 Change the way sort clause is added for primary key when no sort clause is requested.
2506 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2507 before the sort clause is created. When a sort clause is not requested, the
2508 sort clause is created by finding the primary key in the LayoutFieldVector
2511 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2513 2011-09-20 Ben Konrath <ben@bagu.org>
2515 Log error message if no documents are found in the configured directory.
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2518 Extract the glom file extension string to a private static final class
2519 variable (mostly as syntactic sugar). Accept a minor formatting change.
2520 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2521 the example glom.document.directory configuration property to make it
2522 more clear that it can any directory, not just the home directory.
2524 2011-09-18 Ben Konrath <ben@bagu.org>
2526 Add related lists to details view.
2528 The related list table has support for paging and sorting just like the
2529 table in the list view.
2531 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2532 SQL queries for the related list tables.
2533 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2534 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2535 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2536 Rename getList methods to getListView and add comments. Remove
2537 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2538 it being unused. Add methods: getDetailsLayoutAndData(),
2539 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2540 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2541 Create the layout and set the data for the fields in one async call
2542 instead of two. Create related lists where appropriate.
2543 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2544 for method name changes in OnlineGlomService.
2545 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2546 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2547 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2549 * src/main/java/org/glom/web/client/ui/ListView.java:
2550 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2551 tableName from setCellTable(). Create a ListViewTable instead of
2553 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2554 represent a data field in the details view.
2555 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2556 from addDetailsCell() to Field class. Keep track of the Fields and
2557 Portals in the details view.
2558 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2559 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2560 and add a method to get it. Add method to set the contents of the
2562 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2563 New class for related list tables. This class has the data provider
2564 for the related list table.
2565 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2566 abstract class which is the base class for the ListViewTable and the
2568 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2569 New class for list view tables. This class has the data provider for
2570 the list view table.
2571 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2572 methods for related list tables. Add more information to the
2573 LayoutItemField and LayoutItemPortal DTOs.
2574 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2575 Remove debugging print statement.
2576 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2577 Remove debugging print statements. Add primary key field to SQL count
2579 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2580 Remove unnecessary LayoutFieldVector parameter from
2581 getResultSizeOfSQLQuery() method.
2582 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2583 New class for related list table database access.
2584 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2585 class that is a wrapper DTO for details view layout and data.
2586 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2587 new 'fromField' string to this DTO.
2588 * src/main/webapp/style.css: Remove bottom margin and override top
2591 2011-09-15 Ben Konrath <ben@bagu.org>
2593 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2595 This sets things up to make it easier to add the data retrieval for
2596 related lists (portals). No user noticeable changes were made with
2599 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2600 class has the code to retrieve the layouts and access the
2601 database using the new database helper classes.
2602 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2603 Most of the functionality has been removed from this class. This
2604 class now represents the public interface for the client side
2605 code. It also deals with configuring the servlet and cleaning
2606 things up when the servlet is stopped.
2607 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2608 of static methods into this utility class.
2609 * src/main/java/org/glom/web/server/database/DBAccess.java:
2610 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2611 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2612 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2613 These classes have the database retrieval code. The class hierarchy
2614 has been setup to make it easy to reuse code for similar
2617 2011-09-06 Ben Konrath <ben@bagu.org>
2619 Create separate classes for list table code and the data provider.
2621 As part of this refactor, I also split up the code a bit to make it
2624 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2625 table code to two new classes (below).
2626 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2627 with code from ListViewImpl.
2628 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2629 New file with code from ListViewImpl.
2631 2011-09-06 Ben Konrath <ben@bagu.org>
2633 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2635 This fixes the LayoutItemPortal DTO to match the libglom layout object
2638 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2640 2011-09-01 Ben Konrath <ben@bagu.org>
2642 Set title of Portals in the Details View.
2644 * pom.xml: Bump required version of java-libglom to 1.17.1.
2645 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2646 widget creation to its own class. Add comments to constructor.
2647 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2648 The code is mostly from the Group class with the title now set.
2649 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2650 title of Portal. Update some comments. Fix some code formatting.
2652 2011-09-01 Ben Konrath <ben@bagu.org>
2654 Remove TODO comment for the flow table column width.
2656 The flow table column width is working correctly and doesn't need to be
2657 changed. See this mailing list post for more info:
2659 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2661 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2663 2011-08-27 Ben Konrath <ben@bagu.org>
2665 Add document title (database name) to top of the browser page.
2667 I added the document title to the TableSelecitonView but that will
2668 change if / when we add a view that doesn't require table selection.
2670 * mockups/details-contacts.html:
2671 * mockups/details-projects.html:
2672 * mockups/listview-contacts.html:
2673 * mockups/listview-projects.html:
2674 * mockups/style.css: Add document title to mockups to keep things
2676 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2677 sizes to account for the document title.
2678 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2679 Set the document title when it has been retrieved from the server.
2680 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2681 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2682 and implement setDocumentTitle(String) method.
2683 * src/main/webapp/style.css: Add ID for document title style.
2685 2011-08-25 Ben Konrath <ben@bagu.org>
2687 Add NavigationType enum to LayoutItemPortal DTO.
2689 This is the start of adding support for Portals to the Details View.
2691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2692 LayoutItem_Portal.navigation_type enum from libglom to
2693 LayoutItemPortal.NavigationType enum.
2694 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2695 NavigationType enum, field for storing the NavigationType and getter
2698 2011-08-25 Ben Konrath <ben@bagu.org>
2700 Implement the flow table layout in the Details View.
2702 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2703 FlowTable to Group to account for the renamed class.
2704 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2705 File. This is a container widget that implements the Glom details view
2706 flow table behaviour.
2707 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2708 org/glom/web/client/ui/FlowTable.java.
2709 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2710 so that the size of the subgroups are a closer match to the size of
2711 the Glom subgroups. This makes the flowtable layout match the layout
2712 in Glom for the Music Collection example file.
2714 2011-08-16 Ben Konrath <ben@bagu.org>
2716 Create container element for LayoutItemPortal in Details View.
2718 This will help me develop the layout for the FlowTable.
2720 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2721 fieldPanel variable to detailsCell.
2723 2011-08-15 Ben Konrath <ben@bagu.org>
2725 Set the height of the data element in the Details View.
2727 I changed the InlineLabels (text in a span element) to Labels (text in
2728 a div element) so that I could set the height of the details-data
2729 elements instead of the details-cell parent elements. This allows the
2730 the details-data element to display the correct height if style is
2731 applied that shows the height.
2733 This change has the added benefit of allowing the order of the labels
2734 and data elements to be changed for right-to-left languages.
2736 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2737 InlineLabels to Labels.
2738 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2739 InlineLabels to Labels. Set the height of the data element.
2740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2741 multiline text height in the Formatting DTO.
2742 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2743 for multiline height along with getter and setter methods.
2744 * src/main/webapp/style.css: Adjust style to account for the change
2745 from span elements to div elements in the details cell.
2747 2011-08-15 Ben Konrath <ben@bagu.org>
2749 Make the List View appearance match the mockups.
2751 It doesn't match exactly but it's much better than it was.
2753 * mockups/listview-contacts.html: Remove unused css classes.
2754 * mockups/listview-projects.html: Remove unused css classes.
2755 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2756 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2757 for mainPanel instead of VerticalPanel (table). Set style name on
2758 CellTable. Set style name on Details column. Right-align Details
2760 * src/main/webapp/style.css: Adjust properties to match the mockups.
2762 2011-08-12 Ben Konrath <ben@bagu.org>
2764 Add better support for subgroups in the details view.
2766 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2767 changed FlowTable constructor.
2768 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2769 support for subgroups and subgroup-titles.
2770 * src/main/webapp/style.css: Add CSS class for subgroups and
2773 2011-08-12 Ben Konrath <ben@bagu.org>
2775 Return the top level LayoutGroup title.
2777 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2779 2011-08-11 Ben Konrath <ben@bagu.org>
2781 Make the TableSelector header match the mockup.
2783 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2784 the layout panel. Properly lineup the table selection header with
2785 the list and details view.
2786 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2787 margin around the details view.
2788 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2789 Rename listBox variable to tableSelector. Set id for the style sheet.
2790 Use a FlowPanel instead of a HorizontalPanel.
2791 * src/main/webapp/style.css: Add properties to make the TableSelector
2792 box match the mockups.
2794 2011-07-13 Ben Konrath <ben@bagu.org>
2796 Update install script for java-libglom version change.
2798 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2801 2011-07-13 Ben Konrath <ben@bagu.org>
2803 Add support sub-group in the details view.
2805 I also removed the code that special-cased the default details view
2808 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2810 I still have to make a proper flowtable.
2812 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2813 Don't special-case default details view layout.
2814 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2815 addLayoutField() as I'm going to use it.
2816 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2817 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2819 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2820 extracted from DetailsViewImpl.GroupPanel. Add support for
2822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2823 column count when getting the details layout.
2825 2011-07-12 Ben Konrath <ben@bagu.org>
2827 Set browser title with database and table titles.
2829 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2830 Set the browser title when the table changes and when the activity
2832 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2833 title when retrieving document info (the GlomDocument object).
2834 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2835 with getter and setter methods. Remove unused convenience constructor.
2836 Use default code formatting.
2838 2011-07-12 Ben Konrath <ben@bagu.org>
2840 Ignore LayoutItemPortals in the details view.
2842 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2845 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2846 LayoutItemPortal layout objects.
2847 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2848 LayoutItemPortal objects when retrieving the details layout.
2849 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2850 file. This is an empty class and just used to get type information for
2853 2011-07-12 Ben Konrath <ben@bagu.org>
2855 Use java-libglom 1.17.0.
2859 2011-07-11 Ben Konrath <ben@bagu.org>
2861 Remove "Table:" label from table selector.
2863 This matches a recent change in the Glom UI.
2865 * mockups/details-contacts.html:
2866 * mockups/details-projects.html:
2867 * mockups/listview-contacts.html:
2868 * mockups/listview-projects.html: Remove the "Table:" label from the
2870 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2872 2011-07-11 Ben Konrath <ben@bagu.org>
2874 Add main groups to the details view.
2876 This makes things look a little nicer in the details view. The next step
2877 is to implement the flowtable.
2879 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2880 resources from the standard gwt css theme. Standard.css is now
2881 included in OnlineGlom.html so that the online glom css rules have
2882 precedence over the gwt theme.
2883 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2884 the whole LayoutGroup to the DetailsView instead of just the titles.
2885 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2886 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2887 details layout with a helper class (GroupPanel). I might extract this
2888 class when I make the full flowtable.
2889 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2890 string as default so I don't have to worry about NPEs when processing
2892 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2893 note beside OnlineGlom.gwt.xml above).
2894 * src/main/webapp/style.css: Add default font-size to body to override
2895 the font-size set by the standard theme. Don't use h2 tags for
2896 group-title. Create new details-cell class.
2898 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2900 ConfiguredDocument: Set the port number too.
2902 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2903 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2904 Glom document. Presumably this worked sometimes so far because there is a
2905 default port number.
2907 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2909 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2911 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2912 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2913 correct, though we should throw an exception too.
2915 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2917 Fix a addDocuemnt typo.
2919 * src/main/java/org/glom/web/shared/Documents.java
2920 (Documents.addDocuemnt): Rename to addDocument().
2921 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2922 (OnlineGlomServiceImpl.getDocuments): Adapt.
2924 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2926 Slightly improved log output when connection fails.
2928 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2929 (ConfiguredDocument.setUsernameAndPassword):
2930 We don't know for sure if it' the username/password that's wrong, so
2931 rephrase the message.
2932 Also ouput the exception message, though it's generic in this case.
2934 2011-07-08 Ben Konrath <ben@bagu.org>
2938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2939 added braces to a one line if statement because the Eclipse formatter
2940 was getting confused.
2942 2011-07-07 Ben Konrath <ben@bagu.org>
2944 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2946 These should really be two separate tasks but I counldn't get things to
2947 work with GWT 2.2.0 and Eclipse 3.7.
2951 * .settings/org.eclipse.jdt.core.prefs:
2952 * .settings/org.eclipse.jdt.ui.prefs:
2953 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2954 * .settings/org.eclipse.m2e.core.prefs:
2955 Add new config files. Update current files. Remove references to the
2956 webtools plugins as we're not using any of the webtools features.
2957 * .gitignore: Add logs directory which is created when running with
2959 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2960 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2961 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2963 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2965 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2967 onlineglom.properties: Add explanatory comments.
2969 * src/main/resources/onlineglom.properties: Also change the default user
2970 from ben to someuser, to avoid the risk of people thinking we just
2971 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2973 2011-06-28 Ben Konrath <ben@bagu.org>
2975 Use filename in Log for incorrect passwords.
2977 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2978 getFileName(String) method to get the filename from the URI.
2980 2011-06-28 Ben Konrath <ben@bagu.org>
2982 Add the table name to the URL token for the ListPlace.
2984 This makes things consistent between the DetailsPlace and the
2985 ListPlace. It also allows the the ListPlace to be bookmarked.
2987 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2988 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2989 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2990 Remove getDefaultListLayout(). The default layout is now returned
2991 by the getListLayout() method when the table name is an empty string.
2992 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2993 Add table name field. Change to a new ListPlace when the table
2994 has been changed. Use getListLayout() for getting the default
2996 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2997 Add table name field. Set the correct table name in the list box
2998 when loading from bookmark. This corrects a problem for the
3000 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3001 Move table name to super-class (HasSelectableTable). Move document
3002 and table URL keys to super-class in HasSelectableTable.
3003 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3004 Add table name field. Add Tokenizer class with URL key common to
3005 the subclasses (DetailsPlace and ListPlace).
3006 * src/main/java/org/glom/web/client/place/ListPlace.java:
3007 Add table name. Add code to parse the URL token.
3008 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3009 Update ListPlace construction with empty table name string.
3010 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3011 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3012 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3013 Update ListPlace construction with table name string.
3014 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3015 Change defaultTableName field to tableName to reflect how it's now
3016 used. Update the getter and setter methods.
3018 2011-06-28 Ben Konrath <ben@bagu.org>
3020 Enable the table selector in the DetailsView.
3022 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3023 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3024 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3025 Remove getDefaultDetailsLayout(). The default layout is now returned
3026 by the getDetailsLayout() method when the table name is an empty
3028 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3029 event handler for table change event. Change to using
3030 getDetailsLayout() for the default details layout.
3031 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3033 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3034 when navigating to the details place.
3036 2011-06-27 Ben Konrath <ben@bagu.org>
3038 Use filename based unique document ID in URL and for RPC.
3040 The document ID is the glom document name with spaces (' ') replaced
3041 with pluses ('+') and without the .glom extension.
3043 This change is mostly a string substitution of 'documentTitle' for
3044 'documentID'. The only code change is the addition of a Documents DTO to get the
3045 filename to document title mappings as indicated below.
3047 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3048 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3049 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3050 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3051 Use Documents DTO to create the document links in the document
3053 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3054 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3055 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3056 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3057 * src/main/java/org/glom/web/client/place/ListPlace.java:
3058 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3059 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3060 * src/main/java/org/glom/web/client/ui/ListView.java:
3061 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3062 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3063 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3064 * src/main/java/org/glom/web/server/Log.java:
3065 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3066 getDocumentTitles() to getDocuments() and return the Documents DTO.
3067 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3068 transferring the filename to document title mappings.
3070 2011-06-25 Ben Konrath <ben@bagu.org>
3072 Make the authentication popup work again.
3074 This bug was introduced when I extracted ConfiguredDocument to its own class.
3076 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3077 correct success / fail status in setUsernameAndPassword().
3079 2011-06-25 Ben Konrath <ben@bagu.org>
3081 Use filename as unique key for configuring database usernames and passwords.
3083 This replaces the use of the Glom document title which could change
3084 depending on the locale. Thanks to Murray Cumming for pointing out this
3087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3088 * src/main/resources/onlineglom.properties:
3090 2011-06-24 Ben Konrath <ben@bagu.org>
3092 Pass primary key value to DetailsView.
3094 This enables the DetailsView to load the correct data.
3096 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3097 primary key value field and set in constructor. Pass primary key
3098 value to getDetailsData().
3099 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3100 variables for document title and primary key value.
3101 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3102 key value to the DetailsPlace.
3104 2011-06-24 Ben Konrath <ben@bagu.org>
3106 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3108 This allows the primary key to be retrieved by the Details button. This
3109 functionality has not been implemented yet but it's in the works.
3111 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3112 the LayoutGroup result to ListView.setCellTable instead of all of its
3113 fields individually.
3114 * src/main/java/org/glom/web/client/ui/ListView.java:
3115 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3116 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3117 get the primary key for the table.
3118 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3119 index of the primary key in the LayoutGroup accounting for hidden
3120 primary keys. Rename getJavaNumberFormat() to
3121 convertToJavaNumberFormat() for consistency. Cleanup / add some
3123 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3124 field for primary key index and a field to indicate whether the
3125 primary key is hidden or not.
3127 2011-06-23 Ben Konrath <ben@bagu.org>
3129 Rename getTableData methods to getListData.
3131 This is a rename refactor for consistency with other methods.
3133 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3134 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3135 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3138 2011-06-23 Ben Konrath <ben@bagu.org>
3140 Extract the ConfiguredDocument innerclass into its own class.
3142 This makes the servlet code more object oriented.
3144 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3145 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3147 new ConfiguredDocument class.
3149 2011-06-21 Ben Konrath <ben@bagu.org>
3151 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3153 This makes things more inline with how libglom works and reduces code
3154 duplication. This refactor lays the groundwork for adding the primary key to
3155 the LayoutGroup object.
3157 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3158 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3160 Change method names to getListLayout and getDefaultListLayout for
3161 consistency. Use LayoutGroup as the DTO for the list layout instead of
3162 ColumnInfo and LayoutListTable.
3163 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3164 new method names along with the LayoutGroup object for transferring the
3166 * src/main/java/org/glom/web/client/ui/ListView.java:
3167 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3168 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3169 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3171 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3172 Replaced with LayoutGroup.
3173 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3174 expectedResultSize and defaultTableName fields which are needed for
3176 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3177 type field which is needed for the list layout but will also be
3178 useful for the details layout as things progress.
3179 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3180 Make class abstract. Remove the unnecessary
3181 getFormattingHorizontalAlignment method. Add setFormatting method.
3183 2011-06-16 Ben Konrath <ben@bagu.org>
3185 Add scripts for building and installing war.
3187 These will help when updating OnlineGlom but they're also good
3188 supplemental documentation of the build and deployment proceeding.
3190 * utils/build-onlineglom-war.sh: New file.
3191 * utils/install-onlineglom-war.sh: New file.
3193 2011-06-16 Ben Konrath <ben@bagu.org>
3195 Create wrapper class to create consistent log messages.
3197 I wrapped methods in the Log class of gwt-log to add the method names
3198 from the servlet and create consistent formatting of the document title
3199 and table names in the log messages.
3201 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3203 log methods to use methods from wrapped Log class.
3205 2011-06-16 Ben Konrath <ben@bagu.org>
3207 Remove superfluous conditional return.
3209 Thanks to Murray Cumming for pointing this out!
3211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3213 2011-06-15 Ben Konrath <ben@bagu.org>
3215 Return an ArrayList of LayoutGroups for the Details layout.
3217 This corrects a problem with the details layout as it can have more
3218 than one top level LayoutGroup.
3220 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3221 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
3222 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
3223 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
3224 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
3225 with ArrayList of LayoutGroups for the details view layout.
3226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3227 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
3228 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
3229 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
3230 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
3231 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
3233 2011-06-14 Ben Konrath <ben@bagu.org>
3235 Use cast_dynamic method to determine the libglom LayoutItem type.
3237 This is better than finding the LayoutItem type by using the string
3238 returned from the get_part_type_name() method.
3240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3242 2011-06-14 Ben Konrath <ben@bagu.org>
3244 Add method names to log entries in the servlet.