1 2012-07-21 Murray Cumming <murrayc@murrayc.com>
3 tests: Add SelfHostConfiguredDocumentTest
5 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
6 username and password, for use by ConfiguredDocument.
7 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
8 This tests some of the ConfiguredDocument API that requires a database connection.
10 2012-07-21 Murray Cumming <murrayc@murrayc.com>
12 Document: Load title translations and test them.
14 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
15 of titles. I am surprised that we do not do this yet.
16 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
17 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
18 Test translations more.
20 2012-07-20 Murray Cumming <murrayc@murrayc.com>
24 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
25 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
26 Set the timeout here too.
28 2012-07-20 Murray Cumming <murrayc@murrayc.com>
30 tests: ConfiguredDocumentTest: Make this pass.
32 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
33 Disable tests that need a database connection.
35 2012-07-20 Murray Cumming <murrayc@murrayc.com>
37 Use Java 1.7 instead of Java 1.6.
39 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
40 to do this twice, at least for Eclipse.
41 This seems OK because it is the current version.
43 2012-07-20 Murray Cumming <murrayc@murrayc.com>
47 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
48 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
49 Avoid using a null Connection.
51 2012-07-20 Murray Cumming <murrayc@murrayc.com>
53 tests: Add a ConfiguredDocument test.
55 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
58 2012-07-20 Murray Cumming <murrayc@murrayc.com>
60 LayoutItemFIeld: getName(): Use the Field if it is set.
62 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
63 getName(): If the full field details have been set, return its name, so that
64 callers do not need to set the name separately.
65 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
66 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
67 so we can count the rows.
69 2012-07-20 Murray Cumming <murrayc@murrayc.com>
71 tests: SelfHoster: Test SqlUtils too.
73 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
74 Retrieve some data and check it too, as in the regular Glom
75 test_selfhosting_new_from_example.cc test.
76 * src/test/java/org/glom/web/server/SelfHoster.java:
77 createConnection(): Make this public.
79 2012-07-20 Murray Cumming <murrayc@murrayc.com>
81 tests: SelfHoster: createConnection(): Do not warn about expected failures.
83 Let the caller say if the connection is expected to fail, to avoid
84 irrelevant error output.
86 2012-07-20 Murray Cumming <murrayc@murrayc.com>
88 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
90 * src/test/java/org/glom/web/server/SelfHoster.java:
91 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
92 due to the inevitable need to retry the connection while the database server
95 2012-07-20 Murray Cumming <murrayc@murray.com>
97 tests: SelfHoster: createConnection(): Set a timeout.
99 * src/test/java/org/glom/web/server/SelfHoster.java:
100 createConnection(): Use setLoginTimeout() because it otherwise seems to take
101 ages to actually return when it fails.
103 2012-07-20 Murray Cumming <murrayc@murrayc.com>
105 tests: SelfHoster: selfHost(): Close the test connection.
107 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
108 When we check that the connection works, close the connection. This seems
109 to not be closed automatically otherwise.
111 2012-07-20 Murray Cumming <murrayc@murrayc.com>
113 Use slf4j-simple to see JDBC errors.
115 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
117 2012-07-19 Murray Cumming <murrayc@murrayc.com>
119 SelfHoster.discoverFirstFreePort(): Close the socket.
121 * src/test/java/org/glom/web/server/SelfHoster.java:
122 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
124 2012-07-19 Murray Cumming <murrayc@murrayc.com>
126 Avoid another code warning in Eclipse Juno.
128 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
129 Do instanceof checks on the FileUtils.listFiles() result and its
132 2012-07-13 Murray Cumming <murrayc@murrayc.com>
134 Avoid some code warnings in Eclipse Juno
136 * src/main/java/org/glom/web/server/libglom/Document.java:
137 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
138 * src/test/java/org/glom/web/server/SelfHoster.java
139 createTextFile(): Make sure that the FileOutputStream is closed.
141 2012-06-22 Murray Cumming <murrayc@murrayc.com>
143 Added OnlineGlomPropertiesTest.
145 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
146 Make sure we never return a null string.
147 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
148 Added tests of the OnlineGlomProperties API, using our sample file.
150 2012-06-20 Murray Cumming <murrayc@murrayc.com>
152 Make OnlineGlomProperties be a normal class.
154 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
155 Move OnlineGlomProperties into its own file to be a regular class:
156 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
157 This makes testing simpler.
159 2012-06-15 Murray Cumming <murrayc@murrayc.com>
161 OnlineGlomServiceImpl.init(): Move some code into a new method.
163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
164 Create addDocument().
166 2012-06-15 Murray Cumming <murrayc@murrayc.com>
168 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
170 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
171 OnlineGlomProperties.getKey(): Make this more robust by moving the
172 check for *.*.filename to here.
174 2012-06-15 Murray Cumming <murrayc@murrayc.com>
176 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
179 init(): Move knowledge of the config file format into the
180 OnlineGlomProperties inner class.
182 2012-06-15 Murray Cumming <murrayc@murrayc.com>
184 SelfHostExampleTest: Make sure we cleanup on failure.
186 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
187 the use of cleanup() to a tearDown() JUnit method.
189 2012-06-12 Murray Cumming <murrayc@murrayc.com>
191 ConfiguredDocument: Add a primary key to portals at least once.
193 * src/main/java/org/glom/web/server/ConfiguredDocument.java
194 updatePortalsExtras): Fix a typo so that we add the primary key
195 column at least once.
196 This is a fix for the previous commit:
197 ConfiguredDocument: Do not add a primary key to portals each time.
199 2012-06-08 Murray Cumming <murrayc@murrayc.com>
201 SelfHoster: Avoid some compiler warnings.
203 * src/test/java/org/glom/web/server/SelfHoster.java
204 executeCommandLineAndWait():
205 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
206 the now-unused streams for stdout and stderr from the command Processes.
207 These are not used because readln() hangs while waiting for a new line,
208 where there may be no next line. The commented out code is still there
209 to help us figure out how to do this properly.
211 2012-06-08 Murray Cumming <murrayc@murrayc.com>
213 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
215 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
216 Make this actually test the cloning again, though it is not very useful
217 now that we do not use the part that had a problem with cloning before.
219 2012-06-08 Murray Cumming <murrayc@murrayc.com>
221 SelfHoster: Keep trying pg_ctl after starting postgres.
223 * src/test/java/org/glom/web/server/SelfHoster.java
224 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
225 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
226 regular Glom. This seems mad but it seems to work because the first
227 command would fail if pg_ctl would eventually fail.
229 2012-06-08 Murray Cumming <murrayc@murrayc.com>
231 SelfHoster: Wait until the server is really ready.
233 * src/test/java/org/glom/web/server/SelfHoster.java
234 selfHost(): Attempt the connection after starting the server, retrying
235 a few times if necessary, so that the server is really ready already when
236 we return from this method.
237 The regular Glom code does this too because pg_ctl reports success too soon.
239 2012-06-08 Murray Cumming <murrayc@murrayc.com>
241 ConfiguredDocument: Do not add a primary key to portals each time.
243 * src/main/java/org/glom/web/server/ConfiguredDocument.java
244 updatePortalsExtras(): Only add an extra primary key field if there is
245 none, to avoid adding one each time we retrieve the details layout from the
247 This should fix bug #676986 (Ben Konrath)
249 2012-05-25 Murray Cumming <murrayc@murrayc.com>
251 Document.load(): Support version 7 documents.
253 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
254 database_title attribute if the title attribute is not there.
257 2012-05-24 Ben Konrath <ben@bagu.org>
259 Add configuration for auto-generating mvn:i18n from with Eclipse.
261 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
263 2012-05-24 Murray Cumming <murrayc@murrayc.com>
265 Update translations, adding French.
267 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
268 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
269 Add a French translation, using the translation from Glom.
271 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
272 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
273 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
274 Update these based on the translations from Glom.
276 2012-05-24 Murray Cumming <murrayc@murrayc.com>
278 SelfHoster: Add some debug println messages to help when things fail.
280 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
281 System.out.println() lines.
283 2012-05-23 Murray Cumming <murrayc@murrayc.com>
285 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
287 * src/test/java/org/glom/web/server/SelfHoster.java:
288 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
289 instance) instead of just /usr/bin (as on Fedora). Check the result when
292 2012-05-23 Murray Cumming <murrayc@murrayc.com>
294 Remove LayoutItemPortal.get/setNavigationTable().
296 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
297 Remove get/setNavigationTable(), which is only a cache, because it is not
298 used, and does not need to be used, because that decision should be made on
300 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
301 updatePortalsExtras():
302 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
303 getNavigationRecord():
304 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
307 2012-05-21 Murray Cumming <murrayc@murrayc.com>
309 Initial self-hosting for tests.
311 * pom.xml: Change the scope for log4j, to hopefully make it
312 available to the test code which uses it indirectly via jOOQ.
313 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
314 self-hosting, though we only use it for testing.
316 * src/main/java/org/glom/web/server/libglom/Document.java:
317 example rows: Use a map instead of a list for each row of values,
318 so we know what field they are for, instead of relying on the sequence
319 being correct. This is not very efficient, but it does not really need
321 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
322 testReadTableExampleRows(): Adapted.
324 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
325 that returns an Object, for generic use. Note that Object seems to be
326 the implicit base even of double.
327 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
328 for use in CREATE TABLE SQL queries.
329 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
330 to do self-hosting of PostgreSQL databases via its command-line
331 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
332 backends/postgres_self.cc. This is incomplete - it needs more
333 warnings about failures and it needs to clean up properly when things
335 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
336 test of this new class.
338 2012-05-21 Murray Cumming <murrayc@murrayc.com>
340 Document: loading example data: Handle exceptions.
342 * src/main/java/org/glom/web/server/libglom/Document.java:
343 DateFormat.parse() and Double.valueOf() can throw exceptions, though
344 Eclipse did not warn about that.
346 2012-05-20 Murray Cumming <murrayc@murrayc.com>
348 Document: load(), save(): Handle the example rows.
350 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
352 * src/main/java/org/glom/web/server/libglom/Document.java:
353 load(), save(): Load and save the example rows, though the date, time
354 and image types are not handled properly yet.
355 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
356 Add testReadTableExampleRows() just to check that something is read.
358 2012-05-20 Murray Cumming <murrayc@murrayc.com>
360 Document: Add save().
362 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
363 Added getTranslationsMap() for use while saving.
364 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
365 Adedd getUseDefaultFormatting() for use while saving.
366 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
367 and several private methods that it uses.
369 This will be useful while testing via self-hosting.
370 It is not complete, but should be complete enough for testing.
372 2012-05-17 Murray Cumming <murrayc@murrayc.com>
374 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
376 * src/main/java/org/glom/web/client/OnlineGlomService.java
377 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
378 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
379 Remove getSortedListViewData() and getSortedRelatedListData(), adding
380 the sort column index and ascending bool to the regular method.
381 Instead, a sort column index of -1 now means no sort.
382 This is less explicit, but it's fairly simple, reduces the amount of
383 code, and makes the OnlineGlomService API slightly smaller.
384 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
385 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
387 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
388 getListViewData(), getRelatedListData():
389 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
390 getListViewData(), getRelatedListData():
391 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
393 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
395 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
400 2012-05-16 Murray Cumming <murrayc@murrayc.com>
402 Use translations for top-level groups too.
404 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
405 updateTitlesForLocale(): Use the translation for the group
406 as well as for child items.
410 Just recompiled to fix a problem in the released .tar.gz file.
414 2012-05-15 Murray Cumming <murrayc@murrayc.com>
416 Corrections to navigation to related records.
418 * src/main/java/org/glom/web/client/OnlineGlomService.java:
419 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
420 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
421 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
422 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
423 relationship name, because the relationship name is not necessarily unique
425 TOOD: This is inefficient, because it passes the whole list of
426 child field items back to the server, but it is more correct, and happens
427 to fix a bug with the primary key being lost after a few navigations.
428 There is probably a chance to make this more efficient anyway in some
431 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
432 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
433 * src/main/java/org/glom/web/server/ConfiguredDocument.java
434 * src/main/java/org/glom/web/server/database/DBAccess.java
435 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
436 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
439 2012-05-15 Murray Cumming <murrayc@murrayc.com>
441 Fix the use of translations.
443 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
444 Add updateTitlesForLocale().
445 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
446 Call it to discard unwanted translations and to make getTitle() return
447 the wanted translation wihout the need for the client code to specify a locale.
448 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
449 getTitle(): Fallback to the original title, as libglom does.
451 2012-05-15 Murray Cumming <murrayc@murrayc.com>
453 Document: Correctly report the number of available translation locales.
455 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
456 the available locale IDs list.
457 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
458 testLocales: Test this.
460 2012-05-15 Murray Cumming <murrayc@murrayc.com>
462 SqlUtils: Use camelCase.
464 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
465 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
466 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
467 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
468 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
469 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
471 2012-05-15 Murray Cumming <murrayc@murrayc.com>
473 Use jOOQ's tableByName() and fieldByName.
475 * pom.xml: Use jOOQ 2.3.1 to get the new API.
476 * src/main/java/org/glom/web/server/SqlUtils.java:
477 build_sql_select_step_with_where_clause(), .createField(),
478 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
479 so we can get correct quoting and escaping. Thanks to Lukas Eder for
480 adding this, and other things, to jOOQ.
482 2012-05-15 Murray Cumming <murrayc@murrayc.com>
484 SqlUtils: Remove the Connection parameters.
486 * src/main/java/org/glom/web/server/SqlUtils.java:
487 build_sql_select_with_key(), build_sql_select_with_where_clause(),
488 createSelect(), build_sql_select_step_with_where_clause(),
489 build_sql_count_select_with_where_clause(),
490 build_sql_select_count_rows(): Remove the Connection parameter because
491 jOOQ does not actually need a connectionwhen it is just used to build
493 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
495 * src/main/java/org/glom/web/server/ReportGenerator.java:
497 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
499 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
500 Constructor, getListData(), getResultSizeOfSQLQuery():
501 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
502 getSelectQuery(), getCountQuery():
503 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
504 getSelectQuery(), getCountQuery():
505 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
506 getNavigationRecord(): Adapted.
508 2012-05-14 Murray Cumming <murrayc@murrayc.com>
512 * src/main/java/org/glom/web/server/SqlUtils.java:
513 get_find_where_clause_quick(): Use a comparison of
514 lowercase values, instead of a simple equals. Regular Glom
515 uses the PostgreSQL ILIKE operator but jOOQ does not
516 support that just yet, though it will soon.
518 2012-05-14 Murray Cumming <murrayc@murrayc.com>
520 TableToViewDetails: Use a real serialization ID.
522 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
523 Though this does not fix the serialization problem.
525 2012-05-12 Murray Cumming <murrayc@murrayc.com>
527 Added LayoutItemPortalDeepCloneTest.
529 2012-05-11 Murray Cumming <murrayc@murrayc.com>
531 Make navigation work again.
533 * src/main/java/org/glom/web/server/libglom/Document.java:
534 Add getLayoutItemFieldShouldHaveNavigation().
535 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
536 Replace get/setAddNavigation() with the partly-existing
537 get/setNavigationTableName(), with an empty string being no navigation,
538 because this is simpler. Use the new
539 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
541 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
542 Add updateFieldsExtras() and call setNavigationTableName in it.
543 getDetailsLayoutGroup(),
544 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
545 createLayout(): Adapted.
546 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
547 Constructor: Adapted.
549 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
550 Replace get/setAddNavigation() with get/setNavigation(), returning a
551 TableToViewDetails class with both the table name and UsesRelationship,
552 because both are need. The previous code used java-libglom's output
553 variable (strangely, via sharedptr) to return both, but we cannot really
555 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
556 getNavigationRecord(): Adapt. However, we cannot actually use the cache
557 here because it somehow gets set to null during deepCopy(). I must test this.
558 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
559 testGetSuitableTableToViewDetails(): Adapted.
561 TODO: Find out why deepClone() is not quite working.
563 2012-05-11 Murray Cumming <murrayc@murrayc.com>
565 DBAccess: Simplify the retrievel of full field details.
567 * src/main/java/org/glom/web/server/database/DBAccess.java
568 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
569 because the Document loading should have done this.
571 2012-05-11 Murray Cumming <murrayc@murrayc.com>
573 Document: Correct loading of doubly-related layout fields.
575 * src/main/java/org/glom/web/server/libglom/Document.java:
576 loadUsesRelationship(): Actually set the related relationship, instead
577 of only setting it if it's not found.
579 2012-05-09 Murray Cumming <murrayc@murrayc.com>
581 Replace all appearances of Colour with color.
583 Because US English is dominant.
585 2012-05-09 Murray Cumming <murrayc@murrayc.com>
587 Use colors in HTML format, solving a warning about an unused function.
589 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
590 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
591 Add *asHTMLColor() versions of methods.
592 TODO: However, we should create and cache the results on the server.
593 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
594 * src/main/java/org/glom/web/client/ui/list/ListTable.java
595 * src/main/java/org/glom/web/server/ConfiguredDocument.java
596 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
597 Use the asHTMLcolor() versions.
599 2012-05-09 Murray Cumming <murrayc@murrayc.com>
601 ListViewTable: Constructor: Take the table name as a parameter.
603 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
604 Constructor: Take the tableName, and set the member variable, because
606 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
607 setCellTable(): Pass the table name.
608 This makes navigation to non-default tables work again. I don't know
609 why it worked before in the master branch.
611 2012-05-07 Murray Cumming <murrayc@murrayc.com>
613 ConfiguredDocument: Restore correct addition of hidden primary key items.
615 * src/main/java/org/glom/web/client/ui/list/ListTable.java
616 (ListTable.createCellTable): Uncomment out the check for the hidden
618 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
619 add primary key items for top-level lists and portals, as before,
620 instead of adding them to each group.
621 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
622 Actually implement the extra methods such as setHiddenPrimaryKey() and
623 comment that these are used only for top-level list groups and in portals.
624 This strangeness suggests even more that this should not be squeezed
625 into the LayoutGroup class.
627 2012-05-07 Murray Cumming <murrayc@murrayc.com>
629 Fix Formatting loading.
631 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
632 getFormattingUsed(): Remove the duplicate Formatting member variable
633 in favour of the one from the base class.
634 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
635 Initialize a new Formatting instead of using null by default, so we
636 have some defaults, instead of having to initialize one later just to
637 get the same defaults. This also makes loading of formatting from the
638 document work, because that expected a non-null.
640 2012-05-07 Murray Cumming <murrayc@murrayc.com>
642 RelatedListTable: Make sure that the tableName is set.
644 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
645 Constructor: Take the tableName so it is available later. Otherwise,
646 the server assumes that we mean the default table and cannot find the
648 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
649 setData(): Pass the tableName to the RelatedListTable constructor.
651 2012-05-07 Murray Cumming <murrayc@murrayc.com>
655 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
656 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
657 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
659 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
661 * src/main/java/org/glom/web/server/database/DBAccess.java:
662 convertResultSetToDTO(), getPortal():
663 * src/main/java/org/glom/web/server/database/ListDBAccess.java
665 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
666 Add checks for null objects and out of range access, with log messages to
667 give hints so we can fix these properly.
669 2012-05-07 Murray Cumming <murrayc@murrayc.com>
671 Portals: some corrections.
673 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
675 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
676 constructor: Use getRelationshipNameUsed() instead of getName(), because
677 that is what is meant.
678 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
679 getFromField(): Fix a typo, to get the field name, not the table name.
680 * src/main/java/org/glom/web/server/database/DBAccess.java:
681 getPortal(): Fix a typo that stopped this from working.
683 2012-05-07 Murray Cumming <murrayc@murrayc.com>
685 LayoutItemPortal: Also override getTitleOriginal().
687 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
688 This lets the base getTitle() with no parameters work.
689 TODO: Test this properly.
691 2012-05-06 Murray Cumming <murrayc@murrayc.com>
693 LayoutItemPortal: getTitle*(): Use the relationship title.
695 2012-05-06 Murray Cumming <murrayc@murrayc.com>
697 LayoutItemField: Fix loading of custom titles.
699 * src/main/java/org/glom/web/server/libglom/Document.java
700 loadDataLayoutItemField(): The title, if any, instead of the field
701 title, is stored in a title_custom node. Load it from there.
702 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
704 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
705 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
706 getTitle*() overrides.
707 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
710 2012-05-06 Murray Cumming <murrayc@murrayc.com>
712 LayoutItemField: Fall back to field titles, so some are really shown.
714 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
715 Override getTitleOriginal() and getTitle(), as in java-libglom.
716 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
719 2012-05-06 Murray Cumming <murrayc@murrayc.com>
721 Correct use of setExpectedResultSize().
723 * src/main/java/org/glom/web/server/ConfiguredDocument.java
724 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
725 Use setExpectedResultSize only on top-level groups (for instance, the
726 list layout) or on child portals (in details views).
727 Use the correct table name for portals to avoid SQL errors.
728 Update the expected counts when returning cached layouts.
730 2012-05-06 Murray Cumming <murrayc@murrayc.com>
732 Document: Interpret no group column count as 1.
734 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
735 default, though we now check for this in the UI code anyway.
737 2012-05-06 Murray Cumming <murrayc@murrayc.com>
741 2012-05-06 Murray Cumming <murrayc@murrayc.com>
743 Translatable: Use Hashmap instead of Treemap because GWT supports it.
745 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
746 The use of Treemap lead to this error from async methods, with no
748 "The response could not be deserialized"
750 2012-05-06 Murray Cumming <murrayc@murrayc.com>
752 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
754 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
755 when using the Google -> GWT Compile, or
756 g toolbar button -> GWT Compile Project... feature in Eclipse.
758 2012-05-06 Murray Cumming <murrayc@murrayc.com>
760 ListTable.addColumn(): Protect against a null Formatting.
762 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
763 Create a default Formatting if it is null, because that is the simplest
766 2012-05-06 Murray Cumming <murrayc@murrayc.com>
768 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
770 * src/main/java/org/glom/web/server/ConfiguredDocument.java
771 updateLayoutGroup(): Check that the field is not null.
773 2012-05-06 Murray Cumming <murrayc@murrayc.com>
775 ListViewImpl: Protected against a bad cast error.
777 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
778 onEnterKeyDown(): Do not cast without an instanceof check.
780 2012-05-06 Murray Cumming <murrayc@murrayc.com>
782 ListTable: Protect against an out of range error.
784 * src/main/java/org/glom/web/client/ui/list/ListTable.java
785 createCellTable(): This is unlikely, but can happen while debugging.
787 2012-05-06 Murray Cumming <murrayc@murrayc.com>
789 AsyncMessage onFailure() callbacks: Log the exception message.
791 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
792 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
793 * src/main/java/org/glom/web/client/activity/ListActivity.java:
794 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
795 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
796 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
797 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
798 These are useful clues when something is wrong.
800 2012-05-06 Murray Cumming <murrayc@murrayc.com>
802 ConfiguredDocument: Avoid a null dereference.
804 * src/main/java/org/glom/web/server/ConfiguredDocument.java
805 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
806 details maps are created.
808 2012-05-06 Murray Cumming <murrayc@murrayc.com>
810 Document: Correct the port number parsing.
812 * src/main/java/org/glom/web/server/libglom/Document.java:
813 This lets us actually connect to the database and show the document.
815 2012-05-05 Murray Cumming <murrayc@murrayc.com>
819 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
820 user-interaction, asking us to load a temporary URL in a browser.s
821 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
822 which is apparently necessary for testing the service. See the comment.
823 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
824 Show the exception, if any. This is how I saw the 404 in the HTML in
827 2012-05-05 Murray Cumming <murrayc@murrayc.com>
829 DocumentTest: Move the .glom files into the resources directory.
831 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
832 URI via getResource().
834 2012-05-05 Murray Cumming <murrayc@murrayc.com>
836 Document: Remove the FieldIdentifies inner class.
838 * src/main/java/org/glom/web/server/libglom/Document.java: We only
839 use the Relationship (though the same function in libglom is maybe
840 used in other ways) and so this removes a compiler warning.
842 2012-05-05 Murray Cumming <murrayc@murrayc.com>
844 Document.load() Remove the error code parameter.
846 * src/main/java/org/glom/web/server/libglom/Document.java: load():
847 Remove the parameter. We do not set it yet and it could never have
848 worked as an output parameter (though maybe it did in java-libglom).
849 We could use an exception if we really want the failure reason.
850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
852 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
853 setUp(), testGetSuitableTableToViewDetails(): Adapt.
855 2012-05-05 Murray Cumming <murrayc@murrayc.com>
857 Make some inner classes static.
859 * src/main/java/org/glom/web/server/ConfiguredDocument.java
860 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
861 * src/main/java/org/glom/web/server/ReportGenerator.java
862 * src/main/java/org/glom/web/server/libglom/Document.java
863 Make all inner classes static that can be static.
865 2012-05-05 Murray Cumming <murrayc@murrayc.com>
867 OnlineGlomServiceImpl: Do not load and check for java-libglom.
869 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
870 init(): We do not use java-libglom any more.
872 2012-05-05 Murray Cumming <murrayc@murrayc.com>
874 Remove mentions of java-libglom.
876 * README: Remove mention of java-libglom, because it no longer needed.
877 * utils/build-onlineglom-war.sh:
878 * utils/check-and-recover-tomcat.py:
879 * utils/install-onlineglom-war.sh: Remove these as they are no longer
880 useful. Building is now far easier, with no need for jhbuild.
882 2012-05-05 Murray Cumming <murrayc@murrayc.com>
884 Fix the build (mvn package)
886 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
887 (LayoutGroup): Make the LayoutItemList inner class static and protected.
888 Otherwise the GWT Java->Javascript compilation fails with just this
889 error, during mvn package or when attempting to view in a browser,
890 in the GWT developer mode in Eclipse.
892 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
893 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
894 [INFO] Compiling module org.glom.web.OnlineGlom
895 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
896 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
897 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
898 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
899 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
900 [INFO] [ERROR] Cannot proceed due to previous errors
902 It has taken me 2 days to find out what was causing that. After reducing
903 the code, the compiler eventually showed me the full error message.
905 2012-05-04 Murray Cumming <murrayc@murrayc.com>
907 ConfiguredDocument: Cache the cloned and stripped layouts.
909 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
910 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
911 layout in a map, so we can retrieve it again without rebuilding it.
913 2012-05-04 Murray Cumming <murrayc@murrayc.com>
915 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
917 2012-05-04 Murray Cumming <murrayc@murrayc.com>
919 libglom classes: Implement some auto-generated emthods.
921 2012-05-04 Murray Cumming <murrayc@murrayc.com>
923 Add GwtTestOnlineGlomService.
925 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
926 However, this (and the other GwtTest*) does not seem to run during
929 2012-05-04 Murray Cumming <murrayc@murrayc.com>
931 Remove use of unsupported features from client code.
933 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
934 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
935 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
936 Use our client version of StringUtils instead of the apache commons one.
938 However, the GWT Javascript compliation still fails.
940 2012-04-25 Murray Cumming <murrayc@murrayc.com>
942 Add a Field class and implement some loading of it in Document.
944 2012-04-25 Murray Cumming <murrayc@murrayc.com>
946 Initial Document loading implementation, instead of libglom.
948 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
949 and Translatable classes, and adapt the rest of the code to use them.
950 However, this is still missing Layout and Field classes and loading.
952 2012-04-24 Murray Cumming <murrayc@murrayc.com>
954 Use of jOOQ: Move Field creation into a utility method.
956 * src/main/java/org/glom/web/server/SqlUtils.java:
957 This lets us improve it more easily.
959 2012-04-24 Murray Cumming <murrayc@murrayc.com>
961 Use of jOOQ: Improve the code to COUNT a sub-select.
963 * src/main/java/org/glom/web/server/SqlUtils.java:
964 Move initial query creation into
965 build_sql_select_step_with_where_clause().
966 build_sql_select_count_rows(): Use the jOOQ API instead of
967 concatentating text, because a jOOQ Select*Step is a TableLike,
968 which is what from() takes.
970 2012-04-23 Murray Cumming <murrayc@murrayc.com>
972 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
974 * pom.xml: Depend on jooq.
975 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
976 methods with jOOQ, based on the C++ implementations in libglom,
977 with some changes to the logic required by jooQ.
978 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
980 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
981 * src/main/java/org/glom/web/server/ReportGenerator.java:
982 * src/main/java/org/glom/web/server/SqlUtils.java:
983 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
984 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
985 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
986 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
987 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
988 Adapt. In particular, the SqlUtils methods now need to take a Connection,
989 because jOOQ needs that, though it seems unnecessary.
991 This is not quite finished. Ideally jOOQ would help us to build
992 table_name.field_name names, quoting and escaping them properly.
993 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
995 2012-04-21 Murray Cumming <murrayc@murrayc.com>
997 Move use of Glom.build_sql*() into a new SqlUtils class.
999 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1000 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1001 but this will make it easier to start using something other than
1002 libglom or SqlBuilder.
1004 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1006 Update the project URL.
1008 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1010 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1012 Main layout: Use a FlowTable instead of absolute positioning.
1014 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1015 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1016 child panels/widgets must have an absolute position. But that is annoying, so
1017 this adds a FlowTable and puts the child panels in there.
1019 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1021 GwtTestOnlineGlom: Comment out unused code.
1023 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1024 Eclipse has started to say that some code is unused.
1026 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1028 Update to the latest versions of dependencies.
1030 * pom.xml: Update version numbers of dependencies to the latest
1032 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1034 * src/main/java/org/glom/web/server/ReportGenerator.java:
1035 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1036 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1037 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1039 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1040 Modify the imports where necessary.
1042 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1044 Style: Remove overflow:hidden from searchbox
1046 * src/main/webapp/style.css: Because this pushes the Back To Link
1047 label/link on to the next row, which is then hidden due to the
1048 hard-coded (in ems) height.
1050 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1052 Remove some duplicate code.
1054 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1055 getDocumentInfo(): This must have been duplicated during the merge from the
1060 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1062 Reports: Localize the waiting for report message.
1064 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1065 start(): Get the message from the contants.
1066 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1067 Add the string here.
1068 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1069 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1070 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1071 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1072 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1073 Update these files with the English text for newer strings for now.
1075 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1077 Reports: Show a message while waiting for the report.
1079 * src/main/java/org/glom/web/client/ui/ReportView.java
1080 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1081 Add setWaitingText(), to show a message saying that we are
1082 waiting for the report to be ready.
1083 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1084 start(): Call setWaitingText() before calling the async
1087 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1089 ReportGenerator: Specify date and time formats.
1091 * src/main/java/org/glom/web/server/ReportGenerator.java:
1092 createFieldValueElement(): Use the default (and localized)
1093 short formats, though we still need a way to show 4-digit
1094 years without providing the format for every locale.
1095 * src/main/java/org/glom/web/server/database/DBAccess.java:
1096 convertResultSetToDTO(): Use the short formats here too.
1098 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1100 ReportGenerator: Use the correct numeric formatting.
1102 * src/main/java/org/glom/web/server/ReportGenerator.java
1103 createFieldExpression(), createFieldValueElement(): Take the
1104 whole LayoutItem_Field instead of just the field name, so
1105 we have access to the formatting.
1106 createFieldValueElement(): Use JRTextField.setPattern() to
1107 specify the numeric formatting, with the help of a
1108 regular DecimalFormat.
1110 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1112 ReportGenerator: Avoid showing null for group by titles.
1114 * src/main/java/org/glom/web/server/ReportGenerator.java
1115 generateReport(): Use setBlankWhenNull() on the field title
1116 style too, because this is used for values in group by
1119 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1121 ReportGenerator: Add a colon to titles in vertical groups.
1123 * src/main/java/org/glom/web/server/ReportGenerator.java
1124 addFieldToDetailBandVertical(): Pass true for the withColon
1127 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1129 ReportGenerator: Simplify the code by using Position more.
1131 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1133 Reports: Support vertical groups, roughly.
1135 * src/main/java/org/glom/web/server/ReportGenerator.java:
1136 addToReport(): Rename to addGroupToReport() and, if necessary,
1137 call the new addVerticalGroupToReport() method.
1138 createFieldValueElement(): Let the caller specify the Y position
1141 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1143 Reports: Allow a second report to be shown.
1145 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1146 clear(): Do not remove the HTML widget, which broke the whole layout.
1148 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1150 Locales drop-down: Show that we use English by default.
1152 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1153 fillView(): When we use English, just because that is the default, when
1154 no locale is specified, show that in the Locales drop-down instead of
1155 just showing the first item.
1157 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1159 Unselect the Report/Locale/Table combo item when appropriate.
1161 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1162 setPlace(): clear reportName if this is not a ReportPlace.
1163 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1164 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1165 When the provided name is empty, unselect all items, so that none are
1166 indicated. This uses a for loop because I cannot find a single method
1169 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1171 Report: Give the user a way to get back to the list.
1173 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1174 start(), setPlace(): Show the Back To List link on reports, and also
1175 interpret selecting the empty report item as back to list.
1177 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1179 Really show the selected Report name.
1181 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1182 setPlace(): Store the reportName here, if it is that kind of Place.
1183 fillView(): Set the selected Report after filling the list of reports.
1184 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1185 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1186 null Strings, though we need some way to unselect all ListBox items
1189 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1191 ReportGenerator: Try to avoid some problems.
1193 * src/main/java/org/glom/web/server/ReportGenerator.java
1194 addField(): Try to avoid duplicates, and avoid using a null
1197 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1199 Reports: Use quickFind.
1201 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1202 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1204 getReportHTML(): Add a quickFind parameter.
1205 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1206 start(): Pass the quickFind parameter.
1207 * src/main/java/org/glom/web/server/ReportGenerator.java
1208 generateReport(): Take a quickFind parameter.
1210 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1212 ReportPlace: Actually use the report name.
1214 * src/main/java/org/glom/web/client/place/ReportPlace.java
1215 getPlace(): Do not assign the report name to the quickfind.
1217 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1219 Show java.library.path when complaining.
1221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1222 init(): When telling us to check java.library.path, show the
1225 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1227 ReportGenerator: Do not show nulls.
1229 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1231 ReportGenerator: Make the title font larger.
1233 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1235 ReportGenerator: Put field titles inside groups, if there are groups.
1237 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1239 ReportGenerator: Take the Report itself instead of the name and group.
1241 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1242 Remove getReportLayoutGroup().
1243 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1244 getReportHTML(): Pass the report instead
1245 of its name and layout group.
1246 * src/main/java/org/glom/web/server/ReportGenerator.java
1247 generateReport(): Use the report object to use the title
1248 instead of the name.
1250 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1252 ReportGenerator: Remove designBand parameters.
1254 * src/main/java/org/glom/web/server/ReportGenerator.java:
1255 Make designBand a class member instead of passing it to all
1258 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1260 ReportGenerator: Add lines, a bit like in the desktop version.
1262 * src/main/java/org/glom/web/server/ReportGenerator.java
1263 addToReport(): Use JRDesignLine.
1265 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1267 ReportGenerator: Correct the title positions and use some bold style.
1269 * src/main/java/org/glom/web/server/ReportGenerator.java:
1270 Break the code up into reusable functions, correct the placement of
1271 titles, and use normal/bold styles as in the reports in the desktop
1274 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1276 ReportGenerator: Add a header band to show the field titles.
1278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1279 getReportHTML(): Pass the localeId to the ReportGenerator
1281 * src/main/java/org/glom/web/server/ReportGenerator.java
1282 constructor: Take the localeID so we can get translated field
1284 generateReport(), addToReport(), addFieldToBand(): Add field
1285 titles in a column header band.
1287 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1289 Reports drop-down list: Some improvement.
1291 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1292 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1293 Adedd setSelectedReport(),
1294 setReportList(): Add a blank line so that the user can select the
1296 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1297 start(): Show the current report by calling setSelectedReport().
1298 This does not seem to work yet.
1300 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1302 DetailsActivity, ListActivity: Move some variables into a base class.
1304 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1305 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1306 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1307 the clientFactory, documentID, tableName and authenticationPopup into
1308 a base class, to avoid duplication.
1310 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1312 Translate the Reports label.
1314 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1315 Get the "Reports" label string from the constants.
1316 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1317 perties: Add Reports to the constants.
1319 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1321 Reports: Implement grouping.
1323 * src/main/java/org/glom/web/server/ReportGenerator.java:
1324 Handle LayoutItem_GroupBy items and try to do the right thing
1325 with JRDesignGroup. It seems to work.
1327 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1329 Actually show some data with JasperReports.
1331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1332 getReportHTML(): Move most code into a ReportGenerator class.
1333 * src/main/java/org/glom/web/server/ReportGenerator.java:
1334 Recurse into sub-groups, adding fields to the JasperDesign's details
1335 band. Note that we must set an arbitrary width and height, or it just
1336 will not show any data.
1338 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1340 Reports Chooser: Show the titles, not the names.
1342 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1343 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1344 and the names as the values.
1345 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1346 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1347 group now that we provide the report name, so it should always
1350 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1352 Depend on jasperreports.
1354 * pom.xml: Add the dependency. My plan is to use this on the
1357 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1359 Implement navigation to report places.
1361 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1362 start(): Do not bother to handle all events here.
1363 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1364 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1365 Added getSelectedReport().
1366 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1367 .java: start(): When handling a change to the reports chooser,
1368 call getSelectedReport() and goTo() its ReportPlace.
1369 * src/main/java/org/glom/web/client/ui/ReportView.java
1370 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1371 Added setReportHTML() which puts the html in a gwt HTML widget.
1372 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1373 getReportHTML(): Return "TODO" just to show that this works.
1375 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1377 Make ReportPlace usable.
1379 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1380 Mention ReportPlace.
1381 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1382 Correct the @prefix annotation.
1384 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1386 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1388 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1389 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1390 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1391 Change getReportLayout() to getReportHMTL() because we will not need to
1392 parse or render the report layout on the client side.
1393 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1394 getReportLayout(): Return the libglom LayoutGroup type because we will
1395 not need to convert to a shared type, because this will not be used on
1397 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1400 Note that there is still no implementation for this.
1403 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1405 Add a (empty) Report Place, View, and Activity.
1407 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1409 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1410 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1411 this into a superclass:
1412 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1413 and also use it as the base of this new ReportPlace:
1414 * src/main/java/org/glom/web/client/place/ReportPlace.java
1416 * src/main/java/org/glom/web/client/ui/ReportView.java
1417 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1418 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1419 Add these, containing mostly boiler-plate for now.
1421 * src/main/java/org/glom/web/client/OnlineGlomService.java
1422 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1423 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1424 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1425 Add API to get the LayoutGroup for the report.
1427 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1429 Add and fill a Reports drop-down list box.
1431 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1433 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1434 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1435 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1436 Added getReports(document, table, localeID), calling
1437 ConfiguredDocument.getReports().
1438 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1439 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1440 Added setReportsList() and a list widget.
1441 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1442 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1447 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1449 Translations: Add Esperanto.
1451 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1452 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1453 properties: Add this translation because someone took the time to make it.
1455 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1457 Adapt to the java-libglom 1.21.7 API.
1459 * src/main/java/org/glom/web/server/ReportGenerator.java:
1460 addToReport(): get_group_secondary_fields() is now
1461 get_secondary_fields().
1464 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1466 Use the latest java-libglom version.
1468 * pom.xml: Use java-libglom 1.21.7.
1470 2012-03-03 Ben Konrath <ben@bagu.org>
1472 Display date and time in details view.
1474 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1476 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1478 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1480 Require the latest java-libglom.
1482 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1484 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1486 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1488 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1489 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1490 an empty quickfind string. I also corrected libglom to create only
1491 empty where clauses for empty quickfind strings, but this avoids the
1494 2012-02-24 Ben Konrath <ben@bagu.org>
1496 Improve the tabs in the Notebook widget.
1500 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1502 Translations: Try to translate the strings.
1504 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1505 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1506 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1507 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1508 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1509 Take the Open translation from GTK+'s .po files.
1510 Take the Details translation from Glom's po files.
1511 I have added the other strings to Glom so we can get translations that way:
1512 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1514 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1516 TableSelectionViewImpl: Put the search label and entry in a div.
1518 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1519 Put the search widgets in a FlowTable so that the CSS can be used to
1520 style them while keeping them together.
1521 * src/main/webapp/style.css: Mention the new div.
1523 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1525 Translate more strings in more locales.
1527 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1528 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1529 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1530 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1531 Translate the "Details" and "Open" string too.
1533 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1534 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1535 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1536 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1537 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1538 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1539 Add these new locales as placeholders though they currently contain English.
1541 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1543 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1545 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1546 Check the ConfiguredDocument* for null before using it.
1548 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1550 Tell Eclipse about the generated java files.
1552 * .classpath: This lets it find OnlineGlomConstants.java.
1553 It would be nice if Eclipse just used the maven build files.
1555 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1557 Prevent a crash when no locale is specified in the URL.
1559 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1560 Avoid returning a null string, obtained from
1561 Window.Location.getParameter(). This caused a crash when it was
1562 later passed to libglom's API.
1563 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1564 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1565 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1566 guard against future null strings.
1568 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1570 Use the ?locale= query param instead of the &lang= token param.
1572 * src/main/java/org/glom/web/client/place/ListPlace.java
1573 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1574 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1575 Remove the lang token key and value.
1577 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1578 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1579 When the user selects a different locale from the chooser, use
1580 Window.Location.assign() to change the URL, which then causes a reload.
1582 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1583 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1584 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1585 * src/main/java/org/glom/web/client/activity/ListActivity.java
1586 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1587 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1588 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1589 * src/main/java/org/glom/web/client/ui/ListView.java:
1590 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1592 Remove localeID member variables and method/constructor parameters, instead
1593 using Utils.getCurrentLocaleID() when we need a localID to pass to
1596 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1598 Internationalize the UI strings.
1600 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1601 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1602 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1603 because it is unused. Messages are apparently strings that can have
1604 parameters, but we do not need that yet, so Contants will be enough for now.
1605 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1606 to say that we support the en and de locales.
1607 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1608 The original English strings.
1609 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1610 Some German translations of the English strings.
1611 The i18n goal then uses the .properties file to generate an
1612 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1613 returns an implementation that returns the translated strings.
1614 The documentation suggests putting these in src/java/*/client/, but it seems
1615 best to put it in src/resources/*/client/.
1616 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1617 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1618 instead of hard-coding them.
1619 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1620 but that does not seem to stop the build, though it confuses Eclipse.
1622 You can see the translated string by adding ?locale=de to the URL, like so:
1623 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1625 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1627 Improve null/empty String checks.
1629 * pom.xml: Add a dependency on commons-lang, to use
1630 org.apache.commons.lang.StringUtils.
1631 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1632 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1633 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1634 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1635 Use StringUtils.isEmpty().
1637 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1638 StringUtils class with a static isEmpty() function because we
1639 cannot use org.apache.commons.lang.StringUtils in client-side
1640 GWT code because it (apparently) cannot be compiled to javascript.
1641 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1642 * src/main/java/org/glom/web/client/activity/ListActivity.java
1643 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1644 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1645 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1646 * src/main/java/org/glom/web/client/place/ListPlace.java
1647 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1648 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1649 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1650 * src/main/java/org/glom/web/client/ui/details/Group.java
1651 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1652 our StringUtils.isEmpty() function.
1654 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1656 Update to the latest java-libglom API.
1658 * pom.xml: Require java-libglom 1.21.4.
1659 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1660 getDocumentInfo(), getListViewLayoutGroup():
1661 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1663 * src/main/java/org/glom/web/server/database/DBAccess.java
1664 getFieldsToShowForSQLQueryAddGroup(),
1665 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1666 with either get_database_title_original() or
1667 get_database_title(localeID).
1669 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1671 ConfiguredDocument: Avoid a null pointer exception.
1673 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1674 Initialize localeID to "" to avoid returning a null String which
1675 causes a crash in java-libglom's swing-generated code.
1677 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1679 Some simple renaming.
1681 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1682 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1683 for localeChooser. This seems more appropriate and is less ambiguous
1684 particularly in the .css file.
1686 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1688 ConfiguredDocument: Rename the localedID private member variable.
1690 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1692 Adapt to the latest java-libglom API from git master.
1694 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1695 libglom now uses only Vector instead of List, which uses add() instead of
1698 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1700 ConfiguredDocument: Rename the localedID private member variable.
1702 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1704 Build a source tarball with mvn assembly:single
1706 * assembly.xml: Add this file.
1707 * pom.xml: Use the maven-assembly-plugin and tell it to use
1708 our assembly.xml file.
1710 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1712 OnlineGlomServiceImpl: Get .glom files recursively.
1714 * pom.xml: Depend on commons-io from org.apache.commons.
1715 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1716 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1717 files recursively, and with the easier filter for the extension.
1718 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1719 simplify that code too.
1721 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1723 README: Mention that you must install java-libglom packages separately.
1725 But then it works, because java-libglom is now in the central maven
1728 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1730 locales drop-down: Show the correct selected locale when the URL changes.
1732 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1733 .java: setPlace(): Move some code into fillView().
1735 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1737 locales drop-down: Do not lose the primary key.
1739 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1740 start(): onLocaleChange(): Pass the current primary key value,
1741 instead of an empty value.
1743 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1745 locales drop-down: Do not lose the drop-down selection.
1747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1748 .java (TableSelectionActivity.fillView): Set the selected locale
1749 after changing the drop-down items (though we do not really need
1750 to change them just because the locale changes.)
1752 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1754 locales drop-down: Change the tables list when this changes.
1756 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1757 .java: TableSelectionActivity.start(): Move the async table titles
1758 retrieval into a private fillView() method and also call this when
1759 the chosen locale changes.
1760 Note that the document title is not actually translatable yet, but
1761 that is a problem that I should fix soon in libglom.
1763 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1765 Improve the placement of the locales drop-down.
1767 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1768 Put the title and locales drop-down in a div (gwt.FlowTable).
1769 * src/main/webapp/style.css: Add magic css properties to make this work.
1770 Also remove the left margin from the title so that it lines up with the
1773 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1775 locales selector: Show human-readable locale titles.
1777 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1778 getDocumentInfo(): Use java.util.Locale to show a real title of
1779 each locale, in the locale's own language.
1781 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1783 Add a language/locale selector drop-down.
1785 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1786 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1787 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1788 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1789 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1790 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1791 Add a ListBox to show the available locales. Add getLocaleSelector(),
1792 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1793 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1794 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1795 java: Add these classes.
1796 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1797 start(): Fill the locales ListBox. Handle its change event, firing a
1799 setPlace(): Show the selected locale as specified by the URL token.
1800 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1801 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1802 Handle LocaleChangeEvent, going to a new *Place with that locale.
1804 The placement of the ListBox is not pretty, and it currently uses the ID
1805 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1809 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1811 Search box: Show the search text from the URL token.
1813 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1814 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1815 Add setQuickFindText().
1816 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1817 .java: setPlace(): Store the queryText if the place is a ListPlace,
1818 and call TableSelectionView.setQuickFindText().
1820 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1822 Allow use of translations via, for instance, &lang=de in the URL.
1824 * pom.xml: Use the unstable java-libglom 1.21 version.
1826 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1827 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1828 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1829 init(): Instead of calling TranslatableItem.set_current_locale()
1830 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1831 However, this is only for default locales, which are not needed to
1832 change the locale in the URL.
1833 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1834 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1835 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1836 layout for a particular locale.
1837 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1838 Add get/setDefaultLocaleID().
1839 getDocumentInfo(), getListViewData(), getRelatedListData(),
1840 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1841 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1842 localeID parameter, so we can get the layout for a particular locale.
1844 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1845 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1846 * src/main/java/org/glom/web/client/place/ListPlace.java:
1847 Parse and construct a lang parameter too.
1849 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1850 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1851 passed to subsequent methods and constructors.
1852 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1853 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1854 Store the localeID from the *Place and pass it to other constructors
1855 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1857 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1858 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1859 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1860 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1861 * src/main/java/org/glom/web/client/ui/ListView.java:
1862 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1863 Take localeID parameters and pass them to subsequent constructors and
1864 methods, so that the layout is always retrieved for that locale.
1866 This is rather repetitive.
1868 Note that "" means the original (default) locale of the Glom document,
1869 which is usually English.
1871 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1873 Documents: Remove final keyword to fix startup configuration.
1875 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1876 final keywords on the private member variables because that breaks
1877 the startup, apparently (there are warnings) because it stops them
1878 from being serialized. I added these in the previous commit.
1880 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1882 Documents: Add some final keywords.
1884 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1887 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1889 OnlineGlomServiceImpl: Add to overview comments.
1891 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1892 Note that this is where all the document are loaded. They are not
1893 loaded freshly for each page.
1895 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1899 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1900 Add a TextBox for the text of a quick find.
1901 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1903 setBackLink(): Add a String quickFind parameter.
1904 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1905 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1906 to the base interface, because that is how TableSelectionViewImpl is used.
1907 * src/main/webapp/style.css: Add style for the search box and its label.
1909 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1910 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1911 Add these files, based on the existing TableChangeEvent and
1912 TableChangeEventHandlers.
1913 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1914 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1915 a ListPlace() that the user should be taken to.
1916 * src/main/java/org/glom/web/client/activity/ListActivity.java
1917 start(): Handle it here too and adapt the TableChangeEvent handler to
1918 pass the extra "" quickFind parameter to ListPlace.
1919 * src/main/java/org/glom/web/client/place/ListPlace.java:
1920 Constructor: Take an extra String quickFind parameter and store it,
1921 returning it from a new getQuickFind() method.
1922 getToken(): Put the quickFind text in the URL token.
1923 getPlace(): Parse the quickFind text from the URL token.
1924 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1925 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1926 ListPlace constructor.
1927 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1928 .java: start(): Add a Change handler for the TableSelectionView's
1929 TextBox (via its base HasChangeHandlers interface), firing the new
1930 QuickFindChangeEvent.
1931 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1932 pass the extra "" quickFind parameter.
1934 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1935 setCellTable(): Add a String quickFind parameter and pass it to
1936 the ListViewTable() constructor.
1937 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1938 setCellTable() in the base interface, because that is how ListViewImpl
1941 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1942 Add a String quickFind member variable.
1943 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1944 Constructor: Add a String quickFind parameter, storing it in the
1945 base ListTable's member variable.
1946 onRangeChanged(): Pass quickFind to the
1947 OnlineGlomServiceAsync.getSortedListViewData() and
1948 OnlineGlomServiceAsync.getListViewData() methods.
1950 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1951 getListViewData(), getSortedListViewData(): Add a String quickFind
1952 parameter, passing it to ConfiguredDocument.getListViewData().
1953 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1954 Change getListViewData(), getSortedListViewData() in the base interface,
1955 because that is how OnlineGlomServiceImpl is used, via this:
1956 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1957 Change getListViewData(), getSortedListViewData() here too.
1958 This class can apparently be used to asynchronously call methods on
1959 OnlineGlomService, and GWT seems to implement that after recognizing
1960 just the *Async name convention and the extra AsyncCallback parameters.
1962 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1963 getListViewData(): Add a String quickFind parameter, and pass it to
1964 ListViewDBAccess.getData().
1965 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1966 getListData(): Add a String quickFind parameter and pass it to
1968 getSelectQuery(): Add a String quickFind parameter.
1969 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1970 getSelectQuery(): Add a String quickFind parameter and use it with
1971 Glom.get_find_where_clause_quick() to pass a where_clause to
1972 Glom.build_sql_select_with_where_clause(), to actually filter the
1974 getData(): Add a String quickFind parameter, passing it to getListData().
1975 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1976 va: getData(): Pass an empty string to getListData() for the
1977 quickFind parameter.
1979 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1981 ListTable: Minor change.
1983 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1984 createCellTable(): Make this protected instead of public.
1986 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1988 Many files: Use final for the parameters and use the @override attribute.
1990 2012-01-22 Ben Konrath <ben@bagu.org>
1992 Add anchor links for single line text that starts with http, ftp and www.
1996 2012-01-22 Ben Konrath <ben@bagu.org>
1998 Add ellipsis to single line text in details view.
2002 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2004 Remove all javadoc author tags.
2006 Because they are awkward and meaningless when many people touch
2008 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2010 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2012 Revert the COPYING.LESSER to COPYING rename.
2014 Apparently both should be there if it is LGPL.
2016 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2018 *View: Remove unused imports.
2020 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2021 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2022 * src/main/java/org/glom/web/client/ui/ListView.java:
2023 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2024 Remove unused imports, as suggested by Eclipse.
2026 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2028 Move the *View::Presenter types, and some API into one base View.
2030 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2031 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2032 * src/main/java/org/glom/web/client/ui/ListView.java:
2033 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2034 Presenter, setPresenter() and clear() into a shared base interface,
2035 to avoid the unnecessary duplicate Presenter types and to more clearly
2036 show how the *Views share the same structure, even if they are not
2037 used polymorphically.
2039 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2040 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2042 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2043 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2044 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2046 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2049 Feel free to revert this if there is a good reason for the duplicate
2052 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2054 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2056 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2057 a class member instead of a local variable in the method.
2058 This lets us use it to get the view instances, for use in tests.
2059 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2060 beforeOnlineGlom(): Test some more details of the initial view.
2061 Again, this is not very useful.
2063 To really test gwt-glom we will need to start a local postgresql
2064 instance with local data, like the Glom tests in C++.
2066 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2068 pom.xml: Mention the LGPL license.
2070 * pom.xml: Add a licenses section.
2071 * COPYING.LESSER: Move this to COPYING, which
2072 previously contained the GPL. But gwt-glom is all LGPL.
2074 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2076 Add project information to README and pom.xml.
2078 * README: Add a brief description and mention some mvn
2080 * pom.xml: This extra information shows up in mvn site
2083 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2085 Use the latest java-libglom version.
2087 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2089 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2091 GwtTestOnlineGlom: Test a little more.
2093 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2094 protected rather than private, as suggested by the gwt-test-utils
2096 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2097 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2098 Test the initial visibility of the panels.
2100 However, this is not a very useful test.
2101 And I wonder how we should generally test using this idea for an
2102 activity/places app like ours where the real changes happen implicitly
2103 based on the history token/URL.
2105 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2107 Slight modification to *Mapper comments.
2109 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2110 (DataActivityMapper)
2111 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2113 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2115 Remove comments mentioning GIN because they are just copied from
2116 the example code and are apparently not helpful:
2117 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2118 Also change the mention of a class that is only in the example code.
2120 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2122 GwtTestOnlineGlom test: Minor changes.
2124 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2125 Avoid the long qualified class name and modify the comment
2126 because it is now obvious to me that the mocked class is the only
2127 custom one created via GWT.create().
2129 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2131 Tests: Added the beginnings of a test using gwt-test-utils.
2133 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2134 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2135 which tells gwt-test-utils what class will be tested.
2136 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2137 Add a simple (but empty) test case. One class, used by the OnlineGlom
2138 class, is mocked so that it can be created. However, I am not sure
2139 why only this class needs to be mocked.
2141 Note that mockito seems more popular, and clearer, than easymock,
2142 but I have not got that working yet. It might be a matter of the
2145 This test is run during mvn integration-test.
2147 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2149 Tests: Use junit4-style syntax instead of junit3-style.
2151 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2152 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2153 * src/test/java/org/glom/web/shared/DataItemTest.java:
2154 Use the @Test annotation rather than relying on the test*() prefix.
2155 Also no longer implement TestCase, to avoid triggering support for
2156 the junit3-way, which stops the annotations from working.
2157 Change the imports from import junit.framework.* to
2158 import org.junit.*, which is apparently the new way.
2160 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2162 Added a test for ListPlace token parsing and creation.
2164 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2165 This is much the same as DetailsPlaceTest.
2167 I wonder how we could test the other parts of the *Place API.
2169 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2171 DetailsPlace test: Also test getToken() and recreation via getPlace().
2173 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2174 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2175 recreate it, testing the recreated DetailsPlace for the same parameter
2178 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2180 Use the surefire-report plugin.
2182 * pom.xml: This generates a HTML report about the tests in
2183 target/site/surefire-report.html
2184 when you do mvn surefire-report:report. It seems to be popular/normal.
2186 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2188 Added a test for DetailsPlace.
2190 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2191 Test the getPlace() token parsing.
2193 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2195 Added a first unit test.
2197 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2198 * src/test/java/org/glom/web/shared/DataItemTest.java:
2199 This is a silly test but it is just to get things started. Note that
2200 maven/junit finds the test because it looks in src/test by default.
2202 2011-12-22 Ben Konrath <ben@bagu.org>
2204 Change charsetName to "UTF-8" when replacing line breaks.
2206 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2207 that work in Java (such as "UTF8") will not work when compiled to
2210 This fixes a problem with multi-line details view fields that have hard
2211 line breaks. The "License Text" field on this page demonstrates the
2214 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2216 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2218 2011-12-22 Ben Konrath <ben@bagu.org>
2220 Fix another bug with related list navigation.
2222 I've tested all the navigation buttons in all of the related lists
2223 so things should be good now.
2225 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2227 2011-12-22 Ben Konrath <ben@bagu.org>
2229 Fix a crasher when refreshing the list view with the default table.
2231 This crash will also happen when loading the list view with the default
2232 table from a link or bookmark.
2234 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2235 to the main document selection page when the document id hasn't been
2237 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2238 the main document selection page when the document id hasn't been
2240 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2241 values for the details place when the document id hasn't been set.
2242 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2243 values for the list place when the document id hasn't been set.
2245 2011-12-21 Ben Konrath <ben@bagu.org>
2247 Protect against NPE when glom.document.locale is not in config.
2249 This patch protects against an NPE when glom.document.locale is not in
2250 the config file. This NPE will also happen if glom.document.locale is
2253 The patch also updates the error message to display the class name when
2254 the getMessage() returns null. This was happening when the NPE was
2255 thrown and I had "Configuration Error: null". If an NPE is encountered
2256 with this patch, "Configuration Error: NullPointerException " will be
2259 This commit closes this bug:
2261 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2263 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2265 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2267 Rename onlineglom.properties to onlineglom.properties.sample.
2269 * src/main/resources/onlineglom.properties: Rename to:
2270 * src/main/resources/onlineglom.properties.sample:
2271 * src/main/resources/README: And add this file explaining that people
2272 should rename it back when deploying.
2274 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2276 Allow choosing the translation in the .properties file.
2278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2279 init(): Read a glom.document.locale value from the configuration file
2280 and call Glom's TransatableItem::set_current_locale() method.
2281 * src/main/resources/onlineglom.properties: Add a commented-out
2282 example of this new setting.
2284 It would be better to add &lang=de_DE to the URL, but the current
2285 libglom API does not allow us to do this easily. I am working on that.
2287 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2289 Avoid a crash in parsing of token parameters.
2291 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2292 ava: getTokenParams(): Do not crash if a parameter has a key but no
2293 value, and ignore parameters with neither.
2295 2011-12-17 Murray Cumming <murrayc@murayc.com>
2297 History token building/handling: Improve use of token parameters.
2299 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2300 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2301 and buildParamsToken(HashMap), for use by derived classes.
2302 Make the separator private because it is no longer be needed.
2303 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2304 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2305 instead of manual string concatenation.
2306 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2307 of hardcoded indices and awkward splitting code.
2308 * src/main/java/org/glom/web/client/place/ListPlace.java
2309 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2310 instead of manual string concatenation.
2311 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2312 of hardcoded indices and awkward splitting code.
2313 This should fix bug #666420
2315 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2317 Fix a Navgiation->Navigation typo in the code.
2319 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2320 Rename processNavgiation() to processNavigation().
2322 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2324 Fix a seperator->separator typo in the code.
2326 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2327 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2328 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2331 2011-12-15 Ben Konrath <ben@bagu.org>
2333 Cleanup some comments.
2335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2337 2011-12-14 Ben Konrath <ben@bagu.org>
2339 Replace \n with <br/> for multiline text in the details view.
2341 Vertical scrollbars are added when needed as well.
2343 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2345 2011-12-14 Ben Konrath <ben@bagu.org>
2347 Specify the font for document selection links.
2349 * src/main/webapp/style.css:
2351 2011-12-14 Ben Konrath <ben@bagu.org>
2353 Fix bouncy CellTable while paging.
2355 This doesn't currently work with related list tables in unselected
2358 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2360 2011-12-14 Ben Konrath <ben@bagu.org>
2362 Revamp the appearance of the document selection page.
2364 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2365 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2366 * src/main/webapp/style.css:
2368 2011-12-13 Ben Konrath <ben@bagu.org>
2370 Set navigation button column to the smallest size possible.
2372 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2374 2011-12-13 Ben Konrath <ben@bagu.org>
2376 Change OpenButton nomenclature to NavigationButton.
2378 Using NavigtionButton makes things more generic. Classes, methods and
2379 variables have been changed.
2381 This is a rename-only refactor.
2383 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2384 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2385 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2386 Renamed from OpenButtonCell.
2387 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2388 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2389 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2391 2011-12-12 Ben Konrath <ben@bagu.org>
2393 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2395 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2396 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2397 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2398 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2400 2011-12-12 Ben Konrath <ben@bagu.org>
2402 Update variable names and comments.
2404 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2405 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2407 2011-12-12 Ben Konrath <ben@bagu.org>
2409 Properly initialize numNonEmptyRows variable to zero.
2411 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2412 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2414 2011-12-05 Ben Konrath <ben@bagu.org>
2416 Add latest mockup with HTML tables.
2418 Features of this mockup:
2420 -> HTML table for flowtable
2421 -> HTML table for flowtable column
2422 -> Example of how related lists would look
2423 -> Not using text entries for data items
2425 The current version of Online Glom doesn't use HTML tables for the
2428 This mockup has been sent to the glom-devel mailing list but it's good
2429 to have it here as well.
2431 * mockups/details-view-html-tables.html:
2433 2011-12-05 Ben Konrath <ben@bagu.org>
2435 Remove unnecessary getPrimaryKeyField() method.
2437 getPrimaryKeyFieldForTable(String) has been renamed to
2438 getPrimaryKeyField(String).
2440 * src/main/java/org/glom/web/server/database/DBAccess.java:
2441 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2442 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2444 2011-12-05 Ben Konrath <ben@bagu.org>
2446 Add string representation of TypedDataItem value to conversion error message.
2448 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2449 message was extracted into its own method to avoid duplication.
2451 2011-12-05 Ben Konrath <ben@bagu.org>
2453 Add type checking to navigation primary key value creation.
2455 Create navigation primary key only if the expected type from the Glom
2456 document matches the type returned by the SQL query.
2458 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2460 2011-12-05 Ben Konrath <ben@bagu.org>
2462 Rename a couple of variables in RelatedListNavigation.
2464 This is a rename-only refactor.
2466 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2468 2011-12-05 Ben Konrath <ben@bagu.org>
2470 Move getListLayoutGroup() into getListViewLayoutGroup().
2472 This removes getListLayoutGroup(). It was only being called by
2473 getListViewLayoutGroup().
2475 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2477 2011-12-05 Ben Konrath <ben@bagu.org>
2479 Remove check for LayoutItem_Portal in list table method.
2481 This check is no longer necessary because the method isn't being used
2482 to create the LayoutItemPortal DTO.
2484 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2486 2011-12-05 Ben Konrath <ben@bagu.org>
2488 Properly support related list navigation.
2490 Navigation from the "Repository Analyzer -> Package Scans ->
2491 Dependencies" related table wasn't working because the primary key for
2492 related tables wasn't being set properly. This commit fixes the
2495 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2496 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2497 doesn't set the primary key properly for related list tables.
2498 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2499 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2500 useful for getting the primary key for list view tables and for related
2502 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2503 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2504 Move code to set the primary key for the table from the abstract
2505 ListDBAccess class to ListViewDBAccess as it's only correct for list
2507 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2508 Properly add primary key to related list tables.
2510 2011-12-02 Ben Konrath <ben@bagu.org>
2512 Properly set the horizontal alignment of fields.
2514 This fix is for both the list tables and the details view.
2516 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2517 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2518 to set the horizontal alignment of fields.
2520 2011-12-02 Ben Konrath <ben@bagu.org>
2522 Display currency codes in the details view.
2524 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2526 2011-12-02 Ben Konrath <ben@bagu.org>
2528 Avoid duplicate JNI call.
2530 JNI is not as efficient as pure Java and this is an easy (and small)
2533 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2534 Use previously retrieved value for whereClauseToTableName instead of
2537 2011-12-02 Ben Konrath <ben@bagu.org>
2539 Rename a couple of variables in RelatedListNavigation.
2541 This is a rename-only refactor.
2543 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2545 2011-12-02 Ben Konrath <ben@bagu.org>
2547 Indicate clearly that a mismatched primary key type is a bug.
2549 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2550 warning to error. Add 'This is a bug.' to message.
2552 2011-12-02 Ben Konrath <ben@bagu.org>
2554 Update / fix some comments.
2556 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2558 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2560 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2561 Fix comments. Add some TODOs.
2563 2011-12-02 Ben Konrath <ben@bagu.org>
2565 Enable navigation to details view with string primary key from related list.
2567 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2568 Create a text primary key value when return type of result is
2569 java.sql.Types.VARCHAR.
2571 2011-12-02 Ben Konrath <ben@bagu.org>
2573 Use checkboxes for booleans in the details view.
2575 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2577 2011-12-01 Ben Konrath <ben@bagu.org>
2579 Improve performance of related list height calculation.
2581 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2582 Put code to calculate the expected height in a static initializer so
2583 that that it's only called once.
2585 2011-12-01 Ben Konrath <ben@bagu.org>
2587 Show related list tables in notebooks (again).
2589 Calculate the height of the related list tables so the Notebook can be
2590 set the correct height. The height of the related list table is also needed by
2591 FlowTable to be able decide how to create the layout.
2593 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2594 and set the Portal height based on the height of the related list
2595 table and the Portal container.
2596 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2597 Add method to calculate the height of the related list tables.
2598 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2599 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2600 calculate the height of the Pager widget.
2602 2011-12-01 Ben Konrath <ben@bagu.org>
2604 Use CellTable API for table property instead of setting style on Element.
2606 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2608 2011-12-01 Ben Konrath <ben@bagu.org>
2610 Make ListViewTable and RelatedListTable a consistent height.
2612 The tables are now a consistent height regardless of the contents of
2613 the table. A hidden button is added to empty rows to ensure that the
2614 height of these rows will match the height of rows with data.
2616 A navigation button column is now added to every table. The width of
2617 the navigation column is set to 0px when a RelatedListTable shouldn't
2618 have navigation buttons. This maintains the a consistent row height in
2619 tables that don't show the navigation buttons.
2621 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2622 navigation column when not needed.
2623 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2624 arguments for navigation button to constructor of ListViewTable.
2625 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2626 hidden button for empty data rows.
2627 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2628 arguments for navigation button to constructor.
2629 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2630 create navigation buttons. Add hideNavigationButtons() method.
2631 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2632 arguments for navigation button to constructor.
2634 2011-12-01 Ben Konrath <ben@bagu.org>
2636 Use 'visibility: hidden' in Utils.getWidgetHeight().
2638 This is better choice because hidden elements are invisible, don't
2639 respond to events and are not part of the tab order. They will,