1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
3 Document: Interpret no group column count as 1.
5 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
6 default, though we now check for this in the UI code anyway.
8 2012-05-06 Murray Cumming <murrayc@murrayc.com>
12 2012-05-06 Murray Cumming <murrayc@murrayc.com>
14 Translatable: Use Hashmap instead of Treemap because GWT supports it.
16 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
17 The use of Treemap lead to this error from async methods, with no
19 "The response could not be deserialized"
21 2012-05-06 Murray Cumming <murrayc@murrayc.com>
23 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
25 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
26 when using the Google -> GWT Compile, or
27 g toolbar button -> GWT Compile Project... feature in Eclipse.
29 2012-05-06 Murray Cumming <murrayc@murrayc.com>
31 ListTable.addColumn(): Protect against a null Formatting.
33 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
34 Create a default Formatting if it is null, because that is the simplest
37 2012-05-06 Murray Cumming <murrayc@murrayc.com>
39 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
41 * src/main/java/org/glom/web/server/ConfiguredDocument.java
42 updateLayoutGroup(): Check that the field is not null.
44 2012-05-06 Murray Cumming <murrayc@murrayc.com>
46 ListViewImpl: Protected against a bad cast error.
48 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
49 onEnterKeyDown(): Do not cast without an instanceof check.
51 2012-05-06 Murray Cumming <murrayc@murrayc.com>
53 ListTable: Protect against an out of range error.
55 * src/main/java/org/glom/web/client/ui/list/ListTable.java
56 createCellTable(): This is unlikely, but can happen while debugging.
58 2012-05-06 Murray Cumming <murrayc@murrayc.com>
60 AsyncMessage onFailure() callbacks: Log the exception message.
62 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
63 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
64 * src/main/java/org/glom/web/client/activity/ListActivity.java:
65 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
66 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
67 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
68 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
69 These are useful clues when something is wrong.
71 2012-05-06 Murray Cumming <murrayc@murrayc.com>
73 ConfiguredDocument: Avoid a null dereference.
75 * src/main/java/org/glom/web/server/ConfiguredDocument.java
76 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
77 details maps are created.
79 2012-05-06 Murray Cumming <murrayc@murrayc.com>
81 Document: Correct the port number parsing.
83 * src/main/java/org/glom/web/server/libglom/Document.java:
84 This lets us actually connect to the database and show the document.
86 2012-05-05 Murray Cumming <murrayc@murrayc.com>
90 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
91 user-interaction, asking us to load a temporary URL in a browser.s
92 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
93 which is apparently necessary for testing the service. See the comment.
94 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
95 Show the exception, if any. This is how I saw the 404 in the HTML in
98 2012-05-05 Murray Cumming <murrayc@murrayc.com>
100 DocumentTest: Move the .glom files into the resources directory.
102 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
103 URI via getResource().
105 2012-05-05 Murray Cumming <murrayc@murrayc.com>
107 Document: Remove the FieldIdentifies inner class.
109 * src/main/java/org/glom/web/server/libglom/Document.java: We only
110 use the Relationship (though the same function in libglom is maybe
111 used in other ways) and so this removes a compiler warning.
113 2012-05-05 Murray Cumming <murrayc@murrayc.com>
115 Document.load() Remove the error code parameter.
117 * src/main/java/org/glom/web/server/libglom/Document.java: load():
118 Remove the parameter. We do not set it yet and it could never have
119 worked as an output parameter (though maybe it did in java-libglom).
120 We could use an exception if we really want the failure reason.
121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
123 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
124 setUp(), testGetSuitableTableToViewDetails(): Adapt.
126 2012-05-05 Murray Cumming <murrayc@murrayc.com>
128 Make some inner classes static.
130 * src/main/java/org/glom/web/server/ConfiguredDocument.java
131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
132 * src/main/java/org/glom/web/server/ReportGenerator.java
133 * src/main/java/org/glom/web/server/libglom/Document.java
134 Make all inner classes static that can be static.
136 2012-05-05 Murray Cumming <murrayc@murrayc.com>
138 OnlineGlomServiceImpl: Do not load and check for java-libglom.
140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
141 init(): We do not use java-libglom any more.
143 2012-05-05 Murray Cumming <murrayc@murrayc.com>
145 Remove mentions of java-libglom.
147 * README: Remove mention of java-libglom, because it no longer needed.
148 * utils/build-onlineglom-war.sh:
149 * utils/check-and-recover-tomcat.py:
150 * utils/install-onlineglom-war.sh: Remove these as they are no longer
151 useful. Building is now far easier, with no need for jhbuild.
153 2012-05-05 Murray Cumming <murrayc@murrayc.com>
155 Fix the build (mvn package)
157 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
158 (LayoutGroup): Make the LayoutItemList inner class static and protected.
159 Otherwise the GWT Java->Javascript compilation fails with just this
160 error, during mvn package or when attempting to view in a browser,
161 in the GWT developer mode in Eclipse.
163 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
164 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
165 [INFO] Compiling module org.glom.web.OnlineGlom
166 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
167 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
168 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
169 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
170 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
171 [INFO] [ERROR] Cannot proceed due to previous errors
173 It has taken me 2 days to find out what was causing that. After reducing
174 the code, the compiler eventually showed me the full error message.
176 2012-05-04 Murray Cumming <murrayc@murrayc.com>
178 ConfiguredDocument: Cache the cloned and stripped layouts.
180 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
181 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
182 layout in a map, so we can retrieve it again without rebuilding it.
184 2012-05-04 Murray Cumming <murrayc@murrayc.com>
186 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
188 2012-05-04 Murray Cumming <murrayc@murrayc.com>
190 libglom classes: Implement some auto-generated emthods.
192 2012-05-04 Murray Cumming <murrayc@murrayc.com>
194 Add GwtTestOnlineGlomService.
196 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
197 However, this (and the other GwtTest*) does not seem to run during
200 2012-05-04 Murray Cumming <murrayc@murrayc.com>
202 Remove use of unsupported features from client code.
204 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
205 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
206 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
207 Use our client version of StringUtils instead of the apache commons one.
209 However, the GWT Javascript compliation still fails.
211 2012-04-25 Murray Cumming <murrayc@murrayc.com>
213 Add a Field class and implement some loading of it in Document.
215 2012-04-25 Murray Cumming <murrayc@murrayc.com>
217 Initial Document loading implementation, instead of libglom.
219 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
220 and Translatable classes, and adapt the rest of the code to use them.
221 However, this is still missing Layout and Field classes and loading.
223 2012-04-24 Murray Cumming <murrayc@murrayc.com>
225 Use of jOOQ: Move Field creation into a utility method.
227 * src/main/java/org/glom/web/server/SqlUtils.java:
228 This lets us improve it more easily.
230 2012-04-24 Murray Cumming <murrayc@murrayc.com>
232 Use of jOOQ: Improve the code to COUNT a sub-select.
234 * src/main/java/org/glom/web/server/SqlUtils.java:
235 Move initial query creation into
236 build_sql_select_step_with_where_clause().
237 build_sql_select_count_rows(): Use the jOOQ API instead of
238 concatentating text, because a jOOQ Select*Step is a TableLike,
239 which is what from() takes.
241 2012-04-23 Murray Cumming <murrayc@murrayc.com>
243 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
245 * pom.xml: Depend on jooq.
246 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
247 methods with jOOQ, based on the C++ implementations in libglom,
248 with some changes to the logic required by jooQ.
249 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
251 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
252 * src/main/java/org/glom/web/server/ReportGenerator.java:
253 * src/main/java/org/glom/web/server/SqlUtils.java:
254 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
255 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
256 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
257 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
258 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
259 Adapt. In particular, the SqlUtils methods now need to take a Connection,
260 because jOOQ needs that, though it seems unnecessary.
262 This is not quite finished. Ideally jOOQ would help us to build
263 table_name.field_name names, quoting and escaping them properly.
264 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
266 2012-04-21 Murray Cumming <murrayc@murrayc.com>
268 Move use of Glom.build_sql*() into a new SqlUtils class.
270 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
271 to wrap Glom.build_sql*(). The parameter types are still Glom one,
272 but this will make it easier to start using something other than
273 libglom or SqlBuilder.
275 2012-04-21 Murray Cumming <murrayc@murrayc.com>
277 Update the project URL.
279 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
281 2012-04-21 Murray Cumming <murrayc@murrayc.com>
283 Main layout: Use a FlowTable instead of absolute positioning.
285 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
286 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
287 child panels/widgets must have an absolute position. But that is annoying, so
288 this adds a FlowTable and puts the child panels in there.
290 2012-04-21 Murray Cumming <murrayc@murrayc.com>
292 GwtTestOnlineGlom: Comment out unused code.
294 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
295 Eclipse has started to say that some code is unused.
297 2012-04-21 Murray Cumming <murrayc@murrayc.com>
299 Update to the latest versions of dependencies.
301 * pom.xml: Update version numbers of dependencies to the latest
303 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
305 * src/main/java/org/glom/web/server/ReportGenerator.java:
306 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
307 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
308 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
310 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
311 Modify the imports where necessary.
313 2012-04-17 Murray Cumming <murrayc@murrayc.com>
315 Style: Remove overflow:hidden from searchbox
317 * src/main/webapp/style.css: Because this pushes the Back To Link
318 label/link on to the next row, which is then hidden due to the
319 hard-coded (in ems) height.
321 2012-04-20 Murray Cumming <murrayc@murrayc.com>
323 Remove some duplicate code.
325 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
326 getDocumentInfo(): This must have been duplicated during the merge from the
331 2012-04-19 Murray Cumming <murrayc@murrayc.com>
333 Reports: Localize the waiting for report message.
335 * src/main/java/org/glom/web/client/activity/ReportActivity.java
336 start(): Get the message from the contants.
337 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
339 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
340 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
341 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
342 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
343 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
344 Update these files with the English text for newer strings for now.
346 2012-04-19 Murray Cumming <murrayc@murrayc.com>
348 Reports: Show a message while waiting for the report.
350 * src/main/java/org/glom/web/client/ui/ReportView.java
351 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
352 Add setWaitingText(), to show a message saying that we are
353 waiting for the report to be ready.
354 * src/main/java/org/glom/web/client/activity/ReportActivity.java
355 start(): Call setWaitingText() before calling the async
358 2012-04-19 Murray Cumming <murrayc@murrayc.com>
360 ReportGenerator: Specify date and time formats.
362 * src/main/java/org/glom/web/server/ReportGenerator.java:
363 createFieldValueElement(): Use the default (and localized)
364 short formats, though we still need a way to show 4-digit
365 years without providing the format for every locale.
366 * src/main/java/org/glom/web/server/database/DBAccess.java:
367 convertResultSetToDTO(): Use the short formats here too.
369 2012-04-18 Murray Cumming <murrayc@murrayc.com>
371 ReportGenerator: Use the correct numeric formatting.
373 * src/main/java/org/glom/web/server/ReportGenerator.java
374 createFieldExpression(), createFieldValueElement(): Take the
375 whole LayoutItem_Field instead of just the field name, so
376 we have access to the formatting.
377 createFieldValueElement(): Use JRTextField.setPattern() to
378 specify the numeric formatting, with the help of a
379 regular DecimalFormat.
381 2012-04-18 Murray Cumming <murrayc@murrayc.com>
383 ReportGenerator: Avoid showing null for group by titles.
385 * src/main/java/org/glom/web/server/ReportGenerator.java
386 generateReport(): Use setBlankWhenNull() on the field title
387 style too, because this is used for values in group by
390 2012-04-18 Murray Cumming <murrayc@murrayc.com>
392 ReportGenerator: Add a colon to titles in vertical groups.
394 * src/main/java/org/glom/web/server/ReportGenerator.java
395 addFieldToDetailBandVertical(): Pass true for the withColon
398 2012-04-18 Murray Cumming <murrayc@murrayc.com>
400 ReportGenerator: Simplify the code by using Position more.
402 2012-04-18 Murray Cumming <murrayc@murrayc.com>
404 Reports: Support vertical groups, roughly.
406 * src/main/java/org/glom/web/server/ReportGenerator.java:
407 addToReport(): Rename to addGroupToReport() and, if necessary,
408 call the new addVerticalGroupToReport() method.
409 createFieldValueElement(): Let the caller specify the Y position
412 2012-04-17 Murray Cumming <murrayc@murrayc.com>
414 Reports: Allow a second report to be shown.
416 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
417 clear(): Do not remove the HTML widget, which broke the whole layout.
419 2012-04-17 Murray Cumming <murrayc@murrayc.com>
421 Locales drop-down: Show that we use English by default.
423 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
424 fillView(): When we use English, just because that is the default, when
425 no locale is specified, show that in the Locales drop-down instead of
426 just showing the first item.
428 2012-04-17 Murray Cumming <murrayc@murrayc.com>
430 Unselect the Report/Locale/Table combo item when appropriate.
432 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
433 setPlace(): clear reportName if this is not a ReportPlace.
434 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
435 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
436 When the provided name is empty, unselect all items, so that none are
437 indicated. This uses a for loop because I cannot find a single method
440 2012-04-17 Murray Cumming <murrayc@murrayc.com>
442 Report: Give the user a way to get back to the list.
444 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
445 start(), setPlace(): Show the Back To List link on reports, and also
446 interpret selecting the empty report item as back to list.
448 2012-04-13 Murray Cumming <murrayc@murrayc.com>
450 Really show the selected Report name.
452 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
453 setPlace(): Store the reportName here, if it is that kind of Place.
454 fillView(): Set the selected Report after filling the list of reports.
455 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
456 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
457 null Strings, though we need some way to unselect all ListBox items
460 2012-04-13 Murray Cumming <murrayc@murrayc.com>
462 ReportGenerator: Try to avoid some problems.
464 * src/main/java/org/glom/web/server/ReportGenerator.java
465 addField(): Try to avoid duplicates, and avoid using a null
468 2012-04-13 Murray Cumming <murrayc@murrayc.com>
470 Reports: Use quickFind.
472 * src/main/java/org/glom/web/client/OnlineGlomService.java;
473 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
474 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
475 getReportHTML(): Add a quickFind parameter.
476 * src/main/java/org/glom/web/client/activity/ReportActivity.java
477 start(): Pass the quickFind parameter.
478 * src/main/java/org/glom/web/server/ReportGenerator.java
479 generateReport(): Take a quickFind parameter.
481 2012-04-13 Murray Cumming <murrayc@murrayc.com>
483 ReportPlace: Actually use the report name.
485 * src/main/java/org/glom/web/client/place/ReportPlace.java
486 getPlace(): Do not assign the report name to the quickfind.
488 2012-04-13 Murray Cumming <murrayc@murrayc.com>
490 Show java.library.path when complaining.
492 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
493 init(): When telling us to check java.library.path, show the
496 2012-03-06 Murray Cumming <murrayc@murrayc.com>
498 ReportGenerator: Do not show nulls.
500 2012-03-06 Murray Cumming <murrayc@murrayc.com>
502 ReportGenerator: Make the title font larger.
504 2012-03-06 Murray Cumming <murrayc@murrayc.com>
506 ReportGenerator: Put field titles inside groups, if there are groups.
508 2012-03-06 Murray Cumming <murrayc@murrayc.com>
510 ReportGenerator: Take the Report itself instead of the name and group.
512 * src/main/java/org/glom/web/server/ConfiguredDocument.java
513 Remove getReportLayoutGroup().
514 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
515 getReportHTML(): Pass the report instead
516 of its name and layout group.
517 * src/main/java/org/glom/web/server/ReportGenerator.java
518 generateReport(): Use the report object to use the title
521 2012-03-06 Murray Cumming <murrayc@murrayc.com>
523 ReportGenerator: Remove designBand parameters.
525 * src/main/java/org/glom/web/server/ReportGenerator.java:
526 Make designBand a class member instead of passing it to all
529 2012-03-06 Murray Cumming <murrayc@murrayc.com>
531 ReportGenerator: Add lines, a bit like in the desktop version.
533 * src/main/java/org/glom/web/server/ReportGenerator.java
534 addToReport(): Use JRDesignLine.
536 2012-03-06 Murray Cumming <murrayc@murrayc.com>
538 ReportGenerator: Correct the title positions and use some bold style.
540 * src/main/java/org/glom/web/server/ReportGenerator.java:
541 Break the code up into reusable functions, correct the placement of
542 titles, and use normal/bold styles as in the reports in the desktop
545 2012-03-06 Murray Cumming <murrayc@murrayc.com>
547 ReportGenerator: Add a header band to show the field titles.
549 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
550 getReportHTML(): Pass the localeId to the ReportGenerator
552 * src/main/java/org/glom/web/server/ReportGenerator.java
553 constructor: Take the localeID so we can get translated field
555 generateReport(), addToReport(), addFieldToBand(): Add field
556 titles in a column header band.
558 2012-03-05 Murray Cumming <murrayc@murrayc.com>
560 Reports drop-down list: Some improvement.
562 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
563 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
564 Adedd setSelectedReport(),
565 setReportList(): Add a blank line so that the user can select the
567 * src/main/java/org/glom/web/client/activity/ReportActivity.java
568 start(): Show the current report by calling setSelectedReport().
569 This does not seem to work yet.
571 2012-03-05 Murray Cumming <murrayc@murrayc.com>
573 DetailsActivity, ListActivity: Move some variables into a base class.
575 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
576 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
577 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
578 the clientFactory, documentID, tableName and authenticationPopup into
579 a base class, to avoid duplication.
581 2012-03-05 Murray Cumming <murrayc@murrayc.com>
583 Translate the Reports label.
585 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
586 Get the "Reports" label string from the constants.
587 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
588 perties: Add Reports to the constants.
590 2012-03-05 Murray Cumming <murrayc@murrayc.com>
592 Reports: Implement grouping.
594 * src/main/java/org/glom/web/server/ReportGenerator.java:
595 Handle LayoutItem_GroupBy items and try to do the right thing
596 with JRDesignGroup. It seems to work.
598 2012-03-04 Murray Cumming <murrayc@murrayc.com>
600 Actually show some data with JasperReports.
602 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
603 getReportHTML(): Move most code into a ReportGenerator class.
604 * src/main/java/org/glom/web/server/ReportGenerator.java:
605 Recurse into sub-groups, adding fields to the JasperDesign's details
606 band. Note that we must set an arbitrary width and height, or it just
607 will not show any data.
609 2012-03-04 Murray Cumming <murrayc@murrayc.com>
611 Reports Chooser: Show the titles, not the names.
613 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
614 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
615 and the names as the values.
616 * src/main/java/org/glom/web/server/ConfiguredDocument.java
617 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
618 group now that we provide the report name, so it should always
621 2012-02-15 Murray Cumming <murrayc@murrayc.com>
623 Depend on jasperreports.
625 * pom.xml: Add the dependency. My plan is to use this on the
628 2012-01-31 Murray Cumming <murrayc@murrayc.com>
630 Implement navigation to report places.
632 * src/main/java/org/glom/web/client/activity/ReportActivity.java
633 start(): Do not bother to handle all events here.
634 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
635 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
636 Added getSelectedReport().
637 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
638 .java: start(): When handling a change to the reports chooser,
639 call getSelectedReport() and goTo() its ReportPlace.
640 * src/main/java/org/glom/web/client/ui/ReportView.java
641 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
642 Added setReportHTML() which puts the html in a gwt HTML widget.
643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
644 getReportHTML(): Return "TODO" just to show that this works.
646 2012-01-31 Murray Cumming <murrayc@murrayc.com>
648 Make ReportPlace usable.
650 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
652 * src/main/java/org/glom/web/client/place/ReportPlace.java:
653 Correct the @prefix annotation.
655 2012-01-31 Murray Cumming <murrayc@murrayc.com>
657 OnlineGlomService: Return report HTML rather than the LayoutGroup.
659 * src/main/java/org/glom/web/client/OnlineGlomService.java:
660 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
661 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
662 Change getReportLayout() to getReportHMTL() because we will not need to
663 parse or render the report layout on the client side.
664 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
665 getReportLayout(): Return the libglom LayoutGroup type because we will
666 not need to convert to a shared type, because this will not be used on
668 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
671 Note that there is still no implementation for this.
674 2012-01-27 Murray Cumming <murrayc@murrayc.com>
676 Add a (empty) Report Place, View, and Activity.
678 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
680 * src/main/java/org/glom/web/client/place/HasTablePlace.java
681 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
682 this into a superclass:
683 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
684 and also use it as the base of this new ReportPlace:
685 * src/main/java/org/glom/web/client/place/ReportPlace.java
687 * src/main/java/org/glom/web/client/ui/ReportView.java
688 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
689 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
690 Add these, containing mostly boiler-plate for now.
692 * src/main/java/org/glom/web/client/OnlineGlomService.java
693 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
694 * src/main/java/org/glom/web/server/ConfiguredDocument.java
695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
696 Add API to get the LayoutGroup for the report.
698 2012-01-23 Murray Cumming <murrayc@murrayc.com>
700 Add and fill a Reports drop-down list box.
702 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
704 * src/main/java/org/glom/web/client/OnlineGlomService.java:
705 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
706 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
707 Added getReports(document, table, localeID), calling
708 ConfiguredDocument.getReports().
709 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
710 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
711 Added setReportsList() and a list widget.
712 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
713 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
718 2012-04-12 Murray Cumming <murrayc@murrayc.com>
720 Translations: Add Esperanto.
722 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
723 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
724 properties: Add this translation because someone took the time to make it.
726 2012-03-15 Murray Cumming <murrayc@murrayc.com>
728 Adapt to the java-libglom 1.21.7 API.
730 * src/main/java/org/glom/web/server/ReportGenerator.java:
731 addToReport(): get_group_secondary_fields() is now
732 get_secondary_fields().
735 2012-03-15 Murray Cumming <murrayc@murrayc.com>
737 Use the latest java-libglom version.
739 * pom.xml: Use java-libglom 1.21.7.
741 2012-03-03 Ben Konrath <ben@bagu.org>
743 Display date and time in details view.
745 https://bugzilla.gnome.org/show_bug.cgi?id=671257
747 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
749 2012-03-05 Murray Cumming <murrayc@murrayc.com>
751 Require the latest java-libglom.
753 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
755 2012-03-04 Murray Cumming <murrayc@murrayc.com>
757 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
759 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
760 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
761 an empty quickfind string. I also corrected libglom to create only
762 empty where clauses for empty quickfind strings, but this avoids the
765 2012-02-24 Ben Konrath <ben@bagu.org>
767 Improve the tabs in the Notebook widget.
771 2012-01-30 Murray Cumming <murrayc@murrayc.com>
773 Translations: Try to translate the strings.
775 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
776 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
777 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
778 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
779 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
780 Take the Open translation from GTK+'s .po files.
781 Take the Details translation from Glom's po files.
782 I have added the other strings to Glom so we can get translations that way:
783 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
785 2012-01-27 Murray Cumming <murrayc@murrayc.com>
787 TableSelectionViewImpl: Put the search label and entry in a div.
789 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
790 Put the search widgets in a FlowTable so that the CSS can be used to
791 style them while keeping them together.
792 * src/main/webapp/style.css: Mention the new div.
794 2012-01-27 Murray Cumming <murrayc@murrayc.com>
796 Translate more strings in more locales.
798 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
799 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
800 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
801 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
802 Translate the "Details" and "Open" string too.
804 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
805 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
806 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
807 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
808 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
809 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
810 Add these new locales as placeholders though they currently contain English.
812 2012-01-27 Murray Cumming <murrayc@murrayc.com>
814 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
817 Check the ConfiguredDocument* for null before using it.
819 2012-01-26 Murray Cumming <murrayc@murrayc.com>
821 Tell Eclipse about the generated java files.
823 * .classpath: This lets it find OnlineGlomConstants.java.
824 It would be nice if Eclipse just used the maven build files.
826 2012-01-26 Murray Cumming <murrayc@murrayc.com>
828 Prevent a crash when no locale is specified in the URL.
830 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
831 Avoid returning a null string, obtained from
832 Window.Location.getParameter(). This caused a crash when it was
833 later passed to libglom's API.
834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
835 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
836 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
837 guard against future null strings.
839 2012-01-26 Murray Cumming <murrayc@murrayc.com>
841 Use the ?locale= query param instead of the &lang= token param.
843 * src/main/java/org/glom/web/client/place/ListPlace.java
844 * src/main/java/org/glom/web/client/place/DetailsPlace.java
845 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
846 Remove the lang token key and value.
848 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
849 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
850 When the user selects a different locale from the chooser, use
851 Window.Location.assign() to change the URL, which then causes a reload.
853 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
854 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
855 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
856 * src/main/java/org/glom/web/client/activity/ListActivity.java
857 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
858 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
859 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
860 * src/main/java/org/glom/web/client/ui/ListView.java:
861 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
863 Remove localeID member variables and method/constructor parameters, instead
864 using Utils.getCurrentLocaleID() when we need a localID to pass to
867 2012-01-26 Murray Cumming <murrayc@murrayc.com>
869 Internationalize the UI strings.
871 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
872 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
873 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
874 because it is unused. Messages are apparently strings that can have
875 parameters, but we do not need that yet, so Contants will be enough for now.
876 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
877 to say that we support the en and de locales.
878 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
879 The original English strings.
880 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
881 Some German translations of the English strings.
882 The i18n goal then uses the .properties file to generate an
883 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
884 returns an implementation that returns the translated strings.
885 The documentation suggests putting these in src/java/*/client/, but it seems
886 best to put it in src/resources/*/client/.
887 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
888 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
889 instead of hard-coding them.
890 Note that we cannot import OnlineGlomConstants because it does not exist yet,
891 but that does not seem to stop the build, though it confuses Eclipse.
893 You can see the translated string by adding ?locale=de to the URL, like so:
894 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
896 2012-01-24 Murray Cumming <murrayc@murrayc.com>
898 Improve null/empty String checks.
900 * pom.xml: Add a dependency on commons-lang, to use
901 org.apache.commons.lang.StringUtils.
902 * src/main/java/org/glom/web/server/ConfiguredDocument.java
903 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
904 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
905 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
906 Use StringUtils.isEmpty().
908 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
909 StringUtils class with a static isEmpty() function because we
910 cannot use org.apache.commons.lang.StringUtils in client-side
911 GWT code because it (apparently) cannot be compiled to javascript.
912 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
913 * src/main/java/org/glom/web/client/activity/ListActivity.java
914 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
915 * src/main/java/org/glom/web/client/place/DetailsPlace.java
916 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
917 * src/main/java/org/glom/web/client/place/ListPlace.java
918 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
919 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
920 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
921 * src/main/java/org/glom/web/client/ui/details/Group.java
922 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
923 our StringUtils.isEmpty() function.
925 2012-01-24 Murray Cumming <murrayc@murrayc.com>
927 Update to the latest java-libglom API.
929 * pom.xml: Require java-libglom 1.21.4.
930 * src/main/java/org/glom/web/server/ConfiguredDocument.java
931 getDocumentInfo(), getListViewLayoutGroup():
932 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
934 * src/main/java/org/glom/web/server/database/DBAccess.java
935 getFieldsToShowForSQLQueryAddGroup(),
936 getPrimaryKeyLayoutItemField(): Replace get_database_title()
937 with either get_database_title_original() or
938 get_database_title(localeID).
940 2012-01-24 Murray Cumming <murrayc@murrayc.com>
942 ConfiguredDocument: Avoid a null pointer exception.
944 * src/main/java/org/glom/web/server/ConfiguredDocument.java
945 Initialize localeID to "" to avoid returning a null String which
946 causes a crash in java-libglom's swing-generated code.
948 2012-01-23 Murray Cumming <murrayc@murrayc.com>
950 Some simple renaming.
952 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
953 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
954 for localeChooser. This seems more appropriate and is less ambiguous
955 particularly in the .css file.
957 2012-01-23 Murray Cumming <murrayc@murrayc.com>
959 ConfiguredDocument: Rename the localedID private member variable.
961 2012-01-23 Murray Cumming <murrayc@murrayc.com>
963 Adapt to the latest java-libglom API from git master.
965 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
966 libglom now uses only Vector instead of List, which uses add() instead of
969 2012-01-22 Murray Cumming <murrayc@murrayc.com>
971 ConfiguredDocument: Rename the localedID private member variable.
973 2012-01-20 Murray Cumming <murrayc@murrayc.com>
975 Build a source tarball with mvn assembly:single
977 * assembly.xml: Add this file.
978 * pom.xml: Use the maven-assembly-plugin and tell it to use
979 our assembly.xml file.
981 2012-01-19 Murray Cumming <murrayc@murrayc.com>
983 OnlineGlomServiceImpl: Get .glom files recursively.
985 * pom.xml: Depend on commons-io from org.apache.commons.
986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
987 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
988 files recursively, and with the easier filter for the extension.
989 Use org.apache.commons.io.FilenameUtils.removeExtension() to
990 simplify that code too.
992 2012-01-19 Murray Cumming <murrayc@murrayc.com>
994 README: Mention that you must install java-libglom packages separately.
996 But then it works, because java-libglom is now in the central maven
999 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1001 locales drop-down: Show the correct selected locale when the URL changes.
1003 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1004 .java: setPlace(): Move some code into fillView().
1006 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1008 locales drop-down: Do not lose the primary key.
1010 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1011 start(): onLocaleChange(): Pass the current primary key value,
1012 instead of an empty value.
1014 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1016 locales drop-down: Do not lose the drop-down selection.
1018 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1019 .java (TableSelectionActivity.fillView): Set the selected locale
1020 after changing the drop-down items (though we do not really need
1021 to change them just because the locale changes.)
1023 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1025 locales drop-down: Change the tables list when this changes.
1027 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1028 .java: TableSelectionActivity.start(): Move the async table titles
1029 retrieval into a private fillView() method and also call this when
1030 the chosen locale changes.
1031 Note that the document title is not actually translatable yet, but
1032 that is a problem that I should fix soon in libglom.
1034 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1036 Improve the placement of the locales drop-down.
1038 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1039 Put the title and locales drop-down in a div (gwt.FlowTable).
1040 * src/main/webapp/style.css: Add magic css properties to make this work.
1041 Also remove the left margin from the title so that it lines up with the
1044 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1046 locales selector: Show human-readable locale titles.
1048 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1049 getDocumentInfo(): Use java.util.Locale to show a real title of
1050 each locale, in the locale's own language.
1052 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1054 Add a language/locale selector drop-down.
1056 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1057 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1058 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1059 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1060 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1061 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1062 Add a ListBox to show the available locales. Add getLocaleSelector(),
1063 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1064 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1065 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1066 java: Add these classes.
1067 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1068 start(): Fill the locales ListBox. Handle its change event, firing a
1070 setPlace(): Show the selected locale as specified by the URL token.
1071 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1072 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1073 Handle LocaleChangeEvent, going to a new *Place with that locale.
1075 The placement of the ListBox is not pretty, and it currently uses the ID
1076 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1080 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1082 Search box: Show the search text from the URL token.
1084 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1085 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1086 Add setQuickFindText().
1087 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1088 .java: setPlace(): Store the queryText if the place is a ListPlace,
1089 and call TableSelectionView.setQuickFindText().
1091 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1093 Allow use of translations via, for instance, &lang=de in the URL.
1095 * pom.xml: Use the unstable java-libglom 1.21 version.
1097 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1098 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1099 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1100 init(): Instead of calling TranslatableItem.set_current_locale()
1101 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1102 However, this is only for default locales, which are not needed to
1103 change the locale in the URL.
1104 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1105 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1106 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1107 layout for a particular locale.
1108 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1109 Add get/setDefaultLocaleID().
1110 getDocumentInfo(), getListViewData(), getRelatedListData(),
1111 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1112 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1113 localeID parameter, so we can get the layout for a particular locale.
1115 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1116 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1117 * src/main/java/org/glom/web/client/place/ListPlace.java:
1118 Parse and construct a lang parameter too.
1120 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1121 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1122 passed to subsequent methods and constructors.
1123 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1124 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1125 Store the localeID from the *Place and pass it to other constructors
1126 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1128 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1129 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1130 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1131 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1132 * src/main/java/org/glom/web/client/ui/ListView.java:
1133 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1134 Take localeID parameters and pass them to subsequent constructors and
1135 methods, so that the layout is always retrieved for that locale.
1137 This is rather repetitive.
1139 Note that "" means the original (default) locale of the Glom document,
1140 which is usually English.
1142 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1144 Documents: Remove final keyword to fix startup configuration.
1146 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1147 final keywords on the private member variables because that breaks
1148 the startup, apparently (there are warnings) because it stops them
1149 from being serialized. I added these in the previous commit.
1151 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1153 Documents: Add some final keywords.
1155 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1158 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1160 OnlineGlomServiceImpl: Add to overview comments.
1162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1163 Note that this is where all the document are loaded. They are not
1164 loaded freshly for each page.
1166 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1170 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1171 Add a TextBox for the text of a quick find.
1172 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1174 setBackLink(): Add a String quickFind parameter.
1175 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1176 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1177 to the base interface, because that is how TableSelectionViewImpl is used.
1178 * src/main/webapp/style.css: Add style for the search box and its label.
1180 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1181 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1182 Add these files, based on the existing TableChangeEvent and
1183 TableChangeEventHandlers.
1184 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1185 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1186 a ListPlace() that the user should be taken to.
1187 * src/main/java/org/glom/web/client/activity/ListActivity.java
1188 start(): Handle it here too and adapt the TableChangeEvent handler to
1189 pass the extra "" quickFind parameter to ListPlace.
1190 * src/main/java/org/glom/web/client/place/ListPlace.java:
1191 Constructor: Take an extra String quickFind parameter and store it,
1192 returning it from a new getQuickFind() method.
1193 getToken(): Put the quickFind text in the URL token.
1194 getPlace(): Parse the quickFind text from the URL token.
1195 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1196 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1197 ListPlace constructor.
1198 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1199 .java: start(): Add a Change handler for the TableSelectionView's
1200 TextBox (via its base HasChangeHandlers interface), firing the new
1201 QuickFindChangeEvent.
1202 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1203 pass the extra "" quickFind parameter.
1205 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1206 setCellTable(): Add a String quickFind parameter and pass it to
1207 the ListViewTable() constructor.
1208 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1209 setCellTable() in the base interface, because that is how ListViewImpl
1212 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1213 Add a String quickFind member variable.
1214 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1215 Constructor: Add a String quickFind parameter, storing it in the
1216 base ListTable's member variable.
1217 onRangeChanged(): Pass quickFind to the
1218 OnlineGlomServiceAsync.getSortedListViewData() and
1219 OnlineGlomServiceAsync.getListViewData() methods.
1221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1222 getListViewData(), getSortedListViewData(): Add a String quickFind
1223 parameter, passing it to ConfiguredDocument.getListViewData().
1224 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1225 Change getListViewData(), getSortedListViewData() in the base interface,
1226 because that is how OnlineGlomServiceImpl is used, via this:
1227 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1228 Change getListViewData(), getSortedListViewData() here too.
1229 This class can apparently be used to asynchronously call methods on
1230 OnlineGlomService, and GWT seems to implement that after recognizing
1231 just the *Async name convention and the extra AsyncCallback parameters.
1233 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1234 getListViewData(): Add a String quickFind parameter, and pass it to
1235 ListViewDBAccess.getData().
1236 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1237 getListData(): Add a String quickFind parameter and pass it to
1239 getSelectQuery(): Add a String quickFind parameter.
1240 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1241 getSelectQuery(): Add a String quickFind parameter and use it with
1242 Glom.get_find_where_clause_quick() to pass a where_clause to
1243 Glom.build_sql_select_with_where_clause(), to actually filter the
1245 getData(): Add a String quickFind parameter, passing it to getListData().
1246 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1247 va: getData(): Pass an empty string to getListData() for the
1248 quickFind parameter.
1250 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1252 ListTable: Minor change.
1254 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1255 createCellTable(): Make this protected instead of public.
1257 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1259 Many files: Use final for the parameters and use the @override attribute.
1261 2012-01-22 Ben Konrath <ben@bagu.org>
1263 Add anchor links for single line text that starts with http, ftp and www.
1267 2012-01-22 Ben Konrath <ben@bagu.org>
1269 Add ellipsis to single line text in details view.
1273 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1275 Remove all javadoc author tags.
1277 Because they are awkward and meaningless when many people touch
1279 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1281 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1283 Revert the COPYING.LESSER to COPYING rename.
1285 Apparently both should be there if it is LGPL.
1287 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1289 *View: Remove unused imports.
1291 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1292 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1293 * src/main/java/org/glom/web/client/ui/ListView.java:
1294 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1295 Remove unused imports, as suggested by Eclipse.
1297 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1299 Move the *View::Presenter types, and some API into one base View.
1301 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1302 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1303 * src/main/java/org/glom/web/client/ui/ListView.java:
1304 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1305 Presenter, setPresenter() and clear() into a shared base interface,
1306 to avoid the unnecessary duplicate Presenter types and to more clearly
1307 show how the *Views share the same structure, even if they are not
1308 used polymorphically.
1310 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1311 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1313 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1314 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1315 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1317 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1320 Feel free to revert this if there is a good reason for the duplicate
1323 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1325 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1327 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1328 a class member instead of a local variable in the method.
1329 This lets us use it to get the view instances, for use in tests.
1330 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1331 beforeOnlineGlom(): Test some more details of the initial view.
1332 Again, this is not very useful.
1334 To really test gwt-glom we will need to start a local postgresql
1335 instance with local data, like the Glom tests in C++.
1337 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1339 pom.xml: Mention the LGPL license.
1341 * pom.xml: Add a licenses section.
1342 * COPYING.LESSER: Move this to COPYING, which
1343 previously contained the GPL. But gwt-glom is all LGPL.
1345 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1347 Add project information to README and pom.xml.
1349 * README: Add a brief description and mention some mvn
1351 * pom.xml: This extra information shows up in mvn site
1354 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1356 Use the latest java-libglom version.
1358 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1360 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1362 GwtTestOnlineGlom: Test a little more.
1364 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1365 protected rather than private, as suggested by the gwt-test-utils
1367 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1368 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1369 Test the initial visibility of the panels.
1371 However, this is not a very useful test.
1372 And I wonder how we should generally test using this idea for an
1373 activity/places app like ours where the real changes happen implicitly
1374 based on the history token/URL.
1376 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1378 Slight modification to *Mapper comments.
1380 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1381 (DataActivityMapper)
1382 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1384 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1386 Remove comments mentioning GIN because they are just copied from
1387 the example code and are apparently not helpful:
1388 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1389 Also change the mention of a class that is only in the example code.
1391 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1393 GwtTestOnlineGlom test: Minor changes.
1395 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1396 Avoid the long qualified class name and modify the comment
1397 because it is now obvious to me that the mocked class is the only
1398 custom one created via GWT.create().
1400 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1402 Tests: Added the beginnings of a test using gwt-test-utils.
1404 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1405 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1406 which tells gwt-test-utils what class will be tested.
1407 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1408 Add a simple (but empty) test case. One class, used by the OnlineGlom
1409 class, is mocked so that it can be created. However, I am not sure
1410 why only this class needs to be mocked.
1412 Note that mockito seems more popular, and clearer, than easymock,
1413 but I have not got that working yet. It might be a matter of the
1416 This test is run during mvn integration-test.
1418 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1420 Tests: Use junit4-style syntax instead of junit3-style.
1422 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1423 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1424 * src/test/java/org/glom/web/shared/DataItemTest.java:
1425 Use the @Test annotation rather than relying on the test*() prefix.
1426 Also no longer implement TestCase, to avoid triggering support for
1427 the junit3-way, which stops the annotations from working.
1428 Change the imports from import junit.framework.* to
1429 import org.junit.*, which is apparently the new way.
1431 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1433 Added a test for ListPlace token parsing and creation.
1435 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1436 This is much the same as DetailsPlaceTest.
1438 I wonder how we could test the other parts of the *Place API.
1440 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1442 DetailsPlace test: Also test getToken() and recreation via getPlace().
1444 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1445 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1446 recreate it, testing the recreated DetailsPlace for the same parameter
1449 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1451 Use the surefire-report plugin.
1453 * pom.xml: This generates a HTML report about the tests in
1454 target/site/surefire-report.html
1455 when you do mvn surefire-report:report. It seems to be popular/normal.
1457 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1459 Added a test for DetailsPlace.
1461 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1462 Test the getPlace() token parsing.
1464 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1466 Added a first unit test.
1468 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1469 * src/test/java/org/glom/web/shared/DataItemTest.java:
1470 This is a silly test but it is just to get things started. Note that
1471 maven/junit finds the test because it looks in src/test by default.
1473 2011-12-22 Ben Konrath <ben@bagu.org>
1475 Change charsetName to "UTF-8" when replacing line breaks.
1477 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1478 that work in Java (such as "UTF8") will not work when compiled to
1481 This fixes a problem with multi-line details view fields that have hard
1482 line breaks. The "License Text" field on this page demonstrates the
1485 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1487 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1489 2011-12-22 Ben Konrath <ben@bagu.org>
1491 Fix another bug with related list navigation.
1493 I've tested all the navigation buttons in all of the related lists
1494 so things should be good now.
1496 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1498 2011-12-22 Ben Konrath <ben@bagu.org>
1500 Fix a crasher when refreshing the list view with the default table.
1502 This crash will also happen when loading the list view with the default
1503 table from a link or bookmark.
1505 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1506 to the main document selection page when the document id hasn't been
1508 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1509 the main document selection page when the document id hasn't been
1511 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1512 values for the details place when the document id hasn't been set.
1513 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1514 values for the list place when the document id hasn't been set.
1516 2011-12-21 Ben Konrath <ben@bagu.org>
1518 Protect against NPE when glom.document.locale is not in config.
1520 This patch protects against an NPE when glom.document.locale is not in
1521 the config file. This NPE will also happen if glom.document.locale is
1524 The patch also updates the error message to display the class name when
1525 the getMessage() returns null. This was happening when the NPE was
1526 thrown and I had "Configuration Error: null". If an NPE is encountered
1527 with this patch, "Configuration Error: NullPointerException " will be
1530 This commit closes this bug:
1532 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1534 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1536 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1538 Rename onlineglom.properties to onlineglom.properties.sample.
1540 * src/main/resources/onlineglom.properties: Rename to:
1541 * src/main/resources/onlineglom.properties.sample:
1542 * src/main/resources/README: And add this file explaining that people
1543 should rename it back when deploying.
1545 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1547 Allow choosing the translation in the .properties file.
1549 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1550 init(): Read a glom.document.locale value from the configuration file
1551 and call Glom's TransatableItem::set_current_locale() method.
1552 * src/main/resources/onlineglom.properties: Add a commented-out
1553 example of this new setting.
1555 It would be better to add &lang=de_DE to the URL, but the current
1556 libglom API does not allow us to do this easily. I am working on that.
1558 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1560 Avoid a crash in parsing of token parameters.
1562 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1563 ava: getTokenParams(): Do not crash if a parameter has a key but no
1564 value, and ignore parameters with neither.
1566 2011-12-17 Murray Cumming <murrayc@murayc.com>
1568 History token building/handling: Improve use of token parameters.
1570 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1571 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1572 and buildParamsToken(HashMap), for use by derived classes.
1573 Make the separator private because it is no longer be needed.
1574 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1575 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1576 instead of manual string concatenation.
1577 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1578 of hardcoded indices and awkward splitting code.
1579 * src/main/java/org/glom/web/client/place/ListPlace.java
1580 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1581 instead of manual string concatenation.
1582 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1583 of hardcoded indices and awkward splitting code.
1584 This should fix bug #666420
1586 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1588 Fix a Navgiation->Navigation typo in the code.
1590 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1591 Rename processNavgiation() to processNavigation().
1593 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1595 Fix a seperator->separator typo in the code.
1597 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1598 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1599 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1602 2011-12-15 Ben Konrath <ben@bagu.org>
1604 Cleanup some comments.
1606 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1608 2011-12-14 Ben Konrath <ben@bagu.org>
1610 Replace \n with <br/> for multiline text in the details view.
1612 Vertical scrollbars are added when needed as well.
1614 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1616 2011-12-14 Ben Konrath <ben@bagu.org>
1618 Specify the font for document selection links.
1620 * src/main/webapp/style.css:
1622 2011-12-14 Ben Konrath <ben@bagu.org>
1624 Fix bouncy CellTable while paging.
1626 This doesn't currently work with related list tables in unselected
1629 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1631 2011-12-14 Ben Konrath <ben@bagu.org>
1633 Revamp the appearance of the document selection page.
1635 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1636 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1637 * src/main/webapp/style.css:
1639 2011-12-13 Ben Konrath <ben@bagu.org>
1641 Set navigation button column to the smallest size possible.
1643 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1645 2011-12-13 Ben Konrath <ben@bagu.org>
1647 Change OpenButton nomenclature to NavigationButton.
1649 Using NavigtionButton makes things more generic. Classes, methods and
1650 variables have been changed.
1652 This is a rename-only refactor.
1654 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1655 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1656 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1657 Renamed from OpenButtonCell.
1658 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1659 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1660 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1662 2011-12-12 Ben Konrath <ben@bagu.org>
1664 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1666 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1667 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1668 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1669 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1671 2011-12-12 Ben Konrath <ben@bagu.org>
1673 Update variable names and comments.
1675 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1676 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1678 2011-12-12 Ben Konrath <ben@bagu.org>
1680 Properly initialize numNonEmptyRows variable to zero.
1682 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1683 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1685 2011-12-05 Ben Konrath <ben@bagu.org>
1687 Add latest mockup with HTML tables.
1689 Features of this mockup:
1691 -> HTML table for flowtable
1692 -> HTML table for flowtable column
1693 -> Example of how related lists would look
1694 -> Not using text entries for data items
1696 The current version of Online Glom doesn't use HTML tables for the
1699 This mockup has been sent to the glom-devel mailing list but it's good
1700 to have it here as well.
1702 * mockups/details-view-html-tables.html:
1704 2011-12-05 Ben Konrath <ben@bagu.org>
1706 Remove unnecessary getPrimaryKeyField() method.
1708 getPrimaryKeyFieldForTable(String) has been renamed to
1709 getPrimaryKeyField(String).
1711 * src/main/java/org/glom/web/server/database/DBAccess.java:
1712 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1713 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1715 2011-12-05 Ben Konrath <ben@bagu.org>
1717 Add string representation of TypedDataItem value to conversion error message.
1719 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1720 message was extracted into its own method to avoid duplication.
1722 2011-12-05 Ben Konrath <ben@bagu.org>
1724 Add type checking to navigation primary key value creation.
1726 Create navigation primary key only if the expected type from the Glom
1727 document matches the type returned by the SQL query.
1729 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1731 2011-12-05 Ben Konrath <ben@bagu.org>
1733 Rename a couple of variables in RelatedListNavigation.
1735 This is a rename-only refactor.
1737 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1739 2011-12-05 Ben Konrath <ben@bagu.org>
1741 Move getListLayoutGroup() into getListViewLayoutGroup().
1743 This removes getListLayoutGroup(). It was only being called by
1744 getListViewLayoutGroup().
1746 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1748 2011-12-05 Ben Konrath <ben@bagu.org>
1750 Remove check for LayoutItem_Portal in list table method.
1752 This check is no longer necessary because the method isn't being used
1753 to create the LayoutItemPortal DTO.
1755 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1757 2011-12-05 Ben Konrath <ben@bagu.org>
1759 Properly support related list navigation.
1761 Navigation from the "Repository Analyzer -> Package Scans ->
1762 Dependencies" related table wasn't working because the primary key for
1763 related tables wasn't being set properly. This commit fixes the
1766 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1767 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1768 doesn't set the primary key properly for related list tables.
1769 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1770 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1771 useful for getting the primary key for list view tables and for related
1773 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1774 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1775 Move code to set the primary key for the table from the abstract
1776 ListDBAccess class to ListViewDBAccess as it's only correct for list
1778 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1779 Properly add primary key to related list tables.
1781 2011-12-02 Ben Konrath <ben@bagu.org>
1783 Properly set the horizontal alignment of fields.
1785 This fix is for both the list tables and the details view.
1787 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1788 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1789 to set the horizontal alignment of fields.
1791 2011-12-02 Ben Konrath <ben@bagu.org>
1793 Display currency codes in the details view.
1795 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1797 2011-12-02 Ben Konrath <ben@bagu.org>
1799 Avoid duplicate JNI call.
1801 JNI is not as efficient as pure Java and this is an easy (and small)
1804 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1805 Use previously retrieved value for whereClauseToTableName instead of
1808 2011-12-02 Ben Konrath <ben@bagu.org>
1810 Rename a couple of variables in RelatedListNavigation.
1812 This is a rename-only refactor.
1814 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1816 2011-12-02 Ben Konrath <ben@bagu.org>
1818 Indicate clearly that a mismatched primary key type is a bug.
1820 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1821 warning to error. Add 'This is a bug.' to message.
1823 2011-12-02 Ben Konrath <ben@bagu.org>
1825 Update / fix some comments.
1827 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1829 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1831 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1832 Fix comments. Add some TODOs.
1834 2011-12-02 Ben Konrath <ben@bagu.org>
1836 Enable navigation to details view with string primary key from related list.
1838 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1839 Create a text primary key value when return type of result is
1840 java.sql.Types.VARCHAR.
1842 2011-12-02 Ben Konrath <ben@bagu.org>
1844 Use checkboxes for booleans in the details view.
1846 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1848 2011-12-01 Ben Konrath <ben@bagu.org>
1850 Improve performance of related list height calculation.
1852 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1853 Put code to calculate the expected height in a static initializer so
1854 that that it's only called once.
1856 2011-12-01 Ben Konrath <ben@bagu.org>
1858 Show related list tables in notebooks (again).
1860 Calculate the height of the related list tables so the Notebook can be
1861 set the correct height. The height of the related list table is also needed by
1862 FlowTable to be able decide how to create the layout.
1864 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1865 and set the Portal height based on the height of the related list
1866 table and the Portal container.
1867 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1868 Add method to calculate the height of the related list tables.
1869 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1870 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1871 calculate the height of the Pager widget.
1873 2011-12-01 Ben Konrath <ben@bagu.org>
1875 Use CellTable API for table property instead of setting style on Element.
1877 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1879 2011-12-01 Ben Konrath <ben@bagu.org>
1881 Make ListViewTable and RelatedListTable a consistent height.
1883 The tables are now a consistent height regardless of the contents of
1884 the table. A hidden button is added to empty rows to ensure that the
1885 height of these rows will match the height of rows with data.
1887 A navigation button column is now added to every table. The width of
1888 the navigation column is set to 0px when a RelatedListTable shouldn't
1889 have navigation buttons. This maintains the a consistent row height in
1890 tables that don't show the navigation buttons.
1892 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1893 navigation column when not needed.
1894 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1895 arguments for navigation button to constructor of ListViewTable.
1896 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1897 hidden button for empty data rows.
1898 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1899 arguments for navigation button to constructor.
1900 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1901 create navigation buttons. Add hideNavigationButtons() method.
1902 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1903 arguments for navigation button to constructor.
1905 2011-12-01 Ben Konrath <ben@bagu.org>
1907 Use 'visibility: hidden' in Utils.getWidgetHeight().
1909 This is better choice because hidden elements are invisible, don't
1910 respond to events and are not part of the tab order. They will,
1911 however, take up space which is required to be able to calculate the
1912 height of the widget.
1914 * src/main/java/org/glom/web/client/Utils.java:
1916 2011-12-01 Ben Konrath <ben@bagu.org>
1918 Use Utils.getWidgetHeight() in FlowTable.
1920 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1922 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1924 2011-12-01 Ben Konrath <ben@bagu.org>
1926 Put the details css class name on the correct table column.
1928 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1930 2011-11-30 Ben Konrath <ben@bagu.org>
1932 Update for java-libglom API change.
1934 The getters and setters on FieldFormatting and NumericFormat were
1935 changed to remove the 'M'.
1937 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1939 2011-11-29 Ben Konrath <ben@bagu.org>
1941 Only allow RelatedListTables in Portals.
1943 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1945 2011-11-29 Ben Konrath <ben@bagu.org>
1947 Only create a contents panel for Portals when title is being set.
1949 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1951 2011-11-29 Ben Konrath <ben@bagu.org>
1953 Set TabLayoutPanel height based on calculated height its widgets.
1955 This is a potential fix for this bug:
1957 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1959 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1961 2011-11-29 Ben Konrath <ben@bagu.org>
1963 Align details field labels and data with the Open buttons.
1965 * src/main/webapp/style.css:
1967 2011-11-29 Ben Konrath <ben@bagu.org>
1969 Remove unnecessary <div> in the Notebook widget.
1971 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1972 method to get container FlowPanel (<div>).
1973 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1974 initWidget() method directly on the TabLayoutPanel widget instead of
1975 Group's container widget.
1977 2011-11-29 Ben Konrath <ben@bagu.org>
1979 Don't add group titles for Portals in Notebooks.
1981 This reverts the previous patch and fixes a bug I introduced with
1982 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1984 * src/main/java/org/glom/web/client/ui/details/Group.java:
1985 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1987 2011-11-28 Ben Konrath <ben@bagu.org>
1989 Remove unused boolean argument in Portal constructor.
1991 Just a code cleanup.
1993 * src/main/java/org/glom/web/client/ui/details/Group.java:
1994 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1996 2011-11-28 Ben Konrath <ben@bagu.org>
1998 Remove hack for glom 1.18 style glom files.
2000 * src/main/java/org/glom/web/client/ui/details/Group.java:
2001 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2002 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2004 2011-11-28 Ben Konrath <ben@bagu.org>
2006 Use Gda Value version of primary key to log result too large error.
2008 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2010 2011-11-28 Ben Konrath <ben@bagu.org>
2012 Don't use TypedDataItem.getText() for Unknown types from the URL.
2014 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2015 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2016 instead of getText().
2017 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2018 String field and getUnknown() method.
2020 2011-11-28 Ben Konrath <ben@bagu.org>
2022 Log an error message when the java-libglom .so is not present.
2024 The error message was being set in the exception but not logged.
2026 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2028 2011-11-28 Ben Konrath <ben@bagu.org>
2030 Ignore LayoutItem_CalendarPortals.
2032 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2033 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2035 2011-11-28 Ben Konrath <ben@bagu.org>
2037 Extract method for creating the LayoutItemPortal DTO.
2039 Just breaking the code up into smaller chunks.
2041 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2043 2011-11-28 Ben Konrath <ben@bagu.org>
2047 This should have been added with the refactor. Oops!
2049 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2051 2011-11-28 Ben Konrath <ben@bagu.org>
2053 Create primary key value from URL string using type from Glom document.
2055 See this bug, comments 19 - 25:
2057 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2059 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2060 create a TypeDataItem for the primary key here when loading from a
2061 URL. Show the same string for the primary key value as was received
2062 from the URL string (when loading from a URL).
2063 * src/main/java/org/glom/web/server/Utils.java: Update method for
2064 creating the Gda Value from the TypeDataItem to properly deal with
2065 creating a Gda Value based on the Glom document type for the primary
2066 key value string when loading from a URL.
2067 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2068 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2069 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2070 Update for changed method name.
2072 2011-11-27 Ben Konrath <ben@bagu.org>
2074 Rename PrimaryKeyItem to TypedDataItem.
2076 The name PrimaryKeyItem suggests what the class should be used for.
2077 TypedDataItem is a neutral name that describes the class better.
2079 This is a rename-only refactor.
2081 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2082 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2083 * src/main/java/org/glom/web/client/Utils.java:
2084 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2085 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2086 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2087 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2088 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2089 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2091 * src/main/java/org/glom/web/server/Utils.java:
2092 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2093 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2094 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2095 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2097 2011-11-25 Ben Konrath <ben@bagu.org>
2099 Improve Gda Value conversion from PrimaryKeyItem.
2101 The value from the PrimaryKeyItem is only used if its type match the
2102 type from the glom document.
2104 * src/main/java/org/glom/web/server/Utils.java:
2106 2011-11-25 Ben Konrath <ben@bagu.org>
2108 Manually check if the java-liblgom .so is visible to the JVM.
2110 It seems that Tomcat has problems when a static initializer throws an
2111 exception. This check is done before the first method call into
2112 java-libglom so that execution doesn't continue if the .so is not
2115 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2117 2011-11-25 Ben Konrath <ben@bagu.org>
2119 Improve browser configuration error messages.
2123 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2125 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2126 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2127 getConfigurationErrorMessage() method.
2128 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2129 Get and display a specific configuration error message when no Glom
2130 documents are found.
2131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2132 Implement getConfigurationErrorMessage() method. Surround configuration
2133 code in the init() method with a try/catch block. This allows the
2134 errors to be caught while keeping the servlet available to retrieve the
2135 configuration error message.
2137 2011-11-25 Ben Konrath <ben@bagu.org>
2139 Don't use Strings to hold primary key values.
2141 The primary key values are now held in a new data object
2142 (PrimaryKeyItem) that holds type information and the primary key value
2143 using the correct type.
2145 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2146 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2148 PrimaryKeyItem instead of String to hold the primary key value.
2149 * src/main/java/org/glom/web/client/Utils.java: Remove
2150 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2151 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2152 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2153 PrimaryKeyItem instead of String to hold the primary key value. Load
2154 document selection page when the documentID has not been set correctly.
2155 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2156 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2158 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2159 Return empty string for URL instead of "null".
2160 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2161 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2162 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2163 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2164 PrimaryKeyItem instead of String to hold primary key values.
2165 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2166 PrimaryKeyValue to a Gda Value.
2167 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2168 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2169 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2170 Replace temporary database access code that uses the PrimaryKeyValue to
2171 Gda Value conversion.
2172 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2173 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2174 PrimaryKeyItem instead of String.
2175 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2176 hold primary key values.
2178 2011-11-24 Ben Konrath <ben@bagu.org>
2180 Use newly added java-libglom API to create queries.
2182 This isn't finished. I still need to stop using Strings for primary key
2183 values in the client code.
2185 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2186 libglom to use fake connections so that retrieving the query string will
2188 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2189 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2190 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2191 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2192 Use the newly added libglom sql methods and classes to create the
2193 query. Add temporary hack to convert primary value strings to Gda
2196 2011-11-23 Ben Konrath <ben@bagu.org>
2198 Don't explicitly set the height of Portals.
2200 See comments 6 - 10 of this bug for details:
2202 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2204 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2206 2011-11-23 Ben Konrath <ben@bagu.org>
2208 Use an HTML table instead of CSS for the FlowTable layout.
2210 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2211 GWT's FlexTable to implement the FlowTable.
2212 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2214 2011-11-18 Ben Konrath <ben@bagu.org>
2216 Add boolean example to HTML table mockup.
2218 * mockups/details-view-html-tables-text-entries.html:
2220 2011-11-17 Ben Konrath <ben@bagu.org>
2222 Ensure the pager buttons are always visible for related lists.
2224 To accomplish this, I've turned off text wrapping in the list view and
2225 related list tables for both the header and data text. The related list
2226 table now has a fixed layout so the it doesn't overflow its container.
2227 This is required to ensure that the cell text is clipped when it
2228 overflows the cell and an ellipsis is added to the right side of the
2229 cell when text is clipped.
2231 A fixed table layout for the related list table in the details view
2232 seems what we want for the details view anyway, so the side-effect is
2235 The ellipsis will only be displayed in Firefox >= 7.
2239 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2241 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2242 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2243 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2245 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2246 Set the 'table-layout: fixed' CSS property to the related list table.
2247 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2248 'white-space: nowrap;' CSS property on both the list view and the
2249 related list tables.
2251 2011-11-16 Ben Konrath <ben@bagu.org>
2253 Rework the fix for empty notebook tab labels.
2255 Setting the empty group titles with its name caused problems for the
2256 details layout. Instead of using libglom's
2257 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2258 to the client when the title is empty. This allows the Notebook to use
2259 the name when the title is empty without affecting anything else.
2261 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2262 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2264 2011-11-16 Ben Konrath <ben@bagu.org>
2266 Set group titles with name when title is empty.
2268 This fixes a problem with an empty notebook tab label in the Lesson
2269 Planner document. The forth tab in the notebook should be "Internet":
2271 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2273 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2274 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2277 2011-11-16 Ben Konrath <ben@bagu.org>
2279 Remove whitespace from the configured username properties.
2281 This assumes that usernames won't have whitespace at the beginning
2282 or end. But I think this is a reasonable assumption.
2284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2285 String.trim() to remove the whitespace from the username properties.
2287 2011-11-15 Ben Konrath <ben@bagu.org>
2289 Add details view mockup with HTML tables and text entries.
2291 This is from the attachment on this bug:
2293 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2295 * mockups/details-view-html-tables-text-entries.html:
2297 2011-11-15 Ben Konrath <ben@bagu.org>
2299 Add space between the columns of the flow table.
2303 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2305 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2306 space between columns in the flow table.
2308 2011-11-15 Ben Konrath <ben@bagu.org>
2310 Add backup files to the .gitignore.
2312 * .gitignore: Ignore files that end with ~.
2314 2011-11-09 Ben Konrath <ben@bagu.org>
2316 Use latest release of gwt-log.
2318 Gwt-log releases are now being submitted to the maven central
2319 repository so manual installation of the jar is no longer required.
2321 * pom.xml: Update version and groupId of gwt-log dependency.
2323 2011-10-31 Ben Konrath <ben@bagu.org>
2325 Don't use GWT numeric formatting to override the glom currency formatting.
2327 Currencies are now displayed like they are in Glom. See this bug:
2329 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2331 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2333 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2334 currency code to constructor and set it when the cell is rendered.
2335 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2336 currency code to the constructor of the NumericCell.
2338 2011-10-27 Ben Konrath <ben@bagu.org>
2340 Require the latest release of java-libglom (1.17.4).
2344 2011-10-26 Ben Konrath <ben@bagu.org>
2346 Add style to Notebook that matches current theme.
2348 It's not the best style in the world but it's better than the default.
2350 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2351 padding at the bottom of the child widgets.
2352 * src/main/webapp/style.css: Add style for the Notebook.
2354 2011-10-26 Ben Konrath <ben@bagu.org>
2356 Move servlet initialization code to overridden init method.
2358 This is half of the solution to getting proper error messages
2359 displayed when configuration errors occur. Here's the relevant bug:
2361 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2363 The rest of the solution involves surrounding the init method with a
2364 try/catch block and setting a global variable with the error /
2365 exception. A new async method should be created to retrieve and display
2366 the error message / exception.
2368 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2369 code from constructor to init method adding exceptions as needed.
2371 2011-10-26 Ben Konrath <ben@bagu.org>
2373 Add script to monitor and restart tomcat if required.
2375 * utils/check-and-recover-tomcat.py: New file.
2377 2011-10-26 Ben Konrath <ben@bagu.org>
2379 Display the correct number of data items in the pager.
2383 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2385 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2386 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2387 The implementation is the same for both tables: Keep track of the
2388 number of non-empty rows and fire and RowCountChangeEvent after the data has
2390 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2391 custom Pager class that subclasses SimplePager to handle displaying
2392 the correct number when empty rows have been added.
2394 2011-10-26 Ben Konrath <ben@bagu.org>
2396 Correct error in previous commit.
2398 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2399 eventBus parameter from listView.setCellTable().
2401 2011-10-26 Ben Konrath <ben@bagu.org>
2403 Fix error in TODO comment.
2405 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2407 2011-10-24 Ben Konrath <ben@bagu.org>
2409 Create Notebook widgets to the details view.
2411 This isn't finished just yet - I still need to create a reasonable
2412 style to match the current theme.
2414 * src/main/java/org/glom/web/client/Utils.java: Add method for
2415 calculating the height of a widget. This is used in the Notebook class.
2416 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2417 new constructor method in Group.
2418 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2419 method for creating child widget that can be used by subclasses
2420 like Notebook. New constructor that allows disabling the group
2421 titles - Notebooks don't set a group title for their child groups.
2422 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2423 to make Notebooks using GWT's TabLayoutPanel.
2424 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2425 constructor that allows disabling the group titles.
2426 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2427 LayoutItemNotebook DTO.
2428 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2429 DTO for Notebooks. It's just an empty class for now but we might need
2430 it to transfer some specific information in the future.
2432 2011-10-21 Ben Konrath <ben@bagu.org>
2434 Add navigation buttons to related list tables.
2436 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2437 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2439 method getSuitableRecordToViewDetails() for getting the table name
2440 and primary key value for related list navigation buttons.
2441 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2442 private cell renderer class to get the navigation information for
2443 related list tables from the server. Extract the navigation
2444 processing code from the details cell navigation and use it for the
2445 related list navigation as well.
2446 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2447 cell renderer class for the details open buttons. This was needed
2448 because the related list navigation buttons and the list view
2449 navigation buttons need to react differently when clicked.
2450 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2451 the onEnterKeyDown() method because it's now overriden in the
2452 subclasses that are specific to the related list tables and the list
2454 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2455 the vertical size a little because the buttons add a bit of vertical
2456 space to table. This is not a perfect solution because the vertical
2457 size of with table fewer than 5 rows will be a little smaller.
2458 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2459 changes in how navigation buttons are handled.
2460 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2461 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2462 database access object.
2463 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2464 to find the portal for a given relationship name from
2465 RelatedListDBAccess. Add method to find a primary key field for a
2467 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2468 Move code to find the portal for a given relationship name to
2470 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2471 New file: database access object for getting the related list
2472 navigation information (the table name and the primary key value).
2473 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2474 DTO for transferring a table name to navigate to and a primary key
2476 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2477 boolean and getter/setter to specifies if the related list should add
2480 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2482 Use the master branch of java-libglom
2484 * pom.xml: Depend on java-libglom 1.19 instead.
2486 This is the master branch. See also the libglom-1-18 branch.
2488 2011-10-11 Ben Konrath <ben@bagu.org>
2490 Enable the open navigation button when the data has been set.
2492 This avoids having active buttons that don't do anything when the data
2495 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2497 2011-10-11 Ben Konrath <ben@bagu.org>
2499 Use IsWidget interface for FlowTableItem.
2501 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2502 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2504 2011-10-11 Ben Konrath <ben@bagu.org>
2506 Remove GWT styling from open button in details view.
2508 There are still some issues with how the details cell is arranged but
2509 this should be made to match Glom 1.20. I'm going to leave fixing this
2510 until I have Glom 1.20 up and running.
2512 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2513 style name on open button.
2514 * src/main/webapp/style.css: Move and edit details-navigation class.
2515 Re-arrange some classes to make them appear in the same order as the
2518 2011-10-07 Ben Konrath <ben@bagu.org>
2520 Update to GWT 2.4.0.
2522 * .gitignore: Ignore new cache directory.
2523 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2524 * pom.xml: Change GWT and maven plugin to 2.4.0.
2525 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2527 * src/main/java/org/glom/web/client/ClientFactory.java:
2528 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2529 * src/main/java/org/glom/web/client/OnlineGlom.java:
2530 Update source for API changes.
2531 * utils/build-onlineglom-war.sh: Remove cache directory before the
2534 2011-10-07 Ben Konrath <ben@bagu.org>
2536 Add navigation buttons in the details view.
2538 This isn't finished but I thought I'd commit what I have as it's a
2539 pretty good start. I still need to:
2541 1. Change the style so that it fits better into the current theme
2542 2. Adjust the details cell to expand as much as possible.
2544 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2545 click handlers to navigation buttons in the DetailsCells. Create a
2546 refreshData() method to get just the data from the server without the
2548 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2549 Update the tableSelector and browser title when the table name
2550 changes without using the tableSelector.
2551 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2552 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2553 getDetailsCells() to getCells(). Update variable names.
2554 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2555 method to set click handler on navigation button. Rename a few
2556 variables. Add navigation buttons where needed.
2557 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2558 variables and methods.
2559 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2560 navigation boolean and navigation table as required in the
2561 LayoutItemField DTO.
2562 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2563 variables for navigation along with getter/setter methods.
2565 2011-10-07 Ben Konrath <ben@bagu.org>
2567 Rename Field to DetailsCell.
2569 This is a refactor-only commit. No functionality has been added or
2572 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2573 Update variable and method names.
2574 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2575 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2576 variable and method names.
2577 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2579 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2580 variable and method names.
2582 2011-10-07 Ben Konrath <ben@bagu.org>
2584 Create separate methods for layout and data the details view.
2586 This is a refactor-only commit. No functionality has been added or
2589 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2590 private methods: setData(), createLayout().
2592 2011-10-07 Ben Konrath <ben@bagu.org>
2594 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2596 This is part of a change to get navigation buttons in the details view
2597 but it should have been done this way from the start.
2599 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2600 for method name change in TableSelectionView.
2601 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2602 Create TableChangeEvent and set the browser title using the
2603 TableSelectionView API.
2604 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2605 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2606 Change getSelectedTable() to getSelectedTableName(). Add
2607 getSelectedTableTitle().
2609 2011-10-07 Ben Konrath <ben@bagu.org>
2611 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2613 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2615 2011-10-07 Ben Konrath <ben@bagu.org>
2617 Update TableChangeEvent to use newTableName naming convention.
2619 This makes the class more consistent with GWT naming conventions.
2621 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2622 Update for method name change in TableChangeEvent.
2623 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2624 for method name change in TableChangeEvent.
2625 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2626 newTableName variable and getter method. Make toDebugString()
2629 2011-09-30 Ben Konrath <ben@bagu.org>
2631 Disable the pager in the list tables when the data row count is less than the minimum.
2633 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2634 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2636 2011-09-30 Ben Konrath <ben@bagu.org>
2638 Add empty rows to the end of related list and list view tables.
2640 I also extracted the cell rendering classes from the ListTable because
2641 the code was becoming a little crazy with all the anonymous inner
2642 classes. My plan is to use these cell rendering classes in the details
2643 view as well so this refactor will be needed for that change.
2645 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2646 set the row count in related list tables if the data has more rows
2647 than the minimum number of rows visible.
2648 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2649 row count in list view tables if the data has more rows than the
2650 minimum number of rows visible.
2651 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2652 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2654 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2655 for rendering TYPE_NUMERIC cells. The code was extracted from the
2657 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2658 class for rendering cells with buttons in list views. The code was
2659 extracted from the ListTable class.
2660 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2661 for rendering TYPE_TEXT cells. The code was extracted from the
2663 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2664 Add empty rows to the end of the data if required. Implement
2665 ListTable.getMinNumVisibleRows().
2666 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2667 cell renderer code to public classes. Return null in
2668 Column.getValue() for empty rows. Add new abstract method:
2669 getMinNumVisibleRows(). Move code to set the row count of the list view
2670 table to ListViewImpl.
2671 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2672 empty rows to the end of the data if required. Implement
2673 ListTable.getMinNumVisibleRows().
2676 2011-09-27 Ben Konrath <ben@bagu.org>
2678 Use GWT.log for client-side debugging statements.
2680 These are optimized out when deployed so I should have used this method
2681 in the first place. These statements will eventually be replaced with some sort
2682 of notification in the browser.
2684 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2685 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2686 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2687 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2688 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2690 2011-09-27 Ben Konrath <ben@bagu.org>
2692 Put tableselector on the right, back to list link on right.
2694 The idea is that the table selector is acting like a label for the
2695 currently displayed table so it should be placed below the document title. This
2696 puts the table title in a similar position to where it is in Glom.
2698 * mockups/details-contacts.html:
2699 * mockups/details-projects.html:
2700 * mockups/listview-contacts.html:
2701 * mockups/listview-projects.html:
2702 * mockups/style.css:
2703 Update mockups to match how the interfaces currently look.
2704 * src/main/webapp/style.css: Swap positions of backlink with the table
2705 selector. Add some space on the left side of the table selector to
2706 line things up with the document title.
2708 2011-09-27 Ben Konrath <ben@bagu.org>
2710 Add field colouring to details view.
2712 This change re-works how field colouring works. The colour formatting
2713 information is now set to the client with the layout information instead of
2714 with the data. This eliminates the need to send the same colour strings for
2715 data in list view column when colour information is set.
2717 In order to set an alternate colour for negative numeric values, the
2718 number is now sent to client and formatted with the GWT NumberFormat class.
2720 This change also fixes:
2722 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2724 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2725 internationalization framework which is needed for client side numeric
2727 * src/main/java/org/glom/web/client/Utils.java: New file for some
2728 client static utility methods.
2729 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2730 the DataItem object to the Field class. Use a utility method to
2731 create the foreignKeyValue string.
2732 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2733 alignment and text colours in the constructor. Add setData(DataItem)
2734 method. Remove setText(String) method.
2735 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2736 colour information to GlomTextCell. Create and use GlomNumberCell for
2737 rendering numbers. Use utility method to get the string for the
2738 primary key of the key provider. Re-work how the horizontal alignment
2740 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2741 formatting to layout information. Methods for converting the libglom
2742 formatting information were moved from DBAccess.
2743 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2744 numeric formatting (it's now done on the client side). Don't set text
2745 colours in DataItem. Move libglom formatting conversion methods to
2747 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2748 getters/setters for text colour information.
2749 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2750 for transferring the libglom NumericFormat information to the client.
2751 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2752 and getters/setters for: GlomNumericFormat, background colour and
2753 foreground colour strings.
2755 2011-09-26 Ben Konrath <ben@bagu.org>
2757 Simplify code that iterates through the LayoutGroup.
2759 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2761 2011-09-26 Ben Konrath <ben@bagu.org>
2763 Accept Eclipse formatting for OnlineGlomServiceAsync.
2765 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2767 2011-09-26 Ben Konrath <ben@bagu.org>
2769 Don't use the ListDBAccess classes to get the primary key layout information.
2771 This was causing a bug where the wrong index for the hidden primary key
2772 was being sent to the client.
2774 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2775 primary key while creating the LayoutGroup DTO. Create a
2776 LayoutItemField DTO for hidden primary keys. Don't use the
2777 RelatedListDBAccess because it was only used for getting the primary
2779 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2780 access modifier from public to protected for getPrimaryKeyField() and
2781 getPrimaryKeyLayoutItemField().
2782 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2783 abstract method getExpectedResultSize() because RelatedListDBAccess
2784 doesn't have enough info to implement it.
2785 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2786 Remove @Override for getExpectedResultSize().
2787 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2788 Remove method getExpectedResultSize().
2790 2011-09-23 Ben Konrath <ben@bagu.org>
2792 Log which layout (list or details) the ignored item is from.
2794 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2796 2011-09-23 Ben Konrath <ben@bagu.org>
2798 Remove annotations that turn off code formatting in DataItem.
2800 * src/main/java/org/glom/web/shared/DataItem.java:
2802 2011-09-23 Ben Konrath <ben@bagu.org>
2804 Rename GlomField to DataItem and update associated methods.
2806 This is a rename-only refactor. No functionality has been added or
2809 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2810 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2811 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2812 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2813 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2814 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2815 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2816 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2817 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2818 * src/main/java/org/glom/web/server/database/DBAccess.java:
2819 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2820 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2821 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2822 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2823 * src/main/java/org/glom/web/shared/DataItem.java:
2824 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2825 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2827 2011-09-23 Ben Konrath <ben@bagu.org>
2829 Rename GlomDocument to DocumentInfo and update associated methods.
2831 This is a rename-only refactor. No functionality has been added or
2834 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2835 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2836 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2837 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2838 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2839 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2840 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2842 2011-09-20 Ben Konrath <ben@bagu.org>
2844 Require java-libglom 1.17.3.
2846 This picks up the fix for the seg fault problem with the Scenes table
2847 in the Openismus Film Manager example.
2851 2011-09-20 Ben Konrath <ben@bagu.org>
2853 Change the way sort clause is added for primary key when no sort clause is requested.
2855 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2856 before the sort clause is created. When a sort clause is not requested, the
2857 sort clause is created by finding the primary key in the LayoutFieldVector
2860 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2862 2011-09-20 Ben Konrath <ben@bagu.org>
2864 Log error message if no documents are found in the configured directory.
2866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2867 Extract the glom file extension string to a private static final class
2868 variable (mostly as syntactic sugar). Accept a minor formatting change.
2869 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2870 the example glom.document.directory configuration property to make it
2871 more clear that it can any directory, not just the home directory.
2873 2011-09-18 Ben Konrath <ben@bagu.org>
2875 Add related lists to details view.
2877 The related list table has support for paging and sorting just like the
2878 table in the list view.
2880 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2881 SQL queries for the related list tables.
2882 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2883 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2885 Rename getList methods to getListView and add comments. Remove
2886 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2887 it being unused. Add methods: getDetailsLayoutAndData(),
2888 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2889 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2890 Create the layout and set the data for the fields in one async call
2891 instead of two. Create related lists where appropriate.
2892 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2893 for method name changes in OnlineGlomService.
2894 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2895 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2896 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2898 * src/main/java/org/glom/web/client/ui/ListView.java:
2899 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2900 tableName from setCellTable(). Create a ListViewTable instead of
2902 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2903 represent a data field in the details view.
2904 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2905 from addDetailsCell() to Field class. Keep track of the Fields and
2906 Portals in the details view.
2907 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2908 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2909 and add a method to get it. Add method to set the contents of the
2911 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2912 New class for related list tables. This class has the data provider
2913 for the related list table.
2914 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2915 abstract class which is the base class for the ListViewTable and the
2917 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2918 New class for list view tables. This class has the data provider for
2919 the list view table.
2920 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2921 methods for related list tables. Add more information to the
2922 LayoutItemField and LayoutItemPortal DTOs.
2923 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2924 Remove debugging print statement.
2925 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2926 Remove debugging print statements. Add primary key field to SQL count
2928 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2929 Remove unnecessary LayoutFieldVector parameter from
2930 getResultSizeOfSQLQuery() method.
2931 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2932 New class for related list table database access.
2933 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2934 class that is a wrapper DTO for details view layout and data.
2935 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2936 new 'fromField' string to this DTO.
2937 * src/main/webapp/style.css: Remove bottom margin and override top
2940 2011-09-15 Ben Konrath <ben@bagu.org>
2942 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2944 This sets things up to make it easier to add the data retrieval for
2945 related lists (portals). No user noticeable changes were made with
2948 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2949 class has the code to retrieve the layouts and access the
2950 database using the new database helper classes.
2951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2952 Most of the functionality has been removed from this class. This
2953 class now represents the public interface for the client side
2954 code. It also deals with configuring the servlet and cleaning
2955 things up when the servlet is stopped.
2956 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2957 of static methods into this utility class.
2958 * src/main/java/org/glom/web/server/database/DBAccess.java:
2959 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2960 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2961 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2962 These classes have the database retrieval code. The class hierarchy
2963 has been setup to make it easy to reuse code for similar
2966 2011-09-06 Ben Konrath <ben@bagu.org>
2968 Create separate classes for list table code and the data provider.
2970 As part of this refactor, I also split up the code a bit to make it
2973 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2974 table code to two new classes (below).
2975 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2976 with code from ListViewImpl.
2977 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2978 New file with code from ListViewImpl.
2980 2011-09-06 Ben Konrath <ben@bagu.org>
2982 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2984 This fixes the LayoutItemPortal DTO to match the libglom layout object
2987 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2989 2011-09-01 Ben Konrath <ben@bagu.org>
2991 Set title of Portals in the Details View.
2993 * pom.xml: Bump required version of java-libglom to 1.17.1.
2994 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2995 widget creation to its own class. Add comments to constructor.
2996 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2997 The code is mostly from the Group class with the title now set.
2998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2999 title of Portal. Update some comments. Fix some code formatting.
3001 2011-09-01 Ben Konrath <ben@bagu.org>
3003 Remove TODO comment for the flow table column width.
3005 The flow table column width is working correctly and doesn't need to be
3006 changed. See this mailing list post for more info:
3008 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3010 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3012 2011-08-27 Ben Konrath <ben@bagu.org>
3014 Add document title (database name) to top of the browser page.
3016 I added the document title to the TableSelecitonView but that will
3017 change if / when we add a view that doesn't require table selection.
3019 * mockups/details-contacts.html:
3020 * mockups/details-projects.html:
3021 * mockups/listview-contacts.html:
3022 * mockups/listview-projects.html:
3023 * mockups/style.css: Add document title to mockups to keep things
3025 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3026 sizes to account for the document title.
3027 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3028 Set the document title when it has been retrieved from the server.
3029 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3030 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3031 and implement setDocumentTitle(String) method.
3032 * src/main/webapp/style.css: Add ID for document title style.
3034 2011-08-25 Ben Konrath <ben@bagu.org>
3036 Add NavigationType enum to LayoutItemPortal DTO.
3038 This is the start of adding support for Portals to the Details View.
3040 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3041 LayoutItem_Portal.navigation_type enum from libglom to
3042 LayoutItemPortal.NavigationType enum.
3043 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3044 NavigationType enum, field for storing the NavigationType and getter
3047 2011-08-25 Ben Konrath <ben@bagu.org>
3049 Implement the flow table layout in the Details View.
3051 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3052 FlowTable to Group to account for the renamed class.
3053 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3054 File. This is a container widget that implements the Glom details view
3055 flow table behaviour.
3056 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3057 org/glom/web/client/ui/FlowTable.java.
3058 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3059 so that the size of the subgroups are a closer match to the size of
3060 the Glom subgroups. This makes the flowtable layout match the layout
3061 in Glom for the Music Collection example file.
3063 2011-08-16 Ben Konrath <ben@bagu.org>
3065 Create container element for LayoutItemPortal in Details View.
3067 This will help me develop the layout for the FlowTable.
3069 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3070 fieldPanel variable to detailsCell.
3072 2011-08-15 Ben Konrath <ben@bagu.org>
3074 Set the height of the data element in the Details View.
3076 I changed the InlineLabels (text in a span element) to Labels (text in
3077 a div element) so that I could set the height of the details-data
3078 elements instead of the details-cell parent elements. This allows the
3079 the details-data element to display the correct height if style is
3080 applied that shows the height.
3082 This change has the added benefit of allowing the order of the labels
3083 and data elements to be changed for right-to-left languages.
3085 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3086 InlineLabels to Labels.
3087 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3088 InlineLabels to Labels. Set the height of the data element.
3089 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3090 multiline text height in the Formatting DTO.
3091 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3092 for multiline height along with getter and setter methods.
3093 * src/main/webapp/style.css: Adjust style to account for the change
3094 from span elements to div elements in the details cell.
3096 2011-08-15 Ben Konrath <ben@bagu.org>
3098 Make the List View appearance match the mockups.
3100 It doesn't match exactly but it's much better than it was.
3102 * mockups/listview-contacts.html: Remove unused css classes.
3103 * mockups/listview-projects.html: Remove unused css classes.
3104 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3105 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3106 for mainPanel instead of VerticalPanel (table). Set style name on
3107 CellTable. Set style name on Details column. Right-align Details
3109 * src/main/webapp/style.css: Adjust properties to match the mockups.
3111 2011-08-12 Ben Konrath <ben@bagu.org>
3113 Add better support for subgroups in the details view.
3115 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3116 changed FlowTable constructor.
3117 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3118 support for subgroups and subgroup-titles.
3119 * src/main/webapp/style.css: Add CSS class for subgroups and
3122 2011-08-12 Ben Konrath <ben@bagu.org>
3124 Return the top level LayoutGroup title.
3126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3128 2011-08-11 Ben Konrath <ben@bagu.org>
3130 Make the TableSelector header match the mockup.
3132 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3133 the layout panel. Properly lineup the table selection header with
3134 the list and details view.
3135 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3136 margin around the details view.
3137 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3138 Rename listBox variable to tableSelector. Set id for the style sheet.
3139 Use a FlowPanel instead of a HorizontalPanel.
3140 * src/main/webapp/style.css: Add properties to make the TableSelector
3141 box match the mockups.
3143 2011-07-13 Ben Konrath <ben@bagu.org>
3145 Update install script for java-libglom version change.
3147 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3150 2011-07-13 Ben Konrath <ben@bagu.org>
3152 Add support sub-group in the details view.
3154 I also removed the code that special-cased the default details view
3157 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3159 I still have to make a proper flowtable.
3161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3162 Don't special-case default details view layout.
3163 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3164 addLayoutField() as I'm going to use it.
3165 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3166 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3168 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3169 extracted from DetailsViewImpl.GroupPanel. Add support for
3171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3172 column count when getting the details layout.
3174 2011-07-12 Ben Konrath <ben@bagu.org>
3176 Set browser title with database and table titles.
3178 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3179 Set the browser title when the table changes and when the activity
3181 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3182 title when retrieving document info (the GlomDocument object).
3183 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3184 with getter and setter methods. Remove unused convenience constructor.
3185 Use default code formatting.
3187 2011-07-12 Ben Konrath <ben@bagu.org>
3189 Ignore LayoutItemPortals in the details view.
3191 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3194 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3195 LayoutItemPortal layout objects.
3196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3197 LayoutItemPortal objects when retrieving the details layout.
3198 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3199 file. This is an empty class and just used to get type information for
3202 2011-07-12 Ben Konrath <ben@bagu.org>
3204 Use java-libglom 1.17.0.
3208 2011-07-11 Ben Konrath <ben@bagu.org>
3210 Remove "Table:" label from table selector.
3212 This matches a recent change in the Glom UI.
3214 * mockups/details-contacts.html:
3215 * mockups/details-projects.html:
3216 * mockups/listview-contacts.html:
3217 * mockups/listview-projects.html: Remove the "Table:" label from the
3219 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3221 2011-07-11 Ben Konrath <ben@bagu.org>
3223 Add main groups to the details view.
3225 This makes things look a little nicer in the details view. The next step
3226 is to implement the flowtable.
3228 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3229 resources from the standard gwt css theme. Standard.css is now
3230 included in OnlineGlom.html so that the online glom css rules have
3231 precedence over the gwt theme.
3232 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3233 the whole LayoutGroup to the DetailsView instead of just the titles.
3234 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3235 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3236 details layout with a helper class (GroupPanel). I might extract this
3237 class when I make the full flowtable.
3238 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3239 string as default so I don't have to worry about NPEs when processing
3241 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3242 note beside OnlineGlom.gwt.xml above).
3243 * src/main/webapp/style.css: Add default font-size to body to override
3244 the font-size set by the standard theme. Don't use h2 tags for
3245 group-title. Create new details-cell class.
3247 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3249 ConfiguredDocument: Set the port number too.
3251 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3252 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3253 Glom document. Presumably this worked sometimes so far because there is a
3254 default port number.
3256 2011-07-08 Murray Cumming <murrayc@murrayc.com>