1 2012-07-22 Murray Cumming <murrayc@murrayc.com>
5 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
6 * src/main/java/org/glom/web/client/OnlineGlomService.java:
7 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
8 to gwtGlom, which is more appropriate.
9 This servlet name does not seem to be visible to the client side anyway.
11 2012-07-22 Murray Cumming <murrayc@murrayc.com>
13 Tests: Make the imports of assert*() consistent.
15 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
16 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
17 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
18 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
19 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
20 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
21 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
22 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
23 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
24 * src/test/java/org/glom/web/shared/DataItemTest.java:
26 import static org.junit.Assert.*;
27 which seems fairly common.
31 2012-07-21 Murray Cumming <murrayc@murrayc.com>
33 tests: Move a test that needs a database connection.
35 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
36 Move testGetListViewLayoutGroup() to
37 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
38 because it needs a database connection.
40 2012-07-21 Murray Cumming <murrayc@murrayc.com>
42 tests: Use @BeforeClass on tearDown().
44 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
45 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
46 This avoids leaking a postgres process in SelfHostExampleTest.
48 2012-07-21 Murray Cumming <murrayc@murrayc.com>
50 tests: Test translations more.
52 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
53 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
54 Test titles in the non-default locale.
56 2012-07-21 Murray Cumming <murrayc@murrayc.com>
58 tests: Add SelfHostConfiguredDocumentTest
60 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
61 username and password, for use by ConfiguredDocument.
62 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
63 This tests some of the ConfiguredDocument API that requires a database connection.
65 2012-07-21 Murray Cumming <murrayc@murrayc.com>
67 Document: Load title translations and test them.
69 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
70 of titles. I am surprised that we do not do this yet.
71 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
72 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
73 Test translations more.
75 2012-07-20 Murray Cumming <murrayc@murrayc.com>
79 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
80 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
81 Set the timeout here too.
83 2012-07-20 Murray Cumming <murrayc@murrayc.com>
85 tests: ConfiguredDocumentTest: Make this pass.
87 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
88 Disable tests that need a database connection.
90 2012-07-20 Murray Cumming <murrayc@murrayc.com>
92 Use Java 1.7 instead of Java 1.6.
94 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
95 to do this twice, at least for Eclipse.
96 This seems OK because it is the current version.
98 2012-07-20 Murray Cumming <murrayc@murrayc.com>
102 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
103 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
104 Avoid using a null Connection.
106 2012-07-20 Murray Cumming <murrayc@murrayc.com>
108 tests: Add a ConfiguredDocument test.
110 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
113 2012-07-20 Murray Cumming <murrayc@murrayc.com>
115 LayoutItemFIeld: getName(): Use the Field if it is set.
117 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
118 getName(): If the full field details have been set, return its name, so that
119 callers do not need to set the name separately.
120 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
121 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
122 so we can count the rows.
124 2012-07-20 Murray Cumming <murrayc@murrayc.com>
126 tests: SelfHoster: Test SqlUtils too.
128 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
129 Retrieve some data and check it too, as in the regular Glom
130 test_selfhosting_new_from_example.cc test.
131 * src/test/java/org/glom/web/server/SelfHoster.java:
132 createConnection(): Make this public.
134 2012-07-20 Murray Cumming <murrayc@murrayc.com>
136 tests: SelfHoster: createConnection(): Do not warn about expected failures.
138 Let the caller say if the connection is expected to fail, to avoid
139 irrelevant error output.
141 2012-07-20 Murray Cumming <murrayc@murrayc.com>
143 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
145 * src/test/java/org/glom/web/server/SelfHoster.java:
146 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
147 due to the inevitable need to retry the connection while the database server
150 2012-07-20 Murray Cumming <murrayc@murray.com>
152 tests: SelfHoster: createConnection(): Set a timeout.
154 * src/test/java/org/glom/web/server/SelfHoster.java:
155 createConnection(): Use setLoginTimeout() because it otherwise seems to take
156 ages to actually return when it fails.
158 2012-07-20 Murray Cumming <murrayc@murrayc.com>
160 tests: SelfHoster: selfHost(): Close the test connection.
162 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
163 When we check that the connection works, close the connection. This seems
164 to not be closed automatically otherwise.
166 2012-07-20 Murray Cumming <murrayc@murrayc.com>
168 Use slf4j-simple to see JDBC errors.
170 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
172 2012-07-19 Murray Cumming <murrayc@murrayc.com>
174 SelfHoster.discoverFirstFreePort(): Close the socket.
176 * src/test/java/org/glom/web/server/SelfHoster.java:
177 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
179 2012-07-19 Murray Cumming <murrayc@murrayc.com>
181 Avoid another code warning in Eclipse Juno.
183 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
184 Do instanceof checks on the FileUtils.listFiles() result and its
187 2012-07-13 Murray Cumming <murrayc@murrayc.com>
189 Avoid some code warnings in Eclipse Juno
191 * src/main/java/org/glom/web/server/libglom/Document.java:
192 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
193 * src/test/java/org/glom/web/server/SelfHoster.java
194 createTextFile(): Make sure that the FileOutputStream is closed.
196 2012-06-22 Murray Cumming <murrayc@murrayc.com>
198 Added OnlineGlomPropertiesTest.
200 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
201 Make sure we never return a null string.
202 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
203 Added tests of the OnlineGlomProperties API, using our sample file.
205 2012-06-20 Murray Cumming <murrayc@murrayc.com>
207 Make OnlineGlomProperties be a normal class.
209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
210 Move OnlineGlomProperties into its own file to be a regular class:
211 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
212 This makes testing simpler.
214 2012-06-15 Murray Cumming <murrayc@murrayc.com>
216 OnlineGlomServiceImpl.init(): Move some code into a new method.
218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
219 Create addDocument().
221 2012-06-15 Murray Cumming <murrayc@murrayc.com>
223 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
226 OnlineGlomProperties.getKey(): Make this more robust by moving the
227 check for *.*.filename to here.
229 2012-06-15 Murray Cumming <murrayc@murrayc.com>
231 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
234 init(): Move knowledge of the config file format into the
235 OnlineGlomProperties inner class.
237 2012-06-15 Murray Cumming <murrayc@murrayc.com>
239 SelfHostExampleTest: Make sure we cleanup on failure.
241 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
242 the use of cleanup() to a tearDown() JUnit method.
246 2012-06-12 Murray Cumming <murrayc@murrayc.com>
248 ConfiguredDocument: Add a primary key to portals at least once.
250 * src/main/java/org/glom/web/server/ConfiguredDocument.java
251 updatePortalsExtras): Fix a typo so that we add the primary key
252 column at least once.
253 This is a fix for the previous commit:
254 ConfiguredDocument: Do not add a primary key to portals each time.
256 2012-06-08 Murray Cumming <murrayc@murrayc.com>
258 SelfHoster: Avoid some compiler warnings.
260 * src/test/java/org/glom/web/server/SelfHoster.java
261 executeCommandLineAndWait():
262 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
263 the now-unused streams for stdout and stderr from the command Processes.
264 These are not used because readln() hangs while waiting for a new line,
265 where there may be no next line. The commented out code is still there
266 to help us figure out how to do this properly.
268 2012-06-08 Murray Cumming <murrayc@murrayc.com>
270 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
272 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
273 Make this actually test the cloning again, though it is not very useful
274 now that we do not use the part that had a problem with cloning before.
276 2012-06-08 Murray Cumming <murrayc@murrayc.com>
278 SelfHoster: Keep trying pg_ctl after starting postgres.
280 * src/test/java/org/glom/web/server/SelfHoster.java
281 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
282 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
283 regular Glom. This seems mad but it seems to work because the first
284 command would fail if pg_ctl would eventually fail.
286 2012-06-08 Murray Cumming <murrayc@murrayc.com>
288 SelfHoster: Wait until the server is really ready.
290 * src/test/java/org/glom/web/server/SelfHoster.java
291 selfHost(): Attempt the connection after starting the server, retrying
292 a few times if necessary, so that the server is really ready already when
293 we return from this method.
294 The regular Glom code does this too because pg_ctl reports success too soon.
296 2012-06-08 Murray Cumming <murrayc@murrayc.com>
298 ConfiguredDocument: Do not add a primary key to portals each time.
300 * src/main/java/org/glom/web/server/ConfiguredDocument.java
301 updatePortalsExtras(): Only add an extra primary key field if there is
302 none, to avoid adding one each time we retrieve the details layout from the
304 This should fix bug #676986 (Ben Konrath)
306 2012-05-25 Murray Cumming <murrayc@murrayc.com>
308 Document.load(): Support version 7 documents.
310 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
311 database_title attribute if the title attribute is not there.
314 2012-05-24 Ben Konrath <ben@bagu.org>
316 Add configuration for auto-generating mvn:i18n from with Eclipse.
318 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
320 2012-05-24 Murray Cumming <murrayc@murrayc.com>
322 Update translations, adding French.
324 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
325 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
326 Add a French translation, using the translation from Glom.
328 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
329 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
330 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
331 Update these based on the translations from Glom.
333 2012-05-24 Murray Cumming <murrayc@murrayc.com>
335 SelfHoster: Add some debug println messages to help when things fail.
337 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
338 System.out.println() lines.
340 2012-05-23 Murray Cumming <murrayc@murrayc.com>
342 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
344 * src/test/java/org/glom/web/server/SelfHoster.java:
345 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
346 instance) instead of just /usr/bin (as on Fedora). Check the result when
349 2012-05-23 Murray Cumming <murrayc@murrayc.com>
351 Remove LayoutItemPortal.get/setNavigationTable().
353 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
354 Remove get/setNavigationTable(), which is only a cache, because it is not
355 used, and does not need to be used, because that decision should be made on
357 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
358 updatePortalsExtras():
359 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
360 getNavigationRecord():
361 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
364 2012-05-21 Murray Cumming <murrayc@murrayc.com>
366 Initial self-hosting for tests.
368 * pom.xml: Change the scope for log4j, to hopefully make it
369 available to the test code which uses it indirectly via jOOQ.
370 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
371 self-hosting, though we only use it for testing.
373 * src/main/java/org/glom/web/server/libglom/Document.java:
374 example rows: Use a map instead of a list for each row of values,
375 so we know what field they are for, instead of relying on the sequence
376 being correct. This is not very efficient, but it does not really need
378 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
379 testReadTableExampleRows(): Adapted.
381 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
382 that returns an Object, for generic use. Note that Object seems to be
383 the implicit base even of double.
384 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
385 for use in CREATE TABLE SQL queries.
386 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
387 to do self-hosting of PostgreSQL databases via its command-line
388 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
389 backends/postgres_self.cc. This is incomplete - it needs more
390 warnings about failures and it needs to clean up properly when things
392 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
393 test of this new class.
395 2012-05-21 Murray Cumming <murrayc@murrayc.com>
397 Document: loading example data: Handle exceptions.
399 * src/main/java/org/glom/web/server/libglom/Document.java:
400 DateFormat.parse() and Double.valueOf() can throw exceptions, though
401 Eclipse did not warn about that.
403 2012-05-20 Murray Cumming <murrayc@murrayc.com>
405 Document: load(), save(): Handle the example rows.
407 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
409 * src/main/java/org/glom/web/server/libglom/Document.java:
410 load(), save(): Load and save the example rows, though the date, time
411 and image types are not handled properly yet.
412 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
413 Add testReadTableExampleRows() just to check that something is read.
415 2012-05-20 Murray Cumming <murrayc@murrayc.com>
417 Document: Add save().
419 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
420 Added getTranslationsMap() for use while saving.
421 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
422 Adedd getUseDefaultFormatting() for use while saving.
423 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
424 and several private methods that it uses.
426 This will be useful while testing via self-hosting.
427 It is not complete, but should be complete enough for testing.
429 2012-05-17 Murray Cumming <murrayc@murrayc.com>
431 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
433 * src/main/java/org/glom/web/client/OnlineGlomService.java
434 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
435 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
436 Remove getSortedListViewData() and getSortedRelatedListData(), adding
437 the sort column index and ascending bool to the regular method.
438 Instead, a sort column index of -1 now means no sort.
439 This is less explicit, but it's fairly simple, reduces the amount of
440 code, and makes the OnlineGlomService API slightly smaller.
441 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
442 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
444 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
445 getListViewData(), getRelatedListData():
446 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
447 getListViewData(), getRelatedListData():
448 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
450 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
452 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
457 2012-05-16 Murray Cumming <murrayc@murrayc.com>
459 Use translations for top-level groups too.
461 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
462 updateTitlesForLocale(): Use the translation for the group
463 as well as for child items.
467 Just recompiled to fix a problem in the released .tar.gz file.
471 2012-05-15 Murray Cumming <murrayc@murrayc.com>
473 Corrections to navigation to related records.
475 * src/main/java/org/glom/web/client/OnlineGlomService.java:
476 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
477 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
478 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
479 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
480 relationship name, because the relationship name is not necessarily unique
482 TOOD: This is inefficient, because it passes the whole list of
483 child field items back to the server, but it is more correct, and happens
484 to fix a bug with the primary key being lost after a few navigations.
485 There is probably a chance to make this more efficient anyway in some
488 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
489 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
490 * src/main/java/org/glom/web/server/ConfiguredDocument.java
491 * src/main/java/org/glom/web/server/database/DBAccess.java
492 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
493 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
496 2012-05-15 Murray Cumming <murrayc@murrayc.com>
498 Fix the use of translations.
500 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
501 Add updateTitlesForLocale().
502 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
503 Call it to discard unwanted translations and to make getTitle() return
504 the wanted translation wihout the need for the client code to specify a locale.
505 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
506 getTitle(): Fallback to the original title, as libglom does.
508 2012-05-15 Murray Cumming <murrayc@murrayc.com>
510 Document: Correctly report the number of available translation locales.
512 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
513 the available locale IDs list.
514 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
515 testLocales: Test this.
517 2012-05-15 Murray Cumming <murrayc@murrayc.com>
519 SqlUtils: Use camelCase.
521 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
522 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
523 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
524 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
525 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
526 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
528 2012-05-15 Murray Cumming <murrayc@murrayc.com>
530 Use jOOQ's tableByName() and fieldByName.
532 * pom.xml: Use jOOQ 2.3.1 to get the new API.
533 * src/main/java/org/glom/web/server/SqlUtils.java:
534 build_sql_select_step_with_where_clause(), .createField(),
535 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
536 so we can get correct quoting and escaping. Thanks to Lukas Eder for
537 adding this, and other things, to jOOQ.
539 2012-05-15 Murray Cumming <murrayc@murrayc.com>
541 SqlUtils: Remove the Connection parameters.
543 * src/main/java/org/glom/web/server/SqlUtils.java:
544 build_sql_select_with_key(), build_sql_select_with_where_clause(),
545 createSelect(), build_sql_select_step_with_where_clause(),
546 build_sql_count_select_with_where_clause(),
547 build_sql_select_count_rows(): Remove the Connection parameter because
548 jOOQ does not actually need a connectionwhen it is just used to build
550 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
552 * src/main/java/org/glom/web/server/ReportGenerator.java:
554 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
556 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
557 Constructor, getListData(), getResultSizeOfSQLQuery():
558 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
559 getSelectQuery(), getCountQuery():
560 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
561 getSelectQuery(), getCountQuery():
562 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
563 getNavigationRecord(): Adapted.
565 2012-05-14 Murray Cumming <murrayc@murrayc.com>
569 * src/main/java/org/glom/web/server/SqlUtils.java:
570 get_find_where_clause_quick(): Use a comparison of
571 lowercase values, instead of a simple equals. Regular Glom
572 uses the PostgreSQL ILIKE operator but jOOQ does not
573 support that just yet, though it will soon.
575 2012-05-14 Murray Cumming <murrayc@murrayc.com>
577 TableToViewDetails: Use a real serialization ID.
579 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
580 Though this does not fix the serialization problem.
582 2012-05-12 Murray Cumming <murrayc@murrayc.com>
584 Added LayoutItemPortalDeepCloneTest.
586 2012-05-11 Murray Cumming <murrayc@murrayc.com>
588 Make navigation work again.
590 * src/main/java/org/glom/web/server/libglom/Document.java:
591 Add getLayoutItemFieldShouldHaveNavigation().
592 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
593 Replace get/setAddNavigation() with the partly-existing
594 get/setNavigationTableName(), with an empty string being no navigation,
595 because this is simpler. Use the new
596 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
598 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
599 Add updateFieldsExtras() and call setNavigationTableName in it.
600 getDetailsLayoutGroup(),
601 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
602 createLayout(): Adapted.
603 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
604 Constructor: Adapted.
606 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
607 Replace get/setAddNavigation() with get/setNavigation(), returning a
608 TableToViewDetails class with both the table name and UsesRelationship,
609 because both are need. The previous code used java-libglom's output
610 variable (strangely, via sharedptr) to return both, but we cannot really
612 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
613 getNavigationRecord(): Adapt. However, we cannot actually use the cache
614 here because it somehow gets set to null during deepCopy(). I must test this.
615 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
616 testGetSuitableTableToViewDetails(): Adapted.
618 TODO: Find out why deepClone() is not quite working.
620 2012-05-11 Murray Cumming <murrayc@murrayc.com>
622 DBAccess: Simplify the retrievel of full field details.
624 * src/main/java/org/glom/web/server/database/DBAccess.java
625 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
626 because the Document loading should have done this.
628 2012-05-11 Murray Cumming <murrayc@murrayc.com>
630 Document: Correct loading of doubly-related layout fields.
632 * src/main/java/org/glom/web/server/libglom/Document.java:
633 loadUsesRelationship(): Actually set the related relationship, instead
634 of only setting it if it's not found.
636 2012-05-09 Murray Cumming <murrayc@murrayc.com>
638 Replace all appearances of Colour with color.
640 Because US English is dominant.
642 2012-05-09 Murray Cumming <murrayc@murrayc.com>
644 Use colors in HTML format, solving a warning about an unused function.
646 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
647 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
648 Add *asHTMLColor() versions of methods.
649 TODO: However, we should create and cache the results on the server.
650 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
651 * src/main/java/org/glom/web/client/ui/list/ListTable.java
652 * src/main/java/org/glom/web/server/ConfiguredDocument.java
653 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
654 Use the asHTMLcolor() versions.
656 2012-05-09 Murray Cumming <murrayc@murrayc.com>
658 ListViewTable: Constructor: Take the table name as a parameter.
660 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
661 Constructor: Take the tableName, and set the member variable, because
663 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
664 setCellTable(): Pass the table name.
665 This makes navigation to non-default tables work again. I don't know
666 why it worked before in the master branch.
668 2012-05-07 Murray Cumming <murrayc@murrayc.com>
670 ConfiguredDocument: Restore correct addition of hidden primary key items.
672 * src/main/java/org/glom/web/client/ui/list/ListTable.java
673 (ListTable.createCellTable): Uncomment out the check for the hidden
675 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
676 add primary key items for top-level lists and portals, as before,
677 instead of adding them to each group.
678 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
679 Actually implement the extra methods such as setHiddenPrimaryKey() and
680 comment that these are used only for top-level list groups and in portals.
681 This strangeness suggests even more that this should not be squeezed
682 into the LayoutGroup class.
684 2012-05-07 Murray Cumming <murrayc@murrayc.com>
686 Fix Formatting loading.
688 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
689 getFormattingUsed(): Remove the duplicate Formatting member variable
690 in favour of the one from the base class.
691 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
692 Initialize a new Formatting instead of using null by default, so we
693 have some defaults, instead of having to initialize one later just to
694 get the same defaults. This also makes loading of formatting from the
695 document work, because that expected a non-null.
697 2012-05-07 Murray Cumming <murrayc@murrayc.com>
699 RelatedListTable: Make sure that the tableName is set.
701 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
702 Constructor: Take the tableName so it is available later. Otherwise,
703 the server assumes that we mean the default table and cannot find the
705 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
706 setData(): Pass the tableName to the RelatedListTable constructor.
708 2012-05-07 Murray Cumming <murrayc@murrayc.com>
712 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
713 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
714 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
716 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
718 * src/main/java/org/glom/web/server/database/DBAccess.java:
719 convertResultSetToDTO(), getPortal():
720 * src/main/java/org/glom/web/server/database/ListDBAccess.java
722 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
723 Add checks for null objects and out of range access, with log messages to
724 give hints so we can fix these properly.
726 2012-05-07 Murray Cumming <murrayc@murrayc.com>
728 Portals: some corrections.
730 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
732 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
733 constructor: Use getRelationshipNameUsed() instead of getName(), because
734 that is what is meant.
735 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
736 getFromField(): Fix a typo, to get the field name, not the table name.
737 * src/main/java/org/glom/web/server/database/DBAccess.java:
738 getPortal(): Fix a typo that stopped this from working.
740 2012-05-07 Murray Cumming <murrayc@murrayc.com>
742 LayoutItemPortal: Also override getTitleOriginal().
744 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
745 This lets the base getTitle() with no parameters work.
746 TODO: Test this properly.
748 2012-05-06 Murray Cumming <murrayc@murrayc.com>
750 LayoutItemPortal: getTitle*(): Use the relationship title.
752 2012-05-06 Murray Cumming <murrayc@murrayc.com>
754 LayoutItemField: Fix loading of custom titles.
756 * src/main/java/org/glom/web/server/libglom/Document.java
757 loadDataLayoutItemField(): The title, if any, instead of the field
758 title, is stored in a title_custom node. Load it from there.
759 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
761 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
762 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
763 getTitle*() overrides.
764 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
767 2012-05-06 Murray Cumming <murrayc@murrayc.com>
769 LayoutItemField: Fall back to field titles, so some are really shown.
771 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
772 Override getTitleOriginal() and getTitle(), as in java-libglom.
773 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
776 2012-05-06 Murray Cumming <murrayc@murrayc.com>
778 Correct use of setExpectedResultSize().
780 * src/main/java/org/glom/web/server/ConfiguredDocument.java
781 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
782 Use setExpectedResultSize only on top-level groups (for instance, the
783 list layout) or on child portals (in details views).
784 Use the correct table name for portals to avoid SQL errors.
785 Update the expected counts when returning cached layouts.
787 2012-05-06 Murray Cumming <murrayc@murrayc.com>
789 Document: Interpret no group column count as 1.
791 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
792 default, though we now check for this in the UI code anyway.
794 2012-05-06 Murray Cumming <murrayc@murrayc.com>
798 2012-05-06 Murray Cumming <murrayc@murrayc.com>
800 Translatable: Use Hashmap instead of Treemap because GWT supports it.
802 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
803 The use of Treemap lead to this error from async methods, with no
805 "The response could not be deserialized"
807 2012-05-06 Murray Cumming <murrayc@murrayc.com>
809 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
811 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
812 when using the Google -> GWT Compile, or
813 g toolbar button -> GWT Compile Project... feature in Eclipse.
815 2012-05-06 Murray Cumming <murrayc@murrayc.com>
817 ListTable.addColumn(): Protect against a null Formatting.
819 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
820 Create a default Formatting if it is null, because that is the simplest
823 2012-05-06 Murray Cumming <murrayc@murrayc.com>
825 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
827 * src/main/java/org/glom/web/server/ConfiguredDocument.java
828 updateLayoutGroup(): Check that the field is not null.
830 2012-05-06 Murray Cumming <murrayc@murrayc.com>
832 ListViewImpl: Protected against a bad cast error.
834 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
835 onEnterKeyDown(): Do not cast without an instanceof check.
837 2012-05-06 Murray Cumming <murrayc@murrayc.com>
839 ListTable: Protect against an out of range error.
841 * src/main/java/org/glom/web/client/ui/list/ListTable.java
842 createCellTable(): This is unlikely, but can happen while debugging.
844 2012-05-06 Murray Cumming <murrayc@murrayc.com>
846 AsyncMessage onFailure() callbacks: Log the exception message.
848 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
849 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
850 * src/main/java/org/glom/web/client/activity/ListActivity.java:
851 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
852 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
853 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
854 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
855 These are useful clues when something is wrong.
857 2012-05-06 Murray Cumming <murrayc@murrayc.com>
859 ConfiguredDocument: Avoid a null dereference.
861 * src/main/java/org/glom/web/server/ConfiguredDocument.java
862 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
863 details maps are created.
865 2012-05-06 Murray Cumming <murrayc@murrayc.com>
867 Document: Correct the port number parsing.
869 * src/main/java/org/glom/web/server/libglom/Document.java:
870 This lets us actually connect to the database and show the document.
872 2012-05-05 Murray Cumming <murrayc@murrayc.com>
876 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
877 user-interaction, asking us to load a temporary URL in a browser.s
878 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
879 which is apparently necessary for testing the service. See the comment.
880 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
881 Show the exception, if any. This is how I saw the 404 in the HTML in
884 2012-05-05 Murray Cumming <murrayc@murrayc.com>
886 DocumentTest: Move the .glom files into the resources directory.
888 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
889 URI via getResource().
891 2012-05-05 Murray Cumming <murrayc@murrayc.com>
893 Document: Remove the FieldIdentifies inner class.
895 * src/main/java/org/glom/web/server/libglom/Document.java: We only
896 use the Relationship (though the same function in libglom is maybe
897 used in other ways) and so this removes a compiler warning.
899 2012-05-05 Murray Cumming <murrayc@murrayc.com>
901 Document.load() Remove the error code parameter.
903 * src/main/java/org/glom/web/server/libglom/Document.java: load():
904 Remove the parameter. We do not set it yet and it could never have
905 worked as an output parameter (though maybe it did in java-libglom).
906 We could use an exception if we really want the failure reason.
907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
909 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
910 setUp(), testGetSuitableTableToViewDetails(): Adapt.
912 2012-05-05 Murray Cumming <murrayc@murrayc.com>
914 Make some inner classes static.
916 * src/main/java/org/glom/web/server/ConfiguredDocument.java
917 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
918 * src/main/java/org/glom/web/server/ReportGenerator.java
919 * src/main/java/org/glom/web/server/libglom/Document.java
920 Make all inner classes static that can be static.
922 2012-05-05 Murray Cumming <murrayc@murrayc.com>
924 OnlineGlomServiceImpl: Do not load and check for java-libglom.
926 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
927 init(): We do not use java-libglom any more.
929 2012-05-05 Murray Cumming <murrayc@murrayc.com>
931 Remove mentions of java-libglom.
933 * README: Remove mention of java-libglom, because it no longer needed.
934 * utils/build-onlineglom-war.sh:
935 * utils/check-and-recover-tomcat.py:
936 * utils/install-onlineglom-war.sh: Remove these as they are no longer
937 useful. Building is now far easier, with no need for jhbuild.
939 2012-05-05 Murray Cumming <murrayc@murrayc.com>
941 Fix the build (mvn package)
943 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
944 (LayoutGroup): Make the LayoutItemList inner class static and protected.
945 Otherwise the GWT Java->Javascript compilation fails with just this
946 error, during mvn package or when attempting to view in a browser,
947 in the GWT developer mode in Eclipse.
949 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
950 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
951 [INFO] Compiling module org.glom.web.OnlineGlom
952 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
953 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
954 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
955 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
956 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
957 [INFO] [ERROR] Cannot proceed due to previous errors
959 It has taken me 2 days to find out what was causing that. After reducing
960 the code, the compiler eventually showed me the full error message.
962 2012-05-04 Murray Cumming <murrayc@murrayc.com>
964 ConfiguredDocument: Cache the cloned and stripped layouts.
966 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
967 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
968 layout in a map, so we can retrieve it again without rebuilding it.
970 2012-05-04 Murray Cumming <murrayc@murrayc.com>
972 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
974 2012-05-04 Murray Cumming <murrayc@murrayc.com>
976 libglom classes: Implement some auto-generated emthods.
978 2012-05-04 Murray Cumming <murrayc@murrayc.com>
980 Add GwtTestOnlineGlomService.
982 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
983 However, this (and the other GwtTest*) does not seem to run during
986 2012-05-04 Murray Cumming <murrayc@murrayc.com>
988 Remove use of unsupported features from client code.
990 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
991 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
992 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
993 Use our client version of StringUtils instead of the apache commons one.
995 However, the GWT Javascript compliation still fails.
997 2012-04-25 Murray Cumming <murrayc@murrayc.com>
999 Add a Field class and implement some loading of it in Document.
1001 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1003 Initial Document loading implementation, instead of libglom.
1005 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1006 and Translatable classes, and adapt the rest of the code to use them.
1007 However, this is still missing Layout and Field classes and loading.
1009 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1011 Use of jOOQ: Move Field creation into a utility method.
1013 * src/main/java/org/glom/web/server/SqlUtils.java:
1014 This lets us improve it more easily.
1016 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1018 Use of jOOQ: Improve the code to COUNT a sub-select.
1020 * src/main/java/org/glom/web/server/SqlUtils.java:
1021 Move initial query creation into
1022 build_sql_select_step_with_where_clause().
1023 build_sql_select_count_rows(): Use the jOOQ API instead of
1024 concatentating text, because a jOOQ Select*Step is a TableLike,
1025 which is what from() takes.
1027 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1029 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1031 * pom.xml: Depend on jooq.
1032 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1033 methods with jOOQ, based on the C++ implementations in libglom,
1034 with some changes to the logic required by jooQ.
1035 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1037 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1038 * src/main/java/org/glom/web/server/ReportGenerator.java:
1039 * src/main/java/org/glom/web/server/SqlUtils.java:
1040 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1041 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1042 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1043 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1044 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1045 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1046 because jOOQ needs that, though it seems unnecessary.
1048 This is not quite finished. Ideally jOOQ would help us to build
1049 table_name.field_name names, quoting and escaping them properly.
1050 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1052 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1054 Move use of Glom.build_sql*() into a new SqlUtils class.
1056 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1057 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1058 but this will make it easier to start using something other than
1059 libglom or SqlBuilder.
1061 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1063 Update the project URL.
1065 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1067 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1069 Main layout: Use a FlowTable instead of absolute positioning.
1071 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1072 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1073 child panels/widgets must have an absolute position. But that is annoying, so
1074 this adds a FlowTable and puts the child panels in there.
1076 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1078 GwtTestOnlineGlom: Comment out unused code.
1080 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1081 Eclipse has started to say that some code is unused.
1083 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1085 Update to the latest versions of dependencies.
1087 * pom.xml: Update version numbers of dependencies to the latest
1089 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1091 * src/main/java/org/glom/web/server/ReportGenerator.java:
1092 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1093 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1094 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1096 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1097 Modify the imports where necessary.
1099 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1101 Style: Remove overflow:hidden from searchbox
1103 * src/main/webapp/style.css: Because this pushes the Back To Link
1104 label/link on to the next row, which is then hidden due to the
1105 hard-coded (in ems) height.
1107 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1109 Remove some duplicate code.
1111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1112 getDocumentInfo(): This must have been duplicated during the merge from the
1117 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1119 Reports: Localize the waiting for report message.
1121 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1122 start(): Get the message from the contants.
1123 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1124 Add the string here.
1125 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1126 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1127 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1128 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1129 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1130 Update these files with the English text for newer strings for now.
1132 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1134 Reports: Show a message while waiting for the report.
1136 * src/main/java/org/glom/web/client/ui/ReportView.java
1137 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1138 Add setWaitingText(), to show a message saying that we are
1139 waiting for the report to be ready.
1140 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1141 start(): Call setWaitingText() before calling the async
1144 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1146 ReportGenerator: Specify date and time formats.
1148 * src/main/java/org/glom/web/server/ReportGenerator.java:
1149 createFieldValueElement(): Use the default (and localized)
1150 short formats, though we still need a way to show 4-digit
1151 years without providing the format for every locale.
1152 * src/main/java/org/glom/web/server/database/DBAccess.java:
1153 convertResultSetToDTO(): Use the short formats here too.
1155 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1157 ReportGenerator: Use the correct numeric formatting.
1159 * src/main/java/org/glom/web/server/ReportGenerator.java
1160 createFieldExpression(), createFieldValueElement(): Take the
1161 whole LayoutItem_Field instead of just the field name, so
1162 we have access to the formatting.
1163 createFieldValueElement(): Use JRTextField.setPattern() to
1164 specify the numeric formatting, with the help of a
1165 regular DecimalFormat.
1167 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1169 ReportGenerator: Avoid showing null for group by titles.
1171 * src/main/java/org/glom/web/server/ReportGenerator.java
1172 generateReport(): Use setBlankWhenNull() on the field title
1173 style too, because this is used for values in group by
1176 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1178 ReportGenerator: Add a colon to titles in vertical groups.
1180 * src/main/java/org/glom/web/server/ReportGenerator.java
1181 addFieldToDetailBandVertical(): Pass true for the withColon
1184 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1186 ReportGenerator: Simplify the code by using Position more.
1188 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1190 Reports: Support vertical groups, roughly.
1192 * src/main/java/org/glom/web/server/ReportGenerator.java:
1193 addToReport(): Rename to addGroupToReport() and, if necessary,
1194 call the new addVerticalGroupToReport() method.
1195 createFieldValueElement(): Let the caller specify the Y position
1198 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1200 Reports: Allow a second report to be shown.
1202 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1203 clear(): Do not remove the HTML widget, which broke the whole layout.
1205 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1207 Locales drop-down: Show that we use English by default.
1209 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1210 fillView(): When we use English, just because that is the default, when
1211 no locale is specified, show that in the Locales drop-down instead of
1212 just showing the first item.
1214 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1216 Unselect the Report/Locale/Table combo item when appropriate.
1218 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1219 setPlace(): clear reportName if this is not a ReportPlace.
1220 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1221 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1222 When the provided name is empty, unselect all items, so that none are
1223 indicated. This uses a for loop because I cannot find a single method
1226 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1228 Report: Give the user a way to get back to the list.
1230 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1231 start(), setPlace(): Show the Back To List link on reports, and also
1232 interpret selecting the empty report item as back to list.
1234 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1236 Really show the selected Report name.
1238 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1239 setPlace(): Store the reportName here, if it is that kind of Place.
1240 fillView(): Set the selected Report after filling the list of reports.
1241 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1242 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1243 null Strings, though we need some way to unselect all ListBox items
1246 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1248 ReportGenerator: Try to avoid some problems.
1250 * src/main/java/org/glom/web/server/ReportGenerator.java
1251 addField(): Try to avoid duplicates, and avoid using a null
1254 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1256 Reports: Use quickFind.
1258 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1259 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1260 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1261 getReportHTML(): Add a quickFind parameter.
1262 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1263 start(): Pass the quickFind parameter.
1264 * src/main/java/org/glom/web/server/ReportGenerator.java
1265 generateReport(): Take a quickFind parameter.
1267 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1269 ReportPlace: Actually use the report name.
1271 * src/main/java/org/glom/web/client/place/ReportPlace.java
1272 getPlace(): Do not assign the report name to the quickfind.
1274 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1276 Show java.library.path when complaining.
1278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1279 init(): When telling us to check java.library.path, show the
1282 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1284 ReportGenerator: Do not show nulls.
1286 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1288 ReportGenerator: Make the title font larger.
1290 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1292 ReportGenerator: Put field titles inside groups, if there are groups.
1294 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1296 ReportGenerator: Take the Report itself instead of the name and group.
1298 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1299 Remove getReportLayoutGroup().
1300 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1301 getReportHTML(): Pass the report instead
1302 of its name and layout group.
1303 * src/main/java/org/glom/web/server/ReportGenerator.java
1304 generateReport(): Use the report object to use the title
1305 instead of the name.
1307 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1309 ReportGenerator: Remove designBand parameters.
1311 * src/main/java/org/glom/web/server/ReportGenerator.java:
1312 Make designBand a class member instead of passing it to all
1315 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1317 ReportGenerator: Add lines, a bit like in the desktop version.
1319 * src/main/java/org/glom/web/server/ReportGenerator.java
1320 addToReport(): Use JRDesignLine.
1322 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1324 ReportGenerator: Correct the title positions and use some bold style.
1326 * src/main/java/org/glom/web/server/ReportGenerator.java:
1327 Break the code up into reusable functions, correct the placement of
1328 titles, and use normal/bold styles as in the reports in the desktop
1331 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1333 ReportGenerator: Add a header band to show the field titles.
1335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1336 getReportHTML(): Pass the localeId to the ReportGenerator
1338 * src/main/java/org/glom/web/server/ReportGenerator.java
1339 constructor: Take the localeID so we can get translated field
1341 generateReport(), addToReport(), addFieldToBand(): Add field
1342 titles in a column header band.
1344 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1346 Reports drop-down list: Some improvement.
1348 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1349 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1350 Adedd setSelectedReport(),
1351 setReportList(): Add a blank line so that the user can select the
1353 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1354 start(): Show the current report by calling setSelectedReport().
1355 This does not seem to work yet.
1357 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1359 DetailsActivity, ListActivity: Move some variables into a base class.
1361 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1362 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1363 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1364 the clientFactory, documentID, tableName and authenticationPopup into
1365 a base class, to avoid duplication.
1367 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1369 Translate the Reports label.
1371 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1372 Get the "Reports" label string from the constants.
1373 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1374 perties: Add Reports to the constants.
1376 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1378 Reports: Implement grouping.
1380 * src/main/java/org/glom/web/server/ReportGenerator.java:
1381 Handle LayoutItem_GroupBy items and try to do the right thing
1382 with JRDesignGroup. It seems to work.
1384 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1386 Actually show some data with JasperReports.
1388 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1389 getReportHTML(): Move most code into a ReportGenerator class.
1390 * src/main/java/org/glom/web/server/ReportGenerator.java:
1391 Recurse into sub-groups, adding fields to the JasperDesign's details
1392 band. Note that we must set an arbitrary width and height, or it just
1393 will not show any data.
1395 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1397 Reports Chooser: Show the titles, not the names.
1399 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1400 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1401 and the names as the values.
1402 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1403 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1404 group now that we provide the report name, so it should always
1407 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1409 Depend on jasperreports.
1411 * pom.xml: Add the dependency. My plan is to use this on the
1414 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1416 Implement navigation to report places.
1418 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1419 start(): Do not bother to handle all events here.
1420 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1421 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1422 Added getSelectedReport().
1423 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1424 .java: start(): When handling a change to the reports chooser,
1425 call getSelectedReport() and goTo() its ReportPlace.
1426 * src/main/java/org/glom/web/client/ui/ReportView.java
1427 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1428 Added setReportHTML() which puts the html in a gwt HTML widget.
1429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1430 getReportHTML(): Return "TODO" just to show that this works.
1432 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1434 Make ReportPlace usable.
1436 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1437 Mention ReportPlace.
1438 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1439 Correct the @prefix annotation.
1441 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1443 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1445 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1446 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1448 Change getReportLayout() to getReportHMTL() because we will not need to
1449 parse or render the report layout on the client side.
1450 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1451 getReportLayout(): Return the libglom LayoutGroup type because we will
1452 not need to convert to a shared type, because this will not be used on
1454 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1457 Note that there is still no implementation for this.
1460 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1462 Add a (empty) Report Place, View, and Activity.
1464 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1466 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1467 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1468 this into a superclass:
1469 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1470 and also use it as the base of this new ReportPlace:
1471 * src/main/java/org/glom/web/client/place/ReportPlace.java
1473 * src/main/java/org/glom/web/client/ui/ReportView.java
1474 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1475 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1476 Add these, containing mostly boiler-plate for now.
1478 * src/main/java/org/glom/web/client/OnlineGlomService.java
1479 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1480 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1481 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1482 Add API to get the LayoutGroup for the report.
1484 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1486 Add and fill a Reports drop-down list box.
1488 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1490 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1491 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1492 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1493 Added getReports(document, table, localeID), calling
1494 ConfiguredDocument.getReports().
1495 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1496 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1497 Added setReportsList() and a list widget.
1498 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1499 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1504 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1506 Translations: Add Esperanto.
1508 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1509 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1510 properties: Add this translation because someone took the time to make it.
1512 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1514 Adapt to the java-libglom 1.21.7 API.
1516 * src/main/java/org/glom/web/server/ReportGenerator.java:
1517 addToReport(): get_group_secondary_fields() is now
1518 get_secondary_fields().
1521 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1523 Use the latest java-libglom version.
1525 * pom.xml: Use java-libglom 1.21.7.
1527 2012-03-03 Ben Konrath <ben@bagu.org>
1529 Display date and time in details view.
1531 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1533 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1535 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1537 Require the latest java-libglom.
1539 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1541 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1543 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1545 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1546 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1547 an empty quickfind string. I also corrected libglom to create only
1548 empty where clauses for empty quickfind strings, but this avoids the
1551 2012-02-24 Ben Konrath <ben@bagu.org>
1553 Improve the tabs in the Notebook widget.
1557 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1559 Translations: Try to translate the strings.
1561 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1562 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1563 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1564 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1565 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1566 Take the Open translation from GTK+'s .po files.
1567 Take the Details translation from Glom's po files.
1568 I have added the other strings to Glom so we can get translations that way:
1569 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1571 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1573 TableSelectionViewImpl: Put the search label and entry in a div.
1575 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1576 Put the search widgets in a FlowTable so that the CSS can be used to
1577 style them while keeping them together.
1578 * src/main/webapp/style.css: Mention the new div.
1580 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1582 Translate more strings in more locales.
1584 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1585 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1586 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1587 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1588 Translate the "Details" and "Open" string too.
1590 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1591 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1592 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1593 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1594 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1595 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1596 Add these new locales as placeholders though they currently contain English.
1598 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1600 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1602 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1603 Check the ConfiguredDocument* for null before using it.
1605 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1607 Tell Eclipse about the generated java files.
1609 * .classpath: This lets it find OnlineGlomConstants.java.
1610 It would be nice if Eclipse just used the maven build files.
1612 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1614 Prevent a crash when no locale is specified in the URL.
1616 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1617 Avoid returning a null string, obtained from
1618 Window.Location.getParameter(). This caused a crash when it was
1619 later passed to libglom's API.
1620 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1621 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1622 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1623 guard against future null strings.
1625 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1627 Use the ?locale= query param instead of the &lang= token param.
1629 * src/main/java/org/glom/web/client/place/ListPlace.java
1630 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1631 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1632 Remove the lang token key and value.
1634 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1635 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1636 When the user selects a different locale from the chooser, use
1637 Window.Location.assign() to change the URL, which then causes a reload.
1639 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1640 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1641 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1642 * src/main/java/org/glom/web/client/activity/ListActivity.java
1643 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1644 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1645 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1646 * src/main/java/org/glom/web/client/ui/ListView.java:
1647 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1649 Remove localeID member variables and method/constructor parameters, instead
1650 using Utils.getCurrentLocaleID() when we need a localID to pass to
1653 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1655 Internationalize the UI strings.
1657 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1658 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1659 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1660 because it is unused. Messages are apparently strings that can have
1661 parameters, but we do not need that yet, so Contants will be enough for now.
1662 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1663 to say that we support the en and de locales.
1664 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1665 The original English strings.
1666 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1667 Some German translations of the English strings.
1668 The i18n goal then uses the .properties file to generate an
1669 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1670 returns an implementation that returns the translated strings.
1671 The documentation suggests putting these in src/java/*/client/, but it seems
1672 best to put it in src/resources/*/client/.
1673 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1674 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1675 instead of hard-coding them.
1676 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1677 but that does not seem to stop the build, though it confuses Eclipse.
1679 You can see the translated string by adding ?locale=de to the URL, like so:
1680 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1682 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1684 Improve null/empty String checks.
1686 * pom.xml: Add a dependency on commons-lang, to use
1687 org.apache.commons.lang.StringUtils.
1688 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1689 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1690 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1691 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1692 Use StringUtils.isEmpty().
1694 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1695 StringUtils class with a static isEmpty() function because we
1696 cannot use org.apache.commons.lang.StringUtils in client-side
1697 GWT code because it (apparently) cannot be compiled to javascript.
1698 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1699 * src/main/java/org/glom/web/client/activity/ListActivity.java
1700 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1701 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1702 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1703 * src/main/java/org/glom/web/client/place/ListPlace.java
1704 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1705 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1706 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1707 * src/main/java/org/glom/web/client/ui/details/Group.java
1708 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1709 our StringUtils.isEmpty() function.
1711 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1713 Update to the latest java-libglom API.
1715 * pom.xml: Require java-libglom 1.21.4.
1716 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1717 getDocumentInfo(), getListViewLayoutGroup():
1718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1720 * src/main/java/org/glom/web/server/database/DBAccess.java
1721 getFieldsToShowForSQLQueryAddGroup(),
1722 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1723 with either get_database_title_original() or
1724 get_database_title(localeID).
1726 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1728 ConfiguredDocument: Avoid a null pointer exception.
1730 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1731 Initialize localeID to "" to avoid returning a null String which
1732 causes a crash in java-libglom's swing-generated code.
1734 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1736 Some simple renaming.
1738 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1739 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1740 for localeChooser. This seems more appropriate and is less ambiguous
1741 particularly in the .css file.
1743 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1745 ConfiguredDocument: Rename the localedID private member variable.
1747 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1749 Adapt to the latest java-libglom API from git master.
1751 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1752 libglom now uses only Vector instead of List, which uses add() instead of
1755 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1757 ConfiguredDocument: Rename the localedID private member variable.
1759 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1761 Build a source tarball with mvn assembly:single
1763 * assembly.xml: Add this file.
1764 * pom.xml: Use the maven-assembly-plugin and tell it to use
1765 our assembly.xml file.
1767 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1769 OnlineGlomServiceImpl: Get .glom files recursively.
1771 * pom.xml: Depend on commons-io from org.apache.commons.
1772 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1773 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1774 files recursively, and with the easier filter for the extension.
1775 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1776 simplify that code too.
1778 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1780 README: Mention that you must install java-libglom packages separately.
1782 But then it works, because java-libglom is now in the central maven
1785 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1787 locales drop-down: Show the correct selected locale when the URL changes.
1789 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1790 .java: setPlace(): Move some code into fillView().
1792 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1794 locales drop-down: Do not lose the primary key.
1796 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1797 start(): onLocaleChange(): Pass the current primary key value,
1798 instead of an empty value.
1800 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1802 locales drop-down: Do not lose the drop-down selection.
1804 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1805 .java (TableSelectionActivity.fillView): Set the selected locale
1806 after changing the drop-down items (though we do not really need
1807 to change them just because the locale changes.)
1809 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1811 locales drop-down: Change the tables list when this changes.
1813 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1814 .java: TableSelectionActivity.start(): Move the async table titles
1815 retrieval into a private fillView() method and also call this when
1816 the chosen locale changes.
1817 Note that the document title is not actually translatable yet, but
1818 that is a problem that I should fix soon in libglom.
1820 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1822 Improve the placement of the locales drop-down.
1824 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1825 Put the title and locales drop-down in a div (gwt.FlowTable).
1826 * src/main/webapp/style.css: Add magic css properties to make this work.
1827 Also remove the left margin from the title so that it lines up with the
1830 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1832 locales selector: Show human-readable locale titles.
1834 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1835 getDocumentInfo(): Use java.util.Locale to show a real title of
1836 each locale, in the locale's own language.
1838 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1840 Add a language/locale selector drop-down.
1842 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1843 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1844 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1845 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1846 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1847 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1848 Add a ListBox to show the available locales. Add getLocaleSelector(),
1849 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1850 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1851 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1852 java: Add these classes.
1853 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1854 start(): Fill the locales ListBox. Handle its change event, firing a
1856 setPlace(): Show the selected locale as specified by the URL token.
1857 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1858 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1859 Handle LocaleChangeEvent, going to a new *Place with that locale.
1861 The placement of the ListBox is not pretty, and it currently uses the ID
1862 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1866 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1868 Search box: Show the search text from the URL token.
1870 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1871 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1872 Add setQuickFindText().
1873 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1874 .java: setPlace(): Store the queryText if the place is a ListPlace,
1875 and call TableSelectionView.setQuickFindText().
1877 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1879 Allow use of translations via, for instance, &lang=de in the URL.
1881 * pom.xml: Use the unstable java-libglom 1.21 version.
1883 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1884 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1885 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1886 init(): Instead of calling TranslatableItem.set_current_locale()
1887 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1888 However, this is only for default locales, which are not needed to
1889 change the locale in the URL.
1890 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1891 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1892 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1893 layout for a particular locale.
1894 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1895 Add get/setDefaultLocaleID().
1896 getDocumentInfo(), getListViewData(), getRelatedListData(),
1897 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1898 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1899 localeID parameter, so we can get the layout for a particular locale.
1901 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1902 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1903 * src/main/java/org/glom/web/client/place/ListPlace.java:
1904 Parse and construct a lang parameter too.
1906 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1907 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1908 passed to subsequent methods and constructors.
1909 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1910 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1911 Store the localeID from the *Place and pass it to other constructors
1912 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1914 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1915 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1916 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1917 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1918 * src/main/java/org/glom/web/client/ui/ListView.java:
1919 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1920 Take localeID parameters and pass them to subsequent constructors and
1921 methods, so that the layout is always retrieved for that locale.
1923 This is rather repetitive.
1925 Note that "" means the original (default) locale of the Glom document,
1926 which is usually English.
1928 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1930 Documents: Remove final keyword to fix startup configuration.
1932 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1933 final keywords on the private member variables because that breaks
1934 the startup, apparently (there are warnings) because it stops them
1935 from being serialized. I added these in the previous commit.
1937 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1939 Documents: Add some final keywords.
1941 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1944 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1946 OnlineGlomServiceImpl: Add to overview comments.
1948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1949 Note that this is where all the document are loaded. They are not
1950 loaded freshly for each page.
1952 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1956 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1957 Add a TextBox for the text of a quick find.
1958 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1960 setBackLink(): Add a String quickFind parameter.
1961 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1962 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1963 to the base interface, because that is how TableSelectionViewImpl is used.
1964 * src/main/webapp/style.css: Add style for the search box and its label.
1966 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1967 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1968 Add these files, based on the existing TableChangeEvent and
1969 TableChangeEventHandlers.
1970 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1971 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1972 a ListPlace() that the user should be taken to.
1973 * src/main/java/org/glom/web/client/activity/ListActivity.java
1974 start(): Handle it here too and adapt the TableChangeEvent handler to
1975 pass the extra "" quickFind parameter to ListPlace.
1976 * src/main/java/org/glom/web/client/place/ListPlace.java:
1977 Constructor: Take an extra String quickFind parameter and store it,
1978 returning it from a new getQuickFind() method.
1979 getToken(): Put the quickFind text in the URL token.
1980 getPlace(): Parse the quickFind text from the URL token.
1981 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1982 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1983 ListPlace constructor.
1984 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1985 .java: start(): Add a Change handler for the TableSelectionView's
1986 TextBox (via its base HasChangeHandlers interface), firing the new
1987 QuickFindChangeEvent.
1988 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1989 pass the extra "" quickFind parameter.
1991 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1992 setCellTable(): Add a String quickFind parameter and pass it to
1993 the ListViewTable() constructor.
1994 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1995 setCellTable() in the base interface, because that is how ListViewImpl
1998 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1999 Add a String quickFind member variable.
2000 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2001 Constructor: Add a String quickFind parameter, storing it in the
2002 base ListTable's member variable.
2003 onRangeChanged(): Pass quickFind to the
2004 OnlineGlomServiceAsync.getSortedListViewData() and
2005 OnlineGlomServiceAsync.getListViewData() methods.
2007 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2008 getListViewData(), getSortedListViewData(): Add a String quickFind
2009 parameter, passing it to ConfiguredDocument.getListViewData().
2010 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2011 Change getListViewData(), getSortedListViewData() in the base interface,
2012 because that is how OnlineGlomServiceImpl is used, via this:
2013 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2014 Change getListViewData(), getSortedListViewData() here too.
2015 This class can apparently be used to asynchronously call methods on
2016 OnlineGlomService, and GWT seems to implement that after recognizing
2017 just the *Async name convention and the extra AsyncCallback parameters.
2019 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2020 getListViewData(): Add a String quickFind parameter, and pass it to
2021 ListViewDBAccess.getData().
2022 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2023 getListData(): Add a String quickFind parameter and pass it to
2025 getSelectQuery(): Add a String quickFind parameter.
2026 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2027 getSelectQuery(): Add a String quickFind parameter and use it with
2028 Glom.get_find_where_clause_quick() to pass a where_clause to
2029 Glom.build_sql_select_with_where_clause(), to actually filter the
2031 getData(): Add a String quickFind parameter, passing it to getListData().
2032 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2033 va: getData(): Pass an empty string to getListData() for the
2034 quickFind parameter.
2036 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2038 ListTable: Minor change.
2040 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2041 createCellTable(): Make this protected instead of public.
2043 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2045 Many files: Use final for the parameters and use the @override attribute.
2047 2012-01-22 Ben Konrath <ben@bagu.org>
2049 Add anchor links for single line text that starts with http, ftp and www.
2053 2012-01-22 Ben Konrath <ben@bagu.org>
2055 Add ellipsis to single line text in details view.
2059 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2061 Remove all javadoc author tags.
2063 Because they are awkward and meaningless when many people touch
2065 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2067 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2069 Revert the COPYING.LESSER to COPYING rename.
2071 Apparently both should be there if it is LGPL.
2073 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2075 *View: Remove unused imports.
2077 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2078 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2079 * src/main/java/org/glom/web/client/ui/ListView.java:
2080 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2081 Remove unused imports, as suggested by Eclipse.
2083 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2085 Move the *View::Presenter types, and some API into one base View.
2087 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2088 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2089 * src/main/java/org/glom/web/client/ui/ListView.java:
2090 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2091 Presenter, setPresenter() and clear() into a shared base interface,
2092 to avoid the unnecessary duplicate Presenter types and to more clearly
2093 show how the *Views share the same structure, even if they are not
2094 used polymorphically.
2096 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2097 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2099 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2100 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2101 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2103 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2106 Feel free to revert this if there is a good reason for the duplicate
2109 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2111 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2113 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2114 a class member instead of a local variable in the method.
2115 This lets us use it to get the view instances, for use in tests.
2116 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2117 beforeOnlineGlom(): Test some more details of the initial view.
2118 Again, this is not very useful.
2120 To really test gwt-glom we will need to start a local postgresql
2121 instance with local data, like the Glom tests in C++.
2123 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2125 pom.xml: Mention the LGPL license.
2127 * pom.xml: Add a licenses section.
2128 * COPYING.LESSER: Move this to COPYING, which
2129 previously contained the GPL. But gwt-glom is all LGPL.
2131 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2133 Add project information to README and pom.xml.
2135 * README: Add a brief description and mention some mvn
2137 * pom.xml: This extra information shows up in mvn site
2140 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2142 Use the latest java-libglom version.
2144 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2146 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2148 GwtTestOnlineGlom: Test a little more.
2150 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2151 protected rather than private, as suggested by the gwt-test-utils
2153 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2154 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2155 Test the initial visibility of the panels.
2157 However, this is not a very useful test.
2158 And I wonder how we should generally test using this idea for an
2159 activity/places app like ours where the real changes happen implicitly
2160 based on the history token/URL.
2162 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2164 Slight modification to *Mapper comments.
2166 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2167 (DataActivityMapper)
2168 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2170 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2172 Remove comments mentioning GIN because they are just copied from
2173 the example code and are apparently not helpful:
2174 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2175 Also change the mention of a class that is only in the example code.
2177 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2179 GwtTestOnlineGlom test: Minor changes.
2181 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2182 Avoid the long qualified class name and modify the comment
2183 because it is now obvious to me that the mocked class is the only
2184 custom one created via GWT.create().
2186 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2188 Tests: Added the beginnings of a test using gwt-test-utils.
2190 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2191 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2192 which tells gwt-test-utils what class will be tested.
2193 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2194 Add a simple (but empty) test case. One class, used by the OnlineGlom
2195 class, is mocked so that it can be created. However, I am not sure
2196 why only this class needs to be mocked.
2198 Note that mockito seems more popular, and clearer, than easymock,
2199 but I have not got that working yet. It might be a matter of the
2202 This test is run during mvn integration-test.
2204 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2206 Tests: Use junit4-style syntax instead of junit3-style.
2208 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2209 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2210 * src/test/java/org/glom/web/shared/DataItemTest.java:
2211 Use the @Test annotation rather than relying on the test*() prefix.
2212 Also no longer implement TestCase, to avoid triggering support for
2213 the junit3-way, which stops the annotations from working.
2214 Change the imports from import junit.framework.* to
2215 import org.junit.*, which is apparently the new way.
2217 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2219 Added a test for ListPlace token parsing and creation.
2221 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2222 This is much the same as DetailsPlaceTest.
2224 I wonder how we could test the other parts of the *Place API.
2226 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2228 DetailsPlace test: Also test getToken() and recreation via getPlace().
2230 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2231 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2232 recreate it, testing the recreated DetailsPlace for the same parameter
2235 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2237 Use the surefire-report plugin.
2239 * pom.xml: This generates a HTML report about the tests in
2240 target/site/surefire-report.html
2241 when you do mvn surefire-report:report. It seems to be popular/normal.
2243 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2245 Added a test for DetailsPlace.
2247 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2248 Test the getPlace() token parsing.
2250 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2252 Added a first unit test.
2254 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2255 * src/test/java/org/glom/web/shared/DataItemTest.java:
2256 This is a silly test but it is just to get things started. Note that
2257 maven/junit finds the test because it looks in src/test by default.
2259 2011-12-22 Ben Konrath <ben@bagu.org>
2261 Change charsetName to "UTF-8" when replacing line breaks.
2263 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2264 that work in Java (such as "UTF8") will not work when compiled to
2267 This fixes a problem with multi-line details view fields that have hard
2268 line breaks. The "License Text" field on this page demonstrates the
2271 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2273 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2275 2011-12-22 Ben Konrath <ben@bagu.org>
2277 Fix another bug with related list navigation.
2279 I've tested all the navigation buttons in all of the related lists
2280 so things should be good now.
2282 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2284 2011-12-22 Ben Konrath <ben@bagu.org>
2286 Fix a crasher when refreshing the list view with the default table.
2288 This crash will also happen when loading the list view with the default
2289 table from a link or bookmark.
2291 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2292 to the main document selection page when the document id hasn't been
2294 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2295 the main document selection page when the document id hasn't been
2297 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2298 values for the details place when the document id hasn't been set.
2299 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2300 values for the list place when the document id hasn't been set.
2302 2011-12-21 Ben Konrath <ben@bagu.org>
2304 Protect against NPE when glom.document.locale is not in config.
2306 This patch protects against an NPE when glom.document.locale is not in
2307 the config file. This NPE will also happen if glom.document.locale is
2310 The patch also updates the error message to display the class name when
2311 the getMessage() returns null. This was happening when the NPE was
2312 thrown and I had "Configuration Error: null". If an NPE is encountered
2313 with this patch, "Configuration Error: NullPointerException " will be
2316 This commit closes this bug:
2318 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2320 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2322 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2324 Rename onlineglom.properties to onlineglom.properties.sample.
2326 * src/main/resources/onlineglom.properties: Rename to:
2327 * src/main/resources/onlineglom.properties.sample:
2328 * src/main/resources/README: And add this file explaining that people
2329 should rename it back when deploying.
2331 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2333 Allow choosing the translation in the .properties file.
2335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2336 init(): Read a glom.document.locale value from the configuration file
2337 and call Glom's TransatableItem::set_current_locale() method.
2338 * src/main/resources/onlineglom.properties: Add a commented-out
2339 example of this new setting.
2341 It would be better to add &lang=de_DE to the URL, but the current
2342 libglom API does not allow us to do this easily. I am working on that.
2344 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2346 Avoid a crash in parsing of token parameters.
2348 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2349 ava: getTokenParams(): Do not crash if a parameter has a key but no
2350 value, and ignore parameters with neither.
2352 2011-12-17 Murray Cumming <murrayc@murayc.com>
2354 History token building/handling: Improve use of token parameters.
2356 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2357 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2358 and buildParamsToken(HashMap), for use by derived classes.
2359 Make the separator private because it is no longer be needed.
2360 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2361 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2362 instead of manual string concatenation.
2363 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2364 of hardcoded indices and awkward splitting code.
2365 * src/main/java/org/glom/web/client/place/ListPlace.java
2366 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2367 instead of manual string concatenation.
2368 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2369 of hardcoded indices and awkward splitting code.
2370 This should fix bug #666420
2372 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2374 Fix a Navgiation->Navigation typo in the code.
2376 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2377 Rename processNavgiation() to processNavigation().
2379 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2381 Fix a seperator->separator typo in the code.
2383 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2384 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2385 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2388 2011-12-15 Ben Konrath <ben@bagu.org>
2390 Cleanup some comments.
2392 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2394 2011-12-14 Ben Konrath <ben@bagu.org>
2396 Replace \n with <br/> for multiline text in the details view.
2398 Vertical scrollbars are added when needed as well.
2400 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2402 2011-12-14 Ben Konrath <ben@bagu.org>
2404 Specify the font for document selection links.
2406 * src/main/webapp/style.css:
2408 2011-12-14 Ben Konrath <ben@bagu.org>
2410 Fix bouncy CellTable while paging.
2412 This doesn't currently work with related list tables in unselected
2415 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2417 2011-12-14 Ben Konrath <ben@bagu.org>
2419 Revamp the appearance of the document selection page.
2421 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2422 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2423 * src/main/webapp/style.css:
2425 2011-12-13 Ben Konrath <ben@bagu.org>
2427 Set navigation button column to the smallest size possible.
2429 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2431 2011-12-13 Ben Konrath <ben@bagu.org>
2433 Change OpenButton nomenclature to NavigationButton.
2435 Using NavigtionButton makes things more generic. Classes, methods and
2436 variables have been changed.
2438 This is a rename-only refactor.
2440 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2441 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2442 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2443 Renamed from OpenButtonCell.
2444 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2445 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2446 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2448 2011-12-12 Ben Konrath <ben@bagu.org>
2450 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2452 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2453 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2454 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2455 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2457 2011-12-12 Ben Konrath <ben@bagu.org>
2459 Update variable names and comments.
2461 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2462 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2464 2011-12-12 Ben Konrath <ben@bagu.org>
2466 Properly initialize numNonEmptyRows variable to zero.
2468 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2469 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2471 2011-12-05 Ben Konrath <ben@bagu.org>
2473 Add latest mockup with HTML tables.
2475 Features of this mockup:
2477 -> HTML table for flowtable
2478 -> HTML table for flowtable column
2479 -> Example of how related lists would look
2480 -> Not using text entries for data items
2482 The current version of Online Glom doesn't use HTML tables for the
2485 This mockup has been sent to the glom-devel mailing list but it's good
2486 to have it here as well.
2488 * mockups/details-view-html-tables.html:
2490 2011-12-05 Ben Konrath <ben@bagu.org>
2492 Remove unnecessary getPrimaryKeyField() method.
2494 getPrimaryKeyFieldForTable(String) has been renamed to
2495 getPrimaryKeyField(String).
2497 * src/main/java/org/glom/web/server/database/DBAccess.java:
2498 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2499 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2501 2011-12-05 Ben Konrath <ben@bagu.org>
2503 Add string representation of TypedDataItem value to conversion error message.
2505 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2506 message was extracted into its own method to avoid duplication.
2508 2011-12-05 Ben Konrath <ben@bagu.org>
2510 Add type checking to navigation primary key value creation.
2512 Create navigation primary key only if the expected type from the Glom
2513 document matches the type returned by the SQL query.
2515 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2517 2011-12-05 Ben Konrath <ben@bagu.org>
2519 Rename a couple of variables in RelatedListNavigation.
2521 This is a rename-only refactor.
2523 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2525 2011-12-05 Ben Konrath <ben@bagu.org>
2527 Move getListLayoutGroup() into getListViewLayoutGroup().
2529 This removes getListLayoutGroup(). It was only being called by
2530 getListViewLayoutGroup().
2532 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2534 2011-12-05 Ben Konrath <ben@bagu.org>
2536 Remove check for LayoutItem_Portal in list table method.
2538 This check is no longer necessary because the method isn't being used
2539 to create the LayoutItemPortal DTO.
2541 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2543 2011-12-05 Ben Konrath <ben@bagu.org>
2545 Properly support related list navigation.
2547 Navigation from the "Repository Analyzer -> Package Scans ->
2548 Dependencies" related table wasn't working because the primary key for
2549 related tables wasn't being set properly. This commit fixes the
2552 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2553 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2554 doesn't set the primary key properly for related list tables.
2555 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2556 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2557 useful for getting the primary key for list view tables and for related
2559 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2560 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2561 Move code to set the primary key for the table from the abstract
2562 ListDBAccess class to ListViewDBAccess as it's only correct for list
2564 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2565 Properly add primary key to related list tables.
2567 2011-12-02 Ben Konrath <ben@bagu.org>
2569 Properly set the horizontal alignment of fields.
2571 This fix is for both the list tables and the details view.
2573 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2574 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2575 to set the horizontal alignment of fields.
2577 2011-12-02 Ben Konrath <ben@bagu.org>
2579 Display currency codes in the details view.
2581 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2583 2011-12-02 Ben Konrath <ben@bagu.org>
2585 Avoid duplicate JNI call.
2587 JNI is not as efficient as pure Java and this is an easy (and small)
2590 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2591 Use previously retrieved value for whereClauseToTableName instead of
2594 2011-12-02 Ben Konrath <ben@bagu.org>
2596 Rename a couple of variables in RelatedListNavigation.
2598 This is a rename-only refactor.
2600 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2602 2011-12-02 Ben Konrath <ben@bagu.org>
2604 Indicate clearly that a mismatched primary key type is a bug.
2606 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2607 warning to error. Add 'This is a bug.' to message.
2609 2011-12-02 Ben Konrath <ben@bagu.org>
2611 Update / fix some comments.
2613 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2615 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2617 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2618 Fix comments. Add some TODOs.
2620 2011-12-02 Ben Konrath <ben@bagu.org>
2622 Enable navigation to details view with string primary key from related list.
2624 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2625 Create a text primary key value when return type of result is
2626 java.sql.Types.VARCHAR.
2628 2011-12-02 Ben Konrath <ben@bagu.org>
2630 Use checkboxes for booleans in the details view.
2632 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2634 2011-12-01 Ben Konrath <ben@bagu.org>
2636 Improve performance of related list height calculation.
2638 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2639 Put code to calculate the expected height in a static initializer so
2640 that that it's only called once.
2642 2011-12-01 Ben Konrath <ben@bagu.org>
2644 Show related list tables in notebooks (again).
2646 Calculate the height of the related list tables so the Notebook can be
2647 set the correct height. The height of the related list table is also needed by
2648 FlowTable to be able decide how to create the layout.
2650 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2651 and set the Portal height based on the height of the related list
2652 table and the Portal container.
2653 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2654 Add method to calculate the height of the related list tables.
2655 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2656 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2657 calculate the height of the Pager widget.
2659 2011-12-01 Ben Konrath <ben@bagu.org>
2661 Use CellTable API for table property instead of setting style on Element.
2663 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2665 2011-12-01 Ben Konrath <ben@bagu.org>
2667 Make ListViewTable and RelatedListTable a consistent height.
2669 The tables are now a consistent height regardless of the contents of
2670 the table. A hidden button is added to empty rows to ensure that the
2671 height of these rows will match the height of rows with data.
2673 A navigation button column is now added to every table. The width of
2674 the navigation column is set to 0px when a RelatedListTable shouldn't
2675 have navigation buttons. This maintains the a consistent row height in
2676 tables that don't show the navigation buttons.
2678 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2679 navigation column when not needed.
2680 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2681 arguments for navigation button to constructor of ListViewTable.
2682 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2683 hidden button for empty data rows.
2684 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2685 arguments for navigation button to constructor.
2686 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2687 create navigation buttons. Add hideNavigationButtons() method.
2688 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2689 arguments for navigation button to constructor.
2691 2011-12-01 Ben Konrath <ben@bagu.org>
2693 Use 'visibility: hidden' in Utils.getWidgetHeight().
2695 This is better choice because hidden elements are invisible, don't
2696 respond to events and are not part of the tab order. They will,