1 2012-04-17 Murray Cumming <murrayc@murrayc.com>
3 Unselect the Report/Locale/Table combo item when appropriate.
5 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
6 setPlace(): clear reportName if this is not a ReportPlace.
7 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
8 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
9 When the provided name is empty, unselect all items, so that none are
10 indicated. This uses a for loop because I cannot find a single method
13 2012-04-17 Murray Cumming <murrayc@murrayc.com>
15 Report: Give the user a way to get back to the list.
17 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
18 start(), setPlace(): Show the Back To List link on reports, and also
19 interpret selecting the empty report item as back to list.
21 2012-04-17 Murray Cumming <murrayc@murrayc.com>
23 Style: Remove overflow:hidden from searchbox
25 * src/main/webapp/style.css: Because this pushes the Back To Link
26 label/link on to the next row, which is then hidden due to the
27 hard-coded (in ems) height.
29 2012-04-13 Murray Cumming <murrayc@murrayc.com>
31 Really show the selected Report name.
33 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
34 setPlace(): Store the reportName here, if it is that kind of Place.
35 fillView(): Set the selected Report after filling the list of reports.
36 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
37 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
38 null Strings, though we need some way to unselect all ListBox items
41 2012-04-13 Murray Cumming <murrayc@murrayc.com>
43 ReportGenerator: Try to avoid some problems.
45 * src/main/java/org/glom/web/server/ReportGenerator.java
46 addField(): Try to avoid duplicates, and avoid using a null
49 2012-04-13 Murray Cumming <murrayc@murrayc.com>
51 Reports: Use quickFind.
53 * src/main/java/org/glom/web/client/OnlineGlomService.java;
54 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
55 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
56 getReportHTML(): Add a quickFind parameter.
57 * src/main/java/org/glom/web/client/activity/ReportActivity.java
58 start(): Pass the quickFind parameter.
59 * src/main/java/org/glom/web/server/ReportGenerator.java
60 generateReport(): Take a quickFind parameter.
62 2012-04-13 Murray Cumming <murrayc@murrayc.com>
64 ReportPlace: Actually use the report name.
66 * src/main/java/org/glom/web/client/place/ReportPlace.java
67 getPlace(): Do not assign the report name to the quickfind.
69 2012-04-13 Murray Cumming <murrayc@murrayc.com>
71 Show java.library.path when complaining.
73 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
74 init(): When telling us to check java.library.path, show the
77 2012-04-12 Murray Cumming <murrayc@murrayc.com>
79 Adapt to the java-libglom 1.21.8 API.
81 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
82 java-libglom's FieldFormatting is now Formatting.
84 2012-04-12 Murray Cumming <murrayc@murrayc.com>
86 Use the latest java-libglom version.
88 * pom.xml: Use java-libglom 1.21.8.
90 2012-03-15 Murray Cumming <murrayc@murrayc.com>
92 Adapt to the java-libglom 1.21.7 API.
94 * src/main/java/org/glom/web/server/ReportGenerator.java:
95 addToReport(): get_group_secondary_fields() is now
96 get_secondary_fields().
98 2012-03-15 Murray Cumming <murrayc@murrayc.com>
100 Use the latest java-libglom version.
102 * pom.xml: Use java-libglom 1.21.7.
104 2012-03-06 Murray Cumming <murrayc@murrayc.com>
106 ReportGenerator: Do not show nulls.
108 2012-03-06 Murray Cumming <murrayc@murrayc.com>
110 ReportGenerator: Make the title font larger.
112 2012-03-06 Murray Cumming <murrayc@murrayc.com>
114 ReportGenerator: Put field titles inside groups, if there are groups.
116 2012-03-06 Murray Cumming <murrayc@murrayc.com>
118 ReportGenerator: Take the Report itself instead of the name and group.
120 * src/main/java/org/glom/web/server/ConfiguredDocument.java
121 Remove getReportLayoutGroup().
122 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
123 getReportHTML(): Pass the report instead
124 of its name and layout group.
125 * src/main/java/org/glom/web/server/ReportGenerator.java
126 generateReport(): Use the report object to use the title
129 2012-03-06 Murray Cumming <murrayc@murrayc.com>
131 ReportGenerator: Remove designBand parameters.
133 * src/main/java/org/glom/web/server/ReportGenerator.java:
134 Make designBand a class member instead of passing it to all
137 2012-03-06 Murray Cumming <murrayc@murrayc.com>
139 ReportGenerator: Add lines, a bit like in the desktop version.
141 * src/main/java/org/glom/web/server/ReportGenerator.java
142 addToReport(): Use JRDesignLine.
144 2012-03-06 Murray Cumming <murrayc@murrayc.com>
146 ReportGenerator: Correct the title positions and use some bold style.
148 * src/main/java/org/glom/web/server/ReportGenerator.java:
149 Break the code up into reusable functions, correct the placement of
150 titles, and use normal/bold styles as in the reports in the desktop
153 2012-03-06 Murray Cumming <murrayc@murrayc.com>
155 ReportGenerator: Add a header band to show the field titles.
157 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
158 getReportHTML(): Pass the localeId to the ReportGenerator
160 * src/main/java/org/glom/web/server/ReportGenerator.java
161 constructor: Take the localeID so we can get translated field
163 generateReport(), addToReport(), addFieldToBand(): Add field
164 titles in a column header band.
166 2012-03-05 Murray Cumming <murrayc@murrayc.com>
168 Reports drop-down list: Some improvement.
170 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
171 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
172 Adedd setSelectedReport(),
173 setReportList(): Add a blank line so that the user can select the
175 * src/main/java/org/glom/web/client/activity/ReportActivity.java
176 start(): Show the current report by calling setSelectedReport().
177 This does not seem to work yet.
179 2012-03-05 Murray Cumming <murrayc@murrayc.com>
181 DetailsActivity, ListActivity: Move some variables into a base class.
183 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
184 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
185 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
186 the clientFactory, documentID, tableName and authenticationPopup into
187 a base class, to avoid duplication.
189 2012-03-05 Murray Cumming <murrayc@murrayc.com>
191 Translate the Reports label.
193 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
194 Get the "Reports" label string from the constants.
195 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
196 perties: Add Reports to the constants.
198 2012-03-03 Ben Konrath <ben@bagu.org>
200 Display date and time in details view.
202 https://bugzilla.gnome.org/show_bug.cgi?id=671257
204 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
206 2012-03-05 Murray Cumming <murrayc@murrayc.com>
208 Require the latest java-libglom.
210 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
212 2012-03-05 Murray Cumming <murrayc@murrayc.com>
214 Reports: Implement grouping.
216 * src/main/java/org/glom/web/server/ReportGenerator.java:
217 Handle LayoutItem_GroupBy items and try to do the right thing
218 with JRDesignGroup. It seems to work.
220 2012-03-04 Murray Cumming <murrayc@murrayc.com>
222 Actually show some data with JasperReports.
224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
225 getReportHTML(): Move most code into a ReportGenerator class.
226 * src/main/java/org/glom/web/server/ReportGenerator.java:
227 Recurse into sub-groups, adding fields to the JasperDesign's details
228 band. Note that we must set an arbitrary width and height, or it just
229 will not show any data.
231 2012-03-04 Murray Cumming <murrayc@murrayc.com>
233 Reports Chooser: Show the titles, not the names.
235 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
236 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
237 and the names as the values.
238 * src/main/java/org/glom/web/server/ConfiguredDocument.java
239 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
240 group now that we provide the report name, so it should always
243 2012-03-04 Murray Cumming <murrayc@murrayc.com>
245 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
247 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
248 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
249 an empty quickfind string. I also corrected libglom to create only
250 empty where clauses for empty quickfind strings, but this avoids the
253 2012-02-24 Ben Konrath <ben@bagu.org>
255 Improve the tabs in the Notebook widget.
259 2012-02-15 Murray Cumming <murrayc@murrayc.com>
261 Depend on jasperreports.
263 * pom.xml: Add the dependency. My plan is to use this on the
266 2012-01-31 Murray Cumming <murrayc@murrayc.com>
268 Implement navigation to report places.
270 * src/main/java/org/glom/web/client/activity/ReportActivity.java
271 start(): Do not bother to handle all events here.
272 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
273 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
274 Added getSelectedReport().
275 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
276 .java: start(): When handling a change to the reports chooser,
277 call getSelectedReport() and goTo() its ReportPlace.
278 * src/main/java/org/glom/web/client/ui/ReportView.java
279 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
280 Added setReportHTML() which puts the html in a gwt HTML widget.
281 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
282 getReportHTML(): Return "TODO" just to show that this works.
284 2012-01-31 Murray Cumming <murrayc@murrayc.com>
286 Make ReportPlace usable.
288 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
290 * src/main/java/org/glom/web/client/place/ReportPlace.java:
291 Correct the @prefix annotation.
293 2012-01-31 Murray Cumming <murrayc@murrayc.com>
295 OnlineGlomService: Return report HTML rather than the LayoutGroup.
297 * src/main/java/org/glom/web/client/OnlineGlomService.java:
298 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
299 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
300 Change getReportLayout() to getReportHMTL() because we will not need to
301 parse or render the report layout on the client side.
302 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
303 getReportLayout(): Return the libglom LayoutGroup type because we will
304 not need to convert to a shared type, because this will not be used on
306 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
309 Note that there is still no implementation for this.
311 2012-01-30 Murray Cumming <murrayc@murrayc.com>
313 Translations: Try to translate the strings.
315 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
316 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
317 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
318 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
319 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
320 Take the Open translation from GTK+'s .po files.
321 Take the Details translation from Glom's po files.
322 I have added the other strings to Glom so we can get translations that way:
323 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
325 2012-01-27 Murray Cumming <murrayc@murrayc.com>
327 Add a (empty) Report Place, View, and Activity.
329 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
331 * src/main/java/org/glom/web/client/place/HasTablePlace.java
332 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
333 this into a superclass:
334 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
335 and also use it as the base of this new ReportPlace:
336 * src/main/java/org/glom/web/client/place/ReportPlace.java
338 * src/main/java/org/glom/web/client/ui/ReportView.java
339 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
340 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
341 Add these, containing mostly boiler-plate for now.
343 * src/main/java/org/glom/web/client/OnlineGlomService.java
344 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
345 * src/main/java/org/glom/web/server/ConfiguredDocument.java
346 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
347 Add API to get the LayoutGroup for the report.
349 2012-01-27 Murray Cumming <murrayc@murrayc.com>
351 TableSelectionViewImpl: Put the search label and entry in a div.
353 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
354 Put the search widgets in a FlowTable so that the CSS can be used to
355 style them while keeping them together.
356 * src/main/webapp/style.css: Mention the new div.
358 2012-01-27 Murray Cumming <murrayc@murrayc.com>
360 Translate more strings in more locales.
362 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
363 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
364 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
365 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
366 Translate the "Details" and "Open" string too.
368 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
369 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
370 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
371 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
372 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
373 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
374 Add these new locales as placeholders though they currently contain English.
376 2012-01-27 Murray Cumming <murrayc@murrayc.com>
378 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
380 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
381 Check the ConfiguredDocument* for null before using it.
383 2012-01-26 Murray Cumming <murrayc@murrayc.com>
385 Tell Eclipse about the generated java files.
387 * .classpath: This lets it find OnlineGlomConstants.java.
388 It would be nice if Eclipse just used the maven build files.
390 2012-01-26 Murray Cumming <murrayc@murrayc.com>
392 Prevent a crash when no locale is specified in the URL.
394 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
395 Avoid returning a null string, obtained from
396 Window.Location.getParameter(). This caused a crash when it was
397 later passed to libglom's API.
398 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
399 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
400 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
401 guard against future null strings.
403 2012-01-26 Murray Cumming <murrayc@murrayc.com>
405 Use the ?locale= query param instead of the &lang= token param.
407 * src/main/java/org/glom/web/client/place/ListPlace.java
408 * src/main/java/org/glom/web/client/place/DetailsPlace.java
409 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
410 Remove the lang token key and value.
412 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
413 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
414 When the user selects a different locale from the chooser, use
415 Window.Location.assign() to change the URL, which then causes a reload.
417 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
418 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
419 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
420 * src/main/java/org/glom/web/client/activity/ListActivity.java
421 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
422 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
423 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
424 * src/main/java/org/glom/web/client/ui/ListView.java:
425 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
427 Remove localeID member variables and method/constructor parameters, instead
428 using Utils.getCurrentLocaleID() when we need a localID to pass to
431 2012-01-26 Murray Cumming <murrayc@murrayc.com>
433 Internationalize the UI strings.
435 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
436 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
437 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
438 because it is unused. Messages are apparently strings that can have
439 parameters, but we do not need that yet, so Contants will be enough for now.
440 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
441 to say that we support the en and de locales.
442 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
443 The original English strings.
444 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
445 Some German translations of the English strings.
446 The i18n goal then uses the .properties file to generate an
447 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
448 returns an implementation that returns the translated strings.
449 The documentation suggests putting these in src/java/*/client/, but it seems
450 best to put it in src/resources/*/client/.
451 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
452 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
453 instead of hard-coding them.
454 Note that we cannot import OnlineGlomConstants because it does not exist yet,
455 but that does not seem to stop the build, though it confuses Eclipse.
457 You can see the translated string by adding ?locale=de to the URL, like so:
458 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
460 2012-01-24 Murray Cumming <murrayc@murrayc.com>
462 Improve null/empty String checks.
464 * pom.xml: Add a dependency on commons-lang, to use
465 org.apache.commons.lang.StringUtils.
466 * src/main/java/org/glom/web/server/ConfiguredDocument.java
467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
468 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
469 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
470 Use StringUtils.isEmpty().
472 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
473 StringUtils class with a static isEmpty() function because we
474 cannot use org.apache.commons.lang.StringUtils in client-side
475 GWT code because it (apparently) cannot be compiled to javascript.
476 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
477 * src/main/java/org/glom/web/client/activity/ListActivity.java
478 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
479 * src/main/java/org/glom/web/client/place/DetailsPlace.java
480 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
481 * src/main/java/org/glom/web/client/place/ListPlace.java
482 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
483 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
484 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
485 * src/main/java/org/glom/web/client/ui/details/Group.java
486 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
487 our StringUtils.isEmpty() function.
489 2012-01-24 Murray Cumming <murrayc@murrayc.com>
491 Update to the latest java-libglom API.
493 * pom.xml: Require java-libglom 1.21.4.
494 * src/main/java/org/glom/web/server/ConfiguredDocument.java
495 getDocumentInfo(), getListViewLayoutGroup():
496 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
498 * src/main/java/org/glom/web/server/database/DBAccess.java
499 getFieldsToShowForSQLQueryAddGroup(),
500 getPrimaryKeyLayoutItemField(): Replace get_database_title()
501 with either get_database_title_original() or
502 get_database_title(localeID).
504 2012-01-24 Murray Cumming <murrayc@murrayc.com>
506 ConfiguredDocument: Avoid a null pointer exception.
508 * src/main/java/org/glom/web/server/ConfiguredDocument.java
509 Initialize localeID to "" to avoid returning a null String which
510 causes a crash in java-libglom's swing-generated code.
512 2012-01-23 Murray Cumming <murrayc@murrayc.com>
514 Some simple renaming.
516 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
517 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
518 for localeChooser. This seems more appropriate and is less ambiguous
519 particularly in the .css file.
521 2012-01-23 Murray Cumming <murrayc@murrayc.com>
523 ConfiguredDocument: Rename the localedID private member variable.
525 2012-01-23 Murray Cumming <murrayc@murrayc.com>
527 Adapt to the latest java-libglom API from git master.
529 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
530 libglom now uses only Vector instead of List, which uses add() instead of
533 2012-01-23 Murray Cumming <murrayc@murrayc.com>
535 Add and fill a Reports drop-down list box.
537 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
539 * src/main/java/org/glom/web/client/OnlineGlomService.java:
540 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
541 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
542 Added getReports(document, table, localeID), calling
543 ConfiguredDocument.getReports().
544 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
545 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
546 Added setReportsList() and a list widget.
547 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
548 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
550 2012-01-22 Murray Cumming <murrayc@murrayc.com>
552 ConfiguredDocument: Rename the localedID private member variable.
554 2012-01-20 Murray Cumming <murrayc@murrayc.com>
556 Build a source tarball with mvn assembly:single
558 * assembly.xml: Add this file.
559 * pom.xml: Use the maven-assembly-plugin and tell it to use
560 our assembly.xml file.
562 2012-01-19 Murray Cumming <murrayc@murrayc.com>
564 OnlineGlomServiceImpl: Get .glom files recursively.
566 * pom.xml: Depend on commons-io from org.apache.commons.
567 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
568 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
569 files recursively, and with the easier filter for the extension.
570 Use org.apache.commons.io.FilenameUtils.removeExtension() to
571 simplify that code too.
573 2012-01-19 Murray Cumming <murrayc@murrayc.com>
575 README: Mention that you must install java-libglom packages separately.
577 But then it works, because java-libglom is now in the central maven
580 2012-01-18 Murray Cumming <murrayc@murrayc.com>
582 locales drop-down: Show the correct selected locale when the URL changes.
584 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
585 .java: setPlace(): Move some code into fillView().
587 2012-01-18 Murray Cumming <murrayc@murrayc.com>
589 locales drop-down: Do not lose the primary key.
591 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
592 start(): onLocaleChange(): Pass the current primary key value,
593 instead of an empty value.
595 2012-01-18 Murray Cumming <murrayc@murrayc.com>
597 locales drop-down: Do not lose the drop-down selection.
599 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
600 .java (TableSelectionActivity.fillView): Set the selected locale
601 after changing the drop-down items (though we do not really need
602 to change them just because the locale changes.)
604 2012-01-18 Murray Cumming <murrayc@murrayc.com>
606 locales drop-down: Change the tables list when this changes.
608 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
609 .java: TableSelectionActivity.start(): Move the async table titles
610 retrieval into a private fillView() method and also call this when
611 the chosen locale changes.
612 Note that the document title is not actually translatable yet, but
613 that is a problem that I should fix soon in libglom.
615 2012-01-18 Murray Cumming <murrayc@murrayc.com>
617 Improve the placement of the locales drop-down.
619 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
620 Put the title and locales drop-down in a div (gwt.FlowTable).
621 * src/main/webapp/style.css: Add magic css properties to make this work.
622 Also remove the left margin from the title so that it lines up with the
625 2012-01-18 Murray Cumming <murrayc@murrayc.com>
627 locales selector: Show human-readable locale titles.
629 * src/main/java/org/glom/web/server/ConfiguredDocument.java
630 getDocumentInfo(): Use java.util.Locale to show a real title of
631 each locale, in the locale's own language.
633 2012-01-17 Murray Cumming <murrayc@murrayc.com>
635 Add a language/locale selector drop-down.
637 * src/main/java/org/glom/web/shared/DocumentInfo.java:
638 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
639 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
640 getDocumentInfo(): Store the available Locales in the DocumentInfo.
641 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
642 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
643 Add a ListBox to show the available locales. Add getLocaleSelector(),
644 setLocaleList(), getSelectedLocale(), setSelectedLocale().
645 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
646 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
647 java: Add these classes.
648 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
649 start(): Fill the locales ListBox. Handle its change event, firing a
651 setPlace(): Show the selected locale as specified by the URL token.
652 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
653 * src/main/java/org/glom/web/client/activity/ListActivity.java:
654 Handle LocaleChangeEvent, going to a new *Place with that locale.
656 The placement of the ListBox is not pretty, and it currently uses the ID
657 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
661 2012-01-17 Murray Cumming <murrayc@murrayc.com>
663 Search box: Show the search text from the URL token.
665 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
666 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
667 Add setQuickFindText().
668 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
669 .java: setPlace(): Store the queryText if the place is a ListPlace,
670 and call TableSelectionView.setQuickFindText().
672 2012-01-17 Murray Cumming <murrayc@murrayc.com>
674 Allow use of translations via, for instance, &lang=de in the URL.
676 * pom.xml: Use the unstable java-libglom 1.21 version.
678 * src/main/java/org/glom/web/client/OnlineGlomService.java:
679 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
680 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
681 init(): Instead of calling TranslatableItem.set_current_locale()
682 (now removed), call ConfiguredDocument.setDefaultLocaleID().
683 However, this is only for default locales, which are not needed to
684 change the locale in the URL.
685 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
686 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
687 getSortedRelatedListData(): Add a localeID parameter, so we can get the
688 layout for a particular locale.
689 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
690 Add get/setDefaultLocaleID().
691 getDocumentInfo(), getListViewData(), getRelatedListData(),
692 getDetailsLayoutGroup(), getListViewLayoutGroup(),
693 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
694 localeID parameter, so we can get the layout for a particular locale.
696 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
697 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
698 * src/main/java/org/glom/web/client/place/ListPlace.java:
699 Parse and construct a lang parameter too.
701 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
702 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
703 passed to subsequent methods and constructors.
704 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
705 * src/main/java/org/glom/web/client/activity/ListActivity.java:
706 Store the localeID from the *Place and pass it to other constructors
707 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
709 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
710 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
711 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
712 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
713 * src/main/java/org/glom/web/client/ui/ListView.java:
714 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
715 Take localeID parameters and pass them to subsequent constructors and
716 methods, so that the layout is always retrieved for that locale.
718 This is rather repetitive.
720 Note that "" means the original (default) locale of the Glom document,
721 which is usually English.
723 2012-01-17 Murray Cumming <murrayc@murrayc.com>
725 Documents: Remove final keyword to fix startup configuration.
727 * src/main/java/org/glom/web/shared/Documents.java: Remove the
728 final keywords on the private member variables because that breaks
729 the startup, apparently (there are warnings) because it stops them
730 from being serialized. I added these in the previous commit.
732 2012-01-13 Murray Cumming <murrayc@murrayc.com>
734 Documents: Add some final keywords.
736 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
739 2012-01-13 Murray Cumming <murrayc@murrayc.com>
741 OnlineGlomServiceImpl: Add to overview comments.
743 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
744 Note that this is where all the document are loaded. They are not
745 loaded freshly for each page.
747 2012-01-12 Murray Cumming <murrayc@murrayc.com>
751 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
752 Add a TextBox for the text of a quick find.
753 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
755 setBackLink(): Add a String quickFind parameter.
756 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
757 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
758 to the base interface, because that is how TableSelectionViewImpl is used.
759 * src/main/webapp/style.css: Add style for the search box and its label.
761 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
762 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
763 Add these files, based on the existing TableChangeEvent and
764 TableChangeEventHandlers.
765 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
766 start(): Handle QuickFindChangeEvent, passing its quickFind text to
767 a ListPlace() that the user should be taken to.
768 * src/main/java/org/glom/web/client/activity/ListActivity.java
769 start(): Handle it here too and adapt the TableChangeEvent handler to
770 pass the extra "" quickFind parameter to ListPlace.
771 * src/main/java/org/glom/web/client/place/ListPlace.java:
772 Constructor: Take an extra String quickFind parameter and store it,
773 returning it from a new getQuickFind() method.
774 getToken(): Put the quickFind text in the URL token.
775 getPlace(): Parse the quickFind text from the URL token.
776 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
777 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
778 ListPlace constructor.
779 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
780 .java: start(): Add a Change handler for the TableSelectionView's
781 TextBox (via its base HasChangeHandlers interface), firing the new
782 QuickFindChangeEvent.
783 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
784 pass the extra "" quickFind parameter.
786 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
787 setCellTable(): Add a String quickFind parameter and pass it to
788 the ListViewTable() constructor.
789 * src/main/java/org/glom/web/client/ui/ListView.java: Change
790 setCellTable() in the base interface, because that is how ListViewImpl
793 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
794 Add a String quickFind member variable.
795 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
796 Constructor: Add a String quickFind parameter, storing it in the
797 base ListTable's member variable.
798 onRangeChanged(): Pass quickFind to the
799 OnlineGlomServiceAsync.getSortedListViewData() and
800 OnlineGlomServiceAsync.getListViewData() methods.
802 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
803 getListViewData(), getSortedListViewData(): Add a String quickFind
804 parameter, passing it to ConfiguredDocument.getListViewData().
805 * src/main/java/org/glom/web/client/OnlineGlomService.java:
806 Change getListViewData(), getSortedListViewData() in the base interface,
807 because that is how OnlineGlomServiceImpl is used, via this:
808 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
809 Change getListViewData(), getSortedListViewData() here too.
810 This class can apparently be used to asynchronously call methods on
811 OnlineGlomService, and GWT seems to implement that after recognizing
812 just the *Async name convention and the extra AsyncCallback parameters.
814 * src/main/java/org/glom/web/server/ConfiguredDocument.java
815 getListViewData(): Add a String quickFind parameter, and pass it to
816 ListViewDBAccess.getData().
817 * src/main/java/org/glom/web/server/database/ListDBAccess.java
818 getListData(): Add a String quickFind parameter and pass it to
820 getSelectQuery(): Add a String quickFind parameter.
821 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
822 getSelectQuery(): Add a String quickFind parameter and use it with
823 Glom.get_find_where_clause_quick() to pass a where_clause to
824 Glom.build_sql_select_with_where_clause(), to actually filter the
826 getData(): Add a String quickFind parameter, passing it to getListData().
827 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
828 va: getData(): Pass an empty string to getListData() for the
831 2012-01-12 Murray Cumming <murrayc@murrayc.com>
833 ListTable: Minor change.
835 * src/main/java/org/glom/web/client/ui/list/ListTable.java
836 createCellTable(): Make this protected instead of public.
838 2012-01-12 Murray Cumming <murrayc@murrayc.com>
840 Many files: Use final for the parameters and use the @override attribute.
842 2012-01-22 Ben Konrath <ben@bagu.org>
844 Add anchor links for single line text that starts with http, ftp and www.
848 2012-01-22 Ben Konrath <ben@bagu.org>
850 Add ellipsis to single line text in details view.
854 2012-01-04 Murray Cumming <murrayc@murrayc.com>
856 Remove all javadoc author tags.
858 Because they are awkward and meaningless when many people touch
860 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
862 2012-01-04 Murray Cumming <murrayc@murrayc.com>
864 Revert the COPYING.LESSER to COPYING rename.
866 Apparently both should be there if it is LGPL.
868 2012-01-03 Murray Cumming <murrayc@murrayc.com>
870 *View: Remove unused imports.
872 * src/main/java/org/glom/web/client/ui/DetailsView.java:
873 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
874 * src/main/java/org/glom/web/client/ui/ListView.java:
875 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
876 Remove unused imports, as suggested by Eclipse.
878 2012-01-02 Murray Cumming <murrayc@murrayc.com>
880 Move the *View::Presenter types, and some API into one base View.
882 * src/main/java/org/glom/web/client/ui/DetailsView.java:
883 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
884 * src/main/java/org/glom/web/client/ui/ListView.java:
885 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
886 Presenter, setPresenter() and clear() into a shared base interface,
887 to avoid the unnecessary duplicate Presenter types and to more clearly
888 show how the *Views share the same structure, even if they are not
889 used polymorphically.
891 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
892 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
894 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
895 * src/main/java/org/glom/web/client/activity/ListActivity.java:
896 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
898 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
901 Feel free to revert this if there is a good reason for the duplicate
904 2012-01-02 Murray Cumming <murrayc@murrayc.com>
906 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
908 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
909 a class member instead of a local variable in the method.
910 This lets us use it to get the view instances, for use in tests.
911 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
912 beforeOnlineGlom(): Test some more details of the initial view.
913 Again, this is not very useful.
915 To really test gwt-glom we will need to start a local postgresql
916 instance with local data, like the Glom tests in C++.
918 2012-01-02 Murray Cumming <murrayc@murrayc.com>
920 pom.xml: Mention the LGPL license.
922 * pom.xml: Add a licenses section.
923 * COPYING.LESSER: Move this to COPYING, which
924 previously contained the GPL. But gwt-glom is all LGPL.
926 2012-01-02 Murray Cumming <murrayc@murrayc.com>
928 Add project information to README and pom.xml.
930 * README: Add a brief description and mention some mvn
932 * pom.xml: This extra information shows up in mvn site
935 2011-01-02 Murray Cumming <murrayc@murrayc.com>
937 Use the latest java-libglom version.
939 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
941 2012-01-01 Murray Cumming <murrayc@murrayc.com>
943 GwtTestOnlineGlom: Test a little more.
945 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
946 protected rather than private, as suggested by the gwt-test-utils
948 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
949 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
950 Test the initial visibility of the panels.
952 However, this is not a very useful test.
953 And I wonder how we should generally test using this idea for an
954 activity/places app like ours where the real changes happen implicitly
955 based on the history token/URL.
957 2012-01-01 Murray Cumming <murrayc@murrayc.com>
959 Slight modification to *Mapper comments.
961 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
963 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
965 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
967 Remove comments mentioning GIN because they are just copied from
968 the example code and are apparently not helpful:
969 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
970 Also change the mention of a class that is only in the example code.
972 2012-01-01 Murray Cumming <murrayc@murrayc.com>
974 GwtTestOnlineGlom test: Minor changes.
976 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
977 Avoid the long qualified class name and modify the comment
978 because it is now obvious to me that the mocked class is the only
979 custom one created via GWT.create().
981 2012-01-01 Murray Cumming <murrayc@murrayc.com>
983 Tests: Added the beginnings of a test using gwt-test-utils.
985 * pom.xml: Add dependencies on gwt-test-utils and easymock.
986 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
987 which tells gwt-test-utils what class will be tested.
988 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
989 Add a simple (but empty) test case. One class, used by the OnlineGlom
990 class, is mocked so that it can be created. However, I am not sure
991 why only this class needs to be mocked.
993 Note that mockito seems more popular, and clearer, than easymock,
994 but I have not got that working yet. It might be a matter of the
997 This test is run during mvn integration-test.
999 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1001 Tests: Use junit4-style syntax instead of junit3-style.
1003 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1004 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1005 * src/test/java/org/glom/web/shared/DataItemTest.java:
1006 Use the @Test annotation rather than relying on the test*() prefix.
1007 Also no longer implement TestCase, to avoid triggering support for
1008 the junit3-way, which stops the annotations from working.
1009 Change the imports from import junit.framework.* to
1010 import org.junit.*, which is apparently the new way.
1012 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1014 Added a test for ListPlace token parsing and creation.
1016 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1017 This is much the same as DetailsPlaceTest.
1019 I wonder how we could test the other parts of the *Place API.
1021 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1023 DetailsPlace test: Also test getToken() and recreation via getPlace().
1025 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1026 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1027 recreate it, testing the recreated DetailsPlace for the same parameter
1030 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1032 Use the surefire-report plugin.
1034 * pom.xml: This generates a HTML report about the tests in
1035 target/site/surefire-report.html
1036 when you do mvn surefire-report:report. It seems to be popular/normal.
1038 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1040 Added a test for DetailsPlace.
1042 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1043 Test the getPlace() token parsing.
1045 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1047 Added a first unit test.
1049 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1050 * src/test/java/org/glom/web/shared/DataItemTest.java:
1051 This is a silly test but it is just to get things started. Note that
1052 maven/junit finds the test because it looks in src/test by default.
1054 2011-12-22 Ben Konrath <ben@bagu.org>
1056 Change charsetName to "UTF-8" when replacing line breaks.
1058 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1059 that work in Java (such as "UTF8") will not work when compiled to
1062 This fixes a problem with multi-line details view fields that have hard
1063 line breaks. The "License Text" field on this page demonstrates the
1066 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1068 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1070 2011-12-22 Ben Konrath <ben@bagu.org>
1072 Fix another bug with related list navigation.
1074 I've tested all the navigation buttons in all of the related lists
1075 so things should be good now.
1077 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1079 2011-12-22 Ben Konrath <ben@bagu.org>
1081 Fix a crasher when refreshing the list view with the default table.
1083 This crash will also happen when loading the list view with the default
1084 table from a link or bookmark.
1086 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1087 to the main document selection page when the document id hasn't been
1089 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1090 the main document selection page when the document id hasn't been
1092 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1093 values for the details place when the document id hasn't been set.
1094 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1095 values for the list place when the document id hasn't been set.
1097 2011-12-21 Ben Konrath <ben@bagu.org>
1099 Protect against NPE when glom.document.locale is not in config.
1101 This patch protects against an NPE when glom.document.locale is not in
1102 the config file. This NPE will also happen if glom.document.locale is
1105 The patch also updates the error message to display the class name when
1106 the getMessage() returns null. This was happening when the NPE was
1107 thrown and I had "Configuration Error: null". If an NPE is encountered
1108 with this patch, "Configuration Error: NullPointerException " will be
1111 This commit closes this bug:
1113 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1115 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1117 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1119 Rename onlineglom.properties to onlineglom.properties.sample.
1121 * src/main/resources/onlineglom.properties: Rename to:
1122 * src/main/resources/onlineglom.properties.sample:
1123 * src/main/resources/README: And add this file explaining that people
1124 should rename it back when deploying.
1126 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1128 Allow choosing the translation in the .properties file.
1130 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1131 init(): Read a glom.document.locale value from the configuration file
1132 and call Glom's TransatableItem::set_current_locale() method.
1133 * src/main/resources/onlineglom.properties: Add a commented-out
1134 example of this new setting.
1136 It would be better to add &lang=de_DE to the URL, but the current
1137 libglom API does not allow us to do this easily. I am working on that.
1139 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1141 Avoid a crash in parsing of token parameters.
1143 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1144 ava: getTokenParams(): Do not crash if a parameter has a key but no
1145 value, and ignore parameters with neither.
1147 2011-12-17 Murray Cumming <murrayc@murayc.com>
1149 History token building/handling: Improve use of token parameters.
1151 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1152 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1153 and buildParamsToken(HashMap), for use by derived classes.
1154 Make the separator private because it is no longer be needed.
1155 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1156 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1157 instead of manual string concatenation.
1158 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1159 of hardcoded indices and awkward splitting code.
1160 * src/main/java/org/glom/web/client/place/ListPlace.java
1161 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1162 instead of manual string concatenation.
1163 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1164 of hardcoded indices and awkward splitting code.
1165 This should fix bug #666420
1167 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1169 Fix a Navgiation->Navigation typo in the code.
1171 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1172 Rename processNavgiation() to processNavigation().
1174 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1176 Fix a seperator->separator typo in the code.
1178 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1179 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1180 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1183 2011-12-15 Ben Konrath <ben@bagu.org>
1185 Cleanup some comments.
1187 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1189 2011-12-14 Ben Konrath <ben@bagu.org>
1191 Replace \n with <br/> for multiline text in the details view.
1193 Vertical scrollbars are added when needed as well.
1195 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1197 2011-12-14 Ben Konrath <ben@bagu.org>
1199 Specify the font for document selection links.
1201 * src/main/webapp/style.css:
1203 2011-12-14 Ben Konrath <ben@bagu.org>
1205 Fix bouncy CellTable while paging.
1207 This doesn't currently work with related list tables in unselected
1210 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1212 2011-12-14 Ben Konrath <ben@bagu.org>
1214 Revamp the appearance of the document selection page.
1216 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1217 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1218 * src/main/webapp/style.css:
1220 2011-12-13 Ben Konrath <ben@bagu.org>
1222 Set navigation button column to the smallest size possible.
1224 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1226 2011-12-13 Ben Konrath <ben@bagu.org>
1228 Change OpenButton nomenclature to NavigationButton.
1230 Using NavigtionButton makes things more generic. Classes, methods and
1231 variables have been changed.
1233 This is a rename-only refactor.
1235 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1236 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1237 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1238 Renamed from OpenButtonCell.
1239 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1240 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1241 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1243 2011-12-12 Ben Konrath <ben@bagu.org>
1245 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1247 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1248 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1249 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1250 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1252 2011-12-12 Ben Konrath <ben@bagu.org>
1254 Update variable names and comments.
1256 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1257 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1259 2011-12-12 Ben Konrath <ben@bagu.org>
1261 Properly initialize numNonEmptyRows variable to zero.
1263 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1264 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1266 2011-12-05 Ben Konrath <ben@bagu.org>
1268 Add latest mockup with HTML tables.
1270 Features of this mockup:
1272 -> HTML table for flowtable
1273 -> HTML table for flowtable column
1274 -> Example of how related lists would look
1275 -> Not using text entries for data items
1277 The current version of Online Glom doesn't use HTML tables for the
1280 This mockup has been sent to the glom-devel mailing list but it's good
1281 to have it here as well.
1283 * mockups/details-view-html-tables.html:
1285 2011-12-05 Ben Konrath <ben@bagu.org>
1287 Remove unnecessary getPrimaryKeyField() method.
1289 getPrimaryKeyFieldForTable(String) has been renamed to
1290 getPrimaryKeyField(String).
1292 * src/main/java/org/glom/web/server/database/DBAccess.java:
1293 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1294 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1296 2011-12-05 Ben Konrath <ben@bagu.org>
1298 Add string representation of TypedDataItem value to conversion error message.
1300 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1301 message was extracted into its own method to avoid duplication.
1303 2011-12-05 Ben Konrath <ben@bagu.org>
1305 Add type checking to navigation primary key value creation.
1307 Create navigation primary key only if the expected type from the Glom
1308 document matches the type returned by the SQL query.
1310 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1312 2011-12-05 Ben Konrath <ben@bagu.org>
1314 Rename a couple of variables in RelatedListNavigation.
1316 This is a rename-only refactor.
1318 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1320 2011-12-05 Ben Konrath <ben@bagu.org>
1322 Move getListLayoutGroup() into getListViewLayoutGroup().
1324 This removes getListLayoutGroup(). It was only being called by
1325 getListViewLayoutGroup().
1327 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1329 2011-12-05 Ben Konrath <ben@bagu.org>
1331 Remove check for LayoutItem_Portal in list table method.
1333 This check is no longer necessary because the method isn't being used
1334 to create the LayoutItemPortal DTO.
1336 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1338 2011-12-05 Ben Konrath <ben@bagu.org>
1340 Properly support related list navigation.
1342 Navigation from the "Repository Analyzer -> Package Scans ->
1343 Dependencies" related table wasn't working because the primary key for
1344 related tables wasn't being set properly. This commit fixes the
1347 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1348 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1349 doesn't set the primary key properly for related list tables.
1350 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1351 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1352 useful for getting the primary key for list view tables and for related
1354 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1355 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1356 Move code to set the primary key for the table from the abstract
1357 ListDBAccess class to ListViewDBAccess as it's only correct for list
1359 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1360 Properly add primary key to related list tables.
1362 2011-12-02 Ben Konrath <ben@bagu.org>
1364 Properly set the horizontal alignment of fields.
1366 This fix is for both the list tables and the details view.
1368 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1369 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1370 to set the horizontal alignment of fields.
1372 2011-12-02 Ben Konrath <ben@bagu.org>
1374 Display currency codes in the details view.
1376 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1378 2011-12-02 Ben Konrath <ben@bagu.org>
1380 Avoid duplicate JNI call.
1382 JNI is not as efficient as pure Java and this is an easy (and small)
1385 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1386 Use previously retrieved value for whereClauseToTableName instead of
1389 2011-12-02 Ben Konrath <ben@bagu.org>
1391 Rename a couple of variables in RelatedListNavigation.
1393 This is a rename-only refactor.
1395 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1397 2011-12-02 Ben Konrath <ben@bagu.org>
1399 Indicate clearly that a mismatched primary key type is a bug.
1401 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1402 warning to error. Add 'This is a bug.' to message.
1404 2011-12-02 Ben Konrath <ben@bagu.org>
1406 Update / fix some comments.
1408 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1410 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1412 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1413 Fix comments. Add some TODOs.
1415 2011-12-02 Ben Konrath <ben@bagu.org>
1417 Enable navigation to details view with string primary key from related list.
1419 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1420 Create a text primary key value when return type of result is
1421 java.sql.Types.VARCHAR.
1423 2011-12-02 Ben Konrath <ben@bagu.org>
1425 Use checkboxes for booleans in the details view.
1427 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1429 2011-12-01 Ben Konrath <ben@bagu.org>
1431 Improve performance of related list height calculation.
1433 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1434 Put code to calculate the expected height in a static initializer so
1435 that that it's only called once.
1437 2011-12-01 Ben Konrath <ben@bagu.org>
1439 Show related list tables in notebooks (again).
1441 Calculate the height of the related list tables so the Notebook can be
1442 set the correct height. The height of the related list table is also needed by
1443 FlowTable to be able decide how to create the layout.
1445 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1446 and set the Portal height based on the height of the related list
1447 table and the Portal container.
1448 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1449 Add method to calculate the height of the related list tables.
1450 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1451 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1452 calculate the height of the Pager widget.
1454 2011-12-01 Ben Konrath <ben@bagu.org>
1456 Use CellTable API for table property instead of setting style on Element.
1458 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1460 2011-12-01 Ben Konrath <ben@bagu.org>
1462 Make ListViewTable and RelatedListTable a consistent height.
1464 The tables are now a consistent height regardless of the contents of
1465 the table. A hidden button is added to empty rows to ensure that the
1466 height of these rows will match the height of rows with data.
1468 A navigation button column is now added to every table. The width of
1469 the navigation column is set to 0px when a RelatedListTable shouldn't
1470 have navigation buttons. This maintains the a consistent row height in
1471 tables that don't show the navigation buttons.
1473 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1474 navigation column when not needed.
1475 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1476 arguments for navigation button to constructor of ListViewTable.
1477 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1478 hidden button for empty data rows.
1479 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1480 arguments for navigation button to constructor.
1481 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1482 create navigation buttons. Add hideNavigationButtons() method.
1483 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1484 arguments for navigation button to constructor.
1486 2011-12-01 Ben Konrath <ben@bagu.org>
1488 Use 'visibility: hidden' in Utils.getWidgetHeight().
1490 This is better choice because hidden elements are invisible, don't
1491 respond to events and are not part of the tab order. They will,
1492 however, take up space which is required to be able to calculate the
1493 height of the widget.
1495 * src/main/java/org/glom/web/client/Utils.java:
1497 2011-12-01 Ben Konrath <ben@bagu.org>
1499 Use Utils.getWidgetHeight() in FlowTable.
1501 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1503 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1505 2011-12-01 Ben Konrath <ben@bagu.org>
1507 Put the details css class name on the correct table column.
1509 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1511 2011-11-30 Ben Konrath <ben@bagu.org>
1513 Update for java-libglom API change.
1515 The getters and setters on FieldFormatting and NumericFormat were
1516 changed to remove the 'M'.
1518 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1520 2011-11-29 Ben Konrath <ben@bagu.org>
1522 Only allow RelatedListTables in Portals.
1524 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1526 2011-11-29 Ben Konrath <ben@bagu.org>
1528 Only create a contents panel for Portals when title is being set.
1530 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1532 2011-11-29 Ben Konrath <ben@bagu.org>
1534 Set TabLayoutPanel height based on calculated height its widgets.
1536 This is a potential fix for this bug:
1538 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1540 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1542 2011-11-29 Ben Konrath <ben@bagu.org>
1544 Align details field labels and data with the Open buttons.
1546 * src/main/webapp/style.css:
1548 2011-11-29 Ben Konrath <ben@bagu.org>
1550 Remove unnecessary <div> in the Notebook widget.
1552 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1553 method to get container FlowPanel (<div>).
1554 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1555 initWidget() method directly on the TabLayoutPanel widget instead of
1556 Group's container widget.
1558 2011-11-29 Ben Konrath <ben@bagu.org>
1560 Don't add group titles for Portals in Notebooks.
1562 This reverts the previous patch and fixes a bug I introduced with
1563 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1565 * src/main/java/org/glom/web/client/ui/details/Group.java:
1566 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1568 2011-11-28 Ben Konrath <ben@bagu.org>
1570 Remove unused boolean argument in Portal constructor.
1572 Just a code cleanup.
1574 * src/main/java/org/glom/web/client/ui/details/Group.java:
1575 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1577 2011-11-28 Ben Konrath <ben@bagu.org>
1579 Remove hack for glom 1.18 style glom files.
1581 * src/main/java/org/glom/web/client/ui/details/Group.java:
1582 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1583 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1585 2011-11-28 Ben Konrath <ben@bagu.org>
1587 Use Gda Value version of primary key to log result too large error.
1589 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1591 2011-11-28 Ben Konrath <ben@bagu.org>
1593 Don't use TypedDataItem.getText() for Unknown types from the URL.
1595 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1596 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1597 instead of getText().
1598 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1599 String field and getUnknown() method.
1601 2011-11-28 Ben Konrath <ben@bagu.org>
1603 Log an error message when the java-libglom .so is not present.
1605 The error message was being set in the exception but not logged.
1607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1609 2011-11-28 Ben Konrath <ben@bagu.org>
1611 Ignore LayoutItem_CalendarPortals.
1613 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1614 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1616 2011-11-28 Ben Konrath <ben@bagu.org>
1618 Extract method for creating the LayoutItemPortal DTO.
1620 Just breaking the code up into smaller chunks.
1622 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1624 2011-11-28 Ben Konrath <ben@bagu.org>
1628 This should have been added with the refactor. Oops!
1630 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1632 2011-11-28 Ben Konrath <ben@bagu.org>
1634 Create primary key value from URL string using type from Glom document.
1636 See this bug, comments 19 - 25:
1638 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1640 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1641 create a TypeDataItem for the primary key here when loading from a
1642 URL. Show the same string for the primary key value as was received
1643 from the URL string (when loading from a URL).
1644 * src/main/java/org/glom/web/server/Utils.java: Update method for
1645 creating the Gda Value from the TypeDataItem to properly deal with
1646 creating a Gda Value based on the Glom document type for the primary
1647 key value string when loading from a URL.
1648 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1649 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1650 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1651 Update for changed method name.
1653 2011-11-27 Ben Konrath <ben@bagu.org>
1655 Rename PrimaryKeyItem to TypedDataItem.
1657 The name PrimaryKeyItem suggests what the class should be used for.
1658 TypedDataItem is a neutral name that describes the class better.
1660 This is a rename-only refactor.
1662 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1663 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1664 * src/main/java/org/glom/web/client/Utils.java:
1665 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1666 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1667 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1668 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1669 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1670 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1671 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1672 * src/main/java/org/glom/web/server/Utils.java:
1673 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1674 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1675 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1676 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1678 2011-11-25 Ben Konrath <ben@bagu.org>
1680 Improve Gda Value conversion from PrimaryKeyItem.
1682 The value from the PrimaryKeyItem is only used if its type match the
1683 type from the glom document.
1685 * src/main/java/org/glom/web/server/Utils.java:
1687 2011-11-25 Ben Konrath <ben@bagu.org>
1689 Manually check if the java-liblgom .so is visible to the JVM.
1691 It seems that Tomcat has problems when a static initializer throws an
1692 exception. This check is done before the first method call into
1693 java-libglom so that execution doesn't continue if the .so is not
1696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1698 2011-11-25 Ben Konrath <ben@bagu.org>
1700 Improve browser configuration error messages.
1704 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1706 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1707 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1708 getConfigurationErrorMessage() method.
1709 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1710 Get and display a specific configuration error message when no Glom
1711 documents are found.
1712 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1713 Implement getConfigurationErrorMessage() method. Surround configuration
1714 code in the init() method with a try/catch block. This allows the
1715 errors to be caught while keeping the servlet available to retrieve the
1716 configuration error message.
1718 2011-11-25 Ben Konrath <ben@bagu.org>
1720 Don't use Strings to hold primary key values.
1722 The primary key values are now held in a new data object
1723 (PrimaryKeyItem) that holds type information and the primary key value
1724 using the correct type.
1726 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1727 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1728 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1729 PrimaryKeyItem instead of String to hold the primary key value.
1730 * src/main/java/org/glom/web/client/Utils.java: Remove
1731 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1732 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1733 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1734 PrimaryKeyItem instead of String to hold the primary key value. Load
1735 document selection page when the documentID has not been set correctly.
1736 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1737 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1739 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1740 Return empty string for URL instead of "null".
1741 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1742 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1743 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1744 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1745 PrimaryKeyItem instead of String to hold primary key values.
1746 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1747 PrimaryKeyValue to a Gda Value.
1748 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1749 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1750 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1751 Replace temporary database access code that uses the PrimaryKeyValue to
1752 Gda Value conversion.
1753 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1754 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1755 PrimaryKeyItem instead of String.
1756 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1757 hold primary key values.
1759 2011-11-24 Ben Konrath <ben@bagu.org>
1761 Use newly added java-libglom API to create queries.
1763 This isn't finished. I still need to stop using Strings for primary key
1764 values in the client code.
1766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1767 libglom to use fake connections so that retrieving the query string will
1769 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1770 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1771 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1772 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1773 Use the newly added libglom sql methods and classes to create the
1774 query. Add temporary hack to convert primary value strings to Gda
1777 2011-11-23 Ben Konrath <ben@bagu.org>
1779 Don't explicitly set the height of Portals.
1781 See comments 6 - 10 of this bug for details:
1783 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1785 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1787 2011-11-23 Ben Konrath <ben@bagu.org>
1789 Use an HTML table instead of CSS for the FlowTable layout.
1791 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1792 GWT's FlexTable to implement the FlowTable.
1793 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1795 2011-11-18 Ben Konrath <ben@bagu.org>
1797 Add boolean example to HTML table mockup.
1799 * mockups/details-view-html-tables-text-entries.html:
1801 2011-11-17 Ben Konrath <ben@bagu.org>
1803 Ensure the pager buttons are always visible for related lists.
1805 To accomplish this, I've turned off text wrapping in the list view and
1806 related list tables for both the header and data text. The related list
1807 table now has a fixed layout so the it doesn't overflow its container.
1808 This is required to ensure that the cell text is clipped when it
1809 overflows the cell and an ellipsis is added to the right side of the
1810 cell when text is clipped.
1812 A fixed table layout for the related list table in the details view
1813 seems what we want for the details view anyway, so the side-effect is
1816 The ellipsis will only be displayed in Firefox >= 7.
1820 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1822 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1823 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1824 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1826 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1827 Set the 'table-layout: fixed' CSS property to the related list table.
1828 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1829 'white-space: nowrap;' CSS property on both the list view and the
1830 related list tables.
1832 2011-11-16 Ben Konrath <ben@bagu.org>
1834 Rework the fix for empty notebook tab labels.
1836 Setting the empty group titles with its name caused problems for the
1837 details layout. Instead of using libglom's
1838 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1839 to the client when the title is empty. This allows the Notebook to use
1840 the name when the title is empty without affecting anything else.
1842 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1843 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1845 2011-11-16 Ben Konrath <ben@bagu.org>
1847 Set group titles with name when title is empty.
1849 This fixes a problem with an empty notebook tab label in the Lesson
1850 Planner document. The forth tab in the notebook should be "Internet":
1852 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1854 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1855 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1858 2011-11-16 Ben Konrath <ben@bagu.org>
1860 Remove whitespace from the configured username properties.
1862 This assumes that usernames won't have whitespace at the beginning
1863 or end. But I think this is a reasonable assumption.
1865 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1866 String.trim() to remove the whitespace from the username properties.
1868 2011-11-15 Ben Konrath <ben@bagu.org>
1870 Add details view mockup with HTML tables and text entries.
1872 This is from the attachment on this bug:
1874 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1876 * mockups/details-view-html-tables-text-entries.html:
1878 2011-11-15 Ben Konrath <ben@bagu.org>
1880 Add space between the columns of the flow table.
1884 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1886 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1887 space between columns in the flow table.
1889 2011-11-15 Ben Konrath <ben@bagu.org>
1891 Add backup files to the .gitignore.
1893 * .gitignore: Ignore files that end with ~.
1895 2011-11-09 Ben Konrath <ben@bagu.org>
1897 Use latest release of gwt-log.
1899 Gwt-log releases are now being submitted to the maven central
1900 repository so manual installation of the jar is no longer required.
1902 * pom.xml: Update version and groupId of gwt-log dependency.
1904 2011-10-31 Ben Konrath <ben@bagu.org>
1906 Don't use GWT numeric formatting to override the glom currency formatting.
1908 Currencies are now displayed like they are in Glom. See this bug:
1910 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1912 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1914 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1915 currency code to constructor and set it when the cell is rendered.
1916 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1917 currency code to the constructor of the NumericCell.
1919 2011-10-27 Ben Konrath <ben@bagu.org>
1921 Require the latest release of java-libglom (1.17.4).
1925 2011-10-26 Ben Konrath <ben@bagu.org>
1927 Add style to Notebook that matches current theme.
1929 It's not the best style in the world but it's better than the default.
1931 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1932 padding at the bottom of the child widgets.
1933 * src/main/webapp/style.css: Add style for the Notebook.
1935 2011-10-26 Ben Konrath <ben@bagu.org>
1937 Move servlet initialization code to overridden init method.
1939 This is half of the solution to getting proper error messages
1940 displayed when configuration errors occur. Here's the relevant bug:
1942 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1944 The rest of the solution involves surrounding the init method with a
1945 try/catch block and setting a global variable with the error /
1946 exception. A new async method should be created to retrieve and display
1947 the error message / exception.
1949 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1950 code from constructor to init method adding exceptions as needed.
1952 2011-10-26 Ben Konrath <ben@bagu.org>
1954 Add script to monitor and restart tomcat if required.
1956 * utils/check-and-recover-tomcat.py: New file.
1958 2011-10-26 Ben Konrath <ben@bagu.org>
1960 Display the correct number of data items in the pager.
1964 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1966 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1967 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1968 The implementation is the same for both tables: Keep track of the
1969 number of non-empty rows and fire and RowCountChangeEvent after the data has
1971 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1972 custom Pager class that subclasses SimplePager to handle displaying
1973 the correct number when empty rows have been added.
1975 2011-10-26 Ben Konrath <ben@bagu.org>
1977 Correct error in previous commit.
1979 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1980 eventBus parameter from listView.setCellTable().
1982 2011-10-26 Ben Konrath <ben@bagu.org>
1984 Fix error in TODO comment.
1986 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1988 2011-10-24 Ben Konrath <ben@bagu.org>
1990 Create Notebook widgets to the details view.
1992 This isn't finished just yet - I still need to create a reasonable
1993 style to match the current theme.
1995 * src/main/java/org/glom/web/client/Utils.java: Add method for
1996 calculating the height of a widget. This is used in the Notebook class.
1997 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1998 new constructor method in Group.
1999 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2000 method for creating child widget that can be used by subclasses
2001 like Notebook. New constructor that allows disabling the group
2002 titles - Notebooks don't set a group title for their child groups.
2003 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2004 to make Notebooks using GWT's TabLayoutPanel.
2005 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2006 constructor that allows disabling the group titles.
2007 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2008 LayoutItemNotebook DTO.
2009 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2010 DTO for Notebooks. It's just an empty class for now but we might need
2011 it to transfer some specific information in the future.
2013 2011-10-21 Ben Konrath <ben@bagu.org>
2015 Add navigation buttons to related list tables.
2017 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2018 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2020 method getSuitableRecordToViewDetails() for getting the table name
2021 and primary key value for related list navigation buttons.
2022 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2023 private cell renderer class to get the navigation information for
2024 related list tables from the server. Extract the navigation
2025 processing code from the details cell navigation and use it for the
2026 related list navigation as well.
2027 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2028 cell renderer class for the details open buttons. This was needed
2029 because the related list navigation buttons and the list view
2030 navigation buttons need to react differently when clicked.
2031 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2032 the onEnterKeyDown() method because it's now overriden in the
2033 subclasses that are specific to the related list tables and the list
2035 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2036 the vertical size a little because the buttons add a bit of vertical
2037 space to table. This is not a perfect solution because the vertical
2038 size of with table fewer than 5 rows will be a little smaller.
2039 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2040 changes in how navigation buttons are handled.
2041 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2042 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2043 database access object.
2044 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2045 to find the portal for a given relationship name from
2046 RelatedListDBAccess. Add method to find a primary key field for a
2048 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2049 Move code to find the portal for a given relationship name to
2051 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2052 New file: database access object for getting the related list
2053 navigation information (the table name and the primary key value).
2054 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2055 DTO for transferring a table name to navigate to and a primary key
2057 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2058 boolean and getter/setter to specifies if the related list should add
2061 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2063 Use the master branch of java-libglom
2065 * pom.xml: Depend on java-libglom 1.19 instead.
2067 This is the master branch. See also the libglom-1-18 branch.
2069 2011-10-11 Ben Konrath <ben@bagu.org>
2071 Enable the open navigation button when the data has been set.
2073 This avoids having active buttons that don't do anything when the data
2076 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2078 2011-10-11 Ben Konrath <ben@bagu.org>
2080 Use IsWidget interface for FlowTableItem.
2082 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2083 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2085 2011-10-11 Ben Konrath <ben@bagu.org>
2087 Remove GWT styling from open button in details view.
2089 There are still some issues with how the details cell is arranged but
2090 this should be made to match Glom 1.20. I'm going to leave fixing this
2091 until I have Glom 1.20 up and running.
2093 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2094 style name on open button.
2095 * src/main/webapp/style.css: Move and edit details-navigation class.
2096 Re-arrange some classes to make them appear in the same order as the
2099 2011-10-07 Ben Konrath <ben@bagu.org>
2101 Update to GWT 2.4.0.
2103 * .gitignore: Ignore new cache directory.
2104 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2105 * pom.xml: Change GWT and maven plugin to 2.4.0.
2106 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2108 * src/main/java/org/glom/web/client/ClientFactory.java:
2109 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2110 * src/main/java/org/glom/web/client/OnlineGlom.java:
2111 Update source for API changes.
2112 * utils/build-onlineglom-war.sh: Remove cache directory before the
2115 2011-10-07 Ben Konrath <ben@bagu.org>
2117 Add navigation buttons in the details view.
2119 This isn't finished but I thought I'd commit what I have as it's a
2120 pretty good start. I still need to:
2122 1. Change the style so that it fits better into the current theme
2123 2. Adjust the details cell to expand as much as possible.
2125 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2126 click handlers to navigation buttons in the DetailsCells. Create a
2127 refreshData() method to get just the data from the server without the
2129 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2130 Update the tableSelector and browser title when the table name
2131 changes without using the tableSelector.
2132 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2133 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2134 getDetailsCells() to getCells(). Update variable names.
2135 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2136 method to set click handler on navigation button. Rename a few
2137 variables. Add navigation buttons where needed.
2138 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2139 variables and methods.
2140 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2141 navigation boolean and navigation table as required in the
2142 LayoutItemField DTO.
2143 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2144 variables for navigation along with getter/setter methods.
2146 2011-10-07 Ben Konrath <ben@bagu.org>
2148 Rename Field to DetailsCell.
2150 This is a refactor-only commit. No functionality has been added or
2153 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2154 Update variable and method names.
2155 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2156 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2157 variable and method names.
2158 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2160 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2161 variable and method names.
2163 2011-10-07 Ben Konrath <ben@bagu.org>
2165 Create separate methods for layout and data the details view.
2167 This is a refactor-only commit. No functionality has been added or
2170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2171 private methods: setData(), createLayout().
2173 2011-10-07 Ben Konrath <ben@bagu.org>
2175 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2177 This is part of a change to get navigation buttons in the details view
2178 but it should have been done this way from the start.
2180 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2181 for method name change in TableSelectionView.
2182 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2183 Create TableChangeEvent and set the browser title using the
2184 TableSelectionView API.
2185 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2186 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2187 Change getSelectedTable() to getSelectedTableName(). Add
2188 getSelectedTableTitle().
2190 2011-10-07 Ben Konrath <ben@bagu.org>
2192 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2194 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2196 2011-10-07 Ben Konrath <ben@bagu.org>
2198 Update TableChangeEvent to use newTableName naming convention.
2200 This makes the class more consistent with GWT naming conventions.
2202 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2203 Update for method name change in TableChangeEvent.
2204 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2205 for method name change in TableChangeEvent.
2206 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2207 newTableName variable and getter method. Make toDebugString()
2210 2011-09-30 Ben Konrath <ben@bagu.org>
2212 Disable the pager in the list tables when the data row count is less than the minimum.
2214 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2215 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2217 2011-09-30 Ben Konrath <ben@bagu.org>
2219 Add empty rows to the end of related list and list view tables.
2221 I also extracted the cell rendering classes from the ListTable because
2222 the code was becoming a little crazy with all the anonymous inner
2223 classes. My plan is to use these cell rendering classes in the details
2224 view as well so this refactor will be needed for that change.
2226 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2227 set the row count in related list tables if the data has more rows
2228 than the minimum number of rows visible.
2229 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2230 row count in list view tables if the data has more rows than the
2231 minimum number of rows visible.
2232 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2233 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2235 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2236 for rendering TYPE_NUMERIC cells. The code was extracted from the
2238 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2239 class for rendering cells with buttons in list views. The code was
2240 extracted from the ListTable class.
2241 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2242 for rendering TYPE_TEXT cells. The code was extracted from the
2244 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2245 Add empty rows to the end of the data if required. Implement
2246 ListTable.getMinNumVisibleRows().
2247 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2248 cell renderer code to public classes. Return null in
2249 Column.getValue() for empty rows. Add new abstract method:
2250 getMinNumVisibleRows(). Move code to set the row count of the list view
2251 table to ListViewImpl.
2252 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2253 empty rows to the end of the data if required. Implement
2254 ListTable.getMinNumVisibleRows().
2257 2011-09-27 Ben Konrath <ben@bagu.org>
2259 Use GWT.log for client-side debugging statements.
2261 These are optimized out when deployed so I should have used this method
2262 in the first place. These statements will eventually be replaced with some sort
2263 of notification in the browser.
2265 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2266 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2267 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2268 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2269 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2271 2011-09-27 Ben Konrath <ben@bagu.org>
2273 Put tableselector on the right, back to list link on right.
2275 The idea is that the table selector is acting like a label for the
2276 currently displayed table so it should be placed below the document title. This
2277 puts the table title in a similar position to where it is in Glom.
2279 * mockups/details-contacts.html:
2280 * mockups/details-projects.html:
2281 * mockups/listview-contacts.html:
2282 * mockups/listview-projects.html:
2283 * mockups/style.css:
2284 Update mockups to match how the interfaces currently look.
2285 * src/main/webapp/style.css: Swap positions of backlink with the table
2286 selector. Add some space on the left side of the table selector to
2287 line things up with the document title.
2289 2011-09-27 Ben Konrath <ben@bagu.org>
2291 Add field colouring to details view.
2293 This change re-works how field colouring works. The colour formatting
2294 information is now set to the client with the layout information instead of
2295 with the data. This eliminates the need to send the same colour strings for
2296 data in list view column when colour information is set.
2298 In order to set an alternate colour for negative numeric values, the
2299 number is now sent to client and formatted with the GWT NumberFormat class.
2301 This change also fixes:
2303 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2305 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2306 internationalization framework which is needed for client side numeric
2308 * src/main/java/org/glom/web/client/Utils.java: New file for some
2309 client static utility methods.
2310 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2311 the DataItem object to the Field class. Use a utility method to
2312 create the foreignKeyValue string.
2313 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2314 alignment and text colours in the constructor. Add setData(DataItem)
2315 method. Remove setText(String) method.
2316 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2317 colour information to GlomTextCell. Create and use GlomNumberCell for
2318 rendering numbers. Use utility method to get the string for the
2319 primary key of the key provider. Re-work how the horizontal alignment
2321 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2322 formatting to layout information. Methods for converting the libglom
2323 formatting information were moved from DBAccess.
2324 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2325 numeric formatting (it's now done on the client side). Don't set text
2326 colours in DataItem. Move libglom formatting conversion methods to
2328 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2329 getters/setters for text colour information.
2330 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2331 for transferring the libglom NumericFormat information to the client.
2332 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2333 and getters/setters for: GlomNumericFormat, background colour and
2334 foreground colour strings.
2336 2011-09-26 Ben Konrath <ben@bagu.org>
2338 Simplify code that iterates through the LayoutGroup.
2340 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2342 2011-09-26 Ben Konrath <ben@bagu.org>
2344 Accept Eclipse formatting for OnlineGlomServiceAsync.
2346 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2348 2011-09-26 Ben Konrath <ben@bagu.org>
2350 Don't use the ListDBAccess classes to get the primary key layout information.
2352 This was causing a bug where the wrong index for the hidden primary key
2353 was being sent to the client.
2355 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2356 primary key while creating the LayoutGroup DTO. Create a
2357 LayoutItemField DTO for hidden primary keys. Don't use the
2358 RelatedListDBAccess because it was only used for getting the primary
2360 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2361 access modifier from public to protected for getPrimaryKeyField() and
2362 getPrimaryKeyLayoutItemField().
2363 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2364 abstract method getExpectedResultSize() because RelatedListDBAccess
2365 doesn't have enough info to implement it.
2366 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2367 Remove @Override for getExpectedResultSize().
2368 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2369 Remove method getExpectedResultSize().
2371 2011-09-23 Ben Konrath <ben@bagu.org>
2373 Log which layout (list or details) the ignored item is from.
2375 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2377 2011-09-23 Ben Konrath <ben@bagu.org>
2379 Remove annotations that turn off code formatting in DataItem.
2381 * src/main/java/org/glom/web/shared/DataItem.java:
2383 2011-09-23 Ben Konrath <ben@bagu.org>
2385 Rename GlomField to DataItem and update associated methods.
2387 This is a rename-only refactor. No functionality has been added or
2390 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2391 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2393 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2394 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2395 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2396 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2397 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2398 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2399 * src/main/java/org/glom/web/server/database/DBAccess.java:
2400 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2401 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2402 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2403 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2404 * src/main/java/org/glom/web/shared/DataItem.java:
2405 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2406 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2408 2011-09-23 Ben Konrath <ben@bagu.org>
2410 Rename GlomDocument to DocumentInfo and update associated methods.
2412 This is a rename-only refactor. No functionality has been added or
2415 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2416 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2417 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2418 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2419 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2420 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2421 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2423 2011-09-20 Ben Konrath <ben@bagu.org>
2425 Require java-libglom 1.17.3.
2427 This picks up the fix for the seg fault problem with the Scenes table
2428 in the Openismus Film Manager example.
2432 2011-09-20 Ben Konrath <ben@bagu.org>
2434 Change the way sort clause is added for primary key when no sort clause is requested.
2436 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2437 before the sort clause is created. When a sort clause is not requested, the
2438 sort clause is created by finding the primary key in the LayoutFieldVector
2441 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2443 2011-09-20 Ben Konrath <ben@bagu.org>
2445 Log error message if no documents are found in the configured directory.
2447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2448 Extract the glom file extension string to a private static final class
2449 variable (mostly as syntactic sugar). Accept a minor formatting change.
2450 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2451 the example glom.document.directory configuration property to make it
2452 more clear that it can any directory, not just the home directory.
2454 2011-09-18 Ben Konrath <ben@bagu.org>
2456 Add related lists to details view.
2458 The related list table has support for paging and sorting just like the
2459 table in the list view.
2461 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2462 SQL queries for the related list tables.
2463 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2464 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2465 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2466 Rename getList methods to getListView and add comments. Remove
2467 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2468 it being unused. Add methods: getDetailsLayoutAndData(),
2469 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2470 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2471 Create the layout and set the data for the fields in one async call
2472 instead of two. Create related lists where appropriate.
2473 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2474 for method name changes in OnlineGlomService.
2475 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2476 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2477 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2479 * src/main/java/org/glom/web/client/ui/ListView.java:
2480 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2481 tableName from setCellTable(). Create a ListViewTable instead of
2483 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2484 represent a data field in the details view.
2485 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2486 from addDetailsCell() to Field class. Keep track of the Fields and
2487 Portals in the details view.
2488 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2489 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2490 and add a method to get it. Add method to set the contents of the
2492 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2493 New class for related list tables. This class has the data provider
2494 for the related list table.
2495 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2496 abstract class which is the base class for the ListViewTable and the
2498 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2499 New class for list view tables. This class has the data provider for
2500 the list view table.
2501 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2502 methods for related list tables. Add more information to the
2503 LayoutItemField and LayoutItemPortal DTOs.
2504 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2505 Remove debugging print statement.
2506 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2507 Remove debugging print statements. Add primary key field to SQL count
2509 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2510 Remove unnecessary LayoutFieldVector parameter from
2511 getResultSizeOfSQLQuery() method.
2512 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2513 New class for related list table database access.
2514 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2515 class that is a wrapper DTO for details view layout and data.
2516 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2517 new 'fromField' string to this DTO.
2518 * src/main/webapp/style.css: Remove bottom margin and override top
2521 2011-09-15 Ben Konrath <ben@bagu.org>
2523 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2525 This sets things up to make it easier to add the data retrieval for
2526 related lists (portals). No user noticeable changes were made with
2529 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2530 class has the code to retrieve the layouts and access the
2531 database using the new database helper classes.
2532 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2533 Most of the functionality has been removed from this class. This
2534 class now represents the public interface for the client side
2535 code. It also deals with configuring the servlet and cleaning
2536 things up when the servlet is stopped.
2537 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2538 of static methods into this utility class.
2539 * src/main/java/org/glom/web/server/database/DBAccess.java:
2540 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2541 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2542 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2543 These classes have the database retrieval code. The class hierarchy
2544 has been setup to make it easy to reuse code for similar
2547 2011-09-06 Ben Konrath <ben@bagu.org>
2549 Create separate classes for list table code and the data provider.
2551 As part of this refactor, I also split up the code a bit to make it
2554 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2555 table code to two new classes (below).
2556 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2557 with code from ListViewImpl.
2558 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2559 New file with code from ListViewImpl.
2561 2011-09-06 Ben Konrath <ben@bagu.org>
2563 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2565 This fixes the LayoutItemPortal DTO to match the libglom layout object
2568 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2570 2011-09-01 Ben Konrath <ben@bagu.org>
2572 Set title of Portals in the Details View.
2574 * pom.xml: Bump required version of java-libglom to 1.17.1.
2575 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2576 widget creation to its own class. Add comments to constructor.
2577 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2578 The code is mostly from the Group class with the title now set.
2579 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2580 title of Portal. Update some comments. Fix some code formatting.
2582 2011-09-01 Ben Konrath <ben@bagu.org>
2584 Remove TODO comment for the flow table column width.
2586 The flow table column width is working correctly and doesn't need to be
2587 changed. See this mailing list post for more info:
2589 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2591 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2593 2011-08-27 Ben Konrath <ben@bagu.org>
2595 Add document title (database name) to top of the browser page.
2597 I added the document title to the TableSelecitonView but that will
2598 change if / when we add a view that doesn't require table selection.
2600 * mockups/details-contacts.html:
2601 * mockups/details-projects.html:
2602 * mockups/listview-contacts.html:
2603 * mockups/listview-projects.html:
2604 * mockups/style.css: Add document title to mockups to keep things
2606 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2607 sizes to account for the document title.
2608 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2609 Set the document title when it has been retrieved from the server.
2610 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2611 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2612 and implement setDocumentTitle(String) method.
2613 * src/main/webapp/style.css: Add ID for document title style.
2615 2011-08-25 Ben Konrath <ben@bagu.org>
2617 Add NavigationType enum to LayoutItemPortal DTO.
2619 This is the start of adding support for Portals to the Details View.
2621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2622 LayoutItem_Portal.navigation_type enum from libglom to
2623 LayoutItemPortal.NavigationType enum.
2624 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2625 NavigationType enum, field for storing the NavigationType and getter
2628 2011-08-25 Ben Konrath <ben@bagu.org>
2630 Implement the flow table layout in the Details View.
2632 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2633 FlowTable to Group to account for the renamed class.
2634 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2635 File. This is a container widget that implements the Glom details view
2636 flow table behaviour.
2637 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2638 org/glom/web/client/ui/FlowTable.java.
2639 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2640 so that the size of the subgroups are a closer match to the size of
2641 the Glom subgroups. This makes the flowtable layout match the layout
2642 in Glom for the Music Collection example file.
2644 2011-08-16 Ben Konrath <ben@bagu.org>
2646 Create container element for LayoutItemPortal in Details View.
2648 This will help me develop the layout for the FlowTable.
2650 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2651 fieldPanel variable to detailsCell.
2653 2011-08-15 Ben Konrath <ben@bagu.org>
2655 Set the height of the data element in the Details View.
2657 I changed the InlineLabels (text in a span element) to Labels (text in
2658 a div element) so that I could set the height of the details-data
2659 elements instead of the details-cell parent elements. This allows the
2660 the details-data element to display the correct height if style is
2661 applied that shows the height.
2663 This change has the added benefit of allowing the order of the labels
2664 and data elements to be changed for right-to-left languages.
2666 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2667 InlineLabels to Labels.
2668 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2669 InlineLabels to Labels. Set the height of the data element.
2670 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2671 multiline text height in the Formatting DTO.
2672 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2673 for multiline height along with getter and setter methods.
2674 * src/main/webapp/style.css: Adjust style to account for the change
2675 from span elements to div elements in the details cell.
2677 2011-08-15 Ben Konrath <ben@bagu.org>
2679 Make the List View appearance match the mockups.
2681 It doesn't match exactly but it's much better than it was.
2683 * mockups/listview-contacts.html: Remove unused css classes.
2684 * mockups/listview-projects.html: Remove unused css classes.
2685 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2686 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2687 for mainPanel instead of VerticalPanel (table). Set style name on
2688 CellTable. Set style name on Details column. Right-align Details
2690 * src/main/webapp/style.css: Adjust properties to match the mockups.
2692 2011-08-12 Ben Konrath <ben@bagu.org>
2694 Add better support for subgroups in the details view.
2696 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2697 changed FlowTable constructor.
2698 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2699 support for subgroups and subgroup-titles.
2700 * src/main/webapp/style.css: Add CSS class for subgroups and
2703 2011-08-12 Ben Konrath <ben@bagu.org>
2705 Return the top level LayoutGroup title.
2707 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2709 2011-08-11 Ben Konrath <ben@bagu.org>
2711 Make the TableSelector header match the mockup.
2713 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2714 the layout panel. Properly lineup the table selection header with
2715 the list and details view.
2716 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2717 margin around the details view.
2718 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2719 Rename listBox variable to tableSelector. Set id for the style sheet.
2720 Use a FlowPanel instead of a HorizontalPanel.
2721 * src/main/webapp/style.css: Add properties to make the TableSelector
2722 box match the mockups.
2724 2011-07-13 Ben Konrath <ben@bagu.org>
2726 Update install script for java-libglom version change.
2728 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2731 2011-07-13 Ben Konrath <ben@bagu.org>
2733 Add support sub-group in the details view.
2735 I also removed the code that special-cased the default details view
2738 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2740 I still have to make a proper flowtable.
2742 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2743 Don't special-case default details view layout.
2744 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2745 addLayoutField() as I'm going to use it.
2746 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2747 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2749 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2750 extracted from DetailsViewImpl.GroupPanel. Add support for
2752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2753 column count when getting the details layout.
2755 2011-07-12 Ben Konrath <ben@bagu.org>
2757 Set browser title with database and table titles.
2759 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2760 Set the browser title when the table changes and when the activity
2762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2763 title when retrieving document info (the GlomDocument object).
2764 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2765 with getter and setter methods. Remove unused convenience constructor.
2766 Use default code formatting.
2768 2011-07-12 Ben Konrath <ben@bagu.org>
2770 Ignore LayoutItemPortals in the details view.
2772 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2775 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2776 LayoutItemPortal layout objects.
2777 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2778 LayoutItemPortal objects when retrieving the details layout.
2779 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2780 file. This is an empty class and just used to get type information for
2783 2011-07-12 Ben Konrath <ben@bagu.org>
2785 Use java-libglom 1.17.0.
2789 2011-07-11 Ben Konrath <ben@bagu.org>
2791 Remove "Table:" label from table selector.
2793 This matches a recent change in the Glom UI.
2795 * mockups/details-contacts.html:
2796 * mockups/details-projects.html:
2797 * mockups/listview-contacts.html:
2798 * mockups/listview-projects.html: Remove the "Table:" label from the
2800 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2802 2011-07-11 Ben Konrath <ben@bagu.org>
2804 Add main groups to the details view.
2806 This makes things look a little nicer in the details view. The next step
2807 is to implement the flowtable.
2809 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2810 resources from the standard gwt css theme. Standard.css is now
2811 included in OnlineGlom.html so that the online glom css rules have
2812 precedence over the gwt theme.
2813 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2814 the whole LayoutGroup to the DetailsView instead of just the titles.
2815 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2816 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2817 details layout with a helper class (GroupPanel). I might extract this
2818 class when I make the full flowtable.
2819 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2820 string as default so I don't have to worry about NPEs when processing
2822 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2823 note beside OnlineGlom.gwt.xml above).
2824 * src/main/webapp/style.css: Add default font-size to body to override
2825 the font-size set by the standard theme. Don't use h2 tags for
2826 group-title. Create new details-cell class.
2828 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2830 ConfiguredDocument: Set the port number too.
2832 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2833 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2834 Glom document. Presumably this worked sometimes so far because there is a
2835 default port number.
2837 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2839 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2841 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2842 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2843 correct, though we should throw an exception too.
2845 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2847 Fix a addDocuemnt typo.
2849 * src/main/java/org/glom/web/shared/Documents.java
2850 (Documents.addDocuemnt): Rename to addDocument().
2851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2852 (OnlineGlomServiceImpl.getDocuments): Adapt.
2854 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2856 Slightly improved log output when connection fails.
2858 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2859 (ConfiguredDocument.setUsernameAndPassword):
2860 We don't know for sure if it' the username/password that's wrong, so
2861 rephrase the message.
2862 Also ouput the exception message, though it's generic in this case.
2864 2011-07-08 Ben Konrath <ben@bagu.org>
2868 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2869 added braces to a one line if statement because the Eclipse formatter
2870 was getting confused.
2872 2011-07-07 Ben Konrath <ben@bagu.org>
2874 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2876 These should really be two separate tasks but I counldn't get things to
2877 work with GWT 2.2.0 and Eclipse 3.7.
2881 * .settings/org.eclipse.jdt.core.prefs:
2882 * .settings/org.eclipse.jdt.ui.prefs:
2883 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2884 * .settings/org.eclipse.m2e.core.prefs:
2885 Add new config files. Update current files. Remove references to the
2886 webtools plugins as we're not using any of the webtools features.
2887 * .gitignore: Add logs directory which is created when running with
2889 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2890 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2891 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2893 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2895 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2897 onlineglom.properties: Add explanatory comments.
2899 * src/main/resources/onlineglom.properties: Also change the default user
2900 from ben to someuser, to avoid the risk of people thinking we just
2901 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2903 2011-06-28 Ben Konrath <ben@bagu.org>
2905 Use filename in Log for incorrect passwords.
2907 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2908 getFileName(String) method to get the filename from the URI.
2910 2011-06-28 Ben Konrath <ben@bagu.org>
2912 Add the table name to the URL token for the ListPlace.
2914 This makes things consistent between the DetailsPlace and the
2915 ListPlace. It also allows the the ListPlace to be bookmarked.
2917 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2918 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2919 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2920 Remove getDefaultListLayout(). The default layout is now returned
2921 by the getListLayout() method when the table name is an empty string.
2922 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2923 Add table name field. Change to a new ListPlace when the table
2924 has been changed. Use getListLayout() for getting the default
2926 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2927 Add table name field. Set the correct table name in the list box
2928 when loading from bookmark. This corrects a problem for the
2930 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2931 Move table name to super-class (HasSelectableTable). Move document
2932 and table URL keys to super-class in HasSelectableTable.
2933 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2934 Add table name field. Add Tokenizer class with URL key common to
2935 the subclasses (DetailsPlace and ListPlace).
2936 * src/main/java/org/glom/web/client/place/ListPlace.java:
2937 Add table name. Add code to parse the URL token.
2938 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2939 Update ListPlace construction with empty table name string.
2940 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2941 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2942 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2943 Update ListPlace construction with table name string.
2944 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2945 Change defaultTableName field to tableName to reflect how it's now
2946 used. Update the getter and setter methods.
2948 2011-06-28 Ben Konrath <ben@bagu.org>
2950 Enable the table selector in the DetailsView.
2952 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2953 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2955 Remove getDefaultDetailsLayout(). The default layout is now returned
2956 by the getDetailsLayout() method when the table name is an empty
2958 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2959 event handler for table change event. Change to using
2960 getDetailsLayout() for the default details layout.
2961 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2963 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2964 when navigating to the details place.
2966 2011-06-27 Ben Konrath <ben@bagu.org>
2968 Use filename based unique document ID in URL and for RPC.
2970 The document ID is the glom document name with spaces (' ') replaced
2971 with pluses ('+') and without the .glom extension.
2973 This change is mostly a string substitution of 'documentTitle' for
2974 'documentID'. The only code change is the addition of a Documents DTO to get the
2975 filename to document title mappings as indicated below.
2977 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2978 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2979 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2980 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2981 Use Documents DTO to create the document links in the document
2983 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2984 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2985 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2986 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2987 * src/main/java/org/glom/web/client/place/ListPlace.java:
2988 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2989 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2990 * src/main/java/org/glom/web/client/ui/ListView.java:
2991 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2992 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2993 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2994 * src/main/java/org/glom/web/server/Log.java:
2995 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2996 getDocumentTitles() to getDocuments() and return the Documents DTO.
2997 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2998 transferring the filename to document title mappings.
3000 2011-06-25 Ben Konrath <ben@bagu.org>
3002 Make the authentication popup work again.
3004 This bug was introduced when I extracted ConfiguredDocument to its own class.
3006 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3007 correct success / fail status in setUsernameAndPassword().
3009 2011-06-25 Ben Konrath <ben@bagu.org>
3011 Use filename as unique key for configuring database usernames and passwords.
3013 This replaces the use of the Glom document title which could change
3014 depending on the locale. Thanks to Murray Cumming for pointing out this
3017 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3018 * src/main/resources/onlineglom.properties:
3020 2011-06-24 Ben Konrath <ben@bagu.org>
3022 Pass primary key value to DetailsView.
3024 This enables the DetailsView to load the correct data.
3026 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3027 primary key value field and set in constructor. Pass primary key
3028 value to getDetailsData().
3029 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3030 variables for document title and primary key value.
3031 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3032 key value to the DetailsPlace.
3034 2011-06-24 Ben Konrath <ben@bagu.org>
3036 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3038 This allows the primary key to be retrieved by the Details button. This
3039 functionality has not been implemented yet but it's in the works.
3041 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3042 the LayoutGroup result to ListView.setCellTable instead of all of its
3043 fields individually.
3044 * src/main/java/org/glom/web/client/ui/ListView.java:
3045 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3046 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3047 get the primary key for the table.
3048 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3049 index of the primary key in the LayoutGroup accounting for hidden
3050 primary keys. Rename getJavaNumberFormat() to
3051 convertToJavaNumberFormat() for consistency. Cleanup / add some
3053 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3054 field for primary key index and a field to indicate whether the
3055 primary key is hidden or not.
3057 2011-06-23 Ben Konrath <ben@bagu.org>
3059 Rename getTableData methods to getListData.
3061 This is a rename refactor for consistency with other methods.
3063 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3064 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3065 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3066 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3068 2011-06-23 Ben Konrath <ben@bagu.org>
3070 Extract the ConfiguredDocument innerclass into its own class.
3072 This makes the servlet code more object oriented.
3074 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3075 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3076 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3077 new ConfiguredDocument class.
3079 2011-06-21 Ben Konrath <ben@bagu.org>
3081 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3083 This makes things more inline with how libglom works and reduces code
3084 duplication. This refactor lays the groundwork for adding the primary key to
3085 the LayoutGroup object.
3087 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3088 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3089 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3090 Change method names to getListLayout and getDefaultListLayout for
3091 consistency. Use LayoutGroup as the DTO for the list layout instead of
3092 ColumnInfo and LayoutListTable.
3093 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3094 new method names along with the LayoutGroup object for transferring the
3096 * src/main/java/org/glom/web/client/ui/ListView.java:
3097 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3098 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3099 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3101 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3102 Replaced with LayoutGroup.
3103 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3104 expectedResultSize and defaultTableName fields which are needed for
3106 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3107 type field which is needed for the list layout but will also be
3108 useful for the details layout as things progress.
3109 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3110 Make class abstract. Remove the unnecessary
3111 getFormattingHorizontalAlignment method. Add setFormatting method.
3113 2011-06-16 Ben Konrath <ben@bagu.org>
3115 Add scripts for building and installing war.
3117 These will help when updating OnlineGlom but they're also good
3118 supplemental documentation of the build and deployment proceeding.
3120 * utils/build-onlineglom-war.sh: New file.
3121 * utils/install-onlineglom-war.sh: New file.
3123 2011-06-16 Ben Konrath <ben@bagu.org>
3125 Create wrapper class to create consistent log messages.
3127 I wrapped methods in the Log class of gwt-log to add the method names
3128 from the servlet and create consistent formatting of the document title
3129 and table names in the log messages.
3131 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3132 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3133 log methods to use methods from wrapped Log class.
3135 2011-06-16 Ben Konrath <ben@bagu.org>
3137 Remove superfluous conditional return.
3139 Thanks to Murray Cumming for pointing this out!
3141 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3143 2011-06-15 Ben Konrath <ben@bagu.org>
3145 Return an ArrayList of LayoutGroups for the Details layout.
3147 This corrects a problem with the details layout as it can have more
3148 than one top level LayoutGroup.
3150 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3151 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
3152 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
3153 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
3154 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
3155 with ArrayList of LayoutGroups for the details view layout.
3156 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3157 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
3158 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
3159 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
3160 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
3161 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
3163 2011-06-14 Ben Konrath <ben@bagu.org>
3165 Use cast_dynamic method to determine the libglom LayoutItem type.
3167 This is better than finding the LayoutItem type by using the string
3168 returned from the get_part_type_name() method.
3170 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3172 2011-06-14 Ben Konrath <ben@bagu.org>
3174 Add method names to log entries in the servlet.
3176 This helps when tracking down deployment problems.
3178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3180 2011-06-14 Ben Konrath <ben@bagu.org>
3182 Add data to the DetailsView using a hard-coded primary key value.
3184 The layout and functionality of the DetailsView is not complete. This
3185 is just a checkpoint so the patch doesn't get too big.
3187 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3188 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3189 Add getDetailsData() servlet method.
3190 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3191 Add RPC to getDetailsData(). Change the way the LayoutGroups and
3192 LayoutFields are added to the DetailsView.
3193 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3194 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3195 Add setData() method. Change addLayoutGroup() and addLayoutField() to
3196 take the string for the title instead of the object.
3197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3198 Add implementation getDetailsData() along with some private helper
3200 * src/main/webapp/style.css: Add padding to details-data class. Add a
3201 details-label class with the same padding as the details-data class.
3203 2011-06-03 Ben Konrath <ben@bagu.org>
3205 Use presenter.goTo() to change to the DetailsPlace.
3207 This will make things easier when we need to open the DetailsView with
3208 data specific to the row that was clicked.
3210 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3212 2011-06-02 Ben Konrath <ben@bagu.org>
3214 Add CSS file from mockups.
3216 I'm adding this now because it's going to be useful to have when
3217 developing the DetailsView. The TableSelectionView and ListView aren't
3220 * src/main/webapp/OnlineGlom.html:
3221 * src/main/webapp/style.css:
3223 2011-06-02 Ben Konrath <ben@bagu.org>
3225 Use String.isEmpty() to check for empty string.
3227 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3229 2011-06-02 Ben Konrath <ben@bagu.org>
3231 Display main layout group titles in the DetailsView.
3233 This is the start of the DetailsActivity/DetailsView implementation.
3235 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3236 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3237 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
3238 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3239 Get the layout information for the details view from the server and set
3240 the main layout group titles.
3241 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3242 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3243 Add addLayoutGroup() and addLayoutField() methods. This are just
3244 temporary methods for creating the the details view&nbs