1 2012-01-27 Murray Cumming <murrayc@murrayc.com>
3 Translate more strings in more locales.
5 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
6 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
7 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
8 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
9 Translate the "Details" and "Open" string too.
11 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
12 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
13 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
14 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
15 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
16 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
17 Add these new locales as placeholders though they currently contain English.
19 2012-01-27 Murray Cumming <murrayc@murrayc.com>
21 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
23 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
24 Check the ConfiguredDocument* for null before using it.
26 2012-01-26 Murray Cumming <murrayc@murrayc.com>
28 Tell Eclipse about the generated java files.
30 * .classpath: This lets it find OnlineGlomConstants.java.
31 It would be nice if Eclipse just used the maven build files.
33 2012-01-26 Murray Cumming <murrayc@murrayc.com>
35 Prevent a crash when no locale is specified in the URL.
37 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
38 Avoid returning a null string, obtained from
39 Window.Location.getParameter(). This caused a crash when it was
40 later passed to libglom's API.
41 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
42 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
43 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
44 guard against future null strings.
46 2012-01-26 Murray Cumming <murrayc@murrayc.com>
48 Use the ?locale= query param instead of the &lang= token param.
50 * src/main/java/org/glom/web/client/place/ListPlace.java
51 * src/main/java/org/glom/web/client/place/DetailsPlace.java
52 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
53 Remove the lang token key and value.
55 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
56 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
57 When the user selects a different locale from the chooser, use
58 Window.Location.assign() to change the URL, which then causes a reload.
60 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
61 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
62 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
63 * src/main/java/org/glom/web/client/activity/ListActivity.java
64 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
65 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
66 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
67 * src/main/java/org/glom/web/client/ui/ListView.java:
68 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
70 Remove localeID member variables and method/constructor parameters, instead
71 using Utils.getCurrentLocaleID() when we need a localID to pass to
74 2012-01-26 Murray Cumming <murrayc@murrayc.com>
76 Internationalize the UI strings.
78 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
79 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
80 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
81 because it is unused. Messages are apparently strings that can have
82 parameters, but we do not need that yet, so Contants will be enough for now.
83 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
84 to say that we support the en and de locales.
85 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
86 The original English strings.
87 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
88 Some German translations of the English strings.
89 The i18n goal then uses the .properties file to generate an
90 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
91 returns an implementation that returns the translated strings.
92 The documentation suggests putting these in src/java/*/client/, but it seems
93 best to put it in src/resources/*/client/.
94 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
95 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
96 instead of hard-coding them.
97 Note that we cannot import OnlineGlomConstants because it does not exist yet,
98 but that does not seem to stop the build, though it confuses Eclipse.
100 You can see the translated string by adding ?locale=de to the URL, like so:
101 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
103 2012-01-24 Murray Cumming <murrayc@murrayc.com>
105 Improve null/empty String checks.
107 * pom.xml: Add a dependency on commons-lang, to use
108 org.apache.commons.lang.StringUtils.
109 * src/main/java/org/glom/web/server/ConfiguredDocument.java
110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
111 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
112 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
113 Use StringUtils.isEmpty().
115 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
116 StringUtils class with a static isEmpty() function because we
117 cannot use org.apache.commons.lang.StringUtils in client-side
118 GWT code because it (apparently) cannot be compiled to javascript.
119 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
120 * src/main/java/org/glom/web/client/activity/ListActivity.java
121 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
122 * src/main/java/org/glom/web/client/place/DetailsPlace.java
123 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
124 * src/main/java/org/glom/web/client/place/ListPlace.java
125 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
126 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
127 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
128 * src/main/java/org/glom/web/client/ui/details/Group.java
129 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
130 our StringUtils.isEmpty() function.
132 2012-01-24 Murray Cumming <murrayc@murrayc.com>
134 Update to the latest java-libglom API.
136 * pom.xml: Require java-libglom 1.21.4.
137 * src/main/java/org/glom/web/server/ConfiguredDocument.java
138 getDocumentInfo(), getListViewLayoutGroup():
139 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
141 * src/main/java/org/glom/web/server/database/DBAccess.java
142 getFieldsToShowForSQLQueryAddGroup(),
143 getPrimaryKeyLayoutItemField(): Replace get_database_title()
144 with either get_database_title_original() or
145 get_database_title(localeID).
147 2012-01-24 Murray Cumming <murrayc@murrayc.com>
149 ConfiguredDocument: Avoid a null pointer exception.
151 * src/main/java/org/glom/web/server/ConfiguredDocument.java
152 Initialize localeID to "" to avoid returning a null String which
153 causes a crash in java-libglom's swing-generated code.
155 2012-01-23 Murray Cumming <murrayc@murrayc.com>
157 Some simple renaming.
159 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
160 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
161 for localeChooser. This seems more appropriate and is less ambiguous
162 particularly in the .css file.
164 2012-01-23 Murray Cumming <murrayc@murrayc.com>
166 ConfiguredDocument: Rename the localedID private member variable.
168 2012-01-23 Murray Cumming <murrayc@murrayc.com>
170 Adapt to the latest java-libglom API from git master.
172 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
173 libglom now uses only Vector instead of List, which uses add() instead of
176 2012-01-23 Murray Cumming <murrayc@murrayc.com>
178 Add and fill a Reports drop-down list box.
180 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
182 * src/main/java/org/glom/web/client/OnlineGlomService.java:
183 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
185 Added getReports(document, table, localeID), calling
186 ConfiguredDocument.getReports().
187 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
188 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
189 Added setReportsList() and a list widget.
190 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
191 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
193 2012-01-22 Murray Cumming <murrayc@murrayc.com>
195 ConfiguredDocument: Rename the localedID private member variable.
197 2012-01-20 Murray Cumming <murrayc@murrayc.com>
199 Build a source tarball with mvn assembly:single
201 * assembly.xml: Add this file.
202 * pom.xml: Use the maven-assembly-plugin and tell it to use
203 our assembly.xml file.
205 2012-01-19 Murray Cumming <murrayc@murrayc.com>
207 OnlineGlomServiceImpl: Get .glom files recursively.
209 * pom.xml: Depend on commons-io from org.apache.commons.
210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
211 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
212 files recursively, and with the easier filter for the extension.
213 Use org.apache.commons.io.FilenameUtils.removeExtension() to
214 simplify that code too.
216 2012-01-19 Murray Cumming <murrayc@murrayc.com>
218 README: Mention that you must install java-libglom packages separately.
220 But then it works, because java-libglom is now in the central maven
223 2012-01-18 Murray Cumming <murrayc@murrayc.com>
225 locales drop-down: Show the correct selected locale when the URL changes.
227 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
228 .java: setPlace(): Move some code into fillView().
230 2012-01-18 Murray Cumming <murrayc@murrayc.com>
232 locales drop-down: Do not lose the primary key.
234 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
235 start(): onLocaleChange(): Pass the current primary key value,
236 instead of an empty value.
238 2012-01-18 Murray Cumming <murrayc@murrayc.com>
240 locales drop-down: Do not lose the drop-down selection.
242 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
243 .java (TableSelectionActivity.fillView): Set the selected locale
244 after changing the drop-down items (though we do not really need
245 to change them just because the locale changes.)
247 2012-01-18 Murray Cumming <murrayc@murrayc.com>
249 locales drop-down: Change the tables list when this changes.
251 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
252 .java: TableSelectionActivity.start(): Move the async table titles
253 retrieval into a private fillView() method and also call this when
254 the chosen locale changes.
255 Note that the document title is not actually translatable yet, but
256 that is a problem that I should fix soon in libglom.
258 2012-01-18 Murray Cumming <murrayc@murrayc.com>
260 Improve the placement of the locales drop-down.
262 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
263 Put the title and locales drop-down in a div (gwt.FlowTable).
264 * src/main/webapp/style.css: Add magic css properties to make this work.
265 Also remove the left margin from the title so that it lines up with the
268 2012-01-18 Murray Cumming <murrayc@murrayc.com>
270 locales selector: Show human-readable locale titles.
272 * src/main/java/org/glom/web/server/ConfiguredDocument.java
273 getDocumentInfo(): Use java.util.Locale to show a real title of
274 each locale, in the locale's own language.
276 2012-01-17 Murray Cumming <murrayc@murrayc.com>
278 Add a language/locale selector drop-down.
280 * src/main/java/org/glom/web/shared/DocumentInfo.java:
281 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
282 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
283 getDocumentInfo(): Store the available Locales in the DocumentInfo.
284 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
285 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
286 Add a ListBox to show the available locales. Add getLocaleSelector(),
287 setLocaleList(), getSelectedLocale(), setSelectedLocale().
288 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
289 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
290 java: Add these classes.
291 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
292 start(): Fill the locales ListBox. Handle its change event, firing a
294 setPlace(): Show the selected locale as specified by the URL token.
295 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
296 * src/main/java/org/glom/web/client/activity/ListActivity.java:
297 Handle LocaleChangeEvent, going to a new *Place with that locale.
299 The placement of the ListBox is not pretty, and it currently uses the ID
300 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
304 2012-01-17 Murray Cumming <murrayc@murrayc.com>
306 Search box: Show the search text from the URL token.
308 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
309 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
310 Add setQuickFindText().
311 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
312 .java: setPlace(): Store the queryText if the place is a ListPlace,
313 and call TableSelectionView.setQuickFindText().
315 2012-01-17 Murray Cumming <murrayc@murrayc.com>
317 Allow use of translations via, for instance, &lang=de in the URL.
319 * pom.xml: Use the unstable java-libglom 1.21 version.
321 * src/main/java/org/glom/web/client/OnlineGlomService.java:
322 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
323 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
324 init(): Instead of calling TranslatableItem.set_current_locale()
325 (now removed), call ConfiguredDocument.setDefaultLocaleID().
326 However, this is only for default locales, which are not needed to
327 change the locale in the URL.
328 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
329 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
330 getSortedRelatedListData(): Add a localeID parameter, so we can get the
331 layout for a particular locale.
332 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
333 Add get/setDefaultLocaleID().
334 getDocumentInfo(), getListViewData(), getRelatedListData(),
335 getDetailsLayoutGroup(), getListViewLayoutGroup(),
336 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
337 localeID parameter, so we can get the layout for a particular locale.
339 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
340 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
341 * src/main/java/org/glom/web/client/place/ListPlace.java:
342 Parse and construct a lang parameter too.
344 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
345 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
346 passed to subsequent methods and constructors.
347 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
348 * src/main/java/org/glom/web/client/activity/ListActivity.java:
349 Store the localeID from the *Place and pass it to other constructors
350 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
352 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
353 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
354 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
355 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
356 * src/main/java/org/glom/web/client/ui/ListView.java:
357 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
358 Take localeID parameters and pass them to subsequent constructors and
359 methods, so that the layout is always retrieved for that locale.
361 This is rather repetitive.
363 Note that "" means the original (default) locale of the Glom document,
364 which is usually English.
366 2012-01-17 Murray Cumming <murrayc@murrayc.com>
368 Documents: Remove final keyword to fix startup configuration.
370 * src/main/java/org/glom/web/shared/Documents.java: Remove the
371 final keywords on the private member variables because that breaks
372 the startup, apparently (there are warnings) because it stops them
373 from being serialized. I added these in the previous commit.
375 2012-01-13 Murray Cumming <murrayc@murrayc.com>
377 Documents: Add some final keywords.
379 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
382 2012-01-13 Murray Cumming <murrayc@murrayc.com>
384 OnlineGlomServiceImpl: Add to overview comments.
386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
387 Note that this is where all the document are loaded. They are not
388 loaded freshly for each page.
390 2012-01-12 Murray Cumming <murrayc@murrayc.com>
394 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
395 Add a TextBox for the text of a quick find.
396 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
398 setBackLink(): Add a String quickFind parameter.
399 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
400 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
401 to the base interface, because that is how TableSelectionViewImpl is used.
402 * src/main/webapp/style.css: Add style for the search box and its label.
404 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
405 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
406 Add these files, based on the existing TableChangeEvent and
407 TableChangeEventHandlers.
408 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
409 start(): Handle QuickFindChangeEvent, passing its quickFind text to
410 a ListPlace() that the user should be taken to.
411 * src/main/java/org/glom/web/client/activity/ListActivity.java
412 start(): Handle it here too and adapt the TableChangeEvent handler to
413 pass the extra "" quickFind parameter to ListPlace.
414 * src/main/java/org/glom/web/client/place/ListPlace.java:
415 Constructor: Take an extra String quickFind parameter and store it,
416 returning it from a new getQuickFind() method.
417 getToken(): Put the quickFind text in the URL token.
418 getPlace(): Parse the quickFind text from the URL token.
419 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
420 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
421 ListPlace constructor.
422 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
423 .java: start(): Add a Change handler for the TableSelectionView's
424 TextBox (via its base HasChangeHandlers interface), firing the new
425 QuickFindChangeEvent.
426 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
427 pass the extra "" quickFind parameter.
429 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
430 setCellTable(): Add a String quickFind parameter and pass it to
431 the ListViewTable() constructor.
432 * src/main/java/org/glom/web/client/ui/ListView.java: Change
433 setCellTable() in the base interface, because that is how ListViewImpl
436 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
437 Add a String quickFind member variable.
438 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
439 Constructor: Add a String quickFind parameter, storing it in the
440 base ListTable's member variable.
441 onRangeChanged(): Pass quickFind to the
442 OnlineGlomServiceAsync.getSortedListViewData() and
443 OnlineGlomServiceAsync.getListViewData() methods.
445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
446 getListViewData(), getSortedListViewData(): Add a String quickFind
447 parameter, passing it to ConfiguredDocument.getListViewData().
448 * src/main/java/org/glom/web/client/OnlineGlomService.java:
449 Change getListViewData(), getSortedListViewData() in the base interface,
450 because that is how OnlineGlomServiceImpl is used, via this:
451 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
452 Change getListViewData(), getSortedListViewData() here too.
453 This class can apparently be used to asynchronously call methods on
454 OnlineGlomService, and GWT seems to implement that after recognizing
455 just the *Async name convention and the extra AsyncCallback parameters.
457 * src/main/java/org/glom/web/server/ConfiguredDocument.java
458 getListViewData(): Add a String quickFind parameter, and pass it to
459 ListViewDBAccess.getData().
460 * src/main/java/org/glom/web/server/database/ListDBAccess.java
461 getListData(): Add a String quickFind parameter and pass it to
463 getSelectQuery(): Add a String quickFind parameter.
464 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
465 getSelectQuery(): Add a String quickFind parameter and use it with
466 Glom.get_find_where_clause_quick() to pass a where_clause to
467 Glom.build_sql_select_with_where_clause(), to actually filter the
469 getData(): Add a String quickFind parameter, passing it to getListData().
470 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
471 va: getData(): Pass an empty string to getListData() for the
474 2012-01-12 Murray Cumming <murrayc@murrayc.com>
476 ListTable: Minor change.
478 * src/main/java/org/glom/web/client/ui/list/ListTable.java
479 createCellTable(): Make this protected instead of public.
481 2012-01-12 Murray Cumming <murrayc@murrayc.com>
483 Many files: Use final for the parameters and use the @override attribute.
485 2012-01-22 Ben Konrath <ben@bagu.org>
487 Add anchor links for single line text that starts with http, ftp and www.
491 2012-01-22 Ben Konrath <ben@bagu.org>
493 Add ellipsis to single line text in details view.
497 2012-01-04 Murray Cumming <murrayc@murrayc.com>
499 Remove all javadoc author tags.
501 Because they are awkward and meaningless when many people touch
503 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
505 2012-01-04 Murray Cumming <murrayc@murrayc.com>
507 Revert the COPYING.LESSER to COPYING rename.
509 Apparently both should be there if it is LGPL.
511 2012-01-03 Murray Cumming <murrayc@murrayc.com>
513 *View: Remove unused imports.
515 * src/main/java/org/glom/web/client/ui/DetailsView.java:
516 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
517 * src/main/java/org/glom/web/client/ui/ListView.java:
518 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
519 Remove unused imports, as suggested by Eclipse.
521 2012-01-02 Murray Cumming <murrayc@murrayc.com>
523 Move the *View::Presenter types, and some API into one base View.
525 * src/main/java/org/glom/web/client/ui/DetailsView.java:
526 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
527 * src/main/java/org/glom/web/client/ui/ListView.java:
528 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
529 Presenter, setPresenter() and clear() into a shared base interface,
530 to avoid the unnecessary duplicate Presenter types and to more clearly
531 show how the *Views share the same structure, even if they are not
532 used polymorphically.
534 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
535 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
537 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
538 * src/main/java/org/glom/web/client/activity/ListActivity.java:
539 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
541 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
544 Feel free to revert this if there is a good reason for the duplicate
547 2012-01-02 Murray Cumming <murrayc@murrayc.com>
549 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
551 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
552 a class member instead of a local variable in the method.
553 This lets us use it to get the view instances, for use in tests.
554 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
555 beforeOnlineGlom(): Test some more details of the initial view.
556 Again, this is not very useful.
558 To really test gwt-glom we will need to start a local postgresql
559 instance with local data, like the Glom tests in C++.
561 2012-01-02 Murray Cumming <murrayc@murrayc.com>
563 pom.xml: Mention the LGPL license.
565 * pom.xml: Add a licenses section.
566 * COPYING.LESSER: Move this to COPYING, which
567 previously contained the GPL. But gwt-glom is all LGPL.
569 2012-01-02 Murray Cumming <murrayc@murrayc.com>
571 Add project information to README and pom.xml.
573 * README: Add a brief description and mention some mvn
575 * pom.xml: This extra information shows up in mvn site
578 2011-01-02 Murray Cumming <murrayc@murrayc.com>
580 Use the latest java-libglom version.
582 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
584 2012-01-01 Murray Cumming <murrayc@murrayc.com>
586 GwtTestOnlineGlom: Test a little more.
588 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
589 protected rather than private, as suggested by the gwt-test-utils
591 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
592 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
593 Test the initial visibility of the panels.
595 However, this is not a very useful test.
596 And I wonder how we should generally test using this idea for an
597 activity/places app like ours where the real changes happen implicitly
598 based on the history token/URL.
600 2012-01-01 Murray Cumming <murrayc@murrayc.com>
602 Slight modification to *Mapper comments.
604 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
606 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
608 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
610 Remove comments mentioning GIN because they are just copied from
611 the example code and are apparently not helpful:
612 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
613 Also change the mention of a class that is only in the example code.
615 2012-01-01 Murray Cumming <murrayc@murrayc.com>
617 GwtTestOnlineGlom test: Minor changes.
619 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
620 Avoid the long qualified class name and modify the comment
621 because it is now obvious to me that the mocked class is the only
622 custom one created via GWT.create().
624 2012-01-01 Murray Cumming <murrayc@murrayc.com>
626 Tests: Added the beginnings of a test using gwt-test-utils.
628 * pom.xml: Add dependencies on gwt-test-utils and easymock.
629 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
630 which tells gwt-test-utils what class will be tested.
631 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
632 Add a simple (but empty) test case. One class, used by the OnlineGlom
633 class, is mocked so that it can be created. However, I am not sure
634 why only this class needs to be mocked.
636 Note that mockito seems more popular, and clearer, than easymock,
637 but I have not got that working yet. It might be a matter of the
640 This test is run during mvn integration-test.
642 2011-12-31 Murray Cumming <murrayc@murrayc.com>
644 Tests: Use junit4-style syntax instead of junit3-style.
646 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
647 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
648 * src/test/java/org/glom/web/shared/DataItemTest.java:
649 Use the @Test annotation rather than relying on the test*() prefix.
650 Also no longer implement TestCase, to avoid triggering support for
651 the junit3-way, which stops the annotations from working.
652 Change the imports from import junit.framework.* to
653 import org.junit.*, which is apparently the new way.
655 2011-12-31 Murray Cumming <murrayc@murrayc.com>
657 Added a test for ListPlace token parsing and creation.
659 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
660 This is much the same as DetailsPlaceTest.
662 I wonder how we could test the other parts of the *Place API.
664 2011-12-30 Murray Cumming <murrayc@murrayc.com>
666 DetailsPlace test: Also test getToken() and recreation via getPlace().
668 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
669 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
670 recreate it, testing the recreated DetailsPlace for the same parameter
673 2011-12-30 Murray Cumming <murrayc@murrayc.com>
675 Use the surefire-report plugin.
677 * pom.xml: This generates a HTML report about the tests in
678 target/site/surefire-report.html
679 when you do mvn surefire-report:report. It seems to be popular/normal.
681 2011-12-30 Murray Cumming <murrayc@murrayc.com>
683 Added a test for DetailsPlace.
685 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
686 Test the getPlace() token parsing.
688 2011-12-30 Murray Cumming <murrayc@murrayc.com>
690 Added a first unit test.
692 * pom.xml: Add a test goal, and a dependency on junit in that scope.
693 * src/test/java/org/glom/web/shared/DataItemTest.java:
694 This is a silly test but it is just to get things started. Note that
695 maven/junit finds the test because it looks in src/test by default.
697 2011-12-22 Ben Konrath <ben@bagu.org>
699 Change charsetName to "UTF-8" when replacing line breaks.
701 JavaScript requires the charsetName to be "UTF-8". CharsetName values
702 that work in Java (such as "UTF8") will not work when compiled to
705 This fixes a problem with multi-line details view fields that have hard
706 line breaks. The "License Text" field on this page demonstrates the
709 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
711 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
713 2011-12-22 Ben Konrath <ben@bagu.org>
715 Fix another bug with related list navigation.
717 I've tested all the navigation buttons in all of the related lists
718 so things should be good now.
720 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
722 2011-12-22 Ben Konrath <ben@bagu.org>
724 Fix a crasher when refreshing the list view with the default table.
726 This crash will also happen when loading the list view with the default
727 table from a link or bookmark.
729 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
730 to the main document selection page when the document id hasn't been
732 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
733 the main document selection page when the document id hasn't been
735 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
736 values for the details place when the document id hasn't been set.
737 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
738 values for the list place when the document id hasn't been set.
740 2011-12-21 Ben Konrath <ben@bagu.org>
742 Protect against NPE when glom.document.locale is not in config.
744 This patch protects against an NPE when glom.document.locale is not in
745 the config file. This NPE will also happen if glom.document.locale is
748 The patch also updates the error message to display the class name when
749 the getMessage() returns null. This was happening when the NPE was
750 thrown and I had "Configuration Error: null". If an NPE is encountered
751 with this patch, "Configuration Error: NullPointerException " will be
754 This commit closes this bug:
756 https://bugzilla.gnome.org/show_bug.cgi?id=666669
758 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
760 2011-12-20 Murray Cumming <murrayc@murrayc.com>
762 Rename onlineglom.properties to onlineglom.properties.sample.
764 * src/main/resources/onlineglom.properties: Rename to:
765 * src/main/resources/onlineglom.properties.sample:
766 * src/main/resources/README: And add this file explaining that people
767 should rename it back when deploying.
769 2011-12-20 Murray Cumming <murrayc@murrayc.com>
771 Allow choosing the translation in the .properties file.
773 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
774 init(): Read a glom.document.locale value from the configuration file
775 and call Glom's TransatableItem::set_current_locale() method.
776 * src/main/resources/onlineglom.properties: Add a commented-out
777 example of this new setting.
779 It would be better to add &lang=de_DE to the URL, but the current
780 libglom API does not allow us to do this easily. I am working on that.
782 2011-12-19 Murray Cumming <murrayc@murrayc.com>
784 Avoid a crash in parsing of token parameters.
786 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
787 ava: getTokenParams(): Do not crash if a parameter has a key but no
788 value, and ignore parameters with neither.
790 2011-12-17 Murray Cumming <murrayc@murayc.com>
792 History token building/handling: Improve use of token parameters.
794 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
795 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
796 and buildParamsToken(HashMap), for use by derived classes.
797 Make the separator private because it is no longer be needed.
798 * src/main/java/org/glom/web/client/place/DetailsPlace.java
799 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
800 instead of manual string concatenation.
801 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
802 of hardcoded indices and awkward splitting code.
803 * src/main/java/org/glom/web/client/place/ListPlace.java
804 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
805 instead of manual string concatenation.
806 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
807 of hardcoded indices and awkward splitting code.
808 This should fix bug #666420
810 2011-12-16 Murray Cumming <murrayc@murrayc.com>
812 Fix a Navgiation->Navigation typo in the code.
814 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
815 Rename processNavgiation() to processNavigation().
817 2011-12-16 Murray Cumming <murrayc@murrayc.com>
819 Fix a seperator->separator typo in the code.
821 * src/main/java/org/glom/web/client/place/DetailsPlace.java
822 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
823 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
826 2011-12-15 Ben Konrath <ben@bagu.org>
828 Cleanup some comments.
830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
832 2011-12-14 Ben Konrath <ben@bagu.org>
834 Replace \n with <br/> for multiline text in the details view.
836 Vertical scrollbars are added when needed as well.
838 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
840 2011-12-14 Ben Konrath <ben@bagu.org>
842 Specify the font for document selection links.
844 * src/main/webapp/style.css:
846 2011-12-14 Ben Konrath <ben@bagu.org>
848 Fix bouncy CellTable while paging.
850 This doesn't currently work with related list tables in unselected
853 * src/main/java/org/glom/web/client/ui/list/ListTable.java
855 2011-12-14 Ben Konrath <ben@bagu.org>
857 Revamp the appearance of the document selection page.
859 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
860 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
861 * src/main/webapp/style.css:
863 2011-12-13 Ben Konrath <ben@bagu.org>
865 Set navigation button column to the smallest size possible.
867 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
869 2011-12-13 Ben Konrath <ben@bagu.org>
871 Change OpenButton nomenclature to NavigationButton.
873 Using NavigtionButton makes things more generic. Classes, methods and
874 variables have been changed.
876 This is a rename-only refactor.
878 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
879 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
880 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
881 Renamed from OpenButtonCell.
882 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
883 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
884 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
886 2011-12-12 Ben Konrath <ben@bagu.org>
888 Remove unnecessary String argument in RelatedListTable and ListViewTable.
890 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
891 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
892 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
893 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
895 2011-12-12 Ben Konrath <ben@bagu.org>
897 Update variable names and comments.
899 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
900 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
902 2011-12-12 Ben Konrath <ben@bagu.org>
904 Properly initialize numNonEmptyRows variable to zero.
906 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
907 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
909 2011-12-05 Ben Konrath <ben@bagu.org>
911 Add latest mockup with HTML tables.
913 Features of this mockup:
915 -> HTML table for flowtable
916 -> HTML table for flowtable column
917 -> Example of how related lists would look
918 -> Not using text entries for data items
920 The current version of Online Glom doesn't use HTML tables for the
923 This mockup has been sent to the glom-devel mailing list but it's good
924 to have it here as well.
926 * mockups/details-view-html-tables.html:
928 2011-12-05 Ben Konrath <ben@bagu.org>
930 Remove unnecessary getPrimaryKeyField() method.
932 getPrimaryKeyFieldForTable(String) has been renamed to
933 getPrimaryKeyField(String).
935 * src/main/java/org/glom/web/server/database/DBAccess.java:
936 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
937 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
939 2011-12-05 Ben Konrath <ben@bagu.org>
941 Add string representation of TypedDataItem value to conversion error message.
943 * src/main/java/org/glom/web/server/Utils.java: Logging the error
944 message was extracted into its own method to avoid duplication.
946 2011-12-05 Ben Konrath <ben@bagu.org>
948 Add type checking to navigation primary key value creation.
950 Create navigation primary key only if the expected type from the Glom
951 document matches the type returned by the SQL query.
953 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
955 2011-12-05 Ben Konrath <ben@bagu.org>
957 Rename a couple of variables in RelatedListNavigation.
959 This is a rename-only refactor.
961 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
963 2011-12-05 Ben Konrath <ben@bagu.org>
965 Move getListLayoutGroup() into getListViewLayoutGroup().
967 This removes getListLayoutGroup(). It was only being called by
968 getListViewLayoutGroup().
970 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
972 2011-12-05 Ben Konrath <ben@bagu.org>
974 Remove check for LayoutItem_Portal in list table method.
976 This check is no longer necessary because the method isn't being used
977 to create the LayoutItemPortal DTO.
979 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
981 2011-12-05 Ben Konrath <ben@bagu.org>
983 Properly support related list navigation.
985 Navigation from the "Repository Analyzer -> Package Scans ->
986 Dependencies" related table wasn't working because the primary key for
987 related tables wasn't being set properly. This commit fixes the
990 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
991 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
992 doesn't set the primary key properly for related list tables.
993 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
994 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
995 useful for getting the primary key for list view tables and for related
997 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
998 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
999 Move code to set the primary key for the table from the abstract
1000 ListDBAccess class to ListViewDBAccess as it's only correct for list
1002 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1003 Properly add primary key to related list tables.
1005 2011-12-02 Ben Konrath <ben@bagu.org>
1007 Properly set the horizontal alignment of fields.
1009 This fix is for both the list tables and the details view.
1011 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1012 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1013 to set the horizontal alignment of fields.
1015 2011-12-02 Ben Konrath <ben@bagu.org>
1017 Display currency codes in the details view.
1019 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1021 2011-12-02 Ben Konrath <ben@bagu.org>
1023 Avoid duplicate JNI call.
1025 JNI is not as efficient as pure Java and this is an easy (and small)
1028 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1029 Use previously retrieved value for whereClauseToTableName instead of
1032 2011-12-02 Ben Konrath <ben@bagu.org>
1034 Rename a couple of variables in RelatedListNavigation.
1036 This is a rename-only refactor.
1038 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1040 2011-12-02 Ben Konrath <ben@bagu.org>
1042 Indicate clearly that a mismatched primary key type is a bug.
1044 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1045 warning to error. Add 'This is a bug.' to message.
1047 2011-12-02 Ben Konrath <ben@bagu.org>
1049 Update / fix some comments.
1051 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1053 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1055 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1056 Fix comments. Add some TODOs.
1058 2011-12-02 Ben Konrath <ben@bagu.org>
1060 Enable navigation to details view with string primary key from related list.
1062 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1063 Create a text primary key value when return type of result is
1064 java.sql.Types.VARCHAR.
1066 2011-12-02 Ben Konrath <ben@bagu.org>
1068 Use checkboxes for booleans in the details view.
1070 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1072 2011-12-01 Ben Konrath <ben@bagu.org>
1074 Improve performance of related list height calculation.
1076 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1077 Put code to calculate the expected height in a static initializer so
1078 that that it's only called once.
1080 2011-12-01 Ben Konrath <ben@bagu.org>
1082 Show related list tables in notebooks (again).
1084 Calculate the height of the related list tables so the Notebook can be
1085 set the correct height. The height of the related list table is also needed by
1086 FlowTable to be able decide how to create the layout.
1088 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1089 and set the Portal height based on the height of the related list
1090 table and the Portal container.
1091 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1092 Add method to calculate the height of the related list tables.
1093 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1094 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1095 calculate the height of the Pager widget.
1097 2011-12-01 Ben Konrath <ben@bagu.org>
1099 Use CellTable API for table property instead of setting style on Element.
1101 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1103 2011-12-01 Ben Konrath <ben@bagu.org>
1105 Make ListViewTable and RelatedListTable a consistent height.
1107 The tables are now a consistent height regardless of the contents of
1108 the table. A hidden button is added to empty rows to ensure that the
1109 height of these rows will match the height of rows with data.
1111 A navigation button column is now added to every table. The width of
1112 the navigation column is set to 0px when a RelatedListTable shouldn't
1113 have navigation buttons. This maintains the a consistent row height in
1114 tables that don't show the navigation buttons.
1116 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1117 navigation column when not needed.
1118 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1119 arguments for navigation button to constructor of ListViewTable.
1120 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1121 hidden button for empty data rows.
1122 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1123 arguments for navigation button to constructor.
1124 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1125 create navigation buttons. Add hideNavigationButtons() method.
1126 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1127 arguments for navigation button to constructor.
1129 2011-12-01 Ben Konrath <ben@bagu.org>
1131 Use 'visibility: hidden' in Utils.getWidgetHeight().
1133 This is better choice because hidden elements are invisible, don't
1134 respond to events and are not part of the tab order. They will,
1135 however, take up space which is required to be able to calculate the
1136 height of the widget.
1138 * src/main/java/org/glom/web/client/Utils.java:
1140 2011-12-01 Ben Konrath <ben@bagu.org>
1142 Use Utils.getWidgetHeight() in FlowTable.
1144 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1146 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1148 2011-12-01 Ben Konrath <ben@bagu.org>
1150 Put the details css class name on the correct table column.
1152 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1154 2011-11-30 Ben Konrath <ben@bagu.org>
1156 Update for java-libglom API change.
1158 The getters and setters on FieldFormatting and NumericFormat were
1159 changed to remove the 'M'.
1161 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1163 2011-11-29 Ben Konrath <ben@bagu.org>
1165 Only allow RelatedListTables in Portals.
1167 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1169 2011-11-29 Ben Konrath <ben@bagu.org>
1171 Only create a contents panel for Portals when title is being set.
1173 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1175 2011-11-29 Ben Konrath <ben@bagu.org>
1177 Set TabLayoutPanel height based on calculated height its widgets.
1179 This is a potential fix for this bug:
1181 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1183 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1185 2011-11-29 Ben Konrath <ben@bagu.org>
1187 Align details field labels and data with the Open buttons.
1189 * src/main/webapp/style.css:
1191 2011-11-29 Ben Konrath <ben@bagu.org>
1193 Remove unnecessary <div> in the Notebook widget.
1195 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1196 method to get container FlowPanel (<div>).
1197 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1198 initWidget() method directly on the TabLayoutPanel widget instead of
1199 Group's container widget.
1201 2011-11-29 Ben Konrath <ben@bagu.org>
1203 Don't add group titles for Portals in Notebooks.
1205 This reverts the previous patch and fixes a bug I introduced with
1206 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1208 * src/main/java/org/glom/web/client/ui/details/Group.java:
1209 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1211 2011-11-28 Ben Konrath <ben@bagu.org>
1213 Remove unused boolean argument in Portal constructor.
1215 Just a code cleanup.
1217 * src/main/java/org/glom/web/client/ui/details/Group.java:
1218 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1220 2011-11-28 Ben Konrath <ben@bagu.org>
1222 Remove hack for glom 1.18 style glom files.
1224 * src/main/java/org/glom/web/client/ui/details/Group.java:
1225 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1226 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1228 2011-11-28 Ben Konrath <ben@bagu.org>
1230 Use Gda Value version of primary key to log result too large error.
1232 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1234 2011-11-28 Ben Konrath <ben@bagu.org>
1236 Don't use TypedDataItem.getText() for Unknown types from the URL.
1238 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1239 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1240 instead of getText().
1241 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1242 String field and getUnknown() method.
1244 2011-11-28 Ben Konrath <ben@bagu.org>
1246 Log an error message when the java-libglom .so is not present.
1248 The error message was being set in the exception but not logged.
1250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1252 2011-11-28 Ben Konrath <ben@bagu.org>
1254 Ignore LayoutItem_CalendarPortals.
1256 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1257 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1259 2011-11-28 Ben Konrath <ben@bagu.org>
1261 Extract method for creating the LayoutItemPortal DTO.
1263 Just breaking the code up into smaller chunks.
1265 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1267 2011-11-28 Ben Konrath <ben@bagu.org>
1271 This should have been added with the refactor. Oops!
1273 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1275 2011-11-28 Ben Konrath <ben@bagu.org>
1277 Create primary key value from URL string using type from Glom document.
1279 See this bug, comments 19 - 25:
1281 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1283 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1284 create a TypeDataItem for the primary key here when loading from a
1285 URL. Show the same string for the primary key value as was received
1286 from the URL string (when loading from a URL).
1287 * src/main/java/org/glom/web/server/Utils.java: Update method for
1288 creating the Gda Value from the TypeDataItem to properly deal with
1289 creating a Gda Value based on the Glom document type for the primary
1290 key value string when loading from a URL.
1291 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1292 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1293 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1294 Update for changed method name.
1296 2011-11-27 Ben Konrath <ben@bagu.org>
1298 Rename PrimaryKeyItem to TypedDataItem.
1300 The name PrimaryKeyItem suggests what the class should be used for.
1301 TypedDataItem is a neutral name that describes the class better.
1303 This is a rename-only refactor.
1305 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1306 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1307 * src/main/java/org/glom/web/client/Utils.java:
1308 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1309 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1310 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1311 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1312 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1313 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1314 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1315 * src/main/java/org/glom/web/server/Utils.java:
1316 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1317 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1318 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1319 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1321 2011-11-25 Ben Konrath <ben@bagu.org>
1323 Improve Gda Value conversion from PrimaryKeyItem.
1325 The value from the PrimaryKeyItem is only used if its type match the
1326 type from the glom document.
1328 * src/main/java/org/glom/web/server/Utils.java:
1330 2011-11-25 Ben Konrath <ben@bagu.org>
1332 Manually check if the java-liblgom .so is visible to the JVM.
1334 It seems that Tomcat has problems when a static initializer throws an
1335 exception. This check is done before the first method call into
1336 java-libglom so that execution doesn't continue if the .so is not
1339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1341 2011-11-25 Ben Konrath <ben@bagu.org>
1343 Improve browser configuration error messages.
1347 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1349 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1350 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1351 getConfigurationErrorMessage() method.
1352 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1353 Get and display a specific configuration error message when no Glom
1354 documents are found.
1355 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1356 Implement getConfigurationErrorMessage() method. Surround configuration
1357 code in the init() method with a try/catch block. This allows the
1358 errors to be caught while keeping the servlet available to retrieve the
1359 configuration error message.
1361 2011-11-25 Ben Konrath <ben@bagu.org>
1363 Don't use Strings to hold primary key values.
1365 The primary key values are now held in a new data object
1366 (PrimaryKeyItem) that holds type information and the primary key value
1367 using the correct type.
1369 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1370 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1371 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1372 PrimaryKeyItem instead of String to hold the primary key value.
1373 * src/main/java/org/glom/web/client/Utils.java: Remove
1374 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1375 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1376 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1377 PrimaryKeyItem instead of String to hold the primary key value. Load
1378 document selection page when the documentID has not been set correctly.
1379 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1380 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1382 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1383 Return empty string for URL instead of "null".
1384 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1385 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1386 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1387 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1388 PrimaryKeyItem instead of String to hold primary key values.
1389 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1390 PrimaryKeyValue to a Gda Value.
1391 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1392 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1393 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1394 Replace temporary database access code that uses the PrimaryKeyValue to
1395 Gda Value conversion.
1396 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1397 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1398 PrimaryKeyItem instead of String.
1399 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1400 hold primary key values.
1402 2011-11-24 Ben Konrath <ben@bagu.org>
1404 Use newly added java-libglom API to create queries.
1406 This isn't finished. I still need to stop using Strings for primary key
1407 values in the client code.
1409 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1410 libglom to use fake connections so that retrieving the query string will
1412 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1413 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1414 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1415 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1416 Use the newly added libglom sql methods and classes to create the
1417 query. Add temporary hack to convert primary value strings to Gda
1420 2011-11-23 Ben Konrath <ben@bagu.org>
1422 Don't explicitly set the height of Portals.
1424 See comments 6 - 10 of this bug for details:
1426 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1428 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1430 2011-11-23 Ben Konrath <ben@bagu.org>
1432 Use an HTML table instead of CSS for the FlowTable layout.
1434 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1435 GWT's FlexTable to implement the FlowTable.
1436 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1438 2011-11-18 Ben Konrath <ben@bagu.org>
1440 Add boolean example to HTML table mockup.
1442 * mockups/details-view-html-tables-text-entries.html:
1444 2011-11-17 Ben Konrath <ben@bagu.org>
1446 Ensure the pager buttons are always visible for related lists.
1448 To accomplish this, I've turned off text wrapping in the list view and
1449 related list tables for both the header and data text. The related list
1450 table now has a fixed layout so the it doesn't overflow its container.
1451 This is required to ensure that the cell text is clipped when it
1452 overflows the cell and an ellipsis is added to the right side of the
1453 cell when text is clipped.
1455 A fixed table layout for the related list table in the details view
1456 seems what we want for the details view anyway, so the side-effect is
1459 The ellipsis will only be displayed in Firefox >= 7.
1463 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1465 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1466 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1467 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1469 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1470 Set the 'table-layout: fixed' CSS property to the related list table.
1471 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1472 'white-space: nowrap;' CSS property on both the list view and the
1473 related list tables.
1475 2011-11-16 Ben Konrath <ben@bagu.org>
1477 Rework the fix for empty notebook tab labels.
1479 Setting the empty group titles with its name caused problems for the
1480 details layout. Instead of using libglom's
1481 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1482 to the client when the title is empty. This allows the Notebook to use
1483 the name when the title is empty without affecting anything else.
1485 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1486 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1488 2011-11-16 Ben Konrath <ben@bagu.org>
1490 Set group titles with name when title is empty.
1492 This fixes a problem with an empty notebook tab label in the Lesson
1493 Planner document. The forth tab in the notebook should be "Internet":
1495 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1497 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1498 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1501 2011-11-16 Ben Konrath <ben@bagu.org>
1503 Remove whitespace from the configured username properties.
1505 This assumes that usernames won't have whitespace at the beginning
1506 or end. But I think this is a reasonable assumption.
1508 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1509 String.trim() to remove the whitespace from the username properties.
1511 2011-11-15 Ben Konrath <ben@bagu.org>
1513 Add details view mockup with HTML tables and text entries.
1515 This is from the attachment on this bug:
1517 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1519 * mockups/details-view-html-tables-text-entries.html:
1521 2011-11-15 Ben Konrath <ben@bagu.org>
1523 Add space between the columns of the flow table.
1527 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1529 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1530 space between columns in the flow table.
1532 2011-11-15 Ben Konrath <ben@bagu.org>
1534 Add backup files to the .gitignore.
1536 * .gitignore: Ignore files that end with ~.
1538 2011-11-09 Ben Konrath <ben@bagu.org>
1540 Use latest release of gwt-log.
1542 Gwt-log releases are now being submitted to the maven central
1543 repository so manual installation of the jar is no longer required.
1545 * pom.xml: Update version and groupId of gwt-log dependency.
1547 2011-10-31 Ben Konrath <ben@bagu.org>
1549 Don't use GWT numeric formatting to override the glom currency formatting.
1551 Currencies are now displayed like they are in Glom. See this bug:
1553 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1555 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1557 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1558 currency code to constructor and set it when the cell is rendered.
1559 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1560 currency code to the constructor of the NumericCell.
1562 2011-10-27 Ben Konrath <ben@bagu.org>
1564 Require the latest release of java-libglom (1.17.4).
1568 2011-10-26 Ben Konrath <ben@bagu.org>
1570 Add style to Notebook that matches current theme.
1572 It's not the best style in the world but it's better than the default.
1574 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1575 padding at the bottom of the child widgets.
1576 * src/main/webapp/style.css: Add style for the Notebook.
1578 2011-10-26 Ben Konrath <ben@bagu.org>
1580 Move servlet initialization code to overridden init method.
1582 This is half of the solution to getting proper error messages
1583 displayed when configuration errors occur. Here's the relevant bug:
1585 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1587 The rest of the solution involves surrounding the init method with a
1588 try/catch block and setting a global variable with the error /
1589 exception. A new async method should be created to retrieve and display
1590 the error message / exception.
1592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1593 code from constructor to init method adding exceptions as needed.
1595 2011-10-26 Ben Konrath <ben@bagu.org>
1597 Add script to monitor and restart tomcat if required.
1599 * utils/check-and-recover-tomcat.py: New file.
1601 2011-10-26 Ben Konrath <ben@bagu.org>
1603 Display the correct number of data items in the pager.
1607 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1609 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1610 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1611 The implementation is the same for both tables: Keep track of the
1612 number of non-empty rows and fire and RowCountChangeEvent after the data has
1614 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1615 custom Pager class that subclasses SimplePager to handle displaying
1616 the correct number when empty rows have been added.
1618 2011-10-26 Ben Konrath <ben@bagu.org>
1620 Correct error in previous commit.
1622 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1623 eventBus parameter from listView.setCellTable().
1625 2011-10-26 Ben Konrath <ben@bagu.org>
1627 Fix error in TODO comment.
1629 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1631 2011-10-24 Ben Konrath <ben@bagu.org>
1633 Create Notebook widgets to the details view.
1635 This isn't finished just yet - I still need to create a reasonable
1636 style to match the current theme.
1638 * src/main/java/org/glom/web/client/Utils.java: Add method for
1639 calculating the height of a widget. This is used in the Notebook class.
1640 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1641 new constructor method in Group.
1642 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1643 method for creating child widget that can be used by subclasses
1644 like Notebook. New constructor that allows disabling the group
1645 titles - Notebooks don't set a group title for their child groups.
1646 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1647 to make Notebooks using GWT's TabLayoutPanel.
1648 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1649 constructor that allows disabling the group titles.
1650 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1651 LayoutItemNotebook DTO.
1652 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1653 DTO for Notebooks. It's just an empty class for now but we might need
1654 it to transfer some specific information in the future.
1656 2011-10-21 Ben Konrath <ben@bagu.org>
1658 Add navigation buttons to related list tables.
1660 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1661 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1662 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1663 method getSuitableRecordToViewDetails() for getting the table name
1664 and primary key value for related list navigation buttons.
1665 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1666 private cell renderer class to get the navigation information for
1667 related list tables from the server. Extract the navigation
1668 processing code from the details cell navigation and use it for the
1669 related list navigation as well.
1670 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1671 cell renderer class for the details open buttons. This was needed
1672 because the related list navigation buttons and the list view
1673 navigation buttons need to react differently when clicked.
1674 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1675 the onEnterKeyDown() method because it's now overriden in the
1676 subclasses that are specific to the related list tables and the list
1678 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1679 the vertical size a little because the buttons add a bit of vertical
1680 space to table. This is not a perfect solution because the vertical
1681 size of with table fewer than 5 rows will be a little smaller.
1682 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1683 changes in how navigation buttons are handled.
1684 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1685 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1686 database access object.
1687 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1688 to find the portal for a given relationship name from
1689 RelatedListDBAccess. Add method to find a primary key field for a
1691 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1692 Move code to find the portal for a given relationship name to
1694 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1695 New file: database access object for getting the related list
1696 navigation information (the table name and the primary key value).
1697 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1698 DTO for transferring a table name to navigate to and a primary key
1700 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1701 boolean and getter/setter to specifies if the related list should add
1704 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1706 Use the master branch of java-libglom
1708 * pom.xml: Depend on java-libglom 1.19 instead.
1710 This is the master branch. See also the libglom-1-18 branch.
1712 2011-10-11 Ben Konrath <ben@bagu.org>
1714 Enable the open navigation button when the data has been set.
1716 This avoids having active buttons that don't do anything when the data
1719 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1721 2011-10-11 Ben Konrath <ben@bagu.org>
1723 Use IsWidget interface for FlowTableItem.
1725 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1726 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1728 2011-10-11 Ben Konrath <ben@bagu.org>
1730 Remove GWT styling from open button in details view.
1732 There are still some issues with how the details cell is arranged but
1733 this should be made to match Glom 1.20. I'm going to leave fixing this
1734 until I have Glom 1.20 up and running.
1736 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1737 style name on open button.
1738 * src/main/webapp/style.css: Move and edit details-navigation class.
1739 Re-arrange some classes to make them appear in the same order as the
1742 2011-10-07 Ben Konrath <ben@bagu.org>
1744 Update to GWT 2.4.0.
1746 * .gitignore: Ignore new cache directory.
1747 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1748 * pom.xml: Change GWT and maven plugin to 2.4.0.
1749 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1751 * src/main/java/org/glom/web/client/ClientFactory.java:
1752 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1753 * src/main/java/org/glom/web/client/OnlineGlom.java:
1754 Update source for API changes.
1755 * utils/build-onlineglom-war.sh: Remove cache directory before the
1758 2011-10-07 Ben Konrath <ben@bagu.org>
1760 Add navigation buttons in the details view.
1762 This isn't finished but I thought I'd commit what I have as it's a
1763 pretty good start. I still need to:
1765 1. Change the style so that it fits better into the current theme
1766 2. Adjust the details cell to expand as much as possible.
1768 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1769 click handlers to navigation buttons in the DetailsCells. Create a
1770 refreshData() method to get just the data from the server without the
1772 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1773 Update the tableSelector and browser title when the table name
1774 changes without using the tableSelector.
1775 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1776 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1777 getDetailsCells() to getCells(). Update variable names.
1778 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1779 method to set click handler on navigation button. Rename a few
1780 variables. Add navigation buttons where needed.
1781 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1782 variables and methods.
1783 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1784 navigation boolean and navigation table as required in the
1785 LayoutItemField DTO.
1786 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1787 variables for navigation along with getter/setter methods.
1789 2011-10-07 Ben Konrath <ben@bagu.org>
1791 Rename Field to DetailsCell.
1793 This is a refactor-only commit. No functionality has been added or
1796 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1797 Update variable and method names.
1798 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1799 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1800 variable and method names.
1801 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1803 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1804 variable and method names.
1806 2011-10-07 Ben Konrath <ben@bagu.org>
1808 Create separate methods for layout and data the details view.
1810 This is a refactor-only commit. No functionality has been added or
1813 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1814 private methods: setData(), createLayout().
1816 2011-10-07 Ben Konrath <ben@bagu.org>
1818 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1820 This is part of a change to get navigation buttons in the details view
1821 but it should have been done this way from the start.
1823 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1824 for method name change in TableSelectionView.
1825 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1826 Create TableChangeEvent and set the browser title using the
1827 TableSelectionView API.
1828 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1829 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1830 Change getSelectedTable() to getSelectedTableName(). Add
1831 getSelectedTableTitle().
1833 2011-10-07 Ben Konrath <ben@bagu.org>
1835 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1837 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1839 2011-10-07 Ben Konrath <ben@bagu.org>
1841 Update TableChangeEvent to use newTableName naming convention.
1843 This makes the class more consistent with GWT naming conventions.
1845 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1846 Update for method name change in TableChangeEvent.
1847 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1848 for method name change in TableChangeEvent.
1849 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1850 newTableName variable and getter method. Make toDebugString()
1853 2011-09-30 Ben Konrath <ben@bagu.org>
1855 Disable the pager in the list tables when the data row count is less than the minimum.
1857 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1858 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1860 2011-09-30 Ben Konrath <ben@bagu.org>
1862 Add empty rows to the end of related list and list view tables.
1864 I also extracted the cell rendering classes from the ListTable because
1865 the code was becoming a little crazy with all the anonymous inner
1866 classes. My plan is to use these cell rendering classes in the details
1867 view as well so this refactor will be needed for that change.
1869 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1870 set the row count in related list tables if the data has more rows
1871 than the minimum number of rows visible.
1872 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1873 row count in list view tables if the data has more rows than the
1874 minimum number of rows visible.
1875 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1876 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1878 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1879 for rendering TYPE_NUMERIC cells. The code was extracted from the
1881 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1882 class for rendering cells with buttons in list views. The code was
1883 extracted from the ListTable class.
1884 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1885 for rendering TYPE_TEXT cells. The code was extracted from the
1887 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1888 Add empty rows to the end of the data if required. Implement
1889 ListTable.getMinNumVisibleRows().
1890 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1891 cell renderer code to public classes. Return null in
1892 Column.getValue() for empty rows. Add new abstract method:
1893 getMinNumVisibleRows(). Move code to set the row count of the list view
1894 table to ListViewImpl.
1895 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1896 empty rows to the end of the data if required. Implement
1897 ListTable.getMinNumVisibleRows().
1900 2011-09-27 Ben Konrath <ben@bagu.org>
1902 Use GWT.log for client-side debugging statements.
1904 These are optimized out when deployed so I should have used this method
1905 in the first place. These statements will eventually be replaced with some sort
1906 of notification in the browser.
1908 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1909 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1910 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1911 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1912 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1914 2011-09-27 Ben Konrath <ben@bagu.org>
1916 Put tableselector on the right, back to list link on right.
1918 The idea is that the table selector is acting like a label for the
1919 currently displayed table so it should be placed below the document title. This
1920 puts the table title in a similar position to where it is in Glom.
1922 * mockups/details-contacts.html:
1923 * mockups/details-projects.html:
1924 * mockups/listview-contacts.html:
1925 * mockups/listview-projects.html:
1926 * mockups/style.css:
1927 Update mockups to match how the interfaces currently look.
1928 * src/main/webapp/style.css: Swap positions of backlink with the table
1929 selector. Add some space on the left side of the table selector to
1930 line things up with the document title.
1932 2011-09-27 Ben Konrath <ben@bagu.org>
1934 Add field colouring to details view.
1936 This change re-works how field colouring works. The colour formatting
1937 information is now set to the client with the layout information instead of
1938 with the data. This eliminates the need to send the same colour strings for
1939 data in list view column when colour information is set.
1941 In order to set an alternate colour for negative numeric values, the
1942 number is now sent to client and formatted with the GWT NumberFormat class.
1944 This change also fixes:
1946 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1948 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1949 internationalization framework which is needed for client side numeric
1951 * src/main/java/org/glom/web/client/Utils.java: New file for some
1952 client static utility methods.
1953 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1954 the DataItem object to the Field class. Use a utility method to
1955 create the foreignKeyValue string.
1956 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1957 alignment and text colours in the constructor. Add setData(DataItem)
1958 method. Remove setText(String) method.
1959 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1960 colour information to GlomTextCell. Create and use GlomNumberCell for
1961 rendering numbers. Use utility method to get the string for the
1962 primary key of the key provider. Re-work how the horizontal alignment
1964 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1965 formatting to layout information. Methods for converting the libglom
1966 formatting information were moved from DBAccess.
1967 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1968 numeric formatting (it's now done on the client side). Don't set text
1969 colours in DataItem. Move libglom formatting conversion methods to
1971 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1972 getters/setters for text colour information.
1973 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1974 for transferring the libglom NumericFormat information to the client.
1975 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1976 and getters/setters for: GlomNumericFormat, background colour and
1977 foreground colour strings.
1979 2011-09-26 Ben Konrath <ben@bagu.org>
1981 Simplify code that iterates through the LayoutGroup.
1983 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1985 2011-09-26 Ben Konrath <ben@bagu.org>
1987 Accept Eclipse formatting for OnlineGlomServiceAsync.
1989 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1991 2011-09-26 Ben Konrath <ben@bagu.org>
1993 Don't use the ListDBAccess classes to get the primary key layout information.
1995 This was causing a bug where the wrong index for the hidden primary key
1996 was being sent to the client.
1998 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1999 primary key while creating the LayoutGroup DTO. Create a
2000 LayoutItemField DTO for hidden primary keys. Don't use the
2001 RelatedListDBAccess because it was only used for getting the primary
2003 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2004 access modifier from public to protected for getPrimaryKeyField() and
2005 getPrimaryKeyLayoutItemField().
2006 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2007 abstract method getExpectedResultSize() because RelatedListDBAccess
2008 doesn't have enough info to implement it.
2009 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2010 Remove @Override for getExpectedResultSize().
2011 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2012 Remove method getExpectedResultSize().
2014 2011-09-23 Ben Konrath <ben@bagu.org>
2016 Log which layout (list or details) the ignored item is from.
2018 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2020 2011-09-23 Ben Konrath <ben@bagu.org>
2022 Remove annotations that turn off code formatting in DataItem.
2024 * src/main/java/org/glom/web/shared/DataItem.java:
2026 2011-09-23 Ben Konrath <ben@bagu.org>
2028 Rename GlomField to DataItem and update associated methods.
2030 This is a rename-only refactor. No functionality has been added or
2033 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2034 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2035 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2036 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2037 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2038 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2039 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2040 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2041 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2042 * src/main/java/org/glom/web/server/database/DBAccess.java:
2043 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2044 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2045 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2046 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2047 * src/main/java/org/glom/web/shared/DataItem.java:
2048 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2049 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2051 2011-09-23 Ben Konrath <ben@bagu.org>
2053 Rename GlomDocument to DocumentInfo and update associated methods.
2055 This is a rename-only refactor. No functionality has been added or
2058 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2059 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2060 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2061 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2062 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2063 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2064 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2066 2011-09-20 Ben Konrath <ben@bagu.org>
2068 Require java-libglom 1.17.3.
2070 This picks up the fix for the seg fault problem with the Scenes table
2071 in the Openismus Film Manager example.
2075 2011-09-20 Ben Konrath <ben@bagu.org>
2077 Change the way sort clause is added for primary key when no sort clause is requested.
2079 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2080 before the sort clause is created. When a sort clause is not requested, the
2081 sort clause is created by finding the primary key in the LayoutFieldVector
2084 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2086 2011-09-20 Ben Konrath <ben@bagu.org>
2088 Log error message if no documents are found in the configured directory.
2090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2091 Extract the glom file extension string to a private static final class
2092 variable (mostly as syntactic sugar). Accept a minor formatting change.
2093 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2094 the example glom.document.directory configuration property to make it
2095 more clear that it can any directory, not just the home directory.
2097 2011-09-18 Ben Konrath <ben@bagu.org>
2099 Add related lists to details view.
2101 The related list table has support for paging and sorting just like the
2102 table in the list view.
2104 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2105 SQL queries for the related list tables.
2106 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2107 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2109 Rename getList methods to getListView and add comments. Remove
2110 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2111 it being unused. Add methods: getDetailsLayoutAndData(),
2112 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2114 Create the layout and set the data for the fields in one async call
2115 instead of two. Create related lists where appropriate.
2116 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2117 for method name changes in OnlineGlomService.
2118 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2119 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2120 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2122 * src/main/java/org/glom/web/client/ui/ListView.java:
2123 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2124 tableName from setCellTable(). Create a ListViewTable instead of
2126 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2127 represent a data field in the details view.
2128 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2129 from addDetailsCell() to Field class. Keep track of the Fields and
2130 Portals in the details view.
2131 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2132 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2133 and add a method to get it. Add method to set the contents of the
2135 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2136 New class for related list tables. This class has the data provider
2137 for the related list table.
2138 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2139 abstract class which is the base class for the ListViewTable and the
2141 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2142 New class for list view tables. This class has the data provider for
2143 the list view table.
2144 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2145 methods for related list tables. Add more information to the
2146 LayoutItemField and LayoutItemPortal DTOs.
2147 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2148 Remove debugging print statement.
2149 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2150 Remove debugging print statements. Add primary key field to SQL count
2152 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2153 Remove unnecessary LayoutFieldVector parameter from
2154 getResultSizeOfSQLQuery() method.
2155 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2156 New class for related list table database access.
2157 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2158 class that is a wrapper DTO for details view layout and data.
2159 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2160 new 'fromField' string to this DTO.
2161 * src/main/webapp/style.css: Remove bottom margin and override top
2164 2011-09-15 Ben Konrath <ben@bagu.org>
2166 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2168 This sets things up to make it easier to add the data retrieval for
2169 related lists (portals). No user noticeable changes were made with
2172 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2173 class has the code to retrieve the layouts and access the
2174 database using the new database helper classes.
2175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2176 Most of the functionality has been removed from this class. This
2177 class now represents the public interface for the client side
2178 code. It also deals with configuring the servlet and cleaning
2179 things up when the servlet is stopped.
2180 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2181 of static methods into this utility class.
2182 * src/main/java/org/glom/web/server/database/DBAccess.java:
2183 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2184 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2185 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2186 These classes have the database retrieval code. The class hierarchy
2187 has been setup to make it easy to reuse code for similar
2190 2011-09-06 Ben Konrath <ben@bagu.org>
2192 Create separate classes for list table code and the data provider.
2194 As part of this refactor, I also split up the code a bit to make it
2197 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2198 table code to two new classes (below).
2199 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2200 with code from ListViewImpl.
2201 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2202 New file with code from ListViewImpl.
2204 2011-09-06 Ben Konrath <ben@bagu.org>
2206 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2208 This fixes the LayoutItemPortal DTO to match the libglom layout object
2211 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2213 2011-09-01 Ben Konrath <ben@bagu.org>
2215 Set title of Portals in the Details View.
2217 * pom.xml: Bump required version of java-libglom to 1.17.1.
2218 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2219 widget creation to its own class. Add comments to constructor.
2220 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2221 The code is mostly from the Group class with the title now set.
2222 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2223 title of Portal. Update some comments. Fix some code formatting.
2225 2011-09-01 Ben Konrath <ben@bagu.org>
2227 Remove TODO comment for the flow table column width.
2229 The flow table column width is working correctly and doesn't need to be
2230 changed. See this mailing list post for more info:
2232 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2234 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2236 2011-08-27 Ben Konrath <ben@bagu.org>
2238 Add document title (database name) to top of the browser page.
2240 I added the document title to the TableSelecitonView but that will
2241 change if / when we add a view that doesn't require table selection.
2243 * mockups/details-contacts.html:
2244 * mockups/details-projects.html:
2245 * mockups/listview-contacts.html:
2246 * mockups/listview-projects.html:
2247 * mockups/style.css: Add document title to mockups to keep things
2249 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2250 sizes to account for the document title.
2251 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2252 Set the document title when it has been retrieved from the server.
2253 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2254 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2255 and implement setDocumentTitle(String) method.
2256 * src/main/webapp/style.css: Add ID for document title style.
2258 2011-08-25 Ben Konrath <ben@bagu.org>
2260 Add NavigationType enum to LayoutItemPortal DTO.
2262 This is the start of adding support for Portals to the Details View.
2264 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2265 LayoutItem_Portal.navigation_type enum from libglom to
2266 LayoutItemPortal.NavigationType enum.
2267 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2268 NavigationType enum, field for storing the NavigationType and getter
2271 2011-08-25 Ben Konrath <ben@bagu.org>
2273 Implement the flow table layout in the Details View.
2275 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2276 FlowTable to Group to account for the renamed class.
2277 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2278 File. This is a container widget that implements the Glom details view
2279 flow table behaviour.
2280 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2281 org/glom/web/client/ui/FlowTable.java.
2282 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2283 so that the size of the subgroups are a closer match to the size of
2284 the Glom subgroups. This makes the flowtable layout match the layout
2285 in Glom for the Music Collection example file.
2287 2011-08-16 Ben Konrath <ben@bagu.org>
2289 Create container element for LayoutItemPortal in Details View.
2291 This will help me develop the layout for the FlowTable.
2293 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2294 fieldPanel variable to detailsCell.
2296 2011-08-15 Ben Konrath <ben@bagu.org>
2298 Set the height of the data element in the Details View.
2300 I changed the InlineLabels (text in a span element) to Labels (text in
2301 a div element) so that I could set the height of the details-data
2302 elements instead of the details-cell parent elements. This allows the
2303 the details-data element to display the correct height if style is
2304 applied that shows the height.
2306 This change has the added benefit of allowing the order of the labels
2307 and data elements to be changed for right-to-left languages.
2309 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2310 InlineLabels to Labels.
2311 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2312 InlineLabels to Labels. Set the height of the data element.
2313 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2314 multiline text height in the Formatting DTO.
2315 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2316 for multiline height along with getter and setter methods.
2317 * src/main/webapp/style.css: Adjust style to account for the change
2318 from span elements to div elements in the details cell.
2320 2011-08-15 Ben Konrath <ben@bagu.org>
2322 Make the List View appearance match the mockups.
2324 It doesn't match exactly but it's much better than it was.
2326 * mockups/listview-contacts.html: Remove unused css classes.
2327 * mockups/listview-projects.html: Remove unused css classes.
2328 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2329 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2330 for mainPanel instead of VerticalPanel (table). Set style name on
2331 CellTable. Set style name on Details column. Right-align Details
2333 * src/main/webapp/style.css: Adjust properties to match the mockups.
2335 2011-08-12 Ben Konrath <ben@bagu.org>
2337 Add better support for subgroups in the details view.
2339 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2340 changed FlowTable constructor.
2341 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2342 support for subgroups and subgroup-titles.
2343 * src/main/webapp/style.css: Add CSS class for subgroups and
2346 2011-08-12 Ben Konrath <ben@bagu.org>
2348 Return the top level LayoutGroup title.
2350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2352 2011-08-11 Ben Konrath <ben@bagu.org>
2354 Make the TableSelector header match the mockup.
2356 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2357 the layout panel. Properly lineup the table selection header with
2358 the list and details view.
2359 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2360 margin around the details view.
2361 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2362 Rename listBox variable to tableSelector. Set id for the style sheet.
2363 Use a FlowPanel instead of a HorizontalPanel.
2364 * src/main/webapp/style.css: Add properties to make the TableSelector
2365 box match the mockups.
2367 2011-07-13 Ben Konrath <ben@bagu.org>
2369 Update install script for java-libglom version change.
2371 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2374 2011-07-13 Ben Konrath <ben@bagu.org>
2376 Add support sub-group in the details view.
2378 I also removed the code that special-cased the default details view
2381 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2383 I still have to make a proper flowtable.
2385 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2386 Don't special-case default details view layout.
2387 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2388 addLayoutField() as I'm going to use it.
2389 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2390 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2392 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2393 extracted from DetailsViewImpl.GroupPanel. Add support for
2395 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2396 column count when getting the details layout.
2398 2011-07-12 Ben Konrath <ben@bagu.org>
2400 Set browser title with database and table titles.
2402 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2403 Set the browser title when the table changes and when the activity
2405 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2406 title when retrieving document info (the GlomDocument object).
2407 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2408 with getter and setter methods. Remove unused convenience constructor.
2409 Use default code formatting.
2411 2011-07-12 Ben Konrath <ben@bagu.org>
2413 Ignore LayoutItemPortals in the details view.
2415 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2418 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2419 LayoutItemPortal layout objects.
2420 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2421 LayoutItemPortal objects when retrieving the details layout.
2422 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2423 file. This is an empty class and just used to get type information for
2426 2011-07-12 Ben Konrath <ben@bagu.org>
2428 Use java-libglom 1.17.0.
2432 2011-07-11 Ben Konrath <ben@bagu.org>
2434 Remove "Table:" label from table selector.
2436 This matches a recent change in the Glom UI.
2438 * mockups/details-contacts.html:
2439 * mockups/details-projects.html:
2440 * mockups/listview-contacts.html:
2441 * mockups/listview-projects.html: Remove the "Table:" label from the
2443 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2445 2011-07-11 Ben Konrath <ben@bagu.org>
2447 Add main groups to the details view.
2449 This makes things look a little nicer in the details view. The next step
2450 is to implement the flowtable.
2452 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2453 resources from the standard gwt css theme. Standard.css is now
2454 included in OnlineGlom.html so that the online glom css rules have
2455 precedence over the gwt theme.
2456 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2457 the whole LayoutGroup to the DetailsView instead of just the titles.
2458 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2459 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2460 details layout with a helper class (GroupPanel). I might extract this
2461 class when I make the full flowtable.
2462 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2463 string as default so I don't have to worry about NPEs when processing
2465 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2466 note beside OnlineGlom.gwt.xml above).
2467 * src/main/webapp/style.css: Add default font-size to body to override
2468 the font-size set by the standard theme. Don't use h2 tags for
2469 group-title. Create new details-cell class.
2471 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2473 ConfiguredDocument: Set the port number too.
2475 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2476 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2477 Glom document. Presumably this worked sometimes so far because there is a
2478 default port number.
2480 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2482 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2484 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2485 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2486 correct, though we should throw an exception too.
2488 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2490 Fix a addDocuemnt typo.
2492 * src/main/java/org/glom/web/shared/Documents.java
2493 (Documents.addDocuemnt): Rename to addDocument().
2494 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2495 (OnlineGlomServiceImpl.getDocuments): Adapt.
2497 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2499 Slightly improved log output when connection fails.
2501 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2502 (ConfiguredDocument.setUsernameAndPassword):
2503 We don't know for sure if it' the username/password that's wrong, so
2504 rephrase the message.
2505 Also ouput the exception message, though it's generic in this case.
2507 2011-07-08 Ben Konrath <ben@bagu.org>
2511 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2512 added braces to a one line if statement because the Eclipse formatter
2513 was getting confused.
2515 2011-07-07 Ben Konrath <ben@bagu.org>
2517 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2519 These should really be two separate tasks but I counldn't get things to
2520 work with GWT 2.2.0 and Eclipse 3.7.
2524 * .settings/org.eclipse.jdt.core.prefs:
2525 * .settings/org.eclipse.jdt.ui.prefs:
2526 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2527 * .settings/org.eclipse.m2e.core.prefs:
2528 Add new config files. Update current files. Remove references to the
2529 webtools plugins as we're not using any of the webtools features.
2530 * .gitignore: Add logs directory which is created when running with
2532 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2533 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2534 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2536 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2538 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2540 onlineglom.properties: Add explanatory comments.
2542 * src/main/resources/onlineglom.properties: Also change the default user
2543 from ben to someuser, to avoid the risk of people thinking we just
2544 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2546 2011-06-28 Ben Konrath <ben@bagu.org>
2548 Use filename in Log for incorrect passwords.
2550 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2551 getFileName(String) method to get the filename from the URI.
2553 2011-06-28 Ben Konrath <ben@bagu.org>
2555 Add the table name to the URL token for the ListPlace.
2557 This makes things consistent between the DetailsPlace and the
2558 ListPlace. It also allows the the ListPlace to be bookmarked.
2560 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2561 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2562 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2563 Remove getDefaultListLayout(). The default layout is now returned
2564 by the getListLayout() method when the table name is an empty string.
2565 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2566 Add table name field. Change to a new ListPlace when the table
2567 has been changed. Use getListLayout() for getting the default
2569 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2570 Add table name field. Set the correct table name in the list box
2571 when loading from bookmark. This corrects a problem for the
2573 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2574 Move table name to super-class (HasSelectableTable). Move document
2575 and table URL keys to super-class in HasSelectableTable.
2576 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2577 Add table name field. Add Tokenizer class with URL key common to
2578 the subclasses (DetailsPlace and ListPlace).
2579 * src/main/java/org/glom/web/client/place/ListPlace.java:
2580 Add table name. Add code to parse the URL token.
2581 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2582 Update ListPlace construction with empty table name string.
2583 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2584 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2585 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2586 Update ListPlace construction with table name string.
2587 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2588 Change defaultTableName field to tableName to reflect how it's now
2589 used. Update the getter and setter methods.
2591 2011-06-28 Ben Konrath <ben@bagu.org>
2593 Enable the table selector in the DetailsView.
2595 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2596 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2597 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2598 Remove getDefaultDetailsLayout(). The default layout is now returned
2599 by the getDetailsLayout() method when the table name is an empty
2601 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2602 event handler for table change event. Change to using
2603 getDetailsLayout() for the default details layout.
2604 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2606 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2607 when navigating to the details place.
2609 2011-06-27 Ben Konrath <ben@bagu.org>
2611 Use filename based unique document ID in URL and for RPC.
2613 The document ID is the glom document name with spaces (' ') replaced
2614 with pluses ('+') and without the .glom extension.
2616 This change is mostly a string substitution of 'documentTitle' for
2617 'documentID'. The only code change is the addition of a Documents DTO to get the
2618 filename to document title mappings as indicated below.
2620 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2621 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2622 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2623 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2624 Use Documents DTO to create the document links in the document
2626 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2627 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2628 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2629 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2630 * src/main/java/org/glom/web/client/place/ListPlace.java:
2631 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2632 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2633 * src/main/java/org/glom/web/client/ui/ListView.java:
2634 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2635 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2636 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2637 * src/main/java/org/glom/web/server/Log.java:
2638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2639 getDocumentTitles() to getDocuments() and return the Documents DTO.
2640 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2641 transferring the filename to document title mappings.
2643 2011-06-25 Ben Konrath <ben@bagu.org>
2645 Make the authentication popup work again.
2647 This bug was introduced when I extracted ConfiguredDocument to its own class.
2649 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2650 correct success / fail status in setUsernameAndPassword().
2652 2011-06-25 Ben Konrath <ben@bagu.org>
2654 Use filename as unique key for configuring database usernames and passwords.
2656 This replaces the use of the Glom document title which could change
2657 depending on the locale. Thanks to Murray Cumming for pointing out this
2660 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2661 * src/main/resources/onlineglom.properties:
2663 2011-06-24 Ben Konrath <ben@bagu.org>
2665 Pass primary key value to DetailsView.
2667 This enables the DetailsView to load the correct data.
2669 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2670 primary key value field and set in constructor. Pass primary key
2671 value to getDetailsData().
2672 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2673 variables for document title and primary key value.
2674 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2675 key value to the DetailsPlace.
2677 2011-06-24 Ben Konrath <ben@bagu.org>
2679 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2681 This allows the primary key to be retrieved by the Details button. This
2682 functionality has not been implemented yet but it's in the works.
2684 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2685 the LayoutGroup result to ListView.setCellTable instead of all of its
2686 fields individually.
2687 * src/main/java/org/glom/web/client/ui/ListView.java:
2688 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2689 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2690 get the primary key for the table.
2691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2692 index of the primary key in the LayoutGroup accounting for hidden
2693 primary keys. Rename getJavaNumberFormat() to
2694 convertToJavaNumberFormat() for consistency. Cleanup / add some
2696 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2697 field for primary key index and a field to indicate whether the
2698 primary key is hidden or not.
2700 2011-06-23 Ben Konrath <ben@bagu.org>
2702 Rename getTableData methods to getListData.
2704 This is a rename refactor for consistency with other methods.
2706 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2707 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2708 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2709 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2711 2011-06-23 Ben Konrath <ben@bagu.org>
2713 Extract the ConfiguredDocument innerclass into its own class.
2715 This makes the servlet code more object oriented.
2717 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2718 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2719 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2720 new ConfiguredDocument class.
2722 2011-06-21 Ben Konrath <ben@bagu.org>
2724 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2726 This makes things more inline with how libglom works and reduces code
2727 duplication. This refactor lays the groundwork for adding the primary key to
2728 the LayoutGroup object.
2730 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2731 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2732 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2733 Change method names to getListLayout and getDefaultListLayout for
2734 consistency. Use LayoutGroup as the DTO for the list layout instead of
2735 ColumnInfo and LayoutListTable.
2736 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2737 new method names along with the LayoutGroup object for transferring the
2739 * src/main/java/org/glom/web/client/ui/ListView.java:
2740 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2741 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2742 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2744 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2745 Replaced with LayoutGroup.
2746 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2747 expectedResultSize and defaultTableName fields which are needed for
2749 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2750 type field which is needed for the list layout but will also be
2751 useful for the details layout as things progress.
2752 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2753 Make class abstract. Remove the unnecessary
2754 getFormattingHorizontalAlignment method. Add setFormatting method.
2756 2011-06-16 Ben Konrath <ben@bagu.org>
2758 Add scripts for building and installing war.
2760 These will help when updating OnlineGlom but they're also good
2761 supplemental documentation of the build and deployment proceeding.
2763 * utils/build-onlineglom-war.sh: New file.
2764 * utils/install-onlineglom-war.sh: New file.
2766 2011-06-16 Ben Konrath <ben@bagu.org>
2768 Create wrapper class to create consistent log messages.
2770 I wrapped methods in the Log class of gwt-log to add the method names
2771 from the servlet and create consistent formatting of the document title
2772 and table names in the log messages.
2774 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2776 log methods to use methods from wrapped Log class.
2778 2011-06-16 Ben Konrath <ben@bagu.org>
2780 Remove superfluous conditional return.
2782 Thanks to Murray Cumming for pointing this out!
2784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2786 2011-06-15 Ben Konrath <ben@bagu.org>
2788 Return an ArrayList of LayoutGroups for the Details layout.
2790 This corrects a problem with the details layout as it can have more
2791 than one top level LayoutGroup.
2793 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2794 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2795 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2796 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2797 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2798 with ArrayList of LayoutGroups for the details view layout.
2799 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2800 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2801 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2802 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2803 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2804 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2806 2011-06-14 Ben Konrath <ben@bagu.org>
2808 Use cast_dynamic method to determine the libglom LayoutItem type.
2810 This is better than finding the LayoutItem type by using the string
2811 returned from the get_part_type_name() method.
2813 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2815 2011-06-14 Ben Konrath <ben@bagu.org>
2817 Add method names to log entries in the servlet.
2819 This helps when tracking down deployment problems.
2821 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2823 2011-06-14 Ben Konrath <ben@bagu.org>
2825 Add data to the DetailsView using a hard-coded primary key value.
2827 The layout and functionality of the DetailsView is not complete. This
2828 is just a checkpoint so the patch doesn't get too big.
2830 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2831 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2832 Add getDetailsData() servlet method.
2833 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2834 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2835 LayoutFields are added to the DetailsView.
2836 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2837 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2838 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2839 take the string for the title instead of the object.
2840 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2841 Add implementation getDetailsData() along with some private helper
2843 * src/main/webapp/style.css: Add padding to details-data class. Add a
2844 details-label class with the same padding as the details-data class.
2846 2011-06-03 Ben Konrath <ben@bagu.org>
2848 Use presenter.goTo() to change to the DetailsPlace.
2850 This will make things easier when we need to open the DetailsView with
2851 data specific to the row that was clicked.
2853 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2855 2011-06-02 Ben Konrath <ben@bagu.org>
2857 Add CSS file from mockups.
2859 I'm adding this now because it's going to be useful to have when
2860 developing the DetailsView. The TableSelectionView and ListView aren't
2863 * src/main/webapp/OnlineGlom.html:
2864 * src/main/webapp/style.css:
2866 2011-06-02 Ben Konrath <ben@bagu.org>
2868 Use String.isEmpty() to check for empty string.
2870 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2872 2011-06-02 Ben Konrath <ben@bagu.org>
2874 Display main layout group titles in the DetailsView.
2876 This is the start of the DetailsActivity/DetailsView implementation.
2878 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2879 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2880 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2881 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2882 Get the layout information for the details view from the server and set
2883 the main layout group titles.
2884 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2885 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2886 Add addLayoutGroup() and addLayoutField() methods. This are just
2887 temporary methods for creating the the details view that will change
2889 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2890 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2892 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2893 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2894 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2895 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2896 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2897 Data Transfer Objects that mimic the libglom object structure. These are
2898 used for transferring the details layout but could also be used for
2899 transferring the list layout.
2901 2011-05-27 Ben Konrath <ben@bagu.org>
2903 Reset the AuthenticationPopup when clearing the ListView.
2905 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2907 2011-05-27 Ben Konrath <ben@bagu.org>
2909 Fix problem with onlineglom.properties file loading.
2911 The old way worked in Eclipse but not on the server. Loading the
2912 onlineglom.properties file now works in Eclipse and on the server.
2914 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2916 2011-05-24 Ben Konrath <ben@bagu.org>
2918 Update gwt-log from 3.1.0 to 3.1.2.
2920 Gwt-log 3.1.0 has been marked as depreciated.
2924 2011-05-24 Ben Konrath <ben@bagu.org>
2926 Add comment to ListActivity.goTo() method.
2928 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2930 2011-05-24 Ben Konrath <ben@bagu.org>
2932 Remove FIXME in convertGdkColorToHtmlColour()
2934 The Gdk::Color value returned by libglom is 16-bits per channel on both
2935 64 and 32-bit platforms.
2937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2939 2011-05-19 Ben Konrath <ben@bagu.org>
2941 Improve performance of initial ListView load.
2943 I removed a round trip to the server for getting the default table name
2944 and then requesting information about that table. This also removes a potential
2945 problem with the table change handler not being setup in time to receive the
2946 table change event from the ListActivity.
2948 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2949 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2950 getDefaultLayoutListTable() method. Improve comments.
2951 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2952 getDefaultLayoutListTable() method instead of firing a table change
2953 event to get the table to load.
2954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2955 implementation of getDefaultLayoutListTable() method.
2956 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2959 2011-05-19 Ben Konrath <ben@bagu.org>
2961 Override toDebugString() in TableChangeEvent.
2963 This is useful to have for debugging.
2965 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2967 2011-05-19 Ben Konrath <ben@bagu.org>
2969 Add a "Back to List" link when at the DetailsPlace.
2971 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2972 Populate the CellTable based on the selected table of the ListBox if
2973 it's set otherwise use the default table. This allows the "Back to
2975 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2976 Remove Place from constructors. Add a setPlace() method. Add
2977 goToPlace() method. Set class as presenter for TableSelectionView.
2978 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2979 Use the same TableSelectionActivity when switching between the List and
2981 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2982 Subclass the new HasSelectableTablePlace. This removes some duplicate
2984 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2985 New class to represent Places that display the TableSelectionView.
2986 * src/main/java/org/glom/web/client/place/ListPlace.java:
2987 Subclass the new HasSelectableTablePlace. This removes some duplicate
2989 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2990 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2991 Add Presenter interface. Add setBackLinkVisible() method. Add
2992 setBackLink() method.
2994 2011-05-18 Ben Konrath <ben@bagu.org>
2996 Enable the "Details" buttons.
2998 Right now only an empty details view is displayed.
3000 * src/main/java/org/glom/web/client/ClientFactory.java:
3001 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3002 Add DetailsView to ClientFactory.
3003 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3004 A basic activity for the details view.
3005 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3006 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3008 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3009 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3011 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3012 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3013 unnecessary super() in constructor.
3014 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3015 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3016 really shouldn't create a new TableSelectionActivity for both the ListPlace
3017 and the DetailsPlace so this should be considered a temporary solution.
3018 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3019 New file. Represents a URL for the details view.
3020 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3021 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3022 A basic details view interface and implementation.
3023 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3024 Enable the "Details" buttons.
3026 2011-05-12 Ben Konrath <ben@bagu.org>
3028 Use a LayoutPanel with multiple display areas for main layout.
3030 This is mostly a refactor in that there are no changes from the user
3031 point of view. These changes are required so that we can swap out the list view
3032 with the details view when the user clicks the "Details" button.
3034 * src/main/java/org/glom/web/client/ClientFactory.java:
3035 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3036 OnlineGlomView. Add TableSelectionView, ListView and
3037 AuthenticationPopup.
3038 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3039 for main layout. Add display regions for main activities. Add
3040 activity manager for for main activities.
3041 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3042 file from parts of the deleted OnlineGlomActivity.
3043 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3044 New file from parts of the deleted OnlineGlomActivity.
3045 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3046 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3047 New files for app wide table change event.
3048 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3049 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3050 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3051 Activity mappers for the main activities replace the deleted app-wide
3053 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3054 Fix a spelling error in he comment.
3055 * src/main/java/org/glom/web/client/ui/ListView.java:
3056 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3057 Renamed from LayoutListView and modified for MVP. This still not a
3058 proper dumb view as prescribed by the MVP pattern but it works for now.
3059 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3060 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3061 New widget stripped out of the deleted OnlineGlomView.
3062 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3063 Remove hack that is fixed by this patch.
3065 2011-05-06 Ben Konrath <ben@bagu.org>
3067 Rename OnlineGlomPlace to ListPlace.
3069 The only change besides the rename is that url will now display #list
3070 instead of #Document.
3072 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3073 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3074 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3075 * src/main/java/org/glom/web/client/place/ListPlace.java:
3076 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3078 2011-05-06 Ben Konrath <ben@bagu.org>
3080 Use Presenter for app navigation.
3082 This is the proper way to deal with Place (URL) changes with the MVP
3085 * src/main/java/org/glom/web/client/ClientFactory.java:
3086 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3087 PlaceHistoryMapper and PlaceHistoryHandler.
3088 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3089 PlaceHistoryMapper and PlaceHistoryHandler.
3090 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3091 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3092 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3093 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3094 Add Presenter interface and setPresenter methods. Rename addHyperLink
3095 to addDocumentLink taking only the document title as a parameter.
3097 2011-04-14 Ben Konrath <ben@bagu.org>
3099 Prompt for db username/password if they haven't been set.
3101 This is implemented with a popup widget that is contained within the
3102 OnlineGlomView and managed by the OnlineGlomActivity.
3104 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3105 methods for checking and setting the database username and password.
3106 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3107 new methods for checking and setting the database username and
3109 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3110 Display authentication popup if the JDBC connection to the database
3111 has not been authenticated.
3112 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3114 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3115 for dealing with the authentication popup.
3116 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3117 Implement the methods for dealing with the authentication popup.
3118 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3119 try to executed queries if the database connection hasn't been
3120 authenticated. Implement methods for checking and setting the
3121 database username and password.
3123 2011-04-12 Ben Konrath <ben@bagu.org>
3125 Make log messages a little clearer.
3127 Add a dash betweeen the document title and the table name.
3129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3131 2011-04-12 Ben Konrath <ben@bagu.org>
3133 Protect against NPEs when cleaning up database resources.
3135 While this isn't strictly necessary because the exception is caught,
3136 not protecting against the NPEs makes it harder to find the real error
3139 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3141 2011-04-12 Ben Konrath <ben@bagu.org>
3143 Move configuration of the servlet to the constructor.
3145 The servlet will be initialized even if the database authentication
3146 information is not set or correct. I still need to add the UI for prompting
3147 the user for the authentication information when it's required.
3149 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3150 javadocs for getDocumentTitles() method.
3151 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3152 Set error message when RPC fails.
3153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3154 glom files directory from the configuration file. Try to set the
3155 database authentication information for the specific document if it's
3156 set and works otherwise try to use the global authentication
3157 information set for the directory.
3158 * src/main/resources/onlineglom.properties: Moved from
3159 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3160 Added detailed comments for the new keys.
3162 2011-04-11 Ben Konrath <ben@bagu.org>
3164 Remove unnecessary @Override in DocumentSelectionViewImpl.
3166 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3168 2011-04-11 Ben Konrath <ben@bagu.org>
3170 Remove center alignment in DocumentSelectionView.
3172 The title element is still centred but the document titles and bottom
3173 sentence are both left-aligned.
3175 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3177 2011-04-11 Ben Konrath <ben@bagu.org>
3179 Change 'Demo' naming convention to 'Document'.
3181 This is just a rename refactor with no functional changes to the code.
3183 * src/main/java/org/glom/web/client/ClientFactory.java:
3184 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3185 * src/main/java/org/glom/web/client/OnlineGlom.java:
3186 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3187 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3188 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3189 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3190 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3191 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3192 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3193 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3194 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3195 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3197 2011-04-08 Ben Konrath <ben@bagu.org>
3199 Remove FIXME from safeLongToInt() method.
3201 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3204 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3206 2011-04-08 Ben Konrath <ben@bagu.org>
3208 Display an error if no glom documents are found in the specified directory.
3210 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3211 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3212 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3215 2011-04-08 Ben Konrath <ben@bagu.org>
3217 Add copyright header to one more file ... oops.
3219 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3221 2011-04-08 Ben Konrath <ben@bagu.org>
3223 Add copyright header to files without it.
3225 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3226 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3227 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3228 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3229 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3230 * src/main/java/org/glom/web/shared/GlomField.java:
projects / online-glom:gwt-glom.git / blob