Added OnlineGlomPropertiesTest.
[online-glom:gwt-glom.git] / ChangeLog
1 2012-06-22  Murray Cumming  <murrayc@murrayc.com>
2
3         Added OnlineGlomPropertiesTest.
4
5         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
6         Make sure we never return a null string.
7         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
8         Added tests of the OnlineGlomProperties API, using our sample file.
9
10 2012-06-20  Murray Cumming  <murrayc@murrayc.com>
11
12         Make OnlineGlomProperties be a normal class.
13
14         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
15         Move OnlineGlomProperties into its own file to be a regular class:
16         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
17         This makes testing simpler.
18
19 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
20
21         OnlineGlomServiceImpl.init(): Move some code into a new method.
22
23         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
24         Create addDocument().
25
26 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
27
28         OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
29
30         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
31         OnlineGlomProperties.getKey(): Make this more robust by moving the
32         check for *.*.filename to here.
33
34 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
35
36         OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
37
38         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
39         init(): Move knowledge of the config file format into the 
40         OnlineGlomProperties inner class.
41
42 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
43
44         SelfHostExampleTest: Make sure we cleanup on failure.
45
46         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
47         the use of cleanup() to a tearDown() JUnit method.
48
49 2012-06-12  Murray Cumming  <murrayc@murrayc.com>
50
51         ConfiguredDocument: Add a primary key to portals at least once.
52
53         * src/main/java/org/glom/web/server/ConfiguredDocument.java
54         updatePortalsExtras): Fix a typo so that we add the primary key
55         column at least once.
56         This is a fix for the previous commit:
57         ConfiguredDocument: Do not add a primary key to portals each time.
58
59 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
60
61         SelfHoster: Avoid some compiler warnings.
62
63         * src/test/java/org/glom/web/server/SelfHoster.java
64         executeCommandLineAndWait():
65         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
66         the now-unused streams for stdout and stderr from the command Processes.
67         These are not used because readln() hangs while waiting for a new line,
68         where there may be no next line. The commented out code is still there
69         to help us figure out how to do this properly.
70
71 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
72
73         LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
74
75         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
76         Make this actually test the cloning again, though it is not very useful
77         now that we do not use the part that had a problem with cloning before.
78
79 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
80
81         SelfHoster: Keep trying pg_ctl after starting postgres.
82
83         * src/test/java/org/glom/web/server/SelfHoster.java
84         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
85         Try pg_ctl repeatedly (for ever) until it succeeds, as we do in 
86         regular Glom. This seems mad but it seems to work because the first
87         command would fail if pg_ctl would eventually fail.
88
89 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
90
91         SelfHoster: Wait until the server is really ready.
92
93         * src/test/java/org/glom/web/server/SelfHoster.java
94         selfHost(): Attempt the connection after starting the server, retrying 
95         a few times if necessary, so that the server is really ready already when
96         we return from this method.
97         The regular Glom code does this too because pg_ctl reports success too soon.
98
99 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
100
101         ConfiguredDocument: Do not add a primary key to portals each time.
102
103         * src/main/java/org/glom/web/server/ConfiguredDocument.java
104         updatePortalsExtras(): Only add an extra primary key field if there is 
105         none, to avoid adding one each time we retrieve the details layout from the
106         layouts cache.
107         This should fix bug #676986 (Ben Konrath) 
108
109 2012-05-25  Murray Cumming  <murrayc@murrayc.com>
110
111         Document.load(): Support version 7 documents. 
112
113         * src/main/java/org/glom/web/server/libglom/Document.java: Load the 
114         database_title attribute if the title attribute is not there.
115         Bug #676737
116
117 2012-05-24  Ben Konrath  <ben@bagu.org>
118
119         Add configuration for auto-generating mvn:i18n from with Eclipse.
120
121         * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
122
123 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
124
125         Update translations, adding French.
126
127         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
128         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
129         Add a French translation, using the translation from Glom.
130
131         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
132         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
133         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
134         Update these based on the translations from Glom.
135
136 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
137
138         SelfHoster: Add some debug println messages to help when things fail.
139
140         * src/test/java/org/glom/web/server/SelfHoster.java: Add several
141         System.out.println() lines.
142
143 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
144
145         Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
146
147         * src/test/java/org/glom/web/server/SelfHoster.java:
148         getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for 
149         instance) instead of just /usr/bin (as on Fedora). Check the result when 
150         using this method.
151
152 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
153
154         Remove LayoutItemPortal.get/setNavigationTable().
155         
156         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
157         Remove get/setNavigationTable(), which is only a cache, because it is not
158         used, and does not need to be used, because that decision should be made on
159         the server.
160         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
161         updatePortalsExtras():
162         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
163         getNavigationRecord():
164         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
165         Adapted.
166
167 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
168
169         Initial self-hosting for tests.
170
171         * pom.xml: Change the scope for log4j, to hopefully make it 
172         available to the test code which uses it indirectly via jOOQ.
173         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
174         self-hosting, though we only use it for testing.
175
176         * src/main/java/org/glom/web/server/libglom/Document.java:
177         example rows: Use a map instead of a list for each row of values,
178         so we know what field they are for, instead of relying on the sequence
179         being correct. This is not very efficient, but it does not really need 
180         to be.
181         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
182         testReadTableExampleRows(): Adapted.
183
184         * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
185         that returns an Object, for generic use. Note that Object seems to be 
186         the implicit base even of double.
187         * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
188         for use in CREATE TABLE SQL queries.
189         * src/test/java/org/glom/web/server/SelfHoster.java: Add this class 
190         to do self-hosting of PostgreSQL databases via its command-line 
191         utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
192         backends/postgres_self.cc. This is incomplete - it needs more 
193         warnings about failures and it needs to clean up properly when things
194         fail.
195         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple 
196         test of this new class.
197
198 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
199
200         Document: loading example data: Handle exceptions.
201
202         * src/main/java/org/glom/web/server/libglom/Document.java:
203         DateFormat.parse() and Double.valueOf() can throw exceptions, though
204         Eclipse did not warn about that.
205
206 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
207
208         Document: load(), save(): Handle the example rows.
209
210         * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate() 
211         and get/setImage().
212         * src/main/java/org/glom/web/server/libglom/Document.java:
213         load(), save(): Load and save the example rows, though the date, time
214         and image types are not handled properly yet.
215         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
216         Add testReadTableExampleRows() just to check that something is read.
217
218 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
219
220         Document: Add save().
221
222         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
223         Added getTranslationsMap() for use while saving.
224         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
225         Adedd getUseDefaultFormatting() for use while saving.
226         * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
227         and several private methods that it uses.
228
229         This will be useful while testing via self-hosting.
230         It is not complete, but should be complete enough for testing.
231
232 2012-05-17  Murray Cumming  <murrayc@murrayc.com>
233
234         OnlineGlomService: Simplify the getList/RelatedViewData() methods.
235
236         * src/main/java/org/glom/web/client/OnlineGlomService.java
237         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
238         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
239         Remove getSortedListViewData() and getSortedRelatedListData(), adding
240         the sort column index and ascending bool to the regular method.
241         Instead, a sort column index of -1 now means no sort.
242         This is less explicit, but it's fairly simple, reduces the amount of 
243         code, and makes the OnlineGlomService API slightly smaller.
244         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
245         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
246         getDataProvider():
247         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
248         getListViewData(), getRelatedListData():
249         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
250         getListViewData(), getRelatedListData():
251         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
252         getListData():
253         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
254         getData():
255         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
256         getData(): Adapted.
257
258 1.21.9.2:
259
260 2012-05-16  Murray Cumming  <murrayc@murrayc.com>
261
262         Use translations for top-level groups too.
263
264         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
265         updateTitlesForLocale(): Use the translation for the group 
266         as well as for child items.
267
268 1.21.9.1:
269
270 Just recompiled to fix a problem in the released .tar.gz file.
271
272 1.21.9:
273
274 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
275
276         Corrections to navigation to related records.
277         
278         * src/main/java/org/glom/web/client/OnlineGlomService.java:
279         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
280         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
281         getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
282         getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a 
283         relationship name, because the relationship name is not necessarily unique 
284         on the layout.
285         TOOD: This is inefficient, because it passes the whole list of 
286         child field items back to the server, but it is more correct, and happens
287         to fix a bug with the primary key being lost after a few navigations.
288         There is probably a chance to make this more efficient anyway in some 
289         more basic way.
290         
291         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
292         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
293         * src/main/java/org/glom/web/server/ConfiguredDocument.java
294         * src/main/java/org/glom/web/server/database/DBAccess.java
295         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
296         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
297         Adapted.
298
299 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
300
301         Fix the use of translations.
302
303         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
304         Add updateTitlesForLocale().
305         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
306         Call it to discard unwanted translations and to make getTitle() return
307         the wanted translation wihout the need for the client code to specify a locale.
308         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
309         getTitle(): Fallback to the original title, as libglom does.
310
311 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
312
313         Document: Correctly report the number of available translation locales.
314
315         * src/main/java/org/glom/web/server/libglom/Document.java: Fill
316         the available locale IDs list.
317         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
318         testLocales: Test this.
319
320 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
321
322         SqlUtils: Use camelCase.
323
324         * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
325         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
326         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
327         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
328         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
329         * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
330
331 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
332
333         Use jOOQ's tableByName() and fieldByName.
334
335         * pom.xml: Use jOOQ 2.3.1 to get the new API.
336         * src/main/java/org/glom/web/server/SqlUtils.java:
337         build_sql_select_step_with_where_clause(), .createField(),
338         builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
339         so we can get correct quoting and escaping. Thanks to Lukas Eder for 
340         adding this, and other things, to jOOQ.
341
342 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
343
344         SqlUtils: Remove the Connection parameters.
345
346         * src/main/java/org/glom/web/server/SqlUtils.java:
347         build_sql_select_with_key(), build_sql_select_with_where_clause(),
348         createSelect(), build_sql_select_step_with_where_clause(),
349         build_sql_count_select_with_where_clause(),
350         build_sql_select_count_rows(): Remove the Connection parameter because
351         jOOQ does not actually need a connectionwhen it is just used to build 
352         a SQL string:
353         https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
354
355         * src/main/java/org/glom/web/server/ReportGenerator.java:
356         generateReport():
357         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
358         getData():
359         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
360         Constructor, getListData(), getResultSizeOfSQLQuery():
361         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
362         getSelectQuery(), getCountQuery():
363         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
364         getSelectQuery(), getCountQuery():
365         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
366         getNavigationRecord(): Adapted.
367
368 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
369
370         Fix quick find.
371
372         * src/main/java/org/glom/web/server/SqlUtils.java:
373         get_find_where_clause_quick(): Use a comparison of 
374         lowercase values, instead of a simple equals. Regular Glom
375         uses the PostgreSQL ILIKE operator but jOOQ does not 
376         support that just yet, though it will soon.
377
378 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
379
380         TableToViewDetails: Use a real serialization ID.
381
382         * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
383         Though this does not fix the serialization problem.
384
385 2012-05-12  Murray Cumming  <murrayc@murrayc.com>
386
387         Added LayoutItemPortalDeepCloneTest.
388
389 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
390
391         Make navigation work again.
392
393         * src/main/java/org/glom/web/server/libglom/Document.java:
394         Add getLayoutItemFieldShouldHaveNavigation().
395         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
396         Replace get/setAddNavigation() with the partly-existing 
397         get/setNavigationTableName(), with an empty string being no navigation,
398         because this is simpler. Use the new 
399         Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
400         
401         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
402         Add updateFieldsExtras() and call setNavigationTableName in it.
403         getDetailsLayoutGroup(), 
404         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
405         createLayout(): Adapted.
406         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
407         Constructor: Adapted.
408
409         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
410         Replace get/setAddNavigation() with get/setNavigation(), returning a
411         TableToViewDetails class with both the table name and UsesRelationship,
412         because both are need. The previous code used java-libglom's output 
413         variable (strangely, via sharedptr) to return both, but we cannot really
414         do that in Java.
415         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
416         getNavigationRecord(): Adapt. However, we cannot actually use the cache
417         here because it somehow gets set to null during deepCopy(). I must test this.
418         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
419         testGetSuitableTableToViewDetails(): Adapted.
420         
421         TODO: Find out why deepClone() is not quite working.
422         
423 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
424
425         DBAccess: Simplify the retrievel of full field details.
426
427         * src/main/java/org/glom/web/server/database/DBAccess.java
428         getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
429         because the Document loading should have done this.
430
431 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
432
433         Document: Correct loading of doubly-related layout fields.
434
435         * src/main/java/org/glom/web/server/libglom/Document.java:
436         loadUsesRelationship(): Actually set the related relationship, instead
437         of only setting it if it's not found.
438
439 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
440
441         Replace all appearances of Colour with color.
442
443         Because US English is dominant.
444
445 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
446
447         Use colors in HTML format, solving a warning about an unused function.
448
449         * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
450         * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
451         Add *asHTMLColor() versions of methods.
452         TODO: However, we should create and cache the results on the server.
453         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
454         * src/main/java/org/glom/web/client/ui/list/ListTable.java
455         * src/main/java/org/glom/web/server/ConfiguredDocument.java
456         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
457         Use the asHTMLcolor() versions.
458
459 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
460
461         ListViewTable: Constructor: Take the table name as a parameter.
462
463         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
464         Constructor: Take the tableName, and set the member variable, because
465         we use it here.
466         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
467         setCellTable(): Pass the table name.
468         This makes navigation to non-default tables work again. I don't know 
469         why it worked before in the master branch.
470
471 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
472
473         ConfiguredDocument: Restore correct addition of hidden primary key items.
474
475         * src/main/java/org/glom/web/client/ui/list/ListTable.java
476         (ListTable.createCellTable): Uncomment out the check for the hidden
477         primary key.
478         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
479         add primary key items for top-level lists and portals, as before, 
480         instead of adding them to each group.
481         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
482         Actually implement the extra methods such as setHiddenPrimaryKey() and
483         comment that these are used only for top-level list groups and in portals.
484         This strangeness suggests even more that this should not be squeezed
485         into the LayoutGroup class.
486
487 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
488
489         Fix Formatting loading.
490
491         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
492         getFormattingUsed(): Remove the duplicate Formatting member variable
493         in favour of the one from the base class.
494         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
495         Initialize a new Formatting instead of using null by default, so we 
496         have some defaults, instead of having to initialize one later just to 
497         get the same defaults. This also makes loading of formatting from the
498         document work, because that expected a non-null.
499
500 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
501
502         RelatedListTable: Make sure that the tableName is set.
503
504         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
505         Constructor: Take the tableName so it is available later. Otherwise, 
506         the server assumes that we mean the default table and cannot find the
507         relationship in it.
508         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
509         setData(): Pass the tableName to the RelatedListTable constructor.
510
511 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
512
513         Add some checks.
514
515         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
516         RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
517         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
518         getDataProvider():
519         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
520         addColumn():
521         * src/main/java/org/glom/web/server/database/DBAccess.java:
522         convertResultSetToDTO(), getPortal():
523         * src/main/java/org/glom/web/server/database/ListDBAccess.java
524         getListData():
525         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
526         Add checks for null objects and out of range access, with log messages to
527         give hints so we can fix these properly.
528
529 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
530
531         Portals: some corrections.
532
533         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
534         setData():
535         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
536         constructor: Use getRelationshipNameUsed() instead of getName(), because
537         that is what is meant.
538         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
539         getFromField(): Fix a typo, to get the field name, not the table name.
540         * src/main/java/org/glom/web/server/database/DBAccess.java:
541         getPortal(): Fix a typo that stopped this from working.
542
543 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
544
545         LayoutItemPortal: Also override getTitleOriginal().
546
547         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
548         This lets the base getTitle() with no parameters work.
549         TODO: Test this properly.
550
551 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
552
553         LayoutItemPortal: getTitle*(): Use the relationship title.
554
555 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
556
557         LayoutItemField: Fix loading of custom titles.
558
559         * src/main/java/org/glom/web/server/libglom/Document.java
560         loadDataLayoutItemField(): The title, if any, instead of the field 
561         title, is stored in a title_custom node. Load it from there.
562         * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
563         class.
564         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
565         Add getCustomTitle() and use it, instead of super.getTitle*(), in the
566         getTitle*() overrides.
567         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
568         Adapt.
569
570 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
571
572         LayoutItemField: Fall back to field titles, so some are really shown.
573
574         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
575         Override getTitleOriginal() and getTitle(), as in java-libglom.
576         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
577         Test this behaviour.
578
579 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
580
581         Correct use of setExpectedResultSize().
582
583         * src/main/java/org/glom/web/server/ConfiguredDocument.java
584         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
585         Use setExpectedResultSize only on top-level groups (for instance, the
586         list layout) or on child portals (in details views).
587         Use the correct table name for portals to avoid SQL errors.
588         Update the expected counts when returning cached layouts.
589
590 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
591
592         Document: Interpret no group column count as 1.
593
594         * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
595         default, though we now check for this in the UI code anyway.
596
597 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
598
599         More null checks.
600
601 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
602
603         Translatable: Use Hashmap instead of Treemap because GWT supports it.
604
605         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
606         The use of Treemap lead to this error from async methods, with no 
607         further clue:
608         "The response could not be deserialized"
609
610 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
611
612         OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
613
614         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary 
615         when using the Google -> GWT Compile, or 
616         g toolbar button -> GWT Compile Project... feature in Eclipse.
617
618 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
619
620         ListTable.addColumn(): Protect against a null Formatting.
621
622         * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
623         Create a default Formatting if it is null, because that is the simplest
624         way to do this.
625
626 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
627
628         ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
629
630         * src/main/java/org/glom/web/server/ConfiguredDocument.java
631         updateLayoutGroup(): Check that the field is not null.
632
633 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
634
635         ListViewImpl: Protected against a bad cast error.
636
637         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
638         onEnterKeyDown(): Do not cast without an instanceof check.
639
640 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
641
642         ListTable: Protect against an out of range error.
643
644         * src/main/java/org/glom/web/client/ui/list/ListTable.java
645         createCellTable(): This is unlikely, but can happen while debugging.
646
647 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
648
649         AsyncMessage onFailure() callbacks: Log the exception message.
650
651         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
652         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
653         * src/main/java/org/glom/web/client/activity/ListActivity.java:
654         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
655         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
656         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
657         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
658         These are useful clues when something is wrong.
659
660 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
661
662         ConfiguredDocument: Avoid a null dereference.
663
664         * src/main/java/org/glom/web/server/ConfiguredDocument.java
665         TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and 
666         details maps are created.
667
668 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
669
670         Document: Correct the port number parsing.
671
672         * src/main/java/org/glom/web/server/libglom/Document.java:
673         This lets us actually connect to the database and show the document.
674
675 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
676
677         Fix mvn gwt:test
678
679         * pom.xml: Use htmlunit mode for gwt:test, because the default demands
680         user-interaction, asking us to load a temporary URL in a browser.s
681         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
682         which is apparently necessary for testing the service. See the comment.
683         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java: 
684         Show the exception, if any. This is how I saw the 404 in the HTML in 
685         the exception.
686
687 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
688
689         DocumentTest: Move the .glom files into the resources directory.
690
691         * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
692         URI via getResource().
693
694 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
695
696         Document: Remove the FieldIdentifies inner class.
697
698         * src/main/java/org/glom/web/server/libglom/Document.java: We only
699         use the Relationship (though the same function in libglom is maybe
700         used in other ways) and so this removes a compiler warning.
701
702 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
703
704         Document.load() Remove the error code parameter.
705
706         * src/main/java/org/glom/web/server/libglom/Document.java: load():
707         Remove the parameter. We do not set it yet and it could never have
708         worked as an output parameter (though maybe it did in java-libglom).
709         We could use an exception if we really want the failure reason.
710         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
711         init():
712         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
713         setUp(), testGetSuitableTableToViewDetails(): Adapt.
714
715 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
716
717         Make some inner classes static.
718
719         * src/main/java/org/glom/web/server/ConfiguredDocument.java
720         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
721         * src/main/java/org/glom/web/server/ReportGenerator.java
722         * src/main/java/org/glom/web/server/libglom/Document.java
723         Make all inner classes static that can be static.
724
725 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
726
727         OnlineGlomServiceImpl: Do not load and check for java-libglom.
728
729         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
730         init(): We do not use java-libglom any more.
731
732 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
733
734         Remove mentions of java-libglom.
735
736         * README: Remove mention of java-libglom, because it no longer needed.
737         * utils/build-onlineglom-war.sh:
738         * utils/check-and-recover-tomcat.py:
739         * utils/install-onlineglom-war.sh: Remove these as they are no longer
740         useful. Building is now far easier, with no need for jhbuild.
741
742 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
743
744         Fix the build (mvn package)
745
746         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
747         (LayoutGroup): Make the LayoutItemList inner class static and protected.
748         Otherwise the GWT Java->Javascript compilation fails with just this
749         error, during mvn package or when attempting to view in a browser, 
750         in the GWT developer mode in Eclipse.
751
752         [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
753         [INFO] auto discovered modules [org.glom.web.OnlineGlom]
754         [INFO] Compiling module org.glom.web.OnlineGlom
755         [INFO]    [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
756         [INFO]       [ERROR] Line 46:  Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
757         [INFO]    Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
758         [INFO]       [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
759         [INFO]          [WARN] org.glom.web.client.OnlineGlomService_Proxy
760         [INFO]    [ERROR] Cannot proceed due to previous errors
761
762         It has taken me 2 days to find out what was causing that. After reducing
763         the code, the compiler eventually showed me the full error message.
764
765 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
766
767         ConfiguredDocument: Cache the cloned and stripped layouts.
768
769         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
770         getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
771         layout in a map, so we can retrieve it again without rebuilding it.
772
773 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
774
775         UsesRelationshipImpl: Complete the relationshipEquals() implementation.
776
777 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
778
779         libglom classes: Implement some auto-generated emthods.
780
781 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
782
783         Add GwtTestOnlineGlomService.
784
785         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
786         However, this (and the other GwtTest*) does not seem to run during 
787         mvn test. 
788
789 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
790
791         Remove use of unsupported features from client code.
792
793         * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
794         * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
795         * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
796         Use our client version of StringUtils instead of the apache commons one.
797         
798         However, the GWT Javascript compliation still fails.
799
800 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
801
802         Add a Field class and implement some loading of it in Document.
803
804 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
805
806         Initial Document loading implementation, instead of libglom.
807
808         * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
809         and Translatable classes, and adapt the rest of the code to use them.
810         However, this is still missing Layout and Field classes and loading.
811
812 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
813
814         Use of jOOQ: Move Field creation into a utility method.
815
816         * src/main/java/org/glom/web/server/SqlUtils.java:
817         This lets us improve it more easily.
818
819 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
820
821         Use of jOOQ: Improve the code to COUNT a sub-select.
822
823         * src/main/java/org/glom/web/server/SqlUtils.java:
824         Move initial query creation into 
825         build_sql_select_step_with_where_clause().
826         build_sql_select_count_rows(): Use the jOOQ API instead of
827         concatentating text, because a jOOQ Select*Step is a TableLike,
828         which is what from() takes.
829
830 2012-04-23  Murray Cumming  <murrayc@murrayc.com>
831
832         Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
833
834         * pom.xml: Depend on jooq.
835         * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
836         methods with jOOQ, based on the C++ implementations in libglom,
837         with some changes to the logic required by jooQ.
838         Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
839         where clause.
840         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
841         * src/main/java/org/glom/web/server/ReportGenerator.java:
842         * src/main/java/org/glom/web/server/SqlUtils.java:
843         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
844         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
845         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
846         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
847         * src/main/java/org/glom/web/server/database/RelatedListNavigation:
848         Adapt. In particular, the SqlUtils methods now need to take a Connection,
849         because jOOQ needs that, though it seems unnecessary.
850
851         This is not quite finished. Ideally jOOQ would help us to build 
852         table_name.field_name names, quoting and escaping them properly.
853         See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
854
855 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
856
857         Move use of Glom.build_sql*() into a new SqlUtils class.
858
859         * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
860         to wrap Glom.build_sql*(). The parameter types are still Glom one,
861         but this will make it easier to start using something other than 
862         libglom or SqlBuilder.
863
864 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
865
866         Update the project URL.
867
868         * pom.xml: Use an OnlineGlom-specific URL for the project URL.
869
870 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
871
872         Main layout: Use a FlowTable instead of absolute positioning.
873
874         * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
875         The RootLayoutPanel is a (extends) AbsolutePanel, so each of its 
876         child panels/widgets must have an absolute position. But that is annoying, so
877         this adds a FlowTable and puts the child panels in there.
878
879 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
880
881         GwtTestOnlineGlom: Comment out unused code.
882
883         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
884         Eclipse has started to say that some code is unused.
885
886 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
887
888         Update to the latest versions of dependencies.
889
890         * pom.xml: Update version numbers of dependencies to the latest
891         versions.
892         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
893         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
894         * src/main/java/org/glom/web/server/ReportGenerator.java:
895         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
896         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
897         * src/main/java/org/glom/web/server/database/RelatedListNavigation.
898         java:
899         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
900         Modify the imports where necessary.
901
902 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
903
904         Style: Remove overflow:hidden from searchbox
905
906         * src/main/webapp/style.css: Because this pushes the Back To Link
907         label/link on to the next row, which is then hidden due to the 
908         hard-coded (in ems) height.
909
910 2012-04-20  Murray Cumming  <murrayc@murrayc.com>
911
912         Remove some duplicate code.
913
914         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
915         getDocumentInfo(): This must have been duplicated during the merge from the
916         reports branch.
917
918 1.21.8.1:
919
920 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
921
922         Reports: Localize the waiting for report message.
923
924         * src/main/java/org/glom/web/client/activity/ReportActivity.java
925         start(): Get the message from the contants.
926         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
927         Add the string here.
928         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
929         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
930         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
931         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
932         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
933         Update these files with the English text for newer strings for now.
934
935 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
936
937         Reports: Show a message while waiting for the report.
938
939         * src/main/java/org/glom/web/client/ui/ReportView.java
940         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
941         Add setWaitingText(), to show a message saying that we are 
942         waiting for the report to be ready.
943         * src/main/java/org/glom/web/client/activity/ReportActivity.java
944         start(): Call setWaitingText() before calling the async
945         report generation.
946
947 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
948
949         ReportGenerator: Specify date and time formats.
950
951         * src/main/java/org/glom/web/server/ReportGenerator.java:
952         createFieldValueElement(): Use the default (and localized)
953         short formats, though we still need a way to show 4-digit
954         years without providing the format for every locale.
955         * src/main/java/org/glom/web/server/database/DBAccess.java:
956         convertResultSetToDTO(): Use the short formats here too.
957
958 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
959
960         ReportGenerator: Use the correct numeric formatting.
961
962         * src/main/java/org/glom/web/server/ReportGenerator.java
963         createFieldExpression(), createFieldValueElement(): Take the
964         whole LayoutItem_Field instead of just the field name, so
965         we have access to the formatting.
966         createFieldValueElement(): Use JRTextField.setPattern() to
967         specify the numeric formatting, with the help of a 
968         regular DecimalFormat.
969
970 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
971
972         ReportGenerator: Avoid showing null for group by titles.
973
974         * src/main/java/org/glom/web/server/ReportGenerator.java
975         generateReport(): Use setBlankWhenNull() on the field title
976         style too, because this is used for values in group by
977         sections.
978
979 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
980
981         ReportGenerator: Add a colon to titles in vertical groups.
982
983         * src/main/java/org/glom/web/server/ReportGenerator.java
984         addFieldToDetailBandVertical(): Pass true for the withColon
985         parameter.
986
987 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
988
989         ReportGenerator: Simplify the code by using Position more.
990
991 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
992
993         Reports: Support vertical groups, roughly.
994
995         * src/main/java/org/glom/web/server/ReportGenerator.java:
996         addToReport(): Rename to addGroupToReport() and, if necessary,
997         call the new addVerticalGroupToReport() method.
998         createFieldValueElement(): Let the caller specify the Y position
999         too.
1000
1001 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1002
1003         Reports: Allow a second report to be shown.
1004
1005         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1006         clear(): Do not remove the HTML widget, which broke the whole layout.
1007
1008 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1009
1010         Locales drop-down: Show that we use English by default.
1011
1012         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1013         fillView(): When we use English, just because that is the default, when
1014         no locale is specified, show that in the Locales drop-down instead of 
1015         just showing the first item.
1016
1017 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1018
1019         Unselect the Report/Locale/Table combo item when appropriate.
1020
1021         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1022         setPlace(): clear reportName if this is not a ReportPlace.
1023         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1024         setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1025         When the provided name is empty, unselect all items, so that none are
1026         indicated. This uses a for loop because I cannot find a single method
1027         to do this.
1028
1029 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1030
1031         Report: Give the user a way to get back to the list.
1032
1033         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1034         start(), setPlace(): Show the Back To List link on reports, and also 
1035         interpret selecting the empty report item as back to list.
1036
1037 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1038
1039         Really show the selected Report name.
1040
1041         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1042         setPlace(): Store the reportName here, if it is that kind of Place.
1043         fillView(): Set the selected Report after filling the list of reports.
1044         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1045         setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1046         null Strings, though we need some way to unselect all ListBox items
1047         in that case.
1048
1049 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1050
1051         ReportGenerator: Try to avoid some problems.
1052
1053         * src/main/java/org/glom/web/server/ReportGenerator.java
1054         addField(): Try to avoid duplicates, and avoid using a null
1055         class type.
1056
1057 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1058
1059         Reports: Use quickFind.
1060
1061         * src/main/java/org/glom/web/client/OnlineGlomService.java;
1062         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1063         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1064         getReportHTML(): Add a quickFind parameter.
1065         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1066         start(): Pass the quickFind parameter.
1067         * src/main/java/org/glom/web/server/ReportGenerator.java
1068         generateReport(): Take a quickFind parameter.
1069
1070 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1071
1072         ReportPlace: Actually use the report name.
1073
1074         * src/main/java/org/glom/web/client/place/ReportPlace.java
1075         getPlace(): Do not assign the report name to the quickfind.
1076
1077 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1078
1079         Show java.library.path when complaining.
1080
1081         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1082         init(): When telling us to check java.library.path, show the
1083         current value.
1084
1085 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1086
1087         ReportGenerator: Do not show nulls.
1088
1089 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1090
1091         ReportGenerator: Make the title font larger.
1092
1093 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1094
1095         ReportGenerator: Put field titles inside groups, if there are groups.
1096
1097 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1098
1099         ReportGenerator: Take the Report itself instead of the name and group.
1100
1101         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1102         Remove getReportLayoutGroup().
1103         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1104         getReportHTML(): Pass the report instead
1105         of its name and layout group.
1106         * src/main/java/org/glom/web/server/ReportGenerator.java
1107         generateReport(): Use the report object to use the title 
1108         instead of the name.
1109
1110 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1111
1112         ReportGenerator: Remove designBand parameters.
1113
1114         * src/main/java/org/glom/web/server/ReportGenerator.java:
1115         Make designBand a class member instead of passing it to all
1116         methods.
1117
1118 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1119
1120         ReportGenerator: Add lines, a bit like in the desktop version.
1121
1122         * src/main/java/org/glom/web/server/ReportGenerator.java
1123         addToReport(): Use JRDesignLine.
1124
1125 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1126
1127         ReportGenerator: Correct the title positions and use some bold style.
1128
1129         * src/main/java/org/glom/web/server/ReportGenerator.java:
1130         Break the code up into reusable functions, correct the placement of 
1131         titles, and use normal/bold styles as in the reports in the desktop 
1132         version.
1133
1134 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1135
1136         ReportGenerator: Add a header band to show the field titles.
1137
1138         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1139         getReportHTML(): Pass the localeId to the ReportGenerator 
1140         constructor.
1141         * src/main/java/org/glom/web/server/ReportGenerator.java
1142         constructor: Take the localeID so we can get translated field
1143         titles.
1144         generateReport(), addToReport(), addFieldToBand(): Add field 
1145         titles in a column header band.
1146
1147 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1148
1149         Reports drop-down list: Some improvement.
1150
1151         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1152         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1153         Adedd setSelectedReport(),
1154         setReportList(): Add a blank line so that the user can select the 
1155         first one.
1156         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1157         start(): Show the current report by calling setSelectedReport().
1158         This does not seem to work yet.
1159
1160 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1161
1162         DetailsActivity, ListActivity: Move some variables into a base class.
1163
1164         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1165         * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1166         * src/main/java/org/glom/web/client/activity/ListActivity.java: Move 
1167         the clientFactory, documentID, tableName and authenticationPopup into
1168         a base class, to avoid duplication.
1169
1170 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1171
1172         Translate the Reports label.
1173
1174         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1175         Get the "Reports" label string from the constants.
1176         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1177         perties: Add Reports to the constants.
1178
1179 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1180
1181         Reports: Implement grouping.
1182
1183         * src/main/java/org/glom/web/server/ReportGenerator.java:
1184         Handle LayoutItem_GroupBy items and try to do the right thing
1185         with JRDesignGroup. It seems to work.
1186
1187 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1188
1189         Actually show some data with JasperReports.
1190
1191         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: 
1192         getReportHTML(): Move most code into a ReportGenerator class.
1193         * src/main/java/org/glom/web/server/ReportGenerator.java:
1194         Recurse into sub-groups, adding fields to the JasperDesign's details
1195         band. Note that we must set an arbitrary width and height, or it just
1196         will not show any data.
1197
1198 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1199
1200         Reports Chooser: Show the titles, not the names.
1201
1202         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1203         (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1204         and the names as the values.
1205         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1206         (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1207         group now that we provide the report name, so it should always 
1208         succeed.
1209
1210 2012-02-15  Murray Cumming  <murrayc@murrayc.com>
1211
1212         Depend on jasperreports.
1213
1214         * pom.xml: Add the dependency. My plan is to use this on the 
1215         server side.
1216
1217 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1218
1219         Implement navigation to report places.
1220
1221         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1222         start(): Do not bother to handle all events here.
1223         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1224         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1225         Added getSelectedReport().
1226         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1227         .java: start(): When handling a change to the reports chooser,
1228         call getSelectedReport() and goTo() its ReportPlace.
1229         * src/main/java/org/glom/web/client/ui/ReportView.java
1230         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1231         Added setReportHTML() which puts the html in a gwt HTML widget.
1232         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1233         getReportHTML(): Return "TODO" just to show that this works.
1234
1235 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1236
1237         Make ReportPlace usable.
1238
1239         * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1240         Mention ReportPlace.
1241         * src/main/java/org/glom/web/client/place/ReportPlace.java:
1242         Correct the @prefix annotation.
1243
1244 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1245
1246         OnlineGlomService: Return report HTML rather than the LayoutGroup.
1247
1248         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1249         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1250         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1251         Change getReportLayout() to getReportHMTL() because we will not need to 
1252         parse or render the report layout on the client side.
1253         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1254         getReportLayout(): Return the libglom LayoutGroup type because we will
1255         not need to convert to a shared type, because this will not be used on
1256         the client side.
1257         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1258         Adapted.
1259
1260         Note that there is still no implementation for this.
1261
1262
1263 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1264
1265         Add a (empty) Report Place, View, and Activity.
1266
1267         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1268         Rename to:
1269         * src/main/java/org/glom/web/client/place/HasTablePlace.java
1270         * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1271         this into a superclass:
1272         * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1273         and also use it as the base of this new ReportPlace:
1274         * src/main/java/org/glom/web/client/place/ReportPlace.java
1275
1276         * src/main/java/org/glom/web/client/ui/ReportView.java
1277         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1278         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1279         Add these, containing mostly boiler-plate for now.
1280
1281         * src/main/java/org/glom/web/client/OnlineGlomService.java
1282         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1283         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1284         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1285         Add API to get the LayoutGroup for the report.
1286
1287 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1288
1289         Add and fill a Reports drop-down list box.
1290
1291         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1292         Aded getReports():
1293         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1294         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1295         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1296         Added getReports(document, table, localeID), calling 
1297         ConfiguredDocument.getReports().
1298         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1299         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1300         Added setReportsList() and a list widget.
1301         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1302         .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1303
1304
1305 1.21.8:
1306
1307 2012-04-12  Murray Cumming  <murrayc@murrayc.com>
1308
1309         Translations: Add Esperanto.
1310
1311         * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1312         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1313         properties: Add this translation because someone took the time to make it.
1314
1315 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1316
1317         Adapt to the java-libglom 1.21.7 API. 
1318
1319         * src/main/java/org/glom/web/server/ReportGenerator.java:
1320         addToReport(): get_group_secondary_fields() is now
1321         get_secondary_fields().
1322
1323
1324 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1325
1326         Use the latest java-libglom version.
1327
1328         * pom.xml: Use java-libglom 1.21.7.
1329
1330 2012-03-03  Ben Konrath  <ben@bagu.org>
1331
1332         Display date and time in details view.
1333
1334         https://bugzilla.gnome.org/show_bug.cgi?id=671257
1335
1336         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1337
1338 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1339
1340         Require the latest java-libglom.
1341
1342         * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1343
1344 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1345
1346         ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1347
1348         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1349         ListViewDBAccess.getSelectQuery(): Do not create a where clause for 
1350         an empty quickfind string. I also corrected libglom to create only 
1351         empty where clauses for empty quickfind strings, but this avoids the
1352         need for that fix.
1353
1354 2012-02-24  Ben Konrath  <ben@bagu.org>
1355
1356         Improve the tabs in the Notebook widget.
1357
1358         Bug #670728
1359
1360 2012-01-30  Murray Cumming  <murrayc@murrayc.com>
1361
1362         Translations: Try to translate the strings.
1363
1364         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1365         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1366         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1367         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1368         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1369         Take the Open translation from GTK+'s .po files.
1370         Take the Details translation from Glom's po files.
1371         I have added the other strings to Glom so we can get translations that way:
1372         http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1373
1374 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1375
1376         TableSelectionViewImpl: Put the search label and entry in a div.
1377
1378         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1379         Put the search widgets in a FlowTable so that the CSS can be used to
1380         style them while keeping them together.
1381         * src/main/webapp/style.css: Mention the new div.
1382
1383 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1384
1385         Translate more strings in more locales.
1386
1387         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1388         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1389         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1390         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1391         Translate the "Details" and "Open" string too.
1392
1393         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1394         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1395         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1396         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1397         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1398         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1399         Add these new locales as placeholders though they currently contain English.
1400
1401 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1402
1403         OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1404
1405         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1406         Check the ConfiguredDocument* for null before using it.
1407
1408 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1409
1410         Tell Eclipse about the generated java files.
1411
1412         * .classpath: This lets it find OnlineGlomConstants.java.
1413         It would be nice if Eclipse just used the maven build files.
1414
1415 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1416
1417         Prevent a crash when no locale is specified in the URL.
1418
1419         * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1420         Avoid returning a null string, obtained from 
1421         Window.Location.getParameter(). This caused a crash when it was
1422         later passed to libglom's API.
1423         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1424         init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1425         getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1426         guard against future null strings.
1427
1428 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1429
1430         Use the ?locale= query param instead of the &lang= token param. 
1431
1432         * src/main/java/org/glom/web/client/place/ListPlace.java
1433         * src/main/java/org/glom/web/client/place/DetailsPlace.java
1434         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1435         Remove the lang token key and value.
1436         
1437         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1438         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1439         When the user selects a different locale from the chooser, use 
1440         Window.Location.assign() to change the URL, which then causes a reload.
1441         
1442         * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1443         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1444         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1445         * src/main/java/org/glom/web/client/activity/ListActivity.java
1446         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1447         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1448         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1449         * src/main/java/org/glom/web/client/ui/ListView.java:
1450         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1451
1452         Remove localeID member variables and method/constructor parameters, instead
1453         using Utils.getCurrentLocaleID() when we need a localID to pass to 
1454         OnlineGlomService.
1455
1456 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1457
1458         Internationalize the UI strings.
1459
1460         * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a 
1461         <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1462         * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1463         because it is unused. Messages are apparently strings that can have 
1464         parameters, but we do not need that yet, so Contants will be enough for now.
1465         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1466         to say that we support the en and de locales.
1467         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1468         The original English strings.
1469         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1470         Some German translations of the English strings.
1471         The i18n goal then uses the .properties file to generate an 
1472         OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1473         returns an implementation that returns the translated strings.
1474         The documentation suggests putting these in src/java/*/client/, but it seems
1475         best to put it in src/resources/*/client/.
1476         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1477         Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1478         instead of hard-coding them.
1479         Note that we cannot import OnlineGlomConstants because it does not exist yet,
1480         but that does not seem to stop the build, though it confuses Eclipse.
1481         
1482         You can see the translated string by adding ?locale=de to the URL, like so:
1483         http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1484
1485 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1486
1487         Improve null/empty String checks. 
1488
1489         * pom.xml: Add a dependency on commons-lang, to use
1490         org.apache.commons.lang.StringUtils.
1491         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1492         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1493         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1494         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1495         Use StringUtils.isEmpty().
1496
1497         * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1498         StringUtils class with a static isEmpty() function because we 
1499         cannot use org.apache.commons.lang.StringUtils in client-side
1500         GWT code because it (apparently) cannot be compiled to javascript.
1501         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1502         * src/main/java/org/glom/web/client/activity/ListActivity.java
1503         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1504         * src/main/java/org/glom/web/client/place/DetailsPlace.java
1505         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1506         * src/main/java/org/glom/web/client/place/ListPlace.java
1507         * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1508         * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1509         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1510         * src/main/java/org/glom/web/client/ui/details/Group.java
1511         * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use 
1512         our StringUtils.isEmpty() function.
1513
1514 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1515
1516         Update to the latest java-libglom API.
1517
1518         * pom.xml: Require java-libglom 1.21.4.
1519         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1520         getDocumentInfo(), getListViewLayoutGroup():
1521         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1522         getDocuments():
1523         * src/main/java/org/glom/web/server/database/DBAccess.java
1524         getFieldsToShowForSQLQueryAddGroup(),
1525         getPrimaryKeyLayoutItemField(): Replace get_database_title()
1526         with either get_database_title_original() or 
1527         get_database_title(localeID).
1528
1529 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1530
1531         ConfiguredDocument: Avoid a null pointer exception.
1532
1533         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1534         Initialize localeID to "" to avoid returning a null String which 
1535         causes a crash in java-libglom's swing-generated code.
1536
1537 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1538
1539         Some simple renaming.
1540
1541         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1542         * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1543         for localeChooser. This seems more appropriate and is less ambiguous 
1544         particularly in the .css file.
1545
1546 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1547
1548         ConfiguredDocument: Rename the localedID private member variable.
1549
1550 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1551
1552         Adapt to the latest java-libglom API from git master.
1553
1554         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1555         libglom now uses only Vector instead of List, which uses add() instead of
1556         addLast(). 
1557
1558 2012-01-22  Murray Cumming  <murrayc@murrayc.com>
1559
1560         ConfiguredDocument: Rename the localedID private member variable.
1561
1562 2012-01-20  Murray Cumming  <murrayc@murrayc.com>
1563
1564         Build a source tarball with mvn assembly:single
1565
1566         * assembly.xml: Add this file.
1567         * pom.xml: Use the maven-assembly-plugin and tell it to use 
1568         our assembly.xml file.
1569
1570 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
1571
1572         OnlineGlomServiceImpl: Get .glom files recursively.
1573
1574         * pom.xml: Depend on commons-io from org.apache.commons.
1575         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1576         init(): Use org.apache.commons.io.FileUtils.listFiles() to get the 
1577         files recursively, and with the easier filter for the extension.
1578         Use org.apache.commons.io.FilenameUtils.removeExtension() to 
1579         simplify that code too.
1580
1581 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
1582
1583         README: Mention that you must install java-libglom packages separately.
1584
1585         But then it works, because java-libglom is now in the central maven 
1586         repository.
1587
1588 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1589
1590         locales drop-down: Show the correct selected locale when the URL changes.
1591
1592         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1593         .java: setPlace(): Move some code into fillView().
1594
1595 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1596
1597         locales drop-down: Do not lose the primary key.
1598
1599         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1600         start(): onLocaleChange(): Pass the current primary key value, 
1601         instead of an empty value.
1602
1603 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1604
1605         locales drop-down: Do not lose the drop-down selection.
1606
1607         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1608         .java (TableSelectionActivity.fillView): Set the selected locale
1609         after changing the drop-down items (though we do not really need
1610         to change them just because the locale changes.)
1611
1612 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1613
1614         locales drop-down: Change the tables list when this changes.
1615
1616         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1617         .java: TableSelectionActivity.start(): Move the async table titles
1618         retrieval into a private fillView() method and also call this when 
1619         the chosen locale changes.
1620         Note that the document title is not actually translatable yet, but
1621         that is a problem that I should fix soon in libglom.
1622
1623 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1624
1625         Improve the placement of the locales drop-down.
1626
1627         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1628         Put the title and locales drop-down in a div (gwt.FlowTable).
1629         * src/main/webapp/style.css: Add magic css properties to make this work.
1630         Also remove the left margin from the title so that it lines up with the 
1631         headerbox below it.
1632
1633 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1634
1635         locales selector: Show human-readable locale titles.
1636
1637         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1638         getDocumentInfo(): Use java.util.Locale to show a real title of 
1639         each locale, in the locale's own language.
1640
1641 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1642
1643         Add a language/locale selector drop-down.
1644
1645         * src/main/java/org/glom/web/shared/DocumentInfo.java:
1646         Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1647         * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1648         getDocumentInfo(): Store the available Locales in the DocumentInfo.
1649         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1650         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1651         Add a ListBox to show the available locales. Add getLocaleSelector(),
1652         setLocaleList(), getSelectedLocale(), setSelectedLocale().
1653         * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1654         * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1655         java: Add these classes.
1656         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1657         start(): Fill the locales ListBox. Handle its change event, firing a 
1658         LocaleChangeEvent.
1659         setPlace(): Show the selected locale as specified by the URL token.
1660         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1661         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1662         Handle LocaleChangeEvent, going to a new *Place with that locale.
1663
1664         The placement of the ListBox is not pretty, and it currently uses the ID
1665         as a title, instead of "English", "Deutsch", "Espanola", etc, but it 
1666         is a start.
1667
1668
1669 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1670
1671         Search box: Show the search text from the URL token.
1672
1673         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1674         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1675         Add setQuickFindText().
1676         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1677         .java: setPlace(): Store the queryText if the place is a ListPlace, 
1678         and call TableSelectionView.setQuickFindText().
1679
1680 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1681
1682         Allow use of translations via, for instance, &lang=de in the URL.
1683
1684         * pom.xml: Use the unstable java-libglom 1.21 version.
1685
1686         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1687         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1688         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1689         init(): Instead of calling TranslatableItem.set_current_locale() 
1690         (now removed), call ConfiguredDocument.setDefaultLocaleID().
1691         However, this is only for default locales, which are not needed to 
1692         change the locale in the URL.
1693         getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1694         getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1695         getSortedRelatedListData(): Add a localeID parameter, so we can get the 
1696         layout for a particular locale.
1697         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1698         Add get/setDefaultLocaleID().
1699         getDocumentInfo(), getListViewData(), getRelatedListData(),
1700         getDetailsLayoutGroup(), getListViewLayoutGroup(),
1701         createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a 
1702         localeID parameter, so we can get the layout for a particular locale.
1703
1704         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1705         * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1706         * src/main/java/org/glom/web/client/place/ListPlace.java:
1707         Parse and construct a lang parameter too.
1708
1709         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1710         start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1711         passed to subsequent methods and constructors.
1712         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1713         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1714         Store the localeID from the *Place and pass it to other constructors
1715         and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1716
1717         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1718         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1719         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1720         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1721         * src/main/java/org/glom/web/client/ui/ListView.java:
1722         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1723         Take localeID parameters and pass them to subsequent constructors and 
1724         methods, so that the layout is always retrieved for that locale.
1725
1726         This is rather repetitive.
1727
1728         Note that "" means the original (default) locale of the Glom document,
1729         which is usually English.       
1730
1731 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1732
1733         Documents: Remove final keyword to fix startup configuration.
1734
1735         * src/main/java/org/glom/web/shared/Documents.java: Remove the
1736         final keywords on the private member variables because that breaks
1737         the startup, apparently (there are warnings) because it stops them
1738         from being serialized. I added these in the previous commit.
1739
1740 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
1741
1742         Documents: Add some final keywords.
1743
1744         * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1745         this.
1746
1747 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
1748
1749         OnlineGlomServiceImpl: Add to overview comments.
1750
1751         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1752         Note that this is where all the document are loaded. They are not 
1753         loaded freshly for each page.
1754
1755 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
1756
1757         Add a search box.
1758
1759         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1760         Add a TextBox for the text of a quick find.
1761         Add getQuickFindBox(), to get the widget, and getQuickFindText() to 
1762         get the text.
1763         setBackLink(): Add a String quickFind parameter.
1764         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1765         (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1766         to the base interface, because that is how TableSelectionViewImpl is used.
1767         * src/main/webapp/style.css: Add style for the search box and its label.
1768
1769         * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1770         * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1771         Add these files, based on the existing TableChangeEvent and 
1772         TableChangeEventHandlers.
1773         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1774         start(): Handle QuickFindChangeEvent, passing its quickFind text to
1775         a ListPlace() that the user should be taken to.
1776         * src/main/java/org/glom/web/client/activity/ListActivity.java
1777         start(): Handle it here too and adapt the TableChangeEvent handler to 
1778         pass the extra "" quickFind parameter to ListPlace.
1779         * src/main/java/org/glom/web/client/place/ListPlace.java: 
1780         Constructor: Take an extra String quickFind parameter and store it, 
1781         returning it from a new  getQuickFind() method.
1782         getToken(): Put the quickFind text in the URL token.
1783         getPlace(): Parse the quickFind text from the URL token.
1784         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1785         va: addDocumentLink(): Pass an extra "" quickFind parameter to the 
1786         ListPlace constructor.
1787         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1788         .java: start(): Add a Change handler for the TableSelectionView's
1789         TextBox (via its base HasChangeHandlers interface), firing the new 
1790         QuickFindChangeEvent.
1791         setPlace(): Adapt the call to TableSelectionView.setbackLink(), to 
1792         pass the extra "" quickFind parameter.
1793
1794         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1795         setCellTable(): Add a String quickFind parameter and pass it to 
1796         the ListViewTable() constructor.
1797         * src/main/java/org/glom/web/client/ui/ListView.java: Change 
1798         setCellTable() in the base interface, because that is how ListViewImpl
1799         is used.
1800
1801         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1802         Add a String quickFind member variable.
1803         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1804         Constructor: Add a String quickFind parameter, storing it in the
1805         base ListTable's member variable.
1806         onRangeChanged(): Pass quickFind to the 
1807         OnlineGlomServiceAsync.getSortedListViewData() and 
1808         OnlineGlomServiceAsync.getListViewData() methods.
1809
1810         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1811         getListViewData(), getSortedListViewData(): Add a String quickFind 
1812         parameter, passing it to ConfiguredDocument.getListViewData().
1813         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1814         Change getListViewData(), getSortedListViewData() in the base interface,
1815         because that is how OnlineGlomServiceImpl is used, via this:
1816         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1817         Change getListViewData(), getSortedListViewData() here too.
1818         This class can apparently be used to asynchronously call methods on 
1819         OnlineGlomService, and GWT seems to implement that after recognizing 
1820         just the *Async name convention and the extra AsyncCallback parameters.
1821
1822         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1823         getListViewData(): Add a String quickFind parameter, and pass it to 
1824         ListViewDBAccess.getData().
1825         * src/main/java/org/glom/web/server/database/ListDBAccess.java
1826         getListData(): Add a String quickFind parameter and pass it to 
1827         getSelectQuery().
1828         getSelectQuery(): Add a String quickFind parameter.
1829         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1830         getSelectQuery(): Add a String quickFind parameter and use it with 
1831         Glom.get_find_where_clause_quick() to pass a where_clause to 
1832         Glom.build_sql_select_with_where_clause(), to actually filter the 
1833         list view results.
1834         getData(): Add a String quickFind parameter, passing it to getListData().
1835         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1836         va: getData(): Pass an empty string to getListData() for the 
1837         quickFind parameter.
1838
1839 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
1840
1841         ListTable: Minor change.
1842
1843         * src/main/java/org/glom/web/client/ui/list/ListTable.java
1844         createCellTable(): Make this protected instead of public.
1845
1846 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
1847
1848         Many files: Use final for the parameters and use the @override attribute.
1849
1850 2012-01-22  Ben Konrath <ben@bagu.org>
1851
1852         Add anchor links for single line text that starts with http, ftp and www.
1853
1854         Bug #667269
1855
1856 2012-01-22  Ben Konrath <ben@bagu.org>
1857
1858         Add ellipsis to single line text in details view.
1859
1860         Bug #667269
1861
1862 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
1863
1864         Remove all javadoc author tags.
1865
1866         Because they are awkward and meaningless when many people touch
1867         many files.
1868         See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1869  
1870 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
1871
1872         Revert the COPYING.LESSER to COPYING rename.
1873
1874         Apparently both should be there if it is LGPL.
1875
1876 2012-01-03  Murray Cumming  <murrayc@murrayc.com>
1877
1878         *View: Remove unused imports.
1879
1880         * src/main/java/org/glom/web/client/ui/DetailsView.java:
1881         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1882         * src/main/java/org/glom/web/client/ui/ListView.java:
1883         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1884         Remove unused imports, as suggested by Eclipse.
1885
1886 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
1887
1888         Move the *View::Presenter types, and some API into one base View.
1889
1890         * src/main/java/org/glom/web/client/ui/DetailsView.java:
1891         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1892         * src/main/java/org/glom/web/client/ui/ListView.java:
1893         * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1894         Presenter, setPresenter() and clear() into a shared base interface,
1895         to avoid the unnecessary duplicate Presenter types and to more clearly
1896         show how the *Views share the same structure, even if they are not 
1897         used polymorphically.
1898
1899         * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1900         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1901         va:
1902         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1903         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1904         * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1905         ity.java:
1906         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1907         .java: Adapt.
1908
1909         Feel free to revert this if there is a good reason for the duplicate
1910         types.
1911
1912 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
1913
1914         OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1915
1916         * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1917         a class member instead of a local variable in the method.
1918         This lets us use it to get the view instances, for use in tests.
1919         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1920         beforeOnlineGlom(): Test some more details of the initial view.
1921         Again, this is not very useful.
1922
1923         To really test gwt-glom we will need to start a local postgresql 
1924         instance with local data, like the Glom tests in C++.
1925
1926 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
1927
1928         pom.xml: Mention the LGPL license.
1929
1930         * pom.xml: Add a licenses section.
1931         * COPYING.LESSER: Move this to COPYING, which
1932         previously contained the GPL. But gwt-glom is all LGPL.
1933
1934 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
1935
1936         Add project information to README and pom.xml.
1937
1938         * README: Add a brief description and mention some mvn
1939         commands.
1940         * pom.xml: This extra information shows up in mvn site
1941         generated pages.
1942
1943 2011-01-02  Murray Cumming  <murrayc@murrayc.com>
1944
1945         Use the latest java-libglom version.
1946
1947         * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1948
1949 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
1950
1951         GwtTestOnlineGlom: Test a little more.
1952
1953         * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1954         protected rather than private, as suggested by the gwt-test-utils
1955         maintianer here:
1956         http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1957         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1958         Test the initial visibility of the panels.
1959
1960         However, this is not a very useful test.
1961         And I wonder how we should generally test using this idea for an
1962         activity/places app like ours where the real changes happen implicitly
1963         based on the history token/URL.
1964
1965 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
1966
1967         Slight modification to *Mapper comments.
1968
1969         * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1970         (DataActivityMapper)
1971         * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1972         pper.java
1973         * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1974         r.java
1975         Remove comments mentioning GIN because they are just copied from 
1976         the example code and are apparently not helpful:
1977         http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1978         Also change the mention of a class that is only in the example code.
1979
1980 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
1981
1982         GwtTestOnlineGlom test: Minor changes.
1983
1984         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1985         Avoid the long qualified class name and modify the comment 
1986         because it is now obvious to me that the mocked class is the only
1987         custom one created via GWT.create().
1988
1989 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
1990
1991         Tests: Added the beginnings of a test using gwt-test-utils.
1992
1993         * pom.xml: Add dependencies on gwt-test-utils and easymock.
1994         * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1995         which tells gwt-test-utils what class will be tested.
1996         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1997         Add a simple (but empty) test case. One class, used by the OnlineGlom
1998         class, is mocked so that it can be created. However, I am not sure 
1999         why only this class needs to be mocked.
2000
2001         Note that mockito seems more popular, and clearer, than easymock,
2002         but I have not got that working yet. It might be a matter of the 
2003         mockito version.
2004
2005         This test is run during mvn integration-test.
2006
2007 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2008
2009         Tests: Use junit4-style syntax instead of junit3-style.
2010
2011         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2012         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2013         * src/test/java/org/glom/web/shared/DataItemTest.java:
2014         Use the @Test annotation rather than relying on the test*() prefix.
2015         Also no longer implement TestCase, to avoid triggering support for 
2016         the junit3-way, which stops the annotations from working.
2017         Change the imports from import junit.framework.* to 
2018         import org.junit.*, which is apparently the new way.
2019
2020 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2021
2022         Added a test for ListPlace token parsing and creation.
2023
2024         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2025         This is much the same as DetailsPlaceTest.
2026
2027         I wonder how we could test the other parts of the *Place API.
2028
2029 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2030
2031         DetailsPlace test: Also test getToken() and recreation via getPlace().
2032
2033         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2034         testGetPlaceParameters(): Get the tokens from the DetailsPlace and 
2035         recreate it, testing the recreated DetailsPlace for the same parameter
2036         values.
2037
2038 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2039
2040         Use the surefire-report plugin.
2041
2042         * pom.xml: This generates a HTML report about the tests in 
2043         target/site/surefire-report.html
2044         when you do mvn surefire-report:report. It seems to be popular/normal.
2045
2046 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2047
2048         Added a test for DetailsPlace.
2049
2050         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2051         Test the getPlace() token parsing.
2052
2053 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2054
2055         Added a first unit test.
2056
2057         * pom.xml: Add a test goal, and a dependency on junit in that scope.
2058         * src/test/java/org/glom/web/shared/DataItemTest.java:
2059         This is a silly test but it is just to get things started. Note that
2060         maven/junit finds the test because it looks in src/test by default.
2061
2062 2011-12-22  Ben Konrath  <ben@bagu.org>
2063
2064         Change charsetName to "UTF-8" when replacing line breaks.
2065
2066         JavaScript requires the charsetName to be "UTF-8". CharsetName values
2067         that work in Java (such as "UTF8") will not work when compiled to
2068         JavaScript.
2069
2070         This fixes a problem with multi-line details view fields that have hard
2071         line breaks. The "License Text" field on this page demonstrates the
2072         problem:
2073
2074         http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2075
2076         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2077
2078 2011-12-22  Ben Konrath  <ben@bagu.org>
2079
2080         Fix another bug with related list navigation.
2081
2082         I've tested all the navigation buttons in all of the related lists
2083         so things should be good now.
2084
2085         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2086
2087 2011-12-22  Ben Konrath  <ben@bagu.org>
2088
2089         Fix a crasher when refreshing the list view with the default table.
2090
2091         This crash will also happen when loading the list view with the default
2092         table from a link or bookmark.
2093
2094         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2095         to the main document selection page when the document id hasn't been
2096         set.
2097         * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2098         the main document selection page when the document id hasn't been
2099         set.
2100         * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2101         values for the details place when the document id hasn't been set.
2102         * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2103         values for the list place when the document id hasn't been set.
2104
2105 2011-12-21  Ben Konrath  <ben@bagu.org>
2106
2107         Protect against NPE when glom.document.locale is not in config.
2108
2109         This patch protects against an NPE when glom.document.locale is not in
2110         the config file. This NPE will also happen if glom.document.locale is
2111         commented out.
2112
2113         The patch also updates the error message to display the class name when
2114         the getMessage() returns null. This was happening when the NPE was
2115         thrown and I had "Configuration Error: null". If an NPE is encountered
2116         with this patch, "Configuration Error: NullPointerException " will be
2117         displayed.
2118
2119         This commit closes this bug:
2120
2121         https://bugzilla.gnome.org/show_bug.cgi?id=666669
2122
2123         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2124
2125 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2126
2127         Rename onlineglom.properties to onlineglom.properties.sample.
2128
2129         * src/main/resources/onlineglom.properties: Rename to:
2130         * src/main/resources/onlineglom.properties.sample:
2131         * src/main/resources/README: And add this file explaining that people
2132         should rename it back when deploying.
2133
2134 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2135
2136         Allow choosing the translation in the .properties file.
2137
2138         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2139         init(): Read a glom.document.locale value from the configuration file 
2140         and call Glom's TransatableItem::set_current_locale() method.
2141         * src/main/resources/onlineglom.properties: Add a commented-out 
2142         example of this new setting.
2143
2144         It would be better to add &lang=de_DE to the URL, but the current 
2145         libglom API does not allow us to do this easily. I am working on that.
2146
2147 2011-12-19  Murray Cumming  <murrayc@murrayc.com>
2148
2149         Avoid a crash in parsing of token parameters.
2150
2151         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2152         ava: getTokenParams(): Do not crash if a parameter has a key but no 
2153         value, and ignore parameters with neither.
2154
2155 2011-12-17  Murray Cumming  <murrayc@murayc.com>
2156
2157         History token building/handling: Improve use of token parameters.
2158
2159         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java 
2160         (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2161         and buildParamsToken(HashMap), for use by derived classes.
2162         Make the separator private because it is no longer be needed.
2163         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2164         (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2165         instead of manual string concatenation.
2166         (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2167         of hardcoded indices and awkward splitting code.
2168         * src/main/java/org/glom/web/client/place/ListPlace.java
2169         (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2170         instead of manual string concatenation.
2171         (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2172         of hardcoded indices and awkward splitting code.
2173         This should fix bug #666420
2174
2175 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2176
2177         Fix a Navgiation->Navigation typo in the code.
2178
2179         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2180         Rename processNavgiation() to processNavigation().
2181
2182 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2183
2184         Fix a seperator->separator typo in the code.
2185
2186         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2187         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2188         * src/main/java/org/glom/web/client/place/ListPlace.java: Just a 
2189         misspelling.
2190
2191 2011-12-15  Ben Konrath <ben@bagu.org>
2192
2193         Cleanup some comments.
2194
2195         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2196
2197 2011-12-14  Ben Konrath <ben@bagu.org>
2198
2199         Replace \n with <br/> for multiline text in the details view.
2200
2201         Vertical scrollbars are added when needed as well.
2202
2203         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2204
2205 2011-12-14  Ben Konrath <ben@bagu.org>
2206
2207         Specify the font for document selection links.
2208
2209         * src/main/webapp/style.css:
2210
2211 2011-12-14  Ben Konrath <ben@bagu.org>
2212
2213         Fix bouncy CellTable while paging.
2214
2215         This doesn't currently work with related list tables in unselected
2216         Notebook tabs.
2217
2218         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2219
2220 2011-12-14  Ben Konrath <ben@bagu.org>
2221
2222         Revamp the appearance of the document selection page.
2223
2224         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2225         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2226         * src/main/webapp/style.css:
2227
2228 2011-12-13  Ben Konrath <ben@bagu.org>
2229
2230         Set navigation button column to the smallest size possible.
2231
2232         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2233
2234 2011-12-13  Ben Konrath <ben@bagu.org>
2235
2236         Change OpenButton nomenclature to NavigationButton.
2237
2238         Using NavigtionButton makes things more generic. Classes, methods and
2239         variables have been changed.
2240
2241         This is a rename-only refactor.
2242
2243         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2244         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2245         * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2246         Renamed from OpenButtonCell.
2247         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2248         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2249         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2250
2251 2011-12-12  Ben Konrath <ben@bagu.org>
2252
2253         Remove unnecessary String argument in RelatedListTable and ListViewTable.
2254
2255         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2256         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2257         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2258         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2259
2260 2011-12-12  Ben Konrath <ben@bagu.org>
2261
2262         Update variable names and comments.
2263
2264         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2265         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2266
2267 2011-12-12  Ben Konrath <ben@bagu.org>
2268
2269         Properly initialize numNonEmptyRows variable to zero.
2270
2271         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2272         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2273
2274 2011-12-05  Ben Konrath  <ben@bagu.org>
2275
2276         Add latest mockup with HTML tables.
2277
2278         Features of this mockup:
2279
2280         -> HTML table for flowtable
2281         -> HTML table for flowtable column
2282         -> Example of how related lists would look
2283         -> Not using text entries for data items
2284
2285         The current version of Online Glom doesn't use HTML tables for the
2286         flowtable columns.
2287
2288         This mockup has been sent to the glom-devel mailing list but it's good
2289         to have it here as well.
2290
2291         * mockups/details-view-html-tables.html:
2292
2293 2011-12-05  Ben Konrath  <ben@bagu.org>
2294
2295         Remove unnecessary getPrimaryKeyField() method.
2296
2297         getPrimaryKeyFieldForTable(String) has been renamed to
2298         getPrimaryKeyField(String).
2299
2300         * src/main/java/org/glom/web/server/database/DBAccess.java:
2301         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2302         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2303
2304 2011-12-05  Ben Konrath  <ben@bagu.org>
2305
2306         Add string representation of TypedDataItem value to conversion error message.
2307
2308         * src/main/java/org/glom/web/server/Utils.java: Logging the error
2309         message was extracted into its own method to avoid duplication.
2310
2311 2011-12-05  Ben Konrath  <ben@bagu.org>
2312
2313         Add type checking to navigation primary key value creation.
2314
2315         Create navigation primary key only if the expected type from the Glom
2316         document matches the type returned by the SQL query.
2317
2318         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2319
2320 2011-12-05  Ben Konrath  <ben@bagu.org>
2321
2322         Rename a couple of variables in RelatedListNavigation.
2323
2324         This is a rename-only refactor.
2325
2326         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2327
2328 2011-12-05  Ben Konrath  <ben@bagu.org>
2329
2330         Move getListLayoutGroup() into getListViewLayoutGroup().
2331
2332         This removes getListLayoutGroup(). It was only being called by
2333         getListViewLayoutGroup().
2334
2335         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2336
2337 2011-12-05  Ben Konrath  <ben@bagu.org>
2338
2339         Remove check for LayoutItem_Portal in list table method.
2340
2341         This check is no longer necessary because the method isn't being used
2342         to create the LayoutItemPortal DTO.
2343
2344         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2345
2346 2011-12-05  Ben Konrath  <ben@bagu.org>
2347
2348         Properly support related list navigation.
2349
2350         Navigation from the "Repository Analyzer -> Package Scans ->
2351         Dependencies" related table wasn't working because the primary key for
2352         related tables wasn't being set properly. This commit fixes the
2353         problem.
2354
2355         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2356         getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2357         doesn't set the primary key properly for related list tables.
2358         * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2359         name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2360         useful for getting the primary key for list view tables and for related
2361         list tables.
2362         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2363         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2364         Move code to set the primary key for the table from the abstract
2365         ListDBAccess class to ListViewDBAccess as it's only correct for list
2366         view tables.
2367         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2368         Properly add primary key to related list tables.
2369
2370 2011-12-02  Ben Konrath  <ben@bagu.org>
2371
2372         Properly set the horizontal alignment of fields.
2373
2374         This fix is for both the list tables and the details view.
2375
2376         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2377         LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2378         to set the horizontal alignment of fields.
2379
2380 2011-12-02  Ben Konrath  <ben@bagu.org>
2381
2382         Display currency codes in the details view.
2383
2384         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2385
2386 2011-12-02  Ben Konrath  <ben@bagu.org>
2387
2388         Avoid duplicate JNI call.
2389
2390         JNI is not as efficient as pure Java and this is an easy (and small)
2391         optimization.
2392
2393         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2394         Use previously retrieved value for whereClauseToTableName instead of
2395         getting it again.
2396
2397 2011-12-02  Ben Konrath  <ben@bagu.org>
2398
2399         Rename a couple of variables in RelatedListNavigation.
2400
2401         This is a rename-only refactor.
2402
2403         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2404
2405 2011-12-02  Ben Konrath  <ben@bagu.org>
2406
2407         Indicate clearly that a mismatched primary key type is a bug.
2408
2409         * src/main/java/org/glom/web/server/Utils.java: Change log level from
2410         warning to error. Add 'This is a bug.' to message.
2411
2412 2011-12-02  Ben Konrath  <ben@bagu.org>
2413
2414         Update / fix some comments.
2415
2416         * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2417         comments.
2418         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2419         comment.
2420         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2421         Fix comments. Add some TODOs.
2422
2423 2011-12-02  Ben Konrath  <ben@bagu.org>
2424
2425         Enable navigation to details view with string primary key from related list.
2426
2427         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2428         Create a text primary key value when return type of result is
2429         java.sql.Types.VARCHAR.
2430
2431 2011-12-02  Ben Konrath  <ben@bagu.org>
2432
2433         Use checkboxes for booleans in the details view.
2434
2435         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2436
2437 2011-12-01  Ben Konrath  <ben@bagu.org>
2438
2439         Improve performance of related list height calculation.
2440
2441         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2442         Put code to calculate the expected height in a static initializer so
2443         that that it's only called once.
2444
2445 2011-12-01  Ben Konrath  <ben@bagu.org>
2446
2447         Show related list tables in notebooks (again).
2448
2449         Calculate the height of the related list tables so the Notebook can be
2450         set the correct height. The height of the related list table is also needed by
2451         FlowTable to be able decide how to create the layout.
2452
2453         * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2454         and set the Portal height based on the height of the related list
2455         table and the Portal container.
2456         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2457         Add method to calculate the height of the related list tables.
2458         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2459         * src/main/webapp/style.css: Add css class for Pager. This is needed to
2460         calculate the height of the Pager widget.
2461
2462 2011-12-01  Ben Konrath  <ben@bagu.org>
2463
2464         Use CellTable API for table property instead of setting style on Element.
2465
2466         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2467
2468 2011-12-01  Ben Konrath  <ben@bagu.org>
2469
2470         Make ListViewTable and RelatedListTable a consistent height.
2471
2472         The tables are now a consistent height regardless of the contents of
2473         the table. A hidden button is added to empty rows to ensure that the
2474         height of these rows will match the height of rows with data.
2475
2476         A navigation button column is now added to every table. The width of
2477         the navigation column is set to 0px when a RelatedListTable shouldn't
2478         have navigation buttons. This maintains the a consistent row height in
2479         tables that don't show the navigation buttons.
2480
2481         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2482         navigation column when not needed.
2483         * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2484         arguments for navigation button to constructor of ListViewTable.
2485         * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2486         hidden button for empty data rows.
2487         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2488         arguments for navigation button to constructor.
2489         * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2490         create navigation buttons. Add hideNavigationButtons() method.
2491         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2492         arguments for navigation button to constructor.
2493
2494 2011-12-01  Ben Konrath  <ben@bagu.org>
2495
2496         Use 'visibility: hidden' in Utils.getWidgetHeight().
2497
2498         This is better choice because hidden elements are invisible, don't
2499         respond to events and are not part of the tab order. They will,
2500         however, 
2501