1 2012-11-15 Murray Cumming <murrayc@murrayc.com>
3 Document: Use a better base64 decoder to read static image data.
5 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
6 getNodeTextChildAsValue(): Use the apache commons base64 decoder
7 instead of the gwt one, because it correctly decodes the strings
8 from g_base64_encode(). It is probably more correct.
9 The newlines might be confusing the gwt decoder.
11 2012-11-14 Murray Cumming <murrayc@murrayc.com>
13 Document: Do not use == to compare strings. Use equals().
15 * src/main/java/org/glom/web/server/libglom/Document.java:
16 == only checks that they are the same object, so it can
19 2012-11-14 Murray Cumming <murrayc@murrayc.com>
21 Document: Add and use public constants for layout names.
23 * src/main/java/org/glom/web/server/libglom/Document.java:
24 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
25 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
26 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
27 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
28 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
29 them here instead of hard-coded the strings repeatedly.
31 2012-11-13 Murray Cumming <murrayc@murrayc.com>
33 Document: Load static text and image items too.
35 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
36 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
37 New LayoutItem classes to represent these layout items.
38 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
39 main text of a LayoutItemText.
40 * src/main/java/org/glom/web/server/libglom/Document.java:
41 load_after_layout_group(): Handle the node types and instantiate the
43 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
44 Add testLayoutItemText() to check that the text is loaded properly.
46 2012-11-13 Murray Cumming <murrayc@murrayc.com>
48 Do not use client.GWT for shared code.
50 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
51 Import shared.GWT instead of client.GWT, which seems to be appropriate.
53 2012-11-12 Murray Cumming <murrayc@murrayc.com>
55 Use image data when recreating databases for testing.
57 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
58 for use locally (not acrosss the network) when recreating databases
60 getValue(): Use it here instead of getImageDataUrl(), noting that
61 this method is only for use when recreating databases.
62 * src/main/java/org/glom/web/server/libglom/Document.java:
63 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
65 2012-11-09 Murray Cumming <murrayc@murrayc.com>
67 OnlineGlomImages: Detect the mime-type (content type).
69 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
70 doGet(): Instead of hard-coding image/png.
72 2012-11-09 Murray Cumming <murrayc@murrayc.com>
74 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
77 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
78 Java Compiler and Java Build path settings in the UI.
80 2012-11-09 Murray Cumming <murrayc@murrayc.com>
82 Use the latest (now stable) version of GWT.
84 * pom.xml: And the latest version of the gwt-maven-plugin.
86 2012-11-08 Murray Cumming <murrayc@murrayc.com>
88 Added an Indonesian translation.
90 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
91 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
92 This is from the new translation in Glom.
94 2012-07-23 Murray Cumming <murrayc@murrayc.com>
98 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
100 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
101 so it can be used in:
102 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
103 for serving image data.
104 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
106 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
107 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
108 setData(): For image field types, add a GWT Image widget,
109 with the URL that was set in the DataItem.
111 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
112 * src/main/java/org/glom/web/server/database/DBAccess.java:
113 convertResultSetToDTO(): Set the URL for image data, so the client browser
114 can retrieve the image from our new servlet. This uses UriBuilder.
115 Move getPrimaryKeyField to:
116 * src/main/java/org/glom/web/server/libglom/Document.java:
117 Added getTablePrimaryKeyField().
119 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
120 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
121 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
124 2012-07-22 Murray Cumming <murrayc@murrayc.com>
128 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
129 * src/main/java/org/glom/web/client/OnlineGlomService.java:
130 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
131 to gwtGlom, which is more appropriate.
132 This servlet name does not seem to be visible to the client side anyway.
134 2012-07-22 Murray Cumming <murrayc@murrayc.com>
136 Tests: Make the imports of assert*() consistent.
138 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
139 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
140 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
141 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
142 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
143 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
144 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
145 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
146 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
147 * src/test/java/org/glom/web/shared/DataItemTest.java:
149 import static org.junit.Assert.*;
150 which seems fairly common.
154 2012-07-21 Murray Cumming <murrayc@murrayc.com>
156 tests: Move a test that needs a database connection.
158 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
159 Move testGetListViewLayoutGroup() to
160 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
161 because it needs a database connection.
163 2012-07-21 Murray Cumming <murrayc@murrayc.com>
165 tests: Use @BeforeClass on tearDown().
167 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
168 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
169 This avoids leaking a postgres process in SelfHostExampleTest.
171 2012-07-21 Murray Cumming <murrayc@murrayc.com>
173 tests: Test translations more.
175 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
176 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
177 Test titles in the non-default locale.
179 2012-07-21 Murray Cumming <murrayc@murrayc.com>
181 tests: Add SelfHostConfiguredDocumentTest
183 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
184 username and password, for use by ConfiguredDocument.
185 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
186 This tests some of the ConfiguredDocument API that requires a database connection.
188 2012-07-21 Murray Cumming <murrayc@murrayc.com>
190 Document: Load title translations and test them.
192 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
193 of titles. I am surprised that we do not do this yet.
194 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
195 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
196 Test translations more.
198 2012-07-20 Murray Cumming <murrayc@murrayc.com>
202 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
203 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
204 Set the timeout here too.
206 2012-07-20 Murray Cumming <murrayc@murrayc.com>
208 tests: ConfiguredDocumentTest: Make this pass.
210 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
211 Disable tests that need a database connection.
213 2012-07-20 Murray Cumming <murrayc@murrayc.com>
215 Use Java 1.7 instead of Java 1.6.
217 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
218 to do this twice, at least for Eclipse.
219 This seems OK because it is the current version.
221 2012-07-20 Murray Cumming <murrayc@murrayc.com>
225 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
226 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
227 Avoid using a null Connection.
229 2012-07-20 Murray Cumming <murrayc@murrayc.com>
231 tests: Add a ConfiguredDocument test.
233 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
236 2012-07-20 Murray Cumming <murrayc@murrayc.com>
238 LayoutItemFIeld: getName(): Use the Field if it is set.
240 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
241 getName(): If the full field details have been set, return its name, so that
242 callers do not need to set the name separately.
243 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
244 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
245 so we can count the rows.
247 2012-07-20 Murray Cumming <murrayc@murrayc.com>
249 tests: SelfHoster: Test SqlUtils too.
251 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
252 Retrieve some data and check it too, as in the regular Glom
253 test_selfhosting_new_from_example.cc test.
254 * src/test/java/org/glom/web/server/SelfHoster.java:
255 createConnection(): Make this public.
257 2012-07-20 Murray Cumming <murrayc@murrayc.com>
259 tests: SelfHoster: createConnection(): Do not warn about expected failures.
261 Let the caller say if the connection is expected to fail, to avoid
262 irrelevant error output.
264 2012-07-20 Murray Cumming <murrayc@murrayc.com>
266 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
268 * src/test/java/org/glom/web/server/SelfHoster.java:
269 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
270 due to the inevitable need to retry the connection while the database server
273 2012-07-20 Murray Cumming <murrayc@murray.com>
275 tests: SelfHoster: createConnection(): Set a timeout.
277 * src/test/java/org/glom/web/server/SelfHoster.java:
278 createConnection(): Use setLoginTimeout() because it otherwise seems to take
279 ages to actually return when it fails.
281 2012-07-20 Murray Cumming <murrayc@murrayc.com>
283 tests: SelfHoster: selfHost(): Close the test connection.
285 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
286 When we check that the connection works, close the connection. This seems
287 to not be closed automatically otherwise.
289 2012-07-20 Murray Cumming <murrayc@murrayc.com>
291 Use slf4j-simple to see JDBC errors.
293 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
295 2012-07-19 Murray Cumming <murrayc@murrayc.com>
297 SelfHoster.discoverFirstFreePort(): Close the socket.
299 * src/test/java/org/glom/web/server/SelfHoster.java:
300 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
302 2012-07-19 Murray Cumming <murrayc@murrayc.com>
304 Avoid another code warning in Eclipse Juno.
306 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
307 Do instanceof checks on the FileUtils.listFiles() result and its
310 2012-07-13 Murray Cumming <murrayc@murrayc.com>
312 Avoid some code warnings in Eclipse Juno
314 * src/main/java/org/glom/web/server/libglom/Document.java:
315 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
316 * src/test/java/org/glom/web/server/SelfHoster.java
317 createTextFile(): Make sure that the FileOutputStream is closed.
319 2012-06-22 Murray Cumming <murrayc@murrayc.com>
321 Added OnlineGlomPropertiesTest.
323 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
324 Make sure we never return a null string.
325 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
326 Added tests of the OnlineGlomProperties API, using our sample file.
328 2012-06-20 Murray Cumming <murrayc@murrayc.com>
330 Make OnlineGlomProperties be a normal class.
332 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
333 Move OnlineGlomProperties into its own file to be a regular class:
334 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
335 This makes testing simpler.
337 2012-06-15 Murray Cumming <murrayc@murrayc.com>
339 OnlineGlomServiceImpl.init(): Move some code into a new method.
341 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
342 Create addDocument().
344 2012-06-15 Murray Cumming <murrayc@murrayc.com>
346 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
348 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
349 OnlineGlomProperties.getKey(): Make this more robust by moving the
350 check for *.*.filename to here.
352 2012-06-15 Murray Cumming <murrayc@murrayc.com>
354 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
356 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
357 init(): Move knowledge of the config file format into the
358 OnlineGlomProperties inner class.
360 2012-06-15 Murray Cumming <murrayc@murrayc.com>
362 SelfHostExampleTest: Make sure we cleanup on failure.
364 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
365 the use of cleanup() to a tearDown() JUnit method.
369 2012-06-12 Murray Cumming <murrayc@murrayc.com>
371 ConfiguredDocument: Add a primary key to portals at least once.
373 * src/main/java/org/glom/web/server/ConfiguredDocument.java
374 updatePortalsExtras): Fix a typo so that we add the primary key
375 column at least once.
376 This is a fix for the previous commit:
377 ConfiguredDocument: Do not add a primary key to portals each time.
379 2012-06-08 Murray Cumming <murrayc@murrayc.com>
381 SelfHoster: Avoid some compiler warnings.
383 * src/test/java/org/glom/web/server/SelfHoster.java
384 executeCommandLineAndWait():
385 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
386 the now-unused streams for stdout and stderr from the command Processes.
387 These are not used because readln() hangs while waiting for a new line,
388 where there may be no next line. The commented out code is still there
389 to help us figure out how to do this properly.
391 2012-06-08 Murray Cumming <murrayc@murrayc.com>
393 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
395 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
396 Make this actually test the cloning again, though it is not very useful
397 now that we do not use the part that had a problem with cloning before.
399 2012-06-08 Murray Cumming <murrayc@murrayc.com>
401 SelfHoster: Keep trying pg_ctl after starting postgres.
403 * src/test/java/org/glom/web/server/SelfHoster.java
404 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
405 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
406 regular Glom. This seems mad but it seems to work because the first
407 command would fail if pg_ctl would eventually fail.
409 2012-06-08 Murray Cumming <murrayc@murrayc.com>
411 SelfHoster: Wait until the server is really ready.
413 * src/test/java/org/glom/web/server/SelfHoster.java
414 selfHost(): Attempt the connection after starting the server, retrying
415 a few times if necessary, so that the server is really ready already when
416 we return from this method.
417 The regular Glom code does this too because pg_ctl reports success too soon.
419 2012-06-08 Murray Cumming <murrayc@murrayc.com>
421 ConfiguredDocument: Do not add a primary key to portals each time.
423 * src/main/java/org/glom/web/server/ConfiguredDocument.java
424 updatePortalsExtras(): Only add an extra primary key field if there is
425 none, to avoid adding one each time we retrieve the details layout from the
427 This should fix bug #676986 (Ben Konrath)
429 2012-05-25 Murray Cumming <murrayc@murrayc.com>
431 Document.load(): Support version 7 documents.
433 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
434 database_title attribute if the title attribute is not there.
437 2012-05-24 Ben Konrath <ben@bagu.org>
439 Add configuration for auto-generating mvn:i18n from with Eclipse.
441 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
443 2012-05-24 Murray Cumming <murrayc@murrayc.com>
445 Update translations, adding French.
447 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
448 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
449 Add a French translation, using the translation from Glom.
451 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
452 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
453 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
454 Update these based on the translations from Glom.
456 2012-05-24 Murray Cumming <murrayc@murrayc.com>
458 SelfHoster: Add some debug println messages to help when things fail.
460 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
461 System.out.println() lines.
463 2012-05-23 Murray Cumming <murrayc@murrayc.com>
465 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
467 * src/test/java/org/glom/web/server/SelfHoster.java:
468 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
469 instance) instead of just /usr/bin (as on Fedora). Check the result when
472 2012-05-23 Murray Cumming <murrayc@murrayc.com>
474 Remove LayoutItemPortal.get/setNavigationTable().
476 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
477 Remove get/setNavigationTable(), which is only a cache, because it is not
478 used, and does not need to be used, because that decision should be made on
480 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
481 updatePortalsExtras():
482 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
483 getNavigationRecord():
484 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
487 2012-05-21 Murray Cumming <murrayc@murrayc.com>
489 Initial self-hosting for tests.
491 * pom.xml: Change the scope for log4j, to hopefully make it
492 available to the test code which uses it indirectly via jOOQ.
493 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
494 self-hosting, though we only use it for testing.
496 * src/main/java/org/glom/web/server/libglom/Document.java:
497 example rows: Use a map instead of a list for each row of values,
498 so we know what field they are for, instead of relying on the sequence
499 being correct. This is not very efficient, but it does not really need
501 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
502 testReadTableExampleRows(): Adapted.
504 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
505 that returns an Object, for generic use. Note that Object seems to be
506 the implicit base even of double.
507 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
508 for use in CREATE TABLE SQL queries.
509 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
510 to do self-hosting of PostgreSQL databases via its command-line
511 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
512 backends/postgres_self.cc. This is incomplete - it needs more
513 warnings about failures and it needs to clean up properly when things
515 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
516 test of this new class.
518 2012-05-21 Murray Cumming <murrayc@murrayc.com>
520 Document: loading example data: Handle exceptions.
522 * src/main/java/org/glom/web/server/libglom/Document.java:
523 DateFormat.parse() and Double.valueOf() can throw exceptions, though
524 Eclipse did not warn about that.
526 2012-05-20 Murray Cumming <murrayc@murrayc.com>
528 Document: load(), save(): Handle the example rows.
530 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
532 * src/main/java/org/glom/web/server/libglom/Document.java:
533 load(), save(): Load and save the example rows, though the date, time
534 and image types are not handled properly yet.
535 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
536 Add testReadTableExampleRows() just to check that something is read.
538 2012-05-20 Murray Cumming <murrayc@murrayc.com>
540 Document: Add save().
542 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
543 Added getTranslationsMap() for use while saving.
544 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
545 Adedd getUseDefaultFormatting() for use while saving.
546 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
547 and several private methods that it uses.
549 This will be useful while testing via self-hosting.
550 It is not complete, but should be complete enough for testing.
552 2012-05-17 Murray Cumming <murrayc@murrayc.com>
554 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
556 * src/main/java/org/glom/web/client/OnlineGlomService.java
557 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
558 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
559 Remove getSortedListViewData() and getSortedRelatedListData(), adding
560 the sort column index and ascending bool to the regular method.
561 Instead, a sort column index of -1 now means no sort.
562 This is less explicit, but it's fairly simple, reduces the amount of
563 code, and makes the OnlineGlomService API slightly smaller.
564 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
565 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
567 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
568 getListViewData(), getRelatedListData():
569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
570 getListViewData(), getRelatedListData():
571 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
573 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
575 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
580 2012-05-16 Murray Cumming <murrayc@murrayc.com>
582 Use translations for top-level groups too.
584 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
585 updateTitlesForLocale(): Use the translation for the group
586 as well as for child items.
590 Just recompiled to fix a problem in the released .tar.gz file.
594 2012-05-15 Murray Cumming <murrayc@murrayc.com>
596 Corrections to navigation to related records.
598 * src/main/java/org/glom/web/client/OnlineGlomService.java:
599 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
601 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
602 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
603 relationship name, because the relationship name is not necessarily unique
605 TOOD: This is inefficient, because it passes the whole list of
606 child field items back to the server, but it is more correct, and happens
607 to fix a bug with the primary key being lost after a few navigations.
608 There is probably a chance to make this more efficient anyway in some
611 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
612 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
613 * src/main/java/org/glom/web/server/ConfiguredDocument.java
614 * src/main/java/org/glom/web/server/database/DBAccess.java
615 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
616 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
619 2012-05-15 Murray Cumming <murrayc@murrayc.com>
621 Fix the use of translations.
623 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
624 Add updateTitlesForLocale().
625 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
626 Call it to discard unwanted translations and to make getTitle() return
627 the wanted translation wihout the need for the client code to specify a locale.
628 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
629 getTitle(): Fallback to the original title, as libglom does.
631 2012-05-15 Murray Cumming <murrayc@murrayc.com>
633 Document: Correctly report the number of available translation locales.
635 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
636 the available locale IDs list.
637 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
638 testLocales: Test this.
640 2012-05-15 Murray Cumming <murrayc@murrayc.com>
642 SqlUtils: Use camelCase.
644 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
645 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
646 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
647 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
648 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
649 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
651 2012-05-15 Murray Cumming <murrayc@murrayc.com>
653 Use jOOQ's tableByName() and fieldByName.
655 * pom.xml: Use jOOQ 2.3.1 to get the new API.
656 * src/main/java/org/glom/web/server/SqlUtils.java:
657 build_sql_select_step_with_where_clause(), .createField(),
658 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
659 so we can get correct quoting and escaping. Thanks to Lukas Eder for
660 adding this, and other things, to jOOQ.
662 2012-05-15 Murray Cumming <murrayc@murrayc.com>
664 SqlUtils: Remove the Connection parameters.
666 * src/main/java/org/glom/web/server/SqlUtils.java:
667 build_sql_select_with_key(), build_sql_select_with_where_clause(),
668 createSelect(), build_sql_select_step_with_where_clause(),
669 build_sql_count_select_with_where_clause(),
670 build_sql_select_count_rows(): Remove the Connection parameter because
671 jOOQ does not actually need a connectionwhen it is just used to build
673 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
675 * src/main/java/org/glom/web/server/ReportGenerator.java:
677 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
679 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
680 Constructor, getListData(), getResultSizeOfSQLQuery():
681 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
682 getSelectQuery(), getCountQuery():
683 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
684 getSelectQuery(), getCountQuery():
685 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
686 getNavigationRecord(): Adapted.
688 2012-05-14 Murray Cumming <murrayc@murrayc.com>
692 * src/main/java/org/glom/web/server/SqlUtils.java:
693 get_find_where_clause_quick(): Use a comparison of
694 lowercase values, instead of a simple equals. Regular Glom
695 uses the PostgreSQL ILIKE operator but jOOQ does not
696 support that just yet, though it will soon.
698 2012-05-14 Murray Cumming <murrayc@murrayc.com>
700 TableToViewDetails: Use a real serialization ID.
702 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
703 Though this does not fix the serialization problem.
705 2012-05-12 Murray Cumming <murrayc@murrayc.com>
707 Added LayoutItemPortalDeepCloneTest.
709 2012-05-11 Murray Cumming <murrayc@murrayc.com>
711 Make navigation work again.
713 * src/main/java/org/glom/web/server/libglom/Document.java:
714 Add getLayoutItemFieldShouldHaveNavigation().
715 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
716 Replace get/setAddNavigation() with the partly-existing
717 get/setNavigationTableName(), with an empty string being no navigation,
718 because this is simpler. Use the new
719 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
721 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
722 Add updateFieldsExtras() and call setNavigationTableName in it.
723 getDetailsLayoutGroup(),
724 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
725 createLayout(): Adapted.
726 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
727 Constructor: Adapted.
729 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
730 Replace get/setAddNavigation() with get/setNavigation(), returning a
731 TableToViewDetails class with both the table name and UsesRelationship,
732 because both are need. The previous code used java-libglom's output
733 variable (strangely, via sharedptr) to return both, but we cannot really
735 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
736 getNavigationRecord(): Adapt. However, we cannot actually use the cache
737 here because it somehow gets set to null during deepCopy(). I must test this.
738 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
739 testGetSuitableTableToViewDetails(): Adapted.
741 TODO: Find out why deepClone() is not quite working.
743 2012-05-11 Murray Cumming <murrayc@murrayc.com>
745 DBAccess: Simplify the retrievel of full field details.
747 * src/main/java/org/glom/web/server/database/DBAccess.java
748 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
749 because the Document loading should have done this.
751 2012-05-11 Murray Cumming <murrayc@murrayc.com>
753 Document: Correct loading of doubly-related layout fields.
755 * src/main/java/org/glom/web/server/libglom/Document.java:
756 loadUsesRelationship(): Actually set the related relationship, instead
757 of only setting it if it's not found.
759 2012-05-09 Murray Cumming <murrayc@murrayc.com>
761 Replace all appearances of Colour with color.
763 Because US English is dominant.
765 2012-05-09 Murray Cumming <murrayc@murrayc.com>
767 Use colors in HTML format, solving a warning about an unused function.
769 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
770 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
771 Add *asHTMLColor() versions of methods.
772 TODO: However, we should create and cache the results on the server.
773 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
774 * src/main/java/org/glom/web/client/ui/list/ListTable.java
775 * src/main/java/org/glom/web/server/ConfiguredDocument.java
776 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
777 Use the asHTMLcolor() versions.
779 2012-05-09 Murray Cumming <murrayc@murrayc.com>
781 ListViewTable: Constructor: Take the table name as a parameter.
783 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
784 Constructor: Take the tableName, and set the member variable, because
786 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
787 setCellTable(): Pass the table name.
788 This makes navigation to non-default tables work again. I don't know
789 why it worked before in the master branch.
791 2012-05-07 Murray Cumming <murrayc@murrayc.com>
793 ConfiguredDocument: Restore correct addition of hidden primary key items.
795 * src/main/java/org/glom/web/client/ui/list/ListTable.java
796 (ListTable.createCellTable): Uncomment out the check for the hidden
798 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
799 add primary key items for top-level lists and portals, as before,
800 instead of adding them to each group.
801 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
802 Actually implement the extra methods such as setHiddenPrimaryKey() and
803 comment that these are used only for top-level list groups and in portals.
804 This strangeness suggests even more that this should not be squeezed
805 into the LayoutGroup class.
807 2012-05-07 Murray Cumming <murrayc@murrayc.com>
809 Fix Formatting loading.
811 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
812 getFormattingUsed(): Remove the duplicate Formatting member variable
813 in favour of the one from the base class.
814 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
815 Initialize a new Formatting instead of using null by default, so we
816 have some defaults, instead of having to initialize one later just to
817 get the same defaults. This also makes loading of formatting from the
818 document work, because that expected a non-null.
820 2012-05-07 Murray Cumming <murrayc@murrayc.com>
822 RelatedListTable: Make sure that the tableName is set.
824 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
825 Constructor: Take the tableName so it is available later. Otherwise,
826 the server assumes that we mean the default table and cannot find the
828 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
829 setData(): Pass the tableName to the RelatedListTable constructor.
831 2012-05-07 Murray Cumming <murrayc@murrayc.com>
835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
836 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
837 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
839 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
841 * src/main/java/org/glom/web/server/database/DBAccess.java:
842 convertResultSetToDTO(), getPortal():
843 * src/main/java/org/glom/web/server/database/ListDBAccess.java
845 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
846 Add checks for null objects and out of range access, with log messages to
847 give hints so we can fix these properly.
849 2012-05-07 Murray Cumming <murrayc@murrayc.com>
851 Portals: some corrections.
853 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
855 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
856 constructor: Use getRelationshipNameUsed() instead of getName(), because
857 that is what is meant.
858 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
859 getFromField(): Fix a typo, to get the field name, not the table name.
860 * src/main/java/org/glom/web/server/database/DBAccess.java:
861 getPortal(): Fix a typo that stopped this from working.
863 2012-05-07 Murray Cumming <murrayc@murrayc.com>
865 LayoutItemPortal: Also override getTitleOriginal().
867 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
868 This lets the base getTitle() with no parameters work.
869 TODO: Test this properly.
871 2012-05-06 Murray Cumming <murrayc@murrayc.com>
873 LayoutItemPortal: getTitle*(): Use the relationship title.
875 2012-05-06 Murray Cumming <murrayc@murrayc.com>
877 LayoutItemField: Fix loading of custom titles.
879 * src/main/java/org/glom/web/server/libglom/Document.java
880 loadDataLayoutItemField(): The title, if any, instead of the field
881 title, is stored in a title_custom node. Load it from there.
882 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
884 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
885 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
886 getTitle*() overrides.
887 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
890 2012-05-06 Murray Cumming <murrayc@murrayc.com>
892 LayoutItemField: Fall back to field titles, so some are really shown.
894 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
895 Override getTitleOriginal() and getTitle(), as in java-libglom.
896 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
899 2012-05-06 Murray Cumming <murrayc@murrayc.com>
901 Correct use of setExpectedResultSize().
903 * src/main/java/org/glom/web/server/ConfiguredDocument.java
904 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
905 Use setExpectedResultSize only on top-level groups (for instance, the
906 list layout) or on child portals (in details views).
907 Use the correct table name for portals to avoid SQL errors.
908 Update the expected counts when returning cached layouts.
910 2012-05-06 Murray Cumming <murrayc@murrayc.com>
912 Document: Interpret no group column count as 1.
914 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
915 default, though we now check for this in the UI code anyway.
917 2012-05-06 Murray Cumming <murrayc@murrayc.com>
921 2012-05-06 Murray Cumming <murrayc@murrayc.com>
923 Translatable: Use Hashmap instead of Treemap because GWT supports it.
925 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
926 The use of Treemap lead to this error from async methods, with no
928 "The response could not be deserialized"
930 2012-05-06 Murray Cumming <murrayc@murrayc.com>
932 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
934 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
935 when using the Google -> GWT Compile, or
936 g toolbar button -> GWT Compile Project... feature in Eclipse.
938 2012-05-06 Murray Cumming <murrayc@murrayc.com>
940 ListTable.addColumn(): Protect against a null Formatting.
942 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
943 Create a default Formatting if it is null, because that is the simplest
946 2012-05-06 Murray Cumming <murrayc@murrayc.com>
948 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
950 * src/main/java/org/glom/web/server/ConfiguredDocument.java
951 updateLayoutGroup(): Check that the field is not null.
953 2012-05-06 Murray Cumming <murrayc@murrayc.com>
955 ListViewImpl: Protected against a bad cast error.
957 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
958 onEnterKeyDown(): Do not cast without an instanceof check.
960 2012-05-06 Murray Cumming <murrayc@murrayc.com>
962 ListTable: Protect against an out of range error.
964 * src/main/java/org/glom/web/client/ui/list/ListTable.java
965 createCellTable(): This is unlikely, but can happen while debugging.
967 2012-05-06 Murray Cumming <murrayc@murrayc.com>
969 AsyncMessage onFailure() callbacks: Log the exception message.
971 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
972 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
973 * src/main/java/org/glom/web/client/activity/ListActivity.java:
974 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
975 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
976 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
977 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
978 These are useful clues when something is wrong.
980 2012-05-06 Murray Cumming <murrayc@murrayc.com>
982 ConfiguredDocument: Avoid a null dereference.
984 * src/main/java/org/glom/web/server/ConfiguredDocument.java
985 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
986 details maps are created.
988 2012-05-06 Murray Cumming <murrayc@murrayc.com>
990 Document: Correct the port number parsing.
992 * src/main/java/org/glom/web/server/libglom/Document.java:
993 This lets us actually connect to the database and show the document.
995 2012-05-05 Murray Cumming <murrayc@murrayc.com>
999 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1000 user-interaction, asking us to load a temporary URL in a browser.s
1001 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1002 which is apparently necessary for testing the service. See the comment.
1003 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1004 Show the exception, if any. This is how I saw the 404 in the HTML in
1007 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1009 DocumentTest: Move the .glom files into the resources directory.
1011 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1012 URI via getResource().
1014 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1016 Document: Remove the FieldIdentifies inner class.
1018 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1019 use the Relationship (though the same function in libglom is maybe
1020 used in other ways) and so this removes a compiler warning.
1022 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1024 Document.load() Remove the error code parameter.
1026 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1027 Remove the parameter. We do not set it yet and it could never have
1028 worked as an output parameter (though maybe it did in java-libglom).
1029 We could use an exception if we really want the failure reason.
1030 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1032 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1033 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1035 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1037 Make some inner classes static.
1039 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1040 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1041 * src/main/java/org/glom/web/server/ReportGenerator.java
1042 * src/main/java/org/glom/web/server/libglom/Document.java
1043 Make all inner classes static that can be static.
1045 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1047 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1049 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1050 init(): We do not use java-libglom any more.
1052 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1054 Remove mentions of java-libglom.
1056 * README: Remove mention of java-libglom, because it no longer needed.
1057 * utils/build-onlineglom-war.sh:
1058 * utils/check-and-recover-tomcat.py:
1059 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1060 useful. Building is now far easier, with no need for jhbuild.
1062 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1064 Fix the build (mvn package)
1066 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1067 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1068 Otherwise the GWT Java->Javascript compilation fails with just this
1069 error, during mvn package or when attempting to view in a browser,
1070 in the GWT developer mode in Eclipse.
1072 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1073 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1074 [INFO] Compiling module org.glom.web.OnlineGlom
1075 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1076 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1077 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1078 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1079 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1080 [INFO] [ERROR] Cannot proceed due to previous errors
1082 It has taken me 2 days to find out what was causing that. After reducing
1083 the code, the compiler eventually showed me the full error message.
1085 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1087 ConfiguredDocument: Cache the cloned and stripped layouts.
1089 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1090 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1091 layout in a map, so we can retrieve it again without rebuilding it.
1093 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1095 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1097 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1099 libglom classes: Implement some auto-generated emthods.
1101 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1103 Add GwtTestOnlineGlomService.
1105 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1106 However, this (and the other GwtTest*) does not seem to run during
1109 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1111 Remove use of unsupported features from client code.
1113 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1114 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1115 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1116 Use our client version of StringUtils instead of the apache commons one.
1118 However, the GWT Javascript compliation still fails.
1120 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1122 Add a Field class and implement some loading of it in Document.
1124 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1126 Initial Document loading implementation, instead of libglom.
1128 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1129 and Translatable classes, and adapt the rest of the code to use them.
1130 However, this is still missing Layout and Field classes and loading.
1132 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1134 Use of jOOQ: Move Field creation into a utility method.
1136 * src/main/java/org/glom/web/server/SqlUtils.java:
1137 This lets us improve it more easily.
1139 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1141 Use of jOOQ: Improve the code to COUNT a sub-select.
1143 * src/main/java/org/glom/web/server/SqlUtils.java:
1144 Move initial query creation into
1145 build_sql_select_step_with_where_clause().
1146 build_sql_select_count_rows(): Use the jOOQ API instead of
1147 concatentating text, because a jOOQ Select*Step is a TableLike,
1148 which is what from() takes.
1150 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1152 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1154 * pom.xml: Depend on jooq.
1155 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1156 methods with jOOQ, based on the C++ implementations in libglom,
1157 with some changes to the logic required by jooQ.
1158 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1160 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1161 * src/main/java/org/glom/web/server/ReportGenerator.java:
1162 * src/main/java/org/glom/web/server/SqlUtils.java:
1163 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1164 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1165 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1166 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1167 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1168 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1169 because jOOQ needs that, though it seems unnecessary.
1171 This is not quite finished. Ideally jOOQ would help us to build
1172 table_name.field_name names, quoting and escaping them properly.
1173 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1175 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1177 Move use of Glom.build_sql*() into a new SqlUtils class.
1179 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1180 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1181 but this will make it easier to start using something other than
1182 libglom or SqlBuilder.
1184 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1186 Update the project URL.
1188 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1190 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1192 Main layout: Use a FlowTable instead of absolute positioning.
1194 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1195 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1196 child panels/widgets must have an absolute position. But that is annoying, so
1197 this adds a FlowTable and puts the child panels in there.
1199 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1201 GwtTestOnlineGlom: Comment out unused code.
1203 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1204 Eclipse has started to say that some code is unused.
1206 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1208 Update to the latest versions of dependencies.
1210 * pom.xml: Update version numbers of dependencies to the latest
1212 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1214 * src/main/java/org/glom/web/server/ReportGenerator.java:
1215 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1216 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1217 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1219 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1220 Modify the imports where necessary.
1222 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1224 Style: Remove overflow:hidden from searchbox
1226 * src/main/webapp/style.css: Because this pushes the Back To Link
1227 label/link on to the next row, which is then hidden due to the
1228 hard-coded (in ems) height.
1230 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1232 Remove some duplicate code.
1234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1235 getDocumentInfo(): This must have been duplicated during the merge from the
1240 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1242 Reports: Localize the waiting for report message.
1244 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1245 start(): Get the message from the contants.
1246 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1247 Add the string here.
1248 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1249 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1250 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1251 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1252 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1253 Update these files with the English text for newer strings for now.
1255 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1257 Reports: Show a message while waiting for the report.
1259 * src/main/java/org/glom/web/client/ui/ReportView.java
1260 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1261 Add setWaitingText(), to show a message saying that we are
1262 waiting for the report to be ready.
1263 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1264 start(): Call setWaitingText() before calling the async
1267 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1269 ReportGenerator: Specify date and time formats.
1271 * src/main/java/org/glom/web/server/ReportGenerator.java:
1272 createFieldValueElement(): Use the default (and localized)
1273 short formats, though we still need a way to show 4-digit
1274 years without providing the format for every locale.
1275 * src/main/java/org/glom/web/server/database/DBAccess.java:
1276 convertResultSetToDTO(): Use the short formats here too.
1278 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1280 ReportGenerator: Use the correct numeric formatting.
1282 * src/main/java/org/glom/web/server/ReportGenerator.java
1283 createFieldExpression(), createFieldValueElement(): Take the
1284 whole LayoutItem_Field instead of just the field name, so
1285 we have access to the formatting.
1286 createFieldValueElement(): Use JRTextField.setPattern() to
1287 specify the numeric formatting, with the help of a
1288 regular DecimalFormat.
1290 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1292 ReportGenerator: Avoid showing null for group by titles.
1294 * src/main/java/org/glom/web/server/ReportGenerator.java
1295 generateReport(): Use setBlankWhenNull() on the field title
1296 style too, because this is used for values in group by
1299 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1301 ReportGenerator: Add a colon to titles in vertical groups.
1303 * src/main/java/org/glom/web/server/ReportGenerator.java
1304 addFieldToDetailBandVertical(): Pass true for the withColon
1307 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1309 ReportGenerator: Simplify the code by using Position more.
1311 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1313 Reports: Support vertical groups, roughly.
1315 * src/main/java/org/glom/web/server/ReportGenerator.java:
1316 addToReport(): Rename to addGroupToReport() and, if necessary,
1317 call the new addVerticalGroupToReport() method.
1318 createFieldValueElement(): Let the caller specify the Y position
1321 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1323 Reports: Allow a second report to be shown.
1325 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1326 clear(): Do not remove the HTML widget, which broke the whole layout.
1328 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1330 Locales drop-down: Show that we use English by default.
1332 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1333 fillView(): When we use English, just because that is the default, when
1334 no locale is specified, show that in the Locales drop-down instead of
1335 just showing the first item.
1337 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1339 Unselect the Report/Locale/Table combo item when appropriate.
1341 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1342 setPlace(): clear reportName if this is not a ReportPlace.
1343 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1344 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1345 When the provided name is empty, unselect all items, so that none are
1346 indicated. This uses a for loop because I cannot find a single method
1349 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1351 Report: Give the user a way to get back to the list.
1353 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1354 start(), setPlace(): Show the Back To List link on reports, and also
1355 interpret selecting the empty report item as back to list.
1357 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1359 Really show the selected Report name.
1361 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1362 setPlace(): Store the reportName here, if it is that kind of Place.
1363 fillView(): Set the selected Report after filling the list of reports.
1364 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1365 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1366 null Strings, though we need some way to unselect all ListBox items
1369 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1371 ReportGenerator: Try to avoid some problems.
1373 * src/main/java/org/glom/web/server/ReportGenerator.java
1374 addField(): Try to avoid duplicates, and avoid using a null
1377 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1379 Reports: Use quickFind.
1381 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1382 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1383 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1384 getReportHTML(): Add a quickFind parameter.
1385 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1386 start(): Pass the quickFind parameter.
1387 * src/main/java/org/glom/web/server/ReportGenerator.java
1388 generateReport(): Take a quickFind parameter.
1390 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1392 ReportPlace: Actually use the report name.
1394 * src/main/java/org/glom/web/client/place/ReportPlace.java
1395 getPlace(): Do not assign the report name to the quickfind.
1397 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1399 Show java.library.path when complaining.
1401 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1402 init(): When telling us to check java.library.path, show the
1405 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1407 ReportGenerator: Do not show nulls.
1409 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1411 ReportGenerator: Make the title font larger.
1413 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1415 ReportGenerator: Put field titles inside groups, if there are groups.
1417 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1419 ReportGenerator: Take the Report itself instead of the name and group.
1421 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1422 Remove getReportLayoutGroup().
1423 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1424 getReportHTML(): Pass the report instead
1425 of its name and layout group.
1426 * src/main/java/org/glom/web/server/ReportGenerator.java
1427 generateReport(): Use the report object to use the title
1428 instead of the name.
1430 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1432 ReportGenerator: Remove designBand parameters.
1434 * src/main/java/org/glom/web/server/ReportGenerator.java:
1435 Make designBand a class member instead of passing it to all
1438 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1440 ReportGenerator: Add lines, a bit like in the desktop version.
1442 * src/main/java/org/glom/web/server/ReportGenerator.java
1443 addToReport(): Use JRDesignLine.
1445 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1447 ReportGenerator: Correct the title positions and use some bold style.
1449 * src/main/java/org/glom/web/server/ReportGenerator.java:
1450 Break the code up into reusable functions, correct the placement of
1451 titles, and use normal/bold styles as in the reports in the desktop
1454 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1456 ReportGenerator: Add a header band to show the field titles.
1458 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1459 getReportHTML(): Pass the localeId to the ReportGenerator
1461 * src/main/java/org/glom/web/server/ReportGenerator.java
1462 constructor: Take the localeID so we can get translated field
1464 generateReport(), addToReport(), addFieldToBand(): Add field
1465 titles in a column header band.
1467 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1469 Reports drop-down list: Some improvement.
1471 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1472 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1473 Adedd setSelectedReport(),
1474 setReportList(): Add a blank line so that the user can select the
1476 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1477 start(): Show the current report by calling setSelectedReport().
1478 This does not seem to work yet.
1480 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1482 DetailsActivity, ListActivity: Move some variables into a base class.
1484 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1485 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1486 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1487 the clientFactory, documentID, tableName and authenticationPopup into
1488 a base class, to avoid duplication.
1490 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1492 Translate the Reports label.
1494 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1495 Get the "Reports" label string from the constants.
1496 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1497 perties: Add Reports to the constants.
1499 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1501 Reports: Implement grouping.
1503 * src/main/java/org/glom/web/server/ReportGenerator.java:
1504 Handle LayoutItem_GroupBy items and try to do the right thing
1505 with JRDesignGroup. It seems to work.
1507 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1509 Actually show some data with JasperReports.
1511 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1512 getReportHTML(): Move most code into a ReportGenerator class.
1513 * src/main/java/org/glom/web/server/ReportGenerator.java:
1514 Recurse into sub-groups, adding fields to the JasperDesign's details
1515 band. Note that we must set an arbitrary width and height, or it just
1516 will not show any data.
1518 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1520 Reports Chooser: Show the titles, not the names.
1522 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1523 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1524 and the names as the values.
1525 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1526 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1527 group now that we provide the report name, so it should always
1530 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1532 Depend on jasperreports.
1534 * pom.xml: Add the dependency. My plan is to use this on the
1537 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1539 Implement navigation to report places.
1541 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1542 start(): Do not bother to handle all events here.
1543 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1544 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1545 Added getSelectedReport().
1546 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1547 .java: start(): When handling a change to the reports chooser,
1548 call getSelectedReport() and goTo() its ReportPlace.
1549 * src/main/java/org/glom/web/client/ui/ReportView.java
1550 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1551 Added setReportHTML() which puts the html in a gwt HTML widget.
1552 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1553 getReportHTML(): Return "TODO" just to show that this works.
1555 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1557 Make ReportPlace usable.
1559 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1560 Mention ReportPlace.
1561 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1562 Correct the @prefix annotation.
1564 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1566 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1568 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1569 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1571 Change getReportLayout() to getReportHMTL() because we will not need to
1572 parse or render the report layout on the client side.
1573 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1574 getReportLayout(): Return the libglom LayoutGroup type because we will
1575 not need to convert to a shared type, because this will not be used on
1577 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1580 Note that there is still no implementation for this.
1583 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1585 Add a (empty) Report Place, View, and Activity.
1587 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1589 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1590 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1591 this into a superclass:
1592 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1593 and also use it as the base of this new ReportPlace:
1594 * src/main/java/org/glom/web/client/place/ReportPlace.java
1596 * src/main/java/org/glom/web/client/ui/ReportView.java
1597 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1598 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1599 Add these, containing mostly boiler-plate for now.
1601 * src/main/java/org/glom/web/client/OnlineGlomService.java
1602 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1603 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1604 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1605 Add API to get the LayoutGroup for the report.
1607 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1609 Add and fill a Reports drop-down list box.
1611 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1613 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1614 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1615 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1616 Added getReports(document, table, localeID), calling
1617 ConfiguredDocument.getReports().
1618 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1619 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1620 Added setReportsList() and a list widget.
1621 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1622 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1627 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1629 Translations: Add Esperanto.
1631 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1632 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1633 properties: Add this translation because someone took the time to make it.
1635 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1637 Adapt to the java-libglom 1.21.7 API.
1639 * src/main/java/org/glom/web/server/ReportGenerator.java:
1640 addToReport(): get_group_secondary_fields() is now
1641 get_secondary_fields().
1644 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1646 Use the latest java-libglom version.
1648 * pom.xml: Use java-libglom 1.21.7.
1650 2012-03-03 Ben Konrath <ben@bagu.org>
1652 Display date and time in details view.
1654 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1656 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1658 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1660 Require the latest java-libglom.
1662 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1664 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1666 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1668 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1669 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1670 an empty quickfind string. I also corrected libglom to create only
1671 empty where clauses for empty quickfind strings, but this avoids the
1674 2012-02-24 Ben Konrath <ben@bagu.org>
1676 Improve the tabs in the Notebook widget.
1680 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1682 Translations: Try to translate the strings.
1684 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1685 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1686 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1687 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1688 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1689 Take the Open translation from GTK+'s .po files.
1690 Take the Details translation from Glom's po files.
1691 I have added the other strings to Glom so we can get translations that way:
1692 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1694 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1696 TableSelectionViewImpl: Put the search label and entry in a div.
1698 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1699 Put the search widgets in a FlowTable so that the CSS can be used to
1700 style them while keeping them together.
1701 * src/main/webapp/style.css: Mention the new div.
1703 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1705 Translate more strings in more locales.
1707 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1708 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1709 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1710 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1711 Translate the "Details" and "Open" string too.
1713 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1714 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1715 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1716 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1717 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1718 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1719 Add these new locales as placeholders though they currently contain English.
1721 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1723 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1725 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1726 Check the ConfiguredDocument* for null before using it.
1728 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1730 Tell Eclipse about the generated java files.
1732 * .classpath: This lets it find OnlineGlomConstants.java.
1733 It would be nice if Eclipse just used the maven build files.
1735 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1737 Prevent a crash when no locale is specified in the URL.
1739 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1740 Avoid returning a null string, obtained from
1741 Window.Location.getParameter(). This caused a crash when it was
1742 later passed to libglom's API.
1743 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1744 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1745 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1746 guard against future null strings.
1748 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1750 Use the ?locale= query param instead of the &lang= token param.
1752 * src/main/java/org/glom/web/client/place/ListPlace.java
1753 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1754 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1755 Remove the lang token key and value.
1757 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1758 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1759 When the user selects a different locale from the chooser, use
1760 Window.Location.assign() to change the URL, which then causes a reload.
1762 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1763 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1764 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1765 * src/main/java/org/glom/web/client/activity/ListActivity.java
1766 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1767 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1768 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1769 * src/main/java/org/glom/web/client/ui/ListView.java:
1770 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1772 Remove localeID member variables and method/constructor parameters, instead
1773 using Utils.getCurrentLocaleID() when we need a localID to pass to
1776 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1778 Internationalize the UI strings.
1780 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1781 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1782 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1783 because it is unused. Messages are apparently strings that can have
1784 parameters, but we do not need that yet, so Contants will be enough for now.
1785 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1786 to say that we support the en and de locales.
1787 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1788 The original English strings.
1789 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1790 Some German translations of the English strings.
1791 The i18n goal then uses the .properties file to generate an
1792 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1793 returns an implementation that returns the translated strings.
1794 The documentation suggests putting these in src/java/*/client/, but it seems
1795 best to put it in src/resources/*/client/.
1796 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1797 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1798 instead of hard-coding them.
1799 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1800 but that does not seem to stop the build, though it confuses Eclipse.
1802 You can see the translated string by adding ?locale=de to the URL, like so:
1803 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1805 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1807 Improve null/empty String checks.
1809 * pom.xml: Add a dependency on commons-lang, to use
1810 org.apache.commons.lang.StringUtils.
1811 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1812 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1813 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1814 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1815 Use StringUtils.isEmpty().
1817 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1818 StringUtils class with a static isEmpty() function because we
1819 cannot use org.apache.commons.lang.StringUtils in client-side
1820 GWT code because it (apparently) cannot be compiled to javascript.
1821 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1822 * src/main/java/org/glom/web/client/activity/ListActivity.java
1823 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1824 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1825 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1826 * src/main/java/org/glom/web/client/place/ListPlace.java
1827 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1828 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1829 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1830 * src/main/java/org/glom/web/client/ui/details/Group.java
1831 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1832 our StringUtils.isEmpty() function.
1834 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1836 Update to the latest java-libglom API.
1838 * pom.xml: Require java-libglom 1.21.4.
1839 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1840 getDocumentInfo(), getListViewLayoutGroup():
1841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1843 * src/main/java/org/glom/web/server/database/DBAccess.java
1844 getFieldsToShowForSQLQueryAddGroup(),
1845 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1846 with either get_database_title_original() or
1847 get_database_title(localeID).
1849 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1851 ConfiguredDocument: Avoid a null pointer exception.
1853 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1854 Initialize localeID to "" to avoid returning a null String which
1855 causes a crash in java-libglom's swing-generated code.
1857 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1859 Some simple renaming.
1861 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1862 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1863 for localeChooser. This seems more appropriate and is less ambiguous
1864 particularly in the .css file.
1866 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1868 ConfiguredDocument: Rename the localedID private member variable.
1870 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1872 Adapt to the latest java-libglom API from git master.
1874 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1875 libglom now uses only Vector instead of List, which uses add() instead of
1878 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1880 ConfiguredDocument: Rename the localedID private member variable.
1882 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1884 Build a source tarball with mvn assembly:single
1886 * assembly.xml: Add this file.
1887 * pom.xml: Use the maven-assembly-plugin and tell it to use
1888 our assembly.xml file.
1890 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1892 OnlineGlomServiceImpl: Get .glom files recursively.
1894 * pom.xml: Depend on commons-io from org.apache.commons.
1895 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1896 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1897 files recursively, and with the easier filter for the extension.
1898 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1899 simplify that code too.
1901 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1903 README: Mention that you must install java-libglom packages separately.
1905 But then it works, because java-libglom is now in the central maven
1908 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1910 locales drop-down: Show the correct selected locale when the URL changes.
1912 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1913 .java: setPlace(): Move some code into fillView().
1915 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1917 locales drop-down: Do not lose the primary key.
1919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1920 start(): onLocaleChange(): Pass the current primary key value,
1921 instead of an empty value.
1923 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1925 locales drop-down: Do not lose the drop-down selection.
1927 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1928 .java (TableSelectionActivity.fillView): Set the selected locale
1929 after changing the drop-down items (though we do not really need
1930 to change them just because the locale changes.)
1932 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1934 locales drop-down: Change the tables list when this changes.
1936 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1937 .java: TableSelectionActivity.start(): Move the async table titles
1938 retrieval into a private fillView() method and also call this when
1939 the chosen locale changes.
1940 Note that the document title is not actually translatable yet, but
1941 that is a problem that I should fix soon in libglom.
1943 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1945 Improve the placement of the locales drop-down.
1947 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1948 Put the title and locales drop-down in a div (gwt.FlowTable).
1949 * src/main/webapp/style.css: Add magic css properties to make this work.
1950 Also remove the left margin from the title so that it lines up with the
1953 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1955 locales selector: Show human-readable locale titles.
1957 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1958 getDocumentInfo(): Use java.util.Locale to show a real title of
1959 each locale, in the locale's own language.
1961 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1963 Add a language/locale selector drop-down.
1965 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1966 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1967 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1968 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1969 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1970 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1971 Add a ListBox to show the available locales. Add getLocaleSelector(),
1972 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1973 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1974 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1975 java: Add these classes.
1976 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1977 start(): Fill the locales ListBox. Handle its change event, firing a
1979 setPlace(): Show the selected locale as specified by the URL token.
1980 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1981 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1982 Handle LocaleChangeEvent, going to a new *Place with that locale.
1984 The placement of the ListBox is not pretty, and it currently uses the ID
1985 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1989 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1991 Search box: Show the search text from the URL token.
1993 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1994 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1995 Add setQuickFindText().
1996 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1997 .java: setPlace(): Store the queryText if the place is a ListPlace,
1998 and call TableSelectionView.setQuickFindText().
2000 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2002 Allow use of translations via, for instance, &lang=de in the URL.
2004 * pom.xml: Use the unstable java-libglom 1.21 version.
2006 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2007 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2008 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2009 init(): Instead of calling TranslatableItem.set_current_locale()
2010 (now removed), call ConfiguredDocument.setDefaultLocaleID().
2011 However, this is only for default locales, which are not needed to
2012 change the locale in the URL.
2013 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2014 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2015 getSortedRelatedListData(): Add a localeID parameter, so we can get the
2016 layout for a particular locale.
2017 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2018 Add get/setDefaultLocaleID().
2019 getDocumentInfo(), getListViewData(), getRelatedListData(),
2020 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2021 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2022 localeID parameter, so we can get the layout for a particular locale.
2024 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2025 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2026 * src/main/java/org/glom/web/client/place/ListPlace.java:
2027 Parse and construct a lang parameter too.
2029 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2030 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2031 passed to subsequent methods and constructors.
2032 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2033 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2034 Store the localeID from the *Place and pass it to other constructors
2035 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2037 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2038 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2039 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2040 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2041 * src/main/java/org/glom/web/client/ui/ListView.java:
2042 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2043 Take localeID parameters and pass them to subsequent constructors and
2044 methods, so that the layout is always retrieved for that locale.
2046 This is rather repetitive.
2048 Note that "" means the original (default) locale of the Glom document,
2049 which is usually English.
2051 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2053 Documents: Remove final keyword to fix startup configuration.
2055 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2056 final keywords on the private member variables because that breaks
2057 the startup, apparently (there are warnings) because it stops them
2058 from being serialized. I added these in the previous commit.
2060 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2062 Documents: Add some final keywords.
2064 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2067 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2069 OnlineGlomServiceImpl: Add to overview comments.
2071 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2072 Note that this is where all the document are loaded. They are not
2073 loaded freshly for each page.
2075 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2079 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2080 Add a TextBox for the text of a quick find.
2081 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2083 setBackLink(): Add a String quickFind parameter.
2084 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2085 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2086 to the base interface, because that is how TableSelectionViewImpl is used.
2087 * src/main/webapp/style.css: Add style for the search box and its label.
2089 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2090 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2091 Add these files, based on the existing TableChangeEvent and
2092 TableChangeEventHandlers.
2093 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2094 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2095 a ListPlace() that the user should be taken to.
2096 * src/main/java/org/glom/web/client/activity/ListActivity.java
2097 start(): Handle it here too and adapt the TableChangeEvent handler to
2098 pass the extra "" quickFind parameter to ListPlace.
2099 * src/main/java/org/glom/web/client/place/ListPlace.java:
2100 Constructor: Take an extra String quickFind parameter and store it,
2101 returning it from a new getQuickFind() method.
2102 getToken(): Put the quickFind text in the URL token.
2103 getPlace(): Parse the quickFind text from the URL token.
2104 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2105 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2106 ListPlace constructor.
2107 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2108 .java: start(): Add a Change handler for the TableSelectionView's
2109 TextBox (via its base HasChangeHandlers interface), firing the new
2110 QuickFindChangeEvent.
2111 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2112 pass the extra "" quickFind parameter.
2114 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2115 setCellTable(): Add a String quickFind parameter and pass it to
2116 the ListViewTable() constructor.
2117 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2118 setCellTable() in the base interface, because that is how ListViewImpl
2121 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2122 Add a String quickFind member variable.
2123 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2124 Constructor: Add a String quickFind parameter, storing it in the
2125 base ListTable's member variable.
2126 onRangeChanged(): Pass quickFind to the
2127 OnlineGlomServiceAsync.getSortedListViewData() and
2128 OnlineGlomServiceAsync.getListViewData() methods.
2130 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2131 getListViewData(), getSortedListViewData(): Add a String quickFind
2132 parameter, passing it to ConfiguredDocument.getListViewData().
2133 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2134 Change getListViewData(), getSortedListViewData() in the base interface,
2135 because that is how OnlineGlomServiceImpl is used, via this:
2136 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2137 Change getListViewData(), getSortedListViewData() here too.
2138 This class can apparently be used to asynchronously call methods on
2139 OnlineGlomService, and GWT seems to implement that after recognizing
2140 just the *Async name convention and the extra AsyncCallback parameters.
2142 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2143 getListViewData(): Add a String quickFind parameter, and pass it to
2144 ListViewDBAccess.getData().
2145 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2146 getListData(): Add a String quickFind parameter and pass it to
2148 getSelectQuery(): Add a String quickFind parameter.
2149 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2150 getSelectQuery(): Add a String quickFind parameter and use it with
2151 Glom.get_find_where_clause_quick() to pass a where_clause to
2152 Glom.build_sql_select_with_where_clause(), to actually filter the
2154 getData(): Add a String quickFind parameter, passing it to getListData().
2155 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2156 va: getData(): Pass an empty string to getListData() for the
2157 quickFind parameter.
2159 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2161 ListTable: Minor change.
2163 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2164 createCellTable(): Make this protected instead of public.
2166 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2168 Many files: Use final for the parameters and use the @override attribute.
2170 2012-01-22 Ben Konrath <ben@bagu.org>
2172 Add anchor links for single line text that starts with http, ftp and www.
2176 2012-01-22 Ben Konrath <ben@bagu.org>
2178 Add ellipsis to single line text in details view.
2182 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2184 Remove all javadoc author tags.
2186 Because they are awkward and meaningless when many people touch
2188 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2190 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2192 Revert the COPYING.LESSER to COPYING rename.
2194 Apparently both should be there if it is LGPL.
2196 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2198 *View: Remove unused imports.
2200 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2201 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2202 * src/main/java/org/glom/web/client/ui/ListView.java:
2203 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2204 Remove unused imports, as suggested by Eclipse.
2206 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2208 Move the *View::Presenter types, and some API into one base View.
2210 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2211 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2212 * src/main/java/org/glom/web/client/ui/ListView.java:
2213 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2214 Presenter, setPresenter() and clear() into a shared base interface,
2215 to avoid the unnecessary duplicate Presenter types and to more clearly
2216 show how the *Views share the same structure, even if they are not
2217 used polymorphically.
2219 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2220 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2223 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2224 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2226 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2229 Feel free to revert this if there is a good reason for the duplicate
2232 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2234 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2236 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2237 a class member instead of a local variable in the method.
2238 This lets us use it to get the view instances, for use in tests.
2239 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2240 beforeOnlineGlom(): Test some more details of the initial view.
2241 Again, this is not very useful.
2243 To really test gwt-glom we will need to start a local postgresql
2244 instance with local data, like the Glom tests in C++.
2246 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2248 pom.xml: Mention the LGPL license.
2250 * pom.xml: Add a licenses section.
2251 * COPYING.LESSER: Move this to COPYING, which
2252 previously contained the GPL. But gwt-glom is all LGPL.
2254 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2256 Add project information to README and pom.xml.
2258 * README: Add a brief description and mention some mvn
2260 * pom.xml: This extra information shows up in mvn site
2263 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2265 Use the latest java-libglom version.
2267 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2269 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2271 GwtTestOnlineGlom: Test a little more.
2273 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2274 protected rather than private, as suggested by the gwt-test-utils
2276 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2277 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2278 Test the initial visibility of the panels.
2280 However, this is not a very useful test.
2281 And I wonder how we should generally test using this idea for an
2282 activity/places app like ours where the real changes happen implicitly
2283 based on the history token/URL.
2285 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2287 Slight modification to *Mapper comments.
2289 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2290 (DataActivityMapper)
2291 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2293 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2295 Remove comments mentioning GIN because they are just copied from
2296 the example code and are apparently not helpful:
2297 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2298 Also change the mention of a class that is only in the example code.
2300 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2302 GwtTestOnlineGlom test: Minor changes.
2304 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2305 Avoid the long qualified class name and modify the comment
2306 because it is now obvious to me that the mocked class is the only
2307 custom one created via GWT.create().
2309 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2311 Tests: Added the beginnings of a test using gwt-test-utils.
2313 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2314 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2315 which tells gwt-test-utils what class will be tested.
2316 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2317 Add a simple (but empty) test case. One class, used by the OnlineGlom
2318 class, is mocked so that it can be created. However, I am not sure
2319 why only this class needs to be mocked.
2321 Note that mockito seems more popular, and clearer, than easymock,
2322 but I have not got that working yet. It might be a matter of the
2325 This test is run during mvn integration-test.
2327 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2329 Tests: Use junit4-style syntax instead of junit3-style.
2331 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2332 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2333 * src/test/java/org/glom/web/shared/DataItemTest.java:
2334 Use the @Test annotation rather than relying on the test*() prefix.
2335 Also no longer implement TestCase, to avoid triggering support for
2336 the junit3-way, which stops the annotations from working.
2337 Change the imports from import junit.framework.* to
2338 import org.junit.*, which is apparently the new way.
2340 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2342 Added a test for ListPlace token parsing and creation.
2344 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2345 This is much the same as DetailsPlaceTest.
2347 I wonder how we could test the other parts of the *Place API.
2349 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2351 DetailsPlace test: Also test getToken() and recreation via getPlace().
2353 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2354 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2355 recreate it, testing the recreated DetailsPlace for the same parameter
2358 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2360 Use the surefire-report plugin.
2362 * pom.xml: This generates a HTML report about the tests in
2363 target/site/surefire-report.html
2364 when you do mvn surefire-report:report. It seems to be popular/normal.
2366 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2368 Added a test for DetailsPlace.
2370 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2371 Test the getPlace() token parsing.
2373 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2375 Added a first unit test.
2377 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2378 * src/test/java/org/glom/web/shared/DataItemTest.java:
2379 This is a silly test but it is just to get things started. Note that
2380 maven/junit finds the test because it looks in src/test by default.
2382 2011-12-22 Ben Konrath <ben@bagu.org>
2384 Change charsetName to "UTF-8" when replacing line breaks.
2386 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2387 that work in Java (such as "UTF8") will not work when compiled to
2390 This fixes a problem with multi-line details view fields that have hard
2391 line breaks. The "License Text" field on this page demonstrates the
2394 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2396 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2398 2011-12-22 Ben Konrath <ben@bagu.org>
2400 Fix another bug with related list navigation.
2402 I've tested all the navigation buttons in all of the related lists
2403 so things should be good now.
2405 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2407 2011-12-22 Ben Konrath <ben@bagu.org>
2409 Fix a crasher when refreshing the list view with the default table.
2411 This crash will also happen when loading the list view with the default
2412 table from a link or bookmark.
2414 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2415 to the main document selection page when the document id hasn't been
2417 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2418 the main document selection page when the document id hasn't been
2420 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2421 values for the details place when the document id hasn't been set.
2422 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2423 values for the list place when the document id hasn't been set.
2425 2011-12-21 Ben Konrath <ben@bagu.org>
2427 Protect against NPE when glom.document.locale is not in config.
2429 This patch protects against an NPE when glom.document.locale is not in
2430 the config file. This NPE will also happen if glom.document.locale is
2433 The patch also updates the error message to display the class name when
2434 the getMessage() returns null. This was happening when the NPE was
2435 thrown and I had "Configuration Error: null". If an NPE is encountered
2436 with this patch, "Configuration Error: NullPointerException " will be
2439 This commit closes this bug:
2441 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2443 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2445 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2447 Rename onlineglom.properties to onlineglom.properties.sample.
2449 * src/main/resources/onlineglom.properties: Rename to:
2450 * src/main/resources/onlineglom.properties.sample:
2451 * src/main/resources/README: And add this file explaining that people
2452 should rename it back when deploying.
2454 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2456 Allow choosing the translation in the .properties file.
2458 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2459 init(): Read a glom.document.locale value from the configuration file
2460 and call Glom's TransatableItem::set_current_locale() method.
2461 * src/main/resources/onlineglom.properties: Add a commented-out
2462 example of this new setting.
2464 It would be better to add &lang=de_DE to the URL, but the current
2465 libglom API does not allow us to do this easily. I am working on that.
2467 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2469 Avoid a crash in parsing of token parameters.
2471 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2472 ava: getTokenParams(): Do not crash if a parameter has a key but no
2473 value, and ignore parameters with neither.
2475 2011-12-17 Murray Cumming <murrayc@murayc.com>
2477 History token building/handling: Improve use of token parameters.
2479 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2480 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2481 and buildParamsToken(HashMap), for use by derived classes.
2482 Make the separator private because it is no longer be needed.
2483 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2484 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2485 instead of manual string concatenation.
2486 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2487 of hardcoded indices and awkward splitting code.
2488 * src/main/java/org/glom/web/client/place/ListPlace.java
2489 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2490 instead of manual string concatenation.
2491 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2492 of hardcoded indices and awkward splitting code.
2493 This should fix bug #666420
2495 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2497 Fix a Navgiation->Navigation typo in the code.
2499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2500 Rename processNavgiation() to processNavigation().
2502 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2504 Fix a seperator->separator typo in the code.
2506 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2507 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2508 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2511 2011-12-15 Ben Konrath <ben@bagu.org>
2513 Cleanup some comments.
2515 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2517 2011-12-14 Ben Konrath <ben@bagu.org>
2519 Replace \n with <br/> for multiline text in the details view.
2521 Vertical scrollbars are added when needed as well.
2523 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2525 2011-12-14 Ben Konrath <ben@bagu.org>
2527 Specify the font for document selection links.
2529 * src/main/webapp/style.css:
2531 2011-12-14 Ben Konrath <ben@bagu.org>
2533 Fix bouncy CellTable while paging.
2535 This doesn't currently work with related list tables in unselected
2538 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2540 2011-12-14 Ben Konrath <ben@bagu.org>
2542 Revamp the appearance of the document selection page.
2544 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2545 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2546 * src/main/webapp/style.css:
2548 2011-12-13 Ben Konrath <ben@bagu.org>
2550 Set navigation button column to the smallest size possible.
2552 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2554 2011-12-13 Ben Konrath <ben@bagu.org>
2556 Change OpenButton nomenclature to NavigationButton.
2558 Using NavigtionButton makes things more generic. Classes, methods and
2559 variables have been changed.
2561 This is a rename-only refactor.
2563 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2564 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2565 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2566 Renamed from OpenButtonCell.
2567 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2568 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2569 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2571 2011-12-12 Ben Konrath <ben@bagu.org>
2573 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2575 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2576 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2577 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2578 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2580 2011-12-12 Ben Konrath <ben@bagu.org>
2582 Update variable names and comments.
2584 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2585 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2587 2011-12-12 Ben Konrath <ben@bagu.org>
2589 Properly initialize numNonEmptyRows variable to zero.
2591 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2592 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2594 2011-12-05 Ben Konrath <ben@bagu.org>
2596 Add latest mockup with HTML tables.
2598 Features of this mockup:
2600 -> HTML table for flowtable
2601 -> HTML table for flowtable column
2602 -> Example of how related lists would look
2603 -> Not using text entries for data items
2605 The current version of Online Glom doesn't use HTML tables for the
2608 This mockup has been sent to the glom-devel mailing list but it's good
2609 to have it here as well.
2611 * mockups/details-view-html-tables.html:
2613 2011-12-05 Ben Konrath <ben@bagu.org>
2615 Remove unnecessary getPrimaryKeyField() method.
2617 getPrimaryKeyFieldForTable(String) has been renamed to
2618 getPrimaryKeyField(String).
2620 * src/main/java/org/glom/web/server/database/DBAccess.java:
2621 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2622 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2624 2011-12-05 Ben Konrath <ben@bagu.org>
2626 Add string representation of TypedDataItem value to conversion error message.
2628 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2629 message was extracted into its own method to avoid duplication.
2631 2011-12-05 Ben Konrath <ben@bagu.org>
2633 Add type checking to navigation primary key value creation.
2635 Create navigation primary key only if the expected type from the Glom
2636 document matches the type returned by the SQL query.
2638 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2640 2011-12-05 Ben Konrath <ben@bagu.org>
2642 Rename a couple of variables in RelatedListNavigation.
2644 This is a rename-only refactor.
2646 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2648 2011-12-05 Ben Konrath <ben@bagu.org>
2650 Move getListLayoutGroup() into getListViewLayoutGroup().
2652 This removes getListLayoutGroup(). It was only being called by
2653 getListViewLayoutGroup().
2655 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2657 2011-12-05 Ben Konrath <ben@bagu.org>
2659 Remove check for LayoutItem_Portal in list table method.
2661 This check is no longer necessary because the method isn't being used
2662 to create the LayoutItemPortal DTO.
2664 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2666 2011-12-05 Ben Konrath <ben@bagu.org>
2668 Properly support related list navigation.
2670 Navigation from the "Repository Analyzer -> Package Scans ->
2671 Dependencies" related table wasn't working because the primary key for
2672 related tables wasn't being set properly. This commit fixes the
2675 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2676 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2677 doesn't set the primary key properly for related list tables.
2678 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2679 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2680 useful for getting the primary key for list view tables and for related
2682 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2683 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2684 Move code to set the primary key for the table from the abstract
2685 ListDBAccess class to ListViewDBAccess as it's only correct for list
2687 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2688 Properly add primary key to related list tables.
2690 2011-12-02 Ben Konrath <ben@bagu.org>
2692 Properly set the horizontal alignment of fields.
2694 This fix is for both the list tables and the details view.
2696 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2697 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2698 to set the horizontal alignment of fields.
2700 2011-12-02 Ben Konrath <ben@bagu.org>
2702 Display currency codes in the details view.
2704 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2706 2011-12-02 Ben Konrath <ben@bagu.org>
2708 Avoid duplicate JNI call.
2710 JNI is not as efficient as pure Java and this is an easy (and small)
2713 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2714 Use previously retrieved value for whereClauseToTableName instead of
2717 2011-12-02 Ben Konrath <ben@bagu.org>
2719 Rename a couple of variables in RelatedListNavigation.
2721 This is a rename-only refactor.
2723 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2725 2011-12-02 Ben Konrath <ben@bagu.org>
2727 Indicate clearly that a mismatched primary key type is a bug.
2729 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2730 warning to error. Add 'This is a bug.' to message.
2732 2011-12-02 Ben Konrath <ben@bagu.org>
2734 Update / fix some comments.
2736 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2738 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2740 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2741 Fix comments. Add some TODOs.
2743 2011-12-02 Ben Konrath <ben@bagu.org>
2745 Enable navigation to details view with string primary key from related list.
2747 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2748 Create a text primary key value when return type of result is
2749 java.sql.Types.VARCHAR.
2751 2011-12-02 Ben Konrath <ben@bagu.org>
2753 Use checkboxes for booleans in the details view.
2755 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2757 2011-12-01 Ben Konrath <ben@bagu.org>
2759 Improve performance of related list height calculation.
2761 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2762 Put code to calculate the expected height in a static initializer so
2763 that that it's only called once.
2765 2011-12-01 Ben Konrath <ben@bagu.org>
2767 Show related list tables in notebooks (again).
2769 Calculate the height of the related list tables so the Notebook can be
2770 set the correct height. The height of the related list table is also needed by
2771 FlowTable to be able decide how to create the layout.
2773 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2774 and set the Portal height based on the height of the related list
2775 table and the Portal container.
2776 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2777 Add method to calculate the height of the related list tables.
2778 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2779 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2780 calculate the height of the Pager widget.
2782 2011-12-01 Ben Konrath <ben@bagu.org>
2784 Use CellTable API for table property instead of setting style on Element.
2786 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2788 2011-12-01 Ben Konrath <ben@bagu.org>
2790 Make ListViewTable and RelatedListTable a consistent height.
2792 The tables are now a consistent height regardless of the contents of
2793 the table. A hidden button is added to empty rows to ensure that the
2794 height of these rows will match the height of rows with data.
2796 A navigation button column is now added to every table. The width of
2797 the navigation column is set to 0px when a RelatedListTable shouldn't
2798 have navigation buttons. This maintains the a consistent row height in
2799 tables that don't show the navigation buttons.
2801 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2802 navigation column when not needed.
2803 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2804 arguments for navigation button to constructor of ListViewTable.
2805 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2806 hidden button for empty data rows.
2807 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2808 arguments for navigation button to constructor.
2809 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2810 create navigation buttons. Add hideNavigationButtons() method.
2811 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2812 arguments for navigation button to constructor.
2814 2011-12-01 Ben Konrath <ben@bagu.org>
2816 Use 'visibility: hidden' in Utils.getWidgetHeight().
2818 This is better choice because hidden elements are invisible, don't
2819 respond to events and are not part of the tab order. They will,