1 2012-07-21 Murray Cumming <murrayc@murrayc.com>
3 tests: Test translations moe.
5 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
6 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
7 Test titles in the non-default locale.
9 2012-07-21 Murray Cumming <murrayc@murrayc.com>
11 tests: Add SelfHostConfiguredDocumentTest
13 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
14 username and password, for use by ConfiguredDocument.
15 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
16 This tests some of the ConfiguredDocument API that requires a database connection.
18 2012-07-21 Murray Cumming <murrayc@murrayc.com>
20 Document: Load title translations and test them.
22 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
23 of titles. I am surprised that we do not do this yet.
24 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
25 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
26 Test translations more.
28 2012-07-20 Murray Cumming <murrayc@murrayc.com>
32 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
33 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
34 Set the timeout here too.
36 2012-07-20 Murray Cumming <murrayc@murrayc.com>
38 tests: ConfiguredDocumentTest: Make this pass.
40 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
41 Disable tests that need a database connection.
43 2012-07-20 Murray Cumming <murrayc@murrayc.com>
45 Use Java 1.7 instead of Java 1.6.
47 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
48 to do this twice, at least for Eclipse.
49 This seems OK because it is the current version.
51 2012-07-20 Murray Cumming <murrayc@murrayc.com>
55 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
56 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
57 Avoid using a null Connection.
59 2012-07-20 Murray Cumming <murrayc@murrayc.com>
61 tests: Add a ConfiguredDocument test.
63 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
66 2012-07-20 Murray Cumming <murrayc@murrayc.com>
68 LayoutItemFIeld: getName(): Use the Field if it is set.
70 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
71 getName(): If the full field details have been set, return its name, so that
72 callers do not need to set the name separately.
73 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
74 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
75 so we can count the rows.
77 2012-07-20 Murray Cumming <murrayc@murrayc.com>
79 tests: SelfHoster: Test SqlUtils too.
81 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
82 Retrieve some data and check it too, as in the regular Glom
83 test_selfhosting_new_from_example.cc test.
84 * src/test/java/org/glom/web/server/SelfHoster.java:
85 createConnection(): Make this public.
87 2012-07-20 Murray Cumming <murrayc@murrayc.com>
89 tests: SelfHoster: createConnection(): Do not warn about expected failures.
91 Let the caller say if the connection is expected to fail, to avoid
92 irrelevant error output.
94 2012-07-20 Murray Cumming <murrayc@murrayc.com>
96 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
98 * src/test/java/org/glom/web/server/SelfHoster.java:
99 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
100 due to the inevitable need to retry the connection while the database server
103 2012-07-20 Murray Cumming <murrayc@murray.com>
105 tests: SelfHoster: createConnection(): Set a timeout.
107 * src/test/java/org/glom/web/server/SelfHoster.java:
108 createConnection(): Use setLoginTimeout() because it otherwise seems to take
109 ages to actually return when it fails.
111 2012-07-20 Murray Cumming <murrayc@murrayc.com>
113 tests: SelfHoster: selfHost(): Close the test connection.
115 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
116 When we check that the connection works, close the connection. This seems
117 to not be closed automatically otherwise.
119 2012-07-20 Murray Cumming <murrayc@murrayc.com>
121 Use slf4j-simple to see JDBC errors.
123 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
125 2012-07-19 Murray Cumming <murrayc@murrayc.com>
127 SelfHoster.discoverFirstFreePort(): Close the socket.
129 * src/test/java/org/glom/web/server/SelfHoster.java:
130 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
132 2012-07-19 Murray Cumming <murrayc@murrayc.com>
134 Avoid another code warning in Eclipse Juno.
136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
137 Do instanceof checks on the FileUtils.listFiles() result and its
140 2012-07-13 Murray Cumming <murrayc@murrayc.com>
142 Avoid some code warnings in Eclipse Juno
144 * src/main/java/org/glom/web/server/libglom/Document.java:
145 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
146 * src/test/java/org/glom/web/server/SelfHoster.java
147 createTextFile(): Make sure that the FileOutputStream is closed.
149 2012-06-22 Murray Cumming <murrayc@murrayc.com>
151 Added OnlineGlomPropertiesTest.
153 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
154 Make sure we never return a null string.
155 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
156 Added tests of the OnlineGlomProperties API, using our sample file.
158 2012-06-20 Murray Cumming <murrayc@murrayc.com>
160 Make OnlineGlomProperties be a normal class.
162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
163 Move OnlineGlomProperties into its own file to be a regular class:
164 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
165 This makes testing simpler.
167 2012-06-15 Murray Cumming <murrayc@murrayc.com>
169 OnlineGlomServiceImpl.init(): Move some code into a new method.
171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
172 Create addDocument().
174 2012-06-15 Murray Cumming <murrayc@murrayc.com>
176 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
179 OnlineGlomProperties.getKey(): Make this more robust by moving the
180 check for *.*.filename to here.
182 2012-06-15 Murray Cumming <murrayc@murrayc.com>
184 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
187 init(): Move knowledge of the config file format into the
188 OnlineGlomProperties inner class.
190 2012-06-15 Murray Cumming <murrayc@murrayc.com>
192 SelfHostExampleTest: Make sure we cleanup on failure.
194 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
195 the use of cleanup() to a tearDown() JUnit method.
197 2012-06-12 Murray Cumming <murrayc@murrayc.com>
199 ConfiguredDocument: Add a primary key to portals at least once.
201 * src/main/java/org/glom/web/server/ConfiguredDocument.java
202 updatePortalsExtras): Fix a typo so that we add the primary key
203 column at least once.
204 This is a fix for the previous commit:
205 ConfiguredDocument: Do not add a primary key to portals each time.
207 2012-06-08 Murray Cumming <murrayc@murrayc.com>
209 SelfHoster: Avoid some compiler warnings.
211 * src/test/java/org/glom/web/server/SelfHoster.java
212 executeCommandLineAndWait():
213 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
214 the now-unused streams for stdout and stderr from the command Processes.
215 These are not used because readln() hangs while waiting for a new line,
216 where there may be no next line. The commented out code is still there
217 to help us figure out how to do this properly.
219 2012-06-08 Murray Cumming <murrayc@murrayc.com>
221 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
223 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
224 Make this actually test the cloning again, though it is not very useful
225 now that we do not use the part that had a problem with cloning before.
227 2012-06-08 Murray Cumming <murrayc@murrayc.com>
229 SelfHoster: Keep trying pg_ctl after starting postgres.
231 * src/test/java/org/glom/web/server/SelfHoster.java
232 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
233 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
234 regular Glom. This seems mad but it seems to work because the first
235 command would fail if pg_ctl would eventually fail.
237 2012-06-08 Murray Cumming <murrayc@murrayc.com>
239 SelfHoster: Wait until the server is really ready.
241 * src/test/java/org/glom/web/server/SelfHoster.java
242 selfHost(): Attempt the connection after starting the server, retrying
243 a few times if necessary, so that the server is really ready already when
244 we return from this method.
245 The regular Glom code does this too because pg_ctl reports success too soon.
247 2012-06-08 Murray Cumming <murrayc@murrayc.com>
249 ConfiguredDocument: Do not add a primary key to portals each time.
251 * src/main/java/org/glom/web/server/ConfiguredDocument.java
252 updatePortalsExtras(): Only add an extra primary key field if there is
253 none, to avoid adding one each time we retrieve the details layout from the
255 This should fix bug #676986 (Ben Konrath)
257 2012-05-25 Murray Cumming <murrayc@murrayc.com>
259 Document.load(): Support version 7 documents.
261 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
262 database_title attribute if the title attribute is not there.
265 2012-05-24 Ben Konrath <ben@bagu.org>
267 Add configuration for auto-generating mvn:i18n from with Eclipse.
269 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
271 2012-05-24 Murray Cumming <murrayc@murrayc.com>
273 Update translations, adding French.
275 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
276 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
277 Add a French translation, using the translation from Glom.
279 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
280 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
281 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
282 Update these based on the translations from Glom.
284 2012-05-24 Murray Cumming <murrayc@murrayc.com>
286 SelfHoster: Add some debug println messages to help when things fail.
288 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
289 System.out.println() lines.
291 2012-05-23 Murray Cumming <murrayc@murrayc.com>
293 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
295 * src/test/java/org/glom/web/server/SelfHoster.java:
296 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
297 instance) instead of just /usr/bin (as on Fedora). Check the result when
300 2012-05-23 Murray Cumming <murrayc@murrayc.com>
302 Remove LayoutItemPortal.get/setNavigationTable().
304 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
305 Remove get/setNavigationTable(), which is only a cache, because it is not
306 used, and does not need to be used, because that decision should be made on
308 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
309 updatePortalsExtras():
310 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
311 getNavigationRecord():
312 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
315 2012-05-21 Murray Cumming <murrayc@murrayc.com>
317 Initial self-hosting for tests.
319 * pom.xml: Change the scope for log4j, to hopefully make it
320 available to the test code which uses it indirectly via jOOQ.
321 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
322 self-hosting, though we only use it for testing.
324 * src/main/java/org/glom/web/server/libglom/Document.java:
325 example rows: Use a map instead of a list for each row of values,
326 so we know what field they are for, instead of relying on the sequence
327 being correct. This is not very efficient, but it does not really need
329 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
330 testReadTableExampleRows(): Adapted.
332 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
333 that returns an Object, for generic use. Note that Object seems to be
334 the implicit base even of double.
335 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
336 for use in CREATE TABLE SQL queries.
337 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
338 to do self-hosting of PostgreSQL databases via its command-line
339 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
340 backends/postgres_self.cc. This is incomplete - it needs more
341 warnings about failures and it needs to clean up properly when things
343 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
344 test of this new class.
346 2012-05-21 Murray Cumming <murrayc@murrayc.com>
348 Document: loading example data: Handle exceptions.
350 * src/main/java/org/glom/web/server/libglom/Document.java:
351 DateFormat.parse() and Double.valueOf() can throw exceptions, though
352 Eclipse did not warn about that.
354 2012-05-20 Murray Cumming <murrayc@murrayc.com>
356 Document: load(), save(): Handle the example rows.
358 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
360 * src/main/java/org/glom/web/server/libglom/Document.java:
361 load(), save(): Load and save the example rows, though the date, time
362 and image types are not handled properly yet.
363 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
364 Add testReadTableExampleRows() just to check that something is read.
366 2012-05-20 Murray Cumming <murrayc@murrayc.com>
368 Document: Add save().
370 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
371 Added getTranslationsMap() for use while saving.
372 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
373 Adedd getUseDefaultFormatting() for use while saving.
374 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
375 and several private methods that it uses.
377 This will be useful while testing via self-hosting.
378 It is not complete, but should be complete enough for testing.
380 2012-05-17 Murray Cumming <murrayc@murrayc.com>
382 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
384 * src/main/java/org/glom/web/client/OnlineGlomService.java
385 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
387 Remove getSortedListViewData() and getSortedRelatedListData(), adding
388 the sort column index and ascending bool to the regular method.
389 Instead, a sort column index of -1 now means no sort.
390 This is less explicit, but it's fairly simple, reduces the amount of
391 code, and makes the OnlineGlomService API slightly smaller.
392 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
393 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
395 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
396 getListViewData(), getRelatedListData():
397 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
398 getListViewData(), getRelatedListData():
399 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
401 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
403 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
408 2012-05-16 Murray Cumming <murrayc@murrayc.com>
410 Use translations for top-level groups too.
412 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
413 updateTitlesForLocale(): Use the translation for the group
414 as well as for child items.
418 Just recompiled to fix a problem in the released .tar.gz file.
422 2012-05-15 Murray Cumming <murrayc@murrayc.com>
424 Corrections to navigation to related records.
426 * src/main/java/org/glom/web/client/OnlineGlomService.java:
427 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
428 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
429 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
430 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
431 relationship name, because the relationship name is not necessarily unique
433 TOOD: This is inefficient, because it passes the whole list of
434 child field items back to the server, but it is more correct, and happens
435 to fix a bug with the primary key being lost after a few navigations.
436 There is probably a chance to make this more efficient anyway in some
439 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
440 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
441 * src/main/java/org/glom/web/server/ConfiguredDocument.java
442 * src/main/java/org/glom/web/server/database/DBAccess.java
443 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
444 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
447 2012-05-15 Murray Cumming <murrayc@murrayc.com>
449 Fix the use of translations.
451 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
452 Add updateTitlesForLocale().
453 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
454 Call it to discard unwanted translations and to make getTitle() return
455 the wanted translation wihout the need for the client code to specify a locale.
456 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
457 getTitle(): Fallback to the original title, as libglom does.
459 2012-05-15 Murray Cumming <murrayc@murrayc.com>
461 Document: Correctly report the number of available translation locales.
463 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
464 the available locale IDs list.
465 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
466 testLocales: Test this.
468 2012-05-15 Murray Cumming <murrayc@murrayc.com>
470 SqlUtils: Use camelCase.
472 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
473 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
474 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
475 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
476 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
477 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
479 2012-05-15 Murray Cumming <murrayc@murrayc.com>
481 Use jOOQ's tableByName() and fieldByName.
483 * pom.xml: Use jOOQ 2.3.1 to get the new API.
484 * src/main/java/org/glom/web/server/SqlUtils.java:
485 build_sql_select_step_with_where_clause(), .createField(),
486 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
487 so we can get correct quoting and escaping. Thanks to Lukas Eder for
488 adding this, and other things, to jOOQ.
490 2012-05-15 Murray Cumming <murrayc@murrayc.com>
492 SqlUtils: Remove the Connection parameters.
494 * src/main/java/org/glom/web/server/SqlUtils.java:
495 build_sql_select_with_key(), build_sql_select_with_where_clause(),
496 createSelect(), build_sql_select_step_with_where_clause(),
497 build_sql_count_select_with_where_clause(),
498 build_sql_select_count_rows(): Remove the Connection parameter because
499 jOOQ does not actually need a connectionwhen it is just used to build
501 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
503 * src/main/java/org/glom/web/server/ReportGenerator.java:
505 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
507 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
508 Constructor, getListData(), getResultSizeOfSQLQuery():
509 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
510 getSelectQuery(), getCountQuery():
511 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
512 getSelectQuery(), getCountQuery():
513 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
514 getNavigationRecord(): Adapted.
516 2012-05-14 Murray Cumming <murrayc@murrayc.com>
520 * src/main/java/org/glom/web/server/SqlUtils.java:
521 get_find_where_clause_quick(): Use a comparison of
522 lowercase values, instead of a simple equals. Regular Glom
523 uses the PostgreSQL ILIKE operator but jOOQ does not
524 support that just yet, though it will soon.
526 2012-05-14 Murray Cumming <murrayc@murrayc.com>
528 TableToViewDetails: Use a real serialization ID.
530 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
531 Though this does not fix the serialization problem.
533 2012-05-12 Murray Cumming <murrayc@murrayc.com>
535 Added LayoutItemPortalDeepCloneTest.
537 2012-05-11 Murray Cumming <murrayc@murrayc.com>
539 Make navigation work again.
541 * src/main/java/org/glom/web/server/libglom/Document.java:
542 Add getLayoutItemFieldShouldHaveNavigation().
543 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
544 Replace get/setAddNavigation() with the partly-existing
545 get/setNavigationTableName(), with an empty string being no navigation,
546 because this is simpler. Use the new
547 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
549 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
550 Add updateFieldsExtras() and call setNavigationTableName in it.
551 getDetailsLayoutGroup(),
552 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
553 createLayout(): Adapted.
554 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
555 Constructor: Adapted.
557 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
558 Replace get/setAddNavigation() with get/setNavigation(), returning a
559 TableToViewDetails class with both the table name and UsesRelationship,
560 because both are need. The previous code used java-libglom's output
561 variable (strangely, via sharedptr) to return both, but we cannot really
563 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
564 getNavigationRecord(): Adapt. However, we cannot actually use the cache
565 here because it somehow gets set to null during deepCopy(). I must test this.
566 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
567 testGetSuitableTableToViewDetails(): Adapted.
569 TODO: Find out why deepClone() is not quite working.
571 2012-05-11 Murray Cumming <murrayc@murrayc.com>
573 DBAccess: Simplify the retrievel of full field details.
575 * src/main/java/org/glom/web/server/database/DBAccess.java
576 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
577 because the Document loading should have done this.
579 2012-05-11 Murray Cumming <murrayc@murrayc.com>
581 Document: Correct loading of doubly-related layout fields.
583 * src/main/java/org/glom/web/server/libglom/Document.java:
584 loadUsesRelationship(): Actually set the related relationship, instead
585 of only setting it if it's not found.
587 2012-05-09 Murray Cumming <murrayc@murrayc.com>
589 Replace all appearances of Colour with color.
591 Because US English is dominant.
593 2012-05-09 Murray Cumming <murrayc@murrayc.com>
595 Use colors in HTML format, solving a warning about an unused function.
597 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
598 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
599 Add *asHTMLColor() versions of methods.
600 TODO: However, we should create and cache the results on the server.
601 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
602 * src/main/java/org/glom/web/client/ui/list/ListTable.java
603 * src/main/java/org/glom/web/server/ConfiguredDocument.java
604 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
605 Use the asHTMLcolor() versions.
607 2012-05-09 Murray Cumming <murrayc@murrayc.com>
609 ListViewTable: Constructor: Take the table name as a parameter.
611 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
612 Constructor: Take the tableName, and set the member variable, because
614 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
615 setCellTable(): Pass the table name.
616 This makes navigation to non-default tables work again. I don't know
617 why it worked before in the master branch.
619 2012-05-07 Murray Cumming <murrayc@murrayc.com>
621 ConfiguredDocument: Restore correct addition of hidden primary key items.
623 * src/main/java/org/glom/web/client/ui/list/ListTable.java
624 (ListTable.createCellTable): Uncomment out the check for the hidden
626 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
627 add primary key items for top-level lists and portals, as before,
628 instead of adding them to each group.
629 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
630 Actually implement the extra methods such as setHiddenPrimaryKey() and
631 comment that these are used only for top-level list groups and in portals.
632 This strangeness suggests even more that this should not be squeezed
633 into the LayoutGroup class.
635 2012-05-07 Murray Cumming <murrayc@murrayc.com>
637 Fix Formatting loading.
639 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
640 getFormattingUsed(): Remove the duplicate Formatting member variable
641 in favour of the one from the base class.
642 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
643 Initialize a new Formatting instead of using null by default, so we
644 have some defaults, instead of having to initialize one later just to
645 get the same defaults. This also makes loading of formatting from the
646 document work, because that expected a non-null.
648 2012-05-07 Murray Cumming <murrayc@murrayc.com>
650 RelatedListTable: Make sure that the tableName is set.
652 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
653 Constructor: Take the tableName so it is available later. Otherwise,
654 the server assumes that we mean the default table and cannot find the
656 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
657 setData(): Pass the tableName to the RelatedListTable constructor.
659 2012-05-07 Murray Cumming <murrayc@murrayc.com>
663 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
664 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
665 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
667 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
669 * src/main/java/org/glom/web/server/database/DBAccess.java:
670 convertResultSetToDTO(), getPortal():
671 * src/main/java/org/glom/web/server/database/ListDBAccess.java
673 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
674 Add checks for null objects and out of range access, with log messages to
675 give hints so we can fix these properly.
677 2012-05-07 Murray Cumming <murrayc@murrayc.com>
679 Portals: some corrections.
681 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
683 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
684 constructor: Use getRelationshipNameUsed() instead of getName(), because
685 that is what is meant.
686 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
687 getFromField(): Fix a typo, to get the field name, not the table name.
688 * src/main/java/org/glom/web/server/database/DBAccess.java:
689 getPortal(): Fix a typo that stopped this from working.
691 2012-05-07 Murray Cumming <murrayc@murrayc.com>
693 LayoutItemPortal: Also override getTitleOriginal().
695 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
696 This lets the base getTitle() with no parameters work.
697 TODO: Test this properly.
699 2012-05-06 Murray Cumming <murrayc@murrayc.com>
701 LayoutItemPortal: getTitle*(): Use the relationship title.
703 2012-05-06 Murray Cumming <murrayc@murrayc.com>
705 LayoutItemField: Fix loading of custom titles.
707 * src/main/java/org/glom/web/server/libglom/Document.java
708 loadDataLayoutItemField(): The title, if any, instead of the field
709 title, is stored in a title_custom node. Load it from there.
710 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
712 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
713 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
714 getTitle*() overrides.
715 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
718 2012-05-06 Murray Cumming <murrayc@murrayc.com>
720 LayoutItemField: Fall back to field titles, so some are really shown.
722 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
723 Override getTitleOriginal() and getTitle(), as in java-libglom.
724 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
727 2012-05-06 Murray Cumming <murrayc@murrayc.com>
729 Correct use of setExpectedResultSize().
731 * src/main/java/org/glom/web/server/ConfiguredDocument.java
732 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
733 Use setExpectedResultSize only on top-level groups (for instance, the
734 list layout) or on child portals (in details views).
735 Use the correct table name for portals to avoid SQL errors.
736 Update the expected counts when returning cached layouts.
738 2012-05-06 Murray Cumming <murrayc@murrayc.com>
740 Document: Interpret no group column count as 1.
742 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
743 default, though we now check for this in the UI code anyway.
745 2012-05-06 Murray Cumming <murrayc@murrayc.com>
749 2012-05-06 Murray Cumming <murrayc@murrayc.com>
751 Translatable: Use Hashmap instead of Treemap because GWT supports it.
753 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
754 The use of Treemap lead to this error from async methods, with no
756 "The response could not be deserialized"
758 2012-05-06 Murray Cumming <murrayc@murrayc.com>
760 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
762 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
763 when using the Google -> GWT Compile, or
764 g toolbar button -> GWT Compile Project... feature in Eclipse.
766 2012-05-06 Murray Cumming <murrayc@murrayc.com>
768 ListTable.addColumn(): Protect against a null Formatting.
770 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
771 Create a default Formatting if it is null, because that is the simplest
774 2012-05-06 Murray Cumming <murrayc@murrayc.com>
776 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
778 * src/main/java/org/glom/web/server/ConfiguredDocument.java
779 updateLayoutGroup(): Check that the field is not null.
781 2012-05-06 Murray Cumming <murrayc@murrayc.com>
783 ListViewImpl: Protected against a bad cast error.
785 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
786 onEnterKeyDown(): Do not cast without an instanceof check.
788 2012-05-06 Murray Cumming <murrayc@murrayc.com>
790 ListTable: Protect against an out of range error.
792 * src/main/java/org/glom/web/client/ui/list/ListTable.java
793 createCellTable(): This is unlikely, but can happen while debugging.
795 2012-05-06 Murray Cumming <murrayc@murrayc.com>
797 AsyncMessage onFailure() callbacks: Log the exception message.
799 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
800 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
801 * src/main/java/org/glom/web/client/activity/ListActivity.java:
802 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
803 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
804 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
805 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
806 These are useful clues when something is wrong.
808 2012-05-06 Murray Cumming <murrayc@murrayc.com>
810 ConfiguredDocument: Avoid a null dereference.
812 * src/main/java/org/glom/web/server/ConfiguredDocument.java
813 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
814 details maps are created.
816 2012-05-06 Murray Cumming <murrayc@murrayc.com>
818 Document: Correct the port number parsing.
820 * src/main/java/org/glom/web/server/libglom/Document.java:
821 This lets us actually connect to the database and show the document.
823 2012-05-05 Murray Cumming <murrayc@murrayc.com>
827 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
828 user-interaction, asking us to load a temporary URL in a browser.s
829 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
830 which is apparently necessary for testing the service. See the comment.
831 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
832 Show the exception, if any. This is how I saw the 404 in the HTML in
835 2012-05-05 Murray Cumming <murrayc@murrayc.com>
837 DocumentTest: Move the .glom files into the resources directory.
839 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
840 URI via getResource().
842 2012-05-05 Murray Cumming <murrayc@murrayc.com>
844 Document: Remove the FieldIdentifies inner class.
846 * src/main/java/org/glom/web/server/libglom/Document.java: We only
847 use the Relationship (though the same function in libglom is maybe
848 used in other ways) and so this removes a compiler warning.
850 2012-05-05 Murray Cumming <murrayc@murrayc.com>
852 Document.load() Remove the error code parameter.
854 * src/main/java/org/glom/web/server/libglom/Document.java: load():
855 Remove the parameter. We do not set it yet and it could never have
856 worked as an output parameter (though maybe it did in java-libglom).
857 We could use an exception if we really want the failure reason.
858 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
860 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
861 setUp(), testGetSuitableTableToViewDetails(): Adapt.
863 2012-05-05 Murray Cumming <murrayc@murrayc.com>
865 Make some inner classes static.
867 * src/main/java/org/glom/web/server/ConfiguredDocument.java
868 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
869 * src/main/java/org/glom/web/server/ReportGenerator.java
870 * src/main/java/org/glom/web/server/libglom/Document.java
871 Make all inner classes static that can be static.
873 2012-05-05 Murray Cumming <murrayc@murrayc.com>
875 OnlineGlomServiceImpl: Do not load and check for java-libglom.
877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
878 init(): We do not use java-libglom any more.
880 2012-05-05 Murray Cumming <murrayc@murrayc.com>
882 Remove mentions of java-libglom.
884 * README: Remove mention of java-libglom, because it no longer needed.
885 * utils/build-onlineglom-war.sh:
886 * utils/check-and-recover-tomcat.py:
887 * utils/install-onlineglom-war.sh: Remove these as they are no longer
888 useful. Building is now far easier, with no need for jhbuild.
890 2012-05-05 Murray Cumming <murrayc@murrayc.com>
892 Fix the build (mvn package)
894 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
895 (LayoutGroup): Make the LayoutItemList inner class static and protected.
896 Otherwise the GWT Java->Javascript compilation fails with just this
897 error, during mvn package or when attempting to view in a browser,
898 in the GWT developer mode in Eclipse.
900 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
901 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
902 [INFO] Compiling module org.glom.web.OnlineGlom
903 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
904 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
905 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
906 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
907 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
908 [INFO] [ERROR] Cannot proceed due to previous errors
910 It has taken me 2 days to find out what was causing that. After reducing
911 the code, the compiler eventually showed me the full error message.
913 2012-05-04 Murray Cumming <murrayc@murrayc.com>
915 ConfiguredDocument: Cache the cloned and stripped layouts.
917 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
918 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
919 layout in a map, so we can retrieve it again without rebuilding it.
921 2012-05-04 Murray Cumming <murrayc@murrayc.com>
923 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
925 2012-05-04 Murray Cumming <murrayc@murrayc.com>
927 libglom classes: Implement some auto-generated emthods.
929 2012-05-04 Murray Cumming <murrayc@murrayc.com>
931 Add GwtTestOnlineGlomService.
933 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
934 However, this (and the other GwtTest*) does not seem to run during
937 2012-05-04 Murray Cumming <murrayc@murrayc.com>
939 Remove use of unsupported features from client code.
941 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
942 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
943 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
944 Use our client version of StringUtils instead of the apache commons one.
946 However, the GWT Javascript compliation still fails.
948 2012-04-25 Murray Cumming <murrayc@murrayc.com>
950 Add a Field class and implement some loading of it in Document.
952 2012-04-25 Murray Cumming <murrayc@murrayc.com>
954 Initial Document loading implementation, instead of libglom.
956 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
957 and Translatable classes, and adapt the rest of the code to use them.
958 However, this is still missing Layout and Field classes and loading.
960 2012-04-24 Murray Cumming <murrayc@murrayc.com>
962 Use of jOOQ: Move Field creation into a utility method.
964 * src/main/java/org/glom/web/server/SqlUtils.java:
965 This lets us improve it more easily.
967 2012-04-24 Murray Cumming <murrayc@murrayc.com>
969 Use of jOOQ: Improve the code to COUNT a sub-select.
971 * src/main/java/org/glom/web/server/SqlUtils.java:
972 Move initial query creation into
973 build_sql_select_step_with_where_clause().
974 build_sql_select_count_rows(): Use the jOOQ API instead of
975 concatentating text, because a jOOQ Select*Step is a TableLike,
976 which is what from() takes.
978 2012-04-23 Murray Cumming <murrayc@murrayc.com>
980 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
982 * pom.xml: Depend on jooq.
983 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
984 methods with jOOQ, based on the C++ implementations in libglom,
985 with some changes to the logic required by jooQ.
986 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
988 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
989 * src/main/java/org/glom/web/server/ReportGenerator.java:
990 * src/main/java/org/glom/web/server/SqlUtils.java:
991 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
992 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
993 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
994 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
995 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
996 Adapt. In particular, the SqlUtils methods now need to take a Connection,
997 because jOOQ needs that, though it seems unnecessary.
999 This is not quite finished. Ideally jOOQ would help us to build
1000 table_name.field_name names, quoting and escaping them properly.
1001 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1003 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1005 Move use of Glom.build_sql*() into a new SqlUtils class.
1007 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1008 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1009 but this will make it easier to start using something other than
1010 libglom or SqlBuilder.
1012 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1014 Update the project URL.
1016 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1018 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1020 Main layout: Use a FlowTable instead of absolute positioning.
1022 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1023 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1024 child panels/widgets must have an absolute position. But that is annoying, so
1025 this adds a FlowTable and puts the child panels in there.
1027 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1029 GwtTestOnlineGlom: Comment out unused code.
1031 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1032 Eclipse has started to say that some code is unused.
1034 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1036 Update to the latest versions of dependencies.
1038 * pom.xml: Update version numbers of dependencies to the latest
1040 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1041 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1042 * src/main/java/org/glom/web/server/ReportGenerator.java:
1043 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1044 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1045 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1047 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1048 Modify the imports where necessary.
1050 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1052 Style: Remove overflow:hidden from searchbox
1054 * src/main/webapp/style.css: Because this pushes the Back To Link
1055 label/link on to the next row, which is then hidden due to the
1056 hard-coded (in ems) height.
1058 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1060 Remove some duplicate code.
1062 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1063 getDocumentInfo(): This must have been duplicated during the merge from the
1068 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1070 Reports: Localize the waiting for report message.
1072 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1073 start(): Get the message from the contants.
1074 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1075 Add the string here.
1076 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1077 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1078 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1079 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1080 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1081 Update these files with the English text for newer strings for now.
1083 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1085 Reports: Show a message while waiting for the report.
1087 * src/main/java/org/glom/web/client/ui/ReportView.java
1088 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1089 Add setWaitingText(), to show a message saying that we are
1090 waiting for the report to be ready.
1091 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1092 start(): Call setWaitingText() before calling the async
1095 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1097 ReportGenerator: Specify date and time formats.
1099 * src/main/java/org/glom/web/server/ReportGenerator.java:
1100 createFieldValueElement(): Use the default (and localized)
1101 short formats, though we still need a way to show 4-digit
1102 years without providing the format for every locale.
1103 * src/main/java/org/glom/web/server/database/DBAccess.java:
1104 convertResultSetToDTO(): Use the short formats here too.
1106 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1108 ReportGenerator: Use the correct numeric formatting.
1110 * src/main/java/org/glom/web/server/ReportGenerator.java
1111 createFieldExpression(), createFieldValueElement(): Take the
1112 whole LayoutItem_Field instead of just the field name, so
1113 we have access to the formatting.
1114 createFieldValueElement(): Use JRTextField.setPattern() to
1115 specify the numeric formatting, with the help of a
1116 regular DecimalFormat.
1118 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1120 ReportGenerator: Avoid showing null for group by titles.
1122 * src/main/java/org/glom/web/server/ReportGenerator.java
1123 generateReport(): Use setBlankWhenNull() on the field title
1124 style too, because this is used for values in group by
1127 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1129 ReportGenerator: Add a colon to titles in vertical groups.
1131 * src/main/java/org/glom/web/server/ReportGenerator.java
1132 addFieldToDetailBandVertical(): Pass true for the withColon
1135 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1137 ReportGenerator: Simplify the code by using Position more.
1139 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1141 Reports: Support vertical groups, roughly.
1143 * src/main/java/org/glom/web/server/ReportGenerator.java:
1144 addToReport(): Rename to addGroupToReport() and, if necessary,
1145 call the new addVerticalGroupToReport() method.
1146 createFieldValueElement(): Let the caller specify the Y position
1149 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1151 Reports: Allow a second report to be shown.
1153 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1154 clear(): Do not remove the HTML widget, which broke the whole layout.
1156 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1158 Locales drop-down: Show that we use English by default.
1160 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1161 fillView(): When we use English, just because that is the default, when
1162 no locale is specified, show that in the Locales drop-down instead of
1163 just showing the first item.
1165 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1167 Unselect the Report/Locale/Table combo item when appropriate.
1169 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1170 setPlace(): clear reportName if this is not a ReportPlace.
1171 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1172 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1173 When the provided name is empty, unselect all items, so that none are
1174 indicated. This uses a for loop because I cannot find a single method
1177 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1179 Report: Give the user a way to get back to the list.
1181 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1182 start(), setPlace(): Show the Back To List link on reports, and also
1183 interpret selecting the empty report item as back to list.
1185 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1187 Really show the selected Report name.
1189 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1190 setPlace(): Store the reportName here, if it is that kind of Place.
1191 fillView(): Set the selected Report after filling the list of reports.
1192 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1193 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1194 null Strings, though we need some way to unselect all ListBox items
1197 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1199 ReportGenerator: Try to avoid some problems.
1201 * src/main/java/org/glom/web/server/ReportGenerator.java
1202 addField(): Try to avoid duplicates, and avoid using a null
1205 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1207 Reports: Use quickFind.
1209 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1210 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1212 getReportHTML(): Add a quickFind parameter.
1213 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1214 start(): Pass the quickFind parameter.
1215 * src/main/java/org/glom/web/server/ReportGenerator.java
1216 generateReport(): Take a quickFind parameter.
1218 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1220 ReportPlace: Actually use the report name.
1222 * src/main/java/org/glom/web/client/place/ReportPlace.java
1223 getPlace(): Do not assign the report name to the quickfind.
1225 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1227 Show java.library.path when complaining.
1229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1230 init(): When telling us to check java.library.path, show the
1233 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1235 ReportGenerator: Do not show nulls.
1237 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1239 ReportGenerator: Make the title font larger.
1241 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1243 ReportGenerator: Put field titles inside groups, if there are groups.
1245 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1247 ReportGenerator: Take the Report itself instead of the name and group.
1249 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1250 Remove getReportLayoutGroup().
1251 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1252 getReportHTML(): Pass the report instead
1253 of its name and layout group.
1254 * src/main/java/org/glom/web/server/ReportGenerator.java
1255 generateReport(): Use the report object to use the title
1256 instead of the name.
1258 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1260 ReportGenerator: Remove designBand parameters.
1262 * src/main/java/org/glom/web/server/ReportGenerator.java:
1263 Make designBand a class member instead of passing it to all
1266 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1268 ReportGenerator: Add lines, a bit like in the desktop version.
1270 * src/main/java/org/glom/web/server/ReportGenerator.java
1271 addToReport(): Use JRDesignLine.
1273 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1275 ReportGenerator: Correct the title positions and use some bold style.
1277 * src/main/java/org/glom/web/server/ReportGenerator.java:
1278 Break the code up into reusable functions, correct the placement of
1279 titles, and use normal/bold styles as in the reports in the desktop
1282 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1284 ReportGenerator: Add a header band to show the field titles.
1286 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1287 getReportHTML(): Pass the localeId to the ReportGenerator
1289 * src/main/java/org/glom/web/server/ReportGenerator.java
1290 constructor: Take the localeID so we can get translated field
1292 generateReport(), addToReport(), addFieldToBand(): Add field
1293 titles in a column header band.
1295 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1297 Reports drop-down list: Some improvement.
1299 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1300 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1301 Adedd setSelectedReport(),
1302 setReportList(): Add a blank line so that the user can select the
1304 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1305 start(): Show the current report by calling setSelectedReport().
1306 This does not seem to work yet.
1308 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1310 DetailsActivity, ListActivity: Move some variables into a base class.
1312 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1313 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1314 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1315 the clientFactory, documentID, tableName and authenticationPopup into
1316 a base class, to avoid duplication.
1318 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1320 Translate the Reports label.
1322 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1323 Get the "Reports" label string from the constants.
1324 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1325 perties: Add Reports to the constants.
1327 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1329 Reports: Implement grouping.
1331 * src/main/java/org/glom/web/server/ReportGenerator.java:
1332 Handle LayoutItem_GroupBy items and try to do the right thing
1333 with JRDesignGroup. It seems to work.
1335 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1337 Actually show some data with JasperReports.
1339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1340 getReportHTML(): Move most code into a ReportGenerator class.
1341 * src/main/java/org/glom/web/server/ReportGenerator.java:
1342 Recurse into sub-groups, adding fields to the JasperDesign's details
1343 band. Note that we must set an arbitrary width and height, or it just
1344 will not show any data.
1346 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1348 Reports Chooser: Show the titles, not the names.
1350 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1351 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1352 and the names as the values.
1353 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1354 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1355 group now that we provide the report name, so it should always
1358 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1360 Depend on jasperreports.
1362 * pom.xml: Add the dependency. My plan is to use this on the
1365 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1367 Implement navigation to report places.
1369 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1370 start(): Do not bother to handle all events here.
1371 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1372 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1373 Added getSelectedReport().
1374 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1375 .java: start(): When handling a change to the reports chooser,
1376 call getSelectedReport() and goTo() its ReportPlace.
1377 * src/main/java/org/glom/web/client/ui/ReportView.java
1378 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1379 Added setReportHTML() which puts the html in a gwt HTML widget.
1380 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1381 getReportHTML(): Return "TODO" just to show that this works.
1383 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1385 Make ReportPlace usable.
1387 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1388 Mention ReportPlace.
1389 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1390 Correct the @prefix annotation.
1392 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1394 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1396 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1397 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1398 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1399 Change getReportLayout() to getReportHMTL() because we will not need to
1400 parse or render the report layout on the client side.
1401 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1402 getReportLayout(): Return the libglom LayoutGroup type because we will
1403 not need to convert to a shared type, because this will not be used on
1405 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1408 Note that there is still no implementation for this.
1411 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1413 Add a (empty) Report Place, View, and Activity.
1415 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1417 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1418 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1419 this into a superclass:
1420 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1421 and also use it as the base of this new ReportPlace:
1422 * src/main/java/org/glom/web/client/place/ReportPlace.java
1424 * src/main/java/org/glom/web/client/ui/ReportView.java
1425 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1426 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1427 Add these, containing mostly boiler-plate for now.
1429 * src/main/java/org/glom/web/client/OnlineGlomService.java
1430 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1431 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1432 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1433 Add API to get the LayoutGroup for the report.
1435 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1437 Add and fill a Reports drop-down list box.
1439 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1441 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1442 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1443 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1444 Added getReports(document, table, localeID), calling
1445 ConfiguredDocument.getReports().
1446 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1447 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1448 Added setReportsList() and a list widget.
1449 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1450 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1455 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1457 Translations: Add Esperanto.
1459 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1460 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1461 properties: Add this translation because someone took the time to make it.
1463 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1465 Adapt to the java-libglom 1.21.7 API.
1467 * src/main/java/org/glom/web/server/ReportGenerator.java:
1468 addToReport(): get_group_secondary_fields() is now
1469 get_secondary_fields().
1472 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1474 Use the latest java-libglom version.
1476 * pom.xml: Use java-libglom 1.21.7.
1478 2012-03-03 Ben Konrath <ben@bagu.org>
1480 Display date and time in details view.
1482 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1484 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1486 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1488 Require the latest java-libglom.
1490 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1492 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1494 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1496 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1497 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1498 an empty quickfind string. I also corrected libglom to create only
1499 empty where clauses for empty quickfind strings, but this avoids the
1502 2012-02-24 Ben Konrath <ben@bagu.org>
1504 Improve the tabs in the Notebook widget.
1508 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1510 Translations: Try to translate the strings.
1512 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1513 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1514 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1515 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1516 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1517 Take the Open translation from GTK+'s .po files.
1518 Take the Details translation from Glom's po files.
1519 I have added the other strings to Glom so we can get translations that way:
1520 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1522 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1524 TableSelectionViewImpl: Put the search label and entry in a div.
1526 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1527 Put the search widgets in a FlowTable so that the CSS can be used to
1528 style them while keeping them together.
1529 * src/main/webapp/style.css: Mention the new div.
1531 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1533 Translate more strings in more locales.
1535 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1536 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1537 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1538 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1539 Translate the "Details" and "Open" string too.
1541 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1542 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1543 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1544 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1545 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1546 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1547 Add these new locales as placeholders though they currently contain English.
1549 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1551 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1554 Check the ConfiguredDocument* for null before using it.
1556 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1558 Tell Eclipse about the generated java files.
1560 * .classpath: This lets it find OnlineGlomConstants.java.
1561 It would be nice if Eclipse just used the maven build files.
1563 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1565 Prevent a crash when no locale is specified in the URL.
1567 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1568 Avoid returning a null string, obtained from
1569 Window.Location.getParameter(). This caused a crash when it was
1570 later passed to libglom's API.
1571 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1572 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1573 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1574 guard against future null strings.
1576 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1578 Use the ?locale= query param instead of the &lang= token param.
1580 * src/main/java/org/glom/web/client/place/ListPlace.java
1581 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1582 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1583 Remove the lang token key and value.
1585 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1586 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1587 When the user selects a different locale from the chooser, use
1588 Window.Location.assign() to change the URL, which then causes a reload.
1590 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1591 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1592 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1593 * src/main/java/org/glom/web/client/activity/ListActivity.java
1594 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1595 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1596 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1597 * src/main/java/org/glom/web/client/ui/ListView.java:
1598 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1600 Remove localeID member variables and method/constructor parameters, instead
1601 using Utils.getCurrentLocaleID() when we need a localID to pass to
1604 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1606 Internationalize the UI strings.
1608 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1609 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1610 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1611 because it is unused. Messages are apparently strings that can have
1612 parameters, but we do not need that yet, so Contants will be enough for now.
1613 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1614 to say that we support the en and de locales.
1615 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1616 The original English strings.
1617 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1618 Some German translations of the English strings.
1619 The i18n goal then uses the .properties file to generate an
1620 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1621 returns an implementation that returns the translated strings.
1622 The documentation suggests putting these in src/java/*/client/, but it seems
1623 best to put it in src/resources/*/client/.
1624 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1625 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1626 instead of hard-coding them.
1627 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1628 but that does not seem to stop the build, though it confuses Eclipse.
1630 You can see the translated string by adding ?locale=de to the URL, like so:
1631 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1633 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1635 Improve null/empty String checks.
1637 * pom.xml: Add a dependency on commons-lang, to use
1638 org.apache.commons.lang.StringUtils.
1639 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1640 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1641 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1642 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1643 Use StringUtils.isEmpty().
1645 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1646 StringUtils class with a static isEmpty() function because we
1647 cannot use org.apache.commons.lang.StringUtils in client-side
1648 GWT code because it (apparently) cannot be compiled to javascript.
1649 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1650 * src/main/java/org/glom/web/client/activity/ListActivity.java
1651 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1652 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1653 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1654 * src/main/java/org/glom/web/client/place/ListPlace.java
1655 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1656 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1657 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1658 * src/main/java/org/glom/web/client/ui/details/Group.java
1659 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1660 our StringUtils.isEmpty() function.
1662 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1664 Update to the latest java-libglom API.
1666 * pom.xml: Require java-libglom 1.21.4.
1667 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1668 getDocumentInfo(), getListViewLayoutGroup():
1669 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1671 * src/main/java/org/glom/web/server/database/DBAccess.java
1672 getFieldsToShowForSQLQueryAddGroup(),
1673 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1674 with either get_database_title_original() or
1675 get_database_title(localeID).
1677 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1679 ConfiguredDocument: Avoid a null pointer exception.
1681 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1682 Initialize localeID to "" to avoid returning a null String which
1683 causes a crash in java-libglom's swing-generated code.
1685 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1687 Some simple renaming.
1689 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1690 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1691 for localeChooser. This seems more appropriate and is less ambiguous
1692 particularly in the .css file.
1694 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1696 ConfiguredDocument: Rename the localedID private member variable.
1698 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1700 Adapt to the latest java-libglom API from git master.
1702 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1703 libglom now uses only Vector instead of List, which uses add() instead of
1706 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1708 ConfiguredDocument: Rename the localedID private member variable.
1710 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1712 Build a source tarball with mvn assembly:single
1714 * assembly.xml: Add this file.
1715 * pom.xml: Use the maven-assembly-plugin and tell it to use
1716 our assembly.xml file.
1718 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1720 OnlineGlomServiceImpl: Get .glom files recursively.
1722 * pom.xml: Depend on commons-io from org.apache.commons.
1723 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1724 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1725 files recursively, and with the easier filter for the extension.
1726 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1727 simplify that code too.
1729 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1731 README: Mention that you must install java-libglom packages separately.
1733 But then it works, because java-libglom is now in the central maven
1736 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1738 locales drop-down: Show the correct selected locale when the URL changes.
1740 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1741 .java: setPlace(): Move some code into fillView().
1743 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1745 locales drop-down: Do not lose the primary key.
1747 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1748 start(): onLocaleChange(): Pass the current primary key value,
1749 instead of an empty value.
1751 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1753 locales drop-down: Do not lose the drop-down selection.
1755 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1756 .java (TableSelectionActivity.fillView): Set the selected locale
1757 after changing the drop-down items (though we do not really need
1758 to change them just because the locale changes.)
1760 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1762 locales drop-down: Change the tables list when this changes.
1764 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1765 .java: TableSelectionActivity.start(): Move the async table titles
1766 retrieval into a private fillView() method and also call this when
1767 the chosen locale changes.
1768 Note that the document title is not actually translatable yet, but
1769 that is a problem that I should fix soon in libglom.
1771 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1773 Improve the placement of the locales drop-down.
1775 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1776 Put the title and locales drop-down in a div (gwt.FlowTable).
1777 * src/main/webapp/style.css: Add magic css properties to make this work.
1778 Also remove the left margin from the title so that it lines up with the
1781 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1783 locales selector: Show human-readable locale titles.
1785 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1786 getDocumentInfo(): Use java.util.Locale to show a real title of
1787 each locale, in the locale's own language.
1789 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1791 Add a language/locale selector drop-down.
1793 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1794 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1795 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1796 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1797 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1798 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1799 Add a ListBox to show the available locales. Add getLocaleSelector(),
1800 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1801 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1802 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1803 java: Add these classes.
1804 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1805 start(): Fill the locales ListBox. Handle its change event, firing a
1807 setPlace(): Show the selected locale as specified by the URL token.
1808 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1809 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1810 Handle LocaleChangeEvent, going to a new *Place with that locale.
1812 The placement of the ListBox is not pretty, and it currently uses the ID
1813 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1817 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1819 Search box: Show the search text from the URL token.
1821 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1822 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1823 Add setQuickFindText().
1824 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1825 .java: setPlace(): Store the queryText if the place is a ListPlace,
1826 and call TableSelectionView.setQuickFindText().
1828 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1830 Allow use of translations via, for instance, &lang=de in the URL.
1832 * pom.xml: Use the unstable java-libglom 1.21 version.
1834 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1835 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1836 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1837 init(): Instead of calling TranslatableItem.set_current_locale()
1838 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1839 However, this is only for default locales, which are not needed to
1840 change the locale in the URL.
1841 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1842 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1843 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1844 layout for a particular locale.
1845 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1846 Add get/setDefaultLocaleID().
1847 getDocumentInfo(), getListViewData(), getRelatedListData(),
1848 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1849 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1850 localeID parameter, so we can get the layout for a particular locale.
1852 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1853 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1854 * src/main/java/org/glom/web/client/place/ListPlace.java:
1855 Parse and construct a lang parameter too.
1857 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1858 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1859 passed to subsequent methods and constructors.
1860 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1861 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1862 Store the localeID from the *Place and pass it to other constructors
1863 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1865 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1866 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1867 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1868 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1869 * src/main/java/org/glom/web/client/ui/ListView.java:
1870 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1871 Take localeID parameters and pass them to subsequent constructors and
1872 methods, so that the layout is always retrieved for that locale.
1874 This is rather repetitive.
1876 Note that "" means the original (default) locale of the Glom document,
1877 which is usually English.
1879 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1881 Documents: Remove final keyword to fix startup configuration.
1883 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1884 final keywords on the private member variables because that breaks
1885 the startup, apparently (there are warnings) because it stops them
1886 from being serialized. I added these in the previous commit.
1888 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1890 Documents: Add some final keywords.
1892 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1895 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1897 OnlineGlomServiceImpl: Add to overview comments.
1899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1900 Note that this is where all the document are loaded. They are not
1901 loaded freshly for each page.
1903 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1907 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1908 Add a TextBox for the text of a quick find.
1909 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1911 setBackLink(): Add a String quickFind parameter.
1912 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1913 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1914 to the base interface, because that is how TableSelectionViewImpl is used.
1915 * src/main/webapp/style.css: Add style for the search box and its label.
1917 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1918 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1919 Add these files, based on the existing TableChangeEvent and
1920 TableChangeEventHandlers.
1921 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1922 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1923 a ListPlace() that the user should be taken to.
1924 * src/main/java/org/glom/web/client/activity/ListActivity.java
1925 start(): Handle it here too and adapt the TableChangeEvent handler to
1926 pass the extra "" quickFind parameter to ListPlace.
1927 * src/main/java/org/glom/web/client/place/ListPlace.java:
1928 Constructor: Take an extra String quickFind parameter and store it,
1929 returning it from a new getQuickFind() method.
1930 getToken(): Put the quickFind text in the URL token.
1931 getPlace(): Parse the quickFind text from the URL token.
1932 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1933 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1934 ListPlace constructor.
1935 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1936 .java: start(): Add a Change handler for the TableSelectionView's
1937 TextBox (via its base HasChangeHandlers interface), firing the new
1938 QuickFindChangeEvent.
1939 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1940 pass the extra "" quickFind parameter.
1942 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1943 setCellTable(): Add a String quickFind parameter and pass it to
1944 the ListViewTable() constructor.
1945 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1946 setCellTable() in the base interface, because that is how ListViewImpl
1949 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1950 Add a String quickFind member variable.
1951 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1952 Constructor: Add a String quickFind parameter, storing it in the
1953 base ListTable's member variable.
1954 onRangeChanged(): Pass quickFind to the
1955 OnlineGlomServiceAsync.getSortedListViewData() and
1956 OnlineGlomServiceAsync.getListViewData() methods.
1958 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1959 getListViewData(), getSortedListViewData(): Add a String quickFind
1960 parameter, passing it to ConfiguredDocument.getListViewData().
1961 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1962 Change getListViewData(), getSortedListViewData() in the base interface,
1963 because that is how OnlineGlomServiceImpl is used, via this:
1964 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1965 Change getListViewData(), getSortedListViewData() here too.
1966 This class can apparently be used to asynchronously call methods on
1967 OnlineGlomService, and GWT seems to implement that after recognizing
1968 just the *Async name convention and the extra AsyncCallback parameters.
1970 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1971 getListViewData(): Add a String quickFind parameter, and pass it to
1972 ListViewDBAccess.getData().
1973 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1974 getListData(): Add a String quickFind parameter and pass it to
1976 getSelectQuery(): Add a String quickFind parameter.
1977 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1978 getSelectQuery(): Add a String quickFind parameter and use it with
1979 Glom.get_find_where_clause_quick() to pass a where_clause to
1980 Glom.build_sql_select_with_where_clause(), to actually filter the
1982 getData(): Add a String quickFind parameter, passing it to getListData().
1983 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1984 va: getData(): Pass an empty string to getListData() for the
1985 quickFind parameter.
1987 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1989 ListTable: Minor change.
1991 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1992 createCellTable(): Make this protected instead of public.
1994 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1996 Many files: Use final for the parameters and use the @override attribute.
1998 2012-01-22 Ben Konrath <ben@bagu.org>
2000 Add anchor links for single line text that starts with http, ftp and www.
2004 2012-01-22 Ben Konrath <ben@bagu.org>
2006 Add ellipsis to single line text in details view.
2010 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2012 Remove all javadoc author tags.
2014 Because they are awkward and meaningless when many people touch
2016 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2018 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2020 Revert the COPYING.LESSER to COPYING rename.
2022 Apparently both should be there if it is LGPL.
2024 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2026 *View: Remove unused imports.
2028 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2029 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2030 * src/main/java/org/glom/web/client/ui/ListView.java:
2031 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2032 Remove unused imports, as suggested by Eclipse.
2034 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2036 Move the *View::Presenter types, and some API into one base View.
2038 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2039 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2040 * src/main/java/org/glom/web/client/ui/ListView.java:
2041 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2042 Presenter, setPresenter() and clear() into a shared base interface,
2043 to avoid the unnecessary duplicate Presenter types and to more clearly
2044 show how the *Views share the same structure, even if they are not
2045 used polymorphically.
2047 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2048 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2050 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2051 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2052 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2054 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2057 Feel free to revert this if there is a good reason for the duplicate
2060 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2062 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2064 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2065 a class member instead of a local variable in the method.
2066 This lets us use it to get the view instances, for use in tests.
2067 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2068 beforeOnlineGlom(): Test some more details of the initial view.
2069 Again, this is not very useful.
2071 To really test gwt-glom we will need to start a local postgresql
2072 instance with local data, like the Glom tests in C++.
2074 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2076 pom.xml: Mention the LGPL license.
2078 * pom.xml: Add a licenses section.
2079 * COPYING.LESSER: Move this to COPYING, which
2080 previously contained the GPL. But gwt-glom is all LGPL.
2082 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2084 Add project information to README and pom.xml.
2086 * README: Add a brief description and mention some mvn
2088 * pom.xml: This extra information shows up in mvn site
2091 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2093 Use the latest java-libglom version.
2095 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2097 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2099 GwtTestOnlineGlom: Test a little more.
2101 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2102 protected rather than private, as suggested by the gwt-test-utils
2104 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2105 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2106 Test the initial visibility of the panels.
2108 However, this is not a very useful test.
2109 And I wonder how we should generally test using this idea for an
2110 activity/places app like ours where the real changes happen implicitly
2111 based on the history token/URL.
2113 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2115 Slight modification to *Mapper comments.
2117 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2118 (DataActivityMapper)
2119 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2121 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2123 Remove comments mentioning GIN because they are just copied from
2124 the example code and are apparently not helpful:
2125 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2126 Also change the mention of a class that is only in the example code.
2128 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2130 GwtTestOnlineGlom test: Minor changes.
2132 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2133 Avoid the long qualified class name and modify the comment
2134 because it is now obvious to me that the mocked class is the only
2135 custom one created via GWT.create().
2137 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2139 Tests: Added the beginnings of a test using gwt-test-utils.
2141 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2142 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2143 which tells gwt-test-utils what class will be tested.
2144 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2145 Add a simple (but empty) test case. One class, used by the OnlineGlom
2146 class, is mocked so that it can be created. However, I am not sure
2147 why only this class needs to be mocked.
2149 Note that mockito seems more popular, and clearer, than easymock,
2150 but I have not got that working yet. It might be a matter of the
2153 This test is run during mvn integration-test.
2155 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2157 Tests: Use junit4-style syntax instead of junit3-style.
2159 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2160 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2161 * src/test/java/org/glom/web/shared/DataItemTest.java:
2162 Use the @Test annotation rather than relying on the test*() prefix.
2163 Also no longer implement TestCase, to avoid triggering support for
2164 the junit3-way, which stops the annotations from working.
2165 Change the imports from import junit.framework.* to
2166 import org.junit.*, which is apparently the new way.
2168 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2170 Added a test for ListPlace token parsing and creation.
2172 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2173 This is much the same as DetailsPlaceTest.
2175 I wonder how we could test the other parts of the *Place API.
2177 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2179 DetailsPlace test: Also test getToken() and recreation via getPlace().
2181 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2182 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2183 recreate it, testing the recreated DetailsPlace for the same parameter
2186 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2188 Use the surefire-report plugin.
2190 * pom.xml: This generates a HTML report about the tests in
2191 target/site/surefire-report.html
2192 when you do mvn surefire-report:report. It seems to be popular/normal.
2194 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2196 Added a test for DetailsPlace.
2198 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2199 Test the getPlace() token parsing.
2201 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2203 Added a first unit test.
2205 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2206 * src/test/java/org/glom/web/shared/DataItemTest.java:
2207 This is a silly test but it is just to get things started. Note that
2208 maven/junit finds the test because it looks in src/test by default.
2210 2011-12-22 Ben Konrath <ben@bagu.org>
2212 Change charsetName to "UTF-8" when replacing line breaks.
2214 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2215 that work in Java (such as "UTF8") will not work when compiled to
2218 This fixes a problem with multi-line details view fields that have hard
2219 line breaks. The "License Text" field on this page demonstrates the
2222 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2224 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2226 2011-12-22 Ben Konrath <ben@bagu.org>
2228 Fix another bug with related list navigation.
2230 I've tested all the navigation buttons in all of the related lists
2231 so things should be good now.
2233 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2235 2011-12-22 Ben Konrath <ben@bagu.org>
2237 Fix a crasher when refreshing the list view with the default table.
2239 This crash will also happen when loading the list view with the default
2240 table from a link or bookmark.
2242 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2243 to the main document selection page when the document id hasn't been
2245 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2246 the main document selection page when the document id hasn't been
2248 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2249 values for the details place when the document id hasn't been set.
2250 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2251 values for the list place when the document id hasn't been set.
2253 2011-12-21 Ben Konrath <ben@bagu.org>
2255 Protect against NPE when glom.document.locale is not in config.
2257 This patch protects against an NPE when glom.document.locale is not in
2258 the config file. This NPE will also happen if glom.document.locale is
2261 The patch also updates the error message to display the class name when
2262 the getMessage() returns null. This was happening when the NPE was
2263 thrown and I had "Configuration Error: null". If an NPE is encountered
2264 with this patch, "Configuration Error: NullPointerException " will be
2267 This commit closes this bug:
2269 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2271 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2273 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2275 Rename onlineglom.properties to onlineglom.properties.sample.
2277 * src/main/resources/onlineglom.properties: Rename to:
2278 * src/main/resources/onlineglom.properties.sample:
2279 * src/main/resources/README: And add this file explaining that people
2280 should rename it back when deploying.
2282 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2284 Allow choosing the translation in the .properties file.
2286 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2287 init(): Read a glom.document.locale value from the configuration file
2288 and call Glom's TransatableItem::set_current_locale() method.
2289 * src/main/resources/onlineglom.properties: Add a commented-out
2290 example of this new setting.
2292 It would be better to add &lang=de_DE to the URL, but the current
2293 libglom API does not allow us to do this easily. I am working on that.
2295 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2297 Avoid a crash in parsing of token parameters.
2299 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2300 ava: getTokenParams(): Do not crash if a parameter has a key but no
2301 value, and ignore parameters with neither.
2303 2011-12-17 Murray Cumming <murrayc@murayc.com>
2305 History token building/handling: Improve use of token parameters.
2307 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2308 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2309 and buildParamsToken(HashMap), for use by derived classes.
2310 Make the separator private because it is no longer be needed.
2311 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2312 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2313 instead of manual string concatenation.
2314 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2315 of hardcoded indices and awkward splitting code.
2316 * src/main/java/org/glom/web/client/place/ListPlace.java
2317 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2318 instead of manual string concatenation.
2319 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2320 of hardcoded indices and awkward splitting code.
2321 This should fix bug #666420
2323 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2325 Fix a Navgiation->Navigation typo in the code.
2327 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2328 Rename processNavgiation() to processNavigation().
2330 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2332 Fix a seperator->separator typo in the code.
2334 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2335 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2336 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2339 2011-12-15 Ben Konrath <ben@bagu.org>
2341 Cleanup some comments.
2343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2345 2011-12-14 Ben Konrath <ben@bagu.org>
2347 Replace \n with <br/> for multiline text in the details view.
2349 Vertical scrollbars are added when needed as well.
2351 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2353 2011-12-14 Ben Konrath <ben@bagu.org>
2355 Specify the font for document selection links.
2357 * src/main/webapp/style.css:
2359 2011-12-14 Ben Konrath <ben@bagu.org>
2361 Fix bouncy CellTable while paging.
2363 This doesn't currently work with related list tables in unselected
2366 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2368 2011-12-14 Ben Konrath <ben@bagu.org>
2370 Revamp the appearance of the document selection page.
2372 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2373 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2374 * src/main/webapp/style.css:
2376 2011-12-13 Ben Konrath <ben@bagu.org>
2378 Set navigation button column to the smallest size possible.
2380 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2382 2011-12-13 Ben Konrath <ben@bagu.org>
2384 Change OpenButton nomenclature to NavigationButton.
2386 Using NavigtionButton makes things more generic. Classes, methods and
2387 variables have been changed.
2389 This is a rename-only refactor.
2391 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2392 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2393 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2394 Renamed from OpenButtonCell.
2395 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2396 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2397 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2399 2011-12-12 Ben Konrath <ben@bagu.org>
2401 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2403 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2404 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2405 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2406 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2408 2011-12-12 Ben Konrath <ben@bagu.org>
2410 Update variable names and comments.
2412 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2413 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2415 2011-12-12 Ben Konrath <ben@bagu.org>
2417 Properly initialize numNonEmptyRows variable to zero.
2419 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2420 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2422 2011-12-05 Ben Konrath <ben@bagu.org>
2424 Add latest mockup with HTML tables.
2426 Features of this mockup:
2428 -> HTML table for flowtable
2429 -> HTML table for flowtable column
2430 -> Example of how related lists would look
2431 -> Not using text entries for data items
2433 The current version of Online Glom doesn't use HTML tables for the
2436 This mockup has been sent to the glom-devel mailing list but it's good
2437 to have it here as well.
2439 * mockups/details-view-html-tables.html:
2441 2011-12-05 Ben Konrath <ben@bagu.org>
2443 Remove unnecessary getPrimaryKeyField() method.
2445 getPrimaryKeyFieldForTable(String) has been renamed to
2446 getPrimaryKeyField(String).
2448 * src/main/java/org/glom/web/server/database/DBAccess.java:
2449 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2450 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2452 2011-12-05 Ben Konrath <ben@bagu.org>
2454 Add string representation of TypedDataItem value to conversion error message.
2456 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2457 message was extracted into its own method to avoid duplication.
2459 2011-12-05 Ben Konrath <ben@bagu.org>
2461 Add type checking to navigation primary key value creation.
2463 Create navigation primary key only if the expected type from the Glom
2464 document matches the type returned by the SQL query.
2466 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2468 2011-12-05 Ben Konrath <ben@bagu.org>
2470 Rename a couple of variables in RelatedListNavigation.
2472 This is a rename-only refactor.
2474 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2476 2011-12-05 Ben Konrath <ben@bagu.org>
2478 Move getListLayoutGroup() into getListViewLayoutGroup().
2480 This removes getListLayoutGroup(). It was only being called by
2481 getListViewLayoutGroup().
2483 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2485 2011-12-05 Ben Konrath <ben@bagu.org>
2487 Remove check for LayoutItem_Portal in list table method.
2489 This check is no longer necessary because the method isn't being used
2490 to create the LayoutItemPortal DTO.
2492 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2494 2011-12-05 Ben Konrath <ben@bagu.org>
2496 Properly support related list navigation.
2498 Navigation from the "Repository Analyzer -> Package Scans ->
2499 Dependencies" related table wasn't working because the primary key for
2500 related tables wasn't being set properly. This commit fixes the
2503 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2504 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2505 doesn't set the primary key properly for related list tables.
2506 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2507 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2508 useful for getting the primary key for list view tables and for related
2510 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2511 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2512 Move code to set the primary key for the table from the abstract
2513 ListDBAccess class to ListViewDBAccess as it's only correct for list
2515 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2516 Properly add primary key to related list tables.
2518 2011-12-02 Ben Konrath <ben@bagu.org>
2520 Properly set the horizontal alignment of fields.
2522 This fix is for both the list tables and the details view.
2524 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2525 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2526 to set the horizontal alignment of fields.
2528 2011-12-02 Ben Konrath <ben@bagu.org>
2530 Display currency codes in the details view.
2532 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2534 2011-12-02 Ben Konrath <ben@bagu.org>
2536 Avoid duplicate JNI call.
2538 JNI is not as efficient as pure Java and this is an easy (and small)
2541 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2542 Use previously retrieved value for whereClauseToTableName instead of
2545 2011-12-02 Ben Konrath <ben@bagu.org>
2547 Rename a couple of variables in RelatedListNavigation.
2549 This is a rename-only refactor.
2551 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2553 2011-12-02 Ben Konrath <ben@bagu.org>
2555 Indicate clearly that a mismatched primary key type is a bug.
2557 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2558 warning to error. Add 'This is a bug.' to message.
2560 2011-12-02 Ben Konrath <ben@bagu.org>
2562 Update / fix some comments.
2564 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2566 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2568 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2569 Fix comments. Add some TODOs.
2571 2011-12-02 Ben Konrath <ben@bagu.org>
2573 Enable navigation to details view with string primary key from related list.
2575 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2576 Create a text primary key value when return type of result is
2577 java.sql.Types.VARCHAR.
2579 2011-12-02 Ben Konrath <ben@bagu.org>
2581 Use checkboxes for booleans in the details view.
2583 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2585 2011-12-01 Ben Konrath <ben@bagu.org>
2587 Improve performance of related list height calculation.
2589 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2590 Put code to calculate the expected height in a static initializer so
2591 that that it's only called once.
2593 2011-12-01 Ben Konrath <ben@bagu.org>
2595 Show related list tables in notebooks (again).
2597 Calculate the height of the related list tables so the Notebook can be
2598 set the correct height. The height of the related list table is also needed by
2599 FlowTable to be able decide how to create the layout.
2601 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2602 and set the Portal height based on the height of the related list
2603 table and the Portal container.
2604 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2605 Add method to calculate the height of the related list tables.
2606 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2607 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2608 calculate the height of the Pager widget.
2610 2011-12-01 Ben Konrath <ben@bagu.org>
2612 Use CellTable API for table property instead of setting style on Element.
2614 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2616 2011-12-01 Ben Konrath <ben@bagu.org>
2618 Make ListViewTable and RelatedListTable a consistent height.
2620 The tables are now a consistent height regardless of the contents of
2621 the table. A hidden button is added to empty rows to ensure that the
2622 height of these rows will match the height of rows with data.
2624 A navigation button column is now added to every table. The width of
2625 the navigation column is set to 0px when a RelatedListTable shouldn't
2626 have navigation buttons. This maintains the a consistent row height in
2627 tables that don't show the navigation buttons.
2629 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2630 navigation column when not needed.
2631 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2632 arguments for navigation button to constructor of ListViewTable.
2633 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2634 hidden button for empty data rows.
2635 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2636 arguments for navigation button to constructor.
2637 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2638 create navigation buttons. Add hideNavigationButtons() method.
2639 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2640 arguments for navigation button to constructor.
2642 2011-12-01 Ben Konrath <ben@bagu.org>
2644 Use 'visibility: hidden' in Utils.getWidgetHeight().
2646 This is better choice because hidden elements are invisible, don't
2647 respond to events and are not part of the tab order. They will,