3 2012-05-15 Murray Cumming <murrayc@murrayc.com>
5 Corrections to navigation to related records.
7 * src/main/java/org/glom/web/client/OnlineGlomService.java:
8 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
9 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
10 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
11 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
12 relationship name, because the relationship name is not necessarily unique
14 TOOD: This is inefficient, because it passes the whole list of
15 child field items back to the server, but it is more correct, and happens
16 to fix a bug with the primary key being lost after a few navigations.
17 There is probably a chance to make this more efficient anyway in some
20 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
21 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
22 * src/main/java/org/glom/web/server/ConfiguredDocument.java
23 * src/main/java/org/glom/web/server/database/DBAccess.java
24 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
25 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
28 2012-05-15 Murray Cumming <murrayc@murrayc.com>
30 Fix the use of translations.
32 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
33 Add updateTitlesForLocale().
34 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
35 Call it to discard unwanted translations and to make getTitle() return
36 the wanted translation wihout the need for the client code to specify a locale.
37 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
38 getTitle(): Fallback to the original title, as libglom does.
40 2012-05-15 Murray Cumming <murrayc@murrayc.com>
42 Document: Correctly report the number of available translation locales.
44 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
45 the available locale IDs list.
46 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
47 testLocales: Test this.
49 2012-05-15 Murray Cumming <murrayc@murrayc.com>
51 SqlUtils: Use camelCase.
53 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
54 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
55 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
56 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
57 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
58 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
60 2012-05-15 Murray Cumming <murrayc@murrayc.com>
62 Use jOOQ's tableByName() and fieldByName.
64 * pom.xml: Use jOOQ 2.3.1 to get the new API.
65 * src/main/java/org/glom/web/server/SqlUtils.java:
66 build_sql_select_step_with_where_clause(), .createField(),
67 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
68 so we can get correct quoting and escaping. Thanks to Lukas Eder for
69 adding this, and other things, to jOOQ.
71 2012-05-15 Murray Cumming <murrayc@murrayc.com>
73 SqlUtils: Remove the Connection parameters.
75 * src/main/java/org/glom/web/server/SqlUtils.java:
76 build_sql_select_with_key(), build_sql_select_with_where_clause(),
77 createSelect(), build_sql_select_step_with_where_clause(),
78 build_sql_count_select_with_where_clause(),
79 build_sql_select_count_rows(): Remove the Connection parameter because
80 jOOQ does not actually need a connectionwhen it is just used to build
82 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
84 * src/main/java/org/glom/web/server/ReportGenerator.java:
86 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
88 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
89 Constructor, getListData(), getResultSizeOfSQLQuery():
90 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
91 getSelectQuery(), getCountQuery():
92 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
93 getSelectQuery(), getCountQuery():
94 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
95 getNavigationRecord(): Adapted.
97 2012-05-14 Murray Cumming <murrayc@murrayc.com>
101 * src/main/java/org/glom/web/server/SqlUtils.java:
102 get_find_where_clause_quick(): Use a comparison of
103 lowercase values, instead of a simple equals. Regular Glom
104 uses the PostgreSQL ILIKE operator but jOOQ does not
105 support that just yet, though it will soon.
107 2012-05-14 Murray Cumming <murrayc@murrayc.com>
109 TableToViewDetails: Use a real serialization ID.
111 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
112 Though this does not fix the serialization problem.
114 2012-05-12 Murray Cumming <murrayc@murrayc.com>
116 Added LayoutItemPortalDeepCloneTest.
118 2012-05-11 Murray Cumming <murrayc@murrayc.com>
120 Make navigation work again.
122 * src/main/java/org/glom/web/server/libglom/Document.java:
123 Add getLayoutItemFieldShouldHaveNavigation().
124 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
125 Replace get/setAddNavigation() with the partly-existing
126 get/setNavigationTableName(), with an empty string being no navigation,
127 because this is simpler. Use the new
128 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
130 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
131 Add updateFieldsExtras() and call setNavigationTableName in it.
132 getDetailsLayoutGroup(),
133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
134 createLayout(): Adapted.
135 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
136 Constructor: Adapted.
138 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
139 Replace get/setAddNavigation() with get/setNavigation(), returning a
140 TableToViewDetails class with both the table name and UsesRelationship,
141 because both are need. The previous code used java-libglom's output
142 variable (strangely, via sharedptr) to return both, but we cannot really
144 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
145 getNavigationRecord(): Adapt. However, we cannot actually use the cache
146 here because it somehow gets set to null during deepCopy(). I must test this.
147 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
148 testGetSuitableTableToViewDetails(): Adapted.
150 TODO: Find out why deepClone() is not quite working.
152 2012-05-11 Murray Cumming <murrayc@murrayc.com>
154 DBAccess: Simplify the retrievel of full field details.
156 * src/main/java/org/glom/web/server/database/DBAccess.java
157 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
158 because the Document loading should have done this.
160 2012-05-11 Murray Cumming <murrayc@murrayc.com>
162 Document: Correct loading of doubly-related layout fields.
164 * src/main/java/org/glom/web/server/libglom/Document.java:
165 loadUsesRelationship(): Actually set the related relationship, instead
166 of only setting it if it's not found.
168 2012-05-09 Murray Cumming <murrayc@murrayc.com>
170 Replace all appearances of Colour with color.
172 Because US English is dominant.
174 2012-05-09 Murray Cumming <murrayc@murrayc.com>
176 Use colors in HTML format, solving a warning about an unused function.
178 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
179 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
180 Add *asHTMLColor() versions of methods.
181 TODO: However, we should create and cache the results on the server.
182 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
183 * src/main/java/org/glom/web/client/ui/list/ListTable.java
184 * src/main/java/org/glom/web/server/ConfiguredDocument.java
185 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
186 Use the asHTMLcolor() versions.
188 2012-05-09 Murray Cumming <murrayc@murrayc.com>
190 ListViewTable: Constructor: Take the table name as a parameter.
192 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
193 Constructor: Take the tableName, and set the member variable, because
195 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
196 setCellTable(): Pass the table name.
197 This makes navigation to non-default tables work again. I don't know
198 why it worked before in the master branch.
200 2012-05-07 Murray Cumming <murrayc@murrayc.com>
202 ConfiguredDocument: Restore correct addition of hidden primary key items.
204 * src/main/java/org/glom/web/client/ui/list/ListTable.java
205 (ListTable.createCellTable): Uncomment out the check for the hidden
207 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
208 add primary key items for top-level lists and portals, as before,
209 instead of adding them to each group.
210 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
211 Actually implement the extra methods such as setHiddenPrimaryKey() and
212 comment that these are used only for top-level list groups and in portals.
213 This strangeness suggests even more that this should not be squeezed
214 into the LayoutGroup class.
216 2012-05-07 Murray Cumming <murrayc@murrayc.com>
218 Fix Formatting loading.
220 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
221 getFormattingUsed(): Remove the duplicate Formatting member variable
222 in favour of the one from the base class.
223 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
224 Initialize a new Formatting instead of using null by default, so we
225 have some defaults, instead of having to initialize one later just to
226 get the same defaults. This also makes loading of formatting from the
227 document work, because that expected a non-null.
229 2012-05-07 Murray Cumming <murrayc@murrayc.com>
231 RelatedListTable: Make sure that the tableName is set.
233 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
234 Constructor: Take the tableName so it is available later. Otherwise,
235 the server assumes that we mean the default table and cannot find the
237 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
238 setData(): Pass the tableName to the RelatedListTable constructor.
240 2012-05-07 Murray Cumming <murrayc@murrayc.com>
244 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
245 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
246 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
248 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
250 * src/main/java/org/glom/web/server/database/DBAccess.java:
251 convertResultSetToDTO(), getPortal():
252 * src/main/java/org/glom/web/server/database/ListDBAccess.java
254 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
255 Add checks for null objects and out of range access, with log messages to
256 give hints so we can fix these properly.
258 2012-05-07 Murray Cumming <murrayc@murrayc.com>
260 Portals: some corrections.
262 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
264 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
265 constructor: Use getRelationshipNameUsed() instead of getName(), because
266 that is what is meant.
267 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
268 getFromField(): Fix a typo, to get the field name, not the table name.
269 * src/main/java/org/glom/web/server/database/DBAccess.java:
270 getPortal(): Fix a typo that stopped this from working.
272 2012-05-07 Murray Cumming <murrayc@murrayc.com>
274 LayoutItemPortal: Also override getTitleOriginal().
276 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
277 This lets the base getTitle() with no parameters work.
278 TODO: Test this properly.
280 2012-05-06 Murray Cumming <murrayc@murrayc.com>
282 LayoutItemPortal: getTitle*(): Use the relationship title.
284 2012-05-06 Murray Cumming <murrayc@murrayc.com>
286 LayoutItemField: Fix loading of custom titles.
288 * src/main/java/org/glom/web/server/libglom/Document.java
289 loadDataLayoutItemField(): The title, if any, instead of the field
290 title, is stored in a title_custom node. Load it from there.
291 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
293 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
294 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
295 getTitle*() overrides.
296 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
299 2012-05-06 Murray Cumming <murrayc@murrayc.com>
301 LayoutItemField: Fall back to field titles, so some are really shown.
303 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
304 Override getTitleOriginal() and getTitle(), as in java-libglom.
305 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
308 2012-05-06 Murray Cumming <murrayc@murrayc.com>
310 Correct use of setExpectedResultSize().
312 * src/main/java/org/glom/web/server/ConfiguredDocument.java
313 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
314 Use setExpectedResultSize only on top-level groups (for instance, the
315 list layout) or on child portals (in details views).
316 Use the correct table name for portals to avoid SQL errors.
317 Update the expected counts when returning cached layouts.
319 2012-05-06 Murray Cumming <murrayc@murrayc.com>
321 Document: Interpret no group column count as 1.
323 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
324 default, though we now check for this in the UI code anyway.
326 2012-05-06 Murray Cumming <murrayc@murrayc.com>
330 2012-05-06 Murray Cumming <murrayc@murrayc.com>
332 Translatable: Use Hashmap instead of Treemap because GWT supports it.
334 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
335 The use of Treemap lead to this error from async methods, with no
337 "The response could not be deserialized"
339 2012-05-06 Murray Cumming <murrayc@murrayc.com>
341 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
343 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
344 when using the Google -> GWT Compile, or
345 g toolbar button -> GWT Compile Project... feature in Eclipse.
347 2012-05-06 Murray Cumming <murrayc@murrayc.com>
349 ListTable.addColumn(): Protect against a null Formatting.
351 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
352 Create a default Formatting if it is null, because that is the simplest
355 2012-05-06 Murray Cumming <murrayc@murrayc.com>
357 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
359 * src/main/java/org/glom/web/server/ConfiguredDocument.java
360 updateLayoutGroup(): Check that the field is not null.
362 2012-05-06 Murray Cumming <murrayc@murrayc.com>
364 ListViewImpl: Protected against a bad cast error.
366 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
367 onEnterKeyDown(): Do not cast without an instanceof check.
369 2012-05-06 Murray Cumming <murrayc@murrayc.com>
371 ListTable: Protect against an out of range error.
373 * src/main/java/org/glom/web/client/ui/list/ListTable.java
374 createCellTable(): This is unlikely, but can happen while debugging.
376 2012-05-06 Murray Cumming <murrayc@murrayc.com>
378 AsyncMessage onFailure() callbacks: Log the exception message.
380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
381 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
382 * src/main/java/org/glom/web/client/activity/ListActivity.java:
383 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
384 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
385 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
386 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
387 These are useful clues when something is wrong.
389 2012-05-06 Murray Cumming <murrayc@murrayc.com>
391 ConfiguredDocument: Avoid a null dereference.
393 * src/main/java/org/glom/web/server/ConfiguredDocument.java
394 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
395 details maps are created.
397 2012-05-06 Murray Cumming <murrayc@murrayc.com>
399 Document: Correct the port number parsing.
401 * src/main/java/org/glom/web/server/libglom/Document.java:
402 This lets us actually connect to the database and show the document.
404 2012-05-05 Murray Cumming <murrayc@murrayc.com>
408 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
409 user-interaction, asking us to load a temporary URL in a browser.s
410 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
411 which is apparently necessary for testing the service. See the comment.
412 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
413 Show the exception, if any. This is how I saw the 404 in the HTML in
416 2012-05-05 Murray Cumming <murrayc@murrayc.com>
418 DocumentTest: Move the .glom files into the resources directory.
420 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
421 URI via getResource().
423 2012-05-05 Murray Cumming <murrayc@murrayc.com>
425 Document: Remove the FieldIdentifies inner class.
427 * src/main/java/org/glom/web/server/libglom/Document.java: We only
428 use the Relationship (though the same function in libglom is maybe
429 used in other ways) and so this removes a compiler warning.
431 2012-05-05 Murray Cumming <murrayc@murrayc.com>
433 Document.load() Remove the error code parameter.
435 * src/main/java/org/glom/web/server/libglom/Document.java: load():
436 Remove the parameter. We do not set it yet and it could never have
437 worked as an output parameter (though maybe it did in java-libglom).
438 We could use an exception if we really want the failure reason.
439 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
441 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
442 setUp(), testGetSuitableTableToViewDetails(): Adapt.
444 2012-05-05 Murray Cumming <murrayc@murrayc.com>
446 Make some inner classes static.
448 * src/main/java/org/glom/web/server/ConfiguredDocument.java
449 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
450 * src/main/java/org/glom/web/server/ReportGenerator.java
451 * src/main/java/org/glom/web/server/libglom/Document.java
452 Make all inner classes static that can be static.
454 2012-05-05 Murray Cumming <murrayc@murrayc.com>
456 OnlineGlomServiceImpl: Do not load and check for java-libglom.
458 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
459 init(): We do not use java-libglom any more.
461 2012-05-05 Murray Cumming <murrayc@murrayc.com>
463 Remove mentions of java-libglom.
465 * README: Remove mention of java-libglom, because it no longer needed.
466 * utils/build-onlineglom-war.sh:
467 * utils/check-and-recover-tomcat.py:
468 * utils/install-onlineglom-war.sh: Remove these as they are no longer
469 useful. Building is now far easier, with no need for jhbuild.
471 2012-05-05 Murray Cumming <murrayc@murrayc.com>
473 Fix the build (mvn package)
475 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
476 (LayoutGroup): Make the LayoutItemList inner class static and protected.
477 Otherwise the GWT Java->Javascript compilation fails with just this
478 error, during mvn package or when attempting to view in a browser,
479 in the GWT developer mode in Eclipse.
481 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
482 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
483 [INFO] Compiling module org.glom.web.OnlineGlom
484 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
485 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
486 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
487 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
488 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
489 [INFO] [ERROR] Cannot proceed due to previous errors
491 It has taken me 2 days to find out what was causing that. After reducing
492 the code, the compiler eventually showed me the full error message.
494 2012-05-04 Murray Cumming <murrayc@murrayc.com>
496 ConfiguredDocument: Cache the cloned and stripped layouts.
498 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
499 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
500 layout in a map, so we can retrieve it again without rebuilding it.
502 2012-05-04 Murray Cumming <murrayc@murrayc.com>
504 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
506 2012-05-04 Murray Cumming <murrayc@murrayc.com>
508 libglom classes: Implement some auto-generated emthods.
510 2012-05-04 Murray Cumming <murrayc@murrayc.com>
512 Add GwtTestOnlineGlomService.
514 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
515 However, this (and the other GwtTest*) does not seem to run during
518 2012-05-04 Murray Cumming <murrayc@murrayc.com>
520 Remove use of unsupported features from client code.
522 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
523 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
524 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
525 Use our client version of StringUtils instead of the apache commons one.
527 However, the GWT Javascript compliation still fails.
529 2012-04-25 Murray Cumming <murrayc@murrayc.com>
531 Add a Field class and implement some loading of it in Document.
533 2012-04-25 Murray Cumming <murrayc@murrayc.com>
535 Initial Document loading implementation, instead of libglom.
537 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
538 and Translatable classes, and adapt the rest of the code to use them.
539 However, this is still missing Layout and Field classes and loading.
541 2012-04-24 Murray Cumming <murrayc@murrayc.com>
543 Use of jOOQ: Move Field creation into a utility method.
545 * src/main/java/org/glom/web/server/SqlUtils.java:
546 This lets us improve it more easily.
548 2012-04-24 Murray Cumming <murrayc@murrayc.com>
550 Use of jOOQ: Improve the code to COUNT a sub-select.
552 * src/main/java/org/glom/web/server/SqlUtils.java:
553 Move initial query creation into
554 build_sql_select_step_with_where_clause().
555 build_sql_select_count_rows(): Use the jOOQ API instead of
556 concatentating text, because a jOOQ Select*Step is a TableLike,
557 which is what from() takes.
559 2012-04-23 Murray Cumming <murrayc@murrayc.com>
561 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
563 * pom.xml: Depend on jooq.
564 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
565 methods with jOOQ, based on the C++ implementations in libglom,
566 with some changes to the logic required by jooQ.
567 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
569 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
570 * src/main/java/org/glom/web/server/ReportGenerator.java:
571 * src/main/java/org/glom/web/server/SqlUtils.java:
572 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
573 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
574 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
575 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
576 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
577 Adapt. In particular, the SqlUtils methods now need to take a Connection,
578 because jOOQ needs that, though it seems unnecessary.
580 This is not quite finished. Ideally jOOQ would help us to build
581 table_name.field_name names, quoting and escaping them properly.
582 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
584 2012-04-21 Murray Cumming <murrayc@murrayc.com>
586 Move use of Glom.build_sql*() into a new SqlUtils class.
588 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
589 to wrap Glom.build_sql*(). The parameter types are still Glom one,
590 but this will make it easier to start using something other than
591 libglom or SqlBuilder.
593 2012-04-21 Murray Cumming <murrayc@murrayc.com>
595 Update the project URL.
597 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
599 2012-04-21 Murray Cumming <murrayc@murrayc.com>
601 Main layout: Use a FlowTable instead of absolute positioning.
603 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
604 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
605 child panels/widgets must have an absolute position. But that is annoying, so
606 this adds a FlowTable and puts the child panels in there.
608 2012-04-21 Murray Cumming <murrayc@murrayc.com>
610 GwtTestOnlineGlom: Comment out unused code.
612 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
613 Eclipse has started to say that some code is unused.
615 2012-04-21 Murray Cumming <murrayc@murrayc.com>
617 Update to the latest versions of dependencies.
619 * pom.xml: Update version numbers of dependencies to the latest
621 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
622 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
623 * src/main/java/org/glom/web/server/ReportGenerator.java:
624 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
625 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
626 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
628 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
629 Modify the imports where necessary.
631 2012-04-17 Murray Cumming <murrayc@murrayc.com>
633 Style: Remove overflow:hidden from searchbox
635 * src/main/webapp/style.css: Because this pushes the Back To Link
636 label/link on to the next row, which is then hidden due to the
637 hard-coded (in ems) height.
639 2012-04-20 Murray Cumming <murrayc@murrayc.com>
641 Remove some duplicate code.
643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
644 getDocumentInfo(): This must have been duplicated during the merge from the
649 2012-04-19 Murray Cumming <murrayc@murrayc.com>
651 Reports: Localize the waiting for report message.
653 * src/main/java/org/glom/web/client/activity/ReportActivity.java
654 start(): Get the message from the contants.
655 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
657 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
658 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
659 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
660 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
661 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
662 Update these files with the English text for newer strings for now.
664 2012-04-19 Murray Cumming <murrayc@murrayc.com>
666 Reports: Show a message while waiting for the report.
668 * src/main/java/org/glom/web/client/ui/ReportView.java
669 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
670 Add setWaitingText(), to show a message saying that we are
671 waiting for the report to be ready.
672 * src/main/java/org/glom/web/client/activity/ReportActivity.java
673 start(): Call setWaitingText() before calling the async
676 2012-04-19 Murray Cumming <murrayc@murrayc.com>
678 ReportGenerator: Specify date and time formats.
680 * src/main/java/org/glom/web/server/ReportGenerator.java:
681 createFieldValueElement(): Use the default (and localized)
682 short formats, though we still need a way to show 4-digit
683 years without providing the format for every locale.
684 * src/main/java/org/glom/web/server/database/DBAccess.java:
685 convertResultSetToDTO(): Use the short formats here too.
687 2012-04-18 Murray Cumming <murrayc@murrayc.com>
689 ReportGenerator: Use the correct numeric formatting.
691 * src/main/java/org/glom/web/server/ReportGenerator.java
692 createFieldExpression(), createFieldValueElement(): Take the
693 whole LayoutItem_Field instead of just the field name, so
694 we have access to the formatting.
695 createFieldValueElement(): Use JRTextField.setPattern() to
696 specify the numeric formatting, with the help of a
697 regular DecimalFormat.
699 2012-04-18 Murray Cumming <murrayc@murrayc.com>
701 ReportGenerator: Avoid showing null for group by titles.
703 * src/main/java/org/glom/web/server/ReportGenerator.java
704 generateReport(): Use setBlankWhenNull() on the field title
705 style too, because this is used for values in group by
708 2012-04-18 Murray Cumming <murrayc@murrayc.com>
710 ReportGenerator: Add a colon to titles in vertical groups.
712 * src/main/java/org/glom/web/server/ReportGenerator.java
713 addFieldToDetailBandVertical(): Pass true for the withColon
716 2012-04-18 Murray Cumming <murrayc@murrayc.com>
718 ReportGenerator: Simplify the code by using Position more.
720 2012-04-18 Murray Cumming <murrayc@murrayc.com>
722 Reports: Support vertical groups, roughly.
724 * src/main/java/org/glom/web/server/ReportGenerator.java:
725 addToReport(): Rename to addGroupToReport() and, if necessary,
726 call the new addVerticalGroupToReport() method.
727 createFieldValueElement(): Let the caller specify the Y position
730 2012-04-17 Murray Cumming <murrayc@murrayc.com>
732 Reports: Allow a second report to be shown.
734 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
735 clear(): Do not remove the HTML widget, which broke the whole layout.
737 2012-04-17 Murray Cumming <murrayc@murrayc.com>
739 Locales drop-down: Show that we use English by default.
741 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
742 fillView(): When we use English, just because that is the default, when
743 no locale is specified, show that in the Locales drop-down instead of
744 just showing the first item.
746 2012-04-17 Murray Cumming <murrayc@murrayc.com>
748 Unselect the Report/Locale/Table combo item when appropriate.
750 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
751 setPlace(): clear reportName if this is not a ReportPlace.
752 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
753 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
754 When the provided name is empty, unselect all items, so that none are
755 indicated. This uses a for loop because I cannot find a single method
758 2012-04-17 Murray Cumming <murrayc@murrayc.com>
760 Report: Give the user a way to get back to the list.
762 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
763 start(), setPlace(): Show the Back To List link on reports, and also
764 interpret selecting the empty report item as back to list.
766 2012-04-13 Murray Cumming <murrayc@murrayc.com>
768 Really show the selected Report name.
770 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
771 setPlace(): Store the reportName here, if it is that kind of Place.
772 fillView(): Set the selected Report after filling the list of reports.
773 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
774 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
775 null Strings, though we need some way to unselect all ListBox items
778 2012-04-13 Murray Cumming <murrayc@murrayc.com>
780 ReportGenerator: Try to avoid some problems.
782 * src/main/java/org/glom/web/server/ReportGenerator.java
783 addField(): Try to avoid duplicates, and avoid using a null
786 2012-04-13 Murray Cumming <murrayc@murrayc.com>
788 Reports: Use quickFind.
790 * src/main/java/org/glom/web/client/OnlineGlomService.java;
791 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
792 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
793 getReportHTML(): Add a quickFind parameter.
794 * src/main/java/org/glom/web/client/activity/ReportActivity.java
795 start(): Pass the quickFind parameter.
796 * src/main/java/org/glom/web/server/ReportGenerator.java
797 generateReport(): Take a quickFind parameter.
799 2012-04-13 Murray Cumming <murrayc@murrayc.com>
801 ReportPlace: Actually use the report name.
803 * src/main/java/org/glom/web/client/place/ReportPlace.java
804 getPlace(): Do not assign the report name to the quickfind.
806 2012-04-13 Murray Cumming <murrayc@murrayc.com>
808 Show java.library.path when complaining.
810 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
811 init(): When telling us to check java.library.path, show the
814 2012-03-06 Murray Cumming <murrayc@murrayc.com>
816 ReportGenerator: Do not show nulls.
818 2012-03-06 Murray Cumming <murrayc@murrayc.com>
820 ReportGenerator: Make the title font larger.
822 2012-03-06 Murray Cumming <murrayc@murrayc.com>
824 ReportGenerator: Put field titles inside groups, if there are groups.
826 2012-03-06 Murray Cumming <murrayc@murrayc.com>
828 ReportGenerator: Take the Report itself instead of the name and group.
830 * src/main/java/org/glom/web/server/ConfiguredDocument.java
831 Remove getReportLayoutGroup().
832 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
833 getReportHTML(): Pass the report instead
834 of its name and layout group.
835 * src/main/java/org/glom/web/server/ReportGenerator.java
836 generateReport(): Use the report object to use the title
839 2012-03-06 Murray Cumming <murrayc@murrayc.com>
841 ReportGenerator: Remove designBand parameters.
843 * src/main/java/org/glom/web/server/ReportGenerator.java:
844 Make designBand a class member instead of passing it to all
847 2012-03-06 Murray Cumming <murrayc@murrayc.com>
849 ReportGenerator: Add lines, a bit like in the desktop version.
851 * src/main/java/org/glom/web/server/ReportGenerator.java
852 addToReport(): Use JRDesignLine.
854 2012-03-06 Murray Cumming <murrayc@murrayc.com>
856 ReportGenerator: Correct the title positions and use some bold style.
858 * src/main/java/org/glom/web/server/ReportGenerator.java:
859 Break the code up into reusable functions, correct the placement of
860 titles, and use normal/bold styles as in the reports in the desktop
863 2012-03-06 Murray Cumming <murrayc@murrayc.com>
865 ReportGenerator: Add a header band to show the field titles.
867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
868 getReportHTML(): Pass the localeId to the ReportGenerator
870 * src/main/java/org/glom/web/server/ReportGenerator.java
871 constructor: Take the localeID so we can get translated field
873 generateReport(), addToReport(), addFieldToBand(): Add field
874 titles in a column header band.
876 2012-03-05 Murray Cumming <murrayc@murrayc.com>
878 Reports drop-down list: Some improvement.
880 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
881 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
882 Adedd setSelectedReport(),
883 setReportList(): Add a blank line so that the user can select the
885 * src/main/java/org/glom/web/client/activity/ReportActivity.java
886 start(): Show the current report by calling setSelectedReport().
887 This does not seem to work yet.
889 2012-03-05 Murray Cumming <murrayc@murrayc.com>
891 DetailsActivity, ListActivity: Move some variables into a base class.
893 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
894 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
895 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
896 the clientFactory, documentID, tableName and authenticationPopup into
897 a base class, to avoid duplication.
899 2012-03-05 Murray Cumming <murrayc@murrayc.com>
901 Translate the Reports label.
903 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
904 Get the "Reports" label string from the constants.
905 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
906 perties: Add Reports to the constants.
908 2012-03-05 Murray Cumming <murrayc@murrayc.com>
910 Reports: Implement grouping.
912 * src/main/java/org/glom/web/server/ReportGenerator.java:
913 Handle LayoutItem_GroupBy items and try to do the right thing
914 with JRDesignGroup. It seems to work.
916 2012-03-04 Murray Cumming <murrayc@murrayc.com>
918 Actually show some data with JasperReports.
920 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
921 getReportHTML(): Move most code into a ReportGenerator class.
922 * src/main/java/org/glom/web/server/ReportGenerator.java:
923 Recurse into sub-groups, adding fields to the JasperDesign's details
924 band. Note that we must set an arbitrary width and height, or it just
925 will not show any data.
927 2012-03-04 Murray Cumming <murrayc@murrayc.com>
929 Reports Chooser: Show the titles, not the names.
931 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
932 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
933 and the names as the values.
934 * src/main/java/org/glom/web/server/ConfiguredDocument.java
935 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
936 group now that we provide the report name, so it should always
939 2012-02-15 Murray Cumming <murrayc@murrayc.com>
941 Depend on jasperreports.
943 * pom.xml: Add the dependency. My plan is to use this on the
946 2012-01-31 Murray Cumming <murrayc@murrayc.com>
948 Implement navigation to report places.
950 * src/main/java/org/glom/web/client/activity/ReportActivity.java
951 start(): Do not bother to handle all events here.
952 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
953 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
954 Added getSelectedReport().
955 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
956 .java: start(): When handling a change to the reports chooser,
957 call getSelectedReport() and goTo() its ReportPlace.
958 * src/main/java/org/glom/web/client/ui/ReportView.java
959 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
960 Added setReportHTML() which puts the html in a gwt HTML widget.
961 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
962 getReportHTML(): Return "TODO" just to show that this works.
964 2012-01-31 Murray Cumming <murrayc@murrayc.com>
966 Make ReportPlace usable.
968 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
970 * src/main/java/org/glom/web/client/place/ReportPlace.java:
971 Correct the @prefix annotation.
973 2012-01-31 Murray Cumming <murrayc@murrayc.com>
975 OnlineGlomService: Return report HTML rather than the LayoutGroup.
977 * src/main/java/org/glom/web/client/OnlineGlomService.java:
978 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
979 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
980 Change getReportLayout() to getReportHMTL() because we will not need to
981 parse or render the report layout on the client side.
982 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
983 getReportLayout(): Return the libglom LayoutGroup type because we will
984 not need to convert to a shared type, because this will not be used on
986 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
989 Note that there is still no implementation for this.
992 2012-01-27 Murray Cumming <murrayc@murrayc.com>
994 Add a (empty) Report Place, View, and Activity.
996 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
998 * src/main/java/org/glom/web/client/place/HasTablePlace.java
999 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1000 this into a superclass:
1001 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1002 and also use it as the base of this new ReportPlace:
1003 * src/main/java/org/glom/web/client/place/ReportPlace.java
1005 * src/main/java/org/glom/web/client/ui/ReportView.java
1006 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1007 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1008 Add these, containing mostly boiler-plate for now.
1010 * src/main/java/org/glom/web/client/OnlineGlomService.java
1011 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1012 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1013 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1014 Add API to get the LayoutGroup for the report.
1016 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1018 Add and fill a Reports drop-down list box.
1020 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1022 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1023 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1024 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1025 Added getReports(document, table, localeID), calling
1026 ConfiguredDocument.getReports().
1027 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1028 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1029 Added setReportsList() and a list widget.
1030 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1031 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1036 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1038 Translations: Add Esperanto.
1040 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1041 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1042 properties: Add this translation because someone took the time to make it.
1044 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1046 Adapt to the java-libglom 1.21.7 API.
1048 * src/main/java/org/glom/web/server/ReportGenerator.java:
1049 addToReport(): get_group_secondary_fields() is now
1050 get_secondary_fields().
1053 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1055 Use the latest java-libglom version.
1057 * pom.xml: Use java-libglom 1.21.7.
1059 2012-03-03 Ben Konrath <ben@bagu.org>
1061 Display date and time in details view.
1063 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1065 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1067 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1069 Require the latest java-libglom.
1071 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1073 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1075 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1077 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1078 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1079 an empty quickfind string. I also corrected libglom to create only
1080 empty where clauses for empty quickfind strings, but this avoids the
1083 2012-02-24 Ben Konrath <ben@bagu.org>
1085 Improve the tabs in the Notebook widget.
1089 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1091 Translations: Try to translate the strings.
1093 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1094 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1095 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1096 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1097 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1098 Take the Open translation from GTK+'s .po files.
1099 Take the Details translation from Glom's po files.
1100 I have added the other strings to Glom so we can get translations that way:
1101 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1103 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1105 TableSelectionViewImpl: Put the search label and entry in a div.
1107 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1108 Put the search widgets in a FlowTable so that the CSS can be used to
1109 style them while keeping them together.
1110 * src/main/webapp/style.css: Mention the new div.
1112 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1114 Translate more strings in more locales.
1116 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1117 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1118 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1119 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1120 Translate the "Details" and "Open" string too.
1122 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1123 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1124 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1125 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1126 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1127 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1128 Add these new locales as placeholders though they currently contain English.
1130 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1132 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1135 Check the ConfiguredDocument* for null before using it.
1137 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1139 Tell Eclipse about the generated java files.
1141 * .classpath: This lets it find OnlineGlomConstants.java.
1142 It would be nice if Eclipse just used the maven build files.
1144 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1146 Prevent a crash when no locale is specified in the URL.
1148 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1149 Avoid returning a null string, obtained from
1150 Window.Location.getParameter(). This caused a crash when it was
1151 later passed to libglom's API.
1152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1153 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1154 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1155 guard against future null strings.
1157 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1159 Use the ?locale= query param instead of the &lang= token param.
1161 * src/main/java/org/glom/web/client/place/ListPlace.java
1162 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1163 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1164 Remove the lang token key and value.
1166 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1167 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1168 When the user selects a different locale from the chooser, use
1169 Window.Location.assign() to change the URL, which then causes a reload.
1171 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1172 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1173 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1174 * src/main/java/org/glom/web/client/activity/ListActivity.java
1175 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1176 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1177 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1178 * src/main/java/org/glom/web/client/ui/ListView.java:
1179 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1181 Remove localeID member variables and method/constructor parameters, instead
1182 using Utils.getCurrentLocaleID() when we need a localID to pass to
1185 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1187 Internationalize the UI strings.
1189 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1190 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1191 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1192 because it is unused. Messages are apparently strings that can have
1193 parameters, but we do not need that yet, so Contants will be enough for now.
1194 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1195 to say that we support the en and de locales.
1196 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1197 The original English strings.
1198 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1199 Some German translations of the English strings.
1200 The i18n goal then uses the .properties file to generate an
1201 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1202 returns an implementation that returns the translated strings.
1203 The documentation suggests putting these in src/java/*/client/, but it seems
1204 best to put it in src/resources/*/client/.
1205 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1206 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1207 instead of hard-coding them.
1208 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1209 but that does not seem to stop the build, though it confuses Eclipse.
1211 You can see the translated string by adding ?locale=de to the URL, like so:
1212 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1214 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1216 Improve null/empty String checks.
1218 * pom.xml: Add a dependency on commons-lang, to use
1219 org.apache.commons.lang.StringUtils.
1220 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1222 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1223 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1224 Use StringUtils.isEmpty().
1226 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1227 StringUtils class with a static isEmpty() function because we
1228 cannot use org.apache.commons.lang.StringUtils in client-side
1229 GWT code because it (apparently) cannot be compiled to javascript.
1230 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1231 * src/main/java/org/glom/web/client/activity/ListActivity.java
1232 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1233 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1234 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1235 * src/main/java/org/glom/web/client/place/ListPlace.java
1236 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1237 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1238 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1239 * src/main/java/org/glom/web/client/ui/details/Group.java
1240 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1241 our StringUtils.isEmpty() function.
1243 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1245 Update to the latest java-libglom API.
1247 * pom.xml: Require java-libglom 1.21.4.
1248 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1249 getDocumentInfo(), getListViewLayoutGroup():
1250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1252 * src/main/java/org/glom/web/server/database/DBAccess.java
1253 getFieldsToShowForSQLQueryAddGroup(),
1254 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1255 with either get_database_title_original() or
1256 get_database_title(localeID).
1258 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1260 ConfiguredDocument: Avoid a null pointer exception.
1262 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1263 Initialize localeID to "" to avoid returning a null String which
1264 causes a crash in java-libglom's swing-generated code.
1266 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1268 Some simple renaming.
1270 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1271 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1272 for localeChooser. This seems more appropriate and is less ambiguous
1273 particularly in the .css file.
1275 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1277 ConfiguredDocument: Rename the localedID private member variable.
1279 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1281 Adapt to the latest java-libglom API from git master.
1283 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1284 libglom now uses only Vector instead of List, which uses add() instead of
1287 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1289 ConfiguredDocument: Rename the localedID private member variable.
1291 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1293 Build a source tarball with mvn assembly:single
1295 * assembly.xml: Add this file.
1296 * pom.xml: Use the maven-assembly-plugin and tell it to use
1297 our assembly.xml file.
1299 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1301 OnlineGlomServiceImpl: Get .glom files recursively.
1303 * pom.xml: Depend on commons-io from org.apache.commons.
1304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1305 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1306 files recursively, and with the easier filter for the extension.
1307 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1308 simplify that code too.
1310 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1312 README: Mention that you must install java-libglom packages separately.
1314 But then it works, because java-libglom is now in the central maven
1317 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1319 locales drop-down: Show the correct selected locale when the URL changes.
1321 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1322 .java: setPlace(): Move some code into fillView().
1324 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1326 locales drop-down: Do not lose the primary key.
1328 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1329 start(): onLocaleChange(): Pass the current primary key value,
1330 instead of an empty value.
1332 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1334 locales drop-down: Do not lose the drop-down selection.
1336 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1337 .java (TableSelectionActivity.fillView): Set the selected locale
1338 after changing the drop-down items (though we do not really need
1339 to change them just because the locale changes.)
1341 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1343 locales drop-down: Change the tables list when this changes.
1345 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1346 .java: TableSelectionActivity.start(): Move the async table titles
1347 retrieval into a private fillView() method and also call this when
1348 the chosen locale changes.
1349 Note that the document title is not actually translatable yet, but
1350 that is a problem that I should fix soon in libglom.
1352 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1354 Improve the placement of the locales drop-down.
1356 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1357 Put the title and locales drop-down in a div (gwt.FlowTable).
1358 * src/main/webapp/style.css: Add magic css properties to make this work.
1359 Also remove the left margin from the title so that it lines up with the
1362 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1364 locales selector: Show human-readable locale titles.
1366 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1367 getDocumentInfo(): Use java.util.Locale to show a real title of
1368 each locale, in the locale's own language.
1370 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1372 Add a language/locale selector drop-down.
1374 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1375 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1376 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1377 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1378 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1379 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1380 Add a ListBox to show the available locales. Add getLocaleSelector(),
1381 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1382 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1383 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1384 java: Add these classes.
1385 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1386 start(): Fill the locales ListBox. Handle its change event, firing a
1388 setPlace(): Show the selected locale as specified by the URL token.
1389 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1390 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1391 Handle LocaleChangeEvent, going to a new *Place with that locale.
1393 The placement of the ListBox is not pretty, and it currently uses the ID
1394 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1398 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1400 Search box: Show the search text from the URL token.
1402 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1403 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1404 Add setQuickFindText().
1405 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1406 .java: setPlace(): Store the queryText if the place is a ListPlace,
1407 and call TableSelectionView.setQuickFindText().
1409 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1411 Allow use of translations via, for instance, &lang=de in the URL.
1413 * pom.xml: Use the unstable java-libglom 1.21 version.
1415 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1416 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1417 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1418 init(): Instead of calling TranslatableItem.set_current_locale()
1419 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1420 However, this is only for default locales, which are not needed to
1421 change the locale in the URL.
1422 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1423 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1424 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1425 layout for a particular locale.
1426 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1427 Add get/setDefaultLocaleID().
1428 getDocumentInfo(), getListViewData(), getRelatedListData(),
1429 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1430 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1431 localeID parameter, so we can get the layout for a particular locale.
1433 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1434 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1435 * src/main/java/org/glom/web/client/place/ListPlace.java:
1436 Parse and construct a lang parameter too.
1438 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1439 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1440 passed to subsequent methods and constructors.
1441 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1442 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1443 Store the localeID from the *Place and pass it to other constructors
1444 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1446 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1447 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1448 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1449 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1450 * src/main/java/org/glom/web/client/ui/ListView.java:
1451 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1452 Take localeID parameters and pass them to subsequent constructors and
1453 methods, so that the layout is always retrieved for that locale.
1455 This is rather repetitive.
1457 Note that "" means the original (default) locale of the Glom document,
1458 which is usually English.
1460 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1462 Documents: Remove final keyword to fix startup configuration.
1464 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1465 final keywords on the private member variables because that breaks
1466 the startup, apparently (there are warnings) because it stops them
1467 from being serialized. I added these in the previous commit.
1469 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1471 Documents: Add some final keywords.
1473 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1476 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1478 OnlineGlomServiceImpl: Add to overview comments.
1480 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1481 Note that this is where all the document are loaded. They are not
1482 loaded freshly for each page.
1484 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1488 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1489 Add a TextBox for the text of a quick find.
1490 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1492 setBackLink(): Add a String quickFind parameter.
1493 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1494 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1495 to the base interface, because that is how TableSelectionViewImpl is used.
1496 * src/main/webapp/style.css: Add style for the search box and its label.
1498 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1499 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1500 Add these files, based on the existing TableChangeEvent and
1501 TableChangeEventHandlers.
1502 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1503 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1504 a ListPlace() that the user should be taken to.
1505 * src/main/java/org/glom/web/client/activity/ListActivity.java
1506 start(): Handle it here too and adapt the TableChangeEvent handler to
1507 pass the extra "" quickFind parameter to ListPlace.
1508 * src/main/java/org/glom/web/client/place/ListPlace.java:
1509 Constructor: Take an extra String quickFind parameter and store it,
1510 returning it from a new getQuickFind() method.
1511 getToken(): Put the quickFind text in the URL token.
1512 getPlace(): Parse the quickFind text from the URL token.
1513 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1514 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1515 ListPlace constructor.
1516 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1517 .java: start(): Add a Change handler for the TableSelectionView's
1518 TextBox (via its base HasChangeHandlers interface), firing the new
1519 QuickFindChangeEvent.
1520 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1521 pass the extra "" quickFind parameter.
1523 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1524 setCellTable(): Add a String quickFind parameter and pass it to
1525 the ListViewTable() constructor.
1526 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1527 setCellTable() in the base interface, because that is how ListViewImpl
1530 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1531 Add a String quickFind member variable.
1532 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1533 Constructor: Add a String quickFind parameter, storing it in the
1534 base ListTable's member variable.
1535 onRangeChanged(): Pass quickFind to the
1536 OnlineGlomServiceAsync.getSortedListViewData() and
1537 OnlineGlomServiceAsync.getListViewData() methods.
1539 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1540 getListViewData(), getSortedListViewData(): Add a String quickFind
1541 parameter, passing it to ConfiguredDocument.getListViewData().
1542 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1543 Change getListViewData(), getSortedListViewData() in the base interface,
1544 because that is how OnlineGlomServiceImpl is used, via this:
1545 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1546 Change getListViewData(), getSortedListViewData() here too.
1547 This class can apparently be used to asynchronously call methods on
1548 OnlineGlomService, and GWT seems to implement that after recognizing
1549 just the *Async name convention and the extra AsyncCallback parameters.
1551 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1552 getListViewData(): Add a String quickFind parameter, and pass it to
1553 ListViewDBAccess.getData().
1554 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1555 getListData(): Add a String quickFind parameter and pass it to
1557 getSelectQuery(): Add a String quickFind parameter.
1558 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1559 getSelectQuery(): Add a String quickFind parameter and use it with
1560 Glom.get_find_where_clause_quick() to pass a where_clause to
1561 Glom.build_sql_select_with_where_clause(), to actually filter the
1563 getData(): Add a String quickFind parameter, passing it to getListData().
1564 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1565 va: getData(): Pass an empty string to getListData() for the
1566 quickFind parameter.
1568 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1570 ListTable: Minor change.
1572 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1573 createCellTable(): Make this protected instead of public.
1575 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1577 Many files: Use final for the parameters and use the @override attribute.
1579 2012-01-22 Ben Konrath <ben@bagu.org>
1581 Add anchor links for single line text that starts with http, ftp and www.
1585 2012-01-22 Ben Konrath <ben@bagu.org>
1587 Add ellipsis to single line text in details view.
1591 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1593 Remove all javadoc author tags.
1595 Because they are awkward and meaningless when many people touch
1597 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1599 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1601 Revert the COPYING.LESSER to COPYING rename.
1603 Apparently both should be there if it is LGPL.
1605 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1607 *View: Remove unused imports.
1609 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1610 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1611 * src/main/java/org/glom/web/client/ui/ListView.java:
1612 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1613 Remove unused imports, as suggested by Eclipse.
1615 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1617 Move the *View::Presenter types, and some API into one base View.
1619 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1620 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1621 * src/main/java/org/glom/web/client/ui/ListView.java:
1622 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1623 Presenter, setPresenter() and clear() into a shared base interface,
1624 to avoid the unnecessary duplicate Presenter types and to more clearly
1625 show how the *Views share the same structure, even if they are not
1626 used polymorphically.
1628 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1629 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1631 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1632 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1633 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1635 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1638 Feel free to revert this if there is a good reason for the duplicate
1641 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1643 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1645 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1646 a class member instead of a local variable in the method.
1647 This lets us use it to get the view instances, for use in tests.
1648 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1649 beforeOnlineGlom(): Test some more details of the initial view.
1650 Again, this is not very useful.
1652 To really test gwt-glom we will need to start a local postgresql
1653 instance with local data, like the Glom tests in C++.
1655 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1657 pom.xml: Mention the LGPL license.
1659 * pom.xml: Add a licenses section.
1660 * COPYING.LESSER: Move this to COPYING, which
1661 previously contained the GPL. But gwt-glom is all LGPL.
1663 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1665 Add project information to README and pom.xml.
1667 * README: Add a brief description and mention some mvn
1669 * pom.xml: This extra information shows up in mvn site
1672 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1674 Use the latest java-libglom version.
1676 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1678 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1680 GwtTestOnlineGlom: Test a little more.
1682 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1683 protected rather than private, as suggested by the gwt-test-utils
1685 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1686 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1687 Test the initial visibility of the panels.
1689 However, this is not a very useful test.
1690 And I wonder how we should generally test using this idea for an
1691 activity/places app like ours where the real changes happen implicitly
1692 based on the history token/URL.
1694 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1696 Slight modification to *Mapper comments.
1698 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1699 (DataActivityMapper)
1700 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1702 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1704 Remove comments mentioning GIN because they are just copied from
1705 the example code and are apparently not helpful:
1706 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1707 Also change the mention of a class that is only in the example code.
1709 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1711 GwtTestOnlineGlom test: Minor changes.
1713 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1714 Avoid the long qualified class name and modify the comment
1715 because it is now obvious to me that the mocked class is the only
1716 custom one created via GWT.create().
1718 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1720 Tests: Added the beginnings of a test using gwt-test-utils.
1722 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1723 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1724 which tells gwt-test-utils what class will be tested.
1725 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1726 Add a simple (but empty) test case. One class, used by the OnlineGlom
1727 class, is mocked so that it can be created. However, I am not sure
1728 why only this class needs to be mocked.
1730 Note that mockito seems more popular, and clearer, than easymock,
1731 but I have not got that working yet. It might be a matter of the
1734 This test is run during mvn integration-test.
1736 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1738 Tests: Use junit4-style syntax instead of junit3-style.
1740 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1741 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1742 * src/test/java/org/glom/web/shared/DataItemTest.java:
1743 Use the @Test annotation rather than relying on the test*() prefix.
1744 Also no longer implement TestCase, to avoid triggering support for
1745 the junit3-way, which stops the annotations from working.
1746 Change the imports from import junit.framework.* to
1747 import org.junit.*, which is apparently the new way.
1749 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1751 Added a test for ListPlace token parsing and creation.
1753 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1754 This is much the same as DetailsPlaceTest.
1756 I wonder how we could test the other parts of the *Place API.
1758 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1760 DetailsPlace test: Also test getToken() and recreation via getPlace().
1762 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1763 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1764 recreate it, testing the recreated DetailsPlace for the same parameter
1767 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1769 Use the surefire-report plugin.
1771 * pom.xml: This generates a HTML report about the tests in
1772 target/site/surefire-report.html
1773 when you do mvn surefire-report:report. It seems to be popular/normal.
1775 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1777 Added a test for DetailsPlace.
1779 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1780 Test the getPlace() token parsing.
1782 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1784 Added a first unit test.
1786 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1787 * src/test/java/org/glom/web/shared/DataItemTest.java:
1788 This is a silly test but it is just to get things started. Note that
1789 maven/junit finds the test because it looks in src/test by default.
1791 2011-12-22 Ben Konrath <ben@bagu.org>
1793 Change charsetName to "UTF-8" when replacing line breaks.
1795 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1796 that work in Java (such as "UTF8") will not work when compiled to
1799 This fixes a problem with multi-line details view fields that have hard
1800 line breaks. The "License Text" field on this page demonstrates the
1803 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1805 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1807 2011-12-22 Ben Konrath <ben@bagu.org>
1809 Fix another bug with related list navigation.
1811 I've tested all the navigation buttons in all of the related lists
1812 so things should be good now.
1814 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1816 2011-12-22 Ben Konrath <ben@bagu.org>
1818 Fix a crasher when refreshing the list view with the default table.
1820 This crash will also happen when loading the list view with the default
1821 table from a link or bookmark.
1823 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1824 to the main document selection page when the document id hasn't been
1826 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1827 the main document selection page when the document id hasn't been
1829 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1830 values for the details place when the document id hasn't been set.
1831 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1832 values for the list place when the document id hasn't been set.
1834 2011-12-21 Ben Konrath <ben@bagu.org>
1836 Protect against NPE when glom.document.locale is not in config.
1838 This patch protects against an NPE when glom.document.locale is not in
1839 the config file. This NPE will also happen if glom.document.locale is
1842 The patch also updates the error message to display the class name when
1843 the getMessage() returns null. This was happening when the NPE was
1844 thrown and I had "Configuration Error: null". If an NPE is encountered
1845 with this patch, "Configuration Error: NullPointerException " will be
1848 This commit closes this bug:
1850 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1854 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1856 Rename onlineglom.properties to onlineglom.properties.sample.
1858 * src/main/resources/onlineglom.properties: Rename to:
1859 * src/main/resources/onlineglom.properties.sample:
1860 * src/main/resources/README: And add this file explaining that people
1861 should rename it back when deploying.
1863 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1865 Allow choosing the translation in the .properties file.
1867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1868 init(): Read a glom.document.locale value from the configuration file
1869 and call Glom's TransatableItem::set_current_locale() method.
1870 * src/main/resources/onlineglom.properties: Add a commented-out
1871 example of this new setting.
1873 It would be better to add &lang=de_DE to the URL, but the current
1874 libglom API does not allow us to do this easily. I am working on that.
1876 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1878 Avoid a crash in parsing of token parameters.
1880 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1881 ava: getTokenParams(): Do not crash if a parameter has a key but no
1882 value, and ignore parameters with neither.
1884 2011-12-17 Murray Cumming <murrayc@murayc.com>
1886 History token building/handling: Improve use of token parameters.
1888 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1889 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1890 and buildParamsToken(HashMap), for use by derived classes.
1891 Make the separator private because it is no longer be needed.
1892 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1893 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1894 instead of manual string concatenation.
1895 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1896 of hardcoded indices and awkward splitting code.
1897 * src/main/java/org/glom/web/client/place/ListPlace.java
1898 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1899 instead of manual string concatenation.
1900 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1901 of hardcoded indices and awkward splitting code.
1902 This should fix bug #666420
1904 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1906 Fix a Navgiation->Navigation typo in the code.
1908 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1909 Rename processNavgiation() to processNavigation().
1911 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1913 Fix a seperator->separator typo in the code.
1915 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1916 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1917 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1920 2011-12-15 Ben Konrath <ben@bagu.org>
1922 Cleanup some comments.
1924 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1926 2011-12-14 Ben Konrath <ben@bagu.org>
1928 Replace \n with <br/> for multiline text in the details view.
1930 Vertical scrollbars are added when needed as well.
1932 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1934 2011-12-14 Ben Konrath <ben@bagu.org>
1936 Specify the font for document selection links.
1938 * src/main/webapp/style.css:
1940 2011-12-14 Ben Konrath <ben@bagu.org>
1942 Fix bouncy CellTable while paging.
1944 This doesn't currently work with related list tables in unselected
1947 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1949 2011-12-14 Ben Konrath <ben@bagu.org>
1951 Revamp the appearance of the document selection page.
1953 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1954 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1955 * src/main/webapp/style.css:
1957 2011-12-13 Ben Konrath <ben@bagu.org>
1959 Set navigation button column to the smallest size possible.
1961 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1963 2011-12-13 Ben Konrath <ben@bagu.org>
1965 Change OpenButton nomenclature to NavigationButton.
1967 Using NavigtionButton makes things more generic. Classes, methods and
1968 variables have been changed.
1970 This is a rename-only refactor.
1972 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1973 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1974 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1975 Renamed from OpenButtonCell.
1976 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1977 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1978 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1980 2011-12-12 Ben Konrath <ben@bagu.org>
1982 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1984 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1985 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1986 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1987 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1989 2011-12-12 Ben Konrath <ben@bagu.org>
1991 Update variable names and comments.
1993 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1994 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1996 2011-12-12 Ben Konrath <ben@bagu.org>
1998 Properly initialize numNonEmptyRows variable to zero.
2000 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2001 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2003 2011-12-05 Ben Konrath <ben@bagu.org>
2005 Add latest mockup with HTML tables.
2007 Features of this mockup:
2009 -> HTML table for flowtable
2010 -> HTML table for flowtable column
2011 -> Example of how related lists would look
2012 -> Not using text entries for data items
2014 The current version of Online Glom doesn't use HTML tables for the
2017 This mockup has been sent to the glom-devel mailing list but it's good
2018 to have it here as well.
2020 * mockups/details-view-html-tables.html:
2022 2011-12-05 Ben Konrath <ben@bagu.org>
2024 Remove unnecessary getPrimaryKeyField() method.
2026 getPrimaryKeyFieldForTable(String) has been renamed to
2027 getPrimaryKeyField(String).
2029 * src/main/java/org/glom/web/server/database/DBAccess.java:
2030 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2031 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2033 2011-12-05 Ben Konrath <ben@bagu.org>
2035 Add string representation of TypedDataItem value to conversion error message.
2037 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2038 message was extracted into its own method to avoid duplication.
2040 2011-12-05 Ben Konrath <ben@bagu.org>
2042 Add type checking to navigation primary key value creation.
2044 Create navigation primary key only if the expected type from the Glom
2045 document matches the type returned by the SQL query.
2047 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2049 2011-12-05 Ben Konrath <ben@bagu.org>
2051 Rename a couple of variables in RelatedListNavigation.
2053 This is a rename-only refactor.
2055 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2057 2011-12-05 Ben Konrath <ben@bagu.org>
2059 Move getListLayoutGroup() into getListViewLayoutGroup().
2061 This removes getListLayoutGroup(). It was only being called by
2062 getListViewLayoutGroup().
2064 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2066 2011-12-05 Ben Konrath <ben@bagu.org>
2068 Remove check for LayoutItem_Portal in list table method.
2070 This check is no longer necessary because the method isn't being used
2071 to create the LayoutItemPortal DTO.
2073 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2075 2011-12-05 Ben Konrath <ben@bagu.org>
2077 Properly support related list navigation.
2079 Navigation from the "Repository Analyzer -> Package Scans ->
2080 Dependencies" related table wasn't working because the primary key for
2081 related tables wasn't being set properly. This commit fixes the
2084 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2085 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2086 doesn't set the primary key properly for related list tables.
2087 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2088 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2089 useful for getting the primary key for list view tables and for related
2091 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2092 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2093 Move code to set the primary key for the table from the abstract
2094 ListDBAccess class to ListViewDBAccess as it's only correct for list
2096 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2097 Properly add primary key to related list tables.
2099 2011-12-02 Ben Konrath <ben@bagu.org>
2101 Properly set the horizontal alignment of fields.
2103 This fix is for both the list tables and the details view.
2105 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2106 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2107 to set the horizontal alignment of fields.
2109 2011-12-02 Ben Konrath <ben@bagu.org>
2111 Display currency codes in the details view.
2113 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2115 2011-12-02 Ben Konrath <ben@bagu.org>
2117 Avoid duplicate JNI call.
2119 JNI is not as efficient as pure Java and this is an easy (and small)
2122 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2123 Use previously retrieved value for whereClauseToTableName instead of
2126 2011-12-02 Ben Konrath <ben@bagu.org>
2128 Rename a couple of variables in RelatedListNavigation.
2130 This is a rename-only refactor.
2132 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2134 2011-12-02 Ben Konrath <ben@bagu.org>
2136 Indicate clearly that a mismatched primary key type is a bug.
2138 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2139 warning to error. Add 'This is a bug.' to message.
2141 2011-12-02 Ben Konrath <ben@bagu.org>
2143 Update / fix some comments.
2145 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2147 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2149 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2150 Fix comments. Add some TODOs.
2152 2011-12-02 Ben Konrath <ben@bagu.org>
2154 Enable navigation to details view with string primary key from related list.
2156 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2157 Create a text primary key value when return type of result is
2158 java.sql.Types.VARCHAR.
2160 2011-12-02 Ben Konrath <ben@bagu.org>
2162 Use checkboxes for booleans in the details view.
2164 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2166 2011-12-01 Ben Konrath <ben@bagu.org>
2168 Improve performance of related list height calculation.
2170 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2171 Put code to calculate the expected height in a static initializer so
2172 that that it's only called once.
2174 2011-12-01 Ben Konrath <ben@bagu.org>
2176 Show related list tables in notebooks (again).
2178 Calculate the height of the related list tables so the Notebook can be
2179 set the correct height. The height of the related list table is also needed by
2180 FlowTable to be able decide how to create the layout.
2182 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2183 and set the Portal height based on the height of the related list
2184 table and the Portal container.
2185 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2186 Add method to calculate the height of the related list tables.
2187 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2188 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2189 calculate the height of the Pager widget.
2191 2011-12-01 Ben Konrath <ben@bagu.org>
2193 Use CellTable API for table property instead of setting style on Element.
2195 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2197 2011-12-01 Ben Konrath <ben@bagu.org>
2199 Make ListViewTable and RelatedListTable a consistent height.
2201 The tables are now a consistent height regardless of the contents of
2202 the table. A hidden button is added to empty rows to ensure that the
2203 height of these rows will match the height of rows with data.
2205 A navigation button column is now added to every table. The width of
2206 the navigation column is set to 0px when a RelatedListTable shouldn't
2207 have navigation buttons. This maintains the a consistent row height in
2208 tables that don't show the navigation buttons.
2210 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2211 navigation column when not needed.
2212 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2213 arguments for navigation button to constructor of ListViewTable.
2214 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2215 hidden button for empty data rows.
2216 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2217 arguments for navigation button to constructor.
2218 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2219 create navigation buttons. Add hideNavigationButtons() method.
2220 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2221 arguments for navigation button to constructor.
2223 2011-12-01 Ben Konrath <ben@bagu.org>
2225 Use 'visibility: hidden' in Utils.getWidgetHeight().
2227 This is better choice because hidden elements are invisible, don't
2228 respond to events and are not part of the tab order. They will,
2229 however, take up space which is required to be able to calculate the
2230 height of the widget.
2232 * src/main/java/org/glom/web/client/Utils.java:
2234 2011-12-01 Ben Konrath <ben@bagu.org>
2236 Use Utils.getWidgetHeight() in FlowTable.
2238 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2240 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2242 2011-12-01 Ben Konrath <ben@bagu.org>
2244 Put the details css class name on the correct table column.
2246 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2248 2011-11-30 Ben Konrath <ben@bagu.org>
2250 Update for java-libglom API change.
2252 The getters and setters on FieldFormatting and NumericFormat were
2253 changed to remove the 'M'.
2255 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2257 2011-11-29 Ben Konrath <ben@bagu.org>
2259 Only allow RelatedListTables in Portals.
2261 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2263 2011-11-29 Ben Konrath <ben@bagu.org>
2265 Only create a contents panel for Portals when title is being set.
2267 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2269 2011-11-29 Ben Konrath <ben@bagu.org>
2271 Set TabLayoutPanel height based on calculated height its widgets.
2273 This is a potential fix for this bug:
2275 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2277 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2279 2011-11-29 Ben Konrath <ben@bagu.org>
2281 Align details field labels and data with the Open buttons.
2283 * src/main/webapp/style.css:
2285 2011-11-29 Ben Konrath <ben@bagu.org>
2287 Remove unnecessary <div> in the Notebook widget.
2289 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2290 method to get container FlowPanel (<div>).
2291 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2292 initWidget() method directly on the TabLayoutPanel widget instead of
2293 Group's container widget.
2295 2011-11-29 Ben Konrath <ben@bagu.org>
2297 Don't add group titles for Portals in Notebooks.
2299 This reverts the previous patch and fixes a bug I introduced with
2300 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2302 * src/main/java/org/glom/web/client/ui/details/Group.java:
2303 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2305 2011-11-28 Ben Konrath <ben@bagu.org>
2307 Remove unused boolean argument in Portal constructor.
2309 Just a code cleanup.
2311 * src/main/java/org/glom/web/client/ui/details/Group.java:
2312 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2314 2011-11-28 Ben Konrath <ben@bagu.org>
2316 Remove hack for glom 1.18 style glom files.
2318 * src/main/java/org/glom/web/client/ui/details/Group.java:
2319 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2320 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2322 2011-11-28 Ben Konrath <ben@bagu.org>
2324 Use Gda Value version of primary key to log result too large error.
2326 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2328 2011-11-28 Ben Konrath <ben@bagu.org>
2330 Don't use TypedDataItem.getText() for Unknown types from the URL.
2332 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2333 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2334 instead of getText().
2335 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2336 String field and getUnknown() method.
2338 2011-11-28 Ben Konrath <ben@bagu.org>
2340 Log an error message when the java-libglom .so is not present.
2342 The error message was being set in the exception but not logged.
2344 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2346 2011-11-28 Ben Konrath <ben@bagu.org>
2348 Ignore LayoutItem_CalendarPortals.
2350 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2351 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2353 2011-11-28 Ben Konrath <ben@bagu.org>
2355 Extract method for creating the LayoutItemPortal DTO.
2357 Just breaking the code up into smaller chunks.
2359 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2361 2011-11-28 Ben Konrath <ben@bagu.org>
2365 This should have been added with the refactor. Oops!
2367 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2369 2011-11-28 Ben Konrath <ben@bagu.org>
2371 Create primary key value from URL string using type from Glom document.
2373 See this bug, comments 19 - 25:
2375 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2377 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2378 create a TypeDataItem for the primary key here when loading from a
2379 URL. Show the same string for the primary key value as was received
2380 from the URL string (when loading from a URL).
2381 * src/main/java/org/glom/web/server/Utils.java: Update method for
2382 creating the Gda Value from the TypeDataItem to properly deal with
2383 creating a Gda Value based on the Glom document type for the primary
2384 key value string when loading from a URL.
2385 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2386 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2387 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2388 Update for changed method name.
2390 2011-11-27 Ben Konrath <ben@bagu.org>
2392 Rename PrimaryKeyItem to TypedDataItem.
2394 The name PrimaryKeyItem suggests what the class should be used for.
2395 TypedDataItem is a neutral name that describes the class better.
2397 This is a rename-only refactor.
2399 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2400 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2401 * src/main/java/org/glom/web/client/Utils.java:
2402 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2403 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2404 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2405 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2406 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2407 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2408 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2409 * src/main/java/org/glom/web/server/Utils.java:
2410 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2411 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2412 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2413 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2415 2011-11-25 Ben Konrath <ben@bagu.org>
2417 Improve Gda Value conversion from PrimaryKeyItem.
2419 The value from the PrimaryKeyItem is only used if its type match the
2420 type from the glom document.
2422 * src/main/java/org/glom/web/server/Utils.java:
2424 2011-11-25 Ben Konrath <ben@bagu.org>
2426 Manually check if the java-liblgom .so is visible to the JVM.
2428 It seems that Tomcat has problems when a static initializer throws an
2429 exception. This check is done before the first method call into
2430 java-libglom so that execution doesn't continue if the .so is not
2433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2435 2011-11-25 Ben Konrath <ben@bagu.org>
2437 Improve browser configuration error messages.
2441 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2443 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2444 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2445 getConfigurationErrorMessage() method.
2446 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2447 Get and display a specific configuration error message when no Glom
2448 documents are found.
2449 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2450 Implement getConfigurationErrorMessage() method. Surround configuration
2451 code in the init() method with a try/catch block. This allows the
2452 errors to be caught while keeping the servlet available to retrieve the
2453 configuration error message.
2455 2011-11-25 Ben Konrath <ben@bagu.org>
2457 Don't use Strings to hold primary key values.
2459 The primary key values are now held in a new data object
2460 (PrimaryKeyItem) that holds type information and the primary key value
2461 using the correct type.
2463 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2464 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2465 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2466 PrimaryKeyItem instead of String to hold the primary key value.
2467 * src/main/java/org/glom/web/client/Utils.java: Remove
2468 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2469 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2470 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2471 PrimaryKeyItem instead of String to hold the primary key value. Load
2472 document selection page when the documentID has not been set correctly.
2473 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2474 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2476 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2477 Return empty string for URL instead of "null".
2478 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2479 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2480 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2481 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2482 PrimaryKeyItem instead of String to hold primary key values.
2483 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2484 PrimaryKeyValue to a Gda Value.
2485 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2486 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2487 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2488 Replace temporary database access code that uses the PrimaryKeyValue to
2489 Gda Value conversion.
2490 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2491 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2492 PrimaryKeyItem instead of String.
2493 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2494 hold primary key values.
2496 2011-11-24 Ben Konrath <ben@bagu.org>
2498 Use newly added java-libglom API to create queries.
2500 This isn't finished. I still need to stop using Strings for primary key
2501 values in the client code.
2503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2504 libglom to use fake connections so that retrieving the query string will
2506 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2507 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2508 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2509 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2510 Use the newly added libglom sql methods and classes to create the
2511 query. Add temporary hack to convert primary value strings to Gda
2514 2011-11-23 Ben Konrath <ben@bagu.org>
2516 Don't explicitly set the height of Portals.
2518 See comments 6 - 10 of this bug for details:
2520 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2522 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2524 2011-11-23 Ben Konrath <ben@bagu.org>
2526 Use an HTML table instead of CSS for the FlowTable layout.
2528 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2529 GWT's FlexTable to implement the FlowTable.
2530 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2532 2011-11-18 Ben Konrath <ben@bagu.org>
2534 Add boolean example to HTML table mockup.
2536 * mockups/details-view-html-tables-text-entries.html:
2538 2011-11-17 Ben Konrath <ben@bagu.org>
2540 Ensure the pager buttons are always visible for related lists.
2542 To accomplish this, I've turned off text wrapping in the list view and
2543 related list tables for both the header and data text. The related list
2544 table now has a fixed layout so the it doesn't overflow its container.
2545 This is required to ensure that the cell text is clipped when it
2546 overflows the cell and an ellipsis is added to the right side of the
2547 cell when text is clipped.
2549 A fixed table layout for the related list table in the details view
2550 seems what we want for the details view anyway, so the side-effect is
2553 The ellipsis will only be displayed in Firefox >= 7.
2557 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2559 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2560 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2561 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2563 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2564 Set the 'table-layout: fixed' CSS property to the related list table.
2565 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2566 'white-space: nowrap;' CSS property on both the list view and the
2567 related list tables.
2569 2011-11-16 Ben Konrath <ben@bagu.org>
2571 Rework the fix for empty notebook tab labels.
2573 Setting the empty group titles with its name caused problems for the
2574 details layout. Instead of using libglom's
2575 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2576 to the client when the title is empty. This allows the Notebook to use
2577 the name when the title is empty without affecting anything else.
2579 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2580 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2582 2011-11-16 Ben Konrath <ben@bagu.org>
2584 Set group titles with name when title is empty.
2586 This fixes a problem with an empty notebook tab label in the Lesson
2587 Planner document. The forth tab in the notebook should be "Internet":
2589 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2591 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2592 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2595 2011-11-16 Ben Konrath <ben@bagu.org>
2597 Remove whitespace from the configured username properties.
2599 This assumes that usernames won't have whitespace at the beginning
2600 or end. But I think this is a reasonable assumption.
2602 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2603 String.trim() to remove the whitespace from the username properties.
2605 2011-11-15 Ben Konrath <ben@bagu.org>
2607 Add details view mockup with HTML tables and text entries.
2609 This is from the attachment on this bug:
2611 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2613 * mockups/details-view-html-tables-text-entries.html:
2615 2011-11-15 Ben Konrath <ben@bagu.org>
2617 Add space between the columns of the flow table.
2621 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2623 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2624 space between columns in the flow table.
2626 2011-11-15 Ben Konrath <ben@bagu.org>
2628 Add backup files to the .gitignore.
2630 * .gitignore: Ignore files that end with ~.
2632 2011-11-09 Ben Konrath <ben@bagu.org>
2634 Use latest release of gwt-log.
2636 Gwt-log releases are now being submitted to the maven central
2637 repository so manual installation of the jar is no longer required.
2639 * pom.xml: Update version and groupId of gwt-log dependency.
2641 2011-10-31 Ben Konrath <ben@bagu.org>
2643 Don't use GWT numeric formatting to override the glom currency formatting.
2645 Currencies are now displayed like they are in Glom. See this bug:
2647 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2649 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2651 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2652 currency code to constructor and set it when the cell is rendered.
2653 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2654 currency code to the constructor of the NumericCell.
2656 2011-10-27 Ben Konrath <ben@bagu.org>
2658 Require the latest release of java-libglom (1.17.4).
2662 2011-10-26 Ben Konrath <ben@bagu.org>
2664 Add style to Notebook that matches current theme.
2666 It's not the best style in the world but it's better than the default.
2668 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2669 padding at the bottom of the child widgets.
2670 * src/main/webapp/style.css: Add style for the Notebook.
2672 2011-10-26 Ben Konrath <ben@bagu.org>
2674 Move servlet initialization code to overridden init method.
2676 This is half of the solution to getting proper error messages
2677 displayed when configuration errors occur. Here's the relevant bug:
2679 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2681 The rest of the solution involves surrounding the init method with a
2682 try/catch block and setting a global variable with the error /
2683 exception. A new async method should be created to retrieve and display
2684 the error message / exception.
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2687 code from constructor to init method adding exceptions as needed.
2689 2011-10-26 Ben Konrath <ben@bagu.org>
2691 Add script to monitor and restart tomcat if required.
2693 * utils/check-and-recover-tomcat.py: New file.
2695 2011-10-26 Ben Konrath <ben@bagu.org>
2697 Display the correct number of data items in the pager.
2701 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2703 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2704 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2705 The implementation is the same for both tables: Keep track of the
2706 number of non-empty rows and fire and RowCountChangeEvent after the data has
2708 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2709 custom Pager class that subclasses SimplePager to handle displaying
2710 the correct number when empty rows have been added.
2712 2011-10-26 Ben Konrath <ben@bagu.org>
2714 Correct error in previous commit.
2716 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2717 eventBus parameter from listView.setCellTable().
2719 2011-10-26 Ben Konrath <ben@bagu.org>
2721 Fix error in TODO comment.
2723 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2725 2011-10-24 Ben Konrath <ben@bagu.org>
2727 Create Notebook widgets to the details view.
2729 This isn't finished just yet - I still need to create a reasonable
2730 style to match the current theme.
2732 * src/main/java/org/glom/web/client/Utils.java: Add method for
2733 calculating the height of a widget. This is used in the Notebook class.
2734 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2735 new constructor method in Group.
2736 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2737 method for creating child widget that can be used by subclasses
2738 like Notebook. New constructor that allows disabling the group
2739 titles - Notebooks don't set a group title for their child groups.
2740 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2741 to make Notebooks using GWT's TabLayoutPanel.
2742 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2743 constructor that allows disabling the group titles.
2744 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2745 LayoutItemNotebook DTO.
2746 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2747 DTO for Notebooks. It's just an empty class for now but we might need
2748 it to transfer some specific information in the future.
2750 2011-10-21 Ben Konrath <ben@bagu.org>
2752 Add navigation buttons to related list tables.
2754 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2755 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2756 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2757 method getSuitableRecordToViewDetails() for getting the table name
2758 and primary key value for related list navigation buttons.
2759 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2760 private cell renderer class to get the navigation information for
2761 related list tables from the server. Extract the navigation
2762 processing code from the details cell navigation and use it for the
2763 related list navigation as well.
2764 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2765 cell renderer class for the details open buttons. This was needed
2766 because the related list navigation buttons and the list view
2767 navigation buttons need to react differently when clicked.
2768 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2769 the onEnterKeyDown() method because it's now overriden in the
2770 subclasses that are specific to the related list tables and the list
2772 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2773 the vertical size a little because the buttons add a bit of vertical
2774 space to table. This is not a perfect solution because the vertical
2775 size of with table fewer than 5 rows will be a little smaller.
2776 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2777 changes in how navigation buttons are handled.
2778 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2779 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2780 database access object.
2781 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2782 to find the portal for a given relationship name from
2783 RelatedListDBAccess. Add method to find a primary key field for a
2785 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2786 Move code to find the portal for a given relationship name to
2788 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2789 New file: database access object for getting the related list
2790 navigation information (the table name and the primary key value).
2791 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2792 DTO for transferring a table name to navigate to and a primary key
2794 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2795 boolean and getter/setter to specifies if the related list should add
2798 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2800 Use the master branch of java-libglom
2802 * pom.xml: Depend on java-libglom 1.19 instead.
2804 This is the master branch. See also the libglom-1-18 branch.
2806 2011-10-11 Ben Konrath <ben@bagu.org>
2808 Enable the open navigation button when the data has been set.
2810 This avoids having active buttons that don't do anything when the data
2813 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2815 2011-10-11 Ben Konrath <ben@bagu.org>
2817 Use IsWidget interface for FlowTableItem.
2819 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2820 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2822 2011-10-11 Ben Konrath <ben@bagu.org>
2824 Remove GWT styling from open button in details view.
2826 There are still some issues with how the details cell is arranged but
2827 this should be made to match Glom 1.20. I'm going to leave fixing this
2828 until I have Glom 1.20 up and running.
2830 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2831 style name on open button.
2832 * src/main/webapp/style.css: Move and edit details-navigation class.
2833 Re-arrange some classes to make them appear in the same order as the
2836 2011-10-07 Ben Konrath <ben@bagu.org>
2838 Update to GWT 2.4.0.
2840 * .gitignore: Ignore new cache directory.
2841 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2842 * pom.xml: Change GWT and maven plugin to 2.4.0.
2843 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2845 * src/main/java/org/glom/web/client/ClientFactory.java:
2846 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2847 * src/main/java/org/glom/web/client/OnlineGlom.java:
2848 Update source for API changes.
2849 * utils/build-onlineglom-war.sh: Remove cache directory before the
2852 2011-10-07 Ben Konrath <ben@bagu.org>
2854 Add navigation buttons in the details view.
2856 This isn't finished but I thought I'd commit what I have as it's a
2857 pretty good start. I still need to:
2859 1. Change the style so that it fits better into the current theme
2860 2. Adjust the details cell to expand as much as possible.
2862 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2863 click handlers to navigation buttons in the DetailsCells. Create a
2864 refreshData() method to get just the data from the server without the
2866 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2867 Update the tableSelector and browser title when the table name
2868 changes without using the tableSelector.
2869 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2870 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2871 getDetailsCells() to getCells(). Update variable names.
2872 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2873 method to set click handler on navigation button. Rename a few
2874 variables. Add navigation buttons where needed.
2875 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2876 variables and methods.
2877 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2878 navigation boolean and navigation table as required in the
2879 LayoutItemField DTO.
2880 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2881 variables for navigation along with getter/setter methods.
2883 2011-10-07 Ben Konrath <ben@bagu.org>
2885 Rename Field to DetailsCell.
2887 This is a refactor-only commit. No functionality has been added or
2890 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2891 Update variable and method names.
2892 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2893 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2894 variable and method names.
2895 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2897 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2898 variable and method names.
2900 2011-10-07 Ben Konrath <ben@bagu.org>
2902 Create separate methods for layout and data the details view.
2904 This is a refactor-only commit. No functionality has been added or
2907 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2908 private methods: setData(), createLayout().
2910 2011-10-07 Ben Konrath <ben@bagu.org>
2912 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2914 This is part of a change to get navigation buttons in the details view
2915 but it should have been done this way from the start.
2917 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2918 for method name change in TableSelectionView.
2919 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2920 Create TableChangeEvent and set the browser title using the
2921 TableSelectionView API.
2922 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2923 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2924 Change getSelectedTable() to getSelectedTableName(). Add
2925 getSelectedTableTitle().
2927 2011-10-07 Ben Konrath <ben@bagu.org>
2929 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2931 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2933 2011-10-07 Ben Konrath <ben@bagu.org>
2935 Update TableChangeEvent to use newTableName naming convention.
2937 This makes the class more consistent with GWT naming conventions.
2939 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2940 Update for method name change in TableChangeEvent.
2941 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2942 for method name change in TableChangeEvent.
2943 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2944 newTableName variable and getter method. Make toDebugString()
2947 2011-09-30 Ben Konrath <ben@bagu.org>
2949 Disable the pager in the list tables when the data row count is less than the minimum.
2951 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2952 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2954 2011-09-30 Ben Konrath <ben@bagu.org>
2956 Add empty rows to the end of related list and list view tables.
2958 I also extracted the cell rendering classes from the ListTable because
2959 the code was becoming a little crazy with all the anonymous inner
2960 classes. My plan is to use these cell rendering classes in the details
2961 view as well so this refactor will be needed for that change.
2963 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2964 set the row count in related list tables if the data has more rows
2965 than the minimum number of rows visible.
2966 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2967 row count in list view tables if the data has more rows than the
2968 minimum number of rows visible.
2969 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2970 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2972 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2973 for rendering TYPE_NUMERIC cells. The code was extracted from the
2975 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2976 class for rendering cells with buttons in list views. The code was
2977 extracted from the ListTable class.
2978 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2979 for rendering TYPE_TEXT cells. The code was extracted from the
2981 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2982 Add empty rows to the end of the data if required. Implement
2983 ListTable.getMinNumVisibleRows().
2984 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2985 cell renderer code to public classes. Return null in
2986 Column.getValue() for empty rows. Add new abstract method:
2987 getMinNumVisibleRows(). Move code to set the row count of the list view
2988 table to ListViewImpl.
2989 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2990 empty rows to the end of the data if required. Implement
2991 ListTable.getMinNumVisibleRows().
2994 2011-09-27 Ben Konrath <ben@bagu.org>
2996 Use GWT.log for client-side debugging statements.
2998 These are optimized out when deployed so I should have used this method
2999 in the first place. These statements will eventually be replaced with some sort
3000 of notification in the browser.
3002 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3003 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3004 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3005 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3006 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3008 2011-09-27 Ben Konrath <ben@bagu.org>
3010 Put tableselector on the right, back to list link on right.
3012 The idea is that the table selector is acting like a label for the
3013 currently displayed table so it should be placed below the document title. This
3014 puts the table title in a similar position to where it is in Glom.
3016 * mockups/details-contacts.html:
3017 * mockups/details-projects.html:
3018 * mockups/listview-contacts.html:
3019 * mockups/listview-projects.html:
3020 * mockups/style.css:
3021 Update mockups to match how the interfaces currently look.
3022 * src/main/webapp/style.css: Swap positions of backlink with the table
3023 selector. Add some space on the left side of the table selector to
3024 line things up with the document title.
3026 2011-09-27 Ben Konrath <ben@bagu.org>
3028 Add field colouring to details view.
3030 This change re-works how field colouring works. The colour formatting
3031 information is now set to the client with the layout information instead of
3032 with the data. This eliminates the need to send the same colour strings for
3033 data in list view column when colour information is set.
3035 In order to set an alternate colour for negative numeric values, the
3036 number is now sent to client and formatted with the GWT NumberFormat class.
3038 This change also fixes:
3040 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3042 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3043 internationalization framework which is needed for client side numeric
3045 * src/main/java/org/glom/web/client/Utils.java: New file for some
3046 client static utility methods.
3047 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3048 the DataItem object to the Field class. Use a utility method to
3049 create the foreignKeyValue string.
3050 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3051 alignment and text colours in the constructor. Add setData(DataItem)
3052 method. Remove setText(String) method.
3053 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3054 colour information to GlomTextCell. Create and use GlomNumberCell for
3055 rendering numbers. Use utility method to get the string for the
3056 primary key of the key provider. Re-work how the horizontal alignment
3058 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3059 formatting to layout information. Methods for converting the libglom
3060 formatting information were moved from DBAccess.
3061 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3062 numeric formatting (it's now done on the client side). Don't set text
3063 colours in DataItem. Move libglom formatting conversion methods to
3065 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3066 getters/setters for text colour information.
3067 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3068 for transferring the libglom NumericFormat information to the client.
3069 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3070 and getters/setters for: GlomNumericFormat, background colour and
3071 foreground colour strings.
3073 2011-09-26 Ben Konrath <ben@bagu.org>
3075 Simplify code that iterates through the LayoutGroup.
3077 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3079 2011-09-26 Ben Konrath <ben@bagu.org>
3081 Accept Eclipse formatting for OnlineGlomServiceAsync.
3083 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3085 2011-09-26 Ben Konrath <ben@bagu.org>
3087 Don't use the ListDBAccess classes to get the primary key layout information.
3089 This was causing a bug where the wrong index for the hidden primary key
3090 was being sent to the client.
3092 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3093 primary key while creating the LayoutGroup DTO. Create a
3094 LayoutItemField DTO for hidden primary keys. Don't use the
3095 RelatedListDBAccess because it was only used for getting the primary
3097 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3098 access modifier from public to protected for getPrimaryKeyField() and
3099 getPrimaryKeyLayoutItemField().
3100 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3101 abstract method getExpectedResultSize() because RelatedListDBAccess
3102 doesn't have enough info to implement it.
3103 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3104 Remove @Override for getExpectedResultSize().
3105 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3106 Remove method getExpectedResultSize().
3108 2011-09-23 Ben Konrath <ben@bagu.org>
3110 Log which layout (list or details) the ignored item is from.
3112 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3114 2011-09-23 Ben Konrath <ben@bagu.org>
3116 Remove annotations that turn off code formatting in DataItem.
3118 * src/main/java/org/glom/web/shared/DataItem.java:
3120 2011-09-23 Ben Konrath <ben@bagu.org>
3122 Rename GlomField to DataItem and update associated methods.
3124 This is a rename-only refactor. No functionality has been added or
3127 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3128 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3129 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3130 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3131 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3132 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3133 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3134 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3136 * src/main/java/org/glom/web/server/database/DBAccess.java:
3137 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3138 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3139 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3140 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3141 * src/main/java/org/glom/web/shared/DataItem.java:
3142 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3143 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3145 2011-09-23 Ben Konrath <ben@bagu.org>
3147 Rename GlomDocument to DocumentInfo and update associated methods.
3149 This is a rename-only refactor. No functionality has been added or
3152 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3153 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3154 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3155 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3156 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3157 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3158 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3160 2011-09-20 Ben Konrath <ben@bagu.org>
3162 Require java-libglom 1.17.3.
3164 This picks up the fix for the seg fault problem with the Scenes table
3165 in the Openismus Film Manager example.
3169 2011-09-20 Ben Konrath <ben@bagu.org>
3171 Change the way sort clause is added for primary key when no sort clause is requested.
3173 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3174 before the sort clause is created. When a sort clause is not requested, the
3175 sort clause is created by finding the primary key in the LayoutFieldVector
3178 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3180 2011-09-20 Ben Konrath <ben@bagu.org>
3182 Log error message if no documents are found in the configured directory.
3184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3185 Extract the glom file extension string to a private static final class
3186 variable (mostly as syntactic sugar). Accept a minor formatting change.
3187 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3188 the example glom.document.directory configuration property to make it
3189 more clear that it can any directory, not just the home directory.
3191 2011-09-18 Ben Konrath <ben@bagu.org>
3193 Add related lists to details view.
3195 The related list table has support for paging and sorting just like the
3196 table in the list view.
3198 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3199 SQL queries for the related list tables.
3200 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3201 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3203 Rename getList methods to getListView and add comments. Remove
3204 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3205 it being unused. Add methods: getDetailsLayoutAndData(),
3206 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3207 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3208 Create the layout and set the data for the fields in one async call
3209 instead of two. Create related lists where appropriate.
3210 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3211 for method name changes in OnlineGlomService.
3212 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3213 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3214 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3216 * src/main/java/org/glom/web/client/ui/ListView.java:
3217 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3218 tableName from setCellTable(). Create a ListViewTable instead of
3220 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3221 represent a data field in the details view.
3222 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3223 from addDetailsCell() to Field class. Keep track of the Fields and
3224 Portals in the details view.
3225 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3226 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3227 and add a method to get it. Add method to set the contents of the
3229 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3230 New class for related list tables. This class has the data provider
3231 for the related list table.
3232 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3233 abstract class which is the base class for the ListViewTable and the
3235 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3236 New class for list view tables. This class has the data provider for
3237 the list view table.
3238 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3239 methods for related list tables. Add more information to the
3240 LayoutItemField and LayoutItemPortal DTOs.
3241 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3242 Remove debugging print statement.
3243 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3244 Remove debugging print statements. Add primary key field to SQL count
3246 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3247 Remove unnecessary LayoutFieldVector parameter from
3248 getResultSizeOfSQLQuery() method.
3249 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3250 New class for related list table database access.
3251 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3252 class that is a wrapper DTO for details view layout and data.
3253 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3254 new 'fromField' string to this DTO.
3255 * src/main/webapp/style.css: Remove bottom margin and override top
3258 2011-09-15 Ben Konrath <ben@bagu.org>