tests: Move a test that needs a database connection.
[online-glom:gwt-glom.git] / ChangeLog
1 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
2
3         tests: Move a test that needs a database connection.
4
5         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
6         Move testGetListViewLayoutGroup() to
7         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
8         because it needs a database connection.
9
10 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
11
12         tests: Use @BeforeClass on tearDown().
13
14         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
15         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
16         This avoids leaking a postgres process in SelfHostExampleTest.
17
18 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
19
20         tests: Test translations more.
21
22         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
23         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
24         Test titles in the non-default locale.
25
26 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
27
28         tests: Add SelfHostConfiguredDocumentTest
29  
30         * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the 
31         username and password, for use by ConfiguredDocument.
32         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java: 
33         This tests some of the ConfiguredDocument API that requires a database connection.
34
35 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
36
37         Document: Load title translations and test them.
38
39         * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
40         of titles. I am surprised that we do not do this yet.
41         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
42         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
43         Test translations more.
44
45 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
46
47         Set JDBC timeouts.
48
49         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
50         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
51         Set the timeout here too.
52
53 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
54
55         tests: ConfiguredDocumentTest: Make this pass.
56
57         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
58         Disable tests that need a database connection.
59
60 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
61
62         Use Java 1.7 instead of Java 1.6.
63
64         * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
65         to do this twice, at least for Eclipse.
66         This seems OK because it is the current version.
67
68 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
69
70         Some error checking.
71
72         * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
73         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
74         Avoid using a null Connection.
75
76 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
77
78         tests: Add a ConfiguredDocument test.
79
80         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
81         Add this test.
82
83 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
84
85         LayoutItemFIeld: getName(): Use the Field if it is set.
86
87         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
88         getName(): If the full field details have been set, return its name, so that
89         callers do not need to set the name separately.
90         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
91         testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
92         so we can count the rows.
93
94 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
95
96         tests: SelfHoster: Test SqlUtils too.
97
98         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
99         Retrieve some data and check it too, as in the regular Glom
100         test_selfhosting_new_from_example.cc test.
101         * src/test/java/org/glom/web/server/SelfHoster.java:
102         createConnection(): Make this public.
103
104 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
105
106         tests: SelfHoster: createConnection(): Do not warn about expected failures.
107         
108         Let the caller say if the connection is expected to fail, to avoid 
109         irrelevant error output.
110
111 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
112
113         tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
114         
115         * src/test/java/org/glom/web/server/SelfHoster.java:
116         createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
117         due to the inevitable need to retry the connection while the database server
118         starts.
119
120 2012-07-20  Murray Cumming  <murrayc@murray.com>
121
122         tests: SelfHoster: createConnection(): Set a timeout.
123
124         * src/test/java/org/glom/web/server/SelfHoster.java:
125         createConnection(): Use setLoginTimeout() because it otherwise seems to take
126         ages to actually return when it fails.
127
128 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
129
130         tests: SelfHoster: selfHost(): Close the test connection.
131
132         * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
133         When we check that the connection works, close the connection. This seems
134         to not be closed automatically otherwise.
135
136 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
137
138         Use slf4j-simple to see JDBC errors.
139
140         * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
141
142 2012-07-19  Murray Cumming  <murrayc@murrayc.com>
143
144         SelfHoster.discoverFirstFreePort(): Close the socket.
145
146         * src/test/java/org/glom/web/server/SelfHoster.java:
147         discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
148
149 2012-07-19  Murray Cumming  <murrayc@murrayc.com>
150
151         Avoid another code warning in Eclipse Juno.
152
153         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
154         Do instanceof checks on the FileUtils.listFiles() result and its 
155         items.
156
157 2012-07-13  Murray Cumming  <murrayc@murrayc.com>
158
159         Avoid some code warnings in Eclipse Juno
160
161         * src/main/java/org/glom/web/server/libglom/Document.java:
162         getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
163         * src/test/java/org/glom/web/server/SelfHoster.java
164         createTextFile(): Make sure that the FileOutputStream is closed.
165
166 2012-06-22  Murray Cumming  <murrayc@murrayc.com>
167
168         Added OnlineGlomPropertiesTest.
169
170         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
171         Make sure we never return a null string.
172         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
173         Added tests of the OnlineGlomProperties API, using our sample file.
174
175 2012-06-20  Murray Cumming  <murrayc@murrayc.com>
176
177         Make OnlineGlomProperties be a normal class.
178
179         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
180         Move OnlineGlomProperties into its own file to be a regular class:
181         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
182         This makes testing simpler.
183
184 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
185
186         OnlineGlomServiceImpl.init(): Move some code into a new method.
187
188         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
189         Create addDocument().
190
191 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
192
193         OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
194
195         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
196         OnlineGlomProperties.getKey(): Make this more robust by moving the
197         check for *.*.filename to here.
198
199 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
200
201         OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
202
203         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
204         init(): Move knowledge of the config file format into the 
205         OnlineGlomProperties inner class.
206
207 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
208
209         SelfHostExampleTest: Make sure we cleanup on failure.
210
211         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
212         the use of cleanup() to a tearDown() JUnit method.
213
214 2012-06-12  Murray Cumming  <murrayc@murrayc.com>
215
216         ConfiguredDocument: Add a primary key to portals at least once.
217
218         * src/main/java/org/glom/web/server/ConfiguredDocument.java
219         updatePortalsExtras): Fix a typo so that we add the primary key
220         column at least once.
221         This is a fix for the previous commit:
222         ConfiguredDocument: Do not add a primary key to portals each time.
223
224 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
225
226         SelfHoster: Avoid some compiler warnings.
227
228         * src/test/java/org/glom/web/server/SelfHoster.java
229         executeCommandLineAndWait():
230         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
231         the now-unused streams for stdout and stderr from the command Processes.
232         These are not used because readln() hangs while waiting for a new line,
233         where there may be no next line. The commented out code is still there
234         to help us figure out how to do this properly.
235
236 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
237
238         LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
239
240         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
241         Make this actually test the cloning again, though it is not very useful
242         now that we do not use the part that had a problem with cloning before.
243
244 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
245
246         SelfHoster: Keep trying pg_ctl after starting postgres.
247
248         * src/test/java/org/glom/web/server/SelfHoster.java
249         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
250         Try pg_ctl repeatedly (for ever) until it succeeds, as we do in 
251         regular Glom. This seems mad but it seems to work because the first
252         command would fail if pg_ctl would eventually fail.
253
254 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
255
256         SelfHoster: Wait until the server is really ready.
257
258         * src/test/java/org/glom/web/server/SelfHoster.java
259         selfHost(): Attempt the connection after starting the server, retrying 
260         a few times if necessary, so that the server is really ready already when
261         we return from this method.
262         The regular Glom code does this too because pg_ctl reports success too soon.
263
264 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
265
266         ConfiguredDocument: Do not add a primary key to portals each time.
267
268         * src/main/java/org/glom/web/server/ConfiguredDocument.java
269         updatePortalsExtras(): Only add an extra primary key field if there is 
270         none, to avoid adding one each time we retrieve the details layout from the
271         layouts cache.
272         This should fix bug #676986 (Ben Konrath) 
273
274 2012-05-25  Murray Cumming  <murrayc@murrayc.com>
275
276         Document.load(): Support version 7 documents. 
277
278         * src/main/java/org/glom/web/server/libglom/Document.java: Load the 
279         database_title attribute if the title attribute is not there.
280         Bug #676737
281
282 2012-05-24  Ben Konrath  <ben@bagu.org>
283
284         Add configuration for auto-generating mvn:i18n from with Eclipse.
285
286         * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
287
288 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
289
290         Update translations, adding French.
291
292         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
293         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
294         Add a French translation, using the translation from Glom.
295
296         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
297         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
298         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
299         Update these based on the translations from Glom.
300
301 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
302
303         SelfHoster: Add some debug println messages to help when things fail.
304
305         * src/test/java/org/glom/web/server/SelfHoster.java: Add several
306         System.out.println() lines.
307
308 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
309
310         Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
311
312         * src/test/java/org/glom/web/server/SelfHoster.java:
313         getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for 
314         instance) instead of just /usr/bin (as on Fedora). Check the result when 
315         using this method.
316
317 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
318
319         Remove LayoutItemPortal.get/setNavigationTable().
320         
321         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
322         Remove get/setNavigationTable(), which is only a cache, because it is not
323         used, and does not need to be used, because that decision should be made on
324         the server.
325         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
326         updatePortalsExtras():
327         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
328         getNavigationRecord():
329         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
330         Adapted.
331
332 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
333
334         Initial self-hosting for tests.
335
336         * pom.xml: Change the scope for log4j, to hopefully make it 
337         available to the test code which uses it indirectly via jOOQ.
338         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
339         self-hosting, though we only use it for testing.
340
341         * src/main/java/org/glom/web/server/libglom/Document.java:
342         example rows: Use a map instead of a list for each row of values,
343         so we know what field they are for, instead of relying on the sequence
344         being correct. This is not very efficient, but it does not really need 
345         to be.
346         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
347         testReadTableExampleRows(): Adapted.
348
349         * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
350         that returns an Object, for generic use. Note that Object seems to be 
351         the implicit base even of double.
352         * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
353         for use in CREATE TABLE SQL queries.
354         * src/test/java/org/glom/web/server/SelfHoster.java: Add this class 
355         to do self-hosting of PostgreSQL databases via its command-line 
356         utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
357         backends/postgres_self.cc. This is incomplete - it needs more 
358         warnings about failures and it needs to clean up properly when things
359         fail.
360         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple 
361         test of this new class.
362
363 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
364
365         Document: loading example data: Handle exceptions.
366
367         * src/main/java/org/glom/web/server/libglom/Document.java:
368         DateFormat.parse() and Double.valueOf() can throw exceptions, though
369         Eclipse did not warn about that.
370
371 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
372
373         Document: load(), save(): Handle the example rows.
374
375         * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate() 
376         and get/setImage().
377         * src/main/java/org/glom/web/server/libglom/Document.java:
378         load(), save(): Load and save the example rows, though the date, time
379         and image types are not handled properly yet.
380         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
381         Add testReadTableExampleRows() just to check that something is read.
382
383 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
384
385         Document: Add save().
386
387         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
388         Added getTranslationsMap() for use while saving.
389         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
390         Adedd getUseDefaultFormatting() for use while saving.
391         * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
392         and several private methods that it uses.
393
394         This will be useful while testing via self-hosting.
395         It is not complete, but should be complete enough for testing.
396
397 2012-05-17  Murray Cumming  <murrayc@murrayc.com>
398
399         OnlineGlomService: Simplify the getList/RelatedViewData() methods.
400
401         * src/main/java/org/glom/web/client/OnlineGlomService.java
402         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
403         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
404         Remove getSortedListViewData() and getSortedRelatedListData(), adding
405         the sort column index and ascending bool to the regular method.
406         Instead, a sort column index of -1 now means no sort.
407         This is less explicit, but it's fairly simple, reduces the amount of 
408         code, and makes the OnlineGlomService API slightly smaller.
409         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
410         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
411         getDataProvider():
412         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
413         getListViewData(), getRelatedListData():
414         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
415         getListViewData(), getRelatedListData():
416         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
417         getListData():
418         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
419         getData():
420         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
421         getData(): Adapted.
422
423 1.21.9.2:
424
425 2012-05-16  Murray Cumming  <murrayc@murrayc.com>
426
427         Use translations for top-level groups too.
428
429         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
430         updateTitlesForLocale(): Use the translation for the group 
431         as well as for child items.
432
433 1.21.9.1:
434
435 Just recompiled to fix a problem in the released .tar.gz file.
436
437 1.21.9:
438
439 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
440
441         Corrections to navigation to related records.
442         
443         * src/main/java/org/glom/web/client/OnlineGlomService.java:
444         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
445         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
446         getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
447         getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a 
448         relationship name, because the relationship name is not necessarily unique 
449         on the layout.
450         TOOD: This is inefficient, because it passes the whole list of 
451         child field items back to the server, but it is more correct, and happens
452         to fix a bug with the primary key being lost after a few navigations.
453         There is probably a chance to make this more efficient anyway in some 
454         more basic way.
455         
456         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
457         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
458         * src/main/java/org/glom/web/server/ConfiguredDocument.java
459         * src/main/java/org/glom/web/server/database/DBAccess.java
460         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
461         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
462         Adapted.
463
464 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
465
466         Fix the use of translations.
467
468         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
469         Add updateTitlesForLocale().
470         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
471         Call it to discard unwanted translations and to make getTitle() return
472         the wanted translation wihout the need for the client code to specify a locale.
473         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
474         getTitle(): Fallback to the original title, as libglom does.
475
476 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
477
478         Document: Correctly report the number of available translation locales.
479
480         * src/main/java/org/glom/web/server/libglom/Document.java: Fill
481         the available locale IDs list.
482         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
483         testLocales: Test this.
484
485 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
486
487         SqlUtils: Use camelCase.
488
489         * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
490         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
491         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
492         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
493         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
494         * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
495
496 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
497
498         Use jOOQ's tableByName() and fieldByName.
499
500         * pom.xml: Use jOOQ 2.3.1 to get the new API.
501         * src/main/java/org/glom/web/server/SqlUtils.java:
502         build_sql_select_step_with_where_clause(), .createField(),
503         builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
504         so we can get correct quoting and escaping. Thanks to Lukas Eder for 
505         adding this, and other things, to jOOQ.
506
507 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
508
509         SqlUtils: Remove the Connection parameters.
510
511         * src/main/java/org/glom/web/server/SqlUtils.java:
512         build_sql_select_with_key(), build_sql_select_with_where_clause(),
513         createSelect(), build_sql_select_step_with_where_clause(),
514         build_sql_count_select_with_where_clause(),
515         build_sql_select_count_rows(): Remove the Connection parameter because
516         jOOQ does not actually need a connectionwhen it is just used to build 
517         a SQL string:
518         https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
519
520         * src/main/java/org/glom/web/server/ReportGenerator.java:
521         generateReport():
522         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
523         getData():
524         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
525         Constructor, getListData(), getResultSizeOfSQLQuery():
526         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
527         getSelectQuery(), getCountQuery():
528         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
529         getSelectQuery(), getCountQuery():
530         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
531         getNavigationRecord(): Adapted.
532
533 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
534
535         Fix quick find.
536
537         * src/main/java/org/glom/web/server/SqlUtils.java:
538         get_find_where_clause_quick(): Use a comparison of 
539         lowercase values, instead of a simple equals. Regular Glom
540         uses the PostgreSQL ILIKE operator but jOOQ does not 
541         support that just yet, though it will soon.
542
543 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
544
545         TableToViewDetails: Use a real serialization ID.
546
547         * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
548         Though this does not fix the serialization problem.
549
550 2012-05-12  Murray Cumming  <murrayc@murrayc.com>
551
552         Added LayoutItemPortalDeepCloneTest.
553
554 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
555
556         Make navigation work again.
557
558         * src/main/java/org/glom/web/server/libglom/Document.java:
559         Add getLayoutItemFieldShouldHaveNavigation().
560         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
561         Replace get/setAddNavigation() with the partly-existing 
562         get/setNavigationTableName(), with an empty string being no navigation,
563         because this is simpler. Use the new 
564         Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
565         
566         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
567         Add updateFieldsExtras() and call setNavigationTableName in it.
568         getDetailsLayoutGroup(), 
569         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
570         createLayout(): Adapted.
571         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
572         Constructor: Adapted.
573
574         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
575         Replace get/setAddNavigation() with get/setNavigation(), returning a
576         TableToViewDetails class with both the table name and UsesRelationship,
577         because both are need. The previous code used java-libglom's output 
578         variable (strangely, via sharedptr) to return both, but we cannot really
579         do that in Java.
580         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
581         getNavigationRecord(): Adapt. However, we cannot actually use the cache
582         here because it somehow gets set to null during deepCopy(). I must test this.
583         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
584         testGetSuitableTableToViewDetails(): Adapted.
585         
586         TODO: Find out why deepClone() is not quite working.
587         
588 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
589
590         DBAccess: Simplify the retrievel of full field details.
591
592         * src/main/java/org/glom/web/server/database/DBAccess.java
593         getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
594         because the Document loading should have done this.
595
596 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
597
598         Document: Correct loading of doubly-related layout fields.
599
600         * src/main/java/org/glom/web/server/libglom/Document.java:
601         loadUsesRelationship(): Actually set the related relationship, instead
602         of only setting it if it's not found.
603
604 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
605
606         Replace all appearances of Colour with color.
607
608         Because US English is dominant.
609
610 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
611
612         Use colors in HTML format, solving a warning about an unused function.
613
614         * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
615         * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
616         Add *asHTMLColor() versions of methods.
617         TODO: However, we should create and cache the results on the server.
618         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
619         * src/main/java/org/glom/web/client/ui/list/ListTable.java
620         * src/main/java/org/glom/web/server/ConfiguredDocument.java
621         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
622         Use the asHTMLcolor() versions.
623
624 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
625
626         ListViewTable: Constructor: Take the table name as a parameter.
627
628         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
629         Constructor: Take the tableName, and set the member variable, because
630         we use it here.
631         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
632         setCellTable(): Pass the table name.
633         This makes navigation to non-default tables work again. I don't know 
634         why it worked before in the master branch.
635
636 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
637
638         ConfiguredDocument: Restore correct addition of hidden primary key items.
639
640         * src/main/java/org/glom/web/client/ui/list/ListTable.java
641         (ListTable.createCellTable): Uncomment out the check for the hidden
642         primary key.
643         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
644         add primary key items for top-level lists and portals, as before, 
645         instead of adding them to each group.
646         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
647         Actually implement the extra methods such as setHiddenPrimaryKey() and
648         comment that these are used only for top-level list groups and in portals.
649         This strangeness suggests even more that this should not be squeezed
650         into the LayoutGroup class.
651
652 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
653
654         Fix Formatting loading.
655
656         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
657         getFormattingUsed(): Remove the duplicate Formatting member variable
658         in favour of the one from the base class.
659         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
660         Initialize a new Formatting instead of using null by default, so we 
661         have some defaults, instead of having to initialize one later just to 
662         get the same defaults. This also makes loading of formatting from the
663         document work, because that expected a non-null.
664
665 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
666
667         RelatedListTable: Make sure that the tableName is set.
668
669         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
670         Constructor: Take the tableName so it is available later. Otherwise, 
671         the server assumes that we mean the default table and cannot find the
672         relationship in it.
673         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
674         setData(): Pass the tableName to the RelatedListTable constructor.
675
676 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
677
678         Add some checks.
679
680         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
681         RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
682         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
683         getDataProvider():
684         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
685         addColumn():
686         * src/main/java/org/glom/web/server/database/DBAccess.java:
687         convertResultSetToDTO(), getPortal():
688         * src/main/java/org/glom/web/server/database/ListDBAccess.java
689         getListData():
690         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
691         Add checks for null objects and out of range access, with log messages to
692         give hints so we can fix these properly.
693
694 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
695
696         Portals: some corrections.
697
698         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
699         setData():
700         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
701         constructor: Use getRelationshipNameUsed() instead of getName(), because
702         that is what is meant.
703         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
704         getFromField(): Fix a typo, to get the field name, not the table name.
705         * src/main/java/org/glom/web/server/database/DBAccess.java:
706         getPortal(): Fix a typo that stopped this from working.
707
708 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
709
710         LayoutItemPortal: Also override getTitleOriginal().
711
712         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
713         This lets the base getTitle() with no parameters work.
714         TODO: Test this properly.
715
716 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
717
718         LayoutItemPortal: getTitle*(): Use the relationship title.
719
720 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
721
722         LayoutItemField: Fix loading of custom titles.
723
724         * src/main/java/org/glom/web/server/libglom/Document.java
725         loadDataLayoutItemField(): The title, if any, instead of the field 
726         title, is stored in a title_custom node. Load it from there.
727         * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
728         class.
729         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
730         Add getCustomTitle() and use it, instead of super.getTitle*(), in the
731         getTitle*() overrides.
732         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
733         Adapt.
734
735 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
736
737         LayoutItemField: Fall back to field titles, so some are really shown.
738
739         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
740         Override getTitleOriginal() and getTitle(), as in java-libglom.
741         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
742         Test this behaviour.
743
744 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
745
746         Correct use of setExpectedResultSize().
747
748         * src/main/java/org/glom/web/server/ConfiguredDocument.java
749         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
750         Use setExpectedResultSize only on top-level groups (for instance, the
751         list layout) or on child portals (in details views).
752         Use the correct table name for portals to avoid SQL errors.
753         Update the expected counts when returning cached layouts.
754
755 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
756
757         Document: Interpret no group column count as 1.
758
759         * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
760         default, though we now check for this in the UI code anyway.
761
762 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
763
764         More null checks.
765
766 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
767
768         Translatable: Use Hashmap instead of Treemap because GWT supports it.
769
770         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
771         The use of Treemap lead to this error from async methods, with no 
772         further clue:
773         "The response could not be deserialized"
774
775 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
776
777         OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
778
779         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary 
780         when using the Google -> GWT Compile, or 
781         g toolbar button -> GWT Compile Project... feature in Eclipse.
782
783 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
784
785         ListTable.addColumn(): Protect against a null Formatting.
786
787         * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
788         Create a default Formatting if it is null, because that is the simplest
789         way to do this.
790
791 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
792
793         ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
794
795         * src/main/java/org/glom/web/server/ConfiguredDocument.java
796         updateLayoutGroup(): Check that the field is not null.
797
798 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
799
800         ListViewImpl: Protected against a bad cast error.
801
802         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
803         onEnterKeyDown(): Do not cast without an instanceof check.
804
805 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
806
807         ListTable: Protect against an out of range error.
808
809         * src/main/java/org/glom/web/client/ui/list/ListTable.java
810         createCellTable(): This is unlikely, but can happen while debugging.
811
812 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
813
814         AsyncMessage onFailure() callbacks: Log the exception message.
815
816         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
817         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
818         * src/main/java/org/glom/web/client/activity/ListActivity.java:
819         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
820         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
821         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
822         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
823         These are useful clues when something is wrong.
824
825 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
826
827         ConfiguredDocument: Avoid a null dereference.
828
829         * src/main/java/org/glom/web/server/ConfiguredDocument.java
830         TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and 
831         details maps are created.
832
833 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
834
835         Document: Correct the port number parsing.
836
837         * src/main/java/org/glom/web/server/libglom/Document.java:
838         This lets us actually connect to the database and show the document.
839
840 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
841
842         Fix mvn gwt:test
843
844         * pom.xml: Use htmlunit mode for gwt:test, because the default demands
845         user-interaction, asking us to load a temporary URL in a browser.s
846         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
847         which is apparently necessary for testing the service. See the comment.
848         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java: 
849         Show the exception, if any. This is how I saw the 404 in the HTML in 
850         the exception.
851
852 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
853
854         DocumentTest: Move the .glom files into the resources directory.
855
856         * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
857         URI via getResource().
858
859 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
860
861         Document: Remove the FieldIdentifies inner class.
862
863         * src/main/java/org/glom/web/server/libglom/Document.java: We only
864         use the Relationship (though the same function in libglom is maybe
865         used in other ways) and so this removes a compiler warning.
866
867 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
868
869         Document.load() Remove the error code parameter.
870
871         * src/main/java/org/glom/web/server/libglom/Document.java: load():
872         Remove the parameter. We do not set it yet and it could never have
873         worked as an output parameter (though maybe it did in java-libglom).
874         We could use an exception if we really want the failure reason.
875         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
876         init():
877         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
878         setUp(), testGetSuitableTableToViewDetails(): Adapt.
879
880 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
881
882         Make some inner classes static.
883
884         * src/main/java/org/glom/web/server/ConfiguredDocument.java
885         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
886         * src/main/java/org/glom/web/server/ReportGenerator.java
887         * src/main/java/org/glom/web/server/libglom/Document.java
888         Make all inner classes static that can be static.
889
890 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
891
892         OnlineGlomServiceImpl: Do not load and check for java-libglom.
893
894         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
895         init(): We do not use java-libglom any more.
896
897 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
898
899         Remove mentions of java-libglom.
900
901         * README: Remove mention of java-libglom, because it no longer needed.
902         * utils/build-onlineglom-war.sh:
903         * utils/check-and-recover-tomcat.py:
904         * utils/install-onlineglom-war.sh: Remove these as they are no longer
905         useful. Building is now far easier, with no need for jhbuild.
906
907 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
908
909         Fix the build (mvn package)
910
911         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
912         (LayoutGroup): Make the LayoutItemList inner class static and protected.
913         Otherwise the GWT Java->Javascript compilation fails with just this
914         error, during mvn package or when attempting to view in a browser, 
915         in the GWT developer mode in Eclipse.
916
917         [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
918         [INFO] auto discovered modules [org.glom.web.OnlineGlom]
919         [INFO] Compiling module org.glom.web.OnlineGlom
920         [INFO]    [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
921         [INFO]       [ERROR] Line 46:  Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
922         [INFO]    Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
923         [INFO]       [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
924         [INFO]          [WARN] org.glom.web.client.OnlineGlomService_Proxy
925         [INFO]    [ERROR] Cannot proceed due to previous errors
926
927         It has taken me 2 days to find out what was causing that. After reducing
928         the code, the compiler eventually showed me the full error message.
929
930 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
931
932         ConfiguredDocument: Cache the cloned and stripped layouts.
933
934         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
935         getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
936         layout in a map, so we can retrieve it again without rebuilding it.
937
938 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
939
940         UsesRelationshipImpl: Complete the relationshipEquals() implementation.
941
942 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
943
944         libglom classes: Implement some auto-generated emthods.
945
946 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
947
948         Add GwtTestOnlineGlomService.
949
950         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
951         However, this (and the other GwtTest*) does not seem to run during 
952         mvn test. 
953
954 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
955
956         Remove use of unsupported features from client code.
957
958         * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
959         * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
960         * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
961         Use our client version of StringUtils instead of the apache commons one.
962         
963         However, the GWT Javascript compliation still fails.
964
965 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
966
967         Add a Field class and implement some loading of it in Document.
968
969 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
970
971         Initial Document loading implementation, instead of libglom.
972
973         * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
974         and Translatable classes, and adapt the rest of the code to use them.
975         However, this is still missing Layout and Field classes and loading.
976
977 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
978
979         Use of jOOQ: Move Field creation into a utility method.
980
981         * src/main/java/org/glom/web/server/SqlUtils.java:
982         This lets us improve it more easily.
983
984 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
985
986         Use of jOOQ: Improve the code to COUNT a sub-select.
987
988         * src/main/java/org/glom/web/server/SqlUtils.java:
989         Move initial query creation into 
990         build_sql_select_step_with_where_clause().
991         build_sql_select_count_rows(): Use the jOOQ API instead of
992         concatentating text, because a jOOQ Select*Step is a TableLike,
993         which is what from() takes.
994
995 2012-04-23  Murray Cumming  <murrayc@murrayc.com>
996
997         Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
998
999         * pom.xml: Depend on jooq.
1000         * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1001         methods with jOOQ, based on the C++ implementations in libglom,
1002         with some changes to the logic required by jooQ.
1003         Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1004         where clause.
1005         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1006         * src/main/java/org/glom/web/server/ReportGenerator.java:
1007         * src/main/java/org/glom/web/server/SqlUtils.java:
1008         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1009         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1010         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1011         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1012         * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1013         Adapt. In particular, the SqlUtils methods now need to take a Connection,
1014         because jOOQ needs that, though it seems unnecessary.
1015
1016         This is not quite finished. Ideally jOOQ would help us to build 
1017         table_name.field_name names, quoting and escaping them properly.
1018         See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1019
1020 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1021
1022         Move use of Glom.build_sql*() into a new SqlUtils class.
1023
1024         * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1025         to wrap Glom.build_sql*(). The parameter types are still Glom one,
1026         but this will make it easier to start using something other than 
1027         libglom or SqlBuilder.
1028
1029 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1030
1031         Update the project URL.
1032
1033         * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1034
1035 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1036
1037         Main layout: Use a FlowTable instead of absolute positioning.
1038
1039         * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1040         The RootLayoutPanel is a (extends) AbsolutePanel, so each of its 
1041         child panels/widgets must have an absolute position. But that is annoying, so
1042         this adds a FlowTable and puts the child panels in there.
1043
1044 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1045
1046         GwtTestOnlineGlom: Comment out unused code.
1047
1048         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1049         Eclipse has started to say that some code is unused.
1050
1051 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1052
1053         Update to the latest versions of dependencies.
1054
1055         * pom.xml: Update version numbers of dependencies to the latest
1056         versions.
1057         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1058         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1059         * src/main/java/org/glom/web/server/ReportGenerator.java:
1060         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1061         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1062         * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1063         java:
1064         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1065         Modify the imports where necessary.
1066
1067 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1068
1069         Style: Remove overflow:hidden from searchbox
1070
1071         * src/main/webapp/style.css: Because this pushes the Back To Link
1072         label/link on to the next row, which is then hidden due to the 
1073         hard-coded (in ems) height.
1074
1075 2012-04-20  Murray Cumming  <murrayc@murrayc.com>
1076
1077         Remove some duplicate code.
1078
1079         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1080         getDocumentInfo(): This must have been duplicated during the merge from the
1081         reports branch.
1082
1083 1.21.8.1:
1084
1085 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1086
1087         Reports: Localize the waiting for report message.
1088
1089         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1090         start(): Get the message from the contants.
1091         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1092         Add the string here.
1093         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1094         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1095         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1096         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1097         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1098         Update these files with the English text for newer strings for now.
1099
1100 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1101
1102         Reports: Show a message while waiting for the report.
1103
1104         * src/main/java/org/glom/web/client/ui/ReportView.java
1105         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1106         Add setWaitingText(), to show a message saying that we are 
1107         waiting for the report to be ready.
1108         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1109         start(): Call setWaitingText() before calling the async
1110         report generation.
1111
1112 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1113
1114         ReportGenerator: Specify date and time formats.
1115
1116         * src/main/java/org/glom/web/server/ReportGenerator.java:
1117         createFieldValueElement(): Use the default (and localized)
1118         short formats, though we still need a way to show 4-digit
1119         years without providing the format for every locale.
1120         * src/main/java/org/glom/web/server/database/DBAccess.java:
1121         convertResultSetToDTO(): Use the short formats here too.
1122
1123 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1124
1125         ReportGenerator: Use the correct numeric formatting.
1126
1127         * src/main/java/org/glom/web/server/ReportGenerator.java
1128         createFieldExpression(), createFieldValueElement(): Take the
1129         whole LayoutItem_Field instead of just the field name, so
1130         we have access to the formatting.
1131         createFieldValueElement(): Use JRTextField.setPattern() to
1132         specify the numeric formatting, with the help of a 
1133         regular DecimalFormat.
1134
1135 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1136
1137         ReportGenerator: Avoid showing null for group by titles.
1138
1139         * src/main/java/org/glom/web/server/ReportGenerator.java
1140         generateReport(): Use setBlankWhenNull() on the field title
1141         style too, because this is used for values in group by
1142         sections.
1143
1144 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1145
1146         ReportGenerator: Add a colon to titles in vertical groups.
1147
1148         * src/main/java/org/glom/web/server/ReportGenerator.java
1149         addFieldToDetailBandVertical(): Pass true for the withColon
1150         parameter.
1151
1152 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1153
1154         ReportGenerator: Simplify the code by using Position more.
1155
1156 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1157
1158         Reports: Support vertical groups, roughly.
1159
1160         * src/main/java/org/glom/web/server/ReportGenerator.java:
1161         addToReport(): Rename to addGroupToReport() and, if necessary,
1162         call the new addVerticalGroupToReport() method.
1163         createFieldValueElement(): Let the caller specify the Y position
1164         too.
1165
1166 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1167
1168         Reports: Allow a second report to be shown.
1169
1170         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1171         clear(): Do not remove the HTML widget, which broke the whole layout.
1172
1173 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1174
1175         Locales drop-down: Show that we use English by default.
1176
1177         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1178         fillView(): When we use English, just because that is the default, when
1179         no locale is specified, show that in the Locales drop-down instead of 
1180         just showing the first item.
1181
1182 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1183
1184         Unselect the Report/Locale/Table combo item when appropriate.
1185
1186         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1187         setPlace(): clear reportName if this is not a ReportPlace.
1188         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1189         setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1190         When the provided name is empty, unselect all items, so that none are
1191         indicated. This uses a for loop because I cannot find a single method
1192         to do this.
1193
1194 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1195
1196         Report: Give the user a way to get back to the list.
1197
1198         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1199         start(), setPlace(): Show the Back To List link on reports, and also 
1200         interpret selecting the empty report item as back to list.
1201
1202 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1203
1204         Really show the selected Report name.
1205
1206         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1207         setPlace(): Store the reportName here, if it is that kind of Place.
1208         fillView(): Set the selected Report after filling the list of reports.
1209         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1210         setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1211         null Strings, though we need some way to unselect all ListBox items
1212         in that case.
1213
1214 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1215
1216         ReportGenerator: Try to avoid some problems.
1217
1218         * src/main/java/org/glom/web/server/ReportGenerator.java
1219         addField(): Try to avoid duplicates, and avoid using a null
1220         class type.
1221
1222 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1223
1224         Reports: Use quickFind.
1225
1226         * src/main/java/org/glom/web/client/OnlineGlomService.java;
1227         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1228         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1229         getReportHTML(): Add a quickFind parameter.
1230         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1231         start(): Pass the quickFind parameter.
1232         * src/main/java/org/glom/web/server/ReportGenerator.java
1233         generateReport(): Take a quickFind parameter.
1234
1235 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1236
1237         ReportPlace: Actually use the report name.
1238
1239         * src/main/java/org/glom/web/client/place/ReportPlace.java
1240         getPlace(): Do not assign the report name to the quickfind.
1241
1242 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1243
1244         Show java.library.path when complaining.
1245
1246         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1247         init(): When telling us to check java.library.path, show the
1248         current value.
1249
1250 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1251
1252         ReportGenerator: Do not show nulls.
1253
1254 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1255
1256         ReportGenerator: Make the title font larger.
1257
1258 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1259
1260         ReportGenerator: Put field titles inside groups, if there are groups.
1261
1262 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1263
1264         ReportGenerator: Take the Report itself instead of the name and group.
1265
1266         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1267         Remove getReportLayoutGroup().
1268         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1269         getReportHTML(): Pass the report instead
1270         of its name and layout group.
1271         * src/main/java/org/glom/web/server/ReportGenerator.java
1272         generateReport(): Use the report object to use the title 
1273         instead of the name.
1274
1275 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1276
1277         ReportGenerator: Remove designBand parameters.
1278
1279         * src/main/java/org/glom/web/server/ReportGenerator.java:
1280         Make designBand a class member instead of passing it to all
1281         methods.
1282
1283 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1284
1285         ReportGenerator: Add lines, a bit like in the desktop version.
1286
1287         * src/main/java/org/glom/web/server/ReportGenerator.java
1288         addToReport(): Use JRDesignLine.
1289
1290 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1291
1292         ReportGenerator: Correct the title positions and use some bold style.
1293
1294         * src/main/java/org/glom/web/server/ReportGenerator.java:
1295         Break the code up into reusable functions, correct the placement of 
1296         titles, and use normal/bold styles as in the reports in the desktop 
1297         version.
1298
1299 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1300
1301         ReportGenerator: Add a header band to show the field titles.
1302
1303         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1304         getReportHTML(): Pass the localeId to the ReportGenerator 
1305         constructor.
1306         * src/main/java/org/glom/web/server/ReportGenerator.java
1307         constructor: Take the localeID so we can get translated field
1308         titles.
1309         generateReport(), addToReport(), addFieldToBand(): Add field 
1310         titles in a column header band.
1311
1312 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1313
1314         Reports drop-down list: Some improvement.
1315
1316         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1317         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1318         Adedd setSelectedReport(),
1319         setReportList(): Add a blank line so that the user can select the 
1320         first one.
1321         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1322         start(): Show the current report by calling setSelectedReport().
1323         This does not seem to work yet.
1324
1325 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1326
1327         DetailsActivity, ListActivity: Move some variables into a base class.
1328
1329         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1330         * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1331         * src/main/java/org/glom/web/client/activity/ListActivity.java: Move 
1332         the clientFactory, documentID, tableName and authenticationPopup into
1333         a base class, to avoid duplication.
1334
1335 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1336
1337         Translate the Reports label.
1338
1339         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1340         Get the "Reports" label string from the constants.
1341         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1342         perties: Add Reports to the constants.
1343
1344 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1345
1346         Reports: Implement grouping.
1347
1348         * src/main/java/org/glom/web/server/ReportGenerator.java:
1349         Handle LayoutItem_GroupBy items and try to do the right thing
1350         with JRDesignGroup. It seems to work.
1351
1352 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1353
1354         Actually show some data with JasperReports.
1355
1356         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: 
1357         getReportHTML(): Move most code into a ReportGenerator class.
1358         * src/main/java/org/glom/web/server/ReportGenerator.java:
1359         Recurse into sub-groups, adding fields to the JasperDesign's details
1360         band. Note that we must set an arbitrary width and height, or it just
1361         will not show any data.
1362
1363 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1364
1365         Reports Chooser: Show the titles, not the names.
1366
1367         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1368         (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1369         and the names as the values.
1370         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1371         (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1372         group now that we provide the report name, so it should always 
1373         succeed.
1374
1375 2012-02-15  Murray Cumming  <murrayc@murrayc.com>
1376
1377         Depend on jasperreports.
1378
1379         * pom.xml: Add the dependency. My plan is to use this on the 
1380         server side.
1381
1382 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1383
1384         Implement navigation to report places.
1385
1386         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1387         start(): Do not bother to handle all events here.
1388         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1389         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1390         Added getSelectedReport().
1391         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1392         .java: start(): When handling a change to the reports chooser,
1393         call getSelectedReport() and goTo() its ReportPlace.
1394         * src/main/java/org/glom/web/client/ui/ReportView.java
1395         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1396         Added setReportHTML() which puts the html in a gwt HTML widget.
1397         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1398         getReportHTML(): Return "TODO" just to show that this works.
1399
1400 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1401
1402         Make ReportPlace usable.
1403
1404         * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1405         Mention ReportPlace.
1406         * src/main/java/org/glom/web/client/place/ReportPlace.java:
1407         Correct the @prefix annotation.
1408
1409 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1410
1411         OnlineGlomService: Return report HTML rather than the LayoutGroup.
1412
1413         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1414         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1415         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1416         Change getReportLayout() to getReportHMTL() because we will not need to 
1417         parse or render the report layout on the client side.
1418         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1419         getReportLayout(): Return the libglom LayoutGroup type because we will
1420         not need to convert to a shared type, because this will not be used on
1421         the client side.
1422         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1423         Adapted.
1424
1425         Note that there is still no implementation for this.
1426
1427
1428 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1429
1430         Add a (empty) Report Place, View, and Activity.
1431
1432         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1433         Rename to:
1434         * src/main/java/org/glom/web/client/place/HasTablePlace.java
1435         * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1436         this into a superclass:
1437         * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1438         and also use it as the base of this new ReportPlace:
1439         * src/main/java/org/glom/web/client/place/ReportPlace.java
1440
1441         * src/main/java/org/glom/web/client/ui/ReportView.java
1442         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1443         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1444         Add these, containing mostly boiler-plate for now.
1445
1446         * src/main/java/org/glom/web/client/OnlineGlomService.java
1447         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1448         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1449         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1450         Add API to get the LayoutGroup for the report.
1451
1452 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1453
1454         Add and fill a Reports drop-down list box.
1455
1456         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1457         Aded getReports():
1458         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1459         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1460         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1461         Added getReports(document, table, localeID), calling 
1462         ConfiguredDocument.getReports().
1463         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1464         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1465         Added setReportsList() and a list widget.
1466         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1467         .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1468
1469
1470 1.21.8:
1471
1472 2012-04-12  Murray Cumming  <murrayc@murrayc.com>
1473
1474         Translations: Add Esperanto.
1475
1476         * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1477         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1478         properties: Add this translation because someone took the time to make it.
1479
1480 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1481
1482         Adapt to the java-libglom 1.21.7 API. 
1483
1484         * src/main/java/org/glom/web/server/ReportGenerator.java:
1485         addToReport(): get_group_secondary_fields() is now
1486         get_secondary_fields().
1487
1488
1489 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1490
1491         Use the latest java-libglom version.
1492
1493         * pom.xml: Use java-libglom 1.21.7.
1494
1495 2012-03-03  Ben Konrath  <ben@bagu.org>
1496
1497         Display date and time in details view.
1498
1499         https://bugzilla.gnome.org/show_bug.cgi?id=671257
1500
1501         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1502
1503 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1504
1505         Require the latest java-libglom.
1506
1507         * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1508
1509 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1510
1511         ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1512
1513         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1514         ListViewDBAccess.getSelectQuery(): Do not create a where clause for 
1515         an empty quickfind string. I also corrected libglom to create only 
1516         empty where clauses for empty quickfind strings, but this avoids the
1517         need for that fix.
1518
1519 2012-02-24  Ben Konrath  <ben@bagu.org>
1520
1521         Improve the tabs in the Notebook widget.
1522
1523         Bug #670728
1524
1525 2012-01-30  Murray Cumming  <murrayc@murrayc.com>
1526
1527         Translations: Try to translate the strings.
1528
1529         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1530         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1531         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1532         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1533         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1534         Take the Open translation from GTK+'s .po files.
1535         Take the Details translation from Glom's po files.
1536         I have added the other strings to Glom so we can get translations that way:
1537         http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1538
1539 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1540
1541         TableSelectionViewImpl: Put the search label and entry in a div.
1542
1543         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1544         Put the search widgets in a FlowTable so that the CSS can be used to
1545         style them while keeping them together.
1546         * src/main/webapp/style.css: Mention the new div.
1547
1548 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1549
1550         Translate more strings in more locales.
1551
1552         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1553         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1554         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1555         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1556         Translate the "Details" and "Open" string too.
1557
1558         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1559         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1560         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1561         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1562         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1563         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1564         Add these new locales as placeholders though they currently contain English.
1565
1566 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1567
1568         OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1569
1570         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1571         Check the ConfiguredDocument* for null before using it.
1572
1573 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1574
1575         Tell Eclipse about the generated java files.
1576
1577         * .classpath: This lets it find OnlineGlomConstants.java.
1578         It would be nice if Eclipse just used the maven build files.
1579
1580 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1581
1582         Prevent a crash when no locale is specified in the URL.
1583
1584         * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1585         Avoid returning a null string, obtained from 
1586         Window.Location.getParameter(). This caused a crash when it was
1587         later passed to libglom's API.
1588         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1589         init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1590         getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1591         guard against future null strings.
1592
1593 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1594
1595         Use the ?locale= query param instead of the &lang= token param. 
1596
1597         * src/main/java/org/glom/web/client/place/ListPlace.java
1598         * src/main/java/org/glom/web/client/place/DetailsPlace.java
1599         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1600         Remove the lang token key and value.
1601         
1602         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1603         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1604         When the user selects a different locale from the chooser, use 
1605         Window.Location.assign() to change the URL, which then causes a reload.
1606         
1607         * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1608         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1609         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1610         * src/main/java/org/glom/web/client/activity/ListActivity.java
1611         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1612         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1613         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1614         * src/main/java/org/glom/web/client/ui/ListView.java:
1615         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1616
1617         Remove localeID member variables and method/constructor parameters, instead
1618         using Utils.getCurrentLocaleID() when we need a localID to pass to 
1619         OnlineGlomService.
1620
1621 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1622
1623         Internationalize the UI strings.
1624
1625         * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a 
1626         <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1627         * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1628         because it is unused. Messages are apparently strings that can have 
1629         parameters, but we do not need that yet, so Contants will be enough for now.
1630         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1631         to say that we support the en and de locales.
1632         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1633         The original English strings.
1634         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1635         Some German translations of the English strings.
1636         The i18n goal then uses the .properties file to generate an 
1637         OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1638         returns an implementation that returns the translated strings.
1639         The documentation suggests putting these in src/java/*/client/, but it seems
1640         best to put it in src/resources/*/client/.
1641         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1642         Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1643         instead of hard-coding them.
1644         Note that we cannot import OnlineGlomConstants because it does not exist yet,
1645         but that does not seem to stop the build, though it confuses Eclipse.
1646         
1647         You can see the translated string by adding ?locale=de to the URL, like so:
1648         http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1649
1650 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1651
1652         Improve null/empty String checks. 
1653
1654         * pom.xml: Add a dependency on commons-lang, to use
1655         org.apache.commons.lang.StringUtils.
1656         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1657         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1658         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1659         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1660         Use StringUtils.isEmpty().
1661
1662         * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1663         StringUtils class with a static isEmpty() function because we 
1664         cannot use org.apache.commons.lang.StringUtils in client-side
1665         GWT code because it (apparently) cannot be compiled to javascript.
1666         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1667         * src/main/java/org/glom/web/client/activity/ListActivity.java
1668         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1669         * src/main/java/org/glom/web/client/place/DetailsPlace.java
1670         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1671         * src/main/java/org/glom/web/client/place/ListPlace.java
1672         * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1673         * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1674         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1675         * src/main/java/org/glom/web/client/ui/details/Group.java
1676         * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use 
1677         our StringUtils.isEmpty() function.
1678
1679 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1680
1681         Update to the latest java-libglom API.
1682
1683         * pom.xml: Require java-libglom 1.21.4.
1684         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1685         getDocumentInfo(), getListViewLayoutGroup():
1686         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1687         getDocuments():
1688         * src/main/java/org/glom/web/server/database/DBAccess.java
1689         getFieldsToShowForSQLQueryAddGroup(),
1690         getPrimaryKeyLayoutItemField(): Replace get_database_title()
1691         with either get_database_title_original() or 
1692         get_database_title(localeID).
1693
1694 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1695
1696         ConfiguredDocument: Avoid a null pointer exception.
1697
1698         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1699         Initialize localeID to "" to avoid returning a null String which 
1700         causes a crash in java-libglom's swing-generated code.
1701
1702 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1703
1704         Some simple renaming.
1705
1706         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1707         * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1708         for localeChooser. This seems more appropriate and is less ambiguous 
1709         particularly in the .css file.
1710
1711 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1712
1713         ConfiguredDocument: Rename the localedID private member variable.
1714
1715 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1716
1717         Adapt to the latest java-libglom API from git master.
1718
1719         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1720         libglom now uses only Vector instead of List, which uses add() instead of
1721         addLast(). 
1722
1723 2012-01-22  Murray Cumming  <murrayc@murrayc.com>
1724
1725         ConfiguredDocument: Rename the localedID private member variable.
1726
1727 2012-01-20  Murray Cumming  <murrayc@murrayc.com>
1728
1729         Build a source tarball with mvn assembly:single
1730
1731         * assembly.xml: Add this file.
1732         * pom.xml: Use the maven-assembly-plugin and tell it to use 
1733         our assembly.xml file.
1734
1735 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
1736
1737         OnlineGlomServiceImpl: Get .glom files recursively.
1738
1739         * pom.xml: Depend on commons-io from org.apache.commons.
1740         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1741         init(): Use org.apache.commons.io.FileUtils.listFiles() to get the 
1742         files recursively, and with the easier filter for the extension.
1743         Use org.apache.commons.io.FilenameUtils.removeExtension() to 
1744         simplify that code too.
1745
1746 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
1747
1748         README: Mention that you must install java-libglom packages separately.
1749
1750         But then it works, because java-libglom is now in the central maven 
1751         repository.
1752
1753 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1754
1755         locales drop-down: Show the correct selected locale when the URL changes.
1756
1757         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1758         .java: setPlace(): Move some code into fillView().
1759
1760 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1761
1762         locales drop-down: Do not lose the primary key.
1763
1764         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1765         start(): onLocaleChange(): Pass the current primary key value, 
1766         instead of an empty value.
1767
1768 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1769
1770         locales drop-down: Do not lose the drop-down selection.
1771
1772         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1773         .java (TableSelectionActivity.fillView): Set the selected locale
1774         after changing the drop-down items (though we do not really need
1775         to change them just because the locale changes.)
1776
1777 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1778
1779         locales drop-down: Change the tables list when this changes.
1780
1781         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1782         .java: TableSelectionActivity.start(): Move the async table titles
1783         retrieval into a private fillView() method and also call this when 
1784         the chosen locale changes.
1785         Note that the document title is not actually translatable yet, but
1786         that is a problem that I should fix soon in libglom.
1787
1788 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1789
1790         Improve the placement of the locales drop-down.
1791
1792         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1793         Put the title and locales drop-down in a div (gwt.FlowTable).
1794         * src/main/webapp/style.css: Add magic css properties to make this work.
1795         Also remove the left margin from the title so that it lines up with the 
1796         headerbox below it.
1797
1798 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1799
1800         locales selector: Show human-readable locale titles.
1801
1802         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1803         getDocumentInfo(): Use java.util.Locale to show a real title of 
1804         each locale, in the locale's own language.
1805
1806 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1807
1808         Add a language/locale selector drop-down.
1809
1810         * src/main/java/org/glom/web/shared/DocumentInfo.java:
1811         Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1812         * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1813         getDocumentInfo(): Store the available Locales in the DocumentInfo.
1814         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1815         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1816         Add a ListBox to show the available locales. Add getLocaleSelector(),
1817         setLocaleList(), getSelectedLocale(), setSelectedLocale().
1818         * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1819         * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1820         java: Add these classes.
1821         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1822         start(): Fill the locales ListBox. Handle its change event, firing a 
1823         LocaleChangeEvent.
1824         setPlace(): Show the selected locale as specified by the URL token.
1825         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1826         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1827         Handle LocaleChangeEvent, going to a new *Place with that locale.
1828
1829         The placement of the ListBox is not pretty, and it currently uses the ID
1830         as a title, instead of "English", "Deutsch", "Espanola", etc, but it 
1831         is a start.
1832
1833
1834 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1835
1836         Search box: Show the search text from the URL token.
1837
1838         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1839         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1840         Add setQuickFindText().
1841         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1842         .java: setPlace(): Store the queryText if the place is a ListPlace, 
1843         and call TableSelectionView.setQuickFindText().
1844
1845 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1846
1847         Allow use of translations via, for instance, &lang=de in the URL.
1848
1849         * pom.xml: Use the unstable java-libglom 1.21 version.
1850
1851         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1852         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1853         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1854         init(): Instead of calling TranslatableItem.set_current_locale() 
1855         (now removed), call ConfiguredDocument.setDefaultLocaleID().
1856         However, this is only for default locales, which are not needed to 
1857         change the locale in the URL.
1858         getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1859         getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1860         getSortedRelatedListData(): Add a localeID parameter, so we can get the 
1861         layout for a particular locale.
1862         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1863         Add get/setDefaultLocaleID().
1864         getDocumentInfo(), getListViewData(), getRelatedListData(),
1865         getDetailsLayoutGroup(), getListViewLayoutGroup(),
1866         createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a 
1867         localeID parameter, so we can get the layout for a particular locale.
1868
1869         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1870         * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1871         * src/main/java/org/glom/web/client/place/ListPlace.java:
1872         Parse and construct a lang parameter too.
1873
1874         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1875         start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1876         passed to subsequent methods and constructors.
1877         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1878         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1879         Store the localeID from the *Place and pass it to other constructors
1880         and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1881
1882         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1883         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1884         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1885         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1886         * src/main/java/org/glom/web/client/ui/ListView.java:
1887         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1888         Take localeID parameters and pass them to subsequent constructors and 
1889         methods, so that the layout is always retrieved for that locale.
1890
1891         This is rather repetitive.
1892
1893         Note that "" means the original (default) locale of the Glom document,
1894         which is usually English.       
1895
1896 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1897
1898         Documents: Remove final keyword to fix startup configuration.
1899
1900         * src/main/java/org/glom/web/shared/Documents.java: Remove the
1901         final keywords on the private member variables because that breaks
1902         the startup, apparently (there are warnings) because it stops them
1903         from being serialized. I added these in the previous commit.
1904
1905 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
1906
1907         Documents: Add some final keywords.
1908
1909         * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1910         this.
1911
1912 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
1913
1914         OnlineGlomServiceImpl: Add to overview comments.
1915
1916         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1917         Note that this is where all the document are loaded. They are not 
1918         loaded freshly for each page.
1919
1920 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
1921
1922         Add a search box.
1923
1924         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1925         Add a TextBox for the text of a quick find.
1926         Add getQuickFindBox(), to get the widget, and getQuickFindText() to 
1927         get the text.
1928         setBackLink(): Add a String quickFind parameter.
1929         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1930         (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1931         to the base interface, because that is how TableSelectionViewImpl is used.
1932         * src/main/webapp/style.css: Add style for the search box and its label.
1933
1934         * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1935         * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1936         Add these files, based on the existing TableChangeEvent and 
1937         TableChangeEventHandlers.
1938         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1939         start(): Handle QuickFindChangeEvent, passing its quickFind text to
1940         a ListPlace() that the user should be taken to.
1941         * src/main/java/org/glom/web/client/activity/ListActivity.java
1942         start(): Handle it here too and adapt the TableChangeEvent handler to 
1943         pass the extra "" quickFind parameter to ListPlace.
1944         * src/main/java/org/glom/web/client/place/ListPlace.java: 
1945         Constructor: Take an extra String quickFind parameter and store it, 
1946         returning it from a new  getQuickFind() method.
1947         getToken(): Put the quickFind text in the URL token.
1948         getPlace(): Parse the quickFind text from the URL token.
1949         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1950         va: addDocumentLink(): Pass an extra "" quickFind parameter to the 
1951         ListPlace constructor.
1952         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1953         .java: start(): Add a Change handler for the TableSelectionView's
1954         TextBox (via its base HasChangeHandlers interface), firing the new 
1955         QuickFindChangeEvent.
1956         setPlace(): Adapt the call to TableSelectionView.setbackLink(), to 
1957         pass the extra "" quickFind parameter.
1958
1959         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1960         setCellTable(): Add a String quickFind parameter and pass it to 
1961         the ListViewTable() constructor.
1962         * src/main/java/org/glom/web/client/ui/ListView.java: Change 
1963         setCellTable() in the base interface, because that is how ListViewImpl
1964         is used.
1965
1966         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1967         Add a String quickFind member variable.
1968         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1969         Constructor: Add a String quickFind parameter, storing it in the
1970         base ListTable's member variable.
1971         onRangeChanged(): Pass quickFind to the 
1972         OnlineGlomServiceAsync.getSortedListViewData() and 
1973         OnlineGlomServiceAsync.getListViewData() methods.
1974
1975         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1976         getListViewData(), getSortedListViewData(): Add a String quickFind 
1977         parameter, passing it to ConfiguredDocument.getListViewData().
1978         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1979         Change getListViewData(), getSortedListViewData() in the base interface,
1980         because that is how OnlineGlomServiceImpl is used, via this:
1981         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1982         Change getListViewData(), getSortedListViewData() here too.
1983         This class can apparently be used to asynchronously call methods on 
1984         OnlineGlomService, and GWT seems to implement that after recognizing 
1985         just the *Async name convention and the extra AsyncCallback parameters.
1986
1987         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1988         getListViewData(): Add a String quickFind parameter, and pass it to 
1989         ListViewDBAccess.getData().
1990         * src/main/java/org/glom/web/server/database/ListDBAccess.java
1991         getListData(): Add a String quickFind parameter and pass it to 
1992         getSelectQuery().
1993         getSelectQuery(): Add a String quickFind parameter.
1994         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1995         getSelectQuery(): Add a String quickFind parameter and use it with 
1996         Glom.get_find_where_clause_quick() to pass a where_clause to 
1997         Glom.build_sql_select_with_where_clause(), to actually filter the 
1998         list view results.
1999         getData(): Add a String quickFind parameter, passing it to getListData().
2000         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2001         va: getData(): Pass an empty string to getListData() for the 
2002         quickFind parameter.
2003
2004 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2005
2006         ListTable: Minor change.
2007
2008         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2009         createCellTable(): Make this protected instead of public.
2010
2011 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2012
2013         Many files: Use final for the parameters and use the @override attribute.
2014
2015 2012-01-22  Ben Konrath <ben@bagu.org>
2016
2017         Add anchor links for single line text that starts with http, ftp and www.
2018
2019         Bug #667269
2020
2021 2012-01-22  Ben Konrath <ben@bagu.org>
2022
2023         Add ellipsis to single line text in details view.
2024
2025         Bug #667269
2026
2027 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
2028
2029         Remove all javadoc author tags.
2030
2031         Because they are awkward and meaningless when many people touch
2032         many files.
2033         See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2034  
2035 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
2036
2037         Revert the COPYING.LESSER to COPYING rename.
2038
2039         Apparently both should be there if it is LGPL.
2040
2041 2012-01-03  Murray Cumming  <murrayc@murrayc.com>
2042
2043         *View: Remove unused imports.
2044
2045         * src/main/java/org/glom/web/client/ui/DetailsView.java:
2046         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2047         * src/main/java/org/glom/web/client/ui/ListView.java:
2048         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2049         Remove unused imports, as suggested by Eclipse.
2050
2051 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2052
2053         Move the *View::Presenter types, and some API into one base View.
2054
2055         * src/main/java/org/glom/web/client/ui/DetailsView.java:
2056         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2057         * src/main/java/org/glom/web/client/ui/ListView.java:
2058         * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2059         Presenter, setPresenter() and clear() into a shared base interface,
2060         to avoid the unnecessary duplicate Presenter types and to more clearly
2061         show how the *Views share the same structure, even if they are not 
2062         used polymorphically.
2063
2064         * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2065         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2066         va:
2067         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2068         * src/main/java/org/glom/web/client/activity/ListActivity.java:
2069         * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2070         ity.java:
2071         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2072         .java: Adapt.
2073
2074         Feel free to revert this if there is a good reason for the duplicate
2075         types.
2076
2077 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2078
2079         OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2080
2081         * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2082         a class member instead of a local variable in the method.
2083         This lets us use it to get the view instances, for use in tests.
2084         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2085         beforeOnlineGlom(): Test some more details of the initial view.
2086         Again, this is not very useful.
2087
2088         To really test gwt-glom we will need to start a local postgresql 
2089         instance with local data, like the Glom tests in C++.
2090
2091 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2092
2093         pom.xml: Mention the LGPL license.
2094
2095         * pom.xml: Add a licenses section.
2096         * COPYING.LESSER: Move this to COPYING, which
2097         previously contained the GPL. But gwt-glom is all LGPL.
2098
2099 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2100
2101         Add project information to README and pom.xml.
2102
2103         * README: Add a brief description and mention some mvn
2104         commands.
2105         * pom.xml: This extra information shows up in mvn site
2106         generated pages.
2107
2108 2011-01-02  Murray Cumming  <murrayc@murrayc.com>
2109
2110         Use the latest java-libglom version.
2111
2112         * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2113
2114 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2115
2116         GwtTestOnlineGlom: Test a little more.
2117
2118         * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2119         protected rather than private, as suggested by the gwt-test-utils
2120         maintianer here:
2121         http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2122         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2123         Test the initial visibility of the panels.
2124
2125         However, this is not a very useful test.
2126         And I wonder how we should generally test using this idea for an
2127         activity/places app like ours where the real changes happen implicitly
2128         based on the history token/URL.
2129
2130 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2131
2132         Slight modification to *Mapper comments.
2133
2134         * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2135         (DataActivityMapper)
2136         * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2137         pper.java
2138         * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2139         r.java
2140         Remove comments mentioning GIN because they are just copied from 
2141         the example code and are apparently not helpful:
2142         http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2143         Also change the mention of a class that is only in the example code.
2144
2145 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2146
2147         GwtTestOnlineGlom test: Minor changes.
2148
2149         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2150         Avoid the long qualified class name and modify the comment 
2151         because it is now obvious to me that the mocked class is the only
2152         custom one created via GWT.create().
2153
2154 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2155
2156         Tests: Added the beginnings of a test using gwt-test-utils.
2157
2158         * pom.xml: Add dependencies on gwt-test-utils and easymock.
2159         * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2160         which tells gwt-test-utils what class will be tested.
2161         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2162         Add a simple (but empty) test case. One class, used by the OnlineGlom
2163         class, is mocked so that it can be created. However, I am not sure 
2164         why only this class needs to be mocked.
2165
2166         Note that mockito seems more popular, and clearer, than easymock,
2167         but I have not got that working yet. It might be a matter of the 
2168         mockito version.
2169
2170         This test is run during mvn integration-test.
2171
2172 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2173
2174         Tests: Use junit4-style syntax instead of junit3-style.
2175
2176         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2177         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2178         * src/test/java/org/glom/web/shared/DataItemTest.java:
2179         Use the @Test annotation rather than relying on the test*() prefix.
2180         Also no longer implement TestCase, to avoid triggering support for 
2181         the junit3-way, which stops the annotations from working.
2182         Change the imports from import junit.framework.* to 
2183         import org.junit.*, which is apparently the new way.
2184
2185 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2186
2187         Added a test for ListPlace token parsing and creation.
2188
2189         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2190         This is much the same as DetailsPlaceTest.
2191
2192         I wonder how we could test the other parts of the *Place API.
2193
2194 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2195
2196         DetailsPlace test: Also test getToken() and recreation via getPlace().
2197
2198         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2199         testGetPlaceParameters(): Get the tokens from the DetailsPlace and 
2200         recreate it, testing the recreated DetailsPlace for the same parameter
2201         values.
2202
2203 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2204
2205         Use the surefire-report plugin.
2206
2207         * pom.xml: This generates a HTML report about the tests in 
2208         target/site/surefire-report.html
2209         when you do mvn surefire-report:report. It seems to be popular/normal.
2210
2211 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2212
2213         Added a test for DetailsPlace.
2214
2215         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2216         Test the getPlace() token parsing.
2217
2218 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2219
2220         Added a first unit test.
2221
2222         * pom.xml: Add a test goal, and a dependency on junit in that scope.
2223         * src/test/java/org/glom/web/shared/DataItemTest.java:
2224         This is a silly test but it is just to get things started. Note that
2225         maven/junit finds the test because it looks in src/test by default.
2226
2227 2011-12-22  Ben Konrath  <ben@bagu.org>
2228
2229         Change charsetName to "UTF-8" when replacing line breaks.
2230
2231         JavaScript requires the charsetName to be "UTF-8". CharsetName values
2232         that work in Java (such as "UTF8") will not work when compiled to
2233         JavaScript.
2234
2235         This fixes a problem with multi-line details view fields that have hard
2236         line breaks. The "License Text" field on this page demonstrates the
2237         problem:
2238
2239         http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2240
2241         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2242
2243 2011-12-22  Ben Konrath  <ben@bagu.org>
2244
2245         Fix another bug with related list navigation.
2246
2247         I've tested all the navigation buttons in all of the related lists
2248         so things should be good now.
2249
2250         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2251
2252 2011-12-22  Ben Konrath  <ben@bagu.org>
2253
2254         Fix a crasher when refreshing the list view with the default table.
2255
2256         This crash will also happen when loading the list view with the default
2257         table from a link or bookmark.
2258
2259         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2260         to the main document selection page when the document id hasn't been
2261         set.
2262         * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2263         the main document selection page when the document id hasn't been
2264         set.
2265         * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2266         values for the details place when the document id hasn't been set.
2267         * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2268         values for the list place when the document id hasn't been set.
2269
2270 2011-12-21  Ben Konrath  <ben@bagu.org>
2271
2272         Protect against NPE when glom.document.locale is not in config.
2273
2274         This patch protects against an NPE when glom.document.locale is not in
2275         the config file. This NPE will also happen if glom.document.locale is
2276         commented out.
2277
2278         The patch also updates the error message to display the class name when
2279         the getMessage() returns null. This was happening when the NPE was
2280         thrown and I had "Configuration Error: null". If an NPE is encountered
2281         with this patch, "Configuration Error: NullPointerException " will be
2282         displayed.
2283
2284         This commit closes this bug:
2285
2286         https://bugzilla.gnome.org/show_bug.cgi?id=666669
2287
2288         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2289
2290 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2291
2292         Rename onlineglom.properties to onlineglom.properties.sample.
2293
2294         * src/main/resources/onlineglom.properties: Rename to:
2295         * src/main/resources/onlineglom.properties.sample:
2296         * src/main/resources/README: And add this file explaining that people
2297         should rename it back when deploying.
2298
2299 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2300
2301         Allow choosing the translation in the .properties file.
2302
2303         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2304         init(): Read a glom.document.locale value from the configuration file 
2305         and call Glom's TransatableItem::set_current_locale() method.
2306         * src/main/resources/onlineglom.properties: Add a commented-out 
2307         example of this new setting.
2308
2309         It would be better to add &lang=de_DE to the URL, but the current 
2310         libglom API does not allow us to do this easily. I am working on that.
2311
2312 2011-12-19  Murray Cumming  <murrayc@murrayc.com>
2313
2314         Avoid a crash in parsing of token parameters.
2315
2316         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2317         ava: getTokenParams(): Do not crash if a parameter has a key but no 
2318         value, and ignore parameters with neither.
2319
2320 2011-12-17  Murray Cumming  <murrayc@murayc.com>
2321
2322         History token building/handling: Improve use of token parameters.
2323
2324         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java 
2325         (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2326         and buildParamsToken(HashMap), for use by derived classes.
2327         Make the separator private because it is no longer be needed.
2328         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2329         (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2330         instead of manual string concatenation.
2331         (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2332         of hardcoded indices and awkward splitting code.
2333         * src/main/java/org/glom/web/client/place/ListPlace.java
2334         (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2335         instead of manual string concatenation.
2336         (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2337         of hardcoded indices and awkward splitting code.
2338         This should fix bug #666420
2339
2340 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2341
2342         Fix a Navgiation->Navigation typo in the code.
2343
2344         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2345         Rename processNavgiation() to processNavigation().
2346
2347 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2348
2349         Fix a seperator->separator typo in the code.
2350
2351         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2352         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2353         * src/main/java/org/glom/web/client/place/ListPlace.java: Just a 
2354         misspelling.
2355
2356 2011-12-15  Ben Konrath <ben@bagu.org>
2357
2358         Cleanup some comments.
2359
2360         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2361
2362 2011-12-14  Ben Konrath <ben@bagu.org>
2363
2364         Replace \n with <br/> for multiline text in the details view.
2365
2366         Vertical scrollbars are added when needed as well.
2367
2368         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2369
2370 2011-12-14  Ben Konrath <ben@bagu.org>
2371
2372         Specify the font for document selection links.
2373
2374         * src/main/webapp/style.css:
2375
2376 2011-12-14  Ben Konrath <ben@bagu.org>
2377
2378         Fix bouncy CellTable while paging.
2379
2380         This doesn't currently work with related list tables in unselected
2381         Notebook tabs.
2382
2383         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2384
2385 2011-12-14  Ben Konrath <ben@bagu.org>
2386
2387         Revamp the appearance of the document selection page.
2388
2389         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2390         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2391         * src/main/webapp/style.css:
2392
2393 2011-12-13  Ben Konrath <ben@bagu.org>
2394
2395         Set navigation button column to the smallest size possible.
2396
2397         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2398
2399 2011-12-13  Ben Konrath <ben@bagu.org>
2400
2401         Change OpenButton nomenclature to NavigationButton.
2402
2403         Using NavigtionButton makes things more generic. Classes, methods and
2404         variables have been changed.
2405
2406         This is a rename-only refactor.
2407
2408         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2409         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2410         * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2411         Renamed from OpenButtonCell.
2412         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2413         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2414         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2415
2416 2011-12-12  Ben Konrath <ben@bagu.org>
2417
2418         Remove unnecessary String argument in RelatedListTable and ListViewTable.
2419
2420         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2421         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2422         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2423         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2424
2425 2011-12-12  Ben Konrath <ben@bagu.org>
2426
2427         Update variable names and comments.
2428
2429         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2430         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2431
2432 2011-12-12  Ben Konrath <ben@bagu.org>
2433
2434         Properly initialize numNonEmptyRows variable to zero.
2435
2436         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2437         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2438
2439 2011-12-05  Ben Konrath  <ben@bagu.org>
2440
2441         Add latest mockup with HTML tables.
2442
2443         Features of this mockup:
2444
2445         -> HTML table for flowtable
2446         -> HTML table for flowtable column
2447         -> Example of how related lists would look
2448         -> Not using text entries for data items
2449
2450         The current version of Online Glom doesn't use HTML tables for the
2451         flowtable columns.
2452
2453         This mockup has been sent to the glom-devel mailing list but it's good
2454         to have it here as well.
2455
2456         * mockups/details-view-html-tables.html:
2457
2458 2011-12-05  Ben Konrath  <ben@bagu.org>
2459
2460         Remove unnecessary getPrimaryKeyField() method.
2461
2462         getPrimaryKeyFieldForTable(String) has been renamed to
2463         getPrimaryKeyField(String).
2464
2465         * src/main/java/org/glom/web/server/database/DBAccess.java:
2466         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2467         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2468
2469 2011-12-05  Ben Konrath  <ben@bagu.org>
2470
2471         Add string representation of TypedDataItem value to conversion error message.
2472
2473         * src/main/java/org/glom/web/server/Utils.java: Logging the error
2474         message was extracted into its own method to avoid duplication.
2475
2476 2011-12-05  Ben Konrath  <ben@bagu.org>
2477
2478         Add type checking to navigation primary key value creation.
2479
2480         Create navigation primary key only if the expected type from the Glom
2481         document matches the type returned by the SQL query.
2482
2483         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2484
2485 2011-12-05  Ben Konrath  <ben@bagu.org>
2486
2487         Rename a couple of variables in RelatedListNavigation.
2488
2489         This is a rename-only refactor.
2490
2491         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2492
2493 2011-12-05  Ben Konrath  <ben@bagu.org>
2494
2495         Move getListLayoutGroup() into getListViewLayoutGroup().
2496
2497         This removes getListLayoutGroup(). It was only being called by
2498         getListViewLayoutGroup().
2499
2500         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2501
2502 2011-12-05  Ben Konrath  <ben@bagu.org>
2503
2504         Remove check for LayoutItem_Portal in list table method.
2505
2506         This check is no longer necessary because the method isn't being used
2507         to create the LayoutItemPortal DTO.
2508
2509         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2510
2511 2011-12-05  Ben Konrath  <ben@bagu.org>
2512
2513         Properly support related list navigation.
2514
2515         Navigation from the "Repository Analyzer -> Package Scans ->
2516         Dependencies" related table wasn't working because the primary key for
2517         related tables wasn't being set properly. This commit fixes the
2518         problem.
2519
2520         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2521         getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2522         doesn't set the primary key properly for related list tables.
2523         * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2524         name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2525         useful for getting the primary key for list view tables and for related
2526         list tables.
2527         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2528         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2529         Move code to set the primary key for the table from the abstract
2530         ListDBAccess class to ListViewDBAccess as it's only correct for list
2531         view tables.
2532         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2533         Properly add primary key to related list tables.
2534
2535 2011-12-02  Ben Konrath  <ben@bagu.org>
2536
2537         Properly set the horizontal alignment of fields.
2538
2539         This fix is for both the list tables and the details view.
2540
2541         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2542         LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2543         to set the horizontal alignment of fields.
2544
2545 2011-12-02  Ben Konrath  <ben@bagu.org>
2546
2547         Display currency codes in the details view.
2548
2549         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2550
2551 2011-12-02  Ben Konrath  <ben@bagu.org>
2552
2553         Avoid duplicate JNI call.
2554
2555         JNI is not as efficient as pure Java and this is an easy (and small)
2556         optimization.
2557
2558         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2559         Use previously retrieved value for whereClauseToTableName instead of
2560         getting it again.
2561
2562 2011-12-02  Ben Konrath  <ben@bagu.org>
2563
2564         Rename a couple of variables in RelatedListNavigation.
2565
2566         This is a rename-only refactor.
2567
2568         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2569
2570 2011-12-02  Ben Konrath  <ben@bagu.org>
2571
2572         Indicate clearly that a mismatched primary key type is a bug.
2573
2574         * src/main/java/org/glom/web/server/Utils.java: Change log level from
2575         warning to error. Add 'This is a bug.' to message.
2576
2577 2011-12-02  Ben Konrath  <ben@bagu.org>
2578
2579         Update / fix some comments.
2580
2581         * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2582         comments.
2583         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2584         comment.
2585         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2586         Fix comments. Add some TODOs.
2587
2588 2011-12-02  Ben Konrath  <ben@bagu.org>
2589
2590         Enable navigation to details view with string primary key from related list.
2591
2592         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2593         Create a text primary key value when return type of result is
2594         java.sql.Types.VARCHAR.
2595
2596 2011-12-02  Ben Konrath  <ben@bagu.org>
2597
2598         Use checkboxes for booleans in the details view.
2599
2600         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2601
2602 2011-12-01  Ben Konrath  <ben@bagu.org>
2603
2604         Improve performance of related list height calculation.
2605
2606         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2607         Put code to calculate the expected height in a static initializer so
2608         that that it's only called once.
2609
2610 2011-12-01  Ben Konrath  <ben@bagu.org>
2611
2612         Show related list tables in notebooks (again).
2613
2614         Calculate the height of the related list tables so the Notebook can be
2615         set the correct height. The height of the related list table is also needed by
2616         FlowTable to be able decide how to create the layout.
2617
2618         * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2619         and set the Portal height based on the height of the related list
2620         table and the Portal container.
2621         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2622         Add method to calculate the height of the related list tables.
2623         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2624         * src/main/webapp/style.css: Add css class for Pager. This is needed to
2625         calculate the height of the Pager widget.
2626
2627 2011-12-01  Ben Konrath  <ben@bagu.org>
2628
2629         Use CellTable API for table property instead of setting style on Element.
2630
2631         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2632
2633 2011-12-01  Ben Konrath  <ben@bagu.org>
2634
2635         Make ListViewTable and RelatedListTable a consistent height.
2636
2637         The tables are now a consistent height regardless of the contents of
2638         the table. A hidden button is added to empty rows to ensure that the
2639         height of these rows will match the height of rows with data.
2640
2641         A navigation button column is now added to every table. The width of
2642         the navigation column is set to 0px when a RelatedListTable shouldn't
2643         have navigation buttons. This maintains the a consistent row height in
2644         tables that don't show the navigation buttons.
2645
2646         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2647         navigation column when not needed.
2648         * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2649         arguments for navigation button to constructor of ListViewTable.
2650         * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2651         hidden button for empty data rows.
2652         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2653         arguments for navigation button to constructor.
2654         * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2655         create navigation buttons. Add hideNavigationButtons() method.
2656         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2657         arguments for navigation button to constructor.
2658
2659 2011-12-01  Ben Konrath  <ben@bagu.org>
2660
2661         Use 'visibility: hidden' in Utils.getWidgetHeight().
2662
2663         This is better choice because hidden elements are invisible, don't
2664         respond to events and are not part of the tab order. They will,
2665         however, 
2666