1 2012-06-12 Murray Cumming <murrayc@murrayc.com>
3 ConfiguredDocument: Add a primary key to portals at least once.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java
6 updatePortalsExtras): Fix a typo so that we add the primary key
8 This is a fix for the previous commit:
9 ConfiguredDocument: Do not add a primary key to portals each time.
11 2012-06-08 Murray Cumming <murrayc@murrayc.com>
13 SelfHoster: Avoid some compiler warnings.
15 * src/test/java/org/glom/web/server/SelfHoster.java
16 executeCommandLineAndWait():
17 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
18 the now-unused streams for stdout and stderr from the command Processes.
19 These are not used because readln() hangs while waiting for a new line,
20 where there may be no next line. The commented out code is still there
21 to help us figure out how to do this properly.
23 2012-06-08 Murray Cumming <murrayc@murrayc.com>
25 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
27 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
28 Make this actually test the cloning again, though it is not very useful
29 now that we do not use the part that had a problem with cloning before.
31 2012-06-08 Murray Cumming <murrayc@murrayc.com>
33 SelfHoster: Keep trying pg_ctl after starting postgres.
35 * src/test/java/org/glom/web/server/SelfHoster.java
36 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
37 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
38 regular Glom. This seems mad but it seems to work because the first
39 command would fail if pg_ctl would eventually fail.
41 2012-06-08 Murray Cumming <murrayc@murrayc.com>
43 SelfHoster: Wait until the server is really ready.
45 * src/test/java/org/glom/web/server/SelfHoster.java
46 selfHost(): Attempt the connection after starting the server, retrying
47 a few times if necessary, so that the server is really ready already when
48 we return from this method.
49 The regular Glom code does this too because pg_ctl reports success too soon.
51 2012-06-08 Murray Cumming <murrayc@murrayc.com>
53 ConfiguredDocument: Do not add a primary key to portals each time.
55 * src/main/java/org/glom/web/server/ConfiguredDocument.java
56 updatePortalsExtras(): Only add an extra primary key field if there is
57 none, to avoid adding one each time we retrieve the details layout from the
59 This should fix bug #676986 (Ben Konrath)
61 2012-05-25 Murray Cumming <murrayc@murrayc.com>
63 Document.load(): Support version 7 documents.
65 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
66 database_title attribute if the title attribute is not there.
69 2012-05-24 Ben Konrath <ben@bagu.org>
71 Add configuration for auto-generating mvn:i18n from with Eclipse.
73 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
75 2012-05-24 Murray Cumming <murrayc@murrayc.com>
77 Update translations, adding French.
79 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
80 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
81 Add a French translation, using the translation from Glom.
83 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
84 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
85 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
86 Update these based on the translations from Glom.
88 2012-05-24 Murray Cumming <murrayc@murrayc.com>
90 SelfHoster: Add some debug println messages to help when things fail.
92 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
93 System.out.println() lines.
95 2012-05-23 Murray Cumming <murrayc@murrayc.com>
97 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
99 * src/test/java/org/glom/web/server/SelfHoster.java:
100 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
101 instance) instead of just /usr/bin (as on Fedora). Check the result when
104 2012-05-23 Murray Cumming <murrayc@murrayc.com>
106 Remove LayoutItemPortal.get/setNavigationTable().
108 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
109 Remove get/setNavigationTable(), which is only a cache, because it is not
110 used, and does not need to be used, because that decision should be made on
112 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
113 updatePortalsExtras():
114 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
115 getNavigationRecord():
116 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
119 2012-05-21 Murray Cumming <murrayc@murrayc.com>
121 Initial self-hosting for tests.
123 * pom.xml: Change the scope for log4j, to hopefully make it
124 available to the test code which uses it indirectly via jOOQ.
125 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
126 self-hosting, though we only use it for testing.
128 * src/main/java/org/glom/web/server/libglom/Document.java:
129 example rows: Use a map instead of a list for each row of values,
130 so we know what field they are for, instead of relying on the sequence
131 being correct. This is not very efficient, but it does not really need
133 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
134 testReadTableExampleRows(): Adapted.
136 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
137 that returns an Object, for generic use. Note that Object seems to be
138 the implicit base even of double.
139 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
140 for use in CREATE TABLE SQL queries.
141 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
142 to do self-hosting of PostgreSQL databases via its command-line
143 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
144 backends/postgres_self.cc. This is incomplete - it needs more
145 warnings about failures and it needs to clean up properly when things
147 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
148 test of this new class.
150 2012-05-21 Murray Cumming <murrayc@murrayc.com>
152 Document: loading example data: Handle exceptions.
154 * src/main/java/org/glom/web/server/libglom/Document.java:
155 DateFormat.parse() and Double.valueOf() can throw exceptions, though
156 Eclipse did not warn about that.
158 2012-05-20 Murray Cumming <murrayc@murrayc.com>
160 Document: load(), save(): Handle the example rows.
162 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
164 * src/main/java/org/glom/web/server/libglom/Document.java:
165 load(), save(): Load and save the example rows, though the date, time
166 and image types are not handled properly yet.
167 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
168 Add testReadTableExampleRows() just to check that something is read.
170 2012-05-20 Murray Cumming <murrayc@murrayc.com>
172 Document: Add save().
174 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
175 Added getTranslationsMap() for use while saving.
176 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
177 Adedd getUseDefaultFormatting() for use while saving.
178 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
179 and several private methods that it uses.
181 This will be useful while testing via self-hosting.
182 It is not complete, but should be complete enough for testing.
184 2012-05-17 Murray Cumming <murrayc@murrayc.com>
186 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
188 * src/main/java/org/glom/web/client/OnlineGlomService.java
189 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
191 Remove getSortedListViewData() and getSortedRelatedListData(), adding
192 the sort column index and ascending bool to the regular method.
193 Instead, a sort column index of -1 now means no sort.
194 This is less explicit, but it's fairly simple, reduces the amount of
195 code, and makes the OnlineGlomService API slightly smaller.
196 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
197 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
199 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
200 getListViewData(), getRelatedListData():
201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
202 getListViewData(), getRelatedListData():
203 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
205 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
207 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
212 2012-05-16 Murray Cumming <murrayc@murrayc.com>
214 Use translations for top-level groups too.
216 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
217 updateTitlesForLocale(): Use the translation for the group
218 as well as for child items.
222 Just recompiled to fix a problem in the released .tar.gz file.
226 2012-05-15 Murray Cumming <murrayc@murrayc.com>
228 Corrections to navigation to related records.
230 * src/main/java/org/glom/web/client/OnlineGlomService.java:
231 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
233 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
234 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
235 relationship name, because the relationship name is not necessarily unique
237 TOOD: This is inefficient, because it passes the whole list of
238 child field items back to the server, but it is more correct, and happens
239 to fix a bug with the primary key being lost after a few navigations.
240 There is probably a chance to make this more efficient anyway in some
243 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
244 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
245 * src/main/java/org/glom/web/server/ConfiguredDocument.java
246 * src/main/java/org/glom/web/server/database/DBAccess.java
247 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
248 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
251 2012-05-15 Murray Cumming <murrayc@murrayc.com>
253 Fix the use of translations.
255 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
256 Add updateTitlesForLocale().
257 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
258 Call it to discard unwanted translations and to make getTitle() return
259 the wanted translation wihout the need for the client code to specify a locale.
260 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
261 getTitle(): Fallback to the original title, as libglom does.
263 2012-05-15 Murray Cumming <murrayc@murrayc.com>
265 Document: Correctly report the number of available translation locales.
267 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
268 the available locale IDs list.
269 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
270 testLocales: Test this.
272 2012-05-15 Murray Cumming <murrayc@murrayc.com>
274 SqlUtils: Use camelCase.
276 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
277 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
278 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
279 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
280 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
281 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
283 2012-05-15 Murray Cumming <murrayc@murrayc.com>
285 Use jOOQ's tableByName() and fieldByName.
287 * pom.xml: Use jOOQ 2.3.1 to get the new API.
288 * src/main/java/org/glom/web/server/SqlUtils.java:
289 build_sql_select_step_with_where_clause(), .createField(),
290 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
291 so we can get correct quoting and escaping. Thanks to Lukas Eder for
292 adding this, and other things, to jOOQ.
294 2012-05-15 Murray Cumming <murrayc@murrayc.com>
296 SqlUtils: Remove the Connection parameters.
298 * src/main/java/org/glom/web/server/SqlUtils.java:
299 build_sql_select_with_key(), build_sql_select_with_where_clause(),
300 createSelect(), build_sql_select_step_with_where_clause(),
301 build_sql_count_select_with_where_clause(),
302 build_sql_select_count_rows(): Remove the Connection parameter because
303 jOOQ does not actually need a connectionwhen it is just used to build
305 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
307 * src/main/java/org/glom/web/server/ReportGenerator.java:
309 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
311 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
312 Constructor, getListData(), getResultSizeOfSQLQuery():
313 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
314 getSelectQuery(), getCountQuery():
315 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
316 getSelectQuery(), getCountQuery():
317 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
318 getNavigationRecord(): Adapted.
320 2012-05-14 Murray Cumming <murrayc@murrayc.com>
324 * src/main/java/org/glom/web/server/SqlUtils.java:
325 get_find_where_clause_quick(): Use a comparison of
326 lowercase values, instead of a simple equals. Regular Glom
327 uses the PostgreSQL ILIKE operator but jOOQ does not
328 support that just yet, though it will soon.
330 2012-05-14 Murray Cumming <murrayc@murrayc.com>
332 TableToViewDetails: Use a real serialization ID.
334 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
335 Though this does not fix the serialization problem.
337 2012-05-12 Murray Cumming <murrayc@murrayc.com>
339 Added LayoutItemPortalDeepCloneTest.
341 2012-05-11 Murray Cumming <murrayc@murrayc.com>
343 Make navigation work again.
345 * src/main/java/org/glom/web/server/libglom/Document.java:
346 Add getLayoutItemFieldShouldHaveNavigation().
347 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
348 Replace get/setAddNavigation() with the partly-existing
349 get/setNavigationTableName(), with an empty string being no navigation,
350 because this is simpler. Use the new
351 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
353 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
354 Add updateFieldsExtras() and call setNavigationTableName in it.
355 getDetailsLayoutGroup(),
356 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
357 createLayout(): Adapted.
358 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
359 Constructor: Adapted.
361 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
362 Replace get/setAddNavigation() with get/setNavigation(), returning a
363 TableToViewDetails class with both the table name and UsesRelationship,
364 because both are need. The previous code used java-libglom's output
365 variable (strangely, via sharedptr) to return both, but we cannot really
367 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
368 getNavigationRecord(): Adapt. However, we cannot actually use the cache
369 here because it somehow gets set to null during deepCopy(). I must test this.
370 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
371 testGetSuitableTableToViewDetails(): Adapted.
373 TODO: Find out why deepClone() is not quite working.
375 2012-05-11 Murray Cumming <murrayc@murrayc.com>
377 DBAccess: Simplify the retrievel of full field details.
379 * src/main/java/org/glom/web/server/database/DBAccess.java
380 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
381 because the Document loading should have done this.
383 2012-05-11 Murray Cumming <murrayc@murrayc.com>
385 Document: Correct loading of doubly-related layout fields.
387 * src/main/java/org/glom/web/server/libglom/Document.java:
388 loadUsesRelationship(): Actually set the related relationship, instead
389 of only setting it if it's not found.
391 2012-05-09 Murray Cumming <murrayc@murrayc.com>
393 Replace all appearances of Colour with color.
395 Because US English is dominant.
397 2012-05-09 Murray Cumming <murrayc@murrayc.com>
399 Use colors in HTML format, solving a warning about an unused function.
401 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
402 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
403 Add *asHTMLColor() versions of methods.
404 TODO: However, we should create and cache the results on the server.
405 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
406 * src/main/java/org/glom/web/client/ui/list/ListTable.java
407 * src/main/java/org/glom/web/server/ConfiguredDocument.java
408 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
409 Use the asHTMLcolor() versions.
411 2012-05-09 Murray Cumming <murrayc@murrayc.com>
413 ListViewTable: Constructor: Take the table name as a parameter.
415 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
416 Constructor: Take the tableName, and set the member variable, because
418 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
419 setCellTable(): Pass the table name.
420 This makes navigation to non-default tables work again. I don't know
421 why it worked before in the master branch.
423 2012-05-07 Murray Cumming <murrayc@murrayc.com>
425 ConfiguredDocument: Restore correct addition of hidden primary key items.
427 * src/main/java/org/glom/web/client/ui/list/ListTable.java
428 (ListTable.createCellTable): Uncomment out the check for the hidden
430 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
431 add primary key items for top-level lists and portals, as before,
432 instead of adding them to each group.
433 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
434 Actually implement the extra methods such as setHiddenPrimaryKey() and
435 comment that these are used only for top-level list groups and in portals.
436 This strangeness suggests even more that this should not be squeezed
437 into the LayoutGroup class.
439 2012-05-07 Murray Cumming <murrayc@murrayc.com>
441 Fix Formatting loading.
443 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
444 getFormattingUsed(): Remove the duplicate Formatting member variable
445 in favour of the one from the base class.
446 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
447 Initialize a new Formatting instead of using null by default, so we
448 have some defaults, instead of having to initialize one later just to
449 get the same defaults. This also makes loading of formatting from the
450 document work, because that expected a non-null.
452 2012-05-07 Murray Cumming <murrayc@murrayc.com>
454 RelatedListTable: Make sure that the tableName is set.
456 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
457 Constructor: Take the tableName so it is available later. Otherwise,
458 the server assumes that we mean the default table and cannot find the
460 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
461 setData(): Pass the tableName to the RelatedListTable constructor.
463 2012-05-07 Murray Cumming <murrayc@murrayc.com>
467 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
468 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
469 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
471 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
473 * src/main/java/org/glom/web/server/database/DBAccess.java:
474 convertResultSetToDTO(), getPortal():
475 * src/main/java/org/glom/web/server/database/ListDBAccess.java
477 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
478 Add checks for null objects and out of range access, with log messages to
479 give hints so we can fix these properly.
481 2012-05-07 Murray Cumming <murrayc@murrayc.com>
483 Portals: some corrections.
485 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
487 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
488 constructor: Use getRelationshipNameUsed() instead of getName(), because
489 that is what is meant.
490 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
491 getFromField(): Fix a typo, to get the field name, not the table name.
492 * src/main/java/org/glom/web/server/database/DBAccess.java:
493 getPortal(): Fix a typo that stopped this from working.
495 2012-05-07 Murray Cumming <murrayc@murrayc.com>
497 LayoutItemPortal: Also override getTitleOriginal().
499 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
500 This lets the base getTitle() with no parameters work.
501 TODO: Test this properly.
503 2012-05-06 Murray Cumming <murrayc@murrayc.com>
505 LayoutItemPortal: getTitle*(): Use the relationship title.
507 2012-05-06 Murray Cumming <murrayc@murrayc.com>
509 LayoutItemField: Fix loading of custom titles.
511 * src/main/java/org/glom/web/server/libglom/Document.java
512 loadDataLayoutItemField(): The title, if any, instead of the field
513 title, is stored in a title_custom node. Load it from there.
514 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
516 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
517 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
518 getTitle*() overrides.
519 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
522 2012-05-06 Murray Cumming <murrayc@murrayc.com>
524 LayoutItemField: Fall back to field titles, so some are really shown.
526 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
527 Override getTitleOriginal() and getTitle(), as in java-libglom.
528 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
531 2012-05-06 Murray Cumming <murrayc@murrayc.com>
533 Correct use of setExpectedResultSize().
535 * src/main/java/org/glom/web/server/ConfiguredDocument.java
536 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
537 Use setExpectedResultSize only on top-level groups (for instance, the
538 list layout) or on child portals (in details views).
539 Use the correct table name for portals to avoid SQL errors.
540 Update the expected counts when returning cached layouts.
542 2012-05-06 Murray Cumming <murrayc@murrayc.com>
544 Document: Interpret no group column count as 1.
546 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
547 default, though we now check for this in the UI code anyway.
549 2012-05-06 Murray Cumming <murrayc@murrayc.com>
553 2012-05-06 Murray Cumming <murrayc@murrayc.com>
555 Translatable: Use Hashmap instead of Treemap because GWT supports it.
557 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
558 The use of Treemap lead to this error from async methods, with no
560 "The response could not be deserialized"
562 2012-05-06 Murray Cumming <murrayc@murrayc.com>
564 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
566 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
567 when using the Google -> GWT Compile, or
568 g toolbar button -> GWT Compile Project... feature in Eclipse.
570 2012-05-06 Murray Cumming <murrayc@murrayc.com>
572 ListTable.addColumn(): Protect against a null Formatting.
574 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
575 Create a default Formatting if it is null, because that is the simplest
578 2012-05-06 Murray Cumming <murrayc@murrayc.com>
580 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
582 * src/main/java/org/glom/web/server/ConfiguredDocument.java
583 updateLayoutGroup(): Check that the field is not null.
585 2012-05-06 Murray Cumming <murrayc@murrayc.com>
587 ListViewImpl: Protected against a bad cast error.
589 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
590 onEnterKeyDown(): Do not cast without an instanceof check.
592 2012-05-06 Murray Cumming <murrayc@murrayc.com>
594 ListTable: Protect against an out of range error.
596 * src/main/java/org/glom/web/client/ui/list/ListTable.java
597 createCellTable(): This is unlikely, but can happen while debugging.
599 2012-05-06 Murray Cumming <murrayc@murrayc.com>
601 AsyncMessage onFailure() callbacks: Log the exception message.
603 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
604 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
605 * src/main/java/org/glom/web/client/activity/ListActivity.java:
606 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
607 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
608 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
609 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
610 These are useful clues when something is wrong.
612 2012-05-06 Murray Cumming <murrayc@murrayc.com>
614 ConfiguredDocument: Avoid a null dereference.
616 * src/main/java/org/glom/web/server/ConfiguredDocument.java
617 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
618 details maps are created.
620 2012-05-06 Murray Cumming <murrayc@murrayc.com>
622 Document: Correct the port number parsing.
624 * src/main/java/org/glom/web/server/libglom/Document.java:
625 This lets us actually connect to the database and show the document.
627 2012-05-05 Murray Cumming <murrayc@murrayc.com>
631 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
632 user-interaction, asking us to load a temporary URL in a browser.s
633 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
634 which is apparently necessary for testing the service. See the comment.
635 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
636 Show the exception, if any. This is how I saw the 404 in the HTML in
639 2012-05-05 Murray Cumming <murrayc@murrayc.com>
641 DocumentTest: Move the .glom files into the resources directory.
643 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
644 URI via getResource().
646 2012-05-05 Murray Cumming <murrayc@murrayc.com>
648 Document: Remove the FieldIdentifies inner class.
650 * src/main/java/org/glom/web/server/libglom/Document.java: We only
651 use the Relationship (though the same function in libglom is maybe
652 used in other ways) and so this removes a compiler warning.
654 2012-05-05 Murray Cumming <murrayc@murrayc.com>
656 Document.load() Remove the error code parameter.
658 * src/main/java/org/glom/web/server/libglom/Document.java: load():
659 Remove the parameter. We do not set it yet and it could never have
660 worked as an output parameter (though maybe it did in java-libglom).
661 We could use an exception if we really want the failure reason.
662 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
664 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
665 setUp(), testGetSuitableTableToViewDetails(): Adapt.
667 2012-05-05 Murray Cumming <murrayc@murrayc.com>
669 Make some inner classes static.
671 * src/main/java/org/glom/web/server/ConfiguredDocument.java
672 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
673 * src/main/java/org/glom/web/server/ReportGenerator.java
674 * src/main/java/org/glom/web/server/libglom/Document.java
675 Make all inner classes static that can be static.
677 2012-05-05 Murray Cumming <murrayc@murrayc.com>
679 OnlineGlomServiceImpl: Do not load and check for java-libglom.
681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
682 init(): We do not use java-libglom any more.
684 2012-05-05 Murray Cumming <murrayc@murrayc.com>
686 Remove mentions of java-libglom.
688 * README: Remove mention of java-libglom, because it no longer needed.
689 * utils/build-onlineglom-war.sh:
690 * utils/check-and-recover-tomcat.py:
691 * utils/install-onlineglom-war.sh: Remove these as they are no longer
692 useful. Building is now far easier, with no need for jhbuild.
694 2012-05-05 Murray Cumming <murrayc@murrayc.com>
696 Fix the build (mvn package)
698 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
699 (LayoutGroup): Make the LayoutItemList inner class static and protected.
700 Otherwise the GWT Java->Javascript compilation fails with just this
701 error, during mvn package or when attempting to view in a browser,
702 in the GWT developer mode in Eclipse.
704 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
705 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
706 [INFO] Compiling module org.glom.web.OnlineGlom
707 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
708 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
709 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
710 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
711 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
712 [INFO] [ERROR] Cannot proceed due to previous errors
714 It has taken me 2 days to find out what was causing that. After reducing
715 the code, the compiler eventually showed me the full error message.
717 2012-05-04 Murray Cumming <murrayc@murrayc.com>
719 ConfiguredDocument: Cache the cloned and stripped layouts.
721 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
722 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
723 layout in a map, so we can retrieve it again without rebuilding it.
725 2012-05-04 Murray Cumming <murrayc@murrayc.com>
727 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
729 2012-05-04 Murray Cumming <murrayc@murrayc.com>
731 libglom classes: Implement some auto-generated emthods.
733 2012-05-04 Murray Cumming <murrayc@murrayc.com>
735 Add GwtTestOnlineGlomService.
737 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
738 However, this (and the other GwtTest*) does not seem to run during
741 2012-05-04 Murray Cumming <murrayc@murrayc.com>
743 Remove use of unsupported features from client code.
745 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
746 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
747 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
748 Use our client version of StringUtils instead of the apache commons one.
750 However, the GWT Javascript compliation still fails.
752 2012-04-25 Murray Cumming <murrayc@murrayc.com>
754 Add a Field class and implement some loading of it in Document.
756 2012-04-25 Murray Cumming <murrayc@murrayc.com>
758 Initial Document loading implementation, instead of libglom.
760 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
761 and Translatable classes, and adapt the rest of the code to use them.
762 However, this is still missing Layout and Field classes and loading.
764 2012-04-24 Murray Cumming <murrayc@murrayc.com>
766 Use of jOOQ: Move Field creation into a utility method.
768 * src/main/java/org/glom/web/server/SqlUtils.java:
769 This lets us improve it more easily.
771 2012-04-24 Murray Cumming <murrayc@murrayc.com>
773 Use of jOOQ: Improve the code to COUNT a sub-select.
775 * src/main/java/org/glom/web/server/SqlUtils.java:
776 Move initial query creation into
777 build_sql_select_step_with_where_clause().
778 build_sql_select_count_rows(): Use the jOOQ API instead of
779 concatentating text, because a jOOQ Select*Step is a TableLike,
780 which is what from() takes.
782 2012-04-23 Murray Cumming <murrayc@murrayc.com>
784 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
786 * pom.xml: Depend on jooq.
787 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
788 methods with jOOQ, based on the C++ implementations in libglom,
789 with some changes to the logic required by jooQ.
790 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
792 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
793 * src/main/java/org/glom/web/server/ReportGenerator.java:
794 * src/main/java/org/glom/web/server/SqlUtils.java:
795 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
796 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
797 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
798 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
799 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
800 Adapt. In particular, the SqlUtils methods now need to take a Connection,
801 because jOOQ needs that, though it seems unnecessary.
803 This is not quite finished. Ideally jOOQ would help us to build
804 table_name.field_name names, quoting and escaping them properly.
805 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
807 2012-04-21 Murray Cumming <murrayc@murrayc.com>
809 Move use of Glom.build_sql*() into a new SqlUtils class.
811 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
812 to wrap Glom.build_sql*(). The parameter types are still Glom one,
813 but this will make it easier to start using something other than
814 libglom or SqlBuilder.
816 2012-04-21 Murray Cumming <murrayc@murrayc.com>
818 Update the project URL.
820 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
822 2012-04-21 Murray Cumming <murrayc@murrayc.com>
824 Main layout: Use a FlowTable instead of absolute positioning.
826 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
827 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
828 child panels/widgets must have an absolute position. But that is annoying, so
829 this adds a FlowTable and puts the child panels in there.
831 2012-04-21 Murray Cumming <murrayc@murrayc.com>
833 GwtTestOnlineGlom: Comment out unused code.
835 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
836 Eclipse has started to say that some code is unused.
838 2012-04-21 Murray Cumming <murrayc@murrayc.com>
840 Update to the latest versions of dependencies.
842 * pom.xml: Update version numbers of dependencies to the latest
844 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
845 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
846 * src/main/java/org/glom/web/server/ReportGenerator.java:
847 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
848 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
849 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
851 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
852 Modify the imports where necessary.
854 2012-04-17 Murray Cumming <murrayc@murrayc.com>
856 Style: Remove overflow:hidden from searchbox
858 * src/main/webapp/style.css: Because this pushes the Back To Link
859 label/link on to the next row, which is then hidden due to the
860 hard-coded (in ems) height.
862 2012-04-20 Murray Cumming <murrayc@murrayc.com>
864 Remove some duplicate code.
866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
867 getDocumentInfo(): This must have been duplicated during the merge from the
872 2012-04-19 Murray Cumming <murrayc@murrayc.com>
874 Reports: Localize the waiting for report message.
876 * src/main/java/org/glom/web/client/activity/ReportActivity.java
877 start(): Get the message from the contants.
878 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
880 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
881 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
882 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
883 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
884 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
885 Update these files with the English text for newer strings for now.
887 2012-04-19 Murray Cumming <murrayc@murrayc.com>
889 Reports: Show a message while waiting for the report.
891 * src/main/java/org/glom/web/client/ui/ReportView.java
892 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
893 Add setWaitingText(), to show a message saying that we are
894 waiting for the report to be ready.
895 * src/main/java/org/glom/web/client/activity/ReportActivity.java
896 start(): Call setWaitingText() before calling the async
899 2012-04-19 Murray Cumming <murrayc@murrayc.com>
901 ReportGenerator: Specify date and time formats.
903 * src/main/java/org/glom/web/server/ReportGenerator.java:
904 createFieldValueElement(): Use the default (and localized)
905 short formats, though we still need a way to show 4-digit
906 years without providing the format for every locale.
907 * src/main/java/org/glom/web/server/database/DBAccess.java:
908 convertResultSetToDTO(): Use the short formats here too.
910 2012-04-18 Murray Cumming <murrayc@murrayc.com>
912 ReportGenerator: Use the correct numeric formatting.
914 * src/main/java/org/glom/web/server/ReportGenerator.java
915 createFieldExpression(), createFieldValueElement(): Take the
916 whole LayoutItem_Field instead of just the field name, so
917 we have access to the formatting.
918 createFieldValueElement(): Use JRTextField.setPattern() to
919 specify the numeric formatting, with the help of a
920 regular DecimalFormat.
922 2012-04-18 Murray Cumming <murrayc@murrayc.com>
924 ReportGenerator: Avoid showing null for group by titles.
926 * src/main/java/org/glom/web/server/ReportGenerator.java
927 generateReport(): Use setBlankWhenNull() on the field title
928 style too, because this is used for values in group by
931 2012-04-18 Murray Cumming <murrayc@murrayc.com>
933 ReportGenerator: Add a colon to titles in vertical groups.
935 * src/main/java/org/glom/web/server/ReportGenerator.java
936 addFieldToDetailBandVertical(): Pass true for the withColon
939 2012-04-18 Murray Cumming <murrayc@murrayc.com>
941 ReportGenerator: Simplify the code by using Position more.
943 2012-04-18 Murray Cumming <murrayc@murrayc.com>
945 Reports: Support vertical groups, roughly.
947 * src/main/java/org/glom/web/server/ReportGenerator.java:
948 addToReport(): Rename to addGroupToReport() and, if necessary,
949 call the new addVerticalGroupToReport() method.
950 createFieldValueElement(): Let the caller specify the Y position
953 2012-04-17 Murray Cumming <murrayc@murrayc.com>
955 Reports: Allow a second report to be shown.
957 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
958 clear(): Do not remove the HTML widget, which broke the whole layout.
960 2012-04-17 Murray Cumming <murrayc@murrayc.com>
962 Locales drop-down: Show that we use English by default.
964 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
965 fillView(): When we use English, just because that is the default, when
966 no locale is specified, show that in the Locales drop-down instead of
967 just showing the first item.
969 2012-04-17 Murray Cumming <murrayc@murrayc.com>
971 Unselect the Report/Locale/Table combo item when appropriate.
973 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
974 setPlace(): clear reportName if this is not a ReportPlace.
975 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
976 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
977 When the provided name is empty, unselect all items, so that none are
978 indicated. This uses a for loop because I cannot find a single method
981 2012-04-17 Murray Cumming <murrayc@murrayc.com>
983 Report: Give the user a way to get back to the list.
985 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
986 start(), setPlace(): Show the Back To List link on reports, and also
987 interpret selecting the empty report item as back to list.
989 2012-04-13 Murray Cumming <murrayc@murrayc.com>
991 Really show the selected Report name.
993 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
994 setPlace(): Store the reportName here, if it is that kind of Place.
995 fillView(): Set the selected Report after filling the list of reports.
996 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
997 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
998 null Strings, though we need some way to unselect all ListBox items
1001 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1003 ReportGenerator: Try to avoid some problems.
1005 * src/main/java/org/glom/web/server/ReportGenerator.java
1006 addField(): Try to avoid duplicates, and avoid using a null
1009 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1011 Reports: Use quickFind.
1013 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1014 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1016 getReportHTML(): Add a quickFind parameter.
1017 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1018 start(): Pass the quickFind parameter.
1019 * src/main/java/org/glom/web/server/ReportGenerator.java
1020 generateReport(): Take a quickFind parameter.
1022 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1024 ReportPlace: Actually use the report name.
1026 * src/main/java/org/glom/web/client/place/ReportPlace.java
1027 getPlace(): Do not assign the report name to the quickfind.
1029 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1031 Show java.library.path when complaining.
1033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1034 init(): When telling us to check java.library.path, show the
1037 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1039 ReportGenerator: Do not show nulls.
1041 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1043 ReportGenerator: Make the title font larger.
1045 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1047 ReportGenerator: Put field titles inside groups, if there are groups.
1049 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1051 ReportGenerator: Take the Report itself instead of the name and group.
1053 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1054 Remove getReportLayoutGroup().
1055 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1056 getReportHTML(): Pass the report instead
1057 of its name and layout group.
1058 * src/main/java/org/glom/web/server/ReportGenerator.java
1059 generateReport(): Use the report object to use the title
1060 instead of the name.
1062 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1064 ReportGenerator: Remove designBand parameters.
1066 * src/main/java/org/glom/web/server/ReportGenerator.java:
1067 Make designBand a class member instead of passing it to all
1070 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1072 ReportGenerator: Add lines, a bit like in the desktop version.
1074 * src/main/java/org/glom/web/server/ReportGenerator.java
1075 addToReport(): Use JRDesignLine.
1077 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1079 ReportGenerator: Correct the title positions and use some bold style.
1081 * src/main/java/org/glom/web/server/ReportGenerator.java:
1082 Break the code up into reusable functions, correct the placement of
1083 titles, and use normal/bold styles as in the reports in the desktop
1086 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1088 ReportGenerator: Add a header band to show the field titles.
1090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1091 getReportHTML(): Pass the localeId to the ReportGenerator
1093 * src/main/java/org/glom/web/server/ReportGenerator.java
1094 constructor: Take the localeID so we can get translated field
1096 generateReport(), addToReport(), addFieldToBand(): Add field
1097 titles in a column header band.
1099 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1101 Reports drop-down list: Some improvement.
1103 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1104 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1105 Adedd setSelectedReport(),
1106 setReportList(): Add a blank line so that the user can select the
1108 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1109 start(): Show the current report by calling setSelectedReport().
1110 This does not seem to work yet.
1112 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1114 DetailsActivity, ListActivity: Move some variables into a base class.
1116 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1117 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1118 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1119 the clientFactory, documentID, tableName and authenticationPopup into
1120 a base class, to avoid duplication.
1122 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1124 Translate the Reports label.
1126 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1127 Get the "Reports" label string from the constants.
1128 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1129 perties: Add Reports to the constants.
1131 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1133 Reports: Implement grouping.
1135 * src/main/java/org/glom/web/server/ReportGenerator.java:
1136 Handle LayoutItem_GroupBy items and try to do the right thing
1137 with JRDesignGroup. It seems to work.
1139 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1141 Actually show some data with JasperReports.
1143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1144 getReportHTML(): Move most code into a ReportGenerator class.
1145 * src/main/java/org/glom/web/server/ReportGenerator.java:
1146 Recurse into sub-groups, adding fields to the JasperDesign's details
1147 band. Note that we must set an arbitrary width and height, or it just
1148 will not show any data.
1150 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1152 Reports Chooser: Show the titles, not the names.
1154 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1155 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1156 and the names as the values.
1157 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1158 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1159 group now that we provide the report name, so it should always
1162 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1164 Depend on jasperreports.
1166 * pom.xml: Add the dependency. My plan is to use this on the
1169 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1171 Implement navigation to report places.
1173 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1174 start(): Do not bother to handle all events here.
1175 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1176 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1177 Added getSelectedReport().
1178 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1179 .java: start(): When handling a change to the reports chooser,
1180 call getSelectedReport() and goTo() its ReportPlace.
1181 * src/main/java/org/glom/web/client/ui/ReportView.java
1182 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1183 Added setReportHTML() which puts the html in a gwt HTML widget.
1184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1185 getReportHTML(): Return "TODO" just to show that this works.
1187 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1189 Make ReportPlace usable.
1191 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1192 Mention ReportPlace.
1193 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1194 Correct the @prefix annotation.
1196 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1198 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1200 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1201 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1203 Change getReportLayout() to getReportHMTL() because we will not need to
1204 parse or render the report layout on the client side.
1205 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1206 getReportLayout(): Return the libglom LayoutGroup type because we will
1207 not need to convert to a shared type, because this will not be used on
1209 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1212 Note that there is still no implementation for this.
1215 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1217 Add a (empty) Report Place, View, and Activity.
1219 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1221 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1222 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1223 this into a superclass:
1224 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1225 and also use it as the base of this new ReportPlace:
1226 * src/main/java/org/glom/web/client/place/ReportPlace.java
1228 * src/main/java/org/glom/web/client/ui/ReportView.java
1229 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1230 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1231 Add these, containing mostly boiler-plate for now.
1233 * src/main/java/org/glom/web/client/OnlineGlomService.java
1234 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1235 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1236 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1237 Add API to get the LayoutGroup for the report.
1239 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1241 Add and fill a Reports drop-down list box.
1243 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1245 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1246 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1247 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1248 Added getReports(document, table, localeID), calling
1249 ConfiguredDocument.getReports().
1250 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1251 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1252 Added setReportsList() and a list widget.
1253 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1254 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1259 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1261 Translations: Add Esperanto.
1263 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1264 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1265 properties: Add this translation because someone took the time to make it.
1267 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1269 Adapt to the java-libglom 1.21.7 API.
1271 * src/main/java/org/glom/web/server/ReportGenerator.java:
1272 addToReport(): get_group_secondary_fields() is now
1273 get_secondary_fields().
1276 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1278 Use the latest java-libglom version.
1280 * pom.xml: Use java-libglom 1.21.7.
1282 2012-03-03 Ben Konrath <ben@bagu.org>
1284 Display date and time in details view.
1286 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1288 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1290 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1292 Require the latest java-libglom.
1294 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1296 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1298 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1300 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1301 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1302 an empty quickfind string. I also corrected libglom to create only
1303 empty where clauses for empty quickfind strings, but this avoids the
1306 2012-02-24 Ben Konrath <ben@bagu.org>
1308 Improve the tabs in the Notebook widget.
1312 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1314 Translations: Try to translate the strings.
1316 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1317 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1318 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1319 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1320 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1321 Take the Open translation from GTK+'s .po files.
1322 Take the Details translation from Glom's po files.
1323 I have added the other strings to Glom so we can get translations that way:
1324 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1326 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1328 TableSelectionViewImpl: Put the search label and entry in a div.
1330 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1331 Put the search widgets in a FlowTable so that the CSS can be used to
1332 style them while keeping them together.
1333 * src/main/webapp/style.css: Mention the new div.
1335 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1337 Translate more strings in more locales.
1339 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1340 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1341 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1342 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1343 Translate the "Details" and "Open" string too.
1345 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1346 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1347 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1348 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1349 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1350 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1351 Add these new locales as placeholders though they currently contain English.
1353 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1355 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1357 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1358 Check the ConfiguredDocument* for null before using it.
1360 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1362 Tell Eclipse about the generated java files.
1364 * .classpath: This lets it find OnlineGlomConstants.java.
1365 It would be nice if Eclipse just used the maven build files.
1367 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1369 Prevent a crash when no locale is specified in the URL.
1371 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1372 Avoid returning a null string, obtained from
1373 Window.Location.getParameter(). This caused a crash when it was
1374 later passed to libglom's API.
1375 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1376 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1377 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1378 guard against future null strings.
1380 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1382 Use the ?locale= query param instead of the &lang= token param.
1384 * src/main/java/org/glom/web/client/place/ListPlace.java
1385 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1386 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1387 Remove the lang token key and value.
1389 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1390 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1391 When the user selects a different locale from the chooser, use
1392 Window.Location.assign() to change the URL, which then causes a reload.
1394 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1395 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1396 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1397 * src/main/java/org/glom/web/client/activity/ListActivity.java
1398 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1399 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1400 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1401 * src/main/java/org/glom/web/client/ui/ListView.java:
1402 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1404 Remove localeID member variables and method/constructor parameters, instead
1405 using Utils.getCurrentLocaleID() when we need a localID to pass to
1408 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1410 Internationalize the UI strings.
1412 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1413 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1414 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1415 because it is unused. Messages are apparently strings that can have
1416 parameters, but we do not need that yet, so Contants will be enough for now.
1417 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1418 to say that we support the en and de locales.
1419 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1420 The original English strings.
1421 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1422 Some German translations of the English strings.
1423 The i18n goal then uses the .properties file to generate an
1424 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1425 returns an implementation that returns the translated strings.
1426 The documentation suggests putting these in src/java/*/client/, but it seems
1427 best to put it in src/resources/*/client/.
1428 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1429 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1430 instead of hard-coding them.
1431 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1432 but that does not seem to stop the build, though it confuses Eclipse.
1434 You can see the translated string by adding ?locale=de to the URL, like so:
1435 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1437 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1439 Improve null/empty String checks.
1441 * pom.xml: Add a dependency on commons-lang, to use
1442 org.apache.commons.lang.StringUtils.
1443 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1445 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1446 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1447 Use StringUtils.isEmpty().
1449 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1450 StringUtils class with a static isEmpty() function because we
1451 cannot use org.apache.commons.lang.StringUtils in client-side
1452 GWT code because it (apparently) cannot be compiled to javascript.
1453 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1454 * src/main/java/org/glom/web/client/activity/ListActivity.java
1455 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1456 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1457 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1458 * src/main/java/org/glom/web/client/place/ListPlace.java
1459 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1460 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1461 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1462 * src/main/java/org/glom/web/client/ui/details/Group.java
1463 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1464 our StringUtils.isEmpty() function.
1466 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1468 Update to the latest java-libglom API.
1470 * pom.xml: Require java-libglom 1.21.4.
1471 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1472 getDocumentInfo(), getListViewLayoutGroup():
1473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1475 * src/main/java/org/glom/web/server/database/DBAccess.java
1476 getFieldsToShowForSQLQueryAddGroup(),
1477 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1478 with either get_database_title_original() or
1479 get_database_title(localeID).
1481 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1483 ConfiguredDocument: Avoid a null pointer exception.
1485 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1486 Initialize localeID to "" to avoid returning a null String which
1487 causes a crash in java-libglom's swing-generated code.
1489 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1491 Some simple renaming.
1493 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1494 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1495 for localeChooser. This seems more appropriate and is less ambiguous
1496 particularly in the .css file.
1498 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1500 ConfiguredDocument: Rename the localedID private member variable.
1502 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1504 Adapt to the latest java-libglom API from git master.
1506 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1507 libglom now uses only Vector instead of List, which uses add() instead of
1510 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1512 ConfiguredDocument: Rename the localedID private member variable.
1514 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1516 Build a source tarball with mvn assembly:single
1518 * assembly.xml: Add this file.
1519 * pom.xml: Use the maven-assembly-plugin and tell it to use
1520 our assembly.xml file.
1522 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1524 OnlineGlomServiceImpl: Get .glom files recursively.
1526 * pom.xml: Depend on commons-io from org.apache.commons.
1527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1528 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1529 files recursively, and with the easier filter for the extension.
1530 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1531 simplify that code too.
1533 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1535 README: Mention that you must install java-libglom packages separately.
1537 But then it works, because java-libglom is now in the central maven
1540 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1542 locales drop-down: Show the correct selected locale when the URL changes.
1544 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1545 .java: setPlace(): Move some code into fillView().
1547 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1549 locales drop-down: Do not lose the primary key.
1551 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1552 start(): onLocaleChange(): Pass the current primary key value,
1553 instead of an empty value.
1555 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1557 locales drop-down: Do not lose the drop-down selection.
1559 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1560 .java (TableSelectionActivity.fillView): Set the selected locale
1561 after changing the drop-down items (though we do not really need
1562 to change them just because the locale changes.)
1564 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1566 locales drop-down: Change the tables list when this changes.
1568 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1569 .java: TableSelectionActivity.start(): Move the async table titles
1570 retrieval into a private fillView() method and also call this when
1571 the chosen locale changes.
1572 Note that the document title is not actually translatable yet, but
1573 that is a problem that I should fix soon in libglom.
1575 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1577 Improve the placement of the locales drop-down.
1579 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1580 Put the title and locales drop-down in a div (gwt.FlowTable).
1581 * src/main/webapp/style.css: Add magic css properties to make this work.
1582 Also remove the left margin from the title so that it lines up with the
1585 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1587 locales selector: Show human-readable locale titles.
1589 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1590 getDocumentInfo(): Use java.util.Locale to show a real title of
1591 each locale, in the locale's own language.
1593 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1595 Add a language/locale selector drop-down.
1597 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1598 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1599 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1600 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1601 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1602 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1603 Add a ListBox to show the available locales. Add getLocaleSelector(),
1604 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1605 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1606 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1607 java: Add these classes.
1608 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1609 start(): Fill the locales ListBox. Handle its change event, firing a
1611 setPlace(): Show the selected locale as specified by the URL token.
1612 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1613 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1614 Handle LocaleChangeEvent, going to a new *Place with that locale.
1616 The placement of the ListBox is not pretty, and it currently uses the ID
1617 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1621 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1623 Search box: Show the search text from the URL token.
1625 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1626 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1627 Add setQuickFindText().
1628 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1629 .java: setPlace(): Store the queryText if the place is a ListPlace,
1630 and call TableSelectionView.setQuickFindText().
1632 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1634 Allow use of translations via, for instance, &lang=de in the URL.
1636 * pom.xml: Use the unstable java-libglom 1.21 version.
1638 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1639 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1640 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1641 init(): Instead of calling TranslatableItem.set_current_locale()
1642 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1643 However, this is only for default locales, which are not needed to
1644 change the locale in the URL.
1645 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1646 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1647 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1648 layout for a particular locale.
1649 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1650 Add get/setDefaultLocaleID().
1651 getDocumentInfo(), getListViewData(), getRelatedListData(),
1652 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1653 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1654 localeID parameter, so we can get the layout for a particular locale.
1656 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1657 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1658 * src/main/java/org/glom/web/client/place/ListPlace.java:
1659 Parse and construct a lang parameter too.
1661 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1662 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1663 passed to subsequent methods and constructors.
1664 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1665 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1666 Store the localeID from the *Place and pass it to other constructors
1667 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1669 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1670 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1671 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1672 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1673 * src/main/java/org/glom/web/client/ui/ListView.java:
1674 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1675 Take localeID parameters and pass them to subsequent constructors and
1676 methods, so that the layout is always retrieved for that locale.
1678 This is rather repetitive.
1680 Note that "" means the original (default) locale of the Glom document,
1681 which is usually English.
1683 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1685 Documents: Remove final keyword to fix startup configuration.
1687 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1688 final keywords on the private member variables because that breaks
1689 the startup, apparently (there are warnings) because it stops them
1690 from being serialized. I added these in the previous commit.
1692 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1694 Documents: Add some final keywords.
1696 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1699 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1701 OnlineGlomServiceImpl: Add to overview comments.
1703 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1704 Note that this is where all the document are loaded. They are not
1705 loaded freshly for each page.
1707 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1711 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1712 Add a TextBox for the text of a quick find.
1713 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1715 setBackLink(): Add a String quickFind parameter.
1716 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1717 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1718 to the base interface, because that is how TableSelectionViewImpl is used.
1719 * src/main/webapp/style.css: Add style for the search box and its label.
1721 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1722 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1723 Add these files, based on the existing TableChangeEvent and
1724 TableChangeEventHandlers.
1725 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1726 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1727 a ListPlace() that the user should be taken to.
1728 * src/main/java/org/glom/web/client/activity/ListActivity.java
1729 start(): Handle it here too and adapt the TableChangeEvent handler to
1730 pass the extra "" quickFind parameter to ListPlace.
1731 * src/main/java/org/glom/web/client/place/ListPlace.java:
1732 Constructor: Take an extra String quickFind parameter and store it,
1733 returning it from a new getQuickFind() method.
1734 getToken(): Put the quickFind text in the URL token.
1735 getPlace(): Parse the quickFind text from the URL token.
1736 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1737 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1738 ListPlace constructor.
1739 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1740 .java: start(): Add a Change handler for the TableSelectionView's
1741 TextBox (via its base HasChangeHandlers interface), firing the new
1742 QuickFindChangeEvent.
1743 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1744 pass the extra "" quickFind parameter.
1746 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1747 setCellTable(): Add a String quickFind parameter and pass it to
1748 the ListViewTable() constructor.
1749 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1750 setCellTable() in the base interface, because that is how ListViewImpl
1753 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1754 Add a String quickFind member variable.
1755 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1756 Constructor: Add a String quickFind parameter, storing it in the
1757 base ListTable's member variable.
1758 onRangeChanged(): Pass quickFind to the
1759 OnlineGlomServiceAsync.getSortedListViewData() and
1760 OnlineGlomServiceAsync.getListViewData() methods.
1762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1763 getListViewData(), getSortedListViewData(): Add a String quickFind
1764 parameter, passing it to ConfiguredDocument.getListViewData().
1765 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1766 Change getListViewData(), getSortedListViewData() in the base interface,
1767 because that is how OnlineGlomServiceImpl is used, via this:
1768 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1769 Change getListViewData(), getSortedListViewData() here too.
1770 This class can apparently be used to asynchronously call methods on
1771 OnlineGlomService, and GWT seems to implement that after recognizing
1772 just the *Async name convention and the extra AsyncCallback parameters.
1774 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1775 getListViewData(): Add a String quickFind parameter, and pass it to
1776 ListViewDBAccess.getData().
1777 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1778 getListData(): Add a String quickFind parameter and pass it to
1780 getSelectQuery(): Add a String quickFind parameter.
1781 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1782 getSelectQuery(): Add a String quickFind parameter and use it with
1783 Glom.get_find_where_clause_quick() to pass a where_clause to
1784 Glom.build_sql_select_with_where_clause(), to actually filter the
1786 getData(): Add a String quickFind parameter, passing it to getListData().
1787 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1788 va: getData(): Pass an empty string to getListData() for the
1789 quickFind parameter.
1791 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1793 ListTable: Minor change.
1795 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1796 createCellTable(): Make this protected instead of public.
1798 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1800 Many files: Use final for the parameters and use the @override attribute.
1802 2012-01-22 Ben Konrath <ben@bagu.org>
1804 Add anchor links for single line text that starts with http, ftp and www.
1808 2012-01-22 Ben Konrath <ben@bagu.org>
1810 Add ellipsis to single line text in details view.
1814 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1816 Remove all javadoc author tags.
1818 Because they are awkward and meaningless when many people touch
1820 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1822 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1824 Revert the COPYING.LESSER to COPYING rename.
1826 Apparently both should be there if it is LGPL.
1828 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1830 *View: Remove unused imports.
1832 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1833 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1834 * src/main/java/org/glom/web/client/ui/ListView.java:
1835 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1836 Remove unused imports, as suggested by Eclipse.
1838 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1840 Move the *View::Presenter types, and some API into one base View.
1842 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1843 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1844 * src/main/java/org/glom/web/client/ui/ListView.java:
1845 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1846 Presenter, setPresenter() and clear() into a shared base interface,
1847 to avoid the unnecessary duplicate Presenter types and to more clearly
1848 show how the *Views share the same structure, even if they are not
1849 used polymorphically.
1851 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1852 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1854 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1855 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1856 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1858 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1861 Feel free to revert this if there is a good reason for the duplicate
1864 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1866 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1868 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1869 a class member instead of a local variable in the method.
1870 This lets us use it to get the view instances, for use in tests.
1871 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1872 beforeOnlineGlom(): Test some more details of the initial view.
1873 Again, this is not very useful.
1875 To really test gwt-glom we will need to start a local postgresql
1876 instance with local data, like the Glom tests in C++.
1878 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1880 pom.xml: Mention the LGPL license.
1882 * pom.xml: Add a licenses section.
1883 * COPYING.LESSER: Move this to COPYING, which
1884 previously contained the GPL. But gwt-glom is all LGPL.
1886 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1888 Add project information to README and pom.xml.
1890 * README: Add a brief description and mention some mvn
1892 * pom.xml: This extra information shows up in mvn site
1895 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1897 Use the latest java-libglom version.
1899 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1901 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1903 GwtTestOnlineGlom: Test a little more.
1905 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1906 protected rather than private, as suggested by the gwt-test-utils
1908 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1909 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1910 Test the initial visibility of the panels.
1912 However, this is not a very useful test.
1913 And I wonder how we should generally test using this idea for an
1914 activity/places app like ours where the real changes happen implicitly
1915 based on the history token/URL.
1917 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1919 Slight modification to *Mapper comments.
1921 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1922 (DataActivityMapper)
1923 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1925 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1927 Remove comments mentioning GIN because they are just copied from
1928 the example code and are apparently not helpful:
1929 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1930 Also change the mention of a class that is only in the example code.
1932 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1934 GwtTestOnlineGlom test: Minor changes.
1936 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1937 Avoid the long qualified class name and modify the comment
1938 because it is now obvious to me that the mocked class is the only
1939 custom one created via GWT.create().
1941 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1943 Tests: Added the beginnings of a test using gwt-test-utils.
1945 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1946 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1947 which tells gwt-test-utils what class will be tested.
1948 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1949 Add a simple (but empty) test case. One class, used by the OnlineGlom
1950 class, is mocked so that it can be created. However, I am not sure
1951 why only this class needs to be mocked.
1953 Note that mockito seems more popular, and clearer, than easymock,
1954 but I have not got that working yet. It might be a matter of the
1957 This test is run during mvn integration-test.
1959 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1961 Tests: Use junit4-style syntax instead of junit3-style.
1963 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1964 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1965 * src/test/java/org/glom/web/shared/DataItemTest.java:
1966 Use the @Test annotation rather than relying on the test*() prefix.
1967 Also no longer implement TestCase, to avoid triggering support for
1968 the junit3-way, which stops the annotations from working.
1969 Change the imports from import junit.framework.* to
1970 import org.junit.*, which is apparently the new way.
1972 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1974 Added a test for ListPlace token parsing and creation.
1976 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1977 This is much the same as DetailsPlaceTest.
1979 I wonder how we could test the other parts of the *Place API.
1981 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1983 DetailsPlace test: Also test getToken() and recreation via getPlace().
1985 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1986 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1987 recreate it, testing the recreated DetailsPlace for the same parameter
1990 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1992 Use the surefire-report plugin.
1994 * pom.xml: This generates a HTML report about the tests in
1995 target/site/surefire-report.html
1996 when you do mvn surefire-report:report. It seems to be popular/normal.
1998 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2000 Added a test for DetailsPlace.
2002 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2003 Test the getPlace() token parsing.
2005 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2007 Added a first unit test.
2009 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2010 * src/test/java/org/glom/web/shared/DataItemTest.java:
2011 This is a silly test but it is just to get things started. Note that
2012 maven/junit finds the test because it looks in src/test by default.
2014 2011-12-22 Ben Konrath <ben@bagu.org>
2016 Change charsetName to "UTF-8" when replacing line breaks.
2018 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2019 that work in Java (such as "UTF8") will not work when compiled to
2022 This fixes a problem with multi-line details view fields that have hard
2023 line breaks. The "License Text" field on this page demonstrates the
2026 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2028 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2030 2011-12-22 Ben Konrath <ben@bagu.org>
2032 Fix another bug with related list navigation.
2034 I've tested all the navigation buttons in all of the related lists
2035 so things should be good now.
2037 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2039 2011-12-22 Ben Konrath <ben@bagu.org>
2041 Fix a crasher when refreshing the list view with the default table.
2043 This crash will also happen when loading the list view with the default
2044 table from a link or bookmark.
2046 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2047 to the main document selection page when the document id hasn't been
2049 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2050 the main document selection page when the document id hasn't been
2052 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2053 values for the details place when the document id hasn't been set.
2054 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2055 values for the list place when the document id hasn't been set.
2057 2011-12-21 Ben Konrath <ben@bagu.org>
2059 Protect against NPE when glom.document.locale is not in config.
2061 This patch protects against an NPE when glom.document.locale is not in
2062 the config file. This NPE will also happen if glom.document.locale is
2065 The patch also updates the error message to display the class name when
2066 the getMessage() returns null. This was happening when the NPE was
2067 thrown and I had "Configuration Error: null". If an NPE is encountered
2068 with this patch, "Configuration Error: NullPointerException " will be
2071 This commit closes this bug:
2073 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2077 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2079 Rename onlineglom.properties to onlineglom.properties.sample.
2081 * src/main/resources/onlineglom.properties: Rename to:
2082 * src/main/resources/onlineglom.properties.sample:
2083 * src/main/resources/README: And add this file explaining that people
2084 should rename it back when deploying.
2086 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2088 Allow choosing the translation in the .properties file.
2090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2091 init(): Read a glom.document.locale value from the configuration file
2092 and call Glom's TransatableItem::set_current_locale() method.
2093 * src/main/resources/onlineglom.properties: Add a commented-out
2094 example of this new setting.
2096 It would be better to add &lang=de_DE to the URL, but the current
2097 libglom API does not allow us to do this easily. I am working on that.
2099 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2101 Avoid a crash in parsing of token parameters.
2103 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2104 ava: getTokenParams(): Do not crash if a parameter has a key but no
2105 value, and ignore parameters with neither.
2107 2011-12-17 Murray Cumming <murrayc@murayc.com>
2109 History token building/handling: Improve use of token parameters.
2111 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2112 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2113 and buildParamsToken(HashMap), for use by derived classes.
2114 Make the separator private because it is no longer be needed.
2115 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2116 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2117 instead of manual string concatenation.
2118 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2119 of hardcoded indices and awkward splitting code.
2120 * src/main/java/org/glom/web/client/place/ListPlace.java
2121 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2122 instead of manual string concatenation.
2123 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2124 of hardcoded indices and awkward splitting code.
2125 This should fix bug #666420
2127 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2129 Fix a Navgiation->Navigation typo in the code.
2131 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2132 Rename processNavgiation() to processNavigation().
2134 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2136 Fix a seperator->separator typo in the code.
2138 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2139 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2140 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2143 2011-12-15 Ben Konrath <ben@bagu.org>
2145 Cleanup some comments.
2147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2149 2011-12-14 Ben Konrath <ben@bagu.org>
2151 Replace \n with <br/> for multiline text in the details view.
2153 Vertical scrollbars are added when needed as well.
2155 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2157 2011-12-14 Ben Konrath <ben@bagu.org>
2159 Specify the font for document selection links.
2161 * src/main/webapp/style.css:
2163 2011-12-14 Ben Konrath <ben@bagu.org>
2165 Fix bouncy CellTable while paging.
2167 This doesn't currently work with related list tables in unselected
2170 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2172 2011-12-14 Ben Konrath <ben@bagu.org>
2174 Revamp the appearance of the document selection page.
2176 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2177 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2178 * src/main/webapp/style.css:
2180 2011-12-13 Ben Konrath <ben@bagu.org>
2182 Set navigation button column to the smallest size possible.
2184 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2186 2011-12-13 Ben Konrath <ben@bagu.org>
2188 Change OpenButton nomenclature to NavigationButton.
2190 Using NavigtionButton makes things more generic. Classes, methods and
2191 variables have been changed.
2193 This is a rename-only refactor.
2195 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2196 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2197 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2198 Renamed from OpenButtonCell.
2199 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2200 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2201 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2203 2011-12-12 Ben Konrath <ben@bagu.org>
2205 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2207 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2208 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2209 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2210 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2212 2011-12-12 Ben Konrath <ben@bagu.org>
2214 Update variable names and comments.
2216 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2217 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2219 2011-12-12 Ben Konrath <ben@bagu.org>
2221 Properly initialize numNonEmptyRows variable to zero.
2223 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2224 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2226 2011-12-05 Ben Konrath <ben@bagu.org>
2228 Add latest mockup with HTML tables.
2230 Features of this mockup:
2232 -> HTML table for flowtable
2233 -> HTML table for flowtable column
2234 -> Example of how related lists would look
2235 -> Not using text entries for data items
2237 The current version of Online Glom doesn't use HTML tables for the
2240 This mockup has been sent to the glom-devel mailing list but it's good
2241 to have it here as well.
2243 * mockups/details-view-html-tables.html:
2245 2011-12-05 Ben Konrath <ben@bagu.org>
2247 Remove unnecessary getPrimaryKeyField() method.
2249 getPrimaryKeyFieldForTable(String) has been renamed to
2250 getPrimaryKeyField(String).
2252 * src/main/java/org/glom/web/server/database/DBAccess.java:
2253 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2254 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2256 2011-12-05 Ben Konrath <ben@bagu.org>
2258 Add string representation of TypedDataItem value to conversion error message.
2260 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2261 message was extracted into its own method to avoid duplication.
2263 2011-12-05 Ben Konrath <ben@bagu.org>
2265 Add type checking to navigation primary key value creation.
2267 Create navigation primary key only if the expected type from the Glom
2268 document matches the type returned by the SQL query.
2270 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2272 2011-12-05 Ben Konrath <ben@bagu.org>
2274 Rename a couple of variables in RelatedListNavigation.
2276 This is a rename-only refactor.
2278 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2280 2011-12-05 Ben Konrath <ben@bagu.org>
2282 Move getListLayoutGroup() into getListViewLayoutGroup().
2284 This removes getListLayoutGroup(). It was only being called by
2285 getListViewLayoutGroup().
2287 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2289 2011-12-05 Ben Konrath <ben@bagu.org>
2291 Remove check for LayoutItem_Portal in list table method.
2293 This check is no longer necessary because the method isn't being used
2294 to create the LayoutItemPortal DTO.
2296 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2298 2011-12-05 Ben Konrath <ben@bagu.org>
2300 Properly support related list navigation.
2302 Navigation from the "Repository Analyzer -> Package Scans ->
2303 Dependencies" related table wasn't working because the primary key for
2304 related tables wasn't being set properly. This commit fixes the
2307 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2308 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2309 doesn't set the primary key properly for related list tables.
2310 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2311 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2312 useful for getting the primary key for list view tables and for related
2314 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2315 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2316 Move code to set the primary key for the table from the abstract
2317 ListDBAccess class to ListViewDBAccess as it's only correct for list
2319 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2320 Properly add primary key to related list tables.
2322 2011-12-02 Ben Konrath <ben@bagu.org>
2324 Properly set the horizontal alignment of fields.
2326 This fix is for both the list tables and the details view.
2328 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2329 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2330 to set the horizontal alignment of fields.
2332 2011-12-02 Ben Konrath <ben@bagu.org>
2334 Display currency codes in the details view.
2336 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2338 2011-12-02 Ben Konrath <ben@bagu.org>
2340 Avoid duplicate JNI call.
2342 JNI is not as efficient as pure Java and this is an easy (and small)
2345 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2346 Use previously retrieved value for whereClauseToTableName instead of
2349 2011-12-02 Ben Konrath <ben@bagu.org>
2351 Rename a couple of variables in RelatedListNavigation.
2353 This is a rename-only refactor.
2355 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2357 2011-12-02 Ben Konrath <ben@bagu.org>
2359 Indicate clearly that a mismatched primary key type is a bug.
2361 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2362 warning to error. Add 'This is a bug.' to message.
2364 2011-12-02 Ben Konrath <ben@bagu.org>
2366 Update / fix some comments.
2368 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2370 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2372 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2373 Fix comments. Add some TODOs.
2375 2011-12-02 Ben Konrath <ben@bagu.org>
2377 Enable navigation to details view with string primary key from related list.
2379 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2380 Create a text primary key value when return type of result is
2381 java.sql.Types.VARCHAR.
2383 2011-12-02 Ben Konrath <ben@bagu.org>
2385 Use checkboxes for booleans in the details view.
2387 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2389 2011-12-01 Ben Konrath <ben@bagu.org>
2391 Improve performance of related list height calculation.
2393 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2394 Put code to calculate the expected height in a static initializer so
2395 that that it's only called once.
2397 2011-12-01 Ben Konrath <ben@bagu.org>
2399 Show related list tables in notebooks (again).
2401 Calculate the height of the related list tables so the Notebook can be
2402 set the correct height. The height of the related list table is also needed by
2403 FlowTable to be able decide how to create the layout.
2405 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2406 and set the Portal height based on the height of the related list
2407 table and the Portal container.
2408 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2409 Add method to calculate the height of the related list tables.
2410 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2411 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2412 calculate the height of the Pager widget.
2414 2011-12-01 Ben Konrath <ben@bagu.org>
2416 Use CellTable API for table property instead of setting style on Element.
2418 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2420 2011-12-01 Ben Konrath <ben@bagu.org>
2422 Make ListViewTable and RelatedListTable a consistent height.
2424 The tables are now a consistent height regardless of the contents of
2425 the table. A hidden button is added to empty rows to ensure that the
2426 height of these rows will match the height of rows with data.
2428 A navigation button column is now added to every table. The width of
2429 the navigation column is set to 0px when a RelatedListTable shouldn't
2430 have navigation buttons. This maintains the a consistent row height in
2431 tables that don't show the navigation buttons.
2433 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2434 navigation column when not needed.
2435 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2436 arguments for navigation button to constructor of ListViewTable.
2437 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2438 hidden button for empty data rows.
2439 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2440 arguments for navigation button to constructor.
2441 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2442 create navigation buttons. Add hideNavigationButtons() method.
2443 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2444 arguments for navigation button to constructor.
2446 2011-12-01 Ben Konrath <ben@bagu.org>
2448 Use 'visibility: hidden' in Utils.getWidgetHeight().
2450 This is better choice because hidden elements are invisible, don't
2451 respond to events and are not part of the tab order. They will,
2452 however, take up space which is required to be able to calculate the
2453 height of the widget.
2455 * src/main/java/org/glom/web/client/Utils.java:
2457 2011-12-01 Ben Konrath <ben@bagu.org>
2459 Use Utils.getWidgetHeight() in FlowTable.
2461 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2463 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2465 2011-12-01 Ben Konrath <ben@bagu.org>
2467 Put the details css class name on the correct table column.
2469 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2471 2011-11-30 Ben Konrath <ben@bagu.org>
2473 Update for java-libglom API change.
2475 The getters and setters on FieldFormatting and NumericFormat were
2476 changed to remove the 'M'.
2478 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2480 2011-11-29 Ben Konrath <ben@bagu.org>
2482 Only allow RelatedListTables in Portals.
2484 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2486 2011-11-29 Ben Konrath <ben@bagu.org>
2488 Only create a contents panel for Portals when title is being set.
2490 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2492 2011-11-29 Ben Konrath <ben@bagu.org>
2494 Set TabLayoutPanel height based on calculated height its widgets.
2496 This is a potential fix for this bug:
2498 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2500 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2502 2011-11-29 Ben Konrath <ben@bagu.org>
2504 Align details field labels and data with the Open buttons.
2506 * src/main/webapp/style.css:
2508 2011-11-29 Ben Konrath <ben@bagu.org>
2510 Remove unnecessary <div> in the Notebook widget.
2512 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2513 method to get container FlowPanel (<div>).
2514 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2515 initWidget() method directly on the TabLayoutPanel widget instead of
2516 Group's container widget.
2518 2011-11-29 Ben Konrath <ben@bagu.org>
2520 Don't add group titles for Portals in Notebooks.
2522 This reverts the previous patch and fixes a bug I introduced with
2523 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2525 * src/main/java/org/glom/web/client/ui/details/Group.java:
2526 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2528 2011-11-28 Ben Konrath <ben@bagu.org>
2530 Remove unused boolean argument in Portal constructor.
2532 Just a code cleanup.
2534 * src/main/java/org/glom/web/client/ui/details/Group.java:
2535 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2537 2011-11-28 Ben Konrath <ben@bagu.org>
2539 Remove hack for glom 1.18 style glom files.
2541 * src/main/java/org/glom/web/client/ui/details/Group.java:
2542 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2543 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2545 2011-11-28 Ben Konrath <ben@bagu.org>
2547 Use Gda Value version of primary key to log result too large error.
2549 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2551 2011-11-28 Ben Konrath <ben@bagu.org>
2553 Don't use TypedDataItem.getText() for Unknown types from the URL.
2555 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2556 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2557 instead of getText().
2558 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2559 String field and getUnknown() method.
2561 2011-11-28 Ben Konrath <ben@bagu.org>
2563 Log an error message when the java-libglom .so is not present.
2565 The error message was being set in the exception but not logged.
2567 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2569 2011-11-28 Ben Konrath <ben@bagu.org>
2571 Ignore LayoutItem_CalendarPortals.
2573 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2574 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2576 2011-11-28 Ben Konrath <ben@bagu.org>
2578 Extract method for creating the LayoutItemPortal DTO.
2580 Just breaking the code up into smaller chunks.
2582 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2584 2011-11-28 Ben Konrath <ben@bagu.org>
2588 This should have been added with the refactor. Oops!
2590 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2592 2011-11-28 Ben Konrath <ben@bagu.org>
2594 Create primary key value from URL string using type from Glom document.
2596 See this bug, comments 19 - 25:
2598 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2600 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2601 create a TypeDataItem for the primary key here when loading from a
2602 URL. Show the same string for the primary key value as was received
2603 from the URL string (when loading from a URL).
2604 * src/main/java/org/glom/web/server/Utils.java: Update method for
2605 creating the Gda Value from the TypeDataItem to properly deal with
2606 creating a Gda Value based on the Glom document type for the primary
2607 key value string when loading from a URL.
2608 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2609 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2610 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2611 Update for changed method name.
2613 2011-11-27 Ben Konrath <ben@bagu.org>
2615 Rename PrimaryKeyItem to TypedDataItem.
2617 The name PrimaryKeyItem suggests what the class should be used for.
2618 TypedDataItem is a neutral name that describes the class better.
2620 This is a rename-only refactor.
2622 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2623 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2624 * src/main/java/org/glom/web/client/Utils.java:
2625 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2626 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2627 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2628 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2629 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2630 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2631 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2632 * src/main/java/org/glom/web/server/Utils.java:
2633 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2634 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2635 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2636 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2638 2011-11-25 Ben Konrath <ben@bagu.org>
2640 Improve Gda Value conversion from PrimaryKeyItem.
2642 The value from the PrimaryKeyItem is only used if its type match the
2643 type from the glom document.
2645 * src/main/java/org/glom/web/server/Utils.java:
2647 2011-11-25 Ben Konrath <ben@bagu.org>
2649 Manually check if the java-liblgom .so is visible to the JVM.
2651 It seems that Tomcat has problems when a static initializer throws an
2652 exception. This check is done before the first method call into
2653 java-libglom so that execution doesn't continue if the .so is not
2656 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2658 2011-11-25 Ben Konrath <ben@bagu.org>
2660 Improve browser configuration error messages.
2664 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2666 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2667 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2668 getConfigurationErrorMessage() method.
2669 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2670 Get and display a specific configuration error message when no Glom
2671 documents are found.
2672 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2673 Implement getConfigurationErrorMessage() method. Surround configuration
2674 code in the init() method with a try/catch block. This allows the
2675 errors to be caught while keeping the servlet available to retrieve the
2676 configuration error message.
2678 2011-11-25 Ben Konrath <ben@bagu.org>
2680 Don't use Strings to hold primary key values.
2682 The primary key values are now held in a new data object
2683 (PrimaryKeyItem) that holds type information and the primary key value
2684 using the correct type.
2686 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2687 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2689 PrimaryKeyItem instead of String to hold the primary key value.
2690 * src/main/java/org/glom/web/client/Utils.java: Remove
2691 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2692 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2693 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2694 PrimaryKeyItem instead of String to hold the primary key value. Load
2695 document selection page when the documentID has not been set correctly.
2696 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2697 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2699 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2700 Return empty string for URL instead of "null".
2701 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2702 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2703 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2704 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2705 PrimaryKeyItem instead of String to hold primary key values.
2706 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2707 PrimaryKeyValue to a Gda Value.
2708 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2709 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2710 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2711 Replace temporary database access code that uses the PrimaryKeyValue to
2712 Gda Value conversion.
2713 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2714 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2715 PrimaryKeyItem instead of String.
2716 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2717 hold primary key values.
2719 2011-11-24 Ben Konrath <ben@bagu.org>
2721 Use newly added java-libglom API to create queries.
2723 This isn't finished. I still need to stop using Strings for primary key
2724 values in the client code.
2726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2727 libglom to use fake connections so that retrieving the query string will
2729 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2730 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2731 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2732 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2733 Use the newly added libglom sql methods and classes to create the
2734 query. Add temporary hack to convert primary value strings to Gda
2737 2011-11-23 Ben Konrath <ben@bagu.org>
2739 Don't explicitly set the height of Portals.
2741 See comments 6 - 10 of this bug for details:
2743 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2745 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2747 2011-11-23 Ben Konrath <ben@bagu.org>
2749 Use an HTML table instead of CSS for the FlowTable layout.
2751 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2752 GWT's FlexTable to implement the FlowTable.
2753 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2755 2011-11-18 Ben Konrath <ben@bagu.org>
2757 Add boolean example to HTML table mockup.
2759 * mockups/details-view-html-tables-text-entries.html:
2761 2011-11-17 Ben Konrath <ben@bagu.org>
2763 Ensure the pager buttons are always visible for related lists.
2765 To accomplish this, I've turned off text wrapping in the list view and
2766 related list tables for both the header and data text. The related list
2767 table now has a fixed layout so the it doesn't overflow its container.
2768 This is required to ensure that the cell text is clipped when it
2769 overflows the cell and an ellipsis is added to the right side of the
2770 cell when text is clipped.
2772 A fixed table layout for the related list table in the details view
2773 seems what we want for the details view anyway, so the side-effect is
2776 The ellipsis will only be displayed in Firefox >= 7.
2780 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2782 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2783 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2784 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2786 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2787 Set the 'table-layout: fixed' CSS property to the related list table.
2788 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2789 'white-space: nowrap;' CSS property on both the list view and the
2790 related list tables.
2792 2011-11-16 Ben Konrath <ben@bagu.org>
2794 Rework the fix for empty notebook tab labels.
2796 Setting the empty group titles with its name caused problems for the
2797 details layout. Instead of using libglom's
2798 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2799 to the client when the title is empty. This allows the Notebook to use
2800 the name when the title is empty without affecting anything else.
2802 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2803 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2805 2011-11-16 Ben Konrath <ben@bagu.org>
2807 Set group titles with name when title is empty.
2809 This fixes a problem with an empty notebook tab label in the Lesson
2810 Planner document. The forth tab in the notebook should be "Internet":
2812 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2814 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2815 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2818 2011-11-16 Ben Konrath <ben@bagu.org>
2820 Remove whitespace from the configured username properties.
2822 This assumes that usernames won't have whitespace at the beginning
2823 or end. But I think this is a reasonable assumption.
2825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2826 String.trim() to remove the whitespace from the username properties.
2828 2011-11-15 Ben Konrath <ben@bagu.org>
2830 Add details view mockup with HTML tables and text entries.
2832 This is from the attachment on this bug:
2834 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2836 * mockups/details-view-html-tables-text-entries.html:
2838 2011-11-15 Ben Konrath <ben@bagu.org>
2840 Add space between the columns of the flow table.
2844 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2846 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2847 space between columns in the flow table.
2849 2011-11-15 Ben Konrath <ben@bagu.org>
2851 Add backup files to the .gitignore.
2853 * .gitignore: Ignore files that end with ~.
2855 2011-11-09 Ben Konrath <ben@bagu.org>
2857 Use latest release of gwt-log.
2859 Gwt-log releases are now being submitted to the maven central
2860 repository so manual installation of the jar is no longer required.
2862 * pom.xml: Update version and groupId of gwt-log dependency.
2864 2011-10-31 Ben Konrath <ben@bagu.org>
2866 Don't use GWT numeric formatting to override the glom currency formatting.
2868 Currencies are now displayed like they are in Glom. See this bug:
2870 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2872 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2874 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2875 currency code to constructor and set it when the cell is rendered.
2876 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2877 currency code to the constructor of the NumericCell.
2879 2011-10-27 Ben Konrath <ben@bagu.org>
2881 Require the latest release of java-libglom (1.17.4).
2885 2011-10-26 Ben Konrath <ben@bagu.org>
2887 Add style to Notebook that matches current theme.
2889 It's not the best style in the world but it's better than the default.
2891 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2892 padding at the bottom of the child widgets.
2893 * src/main/webapp/style.css: Add style for the Notebook.
2895 2011-10-26 Ben Konrath <ben@bagu.org>
2897 Move servlet initialization code to overridden init method.
2899 This is half of the solution to getting proper error messages
2900 displayed when configuration errors occur. Here's the relevant bug:
2902 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2904 The rest of the solution involves surrounding the init method with a
2905 try/catch block and setting a global variable with the error /
2906 exception. A new async method should be created to retrieve and display
2907 the error message / exception.
2909 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2910 code from constructor to init method adding exceptions as needed.
2912 2011-10-26 Ben Konrath <ben@bagu.org>
2914 Add script to monitor and restart tomcat if required.
2916 * utils/check-and-recover-tomcat.py: New file.
2918 2011-10-26 Ben Konrath <ben@bagu.org>
2920 Display the correct number of data items in the pager.
2924 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2926 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2927 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2928 The implementation is the same for both tables: Keep track of the
2929 number of non-empty rows and fire and RowCountChangeEvent after the data has
2931 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2932 custom Pager class that subclasses SimplePager to handle displaying
2933 the correct number when empty rows have been added.
2935 2011-10-26 Ben Konrath <ben@bagu.org>
2937 Correct error in previous commit.
2939 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2940 eventBus parameter from listView.setCellTable().
2942 2011-10-26 Ben Konrath <ben@bagu.org>
2944 Fix error in TODO comment.
2946 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2948 2011-10-24 Ben Konrath <ben@bagu.org>
2950 Create Notebook widgets to the details view.
2952 This isn't finished just yet - I still need to create a reasonable
2953 style to match the current theme.
2955 * src/main/java/org/glom/web/client/Utils.java: Add method for
2956 calculating the height of a widget. This is used in the Notebook class.
2957 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2958 new constructor method in Group.
2959 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2960 method for creating child widget that can be used by subclasses
2961 like Notebook. New constructor that allows disabling the group
2962 titles - Notebooks don't set a group title for their child groups.
2963 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2964 to make Notebooks using GWT's TabLayoutPanel.
2965 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2966 constructor that allows disabling the group titles.
2967 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2968 LayoutItemNotebook DTO.
2969 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2970 DTO for Notebooks. It's just an empty class for now but we might need
2971 it to transfer some specific information in the future.
2973 2011-10-21 Ben Konrath <ben@bagu.org>
2975 Add navigation buttons to related list tables.
2977 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2978 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2979 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2980 method getSuitableRecordToViewDetails() for getting the table name
2981 and primary key value for related list navigation buttons.
2982 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2983 private cell renderer class to get the navigation information for
2984 related list tables from the server. Extract the navigation
2985 processing code from the details cell navigation and use it for the
2986 related list navigation as well.
2987 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2988 cell renderer class for the details open buttons. This was needed
2989 because the related list navigation buttons and the list view
2990 navigation buttons need to react differently when clicked.
2991 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2992 the onEnterKeyDown() method because it's now overriden in the
2993 subclasses that are specific to the related list tables and the list
2995 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2996 the vertical size a little because the buttons add a bit of vertical
2997 space to table. This is not a perfect solution because the vertical
2998 size of with table fewer than 5 rows will be a little smaller.
2999 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
3000 changes in how navigation buttons are handled.
3001 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
3002 getSuitableRecordToViewDetails() using the new RelatedListNavigation
3003 database access object.
3004 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
3005 to find the portal for a given relationship name from
3006 RelatedListDBAccess. Add method to find a primary key field for a
3008 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3009 Move code to find the portal for a given relationship name to
3011 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
3012 New file: database access object for getting the related list
3013 navigation information (the table name and the primary key value).
3014 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
3015 DTO for transferring a table name to navigate to and a primary key
3017 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3018 boolean and getter/setter to specifies if the related list should add
3021 2011-10-24 Murray Cumming <murrayc@murrayc.com>
3023 Use the master branch of java-libglom
3025 * pom.xml: Depend on java-libglom 1.19 instead.
3027 This is the master branch. See also the libglom-1-18 branch.
3029 2011-10-11 Ben Konrath <ben@bagu.org>
3031 Enable the open navigation button when the data has been set.
3033 This avoids having active buttons that don't do anything when the data
3036 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3038 2011-10-11 Ben Konrath <ben@bagu.org>
3040 Use IsWidget interface for FlowTableItem.
3042 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
3043 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
3045 2011-10-11 Ben Konrath <ben@bagu.org>
3047 Remove GWT styling from open button in details view.
3049 There are still some issues with how the details cell is arranged but
3050 this should be made to match Glom 1.20. I'm going to leave fixing this
3051 until I have Glom 1.20 up and running.
3053 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
3054 style name on open button.
3055 * src/main/webapp/style.css: Move and edit details-navigation class.
3056 Re-arrange some classes to make them appear in the same order as the
3059 2011-10-07 Ben Konrath <ben@bagu.org>
3061 Update to GWT 2.4.0.
3063 * .gitignore: Ignore new cache directory.
3064 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3065 * pom.xml: Change GWT and maven plugin to 2.4.0.
3066 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3068 * src/main/java/org/glom/web/client/ClientFactory.java:
3069 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3070 * src/main/java/org/glom/web/client/OnlineGlom.java:
3071 Update source for API changes.
3072 * utils/build-onlineglom-war.sh: Remove cache directory before the
3075 2011-10-07 Ben Konrath <ben@bagu.org>
3077 Add navigation buttons in the details view.
3079 This isn't finished but I thought I'd commit what I have as it's a
3080 pretty good start. I still need to:
3082 1. Change the style so that it fits better into the current theme
3083 2. Adjust the details cell to expand as much as possible.
3085 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3086 click handlers to navigation buttons in the DetailsCells. Create a
3087 refreshData() method to get just the data from the server without the
3089 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3090 Update the tableSelector and browser title when the table name
3091 changes without using the tableSelector.
3092 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3093 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3094 getDetailsCells() to getCells(). Update variable names.
3095 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3096 method to set click handler on navigation button. Rename a few
3097 variables. Add navigation buttons where needed.
3098 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3099 variables and methods.
3100 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3101 navigation boolean and navigation table as required in the
3102 LayoutItemField DTO.
3103 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3104 variables for navigation along with getter/setter methods.
3106 2011-10-07 Ben Konrath <ben@bagu.org>
3108 Rename Field to DetailsCell.
3110 This is a refactor-only commit. No functionality has been added or
3113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3114 Update variable and method names.
3115 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3116 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3117 variable and method names.
3118 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3120 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3121 variable and method names.
3123 2011-10-07 Ben Konrath <ben@bagu.org>
3125 Create separate methods for layout and data the details view.
3127 This is a refactor-only commit. No functionality has been added or
3130 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3131 private methods: setData(), createLayout().
3133 2011-10-07 Ben Konrath <ben@bagu.org>
3135 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3137 This is part of a change to get navigation buttons in the details view
3138 but it should have been done this way from the start.
3140 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3141 for method name change in TableSelectionView.
3142 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3143 Create TableChangeEvent and set the browser title using the
3144 TableSelectionView API.
3145 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3146 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3147 Change getSelectedTable() to getSelectedTableName(). Add
3148 getSelectedTableTitle().
3150 2011-10-07 Ben Konrath <ben@bagu.org>
3152 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3154 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3156 2011-10-07 Ben Konrath <ben@bagu.org>
3158 Update TableChangeEvent to use newTableName naming convention.
3160 This makes the class more consistent with GWT naming conventions.
3162 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3163 Update for method name change in TableChangeEvent.
3164 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3165 for method name change in TableChangeEvent.
3166 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3167 newTableName variable and getter method. Make toDebugString()
3170 2011-09-30 Ben Konrath <ben@bagu.org>
3172 Disable the pager in the list tables when the data row count is less than the minimum.
3174 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3175 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3177 2011-09-30 Ben Konrath <ben@bagu.org>
3179 Add empty rows to the end of related list and list view tables.
3181 I also extracted the cell rendering classes from the ListTable because
3182 the code was becoming a little crazy with all the anonymous inner
3183 classes. My plan is to use these cell rendering classes in the details
3184 view as well so this refactor will be needed for that change.
3186 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3187 set the row count in related list tables if the data has more rows
3188 than the minimum number of rows visible.
3189 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3190 row count in list view tables if the data has more rows than the
3191 minimum number of rows visible.
3192 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3193 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3195 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3196 for rendering TYPE_NUMERIC cells. The code was extracted from the
3198 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3199 class for rendering cells with buttons in list views. The code was
3200 extracted from the ListTable class.
3201 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3202 for rendering TYPE_TEXT cells. The code was extracted from the
3204 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3205 Add empty rows to the end of the data if required. Implement
3206 ListTable.getMinNumVisibleRows().
3207 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3208 cell renderer code to public classes. Return null in
3209 Column.getValue() for empty rows. Add new abstract method:
3210 getMinNumVisibleRows(). Move code to set the row count of the list view
3211 table to ListViewImpl.
3212 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3213 empty rows to the end of the data if required. Implement
3214 ListTable.getMinNumVisibleRows().
3217 2011-09-27 Ben Konrath <ben@bagu.org>
3219 Use GWT.log for client-side debugging statements.
3221 These are optimized out when deployed so I should have used this method
3222 in the first place. These statements will eventually be replaced with some sort
3223 of notification in the browser.
3225 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3226 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3227 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3228 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3229 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3231 2011-09-27 Ben Konrath <ben@bagu.org>
3233 Put tableselector on the right, back to list link on right.
3235 The idea is that the table selector is acting like a label for the
3236 currently displayed table so it should be placed below the document title. This
3237 puts the table title in a similar position to where it is in Glom.
3239 * mockups/details-contacts.html:
3240 * mockups/details-projects.html:
3241 * mockups/listview-contacts.html:
3242 * mockups/listview-projects.html:
3243 * mockups/style.css:
3244 Update mockups to match how the interfaces currently look.
3245 * src/main/webapp/style.css: Swap positions of backlink with the table
3246 selector. Add some space on the left side of the table selector to
3247 line things up with the document title.
3249 2011-09-27 Ben Konrath <ben@bagu.org>
3251 Add field colouring to details view.
3253 This change re-works how field colouring works. The colour formatting
3254 information is now set to the client with the layout information instead of
3255 with the data. This eliminates the need to send the same colour strings for
3256 data in list view column when colour information is set.
3258 In order to set an alternate colour for negative numeric values, the
3259 number is now sent to client and formatted with the GWT NumberFormat class.
3261 This change also fixes:
3263 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3265 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3266 internationalization framework which is