1 2012-11-09 Murray Cumming <murrayc@murrayc.com>
3 Use the latest (now stable) version of GWT.
5 * pom.xml: And the latest version of the gwt-maven-plugin.
7 2012-11-08 Murray Cumming <murrayc@murrayc.com>
9 Added an Indonesian translation.
11 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
12 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
13 This is from the new translation in Glom.
15 2012-07-23 Murray Cumming <murrayc@murrayc.com>
19 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
21 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
23 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
24 for serving image data.
25 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
27 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
28 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
29 setData(): For image field types, add a GWT Image widget,
30 with the URL that was set in the DataItem.
32 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
33 * src/main/java/org/glom/web/server/database/DBAccess.java:
34 convertResultSetToDTO(): Set the URL for image data, so the client browser
35 can retrieve the image from our new servlet. This uses UriBuilder.
36 Move getPrimaryKeyField to:
37 * src/main/java/org/glom/web/server/libglom/Document.java:
38 Added getTablePrimaryKeyField().
40 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
41 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
42 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
45 2012-07-22 Murray Cumming <murrayc@murrayc.com>
49 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
50 * src/main/java/org/glom/web/client/OnlineGlomService.java:
51 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
52 to gwtGlom, which is more appropriate.
53 This servlet name does not seem to be visible to the client side anyway.
55 2012-07-22 Murray Cumming <murrayc@murrayc.com>
57 Tests: Make the imports of assert*() consistent.
59 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
60 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
61 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
62 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
63 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
64 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
65 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
66 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
67 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
68 * src/test/java/org/glom/web/shared/DataItemTest.java:
70 import static org.junit.Assert.*;
71 which seems fairly common.
75 2012-07-21 Murray Cumming <murrayc@murrayc.com>
77 tests: Move a test that needs a database connection.
79 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
80 Move testGetListViewLayoutGroup() to
81 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
82 because it needs a database connection.
84 2012-07-21 Murray Cumming <murrayc@murrayc.com>
86 tests: Use @BeforeClass on tearDown().
88 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
89 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
90 This avoids leaking a postgres process in SelfHostExampleTest.
92 2012-07-21 Murray Cumming <murrayc@murrayc.com>
94 tests: Test translations more.
96 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
97 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
98 Test titles in the non-default locale.
100 2012-07-21 Murray Cumming <murrayc@murrayc.com>
102 tests: Add SelfHostConfiguredDocumentTest
104 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
105 username and password, for use by ConfiguredDocument.
106 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
107 This tests some of the ConfiguredDocument API that requires a database connection.
109 2012-07-21 Murray Cumming <murrayc@murrayc.com>
111 Document: Load title translations and test them.
113 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
114 of titles. I am surprised that we do not do this yet.
115 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
116 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
117 Test translations more.
119 2012-07-20 Murray Cumming <murrayc@murrayc.com>
123 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
124 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
125 Set the timeout here too.
127 2012-07-20 Murray Cumming <murrayc@murrayc.com>
129 tests: ConfiguredDocumentTest: Make this pass.
131 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
132 Disable tests that need a database connection.
134 2012-07-20 Murray Cumming <murrayc@murrayc.com>
136 Use Java 1.7 instead of Java 1.6.
138 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
139 to do this twice, at least for Eclipse.
140 This seems OK because it is the current version.
142 2012-07-20 Murray Cumming <murrayc@murrayc.com>
146 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
147 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
148 Avoid using a null Connection.
150 2012-07-20 Murray Cumming <murrayc@murrayc.com>
152 tests: Add a ConfiguredDocument test.
154 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
157 2012-07-20 Murray Cumming <murrayc@murrayc.com>
159 LayoutItemFIeld: getName(): Use the Field if it is set.
161 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
162 getName(): If the full field details have been set, return its name, so that
163 callers do not need to set the name separately.
164 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
165 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
166 so we can count the rows.
168 2012-07-20 Murray Cumming <murrayc@murrayc.com>
170 tests: SelfHoster: Test SqlUtils too.
172 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
173 Retrieve some data and check it too, as in the regular Glom
174 test_selfhosting_new_from_example.cc test.
175 * src/test/java/org/glom/web/server/SelfHoster.java:
176 createConnection(): Make this public.
178 2012-07-20 Murray Cumming <murrayc@murrayc.com>
180 tests: SelfHoster: createConnection(): Do not warn about expected failures.
182 Let the caller say if the connection is expected to fail, to avoid
183 irrelevant error output.
185 2012-07-20 Murray Cumming <murrayc@murrayc.com>
187 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
189 * src/test/java/org/glom/web/server/SelfHoster.java:
190 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
191 due to the inevitable need to retry the connection while the database server
194 2012-07-20 Murray Cumming <murrayc@murray.com>
196 tests: SelfHoster: createConnection(): Set a timeout.
198 * src/test/java/org/glom/web/server/SelfHoster.java:
199 createConnection(): Use setLoginTimeout() because it otherwise seems to take
200 ages to actually return when it fails.
202 2012-07-20 Murray Cumming <murrayc@murrayc.com>
204 tests: SelfHoster: selfHost(): Close the test connection.
206 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
207 When we check that the connection works, close the connection. This seems
208 to not be closed automatically otherwise.
210 2012-07-20 Murray Cumming <murrayc@murrayc.com>
212 Use slf4j-simple to see JDBC errors.
214 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
216 2012-07-19 Murray Cumming <murrayc@murrayc.com>
218 SelfHoster.discoverFirstFreePort(): Close the socket.
220 * src/test/java/org/glom/web/server/SelfHoster.java:
221 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
223 2012-07-19 Murray Cumming <murrayc@murrayc.com>
225 Avoid another code warning in Eclipse Juno.
227 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
228 Do instanceof checks on the FileUtils.listFiles() result and its
231 2012-07-13 Murray Cumming <murrayc@murrayc.com>
233 Avoid some code warnings in Eclipse Juno
235 * src/main/java/org/glom/web/server/libglom/Document.java:
236 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
237 * src/test/java/org/glom/web/server/SelfHoster.java
238 createTextFile(): Make sure that the FileOutputStream is closed.
240 2012-06-22 Murray Cumming <murrayc@murrayc.com>
242 Added OnlineGlomPropertiesTest.
244 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
245 Make sure we never return a null string.
246 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
247 Added tests of the OnlineGlomProperties API, using our sample file.
249 2012-06-20 Murray Cumming <murrayc@murrayc.com>
251 Make OnlineGlomProperties be a normal class.
253 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
254 Move OnlineGlomProperties into its own file to be a regular class:
255 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
256 This makes testing simpler.
258 2012-06-15 Murray Cumming <murrayc@murrayc.com>
260 OnlineGlomServiceImpl.init(): Move some code into a new method.
262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
263 Create addDocument().
265 2012-06-15 Murray Cumming <murrayc@murrayc.com>
267 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
270 OnlineGlomProperties.getKey(): Make this more robust by moving the
271 check for *.*.filename to here.
273 2012-06-15 Murray Cumming <murrayc@murrayc.com>
275 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
278 init(): Move knowledge of the config file format into the
279 OnlineGlomProperties inner class.
281 2012-06-15 Murray Cumming <murrayc@murrayc.com>
283 SelfHostExampleTest: Make sure we cleanup on failure.
285 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
286 the use of cleanup() to a tearDown() JUnit method.
290 2012-06-12 Murray Cumming <murrayc@murrayc.com>
292 ConfiguredDocument: Add a primary key to portals at least once.
294 * src/main/java/org/glom/web/server/ConfiguredDocument.java
295 updatePortalsExtras): Fix a typo so that we add the primary key
296 column at least once.
297 This is a fix for the previous commit:
298 ConfiguredDocument: Do not add a primary key to portals each time.
300 2012-06-08 Murray Cumming <murrayc@murrayc.com>
302 SelfHoster: Avoid some compiler warnings.
304 * src/test/java/org/glom/web/server/SelfHoster.java
305 executeCommandLineAndWait():
306 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
307 the now-unused streams for stdout and stderr from the command Processes.
308 These are not used because readln() hangs while waiting for a new line,
309 where there may be no next line. The commented out code is still there
310 to help us figure out how to do this properly.
312 2012-06-08 Murray Cumming <murrayc@murrayc.com>
314 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
316 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
317 Make this actually test the cloning again, though it is not very useful
318 now that we do not use the part that had a problem with cloning before.
320 2012-06-08 Murray Cumming <murrayc@murrayc.com>
322 SelfHoster: Keep trying pg_ctl after starting postgres.
324 * src/test/java/org/glom/web/server/SelfHoster.java
325 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
326 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
327 regular Glom. This seems mad but it seems to work because the first
328 command would fail if pg_ctl would eventually fail.
330 2012-06-08 Murray Cumming <murrayc@murrayc.com>
332 SelfHoster: Wait until the server is really ready.
334 * src/test/java/org/glom/web/server/SelfHoster.java
335 selfHost(): Attempt the connection after starting the server, retrying
336 a few times if necessary, so that the server is really ready already when
337 we return from this method.
338 The regular Glom code does this too because pg_ctl reports success too soon.
340 2012-06-08 Murray Cumming <murrayc@murrayc.com>
342 ConfiguredDocument: Do not add a primary key to portals each time.
344 * src/main/java/org/glom/web/server/ConfiguredDocument.java
345 updatePortalsExtras(): Only add an extra primary key field if there is
346 none, to avoid adding one each time we retrieve the details layout from the
348 This should fix bug #676986 (Ben Konrath)
350 2012-05-25 Murray Cumming <murrayc@murrayc.com>
352 Document.load(): Support version 7 documents.
354 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
355 database_title attribute if the title attribute is not there.
358 2012-05-24 Ben Konrath <ben@bagu.org>
360 Add configuration for auto-generating mvn:i18n from with Eclipse.
362 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
364 2012-05-24 Murray Cumming <murrayc@murrayc.com>
366 Update translations, adding French.
368 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
369 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
370 Add a French translation, using the translation from Glom.
372 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
373 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
374 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
375 Update these based on the translations from Glom.
377 2012-05-24 Murray Cumming <murrayc@murrayc.com>
379 SelfHoster: Add some debug println messages to help when things fail.
381 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
382 System.out.println() lines.
384 2012-05-23 Murray Cumming <murrayc@murrayc.com>
386 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
388 * src/test/java/org/glom/web/server/SelfHoster.java:
389 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
390 instance) instead of just /usr/bin (as on Fedora). Check the result when
393 2012-05-23 Murray Cumming <murrayc@murrayc.com>
395 Remove LayoutItemPortal.get/setNavigationTable().
397 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
398 Remove get/setNavigationTable(), which is only a cache, because it is not
399 used, and does not need to be used, because that decision should be made on
401 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
402 updatePortalsExtras():
403 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
404 getNavigationRecord():
405 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
408 2012-05-21 Murray Cumming <murrayc@murrayc.com>
410 Initial self-hosting for tests.
412 * pom.xml: Change the scope for log4j, to hopefully make it
413 available to the test code which uses it indirectly via jOOQ.
414 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
415 self-hosting, though we only use it for testing.
417 * src/main/java/org/glom/web/server/libglom/Document.java:
418 example rows: Use a map instead of a list for each row of values,
419 so we know what field they are for, instead of relying on the sequence
420 being correct. This is not very efficient, but it does not really need
422 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
423 testReadTableExampleRows(): Adapted.
425 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
426 that returns an Object, for generic use. Note that Object seems to be
427 the implicit base even of double.
428 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
429 for use in CREATE TABLE SQL queries.
430 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
431 to do self-hosting of PostgreSQL databases via its command-line
432 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
433 backends/postgres_self.cc. This is incomplete - it needs more
434 warnings about failures and it needs to clean up properly when things
436 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
437 test of this new class.
439 2012-05-21 Murray Cumming <murrayc@murrayc.com>
441 Document: loading example data: Handle exceptions.
443 * src/main/java/org/glom/web/server/libglom/Document.java:
444 DateFormat.parse() and Double.valueOf() can throw exceptions, though
445 Eclipse did not warn about that.
447 2012-05-20 Murray Cumming <murrayc@murrayc.com>
449 Document: load(), save(): Handle the example rows.
451 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
453 * src/main/java/org/glom/web/server/libglom/Document.java:
454 load(), save(): Load and save the example rows, though the date, time
455 and image types are not handled properly yet.
456 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
457 Add testReadTableExampleRows() just to check that something is read.
459 2012-05-20 Murray Cumming <murrayc@murrayc.com>
461 Document: Add save().
463 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
464 Added getTranslationsMap() for use while saving.
465 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
466 Adedd getUseDefaultFormatting() for use while saving.
467 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
468 and several private methods that it uses.
470 This will be useful while testing via self-hosting.
471 It is not complete, but should be complete enough for testing.
473 2012-05-17 Murray Cumming <murrayc@murrayc.com>
475 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
477 * src/main/java/org/glom/web/client/OnlineGlomService.java
478 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
480 Remove getSortedListViewData() and getSortedRelatedListData(), adding
481 the sort column index and ascending bool to the regular method.
482 Instead, a sort column index of -1 now means no sort.
483 This is less explicit, but it's fairly simple, reduces the amount of
484 code, and makes the OnlineGlomService API slightly smaller.
485 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
486 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
488 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
489 getListViewData(), getRelatedListData():
490 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
491 getListViewData(), getRelatedListData():
492 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
494 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
496 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
501 2012-05-16 Murray Cumming <murrayc@murrayc.com>
503 Use translations for top-level groups too.
505 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
506 updateTitlesForLocale(): Use the translation for the group
507 as well as for child items.
511 Just recompiled to fix a problem in the released .tar.gz file.
515 2012-05-15 Murray Cumming <murrayc@murrayc.com>
517 Corrections to navigation to related records.
519 * src/main/java/org/glom/web/client/OnlineGlomService.java:
520 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
521 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
522 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
523 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
524 relationship name, because the relationship name is not necessarily unique
526 TOOD: This is inefficient, because it passes the whole list of
527 child field items back to the server, but it is more correct, and happens
528 to fix a bug with the primary key being lost after a few navigations.
529 There is probably a chance to make this more efficient anyway in some
532 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
533 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
534 * src/main/java/org/glom/web/server/ConfiguredDocument.java
535 * src/main/java/org/glom/web/server/database/DBAccess.java
536 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
537 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
540 2012-05-15 Murray Cumming <murrayc@murrayc.com>
542 Fix the use of translations.
544 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
545 Add updateTitlesForLocale().
546 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
547 Call it to discard unwanted translations and to make getTitle() return
548 the wanted translation wihout the need for the client code to specify a locale.
549 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
550 getTitle(): Fallback to the original title, as libglom does.
552 2012-05-15 Murray Cumming <murrayc@murrayc.com>
554 Document: Correctly report the number of available translation locales.
556 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
557 the available locale IDs list.
558 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
559 testLocales: Test this.
561 2012-05-15 Murray Cumming <murrayc@murrayc.com>
563 SqlUtils: Use camelCase.
565 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
566 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
567 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
568 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
569 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
570 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
572 2012-05-15 Murray Cumming <murrayc@murrayc.com>
574 Use jOOQ's tableByName() and fieldByName.
576 * pom.xml: Use jOOQ 2.3.1 to get the new API.
577 * src/main/java/org/glom/web/server/SqlUtils.java:
578 build_sql_select_step_with_where_clause(), .createField(),
579 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
580 so we can get correct quoting and escaping. Thanks to Lukas Eder for
581 adding this, and other things, to jOOQ.
583 2012-05-15 Murray Cumming <murrayc@murrayc.com>
585 SqlUtils: Remove the Connection parameters.
587 * src/main/java/org/glom/web/server/SqlUtils.java:
588 build_sql_select_with_key(), build_sql_select_with_where_clause(),
589 createSelect(), build_sql_select_step_with_where_clause(),
590 build_sql_count_select_with_where_clause(),
591 build_sql_select_count_rows(): Remove the Connection parameter because
592 jOOQ does not actually need a connectionwhen it is just used to build
594 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
596 * src/main/java/org/glom/web/server/ReportGenerator.java:
598 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
600 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
601 Constructor, getListData(), getResultSizeOfSQLQuery():
602 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
603 getSelectQuery(), getCountQuery():
604 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
605 getSelectQuery(), getCountQuery():
606 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
607 getNavigationRecord(): Adapted.
609 2012-05-14 Murray Cumming <murrayc@murrayc.com>
613 * src/main/java/org/glom/web/server/SqlUtils.java:
614 get_find_where_clause_quick(): Use a comparison of
615 lowercase values, instead of a simple equals. Regular Glom
616 uses the PostgreSQL ILIKE operator but jOOQ does not
617 support that just yet, though it will soon.
619 2012-05-14 Murray Cumming <murrayc@murrayc.com>
621 TableToViewDetails: Use a real serialization ID.
623 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
624 Though this does not fix the serialization problem.
626 2012-05-12 Murray Cumming <murrayc@murrayc.com>
628 Added LayoutItemPortalDeepCloneTest.
630 2012-05-11 Murray Cumming <murrayc@murrayc.com>
632 Make navigation work again.
634 * src/main/java/org/glom/web/server/libglom/Document.java:
635 Add getLayoutItemFieldShouldHaveNavigation().
636 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
637 Replace get/setAddNavigation() with the partly-existing
638 get/setNavigationTableName(), with an empty string being no navigation,
639 because this is simpler. Use the new
640 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
642 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
643 Add updateFieldsExtras() and call setNavigationTableName in it.
644 getDetailsLayoutGroup(),
645 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
646 createLayout(): Adapted.
647 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
648 Constructor: Adapted.
650 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
651 Replace get/setAddNavigation() with get/setNavigation(), returning a
652 TableToViewDetails class with both the table name and UsesRelationship,
653 because both are need. The previous code used java-libglom's output
654 variable (strangely, via sharedptr) to return both, but we cannot really
656 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
657 getNavigationRecord(): Adapt. However, we cannot actually use the cache
658 here because it somehow gets set to null during deepCopy(). I must test this.
659 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
660 testGetSuitableTableToViewDetails(): Adapted.
662 TODO: Find out why deepClone() is not quite working.
664 2012-05-11 Murray Cumming <murrayc@murrayc.com>
666 DBAccess: Simplify the retrievel of full field details.
668 * src/main/java/org/glom/web/server/database/DBAccess.java
669 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
670 because the Document loading should have done this.
672 2012-05-11 Murray Cumming <murrayc@murrayc.com>
674 Document: Correct loading of doubly-related layout fields.
676 * src/main/java/org/glom/web/server/libglom/Document.java:
677 loadUsesRelationship(): Actually set the related relationship, instead
678 of only setting it if it's not found.
680 2012-05-09 Murray Cumming <murrayc@murrayc.com>
682 Replace all appearances of Colour with color.
684 Because US English is dominant.
686 2012-05-09 Murray Cumming <murrayc@murrayc.com>
688 Use colors in HTML format, solving a warning about an unused function.
690 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
691 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
692 Add *asHTMLColor() versions of methods.
693 TODO: However, we should create and cache the results on the server.
694 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
695 * src/main/java/org/glom/web/client/ui/list/ListTable.java
696 * src/main/java/org/glom/web/server/ConfiguredDocument.java
697 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
698 Use the asHTMLcolor() versions.
700 2012-05-09 Murray Cumming <murrayc@murrayc.com>
702 ListViewTable: Constructor: Take the table name as a parameter.
704 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
705 Constructor: Take the tableName, and set the member variable, because
707 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
708 setCellTable(): Pass the table name.
709 This makes navigation to non-default tables work again. I don't know
710 why it worked before in the master branch.
712 2012-05-07 Murray Cumming <murrayc@murrayc.com>
714 ConfiguredDocument: Restore correct addition of hidden primary key items.
716 * src/main/java/org/glom/web/client/ui/list/ListTable.java
717 (ListTable.createCellTable): Uncomment out the check for the hidden
719 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
720 add primary key items for top-level lists and portals, as before,
721 instead of adding them to each group.
722 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
723 Actually implement the extra methods such as setHiddenPrimaryKey() and
724 comment that these are used only for top-level list groups and in portals.
725 This strangeness suggests even more that this should not be squeezed
726 into the LayoutGroup class.
728 2012-05-07 Murray Cumming <murrayc@murrayc.com>
730 Fix Formatting loading.
732 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
733 getFormattingUsed(): Remove the duplicate Formatting member variable
734 in favour of the one from the base class.
735 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
736 Initialize a new Formatting instead of using null by default, so we
737 have some defaults, instead of having to initialize one later just to
738 get the same defaults. This also makes loading of formatting from the
739 document work, because that expected a non-null.
741 2012-05-07 Murray Cumming <murrayc@murrayc.com>
743 RelatedListTable: Make sure that the tableName is set.
745 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
746 Constructor: Take the tableName so it is available later. Otherwise,
747 the server assumes that we mean the default table and cannot find the
749 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
750 setData(): Pass the tableName to the RelatedListTable constructor.
752 2012-05-07 Murray Cumming <murrayc@murrayc.com>
756 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
757 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
758 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
760 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
762 * src/main/java/org/glom/web/server/database/DBAccess.java:
763 convertResultSetToDTO(), getPortal():
764 * src/main/java/org/glom/web/server/database/ListDBAccess.java
766 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
767 Add checks for null objects and out of range access, with log messages to
768 give hints so we can fix these properly.
770 2012-05-07 Murray Cumming <murrayc@murrayc.com>
772 Portals: some corrections.
774 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
776 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
777 constructor: Use getRelationshipNameUsed() instead of getName(), because
778 that is what is meant.
779 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
780 getFromField(): Fix a typo, to get the field name, not the table name.
781 * src/main/java/org/glom/web/server/database/DBAccess.java:
782 getPortal(): Fix a typo that stopped this from working.
784 2012-05-07 Murray Cumming <murrayc@murrayc.com>
786 LayoutItemPortal: Also override getTitleOriginal().
788 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
789 This lets the base getTitle() with no parameters work.
790 TODO: Test this properly.
792 2012-05-06 Murray Cumming <murrayc@murrayc.com>
794 LayoutItemPortal: getTitle*(): Use the relationship title.
796 2012-05-06 Murray Cumming <murrayc@murrayc.com>
798 LayoutItemField: Fix loading of custom titles.
800 * src/main/java/org/glom/web/server/libglom/Document.java
801 loadDataLayoutItemField(): The title, if any, instead of the field
802 title, is stored in a title_custom node. Load it from there.
803 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
805 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
806 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
807 getTitle*() overrides.
808 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
811 2012-05-06 Murray Cumming <murrayc@murrayc.com>
813 LayoutItemField: Fall back to field titles, so some are really shown.
815 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
816 Override getTitleOriginal() and getTitle(), as in java-libglom.
817 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
820 2012-05-06 Murray Cumming <murrayc@murrayc.com>
822 Correct use of setExpectedResultSize().
824 * src/main/java/org/glom/web/server/ConfiguredDocument.java
825 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
826 Use setExpectedResultSize only on top-level groups (for instance, the
827 list layout) or on child portals (in details views).
828 Use the correct table name for portals to avoid SQL errors.
829 Update the expected counts when returning cached layouts.
831 2012-05-06 Murray Cumming <murrayc@murrayc.com>
833 Document: Interpret no group column count as 1.
835 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
836 default, though we now check for this in the UI code anyway.
838 2012-05-06 Murray Cumming <murrayc@murrayc.com>
842 2012-05-06 Murray Cumming <murrayc@murrayc.com>
844 Translatable: Use Hashmap instead of Treemap because GWT supports it.
846 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
847 The use of Treemap lead to this error from async methods, with no
849 "The response could not be deserialized"
851 2012-05-06 Murray Cumming <murrayc@murrayc.com>
853 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
855 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
856 when using the Google -> GWT Compile, or
857 g toolbar button -> GWT Compile Project... feature in Eclipse.
859 2012-05-06 Murray Cumming <murrayc@murrayc.com>
861 ListTable.addColumn(): Protect against a null Formatting.
863 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
864 Create a default Formatting if it is null, because that is the simplest
867 2012-05-06 Murray Cumming <murrayc@murrayc.com>
869 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
871 * src/main/java/org/glom/web/server/ConfiguredDocument.java
872 updateLayoutGroup(): Check that the field is not null.
874 2012-05-06 Murray Cumming <murrayc@murrayc.com>
876 ListViewImpl: Protected against a bad cast error.
878 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
879 onEnterKeyDown(): Do not cast without an instanceof check.
881 2012-05-06 Murray Cumming <murrayc@murrayc.com>
883 ListTable: Protect against an out of range error.
885 * src/main/java/org/glom/web/client/ui/list/ListTable.java
886 createCellTable(): This is unlikely, but can happen while debugging.
888 2012-05-06 Murray Cumming <murrayc@murrayc.com>
890 AsyncMessage onFailure() callbacks: Log the exception message.
892 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
893 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
894 * src/main/java/org/glom/web/client/activity/ListActivity.java:
895 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
896 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
897 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
898 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
899 These are useful clues when something is wrong.
901 2012-05-06 Murray Cumming <murrayc@murrayc.com>
903 ConfiguredDocument: Avoid a null dereference.
905 * src/main/java/org/glom/web/server/ConfiguredDocument.java
906 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
907 details maps are created.
909 2012-05-06 Murray Cumming <murrayc@murrayc.com>
911 Document: Correct the port number parsing.
913 * src/main/java/org/glom/web/server/libglom/Document.java:
914 This lets us actually connect to the database and show the document.
916 2012-05-05 Murray Cumming <murrayc@murrayc.com>
920 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
921 user-interaction, asking us to load a temporary URL in a browser.s
922 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
923 which is apparently necessary for testing the service. See the comment.
924 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
925 Show the exception, if any. This is how I saw the 404 in the HTML in
928 2012-05-05 Murray Cumming <murrayc@murrayc.com>
930 DocumentTest: Move the .glom files into the resources directory.
932 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
933 URI via getResource().
935 2012-05-05 Murray Cumming <murrayc@murrayc.com>
937 Document: Remove the FieldIdentifies inner class.
939 * src/main/java/org/glom/web/server/libglom/Document.java: We only
940 use the Relationship (though the same function in libglom is maybe
941 used in other ways) and so this removes a compiler warning.
943 2012-05-05 Murray Cumming <murrayc@murrayc.com>
945 Document.load() Remove the error code parameter.
947 * src/main/java/org/glom/web/server/libglom/Document.java: load():
948 Remove the parameter. We do not set it yet and it could never have
949 worked as an output parameter (though maybe it did in java-libglom).
950 We could use an exception if we really want the failure reason.
951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
953 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
954 setUp(), testGetSuitableTableToViewDetails(): Adapt.
956 2012-05-05 Murray Cumming <murrayc@murrayc.com>
958 Make some inner classes static.
960 * src/main/java/org/glom/web/server/ConfiguredDocument.java
961 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
962 * src/main/java/org/glom/web/server/ReportGenerator.java
963 * src/main/java/org/glom/web/server/libglom/Document.java
964 Make all inner classes static that can be static.
966 2012-05-05 Murray Cumming <murrayc@murrayc.com>
968 OnlineGlomServiceImpl: Do not load and check for java-libglom.
970 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
971 init(): We do not use java-libglom any more.
973 2012-05-05 Murray Cumming <murrayc@murrayc.com>
975 Remove mentions of java-libglom.
977 * README: Remove mention of java-libglom, because it no longer needed.
978 * utils/build-onlineglom-war.sh:
979 * utils/check-and-recover-tomcat.py:
980 * utils/install-onlineglom-war.sh: Remove these as they are no longer
981 useful. Building is now far easier, with no need for jhbuild.
983 2012-05-05 Murray Cumming <murrayc@murrayc.com>
985 Fix the build (mvn package)
987 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
988 (LayoutGroup): Make the LayoutItemList inner class static and protected.
989 Otherwise the GWT Java->Javascript compilation fails with just this
990 error, during mvn package or when attempting to view in a browser,
991 in the GWT developer mode in Eclipse.
993 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
994 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
995 [INFO] Compiling module org.glom.web.OnlineGlom
996 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
997 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
998 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
999 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1000 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1001 [INFO] [ERROR] Cannot proceed due to previous errors
1003 It has taken me 2 days to find out what was causing that. After reducing
1004 the code, the compiler eventually showed me the full error message.
1006 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1008 ConfiguredDocument: Cache the cloned and stripped layouts.
1010 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1011 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1012 layout in a map, so we can retrieve it again without rebuilding it.
1014 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1016 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1018 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1020 libglom classes: Implement some auto-generated emthods.
1022 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1024 Add GwtTestOnlineGlomService.
1026 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1027 However, this (and the other GwtTest*) does not seem to run during
1030 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1032 Remove use of unsupported features from client code.
1034 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1035 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1036 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1037 Use our client version of StringUtils instead of the apache commons one.
1039 However, the GWT Javascript compliation still fails.
1041 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1043 Add a Field class and implement some loading of it in Document.
1045 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1047 Initial Document loading implementation, instead of libglom.
1049 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1050 and Translatable classes, and adapt the rest of the code to use them.
1051 However, this is still missing Layout and Field classes and loading.
1053 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1055 Use of jOOQ: Move Field creation into a utility method.
1057 * src/main/java/org/glom/web/server/SqlUtils.java:
1058 This lets us improve it more easily.
1060 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1062 Use of jOOQ: Improve the code to COUNT a sub-select.
1064 * src/main/java/org/glom/web/server/SqlUtils.java:
1065 Move initial query creation into
1066 build_sql_select_step_with_where_clause().
1067 build_sql_select_count_rows(): Use the jOOQ API instead of
1068 concatentating text, because a jOOQ Select*Step is a TableLike,
1069 which is what from() takes.
1071 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1073 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1075 * pom.xml: Depend on jooq.
1076 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1077 methods with jOOQ, based on the C++ implementations in libglom,
1078 with some changes to the logic required by jooQ.
1079 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1081 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1082 * src/main/java/org/glom/web/server/ReportGenerator.java:
1083 * src/main/java/org/glom/web/server/SqlUtils.java:
1084 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1085 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1086 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1087 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1088 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1089 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1090 because jOOQ needs that, though it seems unnecessary.
1092 This is not quite finished. Ideally jOOQ would help us to build
1093 table_name.field_name names, quoting and escaping them properly.
1094 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1096 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1098 Move use of Glom.build_sql*() into a new SqlUtils class.
1100 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1101 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1102 but this will make it easier to start using something other than
1103 libglom or SqlBuilder.
1105 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1107 Update the project URL.
1109 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1111 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1113 Main layout: Use a FlowTable instead of absolute positioning.
1115 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1116 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1117 child panels/widgets must have an absolute position. But that is annoying, so
1118 this adds a FlowTable and puts the child panels in there.
1120 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1122 GwtTestOnlineGlom: Comment out unused code.
1124 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1125 Eclipse has started to say that some code is unused.
1127 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1129 Update to the latest versions of dependencies.
1131 * pom.xml: Update version numbers of dependencies to the latest
1133 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1135 * src/main/java/org/glom/web/server/ReportGenerator.java:
1136 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1137 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1138 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1140 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1141 Modify the imports where necessary.
1143 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1145 Style: Remove overflow:hidden from searchbox
1147 * src/main/webapp/style.css: Because this pushes the Back To Link
1148 label/link on to the next row, which is then hidden due to the
1149 hard-coded (in ems) height.
1151 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1153 Remove some duplicate code.
1155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1156 getDocumentInfo(): This must have been duplicated during the merge from the
1161 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1163 Reports: Localize the waiting for report message.
1165 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1166 start(): Get the message from the contants.
1167 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1168 Add the string here.
1169 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1170 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1171 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1172 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1173 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1174 Update these files with the English text for newer strings for now.
1176 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1178 Reports: Show a message while waiting for the report.
1180 * src/main/java/org/glom/web/client/ui/ReportView.java
1181 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1182 Add setWaitingText(), to show a message saying that we are
1183 waiting for the report to be ready.
1184 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1185 start(): Call setWaitingText() before calling the async
1188 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1190 ReportGenerator: Specify date and time formats.
1192 * src/main/java/org/glom/web/server/ReportGenerator.java:
1193 createFieldValueElement(): Use the default (and localized)
1194 short formats, though we still need a way to show 4-digit
1195 years without providing the format for every locale.
1196 * src/main/java/org/glom/web/server/database/DBAccess.java:
1197 convertResultSetToDTO(): Use the short formats here too.
1199 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1201 ReportGenerator: Use the correct numeric formatting.
1203 * src/main/java/org/glom/web/server/ReportGenerator.java
1204 createFieldExpression(), createFieldValueElement(): Take the
1205 whole LayoutItem_Field instead of just the field name, so
1206 we have access to the formatting.
1207 createFieldValueElement(): Use JRTextField.setPattern() to
1208 specify the numeric formatting, with the help of a
1209 regular DecimalFormat.
1211 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1213 ReportGenerator: Avoid showing null for group by titles.
1215 * src/main/java/org/glom/web/server/ReportGenerator.java
1216 generateReport(): Use setBlankWhenNull() on the field title
1217 style too, because this is used for values in group by
1220 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1222 ReportGenerator: Add a colon to titles in vertical groups.
1224 * src/main/java/org/glom/web/server/ReportGenerator.java
1225 addFieldToDetailBandVertical(): Pass true for the withColon
1228 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1230 ReportGenerator: Simplify the code by using Position more.
1232 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1234 Reports: Support vertical groups, roughly.
1236 * src/main/java/org/glom/web/server/ReportGenerator.java:
1237 addToReport(): Rename to addGroupToReport() and, if necessary,
1238 call the new addVerticalGroupToReport() method.
1239 createFieldValueElement(): Let the caller specify the Y position
1242 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1244 Reports: Allow a second report to be shown.
1246 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1247 clear(): Do not remove the HTML widget, which broke the whole layout.
1249 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1251 Locales drop-down: Show that we use English by default.
1253 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1254 fillView(): When we use English, just because that is the default, when
1255 no locale is specified, show that in the Locales drop-down instead of
1256 just showing the first item.
1258 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1260 Unselect the Report/Locale/Table combo item when appropriate.
1262 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1263 setPlace(): clear reportName if this is not a ReportPlace.
1264 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1265 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1266 When the provided name is empty, unselect all items, so that none are
1267 indicated. This uses a for loop because I cannot find a single method
1270 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1272 Report: Give the user a way to get back to the list.
1274 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1275 start(), setPlace(): Show the Back To List link on reports, and also
1276 interpret selecting the empty report item as back to list.
1278 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1280 Really show the selected Report name.
1282 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1283 setPlace(): Store the reportName here, if it is that kind of Place.
1284 fillView(): Set the selected Report after filling the list of reports.
1285 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1286 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1287 null Strings, though we need some way to unselect all ListBox items
1290 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1292 ReportGenerator: Try to avoid some problems.
1294 * src/main/java/org/glom/web/server/ReportGenerator.java
1295 addField(): Try to avoid duplicates, and avoid using a null
1298 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1300 Reports: Use quickFind.
1302 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1303 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1305 getReportHTML(): Add a quickFind parameter.
1306 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1307 start(): Pass the quickFind parameter.
1308 * src/main/java/org/glom/web/server/ReportGenerator.java
1309 generateReport(): Take a quickFind parameter.
1311 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1313 ReportPlace: Actually use the report name.
1315 * src/main/java/org/glom/web/client/place/ReportPlace.java
1316 getPlace(): Do not assign the report name to the quickfind.
1318 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1320 Show java.library.path when complaining.
1322 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1323 init(): When telling us to check java.library.path, show the
1326 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1328 ReportGenerator: Do not show nulls.
1330 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1332 ReportGenerator: Make the title font larger.
1334 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1336 ReportGenerator: Put field titles inside groups, if there are groups.
1338 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1340 ReportGenerator: Take the Report itself instead of the name and group.
1342 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1343 Remove getReportLayoutGroup().
1344 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1345 getReportHTML(): Pass the report instead
1346 of its name and layout group.
1347 * src/main/java/org/glom/web/server/ReportGenerator.java
1348 generateReport(): Use the report object to use the title
1349 instead of the name.
1351 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1353 ReportGenerator: Remove designBand parameters.
1355 * src/main/java/org/glom/web/server/ReportGenerator.java:
1356 Make designBand a class member instead of passing it to all
1359 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1361 ReportGenerator: Add lines, a bit like in the desktop version.
1363 * src/main/java/org/glom/web/server/ReportGenerator.java
1364 addToReport(): Use JRDesignLine.
1366 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1368 ReportGenerator: Correct the title positions and use some bold style.
1370 * src/main/java/org/glom/web/server/ReportGenerator.java:
1371 Break the code up into reusable functions, correct the placement of
1372 titles, and use normal/bold styles as in the reports in the desktop
1375 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1377 ReportGenerator: Add a header band to show the field titles.
1379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1380 getReportHTML(): Pass the localeId to the ReportGenerator
1382 * src/main/java/org/glom/web/server/ReportGenerator.java
1383 constructor: Take the localeID so we can get translated field
1385 generateReport(), addToReport(), addFieldToBand(): Add field
1386 titles in a column header band.
1388 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1390 Reports drop-down list: Some improvement.
1392 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1393 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1394 Adedd setSelectedReport(),
1395 setReportList(): Add a blank line so that the user can select the
1397 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1398 start(): Show the current report by calling setSelectedReport().
1399 This does not seem to work yet.
1401 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1403 DetailsActivity, ListActivity: Move some variables into a base class.
1405 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1406 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1407 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1408 the clientFactory, documentID, tableName and authenticationPopup into
1409 a base class, to avoid duplication.
1411 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1413 Translate the Reports label.
1415 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1416 Get the "Reports" label string from the constants.
1417 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1418 perties: Add Reports to the constants.
1420 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1422 Reports: Implement grouping.
1424 * src/main/java/org/glom/web/server/ReportGenerator.java:
1425 Handle LayoutItem_GroupBy items and try to do the right thing
1426 with JRDesignGroup. It seems to work.
1428 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1430 Actually show some data with JasperReports.
1432 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1433 getReportHTML(): Move most code into a ReportGenerator class.
1434 * src/main/java/org/glom/web/server/ReportGenerator.java:
1435 Recurse into sub-groups, adding fields to the JasperDesign's details
1436 band. Note that we must set an arbitrary width and height, or it just
1437 will not show any data.
1439 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1441 Reports Chooser: Show the titles, not the names.
1443 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1444 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1445 and the names as the values.
1446 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1447 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1448 group now that we provide the report name, so it should always
1451 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1453 Depend on jasperreports.
1455 * pom.xml: Add the dependency. My plan is to use this on the
1458 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1460 Implement navigation to report places.
1462 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1463 start(): Do not bother to handle all events here.
1464 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1465 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1466 Added getSelectedReport().
1467 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1468 .java: start(): When handling a change to the reports chooser,
1469 call getSelectedReport() and goTo() its ReportPlace.
1470 * src/main/java/org/glom/web/client/ui/ReportView.java
1471 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1472 Added setReportHTML() which puts the html in a gwt HTML widget.
1473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1474 getReportHTML(): Return "TODO" just to show that this works.
1476 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1478 Make ReportPlace usable.
1480 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1481 Mention ReportPlace.
1482 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1483 Correct the @prefix annotation.
1485 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1487 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1489 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1490 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1491 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1492 Change getReportLayout() to getReportHMTL() because we will not need to
1493 parse or render the report layout on the client side.
1494 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1495 getReportLayout(): Return the libglom LayoutGroup type because we will
1496 not need to convert to a shared type, because this will not be used on
1498 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1501 Note that there is still no implementation for this.
1504 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1506 Add a (empty) Report Place, View, and Activity.
1508 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1510 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1511 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1512 this into a superclass:
1513 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1514 and also use it as the base of this new ReportPlace:
1515 * src/main/java/org/glom/web/client/place/ReportPlace.java
1517 * src/main/java/org/glom/web/client/ui/ReportView.java
1518 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1519 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1520 Add these, containing mostly boiler-plate for now.
1522 * src/main/java/org/glom/web/client/OnlineGlomService.java
1523 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1524 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1525 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1526 Add API to get the LayoutGroup for the report.
1528 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1530 Add and fill a Reports drop-down list box.
1532 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1534 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1535 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1536 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1537 Added getReports(document, table, localeID), calling
1538 ConfiguredDocument.getReports().
1539 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1540 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1541 Added setReportsList() and a list widget.
1542 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1543 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1548 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1550 Translations: Add Esperanto.
1552 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1553 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1554 properties: Add this translation because someone took the time to make it.
1556 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1558 Adapt to the java-libglom 1.21.7 API.
1560 * src/main/java/org/glom/web/server/ReportGenerator.java:
1561 addToReport(): get_group_secondary_fields() is now
1562 get_secondary_fields().
1565 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1567 Use the latest java-libglom version.
1569 * pom.xml: Use java-libglom 1.21.7.
1571 2012-03-03 Ben Konrath <ben@bagu.org>
1573 Display date and time in details view.
1575 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1577 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1579 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1581 Require the latest java-libglom.
1583 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1585 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1587 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1589 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1590 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1591 an empty quickfind string. I also corrected libglom to create only
1592 empty where clauses for empty quickfind strings, but this avoids the
1595 2012-02-24 Ben Konrath <ben@bagu.org>
1597 Improve the tabs in the Notebook widget.
1601 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1603 Translations: Try to translate the strings.
1605 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1606 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1607 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1608 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1609 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1610 Take the Open translation from GTK+'s .po files.
1611 Take the Details translation from Glom's po files.
1612 I have added the other strings to Glom so we can get translations that way:
1613 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1615 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1617 TableSelectionViewImpl: Put the search label and entry in a div.
1619 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1620 Put the search widgets in a FlowTable so that the CSS can be used to
1621 style them while keeping them together.
1622 * src/main/webapp/style.css: Mention the new div.
1624 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1626 Translate more strings in more locales.
1628 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1629 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1630 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1631 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1632 Translate the "Details" and "Open" string too.
1634 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1635 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1636 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1637 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1638 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1639 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1640 Add these new locales as placeholders though they currently contain English.
1642 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1644 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1646 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1647 Check the ConfiguredDocument* for null before using it.
1649 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1651 Tell Eclipse about the generated java files.
1653 * .classpath: This lets it find OnlineGlomConstants.java.
1654 It would be nice if Eclipse just used the maven build files.
1656 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1658 Prevent a crash when no locale is specified in the URL.
1660 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1661 Avoid returning a null string, obtained from
1662 Window.Location.getParameter(). This caused a crash when it was
1663 later passed to libglom's API.
1664 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1665 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1666 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1667 guard against future null strings.
1669 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1671 Use the ?locale= query param instead of the &lang= token param.
1673 * src/main/java/org/glom/web/client/place/ListPlace.java
1674 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1675 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1676 Remove the lang token key and value.
1678 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1679 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1680 When the user selects a different locale from the chooser, use
1681 Window.Location.assign() to change the URL, which then causes a reload.
1683 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1684 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1685 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1686 * src/main/java/org/glom/web/client/activity/ListActivity.java
1687 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1688 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1689 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1690 * src/main/java/org/glom/web/client/ui/ListView.java:
1691 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1693 Remove localeID member variables and method/constructor parameters, instead
1694 using Utils.getCurrentLocaleID() when we need a localID to pass to
1697 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1699 Internationalize the UI strings.
1701 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1702 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1703 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1704 because it is unused. Messages are apparently strings that can have
1705 parameters, but we do not need that yet, so Contants will be enough for now.
1706 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1707 to say that we support the en and de locales.
1708 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1709 The original English strings.
1710 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1711 Some German translations of the English strings.
1712 The i18n goal then uses the .properties file to generate an
1713 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1714 returns an implementation that returns the translated strings.
1715 The documentation suggests putting these in src/java/*/client/, but it seems
1716 best to put it in src/resources/*/client/.
1717 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1718 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1719 instead of hard-coding them.
1720 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1721 but that does not seem to stop the build, though it confuses Eclipse.
1723 You can see the translated string by adding ?locale=de to the URL, like so:
1724 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1726 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1728 Improve null/empty String checks.
1730 * pom.xml: Add a dependency on commons-lang, to use
1731 org.apache.commons.lang.StringUtils.
1732 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1734 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1735 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1736 Use StringUtils.isEmpty().
1738 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1739 StringUtils class with a static isEmpty() function because we
1740 cannot use org.apache.commons.lang.StringUtils in client-side
1741 GWT code because it (apparently) cannot be compiled to javascript.
1742 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1743 * src/main/java/org/glom/web/client/activity/ListActivity.java
1744 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1745 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1746 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1747 * src/main/java/org/glom/web/client/place/ListPlace.java
1748 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1749 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1750 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1751 * src/main/java/org/glom/web/client/ui/details/Group.java
1752 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1753 our StringUtils.isEmpty() function.
1755 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1757 Update to the latest java-libglom API.
1759 * pom.xml: Require java-libglom 1.21.4.
1760 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1761 getDocumentInfo(), getListViewLayoutGroup():
1762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1764 * src/main/java/org/glom/web/server/database/DBAccess.java
1765 getFieldsToShowForSQLQueryAddGroup(),
1766 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1767 with either get_database_title_original() or
1768 get_database_title(localeID).
1770 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1772 ConfiguredDocument: Avoid a null pointer exception.
1774 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1775 Initialize localeID to "" to avoid returning a null String which
1776 causes a crash in java-libglom's swing-generated code.
1778 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1780 Some simple renaming.
1782 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1783 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1784 for localeChooser. This seems more appropriate and is less ambiguous
1785 particularly in the .css file.
1787 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1789 ConfiguredDocument: Rename the localedID private member variable.
1791 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1793 Adapt to the latest java-libglom API from git master.
1795 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1796 libglom now uses only Vector instead of List, which uses add() instead of
1799 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1801 ConfiguredDocument: Rename the localedID private member variable.
1803 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1805 Build a source tarball with mvn assembly:single
1807 * assembly.xml: Add this file.
1808 * pom.xml: Use the maven-assembly-plugin and tell it to use
1809 our assembly.xml file.
1811 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1813 OnlineGlomServiceImpl: Get .glom files recursively.
1815 * pom.xml: Depend on commons-io from org.apache.commons.
1816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1817 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1818 files recursively, and with the easier filter for the extension.
1819 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1820 simplify that code too.
1822 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1824 README: Mention that you must install java-libglom packages separately.
1826 But then it works, because java-libglom is now in the central maven
1829 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1831 locales drop-down: Show the correct selected locale when the URL changes.
1833 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1834 .java: setPlace(): Move some code into fillView().
1836 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1838 locales drop-down: Do not lose the primary key.
1840 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1841 start(): onLocaleChange(): Pass the current primary key value,
1842 instead of an empty value.
1844 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1846 locales drop-down: Do not lose the drop-down selection.
1848 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1849 .java (TableSelectionActivity.fillView): Set the selected locale
1850 after changing the drop-down items (though we do not really need
1851 to change them just because the locale changes.)
1853 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1855 locales drop-down: Change the tables list when this changes.
1857 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1858 .java: TableSelectionActivity.start(): Move the async table titles
1859 retrieval into a private fillView() method and also call this when
1860 the chosen locale changes.
1861 Note that the document title is not actually translatable yet, but
1862 that is a problem that I should fix soon in libglom.
1864 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1866 Improve the placement of the locales drop-down.
1868 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1869 Put the title and locales drop-down in a div (gwt.FlowTable).
1870 * src/main/webapp/style.css: Add magic css properties to make this work.
1871 Also remove the left margin from the title so that it lines up with the
1874 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1876 locales selector: Show human-readable locale titles.
1878 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1879 getDocumentInfo(): Use java.util.Locale to show a real title of
1880 each locale, in the locale's own language.
1882 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1884 Add a language/locale selector drop-down.
1886 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1887 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1888 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1889 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1890 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1891 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1892 Add a ListBox to show the available locales. Add getLocaleSelector(),
1893 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1894 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1895 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1896 java: Add these classes.
1897 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1898 start(): Fill the locales ListBox. Handle its change event, firing a
1900 setPlace(): Show the selected locale as specified by the URL token.
1901 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1902 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1903 Handle LocaleChangeEvent, going to a new *Place with that locale.
1905 The placement of the ListBox is not pretty, and it currently uses the ID
1906 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1910 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1912 Search box: Show the search text from the URL token.
1914 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1915 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1916 Add setQuickFindText().
1917 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1918 .java: setPlace(): Store the queryText if the place is a ListPlace,
1919 and call TableSelectionView.setQuickFindText().
1921 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1923 Allow use of translations via, for instance, &lang=de in the URL.
1925 * pom.xml: Use the unstable java-libglom 1.21 version.
1927 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1928 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1929 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1930 init(): Instead of calling TranslatableItem.set_current_locale()
1931 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1932 However, this is only for default locales, which are not needed to
1933 change the locale in the URL.
1934 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1935 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1936 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1937 layout for a particular locale.
1938 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1939 Add get/setDefaultLocaleID().
1940 getDocumentInfo(), getListViewData(), getRelatedListData(),
1941 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1942 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1943 localeID parameter, so we can get the layout for a particular locale.
1945 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1946 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1947 * src/main/java/org/glom/web/client/place/ListPlace.java:
1948 Parse and construct a lang parameter too.
1950 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1951 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1952 passed to subsequent methods and constructors.
1953 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1954 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1955 Store the localeID from the *Place and pass it to other constructors
1956 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1958 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1959 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1960 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1961 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1962 * src/main/java/org/glom/web/client/ui/ListView.java:
1963 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1964 Take localeID parameters and pass them to subsequent constructors and
1965 methods, so that the layout is always retrieved for that locale.
1967 This is rather repetitive.
1969 Note that "" means the original (default) locale of the Glom document,
1970 which is usually English.
1972 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1974 Documents: Remove final keyword to fix startup configuration.
1976 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1977 final keywords on the private member variables because that breaks
1978 the startup, apparently (there are warnings) because it stops them
1979 from being serialized. I added these in the previous commit.
1981 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1983 Documents: Add some final keywords.
1985 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1988 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1990 OnlineGlomServiceImpl: Add to overview comments.
1992 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1993 Note that this is where all the document are loaded. They are not
1994 loaded freshly for each page.
1996 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2000 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2001 Add a TextBox for the text of a quick find.
2002 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2004 setBackLink(): Add a String quickFind parameter.
2005 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2006 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2007 to the base interface, because that is how TableSelectionViewImpl is used.
2008 * src/main/webapp/style.css: Add style for the search box and its label.
2010 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2011 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2012 Add these files, based on the existing TableChangeEvent and
2013 TableChangeEventHandlers.
2014 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2015 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2016 a ListPlace() that the user should be taken to.
2017 * src/main/java/org/glom/web/client/activity/ListActivity.java
2018 start(): Handle it here too and adapt the TableChangeEvent handler to
2019 pass the extra "" quickFind parameter to ListPlace.
2020 * src/main/java/org/glom/web/client/place/ListPlace.java:
2021 Constructor: Take an extra String quickFind parameter and store it,
2022 returning it from a new getQuickFind() method.
2023 getToken(): Put the quickFind text in the URL token.
2024 getPlace(): Parse the quickFind text from the URL token.
2025 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2026 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2027 ListPlace constructor.
2028 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2029 .java: start(): Add a Change handler for the TableSelectionView's
2030 TextBox (via its base HasChangeHandlers interface), firing the new
2031 QuickFindChangeEvent.
2032 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2033 pass the extra "" quickFind parameter.
2035 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2036 setCellTable(): Add a String quickFind parameter and pass it to
2037 the ListViewTable() constructor.
2038 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2039 setCellTable() in the base interface, because that is how ListViewImpl
2042 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2043 Add a String quickFind member variable.
2044 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2045 Constructor: Add a String quickFind parameter, storing it in the
2046 base ListTable's member variable.
2047 onRangeChanged(): Pass quickFind to the
2048 OnlineGlomServiceAsync.getSortedListViewData() and
2049 OnlineGlomServiceAsync.getListViewData() methods.
2051 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2052 getListViewData(), getSortedListViewData(): Add a String quickFind
2053 parameter, passing it to ConfiguredDocument.getListViewData().
2054 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2055 Change getListViewData(), getSortedListViewData() in the base interface,
2056 because that is how OnlineGlomServiceImpl is used, via this:
2057 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2058 Change getListViewData(), getSortedListViewData() here too.
2059 This class can apparently be used to asynchronously call methods on
2060 OnlineGlomService, and GWT seems to implement that after recognizing
2061 just the *Async name convention and the extra AsyncCallback parameters.
2063 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2064 getListViewData(): Add a String quickFind parameter, and pass it to
2065 ListViewDBAccess.getData().
2066 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2067 getListData(): Add a String quickFind parameter and pass it to
2069 getSelectQuery(): Add a String quickFind parameter.
2070 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2071 getSelectQuery(): Add a String quickFind parameter and use it with
2072 Glom.get_find_where_clause_quick() to pass a where_clause to
2073 Glom.build_sql_select_with_where_clause(), to actually filter the
2075 getData(): Add a String quickFind parameter, passing it to getListData().
2076 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2077 va: getData(): Pass an empty string to getListData() for the
2078 quickFind parameter.
2080 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2082 ListTable: Minor change.
2084 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2085 createCellTable(): Make this protected instead of public.
2087 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2089 Many files: Use final for the parameters and use the @override attribute.
2091 2012-01-22 Ben Konrath <ben@bagu.org>
2093 Add anchor links for single line text that starts with http, ftp and www.
2097 2012-01-22 Ben Konrath <ben@bagu.org>
2099 Add ellipsis to single line text in details view.
2103 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2105 Remove all javadoc author tags.
2107 Because they are awkward and meaningless when many people touch
2109 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2111 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2113 Revert the COPYING.LESSER to COPYING rename.
2115 Apparently both should be there if it is LGPL.
2117 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2119 *View: Remove unused imports.
2121 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2122 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2123 * src/main/java/org/glom/web/client/ui/ListView.java:
2124 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2125 Remove unused imports, as suggested by Eclipse.
2127 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2129 Move the *View::Presenter types, and some API into one base View.
2131 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2132 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2133 * src/main/java/org/glom/web/client/ui/ListView.java:
2134 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2135 Presenter, setPresenter() and clear() into a shared base interface,
2136 to avoid the unnecessary duplicate Presenter types and to more clearly
2137 show how the *Views share the same structure, even if they are not
2138 used polymorphically.
2140 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2141 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2143 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2144 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2145 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2147 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2150 Feel free to revert this if there is a good reason for the duplicate
2153 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2155 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2157 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2158 a class member instead of a local variable in the method.
2159 This lets us use it to get the view instances, for use in tests.
2160 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2161 beforeOnlineGlom(): Test some more details of the initial view.
2162 Again, this is not very useful.
2164 To really test gwt-glom we will need to start a local postgresql
2165 instance with local data, like the Glom tests in C++.
2167 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2169 pom.xml: Mention the LGPL license.
2171 * pom.xml: Add a licenses section.
2172 * COPYING.LESSER: Move this to COPYING, which
2173 previously contained the GPL. But gwt-glom is all LGPL.
2175 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2177 Add project information to README and pom.xml.
2179 * README: Add a brief description and mention some mvn
2181 * pom.xml: This extra information shows up in mvn site
2184 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2186 Use the latest java-libglom version.
2188 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2190 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2192 GwtTestOnlineGlom: Test a little more.
2194 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2195 protected rather than private, as suggested by the gwt-test-utils
2197 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2198 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2199 Test the initial visibility of the panels.
2201 However, this is not a very useful test.
2202 And I wonder how we should generally test using this idea for an
2203 activity/places app like ours where the real changes happen implicitly
2204 based on the history token/URL.
2206 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2208 Slight modification to *Mapper comments.
2210 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2211 (DataActivityMapper)
2212 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2214 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2216 Remove comments mentioning GIN because they are just copied from
2217 the example code and are apparently not helpful:
2218 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2219 Also change the mention of a class that is only in the example code.
2221 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2223 GwtTestOnlineGlom test: Minor changes.
2225 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2226 Avoid the long qualified class name and modify the comment
2227 because it is now obvious to me that the mocked class is the only
2228 custom one created via GWT.create().
2230 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2232 Tests: Added the beginnings of a test using gwt-test-utils.
2234 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2235 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2236 which tells gwt-test-utils what class will be tested.
2237 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2238 Add a simple (but empty) test case. One class, used by the OnlineGlom
2239 class, is mocked so that it can be created. However, I am not sure
2240 why only this class needs to be mocked.
2242 Note that mockito seems more popular, and clearer, than easymock,
2243 but I have not got that working yet. It might be a matter of the
2246 This test is run during mvn integration-test.
2248 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2250 Tests: Use junit4-style syntax instead of junit3-style.
2252 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2253 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2254 * src/test/java/org/glom/web/shared/DataItemTest.java:
2255 Use the @Test annotation rather than relying on the test*() prefix.
2256 Also no longer implement TestCase, to avoid triggering support for
2257 the junit3-way, which stops the annotations from working.
2258 Change the imports from import junit.framework.* to
2259 import org.junit.*, which is apparently the new way.
2261 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2263 Added a test for ListPlace token parsing and creation.
2265 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2266 This is much the same as DetailsPlaceTest.
2268 I wonder how we could test the other parts of the *Place API.
2270 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2272 DetailsPlace test: Also test getToken() and recreation via getPlace().
2274 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2275 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2276 recreate it, testing the recreated DetailsPlace for the same parameter
2279 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2281 Use the surefire-report plugin.
2283 * pom.xml: This generates a HTML report about the tests in
2284 target/site/surefire-report.html
2285 when you do mvn surefire-report:report. It seems to be popular/normal.
2287 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2289 Added a test for DetailsPlace.
2291 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2292 Test the getPlace() token parsing.
2294 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2296 Added a first unit test.
2298 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2299 * src/test/java/org/glom/web/shared/DataItemTest.java:
2300 This is a silly test but it is just to get things started. Note that
2301 maven/junit finds the test because it looks in src/test by default.
2303 2011-12-22 Ben Konrath <ben@bagu.org>
2305 Change charsetName to "UTF-8" when replacing line breaks.
2307 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2308 that work in Java (such as "UTF8") will not work when compiled to
2311 This fixes a problem with multi-line details view fields that have hard
2312 line breaks. The "License Text" field on this page demonstrates the
2315 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2317 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2319 2011-12-22 Ben Konrath <ben@bagu.org>
2321 Fix another bug with related list navigation.
2323 I've tested all the navigation buttons in all of the related lists
2324 so things should be good now.
2326 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2328 2011-12-22 Ben Konrath <ben@bagu.org>
2330 Fix a crasher when refreshing the list view with the default table.
2332 This crash will also happen when loading the list view with the default
2333 table from a link or bookmark.
2335 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2336 to the main document selection page when the document id hasn't been
2338 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2339 the main document selection page when the document id hasn't been
2341 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2342 values for the details place when the document id hasn't been set.
2343 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2344 values for the list place when the document id hasn't been set.
2346 2011-12-21 Ben Konrath <ben@bagu.org>
2348 Protect against NPE when glom.document.locale is not in config.
2350 This patch protects against an NPE when glom.document.locale is not in
2351 the config file. This NPE will also happen if glom.document.locale is
2354 The patch also updates the error message to display the class name when
2355 the getMessage() returns null. This was happening when the NPE was
2356 thrown and I had "Configuration Error: null". If an NPE is encountered
2357 with this patch, "Configuration Error: NullPointerException " will be
2360 This commit closes this bug:
2362 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2364 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2366 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2368 Rename onlineglom.properties to onlineglom.properties.sample.
2370 * src/main/resources/onlineglom.properties: Rename to:
2371 * src/main/resources/onlineglom.properties.sample:
2372 * src/main/resources/README: And add this file explaining that people
2373 should rename it back when deploying.
2375 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2377 Allow choosing the translation in the .properties file.
2379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2380 init(): Read a glom.document.locale value from the configuration file
2381 and call Glom's TransatableItem::set_current_locale() method.
2382 * src/main/resources/onlineglom.properties: Add a commented-out
2383 example of this new setting.
2385 It would be better to add &lang=de_DE to the URL, but the current
2386 libglom API does not allow us to do this easily. I am working on that.
2388 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2390 Avoid a crash in parsing of token parameters.
2392 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2393 ava: getTokenParams(): Do not crash if a parameter has a key but no
2394 value, and ignore parameters with neither.
2396 2011-12-17 Murray Cumming <murrayc@murayc.com>
2398 History token building/handling: Improve use of token parameters.
2400 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2401 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2402 and buildParamsToken(HashMap), for use by derived classes.
2403 Make the separator private because it is no longer be needed.
2404 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2405 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2406 instead of manual string concatenation.
2407 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2408 of hardcoded indices and awkward splitting code.
2409 * src/main/java/org/glom/web/client/place/ListPlace.java
2410 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2411 instead of manual string concatenation.
2412 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2413 of hardcoded indices and awkward splitting code.
2414 This should fix bug #666420
2416 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2418 Fix a Navgiation->Navigation typo in the code.
2420 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2421 Rename processNavgiation() to processNavigation().
2423 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2425 Fix a seperator->separator typo in the code.
2427 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2428 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2429 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2432 2011-12-15 Ben Konrath <ben@bagu.org>
2434 Cleanup some comments.
2436 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2438 2011-12-14 Ben Konrath <ben@bagu.org>
2440 Replace \n with <br/> for multiline text in the details view.
2442 Vertical scrollbars are added when needed as well.
2444 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2446 2011-12-14 Ben Konrath <ben@bagu.org>
2448 Specify the font for document selection links.
2450 * src/main/webapp/style.css:
2452 2011-12-14 Ben Konrath <ben@bagu.org>
2454 Fix bouncy CellTable while paging.
2456 This doesn't currently work with related list tables in unselected
2459 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2461 2011-12-14 Ben Konrath <ben@bagu.org>
2463 Revamp the appearance of the document selection page.
2465 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2466 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2467 * src/main/webapp/style.css:
2469 2011-12-13 Ben Konrath <ben@bagu.org>
2471 Set navigation button column to the smallest size possible.
2473 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2475 2011-12-13 Ben Konrath <ben@bagu.org>
2477 Change OpenButton nomenclature to NavigationButton.
2479 Using NavigtionButton makes things more generic. Classes, methods and
2480 variables have been changed.
2482 This is a rename-only refactor.
2484 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2485 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2486 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2487 Renamed from OpenButtonCell.
2488 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2489 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2490 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2492 2011-12-12 Ben Konrath <ben@bagu.org>
2494 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2496 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2497 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2498 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2499 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2501 2011-12-12 Ben Konrath <ben@bagu.org>
2503 Update variable names and comments.
2505 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2506 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2508 2011-12-12 Ben Konrath <ben@bagu.org>
2510 Properly initialize numNonEmptyRows variable to zero.
2512 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2513 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2515 2011-12-05 Ben Konrath <ben@bagu.org>
2517 Add latest mockup with HTML tables.
2519 Features of this mockup:
2521 -> HTML table for flowtable
2522 -> HTML table for flowtable column
2523 -> Example of how related lists would look
2524 -> Not using text entries for data items
2526 The current version of Online Glom doesn't use HTML tables for the
2529 This mockup has been sent to the glom-devel mailing list but it's good
2530 to have it here as well.
2532 * mockups/details-view-html-tables.html:
2534 2011-12-05 Ben Konrath <ben@bagu.org>
2536 Remove unnecessary getPrimaryKeyField() method.
2538 getPrimaryKeyFieldForTable(String) has been renamed to
2539 getPrimaryKeyField(String).
2541 * src/main/java/org/glom/web/server/database/DBAccess.java:
2542 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2543 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2545 2011-12-05 Ben Konrath <ben@bagu.org>
2547 Add string representation of TypedDataItem value to conversion error message.
2549 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2550 message was extracted into its own method to avoid duplication.
2552 2011-12-05 Ben Konrath <ben@bagu.org>
2554 Add type checking to navigation primary key value creation.
2556 Create navigation primary key only if the expected type from the Glom
2557 document matches the type returned by the SQL query.
2559 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2561 2011-12-05 Ben Konrath <ben@bagu.org>
2563 Rename a couple of variables in RelatedListNavigation.
2565 This is a rename-only refactor.
2567 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2569 2011-12-05 Ben Konrath <ben@bagu.org>
2571 Move getListLayoutGroup() into getListViewLayoutGroup().
2573 This removes getListLayoutGroup(). It was only being called by
2574 getListViewLayoutGroup().
2576 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2578 2011-12-05 Ben Konrath <ben@bagu.org>
2580 Remove check for LayoutItem_Portal in list table method.
2582 This check is no longer necessary because the method isn't being used
2583 to create the LayoutItemPortal DTO.
2585 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2587 2011-12-05 Ben Konrath <ben@bagu.org>
2589 Properly support related list navigation.
2591 Navigation from the "Repository Analyzer -> Package Scans ->
2592 Dependencies" related table wasn't working because the primary key for
2593 related tables wasn't being set properly. This commit fixes the
2596 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2597 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2598 doesn't set the primary key properly for related list tables.
2599 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2600 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2601 useful for getting the primary key for list view tables and for related
2603 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2604 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2605 Move code to set the primary key for the table from the abstract
2606 ListDBAccess class to ListViewDBAccess as it's only correct for list
2608 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2609 Properly add primary key to related list tables.
2611 2011-12-02 Ben Konrath <ben@bagu.org>
2613 Properly set the horizontal alignment of fields.
2615 This fix is for both the list tables and the details view.
2617 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2618 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2619 to set the horizontal alignment of fields.
2621 2011-12-02 Ben Konrath <ben@bagu.org>
2623 Display currency codes in the details view.
2625 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2627 2011-12-02 Ben Konrath <ben@bagu.org>
2629 Avoid duplicate JNI call.
2631 JNI is not as efficient as pure Java and this is an easy (and small)
2634 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2635 Use previously retrieved value for whereClauseToTableName instead of
2638 2011-12-02 Ben Konrath <ben@bagu.org>
2640 Rename a couple of variables in RelatedListNavigation.
2642 This is a rename-only refactor.
2644 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2646 2011-12-02 Ben Konrath <ben@bagu.org>
2648 Indicate clearly that a mismatched primary key type is a bug.
2650 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2651 warning to error. Add 'This is a bug.' to message.
2653 2011-12-02 Ben Konrath <ben@bagu.org>
2655 Update / fix some comments.
2657 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2659 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2661 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2662 Fix comments. Add some TODOs.
2664 2011-12-02 Ben Konrath <ben@bagu.org>
2666 Enable navigation to details view with string primary key from related list.
2668 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2669 Create a text primary key value when return type of result is
2670 java.sql.Types.VARCHAR.
2672 2011-12-02 Ben Konrath <ben@bagu.org>
2674 Use checkboxes for booleans in the details view.
2676 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2678 2011-12-01 Ben Konrath <ben@bagu.org>
2680 Improve performance of related list height calculation.
2682 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2683 Put code to calculate the expected height in a static initializer so
2684 that that it's only called once.
2686 2011-12-01 Ben Konrath <ben@bagu.org>
2688 Show related list tables in notebooks (again).
2690 Calculate the height of the related list tables so the Notebook can be
2691 set the correct height. The height of the related list table is also needed by
2692 FlowTable to be able decide how to create the layout.
2694 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2695 and set the Portal height based on the height of the related list
2696 table and the Portal container.
2697 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2698 Add method to calculate the height of the related list tables.
2699 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2700 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2701 calculate the height of the Pager widget.
2703 2011-12-01 Ben Konrath <ben@bagu.org>
2705 Use CellTable API for table property instead of setting style on Element.
2707 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2709 2011-12-01 Ben Konrath <ben@bagu.org>
2711 Make ListViewTable and RelatedListTable a consistent height.
2713 The tables are now a consistent height regardless of the contents of
2714 the table. A hidden button is added to empty rows to ensure that the
2715 height of these rows will match the height of rows with data.
2717 A navigation button column is now added to every table. The width of
2718 the navigation column is set to 0px when a RelatedListTable shouldn't
2719 have navigation buttons. This maintains the a consistent row height in
2720 tables that don't show the navigation buttons.
2722 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2723 navigation column when not needed.
2724 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2725 arguments for navigation button to constructor of ListViewTable.
2726 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2727 hidden button for empty data rows.
2728 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2729 arguments for navigation button to constructor.
2730 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2731 create navigation buttons. Add hideNavigationButtons() method.
2732 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2733 arguments for navigation button to constructor.
2735 2011-12-01 Ben Konrath <ben@bagu.org>
2737 Use 'visibility: hidden' in Utils.getWidgetHeight().
2739 This is better choice because hidden elements are invisible, don't
2740 respond to events and are not part of the tab order. They will,