1 2012-04-17 Murray Cumming <murrayc@murrayc.com>
3 Style: Remove overflow:hidden from searchbox
5 * src/main/webapp/style.css: Because this pushes the Back To Link
6 label/link on to the next row, which is then hidden due to the
7 hard-coded (in ems) height.
9 2012-04-20 Murray Cumming <murrayc@murrayc.com>
11 Remove some duplicate code.
13 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
14 getDocumentInfo(): This must have been duplicated during the merge from the
19 2012-04-19 Murray Cumming <murrayc@murrayc.com>
21 Reports: Localize the waiting for report message.
23 * src/main/java/org/glom/web/client/activity/ReportActivity.java
24 start(): Get the message from the contants.
25 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
27 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
28 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
29 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
30 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
31 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
32 Update these files with the English text for newer strings for now.
34 2012-04-19 Murray Cumming <murrayc@murrayc.com>
36 Reports: Show a message while waiting for the report.
38 * src/main/java/org/glom/web/client/ui/ReportView.java
39 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
40 Add setWaitingText(), to show a message saying that we are
41 waiting for the report to be ready.
42 * src/main/java/org/glom/web/client/activity/ReportActivity.java
43 start(): Call setWaitingText() before calling the async
46 2012-04-19 Murray Cumming <murrayc@murrayc.com>
48 ReportGenerator: Specify date and time formats.
50 * src/main/java/org/glom/web/server/ReportGenerator.java:
51 createFieldValueElement(): Use the default (and localized)
52 short formats, though we still need a way to show 4-digit
53 years without providing the format for every locale.
54 * src/main/java/org/glom/web/server/database/DBAccess.java:
55 convertResultSetToDTO(): Use the short formats here too.
57 2012-04-18 Murray Cumming <murrayc@murrayc.com>
59 ReportGenerator: Use the correct numeric formatting.
61 * src/main/java/org/glom/web/server/ReportGenerator.java
62 createFieldExpression(), createFieldValueElement(): Take the
63 whole LayoutItem_Field instead of just the field name, so
64 we have access to the formatting.
65 createFieldValueElement(): Use JRTextField.setPattern() to
66 specify the numeric formatting, with the help of a
67 regular DecimalFormat.
69 2012-04-18 Murray Cumming <murrayc@murrayc.com>
71 ReportGenerator: Avoid showing null for group by titles.
73 * src/main/java/org/glom/web/server/ReportGenerator.java
74 generateReport(): Use setBlankWhenNull() on the field title
75 style too, because this is used for values in group by
78 2012-04-18 Murray Cumming <murrayc@murrayc.com>
80 ReportGenerator: Add a colon to titles in vertical groups.
82 * src/main/java/org/glom/web/server/ReportGenerator.java
83 addFieldToDetailBandVertical(): Pass true for the withColon
86 2012-04-18 Murray Cumming <murrayc@murrayc.com>
88 ReportGenerator: Simplify the code by using Position more.
90 2012-04-18 Murray Cumming <murrayc@murrayc.com>
92 Reports: Support vertical groups, roughly.
94 * src/main/java/org/glom/web/server/ReportGenerator.java:
95 addToReport(): Rename to addGroupToReport() and, if necessary,
96 call the new addVerticalGroupToReport() method.
97 createFieldValueElement(): Let the caller specify the Y position
100 2012-04-17 Murray Cumming <murrayc@murrayc.com>
102 Reports: Allow a second report to be shown.
104 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
105 clear(): Do not remove the HTML widget, which broke the whole layout.
107 2012-04-17 Murray Cumming <murrayc@murrayc.com>
109 Locales drop-down: Show that we use English by default.
111 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
112 fillView(): When we use English, just because that is the default, when
113 no locale is specified, show that in the Locales drop-down instead of
114 just showing the first item.
116 2012-04-17 Murray Cumming <murrayc@murrayc.com>
118 Unselect the Report/Locale/Table combo item when appropriate.
120 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
121 setPlace(): clear reportName if this is not a ReportPlace.
122 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
123 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
124 When the provided name is empty, unselect all items, so that none are
125 indicated. This uses a for loop because I cannot find a single method
128 2012-04-17 Murray Cumming <murrayc@murrayc.com>
130 Report: Give the user a way to get back to the list.
132 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
133 start(), setPlace(): Show the Back To List link on reports, and also
134 interpret selecting the empty report item as back to list.
136 2012-04-13 Murray Cumming <murrayc@murrayc.com>
138 Really show the selected Report name.
140 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
141 setPlace(): Store the reportName here, if it is that kind of Place.
142 fillView(): Set the selected Report after filling the list of reports.
143 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
144 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
145 null Strings, though we need some way to unselect all ListBox items
148 2012-04-13 Murray Cumming <murrayc@murrayc.com>
150 ReportGenerator: Try to avoid some problems.
152 * src/main/java/org/glom/web/server/ReportGenerator.java
153 addField(): Try to avoid duplicates, and avoid using a null
156 2012-04-13 Murray Cumming <murrayc@murrayc.com>
158 Reports: Use quickFind.
160 * src/main/java/org/glom/web/client/OnlineGlomService.java;
161 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
163 getReportHTML(): Add a quickFind parameter.
164 * src/main/java/org/glom/web/client/activity/ReportActivity.java
165 start(): Pass the quickFind parameter.
166 * src/main/java/org/glom/web/server/ReportGenerator.java
167 generateReport(): Take a quickFind parameter.
169 2012-04-13 Murray Cumming <murrayc@murrayc.com>
171 ReportPlace: Actually use the report name.
173 * src/main/java/org/glom/web/client/place/ReportPlace.java
174 getPlace(): Do not assign the report name to the quickfind.
176 2012-04-13 Murray Cumming <murrayc@murrayc.com>
178 Show java.library.path when complaining.
180 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
181 init(): When telling us to check java.library.path, show the
184 2012-03-06 Murray Cumming <murrayc@murrayc.com>
186 ReportGenerator: Do not show nulls.
188 2012-03-06 Murray Cumming <murrayc@murrayc.com>
190 ReportGenerator: Make the title font larger.
192 2012-03-06 Murray Cumming <murrayc@murrayc.com>
194 ReportGenerator: Put field titles inside groups, if there are groups.
196 2012-03-06 Murray Cumming <murrayc@murrayc.com>
198 ReportGenerator: Take the Report itself instead of the name and group.
200 * src/main/java/org/glom/web/server/ConfiguredDocument.java
201 Remove getReportLayoutGroup().
202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
203 getReportHTML(): Pass the report instead
204 of its name and layout group.
205 * src/main/java/org/glom/web/server/ReportGenerator.java
206 generateReport(): Use the report object to use the title
209 2012-03-06 Murray Cumming <murrayc@murrayc.com>
211 ReportGenerator: Remove designBand parameters.
213 * src/main/java/org/glom/web/server/ReportGenerator.java:
214 Make designBand a class member instead of passing it to all
217 2012-03-06 Murray Cumming <murrayc@murrayc.com>
219 ReportGenerator: Add lines, a bit like in the desktop version.
221 * src/main/java/org/glom/web/server/ReportGenerator.java
222 addToReport(): Use JRDesignLine.
224 2012-03-06 Murray Cumming <murrayc@murrayc.com>
226 ReportGenerator: Correct the title positions and use some bold style.
228 * src/main/java/org/glom/web/server/ReportGenerator.java:
229 Break the code up into reusable functions, correct the placement of
230 titles, and use normal/bold styles as in the reports in the desktop
233 2012-03-06 Murray Cumming <murrayc@murrayc.com>
235 ReportGenerator: Add a header band to show the field titles.
237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
238 getReportHTML(): Pass the localeId to the ReportGenerator
240 * src/main/java/org/glom/web/server/ReportGenerator.java
241 constructor: Take the localeID so we can get translated field
243 generateReport(), addToReport(), addFieldToBand(): Add field
244 titles in a column header band.
246 2012-03-05 Murray Cumming <murrayc@murrayc.com>
248 Reports drop-down list: Some improvement.
250 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
251 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
252 Adedd setSelectedReport(),
253 setReportList(): Add a blank line so that the user can select the
255 * src/main/java/org/glom/web/client/activity/ReportActivity.java
256 start(): Show the current report by calling setSelectedReport().
257 This does not seem to work yet.
259 2012-03-05 Murray Cumming <murrayc@murrayc.com>
261 DetailsActivity, ListActivity: Move some variables into a base class.
263 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
264 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
265 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
266 the clientFactory, documentID, tableName and authenticationPopup into
267 a base class, to avoid duplication.
269 2012-03-05 Murray Cumming <murrayc@murrayc.com>
271 Translate the Reports label.
273 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
274 Get the "Reports" label string from the constants.
275 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
276 perties: Add Reports to the constants.
278 2012-03-05 Murray Cumming <murrayc@murrayc.com>
280 Reports: Implement grouping.
282 * src/main/java/org/glom/web/server/ReportGenerator.java:
283 Handle LayoutItem_GroupBy items and try to do the right thing
284 with JRDesignGroup. It seems to work.
286 2012-03-04 Murray Cumming <murrayc@murrayc.com>
288 Actually show some data with JasperReports.
290 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
291 getReportHTML(): Move most code into a ReportGenerator class.
292 * src/main/java/org/glom/web/server/ReportGenerator.java:
293 Recurse into sub-groups, adding fields to the JasperDesign's details
294 band. Note that we must set an arbitrary width and height, or it just
295 will not show any data.
297 2012-03-04 Murray Cumming <murrayc@murrayc.com>
299 Reports Chooser: Show the titles, not the names.
301 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
302 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
303 and the names as the values.
304 * src/main/java/org/glom/web/server/ConfiguredDocument.java
305 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
306 group now that we provide the report name, so it should always
309 2012-02-15 Murray Cumming <murrayc@murrayc.com>
311 Depend on jasperreports.
313 * pom.xml: Add the dependency. My plan is to use this on the
316 2012-01-31 Murray Cumming <murrayc@murrayc.com>
318 Implement navigation to report places.
320 * src/main/java/org/glom/web/client/activity/ReportActivity.java
321 start(): Do not bother to handle all events here.
322 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
323 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
324 Added getSelectedReport().
325 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
326 .java: start(): When handling a change to the reports chooser,
327 call getSelectedReport() and goTo() its ReportPlace.
328 * src/main/java/org/glom/web/client/ui/ReportView.java
329 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
330 Added setReportHTML() which puts the html in a gwt HTML widget.
331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
332 getReportHTML(): Return "TODO" just to show that this works.
334 2012-01-31 Murray Cumming <murrayc@murrayc.com>
336 Make ReportPlace usable.
338 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
340 * src/main/java/org/glom/web/client/place/ReportPlace.java:
341 Correct the @prefix annotation.
343 2012-01-31 Murray Cumming <murrayc@murrayc.com>
345 OnlineGlomService: Return report HTML rather than the LayoutGroup.
347 * src/main/java/org/glom/web/client/OnlineGlomService.java:
348 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
349 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
350 Change getReportLayout() to getReportHMTL() because we will not need to
351 parse or render the report layout on the client side.
352 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
353 getReportLayout(): Return the libglom LayoutGroup type because we will
354 not need to convert to a shared type, because this will not be used on
356 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
359 Note that there is still no implementation for this.
362 2012-01-27 Murray Cumming <murrayc@murrayc.com>
364 Add a (empty) Report Place, View, and Activity.
366 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
368 * src/main/java/org/glom/web/client/place/HasTablePlace.java
369 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
370 this into a superclass:
371 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
372 and also use it as the base of this new ReportPlace:
373 * src/main/java/org/glom/web/client/place/ReportPlace.java
375 * src/main/java/org/glom/web/client/ui/ReportView.java
376 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
377 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
378 Add these, containing mostly boiler-plate for now.
380 * src/main/java/org/glom/web/client/OnlineGlomService.java
381 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
382 * src/main/java/org/glom/web/server/ConfiguredDocument.java
383 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
384 Add API to get the LayoutGroup for the report.
386 2012-01-23 Murray Cumming <murrayc@murrayc.com>
388 Add and fill a Reports drop-down list box.
390 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
392 * src/main/java/org/glom/web/client/OnlineGlomService.java:
393 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
394 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
395 Added getReports(document, table, localeID), calling
396 ConfiguredDocument.getReports().
397 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
398 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
399 Added setReportsList() and a list widget.
400 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
401 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
406 2012-04-12 Murray Cumming <murrayc@murrayc.com>
408 Translations: Add Esperanto.
410 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
411 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
412 properties: Add this translation because someone took the time to make it.
414 2012-03-15 Murray Cumming <murrayc@murrayc.com>
416 Adapt to the java-libglom 1.21.7 API.
418 * src/main/java/org/glom/web/server/ReportGenerator.java:
419 addToReport(): get_group_secondary_fields() is now
420 get_secondary_fields().
423 2012-03-15 Murray Cumming <murrayc@murrayc.com>
425 Use the latest java-libglom version.
427 * pom.xml: Use java-libglom 1.21.7.
429 2012-03-03 Ben Konrath <ben@bagu.org>
431 Display date and time in details view.
433 https://bugzilla.gnome.org/show_bug.cgi?id=671257
435 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
437 2012-03-05 Murray Cumming <murrayc@murrayc.com>
439 Require the latest java-libglom.
441 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
443 2012-03-04 Murray Cumming <murrayc@murrayc.com>
445 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
447 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
448 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
449 an empty quickfind string. I also corrected libglom to create only
450 empty where clauses for empty quickfind strings, but this avoids the
453 2012-02-24 Ben Konrath <ben@bagu.org>
455 Improve the tabs in the Notebook widget.
459 2012-01-30 Murray Cumming <murrayc@murrayc.com>
461 Translations: Try to translate the strings.
463 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
464 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
465 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
466 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
467 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
468 Take the Open translation from GTK+'s .po files.
469 Take the Details translation from Glom's po files.
470 I have added the other strings to Glom so we can get translations that way:
471 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
473 2012-01-27 Murray Cumming <murrayc@murrayc.com>
475 TableSelectionViewImpl: Put the search label and entry in a div.
477 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
478 Put the search widgets in a FlowTable so that the CSS can be used to
479 style them while keeping them together.
480 * src/main/webapp/style.css: Mention the new div.
482 2012-01-27 Murray Cumming <murrayc@murrayc.com>
484 Translate more strings in more locales.
486 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
487 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
488 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
489 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
490 Translate the "Details" and "Open" string too.
492 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
493 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
494 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
495 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
496 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
497 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
498 Add these new locales as placeholders though they currently contain English.
500 2012-01-27 Murray Cumming <murrayc@murrayc.com>
502 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
504 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
505 Check the ConfiguredDocument* for null before using it.
507 2012-01-26 Murray Cumming <murrayc@murrayc.com>
509 Tell Eclipse about the generated java files.
511 * .classpath: This lets it find OnlineGlomConstants.java.
512 It would be nice if Eclipse just used the maven build files.
514 2012-01-26 Murray Cumming <murrayc@murrayc.com>
516 Prevent a crash when no locale is specified in the URL.
518 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
519 Avoid returning a null string, obtained from
520 Window.Location.getParameter(). This caused a crash when it was
521 later passed to libglom's API.
522 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
523 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
524 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
525 guard against future null strings.
527 2012-01-26 Murray Cumming <murrayc@murrayc.com>
529 Use the ?locale= query param instead of the &lang= token param.
531 * src/main/java/org/glom/web/client/place/ListPlace.java
532 * src/main/java/org/glom/web/client/place/DetailsPlace.java
533 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
534 Remove the lang token key and value.
536 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
537 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
538 When the user selects a different locale from the chooser, use
539 Window.Location.assign() to change the URL, which then causes a reload.
541 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
542 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
543 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
544 * src/main/java/org/glom/web/client/activity/ListActivity.java
545 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
546 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
547 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
548 * src/main/java/org/glom/web/client/ui/ListView.java:
549 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
551 Remove localeID member variables and method/constructor parameters, instead
552 using Utils.getCurrentLocaleID() when we need a localID to pass to
555 2012-01-26 Murray Cumming <murrayc@murrayc.com>
557 Internationalize the UI strings.
559 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
560 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
561 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
562 because it is unused. Messages are apparently strings that can have
563 parameters, but we do not need that yet, so Contants will be enough for now.
564 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
565 to say that we support the en and de locales.
566 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
567 The original English strings.
568 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
569 Some German translations of the English strings.
570 The i18n goal then uses the .properties file to generate an
571 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
572 returns an implementation that returns the translated strings.
573 The documentation suggests putting these in src/java/*/client/, but it seems
574 best to put it in src/resources/*/client/.
575 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
576 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
577 instead of hard-coding them.
578 Note that we cannot import OnlineGlomConstants because it does not exist yet,
579 but that does not seem to stop the build, though it confuses Eclipse.
581 You can see the translated string by adding ?locale=de to the URL, like so:
582 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
584 2012-01-24 Murray Cumming <murrayc@murrayc.com>
586 Improve null/empty String checks.
588 * pom.xml: Add a dependency on commons-lang, to use
589 org.apache.commons.lang.StringUtils.
590 * src/main/java/org/glom/web/server/ConfiguredDocument.java
591 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
592 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
593 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
594 Use StringUtils.isEmpty().
596 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
597 StringUtils class with a static isEmpty() function because we
598 cannot use org.apache.commons.lang.StringUtils in client-side
599 GWT code because it (apparently) cannot be compiled to javascript.
600 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
601 * src/main/java/org/glom/web/client/activity/ListActivity.java
602 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
603 * src/main/java/org/glom/web/client/place/DetailsPlace.java
604 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
605 * src/main/java/org/glom/web/client/place/ListPlace.java
606 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
607 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
608 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
609 * src/main/java/org/glom/web/client/ui/details/Group.java
610 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
611 our StringUtils.isEmpty() function.
613 2012-01-24 Murray Cumming <murrayc@murrayc.com>
615 Update to the latest java-libglom API.
617 * pom.xml: Require java-libglom 1.21.4.
618 * src/main/java/org/glom/web/server/ConfiguredDocument.java
619 getDocumentInfo(), getListViewLayoutGroup():
620 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
622 * src/main/java/org/glom/web/server/database/DBAccess.java
623 getFieldsToShowForSQLQueryAddGroup(),
624 getPrimaryKeyLayoutItemField(): Replace get_database_title()
625 with either get_database_title_original() or
626 get_database_title(localeID).
628 2012-01-24 Murray Cumming <murrayc@murrayc.com>
630 ConfiguredDocument: Avoid a null pointer exception.
632 * src/main/java/org/glom/web/server/ConfiguredDocument.java
633 Initialize localeID to "" to avoid returning a null String which
634 causes a crash in java-libglom's swing-generated code.
636 2012-01-23 Murray Cumming <murrayc@murrayc.com>
638 Some simple renaming.
640 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
641 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
642 for localeChooser. This seems more appropriate and is less ambiguous
643 particularly in the .css file.
645 2012-01-23 Murray Cumming <murrayc@murrayc.com>
647 ConfiguredDocument: Rename the localedID private member variable.
649 2012-01-23 Murray Cumming <murrayc@murrayc.com>
651 Adapt to the latest java-libglom API from git master.
653 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
654 libglom now uses only Vector instead of List, which uses add() instead of
657 2012-01-22 Murray Cumming <murrayc@murrayc.com>
659 ConfiguredDocument: Rename the localedID private member variable.
661 2012-01-20 Murray Cumming <murrayc@murrayc.com>
663 Build a source tarball with mvn assembly:single
665 * assembly.xml: Add this file.
666 * pom.xml: Use the maven-assembly-plugin and tell it to use
667 our assembly.xml file.
669 2012-01-19 Murray Cumming <murrayc@murrayc.com>
671 OnlineGlomServiceImpl: Get .glom files recursively.
673 * pom.xml: Depend on commons-io from org.apache.commons.
674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
675 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
676 files recursively, and with the easier filter for the extension.
677 Use org.apache.commons.io.FilenameUtils.removeExtension() to
678 simplify that code too.
680 2012-01-19 Murray Cumming <murrayc@murrayc.com>
682 README: Mention that you must install java-libglom packages separately.
684 But then it works, because java-libglom is now in the central maven
687 2012-01-18 Murray Cumming <murrayc@murrayc.com>
689 locales drop-down: Show the correct selected locale when the URL changes.
691 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
692 .java: setPlace(): Move some code into fillView().
694 2012-01-18 Murray Cumming <murrayc@murrayc.com>
696 locales drop-down: Do not lose the primary key.
698 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
699 start(): onLocaleChange(): Pass the current primary key value,
700 instead of an empty value.
702 2012-01-18 Murray Cumming <murrayc@murrayc.com>
704 locales drop-down: Do not lose the drop-down selection.
706 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
707 .java (TableSelectionActivity.fillView): Set the selected locale
708 after changing the drop-down items (though we do not really need
709 to change them just because the locale changes.)
711 2012-01-18 Murray Cumming <murrayc@murrayc.com>
713 locales drop-down: Change the tables list when this changes.
715 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
716 .java: TableSelectionActivity.start(): Move the async table titles
717 retrieval into a private fillView() method and also call this when
718 the chosen locale changes.
719 Note that the document title is not actually translatable yet, but
720 that is a problem that I should fix soon in libglom.
722 2012-01-18 Murray Cumming <murrayc@murrayc.com>
724 Improve the placement of the locales drop-down.
726 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
727 Put the title and locales drop-down in a div (gwt.FlowTable).
728 * src/main/webapp/style.css: Add magic css properties to make this work.
729 Also remove the left margin from the title so that it lines up with the
732 2012-01-18 Murray Cumming <murrayc@murrayc.com>
734 locales selector: Show human-readable locale titles.
736 * src/main/java/org/glom/web/server/ConfiguredDocument.java
737 getDocumentInfo(): Use java.util.Locale to show a real title of
738 each locale, in the locale's own language.
740 2012-01-17 Murray Cumming <murrayc@murrayc.com>
742 Add a language/locale selector drop-down.
744 * src/main/java/org/glom/web/shared/DocumentInfo.java:
745 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
746 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
747 getDocumentInfo(): Store the available Locales in the DocumentInfo.
748 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
749 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
750 Add a ListBox to show the available locales. Add getLocaleSelector(),
751 setLocaleList(), getSelectedLocale(), setSelectedLocale().
752 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
753 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
754 java: Add these classes.
755 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
756 start(): Fill the locales ListBox. Handle its change event, firing a
758 setPlace(): Show the selected locale as specified by the URL token.
759 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
760 * src/main/java/org/glom/web/client/activity/ListActivity.java:
761 Handle LocaleChangeEvent, going to a new *Place with that locale.
763 The placement of the ListBox is not pretty, and it currently uses the ID
764 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
768 2012-01-17 Murray Cumming <murrayc@murrayc.com>
770 Search box: Show the search text from the URL token.
772 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
773 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
774 Add setQuickFindText().
775 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
776 .java: setPlace(): Store the queryText if the place is a ListPlace,
777 and call TableSelectionView.setQuickFindText().
779 2012-01-17 Murray Cumming <murrayc@murrayc.com>
781 Allow use of translations via, for instance, &lang=de in the URL.
783 * pom.xml: Use the unstable java-libglom 1.21 version.
785 * src/main/java/org/glom/web/client/OnlineGlomService.java:
786 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
787 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
788 init(): Instead of calling TranslatableItem.set_current_locale()
789 (now removed), call ConfiguredDocument.setDefaultLocaleID().
790 However, this is only for default locales, which are not needed to
791 change the locale in the URL.
792 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
793 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
794 getSortedRelatedListData(): Add a localeID parameter, so we can get the
795 layout for a particular locale.
796 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
797 Add get/setDefaultLocaleID().
798 getDocumentInfo(), getListViewData(), getRelatedListData(),
799 getDetailsLayoutGroup(), getListViewLayoutGroup(),
800 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
801 localeID parameter, so we can get the layout for a particular locale.
803 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
804 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
805 * src/main/java/org/glom/web/client/place/ListPlace.java:
806 Parse and construct a lang parameter too.
808 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
809 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
810 passed to subsequent methods and constructors.
811 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
812 * src/main/java/org/glom/web/client/activity/ListActivity.java:
813 Store the localeID from the *Place and pass it to other constructors
814 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
816 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
817 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
818 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
819 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
820 * src/main/java/org/glom/web/client/ui/ListView.java:
821 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
822 Take localeID parameters and pass them to subsequent constructors and
823 methods, so that the layout is always retrieved for that locale.
825 This is rather repetitive.
827 Note that "" means the original (default) locale of the Glom document,
828 which is usually English.
830 2012-01-17 Murray Cumming <murrayc@murrayc.com>
832 Documents: Remove final keyword to fix startup configuration.
834 * src/main/java/org/glom/web/shared/Documents.java: Remove the
835 final keywords on the private member variables because that breaks
836 the startup, apparently (there are warnings) because it stops them
837 from being serialized. I added these in the previous commit.
839 2012-01-13 Murray Cumming <murrayc@murrayc.com>
841 Documents: Add some final keywords.
843 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
846 2012-01-13 Murray Cumming <murrayc@murrayc.com>
848 OnlineGlomServiceImpl: Add to overview comments.
850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
851 Note that this is where all the document are loaded. They are not
852 loaded freshly for each page.
854 2012-01-12 Murray Cumming <murrayc@murrayc.com>
858 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
859 Add a TextBox for the text of a quick find.
860 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
862 setBackLink(): Add a String quickFind parameter.
863 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
864 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
865 to the base interface, because that is how TableSelectionViewImpl is used.
866 * src/main/webapp/style.css: Add style for the search box and its label.
868 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
869 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
870 Add these files, based on the existing TableChangeEvent and
871 TableChangeEventHandlers.
872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
873 start(): Handle QuickFindChangeEvent, passing its quickFind text to
874 a ListPlace() that the user should be taken to.
875 * src/main/java/org/glom/web/client/activity/ListActivity.java
876 start(): Handle it here too and adapt the TableChangeEvent handler to
877 pass the extra "" quickFind parameter to ListPlace.
878 * src/main/java/org/glom/web/client/place/ListPlace.java:
879 Constructor: Take an extra String quickFind parameter and store it,
880 returning it from a new getQuickFind() method.
881 getToken(): Put the quickFind text in the URL token.
882 getPlace(): Parse the quickFind text from the URL token.
883 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
884 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
885 ListPlace constructor.
886 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
887 .java: start(): Add a Change handler for the TableSelectionView's
888 TextBox (via its base HasChangeHandlers interface), firing the new
889 QuickFindChangeEvent.
890 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
891 pass the extra "" quickFind parameter.
893 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
894 setCellTable(): Add a String quickFind parameter and pass it to
895 the ListViewTable() constructor.
896 * src/main/java/org/glom/web/client/ui/ListView.java: Change
897 setCellTable() in the base interface, because that is how ListViewImpl
900 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
901 Add a String quickFind member variable.
902 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
903 Constructor: Add a String quickFind parameter, storing it in the
904 base ListTable's member variable.
905 onRangeChanged(): Pass quickFind to the
906 OnlineGlomServiceAsync.getSortedListViewData() and
907 OnlineGlomServiceAsync.getListViewData() methods.
909 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
910 getListViewData(), getSortedListViewData(): Add a String quickFind
911 parameter, passing it to ConfiguredDocument.getListViewData().
912 * src/main/java/org/glom/web/client/OnlineGlomService.java:
913 Change getListViewData(), getSortedListViewData() in the base interface,
914 because that is how OnlineGlomServiceImpl is used, via this:
915 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
916 Change getListViewData(), getSortedListViewData() here too.
917 This class can apparently be used to asynchronously call methods on
918 OnlineGlomService, and GWT seems to implement that after recognizing
919 just the *Async name convention and the extra AsyncCallback parameters.
921 * src/main/java/org/glom/web/server/ConfiguredDocument.java
922 getListViewData(): Add a String quickFind parameter, and pass it to
923 ListViewDBAccess.getData().
924 * src/main/java/org/glom/web/server/database/ListDBAccess.java
925 getListData(): Add a String quickFind parameter and pass it to
927 getSelectQuery(): Add a String quickFind parameter.
928 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
929 getSelectQuery(): Add a String quickFind parameter and use it with
930 Glom.get_find_where_clause_quick() to pass a where_clause to
931 Glom.build_sql_select_with_where_clause(), to actually filter the
933 getData(): Add a String quickFind parameter, passing it to getListData().
934 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
935 va: getData(): Pass an empty string to getListData() for the
938 2012-01-12 Murray Cumming <murrayc@murrayc.com>
940 ListTable: Minor change.
942 * src/main/java/org/glom/web/client/ui/list/ListTable.java
943 createCellTable(): Make this protected instead of public.
945 2012-01-12 Murray Cumming <murrayc@murrayc.com>
947 Many files: Use final for the parameters and use the @override attribute.
949 2012-01-22 Ben Konrath <ben@bagu.org>
951 Add anchor links for single line text that starts with http, ftp and www.
955 2012-01-22 Ben Konrath <ben@bagu.org>
957 Add ellipsis to single line text in details view.
961 2012-01-04 Murray Cumming <murrayc@murrayc.com>
963 Remove all javadoc author tags.
965 Because they are awkward and meaningless when many people touch
967 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
969 2012-01-04 Murray Cumming <murrayc@murrayc.com>
971 Revert the COPYING.LESSER to COPYING rename.
973 Apparently both should be there if it is LGPL.
975 2012-01-03 Murray Cumming <murrayc@murrayc.com>
977 *View: Remove unused imports.
979 * src/main/java/org/glom/web/client/ui/DetailsView.java:
980 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
981 * src/main/java/org/glom/web/client/ui/ListView.java:
982 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
983 Remove unused imports, as suggested by Eclipse.
985 2012-01-02 Murray Cumming <murrayc@murrayc.com>
987 Move the *View::Presenter types, and some API into one base View.
989 * src/main/java/org/glom/web/client/ui/DetailsView.java:
990 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
991 * src/main/java/org/glom/web/client/ui/ListView.java:
992 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
993 Presenter, setPresenter() and clear() into a shared base interface,
994 to avoid the unnecessary duplicate Presenter types and to more clearly
995 show how the *Views share the same structure, even if they are not
996 used polymorphically.
998 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
999 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1001 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1002 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1003 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1005 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1008 Feel free to revert this if there is a good reason for the duplicate
1011 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1013 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1015 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1016 a class member instead of a local variable in the method.
1017 This lets us use it to get the view instances, for use in tests.
1018 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1019 beforeOnlineGlom(): Test some more details of the initial view.
1020 Again, this is not very useful.
1022 To really test gwt-glom we will need to start a local postgresql
1023 instance with local data, like the Glom tests in C++.
1025 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1027 pom.xml: Mention the LGPL license.
1029 * pom.xml: Add a licenses section.
1030 * COPYING.LESSER: Move this to COPYING, which
1031 previously contained the GPL. But gwt-glom is all LGPL.
1033 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1035 Add project information to README and pom.xml.
1037 * README: Add a brief description and mention some mvn
1039 * pom.xml: This extra information shows up in mvn site
1042 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1044 Use the latest java-libglom version.
1046 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1048 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1050 GwtTestOnlineGlom: Test a little more.
1052 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1053 protected rather than private, as suggested by the gwt-test-utils
1055 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1056 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1057 Test the initial visibility of the panels.
1059 However, this is not a very useful test.
1060 And I wonder how we should generally test using this idea for an
1061 activity/places app like ours where the real changes happen implicitly
1062 based on the history token/URL.
1064 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1066 Slight modification to *Mapper comments.
1068 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1069 (DataActivityMapper)
1070 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1072 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1074 Remove comments mentioning GIN because they are just copied from
1075 the example code and are apparently not helpful:
1076 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1077 Also change the mention of a class that is only in the example code.
1079 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1081 GwtTestOnlineGlom test: Minor changes.
1083 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1084 Avoid the long qualified class name and modify the comment
1085 because it is now obvious to me that the mocked class is the only
1086 custom one created via GWT.create().
1088 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1090 Tests: Added the beginnings of a test using gwt-test-utils.
1092 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1093 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1094 which tells gwt-test-utils what class will be tested.
1095 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1096 Add a simple (but empty) test case. One class, used by the OnlineGlom
1097 class, is mocked so that it can be created. However, I am not sure
1098 why only this class needs to be mocked.
1100 Note that mockito seems more popular, and clearer, than easymock,
1101 but I have not got that working yet. It might be a matter of the
1104 This test is run during mvn integration-test.
1106 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1108 Tests: Use junit4-style syntax instead of junit3-style.
1110 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1111 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1112 * src/test/java/org/glom/web/shared/DataItemTest.java:
1113 Use the @Test annotation rather than relying on the test*() prefix.
1114 Also no longer implement TestCase, to avoid triggering support for
1115 the junit3-way, which stops the annotations from working.
1116 Change the imports from import junit.framework.* to
1117 import org.junit.*, which is apparently the new way.
1119 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1121 Added a test for ListPlace token parsing and creation.
1123 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1124 This is much the same as DetailsPlaceTest.
1126 I wonder how we could test the other parts of the *Place API.
1128 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1130 DetailsPlace test: Also test getToken() and recreation via getPlace().
1132 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1133 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1134 recreate it, testing the recreated DetailsPlace for the same parameter
1137 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1139 Use the surefire-report plugin.
1141 * pom.xml: This generates a HTML report about the tests in
1142 target/site/surefire-report.html
1143 when you do mvn surefire-report:report. It seems to be popular/normal.
1145 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1147 Added a test for DetailsPlace.
1149 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1150 Test the getPlace() token parsing.
1152 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1154 Added a first unit test.
1156 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1157 * src/test/java/org/glom/web/shared/DataItemTest.java:
1158 This is a silly test but it is just to get things started. Note that
1159 maven/junit finds the test because it looks in src/test by default.
1161 2011-12-22 Ben Konrath <ben@bagu.org>
1163 Change charsetName to "UTF-8" when replacing line breaks.
1165 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1166 that work in Java (such as "UTF8") will not work when compiled to
1169 This fixes a problem with multi-line details view fields that have hard
1170 line breaks. The "License Text" field on this page demonstrates the
1173 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1175 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1177 2011-12-22 Ben Konrath <ben@bagu.org>
1179 Fix another bug with related list navigation.
1181 I've tested all the navigation buttons in all of the related lists
1182 so things should be good now.
1184 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1186 2011-12-22 Ben Konrath <ben@bagu.org>
1188 Fix a crasher when refreshing the list view with the default table.
1190 This crash will also happen when loading the list view with the default
1191 table from a link or bookmark.
1193 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1194 to the main document selection page when the document id hasn't been
1196 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1197 the main document selection page when the document id hasn't been
1199 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1200 values for the details place when the document id hasn't been set.
1201 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1202 values for the list place when the document id hasn't been set.
1204 2011-12-21 Ben Konrath <ben@bagu.org>
1206 Protect against NPE when glom.document.locale is not in config.
1208 This patch protects against an NPE when glom.document.locale is not in
1209 the config file. This NPE will also happen if glom.document.locale is
1212 The patch also updates the error message to display the class name when
1213 the getMessage() returns null. This was happening when the NPE was
1214 thrown and I had "Configuration Error: null". If an NPE is encountered
1215 with this patch, "Configuration Error: NullPointerException " will be
1218 This commit closes this bug:
1220 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1222 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1224 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1226 Rename onlineglom.properties to onlineglom.properties.sample.
1228 * src/main/resources/onlineglom.properties: Rename to:
1229 * src/main/resources/onlineglom.properties.sample:
1230 * src/main/resources/README: And add this file explaining that people
1231 should rename it back when deploying.
1233 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1235 Allow choosing the translation in the .properties file.
1237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1238 init(): Read a glom.document.locale value from the configuration file
1239 and call Glom's TransatableItem::set_current_locale() method.
1240 * src/main/resources/onlineglom.properties: Add a commented-out
1241 example of this new setting.
1243 It would be better to add &lang=de_DE to the URL, but the current
1244 libglom API does not allow us to do this easily. I am working on that.
1246 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1248 Avoid a crash in parsing of token parameters.
1250 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1251 ava: getTokenParams(): Do not crash if a parameter has a key but no
1252 value, and ignore parameters with neither.
1254 2011-12-17 Murray Cumming <murrayc@murayc.com>
1256 History token building/handling: Improve use of token parameters.
1258 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1259 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1260 and buildParamsToken(HashMap), for use by derived classes.
1261 Make the separator private because it is no longer be needed.
1262 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1263 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1264 instead of manual string concatenation.
1265 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1266 of hardcoded indices and awkward splitting code.
1267 * src/main/java/org/glom/web/client/place/ListPlace.java
1268 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1269 instead of manual string concatenation.
1270 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1271 of hardcoded indices and awkward splitting code.
1272 This should fix bug #666420
1274 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1276 Fix a Navgiation->Navigation typo in the code.
1278 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1279 Rename processNavgiation() to processNavigation().
1281 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1283 Fix a seperator->separator typo in the code.
1285 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1286 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1287 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1290 2011-12-15 Ben Konrath <ben@bagu.org>
1292 Cleanup some comments.
1294 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1296 2011-12-14 Ben Konrath <ben@bagu.org>
1298 Replace \n with <br/> for multiline text in the details view.
1300 Vertical scrollbars are added when needed as well.
1302 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1304 2011-12-14 Ben Konrath <ben@bagu.org>
1306 Specify the font for document selection links.
1308 * src/main/webapp/style.css:
1310 2011-12-14 Ben Konrath <ben@bagu.org>
1312 Fix bouncy CellTable while paging.
1314 This doesn't currently work with related list tables in unselected
1317 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1319 2011-12-14 Ben Konrath <ben@bagu.org>
1321 Revamp the appearance of the document selection page.
1323 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1324 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1325 * src/main/webapp/style.css:
1327 2011-12-13 Ben Konrath <ben@bagu.org>
1329 Set navigation button column to the smallest size possible.
1331 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1333 2011-12-13 Ben Konrath <ben@bagu.org>
1335 Change OpenButton nomenclature to NavigationButton.
1337 Using NavigtionButton makes things more generic. Classes, methods and
1338 variables have been changed.
1340 This is a rename-only refactor.
1342 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1343 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1344 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1345 Renamed from OpenButtonCell.
1346 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1347 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1348 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1350 2011-12-12 Ben Konrath <ben@bagu.org>
1352 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1354 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1355 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1356 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1357 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1359 2011-12-12 Ben Konrath <ben@bagu.org>
1361 Update variable names and comments.
1363 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1364 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1366 2011-12-12 Ben Konrath <ben@bagu.org>
1368 Properly initialize numNonEmptyRows variable to zero.
1370 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1371 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1373 2011-12-05 Ben Konrath <ben@bagu.org>
1375 Add latest mockup with HTML tables.
1377 Features of this mockup:
1379 -> HTML table for flowtable
1380 -> HTML table for flowtable column
1381 -> Example of how related lists would look
1382 -> Not using text entries for data items
1384 The current version of Online Glom doesn't use HTML tables for the
1387 This mockup has been sent to the glom-devel mailing list but it's good
1388 to have it here as well.
1390 * mockups/details-view-html-tables.html:
1392 2011-12-05 Ben Konrath <ben@bagu.org>
1394 Remove unnecessary getPrimaryKeyField() method.
1396 getPrimaryKeyFieldForTable(String) has been renamed to
1397 getPrimaryKeyField(String).
1399 * src/main/java/org/glom/web/server/database/DBAccess.java:
1400 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1401 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1403 2011-12-05 Ben Konrath <ben@bagu.org>
1405 Add string representation of TypedDataItem value to conversion error message.
1407 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1408 message was extracted into its own method to avoid duplication.
1410 2011-12-05 Ben Konrath <ben@bagu.org>
1412 Add type checking to navigation primary key value creation.
1414 Create navigation primary key only if the expected type from the Glom
1415 document matches the type returned by the SQL query.
1417 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1419 2011-12-05 Ben Konrath <ben@bagu.org>
1421 Rename a couple of variables in RelatedListNavigation.
1423 This is a rename-only refactor.
1425 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1427 2011-12-05 Ben Konrath <ben@bagu.org>
1429 Move getListLayoutGroup() into getListViewLayoutGroup().
1431 This removes getListLayoutGroup(). It was only being called by
1432 getListViewLayoutGroup().
1434 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1436 2011-12-05 Ben Konrath <ben@bagu.org>
1438 Remove check for LayoutItem_Portal in list table method.
1440 This check is no longer necessary because the method isn't being used
1441 to create the LayoutItemPortal DTO.
1443 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1445 2011-12-05 Ben Konrath <ben@bagu.org>
1447 Properly support related list navigation.
1449 Navigation from the "Repository Analyzer -> Package Scans ->
1450 Dependencies" related table wasn't working because the primary key for
1451 related tables wasn't being set properly. This commit fixes the
1454 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1455 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1456 doesn't set the primary key properly for related list tables.
1457 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1458 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1459 useful for getting the primary key for list view tables and for related
1461 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1462 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1463 Move code to set the primary key for the table from the abstract
1464 ListDBAccess class to ListViewDBAccess as it's only correct for list
1466 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1467 Properly add primary key to related list tables.
1469 2011-12-02 Ben Konrath <ben@bagu.org>
1471 Properly set the horizontal alignment of fields.
1473 This fix is for both the list tables and the details view.
1475 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1476 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1477 to set the horizontal alignment of fields.
1479 2011-12-02 Ben Konrath <ben@bagu.org>
1481 Display currency codes in the details view.
1483 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1485 2011-12-02 Ben Konrath <ben@bagu.org>
1487 Avoid duplicate JNI call.
1489 JNI is not as efficient as pure Java and this is an easy (and small)
1492 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1493 Use previously retrieved value for whereClauseToTableName instead of
1496 2011-12-02 Ben Konrath <ben@bagu.org>
1498 Rename a couple of variables in RelatedListNavigation.
1500 This is a rename-only refactor.
1502 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1504 2011-12-02 Ben Konrath <ben@bagu.org>
1506 Indicate clearly that a mismatched primary key type is a bug.
1508 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1509 warning to error. Add 'This is a bug.' to message.
1511 2011-12-02 Ben Konrath <ben@bagu.org>
1513 Update / fix some comments.
1515 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1517 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1519 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1520 Fix comments. Add some TODOs.
1522 2011-12-02 Ben Konrath <ben@bagu.org>
1524 Enable navigation to details view with string primary key from related list.
1526 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1527 Create a text primary key value when return type of result is
1528 java.sql.Types.VARCHAR.
1530 2011-12-02 Ben Konrath <ben@bagu.org>
1532 Use checkboxes for booleans in the details view.
1534 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1536 2011-12-01 Ben Konrath <ben@bagu.org>
1538 Improve performance of related list height calculation.
1540 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1541 Put code to calculate the expected height in a static initializer so
1542 that that it's only called once.
1544 2011-12-01 Ben Konrath <ben@bagu.org>
1546 Show related list tables in notebooks (again).
1548 Calculate the height of the related list tables so the Notebook can be
1549 set the correct height. The height of the related list table is also needed by
1550 FlowTable to be able decide how to create the layout.
1552 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1553 and set the Portal height based on the height of the related list
1554 table and the Portal container.
1555 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1556 Add method to calculate the height of the related list tables.
1557 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1558 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1559 calculate the height of the Pager widget.
1561 2011-12-01 Ben Konrath <ben@bagu.org>
1563 Use CellTable API for table property instead of setting style on Element.
1565 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1567 2011-12-01 Ben Konrath <ben@bagu.org>
1569 Make ListViewTable and RelatedListTable a consistent height.
1571 The tables are now a consistent height regardless of the contents of
1572 the table. A hidden button is added to empty rows to ensure that the
1573 height of these rows will match the height of rows with data.
1575 A navigation button column is now added to every table. The width of
1576 the navigation column is set to 0px when a RelatedListTable shouldn't
1577 have navigation buttons. This maintains the a consistent row height in
1578 tables that don't show the navigation buttons.
1580 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1581 navigation column when not needed.
1582 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1583 arguments for navigation button to constructor of ListViewTable.
1584 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1585 hidden button for empty data rows.
1586 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1587 arguments for navigation button to constructor.
1588 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1589 create navigation buttons. Add hideNavigationButtons() method.
1590 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1591 arguments for navigation button to constructor.
1593 2011-12-01 Ben Konrath <ben@bagu.org>
1595 Use 'visibility: hidden' in Utils.getWidgetHeight().
1597 This is better choice because hidden elements are invisible, don't
1598 respond to events and are not part of the tab order. They will,
1599 however, take up space which is required to be able to calculate the
1600 height of the widget.
1602 * src/main/java/org/glom/web/client/Utils.java:
1604 2011-12-01 Ben Konrath <ben@bagu.org>
1606 Use Utils.getWidgetHeight() in FlowTable.
1608 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1610 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1612 2011-12-01 Ben Konrath <ben@bagu.org>
1614 Put the details css class name on the correct table column.
1616 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1618 2011-11-30 Ben Konrath <ben@bagu.org>
1620 Update for java-libglom API change.
1622 The getters and setters on FieldFormatting and NumericFormat were
1623 changed to remove the 'M'.
1625 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1627 2011-11-29 Ben Konrath <ben@bagu.org>
1629 Only allow RelatedListTables in Portals.
1631 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1633 2011-11-29 Ben Konrath <ben@bagu.org>
1635 Only create a contents panel for Portals when title is being set.
1637 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1639 2011-11-29 Ben Konrath <ben@bagu.org>
1641 Set TabLayoutPanel height based on calculated height its widgets.
1643 This is a potential fix for this bug:
1645 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1647 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1649 2011-11-29 Ben Konrath <ben@bagu.org>
1651 Align details field labels and data with the Open buttons.
1653 * src/main/webapp/style.css:
1655 2011-11-29 Ben Konrath <ben@bagu.org>
1657 Remove unnecessary <div> in the Notebook widget.
1659 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1660 method to get container FlowPanel (<div>).
1661 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1662 initWidget() method directly on the TabLayoutPanel widget instead of
1663 Group's container widget.
1665 2011-11-29 Ben Konrath <ben@bagu.org>
1667 Don't add group titles for Portals in Notebooks.
1669 This reverts the previous patch and fixes a bug I introduced with
1670 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1672 * src/main/java/org/glom/web/client/ui/details/Group.java:
1673 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1675 2011-11-28 Ben Konrath <ben@bagu.org>
1677 Remove unused boolean argument in Portal constructor.
1679 Just a code cleanup.
1681 * src/main/java/org/glom/web/client/ui/details/Group.java:
1682 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1684 2011-11-28 Ben Konrath <ben@bagu.org>
1686 Remove hack for glom 1.18 style glom files.
1688 * src/main/java/org/glom/web/client/ui/details/Group.java:
1689 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1690 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1692 2011-11-28 Ben Konrath <ben@bagu.org>
1694 Use Gda Value version of primary key to log result too large error.
1696 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1698 2011-11-28 Ben Konrath <ben@bagu.org>
1700 Don't use TypedDataItem.getText() for Unknown types from the URL.
1702 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1703 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1704 instead of getText().
1705 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1706 String field and getUnknown() method.
1708 2011-11-28 Ben Konrath <ben@bagu.org>
1710 Log an error message when the java-libglom .so is not present.
1712 The error message was being set in the exception but not logged.
1714 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1716 2011-11-28 Ben Konrath <ben@bagu.org>
1718 Ignore LayoutItem_CalendarPortals.
1720 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1721 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1723 2011-11-28 Ben Konrath <ben@bagu.org>
1725 Extract method for creating the LayoutItemPortal DTO.
1727 Just breaking the code up into smaller chunks.
1729 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1731 2011-11-28 Ben Konrath <ben@bagu.org>
1735 This should have been added with the refactor. Oops!
1737 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1739 2011-11-28 Ben Konrath <ben@bagu.org>
1741 Create primary key value from URL string using type from Glom document.
1743 See this bug, comments 19 - 25:
1745 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1747 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1748 create a TypeDataItem for the primary key here when loading from a
1749 URL. Show the same string for the primary key value as was received
1750 from the URL string (when loading from a URL).
1751 * src/main/java/org/glom/web/server/Utils.java: Update method for
1752 creating the Gda Value from the TypeDataItem to properly deal with
1753 creating a Gda Value based on the Glom document type for the primary
1754 key value string when loading from a URL.
1755 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1756 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1757 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1758 Update for changed method name.
1760 2011-11-27 Ben Konrath <ben@bagu.org>
1762 Rename PrimaryKeyItem to TypedDataItem.
1764 The name PrimaryKeyItem suggests what the class should be used for.
1765 TypedDataItem is a neutral name that describes the class better.
1767 This is a rename-only refactor.
1769 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1770 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1771 * src/main/java/org/glom/web/client/Utils.java:
1772 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1773 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1774 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1775 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1776 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1777 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1778 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1779 * src/main/java/org/glom/web/server/Utils.java:
1780 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1781 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1782 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1783 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1785 2011-11-25 Ben Konrath <ben@bagu.org>
1787 Improve Gda Value conversion from PrimaryKeyItem.
1789 The value from the PrimaryKeyItem is only used if its type match the
1790 type from the glom document.
1792 * src/main/java/org/glom/web/server/Utils.java:
1794 2011-11-25 Ben Konrath <ben@bagu.org>
1796 Manually check if the java-liblgom .so is visible to the JVM.
1798 It seems that Tomcat has problems when a static initializer throws an
1799 exception. This check is done before the first method call into
1800 java-libglom so that execution doesn't continue if the .so is not
1803 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1805 2011-11-25 Ben Konrath <ben@bagu.org>
1807 Improve browser configuration error messages.
1811 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1813 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1814 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1815 getConfigurationErrorMessage() method.
1816 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1817 Get and display a specific configuration error message when no Glom
1818 documents are found.
1819 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1820 Implement getConfigurationErrorMessage() method. Surround configuration
1821 code in the init() method with a try/catch block. This allows the
1822 errors to be caught while keeping the servlet available to retrieve the
1823 configuration error message.
1825 2011-11-25 Ben Konrath <ben@bagu.org>
1827 Don't use Strings to hold primary key values.
1829 The primary key values are now held in a new data object
1830 (PrimaryKeyItem) that holds type information and the primary key value
1831 using the correct type.
1833 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1834 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1836 PrimaryKeyItem instead of String to hold the primary key value.
1837 * src/main/java/org/glom/web/client/Utils.java: Remove
1838 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1839 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1840 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1841 PrimaryKeyItem instead of String to hold the primary key value. Load
1842 document selection page when the documentID has not been set correctly.
1843 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1844 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1846 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1847 Return empty string for URL instead of "null".
1848 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1849 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1850 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1851 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1852 PrimaryKeyItem instead of String to hold primary key values.
1853 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1854 PrimaryKeyValue to a Gda Value.
1855 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1856 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1857 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1858 Replace temporary database access code that uses the PrimaryKeyValue to
1859 Gda Value conversion.
1860 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1861 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1862 PrimaryKeyItem instead of String.
1863 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1864 hold primary key values.
1866 2011-11-24 Ben Konrath <ben@bagu.org>
1868 Use newly added java-libglom API to create queries.
1870 This isn't finished. I still need to stop using Strings for primary key
1871 values in the client code.
1873 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1874 libglom to use fake connections so that retrieving the query string will
1876 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1877 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1878 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1879 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1880 Use the newly added libglom sql methods and classes to create the
1881 query. Add temporary hack to convert primary value strings to Gda
1884 2011-11-23 Ben Konrath <ben@bagu.org>
1886 Don't explicitly set the height of Portals.
1888 See comments 6 - 10 of this bug for details:
1890 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1892 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1894 2011-11-23 Ben Konrath <ben@bagu.org>
1896 Use an HTML table instead of CSS for the FlowTable layout.
1898 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1899 GWT's FlexTable to implement the FlowTable.
1900 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1902 2011-11-18 Ben Konrath <ben@bagu.org>
1904 Add boolean example to HTML table mockup.
1906 * mockups/details-view-html-tables-text-entries.html:
1908 2011-11-17 Ben Konrath <ben@bagu.org>
1910 Ensure the pager buttons are always visible for related lists.
1912 To accomplish this, I've turned off text wrapping in the list view and
1913 related list tables for both the header and data text. The related list
1914 table now has a fixed layout so the it doesn't overflow its container.
1915 This is required to ensure that the cell text is clipped when it
1916 overflows the cell and an ellipsis is added to the right side of the
1917 cell when text is clipped.
1919 A fixed table layout for the related list table in the details view
1920 seems what we want for the details view anyway, so the side-effect is
1923 The ellipsis will only be displayed in Firefox >= 7.
1927 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1929 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1930 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1931 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1933 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1934 Set the 'table-layout: fixed' CSS property to the related list table.
1935 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1936 'white-space: nowrap;' CSS property on both the list view and the
1937 related list tables.
1939 2011-11-16 Ben Konrath <ben@bagu.org>
1941 Rework the fix for empty notebook tab labels.
1943 Setting the empty group titles with its name caused problems for the
1944 details layout. Instead of using libglom's
1945 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1946 to the client when the title is empty. This allows the Notebook to use
1947 the name when the title is empty without affecting anything else.
1949 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1950 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1952 2011-11-16 Ben Konrath <ben@bagu.org>
1954 Set group titles with name when title is empty.
1956 This fixes a problem with an empty notebook tab label in the Lesson
1957 Planner document. The forth tab in the notebook should be "Internet":
1959 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1961 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1962 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1965 2011-11-16 Ben Konrath <ben@bagu.org>
1967 Remove whitespace from the configured username properties.
1969 This assumes that usernames won't have whitespace at the beginning
1970 or end. But I think this is a reasonable assumption.
1972 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1973 String.trim() to remove the whitespace from the username properties.
1975 2011-11-15 Ben Konrath <ben@bagu.org>
1977 Add details view mockup with HTML tables and text entries.
1979 This is from the attachment on this bug:
1981 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1983 * mockups/details-view-html-tables-text-entries.html:
1985 2011-11-15 Ben Konrath <ben@bagu.org>
1987 Add space between the columns of the flow table.
1991 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1993 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1994 space between columns in the flow table.
1996 2011-11-15 Ben Konrath <ben@bagu.org>
1998 Add backup files to the .gitignore.
2000 * .gitignore: Ignore files that end with ~.
2002 2011-11-09 Ben Konrath <ben@bagu.org>
2004 Use latest release of gwt-log.
2006 Gwt-log releases are now being submitted to the maven central
2007 repository so manual installation of the jar is no longer required.
2009 * pom.xml: Update version and groupId of gwt-log dependency.
2011 2011-10-31 Ben Konrath <ben@bagu.org>
2013 Don't use GWT numeric formatting to override the glom currency formatting.
2015 Currencies are now displayed like they are in Glom. See this bug:
2017 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2019 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2021 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2022 currency code to constructor and set it when the cell is rendered.
2023 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2024 currency code to the constructor of the NumericCell.
2026 2011-10-27 Ben Konrath <ben@bagu.org>
2028 Require the latest release of java-libglom (1.17.4).
2032 2011-10-26 Ben Konrath <ben@bagu.org>
2034 Add style to Notebook that matches current theme.
2036 It's not the best style in the world but it's better than the default.
2038 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2039 padding at the bottom of the child widgets.
2040 * src/main/webapp/style.css: Add style for the Notebook.
2042 2011-10-26 Ben Konrath <ben@bagu.org>
2044 Move servlet initialization code to overridden init method.
2046 This is half of the solution to getting proper error messages
2047 displayed when configuration errors occur. Here's the relevant bug:
2049 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2051 The rest of the solution involves surrounding the init method with a
2052 try/catch block and setting a global variable with the error /
2053 exception. A new async method should be created to retrieve and display
2054 the error message / exception.
2056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2057 code from constructor to init method adding exceptions as needed.
2059 2011-10-26 Ben Konrath <ben@bagu.org>
2061 Add script to monitor and restart tomcat if required.
2063 * utils/check-and-recover-tomcat.py: New file.
2065 2011-10-26 Ben Konrath <ben@bagu.org>
2067 Display the correct number of data items in the pager.
2071 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2073 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2074 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2075 The implementation is the same for both tables: Keep track of the
2076 number of non-empty rows and fire and RowCountChangeEvent after the data has
2078 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2079 custom Pager class that subclasses SimplePager to handle displaying
2080 the correct number when empty rows have been added.
2082 2011-10-26 Ben Konrath <ben@bagu.org>
2084 Correct error in previous commit.
2086 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2087 eventBus parameter from listView.setCellTable().
2089 2011-10-26 Ben Konrath <ben@bagu.org>
2091 Fix error in TODO comment.
2093 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2095 2011-10-24 Ben Konrath <ben@bagu.org>
2097 Create Notebook widgets to the details view.
2099 This isn't finished just yet - I still need to create a reasonable
2100 style to match the current theme.
2102 * src/main/java/org/glom/web/client/Utils.java: Add method for
2103 calculating the height of a widget. This is used in the Notebook class.
2104 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2105 new constructor method in Group.
2106 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2107 method for creating child widget that can be used by subclasses
2108 like Notebook. New constructor that allows disabling the group
2109 titles - Notebooks don't set a group title for their child groups.
2110 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2111 to make Notebooks using GWT's TabLayoutPanel.
2112 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2113 constructor that allows disabling the group titles.
2114 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2115 LayoutItemNotebook DTO.
2116 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2117 DTO for Notebooks. It's just an empty class for now but we might need
2118 it to transfer some specific information in the future.
2120 2011-10-21 Ben Konrath <ben@bagu.org>
2122 Add navigation buttons to related list tables.
2124 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2125 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2127 method getSuitableRecordToViewDetails() for getting the table name
2128 and primary key value for related list navigation buttons.
2129 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2130 private cell renderer class to get the navigation information for
2131 related list tables from the server. Extract the navigation
2132 processing code from the details cell navigation and use it for the
2133 related list navigation as well.
2134 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2135 cell renderer class for the details open buttons. This was needed
2136 because the related list navigation buttons and the list view
2137 navigation buttons need to react differently when clicked.
2138 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2139 the onEnterKeyDown() method because it's now overriden in the
2140 subclasses that are specific to the related list tables and the list
2142 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2143 the vertical size a little because the buttons add a bit of vertical
2144 space to table. This is not a perfect solution because the vertical
2145 size of with table fewer than 5 rows will be a little smaller.
2146 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2147 changes in how navigation buttons are handled.
2148 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2149 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2150 database access object.
2151 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2152 to find the portal for a given relationship name from
2153 RelatedListDBAccess. Add method to find a primary key field for a
2155 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2156 Move code to find the portal for a given relationship name to
2158 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2159 New file: database access object for getting the related list
2160 navigation information (the table name and the primary key value).
2161 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2162 DTO for transferring a table name to navigate to and a primary key
2164 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2165 boolean and getter/setter to specifies if the related list should add
2168 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2170 Use the master branch of java-libglom
2172 * pom.xml: Depend on java-libglom 1.19 instead.
2174 This is the master branch. See also the libglom-1-18 branch.
2176 2011-10-11 Ben Konrath <ben@bagu.org>
2178 Enable the open navigation button when the data has been set.
2180 This avoids having active buttons that don't do anything when the data
2183 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2185 2011-10-11 Ben Konrath <ben@bagu.org>
2187 Use IsWidget interface for FlowTableItem.
2189 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2190 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2192 2011-10-11 Ben Konrath <ben@bagu.org>
2194 Remove GWT styling from open button in details view.
2196 There are still some issues with how the details cell is arranged but
2197 this should be made to match Glom 1.20. I'm going to leave fixing this
2198 until I have Glom 1.20 up and running.
2200 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2201 style name on open button.
2202 * src/main/webapp/style.css: Move and edit details-navigation class.
2203 Re-arrange some classes to make them appear in the same order as the
2206 2011-10-07 Ben Konrath <ben@bagu.org>
2208 Update to GWT 2.4.0.
2210 * .gitignore: Ignore new cache directory.
2211 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2212 * pom.xml: Change GWT and maven plugin to 2.4.0.
2213 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2215 * src/main/java/org/glom/web/client/ClientFactory.java:
2216 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2217 * src/main/java/org/glom/web/client/OnlineGlom.java:
2218 Update source for API changes.
2219 * utils/build-onlineglom-war.sh: Remove cache directory before the
2222 2011-10-07 Ben Konrath <ben@bagu.org>
2224 Add navigation buttons in the details view.
2226 This isn't finished but I thought I'd commit what I have as it's a
2227 pretty good start. I still need to:
2229 1. Change the style so that it fits better into the current theme
2230 2. Adjust the details cell to expand as much as possible.
2232 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2233 click handlers to navigation buttons in the DetailsCells. Create a
2234 refreshData() method to get just the data from the server without the
2236 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2237 Update the tableSelector and browser title when the table name
2238 changes without using the tableSelector.
2239 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2240 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2241 getDetailsCells() to getCells(). Update variable names.
2242 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2243 method to set click handler on navigation button. Rename a few
2244 variables. Add navigation buttons where needed.
2245 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2246 variables and methods.
2247 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2248 navigation boolean and navigation table as required in the
2249 LayoutItemField DTO.
2250 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2251 variables for navigation along with getter/setter methods.
2253 2011-10-07 Ben Konrath <ben@bagu.org>
2255 Rename Field to DetailsCell.
2257 This is a refactor-only commit. No functionality has been added or
2260 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2261 Update variable and method names.
2262 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2263 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2264 variable and method names.
2265 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2267 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2268 variable and method names.
2270 2011-10-07 Ben Konrath <ben@bagu.org>
2272 Create separate methods for layout and data the details view.
2274 This is a refactor-only commit. No functionality has been added or
2277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2278 private methods: setData(), createLayout().
2280 2011-10-07 Ben Konrath <ben@bagu.org>
2282 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2284 This is part of a change to get navigation buttons in the details view
2285 but it should have been done this way from the start.
2287 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2288 for method name change in TableSelectionView.
2289 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2290 Create TableChangeEvent and set the browser title using the
2291 TableSelectionView API.
2292 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2293 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2294 Change getSelectedTable() to getSelectedTableName(). Add
2295 getSelectedTableTitle().
2297 2011-10-07 Ben Konrath <ben@bagu.org>
2299 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2301 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2303 2011-10-07 Ben Konrath <ben@bagu.org>
2305 Update TableChangeEvent to use newTableName naming convention.
2307 This makes the class more consistent with GWT naming conventions.
2309 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2310 Update for method name change in TableChangeEvent.
2311 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2312 for method name change in TableChangeEvent.
2313 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2314 newTableName variable and getter method. Make toDebugString()
2317 2011-09-30 Ben Konrath <ben@bagu.org>
2319 Disable the pager in the list tables when the data row count is less than the minimum.
2321 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2322 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2324 2011-09-30 Ben Konrath <ben@bagu.org>
2326 Add empty rows to the end of related list and list view tables.
2328 I also extracted the cell rendering classes from the ListTable because
2329 the code was becoming a little crazy with all the anonymous inner
2330 classes. My plan is to use these cell rendering classes in the details
2331 view as well so this refactor will be needed for that change.
2333 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2334 set the row count in related list tables if the data has more rows
2335 than the minimum number of rows visible.
2336 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2337 row count in list view tables if the data has more rows than the
2338 minimum number of rows visible.
2339 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2340 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2342 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2343 for rendering TYPE_NUMERIC cells. The code was extracted from the
2345 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2346 class for rendering cells with buttons in list views. The code was
2347 extracted from the ListTable class.
2348 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2349 for rendering TYPE_TEXT cells. The code was extracted from the
2351 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2352 Add empty rows to the end of the data if required. Implement
2353 ListTable.getMinNumVisibleRows().
2354 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2355 cell renderer code to public classes. Return null in
2356 Column.getValue() for empty rows. Add new abstract method:
2357 getMinNumVisibleRows(). Move code to set the row count of the list view
2358 table to ListViewImpl.
2359 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2360 empty rows to the end of the data if required. Implement
2361 ListTable.getMinNumVisibleRows().
2364 2011-09-27 Ben Konrath <ben@bagu.org>
2366 Use GWT.log for client-side debugging statements.
2368 These are optimized out when deployed so I should have used this method
2369 in the first place. These statements will eventually be replaced with some sort
2370 of notification in the browser.
2372 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2373 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2374 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2375 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2376 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2378 2011-09-27 Ben Konrath <ben@bagu.org>
2380 Put tableselector on the right, back to list link on right.
2382 The idea is that the table selector is acting like a label for the
2383 currently displayed table so it should be placed below the document title. This
2384 puts the table title in a similar position to where it is in Glom.
2386 * mockups/details-contacts.html:
2387 * mockups/details-projects.html:
2388 * mockups/listview-contacts.html:
2389 * mockups/listview-projects.html:
2390 * mockups/style.css:
2391 Update mockups to match how the interfaces currently look.
2392 * src/main/webapp/style.css: Swap positions of backlink with the table
2393 selector. Add some space on the left side of the table selector to
2394 line things up with the document title.
2396 2011-09-27 Ben Konrath <ben@bagu.org>
2398 Add field colouring to details view.
2400 This change re-works how field colouring works. The colour formatting
2401 information is now set to the client with the layout information instead of
2402 with the data. This eliminates the need to send the same colour strings for
2403 data in list view column when colour information is set.
2405 In order to set an alternate colour for negative numeric values, the
2406 number is now sent to client and formatted with the GWT NumberFormat class.
2408 This change also fixes:
2410 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2412 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2413 internationalization framework which is needed for client side numeric
2415 * src/main/java/org/glom/web/client/Utils.java: New file for some
2416 client static utility methods.
2417 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2418 the DataItem object to the Field class. Use a utility method to
2419 create the foreignKeyValue string.
2420 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2421 alignment and text colours in the constructor. Add setData(DataItem)
2422 method. Remove setText(String) method.
2423 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2424 colour information to GlomTextCell. Create and use GlomNumberCell for
2425 rendering numbers. Use utility method to get the string for the
2426 primary key of the key provider. Re-work how the horizontal alignment
2428 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2429 formatting to layout information. Methods for converting the libglom
2430 formatting information were moved from DBAccess.
2431 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2432 numeric formatting (it's now done on the client side). Don't set text
2433 colours in DataItem. Move libglom formatting conversion methods to
2435 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2436 getters/setters for text colour information.
2437 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2438 for transferring the libglom NumericFormat information to the client.
2439 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2440 and getters/setters for: GlomNumericFormat, background colour and
2441 foreground colour strings.
2443 2011-09-26 Ben Konrath <ben@bagu.org>
2445 Simplify code that iterates through the LayoutGroup.
2447 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2449 2011-09-26 Ben Konrath <ben@bagu.org>
2451 Accept Eclipse formatting for OnlineGlomServiceAsync.
2453 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2455 2011-09-26 Ben Konrath <ben@bagu.org>
2457 Don't use the ListDBAccess classes to get the primary key layout information.
2459 This was causing a bug where the wrong index for the hidden primary key
2460 was being sent to the client.
2462 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2463 primary key while creating the LayoutGroup DTO. Create a
2464 LayoutItemField DTO for hidden primary keys. Don't use the
2465 RelatedListDBAccess because it was only used for getting the primary
2467 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2468 access modifier from public to protected for getPrimaryKeyField() and
2469 getPrimaryKeyLayoutItemField().
2470 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2471 abstract method getExpectedResultSize() because RelatedListDBAccess
2472 doesn't have enough info to implement it.
2473 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2474 Remove @Override for getExpectedResultSize().
2475 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2476 Remove method getExpectedResultSize().
2478 2011-09-23 Ben Konrath <ben@bagu.org>
2480 Log which layout (list or details) the ignored item is from.
2482 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2484 2011-09-23 Ben Konrath <ben@bagu.org>
2486 Remove annotations that turn off code formatting in DataItem.
2488 * src/main/java/org/glom/web/shared/DataItem.java:
2490 2011-09-23 Ben Konrath <ben@bagu.org>
2492 Rename GlomField to DataItem and update associated methods.
2494 This is a rename-only refactor. No functionality has been added or
2497 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2498 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2500 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2501 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2502 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2503 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2504 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2505 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2506 * src/main/java/org/glom/web/server/database/DBAccess.java:
2507 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2508 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2509 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2510 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2511 * src/main/java/org/glom/web/shared/DataItem.java:
2512 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2513 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2515 2011-09-23 Ben Konrath <ben@bagu.org>
2517 Rename GlomDocument to DocumentInfo and update associated methods.
2519 This is a rename-only refactor. No functionality has been added or
2522 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2523 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2524 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2525 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2526 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2528 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2530 2011-09-20 Ben Konrath <ben@bagu.org>
2532 Require java-libglom 1.17.3.
2534 This picks up the fix for the seg fault problem with the Scenes table
2535 in the Openismus Film Manager example.
2539 2011-09-20 Ben Konrath <ben@bagu.org>
2541 Change the way sort clause is added for primary key when no sort clause is requested.
2543 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2544 before the sort clause is created. When a sort clause is not requested, the
2545 sort clause is created by finding the primary key in the LayoutFieldVector
2548 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2550 2011-09-20 Ben Konrath <ben@bagu.org>
2552 Log error message if no documents are found in the configured directory.
2554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2555 Extract the glom file extension string to a private static final class
2556 variable (mostly as syntactic sugar). Accept a minor formatting change.
2557 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2558 the example glom.document.directory configuration property to make it
2559 more clear that it can any directory, not just the home directory.
2561 2011-09-18 Ben Konrath <ben@bagu.org>
2563 Add related lists to details view.
2565 The related list table has support for paging and sorting just like the
2566 table in the list view.
2568 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2569 SQL queries for the related list tables.
2570 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2571 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2572 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2573 Rename getList methods to getListView and add comments. Remove
2574 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2575 it being unused. Add methods: getDetailsLayoutAndData(),
2576 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2577 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2578 Create the layout and set the data for the fields in one async call
2579 instead of two. Create related lists where appropriate.
2580 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2581 for method name changes in OnlineGlomService.
2582 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2583 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2584 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2586 * src/main/java/org/glom/web/client/ui/ListView.java:
2587 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2588 tableName from setCellTable(). Create a ListViewTable instead of
2590 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2591 represent a data field in the details view.
2592 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2593 from addDetailsCell() to Field class. Keep track of the Fields and
2594 Portals in the details view.
2595 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2596 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2597 and add a method to get it. Add method to set the contents of the
2599 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2600 New class for related list tables. This class has the data provider
2601 for the related list table.
2602 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2603 abstract class which is the base class for the ListViewTable and the
2605 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2606 New class for list view tables. This class has the data provider for
2607 the list view table.
2608 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2609 methods for related list tables. Add more information to the
2610 LayoutItemField and LayoutItemPortal DTOs.
2611 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2612 Remove debugging print statement.
2613 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2614 Remove debugging print statements. Add primary key field to SQL count
2616 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2617 Remove unnecessary LayoutFieldVector parameter from
2618 getResultSizeOfSQLQuery() method.
2619 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2620 New class for related list table database access.
2621 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2622 class that is a wrapper DTO for details view layout and data.
2623 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2624 new 'fromField' string to this DTO.
2625 * src/main/webapp/style.css: Remove bottom margin and override top
2628 2011-09-15 Ben Konrath <ben@bagu.org>
2630 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2632 This sets things up to make it easier to add the data retrieval for
2633 related lists (portals). No user noticeable changes were made with
2636 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2637 class has the code to retrieve the layouts and access the
2638 database using the new database helper classes.
2639 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2640 Most of the functionality has been removed from this class. This
2641 class now represents the public interface for the client side
2642 code. It also deals with configuring the servlet and cleaning
2643 things up when the servlet is stopped.
2644 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2645 of static methods into this utility class.
2646 * src/main/java/org/glom/web/server/database/DBAccess.java:
2647 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2648 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2649 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2650 These classes have the database retrieval code. The class hierarchy
2651 has been setup to make it easy to reuse code for similar
2654 2011-09-06 Ben Konrath <ben@bagu.org>
2656 Create separate classes for list table code and the data provider.
2658 As part of this refactor, I also split up the code a bit to make it
2661 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2662 table code to two new classes (below).
2663 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2664 with code from ListViewImpl.
2665 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2666 New file with code from ListViewImpl.
2668 2011-09-06 Ben Konrath <ben@bagu.org>
2670 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2672 This fixes the LayoutItemPortal DTO to match the libglom layout object
2675 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2677 2011-09-01 Ben Konrath <ben@bagu.org>
2679 Set title of Portals in the Details View.
2681 * pom.xml: Bump required version of java-libglom to 1.17.1.
2682 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2683 widget creation to its own class. Add comments to constructor.
2684 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2685 The code is mostly from the Group class with the title now set.
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2687 title of Portal. Update some comments. Fix some code formatting.
2689 2011-09-01 Ben Konrath <ben@bagu.org>
2691 Remove TODO comment for the flow table column width.
2693 The flow table column width is working correctly and doesn't need to be
2694 changed. See this mailing list post for more info:
2696 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2698 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2700 2011-08-27 Ben Konrath <ben@bagu.org>
2702 Add document title (database name) to top of the browser page.
2704 I added the document title to the TableSelecitonView but that will
2705 change if / when we add a view that doesn't require table selection.
2707 * mockups/details-contacts.html:
2708 * mockups/details-projects.html:
2709 * mockups/listview-contacts.html:
2710 * mockups/listview-projects.html:
2711 * mockups/style.css: Add document title to mockups to keep things
2713 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2714 sizes to account for the document title.
2715 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2716 Set the document title when it has been retrieved from the server.
2717 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2718 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2719 and implement setDocumentTitle(String) method.
2720 * src/main/webapp/style.css: Add ID for document title style.
2722 2011-08-25 Ben Konrath <ben@bagu.org>
2724 Add NavigationType enum to LayoutItemPortal DTO.
2726 This is the start of adding support for Portals to the Details View.
2728 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2729 LayoutItem_Portal.navigation_type enum from libglom to
2730 LayoutItemPortal.NavigationType enum.
2731 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2732 NavigationType enum, field for storing the NavigationType and getter
2735 2011-08-25 Ben Konrath <ben@bagu.org>
2737 Implement the flow table layout in the Details View.
2739 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2740 FlowTable to Group to account for the renamed class.
2741 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2742 File. This is a container widget that implements the Glom details view
2743 flow table behaviour.
2744 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2745 org/glom/web/client/ui/FlowTable.java.
2746 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2747 so that the size of the subgroups are a closer match to the size of
2748 the Glom subgroups. This makes the flowtable layout match the layout
2749 in Glom for the Music Collection example file.
2751 2011-08-16 Ben Konrath <ben@bagu.org>
2753 Create container element for LayoutItemPortal in Details View.
2755 This will help me develop the layout for the FlowTable.
2757 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2758 fieldPanel variable to detailsCell.
2760 2011-08-15 Ben Konrath <ben@bagu.org>
2762 Set the height of the data element in the Details View.
2764 I changed the InlineLabels (text in a span element) to Labels (text in
2765 a div element) so that I could set the height of the details-data
2766 elements instead of the details-cell parent elements. This allows the
2767 the details-data element to display the correct height if style is
2768 applied that shows the height.
2770 This change has the added benefit of allowing the order of the labels
2771 and data elements to be changed for right-to-left languages.
2773 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2774 InlineLabels to Labels.
2775 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2776 InlineLabels to Labels. Set the height of the data element.
2777 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2778 multiline text height in the Formatting DTO.
2779 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2780 for multiline height along with getter and setter methods.
2781 * src/main/webapp/style.css: Adjust style to account for the change
2782 from span elements to div elements in the details cell.
2784 2011-08-15 Ben Konrath <ben@bagu.org>
2786 Make the List View appearance match the mockups.
2788 It doesn't match exactly but it's much better than it was.
2790 * mockups/listview-contacts.html: Remove unused css classes.
2791 * mockups/listview-projects.html: Remove unused css classes.
2792 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2793 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2794 for mainPanel instead of VerticalPanel (table). Set style name on
2795 CellTable. Set style name on Details column. Right-align Details
2797 * src/main/webapp/style.css: Adjust properties to match the mockups.
2799 2011-08-12 Ben Konrath <ben@bagu.org>
2801 Add better support for subgroups in the details view.
2803 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2804 changed FlowTable constructor.
2805 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2806 support for subgroups and subgroup-titles.
2807 * src/main/webapp/style.css: Add CSS class for subgroups and
2810 2011-08-12 Ben Konrath <ben@bagu.org>
2812 Return the top level LayoutGroup title.
2814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2816 2011-08-11 Ben Konrath <ben@bagu.org>
2818 Make the TableSelector header match the mockup.
2820 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2821 the layout panel. Properly lineup the table selection header with
2822 the list and details view.
2823 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2824 margin around the details view.
2825 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2826 Rename listBox variable to tableSelector. Set id for the style sheet.
2827 Use a FlowPanel instead of a HorizontalPanel.
2828 * src/main/webapp/style.css: Add properties to make the TableSelector
2829 box match the mockups.
2831 2011-07-13 Ben Konrath <ben@bagu.org>
2833 Update install script for java-libglom version change.
2835 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2838 2011-07-13 Ben Konrath <ben@bagu.org>
2840 Add support sub-group in the details view.
2842 I also removed the code that special-cased the default details view
2845 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2847 I still have to make a proper flowtable.
2849 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2850 Don't special-case default details view layout.
2851 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2852 addLayoutField() as I'm going to use it.
2853 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2854 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2856 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2857 extracted from DetailsViewImpl.GroupPanel. Add support for
2859 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2860 column count when getting the details layout.
2862 2011-07-12 Ben Konrath <ben@bagu.org>
2864 Set browser title with database and table titles.
2866 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2867 Set the browser title when the table changes and when the activity
2869 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2870 title when retrieving document info (the GlomDocument object).
2871 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2872 with getter and setter methods. Remove unused convenience constructor.
2873 Use default code formatting.
2875 2011-07-12 Ben Konrath <ben@bagu.org>
2877 Ignore LayoutItemPortals in the details view.
2879 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2882 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2883 LayoutItemPortal layout objects.
2884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2885 LayoutItemPortal objects when retrieving the details layout.
2886 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2887 file. This is an empty class and just used to get type information for
2890 2011-07-12 Ben Konrath <ben@bagu.org>
2892 Use java-libglom 1.17.0.
2896 2011-07-11 Ben Konrath <ben@bagu.org>
2898 Remove "Table:" label from table selector.
2900 This matches a recent change in the Glom UI.
2902 * mockups/details-contacts.html:
2903 * mockups/details-projects.html:
2904 * mockups/listview-contacts.html:
2905 * mockups/listview-projects.html: Remove the "Table:" label from the
2907 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2909 2011-07-11 Ben Konrath <ben@bagu.org>
2911 Add main groups to the details view.
2913 This makes things look a little nicer in the details view. The next step
2914 is to implement the flowtable.
2916 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2917 resources from the standard gwt css theme. Standard.css is now
2918 included in OnlineGlom.html so that the online glom css rules have
2919 precedence over the gwt theme.
2920 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2921 the whole LayoutGroup to the DetailsView instead of just the titles.
2922 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2923 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2924 details layout with a helper class (GroupPanel). I might extract this
2925 class when I make the full flowtable.
2926 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2927 string as default so I don't have to worry about NPEs when processing
2929 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2930 note beside OnlineGlom.gwt.xml above).
2931 * src/main/webapp/style.css: Add default font-size to body to override
2932 the font-size set by the standard theme. Don't use h2 tags for
2933 group-title. Create new details-cell class.
2935 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2937 ConfiguredDocument: Set the port number too.
2939 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2940 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2941 Glom document. Presumably this worked sometimes so far because there is a
2942 default port number.
2944 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2946 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2948 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2949 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2950 correct, though we should throw an exception too.
2952 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2954 Fix a addDocuemnt typo.
2956 * src/main/java/org/glom/web/shared/Documents.java
2957 (Documents.addDocuemnt): Rename to addDocument().
2958 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2959 (OnlineGlomServiceImpl.getDocuments): Adapt.
2961 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2963 Slightly improved log output when connection fails.
2965 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2966 (ConfiguredDocument.setUsernameAndPassword):
2967 We don't know for sure if it' the username/password that's wrong, so
2968 rephrase the message.
2969 Also ouput the exception message, though it's generic in this case.
2971 2011-07-08 Ben Konrath <ben@bagu.org>
2975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2976 added braces to a one line if statement because the Eclipse formatter
2977 was getting confused.
2979 2011-07-07 Ben Konrath <ben@bagu.org>
2981 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2983 These should really be two separate tasks but I counldn't get things to
2984 work with GWT 2.2.0 and Eclipse 3.7.
2988 * .settings/org.eclipse.jdt.core.prefs:
2989 * .settings/org.eclipse.jdt.ui.prefs:
2990 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2991 * .settings/org.eclipse.m2e.core.prefs:
2992 Add new config files. Update current files. Remove references to the
2993 webtools plugins as we're not using any of the webtools features.
2994 * .gitignore: Add logs directory which is created when running with
2996 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2997 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2998 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3000 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3002 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3004 onlineglom.properties: Add explanatory comments.
3006 * src/main/resources/onlineglom.properties: Also change the default user
3007 from ben to someuser, to avoid the risk of people thinking we just
3008 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3010 2011-06-28 Ben Konrath <ben@bagu.org>
3012 Use filename in Log for incorrect passwords.
3014 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3015 getFileName(String) method to get the filename from the URI.
3017 2011-06-28 Ben Konrath <ben@bagu.org>
3019 Add the table name to the URL token for the ListPlace.
3021 This makes things consistent between the DetailsPlace and the
3022 ListPlace. It also allows the the ListPlace to be bookmarked.
3024 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3025 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3026 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3027 Remove getDefaultListLayout(). The default layout is now returned
3028 by the getListLayout() method when the table name is an empty string.
3029 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3030 Add table name field. Change to a new ListPlace when the table
3031 has been changed. Use getListLayout() for getting the default
3033 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3034 Add table name field. Set the correct table name in the list box
3035 when loading from bookmark. This corrects a problem for the
3037 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3038 Move table name to super-class (HasSelectableTable). Move document
3039 and table URL keys to super-class in HasSelectableTable.
3040 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3041 Add table name field. Add Tokenizer class with URL key common to
3042 the subclasses (DetailsPlace and ListPlace).
3043 * src/main/java/org/glom/web/client/place/ListPlace.java:
3044 Add table name. Add code to parse the URL token.
3045 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3046 Update ListPlace construction with empty table name string.
3047 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3048 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3049 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3050 Update ListPlace construction with table name string.
3051 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3052 Change defaultTableName field to tableName to reflect how it's now
3053 used. Update the getter and setter methods.
3055 2011-06-28 Ben Konrath <ben@bagu.org>
3057 Enable the table selector in the DetailsView.
3059 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3060 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3062 Remove getDefaultDetailsLayout(). The default layout is now returned
3063 by the getDetailsLayout() method when the table name is an empty
3065 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3066 event handler for table change event. Change to using
3067 getDetailsLayout() for the default details layout.
3068 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3070 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3071 when navigating to the details place.
3073 2011-06-27 Ben Konrath <ben@bagu.org>
3075 Use filename based unique document ID in URL and for RPC.
3077 The document ID is the glom document name with spaces (' ') replaced
3078 with pluses ('+') and without the .glom extension.
3080 This change is mostly a string substitution of 'documentTitle' for
3081 'documentID'. The only code change is the addition of a Documents DTO to get the
3082 filename to document title mappings as indicated below.
3084 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3085 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3086 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3087 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3088 Use Documents DTO to create the document links in the document
3090 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3091 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3092 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3093 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3094 * src/main/java/org/glom/web/client/place/ListPlace.java:
3095 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3096 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3097 * src/main/java/org/glom/web/client/ui/ListView.java:
3098 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3099 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3100 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3101 * src/main/java/org/glom/web/server/Log.java:
3102 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3103 getDocumentTitles() to getDocuments() and return the Documents DTO.
3104 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3105 transferring the filename to document title mappings.
3107 2011-06-25 Ben Konrath <ben@bagu.org>
3109 Make the authentication popup work again.
3111 This bug was introduced when I extracted ConfiguredDocument to its own class.
3113 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3114 correct success / fail status in setUsernameAndPassword().
3116 2011-06-25 Ben Konrath <ben@bagu.org>
3118 Use filename as unique key for configuring database usernames and passwords.
3120 This replaces the use of the Glom document title which could change
3121 depending on the locale. Thanks to Murray Cumming for pointing out this
3124 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3125 * src/main/resources/onlineglom.properties:
3127 2011-06-24 Ben Konrath <ben@bagu.org>
3129 Pass primary key value to DetailsView.
3131 This enables the DetailsView to load the correct data.
3133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3134 primary key value field and set in constructor. Pass primary key
3135 value to getDetailsData().
3136 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3137 variables for document title and primary key value.
3138 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3139 key value to the DetailsPlace.
3141 2011-06-24 Ben Konrath <ben@bagu.org>
3143 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3145 This allows the primary key to be retrieved by the Details button. This
3146 functionality has not been implemented yet but it's in the works.
3148 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3149 the LayoutGroup result to ListView.setCellTable instead of all of its
3150 fields individually.
3151 * src/main/java/org/glom/web/client/ui/ListView.java:
3152 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3153 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3154 get the primary key for the table.
3155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3156 index of the primary key in the LayoutGroup accounting for hidden
3157 primary keys. Rename getJavaNumberFormat() to
3158 convertToJavaNumberFormat() for consistency. Cleanup / add some
3160 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3161 field for primary key index and a field to indicate whether the
3162 primary key is hidden or not.
3164 2011-06-23 Ben Konrath <ben@bagu.org>
3166 Rename getTableData methods to getListData.
3168 This is a rename refactor for consistency with other methods.
3170 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3171 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3172 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3175 2011-06-23 Ben Konrath <ben@bagu.org>
3177 Extract the ConfiguredDocument innerclass into its own class.
3179 This makes the servlet code more object oriented.
3181 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3182 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3183 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3184 new ConfiguredDocument class.
3186 2011-06-21 Ben Konrath <ben@bagu.org>
3188 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3190 This makes things more inline with how libglom works and reduces code
3191 duplication. This refactor lays the groundwork for adding the primary key to
3192 the LayoutGroup object.
3194 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3195 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3197 Change method names to getListLayout and getDefaultListLayout for
3198 consistency. Use LayoutGroup as the DTO for the list layout instead of
3199 ColumnInfo and LayoutListTable.
3200 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3201 new method names along with the LayoutGroup object for transferring the
3203 * src/main/java/org/glom/web/client/ui/ListView.java:
3204 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3205 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3206 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3208 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3209 Replaced with LayoutGroup.
3210 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3211 expectedResultSize and defaultTableName fields which are needed for
3213 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3214 type field which is needed for the list layout but will also be
3215 useful for the details layout as things progress.
3216 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3217 Make class abstract. Remove the unnecessary
3218 getFormattingHorizontalAlignment method. Add setFormatting method.
3220 2011-06-16 Ben Konrath <ben@bagu.org>
3222 Add scripts for building and installing war.
3224 These will help when updating OnlineGlom but they're also good
3225 supplemental documentation of the build and deployment proceeding.
3227 * utils/build-onlineglom-war.sh: New file.
3228 * utils/install-onlineglom-war.sh: New file.
3230 2011-06-16 Ben Konrath <ben@bagu.org>
3232 Create wrapper class to create consistent log messages.
3234 I wrapped methods in the Log class of gwt-log to add the method names
3235 from the servlet and create consistent formatting of the document title
3236 and table names in the log messages.
3238 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3239 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3240 log methods to use methods from wrapped Log class.
3242 2011-06-16 Ben Konrath <ben@bagu.org>
3244 Remove superfluous conditional return.
3246 Thanks to Murray Cumming for pointing this out!