1 2012-06-08 Murray Cumming <murrayc@murrayc.com>
3 SelfHoster: Avoid some compiler warnings.
5 * src/test/java/org/glom/web/server/SelfHoster.java
6 executeCommandLineAndWait():
7 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
8 the now-unused streams for stdout and stderr from the command Processes.
9 These are not used because readln() hangs while waiting for a new line,
10 where there may be no next line. The commented out code is still there
11 to help us figure out how to do this properly.
13 2012-06-08 Murray Cumming <murrayc@murrayc.com>
15 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
17 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
18 Make this actually test the cloning again, though it is not very useful
19 now that we do not use the part that had a problem with cloning before.
21 2012-06-08 Murray Cumming <murrayc@murrayc.com>
23 SelfHoster: Keep trying pg_ctl after starting postgres.
25 * src/test/java/org/glom/web/server/SelfHoster.java
26 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
27 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
28 regular Glom. This seems mad but it seems to work because the first
29 command would fail if pg_ctl would eventually fail.
31 2012-06-08 Murray Cumming <murrayc@murrayc.com>
33 SelfHoster: Wait until the server is really ready.
35 * src/test/java/org/glom/web/server/SelfHoster.java
36 selfHost(): Attempt the connection after starting the server, retrying
37 a few times if necessary, so that the server is really ready already when
38 we return from this method.
39 The regular Glom code does this too because pg_ctl reports success too soon.
41 2012-06-08 Murray Cumming <murrayc@murrayc.com>
43 ConfiguredDocument: Do not add a primary key to portals each time.
45 * src/main/java/org/glom/web/server/ConfiguredDocument.java
46 updatePortalsExtras(): Only add an extra primary key field if there is
47 none, to avoid adding one each time we retrieve the details layout from the
49 This should fix bug #676986 (Ben Konrath)
51 2012-05-25 Murray Cumming <murrayc@murrayc.com>
53 Document.load(): Support version 7 documents.
55 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
56 database_title attribute if the title attribute is not there.
59 2012-05-24 Ben Konrath <ben@bagu.org>
61 Add configuration for auto-generating mvn:i18n from with Eclipse.
63 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
65 2012-05-24 Murray Cumming <murrayc@murrayc.com>
67 Update translations, adding French.
69 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
70 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
71 Add a French translation, using the translation from Glom.
73 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
74 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
75 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
76 Update these based on the translations from Glom.
78 2012-05-24 Murray Cumming <murrayc@murrayc.com>
80 SelfHoster: Add some debug println messages to help when things fail.
82 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
83 System.out.println() lines.
85 2012-05-23 Murray Cumming <murrayc@murrayc.com>
87 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
89 * src/test/java/org/glom/web/server/SelfHoster.java:
90 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
91 instance) instead of just /usr/bin (as on Fedora). Check the result when
94 2012-05-23 Murray Cumming <murrayc@murrayc.com>
96 Remove LayoutItemPortal.get/setNavigationTable().
98 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
99 Remove get/setNavigationTable(), which is only a cache, because it is not
100 used, and does not need to be used, because that decision should be made on
102 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
103 updatePortalsExtras():
104 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
105 getNavigationRecord():
106 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
109 2012-05-21 Murray Cumming <murrayc@murrayc.com>
111 Initial self-hosting for tests.
113 * pom.xml: Change the scope for log4j, to hopefully make it
114 available to the test code which uses it indirectly via jOOQ.
115 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
116 self-hosting, though we only use it for testing.
118 * src/main/java/org/glom/web/server/libglom/Document.java:
119 example rows: Use a map instead of a list for each row of values,
120 so we know what field they are for, instead of relying on the sequence
121 being correct. This is not very efficient, but it does not really need
123 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
124 testReadTableExampleRows(): Adapted.
126 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
127 that returns an Object, for generic use. Note that Object seems to be
128 the implicit base even of double.
129 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
130 for use in CREATE TABLE SQL queries.
131 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
132 to do self-hosting of PostgreSQL databases via its command-line
133 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
134 backends/postgres_self.cc. This is incomplete - it needs more
135 warnings about failures and it needs to clean up properly when things
137 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
138 test of this new class.
140 2012-05-21 Murray Cumming <murrayc@murrayc.com>
142 Document: loading example data: Handle exceptions.
144 * src/main/java/org/glom/web/server/libglom/Document.java:
145 DateFormat.parse() and Double.valueOf() can throw exceptions, though
146 Eclipse did not warn about that.
148 2012-05-20 Murray Cumming <murrayc@murrayc.com>
150 Document: load(), save(): Handle the example rows.
152 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
154 * src/main/java/org/glom/web/server/libglom/Document.java:
155 load(), save(): Load and save the example rows, though the date, time
156 and image types are not handled properly yet.
157 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
158 Add testReadTableExampleRows() just to check that something is read.
160 2012-05-20 Murray Cumming <murrayc@murrayc.com>
162 Document: Add save().
164 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
165 Added getTranslationsMap() for use while saving.
166 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
167 Adedd getUseDefaultFormatting() for use while saving.
168 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
169 and several private methods that it uses.
171 This will be useful while testing via self-hosting.
172 It is not complete, but should be complete enough for testing.
174 2012-05-17 Murray Cumming <murrayc@murrayc.com>
176 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
178 * src/main/java/org/glom/web/client/OnlineGlomService.java
179 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
180 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
181 Remove getSortedListViewData() and getSortedRelatedListData(), adding
182 the sort column index and ascending bool to the regular method.
183 Instead, a sort column index of -1 now means no sort.
184 This is less explicit, but it's fairly simple, reduces the amount of
185 code, and makes the OnlineGlomService API slightly smaller.
186 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
187 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
189 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
190 getListViewData(), getRelatedListData():
191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
192 getListViewData(), getRelatedListData():
193 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
195 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
197 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
202 2012-05-16 Murray Cumming <murrayc@murrayc.com>
204 Use translations for top-level groups too.
206 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
207 updateTitlesForLocale(): Use the translation for the group
208 as well as for child items.
212 Just recompiled to fix a problem in the released .tar.gz file.
216 2012-05-15 Murray Cumming <murrayc@murrayc.com>
218 Corrections to navigation to related records.
220 * src/main/java/org/glom/web/client/OnlineGlomService.java:
221 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
222 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
223 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
224 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
225 relationship name, because the relationship name is not necessarily unique
227 TOOD: This is inefficient, because it passes the whole list of
228 child field items back to the server, but it is more correct, and happens
229 to fix a bug with the primary key being lost after a few navigations.
230 There is probably a chance to make this more efficient anyway in some
233 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
234 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
235 * src/main/java/org/glom/web/server/ConfiguredDocument.java
236 * src/main/java/org/glom/web/server/database/DBAccess.java
237 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
238 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
241 2012-05-15 Murray Cumming <murrayc@murrayc.com>
243 Fix the use of translations.
245 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
246 Add updateTitlesForLocale().
247 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
248 Call it to discard unwanted translations and to make getTitle() return
249 the wanted translation wihout the need for the client code to specify a locale.
250 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
251 getTitle(): Fallback to the original title, as libglom does.
253 2012-05-15 Murray Cumming <murrayc@murrayc.com>
255 Document: Correctly report the number of available translation locales.
257 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
258 the available locale IDs list.
259 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
260 testLocales: Test this.
262 2012-05-15 Murray Cumming <murrayc@murrayc.com>
264 SqlUtils: Use camelCase.
266 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
267 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
268 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
269 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
270 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
271 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
273 2012-05-15 Murray Cumming <murrayc@murrayc.com>
275 Use jOOQ's tableByName() and fieldByName.
277 * pom.xml: Use jOOQ 2.3.1 to get the new API.
278 * src/main/java/org/glom/web/server/SqlUtils.java:
279 build_sql_select_step_with_where_clause(), .createField(),
280 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
281 so we can get correct quoting and escaping. Thanks to Lukas Eder for
282 adding this, and other things, to jOOQ.
284 2012-05-15 Murray Cumming <murrayc@murrayc.com>
286 SqlUtils: Remove the Connection parameters.
288 * src/main/java/org/glom/web/server/SqlUtils.java:
289 build_sql_select_with_key(), build_sql_select_with_where_clause(),
290 createSelect(), build_sql_select_step_with_where_clause(),
291 build_sql_count_select_with_where_clause(),
292 build_sql_select_count_rows(): Remove the Connection parameter because
293 jOOQ does not actually need a connectionwhen it is just used to build
295 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
297 * src/main/java/org/glom/web/server/ReportGenerator.java:
299 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
301 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
302 Constructor, getListData(), getResultSizeOfSQLQuery():
303 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
304 getSelectQuery(), getCountQuery():
305 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
306 getSelectQuery(), getCountQuery():
307 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
308 getNavigationRecord(): Adapted.
310 2012-05-14 Murray Cumming <murrayc@murrayc.com>
314 * src/main/java/org/glom/web/server/SqlUtils.java:
315 get_find_where_clause_quick(): Use a comparison of
316 lowercase values, instead of a simple equals. Regular Glom
317 uses the PostgreSQL ILIKE operator but jOOQ does not
318 support that just yet, though it will soon.
320 2012-05-14 Murray Cumming <murrayc@murrayc.com>
322 TableToViewDetails: Use a real serialization ID.
324 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
325 Though this does not fix the serialization problem.
327 2012-05-12 Murray Cumming <murrayc@murrayc.com>
329 Added LayoutItemPortalDeepCloneTest.
331 2012-05-11 Murray Cumming <murrayc@murrayc.com>
333 Make navigation work again.
335 * src/main/java/org/glom/web/server/libglom/Document.java:
336 Add getLayoutItemFieldShouldHaveNavigation().
337 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
338 Replace get/setAddNavigation() with the partly-existing
339 get/setNavigationTableName(), with an empty string being no navigation,
340 because this is simpler. Use the new
341 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
343 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
344 Add updateFieldsExtras() and call setNavigationTableName in it.
345 getDetailsLayoutGroup(),
346 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
347 createLayout(): Adapted.
348 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
349 Constructor: Adapted.
351 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
352 Replace get/setAddNavigation() with get/setNavigation(), returning a
353 TableToViewDetails class with both the table name and UsesRelationship,
354 because both are need. The previous code used java-libglom's output
355 variable (strangely, via sharedptr) to return both, but we cannot really
357 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
358 getNavigationRecord(): Adapt. However, we cannot actually use the cache
359 here because it somehow gets set to null during deepCopy(). I must test this.
360 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
361 testGetSuitableTableToViewDetails(): Adapted.
363 TODO: Find out why deepClone() is not quite working.
365 2012-05-11 Murray Cumming <murrayc@murrayc.com>
367 DBAccess: Simplify the retrievel of full field details.
369 * src/main/java/org/glom/web/server/database/DBAccess.java
370 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
371 because the Document loading should have done this.
373 2012-05-11 Murray Cumming <murrayc@murrayc.com>
375 Document: Correct loading of doubly-related layout fields.
377 * src/main/java/org/glom/web/server/libglom/Document.java:
378 loadUsesRelationship(): Actually set the related relationship, instead
379 of only setting it if it's not found.
381 2012-05-09 Murray Cumming <murrayc@murrayc.com>
383 Replace all appearances of Colour with color.
385 Because US English is dominant.
387 2012-05-09 Murray Cumming <murrayc@murrayc.com>
389 Use colors in HTML format, solving a warning about an unused function.
391 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
392 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
393 Add *asHTMLColor() versions of methods.
394 TODO: However, we should create and cache the results on the server.
395 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
396 * src/main/java/org/glom/web/client/ui/list/ListTable.java
397 * src/main/java/org/glom/web/server/ConfiguredDocument.java
398 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
399 Use the asHTMLcolor() versions.
401 2012-05-09 Murray Cumming <murrayc@murrayc.com>
403 ListViewTable: Constructor: Take the table name as a parameter.
405 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
406 Constructor: Take the tableName, and set the member variable, because
408 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
409 setCellTable(): Pass the table name.
410 This makes navigation to non-default tables work again. I don't know
411 why it worked before in the master branch.
413 2012-05-07 Murray Cumming <murrayc@murrayc.com>
415 ConfiguredDocument: Restore correct addition of hidden primary key items.
417 * src/main/java/org/glom/web/client/ui/list/ListTable.java
418 (ListTable.createCellTable): Uncomment out the check for the hidden
420 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
421 add primary key items for top-level lists and portals, as before,
422 instead of adding them to each group.
423 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
424 Actually implement the extra methods such as setHiddenPrimaryKey() and
425 comment that these are used only for top-level list groups and in portals.
426 This strangeness suggests even more that this should not be squeezed
427 into the LayoutGroup class.
429 2012-05-07 Murray Cumming <murrayc@murrayc.com>
431 Fix Formatting loading.
433 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
434 getFormattingUsed(): Remove the duplicate Formatting member variable
435 in favour of the one from the base class.
436 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
437 Initialize a new Formatting instead of using null by default, so we
438 have some defaults, instead of having to initialize one later just to
439 get the same defaults. This also makes loading of formatting from the
440 document work, because that expected a non-null.
442 2012-05-07 Murray Cumming <murrayc@murrayc.com>
444 RelatedListTable: Make sure that the tableName is set.
446 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
447 Constructor: Take the tableName so it is available later. Otherwise,
448 the server assumes that we mean the default table and cannot find the
450 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
451 setData(): Pass the tableName to the RelatedListTable constructor.
453 2012-05-07 Murray Cumming <murrayc@murrayc.com>
457 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
458 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
459 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
461 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
463 * src/main/java/org/glom/web/server/database/DBAccess.java:
464 convertResultSetToDTO(), getPortal():
465 * src/main/java/org/glom/web/server/database/ListDBAccess.java
467 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
468 Add checks for null objects and out of range access, with log messages to
469 give hints so we can fix these properly.
471 2012-05-07 Murray Cumming <murrayc@murrayc.com>
473 Portals: some corrections.
475 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
477 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
478 constructor: Use getRelationshipNameUsed() instead of getName(), because
479 that is what is meant.
480 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
481 getFromField(): Fix a typo, to get the field name, not the table name.
482 * src/main/java/org/glom/web/server/database/DBAccess.java:
483 getPortal(): Fix a typo that stopped this from working.
485 2012-05-07 Murray Cumming <murrayc@murrayc.com>
487 LayoutItemPortal: Also override getTitleOriginal().
489 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
490 This lets the base getTitle() with no parameters work.
491 TODO: Test this properly.
493 2012-05-06 Murray Cumming <murrayc@murrayc.com>
495 LayoutItemPortal: getTitle*(): Use the relationship title.
497 2012-05-06 Murray Cumming <murrayc@murrayc.com>
499 LayoutItemField: Fix loading of custom titles.
501 * src/main/java/org/glom/web/server/libglom/Document.java
502 loadDataLayoutItemField(): The title, if any, instead of the field
503 title, is stored in a title_custom node. Load it from there.
504 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
506 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
507 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
508 getTitle*() overrides.
509 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
512 2012-05-06 Murray Cumming <murrayc@murrayc.com>
514 LayoutItemField: Fall back to field titles, so some are really shown.
516 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
517 Override getTitleOriginal() and getTitle(), as in java-libglom.
518 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
521 2012-05-06 Murray Cumming <murrayc@murrayc.com>
523 Correct use of setExpectedResultSize().
525 * src/main/java/org/glom/web/server/ConfiguredDocument.java
526 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
527 Use setExpectedResultSize only on top-level groups (for instance, the
528 list layout) or on child portals (in details views).
529 Use the correct table name for portals to avoid SQL errors.
530 Update the expected counts when returning cached layouts.
532 2012-05-06 Murray Cumming <murrayc@murrayc.com>
534 Document: Interpret no group column count as 1.
536 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
537 default, though we now check for this in the UI code anyway.
539 2012-05-06 Murray Cumming <murrayc@murrayc.com>
543 2012-05-06 Murray Cumming <murrayc@murrayc.com>
545 Translatable: Use Hashmap instead of Treemap because GWT supports it.
547 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
548 The use of Treemap lead to this error from async methods, with no
550 "The response could not be deserialized"
552 2012-05-06 Murray Cumming <murrayc@murrayc.com>
554 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
556 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
557 when using the Google -> GWT Compile, or
558 g toolbar button -> GWT Compile Project... feature in Eclipse.
560 2012-05-06 Murray Cumming <murrayc@murrayc.com>
562 ListTable.addColumn(): Protect against a null Formatting.
564 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
565 Create a default Formatting if it is null, because that is the simplest
568 2012-05-06 Murray Cumming <murrayc@murrayc.com>
570 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
572 * src/main/java/org/glom/web/server/ConfiguredDocument.java
573 updateLayoutGroup(): Check that the field is not null.
575 2012-05-06 Murray Cumming <murrayc@murrayc.com>
577 ListViewImpl: Protected against a bad cast error.
579 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
580 onEnterKeyDown(): Do not cast without an instanceof check.
582 2012-05-06 Murray Cumming <murrayc@murrayc.com>
584 ListTable: Protect against an out of range error.
586 * src/main/java/org/glom/web/client/ui/list/ListTable.java
587 createCellTable(): This is unlikely, but can happen while debugging.
589 2012-05-06 Murray Cumming <murrayc@murrayc.com>
591 AsyncMessage onFailure() callbacks: Log the exception message.
593 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
594 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
595 * src/main/java/org/glom/web/client/activity/ListActivity.java:
596 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
597 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
598 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
599 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
600 These are useful clues when something is wrong.
602 2012-05-06 Murray Cumming <murrayc@murrayc.com>
604 ConfiguredDocument: Avoid a null dereference.
606 * src/main/java/org/glom/web/server/ConfiguredDocument.java
607 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
608 details maps are created.
610 2012-05-06 Murray Cumming <murrayc@murrayc.com>
612 Document: Correct the port number parsing.
614 * src/main/java/org/glom/web/server/libglom/Document.java:
615 This lets us actually connect to the database and show the document.
617 2012-05-05 Murray Cumming <murrayc@murrayc.com>
621 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
622 user-interaction, asking us to load a temporary URL in a browser.s
623 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
624 which is apparently necessary for testing the service. See the comment.
625 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
626 Show the exception, if any. This is how I saw the 404 in the HTML in
629 2012-05-05 Murray Cumming <murrayc@murrayc.com>
631 DocumentTest: Move the .glom files into the resources directory.
633 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
634 URI via getResource().
636 2012-05-05 Murray Cumming <murrayc@murrayc.com>
638 Document: Remove the FieldIdentifies inner class.
640 * src/main/java/org/glom/web/server/libglom/Document.java: We only
641 use the Relationship (though the same function in libglom is maybe
642 used in other ways) and so this removes a compiler warning.
644 2012-05-05 Murray Cumming <murrayc@murrayc.com>
646 Document.load() Remove the error code parameter.
648 * src/main/java/org/glom/web/server/libglom/Document.java: load():
649 Remove the parameter. We do not set it yet and it could never have
650 worked as an output parameter (though maybe it did in java-libglom).
651 We could use an exception if we really want the failure reason.
652 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
654 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
655 setUp(), testGetSuitableTableToViewDetails(): Adapt.
657 2012-05-05 Murray Cumming <murrayc@murrayc.com>
659 Make some inner classes static.
661 * src/main/java/org/glom/web/server/ConfiguredDocument.java
662 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
663 * src/main/java/org/glom/web/server/ReportGenerator.java
664 * src/main/java/org/glom/web/server/libglom/Document.java
665 Make all inner classes static that can be static.
667 2012-05-05 Murray Cumming <murrayc@murrayc.com>
669 OnlineGlomServiceImpl: Do not load and check for java-libglom.
671 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
672 init(): We do not use java-libglom any more.
674 2012-05-05 Murray Cumming <murrayc@murrayc.com>
676 Remove mentions of java-libglom.
678 * README: Remove mention of java-libglom, because it no longer needed.
679 * utils/build-onlineglom-war.sh:
680 * utils/check-and-recover-tomcat.py:
681 * utils/install-onlineglom-war.sh: Remove these as they are no longer
682 useful. Building is now far easier, with no need for jhbuild.
684 2012-05-05 Murray Cumming <murrayc@murrayc.com>
686 Fix the build (mvn package)
688 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
689 (LayoutGroup): Make the LayoutItemList inner class static and protected.
690 Otherwise the GWT Java->Javascript compilation fails with just this
691 error, during mvn package or when attempting to view in a browser,
692 in the GWT developer mode in Eclipse.
694 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
695 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
696 [INFO] Compiling module org.glom.web.OnlineGlom
697 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
698 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
699 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
700 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
701 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
702 [INFO] [ERROR] Cannot proceed due to previous errors
704 It has taken me 2 days to find out what was causing that. After reducing
705 the code, the compiler eventually showed me the full error message.
707 2012-05-04 Murray Cumming <murrayc@murrayc.com>
709 ConfiguredDocument: Cache the cloned and stripped layouts.
711 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
712 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
713 layout in a map, so we can retrieve it again without rebuilding it.
715 2012-05-04 Murray Cumming <murrayc@murrayc.com>
717 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
719 2012-05-04 Murray Cumming <murrayc@murrayc.com>
721 libglom classes: Implement some auto-generated emthods.
723 2012-05-04 Murray Cumming <murrayc@murrayc.com>
725 Add GwtTestOnlineGlomService.
727 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
728 However, this (and the other GwtTest*) does not seem to run during
731 2012-05-04 Murray Cumming <murrayc@murrayc.com>
733 Remove use of unsupported features from client code.
735 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
736 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
737 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
738 Use our client version of StringUtils instead of the apache commons one.
740 However, the GWT Javascript compliation still fails.
742 2012-04-25 Murray Cumming <murrayc@murrayc.com>
744 Add a Field class and implement some loading of it in Document.
746 2012-04-25 Murray Cumming <murrayc@murrayc.com>
748 Initial Document loading implementation, instead of libglom.
750 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
751 and Translatable classes, and adapt the rest of the code to use them.
752 However, this is still missing Layout and Field classes and loading.
754 2012-04-24 Murray Cumming <murrayc@murrayc.com>
756 Use of jOOQ: Move Field creation into a utility method.
758 * src/main/java/org/glom/web/server/SqlUtils.java:
759 This lets us improve it more easily.
761 2012-04-24 Murray Cumming <murrayc@murrayc.com>
763 Use of jOOQ: Improve the code to COUNT a sub-select.
765 * src/main/java/org/glom/web/server/SqlUtils.java:
766 Move initial query creation into
767 build_sql_select_step_with_where_clause().
768 build_sql_select_count_rows(): Use the jOOQ API instead of
769 concatentating text, because a jOOQ Select*Step is a TableLike,
770 which is what from() takes.
772 2012-04-23 Murray Cumming <murrayc@murrayc.com>
774 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
776 * pom.xml: Depend on jooq.
777 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
778 methods with jOOQ, based on the C++ implementations in libglom,
779 with some changes to the logic required by jooQ.
780 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
782 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
783 * src/main/java/org/glom/web/server/ReportGenerator.java:
784 * src/main/java/org/glom/web/server/SqlUtils.java:
785 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
786 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
787 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
788 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
789 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
790 Adapt. In particular, the SqlUtils methods now need to take a Connection,
791 because jOOQ needs that, though it seems unnecessary.
793 This is not quite finished. Ideally jOOQ would help us to build
794 table_name.field_name names, quoting and escaping them properly.
795 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
797 2012-04-21 Murray Cumming <murrayc@murrayc.com>
799 Move use of Glom.build_sql*() into a new SqlUtils class.
801 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
802 to wrap Glom.build_sql*(). The parameter types are still Glom one,
803 but this will make it easier to start using something other than
804 libglom or SqlBuilder.
806 2012-04-21 Murray Cumming <murrayc@murrayc.com>
808 Update the project URL.
810 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
812 2012-04-21 Murray Cumming <murrayc@murrayc.com>
814 Main layout: Use a FlowTable instead of absolute positioning.
816 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
817 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
818 child panels/widgets must have an absolute position. But that is annoying, so
819 this adds a FlowTable and puts the child panels in there.
821 2012-04-21 Murray Cumming <murrayc@murrayc.com>
823 GwtTestOnlineGlom: Comment out unused code.
825 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
826 Eclipse has started to say that some code is unused.
828 2012-04-21 Murray Cumming <murrayc@murrayc.com>
830 Update to the latest versions of dependencies.
832 * pom.xml: Update version numbers of dependencies to the latest
834 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
836 * src/main/java/org/glom/web/server/ReportGenerator.java:
837 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
838 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
839 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
841 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
842 Modify the imports where necessary.
844 2012-04-17 Murray Cumming <murrayc@murrayc.com>
846 Style: Remove overflow:hidden from searchbox
848 * src/main/webapp/style.css: Because this pushes the Back To Link
849 label/link on to the next row, which is then hidden due to the
850 hard-coded (in ems) height.
852 2012-04-20 Murray Cumming <murrayc@murrayc.com>
854 Remove some duplicate code.
856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
857 getDocumentInfo(): This must have been duplicated during the merge from the
862 2012-04-19 Murray Cumming <murrayc@murrayc.com>
864 Reports: Localize the waiting for report message.
866 * src/main/java/org/glom/web/client/activity/ReportActivity.java
867 start(): Get the message from the contants.
868 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
870 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
871 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
872 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
873 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
874 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
875 Update these files with the English text for newer strings for now.
877 2012-04-19 Murray Cumming <murrayc@murrayc.com>
879 Reports: Show a message while waiting for the report.
881 * src/main/java/org/glom/web/client/ui/ReportView.java
882 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
883 Add setWaitingText(), to show a message saying that we are
884 waiting for the report to be ready.
885 * src/main/java/org/glom/web/client/activity/ReportActivity.java
886 start(): Call setWaitingText() before calling the async
889 2012-04-19 Murray Cumming <murrayc@murrayc.com>
891 ReportGenerator: Specify date and time formats.
893 * src/main/java/org/glom/web/server/ReportGenerator.java:
894 createFieldValueElement(): Use the default (and localized)
895 short formats, though we still need a way to show 4-digit
896 years without providing the format for every locale.
897 * src/main/java/org/glom/web/server/database/DBAccess.java:
898 convertResultSetToDTO(): Use the short formats here too.
900 2012-04-18 Murray Cumming <murrayc@murrayc.com>
902 ReportGenerator: Use the correct numeric formatting.
904 * src/main/java/org/glom/web/server/ReportGenerator.java
905 createFieldExpression(), createFieldValueElement(): Take the
906 whole LayoutItem_Field instead of just the field name, so
907 we have access to the formatting.
908 createFieldValueElement(): Use JRTextField.setPattern() to
909 specify the numeric formatting, with the help of a
910 regular DecimalFormat.
912 2012-04-18 Murray Cumming <murrayc@murrayc.com>
914 ReportGenerator: Avoid showing null for group by titles.
916 * src/main/java/org/glom/web/server/ReportGenerator.java
917 generateReport(): Use setBlankWhenNull() on the field title
918 style too, because this is used for values in group by
921 2012-04-18 Murray Cumming <murrayc@murrayc.com>
923 ReportGenerator: Add a colon to titles in vertical groups.
925 * src/main/java/org/glom/web/server/ReportGenerator.java
926 addFieldToDetailBandVertical(): Pass true for the withColon
929 2012-04-18 Murray Cumming <murrayc@murrayc.com>
931 ReportGenerator: Simplify the code by using Position more.
933 2012-04-18 Murray Cumming <murrayc@murrayc.com>
935 Reports: Support vertical groups, roughly.
937 * src/main/java/org/glom/web/server/ReportGenerator.java:
938 addToReport(): Rename to addGroupToReport() and, if necessary,
939 call the new addVerticalGroupToReport() method.
940 createFieldValueElement(): Let the caller specify the Y position
943 2012-04-17 Murray Cumming <murrayc@murrayc.com>
945 Reports: Allow a second report to be shown.
947 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
948 clear(): Do not remove the HTML widget, which broke the whole layout.
950 2012-04-17 Murray Cumming <murrayc@murrayc.com>
952 Locales drop-down: Show that we use English by default.
954 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
955 fillView(): When we use English, just because that is the default, when
956 no locale is specified, show that in the Locales drop-down instead of
957 just showing the first item.
959 2012-04-17 Murray Cumming <murrayc@murrayc.com>
961 Unselect the Report/Locale/Table combo item when appropriate.
963 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
964 setPlace(): clear reportName if this is not a ReportPlace.
965 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
966 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
967 When the provided name is empty, unselect all items, so that none are
968 indicated. This uses a for loop because I cannot find a single method
971 2012-04-17 Murray Cumming <murrayc@murrayc.com>
973 Report: Give the user a way to get back to the list.
975 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
976 start(), setPlace(): Show the Back To List link on reports, and also
977 interpret selecting the empty report item as back to list.
979 2012-04-13 Murray Cumming <murrayc@murrayc.com>
981 Really show the selected Report name.
983 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
984 setPlace(): Store the reportName here, if it is that kind of Place.
985 fillView(): Set the selected Report after filling the list of reports.
986 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
987 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
988 null Strings, though we need some way to unselect all ListBox items
991 2012-04-13 Murray Cumming <murrayc@murrayc.com>
993 ReportGenerator: Try to avoid some problems.
995 * src/main/java/org/glom/web/server/ReportGenerator.java
996 addField(): Try to avoid duplicates, and avoid using a null
999 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1001 Reports: Use quickFind.
1003 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1004 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1005 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1006 getReportHTML(): Add a quickFind parameter.
1007 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1008 start(): Pass the quickFind parameter.
1009 * src/main/java/org/glom/web/server/ReportGenerator.java
1010 generateReport(): Take a quickFind parameter.
1012 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1014 ReportPlace: Actually use the report name.
1016 * src/main/java/org/glom/web/client/place/ReportPlace.java
1017 getPlace(): Do not assign the report name to the quickfind.
1019 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1021 Show java.library.path when complaining.
1023 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1024 init(): When telling us to check java.library.path, show the
1027 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1029 ReportGenerator: Do not show nulls.
1031 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1033 ReportGenerator: Make the title font larger.
1035 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1037 ReportGenerator: Put field titles inside groups, if there are groups.
1039 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1041 ReportGenerator: Take the Report itself instead of the name and group.
1043 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1044 Remove getReportLayoutGroup().
1045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1046 getReportHTML(): Pass the report instead
1047 of its name and layout group.
1048 * src/main/java/org/glom/web/server/ReportGenerator.java
1049 generateReport(): Use the report object to use the title
1050 instead of the name.
1052 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1054 ReportGenerator: Remove designBand parameters.
1056 * src/main/java/org/glom/web/server/ReportGenerator.java:
1057 Make designBand a class member instead of passing it to all
1060 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1062 ReportGenerator: Add lines, a bit like in the desktop version.
1064 * src/main/java/org/glom/web/server/ReportGenerator.java
1065 addToReport(): Use JRDesignLine.
1067 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1069 ReportGenerator: Correct the title positions and use some bold style.
1071 * src/main/java/org/glom/web/server/ReportGenerator.java:
1072 Break the code up into reusable functions, correct the placement of
1073 titles, and use normal/bold styles as in the reports in the desktop
1076 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1078 ReportGenerator: Add a header band to show the field titles.
1080 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1081 getReportHTML(): Pass the localeId to the ReportGenerator
1083 * src/main/java/org/glom/web/server/ReportGenerator.java
1084 constructor: Take the localeID so we can get translated field
1086 generateReport(), addToReport(), addFieldToBand(): Add field
1087 titles in a column header band.
1089 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1091 Reports drop-down list: Some improvement.
1093 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1094 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1095 Adedd setSelectedReport(),
1096 setReportList(): Add a blank line so that the user can select the
1098 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1099 start(): Show the current report by calling setSelectedReport().
1100 This does not seem to work yet.
1102 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1104 DetailsActivity, ListActivity: Move some variables into a base class.
1106 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1107 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1108 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1109 the clientFactory, documentID, tableName and authenticationPopup into
1110 a base class, to avoid duplication.
1112 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1114 Translate the Reports label.
1116 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1117 Get the "Reports" label string from the constants.
1118 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1119 perties: Add Reports to the constants.
1121 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1123 Reports: Implement grouping.
1125 * src/main/java/org/glom/web/server/ReportGenerator.java:
1126 Handle LayoutItem_GroupBy items and try to do the right thing
1127 with JRDesignGroup. It seems to work.
1129 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1131 Actually show some data with JasperReports.
1133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1134 getReportHTML(): Move most code into a ReportGenerator class.
1135 * src/main/java/org/glom/web/server/ReportGenerator.java:
1136 Recurse into sub-groups, adding fields to the JasperDesign's details
1137 band. Note that we must set an arbitrary width and height, or it just
1138 will not show any data.
1140 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1142 Reports Chooser: Show the titles, not the names.
1144 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1145 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1146 and the names as the values.
1147 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1148 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1149 group now that we provide the report name, so it should always
1152 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1154 Depend on jasperreports.
1156 * pom.xml: Add the dependency. My plan is to use this on the
1159 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1161 Implement navigation to report places.
1163 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1164 start(): Do not bother to handle all events here.
1165 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1166 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1167 Added getSelectedReport().
1168 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1169 .java: start(): When handling a change to the reports chooser,
1170 call getSelectedReport() and goTo() its ReportPlace.
1171 * src/main/java/org/glom/web/client/ui/ReportView.java
1172 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1173 Added setReportHTML() which puts the html in a gwt HTML widget.
1174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1175 getReportHTML(): Return "TODO" just to show that this works.
1177 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1179 Make ReportPlace usable.
1181 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1182 Mention ReportPlace.
1183 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1184 Correct the @prefix annotation.
1186 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1188 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1190 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1191 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1193 Change getReportLayout() to getReportHMTL() because we will not need to
1194 parse or render the report layout on the client side.
1195 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1196 getReportLayout(): Return the libglom LayoutGroup type because we will
1197 not need to convert to a shared type, because this will not be used on
1199 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1202 Note that there is still no implementation for this.
1205 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1207 Add a (empty) Report Place, View, and Activity.
1209 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1211 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1212 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1213 this into a superclass:
1214 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1215 and also use it as the base of this new ReportPlace:
1216 * src/main/java/org/glom/web/client/place/ReportPlace.java
1218 * src/main/java/org/glom/web/client/ui/ReportView.java
1219 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1220 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1221 Add these, containing mostly boiler-plate for now.
1223 * src/main/java/org/glom/web/client/OnlineGlomService.java
1224 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1225 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1227 Add API to get the LayoutGroup for the report.
1229 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1231 Add and fill a Reports drop-down list box.
1233 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1235 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1236 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1238 Added getReports(document, table, localeID), calling
1239 ConfiguredDocument.getReports().
1240 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1241 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1242 Added setReportsList() and a list widget.
1243 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1244 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1249 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1251 Translations: Add Esperanto.
1253 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1254 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1255 properties: Add this translation because someone took the time to make it.
1257 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1259 Adapt to the java-libglom 1.21.7 API.
1261 * src/main/java/org/glom/web/server/ReportGenerator.java:
1262 addToReport(): get_group_secondary_fields() is now
1263 get_secondary_fields().
1266 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1268 Use the latest java-libglom version.
1270 * pom.xml: Use java-libglom 1.21.7.
1272 2012-03-03 Ben Konrath <ben@bagu.org>
1274 Display date and time in details view.
1276 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1278 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1280 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1282 Require the latest java-libglom.
1284 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1286 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1288 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1290 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1291 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1292 an empty quickfind string. I also corrected libglom to create only
1293 empty where clauses for empty quickfind strings, but this avoids the
1296 2012-02-24 Ben Konrath <ben@bagu.org>
1298 Improve the tabs in the Notebook widget.
1302 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1304 Translations: Try to translate the strings.
1306 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1307 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1308 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1309 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1310 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1311 Take the Open translation from GTK+'s .po files.
1312 Take the Details translation from Glom's po files.
1313 I have added the other strings to Glom so we can get translations that way:
1314 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1316 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1318 TableSelectionViewImpl: Put the search label and entry in a div.
1320 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1321 Put the search widgets in a FlowTable so that the CSS can be used to
1322 style them while keeping them together.
1323 * src/main/webapp/style.css: Mention the new div.
1325 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1327 Translate more strings in more locales.
1329 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1330 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1331 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1332 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1333 Translate the "Details" and "Open" string too.
1335 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1336 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1337 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1338 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1339 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1340 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1341 Add these new locales as placeholders though they currently contain English.
1343 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1345 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1347 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1348 Check the ConfiguredDocument* for null before using it.
1350 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1352 Tell Eclipse about the generated java files.
1354 * .classpath: This lets it find OnlineGlomConstants.java.
1355 It would be nice if Eclipse just used the maven build files.
1357 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1359 Prevent a crash when no locale is specified in the URL.
1361 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1362 Avoid returning a null string, obtained from
1363 Window.Location.getParameter(). This caused a crash when it was
1364 later passed to libglom's API.
1365 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1366 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1367 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1368 guard against future null strings.
1370 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1372 Use the ?locale= query param instead of the &lang= token param.
1374 * src/main/java/org/glom/web/client/place/ListPlace.java
1375 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1376 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1377 Remove the lang token key and value.
1379 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1380 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1381 When the user selects a different locale from the chooser, use
1382 Window.Location.assign() to change the URL, which then causes a reload.
1384 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1385 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1386 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1387 * src/main/java/org/glom/web/client/activity/ListActivity.java
1388 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1389 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1390 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1391 * src/main/java/org/glom/web/client/ui/ListView.java:
1392 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1394 Remove localeID member variables and method/constructor parameters, instead
1395 using Utils.getCurrentLocaleID() when we need a localID to pass to
1398 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1400 Internationalize the UI strings.
1402 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1403 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1404 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1405 because it is unused. Messages are apparently strings that can have
1406 parameters, but we do not need that yet, so Contants will be enough for now.
1407 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1408 to say that we support the en and de locales.
1409 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1410 The original English strings.
1411 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1412 Some German translations of the English strings.
1413 The i18n goal then uses the .properties file to generate an
1414 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1415 returns an implementation that returns the translated strings.
1416 The documentation suggests putting these in src/java/*/client/, but it seems
1417 best to put it in src/resources/*/client/.
1418 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1419 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1420 instead of hard-coding them.
1421 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1422 but that does not seem to stop the build, though it confuses Eclipse.
1424 You can see the translated string by adding ?locale=de to the URL, like so:
1425 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1427 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1429 Improve null/empty String checks.
1431 * pom.xml: Add a dependency on commons-lang, to use
1432 org.apache.commons.lang.StringUtils.
1433 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1434 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1435 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1436 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1437 Use StringUtils.isEmpty().
1439 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1440 StringUtils class with a static isEmpty() function because we
1441 cannot use org.apache.commons.lang.StringUtils in client-side
1442 GWT code because it (apparently) cannot be compiled to javascript.
1443 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1444 * src/main/java/org/glom/web/client/activity/ListActivity.java
1445 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1446 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1447 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1448 * src/main/java/org/glom/web/client/place/ListPlace.java
1449 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1450 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1451 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1452 * src/main/java/org/glom/web/client/ui/details/Group.java
1453 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1454 our StringUtils.isEmpty() function.
1456 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1458 Update to the latest java-libglom API.
1460 * pom.xml: Require java-libglom 1.21.4.
1461 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1462 getDocumentInfo(), getListViewLayoutGroup():
1463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1465 * src/main/java/org/glom/web/server/database/DBAccess.java
1466 getFieldsToShowForSQLQueryAddGroup(),
1467 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1468 with either get_database_title_original() or
1469 get_database_title(localeID).
1471 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1473 ConfiguredDocument: Avoid a null pointer exception.
1475 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1476 Initialize localeID to "" to avoid returning a null String which
1477 causes a crash in java-libglom's swing-generated code.
1479 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1481 Some simple renaming.
1483 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1484 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1485 for localeChooser. This seems more appropriate and is less ambiguous
1486 particularly in the .css file.
1488 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1490 ConfiguredDocument: Rename the localedID private member variable.
1492 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1494 Adapt to the latest java-libglom API from git master.
1496 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1497 libglom now uses only Vector instead of List, which uses add() instead of
1500 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1502 ConfiguredDocument: Rename the localedID private member variable.
1504 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1506 Build a source tarball with mvn assembly:single
1508 * assembly.xml: Add this file.
1509 * pom.xml: Use the maven-assembly-plugin and tell it to use
1510 our assembly.xml file.
1512 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1514 OnlineGlomServiceImpl: Get .glom files recursively.
1516 * pom.xml: Depend on commons-io from org.apache.commons.
1517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1518 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1519 files recursively, and with the easier filter for the extension.
1520 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1521 simplify that code too.
1523 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1525 README: Mention that you must install java-libglom packages separately.
1527 But then it works, because java-libglom is now in the central maven
1530 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1532 locales drop-down: Show the correct selected locale when the URL changes.
1534 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1535 .java: setPlace(): Move some code into fillView().
1537 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1539 locales drop-down: Do not lose the primary key.
1541 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1542 start(): onLocaleChange(): Pass the current primary key value,
1543 instead of an empty value.
1545 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1547 locales drop-down: Do not lose the drop-down selection.
1549 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1550 .java (TableSelectionActivity.fillView): Set the selected locale
1551 after changing the drop-down items (though we do not really need
1552 to change them just because the locale changes.)
1554 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1556 locales drop-down: Change the tables list when this changes.
1558 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1559 .java: TableSelectionActivity.start(): Move the async table titles
1560 retrieval into a private fillView() method and also call this when
1561 the chosen locale changes.
1562 Note that the document title is not actually translatable yet, but
1563 that is a problem that I should fix soon in libglom.
1565 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1567 Improve the placement of the locales drop-down.
1569 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1570 Put the title and locales drop-down in a div (gwt.FlowTable).
1571 * src/main/webapp/style.css: Add magic css properties to make this work.
1572 Also remove the left margin from the title so that it lines up with the
1575 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1577 locales selector: Show human-readable locale titles.
1579 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1580 getDocumentInfo(): Use java.util.Locale to show a real title of
1581 each locale, in the locale's own language.
1583 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1585 Add a language/locale selector drop-down.
1587 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1588 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1589 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1590 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1591 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1592 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1593 Add a ListBox to show the available locales. Add getLocaleSelector(),
1594 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1595 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1596 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1597 java: Add these classes.
1598 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1599 start(): Fill the locales ListBox. Handle its change event, firing a
1601 setPlace(): Show the selected locale as specified by the URL token.
1602 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1603 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1604 Handle LocaleChangeEvent, going to a new *Place with that locale.
1606 The placement of the ListBox is not pretty, and it currently uses the ID
1607 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1611 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1613 Search box: Show the search text from the URL token.
1615 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1616 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1617 Add setQuickFindText().
1618 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1619 .java: setPlace(): Store the queryText if the place is a ListPlace,
1620 and call TableSelectionView.setQuickFindText().
1622 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1624 Allow use of translations via, for instance, &lang=de in the URL.
1626 * pom.xml: Use the unstable java-libglom 1.21 version.
1628 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1629 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1630 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1631 init(): Instead of calling TranslatableItem.set_current_locale()
1632 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1633 However, this is only for default locales, which are not needed to
1634 change the locale in the URL.
1635 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1636 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1637 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1638 layout for a particular locale.
1639 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1640 Add get/setDefaultLocaleID().
1641 getDocumentInfo(), getListViewData(), getRelatedListData(),
1642 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1643 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1644 localeID parameter, so we can get the layout for a particular locale.
1646 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1647 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1648 * src/main/java/org/glom/web/client/place/ListPlace.java:
1649 Parse and construct a lang parameter too.
1651 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1652 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1653 passed to subsequent methods and constructors.
1654 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1655 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1656 Store the localeID from the *Place and pass it to other constructors
1657 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1659 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1660 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1661 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1662 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1663 * src/main/java/org/glom/web/client/ui/ListView.java:
1664 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1665 Take localeID parameters and pass them to subsequent constructors and
1666 methods, so that the layout is always retrieved for that locale.
1668 This is rather repetitive.
1670 Note that "" means the original (default) locale of the Glom document,
1671 which is usually English.
1673 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1675 Documents: Remove final keyword to fix startup configuration.
1677 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1678 final keywords on the private member variables because that breaks
1679 the startup, apparently (there are warnings) because it stops them
1680 from being serialized. I added these in the previous commit.
1682 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1684 Documents: Add some final keywords.
1686 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1689 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1691 OnlineGlomServiceImpl: Add to overview comments.
1693 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1694 Note that this is where all the document are loaded. They are not
1695 loaded freshly for each page.
1697 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1701 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1702 Add a TextBox for the text of a quick find.
1703 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1705 setBackLink(): Add a String quickFind parameter.
1706 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1707 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1708 to the base interface, because that is how TableSelectionViewImpl is used.
1709 * src/main/webapp/style.css: Add style for the search box and its label.
1711 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1712 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1713 Add these files, based on the existing TableChangeEvent and
1714 TableChangeEventHandlers.
1715 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1716 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1717 a ListPlace() that the user should be taken to.
1718 * src/main/java/org/glom/web/client/activity/ListActivity.java
1719 start(): Handle it here too and adapt the TableChangeEvent handler to
1720 pass the extra "" quickFind parameter to ListPlace.
1721 * src/main/java/org/glom/web/client/place/ListPlace.java:
1722 Constructor: Take an extra String quickFind parameter and store it,
1723 returning it from a new getQuickFind() method.
1724 getToken(): Put the quickFind text in the URL token.
1725 getPlace(): Parse the quickFind text from the URL token.
1726 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1727 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1728 ListPlace constructor.
1729 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1730 .java: start(): Add a Change handler for the TableSelectionView's
1731 TextBox (via its base HasChangeHandlers interface), firing the new
1732 QuickFindChangeEvent.
1733 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1734 pass the extra "" quickFind parameter.
1736 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1737 setCellTable(): Add a String quickFind parameter and pass it to
1738 the ListViewTable() constructor.
1739 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1740 setCellTable() in the base interface, because that is how ListViewImpl
1743 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1744 Add a String quickFind member variable.
1745 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1746 Constructor: Add a String quickFind parameter, storing it in the
1747 base ListTable's member variable.
1748 onRangeChanged(): Pass quickFind to the
1749 OnlineGlomServiceAsync.getSortedListViewData() and
1750 OnlineGlomServiceAsync.getListViewData() methods.
1752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1753 getListViewData(), getSortedListViewData(): Add a String quickFind
1754 parameter, passing it to ConfiguredDocument.getListViewData().
1755 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1756 Change getListViewData(), getSortedListViewData() in the base interface,
1757 because that is how OnlineGlomServiceImpl is used, via this:
1758 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1759 Change getListViewData(), getSortedListViewData() here too.
1760 This class can apparently be used to asynchronously call methods on
1761 OnlineGlomService, and GWT seems to implement that after recognizing
1762 just the *Async name convention and the extra AsyncCallback parameters.
1764 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1765 getListViewData(): Add a String quickFind parameter, and pass it to
1766 ListViewDBAccess.getData().
1767 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1768 getListData(): Add a String quickFind parameter and pass it to
1770 getSelectQuery(): Add a String quickFind parameter.
1771 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1772 getSelectQuery(): Add a String quickFind parameter and use it with
1773 Glom.get_find_where_clause_quick() to pass a where_clause to
1774 Glom.build_sql_select_with_where_clause(), to actually filter the
1776 getData(): Add a String quickFind parameter, passing it to getListData().
1777 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1778 va: getData(): Pass an empty string to getListData() for the
1779 quickFind parameter.
1781 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1783 ListTable: Minor change.
1785 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1786 createCellTable(): Make this protected instead of public.
1788 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1790 Many files: Use final for the parameters and use the @override attribute.
1792 2012-01-22 Ben Konrath <ben@bagu.org>
1794 Add anchor links for single line text that starts with http, ftp and www.
1798 2012-01-22 Ben Konrath <ben@bagu.org>
1800 Add ellipsis to single line text in details view.
1804 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1806 Remove all javadoc author tags.
1808 Because they are awkward and meaningless when many people touch
1810 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1812 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1814 Revert the COPYING.LESSER to COPYING rename.
1816 Apparently both should be there if it is LGPL.
1818 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1820 *View: Remove unused imports.
1822 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1823 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1824 * src/main/java/org/glom/web/client/ui/ListView.java:
1825 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1826 Remove unused imports, as suggested by Eclipse.
1828 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1830 Move the *View::Presenter types, and some API into one base View.
1832 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1833 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1834 * src/main/java/org/glom/web/client/ui/ListView.java:
1835 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1836 Presenter, setPresenter() and clear() into a shared base interface,
1837 to avoid the unnecessary duplicate Presenter types and to more clearly
1838 show how the *Views share the same structure, even if they are not
1839 used polymorphically.
1841 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1842 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1844 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1845 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1846 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1848 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1851 Feel free to revert this if there is a good reason for the duplicate
1854 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1856 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1858 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1859 a class member instead of a local variable in the method.
1860 This lets us use it to get the view instances, for use in tests.
1861 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1862 beforeOnlineGlom(): Test some more details of the initial view.
1863 Again, this is not very useful.
1865 To really test gwt-glom we will need to start a local postgresql
1866 instance with local data, like the Glom tests in C++.
1868 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1870 pom.xml: Mention the LGPL license.
1872 * pom.xml: Add a licenses section.
1873 * COPYING.LESSER: Move this to COPYING, which
1874 previously contained the GPL. But gwt-glom is all LGPL.
1876 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1878 Add project information to README and pom.xml.
1880 * README: Add a brief description and mention some mvn
1882 * pom.xml: This extra information shows up in mvn site
1885 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1887 Use the latest java-libglom version.
1889 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1891 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1893 GwtTestOnlineGlom: Test a little more.
1895 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1896 protected rather than private, as suggested by the gwt-test-utils
1898 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1899 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1900 Test the initial visibility of the panels.
1902 However, this is not a very useful test.
1903 And I wonder how we should generally test using this idea for an
1904 activity/places app like ours where the real changes happen implicitly
1905 based on the history token/URL.
1907 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1909 Slight modification to *Mapper comments.
1911 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1912 (DataActivityMapper)
1913 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1915 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1917 Remove comments mentioning GIN because they are just copied from
1918 the example code and are apparently not helpful:
1919 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1920 Also change the mention of a class that is only in the example code.
1922 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1924 GwtTestOnlineGlom test: Minor changes.
1926 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1927 Avoid the long qualified class name and modify the comment
1928 because it is now obvious to me that the mocked class is the only
1929 custom one created via GWT.create().
1931 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1933 Tests: Added the beginnings of a test using gwt-test-utils.
1935 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1936 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1937 which tells gwt-test-utils what class will be tested.
1938 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1939 Add a simple (but empty) test case. One class, used by the OnlineGlom
1940 class, is mocked so that it can be created. However, I am not sure
1941 why only this class needs to be mocked.
1943 Note that mockito seems more popular, and clearer, than easymock,
1944 but I have not got that working yet. It might be a matter of the
1947 This test is run during mvn integration-test.
1949 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1951 Tests: Use junit4-style syntax instead of junit3-style.
1953 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1954 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1955 * src/test/java/org/glom/web/shared/DataItemTest.java:
1956 Use the @Test annotation rather than relying on the test*() prefix.
1957 Also no longer implement TestCase, to avoid triggering support for
1958 the junit3-way, which stops the annotations from working.
1959 Change the imports from import junit.framework.* to
1960 import org.junit.*, which is apparently the new way.
1962 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1964 Added a test for ListPlace token parsing and creation.
1966 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1967 This is much the same as DetailsPlaceTest.
1969 I wonder how we could test the other parts of the *Place API.
1971 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1973 DetailsPlace test: Also test getToken() and recreation via getPlace().
1975 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1976 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1977 recreate it, testing the recreated DetailsPlace for the same parameter
1980 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1982 Use the surefire-report plugin.
1984 * pom.xml: This generates a HTML report about the tests in
1985 target/site/surefire-report.html
1986 when you do mvn surefire-report:report. It seems to be popular/normal.
1988 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1990 Added a test for DetailsPlace.
1992 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1993 Test the getPlace() token parsing.
1995 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1997 Added a first unit test.
1999 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2000 * src/test/java/org/glom/web/shared/DataItemTest.java:
2001 This is a silly test but it is just to get things started. Note that
2002 maven/junit finds the test because it looks in src/test by default.
2004 2011-12-22 Ben Konrath <ben@bagu.org>
2006 Change charsetName to "UTF-8" when replacing line breaks.
2008 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2009 that work in Java (such as "UTF8") will not work when compiled to
2012 This fixes a problem with multi-line details view fields that have hard
2013 line breaks. The "License Text" field on this page demonstrates the
2016 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2018 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2020 2011-12-22 Ben Konrath <ben@bagu.org>
2022 Fix another bug with related list navigation.
2024 I've tested all the navigation buttons in all of the related lists
2025 so things should be good now.
2027 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2029 2011-12-22 Ben Konrath <ben@bagu.org>
2031 Fix a crasher when refreshing the list view with the default table.
2033 This crash will also happen when loading the list view with the default
2034 table from a link or bookmark.
2036 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2037 to the main document selection page when the document id hasn't been
2039 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2040 the main document selection page when the document id hasn't been
2042 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2043 values for the details place when the document id hasn't been set.
2044 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2045 values for the list place when the document id hasn't been set.
2047 2011-12-21 Ben Konrath <ben@bagu.org>
2049 Protect against NPE when glom.document.locale is not in config.
2051 This patch protects against an NPE when glom.document.locale is not in
2052 the config file. This NPE will also happen if glom.document.locale is
2055 The patch also updates the error message to display the class name when
2056 the getMessage() returns null. This was happening when the NPE was
2057 thrown and I had "Configuration Error: null". If an NPE is encountered
2058 with this patch, "Configuration Error: NullPointerException " will be
2061 This commit closes this bug:
2063 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2065 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2067 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2069 Rename onlineglom.properties to onlineglom.properties.sample.
2071 * src/main/resources/onlineglom.properties: Rename to:
2072 * src/main/resources/onlineglom.properties.sample:
2073 * src/main/resources/README: And add this file explaining that people
2074 should rename it back when deploying.
2076 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2078 Allow choosing the translation in the .properties file.
2080 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2081 init(): Read a glom.document.locale value from the configuration file
2082 and call Glom's TransatableItem::set_current_locale() method.
2083 * src/main/resources/onlineglom.properties: Add a commented-out
2084 example of this new setting.
2086 It would be better to add &lang=de_DE to the URL, but the current
2087 libglom API does not allow us to do this easily. I am working on that.
2089 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2091 Avoid a crash in parsing of token parameters.
2093 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2094 ava: getTokenParams(): Do not crash if a parameter has a key but no
2095 value, and ignore parameters with neither.
2097 2011-12-17 Murray Cumming <murrayc@murayc.com>
2099 History token building/handling: Improve use of token parameters.
2101 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2102 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2103 and buildParamsToken(HashMap), for use by derived classes.
2104 Make the separator private because it is no longer be needed.
2105 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2106 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2107 instead of manual string concatenation.
2108 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2109 of hardcoded indices and awkward splitting code.
2110 * src/main/java/org/glom/web/client/place/ListPlace.java
2111 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2112 instead of manual string concatenation.
2113 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2114 of hardcoded indices and awkward splitting code.
2115 This should fix bug #666420
2117 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2119 Fix a Navgiation->Navigation typo in the code.
2121 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2122 Rename processNavgiation() to processNavigation().
2124 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2126 Fix a seperator->separator typo in the code.
2128 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2129 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2130 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2133 2011-12-15 Ben Konrath <ben@bagu.org>
2135 Cleanup some comments.
2137 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2139 2011-12-14 Ben Konrath <ben@bagu.org>
2141 Replace \n with <br/> for multiline text in the details view.
2143 Vertical scrollbars are added when needed as well.
2145 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2147 2011-12-14 Ben Konrath <ben@bagu.org>
2149 Specify the font for document selection links.
2151 * src/main/webapp/style.css:
2153 2011-12-14 Ben Konrath <ben@bagu.org>
2155 Fix bouncy CellTable while paging.
2157 This doesn't currently work with related list tables in unselected
2160 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2162 2011-12-14 Ben Konrath <ben@bagu.org>
2164 Revamp the appearance of the document selection page.
2166 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2167 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2168 * src/main/webapp/style.css:
2170 2011-12-13 Ben Konrath <ben@bagu.org>
2172 Set navigation button column to the smallest size possible.
2174 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2176 2011-12-13 Ben Konrath <ben@bagu.org>
2178 Change OpenButton nomenclature to NavigationButton.
2180 Using NavigtionButton makes things more generic. Classes, methods and
2181 variables have been changed.
2183 This is a rename-only refactor.
2185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2186 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2187 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2188 Renamed from OpenButtonCell.
2189 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2190 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2191 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2193 2011-12-12 Ben Konrath <ben@bagu.org>
2195 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2197 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2198 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2199 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2200 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2202 2011-12-12 Ben Konrath <ben@bagu.org>
2204 Update variable names and comments.
2206 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2207 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2209 2011-12-12 Ben Konrath <ben@bagu.org>
2211 Properly initialize numNonEmptyRows variable to zero.
2213 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2214 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2216 2011-12-05 Ben Konrath <ben@bagu.org>
2218 Add latest mockup with HTML tables.
2220 Features of this mockup:
2222 -> HTML table for flowtable
2223 -> HTML table for flowtable column
2224 -> Example of how related lists would look
2225 -> Not using text entries for data items
2227 The current version of Online Glom doesn't use HTML tables for the
2230 This mockup has been sent to the glom-devel mailing list but it's good
2231 to have it here as well.
2233 * mockups/details-view-html-tables.html:
2235 2011-12-05 Ben Konrath <ben@bagu.org>
2237 Remove unnecessary getPrimaryKeyField() method.
2239 getPrimaryKeyFieldForTable(String) has been renamed to
2240 getPrimaryKeyField(String).
2242 * src/main/java/org/glom/web/server/database/DBAccess.java:
2243 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2244 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2246 2011-12-05 Ben Konrath <ben@bagu.org>
2248 Add string representation of TypedDataItem value to conversion error message.
2250 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2251 message was extracted into its own method to avoid duplication.
2253 2011-12-05 Ben Konrath <ben@bagu.org>
2255 Add type checking to navigation primary key value creation.
2257 Create navigation primary key only if the expected type from the Glom
2258 document matches the type returned by the SQL query.
2260 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2262 2011-12-05 Ben Konrath <ben@bagu.org>
2264 Rename a couple of variables in RelatedListNavigation.
2266 This is a rename-only refactor.
2268 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2270 2011-12-05 Ben Konrath <ben@bagu.org>
2272 Move getListLayoutGroup() into getListViewLayoutGroup().
2274 This removes getListLayoutGroup(). It was only being called by
2275 getListViewLayoutGroup().
2277 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2279 2011-12-05 Ben Konrath <ben@bagu.org>
2281 Remove check for LayoutItem_Portal in list table method.
2283 This check is no longer necessary because the method isn't being used
2284 to create the LayoutItemPortal DTO.
2286 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2288 2011-12-05 Ben Konrath <ben@bagu.org>
2290 Properly support related list navigation.
2292 Navigation from the "Repository Analyzer -> Package Scans ->
2293 Dependencies" related table wasn't working because the primary key for
2294 related tables wasn't being set properly. This commit fixes the
2297 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2298 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2299 doesn't set the primary key properly for related list tables.
2300 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2301 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2302 useful for getting the primary key for list view tables and for related
2304 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2305 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2306 Move code to set the primary key for the table from the abstract
2307 ListDBAccess class to ListViewDBAccess as it's only correct for list
2309 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2310 Properly add primary key to related list tables.
2312 2011-12-02 Ben Konrath <ben@bagu.org>
2314 Properly set the horizontal alignment of fields.
2316 This fix is for both the list tables and the details view.
2318 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2319 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2320 to set the horizontal alignment of fields.
2322 2011-12-02 Ben Konrath <ben@bagu.org>
2324 Display currency codes in the details view.
2326 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2328 2011-12-02 Ben Konrath <ben@bagu.org>
2330 Avoid duplicate JNI call.
2332 JNI is not as efficient as pure Java and this is an easy (and small)
2335 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2336 Use previously retrieved value for whereClauseToTableName instead of
2339 2011-12-02 Ben Konrath <ben@bagu.org>
2341 Rename a couple of variables in RelatedListNavigation.
2343 This is a rename-only refactor.
2345 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2347 2011-12-02 Ben Konrath <ben@bagu.org>
2349 Indicate clearly that a mismatched primary key type is a bug.
2351 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2352 warning to error. Add 'This is a bug.' to message.
2354 2011-12-02 Ben Konrath <ben@bagu.org>
2356 Update / fix some comments.
2358 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2360 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2362 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2363 Fix comments. Add some TODOs.
2365 2011-12-02 Ben Konrath <ben@bagu.org>
2367 Enable navigation to details view with string primary key from related list.
2369 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2370 Create a text primary key value when return type of result is
2371 java.sql.Types.VARCHAR.
2373 2011-12-02 Ben Konrath <ben@bagu.org>
2375 Use checkboxes for booleans in the details view.
2377 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2379 2011-12-01 Ben Konrath <ben@bagu.org>
2381 Improve performance of related list height calculation.
2383 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2384 Put code to calculate the expected height in a static initializer so
2385 that that it's only called once.
2387 2011-12-01 Ben Konrath <ben@bagu.org>
2389 Show related list tables in notebooks (again).
2391 Calculate the height of the related list tables so the Notebook can be
2392 set the correct height. The height of the related list table is also needed by
2393 FlowTable to be able decide how to create the layout.
2395 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2396 and set the Portal height based on the height of the related list
2397 table and the Portal container.
2398 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2399 Add method to calculate the height of the related list tables.
2400 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2401 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2402 calculate the height of the Pager widget.
2404 2011-12-01 Ben Konrath <ben@bagu.org>
2406 Use CellTable API for table property instead of setting style on Element.
2408 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2410 2011-12-01 Ben Konrath <ben@bagu.org>
2412 Make ListViewTable and RelatedListTable a consistent height.
2414 The tables are now a consistent height regardless of the contents of
2415 the table. A hidden button is added to empty rows to ensure that the
2416 height of these rows will match the height of rows with data.
2418 A navigation button column is now added to every table. The width of
2419 the navigation column is set to 0px when a RelatedListTable shouldn't
2420 have navigation buttons. This maintains the a consistent row height in
2421 tables that don't show the navigation buttons.
2423 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2424 navigation column when not needed.
2425 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2426 arguments for navigation button to constructor of ListViewTable.
2427 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2428 hidden button for empty data rows.
2429 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2430 arguments for navigation button to constructor.
2431 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2432 create navigation buttons. Add hideNavigationButtons() method.
2433 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2434 arguments for navigation button to constructor.
2436 2011-12-01 Ben Konrath <ben@bagu.org>
2438 Use 'visibility: hidden' in Utils.getWidgetHeight().
2440 This is better choice because hidden elements are invisible, don't
2441 respond to events and are not part of the tab order. They will,
2442 however, take up space which is required to be able to calculate the
2443 height of the widget.
2445 * src/main/java/org/glom/web/client/Utils.java:
2447 2011-12-01 Ben Konrath <ben@bagu.org>
2449 Use Utils.getWidgetHeight() in FlowTable.
2451 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2453 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2455 2011-12-01 Ben Konrath <ben@bagu.org>
2457 Put the details css class name on the correct table column.
2459 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2461 2011-11-30 Ben Konrath <ben@bagu.org>
2463 Update for java-libglom API change.
2465 The getters and setters on FieldFormatting and NumericFormat were
2466 changed to remove the 'M'.
2468 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2470 2011-11-29 Ben Konrath <ben@bagu.org>
2472 Only allow RelatedListTables in Portals.
2474 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2476 2011-11-29 Ben Konrath <ben@bagu.org>
2478 Only create a contents panel for Portals when title is being set.
2480 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2482 2011-11-29 Ben Konrath <ben@bagu.org>
2484 Set TabLayoutPanel height based on calculated height its widgets.
2486 This is a potential fix for this bug:
2488 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2490 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2492 2011-11-29 Ben Konrath <ben@bagu.org>
2494 Align details field labels and data with the Open buttons.
2496 * src/main/webapp/style.css:
2498 2011-11-29 Ben Konrath <ben@bagu.org>
2500 Remove unnecessary <div> in the Notebook widget.
2502 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2503 method to get container FlowPanel (<div>).
2504 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2505 initWidget() method directly on the TabLayoutPanel widget instead of
2506 Group's container widget.
2508 2011-11-29 Ben Konrath <ben@bagu.org>
2510 Don't add group titles for Portals in Notebooks.
2512 This reverts the previous patch and fixes a bug I introduced with
2513 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2515 * src/main/java/org/glom/web/client/ui/details/Group.java:
2516 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2518 2011-11-28 Ben Konrath <ben@bagu.org>
2520 Remove unused boolean argument in Portal constructor.
2522 Just a code cleanup.
2524 * src/main/java/org/glom/web/client/ui/details/Group.java:
2525 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2527 2011-11-28 Ben Konrath <ben@bagu.org>
2529 Remove hack for glom 1.18 style glom files.
2531 * src/main/java/org/glom/web/client/ui/details/Group.java:
2532 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2533 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2535 2011-11-28 Ben Konrath <ben@bagu.org>
2537 Use Gda Value version of primary key to log result too large error.
2539 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2541 2011-11-28 Ben Konrath <ben@bagu.org>
2543 Don't use TypedDataItem.getText() for Unknown types from the URL.
2545 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2546 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2547 instead of getText().
2548 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2549 String field and getUnknown() method.
2551 2011-11-28 Ben Konrath <ben@bagu.org>
2553 Log an error message when the java-libglom .so is not present.
2555 The error message was being set in the exception but not logged.
2557 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2559 2011-11-28 Ben Konrath <ben@bagu.org>
2561 Ignore LayoutItem_CalendarPortals.
2563 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2564 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2566 2011-11-28 Ben Konrath <ben@bagu.org>
2568 Extract method for creating the LayoutItemPortal DTO.
2570 Just breaking the code up into smaller chunks.
2572 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2574 2011-11-28 Ben Konrath <ben@bagu.org>
2578 This should have been added with the refactor. Oops!
2580 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2582 2011-11-28 Ben Konrath <ben@bagu.org>
2584 Create primary key value from URL string using type from Glom document.
2586 See this bug, comments 19 - 25:
2588 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2590 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2591 create a TypeDataItem for the primary key here when loading from a
2592 URL. Show the same string for the primary key value as was received
2593 from the URL string (when loading from a URL).
2594 * src/main/java/org/glom/web/server/Utils.java: Update method for
2595 creating the Gda Value from the TypeDataItem to properly deal with
2596 creating a Gda Value based on the Glom document type for the primary
2597 key value string when loading from a URL.
2598 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2599 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2600 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2601 Update for changed method name.
2603 2011-11-27 Ben Konrath <ben@bagu.org>
2605 Rename PrimaryKeyItem to TypedDataItem.
2607 The name PrimaryKeyItem suggests what the class should be used for.
2608 TypedDataItem is a neutral name that describes the class better.
2610 This is a rename-only refactor.
2612 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2613 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2614 * src/main/java/org/glom/web/client/Utils.java:
2615 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2616 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2617 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2618 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2619 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2620 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2622 * src/main/java/org/glom/web/server/Utils.java:
2623 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2624 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2625 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2626 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2628 2011-11-25 Ben Konrath <ben@bagu.org>
2630 Improve Gda Value conversion from PrimaryKeyItem.
2632 The value from the PrimaryKeyItem is only used if its type match the
2633 type from the glom document.
2635 * src/main/java/org/glom/web/server/Utils.java:
2637 2011-11-25 Ben Konrath <ben@bagu.org>
2639 Manually check if the java-liblgom .so is visible to the JVM.
2641 It seems that Tomcat has problems when a static initializer throws an
2642 exception. This check is done before the first method call into
2643 java-libglom so that execution doesn't continue if the .so is not
2646 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2648 2011-11-25 Ben Konrath <ben@bagu.org>
2650 Improve browser configuration error messages.
2654 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2656 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2657 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2658 getConfigurationErrorMessage() method.
2659 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2660 Get and display a specific configuration error message when no Glom
2661 documents are found.
2662 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2663 Implement getConfigurationErrorMessage() method. Surround configuration
2664 code in the init() method with a try/catch block. This allows the
2665 errors to be caught while keeping the servlet available to retrieve the
2666 configuration error message.
2668 2011-11-25 Ben Konrath <ben@bagu.org>
2670 Don't use Strings to hold primary key values.
2672 The primary key values are now held in a new data object
2673 (PrimaryKeyItem) that holds type information and the primary key value
2674 using the correct type.
2676 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2677 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2678 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2679 PrimaryKeyItem instead of String to hold the primary key value.
2680 * src/main/java/org/glom/web/client/Utils.java: Remove
2681 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2682 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2683 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2684 PrimaryKeyItem instead of String to hold the primary key value. Load
2685 document selection page when the documentID has not been set correctly.
2686 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2687 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2689 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2690 Return empty string for URL instead of "null".
2691 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2692 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2693 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2694 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2695 PrimaryKeyItem instead of String to hold primary key values.
2696 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2697 PrimaryKeyValue to a Gda Value.
2698 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2699 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2700 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2701 Replace temporary database access code that uses the PrimaryKeyValue to
2702 Gda Value conversion.
2703 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2704 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2705 PrimaryKeyItem instead of String.
2706 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2707 hold primary key values.
2709 2011-11-24 Ben Konrath <ben@bagu.org>
2711 Use newly added java-libglom API to create queries.
2713 This isn't finished. I still need to stop using Strings for primary key
2714 values in the client code.
2716 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2717 libglom to use fake connections so that retrieving the query string will
2719 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2720 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2721 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2722 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2723 Use the newly added libglom sql methods and classes to create the
2724 query. Add temporary hack to convert primary value strings to Gda
2727 2011-11-23 Ben Konrath <ben@bagu.org>
2729 Don't explicitly set the height of Portals.
2731 See comments 6 - 10 of this bug for details:
2733 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2735 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2737 2011-11-23 Ben Konrath <ben@bagu.org>
2739 Use an HTML table instead of CSS for the FlowTable layout.
2741 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2742 GWT's FlexTable to implement the FlowTable.
2743 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2745 2011-11-18 Ben Konrath <ben@bagu.org>
2747 Add boolean example to HTML table mockup.
2749 * mockups/details-view-html-tables-text-entries.html:
2751 2011-11-17 Ben Konrath <ben@bagu.org>
2753 Ensure the pager buttons are always visible for related lists.
2755 To accomplish this, I've turned off text wrapping in the list view and
2756 related list tables for both the header and data text. The related list
2757 table now has a fixed layout so the it doesn't overflow its container.
2758 This is required to ensure that the cell text is clipped when it
2759 overflows the cell and an ellipsis is added to the right side of the
2760 cell when text is clipped.
2762 A fixed table layout for the related list table in the details view
2763 seems what we want for the details view anyway, so the side-effect is
2766 The ellipsis will only be displayed in Firefox >= 7.
2770 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2772 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2773 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2774 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2776 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2777 Set the 'table-layout: fixed' CSS property to the related list table.
2778 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2779 'white-space: nowrap;' CSS property on both the list view and the
2780 related list tables.
2782 2011-11-16 Ben Konrath <ben@bagu.org>
2784 Rework the fix for empty notebook tab labels.
2786 Setting the empty group titles with its name caused problems for the
2787 details layout. Instead of using libglom's
2788 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2789 to the client when the title is empty. This allows the Notebook to use
2790 the name when the title is empty without affecting anything else.
2792 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2793 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2795 2011-11-16 Ben Konrath <ben@bagu.org>
2797 Set group titles with name when title is empty.
2799 This fixes a problem with an empty notebook tab label in the Lesson
2800 Planner document. The forth tab in the notebook should be "Internet":
2802 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2804 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2805 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2808 2011-11-16 Ben Konrath <ben@bagu.org>
2810 Remove whitespace from the configured username properties.
2812 This assumes that usernames won't have whitespace at the beginning
2813 or end. But I think this is a reasonable assumption.
2815 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2816 String.trim() to remove the whitespace from the username properties.
2818 2011-11-15 Ben Konrath <ben@bagu.org>
2820 Add details view mockup with HTML tables and text entries.
2822 This is from the attachment on this bug:
2824 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2826 * mockups/details-view-html-tables-text-entries.html:
2828 2011-11-15 Ben Konrath <ben@bagu.org>
2830 Add space between the columns of the flow table.
2834 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2836 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2837 space between columns in the flow table.
2839 2011-11-15 Ben Konrath <ben@bagu.org>
2841 Add backup files to the .gitignore.
2843 * .gitignore: Ignore files that end with ~.
2845 2011-11-09 Ben Konrath <ben@bagu.org>
2847 Use latest release of gwt-log.
2849 Gwt-log releases are now being submitted to the maven central
2850 repository so manual installation of the jar is no longer required.
2852 * pom.xml: Update version and groupId of gwt-log dependency.
2854 2011-10-31 Ben Konrath <ben@bagu.org>
2856 Don't use GWT numeric formatting to override the glom currency formatting.
2858 Currencies are now displayed like they are in Glom. See this bug:
2860 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2862 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2864 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2865 currency code to constructor and set it when the cell is rendered.
2866 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2867 currency code to the constructor of the NumericCell.
2869 2011-10-27 Ben Konrath <ben@bagu.org>
2871 Require the latest release of java-libglom (1.17.4).
2875 2011-10-26 Ben Konrath <ben@bagu.org>
2877 Add style to Notebook that matches current theme.
2879 It's not the best style in the world but it's better than the default.
2881 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2882 padding at the bottom of the child widgets.
2883 * src/main/webapp/style.css: Add style for the Notebook.
2885 2011-10-26 Ben Konrath <ben@bagu.org>
2887 Move servlet initialization code to overridden init method.
2889 This is half of the solution to getting proper error messages
2890 displayed when configuration errors occur. Here's the relevant bug:
2892 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2894 The rest of the solution involves surrounding the init method with a
2895 try/catch block and setting a global variable with the error /
2896 exception. A new async method should be created to retrieve and display
2897 the error message / exception.
2899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2900 code from constructor to init method adding exceptions as needed.
2902 2011-10-26 Ben Konrath <ben@bagu.org>
2904 Add script to monitor and restart tomcat if required.
2906 * utils/check-and-recover-tomcat.py: New file.
2908 2011-10-26 Ben Konrath <ben@bagu.org>
2910 Display the correct number of data items in the pager.
2914 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2916 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2917 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2918 The implementation is the same for both tables: Keep track of the
2919 number of non-empty rows and fire and RowCountChangeEvent after the data has
2921 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2922 custom Pager class that subclasses SimplePager to handle displaying
2923 the correct number when empty rows have been added.
2925 2011-10-26 Ben Konrath <ben@bagu.org>
2927 Correct error in previous commit.
2929 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2930 eventBus parameter from listView.setCellTable().
2932 2011-10-26 Ben Konrath <ben@bagu.org>
2934 Fix error in TODO comment.
2936 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2938 2011-10-24 Ben Konrath <ben@bagu.org>
2940 Create Notebook widgets to the details view.
2942 This isn't finished just yet - I still need to create a reasonable
2943 style to match the current theme.
2945 * src/main/java/org/glom/web/client/Utils.java: Add method for
2946 calculating the height of a widget. This is used in the Notebook class.
2947 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2948 new constructor method in Group.
2949 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2950 method for creating child widget that can be used by subclasses
2951 like Notebook. New constructor that allows disabling the group
2952 titles - Notebooks don't set a group title for their child groups.
2953 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2954 to make Notebooks using GWT's TabLayoutPanel.
2955 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2956 constructor that allows disabling the group titles.
2957 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2958 LayoutItemNotebook DTO.
2959 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2960 DTO for Notebooks. It's just an empty class for now but we might need
2961 it to transfer some specific information in the future.
2963 2011-10-21 Ben Konrath <ben@bagu.org>
2965 Add navigation buttons to related list tables.
2967 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2968 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2969 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2970 method getSuitableRecordToViewDetails() for getting the table name
2971 and primary key value for related list navigation buttons.
2972 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2973 private cell renderer class to get the navigation information for
2974 related list tables from the server. Extract the navigation
2975 processing code from the details cell navigation and use it for the
2976 related list navigation as well.
2977 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2978 cell renderer class for the details open buttons. This was needed
2979 because the related list navigation buttons and the list view
2980 navigation buttons need to react differently when clicked.
2981 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2982 the onEnterKeyDown() method because it's now overriden in the
2983 subclasses that are specific to the related list tables and the list
2985 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2986 the vertical size a little because the buttons add a bit of vertical
2987 space to table. This is not a perfect solution because the vertical
2988 size of with table fewer than 5 rows will be a little smaller.
2989 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2990 changes in how navigation buttons are handled.
2991 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2992 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2993 database access object.
2994 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2995 to find the portal for a given relationship name from
2996 RelatedListDBAccess. Add method to find a primary key field for a
2998 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2999 Move code to find the portal for a given relationship name to
3001 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
3002 New file: database access object for getting the related list
3003 navigation information (the table name and the primary key value).
3004 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
3005 DTO for transferring a table name to navigate to and a primary key
3007 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3008 boolean and getter/setter to specifies if the related list should add
3011 2011-10-24 Murray Cumming <murrayc@murrayc.com>
3013 Use the master branch of java-libglom
3015 * pom.xml: Depend on java-libglom 1.19 instead.
3017 This is the master branch. See also the libglom-1-18 branch.
3019 2011-10-11 Ben Konrath <ben@bagu.org>
3021 Enable the open navigation button when the data has been set.
3023 This avoids having active buttons that don't do anything when the data
3026 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3028 2011-10-11 Ben Konrath <ben@bagu.org>
3030 Use IsWidget interface for FlowTableItem.
3032 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
3033 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
3035 2011-10-11 Ben Konrath <ben@bagu.org>
3037 Remove GWT styling from open button in details view.
3039 There are still some issues with how the details cell is arranged but
3040 this should be made to match Glom 1.20. I'm going to leave fixing this
3041 until I have Glom 1.20 up and running.
3043 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
3044 style name on open button.
3045 * src/main/webapp/style.css: Move and edit details-navigation class.
3046 Re-arrange some classes to make them appear in the same order as the
3049 2011-10-07 Ben Konrath <ben@bagu.org>
3051 Update to GWT 2.4.0.
3053 * .gitignore: Ignore new cache directory.
3054 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3055 * pom.xml: Change GWT and maven plugin to 2.4.0.
3056 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3058 * src/main/java/org/glom/web/client/ClientFactory.java:
3059 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3060 * src/main/java/org/glom/web/client/OnlineGlom.java:
3061 Update source for API changes.
3062 * utils/build-onlineglom-war.sh: Remove cache directory before the
3065 2011-10-07 Ben Konrath <ben@bagu.org>
3067 Add navigation buttons in the details view.
3069 This isn't finished but I thought I'd commit what I have as it's a
3070 pretty good start. I still need to:
3072 1. Change the style so that it fits better into the current theme
3073 2. Adjust the details cell to expand as much as possible.
3075 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3076 click handlers to navigation buttons in the DetailsCells. Create a
3077 refreshData() method to get just the data from the server without the
3079 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3080 Update the tableSelector and browser title when the table name
3081 changes without using the tableSelector.
3082 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3083 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3084 getDetailsCells() to getCells(). Update variable names.
3085 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3086 method to set click handler on navigation button. Rename a few
3087 variables. Add navigation buttons where needed.
3088 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3089 variables and methods.
3090 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3091 navigation boolean and navigation table as required in the
3092 LayoutItemField DTO.
3093 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3094 variables for navigation along with getter/setter methods.
3096 2011-10-07 Ben Konrath <ben@bagu.org>
3098 Rename Field to DetailsCell.
3100 This is a refactor-only commit. No functionality has been added or
3103 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3104 Update variable and method names.
3105 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3106 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3107 variable and method names.
3108 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3110 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3111 variable and method names.
3113 2011-10-07 Ben Konrath <ben@bagu.org>
3115 Create separate methods for layout and data the details view.
3117 This is a refactor-only commit. No functionality has been added or
3120 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3121 private methods: setData(), createLayout().
3123 2011-10-07 Ben Konrath <ben@bagu.org>
3125 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3127 This is part of a change to get navigation buttons in the details view
3128 but it should have been done this way from the start.
3130 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3131 for method name change in TableSelectionView.
3132 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3133 Create TableChangeEvent and set the browser title using the
3134 TableSelectionView API.
3135 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3136 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3137 Change getSelectedTable() to getSelectedTableName(). Add
3138 getSelectedTableTitle().
3140 2011-10-07 Ben Konrath <ben@bagu.org>
3142 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3144 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3146 2011-10-07 Ben Konrath <ben@bagu.org>
3148 Update TableChangeEvent to use newTableName naming convention.
3150 This makes the class more consistent with GWT naming conventions.
3152 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3153 Update for method name change in TableChangeEvent.
3154 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3155 for method name change in TableChangeEvent.
3156 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3157 newTableName variable and getter method. Make toDebugString()
3160 2011-09-30 Ben Konrath <ben@bagu.org>
3162 Disable the pager in the list tables when the data row count is less than the minimum.
3164 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3165 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3167 2011-09-30 Ben Konrath <ben@bagu.org>
3169 Add empty rows to the end of related list and list view tables.
3171 I also extracted the cell rendering classes from the ListTable because
3172 the code was becoming a little crazy with all the anonymous inner
3173 classes. My plan is to use these cell rendering classes in the details
3174 view as well so this refactor will be needed for that change.
3176 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3177 set the row count in related list tables if the data has more rows
3178 than the minimum number of rows visible.
3179 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3180 row count in list view tables if the data has more rows than the
3181 minimum number of rows visible.
3182 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3183 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3185 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3186 for rendering TYPE_NUMERIC cells. The code was extracted from the
3188 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3189 class for rendering cells with buttons in list views. The code was
3190 extracted from the ListTable class.
3191 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3192 for rendering TYPE_TEXT cells. The code was extracted from the
3194 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3195 Add empty rows to the end of the data if required. Implement
3196 ListTable.getMinNumVisibleRows().
3197 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3198 cell renderer code to public classes. Return null in
3199 Column.getValue() for empty rows. Add new abstract method:
3200 getMinNumVisibleRows(). Move code to set the row count of the list view
3201 table to ListViewImpl.
3202 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3203 empty rows to the end of the data if required. Implement
3204 ListTable.getMinNumVisibleRows().
3207 2011-09-27 Ben Konrath <ben@bagu.org>
3209 Use GWT.log for client-side debugging statements.
3211 These are optimized out when deployed so I should have used this method
3212 in the first place. These statements will eventually be replaced with some sort
3213 of notification in the browser.
3215 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3216 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3217 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3218 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3219 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3221 2011-09-27 Ben Konrath <ben@bagu.org>
3223 Put tableselector on the right, back to list link on right.
3225 The idea is that the table selector is acting like a label for the
3226 currently displayed table so it should be placed below the document title. This
3227 puts the table title in a similar position to where it is in Glom.
3229 * mockups/details-contacts.html:
3230 * mockups/details-projects.html:
3231 * mockups/listview-contacts.html:
3232 * mockups/listview-projects.html:
3233 * mockups/style.css:
3234 Update mockups to match how the interfaces currently look.
3235 * src/main/webapp/style.css: Swap positions of backlink with the table
3236 selector. Add some space on the left side of the table selector to
3237 line things up with the document title.
3239 2011-09-27 Ben Konrath <ben@bagu.org>
3241 Add field colouring to details view.
3243 This change re-works how field colouring works. The colour formatting
3244 information is now set to the client with the layout information instead of
3245 with the data. This eliminates the need to send the same colour strings for
3246 data in list view column when colour information is set.
3248 In order to set an alternate colour for negative numeric values, the
3249 number is now sent to client and formatted with the GWT NumberFormat class.
3251 This change also fixes:
3253 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3255 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3256 internationalization framework which is needed for client side numeric
3258 * src/main/java/org/glom/web/client/Utils.java: New file for some
3259 client static utility methods.
3260 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3261 the DataItem object to the Field class. Use a utility method to
3262 create the foreignKeyValue string.
3263 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3264 alignment and text colours in the constructor. Add setData(DataItem)
3265 method. Remove setText(String) method.
<