1 2012-05-12 Murray Cumming <murrayc@murrayc.com>
3 Added LayoutItemPortalDeepCloneTest.
5 2012-05-11 Murray Cumming <murrayc@murrayc.com>
7 Make navigation work again.
9 * src/main/java/org/glom/web/server/libglom/Document.java:
10 Add getLayoutItemFieldShouldHaveNavigation().
11 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
12 Replace get/setAddNavigation() with the partly-existing
13 get/setNavigationTableName(), with an empty string being no navigation,
14 because this is simpler. Use the new
15 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
17 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
18 Add updateFieldsExtras() and call setNavigationTableName in it.
19 getDetailsLayoutGroup(),
20 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
21 createLayout(): Adapted.
22 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
25 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
26 Replace get/setAddNavigation() with get/setNavigation(), returning a
27 TableToViewDetails class with both the table name and UsesRelationship,
28 because both are need. The previous code used java-libglom's output
29 variable (strangely, via sharedptr) to return both, but we cannot really
31 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
32 getNavigationRecord(): Adapt. However, we cannot actually use the cache
33 here because it somehow gets set to null during deepCopy(). I must test this.
34 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
35 testGetSuitableTableToViewDetails(): Adapted.
37 TODO: Find out why deepClone() is not quite working.
39 2012-05-11 Murray Cumming <murrayc@murrayc.com>
41 DBAccess: Simplify the retrievel of full field details.
43 * src/main/java/org/glom/web/server/database/DBAccess.java
44 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
45 because the Document loading should have done this.
47 2012-05-11 Murray Cumming <murrayc@murrayc.com>
49 Document: Correct loading of doubly-related layout fields.
51 * src/main/java/org/glom/web/server/libglom/Document.java:
52 loadUsesRelationship(): Actually set the related relationship, instead
53 of only setting it if it's not found.
55 2012-05-09 Murray Cumming <murrayc@murrayc.com>
57 Replace all appearances of Colour with color.
59 Because US English is dominant.
61 2012-05-09 Murray Cumming <murrayc@murrayc.com>
63 Use colors in HTML format, solving a warning about an unused function.
65 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
66 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
67 Add *asHTMLColor() versions of methods.
68 TODO: However, we should create and cache the results on the server.
69 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
70 * src/main/java/org/glom/web/client/ui/list/ListTable.java
71 * src/main/java/org/glom/web/server/ConfiguredDocument.java
72 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
73 Use the asHTMLcolor() versions.
75 2012-05-09 Murray Cumming <murrayc@murrayc.com>
77 ListViewTable: Constructor: Take the table name as a parameter.
79 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
80 Constructor: Take the tableName, and set the member variable, because
82 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
83 setCellTable(): Pass the table name.
84 This makes navigation to non-default tables work again. I don't know
85 why it worked before in the master branch.
87 2012-05-07 Murray Cumming <murrayc@murrayc.com>
89 ConfiguredDocument: Restore correct addition of hidden primary key items.
91 * src/main/java/org/glom/web/client/ui/list/ListTable.java
92 (ListTable.createCellTable): Uncomment out the check for the hidden
94 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
95 add primary key items for top-level lists and portals, as before,
96 instead of adding them to each group.
97 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
98 Actually implement the extra methods such as setHiddenPrimaryKey() and
99 comment that these are used only for top-level list groups and in portals.
100 This strangeness suggests even more that this should not be squeezed
101 into the LayoutGroup class.
103 2012-05-07 Murray Cumming <murrayc@murrayc.com>
105 Fix Formatting loading.
107 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
108 getFormattingUsed(): Remove the duplicate Formatting member variable
109 in favour of the one from the base class.
110 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
111 Initialize a new Formatting instead of using null by default, so we
112 have some defaults, instead of having to initialize one later just to
113 get the same defaults. This also makes loading of formatting from the
114 document work, because that expected a non-null.
116 2012-05-07 Murray Cumming <murrayc@murrayc.com>
118 RelatedListTable: Make sure that the tableName is set.
120 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
121 Constructor: Take the tableName so it is available later. Otherwise,
122 the server assumes that we mean the default table and cannot find the
124 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
125 setData(): Pass the tableName to the RelatedListTable constructor.
127 2012-05-07 Murray Cumming <murrayc@murrayc.com>
131 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
132 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
133 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
135 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
137 * src/main/java/org/glom/web/server/database/DBAccess.java:
138 convertResultSetToDTO(), getPortal():
139 * src/main/java/org/glom/web/server/database/ListDBAccess.java
141 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
142 Add checks for null objects and out of range access, with log messages to
143 give hints so we can fix these properly.
145 2012-05-07 Murray Cumming <murrayc@murrayc.com>
147 Portals: some corrections.
149 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
151 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
152 constructor: Use getRelationshipNameUsed() instead of getName(), because
153 that is what is meant.
154 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
155 getFromField(): Fix a typo, to get the field name, not the table name.
156 * src/main/java/org/glom/web/server/database/DBAccess.java:
157 getPortal(): Fix a typo that stopped this from working.
159 2012-05-07 Murray Cumming <murrayc@murrayc.com>
161 LayoutItemPortal: Also override getTitleOriginal().
163 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
164 This lets the base getTitle() with no parameters work.
165 TODO: Test this properly.
167 2012-05-06 Murray Cumming <murrayc@murrayc.com>
169 LayoutItemPortal: getTitle*(): Use the relationship title.
171 2012-05-06 Murray Cumming <murrayc@murrayc.com>
173 LayoutItemField: Fix loading of custom titles.
175 * src/main/java/org/glom/web/server/libglom/Document.java
176 loadDataLayoutItemField(): The title, if any, instead of the field
177 title, is stored in a title_custom node. Load it from there.
178 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
180 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
181 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
182 getTitle*() overrides.
183 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
186 2012-05-06 Murray Cumming <murrayc@murrayc.com>
188 LayoutItemField: Fall back to field titles, so some are really shown.
190 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
191 Override getTitleOriginal() and getTitle(), as in java-libglom.
192 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
195 2012-05-06 Murray Cumming <murrayc@murrayc.com>
197 Correct use of setExpectedResultSize().
199 * src/main/java/org/glom/web/server/ConfiguredDocument.java
200 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
201 Use setExpectedResultSize only on top-level groups (for instance, the
202 list layout) or on child portals (in details views).
203 Use the correct table name for portals to avoid SQL errors.
204 Update the expected counts when returning cached layouts.
206 2012-05-06 Murray Cumming <murrayc@murrayc.com>
208 Document: Interpret no group column count as 1.
210 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
211 default, though we now check for this in the UI code anyway.
213 2012-05-06 Murray Cumming <murrayc@murrayc.com>
217 2012-05-06 Murray Cumming <murrayc@murrayc.com>
219 Translatable: Use Hashmap instead of Treemap because GWT supports it.
221 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
222 The use of Treemap lead to this error from async methods, with no
224 "The response could not be deserialized"
226 2012-05-06 Murray Cumming <murrayc@murrayc.com>
228 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
230 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
231 when using the Google -> GWT Compile, or
232 g toolbar button -> GWT Compile Project... feature in Eclipse.
234 2012-05-06 Murray Cumming <murrayc@murrayc.com>
236 ListTable.addColumn(): Protect against a null Formatting.
238 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
239 Create a default Formatting if it is null, because that is the simplest
242 2012-05-06 Murray Cumming <murrayc@murrayc.com>
244 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
246 * src/main/java/org/glom/web/server/ConfiguredDocument.java
247 updateLayoutGroup(): Check that the field is not null.
249 2012-05-06 Murray Cumming <murrayc@murrayc.com>
251 ListViewImpl: Protected against a bad cast error.
253 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
254 onEnterKeyDown(): Do not cast without an instanceof check.
256 2012-05-06 Murray Cumming <murrayc@murrayc.com>
258 ListTable: Protect against an out of range error.
260 * src/main/java/org/glom/web/client/ui/list/ListTable.java
261 createCellTable(): This is unlikely, but can happen while debugging.
263 2012-05-06 Murray Cumming <murrayc@murrayc.com>
265 AsyncMessage onFailure() callbacks: Log the exception message.
267 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
268 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
269 * src/main/java/org/glom/web/client/activity/ListActivity.java:
270 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
271 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
272 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
273 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
274 These are useful clues when something is wrong.
276 2012-05-06 Murray Cumming <murrayc@murrayc.com>
278 ConfiguredDocument: Avoid a null dereference.
280 * src/main/java/org/glom/web/server/ConfiguredDocument.java
281 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
282 details maps are created.
284 2012-05-06 Murray Cumming <murrayc@murrayc.com>
286 Document: Correct the port number parsing.
288 * src/main/java/org/glom/web/server/libglom/Document.java:
289 This lets us actually connect to the database and show the document.
291 2012-05-05 Murray Cumming <murrayc@murrayc.com>
295 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
296 user-interaction, asking us to load a temporary URL in a browser.s
297 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
298 which is apparently necessary for testing the service. See the comment.
299 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
300 Show the exception, if any. This is how I saw the 404 in the HTML in
303 2012-05-05 Murray Cumming <murrayc@murrayc.com>
305 DocumentTest: Move the .glom files into the resources directory.
307 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
308 URI via getResource().
310 2012-05-05 Murray Cumming <murrayc@murrayc.com>
312 Document: Remove the FieldIdentifies inner class.
314 * src/main/java/org/glom/web/server/libglom/Document.java: We only
315 use the Relationship (though the same function in libglom is maybe
316 used in other ways) and so this removes a compiler warning.
318 2012-05-05 Murray Cumming <murrayc@murrayc.com>
320 Document.load() Remove the error code parameter.
322 * src/main/java/org/glom/web/server/libglom/Document.java: load():
323 Remove the parameter. We do not set it yet and it could never have
324 worked as an output parameter (though maybe it did in java-libglom).
325 We could use an exception if we really want the failure reason.
326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
328 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
329 setUp(), testGetSuitableTableToViewDetails(): Adapt.
331 2012-05-05 Murray Cumming <murrayc@murrayc.com>
333 Make some inner classes static.
335 * src/main/java/org/glom/web/server/ConfiguredDocument.java
336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
337 * src/main/java/org/glom/web/server/ReportGenerator.java
338 * src/main/java/org/glom/web/server/libglom/Document.java
339 Make all inner classes static that can be static.
341 2012-05-05 Murray Cumming <murrayc@murrayc.com>
343 OnlineGlomServiceImpl: Do not load and check for java-libglom.
345 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
346 init(): We do not use java-libglom any more.
348 2012-05-05 Murray Cumming <murrayc@murrayc.com>
350 Remove mentions of java-libglom.
352 * README: Remove mention of java-libglom, because it no longer needed.
353 * utils/build-onlineglom-war.sh:
354 * utils/check-and-recover-tomcat.py:
355 * utils/install-onlineglom-war.sh: Remove these as they are no longer
356 useful. Building is now far easier, with no need for jhbuild.
358 2012-05-05 Murray Cumming <murrayc@murrayc.com>
360 Fix the build (mvn package)
362 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
363 (LayoutGroup): Make the LayoutItemList inner class static and protected.
364 Otherwise the GWT Java->Javascript compilation fails with just this
365 error, during mvn package or when attempting to view in a browser,
366 in the GWT developer mode in Eclipse.
368 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
369 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
370 [INFO] Compiling module org.glom.web.OnlineGlom
371 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
372 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
373 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
374 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
375 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
376 [INFO] [ERROR] Cannot proceed due to previous errors
378 It has taken me 2 days to find out what was causing that. After reducing
379 the code, the compiler eventually showed me the full error message.
381 2012-05-04 Murray Cumming <murrayc@murrayc.com>
383 ConfiguredDocument: Cache the cloned and stripped layouts.
385 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
386 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
387 layout in a map, so we can retrieve it again without rebuilding it.
389 2012-05-04 Murray Cumming <murrayc@murrayc.com>
391 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
393 2012-05-04 Murray Cumming <murrayc@murrayc.com>
395 libglom classes: Implement some auto-generated emthods.
397 2012-05-04 Murray Cumming <murrayc@murrayc.com>
399 Add GwtTestOnlineGlomService.
401 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
402 However, this (and the other GwtTest*) does not seem to run during
405 2012-05-04 Murray Cumming <murrayc@murrayc.com>
407 Remove use of unsupported features from client code.
409 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
410 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
411 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
412 Use our client version of StringUtils instead of the apache commons one.
414 However, the GWT Javascript compliation still fails.
416 2012-04-25 Murray Cumming <murrayc@murrayc.com>
418 Add a Field class and implement some loading of it in Document.
420 2012-04-25 Murray Cumming <murrayc@murrayc.com>
422 Initial Document loading implementation, instead of libglom.
424 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
425 and Translatable classes, and adapt the rest of the code to use them.
426 However, this is still missing Layout and Field classes and loading.
428 2012-04-24 Murray Cumming <murrayc@murrayc.com>
430 Use of jOOQ: Move Field creation into a utility method.
432 * src/main/java/org/glom/web/server/SqlUtils.java:
433 This lets us improve it more easily.
435 2012-04-24 Murray Cumming <murrayc@murrayc.com>
437 Use of jOOQ: Improve the code to COUNT a sub-select.
439 * src/main/java/org/glom/web/server/SqlUtils.java:
440 Move initial query creation into
441 build_sql_select_step_with_where_clause().
442 build_sql_select_count_rows(): Use the jOOQ API instead of
443 concatentating text, because a jOOQ Select*Step is a TableLike,
444 which is what from() takes.
446 2012-04-23 Murray Cumming <murrayc@murrayc.com>
448 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
450 * pom.xml: Depend on jooq.
451 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
452 methods with jOOQ, based on the C++ implementations in libglom,
453 with some changes to the logic required by jooQ.
454 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
456 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
457 * src/main/java/org/glom/web/server/ReportGenerator.java:
458 * src/main/java/org/glom/web/server/SqlUtils.java:
459 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
460 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
461 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
462 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
463 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
464 Adapt. In particular, the SqlUtils methods now need to take a Connection,
465 because jOOQ needs that, though it seems unnecessary.
467 This is not quite finished. Ideally jOOQ would help us to build
468 table_name.field_name names, quoting and escaping them properly.
469 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
471 2012-04-21 Murray Cumming <murrayc@murrayc.com>
473 Move use of Glom.build_sql*() into a new SqlUtils class.
475 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
476 to wrap Glom.build_sql*(). The parameter types are still Glom one,
477 but this will make it easier to start using something other than
478 libglom or SqlBuilder.
480 2012-04-21 Murray Cumming <murrayc@murrayc.com>
482 Update the project URL.
484 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
486 2012-04-21 Murray Cumming <murrayc@murrayc.com>
488 Main layout: Use a FlowTable instead of absolute positioning.
490 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
491 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
492 child panels/widgets must have an absolute position. But that is annoying, so
493 this adds a FlowTable and puts the child panels in there.
495 2012-04-21 Murray Cumming <murrayc@murrayc.com>
497 GwtTestOnlineGlom: Comment out unused code.
499 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
500 Eclipse has started to say that some code is unused.
502 2012-04-21 Murray Cumming <murrayc@murrayc.com>
504 Update to the latest versions of dependencies.
506 * pom.xml: Update version numbers of dependencies to the latest
508 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
509 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
510 * src/main/java/org/glom/web/server/ReportGenerator.java:
511 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
512 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
513 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
515 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
516 Modify the imports where necessary.
518 2012-04-17 Murray Cumming <murrayc@murrayc.com>
520 Style: Remove overflow:hidden from searchbox
522 * src/main/webapp/style.css: Because this pushes the Back To Link
523 label/link on to the next row, which is then hidden due to the
524 hard-coded (in ems) height.
526 2012-04-20 Murray Cumming <murrayc@murrayc.com>
528 Remove some duplicate code.
530 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
531 getDocumentInfo(): This must have been duplicated during the merge from the
536 2012-04-19 Murray Cumming <murrayc@murrayc.com>
538 Reports: Localize the waiting for report message.
540 * src/main/java/org/glom/web/client/activity/ReportActivity.java
541 start(): Get the message from the contants.
542 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
544 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
545 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
546 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
547 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
548 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
549 Update these files with the English text for newer strings for now.
551 2012-04-19 Murray Cumming <murrayc@murrayc.com>
553 Reports: Show a message while waiting for the report.
555 * src/main/java/org/glom/web/client/ui/ReportView.java
556 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
557 Add setWaitingText(), to show a message saying that we are
558 waiting for the report to be ready.
559 * src/main/java/org/glom/web/client/activity/ReportActivity.java
560 start(): Call setWaitingText() before calling the async
563 2012-04-19 Murray Cumming <murrayc@murrayc.com>
565 ReportGenerator: Specify date and time formats.
567 * src/main/java/org/glom/web/server/ReportGenerator.java:
568 createFieldValueElement(): Use the default (and localized)
569 short formats, though we still need a way to show 4-digit
570 years without providing the format for every locale.
571 * src/main/java/org/glom/web/server/database/DBAccess.java:
572 convertResultSetToDTO(): Use the short formats here too.
574 2012-04-18 Murray Cumming <murrayc@murrayc.com>
576 ReportGenerator: Use the correct numeric formatting.
578 * src/main/java/org/glom/web/server/ReportGenerator.java
579 createFieldExpression(), createFieldValueElement(): Take the
580 whole LayoutItem_Field instead of just the field name, so
581 we have access to the formatting.
582 createFieldValueElement(): Use JRTextField.setPattern() to
583 specify the numeric formatting, with the help of a
584 regular DecimalFormat.
586 2012-04-18 Murray Cumming <murrayc@murrayc.com>
588 ReportGenerator: Avoid showing null for group by titles.
590 * src/main/java/org/glom/web/server/ReportGenerator.java
591 generateReport(): Use setBlankWhenNull() on the field title
592 style too, because this is used for values in group by
595 2012-04-18 Murray Cumming <murrayc@murrayc.com>
597 ReportGenerator: Add a colon to titles in vertical groups.
599 * src/main/java/org/glom/web/server/ReportGenerator.java
600 addFieldToDetailBandVertical(): Pass true for the withColon
603 2012-04-18 Murray Cumming <murrayc@murrayc.com>
605 ReportGenerator: Simplify the code by using Position more.
607 2012-04-18 Murray Cumming <murrayc@murrayc.com>
609 Reports: Support vertical groups, roughly.
611 * src/main/java/org/glom/web/server/ReportGenerator.java:
612 addToReport(): Rename to addGroupToReport() and, if necessary,
613 call the new addVerticalGroupToReport() method.
614 createFieldValueElement(): Let the caller specify the Y position
617 2012-04-17 Murray Cumming <murrayc@murrayc.com>
619 Reports: Allow a second report to be shown.
621 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
622 clear(): Do not remove the HTML widget, which broke the whole layout.
624 2012-04-17 Murray Cumming <murrayc@murrayc.com>
626 Locales drop-down: Show that we use English by default.
628 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
629 fillView(): When we use English, just because that is the default, when
630 no locale is specified, show that in the Locales drop-down instead of
631 just showing the first item.
633 2012-04-17 Murray Cumming <murrayc@murrayc.com>
635 Unselect the Report/Locale/Table combo item when appropriate.
637 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
638 setPlace(): clear reportName if this is not a ReportPlace.
639 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
640 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
641 When the provided name is empty, unselect all items, so that none are
642 indicated. This uses a for loop because I cannot find a single method
645 2012-04-17 Murray Cumming <murrayc@murrayc.com>
647 Report: Give the user a way to get back to the list.
649 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
650 start(), setPlace(): Show the Back To List link on reports, and also
651 interpret selecting the empty report item as back to list.
653 2012-04-13 Murray Cumming <murrayc@murrayc.com>
655 Really show the selected Report name.
657 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
658 setPlace(): Store the reportName here, if it is that kind of Place.
659 fillView(): Set the selected Report after filling the list of reports.
660 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
661 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
662 null Strings, though we need some way to unselect all ListBox items
665 2012-04-13 Murray Cumming <murrayc@murrayc.com>
667 ReportGenerator: Try to avoid some problems.
669 * src/main/java/org/glom/web/server/ReportGenerator.java
670 addField(): Try to avoid duplicates, and avoid using a null
673 2012-04-13 Murray Cumming <murrayc@murrayc.com>
675 Reports: Use quickFind.
677 * src/main/java/org/glom/web/client/OnlineGlomService.java;
678 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
680 getReportHTML(): Add a quickFind parameter.
681 * src/main/java/org/glom/web/client/activity/ReportActivity.java
682 start(): Pass the quickFind parameter.
683 * src/main/java/org/glom/web/server/ReportGenerator.java
684 generateReport(): Take a quickFind parameter.
686 2012-04-13 Murray Cumming <murrayc@murrayc.com>
688 ReportPlace: Actually use the report name.
690 * src/main/java/org/glom/web/client/place/ReportPlace.java
691 getPlace(): Do not assign the report name to the quickfind.
693 2012-04-13 Murray Cumming <murrayc@murrayc.com>
695 Show java.library.path when complaining.
697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
698 init(): When telling us to check java.library.path, show the
701 2012-03-06 Murray Cumming <murrayc@murrayc.com>
703 ReportGenerator: Do not show nulls.
705 2012-03-06 Murray Cumming <murrayc@murrayc.com>
707 ReportGenerator: Make the title font larger.
709 2012-03-06 Murray Cumming <murrayc@murrayc.com>
711 ReportGenerator: Put field titles inside groups, if there are groups.
713 2012-03-06 Murray Cumming <murrayc@murrayc.com>
715 ReportGenerator: Take the Report itself instead of the name and group.
717 * src/main/java/org/glom/web/server/ConfiguredDocument.java
718 Remove getReportLayoutGroup().
719 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
720 getReportHTML(): Pass the report instead
721 of its name and layout group.
722 * src/main/java/org/glom/web/server/ReportGenerator.java
723 generateReport(): Use the report object to use the title
726 2012-03-06 Murray Cumming <murrayc@murrayc.com>
728 ReportGenerator: Remove designBand parameters.
730 * src/main/java/org/glom/web/server/ReportGenerator.java:
731 Make designBand a class member instead of passing it to all
734 2012-03-06 Murray Cumming <murrayc@murrayc.com>
736 ReportGenerator: Add lines, a bit like in the desktop version.
738 * src/main/java/org/glom/web/server/ReportGenerator.java
739 addToReport(): Use JRDesignLine.
741 2012-03-06 Murray Cumming <murrayc@murrayc.com>
743 ReportGenerator: Correct the title positions and use some bold style.
745 * src/main/java/org/glom/web/server/ReportGenerator.java:
746 Break the code up into reusable functions, correct the placement of
747 titles, and use normal/bold styles as in the reports in the desktop
750 2012-03-06 Murray Cumming <murrayc@murrayc.com>
752 ReportGenerator: Add a header band to show the field titles.
754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
755 getReportHTML(): Pass the localeId to the ReportGenerator
757 * src/main/java/org/glom/web/server/ReportGenerator.java
758 constructor: Take the localeID so we can get translated field
760 generateReport(), addToReport(), addFieldToBand(): Add field
761 titles in a column header band.
763 2012-03-05 Murray Cumming <murrayc@murrayc.com>
765 Reports drop-down list: Some improvement.
767 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
768 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
769 Adedd setSelectedReport(),
770 setReportList(): Add a blank line so that the user can select the
772 * src/main/java/org/glom/web/client/activity/ReportActivity.java
773 start(): Show the current report by calling setSelectedReport().
774 This does not seem to work yet.
776 2012-03-05 Murray Cumming <murrayc@murrayc.com>
778 DetailsActivity, ListActivity: Move some variables into a base class.
780 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
781 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
782 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
783 the clientFactory, documentID, tableName and authenticationPopup into
784 a base class, to avoid duplication.
786 2012-03-05 Murray Cumming <murrayc@murrayc.com>
788 Translate the Reports label.
790 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
791 Get the "Reports" label string from the constants.
792 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
793 perties: Add Reports to the constants.
795 2012-03-05 Murray Cumming <murrayc@murrayc.com>
797 Reports: Implement grouping.
799 * src/main/java/org/glom/web/server/ReportGenerator.java:
800 Handle LayoutItem_GroupBy items and try to do the right thing
801 with JRDesignGroup. It seems to work.
803 2012-03-04 Murray Cumming <murrayc@murrayc.com>
805 Actually show some data with JasperReports.
807 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
808 getReportHTML(): Move most code into a ReportGenerator class.
809 * src/main/java/org/glom/web/server/ReportGenerator.java:
810 Recurse into sub-groups, adding fields to the JasperDesign's details
811 band. Note that we must set an arbitrary width and height, or it just
812 will not show any data.
814 2012-03-04 Murray Cumming <murrayc@murrayc.com>
816 Reports Chooser: Show the titles, not the names.
818 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
819 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
820 and the names as the values.
821 * src/main/java/org/glom/web/server/ConfiguredDocument.java
822 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
823 group now that we provide the report name, so it should always
826 2012-02-15 Murray Cumming <murrayc@murrayc.com>
828 Depend on jasperreports.
830 * pom.xml: Add the dependency. My plan is to use this on the
833 2012-01-31 Murray Cumming <murrayc@murrayc.com>
835 Implement navigation to report places.
837 * src/main/java/org/glom/web/client/activity/ReportActivity.java
838 start(): Do not bother to handle all events here.
839 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
840 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
841 Added getSelectedReport().
842 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
843 .java: start(): When handling a change to the reports chooser,
844 call getSelectedReport() and goTo() its ReportPlace.
845 * src/main/java/org/glom/web/client/ui/ReportView.java
846 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
847 Added setReportHTML() which puts the html in a gwt HTML widget.
848 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
849 getReportHTML(): Return "TODO" just to show that this works.
851 2012-01-31 Murray Cumming <murrayc@murrayc.com>
853 Make ReportPlace usable.
855 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
857 * src/main/java/org/glom/web/client/place/ReportPlace.java:
858 Correct the @prefix annotation.
860 2012-01-31 Murray Cumming <murrayc@murrayc.com>
862 OnlineGlomService: Return report HTML rather than the LayoutGroup.
864 * src/main/java/org/glom/web/client/OnlineGlomService.java:
865 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
867 Change getReportLayout() to getReportHMTL() because we will not need to
868 parse or render the report layout on the client side.
869 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
870 getReportLayout(): Return the libglom LayoutGroup type because we will
871 not need to convert to a shared type, because this will not be used on
873 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
876 Note that there is still no implementation for this.
879 2012-01-27 Murray Cumming <murrayc@murrayc.com>
881 Add a (empty) Report Place, View, and Activity.
883 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
885 * src/main/java/org/glom/web/client/place/HasTablePlace.java
886 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
887 this into a superclass:
888 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
889 and also use it as the base of this new ReportPlace:
890 * src/main/java/org/glom/web/client/place/ReportPlace.java
892 * src/main/java/org/glom/web/client/ui/ReportView.java
893 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
894 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
895 Add these, containing mostly boiler-plate for now.
897 * src/main/java/org/glom/web/client/OnlineGlomService.java
898 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
899 * src/main/java/org/glom/web/server/ConfiguredDocument.java
900 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
901 Add API to get the LayoutGroup for the report.
903 2012-01-23 Murray Cumming <murrayc@murrayc.com>
905 Add and fill a Reports drop-down list box.
907 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
909 * src/main/java/org/glom/web/client/OnlineGlomService.java:
910 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
911 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
912 Added getReports(document, table, localeID), calling
913 ConfiguredDocument.getReports().
914 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
915 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
916 Added setReportsList() and a list widget.
917 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
918 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
923 2012-04-12 Murray Cumming <murrayc@murrayc.com>
925 Translations: Add Esperanto.
927 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
928 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
929 properties: Add this translation because someone took the time to make it.
931 2012-03-15 Murray Cumming <murrayc@murrayc.com>
933 Adapt to the java-libglom 1.21.7 API.
935 * src/main/java/org/glom/web/server/ReportGenerator.java:
936 addToReport(): get_group_secondary_fields() is now
937 get_secondary_fields().
940 2012-03-15 Murray Cumming <murrayc@murrayc.com>
942 Use the latest java-libglom version.
944 * pom.xml: Use java-libglom 1.21.7.
946 2012-03-03 Ben Konrath <ben@bagu.org>
948 Display date and time in details view.
950 https://bugzilla.gnome.org/show_bug.cgi?id=671257
952 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
954 2012-03-05 Murray Cumming <murrayc@murrayc.com>
956 Require the latest java-libglom.
958 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
960 2012-03-04 Murray Cumming <murrayc@murrayc.com>
962 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
964 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
965 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
966 an empty quickfind string. I also corrected libglom to create only
967 empty where clauses for empty quickfind strings, but this avoids the
970 2012-02-24 Ben Konrath <ben@bagu.org>
972 Improve the tabs in the Notebook widget.
976 2012-01-30 Murray Cumming <murrayc@murrayc.com>
978 Translations: Try to translate the strings.
980 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
981 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
982 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
983 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
984 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
985 Take the Open translation from GTK+'s .po files.
986 Take the Details translation from Glom's po files.
987 I have added the other strings to Glom so we can get translations that way:
988 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
990 2012-01-27 Murray Cumming <murrayc@murrayc.com>
992 TableSelectionViewImpl: Put the search label and entry in a div.
994 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
995 Put the search widgets in a FlowTable so that the CSS can be used to
996 style them while keeping them together.
997 * src/main/webapp/style.css: Mention the new div.
999 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1001 Translate more strings in more locales.
1003 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1004 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1005 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1006 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1007 Translate the "Details" and "Open" string too.
1009 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1010 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1011 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1012 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1013 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1014 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1015 Add these new locales as placeholders though they currently contain English.
1017 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1019 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1021 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1022 Check the ConfiguredDocument* for null before using it.
1024 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1026 Tell Eclipse about the generated java files.
1028 * .classpath: This lets it find OnlineGlomConstants.java.
1029 It would be nice if Eclipse just used the maven build files.
1031 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1033 Prevent a crash when no locale is specified in the URL.
1035 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1036 Avoid returning a null string, obtained from
1037 Window.Location.getParameter(). This caused a crash when it was
1038 later passed to libglom's API.
1039 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1040 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1041 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1042 guard against future null strings.
1044 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1046 Use the ?locale= query param instead of the &lang= token param.
1048 * src/main/java/org/glom/web/client/place/ListPlace.java
1049 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1050 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1051 Remove the lang token key and value.
1053 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1054 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1055 When the user selects a different locale from the chooser, use
1056 Window.Location.assign() to change the URL, which then causes a reload.
1058 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1059 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1060 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1061 * src/main/java/org/glom/web/client/activity/ListActivity.java
1062 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1063 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1064 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1065 * src/main/java/org/glom/web/client/ui/ListView.java:
1066 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1068 Remove localeID member variables and method/constructor parameters, instead
1069 using Utils.getCurrentLocaleID() when we need a localID to pass to
1072 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1074 Internationalize the UI strings.
1076 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1077 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1078 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1079 because it is unused. Messages are apparently strings that can have
1080 parameters, but we do not need that yet, so Contants will be enough for now.
1081 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1082 to say that we support the en and de locales.
1083 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1084 The original English strings.
1085 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1086 Some German translations of the English strings.
1087 The i18n goal then uses the .properties file to generate an
1088 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1089 returns an implementation that returns the translated strings.
1090 The documentation suggests putting these in src/java/*/client/, but it seems
1091 best to put it in src/resources/*/client/.
1092 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1093 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1094 instead of hard-coding them.
1095 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1096 but that does not seem to stop the build, though it confuses Eclipse.
1098 You can see the translated string by adding ?locale=de to the URL, like so:
1099 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1101 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1103 Improve null/empty String checks.
1105 * pom.xml: Add a dependency on commons-lang, to use
1106 org.apache.commons.lang.StringUtils.
1107 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1109 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1110 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1111 Use StringUtils.isEmpty().
1113 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1114 StringUtils class with a static isEmpty() function because we
1115 cannot use org.apache.commons.lang.StringUtils in client-side
1116 GWT code because it (apparently) cannot be compiled to javascript.
1117 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1118 * src/main/java/org/glom/web/client/activity/ListActivity.java
1119 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1120 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1121 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1122 * src/main/java/org/glom/web/client/place/ListPlace.java
1123 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1124 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1125 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1126 * src/main/java/org/glom/web/client/ui/details/Group.java
1127 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1128 our StringUtils.isEmpty() function.
1130 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1132 Update to the latest java-libglom API.
1134 * pom.xml: Require java-libglom 1.21.4.
1135 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1136 getDocumentInfo(), getListViewLayoutGroup():
1137 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1139 * src/main/java/org/glom/web/server/database/DBAccess.java
1140 getFieldsToShowForSQLQueryAddGroup(),
1141 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1142 with either get_database_title_original() or
1143 get_database_title(localeID).
1145 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1147 ConfiguredDocument: Avoid a null pointer exception.
1149 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1150 Initialize localeID to "" to avoid returning a null String which
1151 causes a crash in java-libglom's swing-generated code.
1153 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1155 Some simple renaming.
1157 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1158 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1159 for localeChooser. This seems more appropriate and is less ambiguous
1160 particularly in the .css file.
1162 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1164 ConfiguredDocument: Rename the localedID private member variable.
1166 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1168 Adapt to the latest java-libglom API from git master.
1170 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1171 libglom now uses only Vector instead of List, which uses add() instead of
1174 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1176 ConfiguredDocument: Rename the localedID private member variable.
1178 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1180 Build a source tarball with mvn assembly:single
1182 * assembly.xml: Add this file.
1183 * pom.xml: Use the maven-assembly-plugin and tell it to use
1184 our assembly.xml file.
1186 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1188 OnlineGlomServiceImpl: Get .glom files recursively.
1190 * pom.xml: Depend on commons-io from org.apache.commons.
1191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1192 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1193 files recursively, and with the easier filter for the extension.
1194 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1195 simplify that code too.
1197 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1199 README: Mention that you must install java-libglom packages separately.
1201 But then it works, because java-libglom is now in the central maven
1204 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1206 locales drop-down: Show the correct selected locale when the URL changes.
1208 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1209 .java: setPlace(): Move some code into fillView().
1211 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1213 locales drop-down: Do not lose the primary key.
1215 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1216 start(): onLocaleChange(): Pass the current primary key value,
1217 instead of an empty value.
1219 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1221 locales drop-down: Do not lose the drop-down selection.
1223 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1224 .java (TableSelectionActivity.fillView): Set the selected locale
1225 after changing the drop-down items (though we do not really need
1226 to change them just because the locale changes.)
1228 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1230 locales drop-down: Change the tables list when this changes.
1232 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1233 .java: TableSelectionActivity.start(): Move the async table titles
1234 retrieval into a private fillView() method and also call this when
1235 the chosen locale changes.
1236 Note that the document title is not actually translatable yet, but
1237 that is a problem that I should fix soon in libglom.
1239 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1241 Improve the placement of the locales drop-down.
1243 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1244 Put the title and locales drop-down in a div (gwt.FlowTable).
1245 * src/main/webapp/style.css: Add magic css properties to make this work.
1246 Also remove the left margin from the title so that it lines up with the
1249 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1251 locales selector: Show human-readable locale titles.
1253 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1254 getDocumentInfo(): Use java.util.Locale to show a real title of
1255 each locale, in the locale's own language.
1257 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1259 Add a language/locale selector drop-down.
1261 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1262 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1263 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1264 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1265 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1266 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1267 Add a ListBox to show the available locales. Add getLocaleSelector(),
1268 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1269 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1270 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1271 java: Add these classes.
1272 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1273 start(): Fill the locales ListBox. Handle its change event, firing a
1275 setPlace(): Show the selected locale as specified by the URL token.
1276 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1277 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1278 Handle LocaleChangeEvent, going to a new *Place with that locale.
1280 The placement of the ListBox is not pretty, and it currently uses the ID
1281 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1285 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1287 Search box: Show the search text from the URL token.
1289 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1290 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1291 Add setQuickFindText().
1292 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1293 .java: setPlace(): Store the queryText if the place is a ListPlace,
1294 and call TableSelectionView.setQuickFindText().
1296 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1298 Allow use of translations via, for instance, &lang=de in the URL.
1300 * pom.xml: Use the unstable java-libglom 1.21 version.
1302 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1303 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1305 init(): Instead of calling TranslatableItem.set_current_locale()
1306 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1307 However, this is only for default locales, which are not needed to
1308 change the locale in the URL.
1309 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1310 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1311 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1312 layout for a particular locale.
1313 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1314 Add get/setDefaultLocaleID().
1315 getDocumentInfo(), getListViewData(), getRelatedListData(),
1316 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1317 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1318 localeID parameter, so we can get the layout for a particular locale.
1320 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1321 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1322 * src/main/java/org/glom/web/client/place/ListPlace.java:
1323 Parse and construct a lang parameter too.
1325 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1326 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1327 passed to subsequent methods and constructors.
1328 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1329 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1330 Store the localeID from the *Place and pass it to other constructors
1331 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1333 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1334 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1335 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1336 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1337 * src/main/java/org/glom/web/client/ui/ListView.java:
1338 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1339 Take localeID parameters and pass them to subsequent constructors and
1340 methods, so that the layout is always retrieved for that locale.
1342 This is rather repetitive.
1344 Note that "" means the original (default) locale of the Glom document,
1345 which is usually English.
1347 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1349 Documents: Remove final keyword to fix startup configuration.
1351 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1352 final keywords on the private member variables because that breaks
1353 the startup, apparently (there are warnings) because it stops them
1354 from being serialized. I added these in the previous commit.
1356 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1358 Documents: Add some final keywords.
1360 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1363 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1365 OnlineGlomServiceImpl: Add to overview comments.
1367 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1368 Note that this is where all the document are loaded. They are not
1369 loaded freshly for each page.
1371 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1375 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1376 Add a TextBox for the text of a quick find.
1377 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1379 setBackLink(): Add a String quickFind parameter.
1380 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1381 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1382 to the base interface, because that is how TableSelectionViewImpl is used.
1383 * src/main/webapp/style.css: Add style for the search box and its label.
1385 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1386 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1387 Add these files, based on the existing TableChangeEvent and
1388 TableChangeEventHandlers.
1389 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1390 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1391 a ListPlace() that the user should be taken to.
1392 * src/main/java/org/glom/web/client/activity/ListActivity.java
1393 start(): Handle it here too and adapt the TableChangeEvent handler to
1394 pass the extra "" quickFind parameter to ListPlace.
1395 * src/main/java/org/glom/web/client/place/ListPlace.java:
1396 Constructor: Take an extra String quickFind parameter and store it,
1397 returning it from a new getQuickFind() method.
1398 getToken(): Put the quickFind text in the URL token.
1399 getPlace(): Parse the quickFind text from the URL token.
1400 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1401 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1402 ListPlace constructor.
1403 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1404 .java: start(): Add a Change handler for the TableSelectionView's
1405 TextBox (via its base HasChangeHandlers interface), firing the new
1406 QuickFindChangeEvent.
1407 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1408 pass the extra "" quickFind parameter.
1410 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1411 setCellTable(): Add a String quickFind parameter and pass it to
1412 the ListViewTable() constructor.
1413 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1414 setCellTable() in the base interface, because that is how ListViewImpl
1417 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1418 Add a String quickFind member variable.
1419 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1420 Constructor: Add a String quickFind parameter, storing it in the
1421 base ListTable's member variable.
1422 onRangeChanged(): Pass quickFind to the
1423 OnlineGlomServiceAsync.getSortedListViewData() and
1424 OnlineGlomServiceAsync.getListViewData() methods.
1426 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1427 getListViewData(), getSortedListViewData(): Add a String quickFind
1428 parameter, passing it to ConfiguredDocument.getListViewData().
1429 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1430 Change getListViewData(), getSortedListViewData() in the base interface,
1431 because that is how OnlineGlomServiceImpl is used, via this:
1432 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1433 Change getListViewData(), getSortedListViewData() here too.
1434 This class can apparently be used to asynchronously call methods on
1435 OnlineGlomService, and GWT seems to implement that after recognizing
1436 just the *Async name convention and the extra AsyncCallback parameters.
1438 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1439 getListViewData(): Add a String quickFind parameter, and pass it to
1440 ListViewDBAccess.getData().
1441 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1442 getListData(): Add a String quickFind parameter and pass it to
1444 getSelectQuery(): Add a String quickFind parameter.
1445 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1446 getSelectQuery(): Add a String quickFind parameter and use it with
1447 Glom.get_find_where_clause_quick() to pass a where_clause to
1448 Glom.build_sql_select_with_where_clause(), to actually filter the
1450 getData(): Add a String quickFind parameter, passing it to getListData().
1451 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1452 va: getData(): Pass an empty string to getListData() for the
1453 quickFind parameter.
1455 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1457 ListTable: Minor change.
1459 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1460 createCellTable(): Make this protected instead of public.
1462 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1464 Many files: Use final for the parameters and use the @override attribute.
1466 2012-01-22 Ben Konrath <ben@bagu.org>
1468 Add anchor links for single line text that starts with http, ftp and www.
1472 2012-01-22 Ben Konrath <ben@bagu.org>
1474 Add ellipsis to single line text in details view.
1478 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1480 Remove all javadoc author tags.
1482 Because they are awkward and meaningless when many people touch
1484 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1486 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1488 Revert the COPYING.LESSER to COPYING rename.
1490 Apparently both should be there if it is LGPL.
1492 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1494 *View: Remove unused imports.
1496 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1497 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1498 * src/main/java/org/glom/web/client/ui/ListView.java:
1499 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1500 Remove unused imports, as suggested by Eclipse.
1502 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1504 Move the *View::Presenter types, and some API into one base View.
1506 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1507 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1508 * src/main/java/org/glom/web/client/ui/ListView.java:
1509 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1510 Presenter, setPresenter() and clear() into a shared base interface,
1511 to avoid the unnecessary duplicate Presenter types and to more clearly
1512 show how the *Views share the same structure, even if they are not
1513 used polymorphically.
1515 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1516 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1518 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1519 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1520 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1522 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1525 Feel free to revert this if there is a good reason for the duplicate
1528 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1530 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1532 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1533 a class member instead of a local variable in the method.
1534 This lets us use it to get the view instances, for use in tests.
1535 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1536 beforeOnlineGlom(): Test some more details of the initial view.
1537 Again, this is not very useful.
1539 To really test gwt-glom we will need to start a local postgresql
1540 instance with local data, like the Glom tests in C++.
1542 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1544 pom.xml: Mention the LGPL license.
1546 * pom.xml: Add a licenses section.
1547 * COPYING.LESSER: Move this to COPYING, which
1548 previously contained the GPL. But gwt-glom is all LGPL.
1550 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1552 Add project information to README and pom.xml.
1554 * README: Add a brief description and mention some mvn
1556 * pom.xml: This extra information shows up in mvn site
1559 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1561 Use the latest java-libglom version.
1563 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1565 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1567 GwtTestOnlineGlom: Test a little more.
1569 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1570 protected rather than private, as suggested by the gwt-test-utils
1572 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1573 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1574 Test the initial visibility of the panels.
1576 However, this is not a very useful test.
1577 And I wonder how we should generally test using this idea for an
1578 activity/places app like ours where the real changes happen implicitly
1579 based on the history token/URL.
1581 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1583 Slight modification to *Mapper comments.
1585 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1586 (DataActivityMapper)
1587 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1589 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1591 Remove comments mentioning GIN because they are just copied from
1592 the example code and are apparently not helpful:
1593 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1594 Also change the mention of a class that is only in the example code.
1596 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1598 GwtTestOnlineGlom test: Minor changes.
1600 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1601 Avoid the long qualified class name and modify the comment
1602 because it is now obvious to me that the mocked class is the only
1603 custom one created via GWT.create().
1605 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1607 Tests: Added the beginnings of a test using gwt-test-utils.
1609 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1610 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1611 which tells gwt-test-utils what class will be tested.
1612 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1613 Add a simple (but empty) test case. One class, used by the OnlineGlom
1614 class, is mocked so that it can be created. However, I am not sure
1615 why only this class needs to be mocked.
1617 Note that mockito seems more popular, and clearer, than easymock,
1618 but I have not got that working yet. It might be a matter of the
1621 This test is run during mvn integration-test.
1623 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1625 Tests: Use junit4-style syntax instead of junit3-style.
1627 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1628 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1629 * src/test/java/org/glom/web/shared/DataItemTest.java:
1630 Use the @Test annotation rather than relying on the test*() prefix.
1631 Also no longer implement TestCase, to avoid triggering support for
1632 the junit3-way, which stops the annotations from working.
1633 Change the imports from import junit.framework.* to
1634 import org.junit.*, which is apparently the new way.
1636 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1638 Added a test for ListPlace token parsing and creation.
1640 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1641 This is much the same as DetailsPlaceTest.
1643 I wonder how we could test the other parts of the *Place API.
1645 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1647 DetailsPlace test: Also test getToken() and recreation via getPlace().
1649 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1650 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1651 recreate it, testing the recreated DetailsPlace for the same parameter
1654 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1656 Use the surefire-report plugin.
1658 * pom.xml: This generates a HTML report about the tests in
1659 target/site/surefire-report.html
1660 when you do mvn surefire-report:report. It seems to be popular/normal.
1662 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1664 Added a test for DetailsPlace.
1666 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1667 Test the getPlace() token parsing.
1669 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1671 Added a first unit test.
1673 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1674 * src/test/java/org/glom/web/shared/DataItemTest.java:
1675 This is a silly test but it is just to get things started. Note that
1676 maven/junit finds the test because it looks in src/test by default.
1678 2011-12-22 Ben Konrath <ben@bagu.org>
1680 Change charsetName to "UTF-8" when replacing line breaks.
1682 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1683 that work in Java (such as "UTF8") will not work when compiled to
1686 This fixes a problem with multi-line details view fields that have hard
1687 line breaks. The "License Text" field on this page demonstrates the
1690 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1692 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1694 2011-12-22 Ben Konrath <ben@bagu.org>
1696 Fix another bug with related list navigation.
1698 I've tested all the navigation buttons in all of the related lists
1699 so things should be good now.
1701 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1703 2011-12-22 Ben Konrath <ben@bagu.org>
1705 Fix a crasher when refreshing the list view with the default table.
1707 This crash will also happen when loading the list view with the default
1708 table from a link or bookmark.
1710 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1711 to the main document selection page when the document id hasn't been
1713 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1714 the main document selection page when the document id hasn't been
1716 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1717 values for the details place when the document id hasn't been set.
1718 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1719 values for the list place when the document id hasn't been set.
1721 2011-12-21 Ben Konrath <ben@bagu.org>
1723 Protect against NPE when glom.document.locale is not in config.
1725 This patch protects against an NPE when glom.document.locale is not in
1726 the config file. This NPE will also happen if glom.document.locale is
1729 The patch also updates the error message to display the class name when
1730 the getMessage() returns null. This was happening when the NPE was
1731 thrown and I had "Configuration Error: null". If an NPE is encountered
1732 with this patch, "Configuration Error: NullPointerException " will be
1735 This commit closes this bug:
1737 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1739 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1741 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1743 Rename onlineglom.properties to onlineglom.properties.sample.
1745 * src/main/resources/onlineglom.properties: Rename to:
1746 * src/main/resources/onlineglom.properties.sample:
1747 * src/main/resources/README: And add this file explaining that people
1748 should rename it back when deploying.
1750 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1752 Allow choosing the translation in the .properties file.
1754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1755 init(): Read a glom.document.locale value from the configuration file
1756 and call Glom's TransatableItem::set_current_locale() method.
1757 * src/main/resources/onlineglom.properties: Add a commented-out
1758 example of this new setting.
1760 It would be better to add &lang=de_DE to the URL, but the current
1761 libglom API does not allow us to do this easily. I am working on that.
1763 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1765 Avoid a crash in parsing of token parameters.
1767 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1768 ava: getTokenParams(): Do not crash if a parameter has a key but no
1769 value, and ignore parameters with neither.
1771 2011-12-17 Murray Cumming <murrayc@murayc.com>
1773 History token building/handling: Improve use of token parameters.
1775 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1776 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1777 and buildParamsToken(HashMap), for use by derived classes.
1778 Make the separator private because it is no longer be needed.
1779 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1780 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1781 instead of manual string concatenation.
1782 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1783 of hardcoded indices and awkward splitting code.
1784 * src/main/java/org/glom/web/client/place/ListPlace.java
1785 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1786 instead of manual string concatenation.
1787 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1788 of hardcoded indices and awkward splitting code.
1789 This should fix bug #666420
1791 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1793 Fix a Navgiation->Navigation typo in the code.
1795 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1796 Rename processNavgiation() to processNavigation().
1798 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1800 Fix a seperator->separator typo in the code.
1802 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1803 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1804 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1807 2011-12-15 Ben Konrath <ben@bagu.org>
1809 Cleanup some comments.
1811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1813 2011-12-14 Ben Konrath <ben@bagu.org>
1815 Replace \n with <br/> for multiline text in the details view.
1817 Vertical scrollbars are added when needed as well.
1819 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1821 2011-12-14 Ben Konrath <ben@bagu.org>
1823 Specify the font for document selection links.
1825 * src/main/webapp/style.css:
1827 2011-12-14 Ben Konrath <ben@bagu.org>
1829 Fix bouncy CellTable while paging.
1831 This doesn't currently work with related list tables in unselected
1834 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1836 2011-12-14 Ben Konrath <ben@bagu.org>
1838 Revamp the appearance of the document selection page.
1840 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1841 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1842 * src/main/webapp/style.css:
1844 2011-12-13 Ben Konrath <ben@bagu.org>
1846 Set navigation button column to the smallest size possible.
1848 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1850 2011-12-13 Ben Konrath <ben@bagu.org>
1852 Change OpenButton nomenclature to NavigationButton.
1854 Using NavigtionButton makes things more generic. Classes, methods and
1855 variables have been changed.
1857 This is a rename-only refactor.
1859 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1860 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1861 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1862 Renamed from OpenButtonCell.
1863 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1864 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1865 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1867 2011-12-12 Ben Konrath <ben@bagu.org>
1869 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1871 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1872 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1873 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1874 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1876 2011-12-12 Ben Konrath <ben@bagu.org>
1878 Update variable names and comments.
1880 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1881 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1883 2011-12-12 Ben Konrath <ben@bagu.org>
1885 Properly initialize numNonEmptyRows variable to zero.
1887 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1888 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1890 2011-12-05 Ben Konrath <ben@bagu.org>
1892 Add latest mockup with HTML tables.
1894 Features of this mockup:
1896 -> HTML table for flowtable
1897 -> HTML table for flowtable column
1898 -> Example of how related lists would look
1899 -> Not using text entries for data items
1901 The current version of Online Glom doesn't use HTML tables for the
1904 This mockup has been sent to the glom-devel mailing list but it's good
1905 to have it here as well.
1907 * mockups/details-view-html-tables.html:
1909 2011-12-05 Ben Konrath <ben@bagu.org>
1911 Remove unnecessary getPrimaryKeyField() method.
1913 getPrimaryKeyFieldForTable(String) has been renamed to
1914 getPrimaryKeyField(String).
1916 * src/main/java/org/glom/web/server/database/DBAccess.java:
1917 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1918 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1920 2011-12-05 Ben Konrath <ben@bagu.org>
1922 Add string representation of TypedDataItem value to conversion error message.
1924 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1925 message was extracted into its own method to avoid duplication.
1927 2011-12-05 Ben Konrath <ben@bagu.org>
1929 Add type checking to navigation primary key value creation.
1931 Create navigation primary key only if the expected type from the Glom
1932 document matches the type returned by the SQL query.
1934 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1936 2011-12-05 Ben Konrath <ben@bagu.org>
1938 Rename a couple of variables in RelatedListNavigation.
1940 This is a rename-only refactor.
1942 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1944 2011-12-05 Ben Konrath <ben@bagu.org>
1946 Move getListLayoutGroup() into getListViewLayoutGroup().
1948 This removes getListLayoutGroup(). It was only being called by
1949 getListViewLayoutGroup().
1951 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1953 2011-12-05 Ben Konrath <ben@bagu.org>
1955 Remove check for LayoutItem_Portal in list table method.
1957 This check is no longer necessary because the method isn't being used
1958 to create the LayoutItemPortal DTO.
1960 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1962 2011-12-05 Ben Konrath <ben@bagu.org>
1964 Properly support related list navigation.
1966 Navigation from the "Repository Analyzer -> Package Scans ->
1967 Dependencies" related table wasn't working because the primary key for
1968 related tables wasn't being set properly. This commit fixes the
1971 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1972 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1973 doesn't set the primary key properly for related list tables.
1974 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1975 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1976 useful for getting the primary key for list view tables and for related
1978 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1979 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1980 Move code to set the primary key for the table from the abstract
1981 ListDBAccess class to ListViewDBAccess as it's only correct for list
1983 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1984 Properly add primary key to related list tables.
1986 2011-12-02 Ben Konrath <ben@bagu.org>
1988 Properly set the horizontal alignment of fields.
1990 This fix is for both the list tables and the details view.
1992 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1993 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1994 to set the horizontal alignment of fields.
1996 2011-12-02 Ben Konrath <ben@bagu.org>
1998 Display currency codes in the details view.
2000 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2002 2011-12-02 Ben Konrath <ben@bagu.org>
2004 Avoid duplicate JNI call.
2006 JNI is not as efficient as pure Java and this is an easy (and small)
2009 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2010 Use previously retrieved value for whereClauseToTableName instead of
2013 2011-12-02 Ben Konrath <ben@bagu.org>
2015 Rename a couple of variables in RelatedListNavigation.
2017 This is a rename-only refactor.
2019 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2021 2011-12-02 Ben Konrath <ben@bagu.org>
2023 Indicate clearly that a mismatched primary key type is a bug.
2025 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2026 warning to error. Add 'This is a bug.' to message.
2028 2011-12-02 Ben Konrath <ben@bagu.org>
2030 Update / fix some comments.
2032 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2034 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2036 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2037 Fix comments. Add some TODOs.
2039 2011-12-02 Ben Konrath <ben@bagu.org>
2041 Enable navigation to details view with string primary key from related list.
2043 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2044 Create a text primary key value when return type of result is
2045 java.sql.Types.VARCHAR.
2047 2011-12-02 Ben Konrath <ben@bagu.org>
2049 Use checkboxes for booleans in the details view.
2051 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2053 2011-12-01 Ben Konrath <ben@bagu.org>
2055 Improve performance of related list height calculation.
2057 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2058 Put code to calculate the expected height in a static initializer so
2059 that that it's only called once.
2061 2011-12-01 Ben Konrath <ben@bagu.org>
2063 Show related list tables in notebooks (again).
2065 Calculate the height of the related list tables so the Notebook can be
2066 set the correct height. The height of the related list table is also needed by
2067 FlowTable to be able decide how to create the layout.
2069 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2070 and set the Portal height based on the height of the related list
2071 table and the Portal container.
2072 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2073 Add method to calculate the height of the related list tables.
2074 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2075 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2076 calculate the height of the Pager widget.
2078 2011-12-01 Ben Konrath <ben@bagu.org>
2080 Use CellTable API for table property instead of setting style on Element.
2082 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2084 2011-12-01 Ben Konrath <ben@bagu.org>
2086 Make ListViewTable and RelatedListTable a consistent height.
2088 The tables are now a consistent height regardless of the contents of
2089 the table. A hidden button is added to empty rows to ensure that the
2090 height of these rows will match the height of rows with data.
2092 A navigation button column is now added to every table. The width of
2093 the navigation column is set to 0px when a RelatedListTable shouldn't
2094 have navigation buttons. This maintains the a consistent row height in
2095 tables that don't show the navigation buttons.
2097 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2098 navigation column when not needed.
2099 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2100 arguments for navigation button to constructor of ListViewTable.
2101 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2102 hidden button for empty data rows.
2103 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2104 arguments for navigation button to constructor.
2105 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2106 create navigation buttons. Add hideNavigationButtons() method.
2107 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2108 arguments for navigation button to constructor.
2110 2011-12-01 Ben Konrath <ben@bagu.org>
2112 Use 'visibility: hidden' in Utils.getWidgetHeight().
2114 This is better choice because hidden elements are invisible, don't
2115 respond to events and are not part of the tab order. They will,
2116 however, take up space which is required to be able to calculate the
2117 height of the widget.
2119 * src/main/java/org/glom/web/client/Utils.java:
2121 2011-12-01 Ben Konrath <ben@bagu.org>
2123 Use Utils.getWidgetHeight() in FlowTable.
2125 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2127 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2129 2011-12-01 Ben Konrath <ben@bagu.org>
2131 Put the details css class name on the correct table column.
2133 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2135 2011-11-30 Ben Konrath <ben@bagu.org>
2137 Update for java-libglom API change.
2139 The getters and setters on FieldFormatting and NumericFormat were
2140 changed to remove the 'M'.
2142 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2144 2011-11-29 Ben Konrath <ben@bagu.org>
2146 Only allow RelatedListTables in Portals.
2148 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2150 2011-11-29 Ben Konrath <ben@bagu.org>
2152 Only create a contents panel for Portals when title is being set.
2154 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2156 2011-11-29 Ben Konrath <ben@bagu.org>
2158 Set TabLayoutPanel height based on calculated height its widgets.
2160 This is a potential fix for this bug:
2162 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2164 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2166 2011-11-29 Ben Konrath <ben@bagu.org>
2168 Align details field labels and data with the Open buttons.
2170 * src/main/webapp/style.css:
2172 2011-11-29 Ben Konrath <ben@bagu.org>
2174 Remove unnecessary <div> in the Notebook widget.
2176 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2177 method to get container FlowPanel (<div>).
2178 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2179 initWidget() method directly on the TabLayoutPanel widget instead of
2180 Group's container widget.
2182 2011-11-29 Ben Konrath <ben@bagu.org>
2184 Don't add group titles for Portals in Notebooks.
2186 This reverts the previous patch and fixes a bug I introduced with
2187 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2189 * src/main/java/org/glom/web/client/ui/details/Group.java:
2190 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2192 2011-11-28 Ben Konrath <ben@bagu.org>
2194 Remove unused boolean argument in Portal constructor.
2196 Just a code cleanup.
2198 * src/main/java/org/glom/web/client/ui/details/Group.java:
2199 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2201 2011-11-28 Ben Konrath <ben@bagu.org>
2203 Remove hack for glom 1.18 style glom files.
2205 * src/main/java/org/glom/web/client/ui/details/Group.java:
2206 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2207 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2209 2011-11-28 Ben Konrath <ben@bagu.org>
2211 Use Gda Value version of primary key to log result too large error.
2213 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2215 2011-11-28 Ben Konrath <ben@bagu.org>
2217 Don't use TypedDataItem.getText() for Unknown types from the URL.
2219 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2220 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2221 instead of getText().
2222 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2223 String field and getUnknown() method.
2225 2011-11-28 Ben Konrath <ben@bagu.org>
2227 Log an error message when the java-libglom .so is not present.
2229 The error message was being set in the exception but not logged.
2231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2233 2011-11-28 Ben Konrath <ben@bagu.org>
2235 Ignore LayoutItem_CalendarPortals.
2237 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2238 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2240 2011-11-28 Ben Konrath <ben@bagu.org>
2242 Extract method for creating the LayoutItemPortal DTO.
2244 Just breaking the code up into smaller chunks.
2246 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2248 2011-11-28 Ben Konrath <ben@bagu.org>
2252 This should have been added with the refactor. Oops!
2254 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2256 2011-11-28 Ben Konrath <ben@bagu.org>
2258 Create primary key value from URL string using type from Glom document.
2260 See this bug, comments 19 - 25:
2262 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2264 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2265 create a TypeDataItem for the primary key here when loading from a
2266 URL. Show the same string for the primary key value as was received
2267 from the URL string (when loading from a URL).
2268 * src/main/java/org/glom/web/server/Utils.java: Update method for
2269 creating the Gda Value from the TypeDataItem to properly deal with
2270 creating a Gda Value based on the Glom document type for the primary
2271 key value string when loading from a URL.
2272 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2273 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2274 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2275 Update for changed method name.
2277 2011-11-27 Ben Konrath <ben@bagu.org>
2279 Rename PrimaryKeyItem to TypedDataItem.
2281 The name PrimaryKeyItem suggests what the class should be used for.
2282 TypedDataItem is a neutral name that describes the class better.
2284 This is a rename-only refactor.
2286 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2287 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2288 * src/main/java/org/glom/web/client/Utils.java:
2289 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2290 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2291 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2292 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2293 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2294 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2296 * src/main/java/org/glom/web/server/Utils.java:
2297 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2298 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2299 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2300 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2302 2011-11-25 Ben Konrath <ben@bagu.org>
2304 Improve Gda Value conversion from PrimaryKeyItem.
2306 The value from the PrimaryKeyItem is only used if its type match the
2307 type from the glom document.
2309 * src/main/java/org/glom/web/server/Utils.java:
2311 2011-11-25 Ben Konrath <ben@bagu.org>
2313 Manually check if the java-liblgom .so is visible to the JVM.
2315 It seems that Tomcat has problems when a static initializer throws an
2316 exception. This check is done before the first method call into
2317 java-libglom so that execution doesn't continue if the .so is not
2320 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2322 2011-11-25 Ben Konrath <ben@bagu.org>
2324 Improve browser configuration error messages.
2328 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2330 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2331 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2332 getConfigurationErrorMessage() method.
2333 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2334 Get and display a specific configuration error message when no Glom
2335 documents are found.
2336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2337 Implement getConfigurationErrorMessage() method. Surround configuration
2338 code in the init() method with a try/catch block. This allows the
2339 errors to be caught while keeping the servlet available to retrieve the
2340 configuration error message.
2342 2011-11-25 Ben Konrath <ben@bagu.org>
2344 Don't use Strings to hold primary key values.
2346 The primary key values are now held in a new data object
2347 (PrimaryKeyItem) that holds type information and the primary key value
2348 using the correct type.
2350 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2351 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2352 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2353 PrimaryKeyItem instead of String to hold the primary key value.
2354 * src/main/java/org/glom/web/client/Utils.java: Remove
2355 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2356 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2357 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2358 PrimaryKeyItem instead of String to hold the primary key value. Load
2359 document selection page when the documentID has not been set correctly.
2360 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2361 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2363 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2364 Return empty string for URL instead of "null".
2365 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2366 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2367 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2368 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2369 PrimaryKeyItem instead of String to hold primary key values.
2370 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2371 PrimaryKeyValue to a Gda Value.
2372 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2373 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2374 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2375 Replace temporary database access code that uses the PrimaryKeyValue to
2376 Gda Value conversion.
2377 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2378 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2379 PrimaryKeyItem instead of String.
2380 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2381 hold primary key values.
2383 2011-11-24 Ben Konrath <ben@bagu.org>
2385 Use newly added java-libglom API to create queries.
2387 This isn't finished. I still need to stop using Strings for primary key
2388 values in the client code.
2390 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2391 libglom to use fake connections so that retrieving the query string will
2393 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2394 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2395 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2396 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2397 Use the newly added libglom sql methods and classes to create the
2398 query. Add temporary hack to convert primary value strings to Gda
2401 2011-11-23 Ben Konrath <ben@bagu.org>
2403 Don't explicitly set the height of Portals.
2405 See comments 6 - 10 of this bug for details:
2407 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2409 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2411 2011-11-23 Ben Konrath <ben@bagu.org>
2413 Use an HTML table instead of CSS for the FlowTable layout.
2415 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2416 GWT's FlexTable to implement the FlowTable.
2417 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2419 2011-11-18 Ben Konrath <ben@bagu.org>
2421 Add boolean example to HTML table mockup.
2423 * mockups/details-view-html-tables-text-entries.html:
2425 2011-11-17 Ben Konrath <ben@bagu.org>
2427 Ensure the pager buttons are always visible for related lists.
2429 To accomplish this, I've turned off text wrapping in the list view and
2430 related list tables for both the header and data text. The related list
2431 table now has a fixed layout so the it doesn't overflow its container.
2432 This is required to ensure that the cell text is clipped when it
2433 overflows the cell and an ellipsis is added to the right side of the
2434 cell when text is clipped.
2436 A fixed table layout for the related list table in the details view
2437 seems what we want for the details view anyway, so the side-effect is
2440 The ellipsis will only be displayed in Firefox >= 7.
2444 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2446 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2447 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2448 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2450 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2451 Set the 'table-layout: fixed' CSS property to the related list table.
2452 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2453 'white-space: nowrap;' CSS property on both the list view and the
2454 related list tables.
2456 2011-11-16 Ben Konrath <ben@bagu.org>
2458 Rework the fix for empty notebook tab labels.
2460 Setting the empty group titles with its name caused problems for the
2461 details layout. Instead of using libglom's
2462 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2463 to the client when the title is empty. This allows the Notebook to use
2464 the name when the title is empty without affecting anything else.
2466 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2467 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2469 2011-11-16 Ben Konrath <ben@bagu.org>
2471 Set group titles with name when title is empty.
2473 This fixes a problem with an empty notebook tab label in the Lesson
2474 Planner document. The forth tab in the notebook should be "Internet":
2476 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2478 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2479 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2482 2011-11-16 Ben Konrath <ben@bagu.org>
2484 Remove whitespace from the configured username properties.
2486 This assumes that usernames won't have whitespace at the beginning
2487 or end. But I think this is a reasonable assumption.
2489 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2490 String.trim() to remove the whitespace from the username properties.
2492 2011-11-15 Ben Konrath <ben@bagu.org>
2494 Add details view mockup with HTML tables and text entries.
2496 This is from the attachment on this bug:
2498 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2500 * mockups/details-view-html-tables-text-entries.html:
2502 2011-11-15 Ben Konrath <ben@bagu.org>
2504 Add space between the columns of the flow table.
2508 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2510 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2511 space between columns in the flow table.
2513 2011-11-15 Ben Konrath <ben@bagu.org>
2515 Add backup files to the .gitignore.
2517 * .gitignore: Ignore files that end with ~.
2519 2011-11-09 Ben Konrath <ben@bagu.org>
2521 Use latest release of gwt-log.
2523 Gwt-log releases are now being submitted to the maven central
2524 repository so manual installation of the jar is no longer required.
2526 * pom.xml: Update version and groupId of gwt-log dependency.
2528 2011-10-31 Ben Konrath <ben@bagu.org>
2530 Don't use GWT numeric formatting to override the glom currency formatting.
2532 Currencies are now displayed like they are in Glom. See this bug:
2534 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2536 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2538 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2539 currency code to constructor and set it when the cell is rendered.
2540 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2541 currency code to the constructor of the NumericCell.
2543 2011-10-27 Ben Konrath <ben@bagu.org>
2545 Require the latest release of java-libglom (1.17.4).
2549 2011-10-26 Ben Konrath <ben@bagu.org>
2551 Add style to Notebook that matches current theme.
2553 It's not the best style in the world but it's better than the default.
2555 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2556 padding at the bottom of the child widgets.
2557 * src/main/webapp/style.css: Add style for the Notebook.
2559 2011-10-26 Ben Konrath <ben@bagu.org>
2561 Move servlet initialization code to overridden init method.
2563 This is half of the solution to getting proper error messages
2564 displayed when configuration errors occur. Here's the relevant bug:
2566 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2568 The rest of the solution involves surrounding the init method with a
2569 try/catch block and setting a global variable with the error /
2570 exception. A new async method should be created to retrieve and display
2571 the error message / exception.
2573 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2574 code from constructor to init method adding exceptions as needed.
2576 2011-10-26 Ben Konrath <ben@bagu.org>
2578 Add script to monitor and restart tomcat if required.
2580 * utils/check-and-recover-tomcat.py: New file.
2582 2011-10-26 Ben Konrath <ben@bagu.org>
2584 Display the correct number of data items in the pager.
2588 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2590 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2591 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2592 The implementation is the same for both tables: Keep track of the
2593 number of non-empty rows and fire and RowCountChangeEvent after the data has
2595 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2596 custom Pager class that subclasses SimplePager to handle displaying
2597 the correct number when empty rows have been added.
2599 2011-10-26 Ben Konrath <ben@bagu.org>
2601 Correct error in previous commit.
2603 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2604 eventBus parameter from listView.setCellTable().
2606 2011-10-26 Ben Konrath <ben@bagu.org>
2608 Fix error in TODO comment.
2610 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2612 2011-10-24 Ben Konrath <ben@bagu.org>
2614 Create Notebook widgets to the details view.
2616 This isn't finished just yet - I still need to create a reasonable
2617 style to match the current theme.
2619 * src/main/java/org/glom/web/client/Utils.java: Add method for
2620 calculating the height of a widget. This is used in the Notebook class.
2621 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2622 new constructor method in Group.
2623 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2624 method for creating child widget that can be used by subclasses
2625 like Notebook. New constructor that allows disabling the group
2626 titles - Notebooks don't set a group title for their child groups.
2627 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2628 to make Notebooks using GWT's TabLayoutPanel.
2629 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2630 constructor that allows disabling the group titles.
2631 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2632 LayoutItemNotebook DTO.
2633 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2634 DTO for Notebooks. It's just an empty class for now but we might need
2635 it to transfer some specific information in the future.
2637 2011-10-21 Ben Konrath <ben@bagu.org>
2639 Add navigation buttons to related list tables.
2641 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2642 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2644 method getSuitableRecordToViewDetails() for getting the table name
2645 and primary key value for related list navigation buttons.
2646 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2647 private cell renderer class to get the navigation information for
2648 related list tables from the server. Extract the navigation
2649 processing code from the details cell navigation and use it for the
2650 related list navigation as well.
2651 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2652 cell renderer class for the details open buttons. This was needed
2653 because the related list navigation buttons and the list view
2654 navigation buttons need to react differently when clicked.
2655 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2656 the onEnterKeyDown() method because it's now overriden in the
2657 subclasses that are specific to the related list tables and the list
2659 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2660 the vertical size a little because the buttons add a bit of vertical
2661 space to table. This is not a perfect solution because the vertical
2662 size of with table fewer than 5 rows will be a little smaller.
2663 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2664 changes in how navigation buttons are handled.
2665 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2666 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2667 database access object.
2668 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2669 to find the portal for a given relationship name from
2670 RelatedListDBAccess. Add method to find a primary key field for a
2672 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2673 Move code to find the portal for a given relationship name to
2675 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2676 New file: database access object for getting the related list
2677 navigation information (the table name and the primary key value).
2678 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2679 DTO for transferring a table name to navigate to and a primary key
2681 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2682 boolean and getter/setter to specifies if the related list should add
2685 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2687 Use the master branch of java-libglom
2689 * pom.xml: Depend on java-libglom 1.19 instead.
2691 This is the master branch. See also the libglom-1-18 branch.
2693 2011-10-11 Ben Konrath <ben@bagu.org>
2695 Enable the open navigation button when the data has been set.
2697 This avoids having active buttons that don't do anything when the data
2700 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2702 2011-10-11 Ben Konrath <ben@bagu.org>
2704 Use IsWidget interface for FlowTableItem.
2706 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2707 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2709 2011-10-11 Ben Konrath <ben@bagu.org>
2711 Remove GWT styling from open button in details view.
2713 There are still some issues with how the details cell is arranged but
2714 this should be made to match Glom 1.20. I'm going to leave fixing this
2715 until I have Glom 1.20 up and running.
2717 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2718 style name on open button.
2719 * src/main/webapp/style.css: Move and edit details-navigation class.
2720 Re-arrange some classes to make them appear in the same order as the
2723 2011-10-07 Ben Konrath <ben@bagu.org>
2725 Update to GWT 2.4.0.
2727 * .gitignore: Ignore new cache directory.
2728 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2729 * pom.xml: Change GWT and maven plugin to 2.4.0.
2730 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2732 * src/main/java/org/glom/web/client/ClientFactory.java:
2733 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2734 * src/main/java/org/glom/web/client/OnlineGlom.java:
2735 Update source for API changes.
2736 * utils/build-onlineglom-war.sh: Remove cache directory before the
2739 2011-10-07 Ben Konrath <ben@bagu.org>
2741 Add navigation buttons in the details view.
2743 This isn't finished but I thought I'd commit what I have as it's a
2744 pretty good start. I still need to:
2746 1. Change the style so that it fits better into the current theme
2747 2. Adjust the details cell to expand as much as possible.
2749 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2750 click handlers to navigation buttons in the DetailsCells. Create a
2751 refreshData() method to get just the data from the server without the
2753 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2754 Update the tableSelector and browser title when the table name
2755 changes without using the tableSelector.
2756 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2757 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2758 getDetailsCells() to getCells(). Update variable names.
2759 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2760 method to set click handler on navigation button. Rename a few
2761 variables. Add navigation buttons where needed.
2762 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2763 variables and methods.
2764 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2765 navigation boolean and navigation table as required in the
2766 LayoutItemField DTO.
2767 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2768 variables for navigation along with getter/setter methods.
2770 2011-10-07 Ben Konrath <ben@bagu.org>
2772 Rename Field to DetailsCell.
2774 This is a refactor-only commit. No functionality has been added or
2777 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2778 Update variable and method names.
2779 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2780 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2781 variable and method names.
2782 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2784 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2785 variable and method names.
2787 2011-10-07 Ben Konrath <ben@bagu.org>
2789 Create separate methods for layout and data the details view.
2791 This is a refactor-only commit. No functionality has been added or
2794 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2795 private methods: setData(), createLayout().
2797 2011-10-07 Ben Konrath <ben@bagu.org>
2799 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2801 This is part of a change to get navigation buttons in the details view
2802 but it should have been done this way from the start.
2804 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2805 for method name change in TableSelectionView.
2806 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2807 Create TableChangeEvent and set the browser title using the
2808 TableSelectionView API.
2809 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2810 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2811 Change getSelectedTable() to getSelectedTableName(). Add
2812 getSelectedTableTitle().
2814 2011-10-07 Ben Konrath <ben@bagu.org>
2816 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2818 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2820 2011-10-07 Ben Konrath <ben@bagu.org>
2822 Update TableChangeEvent to use newTableName naming convention.
2824 This makes the class more consistent with GWT naming conventions.
2826 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2827 Update for method name change in TableChangeEvent.
2828 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2829 for method name change in TableChangeEvent.
2830 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2831 newTableName variable and getter method. Make toDebugString()
2834 2011-09-30 Ben Konrath <ben@bagu.org>
2836 Disable the pager in the list tables when the data row count is less than the minimum.
2838 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2839 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2841 2011-09-30 Ben Konrath <ben@bagu.org>
2843 Add empty rows to the end of related list and list view tables.
2845 I also extracted the cell rendering classes from the ListTable because
2846 the code was becoming a little crazy with all the anonymous inner
2847 classes. My plan is to use these cell rendering classes in the details
2848 view as well so this refactor will be needed for that change.
2850 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2851 set the row count in related list tables if the data has more rows
2852 than the minimum number of rows visible.
2853 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2854 row count in list view tables if the data has more rows than the
2855 minimum number of rows visible.
2856 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2857 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2859 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2860 for rendering TYPE_NUMERIC cells. The code was extracted from the
2862 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2863 class for rendering cells with buttons in list views. The code was
2864 extracted from the ListTable class.
2865 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2866 for rendering TYPE_TEXT cells. The code was extracted from the
2868 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2869 Add empty rows to the end of the data if required. Implement
2870 ListTable.getMinNumVisibleRows().
2871 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2872 cell renderer code to public classes. Return null in
2873 Column.getValue() for empty rows. Add new abstract method:
2874 getMinNumVisibleRows(). Move code to set the row count of the list view
2875 table to ListViewImpl.
2876 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2877 empty rows to the end of the data if required. Implement
2878 ListTable.getMinNumVisibleRows().
2881 2011-09-27 Ben Konrath <ben@bagu.org>
2883 Use GWT.log for client-side debugging statements.
2885 These are optimized out when deployed so I should have used this method
2886 in the first place. These statements will eventually be replaced with some sort
2887 of notification in the browser.
2889 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2890 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2891 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2892 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2893 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2895 2011-09-27 Ben Konrath <ben@bagu.org>
2897 Put tableselector on the right, back to list link on right.
2899 The idea is that the table selector is acting like a label for the
2900 currently displayed table so it should be placed below the document title. This
2901 puts the table title in a similar position to where it is in Glom.
2903 * mockups/details-contacts.html:
2904 * mockups/details-projects.html:
2905 * mockups/listview-contacts.html:
2906 * mockups/listview-projects.html:
2907 * mockups/style.css:
2908 Update mockups to match how the interfaces currently look.
2909 * src/main/webapp/style.css: Swap positions of backlink with the table
2910 selector. Add some space on the left side of the table selector to
2911 line things up with the document title.
2913 2011-09-27 Ben Konrath <ben@bagu.org>
2915 Add field colouring to details view.
2917 This change re-works how field colouring works. The colour formatting
2918 information is now set to the client with the layout information instead of
2919 with the data. This eliminates the need to send the same colour strings for
2920 data in list view column when colour information is set.
2922 In order to set an alternate colour for negative numeric values, the
2923 number is now sent to client and formatted with the GWT NumberFormat class.
2925 This change also fixes:
2927 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2929 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2930 internationalization framework which is needed for client side numeric
2932 * src/main/java/org/glom/web/client/Utils.java: New file for some
2933 client static utility methods.
2934 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2935 the DataItem object to the Field class. Use a utility method to
2936 create the foreignKeyValue string.
2937 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2938 alignment and text colours in the constructor. Add setData(DataItem)
2939 method. Remove setText(String) method.
2940 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2941 colour information to GlomTextCell. Create and use GlomNumberCell for
2942 rendering numbers. Use utility method to get the string for the
2943 primary key of the key provider. Re-work how the horizontal alignment
2945 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2946 formatting to layout information. Methods for converting the libglom
2947 formatting information were moved from DBAccess.
2948 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2949 numeric formatting (it's now done on the client side). Don't set text
2950 colours in DataItem. Move libglom formatting conversion methods to
2952 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2953 getters/setters for text colour information.
2954 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2955 for transferring the libglom NumericFormat information to the client.
2956 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2957 and getters/setters for: GlomNumericFormat, background colour and
2958 foreground colour strings.
2960 2011-09-26 Ben Konrath <ben@bagu.org>
2962 Simplify code that iterates through the LayoutGroup.
2964 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2966 2011-09-26 Ben Konrath <ben@bagu.org>
2968 Accept Eclipse formatting for OnlineGlomServiceAsync.
2970 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2972 2011-09-26 Ben Konrath <ben@bagu.org>
2974 Don't use the ListDBAccess classes to get the primary key layout information.
2976 This was causing a bug where the wrong index for the hidden primary key
2977 was being sent to the client.
2979 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2980 primary key while creating the LayoutGroup DTO. Create a
2981 LayoutItemField DTO for hidden primary keys. Don't use the
2982 RelatedListDBAccess because it was only used for getting the primary
2984 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2985 access modifier from public to protected for getPrimaryKeyField() and
2986 getPrimaryKeyLayoutItemField().
2987 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2988 abstract method getExpectedResultSize() because RelatedListDBAccess
2989 doesn't have enough info to implement it.
2990 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2991 Remove @Override for getExpectedResultSize().
2992 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2993 Remove method getExpectedResultSize().
2995 2011-09-23 Ben Konrath <ben@bagu.org>
2997 Log which layout (list or details) the ignored item is from.
2999 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3001 2011-09-23 Ben Konrath <ben@bagu.org>
3003 Remove annotations that turn off code formatting in DataItem.
3005 * src/main/java/org/glom/web/shared/DataItem.java:
3007 2011-09-23 Ben Konrath <ben@bagu.org>
3009 Rename GlomField to DataItem and update associated methods.
3011 This is a rename-only refactor. No functionality has been added or
3014 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3015 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3016 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3017 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3018 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3019 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3020 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3021 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3023 * src/main/java/org/glom/web/server/database/DBAccess.java:
3024 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3025 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3026 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3027 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3028 * src/main/java/org/glom/web/shared/DataItem.java:
3029 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3030 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3032 2011-09-23 Ben Konrath <ben@bagu.org>
3034 Rename GlomDocument to DocumentInfo and update associated methods.
3036 This is a rename-only refactor. No functionality has been added or
3039 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3040 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3041 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3042 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3043 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3045 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3047 2011-09-20 Ben Konrath <ben@bagu.org>
3049 Require java-libglom 1.17.3.
3051 This picks up the fix for the seg fault problem with the Scenes table
3052 in the Openismus Film Manager example.
3056 2011-09-20 Ben Konrath <ben@bagu.org>
3058 Change the way sort clause is added for primary key when no sort clause is requested.
3060 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3061 before the sort clause is created. When a sort clause is not requested, the
3062 sort clause is created by finding the primary key in the LayoutFieldVector
3065 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3067 2011-09-20 Ben Konrath <ben@bagu.org>
3069 Log error message if no documents are found in the configured directory.
3071 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3072 Extract the glom file extension string to a private static final class
3073 variable (mostly as syntactic sugar). Accept a minor formatting change.
3074 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3075 the example glom.document.directory configuration property to make it
3076 more clear that it can any directory, not just the home directory.
3078 2011-09-18 Ben Konrath <ben@bagu.org>
3080 Add related lists to details view.
3082 The related list table has support for paging and sorting just like the
3083 table in the list view.
3085 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3086 SQL queries for the related list tables.
3087 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3088 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3089 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3090 Rename getList methods to getListView and add comments. Remove
3091 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3092 it being unused. Add methods: getDetailsLayoutAndData(),
3093 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3094 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3095 Create the layout and set the data for the fields in one async call
3096 instead of two. Create related lists where appropriate.
3097 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3098 for method name changes in OnlineGlomService.
3099 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3100 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3101 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3103 * src/main/java/org/glom/web/client/ui/ListView.java:
3104 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3105 tableName from setCellTable(). Create a ListViewTable instead of
3107 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3108 represent a data field in the details view.
3109 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3110 from addDetailsCell() to Field class. Keep track of the Fields and
3111 Portals in the details view.
3112 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3113 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3114 and add a method to get it. Add method to set the contents of the
3116 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3117 New class for related list tables. This class has the data provider
3118 for the related list table.
3119 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3120 abstract class which is the base class for the ListViewTable and the
3122 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3123 New class for list view tables. This class has the data provider for
3124 the list view table.
3125 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3126 methods for related list tables. Add more information to the
3127 LayoutItemField and LayoutItemPortal DTOs.
3128 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3129 Remove debugging print statement.
3130 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3131 Remove debugging print statements. Add primary key field to SQL count
3133 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3134 Remove unnecessary LayoutFieldVector parameter from
3135 getResultSizeOfSQLQuery() method.
3136 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3137 New class for related list table database access.
3138 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3139 class that is a wrapper DTO for details view layout and data.
3140 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3141 new 'fromField' string to this DTO.
3142 * src/main/webapp/style.css: Remove bottom margin and override top
3145 2011-09-15 Ben Konrath <ben@bagu.org>
3147 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3149 This sets things up to make it easier to add the data retrieval for
3150 related lists (portals). No user noticeable changes were made with
3153 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3154 class has the code to retrieve the layouts and access the
3155 database using the new database helper classes.
3156 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3157 Most of the functionality has been removed from this class. This
3158 class now represents the public interface for the client side
3159 code. It also deals with configuring the servlet and cleaning
3160 things up when the servlet is stopped.
3161 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3162 of static methods into this utility class.
3163 * src/main/java/org/glom/web/server/database/DBAccess.java:
3164 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3165 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3166 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3167 These classes have the database retrieval code. The class hierarchy
3168 has been setup to make it easy to reuse code for similar
3171 2011-09-06 Ben Konrath <ben@bagu.org>
3173 Create separate classes for list table code and the data provider.
3175 As part of this refactor, I also split up the code a bit to make it
3178 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3179 table code to two new classes (below).
3180 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3181 with code from ListViewImpl.
3182 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3183 New file with code from ListViewImpl.
3185 2011-09-06 Ben Konrath <ben@bagu.org>
3187 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3189 This fixes the LayoutItemPortal DTO to match the libglom layout object
3192 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3194 2011-09-01 Ben Konrath <ben@bagu.org>
3196 Set title of Portals in the Details View.
3198 * pom.xml: Bump required version of java-libglom to 1.17.1.
3199 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3200 widget creation to its own class. Add comments to constructor.
3201 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3202 The code is mostly from the Group class with the title now set.
3203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3204 title of Portal. Update some comments. Fix some code formatting.
3206 2011-09-01 Ben Konrath <ben@bagu.org>
3208 Remove TODO comment for the flow table column width.
3210 The flow table column width is working correctly and doesn't need to be
3211 changed. See this mailing list post for more info:
3213 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3215 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3217 2011-08-27 Ben Konrath <ben@bagu.org>
3219 Add document title (database name) to top of the browser page.
3221 I added the document title to the TableSelecitonView but that will
3222 change if / when we add a view that doesn't require table selection.
3224 * mockups/details-contacts.html:
3225 * mockups/details-projects.html:
3226 * mockups/listview-contacts.html:
3227 * mockups/listview-projects.html:
3228 * mockups/style.css: Add document title to mockups to keep things
3230 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3231 sizes to account for the document title.
3232 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3233 Set the document title when it has been retrieved from the server.
3234 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3235 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3236 and implement setDocumentTitle(String) method.
3237 * src/main/webapp/style.css: Add ID for document title style.
3239 2011-08-25 Ben Konrath <ben@bagu.org>
3241 Add NavigationType enum to LayoutItemPortal DTO.
3243 This is the start of adding support for Portals to the Details View.
3245 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3246 LayoutItem_Portal.navigation_type enum from libglom to
3247 LayoutItemPortal.NavigationType enum.
3248 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3249 NavigationType enum, field for storing the NavigationType and getter
3252 2011-08-25 Ben Konrath <ben@bagu.org>
3254 Implement the flow table layout in the Details View.
3256 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3257 FlowTable to Group to account for the renamed&nbs