1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
3 LayoutItemField: Fix loading of custom titles.
5 * src/main/java/org/glom/web/server/libglom/Document.java
6 loadDataLayoutItemField(): The title, if any, instead of the field
7 title, is stored in a title_custom node. Load it from there.
8 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
10 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
11 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
12 getTitle*() overrides.
13 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
16 2012-05-06 Murray Cumming <murrayc@murrayc.com>
18 LayoutItemField: Fall back to field titles, so some are really shown.
20 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
21 Override getTitleOriginal() and getTitle(), as in java-libglom.
22 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
25 2012-05-06 Murray Cumming <murrayc@murrayc.com>
27 Correct use of setExpectedResultSize().
29 * src/main/java/org/glom/web/server/ConfiguredDocument.java
30 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
31 Use setExpectedResultSize only on top-level groups (for instance, the
32 list layout) or on child portals (in details views).
33 Use the correct table name for portals to avoid SQL errors.
34 Update the expected counts when returning cached layouts.
36 2012-05-06 Murray Cumming <murrayc@murrayc.com>
38 Document: Interpret no group column count as 1.
40 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
41 default, though we now check for this in the UI code anyway.
43 2012-05-06 Murray Cumming <murrayc@murrayc.com>
47 2012-05-06 Murray Cumming <murrayc@murrayc.com>
49 Translatable: Use Hashmap instead of Treemap because GWT supports it.
51 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
52 The use of Treemap lead to this error from async methods, with no
54 "The response could not be deserialized"
56 2012-05-06 Murray Cumming <murrayc@murrayc.com>
58 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
60 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
61 when using the Google -> GWT Compile, or
62 g toolbar button -> GWT Compile Project... feature in Eclipse.
64 2012-05-06 Murray Cumming <murrayc@murrayc.com>
66 ListTable.addColumn(): Protect against a null Formatting.
68 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
69 Create a default Formatting if it is null, because that is the simplest
72 2012-05-06 Murray Cumming <murrayc@murrayc.com>
74 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
76 * src/main/java/org/glom/web/server/ConfiguredDocument.java
77 updateLayoutGroup(): Check that the field is not null.
79 2012-05-06 Murray Cumming <murrayc@murrayc.com>
81 ListViewImpl: Protected against a bad cast error.
83 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
84 onEnterKeyDown(): Do not cast without an instanceof check.
86 2012-05-06 Murray Cumming <murrayc@murrayc.com>
88 ListTable: Protect against an out of range error.
90 * src/main/java/org/glom/web/client/ui/list/ListTable.java
91 createCellTable(): This is unlikely, but can happen while debugging.
93 2012-05-06 Murray Cumming <murrayc@murrayc.com>
95 AsyncMessage onFailure() callbacks: Log the exception message.
97 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
98 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
99 * src/main/java/org/glom/web/client/activity/ListActivity.java:
100 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
101 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
102 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
103 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
104 These are useful clues when something is wrong.
106 2012-05-06 Murray Cumming <murrayc@murrayc.com>
108 ConfiguredDocument: Avoid a null dereference.
110 * src/main/java/org/glom/web/server/ConfiguredDocument.java
111 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
112 details maps are created.
114 2012-05-06 Murray Cumming <murrayc@murrayc.com>
116 Document: Correct the port number parsing.
118 * src/main/java/org/glom/web/server/libglom/Document.java:
119 This lets us actually connect to the database and show the document.
121 2012-05-05 Murray Cumming <murrayc@murrayc.com>
125 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
126 user-interaction, asking us to load a temporary URL in a browser.s
127 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
128 which is apparently necessary for testing the service. See the comment.
129 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
130 Show the exception, if any. This is how I saw the 404 in the HTML in
133 2012-05-05 Murray Cumming <murrayc@murrayc.com>
135 DocumentTest: Move the .glom files into the resources directory.
137 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
138 URI via getResource().
140 2012-05-05 Murray Cumming <murrayc@murrayc.com>
142 Document: Remove the FieldIdentifies inner class.
144 * src/main/java/org/glom/web/server/libglom/Document.java: We only
145 use the Relationship (though the same function in libglom is maybe
146 used in other ways) and so this removes a compiler warning.
148 2012-05-05 Murray Cumming <murrayc@murrayc.com>
150 Document.load() Remove the error code parameter.
152 * src/main/java/org/glom/web/server/libglom/Document.java: load():
153 Remove the parameter. We do not set it yet and it could never have
154 worked as an output parameter (though maybe it did in java-libglom).
155 We could use an exception if we really want the failure reason.
156 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
158 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
159 setUp(), testGetSuitableTableToViewDetails(): Adapt.
161 2012-05-05 Murray Cumming <murrayc@murrayc.com>
163 Make some inner classes static.
165 * src/main/java/org/glom/web/server/ConfiguredDocument.java
166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
167 * src/main/java/org/glom/web/server/ReportGenerator.java
168 * src/main/java/org/glom/web/server/libglom/Document.java
169 Make all inner classes static that can be static.
171 2012-05-05 Murray Cumming <murrayc@murrayc.com>
173 OnlineGlomServiceImpl: Do not load and check for java-libglom.
175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
176 init(): We do not use java-libglom any more.
178 2012-05-05 Murray Cumming <murrayc@murrayc.com>
180 Remove mentions of java-libglom.
182 * README: Remove mention of java-libglom, because it no longer needed.
183 * utils/build-onlineglom-war.sh:
184 * utils/check-and-recover-tomcat.py:
185 * utils/install-onlineglom-war.sh: Remove these as they are no longer
186 useful. Building is now far easier, with no need for jhbuild.
188 2012-05-05 Murray Cumming <murrayc@murrayc.com>
190 Fix the build (mvn package)
192 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
193 (LayoutGroup): Make the LayoutItemList inner class static and protected.
194 Otherwise the GWT Java->Javascript compilation fails with just this
195 error, during mvn package or when attempting to view in a browser,
196 in the GWT developer mode in Eclipse.
198 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
199 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
200 [INFO] Compiling module org.glom.web.OnlineGlom
201 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
202 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
203 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
204 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
205 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
206 [INFO] [ERROR] Cannot proceed due to previous errors
208 It has taken me 2 days to find out what was causing that. After reducing
209 the code, the compiler eventually showed me the full error message.
211 2012-05-04 Murray Cumming <murrayc@murrayc.com>
213 ConfiguredDocument: Cache the cloned and stripped layouts.
215 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
216 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
217 layout in a map, so we can retrieve it again without rebuilding it.
219 2012-05-04 Murray Cumming <murrayc@murrayc.com>
221 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
223 2012-05-04 Murray Cumming <murrayc@murrayc.com>
225 libglom classes: Implement some auto-generated emthods.
227 2012-05-04 Murray Cumming <murrayc@murrayc.com>
229 Add GwtTestOnlineGlomService.
231 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
232 However, this (and the other GwtTest*) does not seem to run during
235 2012-05-04 Murray Cumming <murrayc@murrayc.com>
237 Remove use of unsupported features from client code.
239 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
240 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
241 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
242 Use our client version of StringUtils instead of the apache commons one.
244 However, the GWT Javascript compliation still fails.
246 2012-04-25 Murray Cumming <murrayc@murrayc.com>
248 Add a Field class and implement some loading of it in Document.
250 2012-04-25 Murray Cumming <murrayc@murrayc.com>
252 Initial Document loading implementation, instead of libglom.
254 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
255 and Translatable classes, and adapt the rest of the code to use them.
256 However, this is still missing Layout and Field classes and loading.
258 2012-04-24 Murray Cumming <murrayc@murrayc.com>
260 Use of jOOQ: Move Field creation into a utility method.
262 * src/main/java/org/glom/web/server/SqlUtils.java:
263 This lets us improve it more easily.
265 2012-04-24 Murray Cumming <murrayc@murrayc.com>
267 Use of jOOQ: Improve the code to COUNT a sub-select.
269 * src/main/java/org/glom/web/server/SqlUtils.java:
270 Move initial query creation into
271 build_sql_select_step_with_where_clause().
272 build_sql_select_count_rows(): Use the jOOQ API instead of
273 concatentating text, because a jOOQ Select*Step is a TableLike,
274 which is what from() takes.
276 2012-04-23 Murray Cumming <murrayc@murrayc.com>
278 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
280 * pom.xml: Depend on jooq.
281 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
282 methods with jOOQ, based on the C++ implementations in libglom,
283 with some changes to the logic required by jooQ.
284 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
286 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
287 * src/main/java/org/glom/web/server/ReportGenerator.java:
288 * src/main/java/org/glom/web/server/SqlUtils.java:
289 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
290 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
291 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
292 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
293 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
294 Adapt. In particular, the SqlUtils methods now need to take a Connection,
295 because jOOQ needs that, though it seems unnecessary.
297 This is not quite finished. Ideally jOOQ would help us to build
298 table_name.field_name names, quoting and escaping them properly.
299 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
301 2012-04-21 Murray Cumming <murrayc@murrayc.com>
303 Move use of Glom.build_sql*() into a new SqlUtils class.
305 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
306 to wrap Glom.build_sql*(). The parameter types are still Glom one,
307 but this will make it easier to start using something other than
308 libglom or SqlBuilder.
310 2012-04-21 Murray Cumming <murrayc@murrayc.com>
312 Update the project URL.
314 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
316 2012-04-21 Murray Cumming <murrayc@murrayc.com>
318 Main layout: Use a FlowTable instead of absolute positioning.
320 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
321 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
322 child panels/widgets must have an absolute position. But that is annoying, so
323 this adds a FlowTable and puts the child panels in there.
325 2012-04-21 Murray Cumming <murrayc@murrayc.com>
327 GwtTestOnlineGlom: Comment out unused code.
329 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
330 Eclipse has started to say that some code is unused.
332 2012-04-21 Murray Cumming <murrayc@murrayc.com>
334 Update to the latest versions of dependencies.
336 * pom.xml: Update version numbers of dependencies to the latest
338 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
340 * src/main/java/org/glom/web/server/ReportGenerator.java:
341 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
342 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
343 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
345 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
346 Modify the imports where necessary.
348 2012-04-17 Murray Cumming <murrayc@murrayc.com>
350 Style: Remove overflow:hidden from searchbox
352 * src/main/webapp/style.css: Because this pushes the Back To Link
353 label/link on to the next row, which is then hidden due to the
354 hard-coded (in ems) height.
356 2012-04-20 Murray Cumming <murrayc@murrayc.com>
358 Remove some duplicate code.
360 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
361 getDocumentInfo(): This must have been duplicated during the merge from the
366 2012-04-19 Murray Cumming <murrayc@murrayc.com>
368 Reports: Localize the waiting for report message.
370 * src/main/java/org/glom/web/client/activity/ReportActivity.java
371 start(): Get the message from the contants.
372 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
374 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
375 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
376 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
377 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
378 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
379 Update these files with the English text for newer strings for now.
381 2012-04-19 Murray Cumming <murrayc@murrayc.com>
383 Reports: Show a message while waiting for the report.
385 * src/main/java/org/glom/web/client/ui/ReportView.java
386 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
387 Add setWaitingText(), to show a message saying that we are
388 waiting for the report to be ready.
389 * src/main/java/org/glom/web/client/activity/ReportActivity.java
390 start(): Call setWaitingText() before calling the async
393 2012-04-19 Murray Cumming <murrayc@murrayc.com>
395 ReportGenerator: Specify date and time formats.
397 * src/main/java/org/glom/web/server/ReportGenerator.java:
398 createFieldValueElement(): Use the default (and localized)
399 short formats, though we still need a way to show 4-digit
400 years without providing the format for every locale.
401 * src/main/java/org/glom/web/server/database/DBAccess.java:
402 convertResultSetToDTO(): Use the short formats here too.
404 2012-04-18 Murray Cumming <murrayc@murrayc.com>
406 ReportGenerator: Use the correct numeric formatting.
408 * src/main/java/org/glom/web/server/ReportGenerator.java
409 createFieldExpression(), createFieldValueElement(): Take the
410 whole LayoutItem_Field instead of just the field name, so
411 we have access to the formatting.
412 createFieldValueElement(): Use JRTextField.setPattern() to
413 specify the numeric formatting, with the help of a
414 regular DecimalFormat.
416 2012-04-18 Murray Cumming <murrayc@murrayc.com>
418 ReportGenerator: Avoid showing null for group by titles.
420 * src/main/java/org/glom/web/server/ReportGenerator.java
421 generateReport(): Use setBlankWhenNull() on the field title
422 style too, because this is used for values in group by
425 2012-04-18 Murray Cumming <murrayc@murrayc.com>
427 ReportGenerator: Add a colon to titles in vertical groups.
429 * src/main/java/org/glom/web/server/ReportGenerator.java
430 addFieldToDetailBandVertical(): Pass true for the withColon
433 2012-04-18 Murray Cumming <murrayc@murrayc.com>
435 ReportGenerator: Simplify the code by using Position more.
437 2012-04-18 Murray Cumming <murrayc@murrayc.com>
439 Reports: Support vertical groups, roughly.
441 * src/main/java/org/glom/web/server/ReportGenerator.java:
442 addToReport(): Rename to addGroupToReport() and, if necessary,
443 call the new addVerticalGroupToReport() method.
444 createFieldValueElement(): Let the caller specify the Y position
447 2012-04-17 Murray Cumming <murrayc@murrayc.com>
449 Reports: Allow a second report to be shown.
451 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
452 clear(): Do not remove the HTML widget, which broke the whole layout.
454 2012-04-17 Murray Cumming <murrayc@murrayc.com>
456 Locales drop-down: Show that we use English by default.
458 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
459 fillView(): When we use English, just because that is the default, when
460 no locale is specified, show that in the Locales drop-down instead of
461 just showing the first item.
463 2012-04-17 Murray Cumming <murrayc@murrayc.com>
465 Unselect the Report/Locale/Table combo item when appropriate.
467 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
468 setPlace(): clear reportName if this is not a ReportPlace.
469 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
470 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
471 When the provided name is empty, unselect all items, so that none are
472 indicated. This uses a for loop because I cannot find a single method
475 2012-04-17 Murray Cumming <murrayc@murrayc.com>
477 Report: Give the user a way to get back to the list.
479 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
480 start(), setPlace(): Show the Back To List link on reports, and also
481 interpret selecting the empty report item as back to list.
483 2012-04-13 Murray Cumming <murrayc@murrayc.com>
485 Really show the selected Report name.
487 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
488 setPlace(): Store the reportName here, if it is that kind of Place.
489 fillView(): Set the selected Report after filling the list of reports.
490 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
491 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
492 null Strings, though we need some way to unselect all ListBox items
495 2012-04-13 Murray Cumming <murrayc@murrayc.com>
497 ReportGenerator: Try to avoid some problems.
499 * src/main/java/org/glom/web/server/ReportGenerator.java
500 addField(): Try to avoid duplicates, and avoid using a null
503 2012-04-13 Murray Cumming <murrayc@murrayc.com>
505 Reports: Use quickFind.
507 * src/main/java/org/glom/web/client/OnlineGlomService.java;
508 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
509 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
510 getReportHTML(): Add a quickFind parameter.
511 * src/main/java/org/glom/web/client/activity/ReportActivity.java
512 start(): Pass the quickFind parameter.
513 * src/main/java/org/glom/web/server/ReportGenerator.java
514 generateReport(): Take a quickFind parameter.
516 2012-04-13 Murray Cumming <murrayc@murrayc.com>
518 ReportPlace: Actually use the report name.
520 * src/main/java/org/glom/web/client/place/ReportPlace.java
521 getPlace(): Do not assign the report name to the quickfind.
523 2012-04-13 Murray Cumming <murrayc@murrayc.com>
525 Show java.library.path when complaining.
527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
528 init(): When telling us to check java.library.path, show the
531 2012-03-06 Murray Cumming <murrayc@murrayc.com>
533 ReportGenerator: Do not show nulls.
535 2012-03-06 Murray Cumming <murrayc@murrayc.com>
537 ReportGenerator: Make the title font larger.
539 2012-03-06 Murray Cumming <murrayc@murrayc.com>
541 ReportGenerator: Put field titles inside groups, if there are groups.
543 2012-03-06 Murray Cumming <murrayc@murrayc.com>
545 ReportGenerator: Take the Report itself instead of the name and group.
547 * src/main/java/org/glom/web/server/ConfiguredDocument.java
548 Remove getReportLayoutGroup().
549 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
550 getReportHTML(): Pass the report instead
551 of its name and layout group.
552 * src/main/java/org/glom/web/server/ReportGenerator.java
553 generateReport(): Use the report object to use the title
556 2012-03-06 Murray Cumming <murrayc@murrayc.com>
558 ReportGenerator: Remove designBand parameters.
560 * src/main/java/org/glom/web/server/ReportGenerator.java:
561 Make designBand a class member instead of passing it to all
564 2012-03-06 Murray Cumming <murrayc@murrayc.com>
566 ReportGenerator: Add lines, a bit like in the desktop version.
568 * src/main/java/org/glom/web/server/ReportGenerator.java
569 addToReport(): Use JRDesignLine.
571 2012-03-06 Murray Cumming <murrayc@murrayc.com>
573 ReportGenerator: Correct the title positions and use some bold style.
575 * src/main/java/org/glom/web/server/ReportGenerator.java:
576 Break the code up into reusable functions, correct the placement of
577 titles, and use normal/bold styles as in the reports in the desktop
580 2012-03-06 Murray Cumming <murrayc@murrayc.com>
582 ReportGenerator: Add a header band to show the field titles.
584 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
585 getReportHTML(): Pass the localeId to the ReportGenerator
587 * src/main/java/org/glom/web/server/ReportGenerator.java
588 constructor: Take the localeID so we can get translated field
590 generateReport(), addToReport(), addFieldToBand(): Add field
591 titles in a column header band.
593 2012-03-05 Murray Cumming <murrayc@murrayc.com>
595 Reports drop-down list: Some improvement.
597 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
598 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
599 Adedd setSelectedReport(),
600 setReportList(): Add a blank line so that the user can select the
602 * src/main/java/org/glom/web/client/activity/ReportActivity.java
603 start(): Show the current report by calling setSelectedReport().
604 This does not seem to work yet.
606 2012-03-05 Murray Cumming <murrayc@murrayc.com>
608 DetailsActivity, ListActivity: Move some variables into a base class.
610 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
611 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
612 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
613 the clientFactory, documentID, tableName and authenticationPopup into
614 a base class, to avoid duplication.
616 2012-03-05 Murray Cumming <murrayc@murrayc.com>
618 Translate the Reports label.
620 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
621 Get the "Reports" label string from the constants.
622 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
623 perties: Add Reports to the constants.
625 2012-03-05 Murray Cumming <murrayc@murrayc.com>
627 Reports: Implement grouping.
629 * src/main/java/org/glom/web/server/ReportGenerator.java:
630 Handle LayoutItem_GroupBy items and try to do the right thing
631 with JRDesignGroup. It seems to work.
633 2012-03-04 Murray Cumming <murrayc@murrayc.com>
635 Actually show some data with JasperReports.
637 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
638 getReportHTML(): Move most code into a ReportGenerator class.
639 * src/main/java/org/glom/web/server/ReportGenerator.java:
640 Recurse into sub-groups, adding fields to the JasperDesign's details
641 band. Note that we must set an arbitrary width and height, or it just
642 will not show any data.
644 2012-03-04 Murray Cumming <murrayc@murrayc.com>
646 Reports Chooser: Show the titles, not the names.
648 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
649 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
650 and the names as the values.
651 * src/main/java/org/glom/web/server/ConfiguredDocument.java
652 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
653 group now that we provide the report name, so it should always
656 2012-02-15 Murray Cumming <murrayc@murrayc.com>
658 Depend on jasperreports.
660 * pom.xml: Add the dependency. My plan is to use this on the
663 2012-01-31 Murray Cumming <murrayc@murrayc.com>
665 Implement navigation to report places.
667 * src/main/java/org/glom/web/client/activity/ReportActivity.java
668 start(): Do not bother to handle all events here.
669 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
670 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
671 Added getSelectedReport().
672 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
673 .java: start(): When handling a change to the reports chooser,
674 call getSelectedReport() and goTo() its ReportPlace.
675 * src/main/java/org/glom/web/client/ui/ReportView.java
676 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
677 Added setReportHTML() which puts the html in a gwt HTML widget.
678 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
679 getReportHTML(): Return "TODO" just to show that this works.
681 2012-01-31 Murray Cumming <murrayc@murrayc.com>
683 Make ReportPlace usable.
685 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
687 * src/main/java/org/glom/web/client/place/ReportPlace.java:
688 Correct the @prefix annotation.
690 2012-01-31 Murray Cumming <murrayc@murrayc.com>
692 OnlineGlomService: Return report HTML rather than the LayoutGroup.
694 * src/main/java/org/glom/web/client/OnlineGlomService.java:
695 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
697 Change getReportLayout() to getReportHMTL() because we will not need to
698 parse or render the report layout on the client side.
699 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
700 getReportLayout(): Return the libglom LayoutGroup type because we will
701 not need to convert to a shared type, because this will not be used on
703 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
706 Note that there is still no implementation for this.
709 2012-01-27 Murray Cumming <murrayc@murrayc.com>
711 Add a (empty) Report Place, View, and Activity.
713 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
715 * src/main/java/org/glom/web/client/place/HasTablePlace.java
716 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
717 this into a superclass:
718 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
719 and also use it as the base of this new ReportPlace:
720 * src/main/java/org/glom/web/client/place/ReportPlace.java
722 * src/main/java/org/glom/web/client/ui/ReportView.java
723 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
724 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
725 Add these, containing mostly boiler-plate for now.
727 * src/main/java/org/glom/web/client/OnlineGlomService.java
728 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
729 * src/main/java/org/glom/web/server/ConfiguredDocument.java
730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
731 Add API to get the LayoutGroup for the report.
733 2012-01-23 Murray Cumming <murrayc@murrayc.com>
735 Add and fill a Reports drop-down list box.
737 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
739 * src/main/java/org/glom/web/client/OnlineGlomService.java:
740 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
741 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
742 Added getReports(document, table, localeID), calling
743 ConfiguredDocument.getReports().
744 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
745 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
746 Added setReportsList() and a list widget.
747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
748 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
753 2012-04-12 Murray Cumming <murrayc@murrayc.com>
755 Translations: Add Esperanto.
757 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
758 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
759 properties: Add this translation because someone took the time to make it.
761 2012-03-15 Murray Cumming <murrayc@murrayc.com>
763 Adapt to the java-libglom 1.21.7 API.
765 * src/main/java/org/glom/web/server/ReportGenerator.java:
766 addToReport(): get_group_secondary_fields() is now
767 get_secondary_fields().
770 2012-03-15 Murray Cumming <murrayc@murrayc.com>
772 Use the latest java-libglom version.
774 * pom.xml: Use java-libglom 1.21.7.
776 2012-03-03 Ben Konrath <ben@bagu.org>
778 Display date and time in details view.
780 https://bugzilla.gnome.org/show_bug.cgi?id=671257
782 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
784 2012-03-05 Murray Cumming <murrayc@murrayc.com>
786 Require the latest java-libglom.
788 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
790 2012-03-04 Murray Cumming <murrayc@murrayc.com>
792 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
794 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
795 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
796 an empty quickfind string. I also corrected libglom to create only
797 empty where clauses for empty quickfind strings, but this avoids the
800 2012-02-24 Ben Konrath <ben@bagu.org>
802 Improve the tabs in the Notebook widget.
806 2012-01-30 Murray Cumming <murrayc@murrayc.com>
808 Translations: Try to translate the strings.
810 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
811 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
812 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
813 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
814 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
815 Take the Open translation from GTK+'s .po files.
816 Take the Details translation from Glom's po files.
817 I have added the other strings to Glom so we can get translations that way:
818 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
820 2012-01-27 Murray Cumming <murrayc@murrayc.com>
822 TableSelectionViewImpl: Put the search label and entry in a div.
824 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
825 Put the search widgets in a FlowTable so that the CSS can be used to
826 style them while keeping them together.
827 * src/main/webapp/style.css: Mention the new div.
829 2012-01-27 Murray Cumming <murrayc@murrayc.com>
831 Translate more strings in more locales.
833 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
834 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
835 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
836 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
837 Translate the "Details" and "Open" string too.
839 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
840 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
841 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
842 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
843 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
844 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
845 Add these new locales as placeholders though they currently contain English.
847 2012-01-27 Murray Cumming <murrayc@murrayc.com>
849 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
852 Check the ConfiguredDocument* for null before using it.
854 2012-01-26 Murray Cumming <murrayc@murrayc.com>
856 Tell Eclipse about the generated java files.
858 * .classpath: This lets it find OnlineGlomConstants.java.
859 It would be nice if Eclipse just used the maven build files.
861 2012-01-26 Murray Cumming <murrayc@murrayc.com>
863 Prevent a crash when no locale is specified in the URL.
865 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
866 Avoid returning a null string, obtained from
867 Window.Location.getParameter(). This caused a crash when it was
868 later passed to libglom's API.
869 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
870 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
871 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
872 guard against future null strings.
874 2012-01-26 Murray Cumming <murrayc@murrayc.com>
876 Use the ?locale= query param instead of the &lang= token param.
878 * src/main/java/org/glom/web/client/place/ListPlace.java
879 * src/main/java/org/glom/web/client/place/DetailsPlace.java
880 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
881 Remove the lang token key and value.
883 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
884 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
885 When the user selects a different locale from the chooser, use
886 Window.Location.assign() to change the URL, which then causes a reload.
888 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
889 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
890 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
891 * src/main/java/org/glom/web/client/activity/ListActivity.java
892 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
893 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
894 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
895 * src/main/java/org/glom/web/client/ui/ListView.java:
896 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
898 Remove localeID member variables and method/constructor parameters, instead
899 using Utils.getCurrentLocaleID() when we need a localID to pass to
902 2012-01-26 Murray Cumming <murrayc@murrayc.com>
904 Internationalize the UI strings.
906 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
907 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
908 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
909 because it is unused. Messages are apparently strings that can have
910 parameters, but we do not need that yet, so Contants will be enough for now.
911 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
912 to say that we support the en and de locales.
913 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
914 The original English strings.
915 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
916 Some German translations of the English strings.
917 The i18n goal then uses the .properties file to generate an
918 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
919 returns an implementation that returns the translated strings.
920 The documentation suggests putting these in src/java/*/client/, but it seems
921 best to put it in src/resources/*/client/.
922 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
923 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
924 instead of hard-coding them.
925 Note that we cannot import OnlineGlomConstants because it does not exist yet,
926 but that does not seem to stop the build, though it confuses Eclipse.
928 You can see the translated string by adding ?locale=de to the URL, like so:
929 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
931 2012-01-24 Murray Cumming <murrayc@murrayc.com>
933 Improve null/empty String checks.
935 * pom.xml: Add a dependency on commons-lang, to use
936 org.apache.commons.lang.StringUtils.
937 * src/main/java/org/glom/web/server/ConfiguredDocument.java
938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
939 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
940 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
941 Use StringUtils.isEmpty().
943 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
944 StringUtils class with a static isEmpty() function because we
945 cannot use org.apache.commons.lang.StringUtils in client-side
946 GWT code because it (apparently) cannot be compiled to javascript.
947 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
948 * src/main/java/org/glom/web/client/activity/ListActivity.java
949 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
950 * src/main/java/org/glom/web/client/place/DetailsPlace.java
951 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
952 * src/main/java/org/glom/web/client/place/ListPlace.java
953 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
954 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
955 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
956 * src/main/java/org/glom/web/client/ui/details/Group.java
957 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
958 our StringUtils.isEmpty() function.
960 2012-01-24 Murray Cumming <murrayc@murrayc.com>
962 Update to the latest java-libglom API.
964 * pom.xml: Require java-libglom 1.21.4.
965 * src/main/java/org/glom/web/server/ConfiguredDocument.java
966 getDocumentInfo(), getListViewLayoutGroup():
967 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
969 * src/main/java/org/glom/web/server/database/DBAccess.java
970 getFieldsToShowForSQLQueryAddGroup(),
971 getPrimaryKeyLayoutItemField(): Replace get_database_title()
972 with either get_database_title_original() or
973 get_database_title(localeID).
975 2012-01-24 Murray Cumming <murrayc@murrayc.com>
977 ConfiguredDocument: Avoid a null pointer exception.
979 * src/main/java/org/glom/web/server/ConfiguredDocument.java
980 Initialize localeID to "" to avoid returning a null String which
981 causes a crash in java-libglom's swing-generated code.
983 2012-01-23 Murray Cumming <murrayc@murrayc.com>
985 Some simple renaming.
987 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
988 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
989 for localeChooser. This seems more appropriate and is less ambiguous
990 particularly in the .css file.
992 2012-01-23 Murray Cumming <murrayc@murrayc.com>
994 ConfiguredDocument: Rename the localedID private member variable.
996 2012-01-23 Murray Cumming <murrayc@murrayc.com>
998 Adapt to the latest java-libglom API from git master.
1000 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1001 libglom now uses only Vector instead of List, which uses add() instead of
1004 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1006 ConfiguredDocument: Rename the localedID private member variable.
1008 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1010 Build a source tarball with mvn assembly:single
1012 * assembly.xml: Add this file.
1013 * pom.xml: Use the maven-assembly-plugin and tell it to use
1014 our assembly.xml file.
1016 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1018 OnlineGlomServiceImpl: Get .glom files recursively.
1020 * pom.xml: Depend on commons-io from org.apache.commons.
1021 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1022 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1023 files recursively, and with the easier filter for the extension.
1024 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1025 simplify that code too.
1027 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1029 README: Mention that you must install java-libglom packages separately.
1031 But then it works, because java-libglom is now in the central maven
1034 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1036 locales drop-down: Show the correct selected locale when the URL changes.
1038 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1039 .java: setPlace(): Move some code into fillView().
1041 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1043 locales drop-down: Do not lose the primary key.
1045 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1046 start(): onLocaleChange(): Pass the current primary key value,
1047 instead of an empty value.
1049 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1051 locales drop-down: Do not lose the drop-down selection.
1053 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1054 .java (TableSelectionActivity.fillView): Set the selected locale
1055 after changing the drop-down items (though we do not really need
1056 to change them just because the locale changes.)
1058 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1060 locales drop-down: Change the tables list when this changes.
1062 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1063 .java: TableSelectionActivity.start(): Move the async table titles
1064 retrieval into a private fillView() method and also call this when
1065 the chosen locale changes.
1066 Note that the document title is not actually translatable yet, but
1067 that is a problem that I should fix soon in libglom.
1069 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1071 Improve the placement of the locales drop-down.
1073 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1074 Put the title and locales drop-down in a div (gwt.FlowTable).
1075 * src/main/webapp/style.css: Add magic css properties to make this work.
1076 Also remove the left margin from the title so that it lines up with the
1079 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1081 locales selector: Show human-readable locale titles.
1083 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1084 getDocumentInfo(): Use java.util.Locale to show a real title of
1085 each locale, in the locale's own language.
1087 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1089 Add a language/locale selector drop-down.
1091 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1092 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1093 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1094 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1095 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1096 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1097 Add a ListBox to show the available locales. Add getLocaleSelector(),
1098 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1099 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1100 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1101 java: Add these classes.
1102 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1103 start(): Fill the locales ListBox. Handle its change event, firing a
1105 setPlace(): Show the selected locale as specified by the URL token.
1106 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1107 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1108 Handle LocaleChangeEvent, going to a new *Place with that locale.
1110 The placement of the ListBox is not pretty, and it currently uses the ID
1111 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1115 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1117 Search box: Show the search text from the URL token.
1119 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1120 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1121 Add setQuickFindText().
1122 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1123 .java: setPlace(): Store the queryText if the place is a ListPlace,
1124 and call TableSelectionView.setQuickFindText().
1126 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1128 Allow use of translations via, for instance, &lang=de in the URL.
1130 * pom.xml: Use the unstable java-libglom 1.21 version.
1132 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1133 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1135 init(): Instead of calling TranslatableItem.set_current_locale()
1136 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1137 However, this is only for default locales, which are not needed to
1138 change the locale in the URL.
1139 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1140 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1141 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1142 layout for a particular locale.
1143 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1144 Add get/setDefaultLocaleID().
1145 getDocumentInfo(), getListViewData(), getRelatedListData(),
1146 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1147 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1148 localeID parameter, so we can get the layout for a particular locale.
1150 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1151 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1152 * src/main/java/org/glom/web/client/place/ListPlace.java:
1153 Parse and construct a lang parameter too.
1155 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1156 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1157 passed to subsequent methods and constructors.
1158 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1159 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1160 Store the localeID from the *Place and pass it to other constructors
1161 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1163 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1164 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1165 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1166 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1167 * src/main/java/org/glom/web/client/ui/ListView.java:
1168 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1169 Take localeID parameters and pass them to subsequent constructors and
1170 methods, so that the layout is always retrieved for that locale.
1172 This is rather repetitive.
1174 Note that "" means the original (default) locale of the Glom document,
1175 which is usually English.
1177 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1179 Documents: Remove final keyword to fix startup configuration.
1181 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1182 final keywords on the private member variables because that breaks
1183 the startup, apparently (there are warnings) because it stops them
1184 from being serialized. I added these in the previous commit.
1186 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1188 Documents: Add some final keywords.
1190 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1193 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1195 OnlineGlomServiceImpl: Add to overview comments.
1197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1198 Note that this is where all the document are loaded. They are not
1199 loaded freshly for each page.
1201 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1205 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1206 Add a TextBox for the text of a quick find.
1207 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1209 setBackLink(): Add a String quickFind parameter.
1210 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1211 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1212 to the base interface, because that is how TableSelectionViewImpl is used.
1213 * src/main/webapp/style.css: Add style for the search box and its label.
1215 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1216 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1217 Add these files, based on the existing TableChangeEvent and
1218 TableChangeEventHandlers.
1219 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1220 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1221 a ListPlace() that the user should be taken to.
1222 * src/main/java/org/glom/web/client/activity/ListActivity.java
1223 start(): Handle it here too and adapt the TableChangeEvent handler to
1224 pass the extra "" quickFind parameter to ListPlace.
1225 * src/main/java/org/glom/web/client/place/ListPlace.java:
1226 Constructor: Take an extra String quickFind parameter and store it,
1227 returning it from a new getQuickFind() method.
1228 getToken(): Put the quickFind text in the URL token.
1229 getPlace(): Parse the quickFind text from the URL token.
1230 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1231 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1232 ListPlace constructor.
1233 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1234 .java: start(): Add a Change handler for the TableSelectionView's
1235 TextBox (via its base HasChangeHandlers interface), firing the new
1236 QuickFindChangeEvent.
1237 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1238 pass the extra "" quickFind parameter.
1240 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1241 setCellTable(): Add a String quickFind parameter and pass it to
1242 the ListViewTable() constructor.
1243 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1244 setCellTable() in the base interface, because that is how ListViewImpl
1247 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1248 Add a String quickFind member variable.
1249 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1250 Constructor: Add a String quickFind parameter, storing it in the
1251 base ListTable's member variable.
1252 onRangeChanged(): Pass quickFind to the
1253 OnlineGlomServiceAsync.getSortedListViewData() and
1254 OnlineGlomServiceAsync.getListViewData() methods.
1256 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1257 getListViewData(), getSortedListViewData(): Add a String quickFind
1258 parameter, passing it to ConfiguredDocument.getListViewData().
1259 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1260 Change getListViewData(), getSortedListViewData() in the base interface,
1261 because that is how OnlineGlomServiceImpl is used, via this:
1262 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1263 Change getListViewData(), getSortedListViewData() here too.
1264 This class can apparently be used to asynchronously call methods on
1265 OnlineGlomService, and GWT seems to implement that after recognizing
1266 just the *Async name convention and the extra AsyncCallback parameters.
1268 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1269 getListViewData(): Add a String quickFind parameter, and pass it to
1270 ListViewDBAccess.getData().
1271 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1272 getListData(): Add a String quickFind parameter and pass it to
1274 getSelectQuery(): Add a String quickFind parameter.
1275 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1276 getSelectQuery(): Add a String quickFind parameter and use it with
1277 Glom.get_find_where_clause_quick() to pass a where_clause to
1278 Glom.build_sql_select_with_where_clause(), to actually filter the
1280 getData(): Add a String quickFind parameter, passing it to getListData().
1281 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1282 va: getData(): Pass an empty string to getListData() for the
1283 quickFind parameter.
1285 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1287 ListTable: Minor change.
1289 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1290 createCellTable(): Make this protected instead of public.
1292 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1294 Many files: Use final for the parameters and use the @override attribute.
1296 2012-01-22 Ben Konrath <ben@bagu.org>
1298 Add anchor links for single line text that starts with http, ftp and www.
1302 2012-01-22 Ben Konrath <ben@bagu.org>
1304 Add ellipsis to single line text in details view.
1308 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1310 Remove all javadoc author tags.
1312 Because they are awkward and meaningless when many people touch
1314 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1316 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1318 Revert the COPYING.LESSER to COPYING rename.
1320 Apparently both should be there if it is LGPL.
1322 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1324 *View: Remove unused imports.
1326 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1327 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1328 * src/main/java/org/glom/web/client/ui/ListView.java:
1329 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1330 Remove unused imports, as suggested by Eclipse.
1332 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1334 Move the *View::Presenter types, and some API into one base View.
1336 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1337 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1338 * src/main/java/org/glom/web/client/ui/ListView.java:
1339 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1340 Presenter, setPresenter() and clear() into a shared base interface,
1341 to avoid the unnecessary duplicate Presenter types and to more clearly
1342 show how the *Views share the same structure, even if they are not
1343 used polymorphically.
1345 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1346 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1348 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1349 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1350 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1352 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1355 Feel free to revert this if there is a good reason for the duplicate
1358 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1360 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1362 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1363 a class member instead of a local variable in the method.
1364 This lets us use it to get the view instances, for use in tests.
1365 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1366 beforeOnlineGlom(): Test some more details of the initial view.
1367 Again, this is not very useful.
1369 To really test gwt-glom we will need to start a local postgresql
1370 instance with local data, like the Glom tests in C++.
1372 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1374 pom.xml: Mention the LGPL license.
1376 * pom.xml: Add a licenses section.
1377 * COPYING.LESSER: Move this to COPYING, which
1378 previously contained the GPL. But gwt-glom is all LGPL.
1380 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1382 Add project information to README and pom.xml.
1384 * README: Add a brief description and mention some mvn
1386 * pom.xml: This extra information shows up in mvn site
1389 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1391 Use the latest java-libglom version.
1393 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1395 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1397 GwtTestOnlineGlom: Test a little more.
1399 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1400 protected rather than private, as suggested by the gwt-test-utils
1402 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1403 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1404 Test the initial visibility of the panels.
1406 However, this is not a very useful test.
1407 And I wonder how we should generally test using this idea for an
1408 activity/places app like ours where the real changes happen implicitly
1409 based on the history token/URL.
1411 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1413 Slight modification to *Mapper comments.
1415 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1416 (DataActivityMapper)
1417 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1419 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1421 Remove comments mentioning GIN because they are just copied from
1422 the example code and are apparently not helpful:
1423 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1424 Also change the mention of a class that is only in the example code.
1426 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1428 GwtTestOnlineGlom test: Minor changes.
1430 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1431 Avoid the long qualified class name and modify the comment
1432 because it is now obvious to me that the mocked class is the only
1433 custom one created via GWT.create().
1435 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1437 Tests: Added the beginnings of a test using gwt-test-utils.
1439 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1440 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1441 which tells gwt-test-utils what class will be tested.
1442 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1443 Add a simple (but empty) test case. One class, used by the OnlineGlom
1444 class, is mocked so that it can be created. However, I am not sure
1445 why only this class needs to be mocked.
1447 Note that mockito seems more popular, and clearer, than easymock,
1448 but I have not got that working yet. It might be a matter of the
1451 This test is run during mvn integration-test.
1453 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1455 Tests: Use junit4-style syntax instead of junit3-style.
1457 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1458 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1459 * src/test/java/org/glom/web/shared/DataItemTest.java:
1460 Use the @Test annotation rather than relying on the test*() prefix.
1461 Also no longer implement TestCase, to avoid triggering support for
1462 the junit3-way, which stops the annotations from working.
1463 Change the imports from import junit.framework.* to
1464 import org.junit.*, which is apparently the new way.
1466 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1468 Added a test for ListPlace token parsing and creation.
1470 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1471 This is much the same as DetailsPlaceTest.
1473 I wonder how we could test the other parts of the *Place API.
1475 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1477 DetailsPlace test: Also test getToken() and recreation via getPlace().
1479 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1480 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1481 recreate it, testing the recreated DetailsPlace for the same parameter
1484 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1486 Use the surefire-report plugin.
1488 * pom.xml: This generates a HTML report about the tests in
1489 target/site/surefire-report.html
1490 when you do mvn surefire-report:report. It seems to be popular/normal.
1492 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1494 Added a test for DetailsPlace.
1496 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1497 Test the getPlace() token parsing.
1499 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1501 Added a first unit test.
1503 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1504 * src/test/java/org/glom/web/shared/DataItemTest.java:
1505 This is a silly test but it is just to get things started. Note that
1506 maven/junit finds the test because it looks in src/test by default.
1508 2011-12-22 Ben Konrath <ben@bagu.org>
1510 Change charsetName to "UTF-8" when replacing line breaks.
1512 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1513 that work in Java (such as "UTF8") will not work when compiled to
1516 This fixes a problem with multi-line details view fields that have hard
1517 line breaks. The "License Text" field on this page demonstrates the
1520 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1522 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1524 2011-12-22 Ben Konrath <ben@bagu.org>
1526 Fix another bug with related list navigation.
1528 I've tested all the navigation buttons in all of the related lists
1529 so things should be good now.
1531 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1533 2011-12-22 Ben Konrath <ben@bagu.org>
1535 Fix a crasher when refreshing the list view with the default table.
1537 This crash will also happen when loading the list view with the default
1538 table from a link or bookmark.
1540 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1541 to the main document selection page when the document id hasn't been
1543 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1544 the main document selection page when the document id hasn't been
1546 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1547 values for the details place when the document id hasn't been set.
1548 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1549 values for the list place when the document id hasn't been set.
1551 2011-12-21 Ben Konrath <ben@bagu.org>
1553 Protect against NPE when glom.document.locale is not in config.
1555 This patch protects against an NPE when glom.document.locale is not in
1556 the config file. This NPE will also happen if glom.document.locale is
1559 The patch also updates the error message to display the class name when
1560 the getMessage() returns null. This was happening when the NPE was
1561 thrown and I had "Configuration Error: null". If an NPE is encountered
1562 with this patch, "Configuration Error: NullPointerException " will be
1565 This commit closes this bug:
1567 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1571 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1573 Rename onlineglom.properties to onlineglom.properties.sample.
1575 * src/main/resources/onlineglom.properties: Rename to:
1576 * src/main/resources/onlineglom.properties.sample:
1577 * src/main/resources/README: And add this file explaining that people
1578 should rename it back when deploying.
1580 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1582 Allow choosing the translation in the .properties file.
1584 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1585 init(): Read a glom.document.locale value from the configuration file
1586 and call Glom's TransatableItem::set_current_locale() method.
1587 * src/main/resources/onlineglom.properties: Add a commented-out
1588 example of this new setting.
1590 It would be better to add &lang=de_DE to the URL, but the current
1591 libglom API does not allow us to do this easily. I am working on that.
1593 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1595 Avoid a crash in parsing of token parameters.
1597 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1598 ava: getTokenParams(): Do not crash if a parameter has a key but no
1599 value, and ignore parameters with neither.
1601 2011-12-17 Murray Cumming <murrayc@murayc.com>
1603 History token building/handling: Improve use of token parameters.
1605 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1606 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1607 and buildParamsToken(HashMap), for use by derived classes.
1608 Make the separator private because it is no longer be needed.
1609 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1610 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1611 instead of manual string concatenation.
1612 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1613 of hardcoded indices and awkward splitting code.
1614 * src/main/java/org/glom/web/client/place/ListPlace.java
1615 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1616 instead of manual string concatenation.
1617 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1618 of hardcoded indices and awkward splitting code.
1619 This should fix bug #666420
1621 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1623 Fix a Navgiation->Navigation typo in the code.
1625 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1626 Rename processNavgiation() to processNavigation().
1628 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1630 Fix a seperator->separator typo in the code.
1632 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1633 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1634 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1637 2011-12-15 Ben Konrath <ben@bagu.org>
1639 Cleanup some comments.
1641 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1643 2011-12-14 Ben Konrath <ben@bagu.org>
1645 Replace \n with <br/> for multiline text in the details view.
1647 Vertical scrollbars are added when needed as well.
1649 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1651 2011-12-14 Ben Konrath <ben@bagu.org>
1653 Specify the font for document selection links.
1655 * src/main/webapp/style.css:
1657 2011-12-14 Ben Konrath <ben@bagu.org>
1659 Fix bouncy CellTable while paging.
1661 This doesn't currently work with related list tables in unselected
1664 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1666 2011-12-14 Ben Konrath <ben@bagu.org>
1668 Revamp the appearance of the document selection page.
1670 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1671 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1672 * src/main/webapp/style.css:
1674 2011-12-13 Ben Konrath <ben@bagu.org>
1676 Set navigation button column to the smallest size possible.
1678 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1680 2011-12-13 Ben Konrath <ben@bagu.org>
1682 Change OpenButton nomenclature to NavigationButton.
1684 Using NavigtionButton makes things more generic. Classes, methods and
1685 variables have been changed.
1687 This is a rename-only refactor.
1689 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1690 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1691 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1692 Renamed from OpenButtonCell.
1693 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1694 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1695 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1697 2011-12-12 Ben Konrath <ben@bagu.org>
1699 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1701 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1702 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1703 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1704 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1706 2011-12-12 Ben Konrath <ben@bagu.org>
1708 Update variable names and comments.
1710 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1711 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1713 2011-12-12 Ben Konrath <ben@bagu.org>
1715 Properly initialize numNonEmptyRows variable to zero.
1717 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1718 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1720 2011-12-05 Ben Konrath <ben@bagu.org>
1722 Add latest mockup with HTML tables.
1724 Features of this mockup:
1726 -> HTML table for flowtable
1727 -> HTML table for flowtable column
1728 -> Example of how related lists would look
1729 -> Not using text entries for data items
1731 The current version of Online Glom doesn't use HTML tables for the
1734 This mockup has been sent to the glom-devel mailing list but it's good
1735 to have it here as well.
1737 * mockups/details-view-html-tables.html:
1739 2011-12-05 Ben Konrath <ben@bagu.org>
1741 Remove unnecessary getPrimaryKeyField() method.
1743 getPrimaryKeyFieldForTable(String) has been renamed to
1744 getPrimaryKeyField(String).
1746 * src/main/java/org/glom/web/server/database/DBAccess.java:
1747 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1748 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1750 2011-12-05 Ben Konrath <ben@bagu.org>
1752 Add string representation of TypedDataItem value to conversion error message.
1754 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1755 message was extracted into its own method to avoid duplication.
1757 2011-12-05 Ben Konrath <ben@bagu.org>
1759 Add type checking to navigation primary key value creation.
1761 Create navigation primary key only if the expected type from the Glom
1762 document matches the type returned by the SQL query.
1764 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1766 2011-12-05 Ben Konrath <ben@bagu.org>
1768 Rename a couple of variables in RelatedListNavigation.
1770 This is a rename-only refactor.
1772 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1774 2011-12-05 Ben Konrath <ben@bagu.org>
1776 Move getListLayoutGroup() into getListViewLayoutGroup().
1778 This removes getListLayoutGroup(). It was only being called by
1779 getListViewLayoutGroup().
1781 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1783 2011-12-05 Ben Konrath <ben@bagu.org>
1785 Remove check for LayoutItem_Portal in list table method.
1787 This check is no longer necessary because the method isn't being used
1788 to create the LayoutItemPortal DTO.
1790 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1792 2011-12-05 Ben Konrath <ben@bagu.org>
1794 Properly support related list navigation.
1796 Navigation from the "Repository Analyzer -> Package Scans ->
1797 Dependencies" related table wasn't working because the primary key for
1798 related tables wasn't being set properly. This commit fixes the
1801 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1802 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1803 doesn't set the primary key properly for related list tables.
1804 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1805 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1806 useful for getting the primary key for list view tables and for related
1808 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1809 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1810 Move code to set the primary key for the table from the abstract
1811 ListDBAccess class to ListViewDBAccess as it's only correct for list
1813 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1814 Properly add primary key to related list tables.
1816 2011-12-02 Ben Konrath <ben@bagu.org>
1818 Properly set the horizontal alignment of fields.
1820 This fix is for both the list tables and the details view.
1822 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1823 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1824 to set the horizontal alignment of fields.
1826 2011-12-02 Ben Konrath <ben@bagu.org>
1828 Display currency codes in the details view.
1830 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1832 2011-12-02 Ben Konrath <ben@bagu.org>
1834 Avoid duplicate JNI call.
1836 JNI is not as efficient as pure Java and this is an easy (and small)
1839 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1840 Use previously retrieved value for whereClauseToTableName instead of
1843 2011-12-02 Ben Konrath <ben@bagu.org>
1845 Rename a couple of variables in RelatedListNavigation.
1847 This is a rename-only refactor.
1849 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1851 2011-12-02 Ben Konrath <ben@bagu.org>
1853 Indicate clearly that a mismatched primary key type is a bug.
1855 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1856 warning to error. Add 'This is a bug.' to message.
1858 2011-12-02 Ben Konrath <ben@bagu.org>
1860 Update / fix some comments.
1862 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1864 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1866 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1867 Fix comments. Add some TODOs.
1869 2011-12-02 Ben Konrath <ben@bagu.org>
1871 Enable navigation to details view with string primary key from related list.
1873 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1874 Create a text primary key value when return type of result is
1875 java.sql.Types.VARCHAR.
1877 2011-12-02 Ben Konrath <ben@bagu.org>
1879 Use checkboxes for booleans in the details view.
1881 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1883 2011-12-01 Ben Konrath <ben@bagu.org>
1885 Improve performance of related list height calculation.
1887 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1888 Put code to calculate the expected height in a static initializer so
1889 that that it's only called once.
1891 2011-12-01 Ben Konrath <ben@bagu.org>
1893 Show related list tables in notebooks (again).
1895 Calculate the height of the related list tables so the Notebook can be
1896 set the correct height. The height of the related list table is also needed by
1897 FlowTable to be able decide how to create the layout.
1899 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1900 and set the Portal height based on the height of the related list
1901 table and the Portal container.
1902 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1903 Add method to calculate the height of the related list tables.
1904 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1905 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1906 calculate the height of the Pager widget.
1908 2011-12-01 Ben Konrath <ben@bagu.org>
1910 Use CellTable API for table property instead of setting style on Element.
1912 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1914 2011-12-01 Ben Konrath <ben@bagu.org>
1916 Make ListViewTable and RelatedListTable a consistent height.
1918 The tables are now a consistent height regardless of the contents of
1919 the table. A hidden button is added to empty rows to ensure that the
1920 height of these rows will match the height of rows with data.
1922 A navigation button column is now added to every table. The width of
1923 the navigation column is set to 0px when a RelatedListTable shouldn't
1924 have navigation buttons. This maintains the a consistent row height in
1925 tables that don't show the navigation buttons.
1927 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1928 navigation column when not needed.
1929 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1930 arguments for navigation button to constructor of ListViewTable.
1931 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1932 hidden button for empty data rows.
1933 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1934 arguments for navigation button to constructor.
1935 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1936 create navigation buttons. Add hideNavigationButtons() method.
1937 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1938 arguments for navigation button to constructor.
1940 2011-12-01 Ben Konrath <ben@bagu.org>
1942 Use 'visibility: hidden' in Utils.getWidgetHeight().
1944 This is better choice because hidden elements are invisible, don't
1945 respond to events and are not part of the tab order. They will,
1946 however, take up space which is required to be able to calculate the
1947 height of the widget.
1949 * src/main/java/org/glom/web/client/Utils.java:
1951 2011-12-01 Ben Konrath <ben@bagu.org>
1953 Use Utils.getWidgetHeight() in FlowTable.
1955 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1957 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1959 2011-12-01 Ben Konrath <ben@bagu.org>
1961 Put the details css class name on the correct table column.
1963 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1965 2011-11-30 Ben Konrath <ben@bagu.org>
1967 Update for java-libglom API change.
1969 The getters and setters on FieldFormatting and NumericFormat were
1970 changed to remove the 'M'.
1972 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1974 2011-11-29 Ben Konrath <ben@bagu.org>
1976 Only allow RelatedListTables in Portals.
1978 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1980 2011-11-29 Ben Konrath <ben@bagu.org>
1982 Only create a contents panel for Portals when title is being set.
1984 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1986 2011-11-29 Ben Konrath <ben@bagu.org>
1988 Set TabLayoutPanel height based on calculated height its widgets.
1990 This is a potential fix for this bug:
1992 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1994 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1996 2011-11-29 Ben Konrath <ben@bagu.org>
1998 Align details field labels and data with the Open buttons.
2000 * src/main/webapp/style.css:
2002 2011-11-29 Ben Konrath <ben@bagu.org>
2004 Remove unnecessary <div> in the Notebook widget.
2006 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2007 method to get container FlowPanel (<div>).
2008 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2009 initWidget() method directly on the TabLayoutPanel widget instead of
2010 Group's container widget.
2012 2011-11-29 Ben Konrath <ben@bagu.org>
2014 Don't add group titles for Portals in Notebooks.
2016 This reverts the previous patch and fixes a bug I introduced with
2017 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2019 * src/main/java/org/glom/web/client/ui/details/Group.java:
2020 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2022 2011-11-28 Ben Konrath <ben@bagu.org>
2024 Remove unused boolean argument in Portal constructor.
2026 Just a code cleanup.
2028 * src/main/java/org/glom/web/client/ui/details/Group.java:
2029 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2031 2011-11-28 Ben Konrath <ben@bagu.org>
2033 Remove hack for glom 1.18 style glom files.
2035 * src/main/java/org/glom/web/client/ui/details/Group.java:
2036 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2037 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2039 2011-11-28 Ben Konrath <ben@bagu.org>
2041 Use Gda Value version of primary key to log result too large error.
2043 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2045 2011-11-28 Ben Konrath <ben@bagu.org>
2047 Don't use TypedDataItem.getText() for Unknown types from the URL.
2049 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2050 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2051 instead of getText().
2052 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2053 String field and getUnknown() method.
2055 2011-11-28 Ben Konrath <ben@bagu.org>
2057 Log an error message when the java-libglom .so is not present.
2059 The error message was being set in the exception but not logged.
2061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2063 2011-11-28 Ben Konrath <ben@bagu.org>
2065 Ignore LayoutItem_CalendarPortals.
2067 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2068 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2070 2011-11-28 Ben Konrath <ben@bagu.org>
2072 Extract method for creating the LayoutItemPortal DTO.
2074 Just breaking the code up into smaller chunks.
2076 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2078 2011-11-28 Ben Konrath <ben@bagu.org>
2082 This should have been added with the refactor. Oops!
2084 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2086 2011-11-28 Ben Konrath <ben@bagu.org>
2088 Create primary key value from URL string using type from Glom document.
2090 See this bug, comments 19 - 25:
2092 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2094 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2095 create a TypeDataItem for the primary key here when loading from a
2096 URL. Show the same string for the primary key value as was received
2097 from the URL string (when loading from a URL).
2098 * src/main/java/org/glom/web/server/Utils.java: Update method for
2099 creating the Gda Value from the TypeDataItem to properly deal with
2100 creating a Gda Value based on the Glom document type for the primary
2101 key value string when loading from a URL.
2102 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2103 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2104 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2105 Update for changed method name.
2107 2011-11-27 Ben Konrath <ben@bagu.org>
2109 Rename PrimaryKeyItem to TypedDataItem.
2111 The name PrimaryKeyItem suggests what the class should be used for.
2112 TypedDataItem is a neutral name that describes the class better.
2114 This is a rename-only refactor.
2116 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2117 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2118 * src/main/java/org/glom/web/client/Utils.java:
2119 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2120 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2121 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2122 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2123 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2124 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2126 * src/main/java/org/glom/web/server/Utils.java:
2127 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2128 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2129 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2130 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2132 2011-11-25 Ben Konrath <ben@bagu.org>
2134 Improve Gda Value conversion from PrimaryKeyItem.
2136 The value from the PrimaryKeyItem is only used if its type match the
2137 type from the glom document.
2139 * src/main/java/org/glom/web/server/Utils.java:
2141 2011-11-25 Ben Konrath <ben@bagu.org>
2143 Manually check if the java-liblgom .so is visible to the JVM.
2145 It seems that Tomcat has problems when a static initializer throws an
2146 exception. This check is done before the first method call into
2147 java-libglom so that execution doesn't continue if the .so is not
2150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2152 2011-11-25 Ben Konrath <ben@bagu.org>
2154 Improve browser configuration error messages.
2158 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2160 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2161 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2162 getConfigurationErrorMessage() method.
2163 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2164 Get and display a specific configuration error message when no Glom
2165 documents are found.
2166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2167 Implement getConfigurationErrorMessage() method. Surround configuration
2168 code in the init() method with a try/catch block. This allows the
2169 errors to be caught while keeping the servlet available to retrieve the
2170 configuration error message.
2172 2011-11-25 Ben Konrath <ben@bagu.org>
2174 Don't use Strings to hold primary key values.
2176 The primary key values are now held in a new data object
2177 (PrimaryKeyItem) that holds type information and the primary key value
2178 using the correct type.
2180 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2181 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2183 PrimaryKeyItem instead of String to hold the primary key value.
2184 * src/main/java/org/glom/web/client/Utils.java: Remove
2185 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2186 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2187 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2188 PrimaryKeyItem instead of String to hold the primary key value. Load
2189 document selection page when the documentID has not been set correctly.
2190 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2191 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2193 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2194 Return empty string for URL instead of "null".
2195 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2196 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2197 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2198 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2199 PrimaryKeyItem instead of String to hold primary key values.
2200 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2201 PrimaryKeyValue to a Gda Value.
2202 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2203 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2204 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2205 Replace temporary database access code that uses the PrimaryKeyValue to
2206 Gda Value conversion.
2207 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2208 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2209 PrimaryKeyItem instead of String.
2210 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2211 hold primary key values.
2213 2011-11-24 Ben Konrath <ben@bagu.org>
2215 Use newly added java-libglom API to create queries.
2217 This isn't finished. I still need to stop using Strings for primary key
2218 values in the client code.
2220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2221 libglom to use fake connections so that retrieving the query string will
2223 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2224 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2225 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2226 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2227 Use the newly added libglom sql methods and classes to create the
2228 query. Add temporary hack to convert primary value strings to Gda
2231 2011-11-23 Ben Konrath <ben@bagu.org>
2233 Don't explicitly set the height of Portals.
2235 See comments 6 - 10 of this bug for details:
2237 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2239 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2241 2011-11-23 Ben Konrath <ben@bagu.org>
2243 Use an HTML table instead of CSS for the FlowTable layout.
2245 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2246 GWT's FlexTable to implement the FlowTable.
2247 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2249 2011-11-18 Ben Konrath <ben@bagu.org>
2251 Add boolean example to HTML table mockup.
2253 * mockups/details-view-html-tables-text-entries.html:
2255 2011-11-17 Ben Konrath <ben@bagu.org>
2257 Ensure the pager buttons are always visible for related lists.
2259 To accomplish this, I've turned off text wrapping in the list view and
2260 related list tables for both the header and data text. The related list
2261 table now has a fixed layout so the it doesn't overflow its container.
2262 This is required to ensure that the cell text is clipped when it
2263 overflows the cell and an ellipsis is added to the right side of the
2264 cell when text is clipped.
2266 A fixed table layout for the related list table in the details view
2267 seems what we want for the details view anyway, so the side-effect is
2270 The ellipsis will only be displayed in Firefox >= 7.
2274 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2276 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2277 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2278 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2280 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2281 Set the 'table-layout: fixed' CSS property to the related list table.
2282 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2283 'white-space: nowrap;' CSS property on both the list view and the
2284 related list tables.
2286 2011-11-16 Ben Konrath <ben@bagu.org>
2288 Rework the fix for empty notebook tab labels.
2290 Setting the empty group titles with its name caused problems for the
2291 details layout. Instead of using libglom's
2292 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2293 to the client when the title is empty. This allows the Notebook to use
2294 the name when the title is empty without affecting anything else.
2296 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2297 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2299 2011-11-16 Ben Konrath <ben@bagu.org>
2301 Set group titles with name when title is empty.
2303 This fixes a problem with an empty notebook tab label in the Lesson
2304 Planner document. The forth tab in the notebook should be "Internet":
2306 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2308 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2309 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2312 2011-11-16 Ben Konrath <ben@bagu.org>
2314 Remove whitespace from the configured username properties.
2316 This assumes that usernames won't have whitespace at the beginning
2317 or end. But I think this is a reasonable assumption.
2319 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2320 String.trim() to remove the whitespace from the username properties.
2322 2011-11-15 Ben Konrath <ben@bagu.org>
2324 Add details view mockup with HTML tables and text entries.
2326 This is from the attachment on this bug:
2328 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2330 * mockups/details-view-html-tables-text-entries.html:
2332 2011-11-15 Ben Konrath <ben@bagu.org>
2334 Add space between the columns of the flow table.
2338 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2340 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2341 space between columns in the flow table.
2343 2011-11-15 Ben Konrath <ben@bagu.org>
2345 Add backup files to the .gitignore.
2347 * .gitignore: Ignore files that end with ~.
2349 2011-11-09 Ben Konrath <ben@bagu.org>
2351 Use latest release of gwt-log.
2353 Gwt-log releases are now being submitted to the maven central
2354 repository so manual installation of the jar is no longer required.
2356 * pom.xml: Update version and groupId of gwt-log dependency.
2358 2011-10-31 Ben Konrath <ben@bagu.org>
2360 Don't use GWT numeric formatting to override the glom currency formatting.
2362 Currencies are now displayed like they are in Glom. See this bug:
2364 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2366 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2368 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2369 currency code to constructor and set it when the cell is rendered.
2370 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2371 currency code to the constructor of the NumericCell.
2373 2011-10-27 Ben Konrath <ben@bagu.org>
2375 Require the latest release of java-libglom (1.17.4).
2379 2011-10-26 Ben Konrath <ben@bagu.org>
2381 Add style to Notebook that matches current theme.
2383 It's not the best style in the world but it's better than the default.
2385 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2386 padding at the bottom of the child widgets.
2387 * src/main/webapp/style.css: Add style for the Notebook.
2389 2011-10-26 Ben Konrath <ben@bagu.org>
2391 Move servlet initialization code to overridden init method.
2393 This is half of the solution to getting proper error messages
2394 displayed when configuration errors occur. Here's the relevant bug:
2396 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2398 The rest of the solution involves surrounding the init method with a
2399 try/catch block and setting a global variable with the error /
2400 exception. A new async method should be created to retrieve and display
2401 the error message / exception.
2403 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2404 code from constructor to init method adding exceptions as needed.
2406 2011-10-26 Ben Konrath <ben@bagu.org>
2408 Add script to monitor and restart tomcat if required.
2410 * utils/check-and-recover-tomcat.py: New file.
2412 2011-10-26 Ben Konrath <ben@bagu.org>
2414 Display the correct number of data items in the pager.
2418 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2420 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2421 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2422 The implementation is the same for both tables: Keep track of the
2423 number of non-empty rows and fire and RowCountChangeEvent after the data has
2425 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2426 custom Pager class that subclasses SimplePager to handle displaying
2427 the correct number when empty rows have been added.
2429 2011-10-26 Ben Konrath <ben@bagu.org>
2431 Correct error in previous commit.
2433 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2434 eventBus parameter from listView.setCellTable().
2436 2011-10-26 Ben Konrath <ben@bagu.org>
2438 Fix error in TODO comment.
2440 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2442 2011-10-24 Ben Konrath <ben@bagu.org>
2444 Create Notebook widgets to the details view.
2446 This isn't finished just yet - I still need to create a reasonable
2447 style to match the current theme.
2449 * src/main/java/org/glom/web/client/Utils.java: Add method for
2450 calculating the height of a widget. This is used in the Notebook class.
2451 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2452 new constructor method in Group.
2453 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2454 method for creating child widget that can be used by subclasses
2455 like Notebook. New constructor that allows disabling the group
2456 titles - Notebooks don't set a group title for their child groups.
2457 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2458 to make Notebooks using GWT's TabLayoutPanel.
2459 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2460 constructor that allows disabling the group titles.
2461 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2462 LayoutItemNotebook DTO.
2463 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2464 DTO for Notebooks. It's just an empty class for now but we might need
2465 it to transfer some specific information in the future.
2467 2011-10-21 Ben Konrath <ben@bagu.org>
2469 Add navigation buttons to related list tables.
2471 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2472 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2474 method getSuitableRecordToViewDetails() for getting the table name
2475 and primary key value for related list navigation buttons.
2476 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2477 private cell renderer class to get the navigation information for
2478 related list tables from the server. Extract the navigation
2479 processing code from the details cell navigation and use it for the
2480 related list navigation as well.
2481 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2482 cell renderer class for the details open buttons. This was needed
2483 because the related list navigation buttons and the list view
2484 navigation buttons need to react differently when clicked.
2485 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2486 the onEnterKeyDown() method because it's now overriden in the
2487 subclasses that are specific to the related list tables and the list
2489 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2490 the vertical size a little because the buttons add a bit of vertical
2491 space to table. This is not a perfect solution because the vertical
2492 size of with table fewer than 5 rows will be a little smaller.
2493 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2494 changes in how navigation buttons are handled.
2495 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2496 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2497 database access object.
2498 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2499 to find the portal for a given relationship name from
2500 RelatedListDBAccess. Add method to find a primary key field for a
2502 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2503 Move code to find the portal for a given relationship name to
2505 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2506 New file: database access object for getting the related list
2507 navigation information (the table name and the primary key value).
2508 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2509 DTO for transferring a table name to navigate to and a primary key
2511 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2512 boolean and getter/setter to specifies if the related list should add
2515 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2517 Use the master branch of java-libglom
2519 * pom.xml: Depend on java-libglom 1.19 instead.
2521 This is the master branch. See also the libglom-1-18 branch.
2523 2011-10-11 Ben Konrath <ben@bagu.org>
2525 Enable the open navigation button when the data has been set.
2527 This avoids having active buttons that don't do anything when the data
2530 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2532 2011-10-11 Ben Konrath <ben@bagu.org>
2534 Use IsWidget interface for FlowTableItem.
2536 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2537 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2539 2011-10-11 Ben Konrath <ben@bagu.org>
2541 Remove GWT styling from open button in details view.
2543 There are still some issues with how the details cell is arranged but
2544 this should be made to match Glom 1.20. I'm going to leave fixing this
2545 until I have Glom 1.20 up and running.
2547 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2548 style name on open button.
2549 * src/main/webapp/style.css: Move and edit details-navigation class.
2550 Re-arrange some classes to make them appear in the same order as the
2553 2011-10-07 Ben Konrath <ben@bagu.org>
2555 Update to GWT 2.4.0.
2557 * .gitignore: Ignore new cache directory.
2558 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2559 * pom.xml: Change GWT and maven plugin to 2.4.0.
2560 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2562 * src/main/java/org/glom/web/client/ClientFactory.java:
2563 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2564 * src/main/java/org/glom/web/client/OnlineGlom.java:
2565 Update source for API changes.
2566 * utils/build-onlineglom-war.sh: Remove cache directory before the
2569 2011-10-07 Ben Konrath <ben@bagu.org>
2571 Add navigation buttons in the details view.
2573 This isn't finished but I thought I'd commit what I have as it's a
2574 pretty good start. I still need to:
2576 1. Change the style so that it fits better into the current theme
2577 2. Adjust the details cell to expand as much as possible.
2579 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2580 click handlers to navigation buttons in the DetailsCells. Create a
2581 refreshData() method to get just the data from the server without the
2583 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2584 Update the tableSelector and browser title when the table name
2585 changes without using the tableSelector.
2586 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2587 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2588 getDetailsCells() to getCells(). Update variable names.
2589 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2590 method to set click handler on navigation button. Rename a few
2591 variables. Add navigation buttons where needed.
2592 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2593 variables and methods.
2594 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2595 navigation boolean and navigation table as required in the
2596 LayoutItemField DTO.
2597 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2598 variables for navigation along with getter/setter methods.
2600 2011-10-07 Ben Konrath <ben@bagu.org>
2602 Rename Field to DetailsCell.
2604 This is a refactor-only commit. No functionality has been added or
2607 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2608 Update variable and method names.
2609 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2610 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2611 variable and method names.
2612 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2614 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2615 variable and method names.
2617 2011-10-07 Ben Konrath <ben@bagu.org>
2619 Create separate methods for layout and data the details view.
2621 This is a refactor-only commit. No functionality has been added or
2624 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2625 private methods: setData(), createLayout().
2627 2011-10-07 Ben Konrath <ben@bagu.org>
2629 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2631 This is part of a change to get navigation buttons in the details view
2632 but it should have been done this way from the start.
2634 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2635 for method name change in TableSelectionView.
2636 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2637 Create TableChangeEvent and set the browser title using the
2638 TableSelectionView API.
2639 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2640 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2641 Change getSelectedTable() to getSelectedTableName(). Add
2642 getSelectedTableTitle().
2644 2011-10-07 Ben Konrath <ben@bagu.org>
2646 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2648 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2650 2011-10-07 Ben Konrath <ben@bagu.org>
2652 Update TableChangeEvent to use newTableName naming convention.
2654 This makes the class more consistent with GWT naming conventions.
2656 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2657 Update for method name change in TableChangeEvent.
2658 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2659 for method name change in TableChangeEvent.
2660 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2661 newTableName variable and getter method. Make toDebugString()
2664 2011-09-30 Ben Konrath <ben@bagu.org>
2666 Disable the pager in the list tables when the data row count is less than the minimum.
2668 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2669 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2671 2011-09-30 Ben Konrath <ben@bagu.org>
2673 Add empty rows to the end of related list and list view tables.
2675 I also extracted the cell rendering classes from the ListTable because
2676 the code was becoming a little crazy with all the anonymous inner
2677 classes. My plan is to use these cell rendering classes in the details
2678 view as well so this refactor will be needed for that change.
2680 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2681 set the row count in related list tables if the data has more rows
2682 than the minimum number of rows visible.
2683 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2684 row count in list view tables if the data has more rows than the
2685 minimum number of rows visible.
2686 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2687 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2689 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2690 for rendering TYPE_NUMERIC cells. The code was extracted from the
2692 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2693 class for rendering cells with buttons in list views. The code was
2694 extracted from the ListTable class.
2695 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2696 for rendering TYPE_TEXT cells. The code was extracted from the
2698 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2699 Add empty rows to the end of the data if required. Implement
2700 ListTable.getMinNumVisibleRows().
2701 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2702 cell renderer code to public classes. Return null in
2703 Column.getValue() for empty rows. Add new abstract method:
2704 getMinNumVisibleRows(). Move code to set the row count of the list view
2705 table to ListViewImpl.
2706 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2707 empty rows to the end of the data if required. Implement
2708 ListTable.getMinNumVisibleRows().
2711 2011-09-27 Ben Konrath <ben@bagu.org>
2713 Use GWT.log for client-side debugging statements.
2715 These are optimized out when deployed so I should have used this method
2716 in the first place. These statements will eventually be replaced with some sort
2717 of notification in the browser.
2719 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2720 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2721 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2722 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2723 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2725 2011-09-27 Ben Konrath <ben@bagu.org>
2727 Put tableselector on the right, back to list link on right.
2729 The idea is that the table selector is acting like a label for the
2730 currently displayed table so it should be placed below the document title. This
2731 puts the table title in a similar position to where it is in Glom.
2733 * mockups/details-contacts.html:
2734 * mockups/details-projects.html:
2735 * mockups/listview-contacts.html:
2736 * mockups/listview-projects.html:
2737 * mockups/style.css:
2738 Update mockups to match how the interfaces currently look.
2739 * src/main/webapp/style.css: Swap positions of backlink with the table
2740 selector. Add some space on the left side of the table selector to
2741 line things up with the document title.
2743 2011-09-27 Ben Konrath <ben@bagu.org>
2745 Add field colouring to details view.
2747 This change re-works how field colouring works. The colour formatting
2748 information is now set to the client with the layout information instead of
2749 with the data. This eliminates the need to send the same colour strings for
2750 data in list view column when colour information is set.
2752 In order to set an alternate colour for negative numeric values, the
2753 number is now sent to client and formatted with the GWT NumberFormat class.
2755 This change also fixes:
2757 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2759 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2760 internationalization framework which is needed for client side numeric
2762 * src/main/java/org/glom/web/client/Utils.java: New file for some
2763 client static utility methods.
2764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2765 the DataItem object to the Field class. Use a utility method to
2766 create the foreignKeyValue string.
2767 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2768 alignment and text colours in the constructor. Add setData(DataItem)
2769 method. Remove setText(String) method.
2770 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2771 colour information to GlomTextCell. Create and use GlomNumberCell for
2772 rendering numbers. Use utility method to get the string for the
2773 primary key of the key provider. Re-work how the horizontal alignment
2775 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2776 formatting to layout information. Methods for converting the libglom
2777 formatting information were moved from DBAccess.
2778 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2779 numeric formatting (it's now done on the client side). Don't set text
2780 colours in DataItem. Move libglom formatting conversion methods to
2782 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2783 getters/setters for text colour information.
2784 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2785 for transferring the libglom NumericFormat information to the client.
2786 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2787 and getters/setters for: GlomNumericFormat, background colour and
2788 foreground colour strings.
2790 2011-09-26 Ben Konrath <ben@bagu.org>
2792 Simplify code that iterates through the LayoutGroup.
2794 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2796 2011-09-26 Ben Konrath <ben@bagu.org>
2798 Accept Eclipse formatting for OnlineGlomServiceAsync.
2800 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2802 2011-09-26 Ben Konrath <ben@bagu.org>
2804 Don't use the ListDBAccess classes to get the primary key layout information.
2806 This was causing a bug where the wrong index for the hidden primary key
2807 was being sent to the client.
2809 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2810 primary key while creating the LayoutGroup DTO. Create a
2811 LayoutItemField DTO for hidden primary keys. Don't use the
2812 RelatedListDBAccess because it was only used for getting the primary
2814 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2815 access modifier from public to protected for getPrimaryKeyField() and
2816 getPrimaryKeyLayoutItemField().
2817 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2818 abstract method getExpectedResultSize() because RelatedListDBAccess
2819 doesn't have enough info to implement it.
2820 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2821 Remove @Override for getExpectedResultSize().
2822 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2823 Remove method getExpectedResultSize().
2825 2011-09-23 Ben Konrath <ben@bagu.org>
2827 Log which layout (list or details) the ignored item is from.
2829 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2831 2011-09-23 Ben Konrath <ben@bagu.org>
2833 Remove annotations that turn off code formatting in DataItem.
2835 * src/main/java/org/glom/web/shared/DataItem.java:
2837 2011-09-23 Ben Konrath <ben@bagu.org>
2839 Rename GlomField to DataItem and update associated methods.
2841 This is a rename-only refactor. No functionality has been added or
2844 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2845 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2846 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2847 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2848 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2849 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2850 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2851 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2853 * src/main/java/org/glom/web/server/database/DBAccess.java:
2854 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2855 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2856 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2857 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2858 * src/main/java/org/glom/web/shared/DataItem.java:
2859 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2860 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2862 2011-09-23 Ben Konrath <ben@bagu.org>
2864 Rename GlomDocument to DocumentInfo and update associated methods.
2866 This is a rename-only refactor. No functionality has been added or
2869 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2870 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2871 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2872 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2873 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2874 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2875 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2877 2011-09-20 Ben Konrath <ben@bagu.org>
2879 Require java-libglom 1.17.3.
2881 This picks up the fix for the seg fault problem with the Scenes table
2882 in the Openismus Film Manager example.
2886 2011-09-20 Ben Konrath <ben@bagu.org>
2888 Change the way sort clause is added for primary key when no sort clause is requested.
2890 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2891 before the sort clause is created. When a sort clause is not requested, the
2892 sort clause is created by finding the primary key in the LayoutFieldVector
2895 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2897 2011-09-20 Ben Konrath <ben@bagu.org>
2899 Log error message if no documents are found in the configured directory.
2901 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2902 Extract the glom file extension string to a private static final class
2903 variable (mostly as syntactic sugar). Accept a minor formatting change.
2904 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2905 the example glom.document.directory configuration property to make it
2906 more clear that it can any directory, not just the home directory.
2908 2011-09-18 Ben Konrath <ben@bagu.org>
2910 Add related lists to details view.
2912 The related list table has support for paging and sorting just like the
2913 table in the list view.
2915 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2916 SQL queries for the related list tables.
2917 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2918 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2919 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2920 Rename getList methods to getListView and add comments. Remove
2921 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2922 it being unused. Add methods: getDetailsLayoutAndData(),
2923 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2924 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2925 Create the layout and set the data for the fields in one async call
2926 instead of two. Create related lists where appropriate.
2927 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2928 for method name changes in OnlineGlomService.
2929 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2930 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2931 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2933 * src/main/java/org/glom/web/client/ui/ListView.java:
2934 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2935 tableName from setCellTable(). Create a ListViewTable instead of
2937 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2938 represent a data field in the details view.
2939 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2940 from addDetailsCell() to Field class. Keep track of the Fields and
2941 Portals in the details view.
2942 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2943 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2944 and add a method to get it. Add method to set the contents of the
2946 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2947 New class for related list tables. This class has the data provider
2948 for the related list table.
2949 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2950 abstract class which is the base class for the ListViewTable and the
2952 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2953 New class for list view tables. This class has the data provider for
2954 the list view table.
2955 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2956 methods for related list tables. Add more information to the
2957 LayoutItemField and LayoutItemPortal DTOs.
2958 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2959 Remove debugging print statement.
2960 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2961 Remove debugging print statements. Add primary key field to SQL count
2963 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2964 Remove unnecessary LayoutFieldVector parameter from
2965 getResultSizeOfSQLQuery() method.
2966 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2967 New class for related list table database access.
2968 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2969 class that is a wrapper DTO for details view layout and data.
2970 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2971 new 'fromField' string to this DTO.
2972 * src/main/webapp/style.css: Remove bottom margin and override top
2975 2011-09-15 Ben Konrath <ben@bagu.org>
2977 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2979 This sets things up to make it easier to add the data retrieval for
2980 related lists (portals). No user noticeable changes were made with
2983 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2984 class has the code to retrieve the layouts and access the
2985 database using the new database helper classes.
2986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2987 Most of the functionality has been removed from this class. This
2988 class now represents the public interface for the client side
2989 code. It also deals with configuring the servlet and cleaning
2990 things up when the servlet is stopped.
2991 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2992 of static methods into this utility class.
2993 * src/main/java/org/glom/web/server/database/DBAccess.java:
2994 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2995 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2996 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2997 These classes have the database retrieval code. The class hierarchy
2998 has been setup to make it easy to reuse code for similar
3001 2011-09-06 Ben Konrath <ben@bagu.org>
3003 Create separate classes for list table code and the data provider.
3005 As part of this refactor, I also split up the code a bit to make it
3008 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3009 table code to two new classes (below).
3010 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3011 with code from ListViewImpl.
3012 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3013 New file with code from ListViewImpl.
3015 2011-09-06 Ben Konrath <ben@bagu.org>
3017 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3019 This fixes the LayoutItemPortal DTO to match the libglom layout object
3022 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3024 2011-09-01 Ben Konrath <ben@bagu.org>
3026 Set title of Portals in the Details View.
3028 * pom.xml: Bump required version of java-libglom to 1.17.1.
3029 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3030 widget creation to its own class. Add comments to constructor.
3031 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3032 The code is mostly from the Group class with the title now set.
3033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3034 title of Portal. Update some comments. Fix some code formatting.
3036 2011-09-01 Ben Konrath <ben@bagu.org>
3038 Remove TODO comment for the flow table column width.
3040 The flow table column width is working correctly and doesn't need to be
3041 changed. See this mailing list post for more info:
3043 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3045 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3047 2011-08-27 Ben Konrath <ben@bagu.org>
3049 Add document title (database name) to top of the browser page.
3051 I added the document title to the TableSelecitonView but that will
3052 change if / when we add a view that doesn't require table selection.
3054 * mockups/details-contacts.html:
3055 * mockups/details-projects.html:
3056 * mockups/listview-contacts.html:
3057 * mockups/listview-projects.html:
3058 * mockups/style.css: Add document title to mockups to keep things
3060 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3061 sizes to account for the document title.
3062 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3063 Set the document title when it has been retrieved from the server.
3064 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3065 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3066 and implement setDocumentTitle(String) method.
3067 * src/main/webapp/style.css: Add ID for document title style.
3069 2011-08-25 Ben Konrath <ben@bagu.org>
3071 Add NavigationType enum to LayoutItemPortal DTO.
3073 This is the start of adding support for Portals to the Details View.
3075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3076 LayoutItem_Portal.navigation_type enum from libglom to
3077 LayoutItemPortal.NavigationType enum.
3078 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3079 NavigationType enum, field for storing the NavigationType and getter
3082 2011-08-25 Ben Konrath <ben@bagu.org>
3084 Implement the flow table layout in the Details View.
3086 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3087 FlowTable to Group to account for the renamed class.
3088 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3089 File. This is a container widget that implements the Glom details view
3090 flow table behaviour.
3091 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3092 org/glom/web/client/ui/FlowTable.java.
3093 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3094 so that the size of the subgroups are a closer match to the size of
3095 the Glom subgroups. This makes the flowtable layout match the layout
3096 in Glom for the Music Collection example file.
3098 2011-08-16 Ben Konrath <ben@bagu.org>
3100 Create container element for LayoutItemPortal in Details View.
3102 This will help me develop the layout for the FlowTable.
3104 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3105 fieldPanel variable to detailsCell.
3107 2011-08-15 Ben Konrath <ben@bagu.org>
3109 Set the height of the data element in the Details View.
3111 I changed the InlineLabels (text in a span element) to Labels (text in
3112 a div element) so that I could set the height of the details-data
3113 elements instead of the details-cell parent elements. This allows the
3114 the details-data element to display the correct height if style is
3115 applied that shows the height.
3117 This change has the added benefit of allowing the order of the labels
3118 and data elements to be changed for right-to-left languages.
3120 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3121 InlineLabels to Labels.
3122 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3123 InlineLabels to Labels. Set the height of the data element.
3124 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3125 multiline text height in the Formatting DTO.
3126 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3127 for multiline height along with getter and setter methods.
3128 * src/main/webapp/style.css: Adjust style to account for the change
3129 from span elements to div elements in the details cell.
3131 2011-08-15 Ben Konrath <ben@bagu.org>
3133 Make the List View appearance match the mockups.
3135 It doesn't match exactly but it's much better than it was.
3137 * mockups/listview-contacts.html: Remove unused css classes.
3138 * mockups/listview-projects.html: Remove unused css classes.
3139 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3140 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3141 for mainPanel instead of VerticalPanel (table). Set style name on
3142 CellTable. Set style name on Details column. Right-align Details
3144 * src/main/webapp/style.css: Adjust properties to match the mockups.
3146 2011-08-12 Ben Konrath <ben@bagu.org>
3148 Add better support for subgroups in the details view.
3150 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3151 changed FlowTable constructor.
3152 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3153 support for subgroups and subgroup-titles.
3154 * src/main/webapp/style.css: Add CSS class for subgroups and
3157 2011-08-12 Ben Konrath <ben@bagu.org>
3159 Return the top level LayoutGroup title.
3161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3163 2011-08-11 Ben Konrath <ben@bagu.org>
3165 Make the TableSelector header match the mockup.
3167 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3168 the layout panel. Properly lineup the table selection header with
3169 the list and details view.
3170 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3171 margin around the details view.
3172 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3173 Rename listBox variable to tableSelector. Set id for the style sheet.
3174 Use a FlowPanel instead of a HorizontalPanel.
3175 * src/main/webapp/style.css: Add properties to make the TableSelector
3176 box match the mockups.
3178 2011-07-13 Ben Konrath <ben@bagu.org>
3180 Update install script for java-libglom version change.
3182 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3185 2011-07-13 Ben Konrath <ben@bagu.org>
3187 Add support sub-group in the details view.
3189 I also removed the code that special-cased the default details view
3192 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3194 I still have to make a proper flowtable.
3196 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3197 Don't special-case default details view layout.
3198 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3199 addLayoutField() as I'm going to use it.
3200 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3201 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3203 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3204 extracted from DetailsViewImpl.GroupPanel. Add support for
3206 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3207 column count when getting the details layout.
3209 2011-07-12 Ben Konrath <ben@bagu.org>
3211 Set browser title with database and table titles.
3213 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3214 Set the browser title when the table changes and when the activity
3216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3217 title when retrieving document info (the GlomDocument object).
3218 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3219 with getter and setter methods. Remove unused convenience constructor.
3220 Use default code formatting.
3222 2011-07-12 Ben Konrath <ben@bagu.org>
3224 Ignore LayoutItemPortals in the details view.
3226 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3229 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3230 LayoutItemPortal layout objects.
3231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3232 LayoutItemPortal objects when retrieving the details layout.
3233 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3234 file. This is an empty class and just used to get type information for
3237 2011-07-12 Ben Konrath <ben@bagu.org>
3239 Use java-libglom 1.17.0.
3243 2011-07-11 Ben Konrath <ben@bagu.org>
3245 Remove "Table:" label from table selector.
3247 This matches a recent change in the Glom UI.
3249 * mockups/details-contacts.html:
3250 * mockups/details-projects.html:
3251 * mockups/listview-contacts.html:
3252 * mockups/listview-projects.html: Remove the "Table:" label from the
3254 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3256 2011-07-11 Ben Konrath <ben@bagu.org>
3258 Add main groups to the details view.