1 2012-07-20 Murray Cumming <murrayc@murrayc.com>
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
6 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
7 Set the timeout here too.
9 2012-07-20 Murray Cumming <murrayc@murrayc.com>
11 tests: ConfiguredDocumentTest: Make this pass.
13 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
14 Disable tests that need a database connection.
16 2012-07-20 Murray Cumming <murrayc@murrayc.com>
18 Use Java 1.7 instead of Java 1.6.
20 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
21 to do this twice, at least for Eclipse.
22 This seems OK because it is the current version.
24 2012-07-20 Murray Cumming <murrayc@murrayc.com>
28 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
29 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
30 Avoid using a null Connection.
32 2012-07-20 Murray Cumming <murrayc@murrayc.com>
34 tests: Add a ConfiguredDocument test.
36 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
39 2012-07-20 Murray Cumming <murrayc@murrayc.com>
41 LayoutItemFIeld: getName(): Use the Field if it is set.
43 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
44 getName(): If the full field details have been set, return its name, so that
45 callers do not need to set the name separately.
46 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
47 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
48 so we can count the rows.
50 2012-07-20 Murray Cumming <murrayc@murrayc.com>
52 tests: SelfHoster: Test SqlUtils too.
54 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
55 Retrieve some data and check it too, as in the regular Glom
56 test_selfhosting_new_from_example.cc test.
57 * src/test/java/org/glom/web/server/SelfHoster.java:
58 createConnection(): Make this public.
60 2012-07-20 Murray Cumming <murrayc@murrayc.com>
62 tests: SelfHoster: createConnection(): Do not warn about expected failures.
64 Let the caller say if the connection is expected to fail, to avoid
65 irrelevant error output.
67 2012-07-20 Murray Cumming <murrayc@murrayc.com>
69 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
71 * src/test/java/org/glom/web/server/SelfHoster.java:
72 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
73 due to the inevitable need to retry the connection while the database server
76 2012-07-20 Murray Cumming <murrayc@murray.com>
78 tests: SelfHoster: createConnection(): Set a timeout.
80 * src/test/java/org/glom/web/server/SelfHoster.java:
81 createConnection(): Use setLoginTimeout() because it otherwise seems to take
82 ages to actually return when it fails.
84 2012-07-20 Murray Cumming <murrayc@murrayc.com>
86 tests: SelfHoster: selfHost(): Close the test connection.
88 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
89 When we check that the connection works, close the connection. This seems
90 to not be closed automatically otherwise.
92 2012-07-20 Murray Cumming <murrayc@murrayc.com>
94 Use slf4j-simple to see JDBC errors.
96 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
98 2012-07-19 Murray Cumming <murrayc@murrayc.com>
100 SelfHoster.discoverFirstFreePort(): Close the socket.
102 * src/test/java/org/glom/web/server/SelfHoster.java:
103 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
105 2012-07-19 Murray Cumming <murrayc@murrayc.com>
107 Avoid another code warning in Eclipse Juno.
109 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
110 Do instanceof checks on the FileUtils.listFiles() result and its
113 2012-07-13 Murray Cumming <murrayc@murrayc.com>
115 Avoid some code warnings in Eclipse Juno
117 * src/main/java/org/glom/web/server/libglom/Document.java:
118 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
119 * src/test/java/org/glom/web/server/SelfHoster.java
120 createTextFile(): Make sure that the FileOutputStream is closed.
122 2012-06-22 Murray Cumming <murrayc@murrayc.com>
124 Added OnlineGlomPropertiesTest.
126 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
127 Make sure we never return a null string.
128 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
129 Added tests of the OnlineGlomProperties API, using our sample file.
131 2012-06-20 Murray Cumming <murrayc@murrayc.com>
133 Make OnlineGlomProperties be a normal class.
135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
136 Move OnlineGlomProperties into its own file to be a regular class:
137 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
138 This makes testing simpler.
140 2012-06-15 Murray Cumming <murrayc@murrayc.com>
142 OnlineGlomServiceImpl.init(): Move some code into a new method.
144 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
145 Create addDocument().
147 2012-06-15 Murray Cumming <murrayc@murrayc.com>
149 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
152 OnlineGlomProperties.getKey(): Make this more robust by moving the
153 check for *.*.filename to here.
155 2012-06-15 Murray Cumming <murrayc@murrayc.com>
157 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
160 init(): Move knowledge of the config file format into the
161 OnlineGlomProperties inner class.
163 2012-06-15 Murray Cumming <murrayc@murrayc.com>
165 SelfHostExampleTest: Make sure we cleanup on failure.
167 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
168 the use of cleanup() to a tearDown() JUnit method.
170 2012-06-12 Murray Cumming <murrayc@murrayc.com>
172 ConfiguredDocument: Add a primary key to portals at least once.
174 * src/main/java/org/glom/web/server/ConfiguredDocument.java
175 updatePortalsExtras): Fix a typo so that we add the primary key
176 column at least once.
177 This is a fix for the previous commit:
178 ConfiguredDocument: Do not add a primary key to portals each time.
180 2012-06-08 Murray Cumming <murrayc@murrayc.com>
182 SelfHoster: Avoid some compiler warnings.
184 * src/test/java/org/glom/web/server/SelfHoster.java
185 executeCommandLineAndWait():
186 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
187 the now-unused streams for stdout and stderr from the command Processes.
188 These are not used because readln() hangs while waiting for a new line,
189 where there may be no next line. The commented out code is still there
190 to help us figure out how to do this properly.
192 2012-06-08 Murray Cumming <murrayc@murrayc.com>
194 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
196 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
197 Make this actually test the cloning again, though it is not very useful
198 now that we do not use the part that had a problem with cloning before.
200 2012-06-08 Murray Cumming <murrayc@murrayc.com>
202 SelfHoster: Keep trying pg_ctl after starting postgres.
204 * src/test/java/org/glom/web/server/SelfHoster.java
205 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
206 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
207 regular Glom. This seems mad but it seems to work because the first
208 command would fail if pg_ctl would eventually fail.
210 2012-06-08 Murray Cumming <murrayc@murrayc.com>
212 SelfHoster: Wait until the server is really ready.
214 * src/test/java/org/glom/web/server/SelfHoster.java
215 selfHost(): Attempt the connection after starting the server, retrying
216 a few times if necessary, so that the server is really ready already when
217 we return from this method.
218 The regular Glom code does this too because pg_ctl reports success too soon.
220 2012-06-08 Murray Cumming <murrayc@murrayc.com>
222 ConfiguredDocument: Do not add a primary key to portals each time.
224 * src/main/java/org/glom/web/server/ConfiguredDocument.java
225 updatePortalsExtras(): Only add an extra primary key field if there is
226 none, to avoid adding one each time we retrieve the details layout from the
228 This should fix bug #676986 (Ben Konrath)
230 2012-05-25 Murray Cumming <murrayc@murrayc.com>
232 Document.load(): Support version 7 documents.
234 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
235 database_title attribute if the title attribute is not there.
238 2012-05-24 Ben Konrath <ben@bagu.org>
240 Add configuration for auto-generating mvn:i18n from with Eclipse.
242 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
244 2012-05-24 Murray Cumming <murrayc@murrayc.com>
246 Update translations, adding French.
248 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
249 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
250 Add a French translation, using the translation from Glom.
252 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
253 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
254 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
255 Update these based on the translations from Glom.
257 2012-05-24 Murray Cumming <murrayc@murrayc.com>
259 SelfHoster: Add some debug println messages to help when things fail.
261 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
262 System.out.println() lines.
264 2012-05-23 Murray Cumming <murrayc@murrayc.com>
266 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
268 * src/test/java/org/glom/web/server/SelfHoster.java:
269 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
270 instance) instead of just /usr/bin (as on Fedora). Check the result when
273 2012-05-23 Murray Cumming <murrayc@murrayc.com>
275 Remove LayoutItemPortal.get/setNavigationTable().
277 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
278 Remove get/setNavigationTable(), which is only a cache, because it is not
279 used, and does not need to be used, because that decision should be made on
281 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
282 updatePortalsExtras():
283 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
284 getNavigationRecord():
285 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
288 2012-05-21 Murray Cumming <murrayc@murrayc.com>
290 Initial self-hosting for tests.
292 * pom.xml: Change the scope for log4j, to hopefully make it
293 available to the test code which uses it indirectly via jOOQ.
294 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
295 self-hosting, though we only use it for testing.
297 * src/main/java/org/glom/web/server/libglom/Document.java:
298 example rows: Use a map instead of a list for each row of values,
299 so we know what field they are for, instead of relying on the sequence
300 being correct. This is not very efficient, but it does not really need
302 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
303 testReadTableExampleRows(): Adapted.
305 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
306 that returns an Object, for generic use. Note that Object seems to be
307 the implicit base even of double.
308 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
309 for use in CREATE TABLE SQL queries.
310 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
311 to do self-hosting of PostgreSQL databases via its command-line
312 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
313 backends/postgres_self.cc. This is incomplete - it needs more
314 warnings about failures and it needs to clean up properly when things
316 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
317 test of this new class.
319 2012-05-21 Murray Cumming <murrayc@murrayc.com>
321 Document: loading example data: Handle exceptions.
323 * src/main/java/org/glom/web/server/libglom/Document.java:
324 DateFormat.parse() and Double.valueOf() can throw exceptions, though
325 Eclipse did not warn about that.
327 2012-05-20 Murray Cumming <murrayc@murrayc.com>
329 Document: load(), save(): Handle the example rows.
331 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
333 * src/main/java/org/glom/web/server/libglom/Document.java:
334 load(), save(): Load and save the example rows, though the date, time
335 and image types are not handled properly yet.
336 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
337 Add testReadTableExampleRows() just to check that something is read.
339 2012-05-20 Murray Cumming <murrayc@murrayc.com>
341 Document: Add save().
343 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
344 Added getTranslationsMap() for use while saving.
345 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
346 Adedd getUseDefaultFormatting() for use while saving.
347 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
348 and several private methods that it uses.
350 This will be useful while testing via self-hosting.
351 It is not complete, but should be complete enough for testing.
353 2012-05-17 Murray Cumming <murrayc@murrayc.com>
355 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
357 * src/main/java/org/glom/web/client/OnlineGlomService.java
358 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
359 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
360 Remove getSortedListViewData() and getSortedRelatedListData(), adding
361 the sort column index and ascending bool to the regular method.
362 Instead, a sort column index of -1 now means no sort.
363 This is less explicit, but it's fairly simple, reduces the amount of
364 code, and makes the OnlineGlomService API slightly smaller.
365 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
366 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
368 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
369 getListViewData(), getRelatedListData():
370 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
371 getListViewData(), getRelatedListData():
372 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
374 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
376 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
381 2012-05-16 Murray Cumming <murrayc@murrayc.com>
383 Use translations for top-level groups too.
385 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
386 updateTitlesForLocale(): Use the translation for the group
387 as well as for child items.
391 Just recompiled to fix a problem in the released .tar.gz file.
395 2012-05-15 Murray Cumming <murrayc@murrayc.com>
397 Corrections to navigation to related records.
399 * src/main/java/org/glom/web/client/OnlineGlomService.java:
400 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
401 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
402 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
403 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
404 relationship name, because the relationship name is not necessarily unique
406 TOOD: This is inefficient, because it passes the whole list of
407 child field items back to the server, but it is more correct, and happens
408 to fix a bug with the primary key being lost after a few navigations.
409 There is probably a chance to make this more efficient anyway in some
412 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
413 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
414 * src/main/java/org/glom/web/server/ConfiguredDocument.java
415 * src/main/java/org/glom/web/server/database/DBAccess.java
416 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
417 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
420 2012-05-15 Murray Cumming <murrayc@murrayc.com>
422 Fix the use of translations.
424 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
425 Add updateTitlesForLocale().
426 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
427 Call it to discard unwanted translations and to make getTitle() return
428 the wanted translation wihout the need for the client code to specify a locale.
429 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
430 getTitle(): Fallback to the original title, as libglom does.
432 2012-05-15 Murray Cumming <murrayc@murrayc.com>
434 Document: Correctly report the number of available translation locales.
436 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
437 the available locale IDs list.
438 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
439 testLocales: Test this.
441 2012-05-15 Murray Cumming <murrayc@murrayc.com>
443 SqlUtils: Use camelCase.
445 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
446 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
447 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
448 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
449 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
450 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
452 2012-05-15 Murray Cumming <murrayc@murrayc.com>
454 Use jOOQ's tableByName() and fieldByName.
456 * pom.xml: Use jOOQ 2.3.1 to get the new API.
457 * src/main/java/org/glom/web/server/SqlUtils.java:
458 build_sql_select_step_with_where_clause(), .createField(),
459 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
460 so we can get correct quoting and escaping. Thanks to Lukas Eder for
461 adding this, and other things, to jOOQ.
463 2012-05-15 Murray Cumming <murrayc@murrayc.com>
465 SqlUtils: Remove the Connection parameters.
467 * src/main/java/org/glom/web/server/SqlUtils.java:
468 build_sql_select_with_key(), build_sql_select_with_where_clause(),
469 createSelect(), build_sql_select_step_with_where_clause(),
470 build_sql_count_select_with_where_clause(),
471 build_sql_select_count_rows(): Remove the Connection parameter because
472 jOOQ does not actually need a connectionwhen it is just used to build
474 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
476 * src/main/java/org/glom/web/server/ReportGenerator.java:
478 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
480 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
481 Constructor, getListData(), getResultSizeOfSQLQuery():
482 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
483 getSelectQuery(), getCountQuery():
484 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
485 getSelectQuery(), getCountQuery():
486 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
487 getNavigationRecord(): Adapted.
489 2012-05-14 Murray Cumming <murrayc@murrayc.com>
493 * src/main/java/org/glom/web/server/SqlUtils.java:
494 get_find_where_clause_quick(): Use a comparison of
495 lowercase values, instead of a simple equals. Regular Glom
496 uses the PostgreSQL ILIKE operator but jOOQ does not
497 support that just yet, though it will soon.
499 2012-05-14 Murray Cumming <murrayc@murrayc.com>
501 TableToViewDetails: Use a real serialization ID.
503 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
504 Though this does not fix the serialization problem.
506 2012-05-12 Murray Cumming <murrayc@murrayc.com>
508 Added LayoutItemPortalDeepCloneTest.
510 2012-05-11 Murray Cumming <murrayc@murrayc.com>
512 Make navigation work again.
514 * src/main/java/org/glom/web/server/libglom/Document.java:
515 Add getLayoutItemFieldShouldHaveNavigation().
516 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
517 Replace get/setAddNavigation() with the partly-existing
518 get/setNavigationTableName(), with an empty string being no navigation,
519 because this is simpler. Use the new
520 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
522 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
523 Add updateFieldsExtras() and call setNavigationTableName in it.
524 getDetailsLayoutGroup(),
525 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
526 createLayout(): Adapted.
527 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
528 Constructor: Adapted.
530 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
531 Replace get/setAddNavigation() with get/setNavigation(), returning a
532 TableToViewDetails class with both the table name and UsesRelationship,
533 because both are need. The previous code used java-libglom's output
534 variable (strangely, via sharedptr) to return both, but we cannot really
536 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
537 getNavigationRecord(): Adapt. However, we cannot actually use the cache
538 here because it somehow gets set to null during deepCopy(). I must test this.
539 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
540 testGetSuitableTableToViewDetails(): Adapted.
542 TODO: Find out why deepClone() is not quite working.
544 2012-05-11 Murray Cumming <murrayc@murrayc.com>
546 DBAccess: Simplify the retrievel of full field details.
548 * src/main/java/org/glom/web/server/database/DBAccess.java
549 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
550 because the Document loading should have done this.
552 2012-05-11 Murray Cumming <murrayc@murrayc.com>
554 Document: Correct loading of doubly-related layout fields.
556 * src/main/java/org/glom/web/server/libglom/Document.java:
557 loadUsesRelationship(): Actually set the related relationship, instead
558 of only setting it if it's not found.
560 2012-05-09 Murray Cumming <murrayc@murrayc.com>
562 Replace all appearances of Colour with color.
564 Because US English is dominant.
566 2012-05-09 Murray Cumming <murrayc@murrayc.com>
568 Use colors in HTML format, solving a warning about an unused function.
570 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
571 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
572 Add *asHTMLColor() versions of methods.
573 TODO: However, we should create and cache the results on the server.
574 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
575 * src/main/java/org/glom/web/client/ui/list/ListTable.java
576 * src/main/java/org/glom/web/server/ConfiguredDocument.java
577 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
578 Use the asHTMLcolor() versions.
580 2012-05-09 Murray Cumming <murrayc@murrayc.com>
582 ListViewTable: Constructor: Take the table name as a parameter.
584 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
585 Constructor: Take the tableName, and set the member variable, because
587 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
588 setCellTable(): Pass the table name.
589 This makes navigation to non-default tables work again. I don't know
590 why it worked before in the master branch.
592 2012-05-07 Murray Cumming <murrayc@murrayc.com>
594 ConfiguredDocument: Restore correct addition of hidden primary key items.
596 * src/main/java/org/glom/web/client/ui/list/ListTable.java
597 (ListTable.createCellTable): Uncomment out the check for the hidden
599 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
600 add primary key items for top-level lists and portals, as before,
601 instead of adding them to each group.
602 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
603 Actually implement the extra methods such as setHiddenPrimaryKey() and
604 comment that these are used only for top-level list groups and in portals.
605 This strangeness suggests even more that this should not be squeezed
606 into the LayoutGroup class.
608 2012-05-07 Murray Cumming <murrayc@murrayc.com>
610 Fix Formatting loading.
612 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
613 getFormattingUsed(): Remove the duplicate Formatting member variable
614 in favour of the one from the base class.
615 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
616 Initialize a new Formatting instead of using null by default, so we
617 have some defaults, instead of having to initialize one later just to
618 get the same defaults. This also makes loading of formatting from the
619 document work, because that expected a non-null.
621 2012-05-07 Murray Cumming <murrayc@murrayc.com>
623 RelatedListTable: Make sure that the tableName is set.
625 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
626 Constructor: Take the tableName so it is available later. Otherwise,
627 the server assumes that we mean the default table and cannot find the
629 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
630 setData(): Pass the tableName to the RelatedListTable constructor.
632 2012-05-07 Murray Cumming <murrayc@murrayc.com>
636 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
637 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
638 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
640 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
642 * src/main/java/org/glom/web/server/database/DBAccess.java:
643 convertResultSetToDTO(), getPortal():
644 * src/main/java/org/glom/web/server/database/ListDBAccess.java
646 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
647 Add checks for null objects and out of range access, with log messages to
648 give hints so we can fix these properly.
650 2012-05-07 Murray Cumming <murrayc@murrayc.com>
652 Portals: some corrections.
654 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
656 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
657 constructor: Use getRelationshipNameUsed() instead of getName(), because
658 that is what is meant.
659 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
660 getFromField(): Fix a typo, to get the field name, not the table name.
661 * src/main/java/org/glom/web/server/database/DBAccess.java:
662 getPortal(): Fix a typo that stopped this from working.
664 2012-05-07 Murray Cumming <murrayc@murrayc.com>
666 LayoutItemPortal: Also override getTitleOriginal().
668 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
669 This lets the base getTitle() with no parameters work.
670 TODO: Test this properly.
672 2012-05-06 Murray Cumming <murrayc@murrayc.com>
674 LayoutItemPortal: getTitle*(): Use the relationship title.
676 2012-05-06 Murray Cumming <murrayc@murrayc.com>
678 LayoutItemField: Fix loading of custom titles.
680 * src/main/java/org/glom/web/server/libglom/Document.java
681 loadDataLayoutItemField(): The title, if any, instead of the field
682 title, is stored in a title_custom node. Load it from there.
683 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
685 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
686 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
687 getTitle*() overrides.
688 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
691 2012-05-06 Murray Cumming <murrayc@murrayc.com>
693 LayoutItemField: Fall back to field titles, so some are really shown.
695 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
696 Override getTitleOriginal() and getTitle(), as in java-libglom.
697 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
700 2012-05-06 Murray Cumming <murrayc@murrayc.com>
702 Correct use of setExpectedResultSize().
704 * src/main/java/org/glom/web/server/ConfiguredDocument.java
705 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
706 Use setExpectedResultSize only on top-level groups (for instance, the
707 list layout) or on child portals (in details views).
708 Use the correct table name for portals to avoid SQL errors.
709 Update the expected counts when returning cached layouts.
711 2012-05-06 Murray Cumming <murrayc@murrayc.com>
713 Document: Interpret no group column count as 1.
715 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
716 default, though we now check for this in the UI code anyway.
718 2012-05-06 Murray Cumming <murrayc@murrayc.com>
722 2012-05-06 Murray Cumming <murrayc@murrayc.com>
724 Translatable: Use Hashmap instead of Treemap because GWT supports it.
726 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
727 The use of Treemap lead to this error from async methods, with no
729 "The response could not be deserialized"
731 2012-05-06 Murray Cumming <murrayc@murrayc.com>
733 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
735 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
736 when using the Google -> GWT Compile, or
737 g toolbar button -> GWT Compile Project... feature in Eclipse.
739 2012-05-06 Murray Cumming <murrayc@murrayc.com>
741 ListTable.addColumn(): Protect against a null Formatting.
743 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
744 Create a default Formatting if it is null, because that is the simplest
747 2012-05-06 Murray Cumming <murrayc@murrayc.com>
749 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
751 * src/main/java/org/glom/web/server/ConfiguredDocument.java
752 updateLayoutGroup(): Check that the field is not null.
754 2012-05-06 Murray Cumming <murrayc@murrayc.com>
756 ListViewImpl: Protected against a bad cast error.
758 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
759 onEnterKeyDown(): Do not cast without an instanceof check.
761 2012-05-06 Murray Cumming <murrayc@murrayc.com>
763 ListTable: Protect against an out of range error.
765 * src/main/java/org/glom/web/client/ui/list/ListTable.java
766 createCellTable(): This is unlikely, but can happen while debugging.
768 2012-05-06 Murray Cumming <murrayc@murrayc.com>
770 AsyncMessage onFailure() callbacks: Log the exception message.
772 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
773 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
774 * src/main/java/org/glom/web/client/activity/ListActivity.java:
775 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
776 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
777 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
778 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
779 These are useful clues when something is wrong.
781 2012-05-06 Murray Cumming <murrayc@murrayc.com>
783 ConfiguredDocument: Avoid a null dereference.
785 * src/main/java/org/glom/web/server/ConfiguredDocument.java
786 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
787 details maps are created.
789 2012-05-06 Murray Cumming <murrayc@murrayc.com>
791 Document: Correct the port number parsing.
793 * src/main/java/org/glom/web/server/libglom/Document.java:
794 This lets us actually connect to the database and show the document.
796 2012-05-05 Murray Cumming <murrayc@murrayc.com>
800 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
801 user-interaction, asking us to load a temporary URL in a browser.s
802 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
803 which is apparently necessary for testing the service. See the comment.
804 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
805 Show the exception, if any. This is how I saw the 404 in the HTML in
808 2012-05-05 Murray Cumming <murrayc@murrayc.com>
810 DocumentTest: Move the .glom files into the resources directory.
812 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
813 URI via getResource().
815 2012-05-05 Murray Cumming <murrayc@murrayc.com>
817 Document: Remove the FieldIdentifies inner class.
819 * src/main/java/org/glom/web/server/libglom/Document.java: We only
820 use the Relationship (though the same function in libglom is maybe
821 used in other ways) and so this removes a compiler warning.
823 2012-05-05 Murray Cumming <murrayc@murrayc.com>
825 Document.load() Remove the error code parameter.
827 * src/main/java/org/glom/web/server/libglom/Document.java: load():
828 Remove the parameter. We do not set it yet and it could never have
829 worked as an output parameter (though maybe it did in java-libglom).
830 We could use an exception if we really want the failure reason.
831 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
833 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
834 setUp(), testGetSuitableTableToViewDetails(): Adapt.
836 2012-05-05 Murray Cumming <murrayc@murrayc.com>
838 Make some inner classes static.
840 * src/main/java/org/glom/web/server/ConfiguredDocument.java
841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
842 * src/main/java/org/glom/web/server/ReportGenerator.java
843 * src/main/java/org/glom/web/server/libglom/Document.java
844 Make all inner classes static that can be static.
846 2012-05-05 Murray Cumming <murrayc@murrayc.com>
848 OnlineGlomServiceImpl: Do not load and check for java-libglom.
850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
851 init(): We do not use java-libglom any more.
853 2012-05-05 Murray Cumming <murrayc@murrayc.com>
855 Remove mentions of java-libglom.
857 * README: Remove mention of java-libglom, because it no longer needed.
858 * utils/build-onlineglom-war.sh:
859 * utils/check-and-recover-tomcat.py:
860 * utils/install-onlineglom-war.sh: Remove these as they are no longer
861 useful. Building is now far easier, with no need for jhbuild.
863 2012-05-05 Murray Cumming <murrayc@murrayc.com>
865 Fix the build (mvn package)
867 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
868 (LayoutGroup): Make the LayoutItemList inner class static and protected.
869 Otherwise the GWT Java->Javascript compilation fails with just this
870 error, during mvn package or when attempting to view in a browser,
871 in the GWT developer mode in Eclipse.
873 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
874 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
875 [INFO] Compiling module org.glom.web.OnlineGlom
876 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
877 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
878 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
879 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
880 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
881 [INFO] [ERROR] Cannot proceed due to previous errors
883 It has taken me 2 days to find out what was causing that. After reducing
884 the code, the compiler eventually showed me the full error message.
886 2012-05-04 Murray Cumming <murrayc@murrayc.com>
888 ConfiguredDocument: Cache the cloned and stripped layouts.
890 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
891 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
892 layout in a map, so we can retrieve it again without rebuilding it.
894 2012-05-04 Murray Cumming <murrayc@murrayc.com>
896 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
898 2012-05-04 Murray Cumming <murrayc@murrayc.com>
900 libglom classes: Implement some auto-generated emthods.
902 2012-05-04 Murray Cumming <murrayc@murrayc.com>
904 Add GwtTestOnlineGlomService.
906 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
907 However, this (and the other GwtTest*) does not seem to run during
910 2012-05-04 Murray Cumming <murrayc@murrayc.com>
912 Remove use of unsupported features from client code.
914 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
915 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
916 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
917 Use our client version of StringUtils instead of the apache commons one.
919 However, the GWT Javascript compliation still fails.
921 2012-04-25 Murray Cumming <murrayc@murrayc.com>
923 Add a Field class and implement some loading of it in Document.
925 2012-04-25 Murray Cumming <murrayc@murrayc.com>
927 Initial Document loading implementation, instead of libglom.
929 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
930 and Translatable classes, and adapt the rest of the code to use them.
931 However, this is still missing Layout and Field classes and loading.
933 2012-04-24 Murray Cumming <murrayc@murrayc.com>
935 Use of jOOQ: Move Field creation into a utility method.
937 * src/main/java/org/glom/web/server/SqlUtils.java:
938 This lets us improve it more easily.
940 2012-04-24 Murray Cumming <murrayc@murrayc.com>
942 Use of jOOQ: Improve the code to COUNT a sub-select.
944 * src/main/java/org/glom/web/server/SqlUtils.java:
945 Move initial query creation into
946 build_sql_select_step_with_where_clause().
947 build_sql_select_count_rows(): Use the jOOQ API instead of
948 concatentating text, because a jOOQ Select*Step is a TableLike,
949 which is what from() takes.
951 2012-04-23 Murray Cumming <murrayc@murrayc.com>
953 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
955 * pom.xml: Depend on jooq.
956 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
957 methods with jOOQ, based on the C++ implementations in libglom,
958 with some changes to the logic required by jooQ.
959 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
961 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
962 * src/main/java/org/glom/web/server/ReportGenerator.java:
963 * src/main/java/org/glom/web/server/SqlUtils.java:
964 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
965 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
966 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
967 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
968 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
969 Adapt. In particular, the SqlUtils methods now need to take a Connection,
970 because jOOQ needs that, though it seems unnecessary.
972 This is not quite finished. Ideally jOOQ would help us to build
973 table_name.field_name names, quoting and escaping them properly.
974 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
976 2012-04-21 Murray Cumming <murrayc@murrayc.com>
978 Move use of Glom.build_sql*() into a new SqlUtils class.
980 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
981 to wrap Glom.build_sql*(). The parameter types are still Glom one,
982 but this will make it easier to start using something other than
983 libglom or SqlBuilder.
985 2012-04-21 Murray Cumming <murrayc@murrayc.com>
987 Update the project URL.
989 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
991 2012-04-21 Murray Cumming <murrayc@murrayc.com>
993 Main layout: Use a FlowTable instead of absolute positioning.
995 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
996 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
997 child panels/widgets must have an absolute position. But that is annoying, so
998 this adds a FlowTable and puts the child panels in there.
1000 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1002 GwtTestOnlineGlom: Comment out unused code.
1004 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1005 Eclipse has started to say that some code is unused.
1007 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1009 Update to the latest versions of dependencies.
1011 * pom.xml: Update version numbers of dependencies to the latest
1013 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1014 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1015 * src/main/java/org/glom/web/server/ReportGenerator.java:
1016 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1017 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1018 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1020 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1021 Modify the imports where necessary.
1023 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1025 Style: Remove overflow:hidden from searchbox
1027 * src/main/webapp/style.css: Because this pushes the Back To Link
1028 label/link on to the next row, which is then hidden due to the
1029 hard-coded (in ems) height.
1031 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1033 Remove some duplicate code.
1035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1036 getDocumentInfo(): This must have been duplicated during the merge from the
1041 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1043 Reports: Localize the waiting for report message.
1045 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1046 start(): Get the message from the contants.
1047 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1048 Add the string here.
1049 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1050 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1051 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1052 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1053 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1054 Update these files with the English text for newer strings for now.
1056 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1058 Reports: Show a message while waiting for the report.
1060 * src/main/java/org/glom/web/client/ui/ReportView.java
1061 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1062 Add setWaitingText(), to show a message saying that we are
1063 waiting for the report to be ready.
1064 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1065 start(): Call setWaitingText() before calling the async
1068 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1070 ReportGenerator: Specify date and time formats.
1072 * src/main/java/org/glom/web/server/ReportGenerator.java:
1073 createFieldValueElement(): Use the default (and localized)
1074 short formats, though we still need a way to show 4-digit
1075 years without providing the format for every locale.
1076 * src/main/java/org/glom/web/server/database/DBAccess.java:
1077 convertResultSetToDTO(): Use the short formats here too.
1079 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1081 ReportGenerator: Use the correct numeric formatting.
1083 * src/main/java/org/glom/web/server/ReportGenerator.java
1084 createFieldExpression(), createFieldValueElement(): Take the
1085 whole LayoutItem_Field instead of just the field name, so
1086 we have access to the formatting.
1087 createFieldValueElement(): Use JRTextField.setPattern() to
1088 specify the numeric formatting, with the help of a
1089 regular DecimalFormat.
1091 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1093 ReportGenerator: Avoid showing null for group by titles.
1095 * src/main/java/org/glom/web/server/ReportGenerator.java
1096 generateReport(): Use setBlankWhenNull() on the field title
1097 style too, because this is used for values in group by
1100 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1102 ReportGenerator: Add a colon to titles in vertical groups.
1104 * src/main/java/org/glom/web/server/ReportGenerator.java
1105 addFieldToDetailBandVertical(): Pass true for the withColon
1108 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1110 ReportGenerator: Simplify the code by using Position more.
1112 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1114 Reports: Support vertical groups, roughly.
1116 * src/main/java/org/glom/web/server/ReportGenerator.java:
1117 addToReport(): Rename to addGroupToReport() and, if necessary,
1118 call the new addVerticalGroupToReport() method.
1119 createFieldValueElement(): Let the caller specify the Y position
1122 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1124 Reports: Allow a second report to be shown.
1126 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1127 clear(): Do not remove the HTML widget, which broke the whole layout.
1129 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1131 Locales drop-down: Show that we use English by default.
1133 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1134 fillView(): When we use English, just because that is the default, when
1135 no locale is specified, show that in the Locales drop-down instead of
1136 just showing the first item.
1138 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1140 Unselect the Report/Locale/Table combo item when appropriate.
1142 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1143 setPlace(): clear reportName if this is not a ReportPlace.
1144 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1145 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1146 When the provided name is empty, unselect all items, so that none are
1147 indicated. This uses a for loop because I cannot find a single method
1150 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1152 Report: Give the user a way to get back to the list.
1154 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1155 start(), setPlace(): Show the Back To List link on reports, and also
1156 interpret selecting the empty report item as back to list.
1158 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1160 Really show the selected Report name.
1162 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1163 setPlace(): Store the reportName here, if it is that kind of Place.
1164 fillView(): Set the selected Report after filling the list of reports.
1165 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1166 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1167 null Strings, though we need some way to unselect all ListBox items
1170 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1172 ReportGenerator: Try to avoid some problems.
1174 * src/main/java/org/glom/web/server/ReportGenerator.java
1175 addField(): Try to avoid duplicates, and avoid using a null
1178 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1180 Reports: Use quickFind.
1182 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1183 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1185 getReportHTML(): Add a quickFind parameter.
1186 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1187 start(): Pass the quickFind parameter.
1188 * src/main/java/org/glom/web/server/ReportGenerator.java
1189 generateReport(): Take a quickFind parameter.
1191 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1193 ReportPlace: Actually use the report name.
1195 * src/main/java/org/glom/web/client/place/ReportPlace.java
1196 getPlace(): Do not assign the report name to the quickfind.
1198 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1200 Show java.library.path when complaining.
1202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1203 init(): When telling us to check java.library.path, show the
1206 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1208 ReportGenerator: Do not show nulls.
1210 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1212 ReportGenerator: Make the title font larger.
1214 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1216 ReportGenerator: Put field titles inside groups, if there are groups.
1218 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1220 ReportGenerator: Take the Report itself instead of the name and group.
1222 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1223 Remove getReportLayoutGroup().
1224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1225 getReportHTML(): Pass the report instead
1226 of its name and layout group.
1227 * src/main/java/org/glom/web/server/ReportGenerator.java
1228 generateReport(): Use the report object to use the title
1229 instead of the name.
1231 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1233 ReportGenerator: Remove designBand parameters.
1235 * src/main/java/org/glom/web/server/ReportGenerator.java:
1236 Make designBand a class member instead of passing it to all
1239 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1241 ReportGenerator: Add lines, a bit like in the desktop version.
1243 * src/main/java/org/glom/web/server/ReportGenerator.java
1244 addToReport(): Use JRDesignLine.
1246 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1248 ReportGenerator: Correct the title positions and use some bold style.
1250 * src/main/java/org/glom/web/server/ReportGenerator.java:
1251 Break the code up into reusable functions, correct the placement of
1252 titles, and use normal/bold styles as in the reports in the desktop
1255 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1257 ReportGenerator: Add a header band to show the field titles.
1259 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1260 getReportHTML(): Pass the localeId to the ReportGenerator
1262 * src/main/java/org/glom/web/server/ReportGenerator.java
1263 constructor: Take the localeID so we can get translated field
1265 generateReport(), addToReport(), addFieldToBand(): Add field
1266 titles in a column header band.
1268 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1270 Reports drop-down list: Some improvement.
1272 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1273 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1274 Adedd setSelectedReport(),
1275 setReportList(): Add a blank line so that the user can select the
1277 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1278 start(): Show the current report by calling setSelectedReport().
1279 This does not seem to work yet.
1281 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1283 DetailsActivity, ListActivity: Move some variables into a base class.
1285 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1286 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1287 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1288 the clientFactory, documentID, tableName and authenticationPopup into
1289 a base class, to avoid duplication.
1291 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1293 Translate the Reports label.
1295 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1296 Get the "Reports" label string from the constants.
1297 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1298 perties: Add Reports to the constants.
1300 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1302 Reports: Implement grouping.
1304 * src/main/java/org/glom/web/server/ReportGenerator.java:
1305 Handle LayoutItem_GroupBy items and try to do the right thing
1306 with JRDesignGroup. It seems to work.
1308 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1310 Actually show some data with JasperReports.
1312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1313 getReportHTML(): Move most code into a ReportGenerator class.
1314 * src/main/java/org/glom/web/server/ReportGenerator.java:
1315 Recurse into sub-groups, adding fields to the JasperDesign's details
1316 band. Note that we must set an arbitrary width and height, or it just
1317 will not show any data.
1319 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1321 Reports Chooser: Show the titles, not the names.
1323 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1324 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1325 and the names as the values.
1326 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1327 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1328 group now that we provide the report name, so it should always
1331 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1333 Depend on jasperreports.
1335 * pom.xml: Add the dependency. My plan is to use this on the
1338 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1340 Implement navigation to report places.
1342 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1343 start(): Do not bother to handle all events here.
1344 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1345 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1346 Added getSelectedReport().
1347 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1348 .java: start(): When handling a change to the reports chooser,
1349 call getSelectedReport() and goTo() its ReportPlace.
1350 * src/main/java/org/glom/web/client/ui/ReportView.java
1351 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1352 Added setReportHTML() which puts the html in a gwt HTML widget.
1353 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1354 getReportHTML(): Return "TODO" just to show that this works.
1356 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1358 Make ReportPlace usable.
1360 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1361 Mention ReportPlace.
1362 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1363 Correct the @prefix annotation.
1365 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1367 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1369 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1370 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1371 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1372 Change getReportLayout() to getReportHMTL() because we will not need to
1373 parse or render the report layout on the client side.
1374 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1375 getReportLayout(): Return the libglom LayoutGroup type because we will
1376 not need to convert to a shared type, because this will not be used on
1378 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1381 Note that there is still no implementation for this.
1384 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1386 Add a (empty) Report Place, View, and Activity.
1388 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1390 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1391 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1392 this into a superclass:
1393 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1394 and also use it as the base of this new ReportPlace:
1395 * src/main/java/org/glom/web/client/place/ReportPlace.java
1397 * src/main/java/org/glom/web/client/ui/ReportView.java
1398 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1399 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1400 Add these, containing mostly boiler-plate for now.
1402 * src/main/java/org/glom/web/client/OnlineGlomService.java
1403 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1404 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1405 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1406 Add API to get the LayoutGroup for the report.
1408 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1410 Add and fill a Reports drop-down list box.
1412 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1414 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1415 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1417 Added getReports(document, table, localeID), calling
1418 ConfiguredDocument.getReports().
1419 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1420 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1421 Added setReportsList() and a list widget.
1422 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1423 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1428 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1430 Translations: Add Esperanto.
1432 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1433 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1434 properties: Add this translation because someone took the time to make it.
1436 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1438 Adapt to the java-libglom 1.21.7 API.
1440 * src/main/java/org/glom/web/server/ReportGenerator.java:
1441 addToReport(): get_group_secondary_fields() is now
1442 get_secondary_fields().
1445 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1447 Use the latest java-libglom version.
1449 * pom.xml: Use java-libglom 1.21.7.
1451 2012-03-03 Ben Konrath <ben@bagu.org>
1453 Display date and time in details view.
1455 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1457 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1459 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1461 Require the latest java-libglom.
1463 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1465 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1467 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1469 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1470 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1471 an empty quickfind string. I also corrected libglom to create only
1472 empty where clauses for empty quickfind strings, but this avoids the
1475 2012-02-24 Ben Konrath <ben@bagu.org>
1477 Improve the tabs in the Notebook widget.
1481 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1483 Translations: Try to translate the strings.
1485 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1486 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1487 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1488 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1489 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1490 Take the Open translation from GTK+'s .po files.
1491 Take the Details translation from Glom's po files.
1492 I have added the other strings to Glom so we can get translations that way:
1493 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1495 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1497 TableSelectionViewImpl: Put the search label and entry in a div.
1499 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1500 Put the search widgets in a FlowTable so that the CSS can be used to
1501 style them while keeping them together.
1502 * src/main/webapp/style.css: Mention the new div.
1504 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1506 Translate more strings in more locales.
1508 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1509 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1510 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1511 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1512 Translate the "Details" and "Open" string too.
1514 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1515 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1516 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1517 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1518 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1519 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1520 Add these new locales as placeholders though they currently contain English.
1522 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1524 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1526 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1527 Check the ConfiguredDocument* for null before using it.
1529 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1531 Tell Eclipse about the generated java files.
1533 * .classpath: This lets it find OnlineGlomConstants.java.
1534 It would be nice if Eclipse just used the maven build files.
1536 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1538 Prevent a crash when no locale is specified in the URL.
1540 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1541 Avoid returning a null string, obtained from
1542 Window.Location.getParameter(). This caused a crash when it was
1543 later passed to libglom's API.
1544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1545 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1546 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1547 guard against future null strings.
1549 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1551 Use the ?locale= query param instead of the &lang= token param.
1553 * src/main/java/org/glom/web/client/place/ListPlace.java
1554 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1555 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1556 Remove the lang token key and value.
1558 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1559 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1560 When the user selects a different locale from the chooser, use
1561 Window.Location.assign() to change the URL, which then causes a reload.
1563 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1564 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1565 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1566 * src/main/java/org/glom/web/client/activity/ListActivity.java
1567 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1568 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1569 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1570 * src/main/java/org/glom/web/client/ui/ListView.java:
1571 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1573 Remove localeID member variables and method/constructor parameters, instead
1574 using Utils.getCurrentLocaleID() when we need a localID to pass to
1577 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1579 Internationalize the UI strings.
1581 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1582 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1583 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1584 because it is unused. Messages are apparently strings that can have
1585 parameters, but we do not need that yet, so Contants will be enough for now.
1586 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1587 to say that we support the en and de locales.
1588 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1589 The original English strings.
1590 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1591 Some German translations of the English strings.
1592 The i18n goal then uses the .properties file to generate an
1593 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1594 returns an implementation that returns the translated strings.
1595 The documentation suggests putting these in src/java/*/client/, but it seems
1596 best to put it in src/resources/*/client/.
1597 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1598 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1599 instead of hard-coding them.
1600 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1601 but that does not seem to stop the build, though it confuses Eclipse.
1603 You can see the translated string by adding ?locale=de to the URL, like so:
1604 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1606 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1608 Improve null/empty String checks.
1610 * pom.xml: Add a dependency on commons-lang, to use
1611 org.apache.commons.lang.StringUtils.
1612 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1613 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1614 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1615 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1616 Use StringUtils.isEmpty().
1618 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1619 StringUtils class with a static isEmpty() function because we
1620 cannot use org.apache.commons.lang.StringUtils in client-side
1621 GWT code because it (apparently) cannot be compiled to javascript.
1622 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1623 * src/main/java/org/glom/web/client/activity/ListActivity.java
1624 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1625 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1626 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1627 * src/main/java/org/glom/web/client/place/ListPlace.java
1628 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1629 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1630 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1631 * src/main/java/org/glom/web/client/ui/details/Group.java
1632 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1633 our StringUtils.isEmpty() function.
1635 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1637 Update to the latest java-libglom API.
1639 * pom.xml: Require java-libglom 1.21.4.
1640 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1641 getDocumentInfo(), getListViewLayoutGroup():
1642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1644 * src/main/java/org/glom/web/server/database/DBAccess.java
1645 getFieldsToShowForSQLQueryAddGroup(),
1646 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1647 with either get_database_title_original() or
1648 get_database_title(localeID).
1650 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1652 ConfiguredDocument: Avoid a null pointer exception.
1654 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1655 Initialize localeID to "" to avoid returning a null String which
1656 causes a crash in java-libglom's swing-generated code.
1658 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1660 Some simple renaming.
1662 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1663 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1664 for localeChooser. This seems more appropriate and is less ambiguous
1665 particularly in the .css file.
1667 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1669 ConfiguredDocument: Rename the localedID private member variable.
1671 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1673 Adapt to the latest java-libglom API from git master.
1675 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1676 libglom now uses only Vector instead of List, which uses add() instead of
1679 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1681 ConfiguredDocument: Rename the localedID private member variable.
1683 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1685 Build a source tarball with mvn assembly:single
1687 * assembly.xml: Add this file.
1688 * pom.xml: Use the maven-assembly-plugin and tell it to use
1689 our assembly.xml file.
1691 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1693 OnlineGlomServiceImpl: Get .glom files recursively.
1695 * pom.xml: Depend on commons-io from org.apache.commons.
1696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1697 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1698 files recursively, and with the easier filter for the extension.
1699 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1700 simplify that code too.
1702 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1704 README: Mention that you must install java-libglom packages separately.
1706 But then it works, because java-libglom is now in the central maven
1709 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1711 locales drop-down: Show the correct selected locale when the URL changes.
1713 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1714 .java: setPlace(): Move some code into fillView().
1716 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1718 locales drop-down: Do not lose the primary key.
1720 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1721 start(): onLocaleChange(): Pass the current primary key value,
1722 instead of an empty value.
1724 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1726 locales drop-down: Do not lose the drop-down selection.
1728 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1729 .java (TableSelectionActivity.fillView): Set the selected locale
1730 after changing the drop-down items (though we do not really need
1731 to change them just because the locale changes.)
1733 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1735 locales drop-down: Change the tables list when this changes.
1737 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1738 .java: TableSelectionActivity.start(): Move the async table titles
1739 retrieval into a private fillView() method and also call this when
1740 the chosen locale changes.
1741 Note that the document title is not actually translatable yet, but
1742 that is a problem that I should fix soon in libglom.
1744 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1746 Improve the placement of the locales drop-down.
1748 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1749 Put the title and locales drop-down in a div (gwt.FlowTable).
1750 * src/main/webapp/style.css: Add magic css properties to make this work.
1751 Also remove the left margin from the title so that it lines up with the
1754 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1756 locales selector: Show human-readable locale titles.
1758 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1759 getDocumentInfo(): Use java.util.Locale to show a real title of
1760 each locale, in the locale's own language.
1762 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1764 Add a language/locale selector drop-down.
1766 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1767 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1768 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1769 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1770 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1771 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1772 Add a ListBox to show the available locales. Add getLocaleSelector(),
1773 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1774 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1775 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1776 java: Add these classes.
1777 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1778 start(): Fill the locales ListBox. Handle its change event, firing a
1780 setPlace(): Show the selected locale as specified by the URL token.
1781 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1782 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1783 Handle LocaleChangeEvent, going to a new *Place with that locale.
1785 The placement of the ListBox is not pretty, and it currently uses the ID
1786 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1790 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1792 Search box: Show the search text from the URL token.
1794 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1795 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1796 Add setQuickFindText().
1797 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1798 .java: setPlace(): Store the queryText if the place is a ListPlace,
1799 and call TableSelectionView.setQuickFindText().
1801 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1803 Allow use of translations via, for instance, &lang=de in the URL.
1805 * pom.xml: Use the unstable java-libglom 1.21 version.
1807 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1808 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1810 init(): Instead of calling TranslatableItem.set_current_locale()
1811 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1812 However, this is only for default locales, which are not needed to
1813 change the locale in the URL.
1814 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1815 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1816 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1817 layout for a particular locale.
1818 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1819 Add get/setDefaultLocaleID().
1820 getDocumentInfo(), getListViewData(), getRelatedListData(),
1821 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1822 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1823 localeID parameter, so we can get the layout for a particular locale.
1825 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1826 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1827 * src/main/java/org/glom/web/client/place/ListPlace.java:
1828 Parse and construct a lang parameter too.
1830 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1831 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1832 passed to subsequent methods and constructors.
1833 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1834 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1835 Store the localeID from the *Place and pass it to other constructors
1836 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1838 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1839 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1840 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1841 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1842 * src/main/java/org/glom/web/client/ui/ListView.java:
1843 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1844 Take localeID parameters and pass them to subsequent constructors and
1845 methods, so that the layout is always retrieved for that locale.
1847 This is rather repetitive.
1849 Note that "" means the original (default) locale of the Glom document,
1850 which is usually English.
1852 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1854 Documents: Remove final keyword to fix startup configuration.
1856 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1857 final keywords on the private member variables because that breaks
1858 the startup, apparently (there are warnings) because it stops them
1859 from being serialized. I added these in the previous commit.
1861 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1863 Documents: Add some final keywords.
1865 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1868 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1870 OnlineGlomServiceImpl: Add to overview comments.
1872 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1873 Note that this is where all the document are loaded. They are not
1874 loaded freshly for each page.
1876 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1880 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1881 Add a TextBox for the text of a quick find.
1882 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1884 setBackLink(): Add a String quickFind parameter.
1885 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1886 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1887 to the base interface, because that is how TableSelectionViewImpl is used.
1888 * src/main/webapp/style.css: Add style for the search box and its label.
1890 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1891 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1892 Add these files, based on the existing TableChangeEvent and
1893 TableChangeEventHandlers.
1894 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1895 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1896 a ListPlace() that the user should be taken to.
1897 * src/main/java/org/glom/web/client/activity/ListActivity.java
1898 start(): Handle it here too and adapt the TableChangeEvent handler to
1899 pass the extra "" quickFind parameter to ListPlace.
1900 * src/main/java/org/glom/web/client/place/ListPlace.java:
1901 Constructor: Take an extra String quickFind parameter and store it,
1902 returning it from a new getQuickFind() method.
1903 getToken(): Put the quickFind text in the URL token.
1904 getPlace(): Parse the quickFind text from the URL token.
1905 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1906 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1907 ListPlace constructor.
1908 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1909 .java: start(): Add a Change handler for the TableSelectionView's
1910 TextBox (via its base HasChangeHandlers interface), firing the new
1911 QuickFindChangeEvent.
1912 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1913 pass the extra "" quickFind parameter.
1915 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1916 setCellTable(): Add a String quickFind parameter and pass it to
1917 the ListViewTable() constructor.
1918 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1919 setCellTable() in the base interface, because that is how ListViewImpl
1922 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1923 Add a String quickFind member variable.
1924 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1925 Constructor: Add a String quickFind parameter, storing it in the
1926 base ListTable's member variable.
1927 onRangeChanged(): Pass quickFind to the
1928 OnlineGlomServiceAsync.getSortedListViewData() and
1929 OnlineGlomServiceAsync.getListViewData() methods.
1931 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1932 getListViewData(), getSortedListViewData(): Add a String quickFind
1933 parameter, passing it to ConfiguredDocument.getListViewData().
1934 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1935 Change getListViewData(), getSortedListViewData() in the base interface,
1936 because that is how OnlineGlomServiceImpl is used, via this:
1937 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1938 Change getListViewData(), getSortedListViewData() here too.
1939 This class can apparently be used to asynchronously call methods on
1940 OnlineGlomService, and GWT seems to implement that after recognizing
1941 just the *Async name convention and the extra AsyncCallback parameters.
1943 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1944 getListViewData(): Add a String quickFind parameter, and pass it to
1945 ListViewDBAccess.getData().
1946 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1947 getListData(): Add a String quickFind parameter and pass it to
1949 getSelectQuery(): Add a String quickFind parameter.
1950 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1951 getSelectQuery(): Add a String quickFind parameter and use it with
1952 Glom.get_find_where_clause_quick() to pass a where_clause to
1953 Glom.build_sql_select_with_where_clause(), to actually filter the
1955 getData(): Add a String quickFind parameter, passing it to getListData().
1956 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1957 va: getData(): Pass an empty string to getListData() for the
1958 quickFind parameter.
1960 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1962 ListTable: Minor change.
1964 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1965 createCellTable(): Make this protected instead of public.
1967 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1969 Many files: Use final for the parameters and use the @override attribute.
1971 2012-01-22 Ben Konrath <ben@bagu.org>
1973 Add anchor links for single line text that starts with http, ftp and www.
1977 2012-01-22 Ben Konrath <ben@bagu.org>
1979 Add ellipsis to single line text in details view.
1983 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1985 Remove all javadoc author tags.
1987 Because they are awkward and meaningless when many people touch
1989 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1991 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1993 Revert the COPYING.LESSER to COPYING rename.
1995 Apparently both should be there if it is LGPL.
1997 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1999 *View: Remove unused imports.
2001 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2002 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2003 * src/main/java/org/glom/web/client/ui/ListView.java:
2004 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2005 Remove unused imports, as suggested by Eclipse.
2007 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2009 Move the *View::Presenter types, and some API into one base View.
2011 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2012 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2013 * src/main/java/org/glom/web/client/ui/ListView.java:
2014 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2015 Presenter, setPresenter() and clear() into a shared base interface,
2016 to avoid the unnecessary duplicate Presenter types and to more clearly
2017 show how the *Views share the same structure, even if they are not
2018 used polymorphically.
2020 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2021 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2023 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2024 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2025 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2027 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2030 Feel free to revert this if there is a good reason for the duplicate
2033 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2035 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2037 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2038 a class member instead of a local variable in the method.
2039 This lets us use it to get the view instances, for use in tests.
2040 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2041 beforeOnlineGlom(): Test some more details of the initial view.
2042 Again, this is not very useful.
2044 To really test gwt-glom we will need to start a local postgresql
2045 instance with local data, like the Glom tests in C++.
2047 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2049 pom.xml: Mention the LGPL license.
2051 * pom.xml: Add a licenses section.
2052 * COPYING.LESSER: Move this to COPYING, which
2053 previously contained the GPL. But gwt-glom is all LGPL.
2055 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2057 Add project information to README and pom.xml.
2059 * README: Add a brief description and mention some mvn
2061 * pom.xml: This extra information shows up in mvn site
2064 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2066 Use the latest java-libglom version.
2068 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2070 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2072 GwtTestOnlineGlom: Test a little more.
2074 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2075 protected rather than private, as suggested by the gwt-test-utils
2077 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2078 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2079 Test the initial visibility of the panels.
2081 However, this is not a very useful test.
2082 And I wonder how we should generally test using this idea for an
2083 activity/places app like ours where the real changes happen implicitly
2084 based on the history token/URL.
2086 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2088 Slight modification to *Mapper comments.
2090 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2091 (DataActivityMapper)
2092 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2094 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2096 Remove comments mentioning GIN because they are just copied from
2097 the example code and are apparently not helpful:
2098 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2099 Also change the mention of a class that is only in the example code.
2101 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2103 GwtTestOnlineGlom test: Minor changes.
2105 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2106 Avoid the long qualified class name and modify the comment
2107 because it is now obvious to me that the mocked class is the only
2108 custom one created via GWT.create().
2110 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2112 Tests: Added the beginnings of a test using gwt-test-utils.
2114 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2115 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2116 which tells gwt-test-utils what class will be tested.
2117 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2118 Add a simple (but empty) test case. One class, used by the OnlineGlom
2119 class, is mocked so that it can be created. However, I am not sure
2120 why only this class needs to be mocked.
2122 Note that mockito seems more popular, and clearer, than easymock,
2123 but I have not got that working yet. It might be a matter of the
2126 This test is run during mvn integration-test.
2128 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2130 Tests: Use junit4-style syntax instead of junit3-style.
2132 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2133 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2134 * src/test/java/org/glom/web/shared/DataItemTest.java:
2135 Use the @Test annotation rather than relying on the test*() prefix.
2136 Also no longer implement TestCase, to avoid triggering support for
2137 the junit3-way, which stops the annotations from working.
2138 Change the imports from import junit.framework.* to
2139 import org.junit.*, which is apparently the new way.
2141 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2143 Added a test for ListPlace token parsing and creation.
2145 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2146 This is much the same as DetailsPlaceTest.
2148 I wonder how we could test the other parts of the *Place API.
2150 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2152 DetailsPlace test: Also test getToken() and recreation via getPlace().
2154 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2155 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2156 recreate it, testing the recreated DetailsPlace for the same parameter
2159 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2161 Use the surefire-report plugin.
2163 * pom.xml: This generates a HTML report about the tests in
2164 target/site/surefire-report.html
2165 when you do mvn surefire-report:report. It seems to be popular/normal.
2167 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2169 Added a test for DetailsPlace.
2171 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2172 Test the getPlace() token parsing.
2174 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2176 Added a first unit test.
2178 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2179 * src/test/java/org/glom/web/shared/DataItemTest.java:
2180 This is a silly test but it is just to get things started. Note that
2181 maven/junit finds the test because it looks in src/test by default.
2183 2011-12-22 Ben Konrath <ben@bagu.org>
2185 Change charsetName to "UTF-8" when replacing line breaks.
2187 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2188 that work in Java (such as "UTF8") will not work when compiled to
2191 This fixes a problem with multi-line details view fields that have hard
2192 line breaks. The "License Text" field on this page demonstrates the
2195 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2197 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2199 2011-12-22 Ben Konrath <ben@bagu.org>
2201 Fix another bug with related list navigation.
2203 I've tested all the navigation buttons in all of the related lists
2204 so things should be good now.
2206 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2208 2011-12-22 Ben Konrath <ben@bagu.org>
2210 Fix a crasher when refreshing the list view with the default table.
2212 This crash will also happen when loading the list view with the default
2213 table from a link or bookmark.
2215 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2216 to the main document selection page when the document id hasn't been
2218 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2219 the main document selection page when the document id hasn't been
2221 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2222 values for the details place when the document id hasn't been set.
2223 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2224 values for the list place when the document id hasn't been set.
2226 2011-12-21 Ben Konrath <ben@bagu.org>
2228 Protect against NPE when glom.document.locale is not in config.
2230 This patch protects against an NPE when glom.document.locale is not in
2231 the config file. This NPE will also happen if glom.document.locale is
2234 The patch also updates the error message to display the class name when
2235 the getMessage() returns null. This was happening when the NPE was
2236 thrown and I had "Configuration Error: null". If an NPE is encountered
2237 with this patch, "Configuration Error: NullPointerException " will be
2240 This commit closes this bug:
2242 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2244 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2246 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2248 Rename onlineglom.properties to onlineglom.properties.sample.
2250 * src/main/resources/onlineglom.properties: Rename to:
2251 * src/main/resources/onlineglom.properties.sample:
2252 * src/main/resources/README: And add this file explaining that people
2253 should rename it back when deploying.
2255 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2257 Allow choosing the translation in the .properties file.
2259 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2260 init(): Read a glom.document.locale value from the configuration file
2261 and call Glom's TransatableItem::set_current_locale() method.
2262 * src/main/resources/onlineglom.properties: Add a commented-out
2263 example of this new setting.
2265 It would be better to add &lang=de_DE to the URL, but the current
2266 libglom API does not allow us to do this easily. I am working on that.
2268 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2270 Avoid a crash in parsing of token parameters.
2272 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2273 ava: getTokenParams(): Do not crash if a parameter has a key but no
2274 value, and ignore parameters with neither.
2276 2011-12-17 Murray Cumming <murrayc@murayc.com>
2278 History token building/handling: Improve use of token parameters.
2280 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2281 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2282 and buildParamsToken(HashMap), for use by derived classes.
2283 Make the separator private because it is no longer be needed.
2284 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2285 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2286 instead of manual string concatenation.
2287 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2288 of hardcoded indices and awkward splitting code.
2289 * src/main/java/org/glom/web/client/place/ListPlace.java
2290 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2291 instead of manual string concatenation.
2292 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2293 of hardcoded indices and awkward splitting code.
2294 This should fix bug #666420
2296 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2298 Fix a Navgiation->Navigation typo in the code.
2300 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2301 Rename processNavgiation() to processNavigation().
2303 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2305 Fix a seperator->separator typo in the code.
2307 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2308 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2309 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2312 2011-12-15 Ben Konrath <ben@bagu.org>
2314 Cleanup some comments.
2316 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2318 2011-12-14 Ben Konrath <ben@bagu.org>
2320 Replace \n with <br/> for multiline text in the details view.
2322 Vertical scrollbars are added when needed as well.
2324 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2326 2011-12-14 Ben Konrath <ben@bagu.org>
2328 Specify the font for document selection links.
2330 * src/main/webapp/style.css:
2332 2011-12-14 Ben Konrath <ben@bagu.org>
2334 Fix bouncy CellTable while paging.
2336 This doesn't currently work with related list tables in unselected
2339 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2341 2011-12-14 Ben Konrath <ben@bagu.org>
2343 Revamp the appearance of the document selection page.
2345 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2346 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2347 * src/main/webapp/style.css:
2349 2011-12-13 Ben Konrath <ben@bagu.org>
2351 Set navigation button column to the smallest size possible.
2353 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2355 2011-12-13 Ben Konrath <ben@bagu.org>
2357 Change OpenButton nomenclature to NavigationButton.
2359 Using NavigtionButton makes things more generic. Classes, methods and
2360 variables have been changed.
2362 This is a rename-only refactor.
2364 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2365 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2366 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2367 Renamed from OpenButtonCell.
2368 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2369 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2370 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2372 2011-12-12 Ben Konrath <ben@bagu.org>
2374 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2376 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2377 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2378 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2379 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2381 2011-12-12 Ben Konrath <ben@bagu.org>
2383 Update variable names and comments.
2385 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2386 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2388 2011-12-12 Ben Konrath <ben@bagu.org>
2390 Properly initialize numNonEmptyRows variable to zero.
2392 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2393 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2395 2011-12-05 Ben Konrath <ben@bagu.org>
2397 Add latest mockup with HTML tables.
2399 Features of this mockup:
2401 -> HTML table for flowtable
2402 -> HTML table for flowtable column
2403 -> Example of how related lists would look
2404 -> Not using text entries for data items
2406 The current version of Online Glom doesn't use HTML tables for the
2409 This mockup has been sent to the glom-devel mailing list but it's good
2410 to have it here as well.
2412 * mockups/details-view-html-tables.html:
2414 2011-12-05 Ben Konrath <ben@bagu.org>
2416 Remove unnecessary getPrimaryKeyField() method.
2418 getPrimaryKeyFieldForTable(String) has been renamed to
2419 getPrimaryKeyField(String).
2421 * src/main/java/org/glom/web/server/database/DBAccess.java:
2422 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2423 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2425 2011-12-05 Ben Konrath <ben@bagu.org>
2427 Add string representation of TypedDataItem value to conversion error message.
2429 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2430 message was extracted into its own method to avoid duplication.
2432 2011-12-05 Ben Konrath <ben@bagu.org>
2434 Add type checking to navigation primary key value creation.
2436 Create navigation primary key only if the expected type from the Glom
2437 document matches the type returned by the SQL query.
2439 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2441 2011-12-05 Ben Konrath <ben@bagu.org>
2443 Rename a couple of variables in RelatedListNavigation.
2445 This is a rename-only refactor.
2447 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2449 2011-12-05 Ben Konrath <ben@bagu.org>
2451 Move getListLayoutGroup() into getListViewLayoutGroup().
2453 This removes getListLayoutGroup(). It was only being called by
2454 getListViewLayoutGroup().
2456 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2458 2011-12-05 Ben Konrath <ben@bagu.org>
2460 Remove check for LayoutItem_Portal in list table method.
2462 This check is no longer necessary because the method isn't being used
2463 to create the LayoutItemPortal DTO.
2465 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2467 2011-12-05 Ben Konrath <ben@bagu.org>
2469 Properly support related list navigation.
2471 Navigation from the "Repository Analyzer -> Package Scans ->
2472 Dependencies" related table wasn't working because the primary key for
2473 related tables wasn't being set properly. This commit fixes the
2476 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2477 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2478 doesn't set the primary key properly for related list tables.
2479 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2480 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2481 useful for getting the primary key for list view tables and for related
2483 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2484 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2485 Move code to set the primary key for the table from the abstract
2486 ListDBAccess class to ListViewDBAccess as it's only correct for list
2488 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2489 Properly add primary key to related list tables.
2491 2011-12-02 Ben Konrath <ben@bagu.org>
2493 Properly set the horizontal alignment of fields.
2495 This fix is for both the list tables and the details view.
2497 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2498 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2499 to set the horizontal alignment of fields.
2501 2011-12-02 Ben Konrath <ben@bagu.org>
2503 Display currency codes in the details view.
2505 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2507 2011-12-02 Ben Konrath <ben@bagu.org>
2509 Avoid duplicate JNI call.
2511 JNI is not as efficient as pure Java and this is an easy (and small)
2514 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2515 Use previously retrieved value for whereClauseToTableName instead of
2518 2011-12-02 Ben Konrath <ben@bagu.org>
2520 Rename a couple of variables in RelatedListNavigation.
2522 This is a rename-only refactor.
2524 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2526 2011-12-02 Ben Konrath <ben@bagu.org>
2528 Indicate clearly that a mismatched primary key type is a bug.
2530 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2531 warning to error. Add 'This is a bug.' to message.
2533 2011-12-02 Ben Konrath <ben@bagu.org>
2535 Update / fix some comments.
2537 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2539 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2541 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2542 Fix comments. Add some TODOs.
2544 2011-12-02 Ben Konrath <ben@bagu.org>
2546 Enable navigation to details view with string primary key from related list.
2548 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2549 Create a text primary key value when return type of result is
2550 java.sql.Types.VARCHAR.
2552 2011-12-02 Ben Konrath <ben@bagu.org>
2554 Use checkboxes for booleans in the details view.
2556 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2558 2011-12-01 Ben Konrath <ben@bagu.org>
2560 Improve performance of related list height calculation.
2562 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2563 Put code to calculate the expected height in a static initializer so
2564 that that it's only called once.
2566 2011-12-01 Ben Konrath <ben@bagu.org>
2568 Show related list tables in notebooks (again).
2570 Calculate the height of the related list tables so the Notebook can be
2571 set the correct height. The height of the related list table is also needed by
2572 FlowTable to be able decide how to create the layout.
2574 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2575 and set the Portal height based on the height of the related list
2576 table and the Portal container.
2577 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2578 Add method to calculate the height of the related list tables.
2579 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2580 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2581 calculate the height of the Pager widget.
2583 2011-12-01 Ben Konrath <ben@bagu.org>
2585 Use CellTable API for table property instead of setting style on Element.
2587 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2589 2011-12-01 Ben Konrath <ben@bagu.org>
2591 Make ListViewTable and RelatedListTable a consistent height.
2593 The tables are now a consistent height regardless of the contents of
2594 the table. A hidden button is added to empty rows to ensure that the
2595 height of these rows will match the height of rows with data.
2597 A navigation button column is now added to every table. The width of
2598 the navigation column is set to 0px when a RelatedListTable shouldn't
2599 have navigation buttons. This maintains the a consistent row height in
2600 tables that don't show the navigation buttons.
2602 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2603 navigation column when not needed.
2604 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2605 arguments for navigation button to constructor of ListViewTable.
2606 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2607 hidden button for empty data rows.
2608 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2609 arguments for navigation button to constructor.
2610 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2611 create navigation buttons. Add hideNavigationButtons() method.
2612 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2613 arguments for navigation button to constructor.
2615 2011-12-01 Ben Konrath <ben@bagu.org>
2617 Use 'visibility: hidden' in Utils.getWidgetHeight().
2619 This is better choice because hidden elements are invisible, don't
2620 respond to events and are not part of the tab order. They will,