1 2012-05-07 Murray Cumming <murrayc@murrayc.com>
3 LayoutItemPortal: Also override getTitleOriginal().
5 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
6 This lets the base getTitle() with no parameters work.
7 TODO: Test this properly.
9 2012-05-06 Murray Cumming <murrayc@murrayc.com>
11 LayoutItemPortal: getTitle*(): Use the relationship title.
13 2012-05-06 Murray Cumming <murrayc@murrayc.com>
15 LayoutItemField: Fix loading of custom titles.
17 * src/main/java/org/glom/web/server/libglom/Document.java
18 loadDataLayoutItemField(): The title, if any, instead of the field
19 title, is stored in a title_custom node. Load it from there.
20 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
22 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
23 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
24 getTitle*() overrides.
25 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
28 2012-05-06 Murray Cumming <murrayc@murrayc.com>
30 LayoutItemField: Fall back to field titles, so some are really shown.
32 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
33 Override getTitleOriginal() and getTitle(), as in java-libglom.
34 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
37 2012-05-06 Murray Cumming <murrayc@murrayc.com>
39 Correct use of setExpectedResultSize().
41 * src/main/java/org/glom/web/server/ConfiguredDocument.java
42 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
43 Use setExpectedResultSize only on top-level groups (for instance, the
44 list layout) or on child portals (in details views).
45 Use the correct table name for portals to avoid SQL errors.
46 Update the expected counts when returning cached layouts.
48 2012-05-06 Murray Cumming <murrayc@murrayc.com>
50 Document: Interpret no group column count as 1.
52 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
53 default, though we now check for this in the UI code anyway.
55 2012-05-06 Murray Cumming <murrayc@murrayc.com>
59 2012-05-06 Murray Cumming <murrayc@murrayc.com>
61 Translatable: Use Hashmap instead of Treemap because GWT supports it.
63 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
64 The use of Treemap lead to this error from async methods, with no
66 "The response could not be deserialized"
68 2012-05-06 Murray Cumming <murrayc@murrayc.com>
70 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
72 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
73 when using the Google -> GWT Compile, or
74 g toolbar button -> GWT Compile Project... feature in Eclipse.
76 2012-05-06 Murray Cumming <murrayc@murrayc.com>
78 ListTable.addColumn(): Protect against a null Formatting.
80 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
81 Create a default Formatting if it is null, because that is the simplest
84 2012-05-06 Murray Cumming <murrayc@murrayc.com>
86 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
88 * src/main/java/org/glom/web/server/ConfiguredDocument.java
89 updateLayoutGroup(): Check that the field is not null.
91 2012-05-06 Murray Cumming <murrayc@murrayc.com>
93 ListViewImpl: Protected against a bad cast error.
95 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
96 onEnterKeyDown(): Do not cast without an instanceof check.
98 2012-05-06 Murray Cumming <murrayc@murrayc.com>
100 ListTable: Protect against an out of range error.
102 * src/main/java/org/glom/web/client/ui/list/ListTable.java
103 createCellTable(): This is unlikely, but can happen while debugging.
105 2012-05-06 Murray Cumming <murrayc@murrayc.com>
107 AsyncMessage onFailure() callbacks: Log the exception message.
109 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
110 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
111 * src/main/java/org/glom/web/client/activity/ListActivity.java:
112 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
113 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
114 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
115 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
116 These are useful clues when something is wrong.
118 2012-05-06 Murray Cumming <murrayc@murrayc.com>
120 ConfiguredDocument: Avoid a null dereference.
122 * src/main/java/org/glom/web/server/ConfiguredDocument.java
123 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
124 details maps are created.
126 2012-05-06 Murray Cumming <murrayc@murrayc.com>
128 Document: Correct the port number parsing.
130 * src/main/java/org/glom/web/server/libglom/Document.java:
131 This lets us actually connect to the database and show the document.
133 2012-05-05 Murray Cumming <murrayc@murrayc.com>
137 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
138 user-interaction, asking us to load a temporary URL in a browser.s
139 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
140 which is apparently necessary for testing the service. See the comment.
141 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
142 Show the exception, if any. This is how I saw the 404 in the HTML in
145 2012-05-05 Murray Cumming <murrayc@murrayc.com>
147 DocumentTest: Move the .glom files into the resources directory.
149 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
150 URI via getResource().
152 2012-05-05 Murray Cumming <murrayc@murrayc.com>
154 Document: Remove the FieldIdentifies inner class.
156 * src/main/java/org/glom/web/server/libglom/Document.java: We only
157 use the Relationship (though the same function in libglom is maybe
158 used in other ways) and so this removes a compiler warning.
160 2012-05-05 Murray Cumming <murrayc@murrayc.com>
162 Document.load() Remove the error code parameter.
164 * src/main/java/org/glom/web/server/libglom/Document.java: load():
165 Remove the parameter. We do not set it yet and it could never have
166 worked as an output parameter (though maybe it did in java-libglom).
167 We could use an exception if we really want the failure reason.
168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
170 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
171 setUp(), testGetSuitableTableToViewDetails(): Adapt.
173 2012-05-05 Murray Cumming <murrayc@murrayc.com>
175 Make some inner classes static.
177 * src/main/java/org/glom/web/server/ConfiguredDocument.java
178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
179 * src/main/java/org/glom/web/server/ReportGenerator.java
180 * src/main/java/org/glom/web/server/libglom/Document.java
181 Make all inner classes static that can be static.
183 2012-05-05 Murray Cumming <murrayc@murrayc.com>
185 OnlineGlomServiceImpl: Do not load and check for java-libglom.
187 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
188 init(): We do not use java-libglom any more.
190 2012-05-05 Murray Cumming <murrayc@murrayc.com>
192 Remove mentions of java-libglom.
194 * README: Remove mention of java-libglom, because it no longer needed.
195 * utils/build-onlineglom-war.sh:
196 * utils/check-and-recover-tomcat.py:
197 * utils/install-onlineglom-war.sh: Remove these as they are no longer
198 useful. Building is now far easier, with no need for jhbuild.
200 2012-05-05 Murray Cumming <murrayc@murrayc.com>
202 Fix the build (mvn package)
204 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
205 (LayoutGroup): Make the LayoutItemList inner class static and protected.
206 Otherwise the GWT Java->Javascript compilation fails with just this
207 error, during mvn package or when attempting to view in a browser,
208 in the GWT developer mode in Eclipse.
210 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
211 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
212 [INFO] Compiling module org.glom.web.OnlineGlom
213 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
214 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
215 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
216 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
217 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
218 [INFO] [ERROR] Cannot proceed due to previous errors
220 It has taken me 2 days to find out what was causing that. After reducing
221 the code, the compiler eventually showed me the full error message.
223 2012-05-04 Murray Cumming <murrayc@murrayc.com>
225 ConfiguredDocument: Cache the cloned and stripped layouts.
227 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
228 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
229 layout in a map, so we can retrieve it again without rebuilding it.
231 2012-05-04 Murray Cumming <murrayc@murrayc.com>
233 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
235 2012-05-04 Murray Cumming <murrayc@murrayc.com>
237 libglom classes: Implement some auto-generated emthods.
239 2012-05-04 Murray Cumming <murrayc@murrayc.com>
241 Add GwtTestOnlineGlomService.
243 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
244 However, this (and the other GwtTest*) does not seem to run during
247 2012-05-04 Murray Cumming <murrayc@murrayc.com>
249 Remove use of unsupported features from client code.
251 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
252 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
253 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
254 Use our client version of StringUtils instead of the apache commons one.
256 However, the GWT Javascript compliation still fails.
258 2012-04-25 Murray Cumming <murrayc@murrayc.com>
260 Add a Field class and implement some loading of it in Document.
262 2012-04-25 Murray Cumming <murrayc@murrayc.com>
264 Initial Document loading implementation, instead of libglom.
266 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
267 and Translatable classes, and adapt the rest of the code to use them.
268 However, this is still missing Layout and Field classes and loading.
270 2012-04-24 Murray Cumming <murrayc@murrayc.com>
272 Use of jOOQ: Move Field creation into a utility method.
274 * src/main/java/org/glom/web/server/SqlUtils.java:
275 This lets us improve it more easily.
277 2012-04-24 Murray Cumming <murrayc@murrayc.com>
279 Use of jOOQ: Improve the code to COUNT a sub-select.
281 * src/main/java/org/glom/web/server/SqlUtils.java:
282 Move initial query creation into
283 build_sql_select_step_with_where_clause().
284 build_sql_select_count_rows(): Use the jOOQ API instead of
285 concatentating text, because a jOOQ Select*Step is a TableLike,
286 which is what from() takes.
288 2012-04-23 Murray Cumming <murrayc@murrayc.com>
290 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
292 * pom.xml: Depend on jooq.
293 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
294 methods with jOOQ, based on the C++ implementations in libglom,
295 with some changes to the logic required by jooQ.
296 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
298 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
299 * src/main/java/org/glom/web/server/ReportGenerator.java:
300 * src/main/java/org/glom/web/server/SqlUtils.java:
301 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
302 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
303 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
304 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
305 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
306 Adapt. In particular, the SqlUtils methods now need to take a Connection,
307 because jOOQ needs that, though it seems unnecessary.
309 This is not quite finished. Ideally jOOQ would help us to build
310 table_name.field_name names, quoting and escaping them properly.
311 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
313 2012-04-21 Murray Cumming <murrayc@murrayc.com>
315 Move use of Glom.build_sql*() into a new SqlUtils class.
317 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
318 to wrap Glom.build_sql*(). The parameter types are still Glom one,
319 but this will make it easier to start using something other than
320 libglom or SqlBuilder.
322 2012-04-21 Murray Cumming <murrayc@murrayc.com>
324 Update the project URL.
326 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
328 2012-04-21 Murray Cumming <murrayc@murrayc.com>
330 Main layout: Use a FlowTable instead of absolute positioning.
332 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
333 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
334 child panels/widgets must have an absolute position. But that is annoying, so
335 this adds a FlowTable and puts the child panels in there.
337 2012-04-21 Murray Cumming <murrayc@murrayc.com>
339 GwtTestOnlineGlom: Comment out unused code.
341 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
342 Eclipse has started to say that some code is unused.
344 2012-04-21 Murray Cumming <murrayc@murrayc.com>
346 Update to the latest versions of dependencies.
348 * pom.xml: Update version numbers of dependencies to the latest
350 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
351 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
352 * src/main/java/org/glom/web/server/ReportGenerator.java:
353 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
354 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
355 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
357 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
358 Modify the imports where necessary.
360 2012-04-17 Murray Cumming <murrayc@murrayc.com>
362 Style: Remove overflow:hidden from searchbox
364 * src/main/webapp/style.css: Because this pushes the Back To Link
365 label/link on to the next row, which is then hidden due to the
366 hard-coded (in ems) height.
368 2012-04-20 Murray Cumming <murrayc@murrayc.com>
370 Remove some duplicate code.
372 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
373 getDocumentInfo(): This must have been duplicated during the merge from the
378 2012-04-19 Murray Cumming <murrayc@murrayc.com>
380 Reports: Localize the waiting for report message.
382 * src/main/java/org/glom/web/client/activity/ReportActivity.java
383 start(): Get the message from the contants.
384 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
386 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
387 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
388 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
389 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
390 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
391 Update these files with the English text for newer strings for now.
393 2012-04-19 Murray Cumming <murrayc@murrayc.com>
395 Reports: Show a message while waiting for the report.
397 * src/main/java/org/glom/web/client/ui/ReportView.java
398 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
399 Add setWaitingText(), to show a message saying that we are
400 waiting for the report to be ready.
401 * src/main/java/org/glom/web/client/activity/ReportActivity.java
402 start(): Call setWaitingText() before calling the async
405 2012-04-19 Murray Cumming <murrayc@murrayc.com>
407 ReportGenerator: Specify date and time formats.
409 * src/main/java/org/glom/web/server/ReportGenerator.java:
410 createFieldValueElement(): Use the default (and localized)
411 short formats, though we still need a way to show 4-digit
412 years without providing the format for every locale.
413 * src/main/java/org/glom/web/server/database/DBAccess.java:
414 convertResultSetToDTO(): Use the short formats here too.
416 2012-04-18 Murray Cumming <murrayc@murrayc.com>
418 ReportGenerator: Use the correct numeric formatting.
420 * src/main/java/org/glom/web/server/ReportGenerator.java
421 createFieldExpression(), createFieldValueElement(): Take the
422 whole LayoutItem_Field instead of just the field name, so
423 we have access to the formatting.
424 createFieldValueElement(): Use JRTextField.setPattern() to
425 specify the numeric formatting, with the help of a
426 regular DecimalFormat.
428 2012-04-18 Murray Cumming <murrayc@murrayc.com>
430 ReportGenerator: Avoid showing null for group by titles.
432 * src/main/java/org/glom/web/server/ReportGenerator.java
433 generateReport(): Use setBlankWhenNull() on the field title
434 style too, because this is used for values in group by
437 2012-04-18 Murray Cumming <murrayc@murrayc.com>
439 ReportGenerator: Add a colon to titles in vertical groups.
441 * src/main/java/org/glom/web/server/ReportGenerator.java
442 addFieldToDetailBandVertical(): Pass true for the withColon
445 2012-04-18 Murray Cumming <murrayc@murrayc.com>
447 ReportGenerator: Simplify the code by using Position more.
449 2012-04-18 Murray Cumming <murrayc@murrayc.com>
451 Reports: Support vertical groups, roughly.
453 * src/main/java/org/glom/web/server/ReportGenerator.java:
454 addToReport(): Rename to addGroupToReport() and, if necessary,
455 call the new addVerticalGroupToReport() method.
456 createFieldValueElement(): Let the caller specify the Y position
459 2012-04-17 Murray Cumming <murrayc@murrayc.com>
461 Reports: Allow a second report to be shown.
463 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
464 clear(): Do not remove the HTML widget, which broke the whole layout.
466 2012-04-17 Murray Cumming <murrayc@murrayc.com>
468 Locales drop-down: Show that we use English by default.
470 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
471 fillView(): When we use English, just because that is the default, when
472 no locale is specified, show that in the Locales drop-down instead of
473 just showing the first item.
475 2012-04-17 Murray Cumming <murrayc@murrayc.com>
477 Unselect the Report/Locale/Table combo item when appropriate.
479 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
480 setPlace(): clear reportName if this is not a ReportPlace.
481 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
482 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
483 When the provided name is empty, unselect all items, so that none are
484 indicated. This uses a for loop because I cannot find a single method
487 2012-04-17 Murray Cumming <murrayc@murrayc.com>
489 Report: Give the user a way to get back to the list.
491 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
492 start(), setPlace(): Show the Back To List link on reports, and also
493 interpret selecting the empty report item as back to list.
495 2012-04-13 Murray Cumming <murrayc@murrayc.com>
497 Really show the selected Report name.
499 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
500 setPlace(): Store the reportName here, if it is that kind of Place.
501 fillView(): Set the selected Report after filling the list of reports.
502 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
503 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
504 null Strings, though we need some way to unselect all ListBox items
507 2012-04-13 Murray Cumming <murrayc@murrayc.com>
509 ReportGenerator: Try to avoid some problems.
511 * src/main/java/org/glom/web/server/ReportGenerator.java
512 addField(): Try to avoid duplicates, and avoid using a null
515 2012-04-13 Murray Cumming <murrayc@murrayc.com>
517 Reports: Use quickFind.
519 * src/main/java/org/glom/web/client/OnlineGlomService.java;
520 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
521 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
522 getReportHTML(): Add a quickFind parameter.
523 * src/main/java/org/glom/web/client/activity/ReportActivity.java
524 start(): Pass the quickFind parameter.
525 * src/main/java/org/glom/web/server/ReportGenerator.java
526 generateReport(): Take a quickFind parameter.
528 2012-04-13 Murray Cumming <murrayc@murrayc.com>
530 ReportPlace: Actually use the report name.
532 * src/main/java/org/glom/web/client/place/ReportPlace.java
533 getPlace(): Do not assign the report name to the quickfind.
535 2012-04-13 Murray Cumming <murrayc@murrayc.com>
537 Show java.library.path when complaining.
539 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
540 init(): When telling us to check java.library.path, show the
543 2012-03-06 Murray Cumming <murrayc@murrayc.com>
545 ReportGenerator: Do not show nulls.
547 2012-03-06 Murray Cumming <murrayc@murrayc.com>
549 ReportGenerator: Make the title font larger.
551 2012-03-06 Murray Cumming <murrayc@murrayc.com>
553 ReportGenerator: Put field titles inside groups, if there are groups.
555 2012-03-06 Murray Cumming <murrayc@murrayc.com>
557 ReportGenerator: Take the Report itself instead of the name and group.
559 * src/main/java/org/glom/web/server/ConfiguredDocument.java
560 Remove getReportLayoutGroup().
561 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
562 getReportHTML(): Pass the report instead
563 of its name and layout group.
564 * src/main/java/org/glom/web/server/ReportGenerator.java
565 generateReport(): Use the report object to use the title
568 2012-03-06 Murray Cumming <murrayc@murrayc.com>
570 ReportGenerator: Remove designBand parameters.
572 * src/main/java/org/glom/web/server/ReportGenerator.java:
573 Make designBand a class member instead of passing it to all
576 2012-03-06 Murray Cumming <murrayc@murrayc.com>
578 ReportGenerator: Add lines, a bit like in the desktop version.
580 * src/main/java/org/glom/web/server/ReportGenerator.java
581 addToReport(): Use JRDesignLine.
583 2012-03-06 Murray Cumming <murrayc@murrayc.com>
585 ReportGenerator: Correct the title positions and use some bold style.
587 * src/main/java/org/glom/web/server/ReportGenerator.java:
588 Break the code up into reusable functions, correct the placement of
589 titles, and use normal/bold styles as in the reports in the desktop
592 2012-03-06 Murray Cumming <murrayc@murrayc.com>
594 ReportGenerator: Add a header band to show the field titles.
596 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
597 getReportHTML(): Pass the localeId to the ReportGenerator
599 * src/main/java/org/glom/web/server/ReportGenerator.java
600 constructor: Take the localeID so we can get translated field
602 generateReport(), addToReport(), addFieldToBand(): Add field
603 titles in a column header band.
605 2012-03-05 Murray Cumming <murrayc@murrayc.com>
607 Reports drop-down list: Some improvement.
609 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
610 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
611 Adedd setSelectedReport(),
612 setReportList(): Add a blank line so that the user can select the
614 * src/main/java/org/glom/web/client/activity/ReportActivity.java
615 start(): Show the current report by calling setSelectedReport().
616 This does not seem to work yet.
618 2012-03-05 Murray Cumming <murrayc@murrayc.com>
620 DetailsActivity, ListActivity: Move some variables into a base class.
622 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
623 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
624 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
625 the clientFactory, documentID, tableName and authenticationPopup into
626 a base class, to avoid duplication.
628 2012-03-05 Murray Cumming <murrayc@murrayc.com>
630 Translate the Reports label.
632 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
633 Get the "Reports" label string from the constants.
634 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
635 perties: Add Reports to the constants.
637 2012-03-05 Murray Cumming <murrayc@murrayc.com>
639 Reports: Implement grouping.
641 * src/main/java/org/glom/web/server/ReportGenerator.java:
642 Handle LayoutItem_GroupBy items and try to do the right thing
643 with JRDesignGroup. It seems to work.
645 2012-03-04 Murray Cumming <murrayc@murrayc.com>
647 Actually show some data with JasperReports.
649 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
650 getReportHTML(): Move most code into a ReportGenerator class.
651 * src/main/java/org/glom/web/server/ReportGenerator.java:
652 Recurse into sub-groups, adding fields to the JasperDesign's details
653 band. Note that we must set an arbitrary width and height, or it just
654 will not show any data.
656 2012-03-04 Murray Cumming <murrayc@murrayc.com>
658 Reports Chooser: Show the titles, not the names.
660 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
661 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
662 and the names as the values.
663 * src/main/java/org/glom/web/server/ConfiguredDocument.java
664 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
665 group now that we provide the report name, so it should always
668 2012-02-15 Murray Cumming <murrayc@murrayc.com>
670 Depend on jasperreports.
672 * pom.xml: Add the dependency. My plan is to use this on the
675 2012-01-31 Murray Cumming <murrayc@murrayc.com>
677 Implement navigation to report places.
679 * src/main/java/org/glom/web/client/activity/ReportActivity.java
680 start(): Do not bother to handle all events here.
681 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
682 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
683 Added getSelectedReport().
684 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
685 .java: start(): When handling a change to the reports chooser,
686 call getSelectedReport() and goTo() its ReportPlace.
687 * src/main/java/org/glom/web/client/ui/ReportView.java
688 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
689 Added setReportHTML() which puts the html in a gwt HTML widget.
690 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
691 getReportHTML(): Return "TODO" just to show that this works.
693 2012-01-31 Murray Cumming <murrayc@murrayc.com>
695 Make ReportPlace usable.
697 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
699 * src/main/java/org/glom/web/client/place/ReportPlace.java:
700 Correct the @prefix annotation.
702 2012-01-31 Murray Cumming <murrayc@murrayc.com>
704 OnlineGlomService: Return report HTML rather than the LayoutGroup.
706 * src/main/java/org/glom/web/client/OnlineGlomService.java:
707 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
708 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
709 Change getReportLayout() to getReportHMTL() because we will not need to
710 parse or render the report layout on the client side.
711 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
712 getReportLayout(): Return the libglom LayoutGroup type because we will
713 not need to convert to a shared type, because this will not be used on
715 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
718 Note that there is still no implementation for this.
721 2012-01-27 Murray Cumming <murrayc@murrayc.com>
723 Add a (empty) Report Place, View, and Activity.
725 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
727 * src/main/java/org/glom/web/client/place/HasTablePlace.java
728 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
729 this into a superclass:
730 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
731 and also use it as the base of this new ReportPlace:
732 * src/main/java/org/glom/web/client/place/ReportPlace.java
734 * src/main/java/org/glom/web/client/ui/ReportView.java
735 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
736 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
737 Add these, containing mostly boiler-plate for now.
739 * src/main/java/org/glom/web/client/OnlineGlomService.java
740 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
741 * src/main/java/org/glom/web/server/ConfiguredDocument.java
742 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
743 Add API to get the LayoutGroup for the report.
745 2012-01-23 Murray Cumming <murrayc@murrayc.com>
747 Add and fill a Reports drop-down list box.
749 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
751 * src/main/java/org/glom/web/client/OnlineGlomService.java:
752 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
753 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
754 Added getReports(document, table, localeID), calling
755 ConfiguredDocument.getReports().
756 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
757 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
758 Added setReportsList() and a list widget.
759 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
760 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
765 2012-04-12 Murray Cumming <murrayc@murrayc.com>
767 Translations: Add Esperanto.
769 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
770 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
771 properties: Add this translation because someone took the time to make it.
773 2012-03-15 Murray Cumming <murrayc@murrayc.com>
775 Adapt to the java-libglom 1.21.7 API.
777 * src/main/java/org/glom/web/server/ReportGenerator.java:
778 addToReport(): get_group_secondary_fields() is now
779 get_secondary_fields().
782 2012-03-15 Murray Cumming <murrayc@murrayc.com>
784 Use the latest java-libglom version.
786 * pom.xml: Use java-libglom 1.21.7.
788 2012-03-03 Ben Konrath <ben@bagu.org>
790 Display date and time in details view.
792 https://bugzilla.gnome.org/show_bug.cgi?id=671257
794 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
796 2012-03-05 Murray Cumming <murrayc@murrayc.com>
798 Require the latest java-libglom.
800 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
802 2012-03-04 Murray Cumming <murrayc@murrayc.com>
804 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
806 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
807 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
808 an empty quickfind string. I also corrected libglom to create only
809 empty where clauses for empty quickfind strings, but this avoids the
812 2012-02-24 Ben Konrath <ben@bagu.org>
814 Improve the tabs in the Notebook widget.
818 2012-01-30 Murray Cumming <murrayc@murrayc.com>
820 Translations: Try to translate the strings.
822 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
823 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
824 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
825 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
826 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
827 Take the Open translation from GTK+'s .po files.
828 Take the Details translation from Glom's po files.
829 I have added the other strings to Glom so we can get translations that way:
830 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
832 2012-01-27 Murray Cumming <murrayc@murrayc.com>
834 TableSelectionViewImpl: Put the search label and entry in a div.
836 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
837 Put the search widgets in a FlowTable so that the CSS can be used to
838 style them while keeping them together.
839 * src/main/webapp/style.css: Mention the new div.
841 2012-01-27 Murray Cumming <murrayc@murrayc.com>
843 Translate more strings in more locales.
845 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
846 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
847 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
848 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
849 Translate the "Details" and "Open" string too.
851 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
852 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
853 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
854 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
855 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
856 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
857 Add these new locales as placeholders though they currently contain English.
859 2012-01-27 Murray Cumming <murrayc@murrayc.com>
861 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
863 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
864 Check the ConfiguredDocument* for null before using it.
866 2012-01-26 Murray Cumming <murrayc@murrayc.com>
868 Tell Eclipse about the generated java files.
870 * .classpath: This lets it find OnlineGlomConstants.java.
871 It would be nice if Eclipse just used the maven build files.
873 2012-01-26 Murray Cumming <murrayc@murrayc.com>
875 Prevent a crash when no locale is specified in the URL.
877 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
878 Avoid returning a null string, obtained from
879 Window.Location.getParameter(). This caused a crash when it was
880 later passed to libglom's API.
881 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
882 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
883 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
884 guard against future null strings.
886 2012-01-26 Murray Cumming <murrayc@murrayc.com>
888 Use the ?locale= query param instead of the &lang= token param.
890 * src/main/java/org/glom/web/client/place/ListPlace.java
891 * src/main/java/org/glom/web/client/place/DetailsPlace.java
892 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
893 Remove the lang token key and value.
895 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
896 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
897 When the user selects a different locale from the chooser, use
898 Window.Location.assign() to change the URL, which then causes a reload.
900 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
901 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
902 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
903 * src/main/java/org/glom/web/client/activity/ListActivity.java
904 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
905 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
906 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
907 * src/main/java/org/glom/web/client/ui/ListView.java:
908 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
910 Remove localeID member variables and method/constructor parameters, instead
911 using Utils.getCurrentLocaleID() when we need a localID to pass to
914 2012-01-26 Murray Cumming <murrayc@murrayc.com>
916 Internationalize the UI strings.
918 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
919 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
920 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
921 because it is unused. Messages are apparently strings that can have
922 parameters, but we do not need that yet, so Contants will be enough for now.
923 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
924 to say that we support the en and de locales.
925 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
926 The original English strings.
927 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
928 Some German translations of the English strings.
929 The i18n goal then uses the .properties file to generate an
930 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
931 returns an implementation that returns the translated strings.
932 The documentation suggests putting these in src/java/*/client/, but it seems
933 best to put it in src/resources/*/client/.
934 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
935 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
936 instead of hard-coding them.
937 Note that we cannot import OnlineGlomConstants because it does not exist yet,
938 but that does not seem to stop the build, though it confuses Eclipse.
940 You can see the translated string by adding ?locale=de to the URL, like so:
941 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
943 2012-01-24 Murray Cumming <murrayc@murrayc.com>
945 Improve null/empty String checks.
947 * pom.xml: Add a dependency on commons-lang, to use
948 org.apache.commons.lang.StringUtils.
949 * src/main/java/org/glom/web/server/ConfiguredDocument.java
950 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
951 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
952 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
953 Use StringUtils.isEmpty().
955 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
956 StringUtils class with a static isEmpty() function because we
957 cannot use org.apache.commons.lang.StringUtils in client-side
958 GWT code because it (apparently) cannot be compiled to javascript.
959 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
960 * src/main/java/org/glom/web/client/activity/ListActivity.java
961 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
962 * src/main/java/org/glom/web/client/place/DetailsPlace.java
963 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
964 * src/main/java/org/glom/web/client/place/ListPlace.java
965 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
966 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
967 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
968 * src/main/java/org/glom/web/client/ui/details/Group.java
969 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
970 our StringUtils.isEmpty() function.
972 2012-01-24 Murray Cumming <murrayc@murrayc.com>
974 Update to the latest java-libglom API.
976 * pom.xml: Require java-libglom 1.21.4.
977 * src/main/java/org/glom/web/server/ConfiguredDocument.java
978 getDocumentInfo(), getListViewLayoutGroup():
979 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
981 * src/main/java/org/glom/web/server/database/DBAccess.java
982 getFieldsToShowForSQLQueryAddGroup(),
983 getPrimaryKeyLayoutItemField(): Replace get_database_title()
984 with either get_database_title_original() or
985 get_database_title(localeID).
987 2012-01-24 Murray Cumming <murrayc@murrayc.com>
989 ConfiguredDocument: Avoid a null pointer exception.
991 * src/main/java/org/glom/web/server/ConfiguredDocument.java
992 Initialize localeID to "" to avoid returning a null String which
993 causes a crash in java-libglom's swing-generated code.
995 2012-01-23 Murray Cumming <murrayc@murrayc.com>
997 Some simple renaming.
999 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1000 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1001 for localeChooser. This seems more appropriate and is less ambiguous
1002 particularly in the .css file.
1004 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1006 ConfiguredDocument: Rename the localedID private member variable.
1008 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1010 Adapt to the latest java-libglom API from git master.
1012 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1013 libglom now uses only Vector instead of List, which uses add() instead of
1016 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1018 ConfiguredDocument: Rename the localedID private member variable.
1020 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1022 Build a source tarball with mvn assembly:single
1024 * assembly.xml: Add this file.
1025 * pom.xml: Use the maven-assembly-plugin and tell it to use
1026 our assembly.xml file.
1028 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1030 OnlineGlomServiceImpl: Get .glom files recursively.
1032 * pom.xml: Depend on commons-io from org.apache.commons.
1033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1034 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1035 files recursively, and with the easier filter for the extension.
1036 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1037 simplify that code too.
1039 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1041 README: Mention that you must install java-libglom packages separately.
1043 But then it works, because java-libglom is now in the central maven
1046 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1048 locales drop-down: Show the correct selected locale when the URL changes.
1050 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1051 .java: setPlace(): Move some code into fillView().
1053 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1055 locales drop-down: Do not lose the primary key.
1057 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1058 start(): onLocaleChange(): Pass the current primary key value,
1059 instead of an empty value.
1061 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1063 locales drop-down: Do not lose the drop-down selection.
1065 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1066 .java (TableSelectionActivity.fillView): Set the selected locale
1067 after changing the drop-down items (though we do not really need
1068 to change them just because the locale changes.)
1070 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1072 locales drop-down: Change the tables list when this changes.
1074 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1075 .java: TableSelectionActivity.start(): Move the async table titles
1076 retrieval into a private fillView() method and also call this when
1077 the chosen locale changes.
1078 Note that the document title is not actually translatable yet, but
1079 that is a problem that I should fix soon in libglom.
1081 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1083 Improve the placement of the locales drop-down.
1085 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1086 Put the title and locales drop-down in a div (gwt.FlowTable).
1087 * src/main/webapp/style.css: Add magic css properties to make this work.
1088 Also remove the left margin from the title so that it lines up with the
1091 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1093 locales selector: Show human-readable locale titles.
1095 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1096 getDocumentInfo(): Use java.util.Locale to show a real title of
1097 each locale, in the locale's own language.
1099 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1101 Add a language/locale selector drop-down.
1103 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1104 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1105 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1106 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1107 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1108 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1109 Add a ListBox to show the available locales. Add getLocaleSelector(),
1110 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1111 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1112 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1113 java: Add these classes.
1114 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1115 start(): Fill the locales ListBox. Handle its change event, firing a
1117 setPlace(): Show the selected locale as specified by the URL token.
1118 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1119 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1120 Handle LocaleChangeEvent, going to a new *Place with that locale.
1122 The placement of the ListBox is not pretty, and it currently uses the ID
1123 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1127 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1129 Search box: Show the search text from the URL token.
1131 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1132 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1133 Add setQuickFindText().
1134 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1135 .java: setPlace(): Store the queryText if the place is a ListPlace,
1136 and call TableSelectionView.setQuickFindText().
1138 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1140 Allow use of translations via, for instance, &lang=de in the URL.
1142 * pom.xml: Use the unstable java-libglom 1.21 version.
1144 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1145 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1147 init(): Instead of calling TranslatableItem.set_current_locale()
1148 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1149 However, this is only for default locales, which are not needed to
1150 change the locale in the URL.
1151 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1152 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1153 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1154 layout for a particular locale.
1155 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1156 Add get/setDefaultLocaleID().
1157 getDocumentInfo(), getListViewData(), getRelatedListData(),
1158 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1159 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1160 localeID parameter, so we can get the layout for a particular locale.
1162 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1163 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1164 * src/main/java/org/glom/web/client/place/ListPlace.java:
1165 Parse and construct a lang parameter too.
1167 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1168 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1169 passed to subsequent methods and constructors.
1170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1171 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1172 Store the localeID from the *Place and pass it to other constructors
1173 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1175 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1176 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1177 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1178 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1179 * src/main/java/org/glom/web/client/ui/ListView.java:
1180 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1181 Take localeID parameters and pass them to subsequent constructors and
1182 methods, so that the layout is always retrieved for that locale.
1184 This is rather repetitive.
1186 Note that "" means the original (default) locale of the Glom document,
1187 which is usually English.
1189 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1191 Documents: Remove final keyword to fix startup configuration.
1193 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1194 final keywords on the private member variables because that breaks
1195 the startup, apparently (there are warnings) because it stops them
1196 from being serialized. I added these in the previous commit.
1198 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1200 Documents: Add some final keywords.
1202 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1205 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1207 OnlineGlomServiceImpl: Add to overview comments.
1209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1210 Note that this is where all the document are loaded. They are not
1211 loaded freshly for each page.
1213 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1217 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1218 Add a TextBox for the text of a quick find.
1219 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1221 setBackLink(): Add a String quickFind parameter.
1222 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1223 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1224 to the base interface, because that is how TableSelectionViewImpl is used.
1225 * src/main/webapp/style.css: Add style for the search box and its label.
1227 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1228 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1229 Add these files, based on the existing TableChangeEvent and
1230 TableChangeEventHandlers.
1231 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1232 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1233 a ListPlace() that the user should be taken to.
1234 * src/main/java/org/glom/web/client/activity/ListActivity.java
1235 start(): Handle it here too and adapt the TableChangeEvent handler to
1236 pass the extra "" quickFind parameter to ListPlace.
1237 * src/main/java/org/glom/web/client/place/ListPlace.java:
1238 Constructor: Take an extra String quickFind parameter and store it,
1239 returning it from a new getQuickFind() method.
1240 getToken(): Put the quickFind text in the URL token.
1241 getPlace(): Parse the quickFind text from the URL token.
1242 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1243 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1244 ListPlace constructor.
1245 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1246 .java: start(): Add a Change handler for the TableSelectionView's
1247 TextBox (via its base HasChangeHandlers interface), firing the new
1248 QuickFindChangeEvent.
1249 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1250 pass the extra "" quickFind parameter.
1252 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1253 setCellTable(): Add a String quickFind parameter and pass it to
1254 the ListViewTable() constructor.
1255 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1256 setCellTable() in the base interface, because that is how ListViewImpl
1259 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1260 Add a String quickFind member variable.
1261 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1262 Constructor: Add a String quickFind parameter, storing it in the
1263 base ListTable's member variable.
1264 onRangeChanged(): Pass quickFind to the
1265 OnlineGlomServiceAsync.getSortedListViewData() and
1266 OnlineGlomServiceAsync.getListViewData() methods.
1268 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1269 getListViewData(), getSortedListViewData(): Add a String quickFind
1270 parameter, passing it to ConfiguredDocument.getListViewData().
1271 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1272 Change getListViewData(), getSortedListViewData() in the base interface,
1273 because that is how OnlineGlomServiceImpl is used, via this:
1274 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1275 Change getListViewData(), getSortedListViewData() here too.
1276 This class can apparently be used to asynchronously call methods on
1277 OnlineGlomService, and GWT seems to implement that after recognizing
1278 just the *Async name convention and the extra AsyncCallback parameters.
1280 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1281 getListViewData(): Add a String quickFind parameter, and pass it to
1282 ListViewDBAccess.getData().
1283 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1284 getListData(): Add a String quickFind parameter and pass it to
1286 getSelectQuery(): Add a String quickFind parameter.
1287 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1288 getSelectQuery(): Add a String quickFind parameter and use it with
1289 Glom.get_find_where_clause_quick() to pass a where_clause to
1290 Glom.build_sql_select_with_where_clause(), to actually filter the
1292 getData(): Add a String quickFind parameter, passing it to getListData().
1293 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1294 va: getData(): Pass an empty string to getListData() for the
1295 quickFind parameter.
1297 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1299 ListTable: Minor change.
1301 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1302 createCellTable(): Make this protected instead of public.
1304 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1306 Many files: Use final for the parameters and use the @override attribute.
1308 2012-01-22 Ben Konrath <ben@bagu.org>
1310 Add anchor links for single line text that starts with http, ftp and www.
1314 2012-01-22 Ben Konrath <ben@bagu.org>
1316 Add ellipsis to single line text in details view.
1320 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1322 Remove all javadoc author tags.
1324 Because they are awkward and meaningless when many people touch
1326 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1328 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1330 Revert the COPYING.LESSER to COPYING rename.
1332 Apparently both should be there if it is LGPL.
1334 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1336 *View: Remove unused imports.
1338 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1339 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1340 * src/main/java/org/glom/web/client/ui/ListView.java:
1341 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1342 Remove unused imports, as suggested by Eclipse.
1344 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1346 Move the *View::Presenter types, and some API into one base View.
1348 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1349 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1350 * src/main/java/org/glom/web/client/ui/ListView.java:
1351 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1352 Presenter, setPresenter() and clear() into a shared base interface,
1353 to avoid the unnecessary duplicate Presenter types and to more clearly
1354 show how the *Views share the same structure, even if they are not
1355 used polymorphically.
1357 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1358 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1360 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1361 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1362 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1364 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1367 Feel free to revert this if there is a good reason for the duplicate
1370 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1372 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1374 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1375 a class member instead of a local variable in the method.
1376 This lets us use it to get the view instances, for use in tests.
1377 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1378 beforeOnlineGlom(): Test some more details of the initial view.
1379 Again, this is not very useful.
1381 To really test gwt-glom we will need to start a local postgresql
1382 instance with local data, like the Glom tests in C++.
1384 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1386 pom.xml: Mention the LGPL license.
1388 * pom.xml: Add a licenses section.
1389 * COPYING.LESSER: Move this to COPYING, which
1390 previously contained the GPL. But gwt-glom is all LGPL.
1392 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1394 Add project information to README and pom.xml.
1396 * README: Add a brief description and mention some mvn
1398 * pom.xml: This extra information shows up in mvn site
1401 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1403 Use the latest java-libglom version.
1405 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1407 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1409 GwtTestOnlineGlom: Test a little more.
1411 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1412 protected rather than private, as suggested by the gwt-test-utils
1414 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1415 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1416 Test the initial visibility of the panels.
1418 However, this is not a very useful test.
1419 And I wonder how we should generally test using this idea for an
1420 activity/places app like ours where the real changes happen implicitly
1421 based on the history token/URL.
1423 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1425 Slight modification to *Mapper comments.
1427 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1428 (DataActivityMapper)
1429 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1431 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1433 Remove comments mentioning GIN because they are just copied from
1434 the example code and are apparently not helpful:
1435 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1436 Also change the mention of a class that is only in the example code.
1438 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1440 GwtTestOnlineGlom test: Minor changes.
1442 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1443 Avoid the long qualified class name and modify the comment
1444 because it is now obvious to me that the mocked class is the only
1445 custom one created via GWT.create().
1447 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1449 Tests: Added the beginnings of a test using gwt-test-utils.
1451 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1452 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1453 which tells gwt-test-utils what class will be tested.
1454 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1455 Add a simple (but empty) test case. One class, used by the OnlineGlom
1456 class, is mocked so that it can be created. However, I am not sure
1457 why only this class needs to be mocked.
1459 Note that mockito seems more popular, and clearer, than easymock,
1460 but I have not got that working yet. It might be a matter of the
1463 This test is run during mvn integration-test.
1465 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1467 Tests: Use junit4-style syntax instead of junit3-style.
1469 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1470 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1471 * src/test/java/org/glom/web/shared/DataItemTest.java:
1472 Use the @Test annotation rather than relying on the test*() prefix.
1473 Also no longer implement TestCase, to avoid triggering support for
1474 the junit3-way, which stops the annotations from working.
1475 Change the imports from import junit.framework.* to
1476 import org.junit.*, which is apparently the new way.
1478 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1480 Added a test for ListPlace token parsing and creation.
1482 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1483 This is much the same as DetailsPlaceTest.
1485 I wonder how we could test the other parts of the *Place API.
1487 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1489 DetailsPlace test: Also test getToken() and recreation via getPlace().
1491 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1492 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1493 recreate it, testing the recreated DetailsPlace for the same parameter
1496 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1498 Use the surefire-report plugin.
1500 * pom.xml: This generates a HTML report about the tests in
1501 target/site/surefire-report.html
1502 when you do mvn surefire-report:report. It seems to be popular/normal.
1504 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1506 Added a test for DetailsPlace.
1508 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1509 Test the getPlace() token parsing.
1511 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1513 Added a first unit test.
1515 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1516 * src/test/java/org/glom/web/shared/DataItemTest.java:
1517 This is a silly test but it is just to get things started. Note that
1518 maven/junit finds the test because it looks in src/test by default.
1520 2011-12-22 Ben Konrath <ben@bagu.org>
1522 Change charsetName to "UTF-8" when replacing line breaks.
1524 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1525 that work in Java (such as "UTF8") will not work when compiled to
1528 This fixes a problem with multi-line details view fields that have hard
1529 line breaks. The "License Text" field on this page demonstrates the
1532 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1534 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1536 2011-12-22 Ben Konrath <ben@bagu.org>
1538 Fix another bug with related list navigation.
1540 I've tested all the navigation buttons in all of the related lists
1541 so things should be good now.
1543 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1545 2011-12-22 Ben Konrath <ben@bagu.org>
1547 Fix a crasher when refreshing the list view with the default table.
1549 This crash will also happen when loading the list view with the default
1550 table from a link or bookmark.
1552 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1553 to the main document selection page when the document id hasn't been
1555 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1556 the main document selection page when the document id hasn't been
1558 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1559 values for the details place when the document id hasn't been set.
1560 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1561 values for the list place when the document id hasn't been set.
1563 2011-12-21 Ben Konrath <ben@bagu.org>
1565 Protect against NPE when glom.document.locale is not in config.
1567 This patch protects against an NPE when glom.document.locale is not in
1568 the config file. This NPE will also happen if glom.document.locale is
1571 The patch also updates the error message to display the class name when
1572 the getMessage() returns null. This was happening when the NPE was
1573 thrown and I had "Configuration Error: null". If an NPE is encountered
1574 with this patch, "Configuration Error: NullPointerException " will be
1577 This commit closes this bug:
1579 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1581 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1583 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1585 Rename onlineglom.properties to onlineglom.properties.sample.
1587 * src/main/resources/onlineglom.properties: Rename to:
1588 * src/main/resources/onlineglom.properties.sample:
1589 * src/main/resources/README: And add this file explaining that people
1590 should rename it back when deploying.
1592 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1594 Allow choosing the translation in the .properties file.
1596 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1597 init(): Read a glom.document.locale value from the configuration file
1598 and call Glom's TransatableItem::set_current_locale() method.
1599 * src/main/resources/onlineglom.properties: Add a commented-out
1600 example of this new setting.
1602 It would be better to add &lang=de_DE to the URL, but the current
1603 libglom API does not allow us to do this easily. I am working on that.
1605 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1607 Avoid a crash in parsing of token parameters.
1609 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1610 ava: getTokenParams(): Do not crash if a parameter has a key but no
1611 value, and ignore parameters with neither.
1613 2011-12-17 Murray Cumming <murrayc@murayc.com>
1615 History token building/handling: Improve use of token parameters.
1617 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1618 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1619 and buildParamsToken(HashMap), for use by derived classes.
1620 Make the separator private because it is no longer be needed.
1621 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1622 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1623 instead of manual string concatenation.
1624 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1625 of hardcoded indices and awkward splitting code.
1626 * src/main/java/org/glom/web/client/place/ListPlace.java
1627 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1628 instead of manual string concatenation.
1629 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1630 of hardcoded indices and awkward splitting code.
1631 This should fix bug #666420
1633 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1635 Fix a Navgiation->Navigation typo in the code.
1637 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1638 Rename processNavgiation() to processNavigation().
1640 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1642 Fix a seperator->separator typo in the code.
1644 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1645 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1646 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1649 2011-12-15 Ben Konrath <ben@bagu.org>
1651 Cleanup some comments.
1653 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1655 2011-12-14 Ben Konrath <ben@bagu.org>
1657 Replace \n with <br/> for multiline text in the details view.
1659 Vertical scrollbars are added when needed as well.
1661 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1663 2011-12-14 Ben Konrath <ben@bagu.org>
1665 Specify the font for document selection links.
1667 * src/main/webapp/style.css:
1669 2011-12-14 Ben Konrath <ben@bagu.org>
1671 Fix bouncy CellTable while paging.
1673 This doesn't currently work with related list tables in unselected
1676 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1678 2011-12-14 Ben Konrath <ben@bagu.org>
1680 Revamp the appearance of the document selection page.
1682 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1683 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1684 * src/main/webapp/style.css:
1686 2011-12-13 Ben Konrath <ben@bagu.org>
1688 Set navigation button column to the smallest size possible.
1690 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1692 2011-12-13 Ben Konrath <ben@bagu.org>
1694 Change OpenButton nomenclature to NavigationButton.
1696 Using NavigtionButton makes things more generic. Classes, methods and
1697 variables have been changed.
1699 This is a rename-only refactor.
1701 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1702 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1703 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1704 Renamed from OpenButtonCell.
1705 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1706 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1707 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1709 2011-12-12 Ben Konrath <ben@bagu.org>
1711 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1713 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1714 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1715 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1716 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1718 2011-12-12 Ben Konrath <ben@bagu.org>
1720 Update variable names and comments.
1722 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1723 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1725 2011-12-12 Ben Konrath <ben@bagu.org>
1727 Properly initialize numNonEmptyRows variable to zero.
1729 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1730 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1732 2011-12-05 Ben Konrath <ben@bagu.org>
1734 Add latest mockup with HTML tables.
1736 Features of this mockup:
1738 -> HTML table for flowtable
1739 -> HTML table for flowtable column
1740 -> Example of how related lists would look
1741 -> Not using text entries for data items
1743 The current version of Online Glom doesn't use HTML tables for the
1746 This mockup has been sent to the glom-devel mailing list but it's good
1747 to have it here as well.
1749 * mockups/details-view-html-tables.html:
1751 2011-12-05 Ben Konrath <ben@bagu.org>
1753 Remove unnecessary getPrimaryKeyField() method.
1755 getPrimaryKeyFieldForTable(String) has been renamed to
1756 getPrimaryKeyField(String).
1758 * src/main/java/org/glom/web/server/database/DBAccess.java:
1759 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1760 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1762 2011-12-05 Ben Konrath <ben@bagu.org>
1764 Add string representation of TypedDataItem value to conversion error message.
1766 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1767 message was extracted into its own method to avoid duplication.
1769 2011-12-05 Ben Konrath <ben@bagu.org>
1771 Add type checking to navigation primary key value creation.
1773 Create navigation primary key only if the expected type from the Glom
1774 document matches the type returned by the SQL query.
1776 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1778 2011-12-05 Ben Konrath <ben@bagu.org>
1780 Rename a couple of variables in RelatedListNavigation.
1782 This is a rename-only refactor.
1784 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1786 2011-12-05 Ben Konrath <ben@bagu.org>
1788 Move getListLayoutGroup() into getListViewLayoutGroup().
1790 This removes getListLayoutGroup(). It was only being called by
1791 getListViewLayoutGroup().
1793 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1795 2011-12-05 Ben Konrath <ben@bagu.org>
1797 Remove check for LayoutItem_Portal in list table method.
1799 This check is no longer necessary because the method isn't being used
1800 to create the LayoutItemPortal DTO.
1802 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1804 2011-12-05 Ben Konrath <ben@bagu.org>
1806 Properly support related list navigation.
1808 Navigation from the "Repository Analyzer -> Package Scans ->
1809 Dependencies" related table wasn't working because the primary key for
1810 related tables wasn't being set properly. This commit fixes the
1813 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1814 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1815 doesn't set the primary key properly for related list tables.
1816 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1817 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1818 useful for getting the primary key for list view tables and for related
1820 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1821 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1822 Move code to set the primary key for the table from the abstract
1823 ListDBAccess class to ListViewDBAccess as it's only correct for list
1825 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1826 Properly add primary key to related list tables.
1828 2011-12-02 Ben Konrath <ben@bagu.org>
1830 Properly set the horizontal alignment of fields.
1832 This fix is for both the list tables and the details view.
1834 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1835 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1836 to set the horizontal alignment of fields.
1838 2011-12-02 Ben Konrath <ben@bagu.org>
1840 Display currency codes in the details view.
1842 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1844 2011-12-02 Ben Konrath <ben@bagu.org>
1846 Avoid duplicate JNI call.
1848 JNI is not as efficient as pure Java and this is an easy (and small)
1851 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1852 Use previously retrieved value for whereClauseToTableName instead of
1855 2011-12-02 Ben Konrath <ben@bagu.org>
1857 Rename a couple of variables in RelatedListNavigation.
1859 This is a rename-only refactor.
1861 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1863 2011-12-02 Ben Konrath <ben@bagu.org>
1865 Indicate clearly that a mismatched primary key type is a bug.
1867 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1868 warning to error. Add 'This is a bug.' to message.
1870 2011-12-02 Ben Konrath <ben@bagu.org>
1872 Update / fix some comments.
1874 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1876 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1878 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1879 Fix comments. Add some TODOs.
1881 2011-12-02 Ben Konrath <ben@bagu.org>
1883 Enable navigation to details view with string primary key from related list.
1885 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1886 Create a text primary key value when return type of result is
1887 java.sql.Types.VARCHAR.
1889 2011-12-02 Ben Konrath <ben@bagu.org>
1891 Use checkboxes for booleans in the details view.
1893 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1895 2011-12-01 Ben Konrath <ben@bagu.org>
1897 Improve performance of related list height calculation.
1899 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1900 Put code to calculate the expected height in a static initializer so
1901 that that it's only called once.
1903 2011-12-01 Ben Konrath <ben@bagu.org>
1905 Show related list tables in notebooks (again).
1907 Calculate the height of the related list tables so the Notebook can be
1908 set the correct height. The height of the related list table is also needed by
1909 FlowTable to be able decide how to create the layout.
1911 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1912 and set the Portal height based on the height of the related list
1913 table and the Portal container.
1914 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1915 Add method to calculate the height of the related list tables.
1916 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1917 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1918 calculate the height of the Pager widget.
1920 2011-12-01 Ben Konrath <ben@bagu.org>
1922 Use CellTable API for table property instead of setting style on Element.
1924 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1926 2011-12-01 Ben Konrath <ben@bagu.org>
1928 Make ListViewTable and RelatedListTable a consistent height.
1930 The tables are now a consistent height regardless of the contents of
1931 the table. A hidden button is added to empty rows to ensure that the
1932 height of these rows will match the height of rows with data.
1934 A navigation button column is now added to every table. The width of
1935 the navigation column is set to 0px when a RelatedListTable shouldn't
1936 have navigation buttons. This maintains the a consistent row height in
1937 tables that don't show the navigation buttons.
1939 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1940 navigation column when not needed.
1941 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1942 arguments for navigation button to constructor of ListViewTable.
1943 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1944 hidden button for empty data rows.
1945 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1946 arguments for navigation button to constructor.
1947 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1948 create navigation buttons. Add hideNavigationButtons() method.
1949 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1950 arguments for navigation button to constructor.
1952 2011-12-01 Ben Konrath <ben@bagu.org>
1954 Use 'visibility: hidden' in Utils.getWidgetHeight().
1956 This is better choice because hidden elements are invisible, don't
1957 respond to events and are not part of the tab order. They will,
1958 however, take up space which is required to be able to calculate the
1959 height of the widget.
1961 * src/main/java/org/glom/web/client/Utils.java:
1963 2011-12-01 Ben Konrath <ben@bagu.org>
1965 Use Utils.getWidgetHeight() in FlowTable.
1967 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1969 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1971 2011-12-01 Ben Konrath <ben@bagu.org>
1973 Put the details css class name on the correct table column.
1975 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1977 2011-11-30 Ben Konrath <ben@bagu.org>
1979 Update for java-libglom API change.
1981 The getters and setters on FieldFormatting and NumericFormat were
1982 changed to remove the 'M'.
1984 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1986 2011-11-29 Ben Konrath <ben@bagu.org>
1988 Only allow RelatedListTables in Portals.
1990 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1992 2011-11-29 Ben Konrath <ben@bagu.org>
1994 Only create a contents panel for Portals when title is being set.
1996 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1998 2011-11-29 Ben Konrath <ben@bagu.org>
2000 Set TabLayoutPanel height based on calculated height its widgets.
2002 This is a potential fix for this bug:
2004 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2006 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2008 2011-11-29 Ben Konrath <ben@bagu.org>
2010 Align details field labels and data with the Open buttons.
2012 * src/main/webapp/style.css:
2014 2011-11-29 Ben Konrath <ben@bagu.org>
2016 Remove unnecessary <div> in the Notebook widget.
2018 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2019 method to get container FlowPanel (<div>).
2020 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2021 initWidget() method directly on the TabLayoutPanel widget instead of
2022 Group's container widget.
2024 2011-11-29 Ben Konrath <ben@bagu.org>
2026 Don't add group titles for Portals in Notebooks.
2028 This reverts the previous patch and fixes a bug I introduced with
2029 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2031 * src/main/java/org/glom/web/client/ui/details/Group.java:
2032 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2034 2011-11-28 Ben Konrath <ben@bagu.org>
2036 Remove unused boolean argument in Portal constructor.
2038 Just a code cleanup.
2040 * src/main/java/org/glom/web/client/ui/details/Group.java:
2041 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2043 2011-11-28 Ben Konrath <ben@bagu.org>
2045 Remove hack for glom 1.18 style glom files.
2047 * src/main/java/org/glom/web/client/ui/details/Group.java:
2048 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2049 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2051 2011-11-28 Ben Konrath <ben@bagu.org>
2053 Use Gda Value version of primary key to log result too large error.
2055 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2057 2011-11-28 Ben Konrath <ben@bagu.org>
2059 Don't use TypedDataItem.getText() for Unknown types from the URL.
2061 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2062 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2063 instead of getText().
2064 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2065 String field and getUnknown() method.
2067 2011-11-28 Ben Konrath <ben@bagu.org>
2069 Log an error message when the java-libglom .so is not present.
2071 The error message was being set in the exception but not logged.
2073 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2075 2011-11-28 Ben Konrath <ben@bagu.org>
2077 Ignore LayoutItem_CalendarPortals.
2079 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2080 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2082 2011-11-28 Ben Konrath <ben@bagu.org>
2084 Extract method for creating the LayoutItemPortal DTO.
2086 Just breaking the code up into smaller chunks.
2088 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2090 2011-11-28 Ben Konrath <ben@bagu.org>
2094 This should have been added with the refactor. Oops!
2096 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2098 2011-11-28 Ben Konrath <ben@bagu.org>
2100 Create primary key value from URL string using type from Glom document.
2102 See this bug, comments 19 - 25:
2104 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2106 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2107 create a TypeDataItem for the primary key here when loading from a
2108 URL. Show the same string for the primary key value as was received
2109 from the URL string (when loading from a URL).
2110 * src/main/java/org/glom/web/server/Utils.java: Update method for
2111 creating the Gda Value from the TypeDataItem to properly deal with
2112 creating a Gda Value based on the Glom document type for the primary
2113 key value string when loading from a URL.
2114 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2115 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2116 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2117 Update for changed method name.
2119 2011-11-27 Ben Konrath <ben@bagu.org>
2121 Rename PrimaryKeyItem to TypedDataItem.
2123 The name PrimaryKeyItem suggests what the class should be used for.
2124 TypedDataItem is a neutral name that describes the class better.
2126 This is a rename-only refactor.
2128 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2129 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2130 * src/main/java/org/glom/web/client/Utils.java:
2131 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2132 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2133 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2134 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2135 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2136 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2137 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2138 * src/main/java/org/glom/web/server/Utils.java:
2139 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2140 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2141 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2142 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2144 2011-11-25 Ben Konrath <ben@bagu.org>
2146 Improve Gda Value conversion from PrimaryKeyItem.
2148 The value from the PrimaryKeyItem is only used if its type match the
2149 type from the glom document.
2151 * src/main/java/org/glom/web/server/Utils.java:
2153 2011-11-25 Ben Konrath <ben@bagu.org>
2155 Manually check if the java-liblgom .so is visible to the JVM.
2157 It seems that Tomcat has problems when a static initializer throws an
2158 exception. This check is done before the first method call into
2159 java-libglom so that execution doesn't continue if the .so is not
2162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2164 2011-11-25 Ben Konrath <ben@bagu.org>
2166 Improve browser configuration error messages.
2170 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2172 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2173 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2174 getConfigurationErrorMessage() method.
2175 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2176 Get and display a specific configuration error message when no Glom
2177 documents are found.
2178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2179 Implement getConfigurationErrorMessage() method. Surround configuration
2180 code in the init() method with a try/catch block. This allows the
2181 errors to be caught while keeping the servlet available to retrieve the
2182 configuration error message.
2184 2011-11-25 Ben Konrath <ben@bagu.org>
2186 Don't use Strings to hold primary key values.
2188 The primary key values are now held in a new data object
2189 (PrimaryKeyItem) that holds type information and the primary key value
2190 using the correct type.
2192 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2193 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2195 PrimaryKeyItem instead of String to hold the primary key value.
2196 * src/main/java/org/glom/web/client/Utils.java: Remove
2197 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2198 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2199 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2200 PrimaryKeyItem instead of String to hold the primary key value. Load
2201 document selection page when the documentID has not been set correctly.
2202 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2203 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2205 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2206 Return empty string for URL instead of "null".
2207 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2208 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2209 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2210 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2211 PrimaryKeyItem instead of String to hold primary key values.
2212 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2213 PrimaryKeyValue to a Gda Value.
2214 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2215 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2216 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2217 Replace temporary database access code that uses the PrimaryKeyValue to
2218 Gda Value conversion.
2219 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2220 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2221 PrimaryKeyItem instead of String.
2222 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2223 hold primary key values.
2225 2011-11-24 Ben Konrath <ben@bagu.org>
2227 Use newly added java-libglom API to create queries.
2229 This isn't finished. I still need to stop using Strings for primary key
2230 values in the client code.
2232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2233 libglom to use fake connections so that retrieving the query string will
2235 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2236 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2237 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2238 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2239 Use the newly added libglom sql methods and classes to create the
2240 query. Add temporary hack to convert primary value strings to Gda
2243 2011-11-23 Ben Konrath <ben@bagu.org>
2245 Don't explicitly set the height of Portals.
2247 See comments 6 - 10 of this bug for details:
2249 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2251 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2253 2011-11-23 Ben Konrath <ben@bagu.org>
2255 Use an HTML table instead of CSS for the FlowTable layout.
2257 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2258 GWT's FlexTable to implement the FlowTable.
2259 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2261 2011-11-18 Ben Konrath <ben@bagu.org>
2263 Add boolean example to HTML table mockup.
2265 * mockups/details-view-html-tables-text-entries.html:
2267 2011-11-17 Ben Konrath <ben@bagu.org>
2269 Ensure the pager buttons are always visible for related lists.
2271 To accomplish this, I've turned off text wrapping in the list view and
2272 related list tables for both the header and data text. The related list
2273 table now has a fixed layout so the it doesn't overflow its container.
2274 This is required to ensure that the cell text is clipped when it
2275 overflows the cell and an ellipsis is added to the right side of the
2276 cell when text is clipped.
2278 A fixed table layout for the related list table in the details view
2279 seems what we want for the details view anyway, so the side-effect is
2282 The ellipsis will only be displayed in Firefox >= 7.
2286 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2288 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2289 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2290 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2292 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2293 Set the 'table-layout: fixed' CSS property to the related list table.
2294 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2295 'white-space: nowrap;' CSS property on both the list view and the
2296 related list tables.
2298 2011-11-16 Ben Konrath <ben@bagu.org>
2300 Rework the fix for empty notebook tab labels.
2302 Setting the empty group titles with its name caused problems for the
2303 details layout. Instead of using libglom's
2304 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2305 to the client when the title is empty. This allows the Notebook to use
2306 the name when the title is empty without affecting anything else.
2308 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2309 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2311 2011-11-16 Ben Konrath <ben@bagu.org>
2313 Set group titles with name when title is empty.
2315 This fixes a problem with an empty notebook tab label in the Lesson
2316 Planner document. The forth tab in the notebook should be "Internet":
2318 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2320 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2321 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2324 2011-11-16 Ben Konrath <ben@bagu.org>
2326 Remove whitespace from the configured username properties.
2328 This assumes that usernames won't have whitespace at the beginning
2329 or end. But I think this is a reasonable assumption.
2331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2332 String.trim() to remove the whitespace from the username properties.
2334 2011-11-15 Ben Konrath <ben@bagu.org>
2336 Add details view mockup with HTML tables and text entries.
2338 This is from the attachment on this bug:
2340 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2342 * mockups/details-view-html-tables-text-entries.html:
2344 2011-11-15 Ben Konrath <ben@bagu.org>
2346 Add space between the columns of the flow table.
2350 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2352 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2353 space between columns in the flow table.
2355 2011-11-15 Ben Konrath <ben@bagu.org>
2357 Add backup files to the .gitignore.
2359 * .gitignore: Ignore files that end with ~.
2361 2011-11-09 Ben Konrath <ben@bagu.org>
2363 Use latest release of gwt-log.
2365 Gwt-log releases are now being submitted to the maven central
2366 repository so manual installation of the jar is no longer required.
2368 * pom.xml: Update version and groupId of gwt-log dependency.
2370 2011-10-31 Ben Konrath <ben@bagu.org>
2372 Don't use GWT numeric formatting to override the glom currency formatting.
2374 Currencies are now displayed like they are in Glom. See this bug:
2376 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2378 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2380 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2381 currency code to constructor and set it when the cell is rendered.
2382 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2383 currency code to the constructor of the NumericCell.
2385 2011-10-27 Ben Konrath <ben@bagu.org>
2387 Require the latest release of java-libglom (1.17.4).
2391 2011-10-26 Ben Konrath <ben@bagu.org>
2393 Add style to Notebook that matches current theme.
2395 It's not the best style in the world but it's better than the default.
2397 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2398 padding at the bottom of the child widgets.
2399 * src/main/webapp/style.css: Add style for the Notebook.
2401 2011-10-26 Ben Konrath <ben@bagu.org>
2403 Move servlet initialization code to overridden init method.
2405 This is half of the solution to getting proper error messages
2406 displayed when configuration errors occur. Here's the relevant bug:
2408 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2410 The rest of the solution involves surrounding the init method with a
2411 try/catch block and setting a global variable with the error /
2412 exception. A new async method should be created to retrieve and display
2413 the error message / exception.
2415 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2416 code from constructor to init method adding exceptions as needed.
2418 2011-10-26 Ben Konrath <ben@bagu.org>
2420 Add script to monitor and restart tomcat if required.
2422 * utils/check-and-recover-tomcat.py: New file.
2424 2011-10-26 Ben Konrath <ben@bagu.org>
2426 Display the correct number of data items in the pager.
2430 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2432 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2433 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2434 The implementation is the same for both tables: Keep track of the
2435 number of non-empty rows and fire and RowCountChangeEvent after the data has
2437 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2438 custom Pager class that subclasses SimplePager to handle displaying
2439 the correct number when empty rows have been added.
2441 2011-10-26 Ben Konrath <ben@bagu.org>
2443 Correct error in previous commit.
2445 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2446 eventBus parameter from listView.setCellTable().
2448 2011-10-26 Ben Konrath <ben@bagu.org>
2450 Fix error in TODO comment.
2452 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2454 2011-10-24 Ben Konrath <ben@bagu.org>
2456 Create Notebook widgets to the details view.
2458 This isn't finished just yet - I still need to create a reasonable
2459 style to match the current theme.
2461 * src/main/java/org/glom/web/client/Utils.java: Add method for
2462 calculating the height of a widget. This is used in the Notebook class.
2463 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2464 new constructor method in Group.
2465 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2466 method for creating child widget that can be used by subclasses
2467 like Notebook. New constructor that allows disabling the group
2468 titles - Notebooks don't set a group title for their child groups.
2469 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2470 to make Notebooks using GWT's TabLayoutPanel.
2471 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2472 constructor that allows disabling the group titles.
2473 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2474 LayoutItemNotebook DTO.
2475 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2476 DTO for Notebooks. It's just an empty class for now but we might need
2477 it to transfer some specific information in the future.
2479 2011-10-21 Ben Konrath <ben@bagu.org>
2481 Add navigation buttons to related list tables.
2483 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2484 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2486 method getSuitableRecordToViewDetails() for getting the table name
2487 and primary key value for related list navigation buttons.
2488 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2489 private cell renderer class to get the navigation information for
2490 related list tables from the server. Extract the navigation
2491 processing code from the details cell navigation and use it for the
2492 related list navigation as well.
2493 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2494 cell renderer class for the details open buttons. This was needed
2495 because the related list navigation buttons and the list view
2496 navigation buttons need to react differently when clicked.
2497 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2498 the onEnterKeyDown() method because it's now overriden in the
2499 subclasses that are specific to the related list tables and the list
2501 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2502 the vertical size a little because the buttons add a bit of vertical
2503 space to table. This is not a perfect solution because the vertical
2504 size of with table fewer than 5 rows will be a little smaller.
2505 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2506 changes in how navigation buttons are handled.
2507 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2508 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2509 database access object.
2510 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2511 to find the portal for a given relationship name from
2512 RelatedListDBAccess. Add method to find a primary key field for a
2514 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2515 Move code to find the portal for a given relationship name to
2517 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2518 New file: database access object for getting the related list
2519 navigation information (the table name and the primary key value).
2520 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2521 DTO for transferring a table name to navigate to and a primary key
2523 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2524 boolean and getter/setter to specifies if the related list should add
2527 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2529 Use the master branch of java-libglom
2531 * pom.xml: Depend on java-libglom 1.19 instead.
2533 This is the master branch. See also the libglom-1-18 branch.
2535 2011-10-11 Ben Konrath <ben@bagu.org>
2537 Enable the open navigation button when the data has been set.
2539 This avoids having active buttons that don't do anything when the data
2542 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2544 2011-10-11 Ben Konrath <ben@bagu.org>
2546 Use IsWidget interface for FlowTableItem.
2548 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2549 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2551 2011-10-11 Ben Konrath <ben@bagu.org>
2553 Remove GWT styling from open button in details view.
2555 There are still some issues with how the details cell is arranged but
2556 this should be made to match Glom 1.20. I'm going to leave fixing this
2557 until I have Glom 1.20 up and running.
2559 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2560 style name on open button.
2561 * src/main/webapp/style.css: Move and edit details-navigation class.
2562 Re-arrange some classes to make them appear in the same order as the
2565 2011-10-07 Ben Konrath <ben@bagu.org>
2567 Update to GWT 2.4.0.
2569 * .gitignore: Ignore new cache directory.
2570 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2571 * pom.xml: Change GWT and maven plugin to 2.4.0.
2572 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2574 * src/main/java/org/glom/web/client/ClientFactory.java:
2575 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2576 * src/main/java/org/glom/web/client/OnlineGlom.java:
2577 Update source for API changes.
2578 * utils/build-onlineglom-war.sh: Remove cache directory before the
2581 2011-10-07 Ben Konrath <ben@bagu.org>
2583 Add navigation buttons in the details view.
2585 This isn't finished but I thought I'd commit what I have as it's a
2586 pretty good start. I still need to:
2588 1. Change the style so that it fits better into the current theme
2589 2. Adjust the details cell to expand as much as possible.
2591 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2592 click handlers to navigation buttons in the DetailsCells. Create a
2593 refreshData() method to get just the data from the server without the
2595 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2596 Update the tableSelector and browser title when the table name
2597 changes without using the tableSelector.
2598 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2599 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2600 getDetailsCells() to getCells(). Update variable names.
2601 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2602 method to set click handler on navigation button. Rename a few
2603 variables. Add navigation buttons where needed.
2604 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2605 variables and methods.
2606 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2607 navigation boolean and navigation table as required in the
2608 LayoutItemField DTO.
2609 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2610 variables for navigation along with getter/setter methods.
2612 2011-10-07 Ben Konrath <ben@bagu.org>
2614 Rename Field to DetailsCell.
2616 This is a refactor-only commit. No functionality has been added or
2619 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2620 Update variable and method names.
2621 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2622 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2623 variable and method names.
2624 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2626 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2627 variable and method names.
2629 2011-10-07 Ben Konrath <ben@bagu.org>
2631 Create separate methods for layout and data the details view.
2633 This is a refactor-only commit. No functionality has been added or
2636 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2637 private methods: setData(), createLayout().
2639 2011-10-07 Ben Konrath <ben@bagu.org>
2641 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2643 This is part of a change to get navigation buttons in the details view
2644 but it should have been done this way from the start.
2646 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2647 for method name change in TableSelectionView.
2648 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2649 Create TableChangeEvent and set the browser title using the
2650 TableSelectionView API.
2651 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2652 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2653 Change getSelectedTable() to getSelectedTableName(). Add
2654 getSelectedTableTitle().
2656 2011-10-07 Ben Konrath <ben@bagu.org>
2658 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2660 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2662 2011-10-07 Ben Konrath <ben@bagu.org>
2664 Update TableChangeEvent to use newTableName naming convention.
2666 This makes the class more consistent with GWT naming conventions.
2668 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2669 Update for method name change in TableChangeEvent.
2670 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2671 for method name change in TableChangeEvent.
2672 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2673 newTableName variable and getter method. Make toDebugString()
2676 2011-09-30 Ben Konrath <ben@bagu.org>
2678 Disable the pager in the list tables when the data row count is less than the minimum.
2680 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2681 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2683 2011-09-30 Ben Konrath <ben@bagu.org>
2685 Add empty rows to the end of related list and list view tables.
2687 I also extracted the cell rendering classes from the ListTable because
2688 the code was becoming a little crazy with all the anonymous inner
2689 classes. My plan is to use these cell rendering classes in the details
2690 view as well so this refactor will be needed for that change.
2692 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2693 set the row count in related list tables if the data has more rows
2694 than the minimum number of rows visible.
2695 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2696 row count in list view tables if the data has more rows than the
2697 minimum number of rows visible.
2698 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2699 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2701 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2702 for rendering TYPE_NUMERIC cells. The code was extracted from the
2704 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2705 class for rendering cells with buttons in list views. The code was
2706 extracted from the ListTable class.
2707 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2708 for rendering TYPE_TEXT cells. The code was extracted from the
2710 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2711 Add empty rows to the end of the data if required. Implement
2712 ListTable.getMinNumVisibleRows().
2713 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2714 cell renderer code to public classes. Return null in
2715 Column.getValue() for empty rows. Add new abstract method:
2716 getMinNumVisibleRows(). Move code to set the row count of the list view
2717 table to ListViewImpl.
2718 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2719 empty rows to the end of the data if required. Implement
2720 ListTable.getMinNumVisibleRows().
2723 2011-09-27 Ben Konrath <ben@bagu.org>
2725 Use GWT.log for client-side debugging statements.
2727 These are optimized out when deployed so I should have used this method
2728 in the first place. These statements will eventually be replaced with some sort
2729 of notification in the browser.
2731 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2732 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2733 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2734 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2735 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2737 2011-09-27 Ben Konrath <ben@bagu.org>
2739 Put tableselector on the right, back to list link on right.
2741 The idea is that the table selector is acting like a label for the
2742 currently displayed table so it should be placed below the document title. This
2743 puts the table title in a similar position to where it is in Glom.
2745 * mockups/details-contacts.html:
2746 * mockups/details-projects.html:
2747 * mockups/listview-contacts.html:
2748 * mockups/listview-projects.html:
2749 * mockups/style.css:
2750 Update mockups to match how the interfaces currently look.
2751 * src/main/webapp/style.css: Swap positions of backlink with the table
2752 selector. Add some space on the left side of the table selector to
2753 line things up with the document title.
2755 2011-09-27 Ben Konrath <ben@bagu.org>
2757 Add field colouring to details view.
2759 This change re-works how field colouring works. The colour formatting
2760 information is now set to the client with the layout information instead of
2761 with the data. This eliminates the need to send the same colour strings for
2762 data in list view column when colour information is set.
2764 In order to set an alternate colour for negative numeric values, the
2765 number is now sent to client and formatted with the GWT NumberFormat class.
2767 This change also fixes:
2769 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2771 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2772 internationalization framework which is needed for client side numeric
2774 * src/main/java/org/glom/web/client/Utils.java: New file for some
2775 client static utility methods.
2776 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2777 the DataItem object to the Field class. Use a utility method to
2778 create the foreignKeyValue string.
2779 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2780 alignment and text colours in the constructor. Add setData(DataItem)
2781 method. Remove setText(String) method.
2782 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2783 colour information to GlomTextCell. Create and use GlomNumberCell for
2784 rendering numbers. Use utility method to get the string for the
2785 primary key of the key provider. Re-work how the horizontal alignment
2787 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2788 formatting to layout information. Methods for converting the libglom
2789 formatting information were moved from DBAccess.
2790 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2791 numeric formatting (it's now done on the client side). Don't set text
2792 colours in DataItem. Move libglom formatting conversion methods to
2794 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2795 getters/setters for text colour information.
2796 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2797 for transferring the libglom NumericFormat information to the client.
2798 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2799 and getters/setters for: GlomNumericFormat, background colour and
2800 foreground colour strings.
2802 2011-09-26 Ben Konrath <ben@bagu.org>
2804 Simplify code that iterates through the LayoutGroup.
2806 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2808 2011-09-26 Ben Konrath <ben@bagu.org>
2810 Accept Eclipse formatting for OnlineGlomServiceAsync.
2812 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2814 2011-09-26 Ben Konrath <ben@bagu.org>
2816 Don't use the ListDBAccess classes to get the primary key layout information.
2818 This was causing a bug where the wrong index for the hidden primary key
2819 was being sent to the client.
2821 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2822 primary key while creating the LayoutGroup DTO. Create a
2823 LayoutItemField DTO for hidden primary keys. Don't use the
2824 RelatedListDBAccess because it was only used for getting the primary
2826 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2827 access modifier from public to protected for getPrimaryKeyField() and
2828 getPrimaryKeyLayoutItemField().
2829 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2830 abstract method getExpectedResultSize() because RelatedListDBAccess
2831 doesn't have enough info to implement it.
2832 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2833 Remove @Override for getExpectedResultSize().
2834 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2835 Remove method getExpectedResultSize().
2837 2011-09-23 Ben Konrath <ben@bagu.org>
2839 Log which layout (list or details) the ignored item is from.
2841 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2843 2011-09-23 Ben Konrath <ben@bagu.org>
2845 Remove annotations that turn off code formatting in DataItem.
2847 * src/main/java/org/glom/web/shared/DataItem.java:
2849 2011-09-23 Ben Konrath <ben@bagu.org>
2851 Rename GlomField to DataItem and update associated methods.
2853 This is a rename-only refactor. No functionality has been added or
2856 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2857 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2858 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2859 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2860 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2861 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2862 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2863 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2865 * src/main/java/org/glom/web/server/database/DBAccess.java:
2866 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2867 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2868 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2869 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2870 * src/main/java/org/glom/web/shared/DataItem.java:
2871 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2872 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2874 2011-09-23 Ben Konrath <ben@bagu.org>
2876 Rename GlomDocument to DocumentInfo and update associated methods.
2878 This is a rename-only refactor. No functionality has been added or
2881 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2882 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2883 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2884 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2885 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2886 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2887 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2889 2011-09-20 Ben Konrath <ben@bagu.org>
2891 Require java-libglom 1.17.3.
2893 This picks up the fix for the seg fault problem with the Scenes table
2894 in the Openismus Film Manager example.
2898 2011-09-20 Ben Konrath <ben@bagu.org>
2900 Change the way sort clause is added for primary key when no sort clause is requested.
2902 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2903 before the sort clause is created. When a sort clause is not requested, the
2904 sort clause is created by finding the primary key in the LayoutFieldVector
2907 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2909 2011-09-20 Ben Konrath <ben@bagu.org>
2911 Log error message if no documents are found in the configured directory.
2913 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2914 Extract the glom file extension string to a private static final class
2915 variable (mostly as syntactic sugar). Accept a minor formatting change.
2916 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2917 the example glom.document.directory configuration property to make it
2918 more clear that it can any directory, not just the home directory.
2920 2011-09-18 Ben Konrath <ben@bagu.org>
2922 Add related lists to details view.
2924 The related list table has support for paging and sorting just like the
2925 table in the list view.
2927 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2928 SQL queries for the related list tables.
2929 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2930 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2931 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2932 Rename getList methods to getListView and add comments. Remove
2933 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2934 it being unused. Add methods: getDetailsLayoutAndData(),
2935 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2936 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2937 Create the layout and set the data for the fields in one async call
2938 instead of two. Create related lists where appropriate.
2939 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2940 for method name changes in OnlineGlomService.
2941 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2942 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2943 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2945 * src/main/java/org/glom/web/client/ui/ListView.java:
2946 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2947 tableName from setCellTable(). Create a ListViewTable instead of
2949 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2950 represent a data field in the details view.
2951 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2952 from addDetailsCell() to Field class. Keep track of the Fields and
2953 Portals in the details view.
2954 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2955 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2956 and add a method to get it. Add method to set the contents of the
2958 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2959 New class for related list tables. This class has the data provider
2960 for the related list table.
2961 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2962 abstract class which is the base class for the ListViewTable and the
2964 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2965 New class for list view tables. This class has the data provider for
2966 the list view table.
2967 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2968 methods for related list tables. Add more information to the
2969 LayoutItemField and LayoutItemPortal DTOs.
2970 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2971 Remove debugging print statement.
2972 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2973 Remove debugging print statements. Add primary key field to SQL count
2975 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2976 Remove unnecessary LayoutFieldVector parameter from
2977 getResultSizeOfSQLQuery() method.
2978 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2979 New class for related list table database access.
2980 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2981 class that is a wrapper DTO for details view layout and data.
2982 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2983 new 'fromField' string to this DTO.
2984 * src/main/webapp/style.css: Remove bottom margin and override top
2987 2011-09-15 Ben Konrath <ben@bagu.org>
2989 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2991 This sets things up to make it easier to add the data retrieval for
2992 related lists (portals). No user noticeable changes were made with
2995 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2996 class has the code to retrieve the layouts and access the
2997 database using the new database helper classes.
2998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2999 Most of the functionality has been removed from this class. This
3000 class now represents the public interface for the client side
3001 code. It also deals with configuring the servlet and cleaning
3002 things up when the servlet is stopped.
3003 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3004 of static methods into this utility class.
3005 * src/main/java/org/glom/web/server/database/DBAccess.java:
3006 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3007 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3008 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3009 These classes have the database retrieval code. The class hierarchy
3010 has been setup to make it easy to reuse code for similar
3013 2011-09-06 Ben Konrath <ben@bagu.org>
3015 Create separate classes for list table code and the data provider.
3017 As part of this refactor, I also split up the code a bit to make it
3020 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3021 table code to two new classes (below).
3022 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3023 with code from ListViewImpl.
3024 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3025 New file with code from ListViewImpl.
3027 2011-09-06 Ben Konrath <ben@bagu.org>
3029 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3031 This fixes the LayoutItemPortal DTO to match the libglom layout object
3034 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3036 2011-09-01 Ben Konrath <ben@bagu.org>
3038 Set title of Portals in the Details View.
3040 * pom.xml: Bump required version of java-libglom to 1.17.1.
3041 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3042 widget creation to its own class. Add comments to constructor.
3043 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3044 The code is mostly from the Group class with the title now set.
3045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3046 title of Portal. Update some comments. Fix some code formatting.
3048 2011-09-01 Ben Konrath <ben@bagu.org>
3050 Remove TODO comment for the flow table column width.
3052 The flow table column width is working correctly and doesn't need to be
3053 changed. See this mailing list post for more info:
3055 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3057 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3059 2011-08-27 Ben Konrath <ben@bagu.org>
3061 Add document title (database name) to top of the browser page.
3063 I added the document title to the TableSelecitonView but that will
3064 change if / when we add a view that doesn't require table selection.
3066 * mockups/details-contacts.html:
3067 * mockups/details-projects.html:
3068 * mockups/listview-contacts.html:
3069 * mockups/listview-projects.html:
3070 * mockups/style.css: Add document title to mockups to keep things
3072 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3073 sizes to account for the document title.
3074 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3075 Set the document title when it has been retrieved from the server.
3076 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3077 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3078 and implement setDocumentTitle(String) method.
3079 * src/main/webapp/style.css: Add ID for document title style.
3081 2011-08-25 Ben Konrath <ben@bagu.org>
3083 Add NavigationType enum to LayoutItemPortal DTO.
3085 This is the start of adding support for Portals to the Details View.
3087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3088 LayoutItem_Portal.navigation_type enum from libglom to
3089 LayoutItemPortal.NavigationType enum.
3090 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3091 NavigationType enum, field for storing the NavigationType and getter
3094 2011-08-25 Ben Konrath <ben@bagu.org>
3096 Implement the flow table layout in the Details View.
3098 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3099 FlowTable to Group to account for the renamed class.
3100 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3101 File. This is a container widget that implements the Glom details view
3102 flow table behaviour.
3103 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3104 org/glom/web/client/ui/FlowTable.java.
3105 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3106 so that the size of the subgroups are a closer match to the size of
3107 the Glom subgroups. This makes the flowtable layout match the layout
3108 in Glom for the Music Collection example file.
3110 2011-08-16 Ben Konrath <ben@bagu.org>
3112 Create container element for LayoutItemPortal in Details View.
3114 This will help me develop the layout for the FlowTable.
3116 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3117 fieldPanel variable to detailsCell.
3119 2011-08-15 Ben Konrath <ben@bagu.org>
3121 Set the height of the data element in the Details View.
3123 I changed the InlineLabels (text in a span element) to Labels (text in
3124 a div element) so that I could set the height of the details-data
3125 elements instead of the details-cell parent elements. This allows the
3126 the details-data element to display the correct height if style is
3127 applied that shows the height.
3129 This change has the added benefit of allowing the order of the labels
3130 and data elements to be changed for right-to-left languages.
3132 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3133 InlineLabels to Labels.
3134 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3135 InlineLabels to Labels. Set the height of the data element.
3136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3137 multiline text height in the Formatting DTO.
3138 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3139 for multiline height along with getter and setter methods.
3140 * src/main/webapp/style.css: Adjust style to account for the change
3141 from span elements to div elements in the details cell.
3143 2011-08-15 Ben Konrath <ben@bagu.org>
3145 Make the List View appearance match the mockups.
3147 It doesn't match exactly but it's much better than it was.
3149 * mockups/listview-contacts.html: Remove unused css classes.
3150 * mockups/listview-projects.html: Remove unused css classes.
3151 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3152 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3153 for mainPanel instead of VerticalPanel (table). Set style name on
3154 CellTable. Set style name on Details column. Right-align Details
3156 * src/main/webapp/style.css: Adjust properties to match the mockups.
3158 2011-08-12 Ben Konrath <ben@bagu.org>
3160 Add better support for subgroups in the details view.
3162 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3163 changed FlowTable constructor.
3164 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3165 support for subgroups and subgroup-titles.
3166 * src/main/webapp/style.css: Add CSS class for subgroups and
3169 2011-08-12 Ben Konrath <ben@bagu.org>
3171 Return the top level LayoutGroup title.
3173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3175 2011-08-11 Ben Konrath <ben@bagu.org>
3177 Make the TableSelector header match the mockup.
3179 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3180 the layout panel. Properly lineup the table selection header with
3181 the list and details view.
3182 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3183 margin around the details view.
3184 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3185 Rename listBox variable to tableSelector. Set id for the style sheet.
3186 Use a FlowPanel instead of a HorizontalPanel.
3187 * src/main/webapp/style.css: Add properties to make the TableSelector
3188 box match the mockups.
3190 2011-07-13 Ben Konrath <ben@bagu.org>
3192 Update install script for java-libglom version change.
3194 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3197 2011-07-13 Ben Konrath <ben@bagu.org>
3199 Add support sub-group in the details view.
3201 I also removed the code that special-cased the default details view
3204 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3206 I still have to make a proper flowtable.
3208 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3209 Don't special-case default details view layout.
3210 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3211 addLayoutField() as I'm going to use it.
3212 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3213 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3215 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3216 extracted from DetailsViewImpl.GroupPanel. Add support for
3218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3219 column count when getting the details layout.
3221 2011-07-12 Ben Konrath <ben@bagu.org>
3223 Set browser title with database and table titles.
3225 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3226 Set the browser title when the table changes and when the activity
3228 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3229 title when retrieving document info (the GlomDocument object).
3230 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3231 with getter and setter methods. Remove unused convenience constructor.
3232 Use default code formatting.
3234 2011-07-12 Ben Konrath <ben@bagu.org>
3236 Ignore LayoutItemPortals in the details view.
3238 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3241 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3242 LayoutItemPortal layout objects.
3243 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3244 LayoutItemPortal objects when retrieving the details layout.
3245 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3246 file. This is an empty class and just used to get type information for
3249 2011-07-12 Ben Konrath <ben@bagu.org>
3251 Use java-libglom 1.17.0.
3255 2011-07-11 Ben Konrath <ben@bagu.org>
3257 Remove "Table:" label from table selector.
3259 This matches a recent change in the Glom UI.