3 2012-04-19 Murray Cumming <murrayc@murrayc.com>
5 Reports: Localize the waiting for report message.
7 * src/main/java/org/glom/web/client/activity/ReportActivity.java
8 start(): Get the message from the contants.
9 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
11 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
12 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
13 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
14 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
15 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
16 Update these files with the English text for newer strings for now.
18 2012-04-19 Murray Cumming <murrayc@murrayc.com>
20 Reports: Show a message while waiting for the report.
22 * src/main/java/org/glom/web/client/ui/ReportView.java
23 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
24 Add setWaitingText(), to show a message saying that we are
25 waiting for the report to be ready.
26 * src/main/java/org/glom/web/client/activity/ReportActivity.java
27 start(): Call setWaitingText() before calling the async
30 2012-04-19 Murray Cumming <murrayc@murrayc.com>
32 ReportGenerator: Specify date and time formats.
34 * src/main/java/org/glom/web/server/ReportGenerator.java:
35 createFieldValueElement(): Use the default (and localized)
36 short formats, though we still need a way to show 4-digit
37 years without providing the format for every locale.
38 * src/main/java/org/glom/web/server/database/DBAccess.java:
39 convertResultSetToDTO(): Use the short formats here too.
41 2012-04-18 Murray Cumming <murrayc@murrayc.com>
43 ReportGenerator: Use the correct numeric formatting.
45 * src/main/java/org/glom/web/server/ReportGenerator.java
46 createFieldExpression(), createFieldValueElement(): Take the
47 whole LayoutItem_Field instead of just the field name, so
48 we have access to the formatting.
49 createFieldValueElement(): Use JRTextField.setPattern() to
50 specify the numeric formatting, with the help of a
51 regular DecimalFormat.
53 2012-04-18 Murray Cumming <murrayc@murrayc.com>
55 ReportGenerator: Avoid showing null for group by titles.
57 * src/main/java/org/glom/web/server/ReportGenerator.java
58 generateReport(): Use setBlankWhenNull() on the field title
59 style too, because this is used for values in group by
62 2012-04-18 Murray Cumming <murrayc@murrayc.com>
64 ReportGenerator: Add a colon to titles in vertical groups.
66 * src/main/java/org/glom/web/server/ReportGenerator.java
67 addFieldToDetailBandVertical(): Pass true for the withColon
70 2012-04-18 Murray Cumming <murrayc@murrayc.com>
72 ReportGenerator: Simplify the code by using Position more.
74 2012-04-18 Murray Cumming <murrayc@murrayc.com>
76 Reports: Support vertical groups, roughly.
78 * src/main/java/org/glom/web/server/ReportGenerator.java:
79 addToReport(): Rename to addGroupToReport() and, if necessary,
80 call the new addVerticalGroupToReport() method.
81 createFieldValueElement(): Let the caller specify the Y position
84 2012-04-17 Murray Cumming <murrayc@murrayc.com>
86 Reports: Allow a second report to be shown.
88 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
89 clear(): Do not remove the HTML widget, which broke the whole layout.
91 2012-04-17 Murray Cumming <murrayc@murrayc.com>
93 Locales drop-down: Show that we use English by default.
95 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
96 fillView(): When we use English, just because that is the default, when
97 no locale is specified, show that in the Locales drop-down instead of
98 just showing the first item.
100 2012-04-17 Murray Cumming <murrayc@murrayc.com>
102 Unselect the Report/Locale/Table combo item when appropriate.
104 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
105 setPlace(): clear reportName if this is not a ReportPlace.
106 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
107 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
108 When the provided name is empty, unselect all items, so that none are
109 indicated. This uses a for loop because I cannot find a single method
112 2012-04-17 Murray Cumming <murrayc@murrayc.com>
114 Report: Give the user a way to get back to the list.
116 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
117 start(), setPlace(): Show the Back To List link on reports, and also
118 interpret selecting the empty report item as back to list.
120 2012-04-17 Murray Cumming <murrayc@murrayc.com>
122 Style: Remove overflow:hidden from searchbox
124 * src/main/webapp/style.css: Because this pushes the Back To Link
125 label/link on to the next row, which is then hidden due to the
126 hard-coded (in ems) height.
128 2012-04-13 Murray Cumming <murrayc@murrayc.com>
130 Really show the selected Report name.
132 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
133 setPlace(): Store the reportName here, if it is that kind of Place.
134 fillView(): Set the selected Report after filling the list of reports.
135 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
136 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
137 null Strings, though we need some way to unselect all ListBox items
140 2012-04-13 Murray Cumming <murrayc@murrayc.com>
142 ReportGenerator: Try to avoid some problems.
144 * src/main/java/org/glom/web/server/ReportGenerator.java
145 addField(): Try to avoid duplicates, and avoid using a null
148 2012-04-13 Murray Cumming <murrayc@murrayc.com>
150 Reports: Use quickFind.
152 * src/main/java/org/glom/web/client/OnlineGlomService.java;
153 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
154 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
155 getReportHTML(): Add a quickFind parameter.
156 * src/main/java/org/glom/web/client/activity/ReportActivity.java
157 start(): Pass the quickFind parameter.
158 * src/main/java/org/glom/web/server/ReportGenerator.java
159 generateReport(): Take a quickFind parameter.
161 2012-04-13 Murray Cumming <murrayc@murrayc.com>
163 ReportPlace: Actually use the report name.
165 * src/main/java/org/glom/web/client/place/ReportPlace.java
166 getPlace(): Do not assign the report name to the quickfind.
168 2012-04-13 Murray Cumming <murrayc@murrayc.com>
170 Show java.library.path when complaining.
172 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
173 init(): When telling us to check java.library.path, show the
176 2012-03-06 Murray Cumming <murrayc@murrayc.com>
178 ReportGenerator: Do not show nulls.
180 2012-03-06 Murray Cumming <murrayc@murrayc.com>
182 ReportGenerator: Make the title font larger.
184 2012-03-06 Murray Cumming <murrayc@murrayc.com>
186 ReportGenerator: Put field titles inside groups, if there are groups.
188 2012-03-06 Murray Cumming <murrayc@murrayc.com>
190 ReportGenerator: Take the Report itself instead of the name and group.
192 * src/main/java/org/glom/web/server/ConfiguredDocument.java
193 Remove getReportLayoutGroup().
194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
195 getReportHTML(): Pass the report instead
196 of its name and layout group.
197 * src/main/java/org/glom/web/server/ReportGenerator.java
198 generateReport(): Use the report object to use the title
201 2012-03-06 Murray Cumming <murrayc@murrayc.com>
203 ReportGenerator: Remove designBand parameters.
205 * src/main/java/org/glom/web/server/ReportGenerator.java:
206 Make designBand a class member instead of passing it to all
209 2012-03-06 Murray Cumming <murrayc@murrayc.com>
211 ReportGenerator: Add lines, a bit like in the desktop version.
213 * src/main/java/org/glom/web/server/ReportGenerator.java
214 addToReport(): Use JRDesignLine.
216 2012-03-06 Murray Cumming <murrayc@murrayc.com>
218 ReportGenerator: Correct the title positions and use some bold style.
220 * src/main/java/org/glom/web/server/ReportGenerator.java:
221 Break the code up into reusable functions, correct the placement of
222 titles, and use normal/bold styles as in the reports in the desktop
225 2012-03-06 Murray Cumming <murrayc@murrayc.com>
227 ReportGenerator: Add a header band to show the field titles.
229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
230 getReportHTML(): Pass the localeId to the ReportGenerator
232 * src/main/java/org/glom/web/server/ReportGenerator.java
233 constructor: Take the localeID so we can get translated field
235 generateReport(), addToReport(), addFieldToBand(): Add field
236 titles in a column header band.
238 2012-03-05 Murray Cumming <murrayc@murrayc.com>
240 Reports drop-down list: Some improvement.
242 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
243 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
244 Adedd setSelectedReport(),
245 setReportList(): Add a blank line so that the user can select the
247 * src/main/java/org/glom/web/client/activity/ReportActivity.java
248 start(): Show the current report by calling setSelectedReport().
249 This does not seem to work yet.
251 2012-03-05 Murray Cumming <murrayc@murrayc.com>
253 DetailsActivity, ListActivity: Move some variables into a base class.
255 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
256 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
257 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
258 the clientFactory, documentID, tableName and authenticationPopup into
259 a base class, to avoid duplication.
261 2012-03-05 Murray Cumming <murrayc@murrayc.com>
263 Translate the Reports label.
265 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
266 Get the "Reports" label string from the constants.
267 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
268 perties: Add Reports to the constants.
270 2012-03-05 Murray Cumming <murrayc@murrayc.com>
272 Reports: Implement grouping.
274 * src/main/java/org/glom/web/server/ReportGenerator.java:
275 Handle LayoutItem_GroupBy items and try to do the right thing
276 with JRDesignGroup. It seems to work.
278 2012-03-04 Murray Cumming <murrayc@murrayc.com>
280 Actually show some data with JasperReports.
282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
283 getReportHTML(): Move most code into a ReportGenerator class.
284 * src/main/java/org/glom/web/server/ReportGenerator.java:
285 Recurse into sub-groups, adding fields to the JasperDesign's details
286 band. Note that we must set an arbitrary width and height, or it just
287 will not show any data.
289 2012-03-04 Murray Cumming <murrayc@murrayc.com>
291 Reports Chooser: Show the titles, not the names.
293 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
294 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
295 and the names as the values.
296 * src/main/java/org/glom/web/server/ConfiguredDocument.java
297 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
298 group now that we provide the report name, so it should always
301 2012-02-15 Murray Cumming <murrayc@murrayc.com>
303 Depend on jasperreports.
305 * pom.xml: Add the dependency. My plan is to use this on the
308 2012-01-31 Murray Cumming <murrayc@murrayc.com>
310 Implement navigation to report places.
312 * src/main/java/org/glom/web/client/activity/ReportActivity.java
313 start(): Do not bother to handle all events here.
314 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
315 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
316 Added getSelectedReport().
317 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
318 .java: start(): When handling a change to the reports chooser,
319 call getSelectedReport() and goTo() its ReportPlace.
320 * src/main/java/org/glom/web/client/ui/ReportView.java
321 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
322 Added setReportHTML() which puts the html in a gwt HTML widget.
323 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
324 getReportHTML(): Return "TODO" just to show that this works.
326 2012-01-31 Murray Cumming <murrayc@murrayc.com>
328 Make ReportPlace usable.
330 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
332 * src/main/java/org/glom/web/client/place/ReportPlace.java:
333 Correct the @prefix annotation.
335 2012-01-31 Murray Cumming <murrayc@murrayc.com>
337 OnlineGlomService: Return report HTML rather than the LayoutGroup.
339 * src/main/java/org/glom/web/client/OnlineGlomService.java:
340 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
341 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
342 Change getReportLayout() to getReportHMTL() because we will not need to
343 parse or render the report layout on the client side.
344 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
345 getReportLayout(): Return the libglom LayoutGroup type because we will
346 not need to convert to a shared type, because this will not be used on
348 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
351 Note that there is still no implementation for this.
354 2012-01-27 Murray Cumming <murrayc@murrayc.com>
356 Add a (empty) Report Place, View, and Activity.
358 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
360 * src/main/java/org/glom/web/client/place/HasTablePlace.java
361 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
362 this into a superclass:
363 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
364 and also use it as the base of this new ReportPlace:
365 * src/main/java/org/glom/web/client/place/ReportPlace.java
367 * src/main/java/org/glom/web/client/ui/ReportView.java
368 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
369 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
370 Add these, containing mostly boiler-plate for now.
372 * src/main/java/org/glom/web/client/OnlineGlomService.java
373 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
374 * src/main/java/org/glom/web/server/ConfiguredDocument.java
375 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
376 Add API to get the LayoutGroup for the report.
378 2012-01-23 Murray Cumming <murrayc@murrayc.com>
380 Add and fill a Reports drop-down list box.
382 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
384 * src/main/java/org/glom/web/client/OnlineGlomService.java:
385 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
387 Added getReports(document, table, localeID), calling
388 ConfiguredDocument.getReports().
389 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
390 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
391 Added setReportsList() and a list widget.
392 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
393 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
398 2012-04-12 Murray Cumming <murrayc@murrayc.com>
400 Translations: Add Esperanto.
402 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
403 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
404 properties: Add this translation because someone took the time to make it.
406 2012-03-15 Murray Cumming <murrayc@murrayc.com>
408 Adapt to the java-libglom 1.21.7 API.
410 * src/main/java/org/glom/web/server/ReportGenerator.java:
411 addToReport(): get_group_secondary_fields() is now
412 get_secondary_fields().
415 2012-03-15 Murray Cumming <murrayc@murrayc.com>
417 Use the latest java-libglom version.
419 * pom.xml: Use java-libglom 1.21.7.
421 2012-03-03 Ben Konrath <ben@bagu.org>
423 Display date and time in details view.
425 https://bugzilla.gnome.org/show_bug.cgi?id=671257
427 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
429 2012-03-05 Murray Cumming <murrayc@murrayc.com>
431 Require the latest java-libglom.
433 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
435 2012-03-04 Murray Cumming <murrayc@murrayc.com>
437 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
439 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
440 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
441 an empty quickfind string. I also corrected libglom to create only
442 empty where clauses for empty quickfind strings, but this avoids the
445 2012-02-24 Ben Konrath <ben@bagu.org>
447 Improve the tabs in the Notebook widget.
451 2012-01-30 Murray Cumming <murrayc@murrayc.com>
453 Translations: Try to translate the strings.
455 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
456 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
457 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
458 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
459 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
460 Take the Open translation from GTK+'s .po files.
461 Take the Details translation from Glom's po files.
462 I have added the other strings to Glom so we can get translations that way:
463 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
465 2012-01-27 Murray Cumming <murrayc@murrayc.com>
467 TableSelectionViewImpl: Put the search label and entry in a div.
469 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
470 Put the search widgets in a FlowTable so that the CSS can be used to
471 style them while keeping them together.
472 * src/main/webapp/style.css: Mention the new div.
474 2012-01-27 Murray Cumming <murrayc@murrayc.com>
476 Translate more strings in more locales.
478 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
479 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
480 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
481 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
482 Translate the "Details" and "Open" string too.
484 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
485 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
486 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
487 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
488 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
489 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
490 Add these new locales as placeholders though they currently contain English.
492 2012-01-27 Murray Cumming <murrayc@murrayc.com>
494 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
496 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
497 Check the ConfiguredDocument* for null before using it.
499 2012-01-26 Murray Cumming <murrayc@murrayc.com>
501 Tell Eclipse about the generated java files.
503 * .classpath: This lets it find OnlineGlomConstants.java.
504 It would be nice if Eclipse just used the maven build files.
506 2012-01-26 Murray Cumming <murrayc@murrayc.com>
508 Prevent a crash when no locale is specified in the URL.
510 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
511 Avoid returning a null string, obtained from
512 Window.Location.getParameter(). This caused a crash when it was
513 later passed to libglom's API.
514 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
515 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
516 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
517 guard against future null strings.
519 2012-01-26 Murray Cumming <murrayc@murrayc.com>
521 Use the ?locale= query param instead of the &lang= token param.
523 * src/main/java/org/glom/web/client/place/ListPlace.java
524 * src/main/java/org/glom/web/client/place/DetailsPlace.java
525 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
526 Remove the lang token key and value.
528 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
529 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
530 When the user selects a different locale from the chooser, use
531 Window.Location.assign() to change the URL, which then causes a reload.
533 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
534 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
535 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
536 * src/main/java/org/glom/web/client/activity/ListActivity.java
537 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
538 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
539 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
540 * src/main/java/org/glom/web/client/ui/ListView.java:
541 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
543 Remove localeID member variables and method/constructor parameters, instead
544 using Utils.getCurrentLocaleID() when we need a localID to pass to
547 2012-01-26 Murray Cumming <murrayc@murrayc.com>
549 Internationalize the UI strings.
551 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
552 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
553 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
554 because it is unused. Messages are apparently strings that can have
555 parameters, but we do not need that yet, so Contants will be enough for now.
556 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
557 to say that we support the en and de locales.
558 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
559 The original English strings.
560 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
561 Some German translations of the English strings.
562 The i18n goal then uses the .properties file to generate an
563 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
564 returns an implementation that returns the translated strings.
565 The documentation suggests putting these in src/java/*/client/, but it seems
566 best to put it in src/resources/*/client/.
567 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
568 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
569 instead of hard-coding them.
570 Note that we cannot import OnlineGlomConstants because it does not exist yet,
571 but that does not seem to stop the build, though it confuses Eclipse.
573 You can see the translated string by adding ?locale=de to the URL, like so:
574 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
576 2012-01-24 Murray Cumming <murrayc@murrayc.com>
578 Improve null/empty String checks.
580 * pom.xml: Add a dependency on commons-lang, to use
581 org.apache.commons.lang.StringUtils.
582 * src/main/java/org/glom/web/server/ConfiguredDocument.java
583 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
584 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
585 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
586 Use StringUtils.isEmpty().
588 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
589 StringUtils class with a static isEmpty() function because we
590 cannot use org.apache.commons.lang.StringUtils in client-side
591 GWT code because it (apparently) cannot be compiled to javascript.
592 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
593 * src/main/java/org/glom/web/client/activity/ListActivity.java
594 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
595 * src/main/java/org/glom/web/client/place/DetailsPlace.java
596 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
597 * src/main/java/org/glom/web/client/place/ListPlace.java
598 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
599 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
600 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
601 * src/main/java/org/glom/web/client/ui/details/Group.java
602 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
603 our StringUtils.isEmpty() function.
605 2012-01-24 Murray Cumming <murrayc@murrayc.com>
607 Update to the latest java-libglom API.
609 * pom.xml: Require java-libglom 1.21.4.
610 * src/main/java/org/glom/web/server/ConfiguredDocument.java
611 getDocumentInfo(), getListViewLayoutGroup():
612 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
614 * src/main/java/org/glom/web/server/database/DBAccess.java
615 getFieldsToShowForSQLQueryAddGroup(),
616 getPrimaryKeyLayoutItemField(): Replace get_database_title()
617 with either get_database_title_original() or
618 get_database_title(localeID).
620 2012-01-24 Murray Cumming <murrayc@murrayc.com>
622 ConfiguredDocument: Avoid a null pointer exception.
624 * src/main/java/org/glom/web/server/ConfiguredDocument.java
625 Initialize localeID to "" to avoid returning a null String which
626 causes a crash in java-libglom's swing-generated code.
628 2012-01-23 Murray Cumming <murrayc@murrayc.com>
630 Some simple renaming.
632 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
633 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
634 for localeChooser. This seems more appropriate and is less ambiguous
635 particularly in the .css file.
637 2012-01-23 Murray Cumming <murrayc@murrayc.com>
639 ConfiguredDocument: Rename the localedID private member variable.
641 2012-01-23 Murray Cumming <murrayc@murrayc.com>
643 Adapt to the latest java-libglom API from git master.
645 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
646 libglom now uses only Vector instead of List, which uses add() instead of
649 2012-01-22 Murray Cumming <murrayc@murrayc.com>
651 ConfiguredDocument: Rename the localedID private member variable.
653 2012-01-20 Murray Cumming <murrayc@murrayc.com>
655 Build a source tarball with mvn assembly:single
657 * assembly.xml: Add this file.
658 * pom.xml: Use the maven-assembly-plugin and tell it to use
659 our assembly.xml file.
661 2012-01-19 Murray Cumming <murrayc@murrayc.com>
663 OnlineGlomServiceImpl: Get .glom files recursively.
665 * pom.xml: Depend on commons-io from org.apache.commons.
666 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
667 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
668 files recursively, and with the easier filter for the extension.
669 Use org.apache.commons.io.FilenameUtils.removeExtension() to
670 simplify that code too.
672 2012-01-19 Murray Cumming <murrayc@murrayc.com>
674 README: Mention that you must install java-libglom packages separately.
676 But then it works, because java-libglom is now in the central maven
679 2012-01-18 Murray Cumming <murrayc@murrayc.com>
681 locales drop-down: Show the correct selected locale when the URL changes.
683 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
684 .java: setPlace(): Move some code into fillView().
686 2012-01-18 Murray Cumming <murrayc@murrayc.com>
688 locales drop-down: Do not lose the primary key.
690 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
691 start(): onLocaleChange(): Pass the current primary key value,
692 instead of an empty value.
694 2012-01-18 Murray Cumming <murrayc@murrayc.com>
696 locales drop-down: Do not lose the drop-down selection.
698 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
699 .java (TableSelectionActivity.fillView): Set the selected locale
700 after changing the drop-down items (though we do not really need
701 to change them just because the locale changes.)
703 2012-01-18 Murray Cumming <murrayc@murrayc.com>
705 locales drop-down: Change the tables list when this changes.
707 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
708 .java: TableSelectionActivity.start(): Move the async table titles
709 retrieval into a private fillView() method and also call this when
710 the chosen locale changes.
711 Note that the document title is not actually translatable yet, but
712 that is a problem that I should fix soon in libglom.
714 2012-01-18 Murray Cumming <murrayc@murrayc.com>
716 Improve the placement of the locales drop-down.
718 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
719 Put the title and locales drop-down in a div (gwt.FlowTable).
720 * src/main/webapp/style.css: Add magic css properties to make this work.
721 Also remove the left margin from the title so that it lines up with the
724 2012-01-18 Murray Cumming <murrayc@murrayc.com>
726 locales selector: Show human-readable locale titles.
728 * src/main/java/org/glom/web/server/ConfiguredDocument.java
729 getDocumentInfo(): Use java.util.Locale to show a real title of
730 each locale, in the locale's own language.
732 2012-01-17 Murray Cumming <murrayc@murrayc.com>
734 Add a language/locale selector drop-down.
736 * src/main/java/org/glom/web/shared/DocumentInfo.java:
737 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
738 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
739 getDocumentInfo(): Store the available Locales in the DocumentInfo.
740 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
741 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
742 Add a ListBox to show the available locales. Add getLocaleSelector(),
743 setLocaleList(), getSelectedLocale(), setSelectedLocale().
744 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
745 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
746 java: Add these classes.
747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
748 start(): Fill the locales ListBox. Handle its change event, firing a
750 setPlace(): Show the selected locale as specified by the URL token.
751 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
752 * src/main/java/org/glom/web/client/activity/ListActivity.java:
753 Handle LocaleChangeEvent, going to a new *Place with that locale.
755 The placement of the ListBox is not pretty, and it currently uses the ID
756 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
760 2012-01-17 Murray Cumming <murrayc@murrayc.com>
762 Search box: Show the search text from the URL token.
764 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
765 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
766 Add setQuickFindText().
767 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
768 .java: setPlace(): Store the queryText if the place is a ListPlace,
769 and call TableSelectionView.setQuickFindText().
771 2012-01-17 Murray Cumming <murrayc@murrayc.com>
773 Allow use of translations via, for instance, &lang=de in the URL.
775 * pom.xml: Use the unstable java-libglom 1.21 version.
777 * src/main/java/org/glom/web/client/OnlineGlomService.java:
778 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
779 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
780 init(): Instead of calling TranslatableItem.set_current_locale()
781 (now removed), call ConfiguredDocument.setDefaultLocaleID().
782 However, this is only for default locales, which are not needed to
783 change the locale in the URL.
784 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
785 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
786 getSortedRelatedListData(): Add a localeID parameter, so we can get the
787 layout for a particular locale.
788 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
789 Add get/setDefaultLocaleID().
790 getDocumentInfo(), getListViewData(), getRelatedListData(),
791 getDetailsLayoutGroup(), getListViewLayoutGroup(),
792 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
793 localeID parameter, so we can get the layout for a particular locale.
795 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
796 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
797 * src/main/java/org/glom/web/client/place/ListPlace.java:
798 Parse and construct a lang parameter too.
800 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
801 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
802 passed to subsequent methods and constructors.
803 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
804 * src/main/java/org/glom/web/client/activity/ListActivity.java:
805 Store the localeID from the *Place and pass it to other constructors
806 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
808 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
809 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
810 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
811 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
812 * src/main/java/org/glom/web/client/ui/ListView.java:
813 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
814 Take localeID parameters and pass them to subsequent constructors and
815 methods, so that the layout is always retrieved for that locale.
817 This is rather repetitive.
819 Note that "" means the original (default) locale of the Glom document,
820 which is usually English.
822 2012-01-17 Murray Cumming <murrayc@murrayc.com>
824 Documents: Remove final keyword to fix startup configuration.
826 * src/main/java/org/glom/web/shared/Documents.java: Remove the
827 final keywords on the private member variables because that breaks
828 the startup, apparently (there are warnings) because it stops them
829 from being serialized. I added these in the previous commit.
831 2012-01-13 Murray Cumming <murrayc@murrayc.com>
833 Documents: Add some final keywords.
835 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
838 2012-01-13 Murray Cumming <murrayc@murrayc.com>
840 OnlineGlomServiceImpl: Add to overview comments.
842 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
843 Note that this is where all the document are loaded. They are not
844 loaded freshly for each page.
846 2012-01-12 Murray Cumming <murrayc@murrayc.com>
850 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
851 Add a TextBox for the text of a quick find.
852 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
854 setBackLink(): Add a String quickFind parameter.
855 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
856 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
857 to the base interface, because that is how TableSelectionViewImpl is used.
858 * src/main/webapp/style.css: Add style for the search box and its label.
860 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
861 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
862 Add these files, based on the existing TableChangeEvent and
863 TableChangeEventHandlers.
864 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
865 start(): Handle QuickFindChangeEvent, passing its quickFind text to
866 a ListPlace() that the user should be taken to.
867 * src/main/java/org/glom/web/client/activity/ListActivity.java
868 start(): Handle it here too and adapt the TableChangeEvent handler to
869 pass the extra "" quickFind parameter to ListPlace.
870 * src/main/java/org/glom/web/client/place/ListPlace.java:
871 Constructor: Take an extra String quickFind parameter and store it,
872 returning it from a new getQuickFind() method.
873 getToken(): Put the quickFind text in the URL token.
874 getPlace(): Parse the quickFind text from the URL token.
875 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
876 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
877 ListPlace constructor.
878 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
879 .java: start(): Add a Change handler for the TableSelectionView's
880 TextBox (via its base HasChangeHandlers interface), firing the new
881 QuickFindChangeEvent.
882 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
883 pass the extra "" quickFind parameter.
885 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
886 setCellTable(): Add a String quickFind parameter and pass it to
887 the ListViewTable() constructor.
888 * src/main/java/org/glom/web/client/ui/ListView.java: Change
889 setCellTable() in the base interface, because that is how ListViewImpl
892 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
893 Add a String quickFind member variable.
894 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
895 Constructor: Add a String quickFind parameter, storing it in the
896 base ListTable's member variable.
897 onRangeChanged(): Pass quickFind to the
898 OnlineGlomServiceAsync.getSortedListViewData() and
899 OnlineGlomServiceAsync.getListViewData() methods.
901 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
902 getListViewData(), getSortedListViewData(): Add a String quickFind
903 parameter, passing it to ConfiguredDocument.getListViewData().
904 * src/main/java/org/glom/web/client/OnlineGlomService.java:
905 Change getListViewData(), getSortedListViewData() in the base interface,
906 because that is how OnlineGlomServiceImpl is used, via this:
907 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
908 Change getListViewData(), getSortedListViewData() here too.
909 This class can apparently be used to asynchronously call methods on
910 OnlineGlomService, and GWT seems to implement that after recognizing
911 just the *Async name convention and the extra AsyncCallback parameters.
913 * src/main/java/org/glom/web/server/ConfiguredDocument.java
914 getListViewData(): Add a String quickFind parameter, and pass it to
915 ListViewDBAccess.getData().
916 * src/main/java/org/glom/web/server/database/ListDBAccess.java
917 getListData(): Add a String quickFind parameter and pass it to
919 getSelectQuery(): Add a String quickFind parameter.
920 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
921 getSelectQuery(): Add a String quickFind parameter and use it with
922 Glom.get_find_where_clause_quick() to pass a where_clause to
923 Glom.build_sql_select_with_where_clause(), to actually filter the
925 getData(): Add a String quickFind parameter, passing it to getListData().
926 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
927 va: getData(): Pass an empty string to getListData() for the
930 2012-01-12 Murray Cumming <murrayc@murrayc.com>
932 ListTable: Minor change.
934 * src/main/java/org/glom/web/client/ui/list/ListTable.java
935 createCellTable(): Make this protected instead of public.
937 2012-01-12 Murray Cumming <murrayc@murrayc.com>
939 Many files: Use final for the parameters and use the @override attribute.
941 2012-01-22 Ben Konrath <ben@bagu.org>
943 Add anchor links for single line text that starts with http, ftp and www.
947 2012-01-22 Ben Konrath <ben@bagu.org>
949 Add ellipsis to single line text in details view.
953 2012-01-04 Murray Cumming <murrayc@murrayc.com>
955 Remove all javadoc author tags.
957 Because they are awkward and meaningless when many people touch
959 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
961 2012-01-04 Murray Cumming <murrayc@murrayc.com>
963 Revert the COPYING.LESSER to COPYING rename.
965 Apparently both should be there if it is LGPL.
967 2012-01-03 Murray Cumming <murrayc@murrayc.com>
969 *View: Remove unused imports.
971 * src/main/java/org/glom/web/client/ui/DetailsView.java:
972 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
973 * src/main/java/org/glom/web/client/ui/ListView.java:
974 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
975 Remove unused imports, as suggested by Eclipse.
977 2012-01-02 Murray Cumming <murrayc@murrayc.com>
979 Move the *View::Presenter types, and some API into one base View.
981 * src/main/java/org/glom/web/client/ui/DetailsView.java:
982 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
983 * src/main/java/org/glom/web/client/ui/ListView.java:
984 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
985 Presenter, setPresenter() and clear() into a shared base interface,
986 to avoid the unnecessary duplicate Presenter types and to more clearly
987 show how the *Views share the same structure, even if they are not
988 used polymorphically.
990 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
991 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
993 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
994 * src/main/java/org/glom/web/client/activity/ListActivity.java:
995 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
997 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1000 Feel free to revert this if there is a good reason for the duplicate
1003 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1005 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1007 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1008 a class member instead of a local variable in the method.
1009 This lets us use it to get the view instances, for use in tests.
1010 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1011 beforeOnlineGlom(): Test some more details of the initial view.
1012 Again, this is not very useful.
1014 To really test gwt-glom we will need to start a local postgresql
1015 instance with local data, like the Glom tests in C++.
1017 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1019 pom.xml: Mention the LGPL license.
1021 * pom.xml: Add a licenses section.
1022 * COPYING.LESSER: Move this to COPYING, which
1023 previously contained the GPL. But gwt-glom is all LGPL.
1025 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1027 Add project information to README and pom.xml.
1029 * README: Add a brief description and mention some mvn
1031 * pom.xml: This extra information shows up in mvn site
1034 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1036 Use the latest java-libglom version.
1038 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1040 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1042 GwtTestOnlineGlom: Test a little more.
1044 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1045 protected rather than private, as suggested by the gwt-test-utils
1047 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1048 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1049 Test the initial visibility of the panels.
1051 However, this is not a very useful test.
1052 And I wonder how we should generally test using this idea for an
1053 activity/places app like ours where the real changes happen implicitly
1054 based on the history token/URL.
1056 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1058 Slight modification to *Mapper comments.
1060 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1061 (DataActivityMapper)
1062 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1064 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1066 Remove comments mentioning GIN because they are just copied from
1067 the example code and are apparently not helpful:
1068 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1069 Also change the mention of a class that is only in the example code.
1071 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1073 GwtTestOnlineGlom test: Minor changes.
1075 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1076 Avoid the long qualified class name and modify the comment
1077 because it is now obvious to me that the mocked class is the only
1078 custom one created via GWT.create().
1080 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1082 Tests: Added the beginnings of a test using gwt-test-utils.
1084 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1085 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1086 which tells gwt-test-utils what class will be tested.
1087 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1088 Add a simple (but empty) test case. One class, used by the OnlineGlom
1089 class, is mocked so that it can be created. However, I am not sure
1090 why only this class needs to be mocked.
1092 Note that mockito seems more popular, and clearer, than easymock,
1093 but I have not got that working yet. It might be a matter of the
1096 This test is run during mvn integration-test.
1098 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1100 Tests: Use junit4-style syntax instead of junit3-style.
1102 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1103 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1104 * src/test/java/org/glom/web/shared/DataItemTest.java:
1105 Use the @Test annotation rather than relying on the test*() prefix.
1106 Also no longer implement TestCase, to avoid triggering support for
1107 the junit3-way, which stops the annotations from working.
1108 Change the imports from import junit.framework.* to
1109 import org.junit.*, which is apparently the new way.
1111 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1113 Added a test for ListPlace token parsing and creation.
1115 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1116 This is much the same as DetailsPlaceTest.
1118 I wonder how we could test the other parts of the *Place API.
1120 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1122 DetailsPlace test: Also test getToken() and recreation via getPlace().
1124 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1125 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1126 recreate it, testing the recreated DetailsPlace for the same parameter
1129 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1131 Use the surefire-report plugin.
1133 * pom.xml: This generates a HTML report about the tests in
1134 target/site/surefire-report.html
1135 when you do mvn surefire-report:report. It seems to be popular/normal.
1137 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1139 Added a test for DetailsPlace.
1141 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1142 Test the getPlace() token parsing.
1144 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1146 Added a first unit test.
1148 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1149 * src/test/java/org/glom/web/shared/DataItemTest.java:
1150 This is a silly test but it is just to get things started. Note that
1151 maven/junit finds the test because it looks in src/test by default.
1153 2011-12-22 Ben Konrath <ben@bagu.org>
1155 Change charsetName to "UTF-8" when replacing line breaks.
1157 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1158 that work in Java (such as "UTF8") will not work when compiled to
1161 This fixes a problem with multi-line details view fields that have hard
1162 line breaks. The "License Text" field on this page demonstrates the
1165 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1167 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1169 2011-12-22 Ben Konrath <ben@bagu.org>
1171 Fix another bug with related list navigation.
1173 I've tested all the navigation buttons in all of the related lists
1174 so things should be good now.
1176 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1178 2011-12-22 Ben Konrath <ben@bagu.org>
1180 Fix a crasher when refreshing the list view with the default table.
1182 This crash will also happen when loading the list view with the default
1183 table from a link or bookmark.
1185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1186 to the main document selection page when the document id hasn't been
1188 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1189 the main document selection page when the document id hasn't been
1191 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1192 values for the details place when the document id hasn't been set.
1193 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1194 values for the list place when the document id hasn't been set.
1196 2011-12-21 Ben Konrath <ben@bagu.org>
1198 Protect against NPE when glom.document.locale is not in config.
1200 This patch protects against an NPE when glom.document.locale is not in
1201 the config file. This NPE will also happen if glom.document.locale is
1204 The patch also updates the error message to display the class name when
1205 the getMessage() returns null. This was happening when the NPE was
1206 thrown and I had "Configuration Error: null". If an NPE is encountered
1207 with this patch, "Configuration Error: NullPointerException " will be
1210 This commit closes this bug:
1212 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1216 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1218 Rename onlineglom.properties to onlineglom.properties.sample.
1220 * src/main/resources/onlineglom.properties: Rename to:
1221 * src/main/resources/onlineglom.properties.sample:
1222 * src/main/resources/README: And add this file explaining that people
1223 should rename it back when deploying.
1225 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1227 Allow choosing the translation in the .properties file.
1229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1230 init(): Read a glom.document.locale value from the configuration file
1231 and call Glom's TransatableItem::set_current_locale() method.
1232 * src/main/resources/onlineglom.properties: Add a commented-out
1233 example of this new setting.
1235 It would be better to add &lang=de_DE to the URL, but the current
1236 libglom API does not allow us to do this easily. I am working on that.
1238 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1240 Avoid a crash in parsing of token parameters.
1242 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1243 ava: getTokenParams(): Do not crash if a parameter has a key but no
1244 value, and ignore parameters with neither.
1246 2011-12-17 Murray Cumming <murrayc@murayc.com>
1248 History token building/handling: Improve use of token parameters.
1250 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1251 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1252 and buildParamsToken(HashMap), for use by derived classes.
1253 Make the separator private because it is no longer be needed.
1254 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1255 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1256 instead of manual string concatenation.
1257 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1258 of hardcoded indices and awkward splitting code.
1259 * src/main/java/org/glom/web/client/place/ListPlace.java
1260 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1261 instead of manual string concatenation.
1262 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1263 of hardcoded indices and awkward splitting code.
1264 This should fix bug #666420
1266 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1268 Fix a Navgiation->Navigation typo in the code.
1270 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1271 Rename processNavgiation() to processNavigation().
1273 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1275 Fix a seperator->separator typo in the code.
1277 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1278 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1279 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1282 2011-12-15 Ben Konrath <ben@bagu.org>
1284 Cleanup some comments.
1286 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1288 2011-12-14 Ben Konrath <ben@bagu.org>
1290 Replace \n with <br/> for multiline text in the details view.
1292 Vertical scrollbars are added when needed as well.
1294 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1296 2011-12-14 Ben Konrath <ben@bagu.org>
1298 Specify the font for document selection links.
1300 * src/main/webapp/style.css:
1302 2011-12-14 Ben Konrath <ben@bagu.org>
1304 Fix bouncy CellTable while paging.
1306 This doesn't currently work with related list tables in unselected
1309 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1311 2011-12-14 Ben Konrath <ben@bagu.org>
1313 Revamp the appearance of the document selection page.
1315 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1316 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1317 * src/main/webapp/style.css:
1319 2011-12-13 Ben Konrath <ben@bagu.org>
1321 Set navigation button column to the smallest size possible.
1323 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1325 2011-12-13 Ben Konrath <ben@bagu.org>
1327 Change OpenButton nomenclature to NavigationButton.
1329 Using NavigtionButton makes things more generic. Classes, methods and
1330 variables have been changed.
1332 This is a rename-only refactor.
1334 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1335 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1336 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1337 Renamed from OpenButtonCell.
1338 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1339 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1340 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1342 2011-12-12 Ben Konrath <ben@bagu.org>
1344 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1346 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1347 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1348 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1349 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1351 2011-12-12 Ben Konrath <ben@bagu.org>
1353 Update variable names and comments.
1355 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1356 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1358 2011-12-12 Ben Konrath <ben@bagu.org>
1360 Properly initialize numNonEmptyRows variable to zero.
1362 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1363 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1365 2011-12-05 Ben Konrath <ben@bagu.org>
1367 Add latest mockup with HTML tables.
1369 Features of this mockup:
1371 -> HTML table for flowtable
1372 -> HTML table for flowtable column
1373 -> Example of how related lists would look
1374 -> Not using text entries for data items
1376 The current version of Online Glom doesn't use HTML tables for the
1379 This mockup has been sent to the glom-devel mailing list but it's good
1380 to have it here as well.
1382 * mockups/details-view-html-tables.html:
1384 2011-12-05 Ben Konrath <ben@bagu.org>
1386 Remove unnecessary getPrimaryKeyField() method.
1388 getPrimaryKeyFieldForTable(String) has been renamed to
1389 getPrimaryKeyField(String).
1391 * src/main/java/org/glom/web/server/database/DBAccess.java:
1392 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1393 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1395 2011-12-05 Ben Konrath <ben@bagu.org>
1397 Add string representation of TypedDataItem value to conversion error message.
1399 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1400 message was extracted into its own method to avoid duplication.
1402 2011-12-05 Ben Konrath <ben@bagu.org>
1404 Add type checking to navigation primary key value creation.
1406 Create navigation primary key only if the expected type from the Glom
1407 document matches the type returned by the SQL query.
1409 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1411 2011-12-05 Ben Konrath <ben@bagu.org>
1413 Rename a couple of variables in RelatedListNavigation.
1415 This is a rename-only refactor.
1417 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1419 2011-12-05 Ben Konrath <ben@bagu.org>
1421 Move getListLayoutGroup() into getListViewLayoutGroup().
1423 This removes getListLayoutGroup(). It was only being called by
1424 getListViewLayoutGroup().
1426 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1428 2011-12-05 Ben Konrath <ben@bagu.org>
1430 Remove check for LayoutItem_Portal in list table method.
1432 This check is no longer necessary because the method isn't being used
1433 to create the LayoutItemPortal DTO.
1435 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1437 2011-12-05 Ben Konrath <ben@bagu.org>
1439 Properly support related list navigation.
1441 Navigation from the "Repository Analyzer -> Package Scans ->
1442 Dependencies" related table wasn't working because the primary key for
1443 related tables wasn't being set properly. This commit fixes the
1446 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1447 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1448 doesn't set the primary key properly for related list tables.
1449 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1450 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1451 useful for getting the primary key for list view tables and for related
1453 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1454 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1455 Move code to set the primary key for the table from the abstract
1456 ListDBAccess class to ListViewDBAccess as it's only correct for list
1458 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1459 Properly add primary key to related list tables.
1461 2011-12-02 Ben Konrath <ben@bagu.org>
1463 Properly set the horizontal alignment of fields.
1465 This fix is for both the list tables and the details view.
1467 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1468 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1469 to set the horizontal alignment of fields.
1471 2011-12-02 Ben Konrath <ben@bagu.org>
1473 Display currency codes in the details view.
1475 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1477 2011-12-02 Ben Konrath <ben@bagu.org>
1479 Avoid duplicate JNI call.
1481 JNI is not as efficient as pure Java and this is an easy (and small)
1484 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1485 Use previously retrieved value for whereClauseToTableName instead of
1488 2011-12-02 Ben Konrath <ben@bagu.org>
1490 Rename a couple of variables in RelatedListNavigation.
1492 This is a rename-only refactor.
1494 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1496 2011-12-02 Ben Konrath <ben@bagu.org>
1498 Indicate clearly that a mismatched primary key type is a bug.
1500 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1501 warning to error. Add 'This is a bug.' to message.
1503 2011-12-02 Ben Konrath <ben@bagu.org>
1505 Update / fix some comments.
1507 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1509 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1511 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1512 Fix comments. Add some TODOs.
1514 2011-12-02 Ben Konrath <ben@bagu.org>
1516 Enable navigation to details view with string primary key from related list.
1518 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1519 Create a text primary key value when return type of result is
1520 java.sql.Types.VARCHAR.
1522 2011-12-02 Ben Konrath <ben@bagu.org>
1524 Use checkboxes for booleans in the details view.
1526 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1528 2011-12-01 Ben Konrath <ben@bagu.org>
1530 Improve performance of related list height calculation.
1532 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1533 Put code to calculate the expected height in a static initializer so
1534 that that it's only called once.
1536 2011-12-01 Ben Konrath <ben@bagu.org>
1538 Show related list tables in notebooks (again).
1540 Calculate the height of the related list tables so the Notebook can be
1541 set the correct height. The height of the related list table is also needed by
1542 FlowTable to be able decide how to create the layout.
1544 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1545 and set the Portal height based on the height of the related list
1546 table and the Portal container.
1547 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1548 Add method to calculate the height of the related list tables.
1549 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1550 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1551 calculate the height of the Pager widget.
1553 2011-12-01 Ben Konrath <ben@bagu.org>
1555 Use CellTable API for table property instead of setting style on Element.
1557 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1559 2011-12-01 Ben Konrath <ben@bagu.org>
1561 Make ListViewTable and RelatedListTable a consistent height.
1563 The tables are now a consistent height regardless of the contents of
1564 the table. A hidden button is added to empty rows to ensure that the
1565 height of these rows will match the height of rows with data.
1567 A navigation button column is now added to every table. The width of
1568 the navigation column is set to 0px when a RelatedListTable shouldn't
1569 have navigation buttons. This maintains the a consistent row height in
1570 tables that don't show the navigation buttons.
1572 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1573 navigation column when not needed.
1574 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1575 arguments for navigation button to constructor of ListViewTable.
1576 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1577 hidden button for empty data rows.
1578 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1579 arguments for navigation button to constructor.
1580 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1581 create navigation buttons. Add hideNavigationButtons() method.
1582 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1583 arguments for navigation button to constructor.
1585 2011-12-01 Ben Konrath <ben@bagu.org>
1587 Use 'visibility: hidden' in Utils.getWidgetHeight().
1589 This is better choice because hidden elements are invisible, don't
1590 respond to events and are not part of the tab order. They will,
1591 however, take up space which is required to be able to calculate the
1592 height of the widget.
1594 * src/main/java/org/glom/web/client/Utils.java:
1596 2011-12-01 Ben Konrath <ben@bagu.org>
1598 Use Utils.getWidgetHeight() in FlowTable.
1600 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1602 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1604 2011-12-01 Ben Konrath <ben@bagu.org>
1606 Put the details css class name on the correct table column.
1608 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1610 2011-11-30 Ben Konrath <ben@bagu.org>
1612 Update for java-libglom API change.
1614 The getters and setters on FieldFormatting and NumericFormat were
1615 changed to remove the 'M'.
1617 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1619 2011-11-29 Ben Konrath <ben@bagu.org>
1621 Only allow RelatedListTables in Portals.
1623 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1625 2011-11-29 Ben Konrath <ben@bagu.org>
1627 Only create a contents panel for Portals when title is being set.
1629 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1631 2011-11-29 Ben Konrath <ben@bagu.org>
1633 Set TabLayoutPanel height based on calculated height its widgets.
1635 This is a potential fix for this bug:
1637 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1639 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1641 2011-11-29 Ben Konrath <ben@bagu.org>
1643 Align details field labels and data with the Open buttons.
1645 * src/main/webapp/style.css:
1647 2011-11-29 Ben Konrath <ben@bagu.org>
1649 Remove unnecessary <div> in the Notebook widget.
1651 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1652 method to get container FlowPanel (<div>).
1653 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1654 initWidget() method directly on the TabLayoutPanel widget instead of
1655 Group's container widget.
1657 2011-11-29 Ben Konrath <ben@bagu.org>
1659 Don't add group titles for Portals in Notebooks.
1661 This reverts the previous patch and fixes a bug I introduced with
1662 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1664 * src/main/java/org/glom/web/client/ui/details/Group.java:
1665 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1667 2011-11-28 Ben Konrath <ben@bagu.org>
1669 Remove unused boolean argument in Portal constructor.
1671 Just a code cleanup.
1673 * src/main/java/org/glom/web/client/ui/details/Group.java:
1674 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1676 2011-11-28 Ben Konrath <ben@bagu.org>
1678 Remove hack for glom 1.18 style glom files.
1680 * src/main/java/org/glom/web/client/ui/details/Group.java:
1681 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1682 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1684 2011-11-28 Ben Konrath <ben@bagu.org>
1686 Use Gda Value version of primary key to log result too large error.
1688 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1690 2011-11-28 Ben Konrath <ben@bagu.org>
1692 Don't use TypedDataItem.getText() for Unknown types from the URL.
1694 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1695 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1696 instead of getText().
1697 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1698 String field and getUnknown() method.
1700 2011-11-28 Ben Konrath <ben@bagu.org>
1702 Log an error message when the java-libglom .so is not present.
1704 The error message was being set in the exception but not logged.
1706 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1708 2011-11-28 Ben Konrath <ben@bagu.org>
1710 Ignore LayoutItem_CalendarPortals.
1712 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1713 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1715 2011-11-28 Ben Konrath <ben@bagu.org>
1717 Extract method for creating the LayoutItemPortal DTO.
1719 Just breaking the code up into smaller chunks.
1721 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1723 2011-11-28 Ben Konrath <ben@bagu.org>
1727 This should have been added with the refactor. Oops!
1729 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1731 2011-11-28 Ben Konrath <ben@bagu.org>
1733 Create primary key value from URL string using type from Glom document.
1735 See this bug, comments 19 - 25:
1737 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1739 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1740 create a TypeDataItem for the primary key here when loading from a
1741 URL. Show the same string for the primary key value as was received
1742 from the URL string (when loading from a URL).
1743 * src/main/java/org/glom/web/server/Utils.java: Update method for
1744 creating the Gda Value from the TypeDataItem to properly deal with
1745 creating a Gda Value based on the Glom document type for the primary
1746 key value string when loading from a URL.
1747 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1748 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1749 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1750 Update for changed method name.
1752 2011-11-27 Ben Konrath <ben@bagu.org>
1754 Rename PrimaryKeyItem to TypedDataItem.
1756 The name PrimaryKeyItem suggests what the class should be used for.
1757 TypedDataItem is a neutral name that describes the class better.
1759 This is a rename-only refactor.
1761 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1762 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1763 * src/main/java/org/glom/web/client/Utils.java:
1764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1765 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1766 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1767 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1768 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1769 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1770 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1771 * src/main/java/org/glom/web/server/Utils.java:
1772 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1773 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1774 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1775 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1777 2011-11-25 Ben Konrath <ben@bagu.org>
1779 Improve Gda Value conversion from PrimaryKeyItem.
1781 The value from the PrimaryKeyItem is only used if its type match the
1782 type from the glom document.
1784 * src/main/java/org/glom/web/server/Utils.java:
1786 2011-11-25 Ben Konrath <ben@bagu.org>
1788 Manually check if the java-liblgom .so is visible to the JVM.
1790 It seems that Tomcat has problems when a static initializer throws an
1791 exception. This check is done before the first method call into
1792 java-libglom so that execution doesn't continue if the .so is not
1795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1797 2011-11-25 Ben Konrath <ben@bagu.org>
1799 Improve browser configuration error messages.
1803 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1805 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1806 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1807 getConfigurationErrorMessage() method.
1808 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1809 Get and display a specific configuration error message when no Glom
1810 documents are found.
1811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1812 Implement getConfigurationErrorMessage() method. Surround configuration
1813 code in the init() method with a try/catch block. This allows the
1814 errors to be caught while keeping the servlet available to retrieve the
1815 configuration error message.
1817 2011-11-25 Ben Konrath <ben@bagu.org>
1819 Don't use Strings to hold primary key values.
1821 The primary key values are now held in a new data object
1822 (PrimaryKeyItem) that holds type information and the primary key value
1823 using the correct type.
1825 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1826 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1828 PrimaryKeyItem instead of String to hold the primary key value.
1829 * src/main/java/org/glom/web/client/Utils.java: Remove
1830 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1831 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1832 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1833 PrimaryKeyItem instead of String to hold the primary key value. Load
1834 document selection page when the documentID has not been set correctly.
1835 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1836 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1838 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1839 Return empty string for URL instead of "null".
1840 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1841 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1842 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1843 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1844 PrimaryKeyItem instead of String to hold primary key values.
1845 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1846 PrimaryKeyValue to a Gda Value.
1847 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1848 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1849 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1850 Replace temporary database access code that uses the PrimaryKeyValue to
1851 Gda Value conversion.
1852 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1853 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1854 PrimaryKeyItem instead of String.
1855 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1856 hold primary key values.
1858 2011-11-24 Ben Konrath <ben@bagu.org>
1860 Use newly added java-libglom API to create queries.
1862 This isn't finished. I still need to stop using Strings for primary key
1863 values in the client code.
1865 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1866 libglom to use fake connections so that retrieving the query string will
1868 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1869 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1870 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1871 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1872 Use the newly added libglom sql methods and classes to create the
1873 query. Add temporary hack to convert primary value strings to Gda
1876 2011-11-23 Ben Konrath <ben@bagu.org>
1878 Don't explicitly set the height of Portals.
1880 See comments 6 - 10 of this bug for details:
1882 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1884 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1886 2011-11-23 Ben Konrath <ben@bagu.org>
1888 Use an HTML table instead of CSS for the FlowTable layout.
1890 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1891 GWT's FlexTable to implement the FlowTable.
1892 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1894 2011-11-18 Ben Konrath <ben@bagu.org>
1896 Add boolean example to HTML table mockup.
1898 * mockups/details-view-html-tables-text-entries.html:
1900 2011-11-17 Ben Konrath <ben@bagu.org>
1902 Ensure the pager buttons are always visible for related lists.
1904 To accomplish this, I've turned off text wrapping in the list view and
1905 related list tables for both the header and data text. The related list
1906 table now has a fixed layout so the it doesn't overflow its container.
1907 This is required to ensure that the cell text is clipped when it
1908 overflows the cell and an ellipsis is added to the right side of the
1909 cell when text is clipped.
1911 A fixed table layout for the related list table in the details view
1912 seems what we want for the details view anyway, so the side-effect is
1915 The ellipsis will only be displayed in Firefox >= 7.
1919 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1921 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1922 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1923 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1925 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1926 Set the 'table-layout: fixed' CSS property to the related list table.
1927 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1928 'white-space: nowrap;' CSS property on both the list view and the
1929 related list tables.
1931 2011-11-16 Ben Konrath <ben@bagu.org>
1933 Rework the fix for empty notebook tab labels.
1935 Setting the empty group titles with its name caused problems for the
1936 details layout. Instead of using libglom's
1937 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1938 to the client when the title is empty. This allows the Notebook to use
1939 the name when the title is empty without affecting anything else.
1941 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1942 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1944 2011-11-16 Ben Konrath <ben@bagu.org>
1946 Set group titles with name when title is empty.
1948 This fixes a problem with an empty notebook tab label in the Lesson
1949 Planner document. The forth tab in the notebook should be "Internet":
1951 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1953 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1954 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1957 2011-11-16 Ben Konrath <ben@bagu.org>
1959 Remove whitespace from the configured username properties.
1961 This assumes that usernames won't have whitespace at the beginning
1962 or end. But I think this is a reasonable assumption.
1964 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1965 String.trim() to remove the whitespace from the username properties.
1967 2011-11-15 Ben Konrath <ben@bagu.org>
1969 Add details view mockup with HTML tables and text entries.
1971 This is from the attachment on this bug:
1973 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1975 * mockups/details-view-html-tables-text-entries.html:
1977 2011-11-15 Ben Konrath <ben@bagu.org>
1979 Add space between the columns of the flow table.
1983 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1985 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1986 space between columns in the flow table.
1988 2011-11-15 Ben Konrath <ben@bagu.org>
1990 Add backup files to the .gitignore.
1992 * .gitignore: Ignore files that end with ~.
1994 2011-11-09 Ben Konrath <ben@bagu.org>
1996 Use latest release of gwt-log.
1998 Gwt-log releases are now being submitted to the maven central
1999 repository so manual installation of the jar is no longer required.
2001 * pom.xml: Update version and groupId of gwt-log dependency.
2003 2011-10-31 Ben Konrath <ben@bagu.org>
2005 Don't use GWT numeric formatting to override the glom currency formatting.
2007 Currencies are now displayed like they are in Glom. See this bug:
2009 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2011 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2013 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2014 currency code to constructor and set it when the cell is rendered.
2015 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2016 currency code to the constructor of the NumericCell.
2018 2011-10-27 Ben Konrath <ben@bagu.org>
2020 Require the latest release of java-libglom (1.17.4).
2024 2011-10-26 Ben Konrath <ben@bagu.org>
2026 Add style to Notebook that matches current theme.
2028 It's not the best style in the world but it's better than the default.
2030 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2031 padding at the bottom of the child widgets.
2032 * src/main/webapp/style.css: Add style for the Notebook.
2034 2011-10-26 Ben Konrath <ben@bagu.org>
2036 Move servlet initialization code to overridden init method.
2038 This is half of the solution to getting proper error messages
2039 displayed when configuration errors occur. Here's the relevant bug:
2041 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2043 The rest of the solution involves surrounding the init method with a
2044 try/catch block and setting a global variable with the error /
2045 exception. A new async method should be created to retrieve and display
2046 the error message / exception.
2048 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2049 code from constructor to init method adding exceptions as needed.
2051 2011-10-26 Ben Konrath <ben@bagu.org>
2053 Add script to monitor and restart tomcat if required.
2055 * utils/check-and-recover-tomcat.py: New file.
2057 2011-10-26 Ben Konrath <ben@bagu.org>
2059 Display the correct number of data items in the pager.
2063 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2065 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2066 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2067 The implementation is the same for both tables: Keep track of the
2068 number of non-empty rows and fire and RowCountChangeEvent after the data has
2070 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2071 custom Pager class that subclasses SimplePager to handle displaying
2072 the correct number when empty rows have been added.
2074 2011-10-26 Ben Konrath <ben@bagu.org>
2076 Correct error in previous commit.
2078 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2079 eventBus parameter from listView.setCellTable().
2081 2011-10-26 Ben Konrath <ben@bagu.org>
2083 Fix error in TODO comment.
2085 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2087 2011-10-24 Ben Konrath <ben@bagu.org>
2089 Create Notebook widgets to the details view.
2091 This isn't finished just yet - I still need to create a reasonable
2092 style to match the current theme.
2094 * src/main/java/org/glom/web/client/Utils.java: Add method for
2095 calculating the height of a widget. This is used in the Notebook class.
2096 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2097 new constructor method in Group.
2098 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2099 method for creating child widget that can be used by subclasses
2100 like Notebook. New constructor that allows disabling the group
2101 titles - Notebooks don't set a group title for their child groups.
2102 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2103 to make Notebooks using GWT's TabLayoutPanel.
2104 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2105 constructor that allows disabling the group titles.
2106 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2107 LayoutItemNotebook DTO.
2108 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2109 DTO for Notebooks. It's just an empty class for now but we might need
2110 it to transfer some specific information in the future.
2112 2011-10-21 Ben Konrath <ben@bagu.org>
2114 Add navigation buttons to related list tables.
2116 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2117 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2118 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2119 method getSuitableRecordToViewDetails() for getting the table name
2120 and primary key value for related list navigation buttons.
2121 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2122 private cell renderer class to get the navigation information for
2123 related list tables from the server. Extract the navigation
2124 processing code from the details cell navigation and use it for the
2125 related list navigation as well.
2126 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2127 cell renderer class for the details open buttons. This was needed
2128 because the related list navigation buttons and the list view
2129 navigation buttons need to react differently when clicked.
2130 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2131 the onEnterKeyDown() method because it's now overriden in the
2132 subclasses that are specific to the related list tables and the list
2134 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2135 the vertical size a little because the buttons add a bit of vertical
2136 space to table. This is not a perfect solution because the vertical
2137 size of with table fewer than 5 rows will be a little smaller.
2138 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2139 changes in how navigation buttons are handled.
2140 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2141 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2142 database access object.
2143 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2144 to find the portal for a given relationship name from
2145 RelatedListDBAccess. Add method to find a primary key field for a
2147 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2148 Move code to find the portal for a given relationship name to
2150 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2151 New file: database access object for getting the related list
2152 navigation information (the table name and the primary key value).
2153 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2154 DTO for transferring a table name to navigate to and a primary key
2156 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2157 boolean and getter/setter to specifies if the related list should add
2160 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2162 Use the master branch of java-libglom
2164 * pom.xml: Depend on java-libglom 1.19 instead.
2166 This is the master branch. See also the libglom-1-18 branch.
2168 2011-10-11 Ben Konrath <ben@bagu.org>
2170 Enable the open navigation button when the data has been set.
2172 This avoids having active buttons that don't do anything when the data
2175 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2177 2011-10-11 Ben Konrath <ben@bagu.org>
2179 Use IsWidget interface for FlowTableItem.
2181 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2182 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2184 2011-10-11 Ben Konrath <ben@bagu.org>
2186 Remove GWT styling from open button in details view.
2188 There are still some issues with how the details cell is arranged but
2189 this should be made to match Glom 1.20. I'm going to leave fixing this
2190 until I have Glom 1.20 up and running.
2192 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2193 style name on open button.
2194 * src/main/webapp/style.css: Move and edit details-navigation class.
2195 Re-arrange some classes to make them appear in the same order as the
2198 2011-10-07 Ben Konrath <ben@bagu.org>
2200 Update to GWT 2.4.0.
2202 * .gitignore: Ignore new cache directory.
2203 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2204 * pom.xml: Change GWT and maven plugin to 2.4.0.
2205 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2207 * src/main/java/org/glom/web/client/ClientFactory.java:
2208 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2209 * src/main/java/org/glom/web/client/OnlineGlom.java:
2210 Update source for API changes.
2211 * utils/build-onlineglom-war.sh: Remove cache directory before the
2214 2011-10-07 Ben Konrath <ben@bagu.org>
2216 Add navigation buttons in the details view.
2218 This isn't finished but I thought I'd commit what I have as it's a
2219 pretty good start. I still need to:
2221 1. Change the style so that it fits better into the current theme
2222 2. Adjust the details cell to expand as much as possible.
2224 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2225 click handlers to navigation buttons in the DetailsCells. Create a
2226 refreshData() method to get just the data from the server without the
2228 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2229 Update the tableSelector and browser title when the table name
2230 changes without using the tableSelector.
2231 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2232 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2233 getDetailsCells() to getCells(). Update variable names.
2234 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2235 method to set click handler on navigation button. Rename a few
2236 variables. Add navigation buttons where needed.
2237 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2238 variables and methods.
2239 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2240 navigation boolean and navigation table as required in the
2241 LayoutItemField DTO.
2242 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2243 variables for navigation along with getter/setter methods.
2245 2011-10-07 Ben Konrath <ben@bagu.org>
2247 Rename Field to DetailsCell.
2249 This is a refactor-only commit. No functionality has been added or
2252 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2253 Update variable and method names.
2254 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2255 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2256 variable and method names.
2257 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2259 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2260 variable and method names.
2262 2011-10-07 Ben Konrath <ben@bagu.org>
2264 Create separate methods for layout and data the details view.
2266 This is a refactor-only commit. No functionality has been added or
2269 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2270 private methods: setData(), createLayout().
2272 2011-10-07 Ben Konrath <ben@bagu.org>
2274 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2276 This is part of a change to get navigation buttons in the details view
2277 but it should have been done this way from the start.
2279 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2280 for method name change in TableSelectionView.
2281 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2282 Create TableChangeEvent and set the browser title using the
2283 TableSelectionView API.
2284 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2285 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2286 Change getSelectedTable() to getSelectedTableName(). Add
2287 getSelectedTableTitle().
2289 2011-10-07 Ben Konrath <ben@bagu.org>
2291 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2293 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2295 2011-10-07 Ben Konrath <ben@bagu.org>
2297 Update TableChangeEvent to use newTableName naming convention.
2299 This makes the class more consistent with GWT naming conventions.
2301 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2302 Update for method name change in TableChangeEvent.
2303 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2304 for method name change in TableChangeEvent.
2305 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2306 newTableName variable and getter method. Make toDebugString()
2309 2011-09-30 Ben Konrath <ben@bagu.org>
2311 Disable the pager in the list tables when the data row count is less than the minimum.
2313 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2314 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2316 2011-09-30 Ben Konrath <ben@bagu.org>
2318 Add empty rows to the end of related list and list view tables.
2320 I also extracted the cell rendering classes from the ListTable because
2321 the code was becoming a little crazy with all the anonymous inner
2322 classes. My plan is to use these cell rendering classes in the details
2323 view as well so this refactor will be needed for that change.
2325 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2326 set the row count in related list tables if the data has more rows
2327 than the minimum number of rows visible.
2328 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2329 row count in list view tables if the data has more rows than the
2330 minimum number of rows visible.
2331 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2332 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2334 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2335 for rendering TYPE_NUMERIC cells. The code was extracted from the
2337 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2338 class for rendering cells with buttons in list views. The code was
2339 extracted from the ListTable class.
2340 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2341 for rendering TYPE_TEXT cells. The code was extracted from the
2343 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2344 Add empty rows to the end of the data if required. Implement
2345 ListTable.getMinNumVisibleRows().
2346 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2347 cell renderer code to public classes. Return null in
2348 Column.getValue() for empty rows. Add new abstract method:
2349 getMinNumVisibleRows(). Move code to set the row count of the list view
2350 table to ListViewImpl.
2351 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2352 empty rows to the end of the data if required. Implement
2353 ListTable.getMinNumVisibleRows().
2356 2011-09-27 Ben Konrath <ben@bagu.org>
2358 Use GWT.log for client-side debugging statements.
2360 These are optimized out when deployed so I should have used this method
2361 in the first place. These statements will eventually be replaced with some sort
2362 of notification in the browser.
2364 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2365 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2366 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2367 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2368 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2370 2011-09-27 Ben Konrath <ben@bagu.org>
2372 Put tableselector on the right, back to list link on right.
2374 The idea is that the table selector is acting like a label for the
2375 currently displayed table so it should be placed below the document title. This
2376 puts the table title in a similar position to where it is in Glom.
2378 * mockups/details-contacts.html:
2379 * mockups/details-projects.html:
2380 * mockups/listview-contacts.html:
2381 * mockups/listview-projects.html:
2382 * mockups/style.css:
2383 Update mockups to match how the interfaces currently look.
2384 * src/main/webapp/style.css: Swap positions of backlink with the table
2385 selector. Add some space on the left side of the table selector to
2386 line things up with the document title.
2388 2011-09-27 Ben Konrath <ben@bagu.org>
2390 Add field colouring to details view.
2392 This change re-works how field colouring works. The colour formatting
2393 information is now set to the client with the layout information instead of
2394 with the data. This eliminates the need to send the same colour strings for
2395 data in list view column when colour information is set.
2397 In order to set an alternate colour for negative numeric values, the
2398 number is now sent to client and formatted with the GWT NumberFormat class.
2400 This change also fixes:
2402 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2404 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2405 internationalization framework which is needed for client side numeric
2407 * src/main/java/org/glom/web/client/Utils.java: New file for some
2408 client static utility methods.
2409 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2410 the DataItem object to the Field class. Use a utility method to
2411 create the foreignKeyValue string.
2412 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2413 alignment and text colours in the constructor. Add setData(DataItem)
2414 method. Remove setText(String) method.
2415 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2416 colour information to GlomTextCell. Create and use GlomNumberCell for
2417 rendering numbers. Use utility method to get the string for the
2418 primary key of the key provider. Re-work how the horizontal alignment
2420 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2421 formatting to layout information. Methods for converting the libglom
2422 formatting information were moved from DBAccess.
2423 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2424 numeric formatting (it's now done on the client side). Don't set text
2425 colours in DataItem. Move libglom formatting conversion methods to
2427 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2428 getters/setters for text colour information.
2429 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2430 for transferring the libglom NumericFormat information to the client.
2431 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2432 and getters/setters for: GlomNumericFormat, background colour and
2433 foreground colour strings.
2435 2011-09-26 Ben Konrath <ben@bagu.org>
2437 Simplify code that iterates through the LayoutGroup.
2439 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2441 2011-09-26 Ben Konrath <ben@bagu.org>
2443 Accept Eclipse formatting for OnlineGlomServiceAsync.
2445 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2447 2011-09-26 Ben Konrath <ben@bagu.org>
2449 Don't use the ListDBAccess classes to get the primary key layout information.
2451 This was causing a bug where the wrong index for the hidden primary key
2452 was being sent to the client.
2454 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2455 primary key while creating the LayoutGroup DTO. Create a
2456 LayoutItemField DTO for hidden primary keys. Don't use the
2457 RelatedListDBAccess because it was only used for getting the primary
2459 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2460 access modifier from public to protected for getPrimaryKeyField() and
2461 getPrimaryKeyLayoutItemField().
2462 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2463 abstract method getExpectedResultSize() because RelatedListDBAccess
2464 doesn't have enough info to implement it.
2465 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2466 Remove @Override for getExpectedResultSize().
2467 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2468 Remove method getExpectedResultSize().
2470 2011-09-23 Ben Konrath <ben@bagu.org>
2472 Log which layout (list or details) the ignored item is from.
2474 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2476 2011-09-23 Ben Konrath <ben@bagu.org>
2478 Remove annotations that turn off code formatting in DataItem.
2480 * src/main/java/org/glom/web/shared/DataItem.java:
2482 2011-09-23 Ben Konrath <ben@bagu.org>
2484 Rename GlomField to DataItem and update associated methods.
2486 This is a rename-only refactor. No functionality has been added or
2489 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2490 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2491 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2492 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2493 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2494 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2495 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2496 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2497 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2498 * src/main/java/org/glom/web/server/database/DBAccess.java:
2499 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2500 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2501 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2502 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2503 * src/main/java/org/glom/web/shared/DataItem.java:
2504 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2505 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2507 2011-09-23 Ben Konrath <ben@bagu.org>
2509 Rename GlomDocument to DocumentInfo and update associated methods.
2511 This is a rename-only refactor. No functionality has been added or
2514 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2515 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2516 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2517 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2518 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2519 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2520 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2522 2011-09-20 Ben Konrath <ben@bagu.org>
2524 Require java-libglom 1.17.3.
2526 This picks up the fix for the seg fault problem with the Scenes table
2527 in the Openismus Film Manager example.
2531 2011-09-20 Ben Konrath <ben@bagu.org>
2533 Change the way sort clause is added for primary key when no sort clause is requested.
2535 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2536 before the sort clause is created. When a sort clause is not requested, the
2537 sort clause is created by finding the primary key in the LayoutFieldVector
2540 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2542 2011-09-20 Ben Konrath <ben@bagu.org>
2544 Log error message if no documents are found in the configured directory.
2546 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2547 Extract the glom file extension string to a private static final class
2548 variable (mostly as syntactic sugar). Accept a minor formatting change.
2549 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2550 the example glom.document.directory configuration property to make it
2551 more clear that it can any directory, not just the home directory.
2553 2011-09-18 Ben Konrath <ben@bagu.org>
2555 Add related lists to details view.
2557 The related list table has support for paging and sorting just like the
2558 table in the list view.
2560 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2561 SQL queries for the related list tables.
2562 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2563 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2564 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2565 Rename getList methods to getListView and add comments. Remove
2566 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2567 it being unused. Add methods: getDetailsLayoutAndData(),
2568 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2569 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2570 Create the layout and set the data for the fields in one async call
2571 instead of two. Create related lists where appropriate.
2572 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2573 for method name changes in OnlineGlomService.
2574 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2575 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2576 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2578 * src/main/java/org/glom/web/client/ui/ListView.java:
2579 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2580 tableName from setCellTable(). Create a ListViewTable instead of
2582 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2583 represent a data field in the details view.
2584 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2585 from addDetailsCell() to Field class. Keep track of the Fields and
2586 Portals in the details view.
2587 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2588 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2589 and add a method to get it. Add method to set the contents of the
2591 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2592 New class for related list tables. This class has the data provider
2593 for the related list table.
2594 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2595 abstract class which is the base class for the ListViewTable and the
2597 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2598 New class for list view tables. This class has the data provider for
2599 the list view table.
2600 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2601 methods for related list tables. Add more information to the
2602 LayoutItemField and LayoutItemPortal DTOs.
2603 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2604 Remove debugging print statement.
2605 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2606 Remove debugging print statements. Add primary key field to SQL count
2608 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2609 Remove unnecessary LayoutFieldVector parameter from
2610 getResultSizeOfSQLQuery() method.
2611 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2612 New class for related list table database access.
2613 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2614 class that is a wrapper DTO for details view layout and data.
2615 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2616 new 'fromField' string to this DTO.
2617 * src/main/webapp/style.css: Remove bottom margin and override top
2620 2011-09-15 Ben Konrath <ben@bagu.org>
2622 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2624 This sets things up to make it easier to add the data retrieval for
2625 related lists (portals). No user noticeable changes were made with
2628 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2629 class has the code to retrieve the layouts and access the
2630 database using the new database helper classes.
2631 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2632 Most of the functionality has been removed from this class. This
2633 class now represents the public interface for the client side
2634 code. It also deals with configuring the servlet and cleaning
2635 things up when the servlet is stopped.
2636 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2637 of static methods into this utility class.
2638 * src/main/java/org/glom/web/server/database/DBAccess.java:
2639 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2640 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2641 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2642 These classes have the database retrieval code. The class hierarchy
2643 has been setup to make it easy to reuse code for similar
2646 2011-09-06 Ben Konrath <ben@bagu.org>
2648 Create separate classes for list table code and the data provider.
2650 As part of this refactor, I also split up the code a bit to make it
2653 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2654 table code to two new classes (below).
2655 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2656 with code from ListViewImpl.
2657 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2658 New file with code from ListViewImpl.
2660 2011-09-06 Ben Konrath <ben@bagu.org>
2662 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2664 This fixes the LayoutItemPortal DTO to match the libglom layout object
2667 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2669 2011-09-01 Ben Konrath <ben@bagu.org>
2671 Set title of Portals in the Details View.
2673 * pom.xml: Bump required version of java-libglom to 1.17.1.
2674 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2675 widget creation to its own class. Add comments to constructor.
2676 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2677 The code is mostly from the Group class with the title now set.
2678 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2679 title of Portal. Update some comments. Fix some code formatting.
2681 2011-09-01 Ben Konrath <ben@bagu.org>
2683 Remove TODO comment for the flow table column width.
2685 The flow table column width is working correctly and doesn't need to be
2686 changed. See this mailing list post for more info:
2688 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2690 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2692 2011-08-27 Ben Konrath <ben@bagu.org>
2694 Add document title (database name) to top of the browser page.
2696 I added the document title to the TableSelecitonView but that will
2697 change if / when we add a view that doesn't require table selection.
2699 * mockups/details-contacts.html:
2700 * mockups/details-projects.html:
2701 * mockups/listview-contacts.html:
2702 * mockups/listview-projects.html:
2703 * mockups/style.css: Add document title to mockups to keep things
2705 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2706 sizes to account for the document title.
2707 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2708 Set the document title when it has been retrieved from the server.
2709 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2710 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2711 and implement setDocumentTitle(String) method.
2712 * src/main/webapp/style.css: Add ID for document title style.
2714 2011-08-25 Ben Konrath <ben@bagu.org>
2716 Add NavigationType enum to LayoutItemPortal DTO.
2718 This is the start of adding support for Portals to the Details View.
2720 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2721 LayoutItem_Portal.navigation_type enum from libglom to
2722 LayoutItemPortal.NavigationType enum.
2723 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2724 NavigationType enum, field for storing the NavigationType and getter
2727 2011-08-25 Ben Konrath <ben@bagu.org>
2729 Implement the flow table layout in the Details View.
2731 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2732 FlowTable to Group to account for the renamed class.
2733 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2734 File. This is a container widget that implements the Glom details view
2735 flow table behaviour.
2736 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2737 org/glom/web/client/ui/FlowTable.java.
2738 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2739 so that the size of the subgroups are a closer match to the size of
2740 the Glom subgroups. This makes the flowtable layout match the layout
2741 in Glom for the Music Collection example file.
2743 2011-08-16 Ben Konrath <ben@bagu.org>
2745 Create container element for LayoutItemPortal in Details View.
2747 This will help me develop the layout for the FlowTable.
2749 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2750 fieldPanel variable to detailsCell.
2752 2011-08-15 Ben Konrath <ben@bagu.org>
2754 Set the height of the data element in the Details View.
2756 I changed the InlineLabels (text in a span element) to Labels (text in
2757 a div element) so that I could set the height of the details-data
2758 elements instead of the details-cell parent elements. This allows the
2759 the details-data element to display the correct height if style is
2760 applied that shows the height.
2762 This change has the added benefit of allowing the order of the labels
2763 and data elements to be changed for right-to-left languages.
2765 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2766 InlineLabels to Labels.
2767 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2768 InlineLabels to Labels. Set the height of the data element.
2769 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2770 multiline text height in the Formatting DTO.
2771 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2772 for multiline height along with getter and setter methods.
2773 * src/main/webapp/style.css: Adjust style to account for the change
2774 from span elements to div elements in the details cell.
2776 2011-08-15 Ben Konrath <ben@bagu.org>
2778 Make the List View appearance match the mockups.
2780 It doesn't match exactly but it's much better than it was.
2782 * mockups/listview-contacts.html: Remove unused css classes.
2783 * mockups/listview-projects.html: Remove unused css classes.
2784 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2785 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2786 for mainPanel instead of VerticalPanel (table). Set style name on
2787 CellTable. Set style name on Details column. Right-align Details
2789 * src/main/webapp/style.css: Adjust properties to match the mockups.
2791 2011-08-12 Ben Konrath <ben@bagu.org>
2793 Add better support for subgroups in the details view.
2795 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2796 changed FlowTable constructor.
2797 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2798 support for subgroups and subgroup-titles.
2799 * src/main/webapp/style.css: Add CSS class for subgroups and
2802 2011-08-12 Ben Konrath <ben@bagu.org>
2804 Return the top level LayoutGroup title.
2806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2808 2011-08-11 Ben Konrath <ben@bagu.org>
2810 Make the TableSelector header match the mockup.
2812 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2813 the layout panel. Properly lineup the table selection header with
2814 the list and details view.
2815 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2816 margin around the details view.
2817 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2818 Rename listBox variable to tableSelector. Set id for the style sheet.
2819 Use a FlowPanel instead of a HorizontalPanel.
2820 * src/main/webapp/style.css: Add properties to make the TableSelector
2821 box match the mockups.
2823 2011-07-13 Ben Konrath <ben@bagu.org>
2825 Update install script for java-libglom version change.
2827 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2830 2011-07-13 Ben Konrath <ben@bagu.org>
2832 Add support sub-group in the details view.
2834 I also removed the code that special-cased the default details view
2837 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2839 I still have to make a proper flowtable.
2841 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2842 Don't special-case default details view layout.
2843 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2844 addLayoutField() as I'm going to use it.
2845 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2846 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2848 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2849 extracted from DetailsViewImpl.GroupPanel. Add support for
2851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2852 column count when getting the details layout.
2854 2011-07-12 Ben Konrath <ben@bagu.org>
2856 Set browser title with database and table titles.
2858 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2859 Set the browser title when the table changes and when the activity
2861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2862 title when retrieving document info (the GlomDocument object).
2863 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2864 with getter and setter methods. Remove unused convenience constructor.
2865 Use default code formatting.
2867 2011-07-12 Ben Konrath <ben@bagu.org>
2869 Ignore LayoutItemPortals in the details view.
2871 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2874 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2875 LayoutItemPortal layout objects.
2876 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2877 LayoutItemPortal objects when retrieving the details layout.
2878 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2879 file. This is an empty class and just used to get type information for
2882 2011-07-12 Ben Konrath <ben@bagu.org>
2884 Use java-libglom 1.17.0.
2888 2011-07-11 Ben Konrath <ben@bagu.org>
2890 Remove "Table:" label from table selector.
2892 This matches a recent change in the Glom UI.
2894 * mockups/details-contacts.html:
2895 * mockups/details-projects.html:
2896 * mockups/listview-contacts.html:
2897 * mockups/listview-projects.html: Remove the "Table:" label from the
2899 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2901 2011-07-11 Ben Konrath <ben@bagu.org>
2903 Add main groups to the details view.
2905 This makes things look a little nicer in the details view. The next step
2906 is to implement the flowtable.
2908 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2909 resources from the standard gwt css theme. Standard.css is now
2910 included in OnlineGlom.html so that the online glom css rules have
2911 precedence over the gwt theme.
2912 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2913 the whole LayoutGroup to the DetailsView instead of just the titles.
2914 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2915 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2916 details layout with a helper class (GroupPanel). I might extract this
2917 class when I make the full flowtable.
2918 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2919 string as default so I don't have to worry about NPEs when processing
2921 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2922 note beside OnlineGlom.gwt.xml above).
2923 * src/main/webapp/style.css: Add default font-size to body to override
2924 the font-size set by the standard theme. Don't use h2 tags for
2925 group-title. Create new details-cell class.
2927 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2929 ConfiguredDocument: Set the port number too.
2931 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2932 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2933 Glom document. Presumably this worked sometimes so far because there is a
2934 default port number.
2936 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2938 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2940 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2941 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2942 correct, though we should throw an exception too.
2944 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2946 Fix a addDocuemnt typo.
2948 * src/main/java/org/glom/web/shared/Documents.java
2949 (Documents.addDocuemnt): Rename to addDocument().
2950 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2951 (OnlineGlomServiceImpl.getDocuments): Adapt.
2953 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2955 Slightly improved log output when connection fails.
2957 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2958 (ConfiguredDocument.setUsernameAndPassword):
2959 We don't know for sure if it' the username/password that's wrong, so
2960 rephrase the message.
2961 Also ouput the exception message, though it's generic in this case.
2963 2011-07-08 Ben Konrath <ben@bagu.org>
2967 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2968 added braces to a one line if statement because the Eclipse formatter
2969 was getting confused.
2971 2011-07-07 Ben Konrath <ben@bagu.org>
2973 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2975 These should really be two separate tasks but I counldn't get things to
2976 work with GWT 2.2.0 and Eclipse 3.7.
2980 * .settings/org.eclipse.jdt.core.prefs:
2981 * .settings/org.eclipse.jdt.ui.prefs:
2982 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2983 * .settings/org.eclipse.m2e.core.prefs:
2984 Add new config files. Update current files. Remove references to the
2985 webtools plugins as we're not using any of the webtools features.
2986 * .gitignore: Add logs directory which is created when running with
2988 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2989 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2990 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2992 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2994 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2996 onlineglom.properties: Add explanatory comments.
2998 * src/main/resources/onlineglom.properties: Also change the default user
2999 from ben to someuser, to avoid the risk of people thinking we just
3000 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3002 2011-06-28 Ben Konrath <ben@bagu.org>
3004 Use filename in Log for incorrect passwords.
3006 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3007 getFileName(String) method to get the filename from the URI.
3009 2011-06-28 Ben Konrath <ben@bagu.org>
3011 Add the table name to the URL token for the ListPlace.
3013 This makes things consistent between the DetailsPlace and the
3014 ListPlace. It also allows the the ListPlace to be bookmarked.
3016 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3017 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3018 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3019 Remove getDefaultListLayout(). The default layout is now returned
3020 by the getListLayout() method when the table name is an empty string.
3021 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3022 Add table name field. Change to a new ListPlace when the table
3023 has been changed. Use getListLayout() for getting the default
3025 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3026 Add table name field. Set the correct table name in the list box
3027 when loading from bookmark. This corrects a problem for the
3029 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3030 Move table name to super-class (HasSelectableTable). Move document
3031 and table URL keys to super-class in HasSelectableTable.
3032 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3033 Add table name field. Add Tokenizer class with URL key common to
3034 the subclasses (DetailsPlace and ListPlace).
3035 * src/main/java/org/glom/web/client/place/ListPlace.java:
3036 Add table name. Add code to parse the URL token.
3037 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3038 Update ListPlace construction with empty table name string.
3039 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3040 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3041 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3042 Update ListPlace construction with table name string.
3043 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3044 Change defaultTableName field to tableName to reflect how it's now
3045 used. Update the getter and setter methods.
3047 2011-06-28 Ben Konrath <ben@bagu.org>
3049 Enable the table selector in the DetailsView.
3051 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3052 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3054 Remove getDefaultDetailsLayout(). The default layout is now returned
3055 by the getDetailsLayout() method when the table name is an empty
3057 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3058 event handler for table change event. Change to using
3059 getDetailsLayout() for the default details layout.
3060 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3062 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3063 when navigating to the details place.
3065 2011-06-27 Ben Konrath <ben@bagu.org>
3067 Use filename based unique document ID in URL and for RPC.
3069 The document ID is the glom document name with spaces (' ') replaced
3070 with pluses ('+') and without the .glom extension.
3072 This change is mostly a string substitution of 'documentTitle' for
3073 'documentID'. The only code change is the addition of a Documents DTO to get the
3074 filename to document title mappings as indicated below.
3076 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3077 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3078 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3079 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3080 Use Documents DTO to create the document links in the document
3082 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3083 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3084 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3085 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3086 * src/main/java/org/glom/web/client/place/ListPlace.java:
3087 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3088 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3089 * src/main/java/org/glom/web/client/ui/ListView.java:
3090 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3091 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3092 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3093 * src/main/java/org/glom/web/server/Log.java:
3094 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3095 getDocumentTitles() to getDocuments() and return the Documents DTO.
3096 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3097 transferring the filename to document title mappings.
3099 2011-06-25 Ben Konrath <ben@bagu.org>
3101 Make the authentication popup work again.
3103 This bug was introduced when I extracted ConfiguredDocument to its own class.
3105 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3106 correct success / fail status in setUsernameAndPassword().
3108 2011-06-25 Ben Konrath <ben@bagu.org>
3110 Use filename as unique key for configuring database usernames and passwords.
3112 This replaces the use of the Glom document title which could change
3113 depending on the locale. Thanks to Murray Cumming for pointing out this
3116 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3117 * src/main/resources/onlineglom.properties:
3119 2011-06-24 Ben Konrath <ben@bagu.org>
3121 Pass primary key value to DetailsView.
3123 This enables the DetailsView to load the correct data.
3125 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3126 primary key value field and set in constructor. Pass primary key
3127 value to getDetailsData().
3128 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3129 variables for document title and primary key value.
3130 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3131 key value to the DetailsPlace.
3133 2011-06-24 Ben Konrath <ben@bagu.org>
3135 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3137 This allows the primary key to be retrieved by the Details button. This
3138 functionality has not been implemented yet but it's in the works.
3140 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3141 the LayoutGroup result to ListView.setCellTable instead of all of its
3142 fields individually.
3143 * src/main/java/org/glom/web/client/ui/ListView.java:
3144 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3145 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3146 get the primary key for the table.
3147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3148 index of the primary key in the LayoutGroup accounting for hidden
3149 primary keys. Rename getJavaNumberFormat() to
3150 convertToJavaNumberFormat() for consistency. Cleanup / add some
3152 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3153 field for primary key index and a field to indicate whether the
3154 primary key is hidden or not.
3156 2011-06-23 Ben Konrath <ben@bagu.org>
3158 Rename getTableData methods to getListData.
3160 This is a rename refactor for consistency with other methods.
3162 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3163 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3164 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3165 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3167 2011-06-23 Ben Konrath <ben@bagu.org>
3169 Extract the ConfiguredDocument innerclass into its own class.
3171 This makes the servlet code more object oriented.
3173 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3174 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3176 new ConfiguredDocument class.
3178 2011-06-21 Ben Konrath <ben@bagu.org>
3180 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3182 This makes things more inline with how libglom works and reduces code
3183 duplication. This refactor lays the groundwork for adding the primary key to
3184 the LayoutGroup object.
3186 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3187 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3188 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3189 Change method names to getListLayout and getDefaultListLayout for
3190 consistency. Use LayoutGroup as the DTO for the list layout instead of
3191 ColumnInfo and LayoutListTable.
3192 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3193 new method names along with the LayoutGroup object for transferring the
3195 * src/main/java/org/glom/web/client/ui/ListView.java:
3196 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3197 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3198 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3200 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3201 Replaced with LayoutGroup.
3202 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3203 expectedResultSize and defaultTableName fields which are needed for
3205 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3206 type field which is needed for the list layout but will also be
3207 useful for the details layout as things progress.
3208 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3209 Make class abstract. Remove the unnecessary
3210 getFormattingHorizontalAlignment method. Add setFormatting method.
3212 2011-06-16 Ben Konrath <ben@bagu.org>
3214 Add scripts for building and installing war.
3216 These will help when updating OnlineGlom but they're also good
3217 supplemental documentation of the build and deployment proceeding.
3219 * utils/build-onlineglom-war.sh: New file.
3220 * utils/install-onlineglom-war.sh: New file.
3222 2011-06-16 Ben Konrath <ben@bagu.org>
3224 Create wrapper class to create consistent log messages.
3226 I wrapped methods in the Log class of gwt-log to add the method names
3227 from the servlet and create consistent formatting of the document title
3228 and table names in the log messages.
3230 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3232 log methods to use methods from wrapped Log class.
3234 2011-06-16 Ben Konrath <ben@bagu.org>
3236 Remove superfluous conditional return.
3238 Thanks to Murray Cumming for pointing this out!
3240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3242 2011-06-15 Ben Konrath <ben@bagu.org>
3244 Return an ArrayList of LayoutGroups for the Details layout.
3246 This corrects a problem with the details layout as it can have more
3247 than one top level LayoutGroup.