tests: Use @BeforeClass on tearDown().
[online-glom:gwt-glom.git] / ChangeLog
1 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
2
3         tests: Use @BeforeClass on tearDown().
4
5         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
6         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
7         This avoids leaking a postgres process in SelfHostExampleTest.
8
9 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
10
11         tests: Test translations more.
12
13         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
14         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
15         Test titles in the non-default locale.
16
17 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
18
19         tests: Add SelfHostConfiguredDocumentTest
20  
21         * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the 
22         username and password, for use by ConfiguredDocument.
23         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java: 
24         This tests some of the ConfiguredDocument API that requires a database connection.
25
26 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
27
28         Document: Load title translations and test them.
29
30         * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
31         of titles. I am surprised that we do not do this yet.
32         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
33         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
34         Test translations more.
35
36 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
37
38         Set JDBC timeouts.
39
40         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
41         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
42         Set the timeout here too.
43
44 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
45
46         tests: ConfiguredDocumentTest: Make this pass.
47
48         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
49         Disable tests that need a database connection.
50
51 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
52
53         Use Java 1.7 instead of Java 1.6.
54
55         * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
56         to do this twice, at least for Eclipse.
57         This seems OK because it is the current version.
58
59 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
60
61         Some error checking.
62
63         * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
64         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
65         Avoid using a null Connection.
66
67 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
68
69         tests: Add a ConfiguredDocument test.
70
71         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
72         Add this test.
73
74 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
75
76         LayoutItemFIeld: getName(): Use the Field if it is set.
77
78         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
79         getName(): If the full field details have been set, return its name, so that
80         callers do not need to set the name separately.
81         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
82         testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
83         so we can count the rows.
84
85 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
86
87         tests: SelfHoster: Test SqlUtils too.
88
89         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
90         Retrieve some data and check it too, as in the regular Glom
91         test_selfhosting_new_from_example.cc test.
92         * src/test/java/org/glom/web/server/SelfHoster.java:
93         createConnection(): Make this public.
94
95 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
96
97         tests: SelfHoster: createConnection(): Do not warn about expected failures.
98         
99         Let the caller say if the connection is expected to fail, to avoid 
100         irrelevant error output.
101
102 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
103
104         tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
105         
106         * src/test/java/org/glom/web/server/SelfHoster.java:
107         createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
108         due to the inevitable need to retry the connection while the database server
109         starts.
110
111 2012-07-20  Murray Cumming  <murrayc@murray.com>
112
113         tests: SelfHoster: createConnection(): Set a timeout.
114
115         * src/test/java/org/glom/web/server/SelfHoster.java:
116         createConnection(): Use setLoginTimeout() because it otherwise seems to take
117         ages to actually return when it fails.
118
119 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
120
121         tests: SelfHoster: selfHost(): Close the test connection.
122
123         * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
124         When we check that the connection works, close the connection. This seems
125         to not be closed automatically otherwise.
126
127 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
128
129         Use slf4j-simple to see JDBC errors.
130
131         * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
132
133 2012-07-19  Murray Cumming  <murrayc@murrayc.com>
134
135         SelfHoster.discoverFirstFreePort(): Close the socket.
136
137         * src/test/java/org/glom/web/server/SelfHoster.java:
138         discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
139
140 2012-07-19  Murray Cumming  <murrayc@murrayc.com>
141
142         Avoid another code warning in Eclipse Juno.
143
144         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
145         Do instanceof checks on the FileUtils.listFiles() result and its 
146         items.
147
148 2012-07-13  Murray Cumming  <murrayc@murrayc.com>
149
150         Avoid some code warnings in Eclipse Juno
151
152         * src/main/java/org/glom/web/server/libglom/Document.java:
153         getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
154         * src/test/java/org/glom/web/server/SelfHoster.java
155         createTextFile(): Make sure that the FileOutputStream is closed.
156
157 2012-06-22  Murray Cumming  <murrayc@murrayc.com>
158
159         Added OnlineGlomPropertiesTest.
160
161         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
162         Make sure we never return a null string.
163         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
164         Added tests of the OnlineGlomProperties API, using our sample file.
165
166 2012-06-20  Murray Cumming  <murrayc@murrayc.com>
167
168         Make OnlineGlomProperties be a normal class.
169
170         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
171         Move OnlineGlomProperties into its own file to be a regular class:
172         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
173         This makes testing simpler.
174
175 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
176
177         OnlineGlomServiceImpl.init(): Move some code into a new method.
178
179         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
180         Create addDocument().
181
182 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
183
184         OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
185
186         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
187         OnlineGlomProperties.getKey(): Make this more robust by moving the
188         check for *.*.filename to here.
189
190 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
191
192         OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
193
194         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
195         init(): Move knowledge of the config file format into the 
196         OnlineGlomProperties inner class.
197
198 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
199
200         SelfHostExampleTest: Make sure we cleanup on failure.
201
202         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
203         the use of cleanup() to a tearDown() JUnit method.
204
205 2012-06-12  Murray Cumming  <murrayc@murrayc.com>
206
207         ConfiguredDocument: Add a primary key to portals at least once.
208
209         * src/main/java/org/glom/web/server/ConfiguredDocument.java
210         updatePortalsExtras): Fix a typo so that we add the primary key
211         column at least once.
212         This is a fix for the previous commit:
213         ConfiguredDocument: Do not add a primary key to portals each time.
214
215 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
216
217         SelfHoster: Avoid some compiler warnings.
218
219         * src/test/java/org/glom/web/server/SelfHoster.java
220         executeCommandLineAndWait():
221         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
222         the now-unused streams for stdout and stderr from the command Processes.
223         These are not used because readln() hangs while waiting for a new line,
224         where there may be no next line. The commented out code is still there
225         to help us figure out how to do this properly.
226
227 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
228
229         LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
230
231         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
232         Make this actually test the cloning again, though it is not very useful
233         now that we do not use the part that had a problem with cloning before.
234
235 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
236
237         SelfHoster: Keep trying pg_ctl after starting postgres.
238
239         * src/test/java/org/glom/web/server/SelfHoster.java
240         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
241         Try pg_ctl repeatedly (for ever) until it succeeds, as we do in 
242         regular Glom. This seems mad but it seems to work because the first
243         command would fail if pg_ctl would eventually fail.
244
245 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
246
247         SelfHoster: Wait until the server is really ready.
248
249         * src/test/java/org/glom/web/server/SelfHoster.java
250         selfHost(): Attempt the connection after starting the server, retrying 
251         a few times if necessary, so that the server is really ready already when
252         we return from this method.
253         The regular Glom code does this too because pg_ctl reports success too soon.
254
255 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
256
257         ConfiguredDocument: Do not add a primary key to portals each time.
258
259         * src/main/java/org/glom/web/server/ConfiguredDocument.java
260         updatePortalsExtras(): Only add an extra primary key field if there is 
261         none, to avoid adding one each time we retrieve the details layout from the
262         layouts cache.
263         This should fix bug #676986 (Ben Konrath) 
264
265 2012-05-25  Murray Cumming  <murrayc@murrayc.com>
266
267         Document.load(): Support version 7 documents. 
268
269         * src/main/java/org/glom/web/server/libglom/Document.java: Load the 
270         database_title attribute if the title attribute is not there.
271         Bug #676737
272
273 2012-05-24  Ben Konrath  <ben@bagu.org>
274
275         Add configuration for auto-generating mvn:i18n from with Eclipse.
276
277         * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
278
279 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
280
281         Update translations, adding French.
282
283         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
284         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
285         Add a French translation, using the translation from Glom.
286
287         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
288         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
289         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
290         Update these based on the translations from Glom.
291
292 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
293
294         SelfHoster: Add some debug println messages to help when things fail.
295
296         * src/test/java/org/glom/web/server/SelfHoster.java: Add several
297         System.out.println() lines.
298
299 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
300
301         Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
302
303         * src/test/java/org/glom/web/server/SelfHoster.java:
304         getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for 
305         instance) instead of just /usr/bin (as on Fedora). Check the result when 
306         using this method.
307
308 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
309
310         Remove LayoutItemPortal.get/setNavigationTable().
311         
312         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
313         Remove get/setNavigationTable(), which is only a cache, because it is not
314         used, and does not need to be used, because that decision should be made on
315         the server.
316         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
317         updatePortalsExtras():
318         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
319         getNavigationRecord():
320         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
321         Adapted.
322
323 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
324
325         Initial self-hosting for tests.
326
327         * pom.xml: Change the scope for log4j, to hopefully make it 
328         available to the test code which uses it indirectly via jOOQ.
329         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
330         self-hosting, though we only use it for testing.
331
332         * src/main/java/org/glom/web/server/libglom/Document.java:
333         example rows: Use a map instead of a list for each row of values,
334         so we know what field they are for, instead of relying on the sequence
335         being correct. This is not very efficient, but it does not really need 
336         to be.
337         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
338         testReadTableExampleRows(): Adapted.
339
340         * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
341         that returns an Object, for generic use. Note that Object seems to be 
342         the implicit base even of double.
343         * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
344         for use in CREATE TABLE SQL queries.
345         * src/test/java/org/glom/web/server/SelfHoster.java: Add this class 
346         to do self-hosting of PostgreSQL databases via its command-line 
347         utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
348         backends/postgres_self.cc. This is incomplete - it needs more 
349         warnings about failures and it needs to clean up properly when things
350         fail.
351         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple 
352         test of this new class.
353
354 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
355
356         Document: loading example data: Handle exceptions.
357
358         * src/main/java/org/glom/web/server/libglom/Document.java:
359         DateFormat.parse() and Double.valueOf() can throw exceptions, though
360         Eclipse did not warn about that.
361
362 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
363
364         Document: load(), save(): Handle the example rows.
365
366         * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate() 
367         and get/setImage().
368         * src/main/java/org/glom/web/server/libglom/Document.java:
369         load(), save(): Load and save the example rows, though the date, time
370         and image types are not handled properly yet.
371         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
372         Add testReadTableExampleRows() just to check that something is read.
373
374 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
375
376         Document: Add save().
377
378         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
379         Added getTranslationsMap() for use while saving.
380         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
381         Adedd getUseDefaultFormatting() for use while saving.
382         * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
383         and several private methods that it uses.
384
385         This will be useful while testing via self-hosting.
386         It is not complete, but should be complete enough for testing.
387
388 2012-05-17  Murray Cumming  <murrayc@murrayc.com>
389
390         OnlineGlomService: Simplify the getList/RelatedViewData() methods.
391
392         * src/main/java/org/glom/web/client/OnlineGlomService.java
393         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
394         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
395         Remove getSortedListViewData() and getSortedRelatedListData(), adding
396         the sort column index and ascending bool to the regular method.
397         Instead, a sort column index of -1 now means no sort.
398         This is less explicit, but it's fairly simple, reduces the amount of 
399         code, and makes the OnlineGlomService API slightly smaller.
400         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
401         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
402         getDataProvider():
403         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
404         getListViewData(), getRelatedListData():
405         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
406         getListViewData(), getRelatedListData():
407         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
408         getListData():
409         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
410         getData():
411         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
412         getData(): Adapted.
413
414 1.21.9.2:
415
416 2012-05-16  Murray Cumming  <murrayc@murrayc.com>
417
418         Use translations for top-level groups too.
419
420         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
421         updateTitlesForLocale(): Use the translation for the group 
422         as well as for child items.
423
424 1.21.9.1:
425
426 Just recompiled to fix a problem in the released .tar.gz file.
427
428 1.21.9:
429
430 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
431
432         Corrections to navigation to related records.
433         
434         * src/main/java/org/glom/web/client/OnlineGlomService.java:
435         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
436         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
437         getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
438         getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a 
439         relationship name, because the relationship name is not necessarily unique 
440         on the layout.
441         TOOD: This is inefficient, because it passes the whole list of 
442         child field items back to the server, but it is more correct, and happens
443         to fix a bug with the primary key being lost after a few navigations.
444         There is probably a chance to make this more efficient anyway in some 
445         more basic way.
446         
447         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
448         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
449         * src/main/java/org/glom/web/server/ConfiguredDocument.java
450         * src/main/java/org/glom/web/server/database/DBAccess.java
451         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
452         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
453         Adapted.
454
455 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
456
457         Fix the use of translations.
458
459         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
460         Add updateTitlesForLocale().
461         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
462         Call it to discard unwanted translations and to make getTitle() return
463         the wanted translation wihout the need for the client code to specify a locale.
464         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
465         getTitle(): Fallback to the original title, as libglom does.
466
467 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
468
469         Document: Correctly report the number of available translation locales.
470
471         * src/main/java/org/glom/web/server/libglom/Document.java: Fill
472         the available locale IDs list.
473         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
474         testLocales: Test this.
475
476 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
477
478         SqlUtils: Use camelCase.
479
480         * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
481         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
482         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
483         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
484         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
485         * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
486
487 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
488
489         Use jOOQ's tableByName() and fieldByName.
490
491         * pom.xml: Use jOOQ 2.3.1 to get the new API.
492         * src/main/java/org/glom/web/server/SqlUtils.java:
493         build_sql_select_step_with_where_clause(), .createField(),
494         builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
495         so we can get correct quoting and escaping. Thanks to Lukas Eder for 
496         adding this, and other things, to jOOQ.
497
498 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
499
500         SqlUtils: Remove the Connection parameters.
501
502         * src/main/java/org/glom/web/server/SqlUtils.java:
503         build_sql_select_with_key(), build_sql_select_with_where_clause(),
504         createSelect(), build_sql_select_step_with_where_clause(),
505         build_sql_count_select_with_where_clause(),
506         build_sql_select_count_rows(): Remove the Connection parameter because
507         jOOQ does not actually need a connectionwhen it is just used to build 
508         a SQL string:
509         https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
510
511         * src/main/java/org/glom/web/server/ReportGenerator.java:
512         generateReport():
513         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
514         getData():
515         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
516         Constructor, getListData(), getResultSizeOfSQLQuery():
517         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
518         getSelectQuery(), getCountQuery():
519         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
520         getSelectQuery(), getCountQuery():
521         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
522         getNavigationRecord(): Adapted.
523
524 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
525
526         Fix quick find.
527
528         * src/main/java/org/glom/web/server/SqlUtils.java:
529         get_find_where_clause_quick(): Use a comparison of 
530         lowercase values, instead of a simple equals. Regular Glom
531         uses the PostgreSQL ILIKE operator but jOOQ does not 
532         support that just yet, though it will soon.
533
534 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
535
536         TableToViewDetails: Use a real serialization ID.
537
538         * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
539         Though this does not fix the serialization problem.
540
541 2012-05-12  Murray Cumming  <murrayc@murrayc.com>
542
543         Added LayoutItemPortalDeepCloneTest.
544
545 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
546
547         Make navigation work again.
548
549         * src/main/java/org/glom/web/server/libglom/Document.java:
550         Add getLayoutItemFieldShouldHaveNavigation().
551         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
552         Replace get/setAddNavigation() with the partly-existing 
553         get/setNavigationTableName(), with an empty string being no navigation,
554         because this is simpler. Use the new 
555         Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
556         
557         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
558         Add updateFieldsExtras() and call setNavigationTableName in it.
559         getDetailsLayoutGroup(), 
560         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
561         createLayout(): Adapted.
562         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
563         Constructor: Adapted.
564
565         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
566         Replace get/setAddNavigation() with get/setNavigation(), returning a
567         TableToViewDetails class with both the table name and UsesRelationship,
568         because both are need. The previous code used java-libglom's output 
569         variable (strangely, via sharedptr) to return both, but we cannot really
570         do that in Java.
571         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
572         getNavigationRecord(): Adapt. However, we cannot actually use the cache
573         here because it somehow gets set to null during deepCopy(). I must test this.
574         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
575         testGetSuitableTableToViewDetails(): Adapted.
576         
577         TODO: Find out why deepClone() is not quite working.
578         
579 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
580
581         DBAccess: Simplify the retrievel of full field details.
582
583         * src/main/java/org/glom/web/server/database/DBAccess.java
584         getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
585         because the Document loading should have done this.
586
587 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
588
589         Document: Correct loading of doubly-related layout fields.
590
591         * src/main/java/org/glom/web/server/libglom/Document.java:
592         loadUsesRelationship(): Actually set the related relationship, instead
593         of only setting it if it's not found.
594
595 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
596
597         Replace all appearances of Colour with color.
598
599         Because US English is dominant.
600
601 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
602
603         Use colors in HTML format, solving a warning about an unused function.
604
605         * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
606         * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
607         Add *asHTMLColor() versions of methods.
608         TODO: However, we should create and cache the results on the server.
609         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
610         * src/main/java/org/glom/web/client/ui/list/ListTable.java
611         * src/main/java/org/glom/web/server/ConfiguredDocument.java
612         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
613         Use the asHTMLcolor() versions.
614
615 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
616
617         ListViewTable: Constructor: Take the table name as a parameter.
618
619         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
620         Constructor: Take the tableName, and set the member variable, because
621         we use it here.
622         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
623         setCellTable(): Pass the table name.
624         This makes navigation to non-default tables work again. I don't know 
625         why it worked before in the master branch.
626
627 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
628
629         ConfiguredDocument: Restore correct addition of hidden primary key items.
630
631         * src/main/java/org/glom/web/client/ui/list/ListTable.java
632         (ListTable.createCellTable): Uncomment out the check for the hidden
633         primary key.
634         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
635         add primary key items for top-level lists and portals, as before, 
636         instead of adding them to each group.
637         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
638         Actually implement the extra methods such as setHiddenPrimaryKey() and
639         comment that these are used only for top-level list groups and in portals.
640         This strangeness suggests even more that this should not be squeezed
641         into the LayoutGroup class.
642
643 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
644
645         Fix Formatting loading.
646
647         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
648         getFormattingUsed(): Remove the duplicate Formatting member variable
649         in favour of the one from the base class.
650         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
651         Initialize a new Formatting instead of using null by default, so we 
652         have some defaults, instead of having to initialize one later just to 
653         get the same defaults. This also makes loading of formatting from the
654         document work, because that expected a non-null.
655
656 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
657
658         RelatedListTable: Make sure that the tableName is set.
659
660         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
661         Constructor: Take the tableName so it is available later. Otherwise, 
662         the server assumes that we mean the default table and cannot find the
663         relationship in it.
664         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
665         setData(): Pass the tableName to the RelatedListTable constructor.
666
667 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
668
669         Add some checks.
670
671         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
672         RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
673         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
674         getDataProvider():
675         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
676         addColumn():
677         * src/main/java/org/glom/web/server/database/DBAccess.java:
678         convertResultSetToDTO(), getPortal():
679         * src/main/java/org/glom/web/server/database/ListDBAccess.java
680         getListData():
681         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
682         Add checks for null objects and out of range access, with log messages to
683         give hints so we can fix these properly.
684
685 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
686
687         Portals: some corrections.
688
689         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
690         setData():
691         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
692         constructor: Use getRelationshipNameUsed() instead of getName(), because
693         that is what is meant.
694         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
695         getFromField(): Fix a typo, to get the field name, not the table name.
696         * src/main/java/org/glom/web/server/database/DBAccess.java:
697         getPortal(): Fix a typo that stopped this from working.
698
699 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
700
701         LayoutItemPortal: Also override getTitleOriginal().
702
703         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
704         This lets the base getTitle() with no parameters work.
705         TODO: Test this properly.
706
707 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
708
709         LayoutItemPortal: getTitle*(): Use the relationship title.
710
711 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
712
713         LayoutItemField: Fix loading of custom titles.
714
715         * src/main/java/org/glom/web/server/libglom/Document.java
716         loadDataLayoutItemField(): The title, if any, instead of the field 
717         title, is stored in a title_custom node. Load it from there.
718         * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
719         class.
720         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
721         Add getCustomTitle() and use it, instead of super.getTitle*(), in the
722         getTitle*() overrides.
723         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
724         Adapt.
725
726 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
727
728         LayoutItemField: Fall back to field titles, so some are really shown.
729
730         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
731         Override getTitleOriginal() and getTitle(), as in java-libglom.
732         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
733         Test this behaviour.
734
735 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
736
737         Correct use of setExpectedResultSize().
738
739         * src/main/java/org/glom/web/server/ConfiguredDocument.java
740         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
741         Use setExpectedResultSize only on top-level groups (for instance, the
742         list layout) or on child portals (in details views).
743         Use the correct table name for portals to avoid SQL errors.
744         Update the expected counts when returning cached layouts.
745
746 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
747
748         Document: Interpret no group column count as 1.
749
750         * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
751         default, though we now check for this in the UI code anyway.
752
753 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
754
755         More null checks.
756
757 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
758
759         Translatable: Use Hashmap instead of Treemap because GWT supports it.
760
761         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
762         The use of Treemap lead to this error from async methods, with no 
763         further clue:
764         "The response could not be deserialized"
765
766 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
767
768         OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
769
770         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary 
771         when using the Google -> GWT Compile, or 
772         g toolbar button -> GWT Compile Project... feature in Eclipse.
773
774 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
775
776         ListTable.addColumn(): Protect against a null Formatting.
777
778         * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
779         Create a default Formatting if it is null, because that is the simplest
780         way to do this.
781
782 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
783
784         ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
785
786         * src/main/java/org/glom/web/server/ConfiguredDocument.java
787         updateLayoutGroup(): Check that the field is not null.
788
789 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
790
791         ListViewImpl: Protected against a bad cast error.
792
793         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
794         onEnterKeyDown(): Do not cast without an instanceof check.
795
796 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
797
798         ListTable: Protect against an out of range error.
799
800         * src/main/java/org/glom/web/client/ui/list/ListTable.java
801         createCellTable(): This is unlikely, but can happen while debugging.
802
803 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
804
805         AsyncMessage onFailure() callbacks: Log the exception message.
806
807         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
808         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
809         * src/main/java/org/glom/web/client/activity/ListActivity.java:
810         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
811         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
812         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
813         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
814         These are useful clues when something is wrong.
815
816 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
817
818         ConfiguredDocument: Avoid a null dereference.
819
820         * src/main/java/org/glom/web/server/ConfiguredDocument.java
821         TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and 
822         details maps are created.
823
824 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
825
826         Document: Correct the port number parsing.
827
828         * src/main/java/org/glom/web/server/libglom/Document.java:
829         This lets us actually connect to the database and show the document.
830
831 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
832
833         Fix mvn gwt:test
834
835         * pom.xml: Use htmlunit mode for gwt:test, because the default demands
836         user-interaction, asking us to load a temporary URL in a browser.s
837         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
838         which is apparently necessary for testing the service. See the comment.
839         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java: 
840         Show the exception, if any. This is how I saw the 404 in the HTML in 
841         the exception.
842
843 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
844
845         DocumentTest: Move the .glom files into the resources directory.
846
847         * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
848         URI via getResource().
849
850 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
851
852         Document: Remove the FieldIdentifies inner class.
853
854         * src/main/java/org/glom/web/server/libglom/Document.java: We only
855         use the Relationship (though the same function in libglom is maybe
856         used in other ways) and so this removes a compiler warning.
857
858 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
859
860         Document.load() Remove the error code parameter.
861
862         * src/main/java/org/glom/web/server/libglom/Document.java: load():
863         Remove the parameter. We do not set it yet and it could never have
864         worked as an output parameter (though maybe it did in java-libglom).
865         We could use an exception if we really want the failure reason.
866         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
867         init():
868         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
869         setUp(), testGetSuitableTableToViewDetails(): Adapt.
870
871 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
872
873         Make some inner classes static.
874
875         * src/main/java/org/glom/web/server/ConfiguredDocument.java
876         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
877         * src/main/java/org/glom/web/server/ReportGenerator.java
878         * src/main/java/org/glom/web/server/libglom/Document.java
879         Make all inner classes static that can be static.
880
881 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
882
883         OnlineGlomServiceImpl: Do not load and check for java-libglom.
884
885         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
886         init(): We do not use java-libglom any more.
887
888 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
889
890         Remove mentions of java-libglom.
891
892         * README: Remove mention of java-libglom, because it no longer needed.
893         * utils/build-onlineglom-war.sh:
894         * utils/check-and-recover-tomcat.py:
895         * utils/install-onlineglom-war.sh: Remove these as they are no longer
896         useful. Building is now far easier, with no need for jhbuild.
897
898 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
899
900         Fix the build (mvn package)
901
902         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
903         (LayoutGroup): Make the LayoutItemList inner class static and protected.
904         Otherwise the GWT Java->Javascript compilation fails with just this
905         error, during mvn package or when attempting to view in a browser, 
906         in the GWT developer mode in Eclipse.
907
908         [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
909         [INFO] auto discovered modules [org.glom.web.OnlineGlom]
910         [INFO] Compiling module org.glom.web.OnlineGlom
911         [INFO]    [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
912         [INFO]       [ERROR] Line 46:  Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
913         [INFO]    Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
914         [INFO]       [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
915         [INFO]          [WARN] org.glom.web.client.OnlineGlomService_Proxy
916         [INFO]    [ERROR] Cannot proceed due to previous errors
917
918         It has taken me 2 days to find out what was causing that. After reducing
919         the code, the compiler eventually showed me the full error message.
920
921 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
922
923         ConfiguredDocument: Cache the cloned and stripped layouts.
924
925         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
926         getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
927         layout in a map, so we can retrieve it again without rebuilding it.
928
929 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
930
931         UsesRelationshipImpl: Complete the relationshipEquals() implementation.
932
933 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
934
935         libglom classes: Implement some auto-generated emthods.
936
937 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
938
939         Add GwtTestOnlineGlomService.
940
941         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
942         However, this (and the other GwtTest*) does not seem to run during 
943         mvn test. 
944
945 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
946
947         Remove use of unsupported features from client code.
948
949         * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
950         * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
951         * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
952         Use our client version of StringUtils instead of the apache commons one.
953         
954         However, the GWT Javascript compliation still fails.
955
956 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
957
958         Add a Field class and implement some loading of it in Document.
959
960 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
961
962         Initial Document loading implementation, instead of libglom.
963
964         * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
965         and Translatable classes, and adapt the rest of the code to use them.
966         However, this is still missing Layout and Field classes and loading.
967
968 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
969
970         Use of jOOQ: Move Field creation into a utility method.
971
972         * src/main/java/org/glom/web/server/SqlUtils.java:
973         This lets us improve it more easily.
974
975 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
976
977         Use of jOOQ: Improve the code to COUNT a sub-select.
978
979         * src/main/java/org/glom/web/server/SqlUtils.java:
980         Move initial query creation into 
981         build_sql_select_step_with_where_clause().
982         build_sql_select_count_rows(): Use the jOOQ API instead of
983         concatentating text, because a jOOQ Select*Step is a TableLike,
984         which is what from() takes.
985
986 2012-04-23  Murray Cumming  <murrayc@murrayc.com>
987
988         Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
989
990         * pom.xml: Depend on jooq.
991         * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
992         methods with jOOQ, based on the C++ implementations in libglom,
993         with some changes to the logic required by jooQ.
994         Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
995         where clause.
996         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
997         * src/main/java/org/glom/web/server/ReportGenerator.java:
998         * src/main/java/org/glom/web/server/SqlUtils.java:
999         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1000         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1001         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1002         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1003         * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1004         Adapt. In particular, the SqlUtils methods now need to take a Connection,
1005         because jOOQ needs that, though it seems unnecessary.
1006
1007         This is not quite finished. Ideally jOOQ would help us to build 
1008         table_name.field_name names, quoting and escaping them properly.
1009         See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1010
1011 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1012
1013         Move use of Glom.build_sql*() into a new SqlUtils class.
1014
1015         * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1016         to wrap Glom.build_sql*(). The parameter types are still Glom one,
1017         but this will make it easier to start using something other than 
1018         libglom or SqlBuilder.
1019
1020 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1021
1022         Update the project URL.
1023
1024         * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1025
1026 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1027
1028         Main layout: Use a FlowTable instead of absolute positioning.
1029
1030         * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1031         The RootLayoutPanel is a (extends) AbsolutePanel, so each of its 
1032         child panels/widgets must have an absolute position. But that is annoying, so
1033         this adds a FlowTable and puts the child panels in there.
1034
1035 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1036
1037         GwtTestOnlineGlom: Comment out unused code.
1038
1039         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1040         Eclipse has started to say that some code is unused.
1041
1042 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1043
1044         Update to the latest versions of dependencies.
1045
1046         * pom.xml: Update version numbers of dependencies to the latest
1047         versions.
1048         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1049         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1050         * src/main/java/org/glom/web/server/ReportGenerator.java:
1051         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1052         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1053         * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1054         java:
1055         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1056         Modify the imports where necessary.
1057
1058 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1059
1060         Style: Remove overflow:hidden from searchbox
1061
1062         * src/main/webapp/style.css: Because this pushes the Back To Link
1063         label/link on to the next row, which is then hidden due to the 
1064         hard-coded (in ems) height.
1065
1066 2012-04-20  Murray Cumming  <murrayc@murrayc.com>
1067
1068         Remove some duplicate code.
1069
1070         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1071         getDocumentInfo(): This must have been duplicated during the merge from the
1072         reports branch.
1073
1074 1.21.8.1:
1075
1076 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1077
1078         Reports: Localize the waiting for report message.
1079
1080         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1081         start(): Get the message from the contants.
1082         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1083         Add the string here.
1084         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1085         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1086         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1087         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1088         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1089         Update these files with the English text for newer strings for now.
1090
1091 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1092
1093         Reports: Show a message while waiting for the report.
1094
1095         * src/main/java/org/glom/web/client/ui/ReportView.java
1096         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1097         Add setWaitingText(), to show a message saying that we are 
1098         waiting for the report to be ready.
1099         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1100         start(): Call setWaitingText() before calling the async
1101         report generation.
1102
1103 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1104
1105         ReportGenerator: Specify date and time formats.
1106
1107         * src/main/java/org/glom/web/server/ReportGenerator.java:
1108         createFieldValueElement(): Use the default (and localized)
1109         short formats, though we still need a way to show 4-digit
1110         years without providing the format for every locale.
1111         * src/main/java/org/glom/web/server/database/DBAccess.java:
1112         convertResultSetToDTO(): Use the short formats here too.
1113
1114 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1115
1116         ReportGenerator: Use the correct numeric formatting.
1117
1118         * src/main/java/org/glom/web/server/ReportGenerator.java
1119         createFieldExpression(), createFieldValueElement(): Take the
1120         whole LayoutItem_Field instead of just the field name, so
1121         we have access to the formatting.
1122         createFieldValueElement(): Use JRTextField.setPattern() to
1123         specify the numeric formatting, with the help of a 
1124         regular DecimalFormat.
1125
1126 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1127
1128         ReportGenerator: Avoid showing null for group by titles.
1129
1130         * src/main/java/org/glom/web/server/ReportGenerator.java
1131         generateReport(): Use setBlankWhenNull() on the field title
1132         style too, because this is used for values in group by
1133         sections.
1134
1135 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1136
1137         ReportGenerator: Add a colon to titles in vertical groups.
1138
1139         * src/main/java/org/glom/web/server/ReportGenerator.java
1140         addFieldToDetailBandVertical(): Pass true for the withColon
1141         parameter.
1142
1143 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1144
1145         ReportGenerator: Simplify the code by using Position more.
1146
1147 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1148
1149         Reports: Support vertical groups, roughly.
1150
1151         * src/main/java/org/glom/web/server/ReportGenerator.java:
1152         addToReport(): Rename to addGroupToReport() and, if necessary,
1153         call the new addVerticalGroupToReport() method.
1154         createFieldValueElement(): Let the caller specify the Y position
1155         too.
1156
1157 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1158
1159         Reports: Allow a second report to be shown.
1160
1161         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1162         clear(): Do not remove the HTML widget, which broke the whole layout.
1163
1164 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1165
1166         Locales drop-down: Show that we use English by default.
1167
1168         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1169         fillView(): When we use English, just because that is the default, when
1170         no locale is specified, show that in the Locales drop-down instead of 
1171         just showing the first item.
1172
1173 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1174
1175         Unselect the Report/Locale/Table combo item when appropriate.
1176
1177         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1178         setPlace(): clear reportName if this is not a ReportPlace.
1179         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1180         setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1181         When the provided name is empty, unselect all items, so that none are
1182         indicated. This uses a for loop because I cannot find a single method
1183         to do this.
1184
1185 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1186
1187         Report: Give the user a way to get back to the list.
1188
1189         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1190         start(), setPlace(): Show the Back To List link on reports, and also 
1191         interpret selecting the empty report item as back to list.
1192
1193 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1194
1195         Really show the selected Report name.
1196
1197         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1198         setPlace(): Store the reportName here, if it is that kind of Place.
1199         fillView(): Set the selected Report after filling the list of reports.
1200         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1201         setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1202         null Strings, though we need some way to unselect all ListBox items
1203         in that case.
1204
1205 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1206
1207         ReportGenerator: Try to avoid some problems.
1208
1209         * src/main/java/org/glom/web/server/ReportGenerator.java
1210         addField(): Try to avoid duplicates, and avoid using a null
1211         class type.
1212
1213 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1214
1215         Reports: Use quickFind.
1216
1217         * src/main/java/org/glom/web/client/OnlineGlomService.java;
1218         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1219         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1220         getReportHTML(): Add a quickFind parameter.
1221         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1222         start(): Pass the quickFind parameter.
1223         * src/main/java/org/glom/web/server/ReportGenerator.java
1224         generateReport(): Take a quickFind parameter.
1225
1226 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1227
1228         ReportPlace: Actually use the report name.
1229
1230         * src/main/java/org/glom/web/client/place/ReportPlace.java
1231         getPlace(): Do not assign the report name to the quickfind.
1232
1233 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1234
1235         Show java.library.path when complaining.
1236
1237         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1238         init(): When telling us to check java.library.path, show the
1239         current value.
1240
1241 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1242
1243         ReportGenerator: Do not show nulls.
1244
1245 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1246
1247         ReportGenerator: Make the title font larger.
1248
1249 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1250
1251         ReportGenerator: Put field titles inside groups, if there are groups.
1252
1253 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1254
1255         ReportGenerator: Take the Report itself instead of the name and group.
1256
1257         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1258         Remove getReportLayoutGroup().
1259         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1260         getReportHTML(): Pass the report instead
1261         of its name and layout group.
1262         * src/main/java/org/glom/web/server/ReportGenerator.java
1263         generateReport(): Use the report object to use the title 
1264         instead of the name.
1265
1266 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1267
1268         ReportGenerator: Remove designBand parameters.
1269
1270         * src/main/java/org/glom/web/server/ReportGenerator.java:
1271         Make designBand a class member instead of passing it to all
1272         methods.
1273
1274 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1275
1276         ReportGenerator: Add lines, a bit like in the desktop version.
1277
1278         * src/main/java/org/glom/web/server/ReportGenerator.java
1279         addToReport(): Use JRDesignLine.
1280
1281 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1282
1283         ReportGenerator: Correct the title positions and use some bold style.
1284
1285         * src/main/java/org/glom/web/server/ReportGenerator.java:
1286         Break the code up into reusable functions, correct the placement of 
1287         titles, and use normal/bold styles as in the reports in the desktop 
1288         version.
1289
1290 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1291
1292         ReportGenerator: Add a header band to show the field titles.
1293
1294         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1295         getReportHTML(): Pass the localeId to the ReportGenerator 
1296         constructor.
1297         * src/main/java/org/glom/web/server/ReportGenerator.java
1298         constructor: Take the localeID so we can get translated field
1299         titles.
1300         generateReport(), addToReport(), addFieldToBand(): Add field 
1301         titles in a column header band.
1302
1303 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1304
1305         Reports drop-down list: Some improvement.
1306
1307         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1308         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1309         Adedd setSelectedReport(),
1310         setReportList(): Add a blank line so that the user can select the 
1311         first one.
1312         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1313         start(): Show the current report by calling setSelectedReport().
1314         This does not seem to work yet.
1315
1316 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1317
1318         DetailsActivity, ListActivity: Move some variables into a base class.
1319
1320         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1321         * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1322         * src/main/java/org/glom/web/client/activity/ListActivity.java: Move 
1323         the clientFactory, documentID, tableName and authenticationPopup into
1324         a base class, to avoid duplication.
1325
1326 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1327
1328         Translate the Reports label.
1329
1330         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1331         Get the "Reports" label string from the constants.
1332         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1333         perties: Add Reports to the constants.
1334
1335 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1336
1337         Reports: Implement grouping.
1338
1339         * src/main/java/org/glom/web/server/ReportGenerator.java:
1340         Handle LayoutItem_GroupBy items and try to do the right thing
1341         with JRDesignGroup. It seems to work.
1342
1343 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1344
1345         Actually show some data with JasperReports.
1346
1347         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: 
1348         getReportHTML(): Move most code into a ReportGenerator class.
1349         * src/main/java/org/glom/web/server/ReportGenerator.java:
1350         Recurse into sub-groups, adding fields to the JasperDesign's details
1351         band. Note that we must set an arbitrary width and height, or it just
1352         will not show any data.
1353
1354 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1355
1356         Reports Chooser: Show the titles, not the names.
1357
1358         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1359         (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1360         and the names as the values.
1361         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1362         (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1363         group now that we provide the report name, so it should always 
1364         succeed.
1365
1366 2012-02-15  Murray Cumming  <murrayc@murrayc.com>
1367
1368         Depend on jasperreports.
1369
1370         * pom.xml: Add the dependency. My plan is to use this on the 
1371         server side.
1372
1373 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1374
1375         Implement navigation to report places.
1376
1377         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1378         start(): Do not bother to handle all events here.
1379         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1380         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1381         Added getSelectedReport().
1382         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1383         .java: start(): When handling a change to the reports chooser,
1384         call getSelectedReport() and goTo() its ReportPlace.
1385         * src/main/java/org/glom/web/client/ui/ReportView.java
1386         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1387         Added setReportHTML() which puts the html in a gwt HTML widget.
1388         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1389         getReportHTML(): Return "TODO" just to show that this works.
1390
1391 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1392
1393         Make ReportPlace usable.
1394
1395         * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1396         Mention ReportPlace.
1397         * src/main/java/org/glom/web/client/place/ReportPlace.java:
1398         Correct the @prefix annotation.
1399
1400 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1401
1402         OnlineGlomService: Return report HTML rather than the LayoutGroup.
1403
1404         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1405         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1406         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1407         Change getReportLayout() to getReportHMTL() because we will not need to 
1408         parse or render the report layout on the client side.
1409         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1410         getReportLayout(): Return the libglom LayoutGroup type because we will
1411         not need to convert to a shared type, because this will not be used on
1412         the client side.
1413         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1414         Adapted.
1415
1416         Note that there is still no implementation for this.
1417
1418
1419 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1420
1421         Add a (empty) Report Place, View, and Activity.
1422
1423         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1424         Rename to:
1425         * src/main/java/org/glom/web/client/place/HasTablePlace.java
1426         * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1427         this into a superclass:
1428         * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1429         and also use it as the base of this new ReportPlace:
1430         * src/main/java/org/glom/web/client/place/ReportPlace.java
1431
1432         * src/main/java/org/glom/web/client/ui/ReportView.java
1433         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1434         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1435         Add these, containing mostly boiler-plate for now.
1436
1437         * src/main/java/org/glom/web/client/OnlineGlomService.java
1438         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1439         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1440         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1441         Add API to get the LayoutGroup for the report.
1442
1443 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1444
1445         Add and fill a Reports drop-down list box.
1446
1447         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1448         Aded getReports():
1449         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1450         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1451         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1452         Added getReports(document, table, localeID), calling 
1453         ConfiguredDocument.getReports().
1454         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1455         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1456         Added setReportsList() and a list widget.
1457         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1458         .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1459
1460
1461 1.21.8:
1462
1463 2012-04-12  Murray Cumming  <murrayc@murrayc.com>
1464
1465         Translations: Add Esperanto.
1466
1467         * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1468         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1469         properties: Add this translation because someone took the time to make it.
1470
1471 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1472
1473         Adapt to the java-libglom 1.21.7 API. 
1474
1475         * src/main/java/org/glom/web/server/ReportGenerator.java:
1476         addToReport(): get_group_secondary_fields() is now
1477         get_secondary_fields().
1478
1479
1480 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1481
1482         Use the latest java-libglom version.
1483
1484         * pom.xml: Use java-libglom 1.21.7.
1485
1486 2012-03-03  Ben Konrath  <ben@bagu.org>
1487
1488         Display date and time in details view.
1489
1490         https://bugzilla.gnome.org/show_bug.cgi?id=671257
1491
1492         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1493
1494 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1495
1496         Require the latest java-libglom.
1497
1498         * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1499
1500 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1501
1502         ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1503
1504         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1505         ListViewDBAccess.getSelectQuery(): Do not create a where clause for 
1506         an empty quickfind string. I also corrected libglom to create only 
1507         empty where clauses for empty quickfind strings, but this avoids the
1508         need for that fix.
1509
1510 2012-02-24  Ben Konrath  <ben@bagu.org>
1511
1512         Improve the tabs in the Notebook widget.
1513
1514         Bug #670728
1515
1516 2012-01-30  Murray Cumming  <murrayc@murrayc.com>
1517
1518         Translations: Try to translate the strings.
1519
1520         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1521         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1522         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1523         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1524         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1525         Take the Open translation from GTK+'s .po files.
1526         Take the Details translation from Glom's po files.
1527         I have added the other strings to Glom so we can get translations that way:
1528         http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1529
1530 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1531
1532         TableSelectionViewImpl: Put the search label and entry in a div.
1533
1534         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1535         Put the search widgets in a FlowTable so that the CSS can be used to
1536         style them while keeping them together.
1537         * src/main/webapp/style.css: Mention the new div.
1538
1539 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1540
1541         Translate more strings in more locales.
1542
1543         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1544         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1545         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1546         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1547         Translate the "Details" and "Open" string too.
1548
1549         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1550         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1551         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1552         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1553         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1554         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1555         Add these new locales as placeholders though they currently contain English.
1556
1557 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1558
1559         OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1560
1561         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1562         Check the ConfiguredDocument* for null before using it.
1563
1564 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1565
1566         Tell Eclipse about the generated java files.
1567
1568         * .classpath: This lets it find OnlineGlomConstants.java.
1569         It would be nice if Eclipse just used the maven build files.
1570
1571 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1572
1573         Prevent a crash when no locale is specified in the URL.
1574
1575         * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1576         Avoid returning a null string, obtained from 
1577         Window.Location.getParameter(). This caused a crash when it was
1578         later passed to libglom's API.
1579         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1580         init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1581         getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1582         guard against future null strings.
1583
1584 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1585
1586         Use the ?locale= query param instead of the &lang= token param. 
1587
1588         * src/main/java/org/glom/web/client/place/ListPlace.java
1589         * src/main/java/org/glom/web/client/place/DetailsPlace.java
1590         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1591         Remove the lang token key and value.
1592         
1593         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1594         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1595         When the user selects a different locale from the chooser, use 
1596         Window.Location.assign() to change the URL, which then causes a reload.
1597         
1598         * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1599         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1600         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1601         * src/main/java/org/glom/web/client/activity/ListActivity.java
1602         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1603         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1604         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1605         * src/main/java/org/glom/web/client/ui/ListView.java:
1606         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1607
1608         Remove localeID member variables and method/constructor parameters, instead
1609         using Utils.getCurrentLocaleID() when we need a localID to pass to 
1610         OnlineGlomService.
1611
1612 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1613
1614         Internationalize the UI strings.
1615
1616         * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a 
1617         <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1618         * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1619         because it is unused. Messages are apparently strings that can have 
1620         parameters, but we do not need that yet, so Contants will be enough for now.
1621         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1622         to say that we support the en and de locales.
1623         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1624         The original English strings.
1625         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1626         Some German translations of the English strings.
1627         The i18n goal then uses the .properties file to generate an 
1628         OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1629         returns an implementation that returns the translated strings.
1630         The documentation suggests putting these in src/java/*/client/, but it seems
1631         best to put it in src/resources/*/client/.
1632         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1633         Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1634         instead of hard-coding them.
1635         Note that we cannot import OnlineGlomConstants because it does not exist yet,
1636         but that does not seem to stop the build, though it confuses Eclipse.
1637         
1638         You can see the translated string by adding ?locale=de to the URL, like so:
1639         http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1640
1641 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1642
1643         Improve null/empty String checks. 
1644
1645         * pom.xml: Add a dependency on commons-lang, to use
1646         org.apache.commons.lang.StringUtils.
1647         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1648         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1649         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1650         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1651         Use StringUtils.isEmpty().
1652
1653         * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1654         StringUtils class with a static isEmpty() function because we 
1655         cannot use org.apache.commons.lang.StringUtils in client-side
1656         GWT code because it (apparently) cannot be compiled to javascript.
1657         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1658         * src/main/java/org/glom/web/client/activity/ListActivity.java
1659         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1660         * src/main/java/org/glom/web/client/place/DetailsPlace.java
1661         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1662         * src/main/java/org/glom/web/client/place/ListPlace.java
1663         * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1664         * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1665         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1666         * src/main/java/org/glom/web/client/ui/details/Group.java
1667         * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use 
1668         our StringUtils.isEmpty() function.
1669
1670 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1671
1672         Update to the latest java-libglom API.
1673
1674         * pom.xml: Require java-libglom 1.21.4.
1675         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1676         getDocumentInfo(), getListViewLayoutGroup():
1677         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1678         getDocuments():
1679         * src/main/java/org/glom/web/server/database/DBAccess.java
1680         getFieldsToShowForSQLQueryAddGroup(),
1681         getPrimaryKeyLayoutItemField(): Replace get_database_title()
1682         with either get_database_title_original() or 
1683         get_database_title(localeID).
1684
1685 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1686
1687         ConfiguredDocument: Avoid a null pointer exception.
1688
1689         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1690         Initialize localeID to "" to avoid returning a null String which 
1691         causes a crash in java-libglom's swing-generated code.
1692
1693 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1694
1695         Some simple renaming.
1696
1697         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1698         * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1699         for localeChooser. This seems more appropriate and is less ambiguous 
1700         particularly in the .css file.
1701
1702 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1703
1704         ConfiguredDocument: Rename the localedID private member variable.
1705
1706 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1707
1708         Adapt to the latest java-libglom API from git master.
1709
1710         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1711         libglom now uses only Vector instead of List, which uses add() instead of
1712         addLast(). 
1713
1714 2012-01-22  Murray Cumming  <murrayc@murrayc.com>
1715
1716         ConfiguredDocument: Rename the localedID private member variable.
1717
1718 2012-01-20  Murray Cumming  <murrayc@murrayc.com>
1719
1720         Build a source tarball with mvn assembly:single
1721
1722         * assembly.xml: Add this file.
1723         * pom.xml: Use the maven-assembly-plugin and tell it to use 
1724         our assembly.xml file.
1725
1726 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
1727
1728         OnlineGlomServiceImpl: Get .glom files recursively.
1729
1730         * pom.xml: Depend on commons-io from org.apache.commons.
1731         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1732         init(): Use org.apache.commons.io.FileUtils.listFiles() to get the 
1733         files recursively, and with the easier filter for the extension.
1734         Use org.apache.commons.io.FilenameUtils.removeExtension() to 
1735         simplify that code too.
1736
1737 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
1738
1739         README: Mention that you must install java-libglom packages separately.
1740
1741         But then it works, because java-libglom is now in the central maven 
1742         repository.
1743
1744 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1745
1746         locales drop-down: Show the correct selected locale when the URL changes.
1747
1748         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1749         .java: setPlace(): Move some code into fillView().
1750
1751 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1752
1753         locales drop-down: Do not lose the primary key.
1754
1755         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1756         start(): onLocaleChange(): Pass the current primary key value, 
1757         instead of an empty value.
1758
1759 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1760
1761         locales drop-down: Do not lose the drop-down selection.
1762
1763         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1764         .java (TableSelectionActivity.fillView): Set the selected locale
1765         after changing the drop-down items (though we do not really need
1766         to change them just because the locale changes.)
1767
1768 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1769
1770         locales drop-down: Change the tables list when this changes.
1771
1772         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1773         .java: TableSelectionActivity.start(): Move the async table titles
1774         retrieval into a private fillView() method and also call this when 
1775         the chosen locale changes.
1776         Note that the document title is not actually translatable yet, but
1777         that is a problem that I should fix soon in libglom.
1778
1779 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1780
1781         Improve the placement of the locales drop-down.
1782
1783         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1784         Put the title and locales drop-down in a div (gwt.FlowTable).
1785         * src/main/webapp/style.css: Add magic css properties to make this work.
1786         Also remove the left margin from the title so that it lines up with the 
1787         headerbox below it.
1788
1789 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
1790
1791         locales selector: Show human-readable locale titles.
1792
1793         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1794         getDocumentInfo(): Use java.util.Locale to show a real title of 
1795         each locale, in the locale's own language.
1796
1797 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1798
1799         Add a language/locale selector drop-down.
1800
1801         * src/main/java/org/glom/web/shared/DocumentInfo.java:
1802         Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1803         * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1804         getDocumentInfo(): Store the available Locales in the DocumentInfo.
1805         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1806         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1807         Add a ListBox to show the available locales. Add getLocaleSelector(),
1808         setLocaleList(), getSelectedLocale(), setSelectedLocale().
1809         * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1810         * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1811         java: Add these classes.
1812         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1813         start(): Fill the locales ListBox. Handle its change event, firing a 
1814         LocaleChangeEvent.
1815         setPlace(): Show the selected locale as specified by the URL token.
1816         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1817         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1818         Handle LocaleChangeEvent, going to a new *Place with that locale.
1819
1820         The placement of the ListBox is not pretty, and it currently uses the ID
1821         as a title, instead of "English", "Deutsch", "Espanola", etc, but it 
1822         is a start.
1823
1824
1825 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1826
1827         Search box: Show the search text from the URL token.
1828
1829         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1830         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1831         Add setQuickFindText().
1832         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1833         .java: setPlace(): Store the queryText if the place is a ListPlace, 
1834         and call TableSelectionView.setQuickFindText().
1835
1836 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1837
1838         Allow use of translations via, for instance, &lang=de in the URL.
1839
1840         * pom.xml: Use the unstable java-libglom 1.21 version.
1841
1842         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1843         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1844         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1845         init(): Instead of calling TranslatableItem.set_current_locale() 
1846         (now removed), call ConfiguredDocument.setDefaultLocaleID().
1847         However, this is only for default locales, which are not needed to 
1848         change the locale in the URL.
1849         getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1850         getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1851         getSortedRelatedListData(): Add a localeID parameter, so we can get the 
1852         layout for a particular locale.
1853         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1854         Add get/setDefaultLocaleID().
1855         getDocumentInfo(), getListViewData(), getRelatedListData(),
1856         getDetailsLayoutGroup(), getListViewLayoutGroup(),
1857         createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a 
1858         localeID parameter, so we can get the layout for a particular locale.
1859
1860         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1861         * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1862         * src/main/java/org/glom/web/client/place/ListPlace.java:
1863         Parse and construct a lang parameter too.
1864
1865         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1866         start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1867         passed to subsequent methods and constructors.
1868         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1869         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1870         Store the localeID from the *Place and pass it to other constructors
1871         and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1872
1873         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1874         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1875         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1876         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1877         * src/main/java/org/glom/web/client/ui/ListView.java:
1878         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1879         Take localeID parameters and pass them to subsequent constructors and 
1880         methods, so that the layout is always retrieved for that locale.
1881
1882         This is rather repetitive.
1883
1884         Note that "" means the original (default) locale of the Glom document,
1885         which is usually English.       
1886
1887 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
1888
1889         Documents: Remove final keyword to fix startup configuration.
1890
1891         * src/main/java/org/glom/web/shared/Documents.java: Remove the
1892         final keywords on the private member variables because that breaks
1893         the startup, apparently (there are warnings) because it stops them
1894         from being serialized. I added these in the previous commit.
1895
1896 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
1897
1898         Documents: Add some final keywords.
1899
1900         * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1901         this.
1902
1903 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
1904
1905         OnlineGlomServiceImpl: Add to overview comments.
1906
1907         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1908         Note that this is where all the document are loaded. They are not 
1909         loaded freshly for each page.
1910
1911 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
1912
1913         Add a search box.
1914
1915         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1916         Add a TextBox for the text of a quick find.
1917         Add getQuickFindBox(), to get the widget, and getQuickFindText() to 
1918         get the text.
1919         setBackLink(): Add a String quickFind parameter.
1920         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1921         (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1922         to the base interface, because that is how TableSelectionViewImpl is used.
1923         * src/main/webapp/style.css: Add style for the search box and its label.
1924
1925         * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1926         * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1927         Add these files, based on the existing TableChangeEvent and 
1928         TableChangeEventHandlers.
1929         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1930         start(): Handle QuickFindChangeEvent, passing its quickFind text to
1931         a ListPlace() that the user should be taken to.
1932         * src/main/java/org/glom/web/client/activity/ListActivity.java
1933         start(): Handle it here too and adapt the TableChangeEvent handler to 
1934         pass the extra "" quickFind parameter to ListPlace.
1935         * src/main/java/org/glom/web/client/place/ListPlace.java: 
1936         Constructor: Take an extra String quickFind parameter and store it, 
1937         returning it from a new  getQuickFind() method.
1938         getToken(): Put the quickFind text in the URL token.
1939         getPlace(): Parse the quickFind text from the URL token.
1940         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1941         va: addDocumentLink(): Pass an extra "" quickFind parameter to the 
1942         ListPlace constructor.
1943         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1944         .java: start(): Add a Change handler for the TableSelectionView's
1945         TextBox (via its base HasChangeHandlers interface), firing the new 
1946         QuickFindChangeEvent.
1947         setPlace(): Adapt the call to TableSelectionView.setbackLink(), to 
1948         pass the extra "" quickFind parameter.
1949
1950         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1951         setCellTable(): Add a String quickFind parameter and pass it to 
1952         the ListViewTable() constructor.
1953         * src/main/java/org/glom/web/client/ui/ListView.java: Change 
1954         setCellTable() in the base interface, because that is how ListViewImpl
1955         is used.
1956
1957         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1958         Add a String quickFind member variable.
1959         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1960         Constructor: Add a String quickFind parameter, storing it in the
1961         base ListTable's member variable.
1962         onRangeChanged(): Pass quickFind to the 
1963         OnlineGlomServiceAsync.getSortedListViewData() and 
1964         OnlineGlomServiceAsync.getListViewData() methods.
1965
1966         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1967         getListViewData(), getSortedListViewData(): Add a String quickFind 
1968         parameter, passing it to ConfiguredDocument.getListViewData().
1969         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1970         Change getListViewData(), getSortedListViewData() in the base interface,
1971         because that is how OnlineGlomServiceImpl is used, via this:
1972         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1973         Change getListViewData(), getSortedListViewData() here too.
1974         This class can apparently be used to asynchronously call methods on 
1975         OnlineGlomService, and GWT seems to implement that after recognizing 
1976         just the *Async name convention and the extra AsyncCallback parameters.
1977
1978         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1979         getListViewData(): Add a String quickFind parameter, and pass it to 
1980         ListViewDBAccess.getData().
1981         * src/main/java/org/glom/web/server/database/ListDBAccess.java
1982         getListData(): Add a String quickFind parameter and pass it to 
1983         getSelectQuery().
1984         getSelectQuery(): Add a String quickFind parameter.
1985         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1986         getSelectQuery(): Add a String quickFind parameter and use it with 
1987         Glom.get_find_where_clause_quick() to pass a where_clause to 
1988         Glom.build_sql_select_with_where_clause(), to actually filter the 
1989         list view results.
1990         getData(): Add a String quickFind parameter, passing it to getListData().
1991         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1992         va: getData(): Pass an empty string to getListData() for the 
1993         quickFind parameter.
1994
1995 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
1996
1997         ListTable: Minor change.
1998
1999         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2000         createCellTable(): Make this protected instead of public.
2001
2002 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2003
2004         Many files: Use final for the parameters and use the @override attribute.
2005
2006 2012-01-22  Ben Konrath <ben@bagu.org>
2007
2008         Add anchor links for single line text that starts with http, ftp and www.
2009
2010         Bug #667269
2011
2012 2012-01-22  Ben Konrath <ben@bagu.org>
2013
2014         Add ellipsis to single line text in details view.
2015
2016         Bug #667269
2017
2018 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
2019
2020         Remove all javadoc author tags.
2021
2022         Because they are awkward and meaningless when many people touch
2023         many files.
2024         See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2025  
2026 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
2027
2028         Revert the COPYING.LESSER to COPYING rename.
2029
2030         Apparently both should be there if it is LGPL.
2031
2032 2012-01-03  Murray Cumming  <murrayc@murrayc.com>
2033
2034         *View: Remove unused imports.
2035
2036         * src/main/java/org/glom/web/client/ui/DetailsView.java:
2037         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2038         * src/main/java/org/glom/web/client/ui/ListView.java:
2039         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2040         Remove unused imports, as suggested by Eclipse.
2041
2042 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2043
2044         Move the *View::Presenter types, and some API into one base View.
2045
2046         * src/main/java/org/glom/web/client/ui/DetailsView.java:
2047         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2048         * src/main/java/org/glom/web/client/ui/ListView.java:
2049         * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2050         Presenter, setPresenter() and clear() into a shared base interface,
2051         to avoid the unnecessary duplicate Presenter types and to more clearly
2052         show how the *Views share the same structure, even if they are not 
2053         used polymorphically.
2054
2055         * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2056         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2057         va:
2058         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2059         * src/main/java/org/glom/web/client/activity/ListActivity.java:
2060         * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2061         ity.java:
2062         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2063         .java: Adapt.
2064
2065         Feel free to revert this if there is a good reason for the duplicate
2066         types.
2067
2068 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2069
2070         OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2071
2072         * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2073         a class member instead of a local variable in the method.
2074         This lets us use it to get the view instances, for use in tests.
2075         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2076         beforeOnlineGlom(): Test some more details of the initial view.
2077         Again, this is not very useful.
2078
2079         To really test gwt-glom we will need to start a local postgresql 
2080         instance with local data, like the Glom tests in C++.
2081
2082 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2083
2084         pom.xml: Mention the LGPL license.
2085
2086         * pom.xml: Add a licenses section.
2087         * COPYING.LESSER: Move this to COPYING, which
2088         previously contained the GPL. But gwt-glom is all LGPL.
2089
2090 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2091
2092         Add project information to README and pom.xml.
2093
2094         * README: Add a brief description and mention some mvn
2095         commands.
2096         * pom.xml: This extra information shows up in mvn site
2097         generated pages.
2098
2099 2011-01-02  Murray Cumming  <murrayc@murrayc.com>
2100
2101         Use the latest java-libglom version.
2102
2103         * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2104
2105 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2106
2107         GwtTestOnlineGlom: Test a little more.
2108
2109         * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2110         protected rather than private, as suggested by the gwt-test-utils
2111         maintianer here:
2112         http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2113         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2114         Test the initial visibility of the panels.
2115
2116         However, this is not a very useful test.
2117         And I wonder how we should generally test using this idea for an
2118         activity/places app like ours where the real changes happen implicitly
2119         based on the history token/URL.
2120
2121 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2122
2123         Slight modification to *Mapper comments.
2124
2125         * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2126         (DataActivityMapper)
2127         * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2128         pper.java
2129         * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2130         r.java
2131         Remove comments mentioning GIN because they are just copied from 
2132         the example code and are apparently not helpful:
2133         http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2134         Also change the mention of a class that is only in the example code.
2135
2136 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2137
2138         GwtTestOnlineGlom test: Minor changes.
2139
2140         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2141         Avoid the long qualified class name and modify the comment 
2142         because it is now obvious to me that the mocked class is the only
2143         custom one created via GWT.create().
2144
2145 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2146
2147         Tests: Added the beginnings of a test using gwt-test-utils.
2148
2149         * pom.xml: Add dependencies on gwt-test-utils and easymock.
2150         * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2151         which tells gwt-test-utils what class will be tested.
2152         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2153         Add a simple (but empty) test case. One class, used by the OnlineGlom
2154         class, is mocked so that it can be created. However, I am not sure 
2155         why only this class needs to be mocked.
2156
2157         Note that mockito seems more popular, and clearer, than easymock,
2158         but I have not got that working yet. It might be a matter of the 
2159         mockito version.
2160
2161         This test is run during mvn integration-test.
2162
2163 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2164
2165         Tests: Use junit4-style syntax instead of junit3-style.
2166
2167         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2168         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2169         * src/test/java/org/glom/web/shared/DataItemTest.java:
2170         Use the @Test annotation rather than relying on the test*() prefix.
2171         Also no longer implement TestCase, to avoid triggering support for 
2172         the junit3-way, which stops the annotations from working.
2173         Change the imports from import junit.framework.* to 
2174         import org.junit.*, which is apparently the new way.
2175
2176 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2177
2178         Added a test for ListPlace token parsing and creation.
2179
2180         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2181         This is much the same as DetailsPlaceTest.
2182
2183         I wonder how we could test the other parts of the *Place API.
2184
2185 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2186
2187         DetailsPlace test: Also test getToken() and recreation via getPlace().
2188
2189         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2190         testGetPlaceParameters(): Get the tokens from the DetailsPlace and 
2191         recreate it, testing the recreated DetailsPlace for the same parameter
2192         values.
2193
2194 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2195
2196         Use the surefire-report plugin.
2197
2198         * pom.xml: This generates a HTML report about the tests in 
2199         target/site/surefire-report.html
2200         when you do mvn surefire-report:report. It seems to be popular/normal.
2201
2202 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2203
2204         Added a test for DetailsPlace.
2205
2206         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2207         Test the getPlace() token parsing.
2208
2209 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2210
2211         Added a first unit test.
2212
2213         * pom.xml: Add a test goal, and a dependency on junit in that scope.
2214         * src/test/java/org/glom/web/shared/DataItemTest.java:
2215         This is a silly test but it is just to get things started. Note that
2216         maven/junit finds the test because it looks in src/test by default.
2217
2218 2011-12-22  Ben Konrath  <ben@bagu.org>
2219
2220         Change charsetName to "UTF-8" when replacing line breaks.
2221
2222         JavaScript requires the charsetName to be "UTF-8". CharsetName values
2223         that work in Java (such as "UTF8") will not work when compiled to
2224         JavaScript.
2225
2226         This fixes a problem with multi-line details view fields that have hard
2227         line breaks. The "License Text" field on this page demonstrates the
2228         problem:
2229
2230         http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2231
2232         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2233
2234 2011-12-22  Ben Konrath  <ben@bagu.org>
2235
2236         Fix another bug with related list navigation.
2237
2238         I've tested all the navigation buttons in all of the related lists
2239         so things should be good now.
2240
2241         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2242
2243 2011-12-22  Ben Konrath  <ben@bagu.org>
2244
2245         Fix a crasher when refreshing the list view with the default table.
2246
2247         This crash will also happen when loading the list view with the default
2248         table from a link or bookmark.
2249
2250         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2251         to the main document selection page when the document id hasn't been
2252         set.
2253         * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2254         the main document selection page when the document id hasn't been
2255         set.
2256         * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2257         values for the details place when the document id hasn't been set.
2258         * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2259         values for the list place when the document id hasn't been set.
2260
2261 2011-12-21  Ben Konrath  <ben@bagu.org>
2262
2263         Protect against NPE when glom.document.locale is not in config.
2264
2265         This patch protects against an NPE when glom.document.locale is not in
2266         the config file. This NPE will also happen if glom.document.locale is
2267         commented out.
2268
2269         The patch also updates the error message to display the class name when
2270         the getMessage() returns null. This was happening when the NPE was
2271         thrown and I had "Configuration Error: null". If an NPE is encountered
2272         with this patch, "Configuration Error: NullPointerException " will be
2273         displayed.
2274
2275         This commit closes this bug:
2276
2277         https://bugzilla.gnome.org/show_bug.cgi?id=666669
2278
2279         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2280
2281 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2282
2283         Rename onlineglom.properties to onlineglom.properties.sample.
2284
2285         * src/main/resources/onlineglom.properties: Rename to:
2286         * src/main/resources/onlineglom.properties.sample:
2287         * src/main/resources/README: And add this file explaining that people
2288         should rename it back when deploying.
2289
2290 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2291
2292         Allow choosing the translation in the .properties file.
2293
2294         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2295         init(): Read a glom.document.locale value from the configuration file 
2296         and call Glom's TransatableItem::set_current_locale() method.
2297         * src/main/resources/onlineglom.properties: Add a commented-out 
2298         example of this new setting.
2299
2300         It would be better to add &lang=de_DE to the URL, but the current 
2301         libglom API does not allow us to do this easily. I am working on that.
2302
2303 2011-12-19  Murray Cumming  <murrayc@murrayc.com>
2304
2305         Avoid a crash in parsing of token parameters.
2306
2307         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2308         ava: getTokenParams(): Do not crash if a parameter has a key but no 
2309         value, and ignore parameters with neither.
2310
2311 2011-12-17  Murray Cumming  <murrayc@murayc.com>
2312
2313         History token building/handling: Improve use of token parameters.
2314
2315         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java 
2316         (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2317         and buildParamsToken(HashMap), for use by derived classes.
2318         Make the separator private because it is no longer be needed.
2319         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2320         (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2321         instead of manual string concatenation.
2322         (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2323         of hardcoded indices and awkward splitting code.
2324         * src/main/java/org/glom/web/client/place/ListPlace.java
2325         (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2326         instead of manual string concatenation.
2327         (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2328         of hardcoded indices and awkward splitting code.
2329         This should fix bug #666420
2330
2331 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2332
2333         Fix a Navgiation->Navigation typo in the code.
2334
2335         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2336         Rename processNavgiation() to processNavigation().
2337
2338 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2339
2340         Fix a seperator->separator typo in the code.
2341
2342         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2343         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2344         * src/main/java/org/glom/web/client/place/ListPlace.java: Just a 
2345         misspelling.
2346
2347 2011-12-15  Ben Konrath <ben@bagu.org>
2348
2349         Cleanup some comments.
2350
2351         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2352
2353 2011-12-14  Ben Konrath <ben@bagu.org>
2354
2355         Replace \n with <br/> for multiline text in the details view.
2356
2357         Vertical scrollbars are added when needed as well.
2358
2359         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2360
2361 2011-12-14  Ben Konrath <ben@bagu.org>
2362
2363         Specify the font for document selection links.
2364
2365         * src/main/webapp/style.css:
2366
2367 2011-12-14  Ben Konrath <ben@bagu.org>
2368
2369         Fix bouncy CellTable while paging.
2370
2371         This doesn't currently work with related list tables in unselected
2372         Notebook tabs.
2373
2374         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2375
2376 2011-12-14  Ben Konrath <ben@bagu.org>
2377
2378         Revamp the appearance of the document selection page.
2379
2380         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2381         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2382         * src/main/webapp/style.css:
2383
2384 2011-12-13  Ben Konrath <ben@bagu.org>
2385
2386         Set navigation button column to the smallest size possible.
2387
2388         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2389
2390 2011-12-13  Ben Konrath <ben@bagu.org>
2391
2392         Change OpenButton nomenclature to NavigationButton.
2393
2394         Using NavigtionButton makes things more generic. Classes, methods and
2395         variables have been changed.
2396
2397         This is a rename-only refactor.
2398
2399         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2400         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2401         * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2402         Renamed from OpenButtonCell.
2403         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2404         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2405         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2406
2407 2011-12-12  Ben Konrath <ben@bagu.org>
2408
2409         Remove unnecessary String argument in RelatedListTable and ListViewTable.
2410
2411         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2412         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2413         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2414         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2415
2416 2011-12-12  Ben Konrath <ben@bagu.org>
2417
2418         Update variable names and comments.
2419
2420         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2421         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2422
2423 2011-12-12  Ben Konrath <ben@bagu.org>
2424
2425         Properly initialize numNonEmptyRows variable to zero.
2426
2427         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2428         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2429
2430 2011-12-05  Ben Konrath  <ben@bagu.org>
2431
2432         Add latest mockup with HTML tables.
2433
2434         Features of this mockup:
2435
2436         -> HTML table for flowtable
2437         -> HTML table for flowtable column
2438         -> Example of how related lists would look
2439         -> Not using text entries for data items
2440
2441         The current version of Online Glom doesn't use HTML tables for the
2442         flowtable columns.
2443
2444         This mockup has been sent to the glom-devel mailing list but it's good
2445         to have it here as well.
2446
2447         * mockups/details-view-html-tables.html:
2448
2449 2011-12-05  Ben Konrath  <ben@bagu.org>
2450
2451         Remove unnecessary getPrimaryKeyField() method.
2452
2453         getPrimaryKeyFieldForTable(String) has been renamed to
2454         getPrimaryKeyField(String).
2455
2456         * src/main/java/org/glom/web/server/database/DBAccess.java:
2457         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2458         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2459
2460 2011-12-05  Ben Konrath  <ben@bagu.org>
2461
2462         Add string representation of TypedDataItem value to conversion error message.
2463
2464         * src/main/java/org/glom/web/server/Utils.java: Logging the error
2465         message was extracted into its own method to avoid duplication.
2466
2467 2011-12-05  Ben Konrath  <ben@bagu.org>
2468
2469         Add type checking to navigation primary key value creation.
2470
2471         Create navigation primary key only if the expected type from the Glom
2472         document matches the type returned by the SQL query.
2473
2474         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2475
2476 2011-12-05  Ben Konrath  <ben@bagu.org>
2477
2478         Rename a couple of variables in RelatedListNavigation.
2479
2480         This is a rename-only refactor.
2481
2482         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2483
2484 2011-12-05  Ben Konrath  <ben@bagu.org>
2485
2486         Move getListLayoutGroup() into getListViewLayoutGroup().
2487
2488         This removes getListLayoutGroup(). It was only being called by
2489         getListViewLayoutGroup().
2490
2491         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2492
2493 2011-12-05  Ben Konrath  <ben@bagu.org>
2494
2495         Remove check for LayoutItem_Portal in list table method.
2496
2497         This check is no longer necessary because the method isn't being used
2498         to create the LayoutItemPortal DTO.
2499
2500         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2501
2502 2011-12-05  Ben Konrath  <ben@bagu.org>
2503
2504         Properly support related list navigation.
2505
2506         Navigation from the "Repository Analyzer -> Package Scans ->
2507         Dependencies" related table wasn't working because the primary key for
2508         related tables wasn't being set properly. This commit fixes the
2509         problem.
2510
2511         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2512         getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2513         doesn't set the primary key properly for related list tables.
2514         * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2515         name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2516         useful for getting the primary key for list view tables and for related
2517         list tables.
2518         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2519         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2520         Move code to set the primary key for the table from the abstract
2521         ListDBAccess class to ListViewDBAccess as it's only correct for list
2522         view tables.
2523         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2524         Properly add primary key to related list tables.
2525
2526 2011-12-02  Ben Konrath  <ben@bagu.org>
2527
2528         Properly set the horizontal alignment of fields.
2529
2530         This fix is for both the list tables and the details view.
2531
2532         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2533         LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2534         to set the horizontal alignment of fields.
2535
2536 2011-12-02  Ben Konrath  <ben@bagu.org>
2537
2538         Display currency codes in the details view.
2539
2540         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2541
2542 2011-12-02  Ben Konrath  <ben@bagu.org>
2543
2544         Avoid duplicate JNI call.
2545
2546         JNI is not as efficient as pure Java and this is an easy (and small)
2547         optimization.
2548
2549         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2550         Use previously retrieved value for whereClauseToTableName instead of
2551         getting it again.
2552
2553 2011-12-02  Ben Konrath  <ben@bagu.org>
2554
2555         Rename a couple of variables in RelatedListNavigation.
2556
2557         This is a rename-only refactor.
2558
2559         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2560
2561 2011-12-02  Ben Konrath  <ben@bagu.org>
2562
2563         Indicate clearly that a mismatched primary key type is a bug.
2564
2565         * src/main/java/org/glom/web/server/Utils.java: Change log level from
2566         warning to error. Add 'This is a bug.' to message.
2567
2568 2011-12-02  Ben Konrath  <ben@bagu.org>
2569
2570         Update / fix some comments.
2571
2572         * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2573         comments.
2574         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2575         comment.
2576         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2577         Fix comments. Add some TODOs.
2578
2579 2011-12-02  Ben Konrath  <ben@bagu.org>
2580
2581         Enable navigation to details view with string primary key from related list.
2582
2583         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2584         Create a text primary key value when return type of result is
2585         java.sql.Types.VARCHAR.
2586
2587 2011-12-02  Ben Konrath  <ben@bagu.org>
2588
2589         Use checkboxes for booleans in the details view.
2590
2591         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2592
2593 2011-12-01  Ben Konrath  <ben@bagu.org>
2594
2595         Improve performance of related list height calculation.
2596
2597         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2598         Put code to calculate the expected height in a static initializer so
2599         that that it's only called once.
2600
2601 2011-12-01  Ben Konrath  <ben@bagu.org>
2602
2603         Show related list tables in notebooks (again).
2604
2605         Calculate the height of the related list tables so the Notebook can be
2606         set the correct height. The height of the related list table is also needed by
2607         FlowTable to be able decide how to create the layout.
2608
2609         * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2610         and set the Portal height based on the height of the related list
2611         table and the Portal container.
2612         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2613         Add method to calculate the height of the related list tables.
2614         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2615         * src/main/webapp/style.css: Add css class for Pager. This is needed to
2616         calculate the height of the Pager widget.
2617
2618 2011-12-01  Ben Konrath  <ben@bagu.org>
2619
2620         Use CellTable API for table property instead of setting style on Element.
2621
2622         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2623
2624 2011-12-01  Ben Konrath  <ben@bagu.org>
2625
2626         Make ListViewTable and RelatedListTable a consistent height.
2627
2628         The tables are now a consistent height regardless of the contents of
2629         the table. A hidden button is added to empty rows to ensure that the
2630         height of these rows will match the height of rows with data.
2631
2632         A navigation button column is now added to every table. The width of
2633         the navigation column is set to 0px when a RelatedListTable shouldn't
2634         have navigation buttons. This maintains the a consistent row height in
2635         tables that don't show the navigation buttons.
2636
2637         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2638         navigation column when not needed.
2639         * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2640         arguments for navigation button to constructor of ListViewTable.
2641         * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2642         hidden button for empty data rows.
2643         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2644         arguments for navigation button to constructor.
2645         * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2646         create navigation buttons. Add hideNavigationButtons() method.
2647         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2648         arguments for navigation button to constructor.
2649
2650 2011-12-01  Ben Konrath  <ben@bagu.org>
2651
2652         Use 'visibility: hidden' in Utils.getWidgetHeight().
2653
2654         This is better choice because hidden elements are invisible, don't
2655         respond to events and are not part of the tab order. They will,
2656         however, 
2657