1 2012-05-17 Murray Cumming <murrayc@murrayc.com>
3 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
5 * src/main/java/org/glom/web/client/OnlineGlomService.java
6 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
7 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
8 Remove getSortedListViewData() and getSortedRelatedListData(), adding
9 the sort column index and ascending bool to the regular method.
10 Instead, a sort column index of -1 now means no sort.
11 This is less explicit, but it's fairly simple, reduces the amount of
12 code, and makes the OnlineGlomService API slightly smaller.
13 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
14 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
16 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
17 getListViewData(), getRelatedListData():
18 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
19 getListViewData(), getRelatedListData():
20 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
22 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
24 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
29 2012-05-16 Murray Cumming <murrayc@murrayc.com>
31 Use translations for top-level groups too.
33 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
34 updateTitlesForLocale(): Use the translation for the group
35 as well as for child items.
39 Just recompiled to fix a problem in the released .tar.gz file.
43 2012-05-15 Murray Cumming <murrayc@murrayc.com>
45 Corrections to navigation to related records.
47 * src/main/java/org/glom/web/client/OnlineGlomService.java:
48 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
49 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
50 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
51 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
52 relationship name, because the relationship name is not necessarily unique
54 TOOD: This is inefficient, because it passes the whole list of
55 child field items back to the server, but it is more correct, and happens
56 to fix a bug with the primary key being lost after a few navigations.
57 There is probably a chance to make this more efficient anyway in some
60 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
61 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
62 * src/main/java/org/glom/web/server/ConfiguredDocument.java
63 * src/main/java/org/glom/web/server/database/DBAccess.java
64 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
65 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
68 2012-05-15 Murray Cumming <murrayc@murrayc.com>
70 Fix the use of translations.
72 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
73 Add updateTitlesForLocale().
74 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
75 Call it to discard unwanted translations and to make getTitle() return
76 the wanted translation wihout the need for the client code to specify a locale.
77 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
78 getTitle(): Fallback to the original title, as libglom does.
80 2012-05-15 Murray Cumming <murrayc@murrayc.com>
82 Document: Correctly report the number of available translation locales.
84 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
85 the available locale IDs list.
86 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
87 testLocales: Test this.
89 2012-05-15 Murray Cumming <murrayc@murrayc.com>
91 SqlUtils: Use camelCase.
93 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
94 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
95 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
96 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
97 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
98 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
100 2012-05-15 Murray Cumming <murrayc@murrayc.com>
102 Use jOOQ's tableByName() and fieldByName.
104 * pom.xml: Use jOOQ 2.3.1 to get the new API.
105 * src/main/java/org/glom/web/server/SqlUtils.java:
106 build_sql_select_step_with_where_clause(), .createField(),
107 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
108 so we can get correct quoting and escaping. Thanks to Lukas Eder for
109 adding this, and other things, to jOOQ.
111 2012-05-15 Murray Cumming <murrayc@murrayc.com>
113 SqlUtils: Remove the Connection parameters.
115 * src/main/java/org/glom/web/server/SqlUtils.java:
116 build_sql_select_with_key(), build_sql_select_with_where_clause(),
117 createSelect(), build_sql_select_step_with_where_clause(),
118 build_sql_count_select_with_where_clause(),
119 build_sql_select_count_rows(): Remove the Connection parameter because
120 jOOQ does not actually need a connectionwhen it is just used to build
122 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
124 * src/main/java/org/glom/web/server/ReportGenerator.java:
126 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
128 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
129 Constructor, getListData(), getResultSizeOfSQLQuery():
130 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
131 getSelectQuery(), getCountQuery():
132 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
133 getSelectQuery(), getCountQuery():
134 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
135 getNavigationRecord(): Adapted.
137 2012-05-14 Murray Cumming <murrayc@murrayc.com>
141 * src/main/java/org/glom/web/server/SqlUtils.java:
142 get_find_where_clause_quick(): Use a comparison of
143 lowercase values, instead of a simple equals. Regular Glom
144 uses the PostgreSQL ILIKE operator but jOOQ does not
145 support that just yet, though it will soon.
147 2012-05-14 Murray Cumming <murrayc@murrayc.com>
149 TableToViewDetails: Use a real serialization ID.
151 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
152 Though this does not fix the serialization problem.
154 2012-05-12 Murray Cumming <murrayc@murrayc.com>
156 Added LayoutItemPortalDeepCloneTest.
158 2012-05-11 Murray Cumming <murrayc@murrayc.com>
160 Make navigation work again.
162 * src/main/java/org/glom/web/server/libglom/Document.java:
163 Add getLayoutItemFieldShouldHaveNavigation().
164 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
165 Replace get/setAddNavigation() with the partly-existing
166 get/setNavigationTableName(), with an empty string being no navigation,
167 because this is simpler. Use the new
168 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
170 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
171 Add updateFieldsExtras() and call setNavigationTableName in it.
172 getDetailsLayoutGroup(),
173 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
174 createLayout(): Adapted.
175 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
176 Constructor: Adapted.
178 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
179 Replace get/setAddNavigation() with get/setNavigation(), returning a
180 TableToViewDetails class with both the table name and UsesRelationship,
181 because both are need. The previous code used java-libglom's output
182 variable (strangely, via sharedptr) to return both, but we cannot really
184 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
185 getNavigationRecord(): Adapt. However, we cannot actually use the cache
186 here because it somehow gets set to null during deepCopy(). I must test this.
187 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
188 testGetSuitableTableToViewDetails(): Adapted.
190 TODO: Find out why deepClone() is not quite working.
192 2012-05-11 Murray Cumming <murrayc@murrayc.com>
194 DBAccess: Simplify the retrievel of full field details.
196 * src/main/java/org/glom/web/server/database/DBAccess.java
197 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
198 because the Document loading should have done this.
200 2012-05-11 Murray Cumming <murrayc@murrayc.com>
202 Document: Correct loading of doubly-related layout fields.
204 * src/main/java/org/glom/web/server/libglom/Document.java:
205 loadUsesRelationship(): Actually set the related relationship, instead
206 of only setting it if it's not found.
208 2012-05-09 Murray Cumming <murrayc@murrayc.com>
210 Replace all appearances of Colour with color.
212 Because US English is dominant.
214 2012-05-09 Murray Cumming <murrayc@murrayc.com>
216 Use colors in HTML format, solving a warning about an unused function.
218 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
219 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
220 Add *asHTMLColor() versions of methods.
221 TODO: However, we should create and cache the results on the server.
222 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
223 * src/main/java/org/glom/web/client/ui/list/ListTable.java
224 * src/main/java/org/glom/web/server/ConfiguredDocument.java
225 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
226 Use the asHTMLcolor() versions.
228 2012-05-09 Murray Cumming <murrayc@murrayc.com>
230 ListViewTable: Constructor: Take the table name as a parameter.
232 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
233 Constructor: Take the tableName, and set the member variable, because
235 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
236 setCellTable(): Pass the table name.
237 This makes navigation to non-default tables work again. I don't know
238 why it worked before in the master branch.
240 2012-05-07 Murray Cumming <murrayc@murrayc.com>
242 ConfiguredDocument: Restore correct addition of hidden primary key items.
244 * src/main/java/org/glom/web/client/ui/list/ListTable.java
245 (ListTable.createCellTable): Uncomment out the check for the hidden
247 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
248 add primary key items for top-level lists and portals, as before,
249 instead of adding them to each group.
250 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
251 Actually implement the extra methods such as setHiddenPrimaryKey() and
252 comment that these are used only for top-level list groups and in portals.
253 This strangeness suggests even more that this should not be squeezed
254 into the LayoutGroup class.
256 2012-05-07 Murray Cumming <murrayc@murrayc.com>
258 Fix Formatting loading.
260 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
261 getFormattingUsed(): Remove the duplicate Formatting member variable
262 in favour of the one from the base class.
263 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
264 Initialize a new Formatting instead of using null by default, so we
265 have some defaults, instead of having to initialize one later just to
266 get the same defaults. This also makes loading of formatting from the
267 document work, because that expected a non-null.
269 2012-05-07 Murray Cumming <murrayc@murrayc.com>
271 RelatedListTable: Make sure that the tableName is set.
273 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
274 Constructor: Take the tableName so it is available later. Otherwise,
275 the server assumes that we mean the default table and cannot find the
277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
278 setData(): Pass the tableName to the RelatedListTable constructor.
280 2012-05-07 Murray Cumming <murrayc@murrayc.com>
284 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
285 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
286 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
288 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
290 * src/main/java/org/glom/web/server/database/DBAccess.java:
291 convertResultSetToDTO(), getPortal():
292 * src/main/java/org/glom/web/server/database/ListDBAccess.java
294 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
295 Add checks for null objects and out of range access, with log messages to
296 give hints so we can fix these properly.
298 2012-05-07 Murray Cumming <murrayc@murrayc.com>
300 Portals: some corrections.
302 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
304 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
305 constructor: Use getRelationshipNameUsed() instead of getName(), because
306 that is what is meant.
307 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
308 getFromField(): Fix a typo, to get the field name, not the table name.
309 * src/main/java/org/glom/web/server/database/DBAccess.java:
310 getPortal(): Fix a typo that stopped this from working.
312 2012-05-07 Murray Cumming <murrayc@murrayc.com>
314 LayoutItemPortal: Also override getTitleOriginal().
316 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
317 This lets the base getTitle() with no parameters work.
318 TODO: Test this properly.
320 2012-05-06 Murray Cumming <murrayc@murrayc.com>
322 LayoutItemPortal: getTitle*(): Use the relationship title.
324 2012-05-06 Murray Cumming <murrayc@murrayc.com>
326 LayoutItemField: Fix loading of custom titles.
328 * src/main/java/org/glom/web/server/libglom/Document.java
329 loadDataLayoutItemField(): The title, if any, instead of the field
330 title, is stored in a title_custom node. Load it from there.
331 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
333 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
334 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
335 getTitle*() overrides.
336 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
339 2012-05-06 Murray Cumming <murrayc@murrayc.com>
341 LayoutItemField: Fall back to field titles, so some are really shown.
343 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
344 Override getTitleOriginal() and getTitle(), as in java-libglom.
345 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
348 2012-05-06 Murray Cumming <murrayc@murrayc.com>
350 Correct use of setExpectedResultSize().
352 * src/main/java/org/glom/web/server/ConfiguredDocument.java
353 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
354 Use setExpectedResultSize only on top-level groups (for instance, the
355 list layout) or on child portals (in details views).
356 Use the correct table name for portals to avoid SQL errors.
357 Update the expected counts when returning cached layouts.
359 2012-05-06 Murray Cumming <murrayc@murrayc.com>
361 Document: Interpret no group column count as 1.
363 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
364 default, though we now check for this in the UI code anyway.
366 2012-05-06 Murray Cumming <murrayc@murrayc.com>
370 2012-05-06 Murray Cumming <murrayc@murrayc.com>
372 Translatable: Use Hashmap instead of Treemap because GWT supports it.
374 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
375 The use of Treemap lead to this error from async methods, with no
377 "The response could not be deserialized"
379 2012-05-06 Murray Cumming <murrayc@murrayc.com>
381 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
383 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
384 when using the Google -> GWT Compile, or
385 g toolbar button -> GWT Compile Project... feature in Eclipse.
387 2012-05-06 Murray Cumming <murrayc@murrayc.com>
389 ListTable.addColumn(): Protect against a null Formatting.
391 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
392 Create a default Formatting if it is null, because that is the simplest
395 2012-05-06 Murray Cumming <murrayc@murrayc.com>
397 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
399 * src/main/java/org/glom/web/server/ConfiguredDocument.java
400 updateLayoutGroup(): Check that the field is not null.
402 2012-05-06 Murray Cumming <murrayc@murrayc.com>
404 ListViewImpl: Protected against a bad cast error.
406 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
407 onEnterKeyDown(): Do not cast without an instanceof check.
409 2012-05-06 Murray Cumming <murrayc@murrayc.com>
411 ListTable: Protect against an out of range error.
413 * src/main/java/org/glom/web/client/ui/list/ListTable.java
414 createCellTable(): This is unlikely, but can happen while debugging.
416 2012-05-06 Murray Cumming <murrayc@murrayc.com>
418 AsyncMessage onFailure() callbacks: Log the exception message.
420 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
421 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
422 * src/main/java/org/glom/web/client/activity/ListActivity.java:
423 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
424 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
425 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
426 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
427 These are useful clues when something is wrong.
429 2012-05-06 Murray Cumming <murrayc@murrayc.com>
431 ConfiguredDocument: Avoid a null dereference.
433 * src/main/java/org/glom/web/server/ConfiguredDocument.java
434 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
435 details maps are created.
437 2012-05-06 Murray Cumming <murrayc@murrayc.com>
439 Document: Correct the port number parsing.
441 * src/main/java/org/glom/web/server/libglom/Document.java:
442 This lets us actually connect to the database and show the document.
444 2012-05-05 Murray Cumming <murrayc@murrayc.com>
448 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
449 user-interaction, asking us to load a temporary URL in a browser.s
450 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
451 which is apparently necessary for testing the service. See the comment.
452 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
453 Show the exception, if any. This is how I saw the 404 in the HTML in
456 2012-05-05 Murray Cumming <murrayc@murrayc.com>
458 DocumentTest: Move the .glom files into the resources directory.
460 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
461 URI via getResource().
463 2012-05-05 Murray Cumming <murrayc@murrayc.com>
465 Document: Remove the FieldIdentifies inner class.
467 * src/main/java/org/glom/web/server/libglom/Document.java: We only
468 use the Relationship (though the same function in libglom is maybe
469 used in other ways) and so this removes a compiler warning.
471 2012-05-05 Murray Cumming <murrayc@murrayc.com>
473 Document.load() Remove the error code parameter.
475 * src/main/java/org/glom/web/server/libglom/Document.java: load():
476 Remove the parameter. We do not set it yet and it could never have
477 worked as an output parameter (though maybe it did in java-libglom).
478 We could use an exception if we really want the failure reason.
479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
481 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
482 setUp(), testGetSuitableTableToViewDetails(): Adapt.
484 2012-05-05 Murray Cumming <murrayc@murrayc.com>
486 Make some inner classes static.
488 * src/main/java/org/glom/web/server/ConfiguredDocument.java
489 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
490 * src/main/java/org/glom/web/server/ReportGenerator.java
491 * src/main/java/org/glom/web/server/libglom/Document.java
492 Make all inner classes static that can be static.
494 2012-05-05 Murray Cumming <murrayc@murrayc.com>
496 OnlineGlomServiceImpl: Do not load and check for java-libglom.
498 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
499 init(): We do not use java-libglom any more.
501 2012-05-05 Murray Cumming <murrayc@murrayc.com>
503 Remove mentions of java-libglom.
505 * README: Remove mention of java-libglom, because it no longer needed.
506 * utils/build-onlineglom-war.sh:
507 * utils/check-and-recover-tomcat.py:
508 * utils/install-onlineglom-war.sh: Remove these as they are no longer
509 useful. Building is now far easier, with no need for jhbuild.
511 2012-05-05 Murray Cumming <murrayc@murrayc.com>
513 Fix the build (mvn package)
515 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
516 (LayoutGroup): Make the LayoutItemList inner class static and protected.
517 Otherwise the GWT Java->Javascript compilation fails with just this
518 error, during mvn package or when attempting to view in a browser,
519 in the GWT developer mode in Eclipse.
521 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
522 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
523 [INFO] Compiling module org.glom.web.OnlineGlom
524 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
525 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
526 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
527 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
528 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
529 [INFO] [ERROR] Cannot proceed due to previous errors
531 It has taken me 2 days to find out what was causing that. After reducing
532 the code, the compiler eventually showed me the full error message.
534 2012-05-04 Murray Cumming <murrayc@murrayc.com>
536 ConfiguredDocument: Cache the cloned and stripped layouts.
538 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
539 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
540 layout in a map, so we can retrieve it again without rebuilding it.
542 2012-05-04 Murray Cumming <murrayc@murrayc.com>
544 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
546 2012-05-04 Murray Cumming <murrayc@murrayc.com>
548 libglom classes: Implement some auto-generated emthods.
550 2012-05-04 Murray Cumming <murrayc@murrayc.com>
552 Add GwtTestOnlineGlomService.
554 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
555 However, this (and the other GwtTest*) does not seem to run during
558 2012-05-04 Murray Cumming <murrayc@murrayc.com>
560 Remove use of unsupported features from client code.
562 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
563 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
564 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
565 Use our client version of StringUtils instead of the apache commons one.
567 However, the GWT Javascript compliation still fails.
569 2012-04-25 Murray Cumming <murrayc@murrayc.com>
571 Add a Field class and implement some loading of it in Document.
573 2012-04-25 Murray Cumming <murrayc@murrayc.com>
575 Initial Document loading implementation, instead of libglom.
577 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
578 and Translatable classes, and adapt the rest of the code to use them.
579 However, this is still missing Layout and Field classes and loading.
581 2012-04-24 Murray Cumming <murrayc@murrayc.com>
583 Use of jOOQ: Move Field creation into a utility method.
585 * src/main/java/org/glom/web/server/SqlUtils.java:
586 This lets us improve it more easily.
588 2012-04-24 Murray Cumming <murrayc@murrayc.com>
590 Use of jOOQ: Improve the code to COUNT a sub-select.
592 * src/main/java/org/glom/web/server/SqlUtils.java:
593 Move initial query creation into
594 build_sql_select_step_with_where_clause().
595 build_sql_select_count_rows(): Use the jOOQ API instead of
596 concatentating text, because a jOOQ Select*Step is a TableLike,
597 which is what from() takes.
599 2012-04-23 Murray Cumming <murrayc@murrayc.com>
601 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
603 * pom.xml: Depend on jooq.
604 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
605 methods with jOOQ, based on the C++ implementations in libglom,
606 with some changes to the logic required by jooQ.
607 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
609 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
610 * src/main/java/org/glom/web/server/ReportGenerator.java:
611 * src/main/java/org/glom/web/server/SqlUtils.java:
612 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
613 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
614 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
615 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
616 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
617 Adapt. In particular, the SqlUtils methods now need to take a Connection,
618 because jOOQ needs that, though it seems unnecessary.
620 This is not quite finished. Ideally jOOQ would help us to build
621 table_name.field_name names, quoting and escaping them properly.
622 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
624 2012-04-21 Murray Cumming <murrayc@murrayc.com>
626 Move use of Glom.build_sql*() into a new SqlUtils class.
628 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
629 to wrap Glom.build_sql*(). The parameter types are still Glom one,
630 but this will make it easier to start using something other than
631 libglom or SqlBuilder.
633 2012-04-21 Murray Cumming <murrayc@murrayc.com>
635 Update the project URL.
637 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
639 2012-04-21 Murray Cumming <murrayc@murrayc.com>
641 Main layout: Use a FlowTable instead of absolute positioning.
643 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
644 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
645 child panels/widgets must have an absolute position. But that is annoying, so
646 this adds a FlowTable and puts the child panels in there.
648 2012-04-21 Murray Cumming <murrayc@murrayc.com>
650 GwtTestOnlineGlom: Comment out unused code.
652 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
653 Eclipse has started to say that some code is unused.
655 2012-04-21 Murray Cumming <murrayc@murrayc.com>
657 Update to the latest versions of dependencies.
659 * pom.xml: Update version numbers of dependencies to the latest
661 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
662 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
663 * src/main/java/org/glom/web/server/ReportGenerator.java:
664 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
665 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
666 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
668 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
669 Modify the imports where necessary.
671 2012-04-17 Murray Cumming <murrayc@murrayc.com>
673 Style: Remove overflow:hidden from searchbox
675 * src/main/webapp/style.css: Because this pushes the Back To Link
676 label/link on to the next row, which is then hidden due to the
677 hard-coded (in ems) height.
679 2012-04-20 Murray Cumming <murrayc@murrayc.com>
681 Remove some duplicate code.
683 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
684 getDocumentInfo(): This must have been duplicated during the merge from the
689 2012-04-19 Murray Cumming <murrayc@murrayc.com>
691 Reports: Localize the waiting for report message.
693 * src/main/java/org/glom/web/client/activity/ReportActivity.java
694 start(): Get the message from the contants.
695 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
697 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
698 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
699 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
700 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
701 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
702 Update these files with the English text for newer strings for now.
704 2012-04-19 Murray Cumming <murrayc@murrayc.com>
706 Reports: Show a message while waiting for the report.
708 * src/main/java/org/glom/web/client/ui/ReportView.java
709 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
710 Add setWaitingText(), to show a message saying that we are
711 waiting for the report to be ready.
712 * src/main/java/org/glom/web/client/activity/ReportActivity.java
713 start(): Call setWaitingText() before calling the async
716 2012-04-19 Murray Cumming <murrayc@murrayc.com>
718 ReportGenerator: Specify date and time formats.
720 * src/main/java/org/glom/web/server/ReportGenerator.java:
721 createFieldValueElement(): Use the default (and localized)
722 short formats, though we still need a way to show 4-digit
723 years without providing the format for every locale.
724 * src/main/java/org/glom/web/server/database/DBAccess.java:
725 convertResultSetToDTO(): Use the short formats here too.
727 2012-04-18 Murray Cumming <murrayc@murrayc.com>
729 ReportGenerator: Use the correct numeric formatting.
731 * src/main/java/org/glom/web/server/ReportGenerator.java
732 createFieldExpression(), createFieldValueElement(): Take the
733 whole LayoutItem_Field instead of just the field name, so
734 we have access to the formatting.
735 createFieldValueElement(): Use JRTextField.setPattern() to
736 specify the numeric formatting, with the help of a
737 regular DecimalFormat.
739 2012-04-18 Murray Cumming <murrayc@murrayc.com>
741 ReportGenerator: Avoid showing null for group by titles.
743 * src/main/java/org/glom/web/server/ReportGenerator.java
744 generateReport(): Use setBlankWhenNull() on the field title
745 style too, because this is used for values in group by
748 2012-04-18 Murray Cumming <murrayc@murrayc.com>
750 ReportGenerator: Add a colon to titles in vertical groups.
752 * src/main/java/org/glom/web/server/ReportGenerator.java
753 addFieldToDetailBandVertical(): Pass true for the withColon
756 2012-04-18 Murray Cumming <murrayc@murrayc.com>
758 ReportGenerator: Simplify the code by using Position more.
760 2012-04-18 Murray Cumming <murrayc@murrayc.com>
762 Reports: Support vertical groups, roughly.
764 * src/main/java/org/glom/web/server/ReportGenerator.java:
765 addToReport(): Rename to addGroupToReport() and, if necessary,
766 call the new addVerticalGroupToReport() method.
767 createFieldValueElement(): Let the caller specify the Y position
770 2012-04-17 Murray Cumming <murrayc@murrayc.com>
772 Reports: Allow a second report to be shown.
774 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
775 clear(): Do not remove the HTML widget, which broke the whole layout.
777 2012-04-17 Murray Cumming <murrayc@murrayc.com>
779 Locales drop-down: Show that we use English by default.
781 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
782 fillView(): When we use English, just because that is the default, when
783 no locale is specified, show that in the Locales drop-down instead of
784 just showing the first item.
786 2012-04-17 Murray Cumming <murrayc@murrayc.com>
788 Unselect the Report/Locale/Table combo item when appropriate.
790 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
791 setPlace(): clear reportName if this is not a ReportPlace.
792 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
793 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
794 When the provided name is empty, unselect all items, so that none are
795 indicated. This uses a for loop because I cannot find a single method
798 2012-04-17 Murray Cumming <murrayc@murrayc.com>
800 Report: Give the user a way to get back to the list.
802 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
803 start(), setPlace(): Show the Back To List link on reports, and also
804 interpret selecting the empty report item as back to list.
806 2012-04-13 Murray Cumming <murrayc@murrayc.com>
808 Really show the selected Report name.
810 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
811 setPlace(): Store the reportName here, if it is that kind of Place.
812 fillView(): Set the selected Report after filling the list of reports.
813 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
814 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
815 null Strings, though we need some way to unselect all ListBox items
818 2012-04-13 Murray Cumming <murrayc@murrayc.com>
820 ReportGenerator: Try to avoid some problems.
822 * src/main/java/org/glom/web/server/ReportGenerator.java
823 addField(): Try to avoid duplicates, and avoid using a null
826 2012-04-13 Murray Cumming <murrayc@murrayc.com>
828 Reports: Use quickFind.
830 * src/main/java/org/glom/web/client/OnlineGlomService.java;
831 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
832 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
833 getReportHTML(): Add a quickFind parameter.
834 * src/main/java/org/glom/web/client/activity/ReportActivity.java
835 start(): Pass the quickFind parameter.
836 * src/main/java/org/glom/web/server/ReportGenerator.java
837 generateReport(): Take a quickFind parameter.
839 2012-04-13 Murray Cumming <murrayc@murrayc.com>
841 ReportPlace: Actually use the report name.
843 * src/main/java/org/glom/web/client/place/ReportPlace.java
844 getPlace(): Do not assign the report name to the quickfind.
846 2012-04-13 Murray Cumming <murrayc@murrayc.com>
848 Show java.library.path when complaining.
850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
851 init(): When telling us to check java.library.path, show the
854 2012-03-06 Murray Cumming <murrayc@murrayc.com>
856 ReportGenerator: Do not show nulls.
858 2012-03-06 Murray Cumming <murrayc@murrayc.com>
860 ReportGenerator: Make the title font larger.
862 2012-03-06 Murray Cumming <murrayc@murrayc.com>
864 ReportGenerator: Put field titles inside groups, if there are groups.
866 2012-03-06 Murray Cumming <murrayc@murrayc.com>
868 ReportGenerator: Take the Report itself instead of the name and group.
870 * src/main/java/org/glom/web/server/ConfiguredDocument.java
871 Remove getReportLayoutGroup().
872 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
873 getReportHTML(): Pass the report instead
874 of its name and layout group.
875 * src/main/java/org/glom/web/server/ReportGenerator.java
876 generateReport(): Use the report object to use the title
879 2012-03-06 Murray Cumming <murrayc@murrayc.com>
881 ReportGenerator: Remove designBand parameters.
883 * src/main/java/org/glom/web/server/ReportGenerator.java:
884 Make designBand a class member instead of passing it to all
887 2012-03-06 Murray Cumming <murrayc@murrayc.com>
889 ReportGenerator: Add lines, a bit like in the desktop version.
891 * src/main/java/org/glom/web/server/ReportGenerator.java
892 addToReport(): Use JRDesignLine.
894 2012-03-06 Murray Cumming <murrayc@murrayc.com>
896 ReportGenerator: Correct the title positions and use some bold style.
898 * src/main/java/org/glom/web/server/ReportGenerator.java:
899 Break the code up into reusable functions, correct the placement of
900 titles, and use normal/bold styles as in the reports in the desktop
903 2012-03-06 Murray Cumming <murrayc@murrayc.com>
905 ReportGenerator: Add a header band to show the field titles.
907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
908 getReportHTML(): Pass the localeId to the ReportGenerator
910 * src/main/java/org/glom/web/server/ReportGenerator.java
911 constructor: Take the localeID so we can get translated field
913 generateReport(), addToReport(), addFieldToBand(): Add field
914 titles in a column header band.
916 2012-03-05 Murray Cumming <murrayc@murrayc.com>
918 Reports drop-down list: Some improvement.
920 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
921 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
922 Adedd setSelectedReport(),
923 setReportList(): Add a blank line so that the user can select the
925 * src/main/java/org/glom/web/client/activity/ReportActivity.java
926 start(): Show the current report by calling setSelectedReport().
927 This does not seem to work yet.
929 2012-03-05 Murray Cumming <murrayc@murrayc.com>
931 DetailsActivity, ListActivity: Move some variables into a base class.
933 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
934 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
935 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
936 the clientFactory, documentID, tableName and authenticationPopup into
937 a base class, to avoid duplication.
939 2012-03-05 Murray Cumming <murrayc@murrayc.com>
941 Translate the Reports label.
943 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
944 Get the "Reports" label string from the constants.
945 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
946 perties: Add Reports to the constants.
948 2012-03-05 Murray Cumming <murrayc@murrayc.com>
950 Reports: Implement grouping.
952 * src/main/java/org/glom/web/server/ReportGenerator.java:
953 Handle LayoutItem_GroupBy items and try to do the right thing
954 with JRDesignGroup. It seems to work.
956 2012-03-04 Murray Cumming <murrayc@murrayc.com>
958 Actually show some data with JasperReports.
960 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
961 getReportHTML(): Move most code into a ReportGenerator class.
962 * src/main/java/org/glom/web/server/ReportGenerator.java:
963 Recurse into sub-groups, adding fields to the JasperDesign's details
964 band. Note that we must set an arbitrary width and height, or it just
965 will not show any data.
967 2012-03-04 Murray Cumming <murrayc@murrayc.com>
969 Reports Chooser: Show the titles, not the names.
971 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
972 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
973 and the names as the values.
974 * src/main/java/org/glom/web/server/ConfiguredDocument.java
975 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
976 group now that we provide the report name, so it should always
979 2012-02-15 Murray Cumming <murrayc@murrayc.com>
981 Depend on jasperreports.
983 * pom.xml: Add the dependency. My plan is to use this on the
986 2012-01-31 Murray Cumming <murrayc@murrayc.com>
988 Implement navigation to report places.
990 * src/main/java/org/glom/web/client/activity/ReportActivity.java
991 start(): Do not bother to handle all events here.
992 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
993 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
994 Added getSelectedReport().
995 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
996 .java: start(): When handling a change to the reports chooser,
997 call getSelectedReport() and goTo() its ReportPlace.
998 * src/main/java/org/glom/web/client/ui/ReportView.java
999 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1000 Added setReportHTML() which puts the html in a gwt HTML widget.
1001 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1002 getReportHTML(): Return "TODO" just to show that this works.
1004 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1006 Make ReportPlace usable.
1008 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1009 Mention ReportPlace.
1010 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1011 Correct the @prefix annotation.
1013 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1015 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1017 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1018 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1020 Change getReportLayout() to getReportHMTL() because we will not need to
1021 parse or render the report layout on the client side.
1022 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1023 getReportLayout(): Return the libglom LayoutGroup type because we will
1024 not need to convert to a shared type, because this will not be used on
1026 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1029 Note that there is still no implementation for this.
1032 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1034 Add a (empty) Report Place, View, and Activity.
1036 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1038 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1039 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1040 this into a superclass:
1041 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1042 and also use it as the base of this new ReportPlace:
1043 * src/main/java/org/glom/web/client/place/ReportPlace.java
1045 * src/main/java/org/glom/web/client/ui/ReportView.java
1046 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1047 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1048 Add these, containing mostly boiler-plate for now.
1050 * src/main/java/org/glom/web/client/OnlineGlomService.java
1051 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1052 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1054 Add API to get the LayoutGroup for the report.
1056 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1058 Add and fill a Reports drop-down list box.
1060 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1062 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1063 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1064 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1065 Added getReports(document, table, localeID), calling
1066 ConfiguredDocument.getReports().
1067 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1068 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1069 Added setReportsList() and a list widget.
1070 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1071 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1076 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1078 Translations: Add Esperanto.
1080 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1081 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1082 properties: Add this translation because someone took the time to make it.
1084 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1086 Adapt to the java-libglom 1.21.7 API.
1088 * src/main/java/org/glom/web/server/ReportGenerator.java:
1089 addToReport(): get_group_secondary_fields() is now
1090 get_secondary_fields().
1093 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1095 Use the latest java-libglom version.
1097 * pom.xml: Use java-libglom 1.21.7.
1099 2012-03-03 Ben Konrath <ben@bagu.org>
1101 Display date and time in details view.
1103 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1105 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1107 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1109 Require the latest java-libglom.
1111 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1113 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1115 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1117 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1118 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1119 an empty quickfind string. I also corrected libglom to create only
1120 empty where clauses for empty quickfind strings, but this avoids the
1123 2012-02-24 Ben Konrath <ben@bagu.org>
1125 Improve the tabs in the Notebook widget.
1129 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1131 Translations: Try to translate the strings.
1133 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1134 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1135 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1136 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1137 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1138 Take the Open translation from GTK+'s .po files.
1139 Take the Details translation from Glom's po files.
1140 I have added the other strings to Glom so we can get translations that way:
1141 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1143 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1145 TableSelectionViewImpl: Put the search label and entry in a div.
1147 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1148 Put the search widgets in a FlowTable so that the CSS can be used to
1149 style them while keeping them together.
1150 * src/main/webapp/style.css: Mention the new div.
1152 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1154 Translate more strings in more locales.
1156 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1157 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1158 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1159 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1160 Translate the "Details" and "Open" string too.
1162 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1163 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1164 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1165 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1166 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1167 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1168 Add these new locales as placeholders though they currently contain English.
1170 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1172 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1175 Check the ConfiguredDocument* for null before using it.
1177 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1179 Tell Eclipse about the generated java files.
1181 * .classpath: This lets it find OnlineGlomConstants.java.
1182 It would be nice if Eclipse just used the maven build files.
1184 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1186 Prevent a crash when no locale is specified in the URL.
1188 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1189 Avoid returning a null string, obtained from
1190 Window.Location.getParameter(). This caused a crash when it was
1191 later passed to libglom's API.
1192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1193 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1194 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1195 guard against future null strings.
1197 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1199 Use the ?locale= query param instead of the &lang= token param.
1201 * src/main/java/org/glom/web/client/place/ListPlace.java
1202 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1203 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1204 Remove the lang token key and value.
1206 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1207 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1208 When the user selects a different locale from the chooser, use
1209 Window.Location.assign() to change the URL, which then causes a reload.
1211 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1212 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1213 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1214 * src/main/java/org/glom/web/client/activity/ListActivity.java
1215 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1216 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1217 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1218 * src/main/java/org/glom/web/client/ui/ListView.java:
1219 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1221 Remove localeID member variables and method/constructor parameters, instead
1222 using Utils.getCurrentLocaleID() when we need a localID to pass to
1225 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1227 Internationalize the UI strings.
1229 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1230 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1231 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1232 because it is unused. Messages are apparently strings that can have
1233 parameters, but we do not need that yet, so Contants will be enough for now.
1234 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1235 to say that we support the en and de locales.
1236 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1237 The original English strings.
1238 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1239 Some German translations of the English strings.
1240 The i18n goal then uses the .properties file to generate an
1241 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1242 returns an implementation that returns the translated strings.
1243 The documentation suggests putting these in src/java/*/client/, but it seems
1244 best to put it in src/resources/*/client/.
1245 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1246 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1247 instead of hard-coding them.
1248 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1249 but that does not seem to stop the build, though it confuses Eclipse.
1251 You can see the translated string by adding ?locale=de to the URL, like so:
1252 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1254 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1256 Improve null/empty String checks.
1258 * pom.xml: Add a dependency on commons-lang, to use
1259 org.apache.commons.lang.StringUtils.
1260 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1261 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1262 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1263 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1264 Use StringUtils.isEmpty().
1266 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1267 StringUtils class with a static isEmpty() function because we
1268 cannot use org.apache.commons.lang.StringUtils in client-side
1269 GWT code because it (apparently) cannot be compiled to javascript.
1270 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1271 * src/main/java/org/glom/web/client/activity/ListActivity.java
1272 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1273 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1274 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1275 * src/main/java/org/glom/web/client/place/ListPlace.java
1276 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1277 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1278 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1279 * src/main/java/org/glom/web/client/ui/details/Group.java
1280 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1281 our StringUtils.isEmpty() function.
1283 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1285 Update to the latest java-libglom API.
1287 * pom.xml: Require java-libglom 1.21.4.
1288 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1289 getDocumentInfo(), getListViewLayoutGroup():
1290 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1292 * src/main/java/org/glom/web/server/database/DBAccess.java
1293 getFieldsToShowForSQLQueryAddGroup(),
1294 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1295 with either get_database_title_original() or
1296 get_database_title(localeID).
1298 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1300 ConfiguredDocument: Avoid a null pointer exception.
1302 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1303 Initialize localeID to "" to avoid returning a null String which
1304 causes a crash in java-libglom's swing-generated code.
1306 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1308 Some simple renaming.
1310 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1311 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1312 for localeChooser. This seems more appropriate and is less ambiguous
1313 particularly in the .css file.
1315 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1317 ConfiguredDocument: Rename the localedID private member variable.
1319 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1321 Adapt to the latest java-libglom API from git master.
1323 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1324 libglom now uses only Vector instead of List, which uses add() instead of
1327 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1329 ConfiguredDocument: Rename the localedID private member variable.
1331 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1333 Build a source tarball with mvn assembly:single
1335 * assembly.xml: Add this file.
1336 * pom.xml: Use the maven-assembly-plugin and tell it to use
1337 our assembly.xml file.
1339 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1341 OnlineGlomServiceImpl: Get .glom files recursively.
1343 * pom.xml: Depend on commons-io from org.apache.commons.
1344 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1345 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1346 files recursively, and with the easier filter for the extension.
1347 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1348 simplify that code too.
1350 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1352 README: Mention that you must install java-libglom packages separately.
1354 But then it works, because java-libglom is now in the central maven
1357 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1359 locales drop-down: Show the correct selected locale when the URL changes.
1361 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1362 .java: setPlace(): Move some code into fillView().
1364 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1366 locales drop-down: Do not lose the primary key.
1368 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1369 start(): onLocaleChange(): Pass the current primary key value,
1370 instead of an empty value.
1372 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1374 locales drop-down: Do not lose the drop-down selection.
1376 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1377 .java (TableSelectionActivity.fillView): Set the selected locale
1378 after changing the drop-down items (though we do not really need
1379 to change them just because the locale changes.)
1381 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1383 locales drop-down: Change the tables list when this changes.
1385 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1386 .java: TableSelectionActivity.start(): Move the async table titles
1387 retrieval into a private fillView() method and also call this when
1388 the chosen locale changes.
1389 Note that the document title is not actually translatable yet, but
1390 that is a problem that I should fix soon in libglom.
1392 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1394 Improve the placement of the locales drop-down.
1396 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1397 Put the title and locales drop-down in a div (gwt.FlowTable).
1398 * src/main/webapp/style.css: Add magic css properties to make this work.
1399 Also remove the left margin from the title so that it lines up with the
1402 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1404 locales selector: Show human-readable locale titles.
1406 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1407 getDocumentInfo(): Use java.util.Locale to show a real title of
1408 each locale, in the locale's own language.
1410 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1412 Add a language/locale selector drop-down.
1414 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1415 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1416 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1417 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1418 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1419 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1420 Add a ListBox to show the available locales. Add getLocaleSelector(),
1421 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1422 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1423 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1424 java: Add these classes.
1425 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1426 start(): Fill the locales ListBox. Handle its change event, firing a
1428 setPlace(): Show the selected locale as specified by the URL token.
1429 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1430 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1431 Handle LocaleChangeEvent, going to a new *Place with that locale.
1433 The placement of the ListBox is not pretty, and it currently uses the ID
1434 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1438 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1440 Search box: Show the search text from the URL token.
1442 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1443 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1444 Add setQuickFindText().
1445 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1446 .java: setPlace(): Store the queryText if the place is a ListPlace,
1447 and call TableSelectionView.setQuickFindText().
1449 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1451 Allow use of translations via, for instance, &lang=de in the URL.
1453 * pom.xml: Use the unstable java-libglom 1.21 version.
1455 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1456 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1457 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1458 init(): Instead of calling TranslatableItem.set_current_locale()
1459 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1460 However, this is only for default locales, which are not needed to
1461 change the locale in the URL.
1462 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1463 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1464 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1465 layout for a particular locale.
1466 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1467 Add get/setDefaultLocaleID().
1468 getDocumentInfo(), getListViewData(), getRelatedListData(),
1469 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1470 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1471 localeID parameter, so we can get the layout for a particular locale.
1473 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1474 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1475 * src/main/java/org/glom/web/client/place/ListPlace.java:
1476 Parse and construct a lang parameter too.
1478 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1479 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1480 passed to subsequent methods and constructors.
1481 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1482 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1483 Store the localeID from the *Place and pass it to other constructors
1484 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1486 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1487 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1488 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1489 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1490 * src/main/java/org/glom/web/client/ui/ListView.java:
1491 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1492 Take localeID parameters and pass them to subsequent constructors and
1493 methods, so that the layout is always retrieved for that locale.
1495 This is rather repetitive.
1497 Note that "" means the original (default) locale of the Glom document,
1498 which is usually English.
1500 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1502 Documents: Remove final keyword to fix startup configuration.
1504 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1505 final keywords on the private member variables because that breaks
1506 the startup, apparently (there are warnings) because it stops them
1507 from being serialized. I added these in the previous commit.
1509 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1511 Documents: Add some final keywords.
1513 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1516 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1518 OnlineGlomServiceImpl: Add to overview comments.
1520 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1521 Note that this is where all the document are loaded. They are not
1522 loaded freshly for each page.
1524 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1528 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1529 Add a TextBox for the text of a quick find.
1530 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1532 setBackLink(): Add a String quickFind parameter.
1533 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1534 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1535 to the base interface, because that is how TableSelectionViewImpl is used.
1536 * src/main/webapp/style.css: Add style for the search box and its label.
1538 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1539 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1540 Add these files, based on the existing TableChangeEvent and
1541 TableChangeEventHandlers.
1542 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1543 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1544 a ListPlace() that the user should be taken to.
1545 * src/main/java/org/glom/web/client/activity/ListActivity.java
1546 start(): Handle it here too and adapt the TableChangeEvent handler to
1547 pass the extra "" quickFind parameter to ListPlace.
1548 * src/main/java/org/glom/web/client/place/ListPlace.java:
1549 Constructor: Take an extra String quickFind parameter and store it,
1550 returning it from a new getQuickFind() method.
1551 getToken(): Put the quickFind text in the URL token.
1552 getPlace(): Parse the quickFind text from the URL token.
1553 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1554 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1555 ListPlace constructor.
1556 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1557 .java: start(): Add a Change handler for the TableSelectionView's
1558 TextBox (via its base HasChangeHandlers interface), firing the new
1559 QuickFindChangeEvent.
1560 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1561 pass the extra "" quickFind parameter.
1563 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1564 setCellTable(): Add a String quickFind parameter and pass it to
1565 the ListViewTable() constructor.
1566 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1567 setCellTable() in the base interface, because that is how ListViewImpl
1570 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1571 Add a String quickFind member variable.
1572 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1573 Constructor: Add a String quickFind parameter, storing it in the
1574 base ListTable's member variable.
1575 onRangeChanged(): Pass quickFind to the
1576 OnlineGlomServiceAsync.getSortedListViewData() and
1577 OnlineGlomServiceAsync.getListViewData() methods.
1579 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1580 getListViewData(), getSortedListViewData(): Add a String quickFind
1581 parameter, passing it to ConfiguredDocument.getListViewData().
1582 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1583 Change getListViewData(), getSortedListViewData() in the base interface,
1584 because that is how OnlineGlomServiceImpl is used, via this:
1585 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1586 Change getListViewData(), getSortedListViewData() here too.
1587 This class can apparently be used to asynchronously call methods on
1588 OnlineGlomService, and GWT seems to implement that after recognizing
1589 just the *Async name convention and the extra AsyncCallback parameters.
1591 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1592 getListViewData(): Add a String quickFind parameter, and pass it to
1593 ListViewDBAccess.getData().
1594 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1595 getListData(): Add a String quickFind parameter and pass it to
1597 getSelectQuery(): Add a String quickFind parameter.
1598 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1599 getSelectQuery(): Add a String quickFind parameter and use it with
1600 Glom.get_find_where_clause_quick() to pass a where_clause to
1601 Glom.build_sql_select_with_where_clause(), to actually filter the
1603 getData(): Add a String quickFind parameter, passing it to getListData().
1604 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1605 va: getData(): Pass an empty string to getListData() for the
1606 quickFind parameter.
1608 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1610 ListTable: Minor change.
1612 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1613 createCellTable(): Make this protected instead of public.
1615 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1617 Many files: Use final for the parameters and use the @override attribute.
1619 2012-01-22 Ben Konrath <ben@bagu.org>
1621 Add anchor links for single line text that starts with http, ftp and www.
1625 2012-01-22 Ben Konrath <ben@bagu.org>
1627 Add ellipsis to single line text in details view.
1631 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1633 Remove all javadoc author tags.
1635 Because they are awkward and meaningless when many people touch
1637 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1639 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1641 Revert the COPYING.LESSER to COPYING rename.
1643 Apparently both should be there if it is LGPL.
1645 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1647 *View: Remove unused imports.
1649 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1650 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1651 * src/main/java/org/glom/web/client/ui/ListView.java:
1652 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1653 Remove unused imports, as suggested by Eclipse.
1655 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1657 Move the *View::Presenter types, and some API into one base View.
1659 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1660 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1661 * src/main/java/org/glom/web/client/ui/ListView.java:
1662 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1663 Presenter, setPresenter() and clear() into a shared base interface,
1664 to avoid the unnecessary duplicate Presenter types and to more clearly
1665 show how the *Views share the same structure, even if they are not
1666 used polymorphically.
1668 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1669 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1671 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1672 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1673 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1675 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1678 Feel free to revert this if there is a good reason for the duplicate
1681 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1683 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1685 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1686 a class member instead of a local variable in the method.
1687 This lets us use it to get the view instances, for use in tests.
1688 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1689 beforeOnlineGlom(): Test some more details of the initial view.
1690 Again, this is not very useful.
1692 To really test gwt-glom we will need to start a local postgresql
1693 instance with local data, like the Glom tests in C++.
1695 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1697 pom.xml: Mention the LGPL license.
1699 * pom.xml: Add a licenses section.
1700 * COPYING.LESSER: Move this to COPYING, which
1701 previously contained the GPL. But gwt-glom is all LGPL.
1703 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1705 Add project information to README and pom.xml.
1707 * README: Add a brief description and mention some mvn
1709 * pom.xml: This extra information shows up in mvn site
1712 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1714 Use the latest java-libglom version.
1716 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1718 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1720 GwtTestOnlineGlom: Test a little more.
1722 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1723 protected rather than private, as suggested by the gwt-test-utils
1725 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1726 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1727 Test the initial visibility of the panels.
1729 However, this is not a very useful test.
1730 And I wonder how we should generally test using this idea for an
1731 activity/places app like ours where the real changes happen implicitly
1732 based on the history token/URL.
1734 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1736 Slight modification to *Mapper comments.
1738 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1739 (DataActivityMapper)
1740 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1742 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1744 Remove comments mentioning GIN because they are just copied from
1745 the example code and are apparently not helpful:
1746 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1747 Also change the mention of a class that is only in the example code.
1749 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1751 GwtTestOnlineGlom test: Minor changes.
1753 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1754 Avoid the long qualified class name and modify the comment
1755 because it is now obvious to me that the mocked class is the only
1756 custom one created via GWT.create().
1758 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1760 Tests: Added the beginnings of a test using gwt-test-utils.
1762 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1763 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1764 which tells gwt-test-utils what class will be tested.
1765 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1766 Add a simple (but empty) test case. One class, used by the OnlineGlom
1767 class, is mocked so that it can be created. However, I am not sure
1768 why only this class needs to be mocked.
1770 Note that mockito seems more popular, and clearer, than easymock,
1771 but I have not got that working yet. It might be a matter of the
1774 This test is run during mvn integration-test.
1776 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1778 Tests: Use junit4-style syntax instead of junit3-style.
1780 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1781 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1782 * src/test/java/org/glom/web/shared/DataItemTest.java:
1783 Use the @Test annotation rather than relying on the test*() prefix.
1784 Also no longer implement TestCase, to avoid triggering support for
1785 the junit3-way, which stops the annotations from working.
1786 Change the imports from import junit.framework.* to
1787 import org.junit.*, which is apparently the new way.
1789 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1791 Added a test for ListPlace token parsing and creation.
1793 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1794 This is much the same as DetailsPlaceTest.
1796 I wonder how we could test the other parts of the *Place API.
1798 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1800 DetailsPlace test: Also test getToken() and recreation via getPlace().
1802 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1803 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1804 recreate it, testing the recreated DetailsPlace for the same parameter
1807 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1809 Use the surefire-report plugin.
1811 * pom.xml: This generates a HTML report about the tests in
1812 target/site/surefire-report.html
1813 when you do mvn surefire-report:report. It seems to be popular/normal.
1815 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1817 Added a test for DetailsPlace.
1819 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1820 Test the getPlace() token parsing.
1822 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1824 Added a first unit test.
1826 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1827 * src/test/java/org/glom/web/shared/DataItemTest.java:
1828 This is a silly test but it is just to get things started. Note that
1829 maven/junit finds the test because it looks in src/test by default.
1831 2011-12-22 Ben Konrath <ben@bagu.org>
1833 Change charsetName to "UTF-8" when replacing line breaks.
1835 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1836 that work in Java (such as "UTF8") will not work when compiled to
1839 This fixes a problem with multi-line details view fields that have hard
1840 line breaks. The "License Text" field on this page demonstrates the
1843 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1845 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1847 2011-12-22 Ben Konrath <ben@bagu.org>
1849 Fix another bug with related list navigation.
1851 I've tested all the navigation buttons in all of the related lists
1852 so things should be good now.
1854 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1856 2011-12-22 Ben Konrath <ben@bagu.org>
1858 Fix a crasher when refreshing the list view with the default table.
1860 This crash will also happen when loading the list view with the default
1861 table from a link or bookmark.
1863 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1864 to the main document selection page when the document id hasn't been
1866 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1867 the main document selection page when the document id hasn't been
1869 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1870 values for the details place when the document id hasn't been set.
1871 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1872 values for the list place when the document id hasn't been set.
1874 2011-12-21 Ben Konrath <ben@bagu.org>
1876 Protect against NPE when glom.document.locale is not in config.
1878 This patch protects against an NPE when glom.document.locale is not in
1879 the config file. This NPE will also happen if glom.document.locale is
1882 The patch also updates the error message to display the class name when
1883 the getMessage() returns null. This was happening when the NPE was
1884 thrown and I had "Configuration Error: null". If an NPE is encountered
1885 with this patch, "Configuration Error: NullPointerException " will be
1888 This commit closes this bug:
1890 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1892 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1894 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1896 Rename onlineglom.properties to onlineglom.properties.sample.
1898 * src/main/resources/onlineglom.properties: Rename to:
1899 * src/main/resources/onlineglom.properties.sample:
1900 * src/main/resources/README: And add this file explaining that people
1901 should rename it back when deploying.
1903 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1905 Allow choosing the translation in the .properties file.
1907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1908 init(): Read a glom.document.locale value from the configuration file
1909 and call Glom's TransatableItem::set_current_locale() method.
1910 * src/main/resources/onlineglom.properties: Add a commented-out
1911 example of this new setting.
1913 It would be better to add &lang=de_DE to the URL, but the current
1914 libglom API does not allow us to do this easily. I am working on that.
1916 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1918 Avoid a crash in parsing of token parameters.
1920 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1921 ava: getTokenParams(): Do not crash if a parameter has a key but no
1922 value, and ignore parameters with neither.
1924 2011-12-17 Murray Cumming <murrayc@murayc.com>
1926 History token building/handling: Improve use of token parameters.
1928 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1929 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1930 and buildParamsToken(HashMap), for use by derived classes.
1931 Make the separator private because it is no longer be needed.
1932 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1933 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1934 instead of manual string concatenation.
1935 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1936 of hardcoded indices and awkward splitting code.
1937 * src/main/java/org/glom/web/client/place/ListPlace.java
1938 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1939 instead of manual string concatenation.
1940 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1941 of hardcoded indices and awkward splitting code.
1942 This should fix bug #666420
1944 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1946 Fix a Navgiation->Navigation typo in the code.
1948 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1949 Rename processNavgiation() to processNavigation().
1951 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1953 Fix a seperator->separator typo in the code.
1955 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1956 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1957 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1960 2011-12-15 Ben Konrath <ben@bagu.org>
1962 Cleanup some comments.
1964 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1966 2011-12-14 Ben Konrath <ben@bagu.org>
1968 Replace \n with <br/> for multiline text in the details view.
1970 Vertical scrollbars are added when needed as well.
1972 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1974 2011-12-14 Ben Konrath <ben@bagu.org>
1976 Specify the font for document selection links.
1978 * src/main/webapp/style.css:
1980 2011-12-14 Ben Konrath <ben@bagu.org>
1982 Fix bouncy CellTable while paging.
1984 This doesn't currently work with related list tables in unselected
1987 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1989 2011-12-14 Ben Konrath <ben@bagu.org>
1991 Revamp the appearance of the document selection page.
1993 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1994 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1995 * src/main/webapp/style.css:
1997 2011-12-13 Ben Konrath <ben@bagu.org>
1999 Set navigation button column to the smallest size possible.
2001 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2003 2011-12-13 Ben Konrath <ben@bagu.org>
2005 Change OpenButton nomenclature to NavigationButton.
2007 Using NavigtionButton makes things more generic. Classes, methods and
2008 variables have been changed.
2010 This is a rename-only refactor.
2012 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2013 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2014 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2015 Renamed from OpenButtonCell.
2016 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2017 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2018 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2020 2011-12-12 Ben Konrath <ben@bagu.org>
2022 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2024 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2025 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2026 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2027 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2029 2011-12-12 Ben Konrath <ben@bagu.org>
2031 Update variable names and comments.
2033 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2034 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2036 2011-12-12 Ben Konrath <ben@bagu.org>
2038 Properly initialize numNonEmptyRows variable to zero.
2040 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2041 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2043 2011-12-05 Ben Konrath <ben@bagu.org>
2045 Add latest mockup with HTML tables.
2047 Features of this mockup:
2049 -> HTML table for flowtable
2050 -> HTML table for flowtable column
2051 -> Example of how related lists would look
2052 -> Not using text entries for data items
2054 The current version of Online Glom doesn't use HTML tables for the
2057 This mockup has been sent to the glom-devel mailing list but it's good
2058 to have it here as well.
2060 * mockups/details-view-html-tables.html:
2062 2011-12-05 Ben Konrath <ben@bagu.org>
2064 Remove unnecessary getPrimaryKeyField() method.
2066 getPrimaryKeyFieldForTable(String) has been renamed to
2067 getPrimaryKeyField(String).
2069 * src/main/java/org/glom/web/server/database/DBAccess.java:
2070 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2071 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2073 2011-12-05 Ben Konrath <ben@bagu.org>
2075 Add string representation of TypedDataItem value to conversion error message.
2077 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2078 message was extracted into its own method to avoid duplication.
2080 2011-12-05 Ben Konrath <ben@bagu.org>
2082 Add type checking to navigation primary key value creation.
2084 Create navigation primary key only if the expected type from the Glom
2085 document matches the type returned by the SQL query.
2087 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2089 2011-12-05 Ben Konrath <ben@bagu.org>
2091 Rename a couple of variables in RelatedListNavigation.
2093 This is a rename-only refactor.
2095 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2097 2011-12-05 Ben Konrath <ben@bagu.org>
2099 Move getListLayoutGroup() into getListViewLayoutGroup().
2101 This removes getListLayoutGroup(). It was only being called by
2102 getListViewLayoutGroup().
2104 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2106 2011-12-05 Ben Konrath <ben@bagu.org>
2108 Remove check for LayoutItem_Portal in list table method.
2110 This check is no longer necessary because the method isn't being used
2111 to create the LayoutItemPortal DTO.
2113 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2115 2011-12-05 Ben Konrath <ben@bagu.org>
2117 Properly support related list navigation.
2119 Navigation from the "Repository Analyzer -> Package Scans ->
2120 Dependencies" related table wasn't working because the primary key for
2121 related tables wasn't being set properly. This commit fixes the
2124 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2125 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2126 doesn't set the primary key properly for related list tables.
2127 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2128 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2129 useful for getting the primary key for list view tables and for related
2131 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2132 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2133 Move code to set the primary key for the table from the abstract
2134 ListDBAccess class to ListViewDBAccess as it's only correct for list
2136 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2137 Properly add primary key to related list tables.
2139 2011-12-02 Ben Konrath <ben@bagu.org>
2141 Properly set the horizontal alignment of fields.
2143 This fix is for both the list tables and the details view.
2145 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2146 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2147 to set the horizontal alignment of fields.
2149 2011-12-02 Ben Konrath <ben@bagu.org>
2151 Display currency codes in the details view.
2153 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2155 2011-12-02 Ben Konrath <ben@bagu.org>
2157 Avoid duplicate JNI call.
2159 JNI is not as efficient as pure Java and this is an easy (and small)
2162 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2163 Use previously retrieved value for whereClauseToTableName instead of
2166 2011-12-02 Ben Konrath <ben@bagu.org>
2168 Rename a couple of variables in RelatedListNavigation.
2170 This is a rename-only refactor.
2172 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2174 2011-12-02 Ben Konrath <ben@bagu.org>
2176 Indicate clearly that a mismatched primary key type is a bug.
2178 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2179 warning to error. Add 'This is a bug.' to message.
2181 2011-12-02 Ben Konrath <ben@bagu.org>
2183 Update / fix some comments.
2185 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2187 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2189 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2190 Fix comments. Add some TODOs.
2192 2011-12-02 Ben Konrath <ben@bagu.org>
2194 Enable navigation to details view with string primary key from related list.
2196 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2197 Create a text primary key value when return type of result is
2198 java.sql.Types.VARCHAR.
2200 2011-12-02 Ben Konrath <ben@bagu.org>
2202 Use checkboxes for booleans in the details view.
2204 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2206 2011-12-01 Ben Konrath <ben@bagu.org>
2208 Improve performance of related list height calculation.
2210 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2211 Put code to calculate the expected height in a static initializer so
2212 that that it's only called once.
2214 2011-12-01 Ben Konrath <ben@bagu.org>
2216 Show related list tables in notebooks (again).
2218 Calculate the height of the related list tables so the Notebook can be
2219 set the correct height. The height of the related list table is also needed by
2220 FlowTable to be able decide how to create the layout.
2222 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2223 and set the Portal height based on the height of the related list
2224 table and the Portal container.
2225 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2226 Add method to calculate the height of the related list tables.
2227 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2228 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2229 calculate the height of the Pager widget.
2231 2011-12-01 Ben Konrath <ben@bagu.org>
2233 Use CellTable API for table property instead of setting style on Element.
2235 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2237 2011-12-01 Ben Konrath <ben@bagu.org>
2239 Make ListViewTable and RelatedListTable a consistent height.
2241 The tables are now a consistent height regardless of the contents of
2242 the table. A hidden button is added to empty rows to ensure that the
2243 height of these rows will match the height of rows with data.
2245 A navigation button column is now added to every table. The width of
2246 the navigation column is set to 0px when a RelatedListTable shouldn't
2247 have navigation buttons. This maintains the a consistent row height in
2248 tables that don't show the navigation buttons.
2250 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2251 navigation column when not needed.
2252 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2253 arguments for navigation button to constructor of ListViewTable.
2254 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2255 hidden button for empty data rows.
2256 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2257 arguments for navigation button to constructor.
2258 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2259 create navigation buttons. Add hideNavigationButtons() method.
2260 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2261 arguments for navigation button to constructor.
2263 2011-12-01 Ben Konrath <ben@bagu.org>
2265 Use 'visibility: hidden' in Utils.getWidgetHeight().
2267 This is better choice because hidden elements are invisible, don't
2268 respond to events and are not part of the tab order. They will,
2269 however, take up space which is required to be able to calculate the
2270 height of the widget.
2272 * src/main/java/org/glom/web/client/Utils.java:
2274 2011-12-01 Ben Konrath <ben@bagu.org>
2276 Use Utils.getWidgetHeight() in FlowTable.
2278 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2280 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2282 2011-12-01 Ben Konrath <ben@bagu.org>
2284 Put the details css class name on the correct table column.
2286 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2288 2011-11-30 Ben Konrath <ben@bagu.org>
2290 Update for java-libglom API change.
2292 The getters and setters on FieldFormatting and NumericFormat were
2293 changed to remove the 'M'.
2295 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2297 2011-11-29 Ben Konrath <ben@bagu.org>
2299 Only allow RelatedListTables in Portals.
2301 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2303 2011-11-29 Ben Konrath <ben@bagu.org>
2305 Only create a contents panel for Portals when title is being set.
2307 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2309 2011-11-29 Ben Konrath <ben@bagu.org>
2311 Set TabLayoutPanel height based on calculated height its widgets.
2313 This is a potential fix for this bug:
2315 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2317 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2319 2011-11-29 Ben Konrath <ben@bagu.org>
2321 Align details field labels and data with the Open buttons.
2323 * src/main/webapp/style.css:
2325 2011-11-29 Ben Konrath <ben@bagu.org>
2327 Remove unnecessary <div> in the Notebook widget.
2329 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2330 method to get container FlowPanel (<div>).
2331 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2332 initWidget() method directly on the TabLayoutPanel widget instead of
2333 Group's container widget.
2335 2011-11-29 Ben Konrath <ben@bagu.org>
2337 Don't add group titles for Portals in Notebooks.
2339 This reverts the previous patch and fixes a bug I introduced with
2340 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2342 * src/main/java/org/glom/web/client/ui/details/Group.java:
2343 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2345 2011-11-28 Ben Konrath <ben@bagu.org>
2347 Remove unused boolean argument in Portal constructor.
2349 Just a code cleanup.
2351 * src/main/java/org/glom/web/client/ui/details/Group.java:
2352 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2354 2011-11-28 Ben Konrath <ben@bagu.org>
2356 Remove hack for glom 1.18 style glom files.
2358 * src/main/java/org/glom/web/client/ui/details/Group.java:
2359 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2360 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2362 2011-11-28 Ben Konrath <ben@bagu.org>
2364 Use Gda Value version of primary key to log result too large error.
2366 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2368 2011-11-28 Ben Konrath <ben@bagu.org>
2370 Don't use TypedDataItem.getText() for Unknown types from the URL.
2372 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2373 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2374 instead of getText().
2375 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2376 String field and getUnknown() method.
2378 2011-11-28 Ben Konrath <ben@bagu.org>
2380 Log an error message when the java-libglom .so is not present.
2382 The error message was being set in the exception but not logged.
2384 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2386 2011-11-28 Ben Konrath <ben@bagu.org>
2388 Ignore LayoutItem_CalendarPortals.
2390 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2391 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2393 2011-11-28 Ben Konrath <ben@bagu.org>
2395 Extract method for creating the LayoutItemPortal DTO.
2397 Just breaking the code up into smaller chunks.
2399 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2401 2011-11-28 Ben Konrath <ben@bagu.org>
2405 This should have been added with the refactor. Oops!
2407 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2409 2011-11-28 Ben Konrath <ben@bagu.org>
2411 Create primary key value from URL string using type from Glom document.
2413 See this bug, comments 19 - 25:
2415 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2417 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2418 create a TypeDataItem for the primary key here when loading from a
2419 URL. Show the same string for the primary key value as was received
2420 from the URL string (when loading from a URL).
2421 * src/main/java/org/glom/web/server/Utils.java: Update method for
2422 creating the Gda Value from the TypeDataItem to properly deal with
2423 creating a Gda Value based on the Glom document type for the primary
2424 key value string when loading from a URL.
2425 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2426 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2427 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2428 Update for changed method name.
2430 2011-11-27 Ben Konrath <ben@bagu.org>
2432 Rename PrimaryKeyItem to TypedDataItem.
2434 The name PrimaryKeyItem suggests what the class should be used for.
2435 TypedDataItem is a neutral name that describes the class better.
2437 This is a rename-only refactor.
2439 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2440 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2441 * src/main/java/org/glom/web/client/Utils.java:
2442 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2443 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2444 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2445 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2446 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2447 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2448 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2449 * src/main/java/org/glom/web/server/Utils.java:
2450 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2451 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2452 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2453 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2455 2011-11-25 Ben Konrath <ben@bagu.org>
2457 Improve Gda Value conversion from PrimaryKeyItem.
2459 The value from the PrimaryKeyItem is only used if its type match the
2460 type from the glom document.
2462 * src/main/java/org/glom/web/server/Utils.java:
2464 2011-11-25 Ben Konrath <ben@bagu.org>
2466 Manually check if the java-liblgom .so is visible to the JVM.
2468 It seems that Tomcat has problems when a static initializer throws an
2469 exception. This check is done before the first method call into
2470 java-libglom so that execution doesn't continue if the .so is not
2473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2475 2011-11-25 Ben Konrath <ben@bagu.org>
2477 Improve browser configuration error messages.
2481 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2483 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2484 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2485 getConfigurationErrorMessage() method.
2486 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2487 Get and display a specific configuration error message when no Glom
2488 documents are found.
2489 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2490 Implement getConfigurationErrorMessage() method. Surround configuration
2491 code in the init() method with a try/catch block. This allows the
2492 errors to be caught while keeping the servlet available to retrieve the
2493 configuration error message.
2495 2011-11-25 Ben Konrath <ben@bagu.org>
2497 Don't use Strings to hold primary key values.
2499 The primary key values are now held in a new data object
2500 (PrimaryKeyItem) that holds type information and the primary key value
2501 using the correct type.
2503 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2504 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2505 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2506 PrimaryKeyItem instead of String to hold the primary key value.
2507 * src/main/java/org/glom/web/client/Utils.java: Remove
2508 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2509 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2510 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2511 PrimaryKeyItem instead of String to hold the primary key value. Load
2512 document selection page when the documentID has not been set correctly.
2513 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2514 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2516 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2517 Return empty string for URL instead of "null".
2518 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2519 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2520 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2521 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2522 PrimaryKeyItem instead of String to hold primary key values.
2523 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2524 PrimaryKeyValue to a Gda Value.
2525 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2526 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2527 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2528 Replace temporary database access code that uses the PrimaryKeyValue to
2529 Gda Value conversion.
2530 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2531 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2532 PrimaryKeyItem instead of String.
2533 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2534 hold primary key values.
2536 2011-11-24 Ben Konrath <ben@bagu.org>
2538 Use newly added java-libglom API to create queries.
2540 This isn't finished. I still need to stop using Strings for primary key
2541 values in the client code.
2543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2544 libglom to use fake connections so that retrieving the query string will
2546 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2547 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2548 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2549 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2550 Use the newly added libglom sql methods and classes to create the
2551 query. Add temporary hack to convert primary value strings to Gda
2554 2011-11-23 Ben Konrath <ben@bagu.org>
2556 Don't explicitly set the height of Portals.
2558 See comments 6 - 10 of this bug for details:
2560 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2562 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2564 2011-11-23 Ben Konrath <ben@bagu.org>
2566 Use an HTML table instead of CSS for the FlowTable layout.
2568 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2569 GWT's FlexTable to implement the FlowTable.
2570 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2572 2011-11-18 Ben Konrath <ben@bagu.org>
2574 Add boolean example to HTML table mockup.
2576 * mockups/details-view-html-tables-text-entries.html:
2578 2011-11-17 Ben Konrath <ben@bagu.org>
2580 Ensure the pager buttons are always visible for related lists.
2582 To accomplish this, I've turned off text wrapping in the list view and
2583 related list tables for both the header and data text. The related list
2584 table now has a fixed layout so the it doesn't overflow its container.
2585 This is required to ensure that the cell text is clipped when it
2586 overflows the cell and an ellipsis is added to the right side of the
2587 cell when text is clipped.
2589 A fixed table layout for the related list table in the details view
2590 seems what we want for the details view anyway, so the side-effect is
2593 The ellipsis will only be displayed in Firefox >= 7.
2597 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2599 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2600 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2601 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2603 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2604 Set the 'table-layout: fixed' CSS property to the related list table.
2605 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2606 'white-space: nowrap;' CSS property on both the list view and the
2607 related list tables.
2609 2011-11-16 Ben Konrath <ben@bagu.org>
2611 Rework the fix for empty notebook tab labels.
2613 Setting the empty group titles with its name caused problems for the
2614 details layout. Instead of using libglom's
2615 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2616 to the client when the title is empty. This allows the Notebook to use
2617 the name when the title is empty without affecting anything else.
2619 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2620 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2622 2011-11-16 Ben Konrath <ben@bagu.org>
2624 Set group titles with name when title is empty.
2626 This fixes a problem with an empty notebook tab label in the Lesson
2627 Planner document. The forth tab in the notebook should be "Internet":
2629 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2631 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2632 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2635 2011-11-16 Ben Konrath <ben@bagu.org>
2637 Remove whitespace from the configured username properties.
2639 This assumes that usernames won't have whitespace at the beginning
2640 or end. But I think this is a reasonable assumption.
2642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2643 String.trim() to remove the whitespace from the username properties.
2645 2011-11-15 Ben Konrath <ben@bagu.org>
2647 Add details view mockup with HTML tables and text entries.
2649 This is from the attachment on this bug:
2651 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2653 * mockups/details-view-html-tables-text-entries.html:
2655 2011-11-15 Ben Konrath <ben@bagu.org>
2657 Add space between the columns of the flow table.
2661 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2663 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2664 space between columns in the flow table.
2666 2011-11-15 Ben Konrath <ben@bagu.org>
2668 Add backup files to the .gitignore.
2670 * .gitignore: Ignore files that end with ~.
2672 2011-11-09 Ben Konrath <ben@bagu.org>
2674 Use latest release of gwt-log.
2676 Gwt-log releases are now being submitted to the maven central
2677 repository so manual installation of the jar is no longer required.
2679 * pom.xml: Update version and groupId of gwt-log dependency.
2681 2011-10-31 Ben Konrath <ben@bagu.org>
2683 Don't use GWT numeric formatting to override the glom currency formatting.
2685 Currencies are now displayed like they are in Glom. See this bug:
2687 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2689 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2691 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2692 currency code to constructor and set it when the cell is rendered.
2693 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2694 currency code to the constructor of the NumericCell.
2696 2011-10-27 Ben Konrath <ben@bagu.org>
2698 Require the latest release of java-libglom (1.17.4).
2702 2011-10-26 Ben Konrath <ben@bagu.org>
2704 Add style to Notebook that matches current theme.
2706 It's not the best style in the world but it's better than the default.
2708 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2709 padding at the bottom of the child widgets.
2710 * src/main/webapp/style.css: Add style for the Notebook.
2712 2011-10-26 Ben Konrath <ben@bagu.org>
2714 Move servlet initialization code to overridden init method.
2716 This is half of the solution to getting proper error messages
2717 displayed when configuration errors occur. Here's the relevant bug:
2719 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2721 The rest of the solution involves surrounding the init method with a
2722 try/catch block and setting a global variable with the error /
2723 exception. A new async method should be created to retrieve and display
2724 the error message / exception.
2726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2727 code from constructor to init method adding exceptions as needed.
2729 2011-10-26 Ben Konrath <ben@bagu.org>
2731 Add script to monitor and restart tomcat if required.
2733 * utils/check-and-recover-tomcat.py: New file.
2735 2011-10-26 Ben Konrath <ben@bagu.org>
2737 Display the correct number of data items in the pager.
2741 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2743 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2744 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2745 The implementation is the same for both tables: Keep track of the
2746 number of non-empty rows and fire and RowCountChangeEvent after the data has
2748 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2749 custom Pager class that subclasses SimplePager to handle displaying
2750 the correct number when empty rows have been added.
2752 2011-10-26 Ben Konrath <ben@bagu.org>
2754 Correct error in previous commit.
2756 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2757 eventBus parameter from listView.setCellTable().
2759 2011-10-26 Ben Konrath <ben@bagu.org>
2761 Fix error in TODO comment.
2763 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2765 2011-10-24 Ben Konrath <ben@bagu.org>
2767 Create Notebook widgets to the details view.
2769 This isn't finished just yet - I still need to create a reasonable
2770 style to match the current theme.
2772 * src/main/java/org/glom/web/client/Utils.java: Add method for
2773 calculating the height of a widget. This is used in the Notebook class.
2774 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2775 new constructor method in Group.
2776 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2777 method for creating child widget that can be used by subclasses
2778 like Notebook. New constructor that allows disabling the group
2779 titles - Notebooks don't set a group title for their child groups.
2780 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2781 to make Notebooks using GWT's TabLayoutPanel.
2782 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2783 constructor that allows disabling the group titles.
2784 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2785 LayoutItemNotebook DTO.
2786 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2787 DTO for Notebooks. It's just an empty class for now but we might need
2788 it to transfer some specific information in the future.
2790 2011-10-21 Ben Konrath <ben@bagu.org>
2792 Add navigation buttons to related list tables.
2794 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2795 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2796 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2797 method getSuitableRecordToViewDetails() for getting the table name
2798 and primary key value for related list navigation buttons.
2799 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2800 private cell renderer class to get the navigation information for
2801 related list tables from the server. Extract the navigation
2802 processing code from the details cell navigation and use it for the
2803 related list navigation as well.
2804 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2805 cell renderer class for the details open buttons. This was needed
2806 because the related list navigation buttons and the list view
2807 navigation buttons need to react differently when clicked.
2808 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2809 the onEnterKeyDown() method because it's now overriden in the
2810 subclasses that are specific to the related list tables and the list
2812 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2813 the vertical size a little because the buttons add a bit of vertical
2814 space to table. This is not a perfect solution because the vertical
2815 size of with table fewer than 5 rows will be a little smaller.
2816 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2817 changes in how navigation buttons are handled.
2818 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2819 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2820 database access object.
2821 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2822 to find the portal for a given relationship name from
2823 RelatedListDBAccess. Add method to find a primary key field for a
2825 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2826 Move code to find the portal for a given relationship name to
2828 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2829 New file: database access object for getting the related list
2830 navigation information (the table name and the primary key value).
2831 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2832 DTO for transferring a table name to navigate to and a primary key
2834 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2835 boolean and getter/setter to specifies if the related list should add
2838 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2840 Use the master branch of java-libglom
2842 * pom.xml: Depend on java-libglom 1.19 instead.
2844 This is the master branch. See also the libglom-1-18 branch.
2846 2011-10-11 Ben Konrath <ben@bagu.org>
2848 Enable the open navigation button when the data has been set.
2850 This avoids having active buttons that don't do anything when the data
2853 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2855 2011-10-11 Ben Konrath <ben@bagu.org>
2857 Use IsWidget interface for FlowTableItem.
2859 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2860 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2862 2011-10-11 Ben Konrath <ben@bagu.org>
2864 Remove GWT styling from open button in details view.
2866 There are still some issues with how the details cell is arranged but
2867 this should be made to match Glom 1.20. I'm going to leave fixing this
2868 until I have Glom 1.20 up and running.
2870 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2871 style name on open button.
2872 * src/main/webapp/style.css: Move and edit details-navigation class.
2873 Re-arrange some classes to make them appear in the same order as the
2876 2011-10-07 Ben Konrath <ben@bagu.org>
2878 Update to GWT 2.4.0.
2880 * .gitignore: Ignore new cache directory.
2881 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2882 * pom.xml: Change GWT and maven plugin to 2.4.0.
2883 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2885 * src/main/java/org/glom/web/client/ClientFactory.java:
2886 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2887 * src/main/java/org/glom/web/client/OnlineGlom.java:
2888 Update source for API changes.
2889 * utils/build-onlineglom-war.sh: Remove cache directory before the
2892 2011-10-07 Ben Konrath <ben@bagu.org>
2894 Add navigation buttons in the details view.
2896 This isn't finished but I thought I'd commit what I have as it's a
2897 pretty good start. I still need to:
2899 1. Change the style so that it fits better into the current theme
2900 2. Adjust the details cell to expand as much as possible.
2902 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2903 click handlers to navigation buttons in the DetailsCells. Create a
2904 refreshData() method to get just the data from the server without the
2906 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2907 Update the tableSelector and browser title when the table name
2908 changes without using the tableSelector.
2909 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2910 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2911 getDetailsCells() to getCells(). Update variable names.
2912 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2913 method to set click handler on navigation button. Rename a few
2914 variables. Add navigation buttons where needed.
2915 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2916 variables and methods.
2917 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2918 navigation boolean and navigation table as required in the
2919 LayoutItemField DTO.
2920 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2921 variables for navigation along with getter/setter methods.
2923 2011-10-07 Ben Konrath <ben@bagu.org>
2925 Rename Field to DetailsCell.
2927 This is a refactor-only commit. No functionality has been added or
2930 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2931 Update variable and method names.
2932 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2933 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2934 variable and method names.
2935 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2937 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2938 variable and method names.
2940 2011-10-07 Ben Konrath <ben@bagu.org>
2942 Create separate methods for layout and data the details view.
2944 This is a refactor-only commit. No functionality has been added or
2947 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2948 private methods: setData(), createLayout().
2950 2011-10-07 Ben Konrath <ben@bagu.org>
2952 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2954 This is part of a change to get navigation buttons in the details view
2955 but it should have been done this way from the start.
2957 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2958 for method name change in TableSelectionView.
2959 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2960 Create TableChangeEvent and set the browser title using the
2961 TableSelectionView API.
2962 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2963 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2964 Change getSelectedTable() to getSelectedTableName(). Add
2965 getSelectedTableTitle().
2967 2011-10-07 Ben Konrath <ben@bagu.org>
2969 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2971 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2973 2011-10-07 Ben Konrath <ben@bagu.org>
2975 Update TableChangeEvent to use newTableName naming convention.
2977 This makes the class more consistent with GWT naming conventions.
2979 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2980 Update for method name change in TableChangeEvent.
2981 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2982 for method name change in TableChangeEvent.
2983 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2984 newTableName variable and getter method. Make toDebugString()
2987 2011-09-30 Ben Konrath <ben@bagu.org>
2989 Disable the pager in the list tables when the data row count is less than the minimum.
2991 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2992 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2994 2011-09-30 Ben Konrath <ben@bagu.org>
2996 Add empty rows to the end of related list and list view tables.
2998 I also extracted the cell rendering classes from the ListTable because
2999 the code was becoming a little crazy with all the anonymous inner
3000 classes. My plan is to use these cell rendering classes in the details
3001 view as well so this refactor will be needed for that change.
3003 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3004 set the row count in related list tables if the data has more rows
3005 than the minimum number of rows visible.
3006 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3007 row count in list view tables if the data has more rows than the
3008 minimum number of rows visible.
3009 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3010 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3012 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3013 for rendering TYPE_NUMERIC cells. The code was extracted from the
3015 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3016 class for rendering cells with buttons in list views. The code was
3017 extracted from the ListTable class.
3018 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3019 for rendering TYPE_TEXT cells. The code was extracted from the
3021 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3022 Add empty rows to the end of the data if required. Implement
3023 ListTable.getMinNumVisibleRows().
3024 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3025 cell renderer code to public classes. Return null in
3026 Column.getValue() for empty rows. Add new abstract method:
3027 getMinNumVisibleRows(). Move code to set the row count of the list view
3028 table to ListViewImpl.
3029 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3030 empty rows to the end of the data if required. Implement
3031 ListTable.getMinNumVisibleRows().
3034 2011-09-27 Ben Konrath <ben@bagu.org>
3036 Use GWT.log for client-side debugging statements.
3038 These are optimized out when deployed so I should have used this method
3039 in the first place. These statements will eventually be replaced with some sort
3040 of notification in the browser.
3042 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3043 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3044 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3045 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3046 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3048 2011-09-27 Ben Konrath <ben@bagu.org>
3050 Put tableselector on the right, back to list link on right.
3052 The idea is that the table selector is acting like a label for the
3053 currently displayed table so it should be placed below the document title. This
3054 puts the table title in a similar position to where it is in Glom.
3056 * mockups/details-contacts.html:
3057 * mockups/details-projects.html:
3058 * mockups/listview-contacts.html:
3059 * mockups/listview-projects.html:
3060 * mockups/style.css:
3061 Update mockups to match how the interfaces currently look.
3062 * src/main/webapp/style.css: Swap positions of backlink with the table
3063 selector. Add some space on the left side of the table selector to
3064 line things up with the document title.
3066 2011-09-27 Ben Konrath <ben@bagu.org>
3068 Add field colouring to details view.
3070 This change re-works how field colouring works. The colour formatting
3071 information is now set to the client with the layout information instead of
3072 with the data. This eliminates the need to send the same colour strings for
3073 data in list view column when colour information is set.
3075 In order to set an alternate colour for negative numeric values, the
3076 number is now sent to client and formatted with the GWT NumberFormat class.
3078 This change also fixes:
3080 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3082 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3083 internationalization framework which is needed for client side numeric
3085 * src/main/java/org/glom/web/client/Utils.java: New file for some
3086 client static utility methods.
3087 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3088 the DataItem object to the Field class. Use a utility method to
3089 create the foreignKeyValue string.
3090 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3091 alignment and text colours in the constructor. Add setData(DataItem)
3092 method. Remove setText(String) method.
3093 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3094 colour information to GlomTextCell. Create and use GlomNumberCell for
3095 rendering numbers. Use utility method to get the string for the
3096 primary key of the key provider. Re-work how the horizontal alignment
3098 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3099 formatting to layout information. Methods for converting the libglom
3100 formatting information were moved from DBAccess.
3101 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3102 numeric formatting (it's now done on the client side). Don't set text
3103 colours in DataItem. Move libglom formatting conversion methods to
3105 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3106 getters/setters for text colour information.
3107 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3108 for transferring the libglom NumericFormat information to the client.
3109 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3110 and getters/setters for: GlomNumericFormat, background colour and
3111 foreground colour strings.
3113 2011-09-26 Ben Konrath <ben@bagu.org>
3115 Simplify code that iterates through the LayoutGroup.
3117 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3119 2011-09-26 Ben Konrath <ben@bagu.org>
3121 Accept Eclipse formatting for OnlineGlomServiceAsync.
3123 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3125 2011-09-26 Ben Konrath <ben@bagu.org>
3127 Don't use the ListDBAccess classes to get the primary key layout information.
3129 This was causing a bug where the wrong index for the hidden primary key
3130 was being sent to the client.
3132 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3133 primary key while creating the LayoutGroup DTO. Create a
3134 LayoutItemField DTO for hidden primary keys. Don't use the
3135 RelatedListDBAccess because it was only used for getting the primary
3137 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3138 access modifier from public to protected for getPrimaryKeyField() and
3139 getPrimaryKeyLayoutItemField().
3140 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3141 abstract method getExpectedResultSize() because RelatedListDBAccess
3142 doesn't have enough info to implement it.
3143 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3144 Remove @Override for getExpectedResultSize().
3145 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3146 Remove method getExpectedResultSize().
3148 2011-09-23 Ben Konrath <ben@bagu.org>
3150 Log which layout (list or details) the ignored item is from.
3152 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3154 2011-09-23 Ben Konrath <ben@bagu.org>
3156 Remove annotations that turn off code formatting in DataItem.
3158 * src/main/java/org/glom/web/shared/DataItem.java:
3160 2011-09-23 Ben Konrath <ben@bagu.org>
3162 Rename GlomField to DataItem and update associated methods.
3164 This is a rename-only refactor. No functionality has been added or
3167 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3168 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3170 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3171 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3172 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3173 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3174 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3176 * src/main/java/org/glom/web/server/database/DBAccess.java:
3177 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3178 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3179 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3180 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3181 * src/main/java/org/glom/web/shared/DataItem.java:
3182 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3183 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3185 2011-09-23 Ben Konrath <ben@bagu.org>
3187 Rename GlomDocument to DocumentInfo and update associated methods.
3189 This is a rename-only refactor. No functionality has been added or
3192 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3193 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3194 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3195 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3196 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3198 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3200 2011-09-20 Ben Konrath <ben@bagu.org>
3202 Require java-libglom 1.17.3.
3204 This picks up the fix for the seg fault problem with the Scenes table
3205 in the Openismus Film Manager example.
3209 2011-09-20 Ben Konrath <ben@bagu.org>
3211 Change the way sort clause is added for primary key when no sort clause is requested.
3213 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3214 before the sort clause is created. When a sort clause is not requested, the
3215 sort clause is created by finding the primary key in the LayoutFieldVector
3218 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3220 2011-09-20 Ben Konrath <ben@bagu.org>
3222 Log error message if no documents are found in the configured directory.
3224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3225 Extract the glom file extension string to a private static final class
3226 variable (mostly as syntactic sugar). Accept a minor formatting change.
3227 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3228 the example glom.document.directory configuration property to make it
3229 more clear that it can any directory, not just the home directory.
3231 2011-09-18 Ben Konrath <ben@bagu.org>
3233 Add related lists to details view.
3235 The related list table has support for paging and sorting just like the
3236 table in the list view.
3238 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3239 SQL queries for the related list tables.
3240 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3241 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3243 Rename getList methods to getListView and add comments. Remove
3244 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3245 it being unused. Add methods: getDetailsLayoutAndData(),
3246 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3247 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3248 Create the layout and set the data for the fields in one async call
3249 instead of two. Create related lists where appropriate.
3250 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3251 for method name changes in OnlineGlomService.
3252 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3253 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3254 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3256 * src/main/java/org/glom/web/client/ui/ListView.java:
3257 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3258 tableName from setCellTable(). Create a ListViewTable instead of
3260 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3261 represent a data field in the details view.
3262 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code