1 2012-05-24 Murray Cumming <murrayc@murrayc.com>
3 Update translations, adding French.
5 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
6 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
7 Add a French translation, using the translation from Glom.
9 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
10 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
11 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
12 Update these based on the translations from Glom.
14 2012-05-24 Murray Cumming <murrayc@murrayc.com>
16 SelfHoster: Add some debug println messages to help when things fail.
18 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
19 System.out.println() lines.
21 2012-05-23 Murray Cumming <murrayc@murrayc.com>
23 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
25 * src/test/java/org/glom/web/server/SelfHoster.java:
26 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
27 instance) instead of just /usr/bin (as on Fedora). Check the result when
30 2012-05-23 Murray Cumming <murrayc@murrayc.com>
32 Remove LayoutItemPortal.get/setNavigationTable().
34 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
35 Remove get/setNavigationTable(), which is only a cache, because it is not
36 used, and does not need to be used, because that decision should be made on
38 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
39 updatePortalsExtras():
40 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
41 getNavigationRecord():
42 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
45 2012-05-21 Murray Cumming <murrayc@murrayc.com>
47 Initial self-hosting for tests.
49 * pom.xml: Change the scope for log4j, to hopefully make it
50 available to the test code which uses it indirectly via jOOQ.
51 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
52 self-hosting, though we only use it for testing.
54 * src/main/java/org/glom/web/server/libglom/Document.java:
55 example rows: Use a map instead of a list for each row of values,
56 so we know what field they are for, instead of relying on the sequence
57 being correct. This is not very efficient, but it does not really need
59 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
60 testReadTableExampleRows(): Adapted.
62 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
63 that returns an Object, for generic use. Note that Object seems to be
64 the implicit base even of double.
65 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
66 for use in CREATE TABLE SQL queries.
67 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
68 to do self-hosting of PostgreSQL databases via its command-line
69 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
70 backends/postgres_self.cc. This is incomplete - it needs more
71 warnings about failures and it needs to clean up properly when things
73 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
74 test of this new class.
76 2012-05-21 Murray Cumming <murrayc@murrayc.com>
78 Document: loading example data: Handle exceptions.
80 * src/main/java/org/glom/web/server/libglom/Document.java:
81 DateFormat.parse() and Double.valueOf() can throw exceptions, though
82 Eclipse did not warn about that.
84 2012-05-20 Murray Cumming <murrayc@murrayc.com>
86 Document: load(), save(): Handle the example rows.
88 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
90 * src/main/java/org/glom/web/server/libglom/Document.java:
91 load(), save(): Load and save the example rows, though the date, time
92 and image types are not handled properly yet.
93 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
94 Add testReadTableExampleRows() just to check that something is read.
96 2012-05-20 Murray Cumming <murrayc@murrayc.com>
100 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
101 Added getTranslationsMap() for use while saving.
102 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
103 Adedd getUseDefaultFormatting() for use while saving.
104 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
105 and several private methods that it uses.
107 This will be useful while testing via self-hosting.
108 It is not complete, but should be complete enough for testing.
110 2012-05-17 Murray Cumming <murrayc@murrayc.com>
112 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
114 * src/main/java/org/glom/web/client/OnlineGlomService.java
115 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
116 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
117 Remove getSortedListViewData() and getSortedRelatedListData(), adding
118 the sort column index and ascending bool to the regular method.
119 Instead, a sort column index of -1 now means no sort.
120 This is less explicit, but it's fairly simple, reduces the amount of
121 code, and makes the OnlineGlomService API slightly smaller.
122 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
123 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
125 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
126 getListViewData(), getRelatedListData():
127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
128 getListViewData(), getRelatedListData():
129 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
131 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
133 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
138 2012-05-16 Murray Cumming <murrayc@murrayc.com>
140 Use translations for top-level groups too.
142 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
143 updateTitlesForLocale(): Use the translation for the group
144 as well as for child items.
148 Just recompiled to fix a problem in the released .tar.gz file.
152 2012-05-15 Murray Cumming <murrayc@murrayc.com>
154 Corrections to navigation to related records.
156 * src/main/java/org/glom/web/client/OnlineGlomService.java:
157 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
159 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
160 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
161 relationship name, because the relationship name is not necessarily unique
163 TOOD: This is inefficient, because it passes the whole list of
164 child field items back to the server, but it is more correct, and happens
165 to fix a bug with the primary key being lost after a few navigations.
166 There is probably a chance to make this more efficient anyway in some
169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
170 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
171 * src/main/java/org/glom/web/server/ConfiguredDocument.java
172 * src/main/java/org/glom/web/server/database/DBAccess.java
173 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
174 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
177 2012-05-15 Murray Cumming <murrayc@murrayc.com>
179 Fix the use of translations.
181 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
182 Add updateTitlesForLocale().
183 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
184 Call it to discard unwanted translations and to make getTitle() return
185 the wanted translation wihout the need for the client code to specify a locale.
186 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
187 getTitle(): Fallback to the original title, as libglom does.
189 2012-05-15 Murray Cumming <murrayc@murrayc.com>
191 Document: Correctly report the number of available translation locales.
193 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
194 the available locale IDs list.
195 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
196 testLocales: Test this.
198 2012-05-15 Murray Cumming <murrayc@murrayc.com>
200 SqlUtils: Use camelCase.
202 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
203 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
204 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
205 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
206 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
207 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
209 2012-05-15 Murray Cumming <murrayc@murrayc.com>
211 Use jOOQ's tableByName() and fieldByName.
213 * pom.xml: Use jOOQ 2.3.1 to get the new API.
214 * src/main/java/org/glom/web/server/SqlUtils.java:
215 build_sql_select_step_with_where_clause(), .createField(),
216 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
217 so we can get correct quoting and escaping. Thanks to Lukas Eder for
218 adding this, and other things, to jOOQ.
220 2012-05-15 Murray Cumming <murrayc@murrayc.com>
222 SqlUtils: Remove the Connection parameters.
224 * src/main/java/org/glom/web/server/SqlUtils.java:
225 build_sql_select_with_key(), build_sql_select_with_where_clause(),
226 createSelect(), build_sql_select_step_with_where_clause(),
227 build_sql_count_select_with_where_clause(),
228 build_sql_select_count_rows(): Remove the Connection parameter because
229 jOOQ does not actually need a connectionwhen it is just used to build
231 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
233 * src/main/java/org/glom/web/server/ReportGenerator.java:
235 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
237 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
238 Constructor, getListData(), getResultSizeOfSQLQuery():
239 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
240 getSelectQuery(), getCountQuery():
241 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
242 getSelectQuery(), getCountQuery():
243 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
244 getNavigationRecord(): Adapted.
246 2012-05-14 Murray Cumming <murrayc@murrayc.com>
250 * src/main/java/org/glom/web/server/SqlUtils.java:
251 get_find_where_clause_quick(): Use a comparison of
252 lowercase values, instead of a simple equals. Regular Glom
253 uses the PostgreSQL ILIKE operator but jOOQ does not
254 support that just yet, though it will soon.
256 2012-05-14 Murray Cumming <murrayc@murrayc.com>
258 TableToViewDetails: Use a real serialization ID.
260 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
261 Though this does not fix the serialization problem.
263 2012-05-12 Murray Cumming <murrayc@murrayc.com>
265 Added LayoutItemPortalDeepCloneTest.
267 2012-05-11 Murray Cumming <murrayc@murrayc.com>
269 Make navigation work again.
271 * src/main/java/org/glom/web/server/libglom/Document.java:
272 Add getLayoutItemFieldShouldHaveNavigation().
273 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
274 Replace get/setAddNavigation() with the partly-existing
275 get/setNavigationTableName(), with an empty string being no navigation,
276 because this is simpler. Use the new
277 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
279 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
280 Add updateFieldsExtras() and call setNavigationTableName in it.
281 getDetailsLayoutGroup(),
282 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
283 createLayout(): Adapted.
284 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
285 Constructor: Adapted.
287 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
288 Replace get/setAddNavigation() with get/setNavigation(), returning a
289 TableToViewDetails class with both the table name and UsesRelationship,
290 because both are need. The previous code used java-libglom's output
291 variable (strangely, via sharedptr) to return both, but we cannot really
293 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
294 getNavigationRecord(): Adapt. However, we cannot actually use the cache
295 here because it somehow gets set to null during deepCopy(). I must test this.
296 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
297 testGetSuitableTableToViewDetails(): Adapted.
299 TODO: Find out why deepClone() is not quite working.
301 2012-05-11 Murray Cumming <murrayc@murrayc.com>
303 DBAccess: Simplify the retrievel of full field details.
305 * src/main/java/org/glom/web/server/database/DBAccess.java
306 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
307 because the Document loading should have done this.
309 2012-05-11 Murray Cumming <murrayc@murrayc.com>
311 Document: Correct loading of doubly-related layout fields.
313 * src/main/java/org/glom/web/server/libglom/Document.java:
314 loadUsesRelationship(): Actually set the related relationship, instead
315 of only setting it if it's not found.
317 2012-05-09 Murray Cumming <murrayc@murrayc.com>
319 Replace all appearances of Colour with color.
321 Because US English is dominant.
323 2012-05-09 Murray Cumming <murrayc@murrayc.com>
325 Use colors in HTML format, solving a warning about an unused function.
327 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
328 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
329 Add *asHTMLColor() versions of methods.
330 TODO: However, we should create and cache the results on the server.
331 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
332 * src/main/java/org/glom/web/client/ui/list/ListTable.java
333 * src/main/java/org/glom/web/server/ConfiguredDocument.java
334 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
335 Use the asHTMLcolor() versions.
337 2012-05-09 Murray Cumming <murrayc@murrayc.com>
339 ListViewTable: Constructor: Take the table name as a parameter.
341 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
342 Constructor: Take the tableName, and set the member variable, because
344 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
345 setCellTable(): Pass the table name.
346 This makes navigation to non-default tables work again. I don't know
347 why it worked before in the master branch.
349 2012-05-07 Murray Cumming <murrayc@murrayc.com>
351 ConfiguredDocument: Restore correct addition of hidden primary key items.
353 * src/main/java/org/glom/web/client/ui/list/ListTable.java
354 (ListTable.createCellTable): Uncomment out the check for the hidden
356 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
357 add primary key items for top-level lists and portals, as before,
358 instead of adding them to each group.
359 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
360 Actually implement the extra methods such as setHiddenPrimaryKey() and
361 comment that these are used only for top-level list groups and in portals.
362 This strangeness suggests even more that this should not be squeezed
363 into the LayoutGroup class.
365 2012-05-07 Murray Cumming <murrayc@murrayc.com>
367 Fix Formatting loading.
369 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
370 getFormattingUsed(): Remove the duplicate Formatting member variable
371 in favour of the one from the base class.
372 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
373 Initialize a new Formatting instead of using null by default, so we
374 have some defaults, instead of having to initialize one later just to
375 get the same defaults. This also makes loading of formatting from the
376 document work, because that expected a non-null.
378 2012-05-07 Murray Cumming <murrayc@murrayc.com>
380 RelatedListTable: Make sure that the tableName is set.
382 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
383 Constructor: Take the tableName so it is available later. Otherwise,
384 the server assumes that we mean the default table and cannot find the
386 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
387 setData(): Pass the tableName to the RelatedListTable constructor.
389 2012-05-07 Murray Cumming <murrayc@murrayc.com>
393 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
394 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
395 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
397 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
399 * src/main/java/org/glom/web/server/database/DBAccess.java:
400 convertResultSetToDTO(), getPortal():
401 * src/main/java/org/glom/web/server/database/ListDBAccess.java
403 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
404 Add checks for null objects and out of range access, with log messages to
405 give hints so we can fix these properly.
407 2012-05-07 Murray Cumming <murrayc@murrayc.com>
409 Portals: some corrections.
411 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
413 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
414 constructor: Use getRelationshipNameUsed() instead of getName(), because
415 that is what is meant.
416 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
417 getFromField(): Fix a typo, to get the field name, not the table name.
418 * src/main/java/org/glom/web/server/database/DBAccess.java:
419 getPortal(): Fix a typo that stopped this from working.
421 2012-05-07 Murray Cumming <murrayc@murrayc.com>
423 LayoutItemPortal: Also override getTitleOriginal().
425 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
426 This lets the base getTitle() with no parameters work.
427 TODO: Test this properly.
429 2012-05-06 Murray Cumming <murrayc@murrayc.com>
431 LayoutItemPortal: getTitle*(): Use the relationship title.
433 2012-05-06 Murray Cumming <murrayc@murrayc.com>
435 LayoutItemField: Fix loading of custom titles.
437 * src/main/java/org/glom/web/server/libglom/Document.java
438 loadDataLayoutItemField(): The title, if any, instead of the field
439 title, is stored in a title_custom node. Load it from there.
440 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
442 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
443 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
444 getTitle*() overrides.
445 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
448 2012-05-06 Murray Cumming <murrayc@murrayc.com>
450 LayoutItemField: Fall back to field titles, so some are really shown.
452 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
453 Override getTitleOriginal() and getTitle(), as in java-libglom.
454 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
457 2012-05-06 Murray Cumming <murrayc@murrayc.com>
459 Correct use of setExpectedResultSize().
461 * src/main/java/org/glom/web/server/ConfiguredDocument.java
462 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
463 Use setExpectedResultSize only on top-level groups (for instance, the
464 list layout) or on child portals (in details views).
465 Use the correct table name for portals to avoid SQL errors.
466 Update the expected counts when returning cached layouts.
468 2012-05-06 Murray Cumming <murrayc@murrayc.com>
470 Document: Interpret no group column count as 1.
472 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
473 default, though we now check for this in the UI code anyway.
475 2012-05-06 Murray Cumming <murrayc@murrayc.com>
479 2012-05-06 Murray Cumming <murrayc@murrayc.com>
481 Translatable: Use Hashmap instead of Treemap because GWT supports it.
483 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
484 The use of Treemap lead to this error from async methods, with no
486 "The response could not be deserialized"
488 2012-05-06 Murray Cumming <murrayc@murrayc.com>
490 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
492 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
493 when using the Google -> GWT Compile, or
494 g toolbar button -> GWT Compile Project... feature in Eclipse.
496 2012-05-06 Murray Cumming <murrayc@murrayc.com>
498 ListTable.addColumn(): Protect against a null Formatting.
500 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
501 Create a default Formatting if it is null, because that is the simplest
504 2012-05-06 Murray Cumming <murrayc@murrayc.com>
506 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
508 * src/main/java/org/glom/web/server/ConfiguredDocument.java
509 updateLayoutGroup(): Check that the field is not null.
511 2012-05-06 Murray Cumming <murrayc@murrayc.com>
513 ListViewImpl: Protected against a bad cast error.
515 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
516 onEnterKeyDown(): Do not cast without an instanceof check.
518 2012-05-06 Murray Cumming <murrayc@murrayc.com>
520 ListTable: Protect against an out of range error.
522 * src/main/java/org/glom/web/client/ui/list/ListTable.java
523 createCellTable(): This is unlikely, but can happen while debugging.
525 2012-05-06 Murray Cumming <murrayc@murrayc.com>
527 AsyncMessage onFailure() callbacks: Log the exception message.
529 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
530 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
531 * src/main/java/org/glom/web/client/activity/ListActivity.java:
532 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
533 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
534 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
535 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
536 These are useful clues when something is wrong.
538 2012-05-06 Murray Cumming <murrayc@murrayc.com>
540 ConfiguredDocument: Avoid a null dereference.
542 * src/main/java/org/glom/web/server/ConfiguredDocument.java
543 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
544 details maps are created.
546 2012-05-06 Murray Cumming <murrayc@murrayc.com>
548 Document: Correct the port number parsing.
550 * src/main/java/org/glom/web/server/libglom/Document.java:
551 This lets us actually connect to the database and show the document.
553 2012-05-05 Murray Cumming <murrayc@murrayc.com>
557 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
558 user-interaction, asking us to load a temporary URL in a browser.s
559 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
560 which is apparently necessary for testing the service. See the comment.
561 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
562 Show the exception, if any. This is how I saw the 404 in the HTML in
565 2012-05-05 Murray Cumming <murrayc@murrayc.com>
567 DocumentTest: Move the .glom files into the resources directory.
569 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
570 URI via getResource().
572 2012-05-05 Murray Cumming <murrayc@murrayc.com>
574 Document: Remove the FieldIdentifies inner class.
576 * src/main/java/org/glom/web/server/libglom/Document.java: We only
577 use the Relationship (though the same function in libglom is maybe
578 used in other ways) and so this removes a compiler warning.
580 2012-05-05 Murray Cumming <murrayc@murrayc.com>
582 Document.load() Remove the error code parameter.
584 * src/main/java/org/glom/web/server/libglom/Document.java: load():
585 Remove the parameter. We do not set it yet and it could never have
586 worked as an output parameter (though maybe it did in java-libglom).
587 We could use an exception if we really want the failure reason.
588 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
590 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
591 setUp(), testGetSuitableTableToViewDetails(): Adapt.
593 2012-05-05 Murray Cumming <murrayc@murrayc.com>
595 Make some inner classes static.
597 * src/main/java/org/glom/web/server/ConfiguredDocument.java
598 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
599 * src/main/java/org/glom/web/server/ReportGenerator.java
600 * src/main/java/org/glom/web/server/libglom/Document.java
601 Make all inner classes static that can be static.
603 2012-05-05 Murray Cumming <murrayc@murrayc.com>
605 OnlineGlomServiceImpl: Do not load and check for java-libglom.
607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
608 init(): We do not use java-libglom any more.
610 2012-05-05 Murray Cumming <murrayc@murrayc.com>
612 Remove mentions of java-libglom.
614 * README: Remove mention of java-libglom, because it no longer needed.
615 * utils/build-onlineglom-war.sh:
616 * utils/check-and-recover-tomcat.py:
617 * utils/install-onlineglom-war.sh: Remove these as they are no longer
618 useful. Building is now far easier, with no need for jhbuild.
620 2012-05-05 Murray Cumming <murrayc@murrayc.com>
622 Fix the build (mvn package)
624 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
625 (LayoutGroup): Make the LayoutItemList inner class static and protected.
626 Otherwise the GWT Java->Javascript compilation fails with just this
627 error, during mvn package or when attempting to view in a browser,
628 in the GWT developer mode in Eclipse.
630 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
631 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
632 [INFO] Compiling module org.glom.web.OnlineGlom
633 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
634 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
635 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
636 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
637 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
638 [INFO] [ERROR] Cannot proceed due to previous errors
640 It has taken me 2 days to find out what was causing that. After reducing
641 the code, the compiler eventually showed me the full error message.
643 2012-05-04 Murray Cumming <murrayc@murrayc.com>
645 ConfiguredDocument: Cache the cloned and stripped layouts.
647 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
648 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
649 layout in a map, so we can retrieve it again without rebuilding it.
651 2012-05-04 Murray Cumming <murrayc@murrayc.com>
653 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
655 2012-05-04 Murray Cumming <murrayc@murrayc.com>
657 libglom classes: Implement some auto-generated emthods.
659 2012-05-04 Murray Cumming <murrayc@murrayc.com>
661 Add GwtTestOnlineGlomService.
663 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
664 However, this (and the other GwtTest*) does not seem to run during
667 2012-05-04 Murray Cumming <murrayc@murrayc.com>
669 Remove use of unsupported features from client code.
671 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
672 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
673 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
674 Use our client version of StringUtils instead of the apache commons one.
676 However, the GWT Javascript compliation still fails.
678 2012-04-25 Murray Cumming <murrayc@murrayc.com>
680 Add a Field class and implement some loading of it in Document.
682 2012-04-25 Murray Cumming <murrayc@murrayc.com>
684 Initial Document loading implementation, instead of libglom.
686 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
687 and Translatable classes, and adapt the rest of the code to use them.
688 However, this is still missing Layout and Field classes and loading.
690 2012-04-24 Murray Cumming <murrayc@murrayc.com>
692 Use of jOOQ: Move Field creation into a utility method.
694 * src/main/java/org/glom/web/server/SqlUtils.java:
695 This lets us improve it more easily.
697 2012-04-24 Murray Cumming <murrayc@murrayc.com>
699 Use of jOOQ: Improve the code to COUNT a sub-select.
701 * src/main/java/org/glom/web/server/SqlUtils.java:
702 Move initial query creation into
703 build_sql_select_step_with_where_clause().
704 build_sql_select_count_rows(): Use the jOOQ API instead of
705 concatentating text, because a jOOQ Select*Step is a TableLike,
706 which is what from() takes.
708 2012-04-23 Murray Cumming <murrayc@murrayc.com>
710 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
712 * pom.xml: Depend on jooq.
713 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
714 methods with jOOQ, based on the C++ implementations in libglom,
715 with some changes to the logic required by jooQ.
716 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
718 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
719 * src/main/java/org/glom/web/server/ReportGenerator.java:
720 * src/main/java/org/glom/web/server/SqlUtils.java:
721 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
722 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
723 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
724 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
725 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
726 Adapt. In particular, the SqlUtils methods now need to take a Connection,
727 because jOOQ needs that, though it seems unnecessary.
729 This is not quite finished. Ideally jOOQ would help us to build
730 table_name.field_name names, quoting and escaping them properly.
731 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
733 2012-04-21 Murray Cumming <murrayc@murrayc.com>
735 Move use of Glom.build_sql*() into a new SqlUtils class.
737 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
738 to wrap Glom.build_sql*(). The parameter types are still Glom one,
739 but this will make it easier to start using something other than
740 libglom or SqlBuilder.
742 2012-04-21 Murray Cumming <murrayc@murrayc.com>
744 Update the project URL.
746 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
748 2012-04-21 Murray Cumming <murrayc@murrayc.com>
750 Main layout: Use a FlowTable instead of absolute positioning.
752 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
753 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
754 child panels/widgets must have an absolute position. But that is annoying, so
755 this adds a FlowTable and puts the child panels in there.
757 2012-04-21 Murray Cumming <murrayc@murrayc.com>
759 GwtTestOnlineGlom: Comment out unused code.
761 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
762 Eclipse has started to say that some code is unused.
764 2012-04-21 Murray Cumming <murrayc@murrayc.com>
766 Update to the latest versions of dependencies.
768 * pom.xml: Update version numbers of dependencies to the latest
770 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
772 * src/main/java/org/glom/web/server/ReportGenerator.java:
773 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
774 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
775 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
777 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
778 Modify the imports where necessary.
780 2012-04-17 Murray Cumming <murrayc@murrayc.com>
782 Style: Remove overflow:hidden from searchbox
784 * src/main/webapp/style.css: Because this pushes the Back To Link
785 label/link on to the next row, which is then hidden due to the
786 hard-coded (in ems) height.
788 2012-04-20 Murray Cumming <murrayc@murrayc.com>
790 Remove some duplicate code.
792 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
793 getDocumentInfo(): This must have been duplicated during the merge from the
798 2012-04-19 Murray Cumming <murrayc@murrayc.com>
800 Reports: Localize the waiting for report message.
802 * src/main/java/org/glom/web/client/activity/ReportActivity.java
803 start(): Get the message from the contants.
804 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
806 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
807 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
808 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
809 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
810 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
811 Update these files with the English text for newer strings for now.
813 2012-04-19 Murray Cumming <murrayc@murrayc.com>
815 Reports: Show a message while waiting for the report.
817 * src/main/java/org/glom/web/client/ui/ReportView.java
818 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
819 Add setWaitingText(), to show a message saying that we are
820 waiting for the report to be ready.
821 * src/main/java/org/glom/web/client/activity/ReportActivity.java
822 start(): Call setWaitingText() before calling the async
825 2012-04-19 Murray Cumming <murrayc@murrayc.com>
827 ReportGenerator: Specify date and time formats.
829 * src/main/java/org/glom/web/server/ReportGenerator.java:
830 createFieldValueElement(): Use the default (and localized)
831 short formats, though we still need a way to show 4-digit
832 years without providing the format for every locale.
833 * src/main/java/org/glom/web/server/database/DBAccess.java:
834 convertResultSetToDTO(): Use the short formats here too.
836 2012-04-18 Murray Cumming <murrayc@murrayc.com>
838 ReportGenerator: Use the correct numeric formatting.
840 * src/main/java/org/glom/web/server/ReportGenerator.java
841 createFieldExpression(), createFieldValueElement(): Take the
842 whole LayoutItem_Field instead of just the field name, so
843 we have access to the formatting.
844 createFieldValueElement(): Use JRTextField.setPattern() to
845 specify the numeric formatting, with the help of a
846 regular DecimalFormat.
848 2012-04-18 Murray Cumming <murrayc@murrayc.com>
850 ReportGenerator: Avoid showing null for group by titles.
852 * src/main/java/org/glom/web/server/ReportGenerator.java
853 generateReport(): Use setBlankWhenNull() on the field title
854 style too, because this is used for values in group by
857 2012-04-18 Murray Cumming <murrayc@murrayc.com>
859 ReportGenerator: Add a colon to titles in vertical groups.
861 * src/main/java/org/glom/web/server/ReportGenerator.java
862 addFieldToDetailBandVertical(): Pass true for the withColon
865 2012-04-18 Murray Cumming <murrayc@murrayc.com>
867 ReportGenerator: Simplify the code by using Position more.
869 2012-04-18 Murray Cumming <murrayc@murrayc.com>
871 Reports: Support vertical groups, roughly.
873 * src/main/java/org/glom/web/server/ReportGenerator.java:
874 addToReport(): Rename to addGroupToReport() and, if necessary,
875 call the new addVerticalGroupToReport() method.
876 createFieldValueElement(): Let the caller specify the Y position
879 2012-04-17 Murray Cumming <murrayc@murrayc.com>
881 Reports: Allow a second report to be shown.
883 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
884 clear(): Do not remove the HTML widget, which broke the whole layout.
886 2012-04-17 Murray Cumming <murrayc@murrayc.com>
888 Locales drop-down: Show that we use English by default.
890 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
891 fillView(): When we use English, just because that is the default, when
892 no locale is specified, show that in the Locales drop-down instead of
893 just showing the first item.
895 2012-04-17 Murray Cumming <murrayc@murrayc.com>
897 Unselect the Report/Locale/Table combo item when appropriate.
899 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
900 setPlace(): clear reportName if this is not a ReportPlace.
901 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
902 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
903 When the provided name is empty, unselect all items, so that none are
904 indicated. This uses a for loop because I cannot find a single method
907 2012-04-17 Murray Cumming <murrayc@murrayc.com>
909 Report: Give the user a way to get back to the list.
911 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
912 start(), setPlace(): Show the Back To List link on reports, and also
913 interpret selecting the empty report item as back to list.
915 2012-04-13 Murray Cumming <murrayc@murrayc.com>
917 Really show the selected Report name.
919 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
920 setPlace(): Store the reportName here, if it is that kind of Place.
921 fillView(): Set the selected Report after filling the list of reports.
922 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
923 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
924 null Strings, though we need some way to unselect all ListBox items
927 2012-04-13 Murray Cumming <murrayc@murrayc.com>
929 ReportGenerator: Try to avoid some problems.
931 * src/main/java/org/glom/web/server/ReportGenerator.java
932 addField(): Try to avoid duplicates, and avoid using a null
935 2012-04-13 Murray Cumming <murrayc@murrayc.com>
937 Reports: Use quickFind.
939 * src/main/java/org/glom/web/client/OnlineGlomService.java;
940 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
941 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
942 getReportHTML(): Add a quickFind parameter.
943 * src/main/java/org/glom/web/client/activity/ReportActivity.java
944 start(): Pass the quickFind parameter.
945 * src/main/java/org/glom/web/server/ReportGenerator.java
946 generateReport(): Take a quickFind parameter.
948 2012-04-13 Murray Cumming <murrayc@murrayc.com>
950 ReportPlace: Actually use the report name.
952 * src/main/java/org/glom/web/client/place/ReportPlace.java
953 getPlace(): Do not assign the report name to the quickfind.
955 2012-04-13 Murray Cumming <murrayc@murrayc.com>
957 Show java.library.path when complaining.
959 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
960 init(): When telling us to check java.library.path, show the
963 2012-03-06 Murray Cumming <murrayc@murrayc.com>
965 ReportGenerator: Do not show nulls.
967 2012-03-06 Murray Cumming <murrayc@murrayc.com>
969 ReportGenerator: Make the title font larger.
971 2012-03-06 Murray Cumming <murrayc@murrayc.com>
973 ReportGenerator: Put field titles inside groups, if there are groups.
975 2012-03-06 Murray Cumming <murrayc@murrayc.com>
977 ReportGenerator: Take the Report itself instead of the name and group.
979 * src/main/java/org/glom/web/server/ConfiguredDocument.java
980 Remove getReportLayoutGroup().
981 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
982 getReportHTML(): Pass the report instead
983 of its name and layout group.
984 * src/main/java/org/glom/web/server/ReportGenerator.java
985 generateReport(): Use the report object to use the title
988 2012-03-06 Murray Cumming <murrayc@murrayc.com>
990 ReportGenerator: Remove designBand parameters.
992 * src/main/java/org/glom/web/server/ReportGenerator.java:
993 Make designBand a class member instead of passing it to all
996 2012-03-06 Murray Cumming <murrayc@murrayc.com>
998 ReportGenerator: Add lines, a bit like in the desktop version.
1000 * src/main/java/org/glom/web/server/ReportGenerator.java
1001 addToReport(): Use JRDesignLine.
1003 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1005 ReportGenerator: Correct the title positions and use some bold style.
1007 * src/main/java/org/glom/web/server/ReportGenerator.java:
1008 Break the code up into reusable functions, correct the placement of
1009 titles, and use normal/bold styles as in the reports in the desktop
1012 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1014 ReportGenerator: Add a header band to show the field titles.
1016 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1017 getReportHTML(): Pass the localeId to the ReportGenerator
1019 * src/main/java/org/glom/web/server/ReportGenerator.java
1020 constructor: Take the localeID so we can get translated field
1022 generateReport(), addToReport(), addFieldToBand(): Add field
1023 titles in a column header band.
1025 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1027 Reports drop-down list: Some improvement.
1029 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1030 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1031 Adedd setSelectedReport(),
1032 setReportList(): Add a blank line so that the user can select the
1034 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1035 start(): Show the current report by calling setSelectedReport().
1036 This does not seem to work yet.
1038 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1040 DetailsActivity, ListActivity: Move some variables into a base class.
1042 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1043 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1044 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1045 the clientFactory, documentID, tableName and authenticationPopup into
1046 a base class, to avoid duplication.
1048 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1050 Translate the Reports label.
1052 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1053 Get the "Reports" label string from the constants.
1054 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1055 perties: Add Reports to the constants.
1057 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1059 Reports: Implement grouping.
1061 * src/main/java/org/glom/web/server/ReportGenerator.java:
1062 Handle LayoutItem_GroupBy items and try to do the right thing
1063 with JRDesignGroup. It seems to work.
1065 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1067 Actually show some data with JasperReports.
1069 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1070 getReportHTML(): Move most code into a ReportGenerator class.
1071 * src/main/java/org/glom/web/server/ReportGenerator.java:
1072 Recurse into sub-groups, adding fields to the JasperDesign's details
1073 band. Note that we must set an arbitrary width and height, or it just
1074 will not show any data.
1076 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1078 Reports Chooser: Show the titles, not the names.
1080 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1081 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1082 and the names as the values.
1083 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1084 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1085 group now that we provide the report name, so it should always
1088 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1090 Depend on jasperreports.
1092 * pom.xml: Add the dependency. My plan is to use this on the
1095 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1097 Implement navigation to report places.
1099 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1100 start(): Do not bother to handle all events here.
1101 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1102 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1103 Added getSelectedReport().
1104 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1105 .java: start(): When handling a change to the reports chooser,
1106 call getSelectedReport() and goTo() its ReportPlace.
1107 * src/main/java/org/glom/web/client/ui/ReportView.java
1108 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1109 Added setReportHTML() which puts the html in a gwt HTML widget.
1110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1111 getReportHTML(): Return "TODO" just to show that this works.
1113 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1115 Make ReportPlace usable.
1117 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1118 Mention ReportPlace.
1119 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1120 Correct the @prefix annotation.
1122 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1124 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1126 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1127 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1128 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1129 Change getReportLayout() to getReportHMTL() because we will not need to
1130 parse or render the report layout on the client side.
1131 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1132 getReportLayout(): Return the libglom LayoutGroup type because we will
1133 not need to convert to a shared type, because this will not be used on
1135 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1138 Note that there is still no implementation for this.
1141 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1143 Add a (empty) Report Place, View, and Activity.
1145 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1147 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1148 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1149 this into a superclass:
1150 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1151 and also use it as the base of this new ReportPlace:
1152 * src/main/java/org/glom/web/client/place/ReportPlace.java
1154 * src/main/java/org/glom/web/client/ui/ReportView.java
1155 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1156 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1157 Add these, containing mostly boiler-plate for now.
1159 * src/main/java/org/glom/web/client/OnlineGlomService.java
1160 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1161 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1163 Add API to get the LayoutGroup for the report.
1165 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1167 Add and fill a Reports drop-down list box.
1169 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1171 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1172 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1174 Added getReports(document, table, localeID), calling
1175 ConfiguredDocument.getReports().
1176 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1177 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1178 Added setReportsList() and a list widget.
1179 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1180 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1185 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1187 Translations: Add Esperanto.
1189 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1190 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1191 properties: Add this translation because someone took the time to make it.
1193 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1195 Adapt to the java-libglom 1.21.7 API.
1197 * src/main/java/org/glom/web/server/ReportGenerator.java:
1198 addToReport(): get_group_secondary_fields() is now
1199 get_secondary_fields().
1202 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1204 Use the latest java-libglom version.
1206 * pom.xml: Use java-libglom 1.21.7.
1208 2012-03-03 Ben Konrath <ben@bagu.org>
1210 Display date and time in details view.
1212 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1214 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1216 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1218 Require the latest java-libglom.
1220 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1222 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1224 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1226 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1227 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1228 an empty quickfind string. I also corrected libglom to create only
1229 empty where clauses for empty quickfind strings, but this avoids the
1232 2012-02-24 Ben Konrath <ben@bagu.org>
1234 Improve the tabs in the Notebook widget.
1238 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1240 Translations: Try to translate the strings.
1242 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1243 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1244 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1245 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1246 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1247 Take the Open translation from GTK+'s .po files.
1248 Take the Details translation from Glom's po files.
1249 I have added the other strings to Glom so we can get translations that way:
1250 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1252 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1254 TableSelectionViewImpl: Put the search label and entry in a div.
1256 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1257 Put the search widgets in a FlowTable so that the CSS can be used to
1258 style them while keeping them together.
1259 * src/main/webapp/style.css: Mention the new div.
1261 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1263 Translate more strings in more locales.
1265 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1266 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1267 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1268 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1269 Translate the "Details" and "Open" string too.
1271 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1272 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1273 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1274 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1275 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1276 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1277 Add these new locales as placeholders though they currently contain English.
1279 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1281 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1283 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1284 Check the ConfiguredDocument* for null before using it.
1286 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1288 Tell Eclipse about the generated java files.
1290 * .classpath: This lets it find OnlineGlomConstants.java.
1291 It would be nice if Eclipse just used the maven build files.
1293 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1295 Prevent a crash when no locale is specified in the URL.
1297 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1298 Avoid returning a null string, obtained from
1299 Window.Location.getParameter(). This caused a crash when it was
1300 later passed to libglom's API.
1301 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1302 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1303 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1304 guard against future null strings.
1306 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1308 Use the ?locale= query param instead of the &lang= token param.
1310 * src/main/java/org/glom/web/client/place/ListPlace.java
1311 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1312 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1313 Remove the lang token key and value.
1315 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1316 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1317 When the user selects a different locale from the chooser, use
1318 Window.Location.assign() to change the URL, which then causes a reload.
1320 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1321 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1322 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1323 * src/main/java/org/glom/web/client/activity/ListActivity.java
1324 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1325 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1326 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1327 * src/main/java/org/glom/web/client/ui/ListView.java:
1328 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1330 Remove localeID member variables and method/constructor parameters, instead
1331 using Utils.getCurrentLocaleID() when we need a localID to pass to
1334 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1336 Internationalize the UI strings.
1338 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1339 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1340 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1341 because it is unused. Messages are apparently strings that can have
1342 parameters, but we do not need that yet, so Contants will be enough for now.
1343 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1344 to say that we support the en and de locales.
1345 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1346 The original English strings.
1347 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1348 Some German translations of the English strings.
1349 The i18n goal then uses the .properties file to generate an
1350 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1351 returns an implementation that returns the translated strings.
1352 The documentation suggests putting these in src/java/*/client/, but it seems
1353 best to put it in src/resources/*/client/.
1354 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1355 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1356 instead of hard-coding them.
1357 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1358 but that does not seem to stop the build, though it confuses Eclipse.
1360 You can see the translated string by adding ?locale=de to the URL, like so:
1361 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1363 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1365 Improve null/empty String checks.
1367 * pom.xml: Add a dependency on commons-lang, to use
1368 org.apache.commons.lang.StringUtils.
1369 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1370 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1371 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1372 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1373 Use StringUtils.isEmpty().
1375 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1376 StringUtils class with a static isEmpty() function because we
1377 cannot use org.apache.commons.lang.StringUtils in client-side
1378 GWT code because it (apparently) cannot be compiled to javascript.
1379 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1380 * src/main/java/org/glom/web/client/activity/ListActivity.java
1381 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1382 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1383 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1384 * src/main/java/org/glom/web/client/place/ListPlace.java
1385 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1386 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1387 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1388 * src/main/java/org/glom/web/client/ui/details/Group.java
1389 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1390 our StringUtils.isEmpty() function.
1392 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1394 Update to the latest java-libglom API.
1396 * pom.xml: Require java-libglom 1.21.4.
1397 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1398 getDocumentInfo(), getListViewLayoutGroup():
1399 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1401 * src/main/java/org/glom/web/server/database/DBAccess.java
1402 getFieldsToShowForSQLQueryAddGroup(),
1403 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1404 with either get_database_title_original() or
1405 get_database_title(localeID).
1407 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1409 ConfiguredDocument: Avoid a null pointer exception.
1411 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1412 Initialize localeID to "" to avoid returning a null String which
1413 causes a crash in java-libglom's swing-generated code.
1415 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1417 Some simple renaming.
1419 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1420 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1421 for localeChooser. This seems more appropriate and is less ambiguous
1422 particularly in the .css file.
1424 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1426 ConfiguredDocument: Rename the localedID private member variable.
1428 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1430 Adapt to the latest java-libglom API from git master.
1432 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1433 libglom now uses only Vector instead of List, which uses add() instead of
1436 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1438 ConfiguredDocument: Rename the localedID private member variable.
1440 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1442 Build a source tarball with mvn assembly:single
1444 * assembly.xml: Add this file.
1445 * pom.xml: Use the maven-assembly-plugin and tell it to use
1446 our assembly.xml file.
1448 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1450 OnlineGlomServiceImpl: Get .glom files recursively.
1452 * pom.xml: Depend on commons-io from org.apache.commons.
1453 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1454 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1455 files recursively, and with the easier filter for the extension.
1456 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1457 simplify that code too.
1459 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1461 README: Mention that you must install java-libglom packages separately.
1463 But then it works, because java-libglom is now in the central maven
1466 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1468 locales drop-down: Show the correct selected locale when the URL changes.
1470 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1471 .java: setPlace(): Move some code into fillView().
1473 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1475 locales drop-down: Do not lose the primary key.
1477 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1478 start(): onLocaleChange(): Pass the current primary key value,
1479 instead of an empty value.
1481 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1483 locales drop-down: Do not lose the drop-down selection.
1485 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1486 .java (TableSelectionActivity.fillView): Set the selected locale
1487 after changing the drop-down items (though we do not really need
1488 to change them just because the locale changes.)
1490 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1492 locales drop-down: Change the tables list when this changes.
1494 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1495 .java: TableSelectionActivity.start(): Move the async table titles
1496 retrieval into a private fillView() method and also call this when
1497 the chosen locale changes.
1498 Note that the document title is not actually translatable yet, but
1499 that is a problem that I should fix soon in libglom.
1501 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1503 Improve the placement of the locales drop-down.
1505 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1506 Put the title and locales drop-down in a div (gwt.FlowTable).
1507 * src/main/webapp/style.css: Add magic css properties to make this work.
1508 Also remove the left margin from the title so that it lines up with the
1511 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1513 locales selector: Show human-readable locale titles.
1515 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1516 getDocumentInfo(): Use java.util.Locale to show a real title of
1517 each locale, in the locale's own language.
1519 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1521 Add a language/locale selector drop-down.
1523 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1524 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1525 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1526 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1527 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1528 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1529 Add a ListBox to show the available locales. Add getLocaleSelector(),
1530 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1531 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1532 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1533 java: Add these classes.
1534 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1535 start(): Fill the locales ListBox. Handle its change event, firing a
1537 setPlace(): Show the selected locale as specified by the URL token.
1538 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1539 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1540 Handle LocaleChangeEvent, going to a new *Place with that locale.
1542 The placement of the ListBox is not pretty, and it currently uses the ID
1543 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1547 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1549 Search box: Show the search text from the URL token.
1551 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1552 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1553 Add setQuickFindText().
1554 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1555 .java: setPlace(): Store the queryText if the place is a ListPlace,
1556 and call TableSelectionView.setQuickFindText().
1558 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1560 Allow use of translations via, for instance, &lang=de in the URL.
1562 * pom.xml: Use the unstable java-libglom 1.21 version.
1564 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1565 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1566 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1567 init(): Instead of calling TranslatableItem.set_current_locale()
1568 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1569 However, this is only for default locales, which are not needed to
1570 change the locale in the URL.
1571 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1572 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1573 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1574 layout for a particular locale.
1575 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1576 Add get/setDefaultLocaleID().
1577 getDocumentInfo(), getListViewData(), getRelatedListData(),
1578 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1579 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1580 localeID parameter, so we can get the layout for a particular locale.
1582 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1583 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1584 * src/main/java/org/glom/web/client/place/ListPlace.java:
1585 Parse and construct a lang parameter too.
1587 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1588 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1589 passed to subsequent methods and constructors.
1590 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1591 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1592 Store the localeID from the *Place and pass it to other constructors
1593 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1595 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1596 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1597 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1598 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1599 * src/main/java/org/glom/web/client/ui/ListView.java:
1600 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1601 Take localeID parameters and pass them to subsequent constructors and
1602 methods, so that the layout is always retrieved for that locale.
1604 This is rather repetitive.
1606 Note that "" means the original (default) locale of the Glom document,
1607 which is usually English.
1609 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1611 Documents: Remove final keyword to fix startup configuration.
1613 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1614 final keywords on the private member variables because that breaks
1615 the startup, apparently (there are warnings) because it stops them
1616 from being serialized. I added these in the previous commit.
1618 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1620 Documents: Add some final keywords.
1622 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1625 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1627 OnlineGlomServiceImpl: Add to overview comments.
1629 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1630 Note that this is where all the document are loaded. They are not
1631 loaded freshly for each page.
1633 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1637 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1638 Add a TextBox for the text of a quick find.
1639 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1641 setBackLink(): Add a String quickFind parameter.
1642 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1643 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1644 to the base interface, because that is how TableSelectionViewImpl is used.
1645 * src/main/webapp/style.css: Add style for the search box and its label.
1647 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1648 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1649 Add these files, based on the existing TableChangeEvent and
1650 TableChangeEventHandlers.
1651 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1652 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1653 a ListPlace() that the user should be taken to.
1654 * src/main/java/org/glom/web/client/activity/ListActivity.java
1655 start(): Handle it here too and adapt the TableChangeEvent handler to
1656 pass the extra "" quickFind parameter to ListPlace.
1657 * src/main/java/org/glom/web/client/place/ListPlace.java:
1658 Constructor: Take an extra String quickFind parameter and store it,
1659 returning it from a new getQuickFind() method.
1660 getToken(): Put the quickFind text in the URL token.
1661 getPlace(): Parse the quickFind text from the URL token.
1662 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1663 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1664 ListPlace constructor.
1665 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1666 .java: start(): Add a Change handler for the TableSelectionView's
1667 TextBox (via its base HasChangeHandlers interface), firing the new
1668 QuickFindChangeEvent.
1669 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1670 pass the extra "" quickFind parameter.
1672 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1673 setCellTable(): Add a String quickFind parameter and pass it to
1674 the ListViewTable() constructor.
1675 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1676 setCellTable() in the base interface, because that is how ListViewImpl
1679 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1680 Add a String quickFind member variable.
1681 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1682 Constructor: Add a String quickFind parameter, storing it in the
1683 base ListTable's member variable.
1684 onRangeChanged(): Pass quickFind to the
1685 OnlineGlomServiceAsync.getSortedListViewData() and
1686 OnlineGlomServiceAsync.getListViewData() methods.
1688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1689 getListViewData(), getSortedListViewData(): Add a String quickFind
1690 parameter, passing it to ConfiguredDocument.getListViewData().
1691 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1692 Change getListViewData(), getSortedListViewData() in the base interface,
1693 because that is how OnlineGlomServiceImpl is used, via this:
1694 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1695 Change getListViewData(), getSortedListViewData() here too.
1696 This class can apparently be used to asynchronously call methods on
1697 OnlineGlomService, and GWT seems to implement that after recognizing
1698 just the *Async name convention and the extra AsyncCallback parameters.
1700 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1701 getListViewData(): Add a String quickFind parameter, and pass it to
1702 ListViewDBAccess.getData().
1703 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1704 getListData(): Add a String quickFind parameter and pass it to
1706 getSelectQuery(): Add a String quickFind parameter.
1707 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1708 getSelectQuery(): Add a String quickFind parameter and use it with
1709 Glom.get_find_where_clause_quick() to pass a where_clause to
1710 Glom.build_sql_select_with_where_clause(), to actually filter the
1712 getData(): Add a String quickFind parameter, passing it to getListData().
1713 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1714 va: getData(): Pass an empty string to getListData() for the
1715 quickFind parameter.
1717 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1719 ListTable: Minor change.
1721 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1722 createCellTable(): Make this protected instead of public.
1724 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1726 Many files: Use final for the parameters and use the @override attribute.
1728 2012-01-22 Ben Konrath <ben@bagu.org>
1730 Add anchor links for single line text that starts with http, ftp and www.
1734 2012-01-22 Ben Konrath <ben@bagu.org>
1736 Add ellipsis to single line text in details view.
1740 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1742 Remove all javadoc author tags.
1744 Because they are awkward and meaningless when many people touch
1746 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1748 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1750 Revert the COPYING.LESSER to COPYING rename.
1752 Apparently both should be there if it is LGPL.
1754 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1756 *View: Remove unused imports.
1758 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1759 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1760 * src/main/java/org/glom/web/client/ui/ListView.java:
1761 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1762 Remove unused imports, as suggested by Eclipse.
1764 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1766 Move the *View::Presenter types, and some API into one base View.
1768 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1769 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1770 * src/main/java/org/glom/web/client/ui/ListView.java:
1771 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1772 Presenter, setPresenter() and clear() into a shared base interface,
1773 to avoid the unnecessary duplicate Presenter types and to more clearly
1774 show how the *Views share the same structure, even if they are not
1775 used polymorphically.
1777 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1778 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1780 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1781 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1782 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1784 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1787 Feel free to revert this if there is a good reason for the duplicate
1790 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1792 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1794 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1795 a class member instead of a local variable in the method.
1796 This lets us use it to get the view instances, for use in tests.
1797 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1798 beforeOnlineGlom(): Test some more details of the initial view.
1799 Again, this is not very useful.
1801 To really test gwt-glom we will need to start a local postgresql
1802 instance with local data, like the Glom tests in C++.
1804 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1806 pom.xml: Mention the LGPL license.
1808 * pom.xml: Add a licenses section.
1809 * COPYING.LESSER: Move this to COPYING, which
1810 previously contained the GPL. But gwt-glom is all LGPL.
1812 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1814 Add project information to README and pom.xml.
1816 * README: Add a brief description and mention some mvn
1818 * pom.xml: This extra information shows up in mvn site
1821 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1823 Use the latest java-libglom version.
1825 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1827 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1829 GwtTestOnlineGlom: Test a little more.
1831 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1832 protected rather than private, as suggested by the gwt-test-utils
1834 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1835 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1836 Test the initial visibility of the panels.
1838 However, this is not a very useful test.
1839 And I wonder how we should generally test using this idea for an
1840 activity/places app like ours where the real changes happen implicitly
1841 based on the history token/URL.
1843 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1845 Slight modification to *Mapper comments.
1847 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1848 (DataActivityMapper)
1849 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1851 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1853 Remove comments mentioning GIN because they are just copied from
1854 the example code and are apparently not helpful:
1855 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1856 Also change the mention of a class that is only in the example code.
1858 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1860 GwtTestOnlineGlom test: Minor changes.
1862 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1863 Avoid the long qualified class name and modify the comment
1864 because it is now obvious to me that the mocked class is the only
1865 custom one created via GWT.create().
1867 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1869 Tests: Added the beginnings of a test using gwt-test-utils.
1871 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1872 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1873 which tells gwt-test-utils what class will be tested.
1874 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1875 Add a simple (but empty) test case. One class, used by the OnlineGlom
1876 class, is mocked so that it can be created. However, I am not sure
1877 why only this class needs to be mocked.
1879 Note that mockito seems more popular, and clearer, than easymock,
1880 but I have not got that working yet. It might be a matter of the
1883 This test is run during mvn integration-test.
1885 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1887 Tests: Use junit4-style syntax instead of junit3-style.
1889 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1890 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1891 * src/test/java/org/glom/web/shared/DataItemTest.java:
1892 Use the @Test annotation rather than relying on the test*() prefix.
1893 Also no longer implement TestCase, to avoid triggering support for
1894 the junit3-way, which stops the annotations from working.
1895 Change the imports from import junit.framework.* to
1896 import org.junit.*, which is apparently the new way.
1898 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1900 Added a test for ListPlace token parsing and creation.
1902 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1903 This is much the same as DetailsPlaceTest.
1905 I wonder how we could test the other parts of the *Place API.
1907 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1909 DetailsPlace test: Also test getToken() and recreation via getPlace().
1911 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1912 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1913 recreate it, testing the recreated DetailsPlace for the same parameter
1916 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1918 Use the surefire-report plugin.
1920 * pom.xml: This generates a HTML report about the tests in
1921 target/site/surefire-report.html
1922 when you do mvn surefire-report:report. It seems to be popular/normal.
1924 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1926 Added a test for DetailsPlace.
1928 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1929 Test the getPlace() token parsing.
1931 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1933 Added a first unit test.
1935 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1936 * src/test/java/org/glom/web/shared/DataItemTest.java:
1937 This is a silly test but it is just to get things started. Note that
1938 maven/junit finds the test because it looks in src/test by default.
1940 2011-12-22 Ben Konrath <ben@bagu.org>
1942 Change charsetName to "UTF-8" when replacing line breaks.
1944 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1945 that work in Java (such as "UTF8") will not work when compiled to
1948 This fixes a problem with multi-line details view fields that have hard
1949 line breaks. The "License Text" field on this page demonstrates the
1952 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1954 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1956 2011-12-22 Ben Konrath <ben@bagu.org>
1958 Fix another bug with related list navigation.
1960 I've tested all the navigation buttons in all of the related lists
1961 so things should be good now.
1963 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1965 2011-12-22 Ben Konrath <ben@bagu.org>
1967 Fix a crasher when refreshing the list view with the default table.
1969 This crash will also happen when loading the list view with the default
1970 table from a link or bookmark.
1972 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1973 to the main document selection page when the document id hasn't been
1975 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1976 the main document selection page when the document id hasn't been
1978 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1979 values for the details place when the document id hasn't been set.
1980 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1981 values for the list place when the document id hasn't been set.
1983 2011-12-21 Ben Konrath <ben@bagu.org>
1985 Protect against NPE when glom.document.locale is not in config.
1987 This patch protects against an NPE when glom.document.locale is not in
1988 the config file. This NPE will also happen if glom.document.locale is
1991 The patch also updates the error message to display the class name when
1992 the getMessage() returns null. This was happening when the NPE was
1993 thrown and I had "Configuration Error: null". If an NPE is encountered
1994 with this patch, "Configuration Error: NullPointerException " will be
1997 This commit closes this bug:
1999 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2001 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2003 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2005 Rename onlineglom.properties to onlineglom.properties.sample.
2007 * src/main/resources/onlineglom.properties: Rename to:
2008 * src/main/resources/onlineglom.properties.sample:
2009 * src/main/resources/README: And add this file explaining that people
2010 should rename it back when deploying.
2012 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2014 Allow choosing the translation in the .properties file.
2016 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2017 init(): Read a glom.document.locale value from the configuration file
2018 and call Glom's TransatableItem::set_current_locale() method.
2019 * src/main/resources/onlineglom.properties: Add a commented-out
2020 example of this new setting.
2022 It would be better to add &lang=de_DE to the URL, but the current
2023 libglom API does not allow us to do this easily. I am working on that.
2025 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2027 Avoid a crash in parsing of token parameters.
2029 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2030 ava: getTokenParams(): Do not crash if a parameter has a key but no
2031 value, and ignore parameters with neither.
2033 2011-12-17 Murray Cumming <murrayc@murayc.com>
2035 History token building/handling: Improve use of token parameters.
2037 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2038 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2039 and buildParamsToken(HashMap), for use by derived classes.
2040 Make the separator private because it is no longer be needed.
2041 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2042 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2043 instead of manual string concatenation.
2044 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2045 of hardcoded indices and awkward splitting code.
2046 * src/main/java/org/glom/web/client/place/ListPlace.java
2047 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2048 instead of manual string concatenation.
2049 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2050 of hardcoded indices and awkward splitting code.
2051 This should fix bug #666420
2053 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2055 Fix a Navgiation->Navigation typo in the code.
2057 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2058 Rename processNavgiation() to processNavigation().
2060 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2062 Fix a seperator->separator typo in the code.
2064 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2065 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2066 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2069 2011-12-15 Ben Konrath <ben@bagu.org>
2071 Cleanup some comments.
2073 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2075 2011-12-14 Ben Konrath <ben@bagu.org>
2077 Replace \n with <br/> for multiline text in the details view.
2079 Vertical scrollbars are added when needed as well.
2081 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2083 2011-12-14 Ben Konrath <ben@bagu.org>
2085 Specify the font for document selection links.
2087 * src/main/webapp/style.css:
2089 2011-12-14 Ben Konrath <ben@bagu.org>
2091 Fix bouncy CellTable while paging.
2093 This doesn't currently work with related list tables in unselected
2096 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2098 2011-12-14 Ben Konrath <ben@bagu.org>
2100 Revamp the appearance of the document selection page.
2102 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2103 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2104 * src/main/webapp/style.css:
2106 2011-12-13 Ben Konrath <ben@bagu.org>
2108 Set navigation button column to the smallest size possible.
2110 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2112 2011-12-13 Ben Konrath <ben@bagu.org>
2114 Change OpenButton nomenclature to NavigationButton.
2116 Using NavigtionButton makes things more generic. Classes, methods and
2117 variables have been changed.
2119 This is a rename-only refactor.
2121 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2122 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2123 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2124 Renamed from OpenButtonCell.
2125 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2126 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2127 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2129 2011-12-12 Ben Konrath <ben@bagu.org>
2131 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2134 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2135 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2136 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2138 2011-12-12 Ben Konrath <ben@bagu.org>
2140 Update variable names and comments.
2142 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2143 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2145 2011-12-12 Ben Konrath <ben@bagu.org>
2147 Properly initialize numNonEmptyRows variable to zero.
2149 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2150 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2152 2011-12-05 Ben Konrath <ben@bagu.org>
2154 Add latest mockup with HTML tables.
2156 Features of this mockup:
2158 -> HTML table for flowtable
2159 -> HTML table for flowtable column
2160 -> Example of how related lists would look
2161 -> Not using text entries for data items
2163 The current version of Online Glom doesn't use HTML tables for the
2166 This mockup has been sent to the glom-devel mailing list but it's good
2167 to have it here as well.
2169 * mockups/details-view-html-tables.html:
2171 2011-12-05 Ben Konrath <ben@bagu.org>
2173 Remove unnecessary getPrimaryKeyField() method.
2175 getPrimaryKeyFieldForTable(String) has been renamed to
2176 getPrimaryKeyField(String).
2178 * src/main/java/org/glom/web/server/database/DBAccess.java:
2179 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2180 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2182 2011-12-05 Ben Konrath <ben@bagu.org>
2184 Add string representation of TypedDataItem value to conversion error message.
2186 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2187 message was extracted into its own method to avoid duplication.
2189 2011-12-05 Ben Konrath <ben@bagu.org>
2191 Add type checking to navigation primary key value creation.
2193 Create navigation primary key only if the expected type from the Glom
2194 document matches the type returned by the SQL query.
2196 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2198 2011-12-05 Ben Konrath <ben@bagu.org>
2200 Rename a couple of variables in RelatedListNavigation.
2202 This is a rename-only refactor.
2204 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2206 2011-12-05 Ben Konrath <ben@bagu.org>
2208 Move getListLayoutGroup() into getListViewLayoutGroup().
2210 This removes getListLayoutGroup(). It was only being called by
2211 getListViewLayoutGroup().
2213 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2215 2011-12-05 Ben Konrath <ben@bagu.org>
2217 Remove check for LayoutItem_Portal in list table method.
2219 This check is no longer necessary because the method isn't being used
2220 to create the LayoutItemPortal DTO.
2222 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2224 2011-12-05 Ben Konrath <ben@bagu.org>
2226 Properly support related list navigation.
2228 Navigation from the "Repository Analyzer -> Package Scans ->
2229 Dependencies" related table wasn't working because the primary key for
2230 related tables wasn't being set properly. This commit fixes the
2233 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2234 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2235 doesn't set the primary key properly for related list tables.
2236 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2237 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2238 useful for getting the primary key for list view tables and for related
2240 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2241 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2242 Move code to set the primary key for the table from the abstract
2243 ListDBAccess class to ListViewDBAccess as it's only correct for list
2245 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2246 Properly add primary key to related list tables.
2248 2011-12-02 Ben Konrath <ben@bagu.org>
2250 Properly set the horizontal alignment of fields.
2252 This fix is for both the list tables and the details view.
2254 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2255 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2256 to set the horizontal alignment of fields.
2258 2011-12-02 Ben Konrath <ben@bagu.org>
2260 Display currency codes in the details view.
2262 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2264 2011-12-02 Ben Konrath <ben@bagu.org>
2266 Avoid duplicate JNI call.
2268 JNI is not as efficient as pure Java and this is an easy (and small)
2271 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2272 Use previously retrieved value for whereClauseToTableName instead of
2275 2011-12-02 Ben Konrath <ben@bagu.org>
2277 Rename a couple of variables in RelatedListNavigation.
2279 This is a rename-only refactor.
2281 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2283 2011-12-02 Ben Konrath <ben@bagu.org>
2285 Indicate clearly that a mismatched primary key type is a bug.
2287 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2288 warning to error. Add 'This is a bug.' to message.
2290 2011-12-02 Ben Konrath <ben@bagu.org>
2292 Update / fix some comments.
2294 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2296 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2298 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2299 Fix comments. Add some TODOs.
2301 2011-12-02 Ben Konrath <ben@bagu.org>
2303 Enable navigation to details view with string primary key from related list.
2305 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2306 Create a text primary key value when return type of result is
2307 java.sql.Types.VARCHAR.
2309 2011-12-02 Ben Konrath <ben@bagu.org>
2311 Use checkboxes for booleans in the details view.
2313 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2315 2011-12-01 Ben Konrath <ben@bagu.org>
2317 Improve performance of related list height calculation.
2319 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2320 Put code to calculate the expected height in a static initializer so
2321 that that it's only called once.
2323 2011-12-01 Ben Konrath <ben@bagu.org>
2325 Show related list tables in notebooks (again).
2327 Calculate the height of the related list tables so the Notebook can be
2328 set the correct height. The height of the related list table is also needed by
2329 FlowTable to be able decide how to create the layout.
2331 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2332 and set the Portal height based on the height of the related list
2333 table and the Portal container.
2334 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2335 Add method to calculate the height of the related list tables.
2336 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2337 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2338 calculate the height of the Pager widget.
2340 2011-12-01 Ben Konrath <ben@bagu.org>
2342 Use CellTable API for table property instead of setting style on Element.
2344 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2346 2011-12-01 Ben Konrath <ben@bagu.org>
2348 Make ListViewTable and RelatedListTable a consistent height.
2350 The tables are now a consistent height regardless of the contents of
2351 the table. A hidden button is added to empty rows to ensure that the
2352 height of these rows will match the height of rows with data.
2354 A navigation button column is now added to every table. The width of
2355 the navigation column is set to 0px when a RelatedListTable shouldn't
2356 have navigation buttons. This maintains the a consistent row height in
2357 tables that don't show the navigation buttons.
2359 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2360 navigation column when not needed.
2361 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2362 arguments for navigation button to constructor of ListViewTable.
2363 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2364 hidden button for empty data rows.
2365 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2366 arguments for navigation button to constructor.
2367 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2368 create navigation buttons. Add hideNavigationButtons() method.
2369 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2370 arguments for navigation button to constructor.
2372 2011-12-01 Ben Konrath <ben@bagu.org>
2374 Use 'visibility: hidden' in Utils.getWidgetHeight().
2376 This is better choice because hidden elements are invisible, don't
2377 respond to events and are not part of the tab order. They will,
2378 however, take up space which is required to be able to calculate the
2379 height of the widget.
2381 * src/main/java/org/glom/web/client/Utils.java:
2383 2011-12-01 Ben Konrath <ben@bagu.org>
2385 Use Utils.getWidgetHeight() in FlowTable.
2387 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2389 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2391 2011-12-01 Ben Konrath <ben@bagu.org>
2393 Put the details css class name on the correct table column.
2395 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2397 2011-11-30 Ben Konrath <ben@bagu.org>
2399 Update for java-libglom API change.
2401 The getters and setters on FieldFormatting and NumericFormat were
2402 changed to remove the 'M'.
2404 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2406 2011-11-29 Ben Konrath <ben@bagu.org>
2408 Only allow RelatedListTables in Portals.
2410 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2412 2011-11-29 Ben Konrath <ben@bagu.org>
2414 Only create a contents panel for Portals when title is being set.
2416 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2418 2011-11-29 Ben Konrath <ben@bagu.org>
2420 Set TabLayoutPanel height based on calculated height its widgets.
2422 This is a potential fix for this bug:
2424 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2426 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2428 2011-11-29 Ben Konrath <ben@bagu.org>
2430 Align details field labels and data with the Open buttons.
2432 * src/main/webapp/style.css:
2434 2011-11-29 Ben Konrath <ben@bagu.org>
2436 Remove unnecessary <div> in the Notebook widget.
2438 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2439 method to get container FlowPanel (<div>).
2440 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2441 initWidget() method directly on the TabLayoutPanel widget instead of
2442 Group's container widget.
2444 2011-11-29 Ben Konrath <ben@bagu.org>
2446 Don't add group titles for Portals in Notebooks.
2448 This reverts the previous patch and fixes a bug I introduced with
2449 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2451 * src/main/java/org/glom/web/client/ui/details/Group.java:
2452 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2454 2011-11-28 Ben Konrath <ben@bagu.org>
2456 Remove unused boolean argument in Portal constructor.
2458 Just a code cleanup.
2460 * src/main/java/org/glom/web/client/ui/details/Group.java:
2461 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2463 2011-11-28 Ben Konrath <ben@bagu.org>
2465 Remove hack for glom 1.18 style glom files.
2467 * src/main/java/org/glom/web/client/ui/details/Group.java:
2468 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2469 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2471 2011-11-28 Ben Konrath <ben@bagu.org>
2473 Use Gda Value version of primary key to log result too large error.
2475 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2477 2011-11-28 Ben Konrath <ben@bagu.org>
2479 Don't use TypedDataItem.getText() for Unknown types from the URL.
2481 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2482 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2483 instead of getText().
2484 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2485 String field and getUnknown() method.
2487 2011-11-28 Ben Konrath <ben@bagu.org>
2489 Log an error message when the java-libglom .so is not present.
2491 The error message was being set in the exception but not logged.
2493 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2495 2011-11-28 Ben Konrath <ben@bagu.org>
2497 Ignore LayoutItem_CalendarPortals.
2499 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2500 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2502 2011-11-28 Ben Konrath <ben@bagu.org>
2504 Extract method for creating the LayoutItemPortal DTO.
2506 Just breaking the code up into smaller chunks.
2508 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2510 2011-11-28 Ben Konrath <ben@bagu.org>
2514 This should have been added with the refactor. Oops!
2516 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2518 2011-11-28 Ben Konrath <ben@bagu.org>
2520 Create primary key value from URL string using type from Glom document.
2522 See this bug, comments 19 - 25:
2524 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2526 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2527 create a TypeDataItem for the primary key here when loading from a
2528 URL. Show the same string for the primary key value as was received
2529 from the URL string (when loading from a URL).
2530 * src/main/java/org/glom/web/server/Utils.java: Update method for
2531 creating the Gda Value from the TypeDataItem to properly deal with
2532 creating a Gda Value based on the Glom document type for the primary
2533 key value string when loading from a URL.
2534 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2535 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2536 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2537 Update for changed method name.
2539 2011-11-27 Ben Konrath <ben@bagu.org>
2541 Rename PrimaryKeyItem to TypedDataItem.
2543 The name PrimaryKeyItem suggests what the class should be used for.
2544 TypedDataItem is a neutral name that describes the class better.
2546 This is a rename-only refactor.
2548 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2549 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2550 * src/main/java/org/glom/web/client/Utils.java:
2551 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2552 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2553 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2554 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2555 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2556 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2557 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2558 * src/main/java/org/glom/web/server/Utils.java:
2559 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2560 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2561 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2562 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2564 2011-11-25 Ben Konrath <ben@bagu.org>
2566 Improve Gda Value conversion from PrimaryKeyItem.
2568 The value from the PrimaryKeyItem is only used if its type match the
2569 type from the glom document.
2571 * src/main/java/org/glom/web/server/Utils.java:
2573 2011-11-25 Ben Konrath <ben@bagu.org>
2575 Manually check if the java-liblgom .so is visible to the JVM.
2577 It seems that Tomcat has problems when a static initializer throws an
2578 exception. This check is done before the first method call into
2579 java-libglom so that execution doesn't continue if the .so is not
2582 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2584 2011-11-25 Ben Konrath <ben@bagu.org>
2586 Improve browser configuration error messages.
2590 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2592 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2593 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2594 getConfigurationErrorMessage() method.
2595 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2596 Get and display a specific configuration error message when no Glom
2597 documents are found.
2598 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2599 Implement getConfigurationErrorMessage() method. Surround configuration
2600 code in the init() method with a try/catch block. This allows the
2601 errors to be caught while keeping the servlet available to retrieve the
2602 configuration error message.
2604 2011-11-25 Ben Konrath <ben@bagu.org>
2606 Don't use Strings to hold primary key values.
2608 The primary key values are now held in a new data object
2609 (PrimaryKeyItem) that holds type information and the primary key value
2610 using the correct type.
2612 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2613 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2614 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2615 PrimaryKeyItem instead of String to hold the primary key value.
2616 * src/main/java/org/glom/web/client/Utils.java: Remove
2617 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2618 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2619 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2620 PrimaryKeyItem instead of String to hold the primary key value. Load
2621 document selection page when the documentID has not been set correctly.
2622 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2623 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2625 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2626 Return empty string for URL instead of "null".
2627 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2628 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2629 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2630 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2631 PrimaryKeyItem instead of String to hold primary key values.
2632 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2633 PrimaryKeyValue to a Gda Value.
2634 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2635 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2636 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2637 Replace temporary database access code that uses the PrimaryKeyValue to
2638 Gda Value conversion.
2639 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2640 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2641 PrimaryKeyItem instead of String.
2642 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2643 hold primary key values.
2645 2011-11-24 Ben Konrath <ben@bagu.org>
2647 Use newly added java-libglom API to create queries.
2649 This isn't finished. I still need to stop using Strings for primary key
2650 values in the client code.
2652 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2653 libglom to use fake connections so that retrieving the query string will
2655 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2656 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2657 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2658 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2659 Use the newly added libglom sql methods and classes to create the
2660 query. Add temporary hack to convert primary value strings to Gda
2663 2011-11-23 Ben Konrath <ben@bagu.org>
2665 Don't explicitly set the height of Portals.
2667 See comments 6 - 10 of this bug for details:
2669 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2671 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2673 2011-11-23 Ben Konrath <ben@bagu.org>
2675 Use an HTML table instead of CSS for the FlowTable layout.
2677 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2678 GWT's FlexTable to implement the FlowTable.
2679 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2681 2011-11-18 Ben Konrath <ben@bagu.org>
2683 Add boolean example to HTML table mockup.
2685 * mockups/details-view-html-tables-text-entries.html:
2687 2011-11-17 Ben Konrath <ben@bagu.org>
2689 Ensure the pager buttons are always visible for related lists.
2691 To accomplish this, I've turned off text wrapping in the list view and
2692 related list tables for both the header and data text. The related list
2693 table now has a fixed layout so the it doesn't overflow its container.
2694 This is required to ensure that the cell text is clipped when it
2695 overflows the cell and an ellipsis is added to the right side of the
2696 cell when text is clipped.
2698 A fixed table layout for the related list table in the details view
2699 seems what we want for the details view anyway, so the side-effect is
2702 The ellipsis will only be displayed in Firefox >= 7.
2706 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2708 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2709 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2710 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2712 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2713 Set the 'table-layout: fixed' CSS property to the related list table.
2714 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2715 'white-space: nowrap;' CSS property on both the list view and the
2716 related list tables.
2718 2011-11-16 Ben Konrath <ben@bagu.org>
2720 Rework the fix for empty notebook tab labels.
2722 Setting the empty group titles with its name caused problems for the
2723 details layout. Instead of using libglom's
2724 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2725 to the client when the title is empty. This allows the Notebook to use
2726 the name when the title is empty without affecting anything else.
2728 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2729 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2731 2011-11-16 Ben Konrath <ben@bagu.org>
2733 Set group titles with name when title is empty.
2735 This fixes a problem with an empty notebook tab label in the Lesson
2736 Planner document. The forth tab in the notebook should be "Internet":
2738 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2740 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2741 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2744 2011-11-16 Ben Konrath <ben@bagu.org>
2746 Remove whitespace from the configured username properties.
2748 This assumes that usernames won't have whitespace at the beginning
2749 or end. But I think this is a reasonable assumption.
2751 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2752 String.trim() to remove the whitespace from the username properties.
2754 2011-11-15 Ben Konrath <ben@bagu.org>
2756 Add details view mockup with HTML tables and text entries.
2758 This is from the attachment on this bug:
2760 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2762 * mockups/details-view-html-tables-text-entries.html:
2764 2011-11-15 Ben Konrath <ben@bagu.org>
2766 Add space between the columns of the flow table.
2770 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2772 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2773 space between columns in the flow table.
2775 2011-11-15 Ben Konrath <ben@bagu.org>
2777 Add backup files to the .gitignore.
2779 * .gitignore: Ignore files that end with ~.
2781 2011-11-09 Ben Konrath <ben@bagu.org>
2783 Use latest release of gwt-log.
2785 Gwt-log releases are now being submitted to the maven central
2786 repository so manual installation of the jar is no longer required.
2788 * pom.xml: Update version and groupId of gwt-log dependency.
2790 2011-10-31 Ben Konrath <ben@bagu.org>
2792 Don't use GWT numeric formatting to override the glom currency formatting.
2794 Currencies are now displayed like they are in Glom. See this bug:
2796 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2798 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2800 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2801 currency code to constructor and set it when the cell is rendered.
2802 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2803 currency code to the constructor of the NumericCell.
2805 2011-10-27 Ben Konrath <ben@bagu.org>
2807 Require the latest release of java-libglom (1.17.4).
2811 2011-10-26 Ben Konrath <ben@bagu.org>
2813 Add style to Notebook that matches current theme.
2815 It's not the best style in the world but it's better than the default.
2817 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2818 padding at the bottom of the child widgets.
2819 * src/main/webapp/style.css: Add style for the Notebook.
2821 2011-10-26 Ben Konrath <ben@bagu.org>
2823 Move servlet initialization code to overridden init method.
2825 This is half of the solution to getting proper error messages
2826 displayed when configuration errors occur. Here's the relevant bug:
2828 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2830 The rest of the solution involves surrounding the init method with a
2831 try/catch block and setting a global variable with the error /
2832 exception. A new async method should be created to retrieve and display
2833 the error message / exception.
2835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2836 code from constructor to init method adding exceptions as needed.
2838 2011-10-26 Ben Konrath <ben@bagu.org>
2840 Add script to monitor and restart tomcat if required.
2842 * utils/check-and-recover-tomcat.py: New file.
2844 2011-10-26 Ben Konrath <ben@bagu.org>
2846 Display the correct number of data items in the pager.
2850 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2852 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2853 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2854 The implementation is the same for both tables: Keep track of the
2855 number of non-empty rows and fire and RowCountChangeEvent after the data has
2857 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2858 custom Pager class that subclasses SimplePager to handle displaying
2859 the correct number when empty rows have been added.
2861 2011-10-26 Ben Konrath <ben@bagu.org>
2863 Correct error in previous commit.
2865 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2866 eventBus parameter from listView.setCellTable().
2868 2011-10-26 Ben Konrath <ben@bagu.org>
2870 Fix error in TODO comment.
2872 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2874 2011-10-24 Ben Konrath <ben@bagu.org>
2876 Create Notebook widgets to the details view.
2878 This isn't finished just yet - I still need to create a reasonable
2879 style to match the current theme.
2881 * src/main/java/org/glom/web/client/Utils.java: Add method for
2882 calculating the height of a widget. This is used in the Notebook class.
2883 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2884 new constructor method in Group.
2885 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2886 method for creating child widget that can be used by subclasses
2887 like Notebook. New constructor that allows disabling the group
2888 titles - Notebooks don't set a group title for their child groups.
2889 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2890 to make Notebooks using GWT's TabLayoutPanel.
2891 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2892 constructor that allows disabling the group titles.
2893 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2894 LayoutItemNotebook DTO.
2895 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2896 DTO for Notebooks. It's just an empty class for now but we might need
2897 it to transfer some specific information in the future.
2899 2011-10-21 Ben Konrath <ben@bagu.org>
2901 Add navigation buttons to related list tables.
2903 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2904 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2906 method getSuitableRecordToViewDetails() for getting the table name
2907 and primary key value for related list navigation buttons.
2908 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2909 private cell renderer class to get the navigation information for
2910 related list tables from the server. Extract the navigation
2911 processing code from the details cell navigation and use it for the
2912 related list navigation as well.
2913 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2914 cell renderer class for the details open buttons. This was needed
2915 because the related list navigation buttons and the list view
2916 navigation buttons need to react differently when clicked.
2917 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2918 the onEnterKeyDown() method because it's now overriden in the
2919 subclasses that are specific to the related list tables and the list
2921 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2922 the vertical size a little because the buttons add a bit of vertical
2923 space to table. This is not a perfect solution because the vertical
2924 size of with table fewer than 5 rows will be a little smaller.
2925 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2926 changes in how navigation buttons are handled.
2927 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2928 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2929 database access object.
2930 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2931 to find the portal for a given relationship name from
2932 RelatedListDBAccess. Add method to find a primary key field for a
2934 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2935 Move code to find the portal for a given relationship name to
2937 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2938 New file: database access object for getting the related list
2939 navigation information (the table name and the primary key value).
2940 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2941 DTO for transferring a table name to navigate to and a primary key
2943 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2944 boolean and getter/setter to specifies if the related list should add
2947 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2949 Use the master branch of java-libglom
2951 * pom.xml: Depend on java-libglom 1.19 instead.
2953 This is the master branch. See also the libglom-1-18 branch.
2955 2011-10-11 Ben Konrath <ben@bagu.org>
2957 Enable the open navigation button when the data has been set.
2959 This avoids having active buttons that don't do anything when the data
2962 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2964 2011-10-11 Ben Konrath <ben@bagu.org>
2966 Use IsWidget interface for FlowTableItem.
2968 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2969 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2971 2011-10-11 Ben Konrath <ben@bagu.org>
2973 Remove GWT styling from open button in details view.
2975 There are still some issues with how the details cell is arranged but
2976 this should be made to match Glom 1.20. I'm going to leave fixing this
2977 until I have Glom 1.20 up and running.
2979 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2980 style name on open button.
2981 * src/main/webapp/style.css: Move and edit details-navigation class.
2982 Re-arrange some classes to make them appear in the same order as the
2985 2011-10-07 Ben Konrath <ben@bagu.org>
2987 Update to GWT 2.4.0.
2989 * .gitignore: Ignore new cache directory.
2990 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2991 * pom.xml: Change GWT and maven plugin to 2.4.0.
2992 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2994 * src/main/java/org/glom/web/client/ClientFactory.java:
2995 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2996 * src/main/java/org/glom/web/client/OnlineGlom.java:
2997 Update source for API changes.
2998 * utils/build-onlineglom-war.sh: Remove cache directory before the
3001 2011-10-07 Ben Konrath <ben@bagu.org>
3003 Add navigation buttons in the details view.
3005 This isn't finished but I thought I'd commit what I have as it's a
3006 pretty good start. I still need to:
3008 1. Change the style so that it fits better into the current theme
3009 2. Adjust the details cell to expand as much as possible.
3011 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3012 click handlers to navigation buttons in the DetailsCells. Create a
3013 refreshData() method to get just the data from the server without the
3015 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3016 Update the tableSelector and browser title when the table name
3017 changes without using the tableSelector.
3018 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3019 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3020 getDetailsCells() to getCells(). Update variable names.
3021 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3022 method to set click handler on navigation button. Rename a few
3023 variables. Add navigation buttons where needed.
3024 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3025 variables and methods.
3026 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3027 navigation boolean and navigation table as required in the
3028 LayoutItemField DTO.
3029 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3030 variables for navigation along with getter/setter methods.
3032 2011-10-07 Ben Konrath <ben@bagu.org>
3034 Rename Field to DetailsCell.
3036 This is a refactor-only commit. No functionality has been added or
3039 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3040 Update variable and method names.
3041 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3042 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3043 variable and method names.
3044 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3046 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3047 variable and method names.
3049 2011-10-07 Ben Konrath <ben@bagu.org>
3051 Create separate methods for layout and data the details view.
3053 This is a refactor-only commit. No functionality has been added or
3056 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3057 private methods: setData(), createLayout().
3059 2011-10-07 Ben Konrath <ben@bagu.org>
3061 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3063 This is part of a change to get navigation buttons in the details view
3064 but it should have been done this way from the start.
3066 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3067 for method name change in TableSelectionView.
3068 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3069 Create TableChangeEvent and set the browser title using the
3070 TableSelectionView API.
3071 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3072 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3073 Change getSelectedTable() to getSelectedTableName(). Add
3074 getSelectedTableTitle().
3076 2011-10-07 Ben Konrath <ben@bagu.org>
3078 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3080 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3082 2011-10-07 Ben Konrath <ben@bagu.org>
3084 Update TableChangeEvent to use newTableName naming convention.
3086 This makes the class more consistent with GWT naming conventions.
3088 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3089 Update for method name change in TableChangeEvent.
3090 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3091 for method name change in TableChangeEvent.
3092 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3093 newTableName variable and getter method. Make toDebugString()
3096 2011-09-30 Ben Konrath <ben@bagu.org>
3098 Disable the pager in the list tables when the data row count is less than the minimum.
3100 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3101 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3103 2011-09-30 Ben Konrath <ben@bagu.org>
3105 Add empty rows to the end of related list and list view tables.
3107 I also extracted the cell rendering classes from the ListTable because
3108 the code was becoming a little crazy with all the anonymous inner
3109 classes. My plan is to use these cell rendering classes in the details
3110 view as well so this refactor will be needed for that change.
3112 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3113 set the row count in related list tables if the data has more rows
3114 than the minimum number of rows visible.
3115 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3116 row count in list view tables if the data has more rows than the
3117 minimum number of rows visible.
3118 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3119 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3121 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3122 for rendering TYPE_NUMERIC cells. The code was extracted from the
3124 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3125 class for rendering cells with buttons in list views. The code was
3126 extracted from the ListTable class.
3127 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3128 for rendering TYPE_TEXT cells. The code was extracted from the
3130 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3131 Add empty rows to the end of the data if required. Implement
3132 ListTable.getMinNumVisibleRows().
3133 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3134 cell renderer code to public classes. Return null in
3135 Column.getValue() for empty rows. Add new abstract method:
3136 getMinNumVisibleRows(). Move code to set the row count of the list view
3137 table to ListViewImpl.
3138 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3139 empty rows to the end of the data if required. Implement
3140 ListTable.getMinNumVisibleRows().
3143 2011-09-27 Ben Konrath <ben@bagu.org>
3145 Use GWT.log for client-side debugging statements.
3147 These are optimized out when deployed so I should have used this method
3148 in the first place. These statements will eventually be replaced with some sort
3149 of notification in the browser.
3151 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3152 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3153 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3154 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3155 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3157 2011-09-27 Ben Konrath <ben@bagu.org>
3159 Put tableselector on the right, back to list link on right.
3161 The idea is that the table selector is acting like a label for the
3162 currently displayed table so it should be placed below the document title. This
3163 puts the table title in a similar position to where it is in Glom.
3165 * mockups/details-contacts.html:
3166 * mockups/details-projects.html:
3167 * mockups/listview-contacts.html:
3168 * mockups/listview-projects.html:
3169 * mockups/style.css:
3170 Update mockups to match how the interfaces currently look.
3171 * src/main/webapp/style.css: Swap positions of backlink with the table
3172 selector. Add some space on the left side of the table selector to
3173 line things up with the document title.
3175 2011-09-27 Ben Konrath <ben@bagu.org>
3177 Add field colouring to details view.
3179 This change re-works how field colouring works. The colour formatting
3180 information is now set to the client with the layout information instead of
3181 with the data. This eliminates the need to send the same colour strings for
3182 data in list view column when colour information is set.
3184 In order to set an alternate colour for negative numeric values, the
3185 number is now sent to client and formatted with the GWT NumberFormat class.
3187 This change also fixes:
3189 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3191 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3192 internationalization framework which is needed for client side numeric
3194 * src/main/java/org/glom/web/client/Utils.java: New file for some
3195 client static utility methods.
3196 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3197 the DataItem object to the Field class. Use a utility method to
3198 create the foreignKeyValue string.
3199 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3200 alignment and text colours in the constructor. Add setData(DataItem)
3201 method. Remove setText(String) method.
3202 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3203 colour information to GlomTextCell. Create and use GlomNumberCell for
3204 rendering numbers. Use utility method to get the string for the
3205 primary key of the key provider. Re-work how the horizontal alignment
3207 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3208 formatting to layout information. Methods for converting the libglom
3209 formatting information were moved from DBAccess.
3210 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3211 numeric formatting (it's now done on the client side). Don't set text
3212 colours in DataItem. Move libglom formatting conversion methods to
3214 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3215 getters/setters for text colour information.
3216 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3217 for transferring the libglom NumericFormat information to the client.
3218 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3219 and getters/setters for: GlomNumericFormat, background colour and
3220 foreground colour strings.
3222 2011-09-26 Ben Konrath <ben@bagu.org>
3224 Simplify code that iterates through the LayoutGroup.
3226 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3228 2011-09-26 Ben Konrath <ben@bagu.org>
3230 Accept Eclipse formatting for OnlineGlomServiceAsync.
3232 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3234 2011-09-26 Ben Konrath <ben@bagu.org>
3236 Don't use the ListDBAccess classes to get the primary key layout information.
3238 This was causing a bug where the wrong index for the hidden primary key
3239 was being sent to the client.
3241 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3242 primary key while creating the LayoutGroup DTO. Create a
3243 LayoutItemField DTO for hidden primary keys. Don't use the
3244 RelatedListDBAccess because it was only used for getting the primary
3246 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3247 access modifier from public to protected for getPrimaryKeyField() and
3248 getPrimaryKeyLayoutItemField().
3249 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3250 abstract method getExpectedResultSize() because RelatedListDBAccess
3251 doesn't have enough info to implement it.
3252 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3253 Remove @Override for getExpectedResultSize().
3254 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3255 Remove method getExpectedResultSize().
3257 2011-09-23 Ben Konrath <ben@bagu.org>
3259 Log which layout (list or details) the ignored item is from.
3261 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3263 2011-09-23 Ben Konrath <ben@bagu.org>