1 2012-11-12 Murray Cumming <murrayc@murrayc.com>
3 Use image data when recreating databases for testing.
5 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
6 for use locally (not acrosss the network) when recreating databases
8 getValue(): Use it here instead of getImageDataUrl(), noting that
9 this method is only for use when recreating databases.
10 * src/main/java/org/glom/web/server/libglom/Document.java:
11 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
13 2012-11-09 Murray Cumming <murrayc@murrayc.com>
15 OnlineGlomImages: Detect the mime-type (content type).
17 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
18 doGet(): Instead of hard-coding image/png.
20 2012-11-09 Murray Cumming <murrayc@murrayc.com>
22 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
25 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
26 Java Compiler and Java Build path settings in the UI.
28 2012-11-09 Murray Cumming <murrayc@murrayc.com>
30 Use the latest (now stable) version of GWT.
32 * pom.xml: And the latest version of the gwt-maven-plugin.
34 2012-11-08 Murray Cumming <murrayc@murrayc.com>
36 Added an Indonesian translation.
38 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
39 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
40 This is from the new translation in Glom.
42 2012-07-23 Murray Cumming <murrayc@murrayc.com>
46 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
48 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
50 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
51 for serving image data.
52 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
54 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
55 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
56 setData(): For image field types, add a GWT Image widget,
57 with the URL that was set in the DataItem.
59 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
60 * src/main/java/org/glom/web/server/database/DBAccess.java:
61 convertResultSetToDTO(): Set the URL for image data, so the client browser
62 can retrieve the image from our new servlet. This uses UriBuilder.
63 Move getPrimaryKeyField to:
64 * src/main/java/org/glom/web/server/libglom/Document.java:
65 Added getTablePrimaryKeyField().
67 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
68 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
69 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
72 2012-07-22 Murray Cumming <murrayc@murrayc.com>
76 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
77 * src/main/java/org/glom/web/client/OnlineGlomService.java:
78 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
79 to gwtGlom, which is more appropriate.
80 This servlet name does not seem to be visible to the client side anyway.
82 2012-07-22 Murray Cumming <murrayc@murrayc.com>
84 Tests: Make the imports of assert*() consistent.
86 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
87 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
88 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
89 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
90 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
91 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
92 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
93 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
94 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
95 * src/test/java/org/glom/web/shared/DataItemTest.java:
97 import static org.junit.Assert.*;
98 which seems fairly common.
102 2012-07-21 Murray Cumming <murrayc@murrayc.com>
104 tests: Move a test that needs a database connection.
106 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
107 Move testGetListViewLayoutGroup() to
108 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
109 because it needs a database connection.
111 2012-07-21 Murray Cumming <murrayc@murrayc.com>
113 tests: Use @BeforeClass on tearDown().
115 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
116 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
117 This avoids leaking a postgres process in SelfHostExampleTest.
119 2012-07-21 Murray Cumming <murrayc@murrayc.com>
121 tests: Test translations more.
123 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
124 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
125 Test titles in the non-default locale.
127 2012-07-21 Murray Cumming <murrayc@murrayc.com>
129 tests: Add SelfHostConfiguredDocumentTest
131 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
132 username and password, for use by ConfiguredDocument.
133 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
134 This tests some of the ConfiguredDocument API that requires a database connection.
136 2012-07-21 Murray Cumming <murrayc@murrayc.com>
138 Document: Load title translations and test them.
140 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
141 of titles. I am surprised that we do not do this yet.
142 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
143 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
144 Test translations more.
146 2012-07-20 Murray Cumming <murrayc@murrayc.com>
150 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
151 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
152 Set the timeout here too.
154 2012-07-20 Murray Cumming <murrayc@murrayc.com>
156 tests: ConfiguredDocumentTest: Make this pass.
158 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
159 Disable tests that need a database connection.
161 2012-07-20 Murray Cumming <murrayc@murrayc.com>
163 Use Java 1.7 instead of Java 1.6.
165 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
166 to do this twice, at least for Eclipse.
167 This seems OK because it is the current version.
169 2012-07-20 Murray Cumming <murrayc@murrayc.com>
173 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
174 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
175 Avoid using a null Connection.
177 2012-07-20 Murray Cumming <murrayc@murrayc.com>
179 tests: Add a ConfiguredDocument test.
181 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
184 2012-07-20 Murray Cumming <murrayc@murrayc.com>
186 LayoutItemFIeld: getName(): Use the Field if it is set.
188 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
189 getName(): If the full field details have been set, return its name, so that
190 callers do not need to set the name separately.
191 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
192 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
193 so we can count the rows.
195 2012-07-20 Murray Cumming <murrayc@murrayc.com>
197 tests: SelfHoster: Test SqlUtils too.
199 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
200 Retrieve some data and check it too, as in the regular Glom
201 test_selfhosting_new_from_example.cc test.
202 * src/test/java/org/glom/web/server/SelfHoster.java:
203 createConnection(): Make this public.
205 2012-07-20 Murray Cumming <murrayc@murrayc.com>
207 tests: SelfHoster: createConnection(): Do not warn about expected failures.
209 Let the caller say if the connection is expected to fail, to avoid
210 irrelevant error output.
212 2012-07-20 Murray Cumming <murrayc@murrayc.com>
214 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
216 * src/test/java/org/glom/web/server/SelfHoster.java:
217 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
218 due to the inevitable need to retry the connection while the database server
221 2012-07-20 Murray Cumming <murrayc@murray.com>
223 tests: SelfHoster: createConnection(): Set a timeout.
225 * src/test/java/org/glom/web/server/SelfHoster.java:
226 createConnection(): Use setLoginTimeout() because it otherwise seems to take
227 ages to actually return when it fails.
229 2012-07-20 Murray Cumming <murrayc@murrayc.com>
231 tests: SelfHoster: selfHost(): Close the test connection.
233 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
234 When we check that the connection works, close the connection. This seems
235 to not be closed automatically otherwise.
237 2012-07-20 Murray Cumming <murrayc@murrayc.com>
239 Use slf4j-simple to see JDBC errors.
241 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
243 2012-07-19 Murray Cumming <murrayc@murrayc.com>
245 SelfHoster.discoverFirstFreePort(): Close the socket.
247 * src/test/java/org/glom/web/server/SelfHoster.java:
248 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
250 2012-07-19 Murray Cumming <murrayc@murrayc.com>
252 Avoid another code warning in Eclipse Juno.
254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
255 Do instanceof checks on the FileUtils.listFiles() result and its
258 2012-07-13 Murray Cumming <murrayc@murrayc.com>
260 Avoid some code warnings in Eclipse Juno
262 * src/main/java/org/glom/web/server/libglom/Document.java:
263 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
264 * src/test/java/org/glom/web/server/SelfHoster.java
265 createTextFile(): Make sure that the FileOutputStream is closed.
267 2012-06-22 Murray Cumming <murrayc@murrayc.com>
269 Added OnlineGlomPropertiesTest.
271 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
272 Make sure we never return a null string.
273 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
274 Added tests of the OnlineGlomProperties API, using our sample file.
276 2012-06-20 Murray Cumming <murrayc@murrayc.com>
278 Make OnlineGlomProperties be a normal class.
280 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
281 Move OnlineGlomProperties into its own file to be a regular class:
282 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
283 This makes testing simpler.
285 2012-06-15 Murray Cumming <murrayc@murrayc.com>
287 OnlineGlomServiceImpl.init(): Move some code into a new method.
289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
290 Create addDocument().
292 2012-06-15 Murray Cumming <murrayc@murrayc.com>
294 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
296 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
297 OnlineGlomProperties.getKey(): Make this more robust by moving the
298 check for *.*.filename to here.
300 2012-06-15 Murray Cumming <murrayc@murrayc.com>
302 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
305 init(): Move knowledge of the config file format into the
306 OnlineGlomProperties inner class.
308 2012-06-15 Murray Cumming <murrayc@murrayc.com>
310 SelfHostExampleTest: Make sure we cleanup on failure.
312 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
313 the use of cleanup() to a tearDown() JUnit method.
317 2012-06-12 Murray Cumming <murrayc@murrayc.com>
319 ConfiguredDocument: Add a primary key to portals at least once.
321 * src/main/java/org/glom/web/server/ConfiguredDocument.java
322 updatePortalsExtras): Fix a typo so that we add the primary key
323 column at least once.
324 This is a fix for the previous commit:
325 ConfiguredDocument: Do not add a primary key to portals each time.
327 2012-06-08 Murray Cumming <murrayc@murrayc.com>
329 SelfHoster: Avoid some compiler warnings.
331 * src/test/java/org/glom/web/server/SelfHoster.java
332 executeCommandLineAndWait():
333 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
334 the now-unused streams for stdout and stderr from the command Processes.
335 These are not used because readln() hangs while waiting for a new line,
336 where there may be no next line. The commented out code is still there
337 to help us figure out how to do this properly.
339 2012-06-08 Murray Cumming <murrayc@murrayc.com>
341 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
343 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
344 Make this actually test the cloning again, though it is not very useful
345 now that we do not use the part that had a problem with cloning before.
347 2012-06-08 Murray Cumming <murrayc@murrayc.com>
349 SelfHoster: Keep trying pg_ctl after starting postgres.
351 * src/test/java/org/glom/web/server/SelfHoster.java
352 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
353 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
354 regular Glom. This seems mad but it seems to work because the first
355 command would fail if pg_ctl would eventually fail.
357 2012-06-08 Murray Cumming <murrayc@murrayc.com>
359 SelfHoster: Wait until the server is really ready.
361 * src/test/java/org/glom/web/server/SelfHoster.java
362 selfHost(): Attempt the connection after starting the server, retrying
363 a few times if necessary, so that the server is really ready already when
364 we return from this method.
365 The regular Glom code does this too because pg_ctl reports success too soon.
367 2012-06-08 Murray Cumming <murrayc@murrayc.com>
369 ConfiguredDocument: Do not add a primary key to portals each time.
371 * src/main/java/org/glom/web/server/ConfiguredDocument.java
372 updatePortalsExtras(): Only add an extra primary key field if there is
373 none, to avoid adding one each time we retrieve the details layout from the
375 This should fix bug #676986 (Ben Konrath)
377 2012-05-25 Murray Cumming <murrayc@murrayc.com>
379 Document.load(): Support version 7 documents.
381 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
382 database_title attribute if the title attribute is not there.
385 2012-05-24 Ben Konrath <ben@bagu.org>
387 Add configuration for auto-generating mvn:i18n from with Eclipse.
389 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
391 2012-05-24 Murray Cumming <murrayc@murrayc.com>
393 Update translations, adding French.
395 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
396 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
397 Add a French translation, using the translation from Glom.
399 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
400 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
401 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
402 Update these based on the translations from Glom.
404 2012-05-24 Murray Cumming <murrayc@murrayc.com>
406 SelfHoster: Add some debug println messages to help when things fail.
408 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
409 System.out.println() lines.
411 2012-05-23 Murray Cumming <murrayc@murrayc.com>
413 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
415 * src/test/java/org/glom/web/server/SelfHoster.java:
416 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
417 instance) instead of just /usr/bin (as on Fedora). Check the result when
420 2012-05-23 Murray Cumming <murrayc@murrayc.com>
422 Remove LayoutItemPortal.get/setNavigationTable().
424 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
425 Remove get/setNavigationTable(), which is only a cache, because it is not
426 used, and does not need to be used, because that decision should be made on
428 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
429 updatePortalsExtras():
430 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
431 getNavigationRecord():
432 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
435 2012-05-21 Murray Cumming <murrayc@murrayc.com>
437 Initial self-hosting for tests.
439 * pom.xml: Change the scope for log4j, to hopefully make it
440 available to the test code which uses it indirectly via jOOQ.
441 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
442 self-hosting, though we only use it for testing.
444 * src/main/java/org/glom/web/server/libglom/Document.java:
445 example rows: Use a map instead of a list for each row of values,
446 so we know what field they are for, instead of relying on the sequence
447 being correct. This is not very efficient, but it does not really need
449 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
450 testReadTableExampleRows(): Adapted.
452 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
453 that returns an Object, for generic use. Note that Object seems to be
454 the implicit base even of double.
455 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
456 for use in CREATE TABLE SQL queries.
457 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
458 to do self-hosting of PostgreSQL databases via its command-line
459 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
460 backends/postgres_self.cc. This is incomplete - it needs more
461 warnings about failures and it needs to clean up properly when things
463 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
464 test of this new class.
466 2012-05-21 Murray Cumming <murrayc@murrayc.com>
468 Document: loading example data: Handle exceptions.
470 * src/main/java/org/glom/web/server/libglom/Document.java:
471 DateFormat.parse() and Double.valueOf() can throw exceptions, though
472 Eclipse did not warn about that.
474 2012-05-20 Murray Cumming <murrayc@murrayc.com>
476 Document: load(), save(): Handle the example rows.
478 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
480 * src/main/java/org/glom/web/server/libglom/Document.java:
481 load(), save(): Load and save the example rows, though the date, time
482 and image types are not handled properly yet.
483 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
484 Add testReadTableExampleRows() just to check that something is read.
486 2012-05-20 Murray Cumming <murrayc@murrayc.com>
488 Document: Add save().
490 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
491 Added getTranslationsMap() for use while saving.
492 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
493 Adedd getUseDefaultFormatting() for use while saving.
494 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
495 and several private methods that it uses.
497 This will be useful while testing via self-hosting.
498 It is not complete, but should be complete enough for testing.
500 2012-05-17 Murray Cumming <murrayc@murrayc.com>
502 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
504 * src/main/java/org/glom/web/client/OnlineGlomService.java
505 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
507 Remove getSortedListViewData() and getSortedRelatedListData(), adding
508 the sort column index and ascending bool to the regular method.
509 Instead, a sort column index of -1 now means no sort.
510 This is less explicit, but it's fairly simple, reduces the amount of
511 code, and makes the OnlineGlomService API slightly smaller.
512 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
513 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
515 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
516 getListViewData(), getRelatedListData():
517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
518 getListViewData(), getRelatedListData():
519 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
521 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
523 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
528 2012-05-16 Murray Cumming <murrayc@murrayc.com>
530 Use translations for top-level groups too.
532 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
533 updateTitlesForLocale(): Use the translation for the group
534 as well as for child items.
538 Just recompiled to fix a problem in the released .tar.gz file.
542 2012-05-15 Murray Cumming <murrayc@murrayc.com>
544 Corrections to navigation to related records.
546 * src/main/java/org/glom/web/client/OnlineGlomService.java:
547 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
548 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
549 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
550 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
551 relationship name, because the relationship name is not necessarily unique
553 TOOD: This is inefficient, because it passes the whole list of
554 child field items back to the server, but it is more correct, and happens
555 to fix a bug with the primary key being lost after a few navigations.
556 There is probably a chance to make this more efficient anyway in some
559 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
560 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
561 * src/main/java/org/glom/web/server/ConfiguredDocument.java
562 * src/main/java/org/glom/web/server/database/DBAccess.java
563 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
564 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
567 2012-05-15 Murray Cumming <murrayc@murrayc.com>
569 Fix the use of translations.
571 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
572 Add updateTitlesForLocale().
573 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
574 Call it to discard unwanted translations and to make getTitle() return
575 the wanted translation wihout the need for the client code to specify a locale.
576 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
577 getTitle(): Fallback to the original title, as libglom does.
579 2012-05-15 Murray Cumming <murrayc@murrayc.com>
581 Document: Correctly report the number of available translation locales.
583 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
584 the available locale IDs list.
585 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
586 testLocales: Test this.
588 2012-05-15 Murray Cumming <murrayc@murrayc.com>
590 SqlUtils: Use camelCase.
592 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
593 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
594 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
595 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
596 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
597 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
599 2012-05-15 Murray Cumming <murrayc@murrayc.com>
601 Use jOOQ's tableByName() and fieldByName.
603 * pom.xml: Use jOOQ 2.3.1 to get the new API.
604 * src/main/java/org/glom/web/server/SqlUtils.java:
605 build_sql_select_step_with_where_clause(), .createField(),
606 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
607 so we can get correct quoting and escaping. Thanks to Lukas Eder for
608 adding this, and other things, to jOOQ.
610 2012-05-15 Murray Cumming <murrayc@murrayc.com>
612 SqlUtils: Remove the Connection parameters.
614 * src/main/java/org/glom/web/server/SqlUtils.java:
615 build_sql_select_with_key(), build_sql_select_with_where_clause(),
616 createSelect(), build_sql_select_step_with_where_clause(),
617 build_sql_count_select_with_where_clause(),
618 build_sql_select_count_rows(): Remove the Connection parameter because
619 jOOQ does not actually need a connectionwhen it is just used to build
621 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
623 * src/main/java/org/glom/web/server/ReportGenerator.java:
625 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
627 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
628 Constructor, getListData(), getResultSizeOfSQLQuery():
629 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
630 getSelectQuery(), getCountQuery():
631 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
632 getSelectQuery(), getCountQuery():
633 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
634 getNavigationRecord(): Adapted.
636 2012-05-14 Murray Cumming <murrayc@murrayc.com>
640 * src/main/java/org/glom/web/server/SqlUtils.java:
641 get_find_where_clause_quick(): Use a comparison of
642 lowercase values, instead of a simple equals. Regular Glom
643 uses the PostgreSQL ILIKE operator but jOOQ does not
644 support that just yet, though it will soon.
646 2012-05-14 Murray Cumming <murrayc@murrayc.com>
648 TableToViewDetails: Use a real serialization ID.
650 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
651 Though this does not fix the serialization problem.
653 2012-05-12 Murray Cumming <murrayc@murrayc.com>
655 Added LayoutItemPortalDeepCloneTest.
657 2012-05-11 Murray Cumming <murrayc@murrayc.com>
659 Make navigation work again.
661 * src/main/java/org/glom/web/server/libglom/Document.java:
662 Add getLayoutItemFieldShouldHaveNavigation().
663 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
664 Replace get/setAddNavigation() with the partly-existing
665 get/setNavigationTableName(), with an empty string being no navigation,
666 because this is simpler. Use the new
667 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
669 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
670 Add updateFieldsExtras() and call setNavigationTableName in it.
671 getDetailsLayoutGroup(),
672 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
673 createLayout(): Adapted.
674 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
675 Constructor: Adapted.
677 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
678 Replace get/setAddNavigation() with get/setNavigation(), returning a
679 TableToViewDetails class with both the table name and UsesRelationship,
680 because both are need. The previous code used java-libglom's output
681 variable (strangely, via sharedptr) to return both, but we cannot really
683 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
684 getNavigationRecord(): Adapt. However, we cannot actually use the cache
685 here because it somehow gets set to null during deepCopy(). I must test this.
686 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
687 testGetSuitableTableToViewDetails(): Adapted.
689 TODO: Find out why deepClone() is not quite working.
691 2012-05-11 Murray Cumming <murrayc@murrayc.com>
693 DBAccess: Simplify the retrievel of full field details.
695 * src/main/java/org/glom/web/server/database/DBAccess.java
696 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
697 because the Document loading should have done this.
699 2012-05-11 Murray Cumming <murrayc@murrayc.com>
701 Document: Correct loading of doubly-related layout fields.
703 * src/main/java/org/glom/web/server/libglom/Document.java:
704 loadUsesRelationship(): Actually set the related relationship, instead
705 of only setting it if it's not found.
707 2012-05-09 Murray Cumming <murrayc@murrayc.com>
709 Replace all appearances of Colour with color.
711 Because US English is dominant.
713 2012-05-09 Murray Cumming <murrayc@murrayc.com>
715 Use colors in HTML format, solving a warning about an unused function.
717 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
718 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
719 Add *asHTMLColor() versions of methods.
720 TODO: However, we should create and cache the results on the server.
721 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
722 * src/main/java/org/glom/web/client/ui/list/ListTable.java
723 * src/main/java/org/glom/web/server/ConfiguredDocument.java
724 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
725 Use the asHTMLcolor() versions.
727 2012-05-09 Murray Cumming <murrayc@murrayc.com>
729 ListViewTable: Constructor: Take the table name as a parameter.
731 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
732 Constructor: Take the tableName, and set the member variable, because
734 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
735 setCellTable(): Pass the table name.
736 This makes navigation to non-default tables work again. I don't know
737 why it worked before in the master branch.
739 2012-05-07 Murray Cumming <murrayc@murrayc.com>
741 ConfiguredDocument: Restore correct addition of hidden primary key items.
743 * src/main/java/org/glom/web/client/ui/list/ListTable.java
744 (ListTable.createCellTable): Uncomment out the check for the hidden
746 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
747 add primary key items for top-level lists and portals, as before,
748 instead of adding them to each group.
749 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
750 Actually implement the extra methods such as setHiddenPrimaryKey() and
751 comment that these are used only for top-level list groups and in portals.
752 This strangeness suggests even more that this should not be squeezed
753 into the LayoutGroup class.
755 2012-05-07 Murray Cumming <murrayc@murrayc.com>
757 Fix Formatting loading.
759 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
760 getFormattingUsed(): Remove the duplicate Formatting member variable
761 in favour of the one from the base class.
762 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
763 Initialize a new Formatting instead of using null by default, so we
764 have some defaults, instead of having to initialize one later just to
765 get the same defaults. This also makes loading of formatting from the
766 document work, because that expected a non-null.
768 2012-05-07 Murray Cumming <murrayc@murrayc.com>
770 RelatedListTable: Make sure that the tableName is set.
772 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
773 Constructor: Take the tableName so it is available later. Otherwise,
774 the server assumes that we mean the default table and cannot find the
776 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
777 setData(): Pass the tableName to the RelatedListTable constructor.
779 2012-05-07 Murray Cumming <murrayc@murrayc.com>
783 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
784 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
785 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
787 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
789 * src/main/java/org/glom/web/server/database/DBAccess.java:
790 convertResultSetToDTO(), getPortal():
791 * src/main/java/org/glom/web/server/database/ListDBAccess.java
793 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
794 Add checks for null objects and out of range access, with log messages to
795 give hints so we can fix these properly.
797 2012-05-07 Murray Cumming <murrayc@murrayc.com>
799 Portals: some corrections.
801 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
803 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
804 constructor: Use getRelationshipNameUsed() instead of getName(), because
805 that is what is meant.
806 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
807 getFromField(): Fix a typo, to get the field name, not the table name.
808 * src/main/java/org/glom/web/server/database/DBAccess.java:
809 getPortal(): Fix a typo that stopped this from working.
811 2012-05-07 Murray Cumming <murrayc@murrayc.com>
813 LayoutItemPortal: Also override getTitleOriginal().
815 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
816 This lets the base getTitle() with no parameters work.
817 TODO: Test this properly.
819 2012-05-06 Murray Cumming <murrayc@murrayc.com>
821 LayoutItemPortal: getTitle*(): Use the relationship title.
823 2012-05-06 Murray Cumming <murrayc@murrayc.com>
825 LayoutItemField: Fix loading of custom titles.
827 * src/main/java/org/glom/web/server/libglom/Document.java
828 loadDataLayoutItemField(): The title, if any, instead of the field
829 title, is stored in a title_custom node. Load it from there.
830 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
832 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
833 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
834 getTitle*() overrides.
835 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
838 2012-05-06 Murray Cumming <murrayc@murrayc.com>
840 LayoutItemField: Fall back to field titles, so some are really shown.
842 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
843 Override getTitleOriginal() and getTitle(), as in java-libglom.
844 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
847 2012-05-06 Murray Cumming <murrayc@murrayc.com>
849 Correct use of setExpectedResultSize().
851 * src/main/java/org/glom/web/server/ConfiguredDocument.java
852 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
853 Use setExpectedResultSize only on top-level groups (for instance, the
854 list layout) or on child portals (in details views).
855 Use the correct table name for portals to avoid SQL errors.
856 Update the expected counts when returning cached layouts.
858 2012-05-06 Murray Cumming <murrayc@murrayc.com>
860 Document: Interpret no group column count as 1.
862 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
863 default, though we now check for this in the UI code anyway.
865 2012-05-06 Murray Cumming <murrayc@murrayc.com>
869 2012-05-06 Murray Cumming <murrayc@murrayc.com>
871 Translatable: Use Hashmap instead of Treemap because GWT supports it.
873 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
874 The use of Treemap lead to this error from async methods, with no
876 "The response could not be deserialized"
878 2012-05-06 Murray Cumming <murrayc@murrayc.com>
880 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
882 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
883 when using the Google -> GWT Compile, or
884 g toolbar button -> GWT Compile Project... feature in Eclipse.
886 2012-05-06 Murray Cumming <murrayc@murrayc.com>
888 ListTable.addColumn(): Protect against a null Formatting.
890 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
891 Create a default Formatting if it is null, because that is the simplest
894 2012-05-06 Murray Cumming <murrayc@murrayc.com>
896 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
898 * src/main/java/org/glom/web/server/ConfiguredDocument.java
899 updateLayoutGroup(): Check that the field is not null.
901 2012-05-06 Murray Cumming <murrayc@murrayc.com>
903 ListViewImpl: Protected against a bad cast error.
905 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
906 onEnterKeyDown(): Do not cast without an instanceof check.
908 2012-05-06 Murray Cumming <murrayc@murrayc.com>
910 ListTable: Protect against an out of range error.
912 * src/main/java/org/glom/web/client/ui/list/ListTable.java
913 createCellTable(): This is unlikely, but can happen while debugging.
915 2012-05-06 Murray Cumming <murrayc@murrayc.com>
917 AsyncMessage onFailure() callbacks: Log the exception message.
919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
920 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
921 * src/main/java/org/glom/web/client/activity/ListActivity.java:
922 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
923 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
924 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
925 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
926 These are useful clues when something is wrong.
928 2012-05-06 Murray Cumming <murrayc@murrayc.com>
930 ConfiguredDocument: Avoid a null dereference.
932 * src/main/java/org/glom/web/server/ConfiguredDocument.java
933 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
934 details maps are created.
936 2012-05-06 Murray Cumming <murrayc@murrayc.com>
938 Document: Correct the port number parsing.
940 * src/main/java/org/glom/web/server/libglom/Document.java:
941 This lets us actually connect to the database and show the document.
943 2012-05-05 Murray Cumming <murrayc@murrayc.com>
947 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
948 user-interaction, asking us to load a temporary URL in a browser.s
949 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
950 which is apparently necessary for testing the service. See the comment.
951 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
952 Show the exception, if any. This is how I saw the 404 in the HTML in
955 2012-05-05 Murray Cumming <murrayc@murrayc.com>
957 DocumentTest: Move the .glom files into the resources directory.
959 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
960 URI via getResource().
962 2012-05-05 Murray Cumming <murrayc@murrayc.com>
964 Document: Remove the FieldIdentifies inner class.
966 * src/main/java/org/glom/web/server/libglom/Document.java: We only
967 use the Relationship (though the same function in libglom is maybe
968 used in other ways) and so this removes a compiler warning.
970 2012-05-05 Murray Cumming <murrayc@murrayc.com>
972 Document.load() Remove the error code parameter.
974 * src/main/java/org/glom/web/server/libglom/Document.java: load():
975 Remove the parameter. We do not set it yet and it could never have
976 worked as an output parameter (though maybe it did in java-libglom).
977 We could use an exception if we really want the failure reason.
978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
980 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
981 setUp(), testGetSuitableTableToViewDetails(): Adapt.
983 2012-05-05 Murray Cumming <murrayc@murrayc.com>
985 Make some inner classes static.
987 * src/main/java/org/glom/web/server/ConfiguredDocument.java
988 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
989 * src/main/java/org/glom/web/server/ReportGenerator.java
990 * src/main/java/org/glom/web/server/libglom/Document.java
991 Make all inner classes static that can be static.
993 2012-05-05 Murray Cumming <murrayc@murrayc.com>
995 OnlineGlomServiceImpl: Do not load and check for java-libglom.
997 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
998 init(): We do not use java-libglom any more.
1000 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1002 Remove mentions of java-libglom.
1004 * README: Remove mention of java-libglom, because it no longer needed.
1005 * utils/build-onlineglom-war.sh:
1006 * utils/check-and-recover-tomcat.py:
1007 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1008 useful. Building is now far easier, with no need for jhbuild.
1010 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1012 Fix the build (mvn package)
1014 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1015 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1016 Otherwise the GWT Java->Javascript compilation fails with just this
1017 error, during mvn package or when attempting to view in a browser,
1018 in the GWT developer mode in Eclipse.
1020 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1021 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1022 [INFO] Compiling module org.glom.web.OnlineGlom
1023 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1024 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1025 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1026 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1027 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1028 [INFO] [ERROR] Cannot proceed due to previous errors
1030 It has taken me 2 days to find out what was causing that. After reducing
1031 the code, the compiler eventually showed me the full error message.
1033 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1035 ConfiguredDocument: Cache the cloned and stripped layouts.
1037 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1038 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1039 layout in a map, so we can retrieve it again without rebuilding it.
1041 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1043 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1045 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1047 libglom classes: Implement some auto-generated emthods.
1049 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1051 Add GwtTestOnlineGlomService.
1053 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1054 However, this (and the other GwtTest*) does not seem to run during
1057 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1059 Remove use of unsupported features from client code.
1061 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1062 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1063 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1064 Use our client version of StringUtils instead of the apache commons one.
1066 However, the GWT Javascript compliation still fails.
1068 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1070 Add a Field class and implement some loading of it in Document.
1072 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1074 Initial Document loading implementation, instead of libglom.
1076 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1077 and Translatable classes, and adapt the rest of the code to use them.
1078 However, this is still missing Layout and Field classes and loading.
1080 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1082 Use of jOOQ: Move Field creation into a utility method.
1084 * src/main/java/org/glom/web/server/SqlUtils.java:
1085 This lets us improve it more easily.
1087 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1089 Use of jOOQ: Improve the code to COUNT a sub-select.
1091 * src/main/java/org/glom/web/server/SqlUtils.java:
1092 Move initial query creation into
1093 build_sql_select_step_with_where_clause().
1094 build_sql_select_count_rows(): Use the jOOQ API instead of
1095 concatentating text, because a jOOQ Select*Step is a TableLike,
1096 which is what from() takes.
1098 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1100 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1102 * pom.xml: Depend on jooq.
1103 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1104 methods with jOOQ, based on the C++ implementations in libglom,
1105 with some changes to the logic required by jooQ.
1106 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1108 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1109 * src/main/java/org/glom/web/server/ReportGenerator.java:
1110 * src/main/java/org/glom/web/server/SqlUtils.java:
1111 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1112 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1113 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1114 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1115 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1116 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1117 because jOOQ needs that, though it seems unnecessary.
1119 This is not quite finished. Ideally jOOQ would help us to build
1120 table_name.field_name names, quoting and escaping them properly.
1121 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1123 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1125 Move use of Glom.build_sql*() into a new SqlUtils class.
1127 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1128 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1129 but this will make it easier to start using something other than
1130 libglom or SqlBuilder.
1132 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1134 Update the project URL.
1136 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1138 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1140 Main layout: Use a FlowTable instead of absolute positioning.
1142 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1143 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1144 child panels/widgets must have an absolute position. But that is annoying, so
1145 this adds a FlowTable and puts the child panels in there.
1147 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1149 GwtTestOnlineGlom: Comment out unused code.
1151 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1152 Eclipse has started to say that some code is unused.
1154 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1156 Update to the latest versions of dependencies.
1158 * pom.xml: Update version numbers of dependencies to the latest
1160 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1162 * src/main/java/org/glom/web/server/ReportGenerator.java:
1163 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1164 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1165 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1167 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1168 Modify the imports where necessary.
1170 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1172 Style: Remove overflow:hidden from searchbox
1174 * src/main/webapp/style.css: Because this pushes the Back To Link
1175 label/link on to the next row, which is then hidden due to the
1176 hard-coded (in ems) height.
1178 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1180 Remove some duplicate code.
1182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1183 getDocumentInfo(): This must have been duplicated during the merge from the
1188 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1190 Reports: Localize the waiting for report message.
1192 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1193 start(): Get the message from the contants.
1194 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1195 Add the string here.
1196 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1197 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1198 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1199 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1200 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1201 Update these files with the English text for newer strings for now.
1203 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1205 Reports: Show a message while waiting for the report.
1207 * src/main/java/org/glom/web/client/ui/ReportView.java
1208 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1209 Add setWaitingText(), to show a message saying that we are
1210 waiting for the report to be ready.
1211 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1212 start(): Call setWaitingText() before calling the async
1215 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1217 ReportGenerator: Specify date and time formats.
1219 * src/main/java/org/glom/web/server/ReportGenerator.java:
1220 createFieldValueElement(): Use the default (and localized)
1221 short formats, though we still need a way to show 4-digit
1222 years without providing the format for every locale.
1223 * src/main/java/org/glom/web/server/database/DBAccess.java:
1224 convertResultSetToDTO(): Use the short formats here too.
1226 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1228 ReportGenerator: Use the correct numeric formatting.
1230 * src/main/java/org/glom/web/server/ReportGenerator.java
1231 createFieldExpression(), createFieldValueElement(): Take the
1232 whole LayoutItem_Field instead of just the field name, so
1233 we have access to the formatting.
1234 createFieldValueElement(): Use JRTextField.setPattern() to
1235 specify the numeric formatting, with the help of a
1236 regular DecimalFormat.
1238 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1240 ReportGenerator: Avoid showing null for group by titles.
1242 * src/main/java/org/glom/web/server/ReportGenerator.java
1243 generateReport(): Use setBlankWhenNull() on the field title
1244 style too, because this is used for values in group by
1247 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1249 ReportGenerator: Add a colon to titles in vertical groups.
1251 * src/main/java/org/glom/web/server/ReportGenerator.java
1252 addFieldToDetailBandVertical(): Pass true for the withColon
1255 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1257 ReportGenerator: Simplify the code by using Position more.
1259 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1261 Reports: Support vertical groups, roughly.
1263 * src/main/java/org/glom/web/server/ReportGenerator.java:
1264 addToReport(): Rename to addGroupToReport() and, if necessary,
1265 call the new addVerticalGroupToReport() method.
1266 createFieldValueElement(): Let the caller specify the Y position
1269 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1271 Reports: Allow a second report to be shown.
1273 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1274 clear(): Do not remove the HTML widget, which broke the whole layout.
1276 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1278 Locales drop-down: Show that we use English by default.
1280 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1281 fillView(): When we use English, just because that is the default, when
1282 no locale is specified, show that in the Locales drop-down instead of
1283 just showing the first item.
1285 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1287 Unselect the Report/Locale/Table combo item when appropriate.
1289 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1290 setPlace(): clear reportName if this is not a ReportPlace.
1291 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1292 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1293 When the provided name is empty, unselect all items, so that none are
1294 indicated. This uses a for loop because I cannot find a single method
1297 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1299 Report: Give the user a way to get back to the list.
1301 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1302 start(), setPlace(): Show the Back To List link on reports, and also
1303 interpret selecting the empty report item as back to list.
1305 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1307 Really show the selected Report name.
1309 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1310 setPlace(): Store the reportName here, if it is that kind of Place.
1311 fillView(): Set the selected Report after filling the list of reports.
1312 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1313 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1314 null Strings, though we need some way to unselect all ListBox items
1317 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1319 ReportGenerator: Try to avoid some problems.
1321 * src/main/java/org/glom/web/server/ReportGenerator.java
1322 addField(): Try to avoid duplicates, and avoid using a null
1325 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1327 Reports: Use quickFind.
1329 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1330 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1332 getReportHTML(): Add a quickFind parameter.
1333 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1334 start(): Pass the quickFind parameter.
1335 * src/main/java/org/glom/web/server/ReportGenerator.java
1336 generateReport(): Take a quickFind parameter.
1338 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1340 ReportPlace: Actually use the report name.
1342 * src/main/java/org/glom/web/client/place/ReportPlace.java
1343 getPlace(): Do not assign the report name to the quickfind.
1345 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1347 Show java.library.path when complaining.
1349 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1350 init(): When telling us to check java.library.path, show the
1353 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1355 ReportGenerator: Do not show nulls.
1357 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1359 ReportGenerator: Make the title font larger.
1361 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1363 ReportGenerator: Put field titles inside groups, if there are groups.
1365 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1367 ReportGenerator: Take the Report itself instead of the name and group.
1369 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1370 Remove getReportLayoutGroup().
1371 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1372 getReportHTML(): Pass the report instead
1373 of its name and layout group.
1374 * src/main/java/org/glom/web/server/ReportGenerator.java
1375 generateReport(): Use the report object to use the title
1376 instead of the name.
1378 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1380 ReportGenerator: Remove designBand parameters.
1382 * src/main/java/org/glom/web/server/ReportGenerator.java:
1383 Make designBand a class member instead of passing it to all
1386 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1388 ReportGenerator: Add lines, a bit like in the desktop version.
1390 * src/main/java/org/glom/web/server/ReportGenerator.java
1391 addToReport(): Use JRDesignLine.
1393 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1395 ReportGenerator: Correct the title positions and use some bold style.
1397 * src/main/java/org/glom/web/server/ReportGenerator.java:
1398 Break the code up into reusable functions, correct the placement of
1399 titles, and use normal/bold styles as in the reports in the desktop
1402 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1404 ReportGenerator: Add a header band to show the field titles.
1406 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1407 getReportHTML(): Pass the localeId to the ReportGenerator
1409 * src/main/java/org/glom/web/server/ReportGenerator.java
1410 constructor: Take the localeID so we can get translated field
1412 generateReport(), addToReport(), addFieldToBand(): Add field
1413 titles in a column header band.
1415 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1417 Reports drop-down list: Some improvement.
1419 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1420 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1421 Adedd setSelectedReport(),
1422 setReportList(): Add a blank line so that the user can select the
1424 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1425 start(): Show the current report by calling setSelectedReport().
1426 This does not seem to work yet.
1428 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1430 DetailsActivity, ListActivity: Move some variables into a base class.
1432 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1433 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1434 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1435 the clientFactory, documentID, tableName and authenticationPopup into
1436 a base class, to avoid duplication.
1438 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1440 Translate the Reports label.
1442 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1443 Get the "Reports" label string from the constants.
1444 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1445 perties: Add Reports to the constants.
1447 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1449 Reports: Implement grouping.
1451 * src/main/java/org/glom/web/server/ReportGenerator.java:
1452 Handle LayoutItem_GroupBy items and try to do the right thing
1453 with JRDesignGroup. It seems to work.
1455 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1457 Actually show some data with JasperReports.
1459 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1460 getReportHTML(): Move most code into a ReportGenerator class.
1461 * src/main/java/org/glom/web/server/ReportGenerator.java:
1462 Recurse into sub-groups, adding fields to the JasperDesign's details
1463 band. Note that we must set an arbitrary width and height, or it just
1464 will not show any data.
1466 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1468 Reports Chooser: Show the titles, not the names.
1470 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1471 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1472 and the names as the values.
1473 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1474 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1475 group now that we provide the report name, so it should always
1478 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1480 Depend on jasperreports.
1482 * pom.xml: Add the dependency. My plan is to use this on the
1485 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1487 Implement navigation to report places.
1489 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1490 start(): Do not bother to handle all events here.
1491 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1492 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1493 Added getSelectedReport().
1494 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1495 .java: start(): When handling a change to the reports chooser,
1496 call getSelectedReport() and goTo() its ReportPlace.
1497 * src/main/java/org/glom/web/client/ui/ReportView.java
1498 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1499 Added setReportHTML() which puts the html in a gwt HTML widget.
1500 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1501 getReportHTML(): Return "TODO" just to show that this works.
1503 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1505 Make ReportPlace usable.
1507 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1508 Mention ReportPlace.
1509 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1510 Correct the @prefix annotation.
1512 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1514 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1516 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1517 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1518 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1519 Change getReportLayout() to getReportHMTL() because we will not need to
1520 parse or render the report layout on the client side.
1521 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1522 getReportLayout(): Return the libglom LayoutGroup type because we will
1523 not need to convert to a shared type, because this will not be used on
1525 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1528 Note that there is still no implementation for this.
1531 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1533 Add a (empty) Report Place, View, and Activity.
1535 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1537 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1538 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1539 this into a superclass:
1540 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1541 and also use it as the base of this new ReportPlace:
1542 * src/main/java/org/glom/web/client/place/ReportPlace.java
1544 * src/main/java/org/glom/web/client/ui/ReportView.java
1545 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1546 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1547 Add these, containing mostly boiler-plate for now.
1549 * src/main/java/org/glom/web/client/OnlineGlomService.java
1550 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1551 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1552 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1553 Add API to get the LayoutGroup for the report.
1555 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1557 Add and fill a Reports drop-down list box.
1559 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1561 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1562 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1563 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1564 Added getReports(document, table, localeID), calling
1565 ConfiguredDocument.getReports().
1566 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1567 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1568 Added setReportsList() and a list widget.
1569 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1570 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1575 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1577 Translations: Add Esperanto.
1579 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1580 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1581 properties: Add this translation because someone took the time to make it.
1583 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1585 Adapt to the java-libglom 1.21.7 API.
1587 * src/main/java/org/glom/web/server/ReportGenerator.java:
1588 addToReport(): get_group_secondary_fields() is now
1589 get_secondary_fields().
1592 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1594 Use the latest java-libglom version.
1596 * pom.xml: Use java-libglom 1.21.7.
1598 2012-03-03 Ben Konrath <ben@bagu.org>
1600 Display date and time in details view.
1602 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1604 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1606 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1608 Require the latest java-libglom.
1610 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1612 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1614 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1616 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1617 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1618 an empty quickfind string. I also corrected libglom to create only
1619 empty where clauses for empty quickfind strings, but this avoids the
1622 2012-02-24 Ben Konrath <ben@bagu.org>
1624 Improve the tabs in the Notebook widget.
1628 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1630 Translations: Try to translate the strings.
1632 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1633 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1634 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1635 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1636 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1637 Take the Open translation from GTK+'s .po files.
1638 Take the Details translation from Glom's po files.
1639 I have added the other strings to Glom so we can get translations that way:
1640 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1642 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1644 TableSelectionViewImpl: Put the search label and entry in a div.
1646 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1647 Put the search widgets in a FlowTable so that the CSS can be used to
1648 style them while keeping them together.
1649 * src/main/webapp/style.css: Mention the new div.
1651 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1653 Translate more strings in more locales.
1655 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1656 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1657 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1658 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1659 Translate the "Details" and "Open" string too.
1661 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1662 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1663 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1664 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1665 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1666 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1667 Add these new locales as placeholders though they currently contain English.
1669 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1671 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1673 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1674 Check the ConfiguredDocument* for null before using it.
1676 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1678 Tell Eclipse about the generated java files.
1680 * .classpath: This lets it find OnlineGlomConstants.java.
1681 It would be nice if Eclipse just used the maven build files.
1683 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1685 Prevent a crash when no locale is specified in the URL.
1687 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1688 Avoid returning a null string, obtained from
1689 Window.Location.getParameter(). This caused a crash when it was
1690 later passed to libglom's API.
1691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1692 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1693 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1694 guard against future null strings.
1696 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1698 Use the ?locale= query param instead of the &lang= token param.
1700 * src/main/java/org/glom/web/client/place/ListPlace.java
1701 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1702 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1703 Remove the lang token key and value.
1705 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1706 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1707 When the user selects a different locale from the chooser, use
1708 Window.Location.assign() to change the URL, which then causes a reload.
1710 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1711 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1712 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1713 * src/main/java/org/glom/web/client/activity/ListActivity.java
1714 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1715 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1716 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1717 * src/main/java/org/glom/web/client/ui/ListView.java:
1718 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1720 Remove localeID member variables and method/constructor parameters, instead
1721 using Utils.getCurrentLocaleID() when we need a localID to pass to
1724 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1726 Internationalize the UI strings.
1728 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1729 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1730 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1731 because it is unused. Messages are apparently strings that can have
1732 parameters, but we do not need that yet, so Contants will be enough for now.
1733 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1734 to say that we support the en and de locales.
1735 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1736 The original English strings.
1737 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1738 Some German translations of the English strings.
1739 The i18n goal then uses the .properties file to generate an
1740 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1741 returns an implementation that returns the translated strings.
1742 The documentation suggests putting these in src/java/*/client/, but it seems
1743 best to put it in src/resources/*/client/.
1744 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1745 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1746 instead of hard-coding them.
1747 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1748 but that does not seem to stop the build, though it confuses Eclipse.
1750 You can see the translated string by adding ?locale=de to the URL, like so:
1751 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1753 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1755 Improve null/empty String checks.
1757 * pom.xml: Add a dependency on commons-lang, to use
1758 org.apache.commons.lang.StringUtils.
1759 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1760 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1761 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1762 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1763 Use StringUtils.isEmpty().
1765 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1766 StringUtils class with a static isEmpty() function because we
1767 cannot use org.apache.commons.lang.StringUtils in client-side
1768 GWT code because it (apparently) cannot be compiled to javascript.
1769 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1770 * src/main/java/org/glom/web/client/activity/ListActivity.java
1771 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1772 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1773 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1774 * src/main/java/org/glom/web/client/place/ListPlace.java
1775 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1776 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1777 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1778 * src/main/java/org/glom/web/client/ui/details/Group.java
1779 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1780 our StringUtils.isEmpty() function.
1782 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1784 Update to the latest java-libglom API.
1786 * pom.xml: Require java-libglom 1.21.4.
1787 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1788 getDocumentInfo(), getListViewLayoutGroup():
1789 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1791 * src/main/java/org/glom/web/server/database/DBAccess.java
1792 getFieldsToShowForSQLQueryAddGroup(),
1793 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1794 with either get_database_title_original() or
1795 get_database_title(localeID).
1797 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1799 ConfiguredDocument: Avoid a null pointer exception.
1801 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1802 Initialize localeID to "" to avoid returning a null String which
1803 causes a crash in java-libglom's swing-generated code.
1805 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1807 Some simple renaming.
1809 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1810 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1811 for localeChooser. This seems more appropriate and is less ambiguous
1812 particularly in the .css file.
1814 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1816 ConfiguredDocument: Rename the localedID private member variable.
1818 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1820 Adapt to the latest java-libglom API from git master.
1822 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1823 libglom now uses only Vector instead of List, which uses add() instead of
1826 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1828 ConfiguredDocument: Rename the localedID private member variable.
1830 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1832 Build a source tarball with mvn assembly:single
1834 * assembly.xml: Add this file.
1835 * pom.xml: Use the maven-assembly-plugin and tell it to use
1836 our assembly.xml file.
1838 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1840 OnlineGlomServiceImpl: Get .glom files recursively.
1842 * pom.xml: Depend on commons-io from org.apache.commons.
1843 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1844 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1845 files recursively, and with the easier filter for the extension.
1846 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1847 simplify that code too.
1849 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1851 README: Mention that you must install java-libglom packages separately.
1853 But then it works, because java-libglom is now in the central maven
1856 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1858 locales drop-down: Show the correct selected locale when the URL changes.
1860 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1861 .java: setPlace(): Move some code into fillView().
1863 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1865 locales drop-down: Do not lose the primary key.
1867 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1868 start(): onLocaleChange(): Pass the current primary key value,
1869 instead of an empty value.
1871 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1873 locales drop-down: Do not lose the drop-down selection.
1875 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1876 .java (TableSelectionActivity.fillView): Set the selected locale
1877 after changing the drop-down items (though we do not really need
1878 to change them just because the locale changes.)
1880 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1882 locales drop-down: Change the tables list when this changes.
1884 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1885 .java: TableSelectionActivity.start(): Move the async table titles
1886 retrieval into a private fillView() method and also call this when
1887 the chosen locale changes.
1888 Note that the document title is not actually translatable yet, but
1889 that is a problem that I should fix soon in libglom.
1891 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1893 Improve the placement of the locales drop-down.
1895 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1896 Put the title and locales drop-down in a div (gwt.FlowTable).
1897 * src/main/webapp/style.css: Add magic css properties to make this work.
1898 Also remove the left margin from the title so that it lines up with the
1901 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1903 locales selector: Show human-readable locale titles.
1905 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1906 getDocumentInfo(): Use java.util.Locale to show a real title of
1907 each locale, in the locale's own language.
1909 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1911 Add a language/locale selector drop-down.
1913 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1914 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1915 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1916 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1917 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1918 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1919 Add a ListBox to show the available locales. Add getLocaleSelector(),
1920 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1921 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1922 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1923 java: Add these classes.
1924 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1925 start(): Fill the locales ListBox. Handle its change event, firing a
1927 setPlace(): Show the selected locale as specified by the URL token.
1928 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1929 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1930 Handle LocaleChangeEvent, going to a new *Place with that locale.
1932 The placement of the ListBox is not pretty, and it currently uses the ID
1933 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1937 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1939 Search box: Show the search text from the URL token.
1941 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1942 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1943 Add setQuickFindText().
1944 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1945 .java: setPlace(): Store the queryText if the place is a ListPlace,
1946 and call TableSelectionView.setQuickFindText().
1948 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1950 Allow use of translations via, for instance, &lang=de in the URL.
1952 * pom.xml: Use the unstable java-libglom 1.21 version.
1954 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1955 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1956 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1957 init(): Instead of calling TranslatableItem.set_current_locale()
1958 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1959 However, this is only for default locales, which are not needed to
1960 change the locale in the URL.
1961 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1962 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1963 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1964 layout for a particular locale.
1965 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1966 Add get/setDefaultLocaleID().
1967 getDocumentInfo(), getListViewData(), getRelatedListData(),
1968 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1969 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1970 localeID parameter, so we can get the layout for a particular locale.
1972 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1973 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1974 * src/main/java/org/glom/web/client/place/ListPlace.java:
1975 Parse and construct a lang parameter too.
1977 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1978 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1979 passed to subsequent methods and constructors.
1980 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1981 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1982 Store the localeID from the *Place and pass it to other constructors
1983 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1985 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1986 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1987 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1988 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1989 * src/main/java/org/glom/web/client/ui/ListView.java:
1990 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1991 Take localeID parameters and pass them to subsequent constructors and
1992 methods, so that the layout is always retrieved for that locale.
1994 This is rather repetitive.
1996 Note that "" means the original (default) locale of the Glom document,
1997 which is usually English.
1999 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2001 Documents: Remove final keyword to fix startup configuration.
2003 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2004 final keywords on the private member variables because that breaks
2005 the startup, apparently (there are warnings) because it stops them
2006 from being serialized. I added these in the previous commit.
2008 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2010 Documents: Add some final keywords.
2012 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2015 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2017 OnlineGlomServiceImpl: Add to overview comments.
2019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2020 Note that this is where all the document are loaded. They are not
2021 loaded freshly for each page.
2023 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2027 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2028 Add a TextBox for the text of a quick find.
2029 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2031 setBackLink(): Add a String quickFind parameter.
2032 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2033 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2034 to the base interface, because that is how TableSelectionViewImpl is used.
2035 * src/main/webapp/style.css: Add style for the search box and its label.
2037 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2038 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2039 Add these files, based on the existing TableChangeEvent and
2040 TableChangeEventHandlers.
2041 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2042 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2043 a ListPlace() that the user should be taken to.
2044 * src/main/java/org/glom/web/client/activity/ListActivity.java
2045 start(): Handle it here too and adapt the TableChangeEvent handler to
2046 pass the extra "" quickFind parameter to ListPlace.
2047 * src/main/java/org/glom/web/client/place/ListPlace.java:
2048 Constructor: Take an extra String quickFind parameter and store it,
2049 returning it from a new getQuickFind() method.
2050 getToken(): Put the quickFind text in the URL token.
2051 getPlace(): Parse the quickFind text from the URL token.
2052 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2053 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2054 ListPlace constructor.
2055 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2056 .java: start(): Add a Change handler for the TableSelectionView's
2057 TextBox (via its base HasChangeHandlers interface), firing the new
2058 QuickFindChangeEvent.
2059 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2060 pass the extra "" quickFind parameter.
2062 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2063 setCellTable(): Add a String quickFind parameter and pass it to
2064 the ListViewTable() constructor.
2065 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2066 setCellTable() in the base interface, because that is how ListViewImpl
2069 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2070 Add a String quickFind member variable.
2071 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2072 Constructor: Add a String quickFind parameter, storing it in the
2073 base ListTable's member variable.
2074 onRangeChanged(): Pass quickFind to the
2075 OnlineGlomServiceAsync.getSortedListViewData() and
2076 OnlineGlomServiceAsync.getListViewData() methods.
2078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2079 getListViewData(), getSortedListViewData(): Add a String quickFind
2080 parameter, passing it to ConfiguredDocument.getListViewData().
2081 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2082 Change getListViewData(), getSortedListViewData() in the base interface,
2083 because that is how OnlineGlomServiceImpl is used, via this:
2084 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2085 Change getListViewData(), getSortedListViewData() here too.
2086 This class can apparently be used to asynchronously call methods on
2087 OnlineGlomService, and GWT seems to implement that after recognizing
2088 just the *Async name convention and the extra AsyncCallback parameters.
2090 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2091 getListViewData(): Add a String quickFind parameter, and pass it to
2092 ListViewDBAccess.getData().
2093 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2094 getListData(): Add a String quickFind parameter and pass it to
2096 getSelectQuery(): Add a String quickFind parameter.
2097 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2098 getSelectQuery(): Add a String quickFind parameter and use it with
2099 Glom.get_find_where_clause_quick() to pass a where_clause to
2100 Glom.build_sql_select_with_where_clause(), to actually filter the
2102 getData(): Add a String quickFind parameter, passing it to getListData().
2103 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2104 va: getData(): Pass an empty string to getListData() for the
2105 quickFind parameter.
2107 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2109 ListTable: Minor change.
2111 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2112 createCellTable(): Make this protected instead of public.
2114 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2116 Many files: Use final for the parameters and use the @override attribute.
2118 2012-01-22 Ben Konrath <ben@bagu.org>
2120 Add anchor links for single line text that starts with http, ftp and www.
2124 2012-01-22 Ben Konrath <ben@bagu.org>
2126 Add ellipsis to single line text in details view.
2130 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2132 Remove all javadoc author tags.
2134 Because they are awkward and meaningless when many people touch
2136 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2138 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2140 Revert the COPYING.LESSER to COPYING rename.
2142 Apparently both should be there if it is LGPL.
2144 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2146 *View: Remove unused imports.
2148 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2149 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2150 * src/main/java/org/glom/web/client/ui/ListView.java:
2151 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2152 Remove unused imports, as suggested by Eclipse.
2154 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2156 Move the *View::Presenter types, and some API into one base View.
2158 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2159 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2160 * src/main/java/org/glom/web/client/ui/ListView.java:
2161 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2162 Presenter, setPresenter() and clear() into a shared base interface,
2163 to avoid the unnecessary duplicate Presenter types and to more clearly
2164 show how the *Views share the same structure, even if they are not
2165 used polymorphically.
2167 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2168 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2171 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2172 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2174 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2177 Feel free to revert this if there is a good reason for the duplicate
2180 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2182 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2184 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2185 a class member instead of a local variable in the method.
2186 This lets us use it to get the view instances, for use in tests.
2187 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2188 beforeOnlineGlom(): Test some more details of the initial view.
2189 Again, this is not very useful.
2191 To really test gwt-glom we will need to start a local postgresql
2192 instance with local data, like the Glom tests in C++.
2194 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2196 pom.xml: Mention the LGPL license.
2198 * pom.xml: Add a licenses section.
2199 * COPYING.LESSER: Move this to COPYING, which
2200 previously contained the GPL. But gwt-glom is all LGPL.
2202 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2204 Add project information to README and pom.xml.
2206 * README: Add a brief description and mention some mvn
2208 * pom.xml: This extra information shows up in mvn site
2211 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2213 Use the latest java-libglom version.
2215 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2217 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2219 GwtTestOnlineGlom: Test a little more.
2221 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2222 protected rather than private, as suggested by the gwt-test-utils
2224 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2225 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2226 Test the initial visibility of the panels.
2228 However, this is not a very useful test.
2229 And I wonder how we should generally test using this idea for an
2230 activity/places app like ours where the real changes happen implicitly
2231 based on the history token/URL.
2233 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2235 Slight modification to *Mapper comments.
2237 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2238 (DataActivityMapper)
2239 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2241 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2243 Remove comments mentioning GIN because they are just copied from
2244 the example code and are apparently not helpful:
2245 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2246 Also change the mention of a class that is only in the example code.
2248 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2250 GwtTestOnlineGlom test: Minor changes.
2252 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2253 Avoid the long qualified class name and modify the comment
2254 because it is now obvious to me that the mocked class is the only
2255 custom one created via GWT.create().
2257 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2259 Tests: Added the beginnings of a test using gwt-test-utils.
2261 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2262 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2263 which tells gwt-test-utils what class will be tested.
2264 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2265 Add a simple (but empty) test case. One class, used by the OnlineGlom
2266 class, is mocked so that it can be created. However, I am not sure
2267 why only this class needs to be mocked.
2269 Note that mockito seems more popular, and clearer, than easymock,
2270 but I have not got that working yet. It might be a matter of the
2273 This test is run during mvn integration-test.
2275 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2277 Tests: Use junit4-style syntax instead of junit3-style.
2279 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2280 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2281 * src/test/java/org/glom/web/shared/DataItemTest.java:
2282 Use the @Test annotation rather than relying on the test*() prefix.
2283 Also no longer implement TestCase, to avoid triggering support for
2284 the junit3-way, which stops the annotations from working.
2285 Change the imports from import junit.framework.* to
2286 import org.junit.*, which is apparently the new way.
2288 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2290 Added a test for ListPlace token parsing and creation.
2292 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2293 This is much the same as DetailsPlaceTest.
2295 I wonder how we could test the other parts of the *Place API.
2297 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2299 DetailsPlace test: Also test getToken() and recreation via getPlace().
2301 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2302 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2303 recreate it, testing the recreated DetailsPlace for the same parameter
2306 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2308 Use the surefire-report plugin.
2310 * pom.xml: This generates a HTML report about the tests in
2311 target/site/surefire-report.html
2312 when you do mvn surefire-report:report. It seems to be popular/normal.
2314 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2316 Added a test for DetailsPlace.
2318 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2319 Test the getPlace() token parsing.
2321 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2323 Added a first unit test.
2325 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2326 * src/test/java/org/glom/web/shared/DataItemTest.java:
2327 This is a silly test but it is just to get things started. Note that
2328 maven/junit finds the test because it looks in src/test by default.
2330 2011-12-22 Ben Konrath <ben@bagu.org>
2332 Change charsetName to "UTF-8" when replacing line breaks.
2334 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2335 that work in Java (such as "UTF8") will not work when compiled to
2338 This fixes a problem with multi-line details view fields that have hard
2339 line breaks. The "License Text" field on this page demonstrates the
2342 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2344 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2346 2011-12-22 Ben Konrath <ben@bagu.org>
2348 Fix another bug with related list navigation.
2350 I've tested all the navigation buttons in all of the related lists
2351 so things should be good now.
2353 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2355 2011-12-22 Ben Konrath <ben@bagu.org>
2357 Fix a crasher when refreshing the list view with the default table.
2359 This crash will also happen when loading the list view with the default
2360 table from a link or bookmark.
2362 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2363 to the main document selection page when the document id hasn't been
2365 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2366 the main document selection page when the document id hasn't been
2368 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2369 values for the details place when the document id hasn't been set.
2370 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2371 values for the list place when the document id hasn't been set.
2373 2011-12-21 Ben Konrath <ben@bagu.org>
2375 Protect against NPE when glom.document.locale is not in config.
2377 This patch protects against an NPE when glom.document.locale is not in
2378 the config file. This NPE will also happen if glom.document.locale is
2381 The patch also updates the error message to display the class name when
2382 the getMessage() returns null. This was happening when the NPE was
2383 thrown and I had "Configuration Error: null". If an NPE is encountered
2384 with this patch, "Configuration Error: NullPointerException " will be
2387 This commit closes this bug:
2389 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2391 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2393 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2395 Rename onlineglom.properties to onlineglom.properties.sample.
2397 * src/main/resources/onlineglom.properties: Rename to:
2398 * src/main/resources/onlineglom.properties.sample:
2399 * src/main/resources/README: And add this file explaining that people
2400 should rename it back when deploying.
2402 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2404 Allow choosing the translation in the .properties file.
2406 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2407 init(): Read a glom.document.locale value from the configuration file
2408 and call Glom's TransatableItem::set_current_locale() method.
2409 * src/main/resources/onlineglom.properties: Add a commented-out
2410 example of this new setting.
2412 It would be better to add &lang=de_DE to the URL, but the current
2413 libglom API does not allow us to do this easily. I am working on that.
2415 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2417 Avoid a crash in parsing of token parameters.
2419 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2420 ava: getTokenParams(): Do not crash if a parameter has a key but no
2421 value, and ignore parameters with neither.
2423 2011-12-17 Murray Cumming <murrayc@murayc.com>
2425 History token building/handling: Improve use of token parameters.
2427 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2428 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2429 and buildParamsToken(HashMap), for use by derived classes.
2430 Make the separator private because it is no longer be needed.
2431 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2432 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2433 instead of manual string concatenation.
2434 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2435 of hardcoded indices and awkward splitting code.
2436 * src/main/java/org/glom/web/client/place/ListPlace.java
2437 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2438 instead of manual string concatenation.
2439 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2440 of hardcoded indices and awkward splitting code.
2441 This should fix bug #666420
2443 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2445 Fix a Navgiation->Navigation typo in the code.
2447 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2448 Rename processNavgiation() to processNavigation().
2450 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2452 Fix a seperator->separator typo in the code.
2454 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2455 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2456 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2459 2011-12-15 Ben Konrath <ben@bagu.org>
2461 Cleanup some comments.
2463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2465 2011-12-14 Ben Konrath <ben@bagu.org>
2467 Replace \n with <br/> for multiline text in the details view.
2469 Vertical scrollbars are added when needed as well.
2471 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2473 2011-12-14 Ben Konrath <ben@bagu.org>
2475 Specify the font for document selection links.
2477 * src/main/webapp/style.css:
2479 2011-12-14 Ben Konrath <ben@bagu.org>
2481 Fix bouncy CellTable while paging.
2483 This doesn't currently work with related list tables in unselected
2486 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2488 2011-12-14 Ben Konrath <ben@bagu.org>
2490 Revamp the appearance of the document selection page.
2492 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2493 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2494 * src/main/webapp/style.css:
2496 2011-12-13 Ben Konrath <ben@bagu.org>
2498 Set navigation button column to the smallest size possible.
2500 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2502 2011-12-13 Ben Konrath <ben@bagu.org>
2504 Change OpenButton nomenclature to NavigationButton.
2506 Using NavigtionButton makes things more generic. Classes, methods and
2507 variables have been changed.
2509 This is a rename-only refactor.
2511 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2512 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2513 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2514 Renamed from OpenButtonCell.
2515 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2516 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2517 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2519 2011-12-12 Ben Konrath <ben@bagu.org>
2521 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2523 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2524 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2525 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2526 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2528 2011-12-12 Ben Konrath <ben@bagu.org>
2530 Update variable names and comments.
2532 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2533 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2535 2011-12-12 Ben Konrath <ben@bagu.org>
2537 Properly initialize numNonEmptyRows variable to zero.
2539 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2540 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2542 2011-12-05 Ben Konrath <ben@bagu.org>
2544 Add latest mockup with HTML tables.
2546 Features of this mockup:
2548 -> HTML table for flowtable
2549 -> HTML table for flowtable column
2550 -> Example of how related lists would look
2551 -> Not using text entries for data items
2553 The current version of Online Glom doesn't use HTML tables for the
2556 This mockup has been sent to the glom-devel mailing list but it's good
2557 to have it here as well.
2559 * mockups/details-view-html-tables.html:
2561 2011-12-05 Ben Konrath <ben@bagu.org>
2563 Remove unnecessary getPrimaryKeyField() method.
2565 getPrimaryKeyFieldForTable(String) has been renamed to
2566 getPrimaryKeyField(String).
2568 * src/main/java/org/glom/web/server/database/DBAccess.java:
2569 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2570 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2572 2011-12-05 Ben Konrath <ben@bagu.org>
2574 Add string representation of TypedDataItem value to conversion error message.
2576 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2577 message was extracted into its own method to avoid duplication.
2579 2011-12-05 Ben Konrath <ben@bagu.org>
2581 Add type checking to navigation primary key value creation.
2583 Create navigation primary key only if the expected type from the Glom
2584 document matches the type returned by the SQL query.
2586 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2588 2011-12-05 Ben Konrath <ben@bagu.org>
2590 Rename a couple of variables in RelatedListNavigation.
2592 This is a rename-only refactor.
2594 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2596 2011-12-05 Ben Konrath <ben@bagu.org>
2598 Move getListLayoutGroup() into getListViewLayoutGroup().
2600 This removes getListLayoutGroup(). It was only being called by
2601 getListViewLayoutGroup().
2603 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2605 2011-12-05 Ben Konrath <ben@bagu.org>
2607 Remove check for LayoutItem_Portal in list table method.
2609 This check is no longer necessary because the method isn't being used
2610 to create the LayoutItemPortal DTO.
2612 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2614 2011-12-05 Ben Konrath <ben@bagu.org>
2616 Properly support related list navigation.
2618 Navigation from the "Repository Analyzer -> Package Scans ->
2619 Dependencies" related table wasn't working because the primary key for
2620 related tables wasn't being set properly. This commit fixes the
2623 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2624 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2625 doesn't set the primary key properly for related list tables.
2626 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2627 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2628 useful for getting the primary key for list view tables and for related
2630 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2631 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2632 Move code to set the primary key for the table from the abstract
2633 ListDBAccess class to ListViewDBAccess as it's only correct for list
2635 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2636 Properly add primary key to related list tables.
2638 2011-12-02 Ben Konrath <ben@bagu.org>
2640 Properly set the horizontal alignment of fields.
2642 This fix is for both the list tables and the details view.
2644 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2645 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2646 to set the horizontal alignment of fields.
2648 2011-12-02 Ben Konrath <ben@bagu.org>
2650 Display currency codes in the details view.
2652 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2654 2011-12-02 Ben Konrath <ben@bagu.org>
2656 Avoid duplicate JNI call.
2658 JNI is not as efficient as pure Java and this is an easy (and small)
2661 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2662 Use previously retrieved value for whereClauseToTableName instead of
2665 2011-12-02 Ben Konrath <ben@bagu.org>
2667 Rename a couple of variables in RelatedListNavigation.
2669 This is a rename-only refactor.
2671 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2673 2011-12-02 Ben Konrath <ben@bagu.org>
2675 Indicate clearly that a mismatched primary key type is a bug.
2677 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2678 warning to error. Add 'This is a bug.' to message.
2680 2011-12-02 Ben Konrath <ben@bagu.org>
2682 Update / fix some comments.
2684 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2686 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2688 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2689 Fix comments. Add some TODOs.
2691 2011-12-02 Ben Konrath <ben@bagu.org>
2693 Enable navigation to details view with string primary key from related list.
2695 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2696 Create a text primary key value when return type of result is
2697 java.sql.Types.VARCHAR.
2699 2011-12-02 Ben Konrath <ben@bagu.org>
2701 Use checkboxes for booleans in the details view.
2703 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2705 2011-12-01 Ben Konrath <ben@bagu.org>
2707 Improve performance of related list height calculation.
2709 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2710 Put code to calculate the expected height in a static initializer so
2711 that that it's only called once.
2713 2011-12-01 Ben Konrath <ben@bagu.org>
2715 Show related list tables in notebooks (again).
2717 Calculate the height of the related list tables so the Notebook can be
2718 set the correct height. The height of the related list table is also needed by
2719 FlowTable to be able decide how to create the layout.
2721 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2722 and set the Portal height based on the height of the related list
2723 table and the Portal container.
2724 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2725 Add method to calculate the height of the related list tables.
2726 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2727 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2728 calculate the height of the Pager widget.
2730 2011-12-01 Ben Konrath <ben@bagu.org>
2732 Use CellTable API for table property instead of setting style on Element.
2734 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2736 2011-12-01 Ben Konrath <ben@bagu.org>
2738 Make ListViewTable and RelatedListTable a consistent height.
2740 The tables are now a consistent height regardless of the contents of
2741 the table. A hidden button is added to empty rows to ensure that the
2742 height of these rows will match the height of rows with data.
2744 A navigation button column is now added to every table. The width of
2745 the navigation column is set to 0px when a RelatedListTable shouldn't
2746 have navigation buttons. This maintains the a consistent row height in
2747 tables that don't show the navigation buttons.
2749 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2750 navigation column when not needed.
2751 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2752 arguments for navigation button to constructor of ListViewTable.
2753 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2754 hidden button for empty data rows.
2755 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2756 arguments for navigation button to constructor.
2757 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2758 create navigation buttons. Add hideNavigationButtons() method.
2759 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2760 arguments for navigation button to constructor.
2762 2011-12-01 Ben Konrath <ben@bagu.org>
2764 Use 'visibility: hidden' in Utils.getWidgetHeight().
2766 This is better choice because hidden elements are invisible, don't
2767 respond to events and are not part of the tab order. They will,