1 2012-05-07 Murray Cumming <murrayc@murrayc.com>
3 ConfiguredDocument: Restore correct addition of hidden primary key items.
5 * src/main/java/org/glom/web/client/ui/list/ListTable.java
6 (ListTable.createCellTable): Uncomment out the check for the hidden
8 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
9 add primary key items for top-level lists and portals, as before,
10 instead of adding them to each group.
11 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
12 Actually implement the extra methods such as setHiddenPrimaryKey() and
13 comment that these are used only for top-level list groups and in portals.
14 This strangeness suggests even more that this should not be squeezed
15 into the LayoutGroup class.
17 2012-05-07 Murray Cumming <murrayc@murrayc.com>
19 Fix Formatting loading.
21 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
22 getFormattingUsed(): Remove the duplicate Formatting member variable
23 in favour of the one from the base class.
24 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
25 Initialize a new Formatting instead of using null by default, so we
26 have some defaults, instead of having to initialize one later just to
27 get the same defaults. This also makes loading of formatting from the
28 document work, because that expected a non-null.
30 2012-05-07 Murray Cumming <murrayc@murrayc.com>
32 RelatedListTable: Make sure that the tableName is set.
34 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
35 Constructor: Take the tableName so it is available later. Otherwise,
36 the server assumes that we mean the default table and cannot find the
38 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
39 setData(): Pass the tableName to the RelatedListTable constructor.
41 2012-05-07 Murray Cumming <murrayc@murrayc.com>
45 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
46 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
47 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
49 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
51 * src/main/java/org/glom/web/server/database/DBAccess.java:
52 convertResultSetToDTO(), getPortal():
53 * src/main/java/org/glom/web/server/database/ListDBAccess.java
55 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
56 Add checks for null objects and out of range access, with log messages to
57 give hints so we can fix these properly.
59 2012-05-07 Murray Cumming <murrayc@murrayc.com>
61 Portals: some corrections.
63 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
65 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
66 constructor: Use getRelationshipNameUsed() instead of getName(), because
67 that is what is meant.
68 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
69 getFromField(): Fix a typo, to get the field name, not the table name.
70 * src/main/java/org/glom/web/server/database/DBAccess.java:
71 getPortal(): Fix a typo that stopped this from working.
73 2012-05-07 Murray Cumming <murrayc@murrayc.com>
75 LayoutItemPortal: Also override getTitleOriginal().
77 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
78 This lets the base getTitle() with no parameters work.
79 TODO: Test this properly.
81 2012-05-06 Murray Cumming <murrayc@murrayc.com>
83 LayoutItemPortal: getTitle*(): Use the relationship title.
85 2012-05-06 Murray Cumming <murrayc@murrayc.com>
87 LayoutItemField: Fix loading of custom titles.
89 * src/main/java/org/glom/web/server/libglom/Document.java
90 loadDataLayoutItemField(): The title, if any, instead of the field
91 title, is stored in a title_custom node. Load it from there.
92 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
94 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
95 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
96 getTitle*() overrides.
97 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
100 2012-05-06 Murray Cumming <murrayc@murrayc.com>
102 LayoutItemField: Fall back to field titles, so some are really shown.
104 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
105 Override getTitleOriginal() and getTitle(), as in java-libglom.
106 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
109 2012-05-06 Murray Cumming <murrayc@murrayc.com>
111 Correct use of setExpectedResultSize().
113 * src/main/java/org/glom/web/server/ConfiguredDocument.java
114 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
115 Use setExpectedResultSize only on top-level groups (for instance, the
116 list layout) or on child portals (in details views).
117 Use the correct table name for portals to avoid SQL errors.
118 Update the expected counts when returning cached layouts.
120 2012-05-06 Murray Cumming <murrayc@murrayc.com>
122 Document: Interpret no group column count as 1.
124 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
125 default, though we now check for this in the UI code anyway.
127 2012-05-06 Murray Cumming <murrayc@murrayc.com>
131 2012-05-06 Murray Cumming <murrayc@murrayc.com>
133 Translatable: Use Hashmap instead of Treemap because GWT supports it.
135 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
136 The use of Treemap lead to this error from async methods, with no
138 "The response could not be deserialized"
140 2012-05-06 Murray Cumming <murrayc@murrayc.com>
142 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
144 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
145 when using the Google -> GWT Compile, or
146 g toolbar button -> GWT Compile Project... feature in Eclipse.
148 2012-05-06 Murray Cumming <murrayc@murrayc.com>
150 ListTable.addColumn(): Protect against a null Formatting.
152 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
153 Create a default Formatting if it is null, because that is the simplest
156 2012-05-06 Murray Cumming <murrayc@murrayc.com>
158 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
160 * src/main/java/org/glom/web/server/ConfiguredDocument.java
161 updateLayoutGroup(): Check that the field is not null.
163 2012-05-06 Murray Cumming <murrayc@murrayc.com>
165 ListViewImpl: Protected against a bad cast error.
167 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
168 onEnterKeyDown(): Do not cast without an instanceof check.
170 2012-05-06 Murray Cumming <murrayc@murrayc.com>
172 ListTable: Protect against an out of range error.
174 * src/main/java/org/glom/web/client/ui/list/ListTable.java
175 createCellTable(): This is unlikely, but can happen while debugging.
177 2012-05-06 Murray Cumming <murrayc@murrayc.com>
179 AsyncMessage onFailure() callbacks: Log the exception message.
181 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
182 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
183 * src/main/java/org/glom/web/client/activity/ListActivity.java:
184 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
185 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
186 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
187 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
188 These are useful clues when something is wrong.
190 2012-05-06 Murray Cumming <murrayc@murrayc.com>
192 ConfiguredDocument: Avoid a null dereference.
194 * src/main/java/org/glom/web/server/ConfiguredDocument.java
195 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
196 details maps are created.
198 2012-05-06 Murray Cumming <murrayc@murrayc.com>
200 Document: Correct the port number parsing.
202 * src/main/java/org/glom/web/server/libglom/Document.java:
203 This lets us actually connect to the database and show the document.
205 2012-05-05 Murray Cumming <murrayc@murrayc.com>
209 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
210 user-interaction, asking us to load a temporary URL in a browser.s
211 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
212 which is apparently necessary for testing the service. See the comment.
213 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
214 Show the exception, if any. This is how I saw the 404 in the HTML in
217 2012-05-05 Murray Cumming <murrayc@murrayc.com>
219 DocumentTest: Move the .glom files into the resources directory.
221 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
222 URI via getResource().
224 2012-05-05 Murray Cumming <murrayc@murrayc.com>
226 Document: Remove the FieldIdentifies inner class.
228 * src/main/java/org/glom/web/server/libglom/Document.java: We only
229 use the Relationship (though the same function in libglom is maybe
230 used in other ways) and so this removes a compiler warning.
232 2012-05-05 Murray Cumming <murrayc@murrayc.com>
234 Document.load() Remove the error code parameter.
236 * src/main/java/org/glom/web/server/libglom/Document.java: load():
237 Remove the parameter. We do not set it yet and it could never have
238 worked as an output parameter (though maybe it did in java-libglom).
239 We could use an exception if we really want the failure reason.
240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
242 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
243 setUp(), testGetSuitableTableToViewDetails(): Adapt.
245 2012-05-05 Murray Cumming <murrayc@murrayc.com>
247 Make some inner classes static.
249 * src/main/java/org/glom/web/server/ConfiguredDocument.java
250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
251 * src/main/java/org/glom/web/server/ReportGenerator.java
252 * src/main/java/org/glom/web/server/libglom/Document.java
253 Make all inner classes static that can be static.
255 2012-05-05 Murray Cumming <murrayc@murrayc.com>
257 OnlineGlomServiceImpl: Do not load and check for java-libglom.
259 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
260 init(): We do not use java-libglom any more.
262 2012-05-05 Murray Cumming <murrayc@murrayc.com>
264 Remove mentions of java-libglom.
266 * README: Remove mention of java-libglom, because it no longer needed.
267 * utils/build-onlineglom-war.sh:
268 * utils/check-and-recover-tomcat.py:
269 * utils/install-onlineglom-war.sh: Remove these as they are no longer
270 useful. Building is now far easier, with no need for jhbuild.
272 2012-05-05 Murray Cumming <murrayc@murrayc.com>
274 Fix the build (mvn package)
276 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
277 (LayoutGroup): Make the LayoutItemList inner class static and protected.
278 Otherwise the GWT Java->Javascript compilation fails with just this
279 error, during mvn package or when attempting to view in a browser,
280 in the GWT developer mode in Eclipse.
282 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
283 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
284 [INFO] Compiling module org.glom.web.OnlineGlom
285 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
286 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
287 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
288 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
289 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
290 [INFO] [ERROR] Cannot proceed due to previous errors
292 It has taken me 2 days to find out what was causing that. After reducing
293 the code, the compiler eventually showed me the full error message.
295 2012-05-04 Murray Cumming <murrayc@murrayc.com>
297 ConfiguredDocument: Cache the cloned and stripped layouts.
299 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
300 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
301 layout in a map, so we can retrieve it again without rebuilding it.
303 2012-05-04 Murray Cumming <murrayc@murrayc.com>
305 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
307 2012-05-04 Murray Cumming <murrayc@murrayc.com>
309 libglom classes: Implement some auto-generated emthods.
311 2012-05-04 Murray Cumming <murrayc@murrayc.com>
313 Add GwtTestOnlineGlomService.
315 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
316 However, this (and the other GwtTest*) does not seem to run during
319 2012-05-04 Murray Cumming <murrayc@murrayc.com>
321 Remove use of unsupported features from client code.
323 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
324 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
325 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
326 Use our client version of StringUtils instead of the apache commons one.
328 However, the GWT Javascript compliation still fails.
330 2012-04-25 Murray Cumming <murrayc@murrayc.com>
332 Add a Field class and implement some loading of it in Document.
334 2012-04-25 Murray Cumming <murrayc@murrayc.com>
336 Initial Document loading implementation, instead of libglom.
338 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
339 and Translatable classes, and adapt the rest of the code to use them.
340 However, this is still missing Layout and Field classes and loading.
342 2012-04-24 Murray Cumming <murrayc@murrayc.com>
344 Use of jOOQ: Move Field creation into a utility method.
346 * src/main/java/org/glom/web/server/SqlUtils.java:
347 This lets us improve it more easily.
349 2012-04-24 Murray Cumming <murrayc@murrayc.com>
351 Use of jOOQ: Improve the code to COUNT a sub-select.
353 * src/main/java/org/glom/web/server/SqlUtils.java:
354 Move initial query creation into
355 build_sql_select_step_with_where_clause().
356 build_sql_select_count_rows(): Use the jOOQ API instead of
357 concatentating text, because a jOOQ Select*Step is a TableLike,
358 which is what from() takes.
360 2012-04-23 Murray Cumming <murrayc@murrayc.com>
362 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
364 * pom.xml: Depend on jooq.
365 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
366 methods with jOOQ, based on the C++ implementations in libglom,
367 with some changes to the logic required by jooQ.
368 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
370 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
371 * src/main/java/org/glom/web/server/ReportGenerator.java:
372 * src/main/java/org/glom/web/server/SqlUtils.java:
373 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
374 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
375 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
376 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
377 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
378 Adapt. In particular, the SqlUtils methods now need to take a Connection,
379 because jOOQ needs that, though it seems unnecessary.
381 This is not quite finished. Ideally jOOQ would help us to build
382 table_name.field_name names, quoting and escaping them properly.
383 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
385 2012-04-21 Murray Cumming <murrayc@murrayc.com>
387 Move use of Glom.build_sql*() into a new SqlUtils class.
389 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
390 to wrap Glom.build_sql*(). The parameter types are still Glom one,
391 but this will make it easier to start using something other than
392 libglom or SqlBuilder.
394 2012-04-21 Murray Cumming <murrayc@murrayc.com>
396 Update the project URL.
398 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
400 2012-04-21 Murray Cumming <murrayc@murrayc.com>
402 Main layout: Use a FlowTable instead of absolute positioning.
404 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
405 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
406 child panels/widgets must have an absolute position. But that is annoying, so
407 this adds a FlowTable and puts the child panels in there.
409 2012-04-21 Murray Cumming <murrayc@murrayc.com>
411 GwtTestOnlineGlom: Comment out unused code.
413 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
414 Eclipse has started to say that some code is unused.
416 2012-04-21 Murray Cumming <murrayc@murrayc.com>
418 Update to the latest versions of dependencies.
420 * pom.xml: Update version numbers of dependencies to the latest
422 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
423 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
424 * src/main/java/org/glom/web/server/ReportGenerator.java:
425 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
426 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
427 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
429 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
430 Modify the imports where necessary.
432 2012-04-17 Murray Cumming <murrayc@murrayc.com>
434 Style: Remove overflow:hidden from searchbox
436 * src/main/webapp/style.css: Because this pushes the Back To Link
437 label/link on to the next row, which is then hidden due to the
438 hard-coded (in ems) height.
440 2012-04-20 Murray Cumming <murrayc@murrayc.com>
442 Remove some duplicate code.
444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
445 getDocumentInfo(): This must have been duplicated during the merge from the
450 2012-04-19 Murray Cumming <murrayc@murrayc.com>
452 Reports: Localize the waiting for report message.
454 * src/main/java/org/glom/web/client/activity/ReportActivity.java
455 start(): Get the message from the contants.
456 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
458 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
459 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
460 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
461 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
462 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
463 Update these files with the English text for newer strings for now.
465 2012-04-19 Murray Cumming <murrayc@murrayc.com>
467 Reports: Show a message while waiting for the report.
469 * src/main/java/org/glom/web/client/ui/ReportView.java
470 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
471 Add setWaitingText(), to show a message saying that we are
472 waiting for the report to be ready.
473 * src/main/java/org/glom/web/client/activity/ReportActivity.java
474 start(): Call setWaitingText() before calling the async
477 2012-04-19 Murray Cumming <murrayc@murrayc.com>
479 ReportGenerator: Specify date and time formats.
481 * src/main/java/org/glom/web/server/ReportGenerator.java:
482 createFieldValueElement(): Use the default (and localized)
483 short formats, though we still need a way to show 4-digit
484 years without providing the format for every locale.
485 * src/main/java/org/glom/web/server/database/DBAccess.java:
486 convertResultSetToDTO(): Use the short formats here too.
488 2012-04-18 Murray Cumming <murrayc@murrayc.com>
490 ReportGenerator: Use the correct numeric formatting.
492 * src/main/java/org/glom/web/server/ReportGenerator.java
493 createFieldExpression(), createFieldValueElement(): Take the
494 whole LayoutItem_Field instead of just the field name, so
495 we have access to the formatting.
496 createFieldValueElement(): Use JRTextField.setPattern() to
497 specify the numeric formatting, with the help of a
498 regular DecimalFormat.
500 2012-04-18 Murray Cumming <murrayc@murrayc.com>
502 ReportGenerator: Avoid showing null for group by titles.
504 * src/main/java/org/glom/web/server/ReportGenerator.java
505 generateReport(): Use setBlankWhenNull() on the field title
506 style too, because this is used for values in group by
509 2012-04-18 Murray Cumming <murrayc@murrayc.com>
511 ReportGenerator: Add a colon to titles in vertical groups.
513 * src/main/java/org/glom/web/server/ReportGenerator.java
514 addFieldToDetailBandVertical(): Pass true for the withColon
517 2012-04-18 Murray Cumming <murrayc@murrayc.com>
519 ReportGenerator: Simplify the code by using Position more.
521 2012-04-18 Murray Cumming <murrayc@murrayc.com>
523 Reports: Support vertical groups, roughly.
525 * src/main/java/org/glom/web/server/ReportGenerator.java:
526 addToReport(): Rename to addGroupToReport() and, if necessary,
527 call the new addVerticalGroupToReport() method.
528 createFieldValueElement(): Let the caller specify the Y position
531 2012-04-17 Murray Cumming <murrayc@murrayc.com>
533 Reports: Allow a second report to be shown.
535 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
536 clear(): Do not remove the HTML widget, which broke the whole layout.
538 2012-04-17 Murray Cumming <murrayc@murrayc.com>
540 Locales drop-down: Show that we use English by default.
542 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
543 fillView(): When we use English, just because that is the default, when
544 no locale is specified, show that in the Locales drop-down instead of
545 just showing the first item.
547 2012-04-17 Murray Cumming <murrayc@murrayc.com>
549 Unselect the Report/Locale/Table combo item when appropriate.
551 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
552 setPlace(): clear reportName if this is not a ReportPlace.
553 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
554 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
555 When the provided name is empty, unselect all items, so that none are
556 indicated. This uses a for loop because I cannot find a single method
559 2012-04-17 Murray Cumming <murrayc@murrayc.com>
561 Report: Give the user a way to get back to the list.
563 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
564 start(), setPlace(): Show the Back To List link on reports, and also
565 interpret selecting the empty report item as back to list.
567 2012-04-13 Murray Cumming <murrayc@murrayc.com>
569 Really show the selected Report name.
571 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
572 setPlace(): Store the reportName here, if it is that kind of Place.
573 fillView(): Set the selected Report after filling the list of reports.
574 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
575 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
576 null Strings, though we need some way to unselect all ListBox items
579 2012-04-13 Murray Cumming <murrayc@murrayc.com>
581 ReportGenerator: Try to avoid some problems.
583 * src/main/java/org/glom/web/server/ReportGenerator.java
584 addField(): Try to avoid duplicates, and avoid using a null
587 2012-04-13 Murray Cumming <murrayc@murrayc.com>
589 Reports: Use quickFind.
591 * src/main/java/org/glom/web/client/OnlineGlomService.java;
592 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
594 getReportHTML(): Add a quickFind parameter.
595 * src/main/java/org/glom/web/client/activity/ReportActivity.java
596 start(): Pass the quickFind parameter.
597 * src/main/java/org/glom/web/server/ReportGenerator.java
598 generateReport(): Take a quickFind parameter.
600 2012-04-13 Murray Cumming <murrayc@murrayc.com>
602 ReportPlace: Actually use the report name.
604 * src/main/java/org/glom/web/client/place/ReportPlace.java
605 getPlace(): Do not assign the report name to the quickfind.
607 2012-04-13 Murray Cumming <murrayc@murrayc.com>
609 Show java.library.path when complaining.
611 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
612 init(): When telling us to check java.library.path, show the
615 2012-03-06 Murray Cumming <murrayc@murrayc.com>
617 ReportGenerator: Do not show nulls.
619 2012-03-06 Murray Cumming <murrayc@murrayc.com>
621 ReportGenerator: Make the title font larger.
623 2012-03-06 Murray Cumming <murrayc@murrayc.com>
625 ReportGenerator: Put field titles inside groups, if there are groups.
627 2012-03-06 Murray Cumming <murrayc@murrayc.com>
629 ReportGenerator: Take the Report itself instead of the name and group.
631 * src/main/java/org/glom/web/server/ConfiguredDocument.java
632 Remove getReportLayoutGroup().
633 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
634 getReportHTML(): Pass the report instead
635 of its name and layout group.
636 * src/main/java/org/glom/web/server/ReportGenerator.java
637 generateReport(): Use the report object to use the title
640 2012-03-06 Murray Cumming <murrayc@murrayc.com>
642 ReportGenerator: Remove designBand parameters.
644 * src/main/java/org/glom/web/server/ReportGenerator.java:
645 Make designBand a class member instead of passing it to all
648 2012-03-06 Murray Cumming <murrayc@murrayc.com>
650 ReportGenerator: Add lines, a bit like in the desktop version.
652 * src/main/java/org/glom/web/server/ReportGenerator.java
653 addToReport(): Use JRDesignLine.
655 2012-03-06 Murray Cumming <murrayc@murrayc.com>
657 ReportGenerator: Correct the title positions and use some bold style.
659 * src/main/java/org/glom/web/server/ReportGenerator.java:
660 Break the code up into reusable functions, correct the placement of
661 titles, and use normal/bold styles as in the reports in the desktop
664 2012-03-06 Murray Cumming <murrayc@murrayc.com>
666 ReportGenerator: Add a header band to show the field titles.
668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
669 getReportHTML(): Pass the localeId to the ReportGenerator
671 * src/main/java/org/glom/web/server/ReportGenerator.java
672 constructor: Take the localeID so we can get translated field
674 generateReport(), addToReport(), addFieldToBand(): Add field
675 titles in a column header band.
677 2012-03-05 Murray Cumming <murrayc@murrayc.com>
679 Reports drop-down list: Some improvement.
681 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
682 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
683 Adedd setSelectedReport(),
684 setReportList(): Add a blank line so that the user can select the
686 * src/main/java/org/glom/web/client/activity/ReportActivity.java
687 start(): Show the current report by calling setSelectedReport().
688 This does not seem to work yet.
690 2012-03-05 Murray Cumming <murrayc@murrayc.com>
692 DetailsActivity, ListActivity: Move some variables into a base class.
694 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
695 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
696 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
697 the clientFactory, documentID, tableName and authenticationPopup into
698 a base class, to avoid duplication.
700 2012-03-05 Murray Cumming <murrayc@murrayc.com>
702 Translate the Reports label.
704 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
705 Get the "Reports" label string from the constants.
706 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
707 perties: Add Reports to the constants.
709 2012-03-05 Murray Cumming <murrayc@murrayc.com>
711 Reports: Implement grouping.
713 * src/main/java/org/glom/web/server/ReportGenerator.java:
714 Handle LayoutItem_GroupBy items and try to do the right thing
715 with JRDesignGroup. It seems to work.
717 2012-03-04 Murray Cumming <murrayc@murrayc.com>
719 Actually show some data with JasperReports.
721 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
722 getReportHTML(): Move most code into a ReportGenerator class.
723 * src/main/java/org/glom/web/server/ReportGenerator.java:
724 Recurse into sub-groups, adding fields to the JasperDesign's details
725 band. Note that we must set an arbitrary width and height, or it just
726 will not show any data.
728 2012-03-04 Murray Cumming <murrayc@murrayc.com>
730 Reports Chooser: Show the titles, not the names.
732 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
733 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
734 and the names as the values.
735 * src/main/java/org/glom/web/server/ConfiguredDocument.java
736 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
737 group now that we provide the report name, so it should always
740 2012-02-15 Murray Cumming <murrayc@murrayc.com>
742 Depend on jasperreports.
744 * pom.xml: Add the dependency. My plan is to use this on the
747 2012-01-31 Murray Cumming <murrayc@murrayc.com>
749 Implement navigation to report places.
751 * src/main/java/org/glom/web/client/activity/ReportActivity.java
752 start(): Do not bother to handle all events here.
753 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
754 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
755 Added getSelectedReport().
756 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
757 .java: start(): When handling a change to the reports chooser,
758 call getSelectedReport() and goTo() its ReportPlace.
759 * src/main/java/org/glom/web/client/ui/ReportView.java
760 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
761 Added setReportHTML() which puts the html in a gwt HTML widget.
762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
763 getReportHTML(): Return "TODO" just to show that this works.
765 2012-01-31 Murray Cumming <murrayc@murrayc.com>
767 Make ReportPlace usable.
769 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
771 * src/main/java/org/glom/web/client/place/ReportPlace.java:
772 Correct the @prefix annotation.
774 2012-01-31 Murray Cumming <murrayc@murrayc.com>
776 OnlineGlomService: Return report HTML rather than the LayoutGroup.
778 * src/main/java/org/glom/web/client/OnlineGlomService.java:
779 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
780 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
781 Change getReportLayout() to getReportHMTL() because we will not need to
782 parse or render the report layout on the client side.
783 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
784 getReportLayout(): Return the libglom LayoutGroup type because we will
785 not need to convert to a shared type, because this will not be used on
787 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
790 Note that there is still no implementation for this.
793 2012-01-27 Murray Cumming <murrayc@murrayc.com>
795 Add a (empty) Report Place, View, and Activity.
797 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
799 * src/main/java/org/glom/web/client/place/HasTablePlace.java
800 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
801 this into a superclass:
802 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
803 and also use it as the base of this new ReportPlace:
804 * src/main/java/org/glom/web/client/place/ReportPlace.java
806 * src/main/java/org/glom/web/client/ui/ReportView.java
807 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
808 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
809 Add these, containing mostly boiler-plate for now.
811 * src/main/java/org/glom/web/client/OnlineGlomService.java
812 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
813 * src/main/java/org/glom/web/server/ConfiguredDocument.java
814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
815 Add API to get the LayoutGroup for the report.
817 2012-01-23 Murray Cumming <murrayc@murrayc.com>
819 Add and fill a Reports drop-down list box.
821 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
823 * src/main/java/org/glom/web/client/OnlineGlomService.java:
824 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
826 Added getReports(document, table, localeID), calling
827 ConfiguredDocument.getReports().
828 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
829 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
830 Added setReportsList() and a list widget.
831 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
832 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
837 2012-04-12 Murray Cumming <murrayc@murrayc.com>
839 Translations: Add Esperanto.
841 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
842 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
843 properties: Add this translation because someone took the time to make it.
845 2012-03-15 Murray Cumming <murrayc@murrayc.com>
847 Adapt to the java-libglom 1.21.7 API.
849 * src/main/java/org/glom/web/server/ReportGenerator.java:
850 addToReport(): get_group_secondary_fields() is now
851 get_secondary_fields().
854 2012-03-15 Murray Cumming <murrayc@murrayc.com>
856 Use the latest java-libglom version.
858 * pom.xml: Use java-libglom 1.21.7.
860 2012-03-03 Ben Konrath <ben@bagu.org>
862 Display date and time in details view.
864 https://bugzilla.gnome.org/show_bug.cgi?id=671257
866 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
868 2012-03-05 Murray Cumming <murrayc@murrayc.com>
870 Require the latest java-libglom.
872 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
874 2012-03-04 Murray Cumming <murrayc@murrayc.com>
876 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
878 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
879 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
880 an empty quickfind string. I also corrected libglom to create only
881 empty where clauses for empty quickfind strings, but this avoids the
884 2012-02-24 Ben Konrath <ben@bagu.org>
886 Improve the tabs in the Notebook widget.
890 2012-01-30 Murray Cumming <murrayc@murrayc.com>
892 Translations: Try to translate the strings.
894 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
895 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
896 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
897 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
898 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
899 Take the Open translation from GTK+'s .po files.
900 Take the Details translation from Glom's po files.
901 I have added the other strings to Glom so we can get translations that way:
902 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
904 2012-01-27 Murray Cumming <murrayc@murrayc.com>
906 TableSelectionViewImpl: Put the search label and entry in a div.
908 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
909 Put the search widgets in a FlowTable so that the CSS can be used to
910 style them while keeping them together.
911 * src/main/webapp/style.css: Mention the new div.
913 2012-01-27 Murray Cumming <murrayc@murrayc.com>
915 Translate more strings in more locales.
917 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
918 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
919 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
920 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
921 Translate the "Details" and "Open" string too.
923 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
924 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
925 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
926 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
927 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
928 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
929 Add these new locales as placeholders though they currently contain English.
931 2012-01-27 Murray Cumming <murrayc@murrayc.com>
933 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
935 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
936 Check the ConfiguredDocument* for null before using it.
938 2012-01-26 Murray Cumming <murrayc@murrayc.com>
940 Tell Eclipse about the generated java files.
942 * .classpath: This lets it find OnlineGlomConstants.java.
943 It would be nice if Eclipse just used the maven build files.
945 2012-01-26 Murray Cumming <murrayc@murrayc.com>
947 Prevent a crash when no locale is specified in the URL.
949 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
950 Avoid returning a null string, obtained from
951 Window.Location.getParameter(). This caused a crash when it was
952 later passed to libglom's API.
953 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
954 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
955 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
956 guard against future null strings.
958 2012-01-26 Murray Cumming <murrayc@murrayc.com>
960 Use the ?locale= query param instead of the &lang= token param.
962 * src/main/java/org/glom/web/client/place/ListPlace.java
963 * src/main/java/org/glom/web/client/place/DetailsPlace.java
964 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
965 Remove the lang token key and value.
967 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
968 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
969 When the user selects a different locale from the chooser, use
970 Window.Location.assign() to change the URL, which then causes a reload.
972 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
973 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
974 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
975 * src/main/java/org/glom/web/client/activity/ListActivity.java
976 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
977 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
978 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
979 * src/main/java/org/glom/web/client/ui/ListView.java:
980 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
982 Remove localeID member variables and method/constructor parameters, instead
983 using Utils.getCurrentLocaleID() when we need a localID to pass to
986 2012-01-26 Murray Cumming <murrayc@murrayc.com>
988 Internationalize the UI strings.
990 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
991 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
992 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
993 because it is unused. Messages are apparently strings that can have
994 parameters, but we do not need that yet, so Contants will be enough for now.
995 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
996 to say that we support the en and de locales.
997 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
998 The original English strings.
999 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1000 Some German translations of the English strings.
1001 The i18n goal then uses the .properties file to generate an
1002 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1003 returns an implementation that returns the translated strings.
1004 The documentation suggests putting these in src/java/*/client/, but it seems
1005 best to put it in src/resources/*/client/.
1006 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1007 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1008 instead of hard-coding them.
1009 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1010 but that does not seem to stop the build, though it confuses Eclipse.
1012 You can see the translated string by adding ?locale=de to the URL, like so:
1013 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1015 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1017 Improve null/empty String checks.
1019 * pom.xml: Add a dependency on commons-lang, to use
1020 org.apache.commons.lang.StringUtils.
1021 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1023 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1024 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1025 Use StringUtils.isEmpty().
1027 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1028 StringUtils class with a static isEmpty() function because we
1029 cannot use org.apache.commons.lang.StringUtils in client-side
1030 GWT code because it (apparently) cannot be compiled to javascript.
1031 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1032 * src/main/java/org/glom/web/client/activity/ListActivity.java
1033 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1034 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1035 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1036 * src/main/java/org/glom/web/client/place/ListPlace.java
1037 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1038 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1039 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1040 * src/main/java/org/glom/web/client/ui/details/Group.java
1041 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1042 our StringUtils.isEmpty() function.
1044 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1046 Update to the latest java-libglom API.
1048 * pom.xml: Require java-libglom 1.21.4.
1049 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1050 getDocumentInfo(), getListViewLayoutGroup():
1051 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1053 * src/main/java/org/glom/web/server/database/DBAccess.java
1054 getFieldsToShowForSQLQueryAddGroup(),
1055 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1056 with either get_database_title_original() or
1057 get_database_title(localeID).
1059 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1061 ConfiguredDocument: Avoid a null pointer exception.
1063 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1064 Initialize localeID to "" to avoid returning a null String which
1065 causes a crash in java-libglom's swing-generated code.
1067 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1069 Some simple renaming.
1071 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1072 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1073 for localeChooser. This seems more appropriate and is less ambiguous
1074 particularly in the .css file.
1076 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1078 ConfiguredDocument: Rename the localedID private member variable.
1080 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1082 Adapt to the latest java-libglom API from git master.
1084 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1085 libglom now uses only Vector instead of List, which uses add() instead of
1088 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1090 ConfiguredDocument: Rename the localedID private member variable.
1092 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1094 Build a source tarball with mvn assembly:single
1096 * assembly.xml: Add this file.
1097 * pom.xml: Use the maven-assembly-plugin and tell it to use
1098 our assembly.xml file.
1100 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1102 OnlineGlomServiceImpl: Get .glom files recursively.
1104 * pom.xml: Depend on commons-io from org.apache.commons.
1105 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1106 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1107 files recursively, and with the easier filter for the extension.
1108 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1109 simplify that code too.
1111 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1113 README: Mention that you must install java-libglom packages separately.
1115 But then it works, because java-libglom is now in the central maven
1118 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1120 locales drop-down: Show the correct selected locale when the URL changes.
1122 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1123 .java: setPlace(): Move some code into fillView().
1125 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1127 locales drop-down: Do not lose the primary key.
1129 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1130 start(): onLocaleChange(): Pass the current primary key value,
1131 instead of an empty value.
1133 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1135 locales drop-down: Do not lose the drop-down selection.
1137 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1138 .java (TableSelectionActivity.fillView): Set the selected locale
1139 after changing the drop-down items (though we do not really need
1140 to change them just because the locale changes.)
1142 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1144 locales drop-down: Change the tables list when this changes.
1146 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1147 .java: TableSelectionActivity.start(): Move the async table titles
1148 retrieval into a private fillView() method and also call this when
1149 the chosen locale changes.
1150 Note that the document title is not actually translatable yet, but
1151 that is a problem that I should fix soon in libglom.
1153 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1155 Improve the placement of the locales drop-down.
1157 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1158 Put the title and locales drop-down in a div (gwt.FlowTable).
1159 * src/main/webapp/style.css: Add magic css properties to make this work.
1160 Also remove the left margin from the title so that it lines up with the
1163 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1165 locales selector: Show human-readable locale titles.
1167 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1168 getDocumentInfo(): Use java.util.Locale to show a real title of
1169 each locale, in the locale's own language.
1171 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1173 Add a language/locale selector drop-down.
1175 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1176 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1177 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1178 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1179 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1180 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1181 Add a ListBox to show the available locales. Add getLocaleSelector(),
1182 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1183 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1184 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1185 java: Add these classes.
1186 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1187 start(): Fill the locales ListBox. Handle its change event, firing a
1189 setPlace(): Show the selected locale as specified by the URL token.
1190 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1191 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1192 Handle LocaleChangeEvent, going to a new *Place with that locale.
1194 The placement of the ListBox is not pretty, and it currently uses the ID
1195 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1199 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1201 Search box: Show the search text from the URL token.
1203 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1204 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1205 Add setQuickFindText().
1206 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1207 .java: setPlace(): Store the queryText if the place is a ListPlace,
1208 and call TableSelectionView.setQuickFindText().
1210 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1212 Allow use of translations via, for instance, &lang=de in the URL.
1214 * pom.xml: Use the unstable java-libglom 1.21 version.
1216 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1217 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1219 init(): Instead of calling TranslatableItem.set_current_locale()
1220 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1221 However, this is only for default locales, which are not needed to
1222 change the locale in the URL.
1223 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1224 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1225 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1226 layout for a particular locale.
1227 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1228 Add get/setDefaultLocaleID().
1229 getDocumentInfo(), getListViewData(), getRelatedListData(),
1230 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1231 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1232 localeID parameter, so we can get the layout for a particular locale.
1234 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1235 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1236 * src/main/java/org/glom/web/client/place/ListPlace.java:
1237 Parse and construct a lang parameter too.
1239 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1240 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1241 passed to subsequent methods and constructors.
1242 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1243 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1244 Store the localeID from the *Place and pass it to other constructors
1245 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1247 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1248 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1249 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1250 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1251 * src/main/java/org/glom/web/client/ui/ListView.java:
1252 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1253 Take localeID parameters and pass them to subsequent constructors and
1254 methods, so that the layout is always retrieved for that locale.
1256 This is rather repetitive.
1258 Note that "" means the original (default) locale of the Glom document,
1259 which is usually English.
1261 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1263 Documents: Remove final keyword to fix startup configuration.
1265 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1266 final keywords on the private member variables because that breaks
1267 the startup, apparently (there are warnings) because it stops them
1268 from being serialized. I added these in the previous commit.
1270 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1272 Documents: Add some final keywords.
1274 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1277 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1279 OnlineGlomServiceImpl: Add to overview comments.
1281 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1282 Note that this is where all the document are loaded. They are not
1283 loaded freshly for each page.
1285 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1289 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1290 Add a TextBox for the text of a quick find.
1291 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1293 setBackLink(): Add a String quickFind parameter.
1294 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1295 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1296 to the base interface, because that is how TableSelectionViewImpl is used.
1297 * src/main/webapp/style.css: Add style for the search box and its label.
1299 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1300 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1301 Add these files, based on the existing TableChangeEvent and
1302 TableChangeEventHandlers.
1303 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1304 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1305 a ListPlace() that the user should be taken to.
1306 * src/main/java/org/glom/web/client/activity/ListActivity.java
1307 start(): Handle it here too and adapt the TableChangeEvent handler to
1308 pass the extra "" quickFind parameter to ListPlace.
1309 * src/main/java/org/glom/web/client/place/ListPlace.java:
1310 Constructor: Take an extra String quickFind parameter and store it,
1311 returning it from a new getQuickFind() method.
1312 getToken(): Put the quickFind text in the URL token.
1313 getPlace(): Parse the quickFind text from the URL token.
1314 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1315 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1316 ListPlace constructor.
1317 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1318 .java: start(): Add a Change handler for the TableSelectionView's
1319 TextBox (via its base HasChangeHandlers interface), firing the new
1320 QuickFindChangeEvent.
1321 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1322 pass the extra "" quickFind parameter.
1324 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1325 setCellTable(): Add a String quickFind parameter and pass it to
1326 the ListViewTable() constructor.
1327 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1328 setCellTable() in the base interface, because that is how ListViewImpl
1331 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1332 Add a String quickFind member variable.
1333 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1334 Constructor: Add a String quickFind parameter, storing it in the
1335 base ListTable's member variable.
1336 onRangeChanged(): Pass quickFind to the
1337 OnlineGlomServiceAsync.getSortedListViewData() and
1338 OnlineGlomServiceAsync.getListViewData() methods.
1340 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1341 getListViewData(), getSortedListViewData(): Add a String quickFind
1342 parameter, passing it to ConfiguredDocument.getListViewData().
1343 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1344 Change getListViewData(), getSortedListViewData() in the base interface,
1345 because that is how OnlineGlomServiceImpl is used, via this:
1346 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1347 Change getListViewData(), getSortedListViewData() here too.
1348 This class can apparently be used to asynchronously call methods on
1349 OnlineGlomService, and GWT seems to implement that after recognizing
1350 just the *Async name convention and the extra AsyncCallback parameters.
1352 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1353 getListViewData(): Add a String quickFind parameter, and pass it to
1354 ListViewDBAccess.getData().
1355 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1356 getListData(): Add a String quickFind parameter and pass it to
1358 getSelectQuery(): Add a String quickFind parameter.
1359 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1360 getSelectQuery(): Add a String quickFind parameter and use it with
1361 Glom.get_find_where_clause_quick() to pass a where_clause to
1362 Glom.build_sql_select_with_where_clause(), to actually filter the
1364 getData(): Add a String quickFind parameter, passing it to getListData().
1365 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1366 va: getData(): Pass an empty string to getListData() for the
1367 quickFind parameter.
1369 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1371 ListTable: Minor change.
1373 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1374 createCellTable(): Make this protected instead of public.
1376 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1378 Many files: Use final for the parameters and use the @override attribute.
1380 2012-01-22 Ben Konrath <ben@bagu.org>
1382 Add anchor links for single line text that starts with http, ftp and www.
1386 2012-01-22 Ben Konrath <ben@bagu.org>
1388 Add ellipsis to single line text in details view.
1392 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1394 Remove all javadoc author tags.
1396 Because they are awkward and meaningless when many people touch
1398 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1400 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1402 Revert the COPYING.LESSER to COPYING rename.
1404 Apparently both should be there if it is LGPL.
1406 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1408 *View: Remove unused imports.
1410 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1411 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1412 * src/main/java/org/glom/web/client/ui/ListView.java:
1413 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1414 Remove unused imports, as suggested by Eclipse.
1416 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1418 Move the *View::Presenter types, and some API into one base View.
1420 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1421 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1422 * src/main/java/org/glom/web/client/ui/ListView.java:
1423 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1424 Presenter, setPresenter() and clear() into a shared base interface,
1425 to avoid the unnecessary duplicate Presenter types and to more clearly
1426 show how the *Views share the same structure, even if they are not
1427 used polymorphically.
1429 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1430 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1432 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1433 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1434 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1436 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1439 Feel free to revert this if there is a good reason for the duplicate
1442 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1444 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1446 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1447 a class member instead of a local variable in the method.
1448 This lets us use it to get the view instances, for use in tests.
1449 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1450 beforeOnlineGlom(): Test some more details of the initial view.
1451 Again, this is not very useful.
1453 To really test gwt-glom we will need to start a local postgresql
1454 instance with local data, like the Glom tests in C++.
1456 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1458 pom.xml: Mention the LGPL license.
1460 * pom.xml: Add a licenses section.
1461 * COPYING.LESSER: Move this to COPYING, which
1462 previously contained the GPL. But gwt-glom is all LGPL.
1464 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1466 Add project information to README and pom.xml.
1468 * README: Add a brief description and mention some mvn
1470 * pom.xml: This extra information shows up in mvn site
1473 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1475 Use the latest java-libglom version.
1477 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1479 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1481 GwtTestOnlineGlom: Test a little more.
1483 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1484 protected rather than private, as suggested by the gwt-test-utils
1486 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1487 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1488 Test the initial visibility of the panels.
1490 However, this is not a very useful test.
1491 And I wonder how we should generally test using this idea for an
1492 activity/places app like ours where the real changes happen implicitly
1493 based on the history token/URL.
1495 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1497 Slight modification to *Mapper comments.
1499 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1500 (DataActivityMapper)
1501 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1503 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1505 Remove comments mentioning GIN because they are just copied from
1506 the example code and are apparently not helpful:
1507 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1508 Also change the mention of a class that is only in the example code.
1510 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1512 GwtTestOnlineGlom test: Minor changes.
1514 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1515 Avoid the long qualified class name and modify the comment
1516 because it is now obvious to me that the mocked class is the only
1517 custom one created via GWT.create().
1519 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1521 Tests: Added the beginnings of a test using gwt-test-utils.
1523 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1524 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1525 which tells gwt-test-utils what class will be tested.
1526 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1527 Add a simple (but empty) test case. One class, used by the OnlineGlom
1528 class, is mocked so that it can be created. However, I am not sure
1529 why only this class needs to be mocked.
1531 Note that mockito seems more popular, and clearer, than easymock,
1532 but I have not got that working yet. It might be a matter of the
1535 This test is run during mvn integration-test.
1537 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1539 Tests: Use junit4-style syntax instead of junit3-style.
1541 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1542 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1543 * src/test/java/org/glom/web/shared/DataItemTest.java:
1544 Use the @Test annotation rather than relying on the test*() prefix.
1545 Also no longer implement TestCase, to avoid triggering support for
1546 the junit3-way, which stops the annotations from working.
1547 Change the imports from import junit.framework.* to
1548 import org.junit.*, which is apparently the new way.
1550 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1552 Added a test for ListPlace token parsing and creation.
1554 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1555 This is much the same as DetailsPlaceTest.
1557 I wonder how we could test the other parts of the *Place API.
1559 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1561 DetailsPlace test: Also test getToken() and recreation via getPlace().
1563 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1564 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1565 recreate it, testing the recreated DetailsPlace for the same parameter
1568 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1570 Use the surefire-report plugin.
1572 * pom.xml: This generates a HTML report about the tests in
1573 target/site/surefire-report.html
1574 when you do mvn surefire-report:report. It seems to be popular/normal.
1576 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1578 Added a test for DetailsPlace.
1580 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1581 Test the getPlace() token parsing.
1583 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1585 Added a first unit test.
1587 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1588 * src/test/java/org/glom/web/shared/DataItemTest.java:
1589 This is a silly test but it is just to get things started. Note that
1590 maven/junit finds the test because it looks in src/test by default.
1592 2011-12-22 Ben Konrath <ben@bagu.org>
1594 Change charsetName to "UTF-8" when replacing line breaks.
1596 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1597 that work in Java (such as "UTF8") will not work when compiled to
1600 This fixes a problem with multi-line details view fields that have hard
1601 line breaks. The "License Text" field on this page demonstrates the
1604 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1606 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1608 2011-12-22 Ben Konrath <ben@bagu.org>
1610 Fix another bug with related list navigation.
1612 I've tested all the navigation buttons in all of the related lists
1613 so things should be good now.
1615 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1617 2011-12-22 Ben Konrath <ben@bagu.org>
1619 Fix a crasher when refreshing the list view with the default table.
1621 This crash will also happen when loading the list view with the default
1622 table from a link or bookmark.
1624 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1625 to the main document selection page when the document id hasn't been
1627 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1628 the main document selection page when the document id hasn't been
1630 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1631 values for the details place when the document id hasn't been set.
1632 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1633 values for the list place when the document id hasn't been set.
1635 2011-12-21 Ben Konrath <ben@bagu.org>
1637 Protect against NPE when glom.document.locale is not in config.
1639 This patch protects against an NPE when glom.document.locale is not in
1640 the config file. This NPE will also happen if glom.document.locale is
1643 The patch also updates the error message to display the class name when
1644 the getMessage() returns null. This was happening when the NPE was
1645 thrown and I had "Configuration Error: null". If an NPE is encountered
1646 with this patch, "Configuration Error: NullPointerException " will be
1649 This commit closes this bug:
1651 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1653 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1655 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1657 Rename onlineglom.properties to onlineglom.properties.sample.
1659 * src/main/resources/onlineglom.properties: Rename to:
1660 * src/main/resources/onlineglom.properties.sample:
1661 * src/main/resources/README: And add this file explaining that people
1662 should rename it back when deploying.
1664 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1666 Allow choosing the translation in the .properties file.
1668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1669 init(): Read a glom.document.locale value from the configuration file
1670 and call Glom's TransatableItem::set_current_locale() method.
1671 * src/main/resources/onlineglom.properties: Add a commented-out
1672 example of this new setting.
1674 It would be better to add &lang=de_DE to the URL, but the current
1675 libglom API does not allow us to do this easily. I am working on that.
1677 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1679 Avoid a crash in parsing of token parameters.
1681 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1682 ava: getTokenParams(): Do not crash if a parameter has a key but no
1683 value, and ignore parameters with neither.
1685 2011-12-17 Murray Cumming <murrayc@murayc.com>
1687 History token building/handling: Improve use of token parameters.
1689 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1690 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1691 and buildParamsToken(HashMap), for use by derived classes.
1692 Make the separator private because it is no longer be needed.
1693 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1694 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1695 instead of manual string concatenation.
1696 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1697 of hardcoded indices and awkward splitting code.
1698 * src/main/java/org/glom/web/client/place/ListPlace.java
1699 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1700 instead of manual string concatenation.
1701 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1702 of hardcoded indices and awkward splitting code.
1703 This should fix bug #666420
1705 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1707 Fix a Navgiation->Navigation typo in the code.
1709 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1710 Rename processNavgiation() to processNavigation().
1712 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1714 Fix a seperator->separator typo in the code.
1716 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1717 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1718 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1721 2011-12-15 Ben Konrath <ben@bagu.org>
1723 Cleanup some comments.
1725 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1727 2011-12-14 Ben Konrath <ben@bagu.org>
1729 Replace \n with <br/> for multiline text in the details view.
1731 Vertical scrollbars are added when needed as well.
1733 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1735 2011-12-14 Ben Konrath <ben@bagu.org>
1737 Specify the font for document selection links.
1739 * src/main/webapp/style.css:
1741 2011-12-14 Ben Konrath <ben@bagu.org>
1743 Fix bouncy CellTable while paging.
1745 This doesn't currently work with related list tables in unselected
1748 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1750 2011-12-14 Ben Konrath <ben@bagu.org>
1752 Revamp the appearance of the document selection page.
1754 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1755 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1756 * src/main/webapp/style.css:
1758 2011-12-13 Ben Konrath <ben@bagu.org>
1760 Set navigation button column to the smallest size possible.
1762 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1764 2011-12-13 Ben Konrath <ben@bagu.org>
1766 Change OpenButton nomenclature to NavigationButton.
1768 Using NavigtionButton makes things more generic. Classes, methods and
1769 variables have been changed.
1771 This is a rename-only refactor.
1773 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1774 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1775 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1776 Renamed from OpenButtonCell.
1777 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1778 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1779 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1781 2011-12-12 Ben Konrath <ben@bagu.org>
1783 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1785 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1786 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1787 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1788 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1790 2011-12-12 Ben Konrath <ben@bagu.org>
1792 Update variable names and comments.
1794 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1795 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1797 2011-12-12 Ben Konrath <ben@bagu.org>
1799 Properly initialize numNonEmptyRows variable to zero.
1801 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1802 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1804 2011-12-05 Ben Konrath <ben@bagu.org>
1806 Add latest mockup with HTML tables.
1808 Features of this mockup:
1810 -> HTML table for flowtable
1811 -> HTML table for flowtable column
1812 -> Example of how related lists would look
1813 -> Not using text entries for data items
1815 The current version of Online Glom doesn't use HTML tables for the
1818 This mockup has been sent to the glom-devel mailing list but it's good
1819 to have it here as well.
1821 * mockups/details-view-html-tables.html:
1823 2011-12-05 Ben Konrath <ben@bagu.org>
1825 Remove unnecessary getPrimaryKeyField() method.
1827 getPrimaryKeyFieldForTable(String) has been renamed to
1828 getPrimaryKeyField(String).
1830 * src/main/java/org/glom/web/server/database/DBAccess.java:
1831 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1832 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1834 2011-12-05 Ben Konrath <ben@bagu.org>
1836 Add string representation of TypedDataItem value to conversion error message.
1838 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1839 message was extracted into its own method to avoid duplication.
1841 2011-12-05 Ben Konrath <ben@bagu.org>
1843 Add type checking to navigation primary key value creation.
1845 Create navigation primary key only if the expected type from the Glom
1846 document matches the type returned by the SQL query.
1848 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1850 2011-12-05 Ben Konrath <ben@bagu.org>
1852 Rename a couple of variables in RelatedListNavigation.
1854 This is a rename-only refactor.
1856 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1858 2011-12-05 Ben Konrath <ben@bagu.org>
1860 Move getListLayoutGroup() into getListViewLayoutGroup().
1862 This removes getListLayoutGroup(). It was only being called by
1863 getListViewLayoutGroup().
1865 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1867 2011-12-05 Ben Konrath <ben@bagu.org>
1869 Remove check for LayoutItem_Portal in list table method.
1871 This check is no longer necessary because the method isn't being used
1872 to create the LayoutItemPortal DTO.
1874 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1876 2011-12-05 Ben Konrath <ben@bagu.org>
1878 Properly support related list navigation.
1880 Navigation from the "Repository Analyzer -> Package Scans ->
1881 Dependencies" related table wasn't working because the primary key for
1882 related tables wasn't being set properly. This commit fixes the
1885 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1886 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1887 doesn't set the primary key properly for related list tables.
1888 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1889 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1890 useful for getting the primary key for list view tables and for related
1892 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1893 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1894 Move code to set the primary key for the table from the abstract
1895 ListDBAccess class to ListViewDBAccess as it's only correct for list
1897 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1898 Properly add primary key to related list tables.
1900 2011-12-02 Ben Konrath <ben@bagu.org>
1902 Properly set the horizontal alignment of fields.
1904 This fix is for both the list tables and the details view.
1906 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1907 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1908 to set the horizontal alignment of fields.
1910 2011-12-02 Ben Konrath <ben@bagu.org>
1912 Display currency codes in the details view.
1914 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1916 2011-12-02 Ben Konrath <ben@bagu.org>
1918 Avoid duplicate JNI call.
1920 JNI is not as efficient as pure Java and this is an easy (and small)
1923 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1924 Use previously retrieved value for whereClauseToTableName instead of
1927 2011-12-02 Ben Konrath <ben@bagu.org>
1929 Rename a couple of variables in RelatedListNavigation.
1931 This is a rename-only refactor.
1933 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1935 2011-12-02 Ben Konrath <ben@bagu.org>
1937 Indicate clearly that a mismatched primary key type is a bug.
1939 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1940 warning to error. Add 'This is a bug.' to message.
1942 2011-12-02 Ben Konrath <ben@bagu.org>
1944 Update / fix some comments.
1946 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1948 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1950 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1951 Fix comments. Add some TODOs.
1953 2011-12-02 Ben Konrath <ben@bagu.org>
1955 Enable navigation to details view with string primary key from related list.
1957 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1958 Create a text primary key value when return type of result is
1959 java.sql.Types.VARCHAR.
1961 2011-12-02 Ben Konrath <ben@bagu.org>
1963 Use checkboxes for booleans in the details view.
1965 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1967 2011-12-01 Ben Konrath <ben@bagu.org>
1969 Improve performance of related list height calculation.
1971 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1972 Put code to calculate the expected height in a static initializer so
1973 that that it's only called once.
1975 2011-12-01 Ben Konrath <ben@bagu.org>
1977 Show related list tables in notebooks (again).
1979 Calculate the height of the related list tables so the Notebook can be
1980 set the correct height. The height of the related list table is also needed by
1981 FlowTable to be able decide how to create the layout.
1983 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1984 and set the Portal height based on the height of the related list
1985 table and the Portal container.
1986 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1987 Add method to calculate the height of the related list tables.
1988 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1989 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1990 calculate the height of the Pager widget.
1992 2011-12-01 Ben Konrath <ben@bagu.org>
1994 Use CellTable API for table property instead of setting style on Element.
1996 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1998 2011-12-01 Ben Konrath <ben@bagu.org>
2000 Make ListViewTable and RelatedListTable a consistent height.
2002 The tables are now a consistent height regardless of the contents of
2003 the table. A hidden button is added to empty rows to ensure that the
2004 height of these rows will match the height of rows with data.
2006 A navigation button column is now added to every table. The width of
2007 the navigation column is set to 0px when a RelatedListTable shouldn't
2008 have navigation buttons. This maintains the a consistent row height in
2009 tables that don't show the navigation buttons.
2011 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2012 navigation column when not needed.
2013 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2014 arguments for navigation button to constructor of ListViewTable.
2015 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2016 hidden button for empty data rows.
2017 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2018 arguments for navigation button to constructor.
2019 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2020 create navigation buttons. Add hideNavigationButtons() method.
2021 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2022 arguments for navigation button to constructor.
2024 2011-12-01 Ben Konrath <ben@bagu.org>
2026 Use 'visibility: hidden' in Utils.getWidgetHeight().
2028 This is better choice because hidden elements are invisible, don't
2029 respond to events and are not part of the tab order. They will,
2030 however, take up space which is required to be able to calculate the
2031 height of the widget.
2033 * src/main/java/org/glom/web/client/Utils.java:
2035 2011-12-01 Ben Konrath <ben@bagu.org>
2037 Use Utils.getWidgetHeight() in FlowTable.
2039 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2041 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2043 2011-12-01 Ben Konrath <ben@bagu.org>
2045 Put the details css class name on the correct table column.
2047 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2049 2011-11-30 Ben Konrath <ben@bagu.org>
2051 Update for java-libglom API change.
2053 The getters and setters on FieldFormatting and NumericFormat were
2054 changed to remove the 'M'.
2056 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2058 2011-11-29 Ben Konrath <ben@bagu.org>
2060 Only allow RelatedListTables in Portals.
2062 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2064 2011-11-29 Ben Konrath <ben@bagu.org>
2066 Only create a contents panel for Portals when title is being set.
2068 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2070 2011-11-29 Ben Konrath <ben@bagu.org>
2072 Set TabLayoutPanel height based on calculated height its widgets.
2074 This is a potential fix for this bug:
2076 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2078 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2080 2011-11-29 Ben Konrath <ben@bagu.org>
2082 Align details field labels and data with the Open buttons.
2084 * src/main/webapp/style.css:
2086 2011-11-29 Ben Konrath <ben@bagu.org>
2088 Remove unnecessary <div> in the Notebook widget.
2090 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2091 method to get container FlowPanel (<div>).
2092 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2093 initWidget() method directly on the TabLayoutPanel widget instead of
2094 Group's container widget.
2096 2011-11-29 Ben Konrath <ben@bagu.org>
2098 Don't add group titles for Portals in Notebooks.
2100 This reverts the previous patch and fixes a bug I introduced with
2101 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2103 * src/main/java/org/glom/web/client/ui/details/Group.java:
2104 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2106 2011-11-28 Ben Konrath <ben@bagu.org>
2108 Remove unused boolean argument in Portal constructor.
2110 Just a code cleanup.
2112 * src/main/java/org/glom/web/client/ui/details/Group.java:
2113 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2115 2011-11-28 Ben Konrath <ben@bagu.org>
2117 Remove hack for glom 1.18 style glom files.
2119 * src/main/java/org/glom/web/client/ui/details/Group.java:
2120 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2121 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2123 2011-11-28 Ben Konrath <ben@bagu.org>
2125 Use Gda Value version of primary key to log result too large error.
2127 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2129 2011-11-28 Ben Konrath <ben@bagu.org>
2131 Don't use TypedDataItem.getText() for Unknown types from the URL.
2133 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2134 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2135 instead of getText().
2136 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2137 String field and getUnknown() method.
2139 2011-11-28 Ben Konrath <ben@bagu.org>
2141 Log an error message when the java-libglom .so is not present.
2143 The error message was being set in the exception but not logged.
2145 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2147 2011-11-28 Ben Konrath <ben@bagu.org>
2149 Ignore LayoutItem_CalendarPortals.
2151 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2152 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2154 2011-11-28 Ben Konrath <ben@bagu.org>
2156 Extract method for creating the LayoutItemPortal DTO.
2158 Just breaking the code up into smaller chunks.
2160 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2162 2011-11-28 Ben Konrath <ben@bagu.org>
2166 This should have been added with the refactor. Oops!
2168 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2170 2011-11-28 Ben Konrath <ben@bagu.org>
2172 Create primary key value from URL string using type from Glom document.
2174 See this bug, comments 19 - 25:
2176 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2178 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2179 create a TypeDataItem for the primary key here when loading from a
2180 URL. Show the same string for the primary key value as was received
2181 from the URL string (when loading from a URL).
2182 * src/main/java/org/glom/web/server/Utils.java: Update method for
2183 creating the Gda Value from the TypeDataItem to properly deal with
2184 creating a Gda Value based on the Glom document type for the primary
2185 key value string when loading from a URL.
2186 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2187 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2188 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2189 Update for changed method name.
2191 2011-11-27 Ben Konrath <ben@bagu.org>
2193 Rename PrimaryKeyItem to TypedDataItem.
2195 The name PrimaryKeyItem suggests what the class should be used for.
2196 TypedDataItem is a neutral name that describes the class better.
2198 This is a rename-only refactor.
2200 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2201 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2202 * src/main/java/org/glom/web/client/Utils.java:
2203 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2204 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2205 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2206 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2207 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2208 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2210 * src/main/java/org/glom/web/server/Utils.java:
2211 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2212 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2213 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2214 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2216 2011-11-25 Ben Konrath <ben@bagu.org>
2218 Improve Gda Value conversion from PrimaryKeyItem.
2220 The value from the PrimaryKeyItem is only used if its type match the
2221 type from the glom document.
2223 * src/main/java/org/glom/web/server/Utils.java:
2225 2011-11-25 Ben Konrath <ben@bagu.org>
2227 Manually check if the java-liblgom .so is visible to the JVM.
2229 It seems that Tomcat has problems when a static initializer throws an
2230 exception. This check is done before the first method call into
2231 java-libglom so that execution doesn't continue if the .so is not
2234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2236 2011-11-25 Ben Konrath <ben@bagu.org>
2238 Improve browser configuration error messages.
2242 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2244 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2245 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2246 getConfigurationErrorMessage() method.
2247 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2248 Get and display a specific configuration error message when no Glom
2249 documents are found.
2250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2251 Implement getConfigurationErrorMessage() method. Surround configuration
2252 code in the init() method with a try/catch block. This allows the
2253 errors to be caught while keeping the servlet available to retrieve the
2254 configuration error message.
2256 2011-11-25 Ben Konrath <ben@bagu.org>
2258 Don't use Strings to hold primary key values.
2260 The primary key values are now held in a new data object
2261 (PrimaryKeyItem) that holds type information and the primary key value
2262 using the correct type.
2264 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2265 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2267 PrimaryKeyItem instead of String to hold the primary key value.
2268 * src/main/java/org/glom/web/client/Utils.java: Remove
2269 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2270 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2271 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2272 PrimaryKeyItem instead of String to hold the primary key value. Load
2273 document selection page when the documentID has not been set correctly.
2274 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2275 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2277 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2278 Return empty string for URL instead of "null".
2279 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2280 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2281 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2282 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2283 PrimaryKeyItem instead of String to hold primary key values.
2284 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2285 PrimaryKeyValue to a Gda Value.
2286 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2287 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2288 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2289 Replace temporary database access code that uses the PrimaryKeyValue to
2290 Gda Value conversion.
2291 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2292 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2293 PrimaryKeyItem instead of String.
2294 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2295 hold primary key values.
2297 2011-11-24 Ben Konrath <ben@bagu.org>
2299 Use newly added java-libglom API to create queries.
2301 This isn't finished. I still need to stop using Strings for primary key
2302 values in the client code.
2304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2305 libglom to use fake connections so that retrieving the query string will
2307 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2308 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2309 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2310 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2311 Use the newly added libglom sql methods and classes to create the
2312 query. Add temporary hack to convert primary value strings to Gda
2315 2011-11-23 Ben Konrath <ben@bagu.org>
2317 Don't explicitly set the height of Portals.
2319 See comments 6 - 10 of this bug for details:
2321 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2323 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2325 2011-11-23 Ben Konrath <ben@bagu.org>
2327 Use an HTML table instead of CSS for the FlowTable layout.
2329 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2330 GWT's FlexTable to implement the FlowTable.
2331 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2333 2011-11-18 Ben Konrath <ben@bagu.org>
2335 Add boolean example to HTML table mockup.
2337 * mockups/details-view-html-tables-text-entries.html:
2339 2011-11-17 Ben Konrath <ben@bagu.org>
2341 Ensure the pager buttons are always visible for related lists.
2343 To accomplish this, I've turned off text wrapping in the list view and
2344 related list tables for both the header and data text. The related list
2345 table now has a fixed layout so the it doesn't overflow its container.
2346 This is required to ensure that the cell text is clipped when it
2347 overflows the cell and an ellipsis is added to the right side of the
2348 cell when text is clipped.
2350 A fixed table layout for the related list table in the details view
2351 seems what we want for the details view anyway, so the side-effect is
2354 The ellipsis will only be displayed in Firefox >= 7.
2358 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2360 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2361 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2362 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2364 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2365 Set the 'table-layout: fixed' CSS property to the related list table.
2366 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2367 'white-space: nowrap;' CSS property on both the list view and the
2368 related list tables.
2370 2011-11-16 Ben Konrath <ben@bagu.org>
2372 Rework the fix for empty notebook tab labels.
2374 Setting the empty group titles with its name caused problems for the
2375 details layout. Instead of using libglom's
2376 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2377 to the client when the title is empty. This allows the Notebook to use
2378 the name when the title is empty without affecting anything else.
2380 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2381 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2383 2011-11-16 Ben Konrath <ben@bagu.org>
2385 Set group titles with name when title is empty.
2387 This fixes a problem with an empty notebook tab label in the Lesson
2388 Planner document. The forth tab in the notebook should be "Internet":
2390 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2392 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2393 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2396 2011-11-16 Ben Konrath <ben@bagu.org>
2398 Remove whitespace from the configured username properties.
2400 This assumes that usernames won't have whitespace at the beginning
2401 or end. But I think this is a reasonable assumption.
2403 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2404 String.trim() to remove the whitespace from the username properties.
2406 2011-11-15 Ben Konrath <ben@bagu.org>
2408 Add details view mockup with HTML tables and text entries.
2410 This is from the attachment on this bug:
2412 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2414 * mockups/details-view-html-tables-text-entries.html:
2416 2011-11-15 Ben Konrath <ben@bagu.org>
2418 Add space between the columns of the flow table.
2422 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2424 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2425 space between columns in the flow table.
2427 2011-11-15 Ben Konrath <ben@bagu.org>
2429 Add backup files to the .gitignore.
2431 * .gitignore: Ignore files that end with ~.
2433 2011-11-09 Ben Konrath <ben@bagu.org>
2435 Use latest release of gwt-log.
2437 Gwt-log releases are now being submitted to the maven central
2438 repository so manual installation of the jar is no longer required.
2440 * pom.xml: Update version and groupId of gwt-log dependency.
2442 2011-10-31 Ben Konrath <ben@bagu.org>
2444 Don't use GWT numeric formatting to override the glom currency formatting.
2446 Currencies are now displayed like they are in Glom. See this bug:
2448 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2450 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2452 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2453 currency code to constructor and set it when the cell is rendered.
2454 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2455 currency code to the constructor of the NumericCell.
2457 2011-10-27 Ben Konrath <ben@bagu.org>
2459 Require the latest release of java-libglom (1.17.4).
2463 2011-10-26 Ben Konrath <ben@bagu.org>
2465 Add style to Notebook that matches current theme.
2467 It's not the best style in the world but it's better than the default.
2469 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2470 padding at the bottom of the child widgets.
2471 * src/main/webapp/style.css: Add style for the Notebook.
2473 2011-10-26 Ben Konrath <ben@bagu.org>
2475 Move servlet initialization code to overridden init method.
2477 This is half of the solution to getting proper error messages
2478 displayed when configuration errors occur. Here's the relevant bug:
2480 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2482 The rest of the solution involves surrounding the init method with a
2483 try/catch block and setting a global variable with the error /
2484 exception. A new async method should be created to retrieve and display
2485 the error message / exception.
2487 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2488 code from constructor to init method adding exceptions as needed.
2490 2011-10-26 Ben Konrath <ben@bagu.org>
2492 Add script to monitor and restart tomcat if required.
2494 * utils/check-and-recover-tomcat.py: New file.
2496 2011-10-26 Ben Konrath <ben@bagu.org>
2498 Display the correct number of data items in the pager.
2502 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2504 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2505 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2506 The implementation is the same for both tables: Keep track of the
2507 number of non-empty rows and fire and RowCountChangeEvent after the data has
2509 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2510 custom Pager class that subclasses SimplePager to handle displaying
2511 the correct number when empty rows have been added.
2513 2011-10-26 Ben Konrath <ben@bagu.org>
2515 Correct error in previous commit.
2517 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2518 eventBus parameter from listView.setCellTable().
2520 2011-10-26 Ben Konrath <ben@bagu.org>
2522 Fix error in TODO comment.
2524 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2526 2011-10-24 Ben Konrath <ben@bagu.org>
2528 Create Notebook widgets to the details view.
2530 This isn't finished just yet - I still need to create a reasonable
2531 style to match the current theme.
2533 * src/main/java/org/glom/web/client/Utils.java: Add method for
2534 calculating the height of a widget. This is used in the Notebook class.
2535 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2536 new constructor method in Group.
2537 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2538 method for creating child widget that can be used by subclasses
2539 like Notebook. New constructor that allows disabling the group
2540 titles - Notebooks don't set a group title for their child groups.
2541 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2542 to make Notebooks using GWT's TabLayoutPanel.
2543 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2544 constructor that allows disabling the group titles.
2545 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2546 LayoutItemNotebook DTO.
2547 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2548 DTO for Notebooks. It's just an empty class for now but we might need
2549 it to transfer some specific information in the future.
2551 2011-10-21 Ben Konrath <ben@bagu.org>
2553 Add navigation buttons to related list tables.
2555 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2556 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2557 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2558 method getSuitableRecordToViewDetails() for getting the table name
2559 and primary key value for related list navigation buttons.
2560 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2561 private cell renderer class to get the navigation information for
2562 related list tables from the server. Extract the navigation
2563 processing code from the details cell navigation and use it for the
2564 related list navigation as well.
2565 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2566 cell renderer class for the details open buttons. This was needed
2567 because the related list navigation buttons and the list view
2568 navigation buttons need to react differently when clicked.
2569 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2570 the onEnterKeyDown() method because it's now overriden in the
2571 subclasses that are specific to the related list tables and the list
2573 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2574 the vertical size a little because the buttons add a bit of vertical
2575 space to table. This is not a perfect solution because the vertical
2576 size of with table fewer than 5 rows will be a little smaller.
2577 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2578 changes in how navigation buttons are handled.
2579 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2580 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2581 database access object.
2582 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2583 to find the portal for a given relationship name from
2584 RelatedListDBAccess. Add method to find a primary key field for a
2586 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2587 Move code to find the portal for a given relationship name to
2589 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2590 New file: database access object for getting the related list
2591 navigation information (the table name and the primary key value).
2592 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2593 DTO for transferring a table name to navigate to and a primary key
2595 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2596 boolean and getter/setter to specifies if the related list should add
2599 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2601 Use the master branch of java-libglom
2603 * pom.xml: Depend on java-libglom 1.19 instead.
2605 This is the master branch. See also the libglom-1-18 branch.
2607 2011-10-11 Ben Konrath <ben@bagu.org>
2609 Enable the open navigation button when the data has been set.
2611 This avoids having active buttons that don't do anything when the data
2614 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2616 2011-10-11 Ben Konrath <ben@bagu.org>
2618 Use IsWidget interface for FlowTableItem.
2620 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2621 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2623 2011-10-11 Ben Konrath <ben@bagu.org>
2625 Remove GWT styling from open button in details view.
2627 There are still some issues with how the details cell is arranged but
2628 this should be made to match Glom 1.20. I'm going to leave fixing this
2629 until I have Glom 1.20 up and running.
2631 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2632 style name on open button.
2633 * src/main/webapp/style.css: Move and edit details-navigation class.
2634 Re-arrange some classes to make them appear in the same order as the
2637 2011-10-07 Ben Konrath <ben@bagu.org>
2639 Update to GWT 2.4.0.
2641 * .gitignore: Ignore new cache directory.
2642 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2643 * pom.xml: Change GWT and maven plugin to 2.4.0.
2644 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2646 * src/main/java/org/glom/web/client/ClientFactory.java:
2647 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2648 * src/main/java/org/glom/web/client/OnlineGlom.java:
2649 Update source for API changes.
2650 * utils/build-onlineglom-war.sh: Remove cache directory before the
2653 2011-10-07 Ben Konrath <ben@bagu.org>
2655 Add navigation buttons in the details view.
2657 This isn't finished but I thought I'd commit what I have as it's a
2658 pretty good start. I still need to:
2660 1. Change the style so that it fits better into the current theme
2661 2. Adjust the details cell to expand as much as possible.
2663 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2664 click handlers to navigation buttons in the DetailsCells. Create a
2665 refreshData() method to get just the data from the server without the
2667 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2668 Update the tableSelector and browser title when the table name
2669 changes without using the tableSelector.
2670 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2671 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2672 getDetailsCells() to getCells(). Update variable names.
2673 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2674 method to set click handler on navigation button. Rename a few
2675 variables. Add navigation buttons where needed.
2676 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2677 variables and methods.
2678 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2679 navigation boolean and navigation table as required in the
2680 LayoutItemField DTO.
2681 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2682 variables for navigation along with getter/setter methods.
2684 2011-10-07 Ben Konrath <ben@bagu.org>
2686 Rename Field to DetailsCell.
2688 This is a refactor-only commit. No functionality has been added or
2691 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2692 Update variable and method names.
2693 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2694 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2695 variable and method names.
2696 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2698 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2699 variable and method names.
2701 2011-10-07 Ben Konrath <ben@bagu.org>
2703 Create separate methods for layout and data the details view.
2705 This is a refactor-only commit. No functionality has been added or
2708 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2709 private methods: setData(), createLayout().
2711 2011-10-07 Ben Konrath <ben@bagu.org>
2713 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2715 This is part of a change to get navigation buttons in the details view
2716 but it should have been done this way from the start.
2718 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2719 for method name change in TableSelectionView.
2720 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2721 Create TableChangeEvent and set the browser title using the
2722 TableSelectionView API.
2723 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2724 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2725 Change getSelectedTable() to getSelectedTableName(). Add
2726 getSelectedTableTitle().
2728 2011-10-07 Ben Konrath <ben@bagu.org>
2730 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2732 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2734 2011-10-07 Ben Konrath <ben@bagu.org>
2736 Update TableChangeEvent to use newTableName naming convention.
2738 This makes the class more consistent with GWT naming conventions.
2740 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2741 Update for method name change in TableChangeEvent.
2742 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2743 for method name change in TableChangeEvent.
2744 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2745 newTableName variable and getter method. Make toDebugString()
2748 2011-09-30 Ben Konrath <ben@bagu.org>
2750 Disable the pager in the list tables when the data row count is less than the minimum.
2752 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2753 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2755 2011-09-30 Ben Konrath <ben@bagu.org>
2757 Add empty rows to the end of related list and list view tables.
2759 I also extracted the cell rendering classes from the ListTable because
2760 the code was becoming a little crazy with all the anonymous inner
2761 classes. My plan is to use these cell rendering classes in the details
2762 view as well so this refactor will be needed for that change.
2764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2765 set the row count in related list tables if the data has more rows
2766 than the minimum number of rows visible.
2767 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2768 row count in list view tables if the data has more rows than the
2769 minimum number of rows visible.
2770 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2771 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2773 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2774 for rendering TYPE_NUMERIC cells. The code was extracted from the
2776 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2777 class for rendering cells with buttons in list views. The code was
2778 extracted from the ListTable class.
2779 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2780 for rendering TYPE_TEXT cells. The code was extracted from the
2782 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2783 Add empty rows to the end of the data if required. Implement
2784 ListTable.getMinNumVisibleRows().
2785 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2786 cell renderer code to public classes. Return null in
2787 Column.getValue() for empty rows. Add new abstract method:
2788 getMinNumVisibleRows(). Move code to set the row count of the list view
2789 table to ListViewImpl.
2790 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2791 empty rows to the end of the data if required. Implement
2792 ListTable.getMinNumVisibleRows().
2795 2011-09-27 Ben Konrath <ben@bagu.org>
2797 Use GWT.log for client-side debugging statements.
2799 These are optimized out when deployed so I should have used this method
2800 in the first place. These statements will eventually be replaced with some sort
2801 of notification in the browser.
2803 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2804 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2805 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2806 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2807 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2809 2011-09-27 Ben Konrath <ben@bagu.org>
2811 Put tableselector on the right, back to list link on right.
2813 The idea is that the table selector is acting like a label for the
2814 currently displayed table so it should be placed below the document title. This
2815 puts the table title in a similar position to where it is in Glom.
2817 * mockups/details-contacts.html:
2818 * mockups/details-projects.html:
2819 * mockups/listview-contacts.html:
2820 * mockups/listview-projects.html:
2821 * mockups/style.css:
2822 Update mockups to match how the interfaces currently look.
2823 * src/main/webapp/style.css: Swap positions of backlink with the table
2824 selector. Add some space on the left side of the table selector to
2825 line things up with the document title.
2827 2011-09-27 Ben Konrath <ben@bagu.org>
2829 Add field colouring to details view.
2831 This change re-works how field colouring works. The colour formatting
2832 information is now set to the client with the layout information instead of
2833 with the data. This eliminates the need to send the same colour strings for
2834 data in list view column when colour information is set.
2836 In order to set an alternate colour for negative numeric values, the
2837 number is now sent to client and formatted with the GWT NumberFormat class.
2839 This change also fixes:
2841 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2843 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2844 internationalization framework which is needed for client side numeric
2846 * src/main/java/org/glom/web/client/Utils.java: New file for some
2847 client static utility methods.
2848 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2849 the DataItem object to the Field class. Use a utility method to
2850 create the foreignKeyValue string.
2851 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2852 alignment and text colours in the constructor. Add setData(DataItem)
2853 method. Remove setText(String) method.
2854 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2855 colour information to GlomTextCell. Create and use GlomNumberCell for
2856 rendering numbers. Use utility method to get the string for the
2857 primary key of the key provider. Re-work how the horizontal alignment
2859 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2860 formatting to layout information. Methods for converting the libglom
2861 formatting information were moved from DBAccess.
2862 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2863 numeric formatting (it's now done on the client side). Don't set text
2864 colours in DataItem. Move libglom formatting conversion methods to
2866 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2867 getters/setters for text colour information.
2868 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2869 for transferring the libglom NumericFormat information to the client.
2870 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2871 and getters/setters for: GlomNumericFormat, background colour and
2872 foreground colour strings.
2874 2011-09-26 Ben Konrath <ben@bagu.org>
2876 Simplify code that iterates through the LayoutGroup.
2878 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2880 2011-09-26 Ben Konrath <ben@bagu.org>
2882 Accept Eclipse formatting for OnlineGlomServiceAsync.
2884 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2886 2011-09-26 Ben Konrath <ben@bagu.org>
2888 Don't use the ListDBAccess classes to get the primary key layout information.
2890 This was causing a bug where the wrong index for the hidden primary key
2891 was being sent to the client.
2893 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2894 primary key while creating the LayoutGroup DTO. Create a
2895 LayoutItemField DTO for hidden primary keys. Don't use the
2896 RelatedListDBAccess because it was only used for getting the primary
2898 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2899 access modifier from public to protected for getPrimaryKeyField() and
2900 getPrimaryKeyLayoutItemField().
2901 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2902 abstract method getExpectedResultSize() because RelatedListDBAccess
2903 doesn't have enough info to implement it.
2904 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2905 Remove @Override for getExpectedResultSize().
2906 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2907 Remove method getExpectedResultSize().
2909 2011-09-23 Ben Konrath <ben@bagu.org>
2911 Log which layout (list or details) the ignored item is from.
2913 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2915 2011-09-23 Ben Konrath <ben@bagu.org>
2917 Remove annotations that turn off code formatting in DataItem.
2919 * src/main/java/org/glom/web/shared/DataItem.java:
2921 2011-09-23 Ben Konrath <ben@bagu.org>
2923 Rename GlomField to DataItem and update associated methods.
2925 This is a rename-only refactor. No functionality has been added or
2928 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2929 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2930 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2931 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2932 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2933 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2934 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2935 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2937 * src/main/java/org/glom/web/server/database/DBAccess.java:
2938 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2939 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2940 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2941 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2942 * src/main/java/org/glom/web/shared/DataItem.java:
2943 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2944 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2946 2011-09-23 Ben Konrath <ben@bagu.org>
2948 Rename GlomDocument to DocumentInfo and update associated methods.
2950 This is a rename-only refactor. No functionality has been added or
2953 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2954 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2955 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2956 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2957 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2958 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2959 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2961 2011-09-20 Ben Konrath <ben@bagu.org>
2963 Require java-libglom 1.17.3.
2965 This picks up the fix for the seg fault problem with the Scenes table
2966 in the Openismus Film Manager example.
2970 2011-09-20 Ben Konrath <ben@bagu.org>
2972 Change the way sort clause is added for primary key when no sort clause is requested.
2974 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2975 before the sort clause is created. When a sort clause is not requested, the
2976 sort clause is created by finding the primary key in the LayoutFieldVector
2979 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2981 2011-09-20 Ben Konrath <ben@bagu.org>
2983 Log error message if no documents are found in the configured directory.
2985 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2986 Extract the glom file extension string to a private static final class
2987 variable (mostly as syntactic sugar). Accept a minor formatting change.
2988 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2989 the example glom.document.directory configuration property to make it
2990 more clear that it can any directory, not just the home directory.
2992 2011-09-18 Ben Konrath <ben@bagu.org>
2994 Add related lists to details view.
2996 The related list table has support for paging and sorting just like the
2997 table in the list view.
2999 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3000 SQL queries for the related list tables.
3001 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3002 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3003 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3004 Rename getList methods to getListView and add comments. Remove
3005 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3006 it being unused. Add methods: getDetailsLayoutAndData(),
3007 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3008 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3009 Create the layout and set the data for the fields in one async call
3010 instead of two. Create related lists where appropriate.
3011 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3012 for method name changes in OnlineGlomService.
3013 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3014 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3015 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3017 * src/main/java/org/glom/web/client/ui/ListView.java:
3018 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3019 tableName from setCellTable(). Create a ListViewTable instead of
3021 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3022 represent a data field in the details view.
3023 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3024 from addDetailsCell() to Field class. Keep track of the Fields and
3025 Portals in the details view.
3026 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3027 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3028 and add a method to get it. Add method to set the contents of the
3030 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3031 New class for related list tables. This class has the data provider
3032 for the related list table.
3033 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3034 abstract class which is the base class for the ListViewTable and the
3036 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3037 New class for list view tables. This class has the data provider for
3038 the list view table.
3039 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3040 methods for related list tables. Add more information to the
3041 LayoutItemField and LayoutItemPortal DTOs.
3042 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3043 Remove debugging print statement.
3044 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3045 Remove debugging print statements. Add primary key field to SQL count
3047 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3048 Remove unnecessary LayoutFieldVector parameter from
3049 getResultSizeOfSQLQuery() method.
3050 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3051 New class for related list table database access.
3052 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3053 class that is a wrapper DTO for details view layout and data.
3054 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3055 new 'fromField' string to this DTO.
3056 * src/main/webapp/style.css: Remove bottom margin and override top
3059 2011-09-15 Ben Konrath <ben@bagu.org>
3061 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3063 This sets things up to make it easier to add the data retrieval for
3064 related lists (portals). No user noticeable changes were made with
3067 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3068 class has the code to retrieve the layouts and access the
3069 database using the new database helper classes.
3070 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3071 Most of the functionality has been removed from this class. This
3072 class now represents the public interface for the client side
3073 code. It also deals with configuring the servlet and cleaning
3074 things up when the servlet is stopped.
3075 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3076 of static methods into this utility class.
3077 * src/main/java/org/glom/web/server/database/DBAccess.java:
3078 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3079 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3080 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3081 These classes have the database retrieval code. The class hierarchy
3082 has been setup to make it easy to reuse code for similar
3085 2011-09-06 Ben Konrath <ben@bagu.org>
3087 Create separate classes for list table code and the data provider.
3089 As part of this refactor, I also split up the code a bit to make it
3092 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3093 table code to two new classes (below).
3094 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3095 with code from ListViewImpl.
3096 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3097 New file with code from ListViewImpl.
3099 2011-09-06 Ben Konrath <ben@bagu.org>
3101 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3103 This fixes the LayoutItemPortal DTO to match the libglom layout object
3106 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3108 2011-09-01 Ben Konrath <ben@bagu.org>
3110 Set title of Portals in the Details View.
3112 * pom.xml: Bump required version of java-libglom to 1.17.1.
3113 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3114 widget creation to its own class. Add comments to constructor.
3115 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3116 The code is mostly from the Group class with the title now set.
3117 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3118 title of Portal. Update some comments. Fix some code formatting.
3120 2011-09-01 Ben Konrath <ben@bagu.org>
3122 Remove TODO comment for the flow table column width.
3124 The flow table column width is working correctly and doesn't need to be
3125 changed. See this mailing list post for more info:
3127 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3129 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3131 2011-08-27 Ben Konrath <ben@bagu.org>
3133 Add document title (database name) to top of the browser page.
3135 I added the document title to the TableSelecitonView but that will
3136 change if / when we add a view that doesn't require table selection.
3138 * mockups/details-contacts.html:
3139 * mockups/details-projects.html:
3140 * mockups/listview-contacts.html:
3141 * mockups/listview-projects.html:
3142 * mockups/style.css: Add document title to mockups to keep things
3144 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3145 sizes to account for the document title.
3146 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3147 Set the document title when it has been retrieved from the server.
3148 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3149 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3150 and implement setDocumentTitle(String) method.
3151 * src/main/webapp/style.css: Add ID for document title style.
3153 2011-08-25 Ben Konrath <ben@bagu.org>
3155 Add NavigationType enum to LayoutItemPortal DTO.
3157 This is the start of adding support for Portals to the Details View.
3159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3160 LayoutItem_Portal.navigation_type enum from libglom to
3161 LayoutItemPortal.NavigationType enum.
3162 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3163 NavigationType enum, field for storing the NavigationType and getter
3166 2011-08-25 Ben Konrath <ben@bagu.org>
3168 Implement the flow table layout in the Details View.
3170 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3171 FlowTable to Group to account for the renamed class.
3172 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3173 File. This is a container widget that implements the Glom details view
3174 flow table behaviour.
3175 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3176 org/glom/web/client/ui/FlowTable.java.
3177 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3178 so that the size of the subgroups are a closer match to the size of
3179 the Glom subgroups. This makes the flowtable layout match the layout
3180 in Glom for the Music Collection example file.
3182 2011-08-16 Ben Konrath <ben@bagu.org>
3184 Create container element for LayoutItemPortal in Details View.
3186 This will help me develop the layout for the FlowTable.
3188 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3189 fieldPanel variable to detailsCell.
3191 2011-08-15 Ben Konrath <ben@bagu.org>
3193 Set the height of the data element in the Details View.
3195 I changed the InlineLabels (text in a span element) to Labels (text in
3196 a div element) so that I could set the height of the details-data
3197 elements instead of the details-cell parent elements. This allows the
3198 the details-data element to display the correct height if style is
3199 applied that shows the height.
3201 This change has the added benefit of allowing the order of the labels
3202 and data elements to be changed for right-to-left languages.
3204 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3205 InlineLabels to Labels.
3206 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3207 InlineLabels to Labels. Set the height of the data element.
3208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3209 multiline text height in the Formatting DTO.
3210 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3211 for multiline height along with getter and setter methods.
3212 * src/main/webapp/style.css: Adjust style to account for the change
3213 from span elements to div elements in the details cell.
3215 2011-08-15 Ben Konrath <ben@bagu.org>
3217 Make the List View appearance match the mockups.
3219 It doesn't match exactly but it's much better than it was.
3221 * mockups/listview-contacts.html: Remove unused css classes.
3222 * mockups/listview-projects.html: Remove unused css classes.
3223 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3224 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3225 for mainPanel instead of VerticalPanel (table). Set style name on
3226 CellTable. Set style name on Details column. Right-align Details
3228 * src/main/webapp/style.css: Adjust properties to match the mockups.
3230 2011-08-12 Ben Konrath <ben@bagu.org>
3232 Add better support for subgroups in the details view.
3234 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3235 changed FlowTable constructor.
3236 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3237 support for subgroups and subgroup-titles.
3238 * src/main/webapp/style.css: Add CSS class for subgroups and
3241 2011-08-12 Ben Konrath <ben@bagu.org>
3243 Return the top level LayoutGroup title.
3245 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3247 2011-08-11 Ben Konrath <ben@bagu.org>
3249 Make the TableSelector header match the mockup.
3251 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3252 the layout panel. Properly lineup the table selection header with
3253 the list and details view.
3254 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3255 margin around the details view.