1 2012-05-14 Murray Cumming <murrayc@murrayc.com>
3 TableToViewDetails: Use a real serialization ID.
5 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
6 Though this does not fix the serialization problem.
8 2012-05-12 Murray Cumming <murrayc@murrayc.com>
10 Added LayoutItemPortalDeepCloneTest.
12 2012-05-11 Murray Cumming <murrayc@murrayc.com>
14 Make navigation work again.
16 * src/main/java/org/glom/web/server/libglom/Document.java:
17 Add getLayoutItemFieldShouldHaveNavigation().
18 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
19 Replace get/setAddNavigation() with the partly-existing
20 get/setNavigationTableName(), with an empty string being no navigation,
21 because this is simpler. Use the new
22 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
24 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
25 Add updateFieldsExtras() and call setNavigationTableName in it.
26 getDetailsLayoutGroup(),
27 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
28 createLayout(): Adapted.
29 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
32 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
33 Replace get/setAddNavigation() with get/setNavigation(), returning a
34 TableToViewDetails class with both the table name and UsesRelationship,
35 because both are need. The previous code used java-libglom's output
36 variable (strangely, via sharedptr) to return both, but we cannot really
38 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
39 getNavigationRecord(): Adapt. However, we cannot actually use the cache
40 here because it somehow gets set to null during deepCopy(). I must test this.
41 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
42 testGetSuitableTableToViewDetails(): Adapted.
44 TODO: Find out why deepClone() is not quite working.
46 2012-05-11 Murray Cumming <murrayc@murrayc.com>
48 DBAccess: Simplify the retrievel of full field details.
50 * src/main/java/org/glom/web/server/database/DBAccess.java
51 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
52 because the Document loading should have done this.
54 2012-05-11 Murray Cumming <murrayc@murrayc.com>
56 Document: Correct loading of doubly-related layout fields.
58 * src/main/java/org/glom/web/server/libglom/Document.java:
59 loadUsesRelationship(): Actually set the related relationship, instead
60 of only setting it if it's not found.
62 2012-05-09 Murray Cumming <murrayc@murrayc.com>
64 Replace all appearances of Colour with color.
66 Because US English is dominant.
68 2012-05-09 Murray Cumming <murrayc@murrayc.com>
70 Use colors in HTML format, solving a warning about an unused function.
72 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
73 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
74 Add *asHTMLColor() versions of methods.
75 TODO: However, we should create and cache the results on the server.
76 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
77 * src/main/java/org/glom/web/client/ui/list/ListTable.java
78 * src/main/java/org/glom/web/server/ConfiguredDocument.java
79 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
80 Use the asHTMLcolor() versions.
82 2012-05-09 Murray Cumming <murrayc@murrayc.com>
84 ListViewTable: Constructor: Take the table name as a parameter.
86 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
87 Constructor: Take the tableName, and set the member variable, because
89 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
90 setCellTable(): Pass the table name.
91 This makes navigation to non-default tables work again. I don't know
92 why it worked before in the master branch.
94 2012-05-07 Murray Cumming <murrayc@murrayc.com>
96 ConfiguredDocument: Restore correct addition of hidden primary key items.
98 * src/main/java/org/glom/web/client/ui/list/ListTable.java
99 (ListTable.createCellTable): Uncomment out the check for the hidden
101 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
102 add primary key items for top-level lists and portals, as before,
103 instead of adding them to each group.
104 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
105 Actually implement the extra methods such as setHiddenPrimaryKey() and
106 comment that these are used only for top-level list groups and in portals.
107 This strangeness suggests even more that this should not be squeezed
108 into the LayoutGroup class.
110 2012-05-07 Murray Cumming <murrayc@murrayc.com>
112 Fix Formatting loading.
114 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
115 getFormattingUsed(): Remove the duplicate Formatting member variable
116 in favour of the one from the base class.
117 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
118 Initialize a new Formatting instead of using null by default, so we
119 have some defaults, instead of having to initialize one later just to
120 get the same defaults. This also makes loading of formatting from the
121 document work, because that expected a non-null.
123 2012-05-07 Murray Cumming <murrayc@murrayc.com>
125 RelatedListTable: Make sure that the tableName is set.
127 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
128 Constructor: Take the tableName so it is available later. Otherwise,
129 the server assumes that we mean the default table and cannot find the
131 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
132 setData(): Pass the tableName to the RelatedListTable constructor.
134 2012-05-07 Murray Cumming <murrayc@murrayc.com>
138 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
139 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
140 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
142 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
144 * src/main/java/org/glom/web/server/database/DBAccess.java:
145 convertResultSetToDTO(), getPortal():
146 * src/main/java/org/glom/web/server/database/ListDBAccess.java
148 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
149 Add checks for null objects and out of range access, with log messages to
150 give hints so we can fix these properly.
152 2012-05-07 Murray Cumming <murrayc@murrayc.com>
154 Portals: some corrections.
156 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
158 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
159 constructor: Use getRelationshipNameUsed() instead of getName(), because
160 that is what is meant.
161 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
162 getFromField(): Fix a typo, to get the field name, not the table name.
163 * src/main/java/org/glom/web/server/database/DBAccess.java:
164 getPortal(): Fix a typo that stopped this from working.
166 2012-05-07 Murray Cumming <murrayc@murrayc.com>
168 LayoutItemPortal: Also override getTitleOriginal().
170 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
171 This lets the base getTitle() with no parameters work.
172 TODO: Test this properly.
174 2012-05-06 Murray Cumming <murrayc@murrayc.com>
176 LayoutItemPortal: getTitle*(): Use the relationship title.
178 2012-05-06 Murray Cumming <murrayc@murrayc.com>
180 LayoutItemField: Fix loading of custom titles.
182 * src/main/java/org/glom/web/server/libglom/Document.java
183 loadDataLayoutItemField(): The title, if any, instead of the field
184 title, is stored in a title_custom node. Load it from there.
185 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
187 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
188 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
189 getTitle*() overrides.
190 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
193 2012-05-06 Murray Cumming <murrayc@murrayc.com>
195 LayoutItemField: Fall back to field titles, so some are really shown.
197 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
198 Override getTitleOriginal() and getTitle(), as in java-libglom.
199 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
202 2012-05-06 Murray Cumming <murrayc@murrayc.com>
204 Correct use of setExpectedResultSize().
206 * src/main/java/org/glom/web/server/ConfiguredDocument.java
207 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
208 Use setExpectedResultSize only on top-level groups (for instance, the
209 list layout) or on child portals (in details views).
210 Use the correct table name for portals to avoid SQL errors.
211 Update the expected counts when returning cached layouts.
213 2012-05-06 Murray Cumming <murrayc@murrayc.com>
215 Document: Interpret no group column count as 1.
217 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
218 default, though we now check for this in the UI code anyway.
220 2012-05-06 Murray Cumming <murrayc@murrayc.com>
224 2012-05-06 Murray Cumming <murrayc@murrayc.com>
226 Translatable: Use Hashmap instead of Treemap because GWT supports it.
228 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
229 The use of Treemap lead to this error from async methods, with no
231 "The response could not be deserialized"
233 2012-05-06 Murray Cumming <murrayc@murrayc.com>
235 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
237 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
238 when using the Google -> GWT Compile, or
239 g toolbar button -> GWT Compile Project... feature in Eclipse.
241 2012-05-06 Murray Cumming <murrayc@murrayc.com>
243 ListTable.addColumn(): Protect against a null Formatting.
245 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
246 Create a default Formatting if it is null, because that is the simplest
249 2012-05-06 Murray Cumming <murrayc@murrayc.com>
251 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
253 * src/main/java/org/glom/web/server/ConfiguredDocument.java
254 updateLayoutGroup(): Check that the field is not null.
256 2012-05-06 Murray Cumming <murrayc@murrayc.com>
258 ListViewImpl: Protected against a bad cast error.
260 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
261 onEnterKeyDown(): Do not cast without an instanceof check.
263 2012-05-06 Murray Cumming <murrayc@murrayc.com>
265 ListTable: Protect against an out of range error.
267 * src/main/java/org/glom/web/client/ui/list/ListTable.java
268 createCellTable(): This is unlikely, but can happen while debugging.
270 2012-05-06 Murray Cumming <murrayc@murrayc.com>
272 AsyncMessage onFailure() callbacks: Log the exception message.
274 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
275 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
276 * src/main/java/org/glom/web/client/activity/ListActivity.java:
277 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
278 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
279 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
280 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
281 These are useful clues when something is wrong.
283 2012-05-06 Murray Cumming <murrayc@murrayc.com>
285 ConfiguredDocument: Avoid a null dereference.
287 * src/main/java/org/glom/web/server/ConfiguredDocument.java
288 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
289 details maps are created.
291 2012-05-06 Murray Cumming <murrayc@murrayc.com>
293 Document: Correct the port number parsing.
295 * src/main/java/org/glom/web/server/libglom/Document.java:
296 This lets us actually connect to the database and show the document.
298 2012-05-05 Murray Cumming <murrayc@murrayc.com>
302 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
303 user-interaction, asking us to load a temporary URL in a browser.s
304 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
305 which is apparently necessary for testing the service. See the comment.
306 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
307 Show the exception, if any. This is how I saw the 404 in the HTML in
310 2012-05-05 Murray Cumming <murrayc@murrayc.com>
312 DocumentTest: Move the .glom files into the resources directory.
314 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
315 URI via getResource().
317 2012-05-05 Murray Cumming <murrayc@murrayc.com>
319 Document: Remove the FieldIdentifies inner class.
321 * src/main/java/org/glom/web/server/libglom/Document.java: We only
322 use the Relationship (though the same function in libglom is maybe
323 used in other ways) and so this removes a compiler warning.
325 2012-05-05 Murray Cumming <murrayc@murrayc.com>
327 Document.load() Remove the error code parameter.
329 * src/main/java/org/glom/web/server/libglom/Document.java: load():
330 Remove the parameter. We do not set it yet and it could never have
331 worked as an output parameter (though maybe it did in java-libglom).
332 We could use an exception if we really want the failure reason.
333 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
335 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
336 setUp(), testGetSuitableTableToViewDetails(): Adapt.
338 2012-05-05 Murray Cumming <murrayc@murrayc.com>
340 Make some inner classes static.
342 * src/main/java/org/glom/web/server/ConfiguredDocument.java
343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
344 * src/main/java/org/glom/web/server/ReportGenerator.java
345 * src/main/java/org/glom/web/server/libglom/Document.java
346 Make all inner classes static that can be static.
348 2012-05-05 Murray Cumming <murrayc@murrayc.com>
350 OnlineGlomServiceImpl: Do not load and check for java-libglom.
352 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
353 init(): We do not use java-libglom any more.
355 2012-05-05 Murray Cumming <murrayc@murrayc.com>
357 Remove mentions of java-libglom.
359 * README: Remove mention of java-libglom, because it no longer needed.
360 * utils/build-onlineglom-war.sh:
361 * utils/check-and-recover-tomcat.py:
362 * utils/install-onlineglom-war.sh: Remove these as they are no longer
363 useful. Building is now far easier, with no need for jhbuild.
365 2012-05-05 Murray Cumming <murrayc@murrayc.com>
367 Fix the build (mvn package)
369 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
370 (LayoutGroup): Make the LayoutItemList inner class static and protected.
371 Otherwise the GWT Java->Javascript compilation fails with just this
372 error, during mvn package or when attempting to view in a browser,
373 in the GWT developer mode in Eclipse.
375 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
376 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
377 [INFO] Compiling module org.glom.web.OnlineGlom
378 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
379 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
380 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
381 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
382 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
383 [INFO] [ERROR] Cannot proceed due to previous errors
385 It has taken me 2 days to find out what was causing that. After reducing
386 the code, the compiler eventually showed me the full error message.
388 2012-05-04 Murray Cumming <murrayc@murrayc.com>
390 ConfiguredDocument: Cache the cloned and stripped layouts.
392 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
393 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
394 layout in a map, so we can retrieve it again without rebuilding it.
396 2012-05-04 Murray Cumming <murrayc@murrayc.com>
398 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
400 2012-05-04 Murray Cumming <murrayc@murrayc.com>
402 libglom classes: Implement some auto-generated emthods.
404 2012-05-04 Murray Cumming <murrayc@murrayc.com>
406 Add GwtTestOnlineGlomService.
408 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
409 However, this (and the other GwtTest*) does not seem to run during
412 2012-05-04 Murray Cumming <murrayc@murrayc.com>
414 Remove use of unsupported features from client code.
416 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
417 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
418 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
419 Use our client version of StringUtils instead of the apache commons one.
421 However, the GWT Javascript compliation still fails.
423 2012-04-25 Murray Cumming <murrayc@murrayc.com>
425 Add a Field class and implement some loading of it in Document.
427 2012-04-25 Murray Cumming <murrayc@murrayc.com>
429 Initial Document loading implementation, instead of libglom.
431 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
432 and Translatable classes, and adapt the rest of the code to use them.
433 However, this is still missing Layout and Field classes and loading.
435 2012-04-24 Murray Cumming <murrayc@murrayc.com>
437 Use of jOOQ: Move Field creation into a utility method.
439 * src/main/java/org/glom/web/server/SqlUtils.java:
440 This lets us improve it more easily.
442 2012-04-24 Murray Cumming <murrayc@murrayc.com>
444 Use of jOOQ: Improve the code to COUNT a sub-select.
446 * src/main/java/org/glom/web/server/SqlUtils.java:
447 Move initial query creation into
448 build_sql_select_step_with_where_clause().
449 build_sql_select_count_rows(): Use the jOOQ API instead of
450 concatentating text, because a jOOQ Select*Step is a TableLike,
451 which is what from() takes.
453 2012-04-23 Murray Cumming <murrayc@murrayc.com>
455 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
457 * pom.xml: Depend on jooq.
458 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
459 methods with jOOQ, based on the C++ implementations in libglom,
460 with some changes to the logic required by jooQ.
461 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
463 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
464 * src/main/java/org/glom/web/server/ReportGenerator.java:
465 * src/main/java/org/glom/web/server/SqlUtils.java:
466 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
467 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
468 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
469 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
470 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
471 Adapt. In particular, the SqlUtils methods now need to take a Connection,
472 because jOOQ needs that, though it seems unnecessary.
474 This is not quite finished. Ideally jOOQ would help us to build
475 table_name.field_name names, quoting and escaping them properly.
476 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
478 2012-04-21 Murray Cumming <murrayc@murrayc.com>
480 Move use of Glom.build_sql*() into a new SqlUtils class.
482 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
483 to wrap Glom.build_sql*(). The parameter types are still Glom one,
484 but this will make it easier to start using something other than
485 libglom or SqlBuilder.
487 2012-04-21 Murray Cumming <murrayc@murrayc.com>
489 Update the project URL.
491 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
493 2012-04-21 Murray Cumming <murrayc@murrayc.com>
495 Main layout: Use a FlowTable instead of absolute positioning.
497 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
498 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
499 child panels/widgets must have an absolute position. But that is annoying, so
500 this adds a FlowTable and puts the child panels in there.
502 2012-04-21 Murray Cumming <murrayc@murrayc.com>
504 GwtTestOnlineGlom: Comment out unused code.
506 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
507 Eclipse has started to say that some code is unused.
509 2012-04-21 Murray Cumming <murrayc@murrayc.com>
511 Update to the latest versions of dependencies.
513 * pom.xml: Update version numbers of dependencies to the latest
515 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
516 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
517 * src/main/java/org/glom/web/server/ReportGenerator.java:
518 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
519 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
520 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
522 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
523 Modify the imports where necessary.
525 2012-04-17 Murray Cumming <murrayc@murrayc.com>
527 Style: Remove overflow:hidden from searchbox
529 * src/main/webapp/style.css: Because this pushes the Back To Link
530 label/link on to the next row, which is then hidden due to the
531 hard-coded (in ems) height.
533 2012-04-20 Murray Cumming <murrayc@murrayc.com>
535 Remove some duplicate code.
537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
538 getDocumentInfo(): This must have been duplicated during the merge from the
543 2012-04-19 Murray Cumming <murrayc@murrayc.com>
545 Reports: Localize the waiting for report message.
547 * src/main/java/org/glom/web/client/activity/ReportActivity.java
548 start(): Get the message from the contants.
549 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
551 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
552 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
553 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
554 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
555 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
556 Update these files with the English text for newer strings for now.
558 2012-04-19 Murray Cumming <murrayc@murrayc.com>
560 Reports: Show a message while waiting for the report.
562 * src/main/java/org/glom/web/client/ui/ReportView.java
563 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
564 Add setWaitingText(), to show a message saying that we are
565 waiting for the report to be ready.
566 * src/main/java/org/glom/web/client/activity/ReportActivity.java
567 start(): Call setWaitingText() before calling the async
570 2012-04-19 Murray Cumming <murrayc@murrayc.com>
572 ReportGenerator: Specify date and time formats.
574 * src/main/java/org/glom/web/server/ReportGenerator.java:
575 createFieldValueElement(): Use the default (and localized)
576 short formats, though we still need a way to show 4-digit
577 years without providing the format for every locale.
578 * src/main/java/org/glom/web/server/database/DBAccess.java:
579 convertResultSetToDTO(): Use the short formats here too.
581 2012-04-18 Murray Cumming <murrayc@murrayc.com>
583 ReportGenerator: Use the correct numeric formatting.
585 * src/main/java/org/glom/web/server/ReportGenerator.java
586 createFieldExpression(), createFieldValueElement(): Take the
587 whole LayoutItem_Field instead of just the field name, so
588 we have access to the formatting.
589 createFieldValueElement(): Use JRTextField.setPattern() to
590 specify the numeric formatting, with the help of a
591 regular DecimalFormat.
593 2012-04-18 Murray Cumming <murrayc@murrayc.com>
595 ReportGenerator: Avoid showing null for group by titles.
597 * src/main/java/org/glom/web/server/ReportGenerator.java
598 generateReport(): Use setBlankWhenNull() on the field title
599 style too, because this is used for values in group by
602 2012-04-18 Murray Cumming <murrayc@murrayc.com>
604 ReportGenerator: Add a colon to titles in vertical groups.
606 * src/main/java/org/glom/web/server/ReportGenerator.java
607 addFieldToDetailBandVertical(): Pass true for the withColon
610 2012-04-18 Murray Cumming <murrayc@murrayc.com>
612 ReportGenerator: Simplify the code by using Position more.
614 2012-04-18 Murray Cumming <murrayc@murrayc.com>
616 Reports: Support vertical groups, roughly.
618 * src/main/java/org/glom/web/server/ReportGenerator.java:
619 addToReport(): Rename to addGroupToReport() and, if necessary,
620 call the new addVerticalGroupToReport() method.
621 createFieldValueElement(): Let the caller specify the Y position
624 2012-04-17 Murray Cumming <murrayc@murrayc.com>
626 Reports: Allow a second report to be shown.
628 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
629 clear(): Do not remove the HTML widget, which broke the whole layout.
631 2012-04-17 Murray Cumming <murrayc@murrayc.com>
633 Locales drop-down: Show that we use English by default.
635 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
636 fillView(): When we use English, just because that is the default, when
637 no locale is specified, show that in the Locales drop-down instead of
638 just showing the first item.
640 2012-04-17 Murray Cumming <murrayc@murrayc.com>
642 Unselect the Report/Locale/Table combo item when appropriate.
644 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
645 setPlace(): clear reportName if this is not a ReportPlace.
646 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
647 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
648 When the provided name is empty, unselect all items, so that none are
649 indicated. This uses a for loop because I cannot find a single method
652 2012-04-17 Murray Cumming <murrayc@murrayc.com>
654 Report: Give the user a way to get back to the list.
656 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
657 start(), setPlace(): Show the Back To List link on reports, and also
658 interpret selecting the empty report item as back to list.
660 2012-04-13 Murray Cumming <murrayc@murrayc.com>
662 Really show the selected Report name.
664 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
665 setPlace(): Store the reportName here, if it is that kind of Place.
666 fillView(): Set the selected Report after filling the list of reports.
667 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
668 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
669 null Strings, though we need some way to unselect all ListBox items
672 2012-04-13 Murray Cumming <murrayc@murrayc.com>
674 ReportGenerator: Try to avoid some problems.
676 * src/main/java/org/glom/web/server/ReportGenerator.java
677 addField(): Try to avoid duplicates, and avoid using a null
680 2012-04-13 Murray Cumming <murrayc@murrayc.com>
682 Reports: Use quickFind.
684 * src/main/java/org/glom/web/client/OnlineGlomService.java;
685 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
687 getReportHTML(): Add a quickFind parameter.
688 * src/main/java/org/glom/web/client/activity/ReportActivity.java
689 start(): Pass the quickFind parameter.
690 * src/main/java/org/glom/web/server/ReportGenerator.java
691 generateReport(): Take a quickFind parameter.
693 2012-04-13 Murray Cumming <murrayc@murrayc.com>
695 ReportPlace: Actually use the report name.
697 * src/main/java/org/glom/web/client/place/ReportPlace.java
698 getPlace(): Do not assign the report name to the quickfind.
700 2012-04-13 Murray Cumming <murrayc@murrayc.com>
702 Show java.library.path when complaining.
704 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
705 init(): When telling us to check java.library.path, show the
708 2012-03-06 Murray Cumming <murrayc@murrayc.com>
710 ReportGenerator: Do not show nulls.
712 2012-03-06 Murray Cumming <murrayc@murrayc.com>
714 ReportGenerator: Make the title font larger.
716 2012-03-06 Murray Cumming <murrayc@murrayc.com>
718 ReportGenerator: Put field titles inside groups, if there are groups.
720 2012-03-06 Murray Cumming <murrayc@murrayc.com>
722 ReportGenerator: Take the Report itself instead of the name and group.
724 * src/main/java/org/glom/web/server/ConfiguredDocument.java
725 Remove getReportLayoutGroup().
726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
727 getReportHTML(): Pass the report instead
728 of its name and layout group.
729 * src/main/java/org/glom/web/server/ReportGenerator.java
730 generateReport(): Use the report object to use the title
733 2012-03-06 Murray Cumming <murrayc@murrayc.com>
735 ReportGenerator: Remove designBand parameters.
737 * src/main/java/org/glom/web/server/ReportGenerator.java:
738 Make designBand a class member instead of passing it to all
741 2012-03-06 Murray Cumming <murrayc@murrayc.com>
743 ReportGenerator: Add lines, a bit like in the desktop version.
745 * src/main/java/org/glom/web/server/ReportGenerator.java
746 addToReport(): Use JRDesignLine.
748 2012-03-06 Murray Cumming <murrayc@murrayc.com>
750 ReportGenerator: Correct the title positions and use some bold style.
752 * src/main/java/org/glom/web/server/ReportGenerator.java:
753 Break the code up into reusable functions, correct the placement of
754 titles, and use normal/bold styles as in the reports in the desktop
757 2012-03-06 Murray Cumming <murrayc@murrayc.com>
759 ReportGenerator: Add a header band to show the field titles.
761 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
762 getReportHTML(): Pass the localeId to the ReportGenerator
764 * src/main/java/org/glom/web/server/ReportGenerator.java
765 constructor: Take the localeID so we can get translated field
767 generateReport(), addToReport(), addFieldToBand(): Add field
768 titles in a column header band.
770 2012-03-05 Murray Cumming <murrayc@murrayc.com>
772 Reports drop-down list: Some improvement.
774 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
775 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
776 Adedd setSelectedReport(),
777 setReportList(): Add a blank line so that the user can select the
779 * src/main/java/org/glom/web/client/activity/ReportActivity.java
780 start(): Show the current report by calling setSelectedReport().
781 This does not seem to work yet.
783 2012-03-05 Murray Cumming <murrayc@murrayc.com>
785 DetailsActivity, ListActivity: Move some variables into a base class.
787 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
788 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
789 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
790 the clientFactory, documentID, tableName and authenticationPopup into
791 a base class, to avoid duplication.
793 2012-03-05 Murray Cumming <murrayc@murrayc.com>
795 Translate the Reports label.
797 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
798 Get the "Reports" label string from the constants.
799 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
800 perties: Add Reports to the constants.
802 2012-03-05 Murray Cumming <murrayc@murrayc.com>
804 Reports: Implement grouping.
806 * src/main/java/org/glom/web/server/ReportGenerator.java:
807 Handle LayoutItem_GroupBy items and try to do the right thing
808 with JRDesignGroup. It seems to work.
810 2012-03-04 Murray Cumming <murrayc@murrayc.com>
812 Actually show some data with JasperReports.
814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
815 getReportHTML(): Move most code into a ReportGenerator class.
816 * src/main/java/org/glom/web/server/ReportGenerator.java:
817 Recurse into sub-groups, adding fields to the JasperDesign's details
818 band. Note that we must set an arbitrary width and height, or it just
819 will not show any data.
821 2012-03-04 Murray Cumming <murrayc@murrayc.com>
823 Reports Chooser: Show the titles, not the names.
825 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
826 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
827 and the names as the values.
828 * src/main/java/org/glom/web/server/ConfiguredDocument.java
829 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
830 group now that we provide the report name, so it should always
833 2012-02-15 Murray Cumming <murrayc@murrayc.com>
835 Depend on jasperreports.
837 * pom.xml: Add the dependency. My plan is to use this on the
840 2012-01-31 Murray Cumming <murrayc@murrayc.com>
842 Implement navigation to report places.
844 * src/main/java/org/glom/web/client/activity/ReportActivity.java
845 start(): Do not bother to handle all events here.
846 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
847 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
848 Added getSelectedReport().
849 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
850 .java: start(): When handling a change to the reports chooser,
851 call getSelectedReport() and goTo() its ReportPlace.
852 * src/main/java/org/glom/web/client/ui/ReportView.java
853 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
854 Added setReportHTML() which puts the html in a gwt HTML widget.
855 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
856 getReportHTML(): Return "TODO" just to show that this works.
858 2012-01-31 Murray Cumming <murrayc@murrayc.com>
860 Make ReportPlace usable.
862 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
864 * src/main/java/org/glom/web/client/place/ReportPlace.java:
865 Correct the @prefix annotation.
867 2012-01-31 Murray Cumming <murrayc@murrayc.com>
869 OnlineGlomService: Return report HTML rather than the LayoutGroup.
871 * src/main/java/org/glom/web/client/OnlineGlomService.java:
872 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
873 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
874 Change getReportLayout() to getReportHMTL() because we will not need to
875 parse or render the report layout on the client side.
876 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
877 getReportLayout(): Return the libglom LayoutGroup type because we will
878 not need to convert to a shared type, because this will not be used on
880 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
883 Note that there is still no implementation for this.
886 2012-01-27 Murray Cumming <murrayc@murrayc.com>
888 Add a (empty) Report Place, View, and Activity.
890 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
892 * src/main/java/org/glom/web/client/place/HasTablePlace.java
893 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
894 this into a superclass:
895 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
896 and also use it as the base of this new ReportPlace:
897 * src/main/java/org/glom/web/client/place/ReportPlace.java
899 * src/main/java/org/glom/web/client/ui/ReportView.java
900 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
901 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
902 Add these, containing mostly boiler-plate for now.
904 * src/main/java/org/glom/web/client/OnlineGlomService.java
905 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
906 * src/main/java/org/glom/web/server/ConfiguredDocument.java
907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
908 Add API to get the LayoutGroup for the report.
910 2012-01-23 Murray Cumming <murrayc@murrayc.com>
912 Add and fill a Reports drop-down list box.
914 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
916 * src/main/java/org/glom/web/client/OnlineGlomService.java:
917 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
918 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
919 Added getReports(document, table, localeID), calling
920 ConfiguredDocument.getReports().
921 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
922 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
923 Added setReportsList() and a list widget.
924 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
925 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
930 2012-04-12 Murray Cumming <murrayc@murrayc.com>
932 Translations: Add Esperanto.
934 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
935 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
936 properties: Add this translation because someone took the time to make it.
938 2012-03-15 Murray Cumming <murrayc@murrayc.com>
940 Adapt to the java-libglom 1.21.7 API.
942 * src/main/java/org/glom/web/server/ReportGenerator.java:
943 addToReport(): get_group_secondary_fields() is now
944 get_secondary_fields().
947 2012-03-15 Murray Cumming <murrayc@murrayc.com>
949 Use the latest java-libglom version.
951 * pom.xml: Use java-libglom 1.21.7.
953 2012-03-03 Ben Konrath <ben@bagu.org>
955 Display date and time in details view.
957 https://bugzilla.gnome.org/show_bug.cgi?id=671257
959 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
961 2012-03-05 Murray Cumming <murrayc@murrayc.com>
963 Require the latest java-libglom.
965 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
967 2012-03-04 Murray Cumming <murrayc@murrayc.com>
969 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
971 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
972 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
973 an empty quickfind string. I also corrected libglom to create only
974 empty where clauses for empty quickfind strings, but this avoids the
977 2012-02-24 Ben Konrath <ben@bagu.org>
979 Improve the tabs in the Notebook widget.
983 2012-01-30 Murray Cumming <murrayc@murrayc.com>
985 Translations: Try to translate the strings.
987 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
988 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
989 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
990 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
991 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
992 Take the Open translation from GTK+'s .po files.
993 Take the Details translation from Glom's po files.
994 I have added the other strings to Glom so we can get translations that way:
995 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
997 2012-01-27 Murray Cumming <murrayc@murrayc.com>
999 TableSelectionViewImpl: Put the search label and entry in a div.
1001 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1002 Put the search widgets in a FlowTable so that the CSS can be used to
1003 style them while keeping them together.
1004 * src/main/webapp/style.css: Mention the new div.
1006 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1008 Translate more strings in more locales.
1010 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1011 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1012 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1013 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1014 Translate the "Details" and "Open" string too.
1016 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1017 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1018 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1019 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1020 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1021 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1022 Add these new locales as placeholders though they currently contain English.
1024 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1026 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1028 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1029 Check the ConfiguredDocument* for null before using it.
1031 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1033 Tell Eclipse about the generated java files.
1035 * .classpath: This lets it find OnlineGlomConstants.java.
1036 It would be nice if Eclipse just used the maven build files.
1038 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1040 Prevent a crash when no locale is specified in the URL.
1042 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1043 Avoid returning a null string, obtained from
1044 Window.Location.getParameter(). This caused a crash when it was
1045 later passed to libglom's API.
1046 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1047 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1048 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1049 guard against future null strings.
1051 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1053 Use the ?locale= query param instead of the &lang= token param.
1055 * src/main/java/org/glom/web/client/place/ListPlace.java
1056 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1057 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1058 Remove the lang token key and value.
1060 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1061 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1062 When the user selects a different locale from the chooser, use
1063 Window.Location.assign() to change the URL, which then causes a reload.
1065 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1066 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1067 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1068 * src/main/java/org/glom/web/client/activity/ListActivity.java
1069 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1070 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1071 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1072 * src/main/java/org/glom/web/client/ui/ListView.java:
1073 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1075 Remove localeID member variables and method/constructor parameters, instead
1076 using Utils.getCurrentLocaleID() when we need a localID to pass to
1079 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1081 Internationalize the UI strings.
1083 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1084 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1085 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1086 because it is unused. Messages are apparently strings that can have
1087 parameters, but we do not need that yet, so Contants will be enough for now.
1088 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1089 to say that we support the en and de locales.
1090 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1091 The original English strings.
1092 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1093 Some German translations of the English strings.
1094 The i18n goal then uses the .properties file to generate an
1095 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1096 returns an implementation that returns the translated strings.
1097 The documentation suggests putting these in src/java/*/client/, but it seems
1098 best to put it in src/resources/*/client/.
1099 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1100 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1101 instead of hard-coding them.
1102 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1103 but that does not seem to stop the build, though it confuses Eclipse.
1105 You can see the translated string by adding ?locale=de to the URL, like so:
1106 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1108 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1110 Improve null/empty String checks.
1112 * pom.xml: Add a dependency on commons-lang, to use
1113 org.apache.commons.lang.StringUtils.
1114 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1115 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1116 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1117 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1118 Use StringUtils.isEmpty().
1120 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1121 StringUtils class with a static isEmpty() function because we
1122 cannot use org.apache.commons.lang.StringUtils in client-side
1123 GWT code because it (apparently) cannot be compiled to javascript.
1124 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1125 * src/main/java/org/glom/web/client/activity/ListActivity.java
1126 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1127 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1128 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1129 * src/main/java/org/glom/web/client/place/ListPlace.java
1130 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1131 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1132 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1133 * src/main/java/org/glom/web/client/ui/details/Group.java
1134 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1135 our StringUtils.isEmpty() function.
1137 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1139 Update to the latest java-libglom API.
1141 * pom.xml: Require java-libglom 1.21.4.
1142 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1143 getDocumentInfo(), getListViewLayoutGroup():
1144 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1146 * src/main/java/org/glom/web/server/database/DBAccess.java
1147 getFieldsToShowForSQLQueryAddGroup(),
1148 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1149 with either get_database_title_original() or
1150 get_database_title(localeID).
1152 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1154 ConfiguredDocument: Avoid a null pointer exception.
1156 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1157 Initialize localeID to "" to avoid returning a null String which
1158 causes a crash in java-libglom's swing-generated code.
1160 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1162 Some simple renaming.
1164 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1165 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1166 for localeChooser. This seems more appropriate and is less ambiguous
1167 particularly in the .css file.
1169 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1171 ConfiguredDocument: Rename the localedID private member variable.
1173 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1175 Adapt to the latest java-libglom API from git master.
1177 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1178 libglom now uses only Vector instead of List, which uses add() instead of
1181 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1183 ConfiguredDocument: Rename the localedID private member variable.
1185 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1187 Build a source tarball with mvn assembly:single
1189 * assembly.xml: Add this file.
1190 * pom.xml: Use the maven-assembly-plugin and tell it to use
1191 our assembly.xml file.
1193 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1195 OnlineGlomServiceImpl: Get .glom files recursively.
1197 * pom.xml: Depend on commons-io from org.apache.commons.
1198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1199 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1200 files recursively, and with the easier filter for the extension.
1201 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1202 simplify that code too.
1204 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1206 README: Mention that you must install java-libglom packages separately.
1208 But then it works, because java-libglom is now in the central maven
1211 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1213 locales drop-down: Show the correct selected locale when the URL changes.
1215 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1216 .java: setPlace(): Move some code into fillView().
1218 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1220 locales drop-down: Do not lose the primary key.
1222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1223 start(): onLocaleChange(): Pass the current primary key value,
1224 instead of an empty value.
1226 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1228 locales drop-down: Do not lose the drop-down selection.
1230 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1231 .java (TableSelectionActivity.fillView): Set the selected locale
1232 after changing the drop-down items (though we do not really need
1233 to change them just because the locale changes.)
1235 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1237 locales drop-down: Change the tables list when this changes.
1239 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1240 .java: TableSelectionActivity.start(): Move the async table titles
1241 retrieval into a private fillView() method and also call this when
1242 the chosen locale changes.
1243 Note that the document title is not actually translatable yet, but
1244 that is a problem that I should fix soon in libglom.
1246 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1248 Improve the placement of the locales drop-down.
1250 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1251 Put the title and locales drop-down in a div (gwt.FlowTable).
1252 * src/main/webapp/style.css: Add magic css properties to make this work.
1253 Also remove the left margin from the title so that it lines up with the
1256 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1258 locales selector: Show human-readable locale titles.
1260 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1261 getDocumentInfo(): Use java.util.Locale to show a real title of
1262 each locale, in the locale's own language.
1264 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1266 Add a language/locale selector drop-down.
1268 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1269 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1270 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1271 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1272 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1273 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1274 Add a ListBox to show the available locales. Add getLocaleSelector(),
1275 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1276 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1277 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1278 java: Add these classes.
1279 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1280 start(): Fill the locales ListBox. Handle its change event, firing a
1282 setPlace(): Show the selected locale as specified by the URL token.
1283 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1284 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1285 Handle LocaleChangeEvent, going to a new *Place with that locale.
1287 The placement of the ListBox is not pretty, and it currently uses the ID
1288 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1292 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1294 Search box: Show the search text from the URL token.
1296 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1297 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1298 Add setQuickFindText().
1299 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1300 .java: setPlace(): Store the queryText if the place is a ListPlace,
1301 and call TableSelectionView.setQuickFindText().
1303 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1305 Allow use of translations via, for instance, &lang=de in the URL.
1307 * pom.xml: Use the unstable java-libglom 1.21 version.
1309 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1310 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1311 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1312 init(): Instead of calling TranslatableItem.set_current_locale()
1313 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1314 However, this is only for default locales, which are not needed to
1315 change the locale in the URL.
1316 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1317 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1318 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1319 layout for a particular locale.
1320 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1321 Add get/setDefaultLocaleID().
1322 getDocumentInfo(), getListViewData(), getRelatedListData(),
1323 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1324 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1325 localeID parameter, so we can get the layout for a particular locale.
1327 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1328 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1329 * src/main/java/org/glom/web/client/place/ListPlace.java:
1330 Parse and construct a lang parameter too.
1332 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1333 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1334 passed to subsequent methods and constructors.
1335 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1336 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1337 Store the localeID from the *Place and pass it to other constructors
1338 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1340 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1341 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1342 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1343 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1344 * src/main/java/org/glom/web/client/ui/ListView.java:
1345 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1346 Take localeID parameters and pass them to subsequent constructors and
1347 methods, so that the layout is always retrieved for that locale.
1349 This is rather repetitive.
1351 Note that "" means the original (default) locale of the Glom document,
1352 which is usually English.
1354 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1356 Documents: Remove final keyword to fix startup configuration.
1358 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1359 final keywords on the private member variables because that breaks
1360 the startup, apparently (there are warnings) because it stops them
1361 from being serialized. I added these in the previous commit.
1363 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1365 Documents: Add some final keywords.
1367 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1370 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1372 OnlineGlomServiceImpl: Add to overview comments.
1374 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1375 Note that this is where all the document are loaded. They are not
1376 loaded freshly for each page.
1378 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1382 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1383 Add a TextBox for the text of a quick find.
1384 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1386 setBackLink(): Add a String quickFind parameter.
1387 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1388 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1389 to the base interface, because that is how TableSelectionViewImpl is used.
1390 * src/main/webapp/style.css: Add style for the search box and its label.
1392 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1393 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1394 Add these files, based on the existing TableChangeEvent and
1395 TableChangeEventHandlers.
1396 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1397 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1398 a ListPlace() that the user should be taken to.
1399 * src/main/java/org/glom/web/client/activity/ListActivity.java
1400 start(): Handle it here too and adapt the TableChangeEvent handler to
1401 pass the extra "" quickFind parameter to ListPlace.
1402 * src/main/java/org/glom/web/client/place/ListPlace.java:
1403 Constructor: Take an extra String quickFind parameter and store it,
1404 returning it from a new getQuickFind() method.
1405 getToken(): Put the quickFind text in the URL token.
1406 getPlace(): Parse the quickFind text from the URL token.
1407 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1408 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1409 ListPlace constructor.
1410 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1411 .java: start(): Add a Change handler for the TableSelectionView's
1412 TextBox (via its base HasChangeHandlers interface), firing the new
1413 QuickFindChangeEvent.
1414 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1415 pass the extra "" quickFind parameter.
1417 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1418 setCellTable(): Add a String quickFind parameter and pass it to
1419 the ListViewTable() constructor.
1420 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1421 setCellTable() in the base interface, because that is how ListViewImpl
1424 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1425 Add a String quickFind member variable.
1426 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1427 Constructor: Add a String quickFind parameter, storing it in the
1428 base ListTable's member variable.
1429 onRangeChanged(): Pass quickFind to the
1430 OnlineGlomServiceAsync.getSortedListViewData() and
1431 OnlineGlomServiceAsync.getListViewData() methods.
1433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1434 getListViewData(), getSortedListViewData(): Add a String quickFind
1435 parameter, passing it to ConfiguredDocument.getListViewData().
1436 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1437 Change getListViewData(), getSortedListViewData() in the base interface,
1438 because that is how OnlineGlomServiceImpl is used, via this:
1439 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1440 Change getListViewData(), getSortedListViewData() here too.
1441 This class can apparently be used to asynchronously call methods on
1442 OnlineGlomService, and GWT seems to implement that after recognizing
1443 just the *Async name convention and the extra AsyncCallback parameters.
1445 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1446 getListViewData(): Add a String quickFind parameter, and pass it to
1447 ListViewDBAccess.getData().
1448 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1449 getListData(): Add a String quickFind parameter and pass it to
1451 getSelectQuery(): Add a String quickFind parameter.
1452 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1453 getSelectQuery(): Add a String quickFind parameter and use it with
1454 Glom.get_find_where_clause_quick() to pass a where_clause to
1455 Glom.build_sql_select_with_where_clause(), to actually filter the
1457 getData(): Add a String quickFind parameter, passing it to getListData().
1458 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1459 va: getData(): Pass an empty string to getListData() for the
1460 quickFind parameter.
1462 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1464 ListTable: Minor change.
1466 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1467 createCellTable(): Make this protected instead of public.
1469 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1471 Many files: Use final for the parameters and use the @override attribute.
1473 2012-01-22 Ben Konrath <ben@bagu.org>
1475 Add anchor links for single line text that starts with http, ftp and www.
1479 2012-01-22 Ben Konrath <ben@bagu.org>
1481 Add ellipsis to single line text in details view.
1485 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1487 Remove all javadoc author tags.
1489 Because they are awkward and meaningless when many people touch
1491 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1493 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1495 Revert the COPYING.LESSER to COPYING rename.
1497 Apparently both should be there if it is LGPL.
1499 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1501 *View: Remove unused imports.
1503 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1504 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1505 * src/main/java/org/glom/web/client/ui/ListView.java:
1506 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1507 Remove unused imports, as suggested by Eclipse.
1509 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1511 Move the *View::Presenter types, and some API into one base View.
1513 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1514 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1515 * src/main/java/org/glom/web/client/ui/ListView.java:
1516 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1517 Presenter, setPresenter() and clear() into a shared base interface,
1518 to avoid the unnecessary duplicate Presenter types and to more clearly
1519 show how the *Views share the same structure, even if they are not
1520 used polymorphically.
1522 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1523 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1525 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1526 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1527 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1529 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1532 Feel free to revert this if there is a good reason for the duplicate
1535 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1537 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1539 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1540 a class member instead of a local variable in the method.
1541 This lets us use it to get the view instances, for use in tests.
1542 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1543 beforeOnlineGlom(): Test some more details of the initial view.
1544 Again, this is not very useful.
1546 To really test gwt-glom we will need to start a local postgresql
1547 instance with local data, like the Glom tests in C++.
1549 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1551 pom.xml: Mention the LGPL license.
1553 * pom.xml: Add a licenses section.
1554 * COPYING.LESSER: Move this to COPYING, which
1555 previously contained the GPL. But gwt-glom is all LGPL.
1557 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1559 Add project information to README and pom.xml.
1561 * README: Add a brief description and mention some mvn
1563 * pom.xml: This extra information shows up in mvn site
1566 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1568 Use the latest java-libglom version.
1570 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1572 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1574 GwtTestOnlineGlom: Test a little more.
1576 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1577 protected rather than private, as suggested by the gwt-test-utils
1579 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1580 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1581 Test the initial visibility of the panels.
1583 However, this is not a very useful test.
1584 And I wonder how we should generally test using this idea for an
1585 activity/places app like ours where the real changes happen implicitly
1586 based on the history token/URL.
1588 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1590 Slight modification to *Mapper comments.
1592 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1593 (DataActivityMapper)
1594 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1596 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1598 Remove comments mentioning GIN because they are just copied from
1599 the example code and are apparently not helpful:
1600 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1601 Also change the mention of a class that is only in the example code.
1603 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1605 GwtTestOnlineGlom test: Minor changes.
1607 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1608 Avoid the long qualified class name and modify the comment
1609 because it is now obvious to me that the mocked class is the only
1610 custom one created via GWT.create().
1612 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1614 Tests: Added the beginnings of a test using gwt-test-utils.
1616 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1617 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1618 which tells gwt-test-utils what class will be tested.
1619 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1620 Add a simple (but empty) test case. One class, used by the OnlineGlom
1621 class, is mocked so that it can be created. However, I am not sure
1622 why only this class needs to be mocked.
1624 Note that mockito seems more popular, and clearer, than easymock,
1625 but I have not got that working yet. It might be a matter of the
1628 This test is run during mvn integration-test.
1630 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1632 Tests: Use junit4-style syntax instead of junit3-style.
1634 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1635 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1636 * src/test/java/org/glom/web/shared/DataItemTest.java:
1637 Use the @Test annotation rather than relying on the test*() prefix.
1638 Also no longer implement TestCase, to avoid triggering support for
1639 the junit3-way, which stops the annotations from working.
1640 Change the imports from import junit.framework.* to
1641 import org.junit.*, which is apparently the new way.
1643 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1645 Added a test for ListPlace token parsing and creation.
1647 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1648 This is much the same as DetailsPlaceTest.
1650 I wonder how we could test the other parts of the *Place API.
1652 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1654 DetailsPlace test: Also test getToken() and recreation via getPlace().
1656 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1657 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1658 recreate it, testing the recreated DetailsPlace for the same parameter
1661 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1663 Use the surefire-report plugin.
1665 * pom.xml: This generates a HTML report about the tests in
1666 target/site/surefire-report.html
1667 when you do mvn surefire-report:report. It seems to be popular/normal.
1669 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1671 Added a test for DetailsPlace.
1673 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1674 Test the getPlace() token parsing.
1676 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1678 Added a first unit test.
1680 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1681 * src/test/java/org/glom/web/shared/DataItemTest.java:
1682 This is a silly test but it is just to get things started. Note that
1683 maven/junit finds the test because it looks in src/test by default.
1685 2011-12-22 Ben Konrath <ben@bagu.org>
1687 Change charsetName to "UTF-8" when replacing line breaks.
1689 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1690 that work in Java (such as "UTF8") will not work when compiled to
1693 This fixes a problem with multi-line details view fields that have hard
1694 line breaks. The "License Text" field on this page demonstrates the
1697 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1699 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1701 2011-12-22 Ben Konrath <ben@bagu.org>
1703 Fix another bug with related list navigation.
1705 I've tested all the navigation buttons in all of the related lists
1706 so things should be good now.
1708 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1710 2011-12-22 Ben Konrath <ben@bagu.org>
1712 Fix a crasher when refreshing the list view with the default table.
1714 This crash will also happen when loading the list view with the default
1715 table from a link or bookmark.
1717 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1718 to the main document selection page when the document id hasn't been
1720 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1721 the main document selection page when the document id hasn't been
1723 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1724 values for the details place when the document id hasn't been set.
1725 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1726 values for the list place when the document id hasn't been set.
1728 2011-12-21 Ben Konrath <ben@bagu.org>
1730 Protect against NPE when glom.document.locale is not in config.
1732 This patch protects against an NPE when glom.document.locale is not in
1733 the config file. This NPE will also happen if glom.document.locale is
1736 The patch also updates the error message to display the class name when
1737 the getMessage() returns null. This was happening when the NPE was
1738 thrown and I had "Configuration Error: null". If an NPE is encountered
1739 with this patch, "Configuration Error: NullPointerException " will be
1742 This commit closes this bug:
1744 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1748 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1750 Rename onlineglom.properties to onlineglom.properties.sample.
1752 * src/main/resources/onlineglom.properties: Rename to:
1753 * src/main/resources/onlineglom.properties.sample:
1754 * src/main/resources/README: And add this file explaining that people
1755 should rename it back when deploying.
1757 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1759 Allow choosing the translation in the .properties file.
1761 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1762 init(): Read a glom.document.locale value from the configuration file
1763 and call Glom's TransatableItem::set_current_locale() method.
1764 * src/main/resources/onlineglom.properties: Add a commented-out
1765 example of this new setting.
1767 It would be better to add &lang=de_DE to the URL, but the current
1768 libglom API does not allow us to do this easily. I am working on that.
1770 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1772 Avoid a crash in parsing of token parameters.
1774 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1775 ava: getTokenParams(): Do not crash if a parameter has a key but no
1776 value, and ignore parameters with neither.
1778 2011-12-17 Murray Cumming <murrayc@murayc.com>
1780 History token building/handling: Improve use of token parameters.
1782 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1783 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1784 and buildParamsToken(HashMap), for use by derived classes.
1785 Make the separator private because it is no longer be needed.
1786 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1787 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1788 instead of manual string concatenation.
1789 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1790 of hardcoded indices and awkward splitting code.
1791 * src/main/java/org/glom/web/client/place/ListPlace.java
1792 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1793 instead of manual string concatenation.
1794 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1795 of hardcoded indices and awkward splitting code.
1796 This should fix bug #666420
1798 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1800 Fix a Navgiation->Navigation typo in the code.
1802 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1803 Rename processNavgiation() to processNavigation().
1805 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1807 Fix a seperator->separator typo in the code.
1809 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1810 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1811 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1814 2011-12-15 Ben Konrath <ben@bagu.org>
1816 Cleanup some comments.
1818 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1820 2011-12-14 Ben Konrath <ben@bagu.org>
1822 Replace \n with <br/> for multiline text in the details view.
1824 Vertical scrollbars are added when needed as well.
1826 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1828 2011-12-14 Ben Konrath <ben@bagu.org>
1830 Specify the font for document selection links.
1832 * src/main/webapp/style.css:
1834 2011-12-14 Ben Konrath <ben@bagu.org>
1836 Fix bouncy CellTable while paging.
1838 This doesn't currently work with related list tables in unselected
1841 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1843 2011-12-14 Ben Konrath <ben@bagu.org>
1845 Revamp the appearance of the document selection page.
1847 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1848 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1849 * src/main/webapp/style.css:
1851 2011-12-13 Ben Konrath <ben@bagu.org>
1853 Set navigation button column to the smallest size possible.
1855 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1857 2011-12-13 Ben Konrath <ben@bagu.org>
1859 Change OpenButton nomenclature to NavigationButton.
1861 Using NavigtionButton makes things more generic. Classes, methods and
1862 variables have been changed.
1864 This is a rename-only refactor.
1866 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1867 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1868 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1869 Renamed from OpenButtonCell.
1870 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1871 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1872 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1874 2011-12-12 Ben Konrath <ben@bagu.org>
1876 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1878 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1879 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1880 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1881 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1883 2011-12-12 Ben Konrath <ben@bagu.org>
1885 Update variable names and comments.
1887 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1888 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1890 2011-12-12 Ben Konrath <ben@bagu.org>
1892 Properly initialize numNonEmptyRows variable to zero.
1894 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1895 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1897 2011-12-05 Ben Konrath <ben@bagu.org>
1899 Add latest mockup with HTML tables.
1901 Features of this mockup:
1903 -> HTML table for flowtable
1904 -> HTML table for flowtable column
1905 -> Example of how related lists would look
1906 -> Not using text entries for data items
1908 The current version of Online Glom doesn't use HTML tables for the
1911 This mockup has been sent to the glom-devel mailing list but it's good
1912 to have it here as well.
1914 * mockups/details-view-html-tables.html:
1916 2011-12-05 Ben Konrath <ben@bagu.org>
1918 Remove unnecessary getPrimaryKeyField() method.
1920 getPrimaryKeyFieldForTable(String) has been renamed to
1921 getPrimaryKeyField(String).
1923 * src/main/java/org/glom/web/server/database/DBAccess.java:
1924 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1925 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1927 2011-12-05 Ben Konrath <ben@bagu.org>
1929 Add string representation of TypedDataItem value to conversion error message.
1931 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1932 message was extracted into its own method to avoid duplication.
1934 2011-12-05 Ben Konrath <ben@bagu.org>
1936 Add type checking to navigation primary key value creation.
1938 Create navigation primary key only if the expected type from the Glom
1939 document matches the type returned by the SQL query.
1941 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1943 2011-12-05 Ben Konrath <ben@bagu.org>
1945 Rename a couple of variables in RelatedListNavigation.
1947 This is a rename-only refactor.
1949 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1951 2011-12-05 Ben Konrath <ben@bagu.org>
1953 Move getListLayoutGroup() into getListViewLayoutGroup().
1955 This removes getListLayoutGroup(). It was only being called by
1956 getListViewLayoutGroup().
1958 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1960 2011-12-05 Ben Konrath <ben@bagu.org>
1962 Remove check for LayoutItem_Portal in list table method.
1964 This check is no longer necessary because the method isn't being used
1965 to create the LayoutItemPortal DTO.
1967 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1969 2011-12-05 Ben Konrath <ben@bagu.org>
1971 Properly support related list navigation.
1973 Navigation from the "Repository Analyzer -> Package Scans ->
1974 Dependencies" related table wasn't working because the primary key for
1975 related tables wasn't being set properly. This commit fixes the
1978 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1979 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1980 doesn't set the primary key properly for related list tables.
1981 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1982 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1983 useful for getting the primary key for list view tables and for related
1985 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1986 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1987 Move code to set the primary key for the table from the abstract
1988 ListDBAccess class to ListViewDBAccess as it's only correct for list
1990 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1991 Properly add primary key to related list tables.
1993 2011-12-02 Ben Konrath <ben@bagu.org>
1995 Properly set the horizontal alignment of fields.
1997 This fix is for both the list tables and the details view.
1999 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2000 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2001 to set the horizontal alignment of fields.
2003 2011-12-02 Ben Konrath <ben@bagu.org>
2005 Display currency codes in the details view.
2007 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2009 2011-12-02 Ben Konrath <ben@bagu.org>
2011 Avoid duplicate JNI call.
2013 JNI is not as efficient as pure Java and this is an easy (and small)
2016 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2017 Use previously retrieved value for whereClauseToTableName instead of
2020 2011-12-02 Ben Konrath <ben@bagu.org>
2022 Rename a couple of variables in RelatedListNavigation.
2024 This is a rename-only refactor.
2026 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2028 2011-12-02 Ben Konrath <ben@bagu.org>
2030 Indicate clearly that a mismatched primary key type is a bug.
2032 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2033 warning to error. Add 'This is a bug.' to message.
2035 2011-12-02 Ben Konrath <ben@bagu.org>
2037 Update / fix some comments.
2039 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2041 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2043 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2044 Fix comments. Add some TODOs.
2046 2011-12-02 Ben Konrath <ben@bagu.org>
2048 Enable navigation to details view with string primary key from related list.
2050 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2051 Create a text primary key value when return type of result is
2052 java.sql.Types.VARCHAR.
2054 2011-12-02 Ben Konrath <ben@bagu.org>
2056 Use checkboxes for booleans in the details view.
2058 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2060 2011-12-01 Ben Konrath <ben@bagu.org>
2062 Improve performance of related list height calculation.
2064 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2065 Put code to calculate the expected height in a static initializer so
2066 that that it's only called once.
2068 2011-12-01 Ben Konrath <ben@bagu.org>
2070 Show related list tables in notebooks (again).
2072 Calculate the height of the related list tables so the Notebook can be
2073 set the correct height. The height of the related list table is also needed by
2074 FlowTable to be able decide how to create the layout.
2076 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2077 and set the Portal height based on the height of the related list
2078 table and the Portal container.
2079 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2080 Add method to calculate the height of the related list tables.
2081 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2082 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2083 calculate the height of the Pager widget.
2085 2011-12-01 Ben Konrath <ben@bagu.org>
2087 Use CellTable API for table property instead of setting style on Element.
2089 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2091 2011-12-01 Ben Konrath <ben@bagu.org>
2093 Make ListViewTable and RelatedListTable a consistent height.
2095 The tables are now a consistent height regardless of the contents of
2096 the table. A hidden button is added to empty rows to ensure that the
2097 height of these rows will match the height of rows with data.
2099 A navigation button column is now added to every table. The width of
2100 the navigation column is set to 0px when a RelatedListTable shouldn't
2101 have navigation buttons. This maintains the a consistent row height in
2102 tables that don't show the navigation buttons.
2104 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2105 navigation column when not needed.
2106 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2107 arguments for navigation button to constructor of ListViewTable.
2108 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2109 hidden button for empty data rows.
2110 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2111 arguments for navigation button to constructor.
2112 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2113 create navigation buttons. Add hideNavigationButtons() method.
2114 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2115 arguments for navigation button to constructor.
2117 2011-12-01 Ben Konrath <ben@bagu.org>
2119 Use 'visibility: hidden' in Utils.getWidgetHeight().
2121 This is better choice because hidden elements are invisible, don't
2122 respond to events and are not part of the tab order. They will,
2123 however, take up space which is required to be able to calculate the
2124 height of the widget.
2126 * src/main/java/org/glom/web/client/Utils.java:
2128 2011-12-01 Ben Konrath <ben@bagu.org>
2130 Use Utils.getWidgetHeight() in FlowTable.
2132 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2134 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2136 2011-12-01 Ben Konrath <ben@bagu.org>
2138 Put the details css class name on the correct table column.
2140 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2142 2011-11-30 Ben Konrath <ben@bagu.org>
2144 Update for java-libglom API change.
2146 The getters and setters on FieldFormatting and NumericFormat were
2147 changed to remove the 'M'.
2149 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2151 2011-11-29 Ben Konrath <ben@bagu.org>
2153 Only allow RelatedListTables in Portals.
2155 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2157 2011-11-29 Ben Konrath <ben@bagu.org>
2159 Only create a contents panel for Portals when title is being set.
2161 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2163 2011-11-29 Ben Konrath <ben@bagu.org>
2165 Set TabLayoutPanel height based on calculated height its widgets.
2167 This is a potential fix for this bug:
2169 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2171 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2173 2011-11-29 Ben Konrath <ben@bagu.org>
2175 Align details field labels and data with the Open buttons.
2177 * src/main/webapp/style.css:
2179 2011-11-29 Ben Konrath <ben@bagu.org>
2181 Remove unnecessary <div> in the Notebook widget.
2183 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2184 method to get container FlowPanel (<div>).
2185 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2186 initWidget() method directly on the TabLayoutPanel widget instead of
2187 Group's container widget.
2189 2011-11-29 Ben Konrath <ben@bagu.org>
2191 Don't add group titles for Portals in Notebooks.
2193 This reverts the previous patch and fixes a bug I introduced with
2194 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2196 * src/main/java/org/glom/web/client/ui/details/Group.java:
2197 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2199 2011-11-28 Ben Konrath <ben@bagu.org>
2201 Remove unused boolean argument in Portal constructor.
2203 Just a code cleanup.
2205 * src/main/java/org/glom/web/client/ui/details/Group.java:
2206 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2208 2011-11-28 Ben Konrath <ben@bagu.org>
2210 Remove hack for glom 1.18 style glom files.
2212 * src/main/java/org/glom/web/client/ui/details/Group.java:
2213 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2214 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2216 2011-11-28 Ben Konrath <ben@bagu.org>
2218 Use Gda Value version of primary key to log result too large error.
2220 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2222 2011-11-28 Ben Konrath <ben@bagu.org>
2224 Don't use TypedDataItem.getText() for Unknown types from the URL.
2226 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2227 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2228 instead of getText().
2229 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2230 String field and getUnknown() method.
2232 2011-11-28 Ben Konrath <ben@bagu.org>
2234 Log an error message when the java-libglom .so is not present.
2236 The error message was being set in the exception but not logged.
2238 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2240 2011-11-28 Ben Konrath <ben@bagu.org>
2242 Ignore LayoutItem_CalendarPortals.
2244 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2245 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2247 2011-11-28 Ben Konrath <ben@bagu.org>
2249 Extract method for creating the LayoutItemPortal DTO.
2251 Just breaking the code up into smaller chunks.
2253 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2255 2011-11-28 Ben Konrath <ben@bagu.org>
2259 This should have been added with the refactor. Oops!
2261 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2263 2011-11-28 Ben Konrath <ben@bagu.org>
2265 Create primary key value from URL string using type from Glom document.
2267 See this bug, comments 19 - 25:
2269 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2271 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2272 create a TypeDataItem for the primary key here when loading from a
2273 URL. Show the same string for the primary key value as was received
2274 from the URL string (when loading from a URL).
2275 * src/main/java/org/glom/web/server/Utils.java: Update method for
2276 creating the Gda Value from the TypeDataItem to properly deal with
2277 creating a Gda Value based on the Glom document type for the primary
2278 key value string when loading from a URL.
2279 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2280 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2281 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2282 Update for changed method name.
2284 2011-11-27 Ben Konrath <ben@bagu.org>
2286 Rename PrimaryKeyItem to TypedDataItem.
2288 The name PrimaryKeyItem suggests what the class should be used for.
2289 TypedDataItem is a neutral name that describes the class better.
2291 This is a rename-only refactor.
2293 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2294 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2295 * src/main/java/org/glom/web/client/Utils.java:
2296 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2297 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2298 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2299 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2300 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2301 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2302 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2303 * src/main/java/org/glom/web/server/Utils.java:
2304 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2305 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2306 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2307 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2309 2011-11-25 Ben Konrath <ben@bagu.org>
2311 Improve Gda Value conversion from PrimaryKeyItem.
2313 The value from the PrimaryKeyItem is only used if its type match the
2314 type from the glom document.
2316 * src/main/java/org/glom/web/server/Utils.java:
2318 2011-11-25 Ben Konrath <ben@bagu.org>
2320 Manually check if the java-liblgom .so is visible to the JVM.
2322 It seems that Tomcat has problems when a static initializer throws an
2323 exception. This check is done before the first method call into
2324 java-libglom so that execution doesn't continue if the .so is not
2327 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2329 2011-11-25 Ben Konrath <ben@bagu.org>
2331 Improve browser configuration error messages.
2335 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2337 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2338 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2339 getConfigurationErrorMessage() method.
2340 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2341 Get and display a specific configuration error message when no Glom
2342 documents are found.
2343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2344 Implement getConfigurationErrorMessage() method. Surround configuration
2345 code in the init() method with a try/catch block. This allows the
2346 errors to be caught while keeping the servlet available to retrieve the
2347 configuration error message.
2349 2011-11-25 Ben Konrath <ben@bagu.org>
2351 Don't use Strings to hold primary key values.
2353 The primary key values are now held in a new data object
2354 (PrimaryKeyItem) that holds type information and the primary key value
2355 using the correct type.
2357 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2358 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2359 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2360 PrimaryKeyItem instead of String to hold the primary key value.
2361 * src/main/java/org/glom/web/client/Utils.java: Remove
2362 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2363 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2364 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2365 PrimaryKeyItem instead of String to hold the primary key value. Load
2366 document selection page when the documentID has not been set correctly.
2367 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2368 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2370 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2371 Return empty string for URL instead of "null".
2372 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2373 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2374 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2375 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2376 PrimaryKeyItem instead of String to hold primary key values.
2377 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2378 PrimaryKeyValue to a Gda Value.
2379 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2380 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2381 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2382 Replace temporary database access code that uses the PrimaryKeyValue to
2383 Gda Value conversion.
2384 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2385 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2386 PrimaryKeyItem instead of String.
2387 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2388 hold primary key values.
2390 2011-11-24 Ben Konrath <ben@bagu.org>
2392 Use newly added java-libglom API to create queries.
2394 This isn't finished. I still need to stop using Strings for primary key
2395 values in the client code.
2397 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2398 libglom to use fake connections so that retrieving the query string will
2400 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2401 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2402 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2403 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2404 Use the newly added libglom sql methods and classes to create the
2405 query. Add temporary hack to convert primary value strings to Gda
2408 2011-11-23 Ben Konrath <ben@bagu.org>
2410 Don't explicitly set the height of Portals.
2412 See comments 6 - 10 of this bug for details:
2414 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2416 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2418 2011-11-23 Ben Konrath <ben@bagu.org>
2420 Use an HTML table instead of CSS for the FlowTable layout.
2422 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2423 GWT's FlexTable to implement the FlowTable.
2424 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2426 2011-11-18 Ben Konrath <ben@bagu.org>
2428 Add boolean example to HTML table mockup.
2430 * mockups/details-view-html-tables-text-entries.html:
2432 2011-11-17 Ben Konrath <ben@bagu.org>
2434 Ensure the pager buttons are always visible for related lists.
2436 To accomplish this, I've turned off text wrapping in the list view and
2437 related list tables for both the header and data text. The related list
2438 table now has a fixed layout so the it doesn't overflow its container.
2439 This is required to ensure that the cell text is clipped when it
2440 overflows the cell and an ellipsis is added to the right side of the
2441 cell when text is clipped.
2443 A fixed table layout for the related list table in the details view
2444 seems what we want for the details view anyway, so the side-effect is
2447 The ellipsis will only be displayed in Firefox >= 7.
2451 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2453 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2454 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2455 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2457 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2458 Set the 'table-layout: fixed' CSS property to the related list table.
2459 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2460 'white-space: nowrap;' CSS property on both the list view and the
2461 related list tables.
2463 2011-11-16 Ben Konrath <ben@bagu.org>
2465 Rework the fix for empty notebook tab labels.
2467 Setting the empty group titles with its name caused problems for the
2468 details layout. Instead of using libglom's
2469 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2470 to the client when the title is empty. This allows the Notebook to use
2471 the name when the title is empty without affecting anything else.
2473 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2474 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2476 2011-11-16 Ben Konrath <ben@bagu.org>
2478 Set group titles with name when title is empty.
2480 This fixes a problem with an empty notebook tab label in the Lesson
2481 Planner document. The forth tab in the notebook should be "Internet":
2483 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2485 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2486 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2489 2011-11-16 Ben Konrath <ben@bagu.org>
2491 Remove whitespace from the configured username properties.
2493 This assumes that usernames won't have whitespace at the beginning
2494 or end. But I think this is a reasonable assumption.
2496 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2497 String.trim() to remove the whitespace from the username properties.
2499 2011-11-15 Ben Konrath <ben@bagu.org>
2501 Add details view mockup with HTML tables and text entries.
2503 This is from the attachment on this bug:
2505 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2507 * mockups/details-view-html-tables-text-entries.html:
2509 2011-11-15 Ben Konrath <ben@bagu.org>
2511 Add space between the columns of the flow table.
2515 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2517 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2518 space between columns in the flow table.
2520 2011-11-15 Ben Konrath <ben@bagu.org>
2522 Add backup files to the .gitignore.
2524 * .gitignore: Ignore files that end with ~.
2526 2011-11-09 Ben Konrath <ben@bagu.org>
2528 Use latest release of gwt-log.
2530 Gwt-log releases are now being submitted to the maven central
2531 repository so manual installation of the jar is no longer required.
2533 * pom.xml: Update version and groupId of gwt-log dependency.
2535 2011-10-31 Ben Konrath <ben@bagu.org>
2537 Don't use GWT numeric formatting to override the glom currency formatting.
2539 Currencies are now displayed like they are in Glom. See this bug:
2541 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2543 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2545 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2546 currency code to constructor and set it when the cell is rendered.
2547 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2548 currency code to the constructor of the NumericCell.
2550 2011-10-27 Ben Konrath <ben@bagu.org>
2552 Require the latest release of java-libglom (1.17.4).
2556 2011-10-26 Ben Konrath <ben@bagu.org>
2558 Add style to Notebook that matches current theme.
2560 It's not the best style in the world but it's better than the default.
2562 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2563 padding at the bottom of the child widgets.
2564 * src/main/webapp/style.css: Add style for the Notebook.
2566 2011-10-26 Ben Konrath <ben@bagu.org>
2568 Move servlet initialization code to overridden init method.
2570 This is half of the solution to getting proper error messages
2571 displayed when configuration errors occur. Here's the relevant bug:
2573 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2575 The rest of the solution involves surrounding the init method with a
2576 try/catch block and setting a global variable with the error /
2577 exception. A new async method should be created to retrieve and display
2578 the error message / exception.
2580 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2581 code from constructor to init method adding exceptions as needed.
2583 2011-10-26 Ben Konrath <ben@bagu.org>
2585 Add script to monitor and restart tomcat if required.
2587 * utils/check-and-recover-tomcat.py: New file.
2589 2011-10-26 Ben Konrath <ben@bagu.org>
2591 Display the correct number of data items in the pager.
2595 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2597 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2598 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2599 The implementation is the same for both tables: Keep track of the
2600 number of non-empty rows and fire and RowCountChangeEvent after the data has
2602 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2603 custom Pager class that subclasses SimplePager to handle displaying
2604 the correct number when empty rows have been added.
2606 2011-10-26 Ben Konrath <ben@bagu.org>
2608 Correct error in previous commit.
2610 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2611 eventBus parameter from listView.setCellTable().
2613 2011-10-26 Ben Konrath <ben@bagu.org>
2615 Fix error in TODO comment.
2617 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2619 2011-10-24 Ben Konrath <ben@bagu.org>
2621 Create Notebook widgets to the details view.
2623 This isn't finished just yet - I still need to create a reasonable
2624 style to match the current theme.
2626 * src/main/java/org/glom/web/client/Utils.java: Add method for
2627 calculating the height of a widget. This is used in the Notebook class.
2628 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2629 new constructor method in Group.
2630 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2631 method for creating child widget that can be used by subclasses
2632 like Notebook. New constructor that allows disabling the group
2633 titles - Notebooks don't set a group title for their child groups.
2634 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2635 to make Notebooks using GWT's TabLayoutPanel.
2636 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2637 constructor that allows disabling the group titles.
2638 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2639 LayoutItemNotebook DTO.
2640 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2641 DTO for Notebooks. It's just an empty class for now but we might need
2642 it to transfer some specific information in the future.
2644 2011-10-21 Ben Konrath <ben@bagu.org>
2646 Add navigation buttons to related list tables.
2648 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2649 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2650 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2651 method getSuitableRecordToViewDetails() for getting the table name
2652 and primary key value for related list navigation buttons.
2653 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2654 private cell renderer class to get the navigation information for
2655 related list tables from the server. Extract the navigation
2656 processing code from the details cell navigation and use it for the
2657 related list navigation as well.
2658 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2659 cell renderer class for the details open buttons. This was needed
2660 because the related list navigation buttons and the list view
2661 navigation buttons need to react differently when clicked.
2662 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2663 the onEnterKeyDown() method because it's now overriden in the
2664 subclasses that are specific to the related list tables and the list
2666 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2667 the vertical size a little because the buttons add a bit of vertical
2668 space to table. This is not a perfect solution because the vertical
2669 size of with table fewer than 5 rows will be a little smaller.
2670 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2671 changes in how navigation buttons are handled.
2672 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2673 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2674 database access object.
2675 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2676 to find the portal for a given relationship name from
2677 RelatedListDBAccess. Add method to find a primary key field for a
2679 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2680 Move code to find the portal for a given relationship name to
2682 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2683 New file: database access object for getting the related list
2684 navigation information (the table name and the primary key value).
2685 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2686 DTO for transferring a table name to navigate to and a primary key
2688 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2689 boolean and getter/setter to specifies if the related list should add
2692 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2694 Use the master branch of java-libglom
2696 * pom.xml: Depend on java-libglom 1.19 instead.
2698 This is the master branch. See also the libglom-1-18 branch.
2700 2011-10-11 Ben Konrath <ben@bagu.org>
2702 Enable the open navigation button when the data has been set.
2704 This avoids having active buttons that don't do anything when the data
2707 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2709 2011-10-11 Ben Konrath <ben@bagu.org>
2711 Use IsWidget interface for FlowTableItem.
2713 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2714 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2716 2011-10-11 Ben Konrath <ben@bagu.org>
2718 Remove GWT styling from open button in details view.
2720 There are still some issues with how the details cell is arranged but
2721 this should be made to match Glom 1.20. I'm going to leave fixing this
2722 until I have Glom 1.20 up and running.
2724 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2725 style name on open button.
2726 * src/main/webapp/style.css: Move and edit details-navigation class.
2727 Re-arrange some classes to make them appear in the same order as the
2730 2011-10-07 Ben Konrath <ben@bagu.org>
2732 Update to GWT 2.4.0.
2734 * .gitignore: Ignore new cache directory.
2735 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2736 * pom.xml: Change GWT and maven plugin to 2.4.0.
2737 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2739 * src/main/java/org/glom/web/client/ClientFactory.java:
2740 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2741 * src/main/java/org/glom/web/client/OnlineGlom.java:
2742 Update source for API changes.
2743 * utils/build-onlineglom-war.sh: Remove cache directory before the
2746 2011-10-07 Ben Konrath <ben@bagu.org>
2748 Add navigation buttons in the details view.
2750 This isn't finished but I thought I'd commit what I have as it's a
2751 pretty good start. I still need to:
2753 1. Change the style so that it fits better into the current theme
2754 2. Adjust the details cell to expand as much as possible.
2756 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2757 click handlers to navigation buttons in the DetailsCells. Create a
2758 refreshData() method to get just the data from the server without the
2760 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2761 Update the tableSelector and browser title when the table name
2762 changes without using the tableSelector.
2763 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2764 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2765 getDetailsCells() to getCells(). Update variable names.
2766 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2767 method to set click handler on navigation button. Rename a few
2768 variables. Add navigation buttons where needed.
2769 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2770 variables and methods.
2771 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2772 navigation boolean and navigation table as required in the
2773 LayoutItemField DTO.
2774 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2775 variables for navigation along with getter/setter methods.
2777 2011-10-07 Ben Konrath <ben@bagu.org>
2779 Rename Field to DetailsCell.
2781 This is a refactor-only commit. No functionality has been added or
2784 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2785 Update variable and method names.
2786 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2787 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2788 variable and method names.
2789 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2791 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2792 variable and method names.
2794 2011-10-07 Ben Konrath <ben@bagu.org>
2796 Create separate methods for layout and data the details view.
2798 This is a refactor-only commit. No functionality has been added or
2801 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2802 private methods: setData(), createLayout().
2804 2011-10-07 Ben Konrath <ben@bagu.org>
2806 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2808 This is part of a change to get navigation buttons in the details view
2809 but it should have been done this way from the start.
2811 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2812 for method name change in TableSelectionView.
2813 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2814 Create TableChangeEvent and set the browser title using the
2815 TableSelectionView API.
2816 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2817 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2818 Change getSelectedTable() to getSelectedTableName(). Add
2819 getSelectedTableTitle().
2821 2011-10-07 Ben Konrath <ben@bagu.org>
2823 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2825 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2827 2011-10-07 Ben Konrath <ben@bagu.org>
2829 Update TableChangeEvent to use newTableName naming convention.
2831 This makes the class more consistent with GWT naming conventions.
2833 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2834 Update for method name change in TableChangeEvent.
2835 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2836 for method name change in TableChangeEvent.
2837 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2838 newTableName variable and getter method. Make toDebugString()
2841 2011-09-30 Ben Konrath <ben@bagu.org>
2843 Disable the pager in the list tables when the data row count is less than the minimum.
2845 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2846 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2848 2011-09-30 Ben Konrath <ben@bagu.org>
2850 Add empty rows to the end of related list and list view tables.
2852 I also extracted the cell rendering classes from the ListTable because
2853 the code was becoming a little crazy with all the anonymous inner
2854 classes. My plan is to use these cell rendering classes in the details
2855 view as well so this refactor will be needed for that change.
2857 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2858 set the row count in related list tables if the data has more rows
2859 than the minimum number of rows visible.
2860 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2861 row count in list view tables if the data has more rows than the
2862 minimum number of rows visible.
2863 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2864 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2866 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2867 for rendering TYPE_NUMERIC cells. The code was extracted from the
2869 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2870 class for rendering cells with buttons in list views. The code was
2871 extracted from the ListTable class.
2872 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2873 for rendering TYPE_TEXT cells. The code was extracted from the
2875 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2876 Add empty rows to the end of the data if required. Implement
2877 ListTable.getMinNumVisibleRows().
2878 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2879 cell renderer code to public classes. Return null in
2880 Column.getValue() for empty rows. Add new abstract method:
2881 getMinNumVisibleRows(). Move code to set the row count of the list view
2882 table to ListViewImpl.
2883 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2884 empty rows to the end of the data if required. Implement
2885 ListTable.getMinNumVisibleRows().
2888 2011-09-27 Ben Konrath <ben@bagu.org>
2890 Use GWT.log for client-side debugging statements.
2892 These are optimized out when deployed so I should have used this method
2893 in the first place. These statements will eventually be replaced with some sort
2894 of notification in the browser.
2896 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2897 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2898 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2899 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2900 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2902 2011-09-27 Ben Konrath <ben@bagu.org>
2904 Put tableselector on the right, back to list link on right.
2906 The idea is that the table selector is acting like a label for the
2907 currently displayed table so it should be placed below the document title. This
2908 puts the table title in a similar position to where it is in Glom.
2910 * mockups/details-contacts.html:
2911 * mockups/details-projects.html:
2912 * mockups/listview-contacts.html:
2913 * mockups/listview-projects.html:
2914 * mockups/style.css:
2915 Update mockups to match how the interfaces currently look.
2916 * src/main/webapp/style.css: Swap positions of backlink with the table
2917 selector. Add some space on the left side of the table selector to
2918 line things up with the document title.
2920 2011-09-27 Ben Konrath <ben@bagu.org>
2922 Add field colouring to details view.
2924 This change re-works how field colouring works. The colour formatting
2925 information is now set to the client with the layout information instead of
2926 with the data. This eliminates the need to send the same colour strings for
2927 data in list view column when colour information is set.
2929 In order to set an alternate colour for negative numeric values, the
2930 number is now sent to client and formatted with the GWT NumberFormat class.
2932 This change also fixes:
2934 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2936 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2937 internationalization framework which is needed for client side numeric
2939 * src/main/java/org/glom/web/client/Utils.java: New file for some
2940 client static utility methods.
2941 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2942 the DataItem object to the Field class. Use a utility method to
2943 create the foreignKeyValue string.
2944 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2945 alignment and text colours in the constructor. Add setData(DataItem)
2946 method. Remove setText(String) method.
2947 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2948 colour information to GlomTextCell. Create and use GlomNumberCell for
2949 rendering numbers. Use utility method to get the string for the
2950 primary key of the key provider. Re-work how the horizontal alignment
2952 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2953 formatting to layout information. Methods for converting the libglom
2954 formatting information were moved from DBAccess.
2955 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2956 numeric formatting (it's now done on the client side). Don't set text
2957 colours in DataItem. Move libglom formatting conversion methods to
2959 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2960 getters/setters for text colour information.
2961 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2962 for transferring the libglom NumericFormat information to the client.
2963 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2964 and getters/setters for: GlomNumericFormat, background colour and
2965 foreground colour strings.
2967 2011-09-26 Ben Konrath <ben@bagu.org>
2969 Simplify code that iterates through the LayoutGroup.
2971 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2973 2011-09-26 Ben Konrath <ben@bagu.org>
2975 Accept Eclipse formatting for OnlineGlomServiceAsync.
2977 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2979 2011-09-26 Ben Konrath <ben@bagu.org>
2981 Don't use the ListDBAccess classes to get the primary key layout information.
2983 This was causing a bug where the wrong index for the hidden primary key
2984 was being sent to the client.
2986 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2987 primary key while creating the LayoutGroup DTO. Create a
2988 LayoutItemField DTO for hidden primary keys. Don't use the
2989 RelatedListDBAccess because it was only used for getting the primary
2991 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2992 access modifier from public to protected for getPrimaryKeyField() and
2993 getPrimaryKeyLayoutItemField().
2994 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2995 abstract method getExpectedResultSize() because RelatedListDBAccess
2996 doesn't have enough info to implement it.
2997 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2998 Remove @Override for getExpectedResultSize().
2999 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3000 Remove method getExpectedResultSize().
3002 2011-09-23 Ben Konrath <ben@bagu.org>
3004 Log which layout (list or details) the ignored item is from.
3006 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3008 2011-09-23 Ben Konrath <ben@bagu.org>
3010 Remove annotations that turn off code formatting in DataItem.
3012 * src/main/java/org/glom/web/shared/DataItem.java:
3014 2011-09-23 Ben Konrath <ben@bagu.org>
3016 Rename GlomField to DataItem and update associated methods.
3018 This is a rename-only refactor. No functionality has been added or
3021 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3022 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3023 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3024 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3025 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3026 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3027 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3028 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3030 * src/main/java/org/glom/web/server/database/DBAccess.java:
3031 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3032 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3033 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3034 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3035 * src/main/java/org/glom/web/shared/DataItem.java:
3036 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3037 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3039 2011-09-23 Ben Konrath <ben@bagu.org>
3041 Rename GlomDocument to DocumentInfo and update associated methods.
3043 This is a rename-only refactor. No functionality has been added or
3046 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3047 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3048 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3049 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3050 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3051 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3052 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3054 2011-09-20 Ben Konrath <ben@bagu.org>
3056 Require java-libglom 1.17.3.
3058 This picks up the fix for the seg fault problem with the Scenes table
3059 in the Openismus Film Manager example.
3063 2011-09-20 Ben Konrath <ben@bagu.org>
3065 Change the way sort clause is added for primary key when no sort clause is requested.
3067 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3068 before the sort clause is created. When a sort clause is not requested, the
3069 sort clause is created by finding the primary key in the LayoutFieldVector
3072 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3074 2011-09-20 Ben Konrath <ben@bagu.org>
3076 Log error message if no documents are found in the configured directory.
3078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3079 Extract the glom file extension string to a private static final class
3080 variable (mostly as syntactic sugar). Accept a minor formatting change.
3081 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3082 the example glom.document.directory configuration property to make it
3083 more clear that it can any directory, not just the home directory.
3085 2011-09-18 Ben Konrath <ben@bagu.org>
3087 Add related lists to details view.
3089 The related list table has support for paging and sorting just like the
3090 table in the list view.
3092 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3093 SQL queries for the related list tables.
3094 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3095 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3096 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3097 Rename getList methods to getListView and add comments. Remove
3098 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3099 it being unused. Add methods: getDetailsLayoutAndData(),
3100 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3102 Create the layout and set the data for the fields in one async call
3103 instead of two. Create related lists where appropriate.
3104 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3105 for method name changes in OnlineGlomService.
3106 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3107 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3108 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3110 * src/main/java/org/glom/web/client/ui/ListView.java:
3111 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3112 tableName from setCellTable(). Create a ListViewTable instead of
3114 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3115 represent a data field in the details view.
3116 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3117 from addDetailsCell() to Field class. Keep track of the Fields and
3118 Portals in the details view.
3119 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3120 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3121 and add a method to get it. Add method to set the contents of the
3123 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3124 New class for related list tables. This class has the data provider
3125 for the related list table.
3126 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3127 abstract class which is the base class for the ListViewTable and the
3129 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3130 New class for list view tables. This class has the data provider for
3131 the list view table.
3132 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3133 methods for related list tables. Add more information to the
3134 LayoutItemField and LayoutItemPortal DTOs.
3135 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3136 Remove debugging print statement.
3137 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3138 Remove debugging print statements. Add primary key field to SQL count
3140 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3141 Remove unnecessary LayoutFieldVector parameter from
3142 getResultSizeOfSQLQuery() method.
3143 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3144 New class for related list table database access.
3145 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3146 class that is a wrapper DTO for details view layout and data.
3147 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3148 new 'fromField' string to this DTO.
3149 * src/main/webapp/style.css: Remove bottom margin and override top
3152 2011-09-15 Ben Konrath <ben@bagu.org>
3154 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3156 This sets things up to make it easier to add the data retrieval for
3157 related lists (portals). No user noticeable changes were made with
3160 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3161 class has the code to retrieve the layouts and access the
3162 database using the new database helper classes.
3163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3164 Most of the functionality has been removed from this class. This
3165 class now represents the public interface for the client side
3166 code. It also deals with configuring the servlet and cleaning
3167 things up when the servlet is stopped.
3168 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3169 of static methods into this utility class.
3170 * src/main/java/org/glom/web/server/database/DBAccess.java:
3171 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3172 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3173 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3174 These classes have the database retrieval code. The class hierarchy
3175 has been setup to make it easy to reuse code for similar
3178 2011-09-06 Ben Konrath <ben@bagu.org>
3180 Create separate classes for list table code and the data provider.
3182 As part of this refactor, I also split up the code a bit to make it
3185 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3186 table code to two new classes (below).
3187 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3188 with code from ListViewImpl.
3189 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3190 New file with code from ListViewImpl.
3192 2011-09-06 Ben Konrath <ben@bagu.org>
3194 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3196 This fixes the LayoutItemPortal DTO to match the libglom layout object
3199 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3201 2011-09-01 Ben Konrath <ben@bagu.org>
3203 Set title of Portals in the Details View.
3205 * pom.xml: Bump required version of java-libglom to 1.17.1.
3206 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3207 widget creation to its own class. Add comments to constructor.
3208 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3209 The code is mostly from the Group class with the title now set.
3210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3211 title of Portal. Update some comments. Fix some code formatting.
3213 2011-09-01 Ben Konrath <ben@bagu.org>
3215 Remove TODO comment for the flow table column width.
3217 The flow table column width is working correctly and doesn't need to be
3218 changed. See this mailing list post for more info:
3220 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3222 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3224 2011-08-27 Ben Konrath <ben@bagu.org>
3226 Add document title (database name) to top of the browser page.
3228 I added the document title to the TableSelecitonView but that will
3229 change if / when we add a view that doesn't require table selection.
3231 * mockups/details-contacts.html:
3232 * mockups/details-projects.html:
3233 * mockups/listview-contacts.html:
3234 * mockups/listview-projects.html:
3235 * mockups/style.css: Add document title to mockups to keep things
3237 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3238 sizes to account for the document title.
3239 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3240 Set the document title when it has been retrieved from the server.
3241 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3242 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3243 and implement setDocumentTitle(String) method.
3244 * src/main/webapp/style.css: Add ID for document title style.
3246 2011-08-25 Ben Konrath <ben@bagu.org>
3248 Add NavigationType enum to LayoutItemPortal DTO.
3250 This is the start of adding support for Portals to the Details View.
3252 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3253 LayoutItem_Portal.navigation_type enum from libglom to
3254 LayoutItemPortal.NavigationType enum.
3255 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3256 NavigationType enum, field for storing the NavigationType and getter