1 2012-05-05 Murray Cumming <murrayc@murrayc.com>
3 Fix the build (mvn package)
5 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
6 (LayoutGroup): Make the LayoutItemList inner class static and protected.
7 Otherwise the GWT Java->Javascript compilation fails with just this
8 error, during mvn package or when attempting to view in a browser,
9 in the GWT developer mode in Eclipse.
11 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
12 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
13 [INFO] Compiling module org.glom.web.OnlineGlom
14 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
15 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
16 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
17 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
18 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
19 [INFO] [ERROR] Cannot proceed due to previous errors
21 It has taken me 2 days to find out what was causing that. After reducing
22 the code, the compiler eventually showed me the full error message.
24 2012-05-04 Murray Cumming <murrayc@murrayc.com>
26 ConfiguredDocument: Cache the cloned and stripped layouts.
28 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
29 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
30 layout in a map, so we can retrieve it again without rebuilding it.
32 2012-05-04 Murray Cumming <murrayc@murrayc.com>
34 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
36 2012-05-04 Murray Cumming <murrayc@murrayc.com>
38 libglom classes: Implement some auto-generated emthods.
40 2012-05-04 Murray Cumming <murrayc@murrayc.com>
42 Add GwtTestOnlineGlomService.
44 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
45 However, this (and the other GwtTest*) does not seem to run during
48 2012-05-04 Murray Cumming <murrayc@murrayc.com>
50 Remove use of unsupported features from client code.
52 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
53 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
54 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
55 Use our client version of StringUtils instead of the apache commons one.
57 However, the GWT Javascript compliation still fails.
59 2012-04-25 Murray Cumming <murrayc@murrayc.com>
61 Add a Field class and implement some loading of it in Document.
63 2012-04-25 Murray Cumming <murrayc@murrayc.com>
65 Initial Document loading implementation, instead of libglom.
67 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
68 and Translatable classes, and adapt the rest of the code to use them.
69 However, this is still missing Layout and Field classes and loading.
71 2012-04-24 Murray Cumming <murrayc@murrayc.com>
73 Use of jOOQ: Move Field creation into a utility method.
75 * src/main/java/org/glom/web/server/SqlUtils.java:
76 This lets us improve it more easily.
78 2012-04-24 Murray Cumming <murrayc@murrayc.com>
80 Use of jOOQ: Improve the code to COUNT a sub-select.
82 * src/main/java/org/glom/web/server/SqlUtils.java:
83 Move initial query creation into
84 build_sql_select_step_with_where_clause().
85 build_sql_select_count_rows(): Use the jOOQ API instead of
86 concatentating text, because a jOOQ Select*Step is a TableLike,
87 which is what from() takes.
89 2012-04-23 Murray Cumming <murrayc@murrayc.com>
91 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
93 * pom.xml: Depend on jooq.
94 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
95 methods with jOOQ, based on the C++ implementations in libglom,
96 with some changes to the logic required by jooQ.
97 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
99 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
100 * src/main/java/org/glom/web/server/ReportGenerator.java:
101 * src/main/java/org/glom/web/server/SqlUtils.java:
102 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
103 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
104 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
105 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
106 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
107 Adapt. In particular, the SqlUtils methods now need to take a Connection,
108 because jOOQ needs that, though it seems unnecessary.
110 This is not quite finished. Ideally jOOQ would help us to build
111 table_name.field_name names, quoting and escaping them properly.
112 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
114 2012-04-21 Murray Cumming <murrayc@murrayc.com>
116 Move use of Glom.build_sql*() into a new SqlUtils class.
118 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
119 to wrap Glom.build_sql*(). The parameter types are still Glom one,
120 but this will make it easier to start using something other than
121 libglom or SqlBuilder.
123 2012-04-21 Murray Cumming <murrayc@murrayc.com>
125 Update the project URL.
127 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
129 2012-04-21 Murray Cumming <murrayc@murrayc.com>
131 Main layout: Use a FlowTable instead of absolute positioning.
133 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
134 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
135 child panels/widgets must have an absolute position. But that is annoying, so
136 this adds a FlowTable and puts the child panels in there.
138 2012-04-21 Murray Cumming <murrayc@murrayc.com>
140 GwtTestOnlineGlom: Comment out unused code.
142 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
143 Eclipse has started to say that some code is unused.
145 2012-04-21 Murray Cumming <murrayc@murrayc.com>
147 Update to the latest versions of dependencies.
149 * pom.xml: Update version numbers of dependencies to the latest
151 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
153 * src/main/java/org/glom/web/server/ReportGenerator.java:
154 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
155 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
156 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
158 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
159 Modify the imports where necessary.
161 2012-04-17 Murray Cumming <murrayc@murrayc.com>
163 Style: Remove overflow:hidden from searchbox
165 * src/main/webapp/style.css: Because this pushes the Back To Link
166 label/link on to the next row, which is then hidden due to the
167 hard-coded (in ems) height.
169 2012-04-20 Murray Cumming <murrayc@murrayc.com>
171 Remove some duplicate code.
173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
174 getDocumentInfo(): This must have been duplicated during the merge from the
179 2012-04-19 Murray Cumming <murrayc@murrayc.com>
181 Reports: Localize the waiting for report message.
183 * src/main/java/org/glom/web/client/activity/ReportActivity.java
184 start(): Get the message from the contants.
185 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
187 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
188 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
189 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
190 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
191 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
192 Update these files with the English text for newer strings for now.
194 2012-04-19 Murray Cumming <murrayc@murrayc.com>
196 Reports: Show a message while waiting for the report.
198 * src/main/java/org/glom/web/client/ui/ReportView.java
199 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
200 Add setWaitingText(), to show a message saying that we are
201 waiting for the report to be ready.
202 * src/main/java/org/glom/web/client/activity/ReportActivity.java
203 start(): Call setWaitingText() before calling the async
206 2012-04-19 Murray Cumming <murrayc@murrayc.com>
208 ReportGenerator: Specify date and time formats.
210 * src/main/java/org/glom/web/server/ReportGenerator.java:
211 createFieldValueElement(): Use the default (and localized)
212 short formats, though we still need a way to show 4-digit
213 years without providing the format for every locale.
214 * src/main/java/org/glom/web/server/database/DBAccess.java:
215 convertResultSetToDTO(): Use the short formats here too.
217 2012-04-18 Murray Cumming <murrayc@murrayc.com>
219 ReportGenerator: Use the correct numeric formatting.
221 * src/main/java/org/glom/web/server/ReportGenerator.java
222 createFieldExpression(), createFieldValueElement(): Take the
223 whole LayoutItem_Field instead of just the field name, so
224 we have access to the formatting.
225 createFieldValueElement(): Use JRTextField.setPattern() to
226 specify the numeric formatting, with the help of a
227 regular DecimalFormat.
229 2012-04-18 Murray Cumming <murrayc@murrayc.com>
231 ReportGenerator: Avoid showing null for group by titles.
233 * src/main/java/org/glom/web/server/ReportGenerator.java
234 generateReport(): Use setBlankWhenNull() on the field title
235 style too, because this is used for values in group by
238 2012-04-18 Murray Cumming <murrayc@murrayc.com>
240 ReportGenerator: Add a colon to titles in vertical groups.
242 * src/main/java/org/glom/web/server/ReportGenerator.java
243 addFieldToDetailBandVertical(): Pass true for the withColon
246 2012-04-18 Murray Cumming <murrayc@murrayc.com>
248 ReportGenerator: Simplify the code by using Position more.
250 2012-04-18 Murray Cumming <murrayc@murrayc.com>
252 Reports: Support vertical groups, roughly.
254 * src/main/java/org/glom/web/server/ReportGenerator.java:
255 addToReport(): Rename to addGroupToReport() and, if necessary,
256 call the new addVerticalGroupToReport() method.
257 createFieldValueElement(): Let the caller specify the Y position
260 2012-04-17 Murray Cumming <murrayc@murrayc.com>
262 Reports: Allow a second report to be shown.
264 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
265 clear(): Do not remove the HTML widget, which broke the whole layout.
267 2012-04-17 Murray Cumming <murrayc@murrayc.com>
269 Locales drop-down: Show that we use English by default.
271 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
272 fillView(): When we use English, just because that is the default, when
273 no locale is specified, show that in the Locales drop-down instead of
274 just showing the first item.
276 2012-04-17 Murray Cumming <murrayc@murrayc.com>
278 Unselect the Report/Locale/Table combo item when appropriate.
280 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
281 setPlace(): clear reportName if this is not a ReportPlace.
282 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
283 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
284 When the provided name is empty, unselect all items, so that none are
285 indicated. This uses a for loop because I cannot find a single method
288 2012-04-17 Murray Cumming <murrayc@murrayc.com>
290 Report: Give the user a way to get back to the list.
292 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
293 start(), setPlace(): Show the Back To List link on reports, and also
294 interpret selecting the empty report item as back to list.
296 2012-04-13 Murray Cumming <murrayc@murrayc.com>
298 Really show the selected Report name.
300 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
301 setPlace(): Store the reportName here, if it is that kind of Place.
302 fillView(): Set the selected Report after filling the list of reports.
303 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
304 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
305 null Strings, though we need some way to unselect all ListBox items
308 2012-04-13 Murray Cumming <murrayc@murrayc.com>
310 ReportGenerator: Try to avoid some problems.
312 * src/main/java/org/glom/web/server/ReportGenerator.java
313 addField(): Try to avoid duplicates, and avoid using a null
316 2012-04-13 Murray Cumming <murrayc@murrayc.com>
318 Reports: Use quickFind.
320 * src/main/java/org/glom/web/client/OnlineGlomService.java;
321 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
322 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
323 getReportHTML(): Add a quickFind parameter.
324 * src/main/java/org/glom/web/client/activity/ReportActivity.java
325 start(): Pass the quickFind parameter.
326 * src/main/java/org/glom/web/server/ReportGenerator.java
327 generateReport(): Take a quickFind parameter.
329 2012-04-13 Murray Cumming <murrayc@murrayc.com>
331 ReportPlace: Actually use the report name.
333 * src/main/java/org/glom/web/client/place/ReportPlace.java
334 getPlace(): Do not assign the report name to the quickfind.
336 2012-04-13 Murray Cumming <murrayc@murrayc.com>
338 Show java.library.path when complaining.
340 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
341 init(): When telling us to check java.library.path, show the
344 2012-03-06 Murray Cumming <murrayc@murrayc.com>
346 ReportGenerator: Do not show nulls.
348 2012-03-06 Murray Cumming <murrayc@murrayc.com>
350 ReportGenerator: Make the title font larger.
352 2012-03-06 Murray Cumming <murrayc@murrayc.com>
354 ReportGenerator: Put field titles inside groups, if there are groups.
356 2012-03-06 Murray Cumming <murrayc@murrayc.com>
358 ReportGenerator: Take the Report itself instead of the name and group.
360 * src/main/java/org/glom/web/server/ConfiguredDocument.java
361 Remove getReportLayoutGroup().
362 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
363 getReportHTML(): Pass the report instead
364 of its name and layout group.
365 * src/main/java/org/glom/web/server/ReportGenerator.java
366 generateReport(): Use the report object to use the title
369 2012-03-06 Murray Cumming <murrayc@murrayc.com>
371 ReportGenerator: Remove designBand parameters.
373 * src/main/java/org/glom/web/server/ReportGenerator.java:
374 Make designBand a class member instead of passing it to all
377 2012-03-06 Murray Cumming <murrayc@murrayc.com>
379 ReportGenerator: Add lines, a bit like in the desktop version.
381 * src/main/java/org/glom/web/server/ReportGenerator.java
382 addToReport(): Use JRDesignLine.
384 2012-03-06 Murray Cumming <murrayc@murrayc.com>
386 ReportGenerator: Correct the title positions and use some bold style.
388 * src/main/java/org/glom/web/server/ReportGenerator.java:
389 Break the code up into reusable functions, correct the placement of
390 titles, and use normal/bold styles as in the reports in the desktop
393 2012-03-06 Murray Cumming <murrayc@murrayc.com>
395 ReportGenerator: Add a header band to show the field titles.
397 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
398 getReportHTML(): Pass the localeId to the ReportGenerator
400 * src/main/java/org/glom/web/server/ReportGenerator.java
401 constructor: Take the localeID so we can get translated field
403 generateReport(), addToReport(), addFieldToBand(): Add field
404 titles in a column header band.
406 2012-03-05 Murray Cumming <murrayc@murrayc.com>
408 Reports drop-down list: Some improvement.
410 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
411 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
412 Adedd setSelectedReport(),
413 setReportList(): Add a blank line so that the user can select the
415 * src/main/java/org/glom/web/client/activity/ReportActivity.java
416 start(): Show the current report by calling setSelectedReport().
417 This does not seem to work yet.
419 2012-03-05 Murray Cumming <murrayc@murrayc.com>
421 DetailsActivity, ListActivity: Move some variables into a base class.
423 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
424 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
425 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
426 the clientFactory, documentID, tableName and authenticationPopup into
427 a base class, to avoid duplication.
429 2012-03-05 Murray Cumming <murrayc@murrayc.com>
431 Translate the Reports label.
433 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
434 Get the "Reports" label string from the constants.
435 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
436 perties: Add Reports to the constants.
438 2012-03-05 Murray Cumming <murrayc@murrayc.com>
440 Reports: Implement grouping.
442 * src/main/java/org/glom/web/server/ReportGenerator.java:
443 Handle LayoutItem_GroupBy items and try to do the right thing
444 with JRDesignGroup. It seems to work.
446 2012-03-04 Murray Cumming <murrayc@murrayc.com>
448 Actually show some data with JasperReports.
450 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
451 getReportHTML(): Move most code into a ReportGenerator class.
452 * src/main/java/org/glom/web/server/ReportGenerator.java:
453 Recurse into sub-groups, adding fields to the JasperDesign's details
454 band. Note that we must set an arbitrary width and height, or it just
455 will not show any data.
457 2012-03-04 Murray Cumming <murrayc@murrayc.com>
459 Reports Chooser: Show the titles, not the names.
461 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
462 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
463 and the names as the values.
464 * src/main/java/org/glom/web/server/ConfiguredDocument.java
465 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
466 group now that we provide the report name, so it should always
469 2012-02-15 Murray Cumming <murrayc@murrayc.com>
471 Depend on jasperreports.
473 * pom.xml: Add the dependency. My plan is to use this on the
476 2012-01-31 Murray Cumming <murrayc@murrayc.com>
478 Implement navigation to report places.
480 * src/main/java/org/glom/web/client/activity/ReportActivity.java
481 start(): Do not bother to handle all events here.
482 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
483 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
484 Added getSelectedReport().
485 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
486 .java: start(): When handling a change to the reports chooser,
487 call getSelectedReport() and goTo() its ReportPlace.
488 * src/main/java/org/glom/web/client/ui/ReportView.java
489 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
490 Added setReportHTML() which puts the html in a gwt HTML widget.
491 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
492 getReportHTML(): Return "TODO" just to show that this works.
494 2012-01-31 Murray Cumming <murrayc@murrayc.com>
496 Make ReportPlace usable.
498 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
500 * src/main/java/org/glom/web/client/place/ReportPlace.java:
501 Correct the @prefix annotation.
503 2012-01-31 Murray Cumming <murrayc@murrayc.com>
505 OnlineGlomService: Return report HTML rather than the LayoutGroup.
507 * src/main/java/org/glom/web/client/OnlineGlomService.java:
508 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
509 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
510 Change getReportLayout() to getReportHMTL() because we will not need to
511 parse or render the report layout on the client side.
512 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
513 getReportLayout(): Return the libglom LayoutGroup type because we will
514 not need to convert to a shared type, because this will not be used on
516 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
519 Note that there is still no implementation for this.
522 2012-01-27 Murray Cumming <murrayc@murrayc.com>
524 Add a (empty) Report Place, View, and Activity.
526 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
528 * src/main/java/org/glom/web/client/place/HasTablePlace.java
529 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
530 this into a superclass:
531 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
532 and also use it as the base of this new ReportPlace:
533 * src/main/java/org/glom/web/client/place/ReportPlace.java
535 * src/main/java/org/glom/web/client/ui/ReportView.java
536 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
537 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
538 Add these, containing mostly boiler-plate for now.
540 * src/main/java/org/glom/web/client/OnlineGlomService.java
541 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
542 * src/main/java/org/glom/web/server/ConfiguredDocument.java
543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
544 Add API to get the LayoutGroup for the report.
546 2012-01-23 Murray Cumming <murrayc@murrayc.com>
548 Add and fill a Reports drop-down list box.
550 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
552 * src/main/java/org/glom/web/client/OnlineGlomService.java:
553 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
555 Added getReports(document, table, localeID), calling
556 ConfiguredDocument.getReports().
557 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
558 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
559 Added setReportsList() and a list widget.
560 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
561 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
566 2012-04-12 Murray Cumming <murrayc@murrayc.com>
568 Translations: Add Esperanto.
570 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
571 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
572 properties: Add this translation because someone took the time to make it.
574 2012-03-15 Murray Cumming <murrayc@murrayc.com>
576 Adapt to the java-libglom 1.21.7 API.
578 * src/main/java/org/glom/web/server/ReportGenerator.java:
579 addToReport(): get_group_secondary_fields() is now
580 get_secondary_fields().
583 2012-03-15 Murray Cumming <murrayc@murrayc.com>
585 Use the latest java-libglom version.
587 * pom.xml: Use java-libglom 1.21.7.
589 2012-03-03 Ben Konrath <ben@bagu.org>
591 Display date and time in details view.
593 https://bugzilla.gnome.org/show_bug.cgi?id=671257
595 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
597 2012-03-05 Murray Cumming <murrayc@murrayc.com>
599 Require the latest java-libglom.
601 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
603 2012-03-04 Murray Cumming <murrayc@murrayc.com>
605 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
607 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
608 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
609 an empty quickfind string. I also corrected libglom to create only
610 empty where clauses for empty quickfind strings, but this avoids the
613 2012-02-24 Ben Konrath <ben@bagu.org>
615 Improve the tabs in the Notebook widget.
619 2012-01-30 Murray Cumming <murrayc@murrayc.com>
621 Translations: Try to translate the strings.
623 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
624 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
625 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
626 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
627 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
628 Take the Open translation from GTK+'s .po files.
629 Take the Details translation from Glom's po files.
630 I have added the other strings to Glom so we can get translations that way:
631 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
633 2012-01-27 Murray Cumming <murrayc@murrayc.com>
635 TableSelectionViewImpl: Put the search label and entry in a div.
637 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
638 Put the search widgets in a FlowTable so that the CSS can be used to
639 style them while keeping them together.
640 * src/main/webapp/style.css: Mention the new div.
642 2012-01-27 Murray Cumming <murrayc@murrayc.com>
644 Translate more strings in more locales.
646 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
647 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
648 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
649 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
650 Translate the "Details" and "Open" string too.
652 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
653 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
654 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
655 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
656 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
657 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
658 Add these new locales as placeholders though they currently contain English.
660 2012-01-27 Murray Cumming <murrayc@murrayc.com>
662 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
664 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
665 Check the ConfiguredDocument* for null before using it.
667 2012-01-26 Murray Cumming <murrayc@murrayc.com>
669 Tell Eclipse about the generated java files.
671 * .classpath: This lets it find OnlineGlomConstants.java.
672 It would be nice if Eclipse just used the maven build files.
674 2012-01-26 Murray Cumming <murrayc@murrayc.com>
676 Prevent a crash when no locale is specified in the URL.
678 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
679 Avoid returning a null string, obtained from
680 Window.Location.getParameter(). This caused a crash when it was
681 later passed to libglom's API.
682 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
683 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
684 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
685 guard against future null strings.
687 2012-01-26 Murray Cumming <murrayc@murrayc.com>
689 Use the ?locale= query param instead of the &lang= token param.
691 * src/main/java/org/glom/web/client/place/ListPlace.java
692 * src/main/java/org/glom/web/client/place/DetailsPlace.java
693 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
694 Remove the lang token key and value.
696 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
697 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
698 When the user selects a different locale from the chooser, use
699 Window.Location.assign() to change the URL, which then causes a reload.
701 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
702 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
703 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
704 * src/main/java/org/glom/web/client/activity/ListActivity.java
705 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
706 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
707 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
708 * src/main/java/org/glom/web/client/ui/ListView.java:
709 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
711 Remove localeID member variables and method/constructor parameters, instead
712 using Utils.getCurrentLocaleID() when we need a localID to pass to
715 2012-01-26 Murray Cumming <murrayc@murrayc.com>
717 Internationalize the UI strings.
719 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
720 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
721 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
722 because it is unused. Messages are apparently strings that can have
723 parameters, but we do not need that yet, so Contants will be enough for now.
724 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
725 to say that we support the en and de locales.
726 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
727 The original English strings.
728 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
729 Some German translations of the English strings.
730 The i18n goal then uses the .properties file to generate an
731 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
732 returns an implementation that returns the translated strings.
733 The documentation suggests putting these in src/java/*/client/, but it seems
734 best to put it in src/resources/*/client/.
735 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
736 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
737 instead of hard-coding them.
738 Note that we cannot import OnlineGlomConstants because it does not exist yet,
739 but that does not seem to stop the build, though it confuses Eclipse.
741 You can see the translated string by adding ?locale=de to the URL, like so:
742 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
744 2012-01-24 Murray Cumming <murrayc@murrayc.com>
746 Improve null/empty String checks.
748 * pom.xml: Add a dependency on commons-lang, to use
749 org.apache.commons.lang.StringUtils.
750 * src/main/java/org/glom/web/server/ConfiguredDocument.java
751 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
752 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
753 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
754 Use StringUtils.isEmpty().
756 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
757 StringUtils class with a static isEmpty() function because we
758 cannot use org.apache.commons.lang.StringUtils in client-side
759 GWT code because it (apparently) cannot be compiled to javascript.
760 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
761 * src/main/java/org/glom/web/client/activity/ListActivity.java
762 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
763 * src/main/java/org/glom/web/client/place/DetailsPlace.java
764 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
765 * src/main/java/org/glom/web/client/place/ListPlace.java
766 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
767 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
768 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
769 * src/main/java/org/glom/web/client/ui/details/Group.java
770 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
771 our StringUtils.isEmpty() function.
773 2012-01-24 Murray Cumming <murrayc@murrayc.com>
775 Update to the latest java-libglom API.
777 * pom.xml: Require java-libglom 1.21.4.
778 * src/main/java/org/glom/web/server/ConfiguredDocument.java
779 getDocumentInfo(), getListViewLayoutGroup():
780 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
782 * src/main/java/org/glom/web/server/database/DBAccess.java
783 getFieldsToShowForSQLQueryAddGroup(),
784 getPrimaryKeyLayoutItemField(): Replace get_database_title()
785 with either get_database_title_original() or
786 get_database_title(localeID).
788 2012-01-24 Murray Cumming <murrayc@murrayc.com>
790 ConfiguredDocument: Avoid a null pointer exception.
792 * src/main/java/org/glom/web/server/ConfiguredDocument.java
793 Initialize localeID to "" to avoid returning a null String which
794 causes a crash in java-libglom's swing-generated code.
796 2012-01-23 Murray Cumming <murrayc@murrayc.com>
798 Some simple renaming.
800 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
801 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
802 for localeChooser. This seems more appropriate and is less ambiguous
803 particularly in the .css file.
805 2012-01-23 Murray Cumming <murrayc@murrayc.com>
807 ConfiguredDocument: Rename the localedID private member variable.
809 2012-01-23 Murray Cumming <murrayc@murrayc.com>
811 Adapt to the latest java-libglom API from git master.
813 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
814 libglom now uses only Vector instead of List, which uses add() instead of
817 2012-01-22 Murray Cumming <murrayc@murrayc.com>
819 ConfiguredDocument: Rename the localedID private member variable.
821 2012-01-20 Murray Cumming <murrayc@murrayc.com>
823 Build a source tarball with mvn assembly:single
825 * assembly.xml: Add this file.
826 * pom.xml: Use the maven-assembly-plugin and tell it to use
827 our assembly.xml file.
829 2012-01-19 Murray Cumming <murrayc@murrayc.com>
831 OnlineGlomServiceImpl: Get .glom files recursively.
833 * pom.xml: Depend on commons-io from org.apache.commons.
834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
835 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
836 files recursively, and with the easier filter for the extension.
837 Use org.apache.commons.io.FilenameUtils.removeExtension() to
838 simplify that code too.
840 2012-01-19 Murray Cumming <murrayc@murrayc.com>
842 README: Mention that you must install java-libglom packages separately.
844 But then it works, because java-libglom is now in the central maven
847 2012-01-18 Murray Cumming <murrayc@murrayc.com>
849 locales drop-down: Show the correct selected locale when the URL changes.
851 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
852 .java: setPlace(): Move some code into fillView().
854 2012-01-18 Murray Cumming <murrayc@murrayc.com>
856 locales drop-down: Do not lose the primary key.
858 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
859 start(): onLocaleChange(): Pass the current primary key value,
860 instead of an empty value.
862 2012-01-18 Murray Cumming <murrayc@murrayc.com>
864 locales drop-down: Do not lose the drop-down selection.
866 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
867 .java (TableSelectionActivity.fillView): Set the selected locale
868 after changing the drop-down items (though we do not really need
869 to change them just because the locale changes.)
871 2012-01-18 Murray Cumming <murrayc@murrayc.com>
873 locales drop-down: Change the tables list when this changes.
875 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
876 .java: TableSelectionActivity.start(): Move the async table titles
877 retrieval into a private fillView() method and also call this when
878 the chosen locale changes.
879 Note that the document title is not actually translatable yet, but
880 that is a problem that I should fix soon in libglom.
882 2012-01-18 Murray Cumming <murrayc@murrayc.com>
884 Improve the placement of the locales drop-down.
886 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
887 Put the title and locales drop-down in a div (gwt.FlowTable).
888 * src/main/webapp/style.css: Add magic css properties to make this work.
889 Also remove the left margin from the title so that it lines up with the
892 2012-01-18 Murray Cumming <murrayc@murrayc.com>
894 locales selector: Show human-readable locale titles.
896 * src/main/java/org/glom/web/server/ConfiguredDocument.java
897 getDocumentInfo(): Use java.util.Locale to show a real title of
898 each locale, in the locale's own language.
900 2012-01-17 Murray Cumming <murrayc@murrayc.com>
902 Add a language/locale selector drop-down.
904 * src/main/java/org/glom/web/shared/DocumentInfo.java:
905 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
906 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
907 getDocumentInfo(): Store the available Locales in the DocumentInfo.
908 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
909 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
910 Add a ListBox to show the available locales. Add getLocaleSelector(),
911 setLocaleList(), getSelectedLocale(), setSelectedLocale().
912 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
913 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
914 java: Add these classes.
915 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
916 start(): Fill the locales ListBox. Handle its change event, firing a
918 setPlace(): Show the selected locale as specified by the URL token.
919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
920 * src/main/java/org/glom/web/client/activity/ListActivity.java:
921 Handle LocaleChangeEvent, going to a new *Place with that locale.
923 The placement of the ListBox is not pretty, and it currently uses the ID
924 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
928 2012-01-17 Murray Cumming <murrayc@murrayc.com>
930 Search box: Show the search text from the URL token.
932 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
933 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
934 Add setQuickFindText().
935 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
936 .java: setPlace(): Store the queryText if the place is a ListPlace,
937 and call TableSelectionView.setQuickFindText().
939 2012-01-17 Murray Cumming <murrayc@murrayc.com>
941 Allow use of translations via, for instance, &lang=de in the URL.
943 * pom.xml: Use the unstable java-libglom 1.21 version.
945 * src/main/java/org/glom/web/client/OnlineGlomService.java:
946 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
947 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
948 init(): Instead of calling TranslatableItem.set_current_locale()
949 (now removed), call ConfiguredDocument.setDefaultLocaleID().
950 However, this is only for default locales, which are not needed to
951 change the locale in the URL.
952 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
953 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
954 getSortedRelatedListData(): Add a localeID parameter, so we can get the
955 layout for a particular locale.
956 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
957 Add get/setDefaultLocaleID().
958 getDocumentInfo(), getListViewData(), getRelatedListData(),
959 getDetailsLayoutGroup(), getListViewLayoutGroup(),
960 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
961 localeID parameter, so we can get the layout for a particular locale.
963 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
964 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
965 * src/main/java/org/glom/web/client/place/ListPlace.java:
966 Parse and construct a lang parameter too.
968 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
969 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
970 passed to subsequent methods and constructors.
971 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
972 * src/main/java/org/glom/web/client/activity/ListActivity.java:
973 Store the localeID from the *Place and pass it to other constructors
974 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
976 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
977 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
978 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
979 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
980 * src/main/java/org/glom/web/client/ui/ListView.java:
981 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
982 Take localeID parameters and pass them to subsequent constructors and
983 methods, so that the layout is always retrieved for that locale.
985 This is rather repetitive.
987 Note that "" means the original (default) locale of the Glom document,
988 which is usually English.
990 2012-01-17 Murray Cumming <murrayc@murrayc.com>
992 Documents: Remove final keyword to fix startup configuration.
994 * src/main/java/org/glom/web/shared/Documents.java: Remove the
995 final keywords on the private member variables because that breaks
996 the startup, apparently (there are warnings) because it stops them
997 from being serialized. I added these in the previous commit.
999 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1001 Documents: Add some final keywords.
1003 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1006 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1008 OnlineGlomServiceImpl: Add to overview comments.
1010 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1011 Note that this is where all the document are loaded. They are not
1012 loaded freshly for each page.
1014 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1018 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1019 Add a TextBox for the text of a quick find.
1020 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1022 setBackLink(): Add a String quickFind parameter.
1023 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1024 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1025 to the base interface, because that is how TableSelectionViewImpl is used.
1026 * src/main/webapp/style.css: Add style for the search box and its label.
1028 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1029 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1030 Add these files, based on the existing TableChangeEvent and
1031 TableChangeEventHandlers.
1032 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1033 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1034 a ListPlace() that the user should be taken to.
1035 * src/main/java/org/glom/web/client/activity/ListActivity.java
1036 start(): Handle it here too and adapt the TableChangeEvent handler to
1037 pass the extra "" quickFind parameter to ListPlace.
1038 * src/main/java/org/glom/web/client/place/ListPlace.java:
1039 Constructor: Take an extra String quickFind parameter and store it,
1040 returning it from a new getQuickFind() method.
1041 getToken(): Put the quickFind text in the URL token.
1042 getPlace(): Parse the quickFind text from the URL token.
1043 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1044 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1045 ListPlace constructor.
1046 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1047 .java: start(): Add a Change handler for the TableSelectionView's
1048 TextBox (via its base HasChangeHandlers interface), firing the new
1049 QuickFindChangeEvent.
1050 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1051 pass the extra "" quickFind parameter.
1053 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1054 setCellTable(): Add a String quickFind parameter and pass it to
1055 the ListViewTable() constructor.
1056 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1057 setCellTable() in the base interface, because that is how ListViewImpl
1060 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1061 Add a String quickFind member variable.
1062 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1063 Constructor: Add a String quickFind parameter, storing it in the
1064 base ListTable's member variable.
1065 onRangeChanged(): Pass quickFind to the
1066 OnlineGlomServiceAsync.getSortedListViewData() and
1067 OnlineGlomServiceAsync.getListViewData() methods.
1069 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1070 getListViewData(), getSortedListViewData(): Add a String quickFind
1071 parameter, passing it to ConfiguredDocument.getListViewData().
1072 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1073 Change getListViewData(), getSortedListViewData() in the base interface,
1074 because that is how OnlineGlomServiceImpl is used, via this:
1075 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1076 Change getListViewData(), getSortedListViewData() here too.
1077 This class can apparently be used to asynchronously call methods on
1078 OnlineGlomService, and GWT seems to implement that after recognizing
1079 just the *Async name convention and the extra AsyncCallback parameters.
1081 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1082 getListViewData(): Add a String quickFind parameter, and pass it to
1083 ListViewDBAccess.getData().
1084 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1085 getListData(): Add a String quickFind parameter and pass it to
1087 getSelectQuery(): Add a String quickFind parameter.
1088 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1089 getSelectQuery(): Add a String quickFind parameter and use it with
1090 Glom.get_find_where_clause_quick() to pass a where_clause to
1091 Glom.build_sql_select_with_where_clause(), to actually filter the
1093 getData(): Add a String quickFind parameter, passing it to getListData().
1094 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1095 va: getData(): Pass an empty string to getListData() for the
1096 quickFind parameter.
1098 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1100 ListTable: Minor change.
1102 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1103 createCellTable(): Make this protected instead of public.
1105 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1107 Many files: Use final for the parameters and use the @override attribute.
1109 2012-01-22 Ben Konrath <ben@bagu.org>
1111 Add anchor links for single line text that starts with http, ftp and www.
1115 2012-01-22 Ben Konrath <ben@bagu.org>
1117 Add ellipsis to single line text in details view.
1121 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1123 Remove all javadoc author tags.
1125 Because they are awkward and meaningless when many people touch
1127 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1129 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1131 Revert the COPYING.LESSER to COPYING rename.
1133 Apparently both should be there if it is LGPL.
1135 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1137 *View: Remove unused imports.
1139 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1140 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1141 * src/main/java/org/glom/web/client/ui/ListView.java:
1142 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1143 Remove unused imports, as suggested by Eclipse.
1145 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1147 Move the *View::Presenter types, and some API into one base View.
1149 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1150 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1151 * src/main/java/org/glom/web/client/ui/ListView.java:
1152 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1153 Presenter, setPresenter() and clear() into a shared base interface,
1154 to avoid the unnecessary duplicate Presenter types and to more clearly
1155 show how the *Views share the same structure, even if they are not
1156 used polymorphically.
1158 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1159 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1162 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1163 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1165 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1168 Feel free to revert this if there is a good reason for the duplicate
1171 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1173 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1175 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1176 a class member instead of a local variable in the method.
1177 This lets us use it to get the view instances, for use in tests.
1178 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1179 beforeOnlineGlom(): Test some more details of the initial view.
1180 Again, this is not very useful.
1182 To really test gwt-glom we will need to start a local postgresql
1183 instance with local data, like the Glom tests in C++.
1185 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1187 pom.xml: Mention the LGPL license.
1189 * pom.xml: Add a licenses section.
1190 * COPYING.LESSER: Move this to COPYING, which
1191 previously contained the GPL. But gwt-glom is all LGPL.
1193 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1195 Add project information to README and pom.xml.
1197 * README: Add a brief description and mention some mvn
1199 * pom.xml: This extra information shows up in mvn site
1202 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1204 Use the latest java-libglom version.
1206 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1208 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1210 GwtTestOnlineGlom: Test a little more.
1212 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1213 protected rather than private, as suggested by the gwt-test-utils
1215 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1216 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1217 Test the initial visibility of the panels.
1219 However, this is not a very useful test.
1220 And I wonder how we should generally test using this idea for an
1221 activity/places app like ours where the real changes happen implicitly
1222 based on the history token/URL.
1224 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1226 Slight modification to *Mapper comments.
1228 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1229 (DataActivityMapper)
1230 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1232 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1234 Remove comments mentioning GIN because they are just copied from
1235 the example code and are apparently not helpful:
1236 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1237 Also change the mention of a class that is only in the example code.
1239 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1241 GwtTestOnlineGlom test: Minor changes.
1243 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1244 Avoid the long qualified class name and modify the comment
1245 because it is now obvious to me that the mocked class is the only
1246 custom one created via GWT.create().
1248 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1250 Tests: Added the beginnings of a test using gwt-test-utils.
1252 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1253 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1254 which tells gwt-test-utils what class will be tested.
1255 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1256 Add a simple (but empty) test case. One class, used by the OnlineGlom
1257 class, is mocked so that it can be created. However, I am not sure
1258 why only this class needs to be mocked.
1260 Note that mockito seems more popular, and clearer, than easymock,
1261 but I have not got that working yet. It might be a matter of the
1264 This test is run during mvn integration-test.
1266 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1268 Tests: Use junit4-style syntax instead of junit3-style.
1270 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1271 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1272 * src/test/java/org/glom/web/shared/DataItemTest.java:
1273 Use the @Test annotation rather than relying on the test*() prefix.
1274 Also no longer implement TestCase, to avoid triggering support for
1275 the junit3-way, which stops the annotations from working.
1276 Change the imports from import junit.framework.* to
1277 import org.junit.*, which is apparently the new way.
1279 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1281 Added a test for ListPlace token parsing and creation.
1283 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1284 This is much the same as DetailsPlaceTest.
1286 I wonder how we could test the other parts of the *Place API.
1288 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1290 DetailsPlace test: Also test getToken() and recreation via getPlace().
1292 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1293 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1294 recreate it, testing the recreated DetailsPlace for the same parameter
1297 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1299 Use the surefire-report plugin.
1301 * pom.xml: This generates a HTML report about the tests in
1302 target/site/surefire-report.html
1303 when you do mvn surefire-report:report. It seems to be popular/normal.
1305 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1307 Added a test for DetailsPlace.
1309 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1310 Test the getPlace() token parsing.
1312 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1314 Added a first unit test.
1316 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1317 * src/test/java/org/glom/web/shared/DataItemTest.java:
1318 This is a silly test but it is just to get things started. Note that
1319 maven/junit finds the test because it looks in src/test by default.
1321 2011-12-22 Ben Konrath <ben@bagu.org>
1323 Change charsetName to "UTF-8" when replacing line breaks.
1325 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1326 that work in Java (such as "UTF8") will not work when compiled to
1329 This fixes a problem with multi-line details view fields that have hard
1330 line breaks. The "License Text" field on this page demonstrates the
1333 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1335 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1337 2011-12-22 Ben Konrath <ben@bagu.org>
1339 Fix another bug with related list navigation.
1341 I've tested all the navigation buttons in all of the related lists
1342 so things should be good now.
1344 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1346 2011-12-22 Ben Konrath <ben@bagu.org>
1348 Fix a crasher when refreshing the list view with the default table.
1350 This crash will also happen when loading the list view with the default
1351 table from a link or bookmark.
1353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1354 to the main document selection page when the document id hasn't been
1356 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1357 the main document selection page when the document id hasn't been
1359 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1360 values for the details place when the document id hasn't been set.
1361 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1362 values for the list place when the document id hasn't been set.
1364 2011-12-21 Ben Konrath <ben@bagu.org>
1366 Protect against NPE when glom.document.locale is not in config.
1368 This patch protects against an NPE when glom.document.locale is not in
1369 the config file. This NPE will also happen if glom.document.locale is
1372 The patch also updates the error message to display the class name when
1373 the getMessage() returns null. This was happening when the NPE was
1374 thrown and I had "Configuration Error: null". If an NPE is encountered
1375 with this patch, "Configuration Error: NullPointerException " will be
1378 This commit closes this bug:
1380 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1382 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1384 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1386 Rename onlineglom.properties to onlineglom.properties.sample.
1388 * src/main/resources/onlineglom.properties: Rename to:
1389 * src/main/resources/onlineglom.properties.sample:
1390 * src/main/resources/README: And add this file explaining that people
1391 should rename it back when deploying.
1393 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1395 Allow choosing the translation in the .properties file.
1397 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1398 init(): Read a glom.document.locale value from the configuration file
1399 and call Glom's TransatableItem::set_current_locale() method.
1400 * src/main/resources/onlineglom.properties: Add a commented-out
1401 example of this new setting.
1403 It would be better to add &lang=de_DE to the URL, but the current
1404 libglom API does not allow us to do this easily. I am working on that.
1406 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1408 Avoid a crash in parsing of token parameters.
1410 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1411 ava: getTokenParams(): Do not crash if a parameter has a key but no
1412 value, and ignore parameters with neither.
1414 2011-12-17 Murray Cumming <murrayc@murayc.com>
1416 History token building/handling: Improve use of token parameters.
1418 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1419 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1420 and buildParamsToken(HashMap), for use by derived classes.
1421 Make the separator private because it is no longer be needed.
1422 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1423 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1424 instead of manual string concatenation.
1425 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1426 of hardcoded indices and awkward splitting code.
1427 * src/main/java/org/glom/web/client/place/ListPlace.java
1428 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1429 instead of manual string concatenation.
1430 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1431 of hardcoded indices and awkward splitting code.
1432 This should fix bug #666420
1434 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1436 Fix a Navgiation->Navigation typo in the code.
1438 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1439 Rename processNavgiation() to processNavigation().
1441 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1443 Fix a seperator->separator typo in the code.
1445 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1446 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1447 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1450 2011-12-15 Ben Konrath <ben@bagu.org>
1452 Cleanup some comments.
1454 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1456 2011-12-14 Ben Konrath <ben@bagu.org>
1458 Replace \n with <br/> for multiline text in the details view.
1460 Vertical scrollbars are added when needed as well.
1462 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1464 2011-12-14 Ben Konrath <ben@bagu.org>
1466 Specify the font for document selection links.
1468 * src/main/webapp/style.css:
1470 2011-12-14 Ben Konrath <ben@bagu.org>
1472 Fix bouncy CellTable while paging.
1474 This doesn't currently work with related list tables in unselected
1477 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1479 2011-12-14 Ben Konrath <ben@bagu.org>
1481 Revamp the appearance of the document selection page.
1483 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1484 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1485 * src/main/webapp/style.css:
1487 2011-12-13 Ben Konrath <ben@bagu.org>
1489 Set navigation button column to the smallest size possible.
1491 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1493 2011-12-13 Ben Konrath <ben@bagu.org>
1495 Change OpenButton nomenclature to NavigationButton.
1497 Using NavigtionButton makes things more generic. Classes, methods and
1498 variables have been changed.
1500 This is a rename-only refactor.
1502 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1503 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1504 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1505 Renamed from OpenButtonCell.
1506 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1507 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1508 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1510 2011-12-12 Ben Konrath <ben@bagu.org>
1512 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1514 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1515 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1516 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1517 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1519 2011-12-12 Ben Konrath <ben@bagu.org>
1521 Update variable names and comments.
1523 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1524 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1526 2011-12-12 Ben Konrath <ben@bagu.org>
1528 Properly initialize numNonEmptyRows variable to zero.
1530 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1531 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1533 2011-12-05 Ben Konrath <ben@bagu.org>
1535 Add latest mockup with HTML tables.
1537 Features of this mockup:
1539 -> HTML table for flowtable
1540 -> HTML table for flowtable column
1541 -> Example of how related lists would look
1542 -> Not using text entries for data items
1544 The current version of Online Glom doesn't use HTML tables for the
1547 This mockup has been sent to the glom-devel mailing list but it's good
1548 to have it here as well.
1550 * mockups/details-view-html-tables.html:
1552 2011-12-05 Ben Konrath <ben@bagu.org>
1554 Remove unnecessary getPrimaryKeyField() method.
1556 getPrimaryKeyFieldForTable(String) has been renamed to
1557 getPrimaryKeyField(String).
1559 * src/main/java/org/glom/web/server/database/DBAccess.java:
1560 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1561 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1563 2011-12-05 Ben Konrath <ben@bagu.org>
1565 Add string representation of TypedDataItem value to conversion error message.
1567 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1568 message was extracted into its own method to avoid duplication.
1570 2011-12-05 Ben Konrath <ben@bagu.org>
1572 Add type checking to navigation primary key value creation.
1574 Create navigation primary key only if the expected type from the Glom
1575 document matches the type returned by the SQL query.
1577 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1579 2011-12-05 Ben Konrath <ben@bagu.org>
1581 Rename a couple of variables in RelatedListNavigation.
1583 This is a rename-only refactor.
1585 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1587 2011-12-05 Ben Konrath <ben@bagu.org>
1589 Move getListLayoutGroup() into getListViewLayoutGroup().
1591 This removes getListLayoutGroup(). It was only being called by
1592 getListViewLayoutGroup().
1594 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1596 2011-12-05 Ben Konrath <ben@bagu.org>
1598 Remove check for LayoutItem_Portal in list table method.
1600 This check is no longer necessary because the method isn't being used
1601 to create the LayoutItemPortal DTO.
1603 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1605 2011-12-05 Ben Konrath <ben@bagu.org>
1607 Properly support related list navigation.
1609 Navigation from the "Repository Analyzer -> Package Scans ->
1610 Dependencies" related table wasn't working because the primary key for
1611 related tables wasn't being set properly. This commit fixes the
1614 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1615 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1616 doesn't set the primary key properly for related list tables.
1617 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1618 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1619 useful for getting the primary key for list view tables and for related
1621 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1622 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1623 Move code to set the primary key for the table from the abstract
1624 ListDBAccess class to ListViewDBAccess as it's only correct for list
1626 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1627 Properly add primary key to related list tables.
1629 2011-12-02 Ben Konrath <ben@bagu.org>
1631 Properly set the horizontal alignment of fields.
1633 This fix is for both the list tables and the details view.
1635 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1636 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1637 to set the horizontal alignment of fields.
1639 2011-12-02 Ben Konrath <ben@bagu.org>
1641 Display currency codes in the details view.
1643 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1645 2011-12-02 Ben Konrath <ben@bagu.org>
1647 Avoid duplicate JNI call.
1649 JNI is not as efficient as pure Java and this is an easy (and small)
1652 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1653 Use previously retrieved value for whereClauseToTableName instead of
1656 2011-12-02 Ben Konrath <ben@bagu.org>
1658 Rename a couple of variables in RelatedListNavigation.
1660 This is a rename-only refactor.
1662 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1664 2011-12-02 Ben Konrath <ben@bagu.org>
1666 Indicate clearly that a mismatched primary key type is a bug.
1668 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1669 warning to error. Add 'This is a bug.' to message.
1671 2011-12-02 Ben Konrath <ben@bagu.org>
1673 Update / fix some comments.
1675 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1677 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1679 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1680 Fix comments. Add some TODOs.
1682 2011-12-02 Ben Konrath <ben@bagu.org>
1684 Enable navigation to details view with string primary key from related list.
1686 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1687 Create a text primary key value when return type of result is
1688 java.sql.Types.VARCHAR.
1690 2011-12-02 Ben Konrath <ben@bagu.org>
1692 Use checkboxes for booleans in the details view.
1694 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1696 2011-12-01 Ben Konrath <ben@bagu.org>
1698 Improve performance of related list height calculation.
1700 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1701 Put code to calculate the expected height in a static initializer so
1702 that that it's only called once.
1704 2011-12-01 Ben Konrath <ben@bagu.org>
1706 Show related list tables in notebooks (again).
1708 Calculate the height of the related list tables so the Notebook can be
1709 set the correct height. The height of the related list table is also needed by
1710 FlowTable to be able decide how to create the layout.
1712 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1713 and set the Portal height based on the height of the related list
1714 table and the Portal container.
1715 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1716 Add method to calculate the height of the related list tables.
1717 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1718 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1719 calculate the height of the Pager widget.
1721 2011-12-01 Ben Konrath <ben@bagu.org>
1723 Use CellTable API for table property instead of setting style on Element.
1725 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1727 2011-12-01 Ben Konrath <ben@bagu.org>
1729 Make ListViewTable and RelatedListTable a consistent height.
1731 The tables are now a consistent height regardless of the contents of
1732 the table. A hidden button is added to empty rows to ensure that the
1733 height of these rows will match the height of rows with data.
1735 A navigation button column is now added to every table. The width of
1736 the navigation column is set to 0px when a RelatedListTable shouldn't
1737 have navigation buttons. This maintains the a consistent row height in
1738 tables that don't show the navigation buttons.
1740 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1741 navigation column when not needed.
1742 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1743 arguments for navigation button to constructor of ListViewTable.
1744 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1745 hidden button for empty data rows.
1746 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1747 arguments for navigation button to constructor.
1748 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1749 create navigation buttons. Add hideNavigationButtons() method.
1750 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1751 arguments for navigation button to constructor.
1753 2011-12-01 Ben Konrath <ben@bagu.org>
1755 Use 'visibility: hidden' in Utils.getWidgetHeight().
1757 This is better choice because hidden elements are invisible, don't
1758 respond to events and are not part of the tab order. They will,
1759 however, take up space which is required to be able to calculate the
1760 height of the widget.
1762 * src/main/java/org/glom/web/client/Utils.java:
1764 2011-12-01 Ben Konrath <ben@bagu.org>
1766 Use Utils.getWidgetHeight() in FlowTable.
1768 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1770 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1772 2011-12-01 Ben Konrath <ben@bagu.org>
1774 Put the details css class name on the correct table column.
1776 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1778 2011-11-30 Ben Konrath <ben@bagu.org>
1780 Update for java-libglom API change.
1782 The getters and setters on FieldFormatting and NumericFormat were
1783 changed to remove the 'M'.
1785 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1787 2011-11-29 Ben Konrath <ben@bagu.org>
1789 Only allow RelatedListTables in Portals.
1791 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1793 2011-11-29 Ben Konrath <ben@bagu.org>
1795 Only create a contents panel for Portals when title is being set.
1797 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1799 2011-11-29 Ben Konrath <ben@bagu.org>
1801 Set TabLayoutPanel height based on calculated height its widgets.
1803 This is a potential fix for this bug:
1805 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1807 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1809 2011-11-29 Ben Konrath <ben@bagu.org>
1811 Align details field labels and data with the Open buttons.
1813 * src/main/webapp/style.css:
1815 2011-11-29 Ben Konrath <ben@bagu.org>
1817 Remove unnecessary <div> in the Notebook widget.
1819 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1820 method to get container FlowPanel (<div>).
1821 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1822 initWidget() method directly on the TabLayoutPanel widget instead of
1823 Group's container widget.
1825 2011-11-29 Ben Konrath <ben@bagu.org>
1827 Don't add group titles for Portals in Notebooks.
1829 This reverts the previous patch and fixes a bug I introduced with
1830 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1832 * src/main/java/org/glom/web/client/ui/details/Group.java:
1833 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1835 2011-11-28 Ben Konrath <ben@bagu.org>
1837 Remove unused boolean argument in Portal constructor.
1839 Just a code cleanup.
1841 * src/main/java/org/glom/web/client/ui/details/Group.java:
1842 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1844 2011-11-28 Ben Konrath <ben@bagu.org>
1846 Remove hack for glom 1.18 style glom files.
1848 * src/main/java/org/glom/web/client/ui/details/Group.java:
1849 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1850 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1852 2011-11-28 Ben Konrath <ben@bagu.org>
1854 Use Gda Value version of primary key to log result too large error.
1856 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1858 2011-11-28 Ben Konrath <ben@bagu.org>
1860 Don't use TypedDataItem.getText() for Unknown types from the URL.
1862 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1863 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1864 instead of getText().
1865 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1866 String field and getUnknown() method.
1868 2011-11-28 Ben Konrath <ben@bagu.org>
1870 Log an error message when the java-libglom .so is not present.
1872 The error message was being set in the exception but not logged.
1874 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1876 2011-11-28 Ben Konrath <ben@bagu.org>
1878 Ignore LayoutItem_CalendarPortals.
1880 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1881 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1883 2011-11-28 Ben Konrath <ben@bagu.org>
1885 Extract method for creating the LayoutItemPortal DTO.
1887 Just breaking the code up into smaller chunks.
1889 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1891 2011-11-28 Ben Konrath <ben@bagu.org>
1895 This should have been added with the refactor. Oops!
1897 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1899 2011-11-28 Ben Konrath <ben@bagu.org>
1901 Create primary key value from URL string using type from Glom document.
1903 See this bug, comments 19 - 25:
1905 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1907 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1908 create a TypeDataItem for the primary key here when loading from a
1909 URL. Show the same string for the primary key value as was received
1910 from the URL string (when loading from a URL).
1911 * src/main/java/org/glom/web/server/Utils.java: Update method for
1912 creating the Gda Value from the TypeDataItem to properly deal with
1913 creating a Gda Value based on the Glom document type for the primary
1914 key value string when loading from a URL.
1915 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1916 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1917 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1918 Update for changed method name.
1920 2011-11-27 Ben Konrath <ben@bagu.org>
1922 Rename PrimaryKeyItem to TypedDataItem.
1924 The name PrimaryKeyItem suggests what the class should be used for.
1925 TypedDataItem is a neutral name that describes the class better.
1927 This is a rename-only refactor.
1929 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1930 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1931 * src/main/java/org/glom/web/client/Utils.java:
1932 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1933 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1934 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1935 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1936 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1937 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1939 * src/main/java/org/glom/web/server/Utils.java:
1940 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1941 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1942 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1943 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1945 2011-11-25 Ben Konrath <ben@bagu.org>
1947 Improve Gda Value conversion from PrimaryKeyItem.
1949 The value from the PrimaryKeyItem is only used if its type match the
1950 type from the glom document.
1952 * src/main/java/org/glom/web/server/Utils.java:
1954 2011-11-25 Ben Konrath <ben@bagu.org>
1956 Manually check if the java-liblgom .so is visible to the JVM.
1958 It seems that Tomcat has problems when a static initializer throws an
1959 exception. This check is done before the first method call into
1960 java-libglom so that execution doesn't continue if the .so is not
1963 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1965 2011-11-25 Ben Konrath <ben@bagu.org>
1967 Improve browser configuration error messages.
1971 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1973 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1974 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1975 getConfigurationErrorMessage() method.
1976 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1977 Get and display a specific configuration error message when no Glom
1978 documents are found.
1979 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1980 Implement getConfigurationErrorMessage() method. Surround configuration
1981 code in the init() method with a try/catch block. This allows the
1982 errors to be caught while keeping the servlet available to retrieve the
1983 configuration error message.
1985 2011-11-25 Ben Konrath <ben@bagu.org>
1987 Don't use Strings to hold primary key values.
1989 The primary key values are now held in a new data object
1990 (PrimaryKeyItem) that holds type information and the primary key value
1991 using the correct type.
1993 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1994 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1995 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1996 PrimaryKeyItem instead of String to hold the primary key value.
1997 * src/main/java/org/glom/web/client/Utils.java: Remove
1998 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1999 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2000 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2001 PrimaryKeyItem instead of String to hold the primary key value. Load
2002 document selection page when the documentID has not been set correctly.
2003 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2004 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2006 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2007 Return empty string for URL instead of "null".
2008 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2009 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2010 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2011 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2012 PrimaryKeyItem instead of String to hold primary key values.
2013 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2014 PrimaryKeyValue to a Gda Value.
2015 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2016 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2017 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2018 Replace temporary database access code that uses the PrimaryKeyValue to
2019 Gda Value conversion.
2020 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2021 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2022 PrimaryKeyItem instead of String.
2023 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2024 hold primary key values.
2026 2011-11-24 Ben Konrath <ben@bagu.org>
2028 Use newly added java-libglom API to create queries.
2030 This isn't finished. I still need to stop using Strings for primary key
2031 values in the client code.
2033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2034 libglom to use fake connections so that retrieving the query string will
2036 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2037 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2038 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2039 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2040 Use the newly added libglom sql methods and classes to create the
2041 query. Add temporary hack to convert primary value strings to Gda
2044 2011-11-23 Ben Konrath <ben@bagu.org>
2046 Don't explicitly set the height of Portals.
2048 See comments 6 - 10 of this bug for details:
2050 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2052 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2054 2011-11-23 Ben Konrath <ben@bagu.org>
2056 Use an HTML table instead of CSS for the FlowTable layout.
2058 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2059 GWT's FlexTable to implement the FlowTable.
2060 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2062 2011-11-18 Ben Konrath <ben@bagu.org>
2064 Add boolean example to HTML table mockup.
2066 * mockups/details-view-html-tables-text-entries.html:
2068 2011-11-17 Ben Konrath <ben@bagu.org>
2070 Ensure the pager buttons are always visible for related lists.
2072 To accomplish this, I've turned off text wrapping in the list view and
2073 related list tables for both the header and data text. The related list
2074 table now has a fixed layout so the it doesn't overflow its container.
2075 This is required to ensure that the cell text is clipped when it
2076 overflows the cell and an ellipsis is added to the right side of the
2077 cell when text is clipped.
2079 A fixed table layout for the related list table in the details view
2080 seems what we want for the details view anyway, so the side-effect is
2083 The ellipsis will only be displayed in Firefox >= 7.
2087 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2089 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2090 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2091 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2093 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2094 Set the 'table-layout: fixed' CSS property to the related list table.
2095 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2096 'white-space: nowrap;' CSS property on both the list view and the
2097 related list tables.
2099 2011-11-16 Ben Konrath <ben@bagu.org>
2101 Rework the fix for empty notebook tab labels.
2103 Setting the empty group titles with its name caused problems for the
2104 details layout. Instead of using libglom's
2105 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2106 to the client when the title is empty. This allows the Notebook to use
2107 the name when the title is empty without affecting anything else.
2109 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2110 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2112 2011-11-16 Ben Konrath <ben@bagu.org>
2114 Set group titles with name when title is empty.
2116 This fixes a problem with an empty notebook tab label in the Lesson
2117 Planner document. The forth tab in the notebook should be "Internet":
2119 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2121 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2122 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2125 2011-11-16 Ben Konrath <ben@bagu.org>
2127 Remove whitespace from the configured username properties.
2129 This assumes that usernames won't have whitespace at the beginning
2130 or end. But I think this is a reasonable assumption.
2132 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2133 String.trim() to remove the whitespace from the username properties.
2135 2011-11-15 Ben Konrath <ben@bagu.org>
2137 Add details view mockup with HTML tables and text entries.
2139 This is from the attachment on this bug:
2141 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2143 * mockups/details-view-html-tables-text-entries.html:
2145 2011-11-15 Ben Konrath <ben@bagu.org>
2147 Add space between the columns of the flow table.
2151 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2153 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2154 space between columns in the flow table.
2156 2011-11-15 Ben Konrath <ben@bagu.org>
2158 Add backup files to the .gitignore.
2160 * .gitignore: Ignore files that end with ~.
2162 2011-11-09 Ben Konrath <ben@bagu.org>
2164 Use latest release of gwt-log.
2166 Gwt-log releases are now being submitted to the maven central
2167 repository so manual installation of the jar is no longer required.
2169 * pom.xml: Update version and groupId of gwt-log dependency.
2171 2011-10-31 Ben Konrath <ben@bagu.org>
2173 Don't use GWT numeric formatting to override the glom currency formatting.
2175 Currencies are now displayed like they are in Glom. See this bug:
2177 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2179 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2181 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2182 currency code to constructor and set it when the cell is rendered.
2183 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2184 currency code to the constructor of the NumericCell.
2186 2011-10-27 Ben Konrath <ben@bagu.org>
2188 Require the latest release of java-libglom (1.17.4).
2192 2011-10-26 Ben Konrath <ben@bagu.org>
2194 Add style to Notebook that matches current theme.
2196 It's not the best style in the world but it's better than the default.
2198 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2199 padding at the bottom of the child widgets.
2200 * src/main/webapp/style.css: Add style for the Notebook.
2202 2011-10-26 Ben Konrath <ben@bagu.org>
2204 Move servlet initialization code to overridden init method.
2206 This is half of the solution to getting proper error messages
2207 displayed when configuration errors occur. Here's the relevant bug:
2209 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2211 The rest of the solution involves surrounding the init method with a
2212 try/catch block and setting a global variable with the error /
2213 exception. A new async method should be created to retrieve and display
2214 the error message / exception.
2216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2217 code from constructor to init method adding exceptions as needed.
2219 2011-10-26 Ben Konrath <ben@bagu.org>
2221 Add script to monitor and restart tomcat if required.
2223 * utils/check-and-recover-tomcat.py: New file.
2225 2011-10-26 Ben Konrath <ben@bagu.org>
2227 Display the correct number of data items in the pager.
2231 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2233 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2234 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2235 The implementation is the same for both tables: Keep track of the
2236 number of non-empty rows and fire and RowCountChangeEvent after the data has
2238 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2239 custom Pager class that subclasses SimplePager to handle displaying
2240 the correct number when empty rows have been added.
2242 2011-10-26 Ben Konrath <ben@bagu.org>
2244 Correct error in previous commit.
2246 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2247 eventBus parameter from listView.setCellTable().
2249 2011-10-26 Ben Konrath <ben@bagu.org>
2251 Fix error in TODO comment.
2253 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2255 2011-10-24 Ben Konrath <ben@bagu.org>
2257 Create Notebook widgets to the details view.
2259 This isn't finished just yet - I still need to create a reasonable
2260 style to match the current theme.
2262 * src/main/java/org/glom/web/client/Utils.java: Add method for
2263 calculating the height of a widget. This is used in the Notebook class.
2264 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2265 new constructor method in Group.
2266 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2267 method for creating child widget that can be used by subclasses
2268 like Notebook. New constructor that allows disabling the group
2269 titles - Notebooks don't set a group title for their child groups.
2270 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2271 to make Notebooks using GWT's TabLayoutPanel.
2272 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2273 constructor that allows disabling the group titles.
2274 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2275 LayoutItemNotebook DTO.
2276 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2277 DTO for Notebooks. It's just an empty class for now but we might need
2278 it to transfer some specific information in the future.
2280 2011-10-21 Ben Konrath <ben@bagu.org>
2282 Add navigation buttons to related list tables.
2284 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2285 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2286 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2287 method getSuitableRecordToViewDetails() for getting the table name
2288 and primary key value for related list navigation buttons.
2289 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2290 private cell renderer class to get the navigation information for
2291 related list tables from the server. Extract the navigation
2292 processing code from the details cell navigation and use it for the
2293 related list navigation as well.
2294 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2295 cell renderer class for the details open buttons. This was needed
2296 because the related list navigation buttons and the list view
2297 navigation buttons need to react differently when clicked.
2298 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2299 the onEnterKeyDown() method because it's now overriden in the
2300 subclasses that are specific to the related list tables and the list
2302 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2303 the vertical size a little because the buttons add a bit of vertical
2304 space to table. This is not a perfect solution because the vertical
2305 size of with table fewer than 5 rows will be a little smaller.
2306 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2307 changes in how navigation buttons are handled.
2308 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2309 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2310 database access object.
2311 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2312 to find the portal for a given relationship name from
2313 RelatedListDBAccess. Add method to find a primary key field for a
2315 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2316 Move code to find the portal for a given relationship name to
2318 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2319 New file: database access object for getting the related list
2320 navigation information (the table name and the primary key value).
2321 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2322 DTO for transferring a table name to navigate to and a primary key
2324 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2325 boolean and getter/setter to specifies if the related list should add
2328 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2330 Use the master branch of java-libglom
2332 * pom.xml: Depend on java-libglom 1.19 instead.
2334 This is the master branch. See also the libglom-1-18 branch.
2336 2011-10-11 Ben Konrath <ben@bagu.org>
2338 Enable the open navigation button when the data has been set.
2340 This avoids having active buttons that don't do anything when the data
2343 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2345 2011-10-11 Ben Konrath <ben@bagu.org>
2347 Use IsWidget interface for FlowTableItem.
2349 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2350 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2352 2011-10-11 Ben Konrath <ben@bagu.org>
2354 Remove GWT styling from open button in details view.
2356 There are still some issues with how the details cell is arranged but
2357 this should be made to match Glom 1.20. I'm going to leave fixing this
2358 until I have Glom 1.20 up and running.
2360 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2361 style name on open button.
2362 * src/main/webapp/style.css: Move and edit details-navigation class.
2363 Re-arrange some classes to make them appear in the same order as the
2366 2011-10-07 Ben Konrath <ben@bagu.org>
2368 Update to GWT 2.4.0.
2370 * .gitignore: Ignore new cache directory.
2371 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2372 * pom.xml: Change GWT and maven plugin to 2.4.0.
2373 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2375 * src/main/java/org/glom/web/client/ClientFactory.java:
2376 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2377 * src/main/java/org/glom/web/client/OnlineGlom.java:
2378 Update source for API changes.
2379 * utils/build-onlineglom-war.sh: Remove cache directory before the
2382 2011-10-07 Ben Konrath <ben@bagu.org>
2384 Add navigation buttons in the details view.
2386 This isn't finished but I thought I'd commit what I have as it's a
2387 pretty good start. I still need to:
2389 1. Change the style so that it fits better into the current theme
2390 2. Adjust the details cell to expand as much as possible.
2392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2393 click handlers to navigation buttons in the DetailsCells. Create a
2394 refreshData() method to get just the data from the server without the
2396 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2397 Update the tableSelector and browser title when the table name
2398 changes without using the tableSelector.
2399 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2400 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2401 getDetailsCells() to getCells(). Update variable names.
2402 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2403 method to set click handler on navigation button. Rename a few
2404 variables. Add navigation buttons where needed.
2405 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2406 variables and methods.
2407 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2408 navigation boolean and navigation table as required in the
2409 LayoutItemField DTO.
2410 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2411 variables for navigation along with getter/setter methods.
2413 2011-10-07 Ben Konrath <ben@bagu.org>
2415 Rename Field to DetailsCell.
2417 This is a refactor-only commit. No functionality has been added or
2420 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2421 Update variable and method names.
2422 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2423 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2424 variable and method names.
2425 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2427 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2428 variable and method names.
2430 2011-10-07 Ben Konrath <ben@bagu.org>
2432 Create separate methods for layout and data the details view.
2434 This is a refactor-only commit. No functionality has been added or
2437 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2438 private methods: setData(), createLayout().
2440 2011-10-07 Ben Konrath <ben@bagu.org>
2442 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2444 This is part of a change to get navigation buttons in the details view
2445 but it should have been done this way from the start.
2447 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2448 for method name change in TableSelectionView.
2449 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2450 Create TableChangeEvent and set the browser title using the
2451 TableSelectionView API.
2452 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2453 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2454 Change getSelectedTable() to getSelectedTableName(). Add
2455 getSelectedTableTitle().
2457 2011-10-07 Ben Konrath <ben@bagu.org>
2459 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2461 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2463 2011-10-07 Ben Konrath <ben@bagu.org>
2465 Update TableChangeEvent to use newTableName naming convention.
2467 This makes the class more consistent with GWT naming conventions.
2469 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2470 Update for method name change in TableChangeEvent.
2471 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2472 for method name change in TableChangeEvent.
2473 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2474 newTableName variable and getter method. Make toDebugString()
2477 2011-09-30 Ben Konrath <ben@bagu.org>
2479 Disable the pager in the list tables when the data row count is less than the minimum.
2481 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2482 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2484 2011-09-30 Ben Konrath <ben@bagu.org>
2486 Add empty rows to the end of related list and list view tables.
2488 I also extracted the cell rendering classes from the ListTable because
2489 the code was becoming a little crazy with all the anonymous inner
2490 classes. My plan is to use these cell rendering classes in the details
2491 view as well so this refactor will be needed for that change.
2493 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2494 set the row count in related list tables if the data has more rows
2495 than the minimum number of rows visible.
2496 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2497 row count in list view tables if the data has more rows than the
2498 minimum number of rows visible.
2499 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2500 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2502 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2503 for rendering TYPE_NUMERIC cells. The code was extracted from the
2505 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2506 class for rendering cells with buttons in list views. The code was
2507 extracted from the ListTable class.
2508 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2509 for rendering TYPE_TEXT cells. The code was extracted from the
2511 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2512 Add empty rows to the end of the data if required. Implement
2513 ListTable.getMinNumVisibleRows().
2514 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2515 cell renderer code to public classes. Return null in
2516 Column.getValue() for empty rows. Add new abstract method:
2517 getMinNumVisibleRows(). Move code to set the row count of the list view
2518 table to ListViewImpl.
2519 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2520 empty rows to the end of the data if required. Implement
2521 ListTable.getMinNumVisibleRows().
2524 2011-09-27 Ben Konrath <ben@bagu.org>
2526 Use GWT.log for client-side debugging statements.
2528 These are optimized out when deployed so I should have used this method
2529 in the first place. These statements will eventually be replaced with some sort
2530 of notification in the browser.
2532 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2533 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2534 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2535 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2536 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2538 2011-09-27 Ben Konrath <ben@bagu.org>
2540 Put tableselector on the right, back to list link on right.
2542 The idea is that the table selector is acting like a label for the
2543 currently displayed table so it should be placed below the document title. This
2544 puts the table title in a similar position to where it is in Glom.
2546 * mockups/details-contacts.html:
2547 * mockups/details-projects.html:
2548 * mockups/listview-contacts.html:
2549 * mockups/listview-projects.html:
2550 * mockups/style.css:
2551 Update mockups to match how the interfaces currently look.
2552 * src/main/webapp/style.css: Swap positions of backlink with the table
2553 selector. Add some space on the left side of the table selector to
2554 line things up with the document title.
2556 2011-09-27 Ben Konrath <ben@bagu.org>
2558 Add field colouring to details view.
2560 This change re-works how field colouring works. The colour formatting
2561 information is now set to the client with the layout information instead of
2562 with the data. This eliminates the need to send the same colour strings for
2563 data in list view column when colour information is set.
2565 In order to set an alternate colour for negative numeric values, the
2566 number is now sent to client and formatted with the GWT NumberFormat class.
2568 This change also fixes:
2570 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2572 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2573 internationalization framework which is needed for client side numeric
2575 * src/main/java/org/glom/web/client/Utils.java: New file for some
2576 client static utility methods.
2577 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2578 the DataItem object to the Field class. Use a utility method to
2579 create the foreignKeyValue string.
2580 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2581 alignment and text colours in the constructor. Add setData(DataItem)
2582 method. Remove setText(String) method.
2583 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2584 colour information to GlomTextCell. Create and use GlomNumberCell for
2585 rendering numbers. Use utility method to get the string for the
2586 primary key of the key provider. Re-work how the horizontal alignment
2588 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2589 formatting to layout information. Methods for converting the libglom
2590 formatting information were moved from DBAccess.
2591 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2592 numeric formatting (it's now done on the client side). Don't set text
2593 colours in DataItem. Move libglom formatting conversion methods to
2595 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2596 getters/setters for text colour information.
2597 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2598 for transferring the libglom NumericFormat information to the client.
2599 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2600 and getters/setters for: GlomNumericFormat, background colour and
2601 foreground colour strings.
2603 2011-09-26 Ben Konrath <ben@bagu.org>
2605 Simplify code that iterates through the LayoutGroup.
2607 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2609 2011-09-26 Ben Konrath <ben@bagu.org>
2611 Accept Eclipse formatting for OnlineGlomServiceAsync.
2613 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2615 2011-09-26 Ben Konrath <ben@bagu.org>
2617 Don't use the ListDBAccess classes to get the primary key layout information.
2619 This was causing a bug where the wrong index for the hidden primary key
2620 was being sent to the client.
2622 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2623 primary key while creating the LayoutGroup DTO. Create a
2624 LayoutItemField DTO for hidden primary keys. Don't use the
2625 RelatedListDBAccess because it was only used for getting the primary
2627 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2628 access modifier from public to protected for getPrimaryKeyField() and
2629 getPrimaryKeyLayoutItemField().
2630 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2631 abstract method getExpectedResultSize() because RelatedListDBAccess
2632 doesn't have enough info to implement it.
2633 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2634 Remove @Override for getExpectedResultSize().
2635 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2636 Remove method getExpectedResultSize().
2638 2011-09-23 Ben Konrath <ben@bagu.org>
2640 Log which layout (list or details) the ignored item is from.
2642 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2644 2011-09-23 Ben Konrath <ben@bagu.org>
2646 Remove annotations that turn off code formatting in DataItem.
2648 * src/main/java/org/glom/web/shared/DataItem.java:
2650 2011-09-23 Ben Konrath <ben@bagu.org>
2652 Rename GlomField to DataItem and update associated methods.
2654 This is a rename-only refactor. No functionality has been added or
2657 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2658 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2659 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2660 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2661 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2662 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2663 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2664 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2665 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2666 * src/main/java/org/glom/web/server/database/DBAccess.java:
2667 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2668 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2669 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2670 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2671 * src/main/java/org/glom/web/shared/DataItem.java:
2672 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2673 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2675 2011-09-23 Ben Konrath <ben@bagu.org>
2677 Rename GlomDocument to DocumentInfo and update associated methods.
2679 This is a rename-only refactor. No functionality has been added or
2682 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2683 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2684 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2685 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2686 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2687 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2688 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2690 2011-09-20 Ben Konrath <ben@bagu.org>
2692 Require java-libglom 1.17.3.
2694 This picks up the fix for the seg fault problem with the Scenes table
2695 in the Openismus Film Manager example.
2699 2011-09-20 Ben Konrath <ben@bagu.org>
2701 Change the way sort clause is added for primary key when no sort clause is requested.
2703 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2704 before the sort clause is created. When a sort clause is not requested, the
2705 sort clause is created by finding the primary key in the LayoutFieldVector
2708 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2710 2011-09-20 Ben Konrath <ben@bagu.org>
2712 Log error message if no documents are found in the configured directory.
2714 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2715 Extract the glom file extension string to a private static final class
2716 variable (mostly as syntactic sugar). Accept a minor formatting change.
2717 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2718 the example glom.document.directory configuration property to make it
2719 more clear that it can any directory, not just the home directory.
2721 2011-09-18 Ben Konrath <ben@bagu.org>
2723 Add related lists to details view.
2725 The related list table has support for paging and sorting just like the
2726 table in the list view.
2728 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2729 SQL queries for the related list tables.
2730 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2731 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2732 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2733 Rename getList methods to getListView and add comments. Remove
2734 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2735 it being unused. Add methods: getDetailsLayoutAndData(),
2736 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2737 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2738 Create the layout and set the data for the fields in one async call
2739 instead of two. Create related lists where appropriate.
2740 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2741 for method name changes in OnlineGlomService.
2742 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2743 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2744 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2746 * src/main/java/org/glom/web/client/ui/ListView.java:
2747 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2748 tableName from setCellTable(). Create a ListViewTable instead of
2750 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2751 represent a data field in the details view.
2752 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2753 from addDetailsCell() to Field class. Keep track of the Fields and
2754 Portals in the details view.
2755 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2756 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2757 and add a method to get it. Add method to set the contents of the
2759 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2760 New class for related list tables. This class has the data provider
2761 for the related list table.
2762 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2763 abstract class which is the base class for the ListViewTable and the
2765 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2766 New class for list view tables. This class has the data provider for
2767 the list view table.
2768 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2769 methods for related list tables. Add more information to the
2770 LayoutItemField and LayoutItemPortal DTOs.
2771 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2772 Remove debugging print statement.
2773 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2774 Remove debugging print statements. Add primary key field to SQL count
2776 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2777 Remove unnecessary LayoutFieldVector parameter from
2778 getResultSizeOfSQLQuery() method.
2779 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2780 New class for related list table database access.
2781 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2782 class that is a wrapper DTO for details view layout and data.
2783 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2784 new 'fromField' string to this DTO.
2785 * src/main/webapp/style.css: Remove bottom margin and override top
2788 2011-09-15 Ben Konrath <ben@bagu.org>
2790 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2792 This sets things up to make it easier to add the data retrieval for
2793 related lists (portals). No user noticeable changes were made with
2796 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2797 class has the code to retrieve the layouts and access the
2798 database using the new database helper classes.
2799 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2800 Most of the functionality has been removed from this class. This
2801 class now represents the public interface for the client side
2802 code. It also deals with configuring the servlet and cleaning
2803 things up when the servlet is stopped.
2804 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2805 of static methods into this utility class.
2806 * src/main/java/org/glom/web/server/database/DBAccess.java:
2807 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2808 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2809 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2810 These classes have the database retrieval code. The class hierarchy
2811 has been setup to make it easy to reuse code for similar
2814 2011-09-06 Ben Konrath <ben@bagu.org>
2816 Create separate classes for list table code and the data provider.
2818 As part of this refactor, I also split up the code a bit to make it
2821 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2822 table code to two new classes (below).
2823 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2824 with code from ListViewImpl.
2825 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2826 New file with code from ListViewImpl.
2828 2011-09-06 Ben Konrath <ben@bagu.org>
2830 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2832 This fixes the LayoutItemPortal DTO to match the libglom layout object
2835 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2837 2011-09-01 Ben Konrath <ben@bagu.org>
2839 Set title of Portals in the Details View.
2841 * pom.xml: Bump required version of java-libglom to 1.17.1.
2842 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2843 widget creation to its own class. Add comments to constructor.
2844 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2845 The code is mostly from the Group class with the title now set.
2846 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2847 title of Portal. Update some comments. Fix some code formatting.
2849 2011-09-01 Ben Konrath <ben@bagu.org>
2851 Remove TODO comment for the flow table column width.
2853 The flow table column width is working correctly and doesn't need to be
2854 changed. See this mailing list post for more info:
2856 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2858 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2860 2011-08-27 Ben Konrath <ben@bagu.org>
2862 Add document title (database name) to top of the browser page.
2864 I added the document title to the TableSelecitonView but that will
2865 change if / when we add a view that doesn't require table selection.
2867 * mockups/details-contacts.html:
2868 * mockups/details-projects.html:
2869 * mockups/listview-contacts.html:
2870 * mockups/listview-projects.html:
2871 * mockups/style.css: Add document title to mockups to keep things
2873 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2874 sizes to account for the document title.
2875 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2876 Set the document title when it has been retrieved from the server.
2877 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2878 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2879 and implement setDocumentTitle(String) method.
2880 * src/main/webapp/style.css: Add ID for document title style.
2882 2011-08-25 Ben Konrath <ben@bagu.org>
2884 Add NavigationType enum to LayoutItemPortal DTO.
2886 This is the start of adding support for Portals to the Details View.
2888 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2889 LayoutItem_Portal.navigation_type enum from libglom to
2890 LayoutItemPortal.NavigationType enum.
2891 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2892 NavigationType enum, field for storing the NavigationType and getter
2895 2011-08-25 Ben Konrath <ben@bagu.org>
2897 Implement the flow table layout in the Details View.
2899 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2900 FlowTable to Group to account for the renamed class.
2901 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2902 File. This is a container widget that implements the Glom details view
2903 flow table behaviour.
2904 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2905 org/glom/web/client/ui/FlowTable.java.
2906 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2907 so that the size of the subgroups are a closer match to the size of
2908 the Glom subgroups. This makes the flowtable layout match the layout
2909 in Glom for the Music Collection example file.
2911 2011-08-16 Ben Konrath <ben@bagu.org>
2913 Create container element for LayoutItemPortal in Details View.
2915 This will help me develop the layout for the FlowTable.
2917 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2918 fieldPanel variable to detailsCell.
2920 2011-08-15 Ben Konrath <ben@bagu.org>
2922 Set the height of the data element in the Details View.
2924 I changed the InlineLabels (text in a span element) to Labels (text in
2925 a div element) so that I could set the height of the details-data
2926 elements instead of the details-cell parent elements. This allows the
2927 the details-data element to display the correct height if style is
2928 applied that shows the height.
2930 This change has the added benefit of allowing the order of the labels
2931 and data elements to be changed for right-to-left languages.
2933 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2934 InlineLabels to Labels.
2935 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2936 InlineLabels to Labels. Set the height of the data element.
2937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2938 multiline text height in the Formatting DTO.
2939 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2940 for multiline height along with getter and setter methods.
2941 * src/main/webapp/style.css: Adjust style to account for the change
2942 from span elements to div elements in the details cell.
2944 2011-08-15 Ben Konrath <ben@bagu.org>
2946 Make the List View appearance match the mockups.
2948 It doesn't match exactly but it's much better than it was.
2950 * mockups/listview-contacts.html: Remove unused css classes.
2951 * mockups/listview-projects.html: Remove unused css classes.
2952 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2953 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2954 for mainPanel instead of VerticalPanel (table). Set style name on
2955 CellTable. Set style name on Details column. Right-align Details
2957 * src/main/webapp/style.css: Adjust properties to match the mockups.
2959 2011-08-12 Ben Konrath <ben@bagu.org>
2961 Add better support for subgroups in the details view.
2963 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2964 changed FlowTable constructor.
2965 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2966 support for subgroups and subgroup-titles.
2967 * src/main/webapp/style.css: Add CSS class for subgroups and
2970 2011-08-12 Ben Konrath <ben@bagu.org>
2972 Return the top level LayoutGroup title.
2974 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2976 2011-08-11 Ben Konrath <ben@bagu.org>
2978 Make the TableSelector header match the mockup.
2980 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2981 the layout panel. Properly lineup the table selection header with
2982 the list and details view.
2983 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2984 margin around the details view.
2985 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2986 Rename listBox variable to tableSelector. Set id for the style sheet.
2987 Use a FlowPanel instead of a HorizontalPanel.
2988 * src/main/webapp/style.css: Add properties to make the TableSelector
2989 box match the mockups.
2991 2011-07-13 Ben Konrath <ben@bagu.org>
2993 Update install script for java-libglom version change.
2995 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2998 2011-07-13 Ben Konrath <ben@bagu.org>
3000 Add support sub-group in the details view.
3002 I also removed the code that special-cased the default details view
3005 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3007 I still have to make a proper flowtable.
3009 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3010 Don't special-case default details view layout.
3011 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3012 addLayoutField() as I'm going to use it.
3013 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3014 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3016 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3017 extracted from DetailsViewImpl.GroupPanel. Add support for
3019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3020 column count when getting the details layout.
3022 2011-07-12 Ben Konrath <ben@bagu.org>
3024 Set browser title with database and table titles.
3026 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3027 Set the browser title when the table changes and when the activity
3029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3030 title when retrieving document info (the GlomDocument object).
3031 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3032 with getter and setter methods. Remove unused convenience constructor.
3033 Use default code formatting.
3035 2011-07-12 Ben Konrath <ben@bagu.org>
3037 Ignore LayoutItemPortals in the details view.
3039 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3042 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3043 LayoutItemPortal layout objects.
3044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3045 LayoutItemPortal objects when retrieving the details layout.
3046 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3047 file. This is an empty class and just used to get type information for
3050 2011-07-12 Ben Konrath <ben@bagu.org>
3052 Use java-libglom 1.17.0.
3056 2011-07-11 Ben Konrath <ben@bagu.org>
3058 Remove "Table:" label from table selector.
3060 This matches a recent change in the Glom UI.
3062 * mockups/details-contacts.html:
3063 * mockups/details-projects.html:
3064 * mockups/listview-contacts.html:
3065 * mockups/listview-projects.html: Remove the "Table:" label from the
3067 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3069 2011-07-11 Ben Konrath <ben@bagu.org>
3071 Add main groups to the details view.
3073 This makes things look a little nicer in the details view. The next step
3074 is to implement the flowtable.
3076 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3077 resources from the standard gwt css theme. Standard.css is now
3078 included in OnlineGlom.html so that the online glom css rules have
3079 precedence over the gwt theme.
3080 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3081 the whole LayoutGroup to the DetailsView instead of just the titles.
3082 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3083 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3084 details layout with a helper class (GroupPanel). I might extract this
3085 class when I make the full flowtable.
3086 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3087 string as default so I don't have to worry about NPEs when processing
3089 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3090 note beside OnlineGlom.gwt.xml above).
3091 * src/main/webapp/style.css: Add default font-size to body to override
3092 the font-size set by the standard theme. Don't use h2 tags for
3093 group-title. Create new details-cell class.
3095 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3097 ConfiguredDocument: Set the port number too.
3099 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3100 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3101 Glom document. Presumably this worked sometimes so far because there is a
3102 default port number.
3104 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3106 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3108 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3109 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3110 correct, though we should throw an exception too.
3112 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3114 Fix a addDocuemnt typo.
3116 * src/main/java/org/glom/web/shared/Documents.java
3117 (Documents.addDocuemnt): Rename to addDocument().
3118 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3119 (OnlineGlomServiceImpl.getDocuments): Adapt.
3121 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3123 Slightly improved log output when connection fails.
3125 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3126 (ConfiguredDocument.setUsernameAndPassword):
3127 We don't know for sure if it' the username/password that's wrong, so
3128 rephrase the message.
3129 Also ouput the exception message, though it's generic in this case.
3131 2011-07-08 Ben Konrath <ben@bagu.org>
3135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3136 added braces to a one line if statement because the Eclipse formatter
3137 was getting confused.
3139 2011-07-07 Ben Konrath <ben@bagu.org>
3141 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3143 These should really be two separate tasks but I counldn't get things to
3144 work with GWT 2.2.0 and Eclipse 3.7.
3148 * .settings/org.eclipse.jdt.core.prefs:
3149 * .settings/org.eclipse.jdt.ui.prefs:
3150 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3151 * .settings/org.eclipse.m2e.core.prefs:
3152 Add new config files. Update current files. Remove references to the
3153 webtools plugins as we're not using any of the webtools features.
3154 * .gitignore: Add logs directory which is created when running with
3156 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
3157 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
3158 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3160 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3162 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3164 onlineglom.properties: Add explanatory comments.
3166 * src/main/resources/onlineglom.properties: Also change the default user
3167 from ben to someuser, to avoid the risk of people thinking we just
3168 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3170 2011-06-28 Ben Konrath <ben@bagu.org>
3172 Use filename in Log for incorrect passwords.
3174 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3175 getFileName(String) method to get the filename from the URI.
3177 2011-06-28 Ben Konrath <ben@bagu.org>
3179 Add the table name to the URL token for the ListPlace.
3181 This makes things consistent between the DetailsPlace and the
3182 ListPlace. It also allows the the ListPlace to be bookmarked.
3184 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3185 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3187 Remove getDefaultListLayout(). The default layout is now returned
3188 by the getListLayout() method when the table name is an empty string.
3189 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3190 Add table name field. Change to a new ListPlace when the table
3191 has been changed. Use getListLayout() for getting the default
3193 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3194 Add table name field. Set the correct table name in the list box
3195 when loading from bookmark. This corrects a problem for the
3197 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3198 Move table name to super-class (HasSelectableTable). Move document
3199 and table URL keys to super-class in HasSelectableTable.
3200 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3201 Add table name field. Add Tokenizer class with URL key common to
3202 the subclasses (DetailsPlace and ListPlace).
3203 * src/main/java/org/glom/web/client/place/ListPlace.java:
3204 Add table name. Add code to parse the URL token.
3205 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3206 Update ListPlace construction with empty table name string.
3207 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3208 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3209 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3210 Update ListPlace construction with table name string.
3211 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3212 Change defaultTableName field to tableName to reflect how it's now
3213 used. Update the getter and setter methods.
3215 2011-06-28 Ben Konrath <ben@bagu.org>
3217 Enable the table selector in the DetailsView.
3219 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3220 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3222 Remove getDefaultDetailsLayout(). The default layout is now returned
3223 by the getDetailsLayout() method when the table name is an empty
3225 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3226 event handler for table change event. Change to using
3227 getDetailsLayout() for the default details layout.
3228 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3230 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3231 when navigating to the details place.
3233 2011-06-27 Ben Konrath <ben@bagu.org>
3235 Use filename based unique document ID in URL and for RPC.
3237 The document ID is the glom document name with spaces (' ') replaced
3238 with pluses ('+') and without the .glom extension.
3240 This change is mostly a string substitution of 'documentTitle' for
3241 'documentID'. The only code change is the addition of a Documents DTO to get the
3242 filename to document title mappings as indicated below.
3244 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3245 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3246 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3247 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3248 Use Documents DTO to create the document links in the document