1 2012-11-19 Murray Cumming <murrayc@murrayc.com>
3 Update the .glom files used for tests.
5 * src/test/resources/org/glom/web/server/example_film_manager.glom:
6 * src/test/resources/org/glom/web/server/example_music_collection.glom:
7 * src/test/resources/org/glom/web/server/libglom/example_film_manager.glom:
8 * src/test/resources/org/glom/web/server/libglom/example_music_collection.glom:
9 Copy them from git master of Glom.
11 2012-11-18 Murray Cumming <murrayc@murrayc.com>
13 Update versions of dependencies.
15 * pom.xml: Increase some version numbers based on the output of
16 , using mvn versions:display-dependency-updates.
17 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
18 Use the annotation instead of getModuleName().
19 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
20 Do not use deprecated assert() classes/methods.
22 2012-11-18 Murray Cumming <murrayc@murrayc.com>
24 Document: Correct an import to use the correct Log API.
26 * src/main/java/org/glom/web/server/libglom/Document.java:
27 Use our Utils.Log API rather than the jfree one that Eclipse
28 must have suggested at some time.
30 2012-11-15 Murray Cumming <murrayc@murrayc.com>
32 Details: Get static image data from our images services.
34 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
35 Add constructors for LayoutItemText and LayoutItemImage and
36 deal with their common type instead of just LayoutItemField.
38 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
40 * src/main/java/org/glom/web/client/ui/details/Group.java:
41 createChildWidget(): Use the other DetailsCell constructors for
42 these layout items, and do not add them to the list of
43 cells with data from the database.
44 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
45 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
46 Remove the image data when cloning the layout and storing it in the
47 cache. Clients will instead get it via the URL, from
49 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
50 doGet(): Depending on the URI parameters, optionally get
51 image data from a layout_item_image in the document,
53 * src/main/java/org/glom/web/server/database/DBAccess.java:
54 convertResultSetToDTO(): Move some URIBuilder code to:
55 * src/main/java/org/glom/web/server/Utils.java:
56 Add buildImageDataUrl() taking the primary key, etc, to
57 get data from the database.
59 2012-11-15 Murray Cumming <murrayc@murrayc.com>
61 Document: Static image items: Store an image URL, using the layout path.
63 * src/main/java/org/glom/web/server/Utils.java: Add buildImageDataUrl().
64 * src/main/java/org/glom/web/server/libglom/Document.java:
65 Add a constructor that takes the documentID, for use in the
67 loadLayoutNode(): Pass a Path object to the helper methods, so we
68 can use it to create a URL for LayoutItemImage items.
69 This seems as good a way as any to specify a layout item in the document.
70 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
71 Pass the documentID to the constructor, for use in the LayoutItemImage
74 2012-11-15 Murray Cumming <murrayc@murrayc.com>
76 Document: Add getLayoutItemByPath().
78 * src/main/java/org/glom/web/server/Utils.java:
79 Add buildLayoutPath() and parseLayoutPath().
80 * src/test/java/org/glom/web/server/LayoutPathTest.java: Test that these
82 * src/main/java/org/glom/web/server/libglom/Document.java:
83 Add Add getLayoutItemByPath().
84 * src/test/java/org/glom/web/server/libglom/DocumentLayoutPathTest.java: Test
87 This will be useful in subsequent commits.
89 2012-11-15 Murray Cumming <murrayc@murrayc.com>
91 Need a short description (OOPS!).
92 Need the bug URL (OOPS!).
94 Reviewed by NOBODY (OOPS!).
96 Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
99 * .settings/com.google.gdt.eclipse.core.prefs:
100 * .settings/com.google.gwt.eclipse.core.prefs:
101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
102 (DetailsActivity.createLayout):
103 (DetailsActivity.setData):
104 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
106 (DetailsCell.DetailsCell):
107 (DetailsCell.setupWidgets):
108 (DetailsCell.setData):
109 (DetailsCell.getLayoutItem):
110 * src/main/java/org/glom/web/client/ui/details/Group.java:
111 (Group.createChildWidget):
112 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
113 (ConfiguredDocument.getValidListViewLayoutGroup):
114 (ConfiguredDocument.getDetailsLayoutGroup):
115 (ConfiguredDocument):
116 (ConfiguredDocument.updateLayoutItemImages):
117 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
118 (ConfiguredDocumentSet.getDocumentIdForFilename):
119 (ConfiguredDocumentSet):
120 (ConfiguredDocumentSet.addDocument):
121 (ConfiguredDocumentSet.readConfiguration):
122 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
123 (OnlineGlomImages.OnlineGlomImages):
124 (OnlineGlomImages.doGet):
126 (OnlineGlomImages.getImageFromDocument):
127 (OnlineGlomImages.getImageFromDatabase):
128 * src/main/java/org/glom/web/server/Utils.java:
130 (Utils.buildImageDataUrl):
131 (Utils.buildImageDataUrlStart):
132 (Utils.buildLayoutPath):
133 (Utils.parseLayoutPath):
134 * src/main/java/org/glom/web/server/database/DBAccess.java:
135 (DBAccess.convertResultSetToDTO):
136 * src/main/java/org/glom/web/server/libglom/Document.java:
140 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
141 (DocumentTest.TestThread.run):
143 2012-11-15 Murray Cumming <murrayc@murrayc.com>
145 Document: Use a better base64 decoder to read static image data.
147 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
148 getNodeTextChildAsValue(): Use the apache commons base64 decoder
149 instead of the gwt one, because it correctly decodes the strings
150 from g_base64_encode(). It is probably more correct.
151 The newlines might be confusing the gwt decoder.
153 2012-11-14 Murray Cumming <murrayc@murrayc.com>
155 Document: Do not use == to compare strings. Use equals().
157 * src/main/java/org/glom/web/server/libglom/Document.java:
158 == only checks that they are the same object, so it can
161 2012-11-14 Murray Cumming <murrayc@murrayc.com>
163 Document: Add and use public constants for layout names.
165 * src/main/java/org/glom/web/server/libglom/Document.java:
166 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
167 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
168 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
169 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
170 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
171 them here instead of hard-coded the strings repeatedly.
173 2012-11-13 Murray Cumming <murrayc@murrayc.com>
175 Document: Load static text and image items too.
177 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
178 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
179 New LayoutItem classes to represent these layout items.
180 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
181 main text of a LayoutItemText.
182 * src/main/java/org/glom/web/server/libglom/Document.java:
183 load_after_layout_group(): Handle the node types and instantiate the
185 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
186 Add testLayoutItemText() to check that the text is loaded properly.
188 2012-11-13 Murray Cumming <murrayc@murrayc.com>
190 Do not use client.GWT for shared code.
192 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
193 Import shared.GWT instead of client.GWT, which seems to be appropriate.
195 2012-11-12 Murray Cumming <murrayc@murrayc.com>
197 Use image data when recreating databases for testing.
199 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
200 for use locally (not acrosss the network) when recreating databases
202 getValue(): Use it here instead of getImageDataUrl(), noting that
203 this method is only for use when recreating databases.
204 * src/main/java/org/glom/web/server/libglom/Document.java:
205 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
207 2012-11-09 Murray Cumming <murrayc@murrayc.com>
209 OnlineGlomImages: Detect the mime-type (content type).
211 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
212 doGet(): Instead of hard-coding image/png.
214 2012-11-09 Murray Cumming <murrayc@murrayc.com>
216 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
219 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
220 Java Compiler and Java Build path settings in the UI.
222 2012-11-09 Murray Cumming <murrayc@murrayc.com>
224 Use the latest (now stable) version of GWT.
226 * pom.xml: And the latest version of the gwt-maven-plugin.
228 2012-11-08 Murray Cumming <murrayc@murrayc.com>
230 Added an Indonesian translation.
232 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
233 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
234 This is from the new translation in Glom.
236 2012-07-23 Murray Cumming <murrayc@murrayc.com>
238 Details: Show images.
240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
242 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
243 so it can be used in:
244 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
245 for serving image data.
246 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
248 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
249 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
250 setData(): For image field types, add a GWT Image widget,
251 with the URL that was set in the DataItem.
253 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
254 * src/main/java/org/glom/web/server/database/DBAccess.java:
255 convertResultSetToDTO(): Set the URL for image data, so the client browser
256 can retrieve the image from our new servlet. This uses UriBuilder.
257 Move getPrimaryKeyField to:
258 * src/main/java/org/glom/web/server/libglom/Document.java:
259 Added getTablePrimaryKeyField().
261 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
262 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
263 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
266 2012-07-22 Murray Cumming <murrayc@murrayc.com>
270 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
271 * src/main/java/org/glom/web/client/OnlineGlomService.java:
272 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
273 to gwtGlom, which is more appropriate.
274 This servlet name does not seem to be visible to the client side anyway.
276 2012-07-22 Murray Cumming <murrayc@murrayc.com>
278 Tests: Make the imports of assert*() consistent.
280 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
281 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
282 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
283 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
284 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
285 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
286 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
287 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
288 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
289 * src/test/java/org/glom/web/shared/DataItemTest.java:
291 import static org.junit.Assert.*;
292 which seems fairly common.
296 2012-07-21 Murray Cumming <murrayc@murrayc.com>
298 tests: Move a test that needs a database connection.
300 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
301 Move testGetListViewLayoutGroup() to
302 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
303 because it needs a database connection.
305 2012-07-21 Murray Cumming <murrayc@murrayc.com>
307 tests: Use @BeforeClass on tearDown().
309 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
310 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
311 This avoids leaking a postgres process in SelfHostExampleTest.
313 2012-07-21 Murray Cumming <murrayc@murrayc.com>
315 tests: Test translations more.
317 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
318 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
319 Test titles in the non-default locale.
321 2012-07-21 Murray Cumming <murrayc@murrayc.com>
323 tests: Add SelfHostConfiguredDocumentTest
325 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
326 username and password, for use by ConfiguredDocument.
327 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
328 This tests some of the ConfiguredDocument API that requires a database connection.
330 2012-07-21 Murray Cumming <murrayc@murrayc.com>
332 Document: Load title translations and test them.
334 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
335 of titles. I am surprised that we do not do this yet.
336 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
337 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
338 Test translations more.
340 2012-07-20 Murray Cumming <murrayc@murrayc.com>
344 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
345 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
346 Set the timeout here too.
348 2012-07-20 Murray Cumming <murrayc@murrayc.com>
350 tests: ConfiguredDocumentTest: Make this pass.
352 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
353 Disable tests that need a database connection.
355 2012-07-20 Murray Cumming <murrayc@murrayc.com>
357 Use Java 1.7 instead of Java 1.6.
359 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
360 to do this twice, at least for Eclipse.
361 This seems OK because it is the current version.
363 2012-07-20 Murray Cumming <murrayc@murrayc.com>
367 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
368 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
369 Avoid using a null Connection.
371 2012-07-20 Murray Cumming <murrayc@murrayc.com>
373 tests: Add a ConfiguredDocument test.
375 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
378 2012-07-20 Murray Cumming <murrayc@murrayc.com>
380 LayoutItemFIeld: getName(): Use the Field if it is set.
382 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
383 getName(): If the full field details have been set, return its name, so that
384 callers do not need to set the name separately.
385 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
386 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
387 so we can count the rows.
389 2012-07-20 Murray Cumming <murrayc@murrayc.com>
391 tests: SelfHoster: Test SqlUtils too.
393 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
394 Retrieve some data and check it too, as in the regular Glom
395 test_selfhosting_new_from_example.cc test.
396 * src/test/java/org/glom/web/server/SelfHoster.java:
397 createConnection(): Make this public.
399 2012-07-20 Murray Cumming <murrayc@murrayc.com>
401 tests: SelfHoster: createConnection(): Do not warn about expected failures.
403 Let the caller say if the connection is expected to fail, to avoid
404 irrelevant error output.
406 2012-07-20 Murray Cumming <murrayc@murrayc.com>
408 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
410 * src/test/java/org/glom/web/server/SelfHoster.java:
411 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
412 due to the inevitable need to retry the connection while the database server
415 2012-07-20 Murray Cumming <murrayc@murray.com>
417 tests: SelfHoster: createConnection(): Set a timeout.
419 * src/test/java/org/glom/web/server/SelfHoster.java:
420 createConnection(): Use setLoginTimeout() because it otherwise seems to take
421 ages to actually return when it fails.
423 2012-07-20 Murray Cumming <murrayc@murrayc.com>
425 tests: SelfHoster: selfHost(): Close the test connection.
427 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
428 When we check that the connection works, close the connection. This seems
429 to not be closed automatically otherwise.
431 2012-07-20 Murray Cumming <murrayc@murrayc.com>
433 Use slf4j-simple to see JDBC errors.
435 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
437 2012-07-19 Murray Cumming <murrayc@murrayc.com>
439 SelfHoster.discoverFirstFreePort(): Close the socket.
441 * src/test/java/org/glom/web/server/SelfHoster.java:
442 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
444 2012-07-19 Murray Cumming <murrayc@murrayc.com>
446 Avoid another code warning in Eclipse Juno.
448 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
449 Do instanceof checks on the FileUtils.listFiles() result and its
452 2012-07-13 Murray Cumming <murrayc@murrayc.com>
454 Avoid some code warnings in Eclipse Juno
456 * src/main/java/org/glom/web/server/libglom/Document.java:
457 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
458 * src/test/java/org/glom/web/server/SelfHoster.java
459 createTextFile(): Make sure that the FileOutputStream is closed.
461 2012-06-22 Murray Cumming <murrayc@murrayc.com>
463 Added OnlineGlomPropertiesTest.
465 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
466 Make sure we never return a null string.
467 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
468 Added tests of the OnlineGlomProperties API, using our sample file.
470 2012-06-20 Murray Cumming <murrayc@murrayc.com>
472 Make OnlineGlomProperties be a normal class.
474 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
475 Move OnlineGlomProperties into its own file to be a regular class:
476 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
477 This makes testing simpler.
479 2012-06-15 Murray Cumming <murrayc@murrayc.com>
481 OnlineGlomServiceImpl.init(): Move some code into a new method.
483 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
484 Create addDocument().
486 2012-06-15 Murray Cumming <murrayc@murrayc.com>
488 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
490 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
491 OnlineGlomProperties.getKey(): Make this more robust by moving the
492 check for *.*.filename to here.
494 2012-06-15 Murray Cumming <murrayc@murrayc.com>
496 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
498 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
499 init(): Move knowledge of the config file format into the
500 OnlineGlomProperties inner class.
502 2012-06-15 Murray Cumming <murrayc@murrayc.com>
504 SelfHostExampleTest: Make sure we cleanup on failure.
506 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
507 the use of cleanup() to a tearDown() JUnit method.
511 2012-06-12 Murray Cumming <murrayc@murrayc.com>
513 ConfiguredDocument: Add a primary key to portals at least once.
515 * src/main/java/org/glom/web/server/ConfiguredDocument.java
516 updatePortalsExtras): Fix a typo so that we add the primary key
517 column at least once.
518 This is a fix for the previous commit:
519 ConfiguredDocument: Do not add a primary key to portals each time.
521 2012-06-08 Murray Cumming <murrayc@murrayc.com>
523 SelfHoster: Avoid some compiler warnings.
525 * src/test/java/org/glom/web/server/SelfHoster.java
526 executeCommandLineAndWait():
527 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
528 the now-unused streams for stdout and stderr from the command Processes.
529 These are not used because readln() hangs while waiting for a new line,
530 where there may be no next line. The commented out code is still there
531 to help us figure out how to do this properly.
533 2012-06-08 Murray Cumming <murrayc@murrayc.com>
535 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
537 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
538 Make this actually test the cloning again, though it is not very useful
539 now that we do not use the part that had a problem with cloning before.
541 2012-06-08 Murray Cumming <murrayc@murrayc.com>
543 SelfHoster: Keep trying pg_ctl after starting postgres.
545 * src/test/java/org/glom/web/server/SelfHoster.java
546 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
547 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
548 regular Glom. This seems mad but it seems to work because the first
549 command would fail if pg_ctl would eventually fail.
551 2012-06-08 Murray Cumming <murrayc@murrayc.com>
553 SelfHoster: Wait until the server is really ready.
555 * src/test/java/org/glom/web/server/SelfHoster.java
556 selfHost(): Attempt the connection after starting the server, retrying
557 a few times if necessary, so that the server is really ready already when
558 we return from this method.
559 The regular Glom code does this too because pg_ctl reports success too soon.
561 2012-06-08 Murray Cumming <murrayc@murrayc.com>
563 ConfiguredDocument: Do not add a primary key to portals each time.
565 * src/main/java/org/glom/web/server/ConfiguredDocument.java
566 updatePortalsExtras(): Only add an extra primary key field if there is
567 none, to avoid adding one each time we retrieve the details layout from the
569 This should fix bug #676986 (Ben Konrath)
571 2012-05-25 Murray Cumming <murrayc@murrayc.com>
573 Document.load(): Support version 7 documents.
575 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
576 database_title attribute if the title attribute is not there.
579 2012-05-24 Ben Konrath <ben@bagu.org>
581 Add configuration for auto-generating mvn:i18n from with Eclipse.
583 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
585 2012-05-24 Murray Cumming <murrayc@murrayc.com>
587 Update translations, adding French.
589 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
590 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
591 Add a French translation, using the translation from Glom.
593 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
594 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
595 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
596 Update these based on the translations from Glom.
598 2012-05-24 Murray Cumming <murrayc@murrayc.com>
600 SelfHoster: Add some debug println messages to help when things fail.
602 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
603 System.out.println() lines.
605 2012-05-23 Murray Cumming <murrayc@murrayc.com>
607 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
609 * src/test/java/org/glom/web/server/SelfHoster.java:
610 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
611 instance) instead of just /usr/bin (as on Fedora). Check the result when
614 2012-05-23 Murray Cumming <murrayc@murrayc.com>
616 Remove LayoutItemPortal.get/setNavigationTable().
618 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
619 Remove get/setNavigationTable(), which is only a cache, because it is not
620 used, and does not need to be used, because that decision should be made on
622 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
623 updatePortalsExtras():
624 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
625 getNavigationRecord():
626 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
629 2012-05-21 Murray Cumming <murrayc@murrayc.com>
631 Initial self-hosting for tests.
633 * pom.xml: Change the scope for log4j, to hopefully make it
634 available to the test code which uses it indirectly via jOOQ.
635 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
636 self-hosting, though we only use it for testing.
638 * src/main/java/org/glom/web/server/libglom/Document.java:
639 example rows: Use a map instead of a list for each row of values,
640 so we know what field they are for, instead of relying on the sequence
641 being correct. This is not very efficient, but it does not really need
643 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
644 testReadTableExampleRows(): Adapted.
646 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
647 that returns an Object, for generic use. Note that Object seems to be
648 the implicit base even of double.
649 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
650 for use in CREATE TABLE SQL queries.
651 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
652 to do self-hosting of PostgreSQL databases via its command-line
653 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
654 backends/postgres_self.cc. This is incomplete - it needs more
655 warnings about failures and it needs to clean up properly when things
657 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
658 test of this new class.
660 2012-05-21 Murray Cumming <murrayc@murrayc.com>
662 Document: loading example data: Handle exceptions.
664 * src/main/java/org/glom/web/server/libglom/Document.java:
665 DateFormat.parse() and Double.valueOf() can throw exceptions, though
666 Eclipse did not warn about that.
668 2012-05-20 Murray Cumming <murrayc@murrayc.com>
670 Document: load(), save(): Handle the example rows.
672 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
674 * src/main/java/org/glom/web/server/libglom/Document.java:
675 load(), save(): Load and save the example rows, though the date, time
676 and image types are not handled properly yet.
677 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
678 Add testReadTableExampleRows() just to check that something is read.
680 2012-05-20 Murray Cumming <murrayc@murrayc.com>
682 Document: Add save().
684 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
685 Added getTranslationsMap() for use while saving.
686 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
687 Adedd getUseDefaultFormatting() for use while saving.
688 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
689 and several private methods that it uses.
691 This will be useful while testing via self-hosting.
692 It is not complete, but should be complete enough for testing.
694 2012-05-17 Murray Cumming <murrayc@murrayc.com>
696 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
698 * src/main/java/org/glom/web/client/OnlineGlomService.java
699 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
701 Remove getSortedListViewData() and getSortedRelatedListData(), adding
702 the sort column index and ascending bool to the regular method.
703 Instead, a sort column index of -1 now means no sort.
704 This is less explicit, but it's fairly simple, reduces the amount of
705 code, and makes the OnlineGlomService API slightly smaller.
706 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
707 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
709 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
710 getListViewData(), getRelatedListData():
711 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
712 getListViewData(), getRelatedListData():
713 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
715 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
717 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
722 2012-05-16 Murray Cumming <murrayc@murrayc.com>
724 Use translations for top-level groups too.
726 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
727 updateTitlesForLocale(): Use the translation for the group
728 as well as for child items.
732 Just recompiled to fix a problem in the released .tar.gz file.
736 2012-05-15 Murray Cumming <murrayc@murrayc.com>
738 Corrections to navigation to related records.
740 * src/main/java/org/glom/web/client/OnlineGlomService.java:
741 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
742 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
743 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
744 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
745 relationship name, because the relationship name is not necessarily unique
747 TOOD: This is inefficient, because it passes the whole list of
748 child field items back to the server, but it is more correct, and happens
749 to fix a bug with the primary key being lost after a few navigations.
750 There is probably a chance to make this more efficient anyway in some
753 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
754 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
755 * src/main/java/org/glom/web/server/ConfiguredDocument.java
756 * src/main/java/org/glom/web/server/database/DBAccess.java
757 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
758 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
761 2012-05-15 Murray Cumming <murrayc@murrayc.com>
763 Fix the use of translations.
765 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
766 Add updateTitlesForLocale().
767 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
768 Call it to discard unwanted translations and to make getTitle() return
769 the wanted translation wihout the need for the client code to specify a locale.
770 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
771 getTitle(): Fallback to the original title, as libglom does.
773 2012-05-15 Murray Cumming <murrayc@murrayc.com>
775 Document: Correctly report the number of available translation locales.
777 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
778 the available locale IDs list.
779 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
780 testLocales: Test this.
782 2012-05-15 Murray Cumming <murrayc@murrayc.com>
784 SqlUtils: Use camelCase.
786 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
787 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
788 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
789 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
790 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
791 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
793 2012-05-15 Murray Cumming <murrayc@murrayc.com>
795 Use jOOQ's tableByName() and fieldByName.
797 * pom.xml: Use jOOQ 2.3.1 to get the new API.
798 * src/main/java/org/glom/web/server/SqlUtils.java:
799 build_sql_select_step_with_where_clause(), .createField(),
800 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
801 so we can get correct quoting and escaping. Thanks to Lukas Eder for
802 adding this, and other things, to jOOQ.
804 2012-05-15 Murray Cumming <murrayc@murrayc.com>
806 SqlUtils: Remove the Connection parameters.
808 * src/main/java/org/glom/web/server/SqlUtils.java:
809 build_sql_select_with_key(), build_sql_select_with_where_clause(),
810 createSelect(), build_sql_select_step_with_where_clause(),
811 build_sql_count_select_with_where_clause(),
812 build_sql_select_count_rows(): Remove the Connection parameter because
813 jOOQ does not actually need a connectionwhen it is just used to build
815 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
817 * src/main/java/org/glom/web/server/ReportGenerator.java:
819 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
821 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
822 Constructor, getListData(), getResultSizeOfSQLQuery():
823 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
824 getSelectQuery(), getCountQuery():
825 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
826 getSelectQuery(), getCountQuery():
827 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
828 getNavigationRecord(): Adapted.
830 2012-05-14 Murray Cumming <murrayc@murrayc.com>
834 * src/main/java/org/glom/web/server/SqlUtils.java:
835 get_find_where_clause_quick(): Use a comparison of
836 lowercase values, instead of a simple equals. Regular Glom
837 uses the PostgreSQL ILIKE operator but jOOQ does not
838 support that just yet, though it will soon.
840 2012-05-14 Murray Cumming <murrayc@murrayc.com>
842 TableToViewDetails: Use a real serialization ID.
844 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
845 Though this does not fix the serialization problem.
847 2012-05-12 Murray Cumming <murrayc@murrayc.com>
849 Added LayoutItemPortalDeepCloneTest.
851 2012-05-11 Murray Cumming <murrayc@murrayc.com>
853 Make navigation work again.
855 * src/main/java/org/glom/web/server/libglom/Document.java:
856 Add getLayoutItemFieldShouldHaveNavigation().
857 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
858 Replace get/setAddNavigation() with the partly-existing
859 get/setNavigationTableName(), with an empty string being no navigation,
860 because this is simpler. Use the new
861 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
863 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
864 Add updateFieldsExtras() and call setNavigationTableName in it.
865 getDetailsLayoutGroup(),
866 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
867 createLayout(): Adapted.
868 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
869 Constructor: Adapted.
871 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
872 Replace get/setAddNavigation() with get/setNavigation(), returning a
873 TableToViewDetails class with both the table name and UsesRelationship,
874 because both are need. The previous code used java-libglom's output
875 variable (strangely, via sharedptr) to return both, but we cannot really
877 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
878 getNavigationRecord(): Adapt. However, we cannot actually use the cache
879 here because it somehow gets set to null during deepCopy(). I must test this.
880 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
881 testGetSuitableTableToViewDetails(): Adapted.
883 TODO: Find out why deepClone() is not quite working.
885 2012-05-11 Murray Cumming <murrayc@murrayc.com>
887 DBAccess: Simplify the retrievel of full field details.
889 * src/main/java/org/glom/web/server/database/DBAccess.java
890 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
891 because the Document loading should have done this.
893 2012-05-11 Murray Cumming <murrayc@murrayc.com>
895 Document: Correct loading of doubly-related layout fields.
897 * src/main/java/org/glom/web/server/libglom/Document.java:
898 loadUsesRelationship(): Actually set the related relationship, instead
899 of only setting it if it's not found.
901 2012-05-09 Murray Cumming <murrayc@murrayc.com>
903 Replace all appearances of Colour with color.
905 Because US English is dominant.
907 2012-05-09 Murray Cumming <murrayc@murrayc.com>
909 Use colors in HTML format, solving a warning about an unused function.
911 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
912 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
913 Add *asHTMLColor() versions of methods.
914 TODO: However, we should create and cache the results on the server.
915 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
916 * src/main/java/org/glom/web/client/ui/list/ListTable.java
917 * src/main/java/org/glom/web/server/ConfiguredDocument.java
918 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
919 Use the asHTMLcolor() versions.
921 2012-05-09 Murray Cumming <murrayc@murrayc.com>
923 ListViewTable: Constructor: Take the table name as a parameter.
925 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
926 Constructor: Take the tableName, and set the member variable, because
928 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
929 setCellTable(): Pass the table name.
930 This makes navigation to non-default tables work again. I don't know
931 why it worked before in the master branch.
933 2012-05-07 Murray Cumming <murrayc@murrayc.com>
935 ConfiguredDocument: Restore correct addition of hidden primary key items.
937 * src/main/java/org/glom/web/client/ui/list/ListTable.java
938 (ListTable.createCellTable): Uncomment out the check for the hidden
940 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
941 add primary key items for top-level lists and portals, as before,
942 instead of adding them to each group.
943 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
944 Actually implement the extra methods such as setHiddenPrimaryKey() and
945 comment that these are used only for top-level list groups and in portals.
946 This strangeness suggests even more that this should not be squeezed
947 into the LayoutGroup class.
949 2012-05-07 Murray Cumming <murrayc@murrayc.com>
951 Fix Formatting loading.
953 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
954 getFormattingUsed(): Remove the duplicate Formatting member variable
955 in favour of the one from the base class.
956 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
957 Initialize a new Formatting instead of using null by default, so we
958 have some defaults, instead of having to initialize one later just to
959 get the same defaults. This also makes loading of formatting from the
960 document work, because that expected a non-null.
962 2012-05-07 Murray Cumming <murrayc@murrayc.com>
964 RelatedListTable: Make sure that the tableName is set.
966 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
967 Constructor: Take the tableName so it is available later. Otherwise,
968 the server assumes that we mean the default table and cannot find the
970 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
971 setData(): Pass the tableName to the RelatedListTable constructor.
973 2012-05-07 Murray Cumming <murrayc@murrayc.com>
977 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
978 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
979 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
981 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
983 * src/main/java/org/glom/web/server/database/DBAccess.java:
984 convertResultSetToDTO(), getPortal():
985 * src/main/java/org/glom/web/server/database/ListDBAccess.java
987 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
988 Add checks for null objects and out of range access, with log messages to
989 give hints so we can fix these properly.
991 2012-05-07 Murray Cumming <murrayc@murrayc.com>
993 Portals: some corrections.
995 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
997 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
998 constructor: Use getRelationshipNameUsed() instead of getName(), because
999 that is what is meant.
1000 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1001 getFromField(): Fix a typo, to get the field name, not the table name.
1002 * src/main/java/org/glom/web/server/database/DBAccess.java:
1003 getPortal(): Fix a typo that stopped this from working.
1005 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1007 LayoutItemPortal: Also override getTitleOriginal().
1009 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1010 This lets the base getTitle() with no parameters work.
1011 TODO: Test this properly.
1013 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1015 LayoutItemPortal: getTitle*(): Use the relationship title.
1017 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1019 LayoutItemField: Fix loading of custom titles.
1021 * src/main/java/org/glom/web/server/libglom/Document.java
1022 loadDataLayoutItemField(): The title, if any, instead of the field
1023 title, is stored in a title_custom node. Load it from there.
1024 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
1026 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
1027 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
1028 getTitle*() overrides.
1029 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1032 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1034 LayoutItemField: Fall back to field titles, so some are really shown.
1036 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1037 Override getTitleOriginal() and getTitle(), as in java-libglom.
1038 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1039 Test this behaviour.
1041 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1043 Correct use of setExpectedResultSize().
1045 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1046 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
1047 Use setExpectedResultSize only on top-level groups (for instance, the
1048 list layout) or on child portals (in details views).
1049 Use the correct table name for portals to avoid SQL errors.
1050 Update the expected counts when returning cached layouts.
1052 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1054 Document: Interpret no group column count as 1.
1056 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
1057 default, though we now check for this in the UI code anyway.
1059 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1063 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1065 Translatable: Use Hashmap instead of Treemap because GWT supports it.
1067 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
1068 The use of Treemap lead to this error from async methods, with no
1070 "The response could not be deserialized"
1072 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1074 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
1076 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
1077 when using the Google -> GWT Compile, or
1078 g toolbar button -> GWT Compile Project... feature in Eclipse.
1080 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1082 ListTable.addColumn(): Protect against a null Formatting.
1084 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
1085 Create a default Formatting if it is null, because that is the simplest
1088 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1090 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
1092 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1093 updateLayoutGroup(): Check that the field is not null.
1095 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1097 ListViewImpl: Protected against a bad cast error.
1099 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1100 onEnterKeyDown(): Do not cast without an instanceof check.
1102 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1104 ListTable: Protect against an out of range error.
1106 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1107 createCellTable(): This is unlikely, but can happen while debugging.
1109 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1111 AsyncMessage onFailure() callbacks: Log the exception message.
1113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1114 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1115 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1116 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1117 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1118 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1119 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1120 These are useful clues when something is wrong.
1122 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1124 ConfiguredDocument: Avoid a null dereference.
1126 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1127 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
1128 details maps are created.
1130 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1132 Document: Correct the port number parsing.
1134 * src/main/java/org/glom/web/server/libglom/Document.java:
1135 This lets us actually connect to the database and show the document.
1137 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1141 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1142 user-interaction, asking us to load a temporary URL in a browser.s
1143 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1144 which is apparently necessary for testing the service. See the comment.
1145 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1146 Show the exception, if any. This is how I saw the 404 in the HTML in
1149 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1151 DocumentTest: Move the .glom files into the resources directory.
1153 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1154 URI via getResource().
1156 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1158 Document: Remove the FieldIdentifies inner class.
1160 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1161 use the Relationship (though the same function in libglom is maybe
1162 used in other ways) and so this removes a compiler warning.
1164 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1166 Document.load() Remove the error code parameter.
1168 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1169 Remove the parameter. We do not set it yet and it could never have
1170 worked as an output parameter (though maybe it did in java-libglom).
1171 We could use an exception if we really want the failure reason.
1172 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1174 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1175 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1177 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1179 Make some inner classes static.
1181 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1183 * src/main/java/org/glom/web/server/ReportGenerator.java
1184 * src/main/java/org/glom/web/server/libglom/Document.java
1185 Make all inner classes static that can be static.
1187 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1189 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1192 init(): We do not use java-libglom any more.
1194 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1196 Remove mentions of java-libglom.
1198 * README: Remove mention of java-libglom, because it no longer needed.
1199 * utils/build-onlineglom-war.sh:
1200 * utils/check-and-recover-tomcat.py:
1201 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1202 useful. Building is now far easier, with no need for jhbuild.
1204 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1206 Fix the build (mvn package)
1208 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1209 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1210 Otherwise the GWT Java->Javascript compilation fails with just this
1211 error, during mvn package or when attempting to view in a browser,
1212 in the GWT developer mode in Eclipse.
1214 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1215 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1216 [INFO] Compiling module org.glom.web.OnlineGlom
1217 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1218 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1219 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1220 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1221 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1222 [INFO] [ERROR] Cannot proceed due to previous errors
1224 It has taken me 2 days to find out what was causing that. After reducing
1225 the code, the compiler eventually showed me the full error message.
1227 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1229 ConfiguredDocument: Cache the cloned and stripped layouts.
1231 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1232 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1233 layout in a map, so we can retrieve it again without rebuilding it.
1235 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1237 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1239 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1241 libglom classes: Implement some auto-generated emthods.
1243 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1245 Add GwtTestOnlineGlomService.
1247 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1248 However, this (and the other GwtTest*) does not seem to run during
1251 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1253 Remove use of unsupported features from client code.
1255 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1256 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1257 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1258 Use our client version of StringUtils instead of the apache commons one.
1260 However, the GWT Javascript compliation still fails.
1262 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1264 Add a Field class and implement some loading of it in Document.
1266 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1268 Initial Document loading implementation, instead of libglom.
1270 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1271 and Translatable classes, and adapt the rest of the code to use them.
1272 However, this is still missing Layout and Field classes and loading.
1274 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1276 Use of jOOQ: Move Field creation into a utility method.
1278 * src/main/java/org/glom/web/server/SqlUtils.java:
1279 This lets us improve it more easily.
1281 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1283 Use of jOOQ: Improve the code to COUNT a sub-select.
1285 * src/main/java/org/glom/web/server/SqlUtils.java:
1286 Move initial query creation into
1287 build_sql_select_step_with_where_clause().
1288 build_sql_select_count_rows(): Use the jOOQ API instead of
1289 concatentating text, because a jOOQ Select*Step is a TableLike,
1290 which is what from() takes.
1292 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1294 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1296 * pom.xml: Depend on jooq.
1297 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1298 methods with jOOQ, based on the C++ implementations in libglom,
1299 with some changes to the logic required by jooQ.
1300 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1302 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1303 * src/main/java/org/glom/web/server/ReportGenerator.java:
1304 * src/main/java/org/glom/web/server/SqlUtils.java:
1305 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1306 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1307 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1308 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1309 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1310 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1311 because jOOQ needs that, though it seems unnecessary.
1313 This is not quite finished. Ideally jOOQ would help us to build
1314 table_name.field_name names, quoting and escaping them properly.
1315 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1317 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1319 Move use of Glom.build_sql*() into a new SqlUtils class.
1321 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1322 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1323 but this will make it easier to start using something other than
1324 libglom or SqlBuilder.
1326 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1328 Update the project URL.
1330 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1332 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1334 Main layout: Use a FlowTable instead of absolute positioning.
1336 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1337 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1338 child panels/widgets must have an absolute position. But that is annoying, so
1339 this adds a FlowTable and puts the child panels in there.
1341 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1343 GwtTestOnlineGlom: Comment out unused code.
1345 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1346 Eclipse has started to say that some code is unused.
1348 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1350 Update to the latest versions of dependencies.
1352 * pom.xml: Update version numbers of dependencies to the latest
1354 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1355 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1356 * src/main/java/org/glom/web/server/ReportGenerator.java:
1357 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1358 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1359 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1361 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1362 Modify the imports where necessary.
1364 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1366 Style: Remove overflow:hidden from searchbox
1368 * src/main/webapp/style.css: Because this pushes the Back To Link
1369 label/link on to the next row, which is then hidden due to the
1370 hard-coded (in ems) height.
1372 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1374 Remove some duplicate code.
1376 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1377 getDocumentInfo(): This must have been duplicated during the merge from the
1382 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1384 Reports: Localize the waiting for report message.
1386 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1387 start(): Get the message from the contants.
1388 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1389 Add the string here.
1390 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1391 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1392 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1393 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1394 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1395 Update these files with the English text for newer strings for now.
1397 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1399 Reports: Show a message while waiting for the report.
1401 * src/main/java/org/glom/web/client/ui/ReportView.java
1402 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1403 Add setWaitingText(), to show a message saying that we are
1404 waiting for the report to be ready.
1405 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1406 start(): Call setWaitingText() before calling the async
1409 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1411 ReportGenerator: Specify date and time formats.
1413 * src/main/java/org/glom/web/server/ReportGenerator.java:
1414 createFieldValueElement(): Use the default (and localized)
1415 short formats, though we still need a way to show 4-digit
1416 years without providing the format for every locale.
1417 * src/main/java/org/glom/web/server/database/DBAccess.java:
1418 convertResultSetToDTO(): Use the short formats here too.
1420 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1422 ReportGenerator: Use the correct numeric formatting.
1424 * src/main/java/org/glom/web/server/ReportGenerator.java
1425 createFieldExpression(), createFieldValueElement(): Take the
1426 whole LayoutItem_Field instead of just the field name, so
1427 we have access to the formatting.
1428 createFieldValueElement(): Use JRTextField.setPattern() to
1429 specify the numeric formatting, with the help of a
1430 regular DecimalFormat.
1432 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1434 ReportGenerator: Avoid showing null for group by titles.
1436 * src/main/java/org/glom/web/server/ReportGenerator.java
1437 generateReport(): Use setBlankWhenNull() on the field title
1438 style too, because this is used for values in group by
1441 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1443 ReportGenerator: Add a colon to titles in vertical groups.
1445 * src/main/java/org/glom/web/server/ReportGenerator.java
1446 addFieldToDetailBandVertical(): Pass true for the withColon
1449 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1451 ReportGenerator: Simplify the code by using Position more.
1453 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1455 Reports: Support vertical groups, roughly.
1457 * src/main/java/org/glom/web/server/ReportGenerator.java:
1458 addToReport(): Rename to addGroupToReport() and, if necessary,
1459 call the new addVerticalGroupToReport() method.
1460 createFieldValueElement(): Let the caller specify the Y position
1463 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1465 Reports: Allow a second report to be shown.
1467 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1468 clear(): Do not remove the HTML widget, which broke the whole layout.
1470 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1472 Locales drop-down: Show that we use English by default.
1474 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1475 fillView(): When we use English, just because that is the default, when
1476 no locale is specified, show that in the Locales drop-down instead of
1477 just showing the first item.
1479 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1481 Unselect the Report/Locale/Table combo item when appropriate.
1483 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1484 setPlace(): clear reportName if this is not a ReportPlace.
1485 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1486 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1487 When the provided name is empty, unselect all items, so that none are
1488 indicated. This uses a for loop because I cannot find a single method
1491 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1493 Report: Give the user a way to get back to the list.
1495 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1496 start(), setPlace(): Show the Back To List link on reports, and also
1497 interpret selecting the empty report item as back to list.
1499 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1501 Really show the selected Report name.
1503 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1504 setPlace(): Store the reportName here, if it is that kind of Place.
1505 fillView(): Set the selected Report after filling the list of reports.
1506 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1507 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1508 null Strings, though we need some way to unselect all ListBox items
1511 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1513 ReportGenerator: Try to avoid some problems.
1515 * src/main/java/org/glom/web/server/ReportGenerator.java
1516 addField(): Try to avoid duplicates, and avoid using a null
1519 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1521 Reports: Use quickFind.
1523 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1524 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1525 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1526 getReportHTML(): Add a quickFind parameter.
1527 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1528 start(): Pass the quickFind parameter.
1529 * src/main/java/org/glom/web/server/ReportGenerator.java
1530 generateReport(): Take a quickFind parameter.
1532 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1534 ReportPlace: Actually use the report name.
1536 * src/main/java/org/glom/web/client/place/ReportPlace.java
1537 getPlace(): Do not assign the report name to the quickfind.
1539 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1541 Show java.library.path when complaining.
1543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1544 init(): When telling us to check java.library.path, show the
1547 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1549 ReportGenerator: Do not show nulls.
1551 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1553 ReportGenerator: Make the title font larger.
1555 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1557 ReportGenerator: Put field titles inside groups, if there are groups.
1559 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1561 ReportGenerator: Take the Report itself instead of the name and group.
1563 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1564 Remove getReportLayoutGroup().
1565 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1566 getReportHTML(): Pass the report instead
1567 of its name and layout group.
1568 * src/main/java/org/glom/web/server/ReportGenerator.java
1569 generateReport(): Use the report object to use the title
1570 instead of the name.
1572 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1574 ReportGenerator: Remove designBand parameters.
1576 * src/main/java/org/glom/web/server/ReportGenerator.java:
1577 Make designBand a class member instead of passing it to all
1580 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1582 ReportGenerator: Add lines, a bit like in the desktop version.
1584 * src/main/java/org/glom/web/server/ReportGenerator.java
1585 addToReport(): Use JRDesignLine.
1587 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1589 ReportGenerator: Correct the title positions and use some bold style.
1591 * src/main/java/org/glom/web/server/ReportGenerator.java:
1592 Break the code up into reusable functions, correct the placement of
1593 titles, and use normal/bold styles as in the reports in the desktop
1596 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1598 ReportGenerator: Add a header band to show the field titles.
1600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1601 getReportHTML(): Pass the localeId to the ReportGenerator
1603 * src/main/java/org/glom/web/server/ReportGenerator.java
1604 constructor: Take the localeID so we can get translated field
1606 generateReport(), addToReport(), addFieldToBand(): Add field
1607 titles in a column header band.
1609 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1611 Reports drop-down list: Some improvement.
1613 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1614 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1615 Adedd setSelectedReport(),
1616 setReportList(): Add a blank line so that the user can select the
1618 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1619 start(): Show the current report by calling setSelectedReport().
1620 This does not seem to work yet.
1622 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1624 DetailsActivity, ListActivity: Move some variables into a base class.
1626 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1627 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1628 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1629 the clientFactory, documentID, tableName and authenticationPopup into
1630 a base class, to avoid duplication.
1632 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1634 Translate the Reports label.
1636 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1637 Get the "Reports" label string from the constants.
1638 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1639 perties: Add Reports to the constants.
1641 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1643 Reports: Implement grouping.
1645 * src/main/java/org/glom/web/server/ReportGenerator.java:
1646 Handle LayoutItem_GroupBy items and try to do the right thing
1647 with JRDesignGroup. It seems to work.
1649 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1651 Actually show some data with JasperReports.
1653 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1654 getReportHTML(): Move most code into a ReportGenerator class.
1655 * src/main/java/org/glom/web/server/ReportGenerator.java:
1656 Recurse into sub-groups, adding fields to the JasperDesign's details
1657 band. Note that we must set an arbitrary width and height, or it just
1658 will not show any data.
1660 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1662 Reports Chooser: Show the titles, not the names.
1664 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1665 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1666 and the names as the values.
1667 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1668 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1669 group now that we provide the report name, so it should always
1672 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1674 Depend on jasperreports.
1676 * pom.xml: Add the dependency. My plan is to use this on the
1679 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1681 Implement navigation to report places.
1683 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1684 start(): Do not bother to handle all events here.
1685 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1686 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1687 Added getSelectedReport().
1688 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1689 .java: start(): When handling a change to the reports chooser,
1690 call getSelectedReport() and goTo() its ReportPlace.
1691 * src/main/java/org/glom/web/client/ui/ReportView.java
1692 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1693 Added setReportHTML() which puts the html in a gwt HTML widget.
1694 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1695 getReportHTML(): Return "TODO" just to show that this works.
1697 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1699 Make ReportPlace usable.
1701 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1702 Mention ReportPlace.
1703 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1704 Correct the @prefix annotation.
1706 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1708 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1710 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1711 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1712 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1713 Change getReportLayout() to getReportHMTL() because we will not need to
1714 parse or render the report layout on the client side.
1715 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1716 getReportLayout(): Return the libglom LayoutGroup type because we will
1717 not need to convert to a shared type, because this will not be used on
1719 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1722 Note that there is still no implementation for this.
1725 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1727 Add a (empty) Report Place, View, and Activity.
1729 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1731 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1732 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1733 this into a superclass:
1734 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1735 and also use it as the base of this new ReportPlace:
1736 * src/main/java/org/glom/web/client/place/ReportPlace.java
1738 * src/main/java/org/glom/web/client/ui/ReportView.java
1739 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1740 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1741 Add these, containing mostly boiler-plate for now.
1743 * src/main/java/org/glom/web/client/OnlineGlomService.java
1744 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1745 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1747 Add API to get the LayoutGroup for the report.
1749 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1751 Add and fill a Reports drop-down list box.
1753 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1755 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1756 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1757 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1758 Added getReports(document, table, localeID), calling
1759 ConfiguredDocument.getReports().
1760 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1761 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1762 Added setReportsList() and a list widget.
1763 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1764 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1769 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1771 Translations: Add Esperanto.
1773 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1774 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1775 properties: Add this translation because someone took the time to make it.
1777 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1779 Adapt to the java-libglom 1.21.7 API.
1781 * src/main/java/org/glom/web/server/ReportGenerator.java:
1782 addToReport(): get_group_secondary_fields() is now
1783 get_secondary_fields().
1786 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1788 Use the latest java-libglom version.
1790 * pom.xml: Use java-libglom 1.21.7.
1792 2012-03-03 Ben Konrath <ben@bagu.org>
1794 Display date and time in details view.
1796 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1798 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1800 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1802 Require the latest java-libglom.
1804 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1806 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1808 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1810 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1811 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1812 an empty quickfind string. I also corrected libglom to create only
1813 empty where clauses for empty quickfind strings, but this avoids the
1816 2012-02-24 Ben Konrath <ben@bagu.org>
1818 Improve the tabs in the Notebook widget.
1822 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1824 Translations: Try to translate the strings.
1826 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1827 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1828 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1829 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1830 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1831 Take the Open translation from GTK+'s .po files.
1832 Take the Details translation from Glom's po files.
1833 I have added the other strings to Glom so we can get translations that way:
1834 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1836 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1838 TableSelectionViewImpl: Put the search label and entry in a div.
1840 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1841 Put the search widgets in a FlowTable so that the CSS can be used to
1842 style them while keeping them together.
1843 * src/main/webapp/style.css: Mention the new div.
1845 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1847 Translate more strings in more locales.
1849 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1850 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1851 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1852 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1853 Translate the "Details" and "Open" string too.
1855 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1856 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1857 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1858 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1859 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1860 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1861 Add these new locales as placeholders though they currently contain English.
1863 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1865 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1868 Check the ConfiguredDocument* for null before using it.
1870 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1872 Tell Eclipse about the generated java files.
1874 * .classpath: This lets it find OnlineGlomConstants.java.
1875 It would be nice if Eclipse just used the maven build files.
1877 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1879 Prevent a crash when no locale is specified in the URL.
1881 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1882 Avoid returning a null string, obtained from
1883 Window.Location.getParameter(). This caused a crash when it was
1884 later passed to libglom's API.
1885 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1886 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1887 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1888 guard against future null strings.
1890 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1892 Use the ?locale= query param instead of the &lang= token param.
1894 * src/main/java/org/glom/web/client/place/ListPlace.java
1895 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1896 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1897 Remove the lang token key and value.
1899 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1900 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1901 When the user selects a different locale from the chooser, use
1902 Window.Location.assign() to change the URL, which then causes a reload.
1904 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1905 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1906 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1907 * src/main/java/org/glom/web/client/activity/ListActivity.java
1908 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1909 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1910 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1911 * src/main/java/org/glom/web/client/ui/ListView.java:
1912 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1914 Remove localeID member variables and method/constructor parameters, instead
1915 using Utils.getCurrentLocaleID() when we need a localID to pass to
1918 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1920 Internationalize the UI strings.
1922 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1923 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1924 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1925 because it is unused. Messages are apparently strings that can have
1926 parameters, but we do not need that yet, so Contants will be enough for now.
1927 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1928 to say that we support the en and de locales.
1929 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1930 The original English strings.
1931 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1932 Some German translations of the English strings.
1933 The i18n goal then uses the .properties file to generate an
1934 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1935 returns an implementation that returns the translated strings.
1936 The documentation suggests putting these in src/java/*/client/, but it seems
1937 best to put it in src/resources/*/client/.
1938 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1939 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1940 instead of hard-coding them.
1941 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1942 but that does not seem to stop the build, though it confuses Eclipse.
1944 You can see the translated string by adding ?locale=de to the URL, like so:
1945 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1947 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1949 Improve null/empty String checks.
1951 * pom.xml: Add a dependency on commons-lang, to use
1952 org.apache.commons.lang.StringUtils.
1953 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1955 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1956 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1957 Use StringUtils.isEmpty().
1959 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1960 StringUtils class with a static isEmpty() function because we
1961 cannot use org.apache.commons.lang.StringUtils in client-side
1962 GWT code because it (apparently) cannot be compiled to javascript.
1963 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1964 * src/main/java/org/glom/web/client/activity/ListActivity.java
1965 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1966 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1967 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1968 * src/main/java/org/glom/web/client/place/ListPlace.java
1969 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1970 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1971 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1972 * src/main/java/org/glom/web/client/ui/details/Group.java
1973 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1974 our StringUtils.isEmpty() function.
1976 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1978 Update to the latest java-libglom API.
1980 * pom.xml: Require java-libglom 1.21.4.
1981 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1982 getDocumentInfo(), getListViewLayoutGroup():
1983 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1985 * src/main/java/org/glom/web/server/database/DBAccess.java
1986 getFieldsToShowForSQLQueryAddGroup(),
1987 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1988 with either get_database_title_original() or
1989 get_database_title(localeID).
1991 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1993 ConfiguredDocument: Avoid a null pointer exception.
1995 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1996 Initialize localeID to "" to avoid returning a null String which
1997 causes a crash in java-libglom's swing-generated code.
1999 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2001 Some simple renaming.
2003 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2004 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
2005 for localeChooser. This seems more appropriate and is less ambiguous
2006 particularly in the .css file.
2008 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2010 ConfiguredDocument: Rename the localedID private member variable.
2012 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2014 Adapt to the latest java-libglom API from git master.
2016 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2017 libglom now uses only Vector instead of List, which uses add() instead of
2020 2012-01-22 Murray Cumming <murrayc@murrayc.com>
2022 ConfiguredDocument: Rename the localedID private member variable.
2024 2012-01-20 Murray Cumming <murrayc@murrayc.com>
2026 Build a source tarball with mvn assembly:single
2028 * assembly.xml: Add this file.
2029 * pom.xml: Use the maven-assembly-plugin and tell it to use
2030 our assembly.xml file.
2032 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2034 OnlineGlomServiceImpl: Get .glom files recursively.
2036 * pom.xml: Depend on commons-io from org.apache.commons.
2037 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2038 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
2039 files recursively, and with the easier filter for the extension.
2040 Use org.apache.commons.io.FilenameUtils.removeExtension() to
2041 simplify that code too.
2043 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2045 README: Mention that you must install java-libglom packages separately.
2047 But then it works, because java-libglom is now in the central maven
2050 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2052 locales drop-down: Show the correct selected locale when the URL changes.
2054 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2055 .java: setPlace(): Move some code into fillView().
2057 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2059 locales drop-down: Do not lose the primary key.
2061 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2062 start(): onLocaleChange(): Pass the current primary key value,
2063 instead of an empty value.
2065 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2067 locales drop-down: Do not lose the drop-down selection.
2069 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2070 .java (TableSelectionActivity.fillView): Set the selected locale
2071 after changing the drop-down items (though we do not really need
2072 to change them just because the locale changes.)
2074 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2076 locales drop-down: Change the tables list when this changes.
2078 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2079 .java: TableSelectionActivity.start(): Move the async table titles
2080 retrieval into a private fillView() method and also call this when
2081 the chosen locale changes.
2082 Note that the document title is not actually translatable yet, but
2083 that is a problem that I should fix soon in libglom.
2085 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2087 Improve the placement of the locales drop-down.
2089 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2090 Put the title and locales drop-down in a div (gwt.FlowTable).
2091 * src/main/webapp/style.css: Add magic css properties to make this work.
2092 Also remove the left margin from the title so that it lines up with the
2095 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2097 locales selector: Show human-readable locale titles.
2099 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2100 getDocumentInfo(): Use java.util.Locale to show a real title of
2101 each locale, in the locale's own language.
2103 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2105 Add a language/locale selector drop-down.
2107 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2108 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
2109 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
2110 getDocumentInfo(): Store the available Locales in the DocumentInfo.
2111 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2112 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2113 Add a ListBox to show the available locales. Add getLocaleSelector(),
2114 setLocaleList(), getSelectedLocale(), setSelectedLocale().
2115 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
2116 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
2117 java: Add these classes.
2118 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2119 start(): Fill the locales ListBox. Handle its change event, firing a
2121 setPlace(): Show the selected locale as specified by the URL token.
2122 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2123 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2124 Handle LocaleChangeEvent, going to a new *Place with that locale.
2126 The placement of the ListBox is not pretty, and it currently uses the ID
2127 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
2131 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2133 Search box: Show the search text from the URL token.
2135 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2136 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2137 Add setQuickFindText().
2138 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2139 .java: setPlace(): Store the queryText if the place is a ListPlace,
2140 and call TableSelectionView.setQuickFindText().
2142 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2144 Allow use of translations via, for instance, &lang=de in the URL.
2146 * pom.xml: Use the unstable java-libglom 1.21 version.
2148 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2149 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2151 init(): Instead of calling TranslatableItem.set_current_locale()
2152 (now removed), call ConfiguredDocument.setDefaultLocaleID().
2153 However, this is only for default locales, which are not needed to
2154 change the locale in the URL.
2155 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2156 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2157 getSortedRelatedListData(): Add a localeID parameter, so we can get the
2158 layout for a particular locale.
2159 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2160 Add get/setDefaultLocaleID().
2161 getDocumentInfo(), getListViewData(), getRelatedListData(),
2162 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2163 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2164 localeID parameter, so we can get the layout for a particular locale.
2166 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2167 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2168 * src/main/java/org/glom/web/client/place/ListPlace.java:
2169 Parse and construct a lang parameter too.
2171 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2172 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2173 passed to subsequent methods and constructors.
2174 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2175 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2176 Store the localeID from the *Place and pass it to other constructors
2177 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2179 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2180 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2181 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2182 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2183 * src/main/java/org/glom/web/client/ui/ListView.java:
2184 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2185 Take localeID parameters and pass them to subsequent constructors and
2186 methods, so that the layout is always retrieved for that locale.
2188 This is rather repetitive.
2190 Note that "" means the original (default) locale of the Glom document,
2191 which is usually English.
2193 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2195 Documents: Remove final keyword to fix startup configuration.
2197 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2198 final keywords on the private member variables because that breaks
2199 the startup, apparently (there are warnings) because it stops them
2200 from being serialized. I added these in the previous commit.
2202 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2204 Documents: Add some final keywords.
2206 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2209 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2211 OnlineGlomServiceImpl: Add to overview comments.
2213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2214 Note that this is where all the document are loaded. They are not
2215 loaded freshly for each page.
2217 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2221 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2222 Add a TextBox for the text of a quick find.
2223 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2225 setBackLink(): Add a String quickFind parameter.
2226 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2227 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2228 to the base interface, because that is how TableSelectionViewImpl is used.
2229 * src/main/webapp/style.css: Add style for the search box and its label.
2231 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2232 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2233 Add these files, based on the existing TableChangeEvent and
2234 TableChangeEventHandlers.
2235 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2236 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2237 a ListPlace() that the user should be taken to.
2238 * src/main/java/org/glom/web/client/activity/ListActivity.java
2239 start(): Handle it here too and adapt the TableChangeEvent handler to
2240 pass the extra "" quickFind parameter to ListPlace.
2241 * src/main/java/org/glom/web/client/place/ListPlace.java:
2242 Constructor: Take an extra String quickFind parameter and store it,
2243 returning it from a new getQuickFind() method.
2244 getToken(): Put the quickFind text in the URL token.
2245 getPlace(): Parse the quickFind text from the URL token.
2246 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2247 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2248 ListPlace constructor.
2249 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2250 .java: start(): Add a Change handler for the TableSelectionView's
2251 TextBox (via its base HasChangeHandlers interface), firing the new
2252 QuickFindChangeEvent.
2253 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2254 pass the extra "" quickFind parameter.
2256 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2257 setCellTable(): Add a String quickFind parameter and pass it to
2258 the ListViewTable() constructor.
2259 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2260 setCellTable() in the base interface, because that is how ListViewImpl
2263 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2264 Add a String quickFind member variable.
2265 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2266 Constructor: Add a String quickFind parameter, storing it in the
2267 base ListTable's member variable.
2268 onRangeChanged(): Pass quickFind to the
2269 OnlineGlomServiceAsync.getSortedListViewData() and
2270 OnlineGlomServiceAsync.getListViewData() methods.
2272 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2273 getListViewData(), getSortedListViewData(): Add a String quickFind
2274 parameter, passing it to ConfiguredDocument.getListViewData().
2275 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2276 Change getListViewData(), getSortedListViewData() in the base interface,
2277 because that is how OnlineGlomServiceImpl is used, via this:
2278 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2279 Change getListViewData(), getSortedListViewData() here too.
2280 This class can apparently be used to asynchronously call methods on
2281 OnlineGlomService, and GWT seems to implement that after recognizing
2282 just the *Async name convention and the extra AsyncCallback parameters.
2284 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2285 getListViewData(): Add a String quickFind parameter, and pass it to
2286 ListViewDBAccess.getData().
2287 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2288 getListData(): Add a String quickFind parameter and pass it to
2290 getSelectQuery(): Add a String quickFind parameter.
2291 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2292 getSelectQuery(): Add a String quickFind parameter and use it with
2293 Glom.get_find_where_clause_quick() to pass a where_clause to
2294 Glom.build_sql_select_with_where_clause(), to actually filter the
2296 getData(): Add a String quickFind parameter, passing it to getListData().
2297 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2298 va: getData(): Pass an empty string to getListData() for the
2299 quickFind parameter.
2301 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2303 ListTable: Minor change.
2305 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2306 createCellTable(): Make this protected instead of public.
2308 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2310 Many files: Use final for the parameters and use the @override attribute.
2312 2012-01-22 Ben Konrath <ben@bagu.org>
2314 Add anchor links for single line text that starts with http, ftp and www.
2318 2012-01-22 Ben Konrath <ben@bagu.org>
2320 Add ellipsis to single line text in details view.
2324 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2326 Remove all javadoc author tags.
2328 Because they are awkward and meaningless when many people touch
2330 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2332 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2334 Revert the COPYING.LESSER to COPYING rename.
2336 Apparently both should be there if it is LGPL.
2338 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2340 *View: Remove unused imports.
2342 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2343 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2344 * src/main/java/org/glom/web/client/ui/ListView.java:
2345 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2346 Remove unused imports, as suggested by Eclipse.
2348 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2350 Move the *View::Presenter types, and some API into one base View.
2352 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2353 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2354 * src/main/java/org/glom/web/client/ui/ListView.java:
2355 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2356 Presenter, setPresenter() and clear() into a shared base interface,
2357 to avoid the unnecessary duplicate Presenter types and to more clearly
2358 show how the *Views share the same structure, even if they are not
2359 used polymorphically.
2361 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2362 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2364 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2365 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2366 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2368 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2371 Feel free to revert this if there is a good reason for the duplicate
2374 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2376 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2378 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2379 a class member instead of a local variable in the method.
2380 This lets us use it to get the view instances, for use in tests.
2381 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2382 beforeOnlineGlom(): Test some more details of the initial view.
2383 Again, this is not very useful.
2385 To really test gwt-glom we will need to start a local postgresql
2386 instance with local data, like the Glom tests in C++.
2388 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2390 pom.xml: Mention the LGPL license.
2392 * pom.xml: Add a licenses section.
2393 * COPYING.LESSER: Move this to COPYING, which
2394 previously contained the GPL. But gwt-glom is all LGPL.
2396 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2398 Add project information to README and pom.xml.
2400 * README: Add a brief description and mention some mvn
2402 * pom.xml: This extra information shows up in mvn site
2405 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2407 Use the latest java-libglom version.
2409 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2411 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2413 GwtTestOnlineGlom: Test a little more.
2415 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2416 protected rather than private, as suggested by the gwt-test-utils
2418 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2419 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2420 Test the initial visibility of the panels.
2422 However, this is not a very useful test.
2423 And I wonder how we should generally test using this idea for an
2424 activity/places app like ours where the real changes happen implicitly
2425 based on the history token/URL.
2427 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2429 Slight modification to *Mapper comments.
2431 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2432 (DataActivityMapper)
2433 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2435 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2437 Remove comments mentioning GIN because they are just copied from
2438 the example code and are apparently not helpful:
2439 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2440 Also change the mention of a class that is only in the example code.
2442 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2444 GwtTestOnlineGlom test: Minor changes.
2446 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2447 Avoid the long qualified class name and modify the comment
2448 because it is now obvious to me that the mocked class is the only
2449 custom one created via GWT.create().
2451 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2453 Tests: Added the beginnings of a test using gwt-test-utils.
2455 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2456 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2457 which tells gwt-test-utils what class will be tested.
2458 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2459 Add a simple (but empty) test case. One class, used by the OnlineGlom
2460 class, is mocked so that it can be created. However, I am not sure
2461 why only this class needs to be mocked.
2463 Note that mockito seems more popular, and clearer, than easymock,
2464 but I have not got that working yet. It might be a matter of the
2467 This test is run during mvn integration-test.
2469 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2471 Tests: Use junit4-style syntax instead of junit3-style.
2473 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2474 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2475 * src/test/java/org/glom/web/shared/DataItemTest.java:
2476 Use the @Test annotation rather than relying on the test*() prefix.
2477 Also no longer implement TestCase, to avoid triggering support for
2478 the junit3-way, which stops the annotations from working.
2479 Change the imports from import junit.framework.* to
2480 import org.junit.*, which is apparently the new way.
2482 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2484 Added a test for ListPlace token parsing and creation.
2486 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2487 This is much the same as DetailsPlaceTest.
2489 I wonder how we could test the other parts of the *Place API.
2491 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2493 DetailsPlace test: Also test getToken() and recreation via getPlace().
2495 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2496 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2497 recreate it, testing the recreated DetailsPlace for the same parameter
2500 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2502 Use the surefire-report plugin.
2504 * pom.xml: This generates a HTML report about the tests in
2505 target/site/surefire-report.html
2506 when you do mvn surefire-report:report. It seems to be popular/normal.
2508 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2510 Added a test for DetailsPlace.
2512 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2513 Test the getPlace() token parsing.
2515 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2517 Added a first unit test.
2519 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2520 * src/test/java/org/glom/web/shared/DataItemTest.java:
2521 This is a silly test but it is just to get things started. Note that
2522 maven/junit finds the test because it looks in src/test by default.
2524 2011-12-22 Ben Konrath <ben@bagu.org>
2526 Change charsetName to "UTF-8" when replacing line breaks.
2528 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2529 that work in Java (such as "UTF8") will not work when compiled to
2532 This fixes a problem with multi-line details view fields that have hard
2533 line breaks. The "License Text" field on this page demonstrates the
2536 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2538 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2540 2011-12-22 Ben Konrath <ben@bagu.org>
2542 Fix another bug with related list navigation.
2544 I've tested all the navigation buttons in all of the related lists
2545 so things should be good now.
2547 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2549 2011-12-22 Ben Konrath <ben@bagu.org>
2551 Fix a crasher when refreshing the list view with the default table.
2553 This crash will also happen when loading the list view with the default
2554 table from a link or bookmark.
2556 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2557 to the main document selection page when the document id hasn't been
2559 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2560 the main document selection page when the document id hasn't been
2562 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2563 values for the details place when the document id hasn't been set.
2564 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2565 values for the list place when the document id hasn't been set.
2567 2011-12-21 Ben Konrath <ben@bagu.org>
2569 Protect against NPE when glom.document.locale is not in config.
2571 This patch protects against an NPE when glom.document.locale is not in
2572 the config file. This NPE will also happen if glom.document.locale is
2575 The patch also updates the error message to display the class name when
2576 the getMessage() returns null. This was happening when the NPE was
2577 thrown and I had "Configuration Error: null". If an NPE is encountered
2578 with this patch, "Configuration Error: NullPointerException " will be
2581 This commit closes this bug:
2583 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2585 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2587 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2589 Rename onlineglom.properties to onlineglom.properties.sample.
2591 * src/main/resources/onlineglom.properties: Rename to:
2592 * src/main/resources/onlineglom.properties.sample:
2593 * src/main/resources/README: And add this file explaining that people
2594 should rename it back when deploying.
2596 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2598 Allow choosing the translation in the .properties file.
2600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2601 init(): Read a glom.document.locale value from the configuration file
2602 and call Glom's TransatableItem::set_current_locale() method.
2603 * src/main/resources/onlineglom.properties: Add a commented-out
2604 example of this new setting.
2606 It would be better to add &lang=de_DE to the URL, but the current
2607 libglom API does not allow us to do this easily. I am working on that.
2609 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2611 Avoid a crash in parsing of token parameters.
2613 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2614 ava: getTokenParams(): Do not crash if a parameter has a key but no
2615 value, and ignore parameters with neither.
2617 2011-12-17 Murray Cumming <murrayc@murayc.com>
2619 History token building/handling: Improve use of token parameters.
2621 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2622 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2623 and buildParamsToken(HashMap), for use by derived classes.
2624 Make the separator private because it is no longer be needed.
2625 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2626 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2627 instead of manual string concatenation.
2628 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2629 of hardcoded indices and awkward splitting code.
2630 * src/main/java/org/glom/web/client/place/ListPlace.java
2631 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2632 instead of manual string concatenation.
2633 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2634 of hardcoded indices and awkward splitting code.
2635 This should fix bug #666420
2637 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2639 Fix a Navgiation->Navigation typo in the code.
2641 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2642 Rename processNavgiation() to processNavigation().
2644 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2646 Fix a seperator->separator typo in the code.
2648 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2649 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2650 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2653 2011-12-15 Ben Konrath <ben@bagu.org>
2655 Cleanup some comments.
2657 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2659 2011-12-14 Ben Konrath <ben@bagu.org>
2661 Replace \n with <br/> for multiline text in the details view.
2663 Vertical scrollbars are added when needed as well.
2665 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2667 2011-12-14 Ben Konrath <ben@bagu.org>
2669 Specify the font for document selection links.
2671 * src/main/webapp/style.css:
2673 2011-12-14 Ben Konrath <ben@bagu.org>
2675 Fix bouncy CellTable while paging.
2677 This doesn't currently work with related list tables in unselected
2680 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2682 2011-12-14 Ben Konrath <ben@bagu.org>
2684 Revamp the appearance of the document selection page.
2686 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2687 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2688 * src/main/webapp/style.css:
2690 2011-12-13 Ben Konrath <ben@bagu.org>
2692 Set navigation button column to the smallest size possible.
2694 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2696 2011-12-13 Ben Konrath <ben@bagu.org>
2698 Change OpenButton nomenclature to NavigationButton.
2700 Using NavigtionButton makes things more generic. Classes, methods and
2701 variables have been changed.
2703 This is a rename-only refactor.
2705 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2706 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2707 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2708 Renamed from OpenButtonCell.
2709 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2710 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2711 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2713 2011-12-12 Ben Konrath <ben@bagu.org>
2715 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2717 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2718 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2719 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2720 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2722 2011-12-12 Ben Konrath <ben@bagu.org>
2724 Update variable names and comments.
2726 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2727 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2729 2011-12-12 Ben Konrath <ben@bagu.org>
2731 Properly initialize numNonEmptyRows variable to zero.
2733 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2734 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2736 2011-12-05 Ben Konrath <ben@bagu.org>
2738 Add latest mockup with HTML tables.
2740 Features of this mockup:
2742 -> HTML table for flowtable
2743 -> HTML table for flowtable column
2744 -> Example of how related lists would look
2745 -> Not using text entries for data items
2747 The current version of Online Glom doesn't use HTML tables for the
2750 This mockup has been sent to the glom-devel mailing list but it's good
2751 to have it here as well.
2753 * mockups/details-view-html-tables.html:
2755 2011-12-05 Ben Konrath <ben@bagu.org>
2757 Remove unnecessary getPrimaryKeyField() method.
2759 getPrimaryKeyFieldForTable(String) has been renamed to
2760 getPrimaryKeyField(String).
2762 * src/main/java/org/glom/web/server/database/DBAccess.java:
2763 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2764 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2766 2011-12-05 Ben Konrath <ben@bagu.org>
2768 Add string representation of TypedDataItem value to conversion error message.
2770 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2771 message was extracted into its own method to avoid duplication.
2773 2011-12-05 Ben Konrath <ben@bagu.org>
2775 Add type checking to navigation primary key value creation.
2777 Create navigation primary key only if the expected type from the Glom
2778 document matches the type returned by the SQL query.
2780 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2782 2011-12-05 Ben Konrath <ben@bagu.org>
2784 Rename a couple of variables in RelatedListNavigation.
2786 This is a rename-only refactor.
2788 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2790 2011-12-05 Ben Konrath <ben@bagu.org>
2792 Move getListLayoutGroup() into getListViewLayoutGroup().
2794 This removes getListLayoutGroup(). It was only being called by
2795 getListViewLayoutGroup().
2797 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2799 2011-12-05 Ben Konrath <ben@bagu.org>
2801 Remove check for LayoutItem_Portal in list table method.
2803 This check is no longer necessary because the method isn't being used
2804 to create the LayoutItemPortal DTO.
2806 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2808 2011-12-05 Ben Konrath <ben@bagu.org>
2810 Properly support related list navigation.
2812 Navigation from the "Repository Analyzer -> Package Scans ->
2813 Dependencies" related table wasn't working because the primary key for
2814 related tables wasn't being set properly. This commit fixes the
2817 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2818 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2819 doesn't set the primary key properly for related list tables.
2820 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2821 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2822 useful for getting the primary key for list view tables and for related
2824 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2825 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2826 Move code to set the primary key for the table from the abstract
2827 ListDBAccess class to ListViewDBAccess as it's only correct for list
2829 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2830 Properly add primary key to related list tables.
2832 2011-12-02 Ben Konrath <ben@bagu.org>
2834 Properly set the horizontal alignment of fields.
2836 This fix is for both the list tables and the details view.
2838 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2839 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2840 to set the horizontal alignment of fields.
2842 2011-12-02 Ben Konrath <ben@bagu.org>
2844 Display currency codes in the details view.
2846 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2848 2011-12-02 Ben Konrath <ben@bagu.org>
2850 Avoid duplicate JNI call.
2852 JNI is not as efficient as pure Java and this is an easy (and small)
2855 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2856 Use previously retrieved value for whereClauseToTableName instead of
2859 2011-12-02 Ben Konrath <ben@bagu.org>
2861 Rename a couple of variables in RelatedListNavigation.
2863 This is a rename-only refactor.
2865 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2867 2011-12-02 Ben Konrath <ben@bagu.org>
2869 Indicate clearly that a mismatched primary key type is a bug.
2871 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2872 warning to error. Add 'This is a bug.' to message.
2874 2011-12-02 Ben Konrath <ben@bagu.org>
2876 Update / fix some comments.
2878 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2880 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2882 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2883 Fix comments. Add some TODOs.
2885 2011-12-02 Ben Konrath <ben@bagu.org>
2887 Enable navigation to details view with string primary key from related list.
2889 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2890 Create a text primary key value when return type of result is
2891 java.sql.Types.VARCHAR.
2893 2011-12-02 Ben Konrath <ben@bagu.org>
2895 Use checkboxes for booleans in the details view.
2897 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2899 2011-12-01 Ben Konrath <ben@bagu.org>
2901 Improve performance of related list height calculation.
2903 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2904 Put code to calculate the expected height in a static initializer so
2905 that that it's only called once.
2907 2011-12-01 Ben Konrath <ben@bagu.org>
2909 Show related list tables in notebooks (again).
2911 Calculate the height of the related list tables so the Notebook can be
2912 set the correct height. The height of the related list table is also needed by
2913 FlowTable to be able decide how to create the layout.
2915 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2916 and set the Portal height based on the height of the related list
2917 table and the Portal container.
2918 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2919 Add method to calculate the height of the related list tables.
2920 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2921 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2922 calculate the height of the Pager widget.
2924 2011-12-01 Ben Konrath <ben@bagu.org>
2926 Use CellTable API for table property instead of setting style on Element.
2928 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2930 2011-12-01 Ben Konrath <ben@bagu.org>
2932 Make ListViewTable and RelatedListTable a consistent height.
2934 The tables are now a consistent height regardless of the contents of
2935 the table. A hidden button is added to empty rows to ensure that the
2936 height of these rows will match the height of rows with data.
2938 A navigation button column is now added to every table. The width of
2939 the navigation column is set to 0px when a RelatedListTable shouldn't
2940 have navigation buttons. This maintains the a consistent row height in
2941 tables that don't show the navigation buttons.
2943 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2944 navigation column when not needed.
2945 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2946 arguments for navigation button to constructor of ListViewTable.
2947 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2948 hidden button for empty data rows.
2949 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2950 arguments for navigation button to constructor.
2951 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2952 create navigation buttons. Add hideNavigationButtons() method.
2953 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2954 arguments for navigation button to constructor.
2956 2011-12-01 Ben Konrath <ben@bagu.org>
2958 Use 'visibility: hidden' in Utils.getWidgetHeight().
2960 This is better choice because hidden elements are invisible, don't
2961 respond to events and are not part of the tab order. They will,