1 2012-05-07 Murray Cumming <murrayc@murrayc.com>
3 Portals: some corrections.
5 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
7 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
8 constructor: Use getRelationshipNameUsed() instead of getName(), because
10 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
11 getFromField(): Fix a typo, to get the field name, not the table name.
12 * src/main/java/org/glom/web/server/database/DBAccess.java:
13 getPortal(): Fix a typo that stopped this from working.
15 2012-05-07 Murray Cumming <murrayc@murrayc.com>
17 LayoutItemPortal: Also override getTitleOriginal().
19 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
20 This lets the base getTitle() with no parameters work.
21 TODO: Test this properly.
23 2012-05-06 Murray Cumming <murrayc@murrayc.com>
25 LayoutItemPortal: getTitle*(): Use the relationship title.
27 2012-05-06 Murray Cumming <murrayc@murrayc.com>
29 LayoutItemField: Fix loading of custom titles.
31 * src/main/java/org/glom/web/server/libglom/Document.java
32 loadDataLayoutItemField(): The title, if any, instead of the field
33 title, is stored in a title_custom node. Load it from there.
34 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
36 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
37 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
38 getTitle*() overrides.
39 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
42 2012-05-06 Murray Cumming <murrayc@murrayc.com>
44 LayoutItemField: Fall back to field titles, so some are really shown.
46 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
47 Override getTitleOriginal() and getTitle(), as in java-libglom.
48 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
51 2012-05-06 Murray Cumming <murrayc@murrayc.com>
53 Correct use of setExpectedResultSize().
55 * src/main/java/org/glom/web/server/ConfiguredDocument.java
56 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
57 Use setExpectedResultSize only on top-level groups (for instance, the
58 list layout) or on child portals (in details views).
59 Use the correct table name for portals to avoid SQL errors.
60 Update the expected counts when returning cached layouts.
62 2012-05-06 Murray Cumming <murrayc@murrayc.com>
64 Document: Interpret no group column count as 1.
66 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
67 default, though we now check for this in the UI code anyway.
69 2012-05-06 Murray Cumming <murrayc@murrayc.com>
73 2012-05-06 Murray Cumming <murrayc@murrayc.com>
75 Translatable: Use Hashmap instead of Treemap because GWT supports it.
77 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
78 The use of Treemap lead to this error from async methods, with no
80 "The response could not be deserialized"
82 2012-05-06 Murray Cumming <murrayc@murrayc.com>
84 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
86 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
87 when using the Google -> GWT Compile, or
88 g toolbar button -> GWT Compile Project... feature in Eclipse.
90 2012-05-06 Murray Cumming <murrayc@murrayc.com>
92 ListTable.addColumn(): Protect against a null Formatting.
94 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
95 Create a default Formatting if it is null, because that is the simplest
98 2012-05-06 Murray Cumming <murrayc@murrayc.com>
100 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
102 * src/main/java/org/glom/web/server/ConfiguredDocument.java
103 updateLayoutGroup(): Check that the field is not null.
105 2012-05-06 Murray Cumming <murrayc@murrayc.com>
107 ListViewImpl: Protected against a bad cast error.
109 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
110 onEnterKeyDown(): Do not cast without an instanceof check.
112 2012-05-06 Murray Cumming <murrayc@murrayc.com>
114 ListTable: Protect against an out of range error.
116 * src/main/java/org/glom/web/client/ui/list/ListTable.java
117 createCellTable(): This is unlikely, but can happen while debugging.
119 2012-05-06 Murray Cumming <murrayc@murrayc.com>
121 AsyncMessage onFailure() callbacks: Log the exception message.
123 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
124 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
125 * src/main/java/org/glom/web/client/activity/ListActivity.java:
126 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
127 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
128 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
129 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
130 These are useful clues when something is wrong.
132 2012-05-06 Murray Cumming <murrayc@murrayc.com>
134 ConfiguredDocument: Avoid a null dereference.
136 * src/main/java/org/glom/web/server/ConfiguredDocument.java
137 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
138 details maps are created.
140 2012-05-06 Murray Cumming <murrayc@murrayc.com>
142 Document: Correct the port number parsing.
144 * src/main/java/org/glom/web/server/libglom/Document.java:
145 This lets us actually connect to the database and show the document.
147 2012-05-05 Murray Cumming <murrayc@murrayc.com>
151 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
152 user-interaction, asking us to load a temporary URL in a browser.s
153 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
154 which is apparently necessary for testing the service. See the comment.
155 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
156 Show the exception, if any. This is how I saw the 404 in the HTML in
159 2012-05-05 Murray Cumming <murrayc@murrayc.com>
161 DocumentTest: Move the .glom files into the resources directory.
163 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
164 URI via getResource().
166 2012-05-05 Murray Cumming <murrayc@murrayc.com>
168 Document: Remove the FieldIdentifies inner class.
170 * src/main/java/org/glom/web/server/libglom/Document.java: We only
171 use the Relationship (though the same function in libglom is maybe
172 used in other ways) and so this removes a compiler warning.
174 2012-05-05 Murray Cumming <murrayc@murrayc.com>
176 Document.load() Remove the error code parameter.
178 * src/main/java/org/glom/web/server/libglom/Document.java: load():
179 Remove the parameter. We do not set it yet and it could never have
180 worked as an output parameter (though maybe it did in java-libglom).
181 We could use an exception if we really want the failure reason.
182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
184 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
185 setUp(), testGetSuitableTableToViewDetails(): Adapt.
187 2012-05-05 Murray Cumming <murrayc@murrayc.com>
189 Make some inner classes static.
191 * src/main/java/org/glom/web/server/ConfiguredDocument.java
192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
193 * src/main/java/org/glom/web/server/ReportGenerator.java
194 * src/main/java/org/glom/web/server/libglom/Document.java
195 Make all inner classes static that can be static.
197 2012-05-05 Murray Cumming <murrayc@murrayc.com>
199 OnlineGlomServiceImpl: Do not load and check for java-libglom.
201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
202 init(): We do not use java-libglom any more.
204 2012-05-05 Murray Cumming <murrayc@murrayc.com>
206 Remove mentions of java-libglom.
208 * README: Remove mention of java-libglom, because it no longer needed.
209 * utils/build-onlineglom-war.sh:
210 * utils/check-and-recover-tomcat.py:
211 * utils/install-onlineglom-war.sh: Remove these as they are no longer
212 useful. Building is now far easier, with no need for jhbuild.
214 2012-05-05 Murray Cumming <murrayc@murrayc.com>
216 Fix the build (mvn package)
218 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
219 (LayoutGroup): Make the LayoutItemList inner class static and protected.
220 Otherwise the GWT Java->Javascript compilation fails with just this
221 error, during mvn package or when attempting to view in a browser,
222 in the GWT developer mode in Eclipse.
224 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
225 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
226 [INFO] Compiling module org.glom.web.OnlineGlom
227 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
228 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
229 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
230 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
231 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
232 [INFO] [ERROR] Cannot proceed due to previous errors
234 It has taken me 2 days to find out what was causing that. After reducing
235 the code, the compiler eventually showed me the full error message.
237 2012-05-04 Murray Cumming <murrayc@murrayc.com>
239 ConfiguredDocument: Cache the cloned and stripped layouts.
241 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
242 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
243 layout in a map, so we can retrieve it again without rebuilding it.
245 2012-05-04 Murray Cumming <murrayc@murrayc.com>
247 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
249 2012-05-04 Murray Cumming <murrayc@murrayc.com>
251 libglom classes: Implement some auto-generated emthods.
253 2012-05-04 Murray Cumming <murrayc@murrayc.com>
255 Add GwtTestOnlineGlomService.
257 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
258 However, this (and the other GwtTest*) does not seem to run during
261 2012-05-04 Murray Cumming <murrayc@murrayc.com>
263 Remove use of unsupported features from client code.
265 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
266 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
267 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
268 Use our client version of StringUtils instead of the apache commons one.
270 However, the GWT Javascript compliation still fails.
272 2012-04-25 Murray Cumming <murrayc@murrayc.com>
274 Add a Field class and implement some loading of it in Document.
276 2012-04-25 Murray Cumming <murrayc@murrayc.com>
278 Initial Document loading implementation, instead of libglom.
280 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
281 and Translatable classes, and adapt the rest of the code to use them.
282 However, this is still missing Layout and Field classes and loading.
284 2012-04-24 Murray Cumming <murrayc@murrayc.com>
286 Use of jOOQ: Move Field creation into a utility method.
288 * src/main/java/org/glom/web/server/SqlUtils.java:
289 This lets us improve it more easily.
291 2012-04-24 Murray Cumming <murrayc@murrayc.com>
293 Use of jOOQ: Improve the code to COUNT a sub-select.
295 * src/main/java/org/glom/web/server/SqlUtils.java:
296 Move initial query creation into
297 build_sql_select_step_with_where_clause().
298 build_sql_select_count_rows(): Use the jOOQ API instead of
299 concatentating text, because a jOOQ Select*Step is a TableLike,
300 which is what from() takes.
302 2012-04-23 Murray Cumming <murrayc@murrayc.com>
304 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
306 * pom.xml: Depend on jooq.
307 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
308 methods with jOOQ, based on the C++ implementations in libglom,
309 with some changes to the logic required by jooQ.
310 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
312 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
313 * src/main/java/org/glom/web/server/ReportGenerator.java:
314 * src/main/java/org/glom/web/server/SqlUtils.java:
315 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
316 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
317 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
318 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
319 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
320 Adapt. In particular, the SqlUtils methods now need to take a Connection,
321 because jOOQ needs that, though it seems unnecessary.
323 This is not quite finished. Ideally jOOQ would help us to build
324 table_name.field_name names, quoting and escaping them properly.
325 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
327 2012-04-21 Murray Cumming <murrayc@murrayc.com>
329 Move use of Glom.build_sql*() into a new SqlUtils class.
331 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
332 to wrap Glom.build_sql*(). The parameter types are still Glom one,
333 but this will make it easier to start using something other than
334 libglom or SqlBuilder.
336 2012-04-21 Murray Cumming <murrayc@murrayc.com>
338 Update the project URL.
340 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
342 2012-04-21 Murray Cumming <murrayc@murrayc.com>
344 Main layout: Use a FlowTable instead of absolute positioning.
346 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
347 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
348 child panels/widgets must have an absolute position. But that is annoying, so
349 this adds a FlowTable and puts the child panels in there.
351 2012-04-21 Murray Cumming <murrayc@murrayc.com>
353 GwtTestOnlineGlom: Comment out unused code.
355 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
356 Eclipse has started to say that some code is unused.
358 2012-04-21 Murray Cumming <murrayc@murrayc.com>
360 Update to the latest versions of dependencies.
362 * pom.xml: Update version numbers of dependencies to the latest
364 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
365 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
366 * src/main/java/org/glom/web/server/ReportGenerator.java:
367 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
368 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
369 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
371 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
372 Modify the imports where necessary.
374 2012-04-17 Murray Cumming <murrayc@murrayc.com>
376 Style: Remove overflow:hidden from searchbox
378 * src/main/webapp/style.css: Because this pushes the Back To Link
379 label/link on to the next row, which is then hidden due to the
380 hard-coded (in ems) height.
382 2012-04-20 Murray Cumming <murrayc@murrayc.com>
384 Remove some duplicate code.
386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
387 getDocumentInfo(): This must have been duplicated during the merge from the
392 2012-04-19 Murray Cumming <murrayc@murrayc.com>
394 Reports: Localize the waiting for report message.
396 * src/main/java/org/glom/web/client/activity/ReportActivity.java
397 start(): Get the message from the contants.
398 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
400 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
401 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
402 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
403 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
404 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
405 Update these files with the English text for newer strings for now.
407 2012-04-19 Murray Cumming <murrayc@murrayc.com>
409 Reports: Show a message while waiting for the report.
411 * src/main/java/org/glom/web/client/ui/ReportView.java
412 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
413 Add setWaitingText(), to show a message saying that we are
414 waiting for the report to be ready.
415 * src/main/java/org/glom/web/client/activity/ReportActivity.java
416 start(): Call setWaitingText() before calling the async
419 2012-04-19 Murray Cumming <murrayc@murrayc.com>
421 ReportGenerator: Specify date and time formats.
423 * src/main/java/org/glom/web/server/ReportGenerator.java:
424 createFieldValueElement(): Use the default (and localized)
425 short formats, though we still need a way to show 4-digit
426 years without providing the format for every locale.
427 * src/main/java/org/glom/web/server/database/DBAccess.java:
428 convertResultSetToDTO(): Use the short formats here too.
430 2012-04-18 Murray Cumming <murrayc@murrayc.com>
432 ReportGenerator: Use the correct numeric formatting.
434 * src/main/java/org/glom/web/server/ReportGenerator.java
435 createFieldExpression(), createFieldValueElement(): Take the
436 whole LayoutItem_Field instead of just the field name, so
437 we have access to the formatting.
438 createFieldValueElement(): Use JRTextField.setPattern() to
439 specify the numeric formatting, with the help of a
440 regular DecimalFormat.
442 2012-04-18 Murray Cumming <murrayc@murrayc.com>
444 ReportGenerator: Avoid showing null for group by titles.
446 * src/main/java/org/glom/web/server/ReportGenerator.java
447 generateReport(): Use setBlankWhenNull() on the field title
448 style too, because this is used for values in group by
451 2012-04-18 Murray Cumming <murrayc@murrayc.com>
453 ReportGenerator: Add a colon to titles in vertical groups.
455 * src/main/java/org/glom/web/server/ReportGenerator.java
456 addFieldToDetailBandVertical(): Pass true for the withColon
459 2012-04-18 Murray Cumming <murrayc@murrayc.com>
461 ReportGenerator: Simplify the code by using Position more.
463 2012-04-18 Murray Cumming <murrayc@murrayc.com>
465 Reports: Support vertical groups, roughly.
467 * src/main/java/org/glom/web/server/ReportGenerator.java:
468 addToReport(): Rename to addGroupToReport() and, if necessary,
469 call the new addVerticalGroupToReport() method.
470 createFieldValueElement(): Let the caller specify the Y position
473 2012-04-17 Murray Cumming <murrayc@murrayc.com>
475 Reports: Allow a second report to be shown.
477 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
478 clear(): Do not remove the HTML widget, which broke the whole layout.
480 2012-04-17 Murray Cumming <murrayc@murrayc.com>
482 Locales drop-down: Show that we use English by default.
484 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
485 fillView(): When we use English, just because that is the default, when
486 no locale is specified, show that in the Locales drop-down instead of
487 just showing the first item.
489 2012-04-17 Murray Cumming <murrayc@murrayc.com>
491 Unselect the Report/Locale/Table combo item when appropriate.
493 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
494 setPlace(): clear reportName if this is not a ReportPlace.
495 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
496 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
497 When the provided name is empty, unselect all items, so that none are
498 indicated. This uses a for loop because I cannot find a single method
501 2012-04-17 Murray Cumming <murrayc@murrayc.com>
503 Report: Give the user a way to get back to the list.
505 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
506 start(), setPlace(): Show the Back To List link on reports, and also
507 interpret selecting the empty report item as back to list.
509 2012-04-13 Murray Cumming <murrayc@murrayc.com>
511 Really show the selected Report name.
513 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
514 setPlace(): Store the reportName here, if it is that kind of Place.
515 fillView(): Set the selected Report after filling the list of reports.
516 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
517 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
518 null Strings, though we need some way to unselect all ListBox items
521 2012-04-13 Murray Cumming <murrayc@murrayc.com>
523 ReportGenerator: Try to avoid some problems.
525 * src/main/java/org/glom/web/server/ReportGenerator.java
526 addField(): Try to avoid duplicates, and avoid using a null
529 2012-04-13 Murray Cumming <murrayc@murrayc.com>
531 Reports: Use quickFind.
533 * src/main/java/org/glom/web/client/OnlineGlomService.java;
534 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
535 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
536 getReportHTML(): Add a quickFind parameter.
537 * src/main/java/org/glom/web/client/activity/ReportActivity.java
538 start(): Pass the quickFind parameter.
539 * src/main/java/org/glom/web/server/ReportGenerator.java
540 generateReport(): Take a quickFind parameter.
542 2012-04-13 Murray Cumming <murrayc@murrayc.com>
544 ReportPlace: Actually use the report name.
546 * src/main/java/org/glom/web/client/place/ReportPlace.java
547 getPlace(): Do not assign the report name to the quickfind.
549 2012-04-13 Murray Cumming <murrayc@murrayc.com>
551 Show java.library.path when complaining.
553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
554 init(): When telling us to check java.library.path, show the
557 2012-03-06 Murray Cumming <murrayc@murrayc.com>
559 ReportGenerator: Do not show nulls.
561 2012-03-06 Murray Cumming <murrayc@murrayc.com>
563 ReportGenerator: Make the title font larger.
565 2012-03-06 Murray Cumming <murrayc@murrayc.com>
567 ReportGenerator: Put field titles inside groups, if there are groups.
569 2012-03-06 Murray Cumming <murrayc@murrayc.com>
571 ReportGenerator: Take the Report itself instead of the name and group.
573 * src/main/java/org/glom/web/server/ConfiguredDocument.java
574 Remove getReportLayoutGroup().
575 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
576 getReportHTML(): Pass the report instead
577 of its name and layout group.
578 * src/main/java/org/glom/web/server/ReportGenerator.java
579 generateReport(): Use the report object to use the title
582 2012-03-06 Murray Cumming <murrayc@murrayc.com>
584 ReportGenerator: Remove designBand parameters.
586 * src/main/java/org/glom/web/server/ReportGenerator.java:
587 Make designBand a class member instead of passing it to all
590 2012-03-06 Murray Cumming <murrayc@murrayc.com>
592 ReportGenerator: Add lines, a bit like in the desktop version.
594 * src/main/java/org/glom/web/server/ReportGenerator.java
595 addToReport(): Use JRDesignLine.
597 2012-03-06 Murray Cumming <murrayc@murrayc.com>
599 ReportGenerator: Correct the title positions and use some bold style.
601 * src/main/java/org/glom/web/server/ReportGenerator.java:
602 Break the code up into reusable functions, correct the placement of
603 titles, and use normal/bold styles as in the reports in the desktop
606 2012-03-06 Murray Cumming <murrayc@murrayc.com>
608 ReportGenerator: Add a header band to show the field titles.
610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
611 getReportHTML(): Pass the localeId to the ReportGenerator
613 * src/main/java/org/glom/web/server/ReportGenerator.java
614 constructor: Take the localeID so we can get translated field
616 generateReport(), addToReport(), addFieldToBand(): Add field
617 titles in a column header band.
619 2012-03-05 Murray Cumming <murrayc@murrayc.com>
621 Reports drop-down list: Some improvement.
623 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
624 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
625 Adedd setSelectedReport(),
626 setReportList(): Add a blank line so that the user can select the
628 * src/main/java/org/glom/web/client/activity/ReportActivity.java
629 start(): Show the current report by calling setSelectedReport().
630 This does not seem to work yet.
632 2012-03-05 Murray Cumming <murrayc@murrayc.com>
634 DetailsActivity, ListActivity: Move some variables into a base class.
636 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
637 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
638 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
639 the clientFactory, documentID, tableName and authenticationPopup into
640 a base class, to avoid duplication.
642 2012-03-05 Murray Cumming <murrayc@murrayc.com>
644 Translate the Reports label.
646 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
647 Get the "Reports" label string from the constants.
648 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
649 perties: Add Reports to the constants.
651 2012-03-05 Murray Cumming <murrayc@murrayc.com>
653 Reports: Implement grouping.
655 * src/main/java/org/glom/web/server/ReportGenerator.java:
656 Handle LayoutItem_GroupBy items and try to do the right thing
657 with JRDesignGroup. It seems to work.
659 2012-03-04 Murray Cumming <murrayc@murrayc.com>
661 Actually show some data with JasperReports.
663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
664 getReportHTML(): Move most code into a ReportGenerator class.
665 * src/main/java/org/glom/web/server/ReportGenerator.java:
666 Recurse into sub-groups, adding fields to the JasperDesign's details
667 band. Note that we must set an arbitrary width and height, or it just
668 will not show any data.
670 2012-03-04 Murray Cumming <murrayc@murrayc.com>
672 Reports Chooser: Show the titles, not the names.
674 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
675 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
676 and the names as the values.
677 * src/main/java/org/glom/web/server/ConfiguredDocument.java
678 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
679 group now that we provide the report name, so it should always
682 2012-02-15 Murray Cumming <murrayc@murrayc.com>
684 Depend on jasperreports.
686 * pom.xml: Add the dependency. My plan is to use this on the
689 2012-01-31 Murray Cumming <murrayc@murrayc.com>
691 Implement navigation to report places.
693 * src/main/java/org/glom/web/client/activity/ReportActivity.java
694 start(): Do not bother to handle all events here.
695 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
696 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
697 Added getSelectedReport().
698 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
699 .java: start(): When handling a change to the reports chooser,
700 call getSelectedReport() and goTo() its ReportPlace.
701 * src/main/java/org/glom/web/client/ui/ReportView.java
702 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
703 Added setReportHTML() which puts the html in a gwt HTML widget.
704 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
705 getReportHTML(): Return "TODO" just to show that this works.
707 2012-01-31 Murray Cumming <murrayc@murrayc.com>
709 Make ReportPlace usable.
711 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
713 * src/main/java/org/glom/web/client/place/ReportPlace.java:
714 Correct the @prefix annotation.
716 2012-01-31 Murray Cumming <murrayc@murrayc.com>
718 OnlineGlomService: Return report HTML rather than the LayoutGroup.
720 * src/main/java/org/glom/web/client/OnlineGlomService.java:
721 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
722 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
723 Change getReportLayout() to getReportHMTL() because we will not need to
724 parse or render the report layout on the client side.
725 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
726 getReportLayout(): Return the libglom LayoutGroup type because we will
727 not need to convert to a shared type, because this will not be used on
729 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
732 Note that there is still no implementation for this.
735 2012-01-27 Murray Cumming <murrayc@murrayc.com>
737 Add a (empty) Report Place, View, and Activity.
739 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
741 * src/main/java/org/glom/web/client/place/HasTablePlace.java
742 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
743 this into a superclass:
744 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
745 and also use it as the base of this new ReportPlace:
746 * src/main/java/org/glom/web/client/place/ReportPlace.java
748 * src/main/java/org/glom/web/client/ui/ReportView.java
749 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
750 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
751 Add these, containing mostly boiler-plate for now.
753 * src/main/java/org/glom/web/client/OnlineGlomService.java
754 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
755 * src/main/java/org/glom/web/server/ConfiguredDocument.java
756 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
757 Add API to get the LayoutGroup for the report.
759 2012-01-23 Murray Cumming <murrayc@murrayc.com>
761 Add and fill a Reports drop-down list box.
763 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
765 * src/main/java/org/glom/web/client/OnlineGlomService.java:
766 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
768 Added getReports(document, table, localeID), calling
769 ConfiguredDocument.getReports().
770 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
771 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
772 Added setReportsList() and a list widget.
773 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
774 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
779 2012-04-12 Murray Cumming <murrayc@murrayc.com>
781 Translations: Add Esperanto.
783 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
784 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
785 properties: Add this translation because someone took the time to make it.
787 2012-03-15 Murray Cumming <murrayc@murrayc.com>
789 Adapt to the java-libglom 1.21.7 API.
791 * src/main/java/org/glom/web/server/ReportGenerator.java:
792 addToReport(): get_group_secondary_fields() is now
793 get_secondary_fields().
796 2012-03-15 Murray Cumming <murrayc@murrayc.com>
798 Use the latest java-libglom version.
800 * pom.xml: Use java-libglom 1.21.7.
802 2012-03-03 Ben Konrath <ben@bagu.org>
804 Display date and time in details view.
806 https://bugzilla.gnome.org/show_bug.cgi?id=671257
808 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
810 2012-03-05 Murray Cumming <murrayc@murrayc.com>
812 Require the latest java-libglom.
814 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
816 2012-03-04 Murray Cumming <murrayc@murrayc.com>
818 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
820 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
821 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
822 an empty quickfind string. I also corrected libglom to create only
823 empty where clauses for empty quickfind strings, but this avoids the
826 2012-02-24 Ben Konrath <ben@bagu.org>
828 Improve the tabs in the Notebook widget.
832 2012-01-30 Murray Cumming <murrayc@murrayc.com>
834 Translations: Try to translate the strings.
836 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
837 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
838 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
839 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
840 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
841 Take the Open translation from GTK+'s .po files.
842 Take the Details translation from Glom's po files.
843 I have added the other strings to Glom so we can get translations that way:
844 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
846 2012-01-27 Murray Cumming <murrayc@murrayc.com>
848 TableSelectionViewImpl: Put the search label and entry in a div.
850 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
851 Put the search widgets in a FlowTable so that the CSS can be used to
852 style them while keeping them together.
853 * src/main/webapp/style.css: Mention the new div.
855 2012-01-27 Murray Cumming <murrayc@murrayc.com>
857 Translate more strings in more locales.
859 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
860 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
861 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
862 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
863 Translate the "Details" and "Open" string too.
865 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
866 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
867 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
868 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
869 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
870 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
871 Add these new locales as placeholders though they currently contain English.
873 2012-01-27 Murray Cumming <murrayc@murrayc.com>
875 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
878 Check the ConfiguredDocument* for null before using it.
880 2012-01-26 Murray Cumming <murrayc@murrayc.com>
882 Tell Eclipse about the generated java files.
884 * .classpath: This lets it find OnlineGlomConstants.java.
885 It would be nice if Eclipse just used the maven build files.
887 2012-01-26 Murray Cumming <murrayc@murrayc.com>
889 Prevent a crash when no locale is specified in the URL.
891 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
892 Avoid returning a null string, obtained from
893 Window.Location.getParameter(). This caused a crash when it was
894 later passed to libglom's API.
895 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
896 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
897 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
898 guard against future null strings.
900 2012-01-26 Murray Cumming <murrayc@murrayc.com>
902 Use the ?locale= query param instead of the &lang= token param.
904 * src/main/java/org/glom/web/client/place/ListPlace.java
905 * src/main/java/org/glom/web/client/place/DetailsPlace.java
906 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
907 Remove the lang token key and value.
909 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
910 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
911 When the user selects a different locale from the chooser, use
912 Window.Location.assign() to change the URL, which then causes a reload.
914 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
915 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
916 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
917 * src/main/java/org/glom/web/client/activity/ListActivity.java
918 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
919 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
920 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
921 * src/main/java/org/glom/web/client/ui/ListView.java:
922 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
924 Remove localeID member variables and method/constructor parameters, instead
925 using Utils.getCurrentLocaleID() when we need a localID to pass to
928 2012-01-26 Murray Cumming <murrayc@murrayc.com>
930 Internationalize the UI strings.
932 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
933 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
934 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
935 because it is unused. Messages are apparently strings that can have
936 parameters, but we do not need that yet, so Contants will be enough for now.
937 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
938 to say that we support the en and de locales.
939 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
940 The original English strings.
941 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
942 Some German translations of the English strings.
943 The i18n goal then uses the .properties file to generate an
944 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
945 returns an implementation that returns the translated strings.
946 The documentation suggests putting these in src/java/*/client/, but it seems
947 best to put it in src/resources/*/client/.
948 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
949 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
950 instead of hard-coding them.
951 Note that we cannot import OnlineGlomConstants because it does not exist yet,
952 but that does not seem to stop the build, though it confuses Eclipse.
954 You can see the translated string by adding ?locale=de to the URL, like so:
955 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
957 2012-01-24 Murray Cumming <murrayc@murrayc.com>
959 Improve null/empty String checks.
961 * pom.xml: Add a dependency on commons-lang, to use
962 org.apache.commons.lang.StringUtils.
963 * src/main/java/org/glom/web/server/ConfiguredDocument.java
964 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
965 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
966 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
967 Use StringUtils.isEmpty().
969 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
970 StringUtils class with a static isEmpty() function because we
971 cannot use org.apache.commons.lang.StringUtils in client-side
972 GWT code because it (apparently) cannot be compiled to javascript.
973 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
974 * src/main/java/org/glom/web/client/activity/ListActivity.java
975 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
976 * src/main/java/org/glom/web/client/place/DetailsPlace.java
977 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
978 * src/main/java/org/glom/web/client/place/ListPlace.java
979 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
980 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
981 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
982 * src/main/java/org/glom/web/client/ui/details/Group.java
983 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
984 our StringUtils.isEmpty() function.
986 2012-01-24 Murray Cumming <murrayc@murrayc.com>
988 Update to the latest java-libglom API.
990 * pom.xml: Require java-libglom 1.21.4.
991 * src/main/java/org/glom/web/server/ConfiguredDocument.java
992 getDocumentInfo(), getListViewLayoutGroup():
993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
995 * src/main/java/org/glom/web/server/database/DBAccess.java
996 getFieldsToShowForSQLQueryAddGroup(),
997 getPrimaryKeyLayoutItemField(): Replace get_database_title()
998 with either get_database_title_original() or
999 get_database_title(localeID).
1001 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1003 ConfiguredDocument: Avoid a null pointer exception.
1005 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1006 Initialize localeID to "" to avoid returning a null String which
1007 causes a crash in java-libglom's swing-generated code.
1009 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1011 Some simple renaming.
1013 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1014 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1015 for localeChooser. This seems more appropriate and is less ambiguous
1016 particularly in the .css file.
1018 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1020 ConfiguredDocument: Rename the localedID private member variable.
1022 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1024 Adapt to the latest java-libglom API from git master.
1026 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1027 libglom now uses only Vector instead of List, which uses add() instead of
1030 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1032 ConfiguredDocument: Rename the localedID private member variable.
1034 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1036 Build a source tarball with mvn assembly:single
1038 * assembly.xml: Add this file.
1039 * pom.xml: Use the maven-assembly-plugin and tell it to use
1040 our assembly.xml file.
1042 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1044 OnlineGlomServiceImpl: Get .glom files recursively.
1046 * pom.xml: Depend on commons-io from org.apache.commons.
1047 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1048 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1049 files recursively, and with the easier filter for the extension.
1050 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1051 simplify that code too.
1053 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1055 README: Mention that you must install java-libglom packages separately.
1057 But then it works, because java-libglom is now in the central maven
1060 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1062 locales drop-down: Show the correct selected locale when the URL changes.
1064 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1065 .java: setPlace(): Move some code into fillView().
1067 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1069 locales drop-down: Do not lose the primary key.
1071 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1072 start(): onLocaleChange(): Pass the current primary key value,
1073 instead of an empty value.
1075 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1077 locales drop-down: Do not lose the drop-down selection.
1079 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1080 .java (TableSelectionActivity.fillView): Set the selected locale
1081 after changing the drop-down items (though we do not really need
1082 to change them just because the locale changes.)
1084 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1086 locales drop-down: Change the tables list when this changes.
1088 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1089 .java: TableSelectionActivity.start(): Move the async table titles
1090 retrieval into a private fillView() method and also call this when
1091 the chosen locale changes.
1092 Note that the document title is not actually translatable yet, but
1093 that is a problem that I should fix soon in libglom.
1095 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1097 Improve the placement of the locales drop-down.
1099 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1100 Put the title and locales drop-down in a div (gwt.FlowTable).
1101 * src/main/webapp/style.css: Add magic css properties to make this work.
1102 Also remove the left margin from the title so that it lines up with the
1105 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1107 locales selector: Show human-readable locale titles.
1109 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1110 getDocumentInfo(): Use java.util.Locale to show a real title of
1111 each locale, in the locale's own language.
1113 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1115 Add a language/locale selector drop-down.
1117 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1118 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1119 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1120 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1121 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1122 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1123 Add a ListBox to show the available locales. Add getLocaleSelector(),
1124 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1125 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1126 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1127 java: Add these classes.
1128 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1129 start(): Fill the locales ListBox. Handle its change event, firing a
1131 setPlace(): Show the selected locale as specified by the URL token.
1132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1133 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1134 Handle LocaleChangeEvent, going to a new *Place with that locale.
1136 The placement of the ListBox is not pretty, and it currently uses the ID
1137 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1141 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1143 Search box: Show the search text from the URL token.
1145 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1146 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1147 Add setQuickFindText().
1148 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1149 .java: setPlace(): Store the queryText if the place is a ListPlace,
1150 and call TableSelectionView.setQuickFindText().
1152 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1154 Allow use of translations via, for instance, &lang=de in the URL.
1156 * pom.xml: Use the unstable java-libglom 1.21 version.
1158 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1159 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1161 init(): Instead of calling TranslatableItem.set_current_locale()
1162 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1163 However, this is only for default locales, which are not needed to
1164 change the locale in the URL.
1165 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1166 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1167 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1168 layout for a particular locale.
1169 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1170 Add get/setDefaultLocaleID().
1171 getDocumentInfo(), getListViewData(), getRelatedListData(),
1172 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1173 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1174 localeID parameter, so we can get the layout for a particular locale.
1176 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1177 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1178 * src/main/java/org/glom/web/client/place/ListPlace.java:
1179 Parse and construct a lang parameter too.
1181 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1182 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1183 passed to subsequent methods and constructors.
1184 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1185 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1186 Store the localeID from the *Place and pass it to other constructors
1187 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1189 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1190 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1191 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1192 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1193 * src/main/java/org/glom/web/client/ui/ListView.java:
1194 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1195 Take localeID parameters and pass them to subsequent constructors and
1196 methods, so that the layout is always retrieved for that locale.
1198 This is rather repetitive.
1200 Note that "" means the original (default) locale of the Glom document,
1201 which is usually English.
1203 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1205 Documents: Remove final keyword to fix startup configuration.
1207 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1208 final keywords on the private member variables because that breaks
1209 the startup, apparently (there are warnings) because it stops them
1210 from being serialized. I added these in the previous commit.
1212 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1214 Documents: Add some final keywords.
1216 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1219 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1221 OnlineGlomServiceImpl: Add to overview comments.
1223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1224 Note that this is where all the document are loaded. They are not
1225 loaded freshly for each page.
1227 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1231 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1232 Add a TextBox for the text of a quick find.
1233 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1235 setBackLink(): Add a String quickFind parameter.
1236 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1237 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1238 to the base interface, because that is how TableSelectionViewImpl is used.
1239 * src/main/webapp/style.css: Add style for the search box and its label.
1241 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1242 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1243 Add these files, based on the existing TableChangeEvent and
1244 TableChangeEventHandlers.
1245 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1246 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1247 a ListPlace() that the user should be taken to.
1248 * src/main/java/org/glom/web/client/activity/ListActivity.java
1249 start(): Handle it here too and adapt the TableChangeEvent handler to
1250 pass the extra "" quickFind parameter to ListPlace.
1251 * src/main/java/org/glom/web/client/place/ListPlace.java:
1252 Constructor: Take an extra String quickFind parameter and store it,
1253 returning it from a new getQuickFind() method.
1254 getToken(): Put the quickFind text in the URL token.
1255 getPlace(): Parse the quickFind text from the URL token.
1256 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1257 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1258 ListPlace constructor.
1259 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1260 .java: start(): Add a Change handler for the TableSelectionView's
1261 TextBox (via its base HasChangeHandlers interface), firing the new
1262 QuickFindChangeEvent.
1263 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1264 pass the extra "" quickFind parameter.
1266 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1267 setCellTable(): Add a String quickFind parameter and pass it to
1268 the ListViewTable() constructor.
1269 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1270 setCellTable() in the base interface, because that is how ListViewImpl
1273 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1274 Add a String quickFind member variable.
1275 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1276 Constructor: Add a String quickFind parameter, storing it in the
1277 base ListTable's member variable.
1278 onRangeChanged(): Pass quickFind to the
1279 OnlineGlomServiceAsync.getSortedListViewData() and
1280 OnlineGlomServiceAsync.getListViewData() methods.
1282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1283 getListViewData(), getSortedListViewData(): Add a String quickFind
1284 parameter, passing it to ConfiguredDocument.getListViewData().
1285 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1286 Change getListViewData(), getSortedListViewData() in the base interface,
1287 because that is how OnlineGlomServiceImpl is used, via this:
1288 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1289 Change getListViewData(), getSortedListViewData() here too.
1290 This class can apparently be used to asynchronously call methods on
1291 OnlineGlomService, and GWT seems to implement that after recognizing
1292 just the *Async name convention and the extra AsyncCallback parameters.
1294 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1295 getListViewData(): Add a String quickFind parameter, and pass it to
1296 ListViewDBAccess.getData().
1297 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1298 getListData(): Add a String quickFind parameter and pass it to
1300 getSelectQuery(): Add a String quickFind parameter.
1301 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1302 getSelectQuery(): Add a String quickFind parameter and use it with
1303 Glom.get_find_where_clause_quick() to pass a where_clause to
1304 Glom.build_sql_select_with_where_clause(), to actually filter the
1306 getData(): Add a String quickFind parameter, passing it to getListData().
1307 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1308 va: getData(): Pass an empty string to getListData() for the
1309 quickFind parameter.
1311 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1313 ListTable: Minor change.
1315 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1316 createCellTable(): Make this protected instead of public.
1318 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1320 Many files: Use final for the parameters and use the @override attribute.
1322 2012-01-22 Ben Konrath <ben@bagu.org>
1324 Add anchor links for single line text that starts with http, ftp and www.
1328 2012-01-22 Ben Konrath <ben@bagu.org>
1330 Add ellipsis to single line text in details view.
1334 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1336 Remove all javadoc author tags.
1338 Because they are awkward and meaningless when many people touch
1340 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1342 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1344 Revert the COPYING.LESSER to COPYING rename.
1346 Apparently both should be there if it is LGPL.
1348 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1350 *View: Remove unused imports.
1352 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1353 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1354 * src/main/java/org/glom/web/client/ui/ListView.java:
1355 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1356 Remove unused imports, as suggested by Eclipse.
1358 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1360 Move the *View::Presenter types, and some API into one base View.
1362 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1363 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1364 * src/main/java/org/glom/web/client/ui/ListView.java:
1365 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1366 Presenter, setPresenter() and clear() into a shared base interface,
1367 to avoid the unnecessary duplicate Presenter types and to more clearly
1368 show how the *Views share the same structure, even if they are not
1369 used polymorphically.
1371 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1372 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1374 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1375 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1376 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1378 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1381 Feel free to revert this if there is a good reason for the duplicate
1384 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1386 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1388 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1389 a class member instead of a local variable in the method.
1390 This lets us use it to get the view instances, for use in tests.
1391 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1392 beforeOnlineGlom(): Test some more details of the initial view.
1393 Again, this is not very useful.
1395 To really test gwt-glom we will need to start a local postgresql
1396 instance with local data, like the Glom tests in C++.
1398 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1400 pom.xml: Mention the LGPL license.
1402 * pom.xml: Add a licenses section.
1403 * COPYING.LESSER: Move this to COPYING, which
1404 previously contained the GPL. But gwt-glom is all LGPL.
1406 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1408 Add project information to README and pom.xml.
1410 * README: Add a brief description and mention some mvn
1412 * pom.xml: This extra information shows up in mvn site
1415 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1417 Use the latest java-libglom version.
1419 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1421 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1423 GwtTestOnlineGlom: Test a little more.
1425 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1426 protected rather than private, as suggested by the gwt-test-utils
1428 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1429 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1430 Test the initial visibility of the panels.
1432 However, this is not a very useful test.
1433 And I wonder how we should generally test using this idea for an
1434 activity/places app like ours where the real changes happen implicitly
1435 based on the history token/URL.
1437 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1439 Slight modification to *Mapper comments.
1441 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1442 (DataActivityMapper)
1443 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1445 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1447 Remove comments mentioning GIN because they are just copied from
1448 the example code and are apparently not helpful:
1449 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1450 Also change the mention of a class that is only in the example code.
1452 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1454 GwtTestOnlineGlom test: Minor changes.
1456 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1457 Avoid the long qualified class name and modify the comment
1458 because it is now obvious to me that the mocked class is the only
1459 custom one created via GWT.create().
1461 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1463 Tests: Added the beginnings of a test using gwt-test-utils.
1465 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1466 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1467 which tells gwt-test-utils what class will be tested.
1468 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1469 Add a simple (but empty) test case. One class, used by the OnlineGlom
1470 class, is mocked so that it can be created. However, I am not sure
1471 why only this class needs to be mocked.
1473 Note that mockito seems more popular, and clearer, than easymock,
1474 but I have not got that working yet. It might be a matter of the
1477 This test is run during mvn integration-test.
1479 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1481 Tests: Use junit4-style syntax instead of junit3-style.
1483 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1484 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1485 * src/test/java/org/glom/web/shared/DataItemTest.java:
1486 Use the @Test annotation rather than relying on the test*() prefix.
1487 Also no longer implement TestCase, to avoid triggering support for
1488 the junit3-way, which stops the annotations from working.
1489 Change the imports from import junit.framework.* to
1490 import org.junit.*, which is apparently the new way.
1492 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1494 Added a test for ListPlace token parsing and creation.
1496 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1497 This is much the same as DetailsPlaceTest.
1499 I wonder how we could test the other parts of the *Place API.
1501 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1503 DetailsPlace test: Also test getToken() and recreation via getPlace().
1505 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1506 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1507 recreate it, testing the recreated DetailsPlace for the same parameter
1510 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1512 Use the surefire-report plugin.
1514 * pom.xml: This generates a HTML report about the tests in
1515 target/site/surefire-report.html
1516 when you do mvn surefire-report:report. It seems to be popular/normal.
1518 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1520 Added a test for DetailsPlace.
1522 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1523 Test the getPlace() token parsing.
1525 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1527 Added a first unit test.
1529 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1530 * src/test/java/org/glom/web/shared/DataItemTest.java:
1531 This is a silly test but it is just to get things started. Note that
1532 maven/junit finds the test because it looks in src/test by default.
1534 2011-12-22 Ben Konrath <ben@bagu.org>
1536 Change charsetName to "UTF-8" when replacing line breaks.
1538 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1539 that work in Java (such as "UTF8") will not work when compiled to
1542 This fixes a problem with multi-line details view fields that have hard
1543 line breaks. The "License Text" field on this page demonstrates the
1546 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1548 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1550 2011-12-22 Ben Konrath <ben@bagu.org>
1552 Fix another bug with related list navigation.
1554 I've tested all the navigation buttons in all of the related lists
1555 so things should be good now.
1557 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1559 2011-12-22 Ben Konrath <ben@bagu.org>
1561 Fix a crasher when refreshing the list view with the default table.
1563 This crash will also happen when loading the list view with the default
1564 table from a link or bookmark.
1566 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1567 to the main document selection page when the document id hasn't been
1569 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1570 the main document selection page when the document id hasn't been
1572 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1573 values for the details place when the document id hasn't been set.
1574 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1575 values for the list place when the document id hasn't been set.
1577 2011-12-21 Ben Konrath <ben@bagu.org>
1579 Protect against NPE when glom.document.locale is not in config.
1581 This patch protects against an NPE when glom.document.locale is not in
1582 the config file. This NPE will also happen if glom.document.locale is
1585 The patch also updates the error message to display the class name when
1586 the getMessage() returns null. This was happening when the NPE was
1587 thrown and I had "Configuration Error: null". If an NPE is encountered
1588 with this patch, "Configuration Error: NullPointerException " will be
1591 This commit closes this bug:
1593 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1597 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1599 Rename onlineglom.properties to onlineglom.properties.sample.
1601 * src/main/resources/onlineglom.properties: Rename to:
1602 * src/main/resources/onlineglom.properties.sample:
1603 * src/main/resources/README: And add this file explaining that people
1604 should rename it back when deploying.
1606 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1608 Allow choosing the translation in the .properties file.
1610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1611 init(): Read a glom.document.locale value from the configuration file
1612 and call Glom's TransatableItem::set_current_locale() method.
1613 * src/main/resources/onlineglom.properties: Add a commented-out
1614 example of this new setting.
1616 It would be better to add &lang=de_DE to the URL, but the current
1617 libglom API does not allow us to do this easily. I am working on that.
1619 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1621 Avoid a crash in parsing of token parameters.
1623 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1624 ava: getTokenParams(): Do not crash if a parameter has a key but no
1625 value, and ignore parameters with neither.
1627 2011-12-17 Murray Cumming <murrayc@murayc.com>
1629 History token building/handling: Improve use of token parameters.
1631 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1632 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1633 and buildParamsToken(HashMap), for use by derived classes.
1634 Make the separator private because it is no longer be needed.
1635 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1636 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1637 instead of manual string concatenation.
1638 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1639 of hardcoded indices and awkward splitting code.
1640 * src/main/java/org/glom/web/client/place/ListPlace.java
1641 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1642 instead of manual string concatenation.
1643 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1644 of hardcoded indices and awkward splitting code.
1645 This should fix bug #666420
1647 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1649 Fix a Navgiation->Navigation typo in the code.
1651 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1652 Rename processNavgiation() to processNavigation().
1654 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1656 Fix a seperator->separator typo in the code.
1658 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1659 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1660 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1663 2011-12-15 Ben Konrath <ben@bagu.org>
1665 Cleanup some comments.
1667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1669 2011-12-14 Ben Konrath <ben@bagu.org>
1671 Replace \n with <br/> for multiline text in the details view.
1673 Vertical scrollbars are added when needed as well.
1675 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1677 2011-12-14 Ben Konrath <ben@bagu.org>
1679 Specify the font for document selection links.
1681 * src/main/webapp/style.css:
1683 2011-12-14 Ben Konrath <ben@bagu.org>
1685 Fix bouncy CellTable while paging.
1687 This doesn't currently work with related list tables in unselected
1690 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1692 2011-12-14 Ben Konrath <ben@bagu.org>
1694 Revamp the appearance of the document selection page.
1696 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1697 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1698 * src/main/webapp/style.css:
1700 2011-12-13 Ben Konrath <ben@bagu.org>
1702 Set navigation button column to the smallest size possible.
1704 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1706 2011-12-13 Ben Konrath <ben@bagu.org>
1708 Change OpenButton nomenclature to NavigationButton.
1710 Using NavigtionButton makes things more generic. Classes, methods and
1711 variables have been changed.
1713 This is a rename-only refactor.
1715 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1716 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1717 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1718 Renamed from OpenButtonCell.
1719 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1720 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1721 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1723 2011-12-12 Ben Konrath <ben@bagu.org>
1725 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1727 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1728 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1729 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1730 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1732 2011-12-12 Ben Konrath <ben@bagu.org>
1734 Update variable names and comments.
1736 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1737 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1739 2011-12-12 Ben Konrath <ben@bagu.org>
1741 Properly initialize numNonEmptyRows variable to zero.
1743 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1744 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1746 2011-12-05 Ben Konrath <ben@bagu.org>
1748 Add latest mockup with HTML tables.
1750 Features of this mockup:
1752 -> HTML table for flowtable
1753 -> HTML table for flowtable column
1754 -> Example of how related lists would look
1755 -> Not using text entries for data items
1757 The current version of Online Glom doesn't use HTML tables for the
1760 This mockup has been sent to the glom-devel mailing list but it's good
1761 to have it here as well.
1763 * mockups/details-view-html-tables.html:
1765 2011-12-05 Ben Konrath <ben@bagu.org>
1767 Remove unnecessary getPrimaryKeyField() method.
1769 getPrimaryKeyFieldForTable(String) has been renamed to
1770 getPrimaryKeyField(String).
1772 * src/main/java/org/glom/web/server/database/DBAccess.java:
1773 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1774 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1776 2011-12-05 Ben Konrath <ben@bagu.org>
1778 Add string representation of TypedDataItem value to conversion error message.
1780 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1781 message was extracted into its own method to avoid duplication.
1783 2011-12-05 Ben Konrath <ben@bagu.org>
1785 Add type checking to navigation primary key value creation.
1787 Create navigation primary key only if the expected type from the Glom
1788 document matches the type returned by the SQL query.
1790 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1792 2011-12-05 Ben Konrath <ben@bagu.org>
1794 Rename a couple of variables in RelatedListNavigation.
1796 This is a rename-only refactor.
1798 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1800 2011-12-05 Ben Konrath <ben@bagu.org>
1802 Move getListLayoutGroup() into getListViewLayoutGroup().
1804 This removes getListLayoutGroup(). It was only being called by
1805 getListViewLayoutGroup().
1807 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1809 2011-12-05 Ben Konrath <ben@bagu.org>
1811 Remove check for LayoutItem_Portal in list table method.
1813 This check is no longer necessary because the method isn't being used
1814 to create the LayoutItemPortal DTO.
1816 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1818 2011-12-05 Ben Konrath <ben@bagu.org>
1820 Properly support related list navigation.
1822 Navigation from the "Repository Analyzer -> Package Scans ->
1823 Dependencies" related table wasn't working because the primary key for
1824 related tables wasn't being set properly. This commit fixes the
1827 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1828 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1829 doesn't set the primary key properly for related list tables.
1830 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1831 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1832 useful for getting the primary key for list view tables and for related
1834 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1835 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1836 Move code to set the primary key for the table from the abstract
1837 ListDBAccess class to ListViewDBAccess as it's only correct for list
1839 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1840 Properly add primary key to related list tables.
1842 2011-12-02 Ben Konrath <ben@bagu.org>
1844 Properly set the horizontal alignment of fields.
1846 This fix is for both the list tables and the details view.
1848 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1849 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1850 to set the horizontal alignment of fields.
1852 2011-12-02 Ben Konrath <ben@bagu.org>
1854 Display currency codes in the details view.
1856 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1858 2011-12-02 Ben Konrath <ben@bagu.org>
1860 Avoid duplicate JNI call.
1862 JNI is not as efficient as pure Java and this is an easy (and small)
1865 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1866 Use previously retrieved value for whereClauseToTableName instead of
1869 2011-12-02 Ben Konrath <ben@bagu.org>
1871 Rename a couple of variables in RelatedListNavigation.
1873 This is a rename-only refactor.
1875 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1877 2011-12-02 Ben Konrath <ben@bagu.org>
1879 Indicate clearly that a mismatched primary key type is a bug.
1881 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1882 warning to error. Add 'This is a bug.' to message.
1884 2011-12-02 Ben Konrath <ben@bagu.org>
1886 Update / fix some comments.
1888 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1890 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1892 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1893 Fix comments. Add some TODOs.
1895 2011-12-02 Ben Konrath <ben@bagu.org>
1897 Enable navigation to details view with string primary key from related list.
1899 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1900 Create a text primary key value when return type of result is
1901 java.sql.Types.VARCHAR.
1903 2011-12-02 Ben Konrath <ben@bagu.org>
1905 Use checkboxes for booleans in the details view.
1907 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1909 2011-12-01 Ben Konrath <ben@bagu.org>
1911 Improve performance of related list height calculation.
1913 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1914 Put code to calculate the expected height in a static initializer so
1915 that that it's only called once.
1917 2011-12-01 Ben Konrath <ben@bagu.org>
1919 Show related list tables in notebooks (again).
1921 Calculate the height of the related list tables so the Notebook can be
1922 set the correct height. The height of the related list table is also needed by
1923 FlowTable to be able decide how to create the layout.
1925 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1926 and set the Portal height based on the height of the related list
1927 table and the Portal container.
1928 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1929 Add method to calculate the height of the related list tables.
1930 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1931 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1932 calculate the height of the Pager widget.
1934 2011-12-01 Ben Konrath <ben@bagu.org>
1936 Use CellTable API for table property instead of setting style on Element.
1938 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1940 2011-12-01 Ben Konrath <ben@bagu.org>
1942 Make ListViewTable and RelatedListTable a consistent height.
1944 The tables are now a consistent height regardless of the contents of
1945 the table. A hidden button is added to empty rows to ensure that the
1946 height of these rows will match the height of rows with data.
1948 A navigation button column is now added to every table. The width of
1949 the navigation column is set to 0px when a RelatedListTable shouldn't
1950 have navigation buttons. This maintains the a consistent row height in
1951 tables that don't show the navigation buttons.
1953 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1954 navigation column when not needed.
1955 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1956 arguments for navigation button to constructor of ListViewTable.
1957 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1958 hidden button for empty data rows.
1959 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1960 arguments for navigation button to constructor.
1961 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1962 create navigation buttons. Add hideNavigationButtons() method.
1963 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1964 arguments for navigation button to constructor.
1966 2011-12-01 Ben Konrath <ben@bagu.org>
1968 Use 'visibility: hidden' in Utils.getWidgetHeight().
1970 This is better choice because hidden elements are invisible, don't
1971 respond to events and are not part of the tab order. They will,
1972 however, take up space which is required to be able to calculate the
1973 height of the widget.
1975 * src/main/java/org/glom/web/client/Utils.java:
1977 2011-12-01 Ben Konrath <ben@bagu.org>
1979 Use Utils.getWidgetHeight() in FlowTable.
1981 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1983 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1985 2011-12-01 Ben Konrath <ben@bagu.org>
1987 Put the details css class name on the correct table column.
1989 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1991 2011-11-30 Ben Konrath <ben@bagu.org>
1993 Update for java-libglom API change.
1995 The getters and setters on FieldFormatting and NumericFormat were
1996 changed to remove the 'M'.
1998 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2000 2011-11-29 Ben Konrath <ben@bagu.org>
2002 Only allow RelatedListTables in Portals.
2004 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2006 2011-11-29 Ben Konrath <ben@bagu.org>
2008 Only create a contents panel for Portals when title is being set.
2010 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2012 2011-11-29 Ben Konrath <ben@bagu.org>
2014 Set TabLayoutPanel height based on calculated height its widgets.
2016 This is a potential fix for this bug:
2018 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2020 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2022 2011-11-29 Ben Konrath <ben@bagu.org>
2024 Align details field labels and data with the Open buttons.
2026 * src/main/webapp/style.css:
2028 2011-11-29 Ben Konrath <ben@bagu.org>
2030 Remove unnecessary <div> in the Notebook widget.
2032 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2033 method to get container FlowPanel (<div>).
2034 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2035 initWidget() method directly on the TabLayoutPanel widget instead of
2036 Group's container widget.
2038 2011-11-29 Ben Konrath <ben@bagu.org>
2040 Don't add group titles for Portals in Notebooks.
2042 This reverts the previous patch and fixes a bug I introduced with
2043 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2045 * src/main/java/org/glom/web/client/ui/details/Group.java:
2046 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2048 2011-11-28 Ben Konrath <ben@bagu.org>
2050 Remove unused boolean argument in Portal constructor.
2052 Just a code cleanup.
2054 * src/main/java/org/glom/web/client/ui/details/Group.java:
2055 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2057 2011-11-28 Ben Konrath <ben@bagu.org>
2059 Remove hack for glom 1.18 style glom files.
2061 * src/main/java/org/glom/web/client/ui/details/Group.java:
2062 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2063 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2065 2011-11-28 Ben Konrath <ben@bagu.org>
2067 Use Gda Value version of primary key to log result too large error.
2069 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2071 2011-11-28 Ben Konrath <ben@bagu.org>
2073 Don't use TypedDataItem.getText() for Unknown types from the URL.
2075 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2076 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2077 instead of getText().
2078 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2079 String field and getUnknown() method.
2081 2011-11-28 Ben Konrath <ben@bagu.org>
2083 Log an error message when the java-libglom .so is not present.
2085 The error message was being set in the exception but not logged.
2087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2089 2011-11-28 Ben Konrath <ben@bagu.org>
2091 Ignore LayoutItem_CalendarPortals.
2093 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2094 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2096 2011-11-28 Ben Konrath <ben@bagu.org>
2098 Extract method for creating the LayoutItemPortal DTO.
2100 Just breaking the code up into smaller chunks.
2102 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2104 2011-11-28 Ben Konrath <ben@bagu.org>
2108 This should have been added with the refactor. Oops!
2110 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2112 2011-11-28 Ben Konrath <ben@bagu.org>
2114 Create primary key value from URL string using type from Glom document.
2116 See this bug, comments 19 - 25:
2118 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2120 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2121 create a TypeDataItem for the primary key here when loading from a
2122 URL. Show the same string for the primary key value as was received
2123 from the URL string (when loading from a URL).
2124 * src/main/java/org/glom/web/server/Utils.java: Update method for
2125 creating the Gda Value from the TypeDataItem to properly deal with
2126 creating a Gda Value based on the Glom document type for the primary
2127 key value string when loading from a URL.
2128 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2129 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2130 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2131 Update for changed method name.
2133 2011-11-27 Ben Konrath <ben@bagu.org>
2135 Rename PrimaryKeyItem to TypedDataItem.
2137 The name PrimaryKeyItem suggests what the class should be used for.
2138 TypedDataItem is a neutral name that describes the class better.
2140 This is a rename-only refactor.
2142 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2143 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2144 * src/main/java/org/glom/web/client/Utils.java:
2145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2146 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2147 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2148 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2149 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2150 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2152 * src/main/java/org/glom/web/server/Utils.java:
2153 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2154 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2155 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2156 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2158 2011-11-25 Ben Konrath <ben@bagu.org>
2160 Improve Gda Value conversion from PrimaryKeyItem.
2162 The value from the PrimaryKeyItem is only used if its type match the
2163 type from the glom document.
2165 * src/main/java/org/glom/web/server/Utils.java:
2167 2011-11-25 Ben Konrath <ben@bagu.org>
2169 Manually check if the java-liblgom .so is visible to the JVM.
2171 It seems that Tomcat has problems when a static initializer throws an
2172 exception. This check is done before the first method call into
2173 java-libglom so that execution doesn't continue if the .so is not
2176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2178 2011-11-25 Ben Konrath <ben@bagu.org>
2180 Improve browser configuration error messages.
2184 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2186 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2187 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2188 getConfigurationErrorMessage() method.
2189 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2190 Get and display a specific configuration error message when no Glom
2191 documents are found.
2192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2193 Implement getConfigurationErrorMessage() method. Surround configuration
2194 code in the init() method with a try/catch block. This allows the
2195 errors to be caught while keeping the servlet available to retrieve the
2196 configuration error message.
2198 2011-11-25 Ben Konrath <ben@bagu.org>
2200 Don't use Strings to hold primary key values.
2202 The primary key values are now held in a new data object
2203 (PrimaryKeyItem) that holds type information and the primary key value
2204 using the correct type.
2206 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2207 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2209 PrimaryKeyItem instead of String to hold the primary key value.
2210 * src/main/java/org/glom/web/client/Utils.java: Remove
2211 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2212 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2213 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2214 PrimaryKeyItem instead of String to hold the primary key value. Load
2215 document selection page when the documentID has not been set correctly.
2216 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2217 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2219 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2220 Return empty string for URL instead of "null".
2221 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2222 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2223 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2224 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2225 PrimaryKeyItem instead of String to hold primary key values.
2226 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2227 PrimaryKeyValue to a Gda Value.
2228 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2229 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2230 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2231 Replace temporary database access code that uses the PrimaryKeyValue to
2232 Gda Value conversion.
2233 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2234 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2235 PrimaryKeyItem instead of String.
2236 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2237 hold primary key values.
2239 2011-11-24 Ben Konrath <ben@bagu.org>
2241 Use newly added java-libglom API to create queries.
2243 This isn't finished. I still need to stop using Strings for primary key
2244 values in the client code.
2246 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2247 libglom to use fake connections so that retrieving the query string will
2249 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2250 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2251 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2252 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2253 Use the newly added libglom sql methods and classes to create the
2254 query. Add temporary hack to convert primary value strings to Gda
2257 2011-11-23 Ben Konrath <ben@bagu.org>
2259 Don't explicitly set the height of Portals.
2261 See comments 6 - 10 of this bug for details:
2263 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2265 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2267 2011-11-23 Ben Konrath <ben@bagu.org>
2269 Use an HTML table instead of CSS for the FlowTable layout.
2271 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2272 GWT's FlexTable to implement the FlowTable.
2273 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2275 2011-11-18 Ben Konrath <ben@bagu.org>
2277 Add boolean example to HTML table mockup.
2279 * mockups/details-view-html-tables-text-entries.html:
2281 2011-11-17 Ben Konrath <ben@bagu.org>
2283 Ensure the pager buttons are always visible for related lists.
2285 To accomplish this, I've turned off text wrapping in the list view and
2286 related list tables for both the header and data text. The related list
2287 table now has a fixed layout so the it doesn't overflow its container.
2288 This is required to ensure that the cell text is clipped when it
2289 overflows the cell and an ellipsis is added to the right side of the
2290 cell when text is clipped.
2292 A fixed table layout for the related list table in the details view
2293 seems what we want for the details view anyway, so the side-effect is
2296 The ellipsis will only be displayed in Firefox >= 7.
2300 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2302 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2303 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2304 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2306 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2307 Set the 'table-layout: fixed' CSS property to the related list table.
2308 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2309 'white-space: nowrap;' CSS property on both the list view and the
2310 related list tables.
2312 2011-11-16 Ben Konrath <ben@bagu.org>
2314 Rework the fix for empty notebook tab labels.
2316 Setting the empty group titles with its name caused problems for the
2317 details layout. Instead of using libglom's
2318 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2319 to the client when the title is empty. This allows the Notebook to use
2320 the name when the title is empty without affecting anything else.
2322 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2323 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2325 2011-11-16 Ben Konrath <ben@bagu.org>
2327 Set group titles with name when title is empty.
2329 This fixes a problem with an empty notebook tab label in the Lesson
2330 Planner document. The forth tab in the notebook should be "Internet":
2332 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2334 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2335 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2338 2011-11-16 Ben Konrath <ben@bagu.org>
2340 Remove whitespace from the configured username properties.
2342 This assumes that usernames won't have whitespace at the beginning
2343 or end. But I think this is a reasonable assumption.
2345 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2346 String.trim() to remove the whitespace from the username properties.
2348 2011-11-15 Ben Konrath <ben@bagu.org>
2350 Add details view mockup with HTML tables and text entries.
2352 This is from the attachment on this bug:
2354 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2356 * mockups/details-view-html-tables-text-entries.html:
2358 2011-11-15 Ben Konrath <ben@bagu.org>
2360 Add space between the columns of the flow table.
2364 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2366 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2367 space between columns in the flow table.
2369 2011-11-15 Ben Konrath <ben@bagu.org>
2371 Add backup files to the .gitignore.
2373 * .gitignore: Ignore files that end with ~.
2375 2011-11-09 Ben Konrath <ben@bagu.org>
2377 Use latest release of gwt-log.
2379 Gwt-log releases are now being submitted to the maven central
2380 repository so manual installation of the jar is no longer required.
2382 * pom.xml: Update version and groupId of gwt-log dependency.
2384 2011-10-31 Ben Konrath <ben@bagu.org>
2386 Don't use GWT numeric formatting to override the glom currency formatting.
2388 Currencies are now displayed like they are in Glom. See this bug:
2390 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2392 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2394 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2395 currency code to constructor and set it when the cell is rendered.
2396 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2397 currency code to the constructor of the NumericCell.
2399 2011-10-27 Ben Konrath <ben@bagu.org>
2401 Require the latest release of java-libglom (1.17.4).
2405 2011-10-26 Ben Konrath <ben@bagu.org>
2407 Add style to Notebook that matches current theme.
2409 It's not the best style in the world but it's better than the default.
2411 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2412 padding at the bottom of the child widgets.
2413 * src/main/webapp/style.css: Add style for the Notebook.
2415 2011-10-26 Ben Konrath <ben@bagu.org>
2417 Move servlet initialization code to overridden init method.
2419 This is half of the solution to getting proper error messages
2420 displayed when configuration errors occur. Here's the relevant bug:
2422 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2424 The rest of the solution involves surrounding the init method with a
2425 try/catch block and setting a global variable with the error /
2426 exception. A new async method should be created to retrieve and display
2427 the error message / exception.
2429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2430 code from constructor to init method adding exceptions as needed.
2432 2011-10-26 Ben Konrath <ben@bagu.org>
2434 Add script to monitor and restart tomcat if required.
2436 * utils/check-and-recover-tomcat.py: New file.
2438 2011-10-26 Ben Konrath <ben@bagu.org>
2440 Display the correct number of data items in the pager.
2444 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2446 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2447 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2448 The implementation is the same for both tables: Keep track of the
2449 number of non-empty rows and fire and RowCountChangeEvent after the data has
2451 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2452 custom Pager class that subclasses SimplePager to handle displaying
2453 the correct number when empty rows have been added.
2455 2011-10-26 Ben Konrath <ben@bagu.org>
2457 Correct error in previous commit.
2459 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2460 eventBus parameter from listView.setCellTable().
2462 2011-10-26 Ben Konrath <ben@bagu.org>
2464 Fix error in TODO comment.
2466 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2468 2011-10-24 Ben Konrath <ben@bagu.org>
2470 Create Notebook widgets to the details view.
2472 This isn't finished just yet - I still need to create a reasonable
2473 style to match the current theme.
2475 * src/main/java/org/glom/web/client/Utils.java: Add method for
2476 calculating the height of a widget. This is used in the Notebook class.
2477 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2478 new constructor method in Group.
2479 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2480 method for creating child widget that can be used by subclasses
2481 like Notebook. New constructor that allows disabling the group
2482 titles - Notebooks don't set a group title for their child groups.
2483 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2484 to make Notebooks using GWT's TabLayoutPanel.
2485 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2486 constructor that allows disabling the group titles.
2487 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2488 LayoutItemNotebook DTO.
2489 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2490 DTO for Notebooks. It's just an empty class for now but we might need
2491 it to transfer some specific information in the future.
2493 2011-10-21 Ben Konrath <ben@bagu.org>
2495 Add navigation buttons to related list tables.
2497 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2498 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2500 method getSuitableRecordToViewDetails() for getting the table name
2501 and primary key value for related list navigation buttons.
2502 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2503 private cell renderer class to get the navigation information for
2504 related list tables from the server. Extract the navigation
2505 processing code from the details cell navigation and use it for the
2506 related list navigation as well.
2507 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2508 cell renderer class for the details open buttons. This was needed
2509 because the related list navigation buttons and the list view
2510 navigation buttons need to react differently when clicked.
2511 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2512 the onEnterKeyDown() method because it's now overriden in the
2513 subclasses that are specific to the related list tables and the list
2515 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2516 the vertical size a little because the buttons add a bit of vertical
2517 space to table. This is not a perfect solution because the vertical
2518 size of with table fewer than 5 rows will be a little smaller.
2519 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2520 changes in how navigation buttons are handled.
2521 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2522 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2523 database access object.
2524 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2525 to find the portal for a given relationship name from
2526 RelatedListDBAccess. Add method to find a primary key field for a
2528 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2529 Move code to find the portal for a given relationship name to
2531 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2532 New file: database access object for getting the related list
2533 navigation information (the table name and the primary key value).
2534 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2535 DTO for transferring a table name to navigate to and a primary key
2537 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2538 boolean and getter/setter to specifies if the related list should add
2541 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2543 Use the master branch of java-libglom
2545 * pom.xml: Depend on java-libglom 1.19 instead.
2547 This is the master branch. See also the libglom-1-18 branch.
2549 2011-10-11 Ben Konrath <ben@bagu.org>
2551 Enable the open navigation button when the data has been set.
2553 This avoids having active buttons that don't do anything when the data
2556 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2558 2011-10-11 Ben Konrath <ben@bagu.org>
2560 Use IsWidget interface for FlowTableItem.
2562 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2563 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2565 2011-10-11 Ben Konrath <ben@bagu.org>
2567 Remove GWT styling from open button in details view.
2569 There are still some issues with how the details cell is arranged but
2570 this should be made to match Glom 1.20. I'm going to leave fixing this
2571 until I have Glom 1.20 up and running.
2573 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2574 style name on open button.
2575 * src/main/webapp/style.css: Move and edit details-navigation class.
2576 Re-arrange some classes to make them appear in the same order as the
2579 2011-10-07 Ben Konrath <ben@bagu.org>
2581 Update to GWT 2.4.0.
2583 * .gitignore: Ignore new cache directory.
2584 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2585 * pom.xml: Change GWT and maven plugin to 2.4.0.
2586 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2588 * src/main/java/org/glom/web/client/ClientFactory.java:
2589 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2590 * src/main/java/org/glom/web/client/OnlineGlom.java:
2591 Update source for API changes.
2592 * utils/build-onlineglom-war.sh: Remove cache directory before the
2595 2011-10-07 Ben Konrath <ben@bagu.org>
2597 Add navigation buttons in the details view.
2599 This isn't finished but I thought I'd commit what I have as it's a
2600 pretty good start. I still need to:
2602 1. Change the style so that it fits better into the current theme
2603 2. Adjust the details cell to expand as much as possible.
2605 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2606 click handlers to navigation buttons in the DetailsCells. Create a
2607 refreshData() method to get just the data from the server without the
2609 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2610 Update the tableSelector and browser title when the table name
2611 changes without using the tableSelector.
2612 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2613 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2614 getDetailsCells() to getCells(). Update variable names.
2615 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2616 method to set click handler on navigation button. Rename a few
2617 variables. Add navigation buttons where needed.
2618 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2619 variables and methods.
2620 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2621 navigation boolean and navigation table as required in the
2622 LayoutItemField DTO.
2623 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2624 variables for navigation along with getter/setter methods.
2626 2011-10-07 Ben Konrath <ben@bagu.org>
2628 Rename Field to DetailsCell.
2630 This is a refactor-only commit. No functionality has been added or
2633 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2634 Update variable and method names.
2635 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2636 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2637 variable and method names.
2638 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2640 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2641 variable and method names.
2643 2011-10-07 Ben Konrath <ben@bagu.org>
2645 Create separate methods for layout and data the details view.
2647 This is a refactor-only commit. No functionality has been added or
2650 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2651 private methods: setData(), createLayout().
2653 2011-10-07 Ben Konrath <ben@bagu.org>
2655 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2657 This is part of a change to get navigation buttons in the details view
2658 but it should have been done this way from the start.
2660 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2661 for method name change in TableSelectionView.
2662 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2663 Create TableChangeEvent and set the browser title using the
2664 TableSelectionView API.
2665 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2666 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2667 Change getSelectedTable() to getSelectedTableName(). Add
2668 getSelectedTableTitle().
2670 2011-10-07 Ben Konrath <ben@bagu.org>
2672 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2674 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2676 2011-10-07 Ben Konrath <ben@bagu.org>
2678 Update TableChangeEvent to use newTableName naming convention.
2680 This makes the class more consistent with GWT naming conventions.
2682 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2683 Update for method name change in TableChangeEvent.
2684 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2685 for method name change in TableChangeEvent.
2686 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2687 newTableName variable and getter method. Make toDebugString()
2690 2011-09-30 Ben Konrath <ben@bagu.org>
2692 Disable the pager in the list tables when the data row count is less than the minimum.
2694 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2695 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2697 2011-09-30 Ben Konrath <ben@bagu.org>
2699 Add empty rows to the end of related list and list view tables.
2701 I also extracted the cell rendering classes from the ListTable because
2702 the code was becoming a little crazy with all the anonymous inner
2703 classes. My plan is to use these cell rendering classes in the details
2704 view as well so this refactor will be needed for that change.
2706 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2707 set the row count in related list tables if the data has more rows
2708 than the minimum number of rows visible.
2709 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2710 row count in list view tables if the data has more rows than the
2711 minimum number of rows visible.
2712 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2713 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2715 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2716 for rendering TYPE_NUMERIC cells. The code was extracted from the
2718 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2719 class for rendering cells with buttons in list views. The code was
2720 extracted from the ListTable class.
2721 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2722 for rendering TYPE_TEXT cells. The code was extracted from the
2724 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2725 Add empty rows to the end of the data if required. Implement
2726 ListTable.getMinNumVisibleRows().
2727 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2728 cell renderer code to public classes. Return null in
2729 Column.getValue() for empty rows. Add new abstract method:
2730 getMinNumVisibleRows(). Move code to set the row count of the list view
2731 table to ListViewImpl.
2732 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2733 empty rows to the end of the data if required. Implement
2734 ListTable.getMinNumVisibleRows().
2737 2011-09-27 Ben Konrath <ben@bagu.org>
2739 Use GWT.log for client-side debugging statements.
2741 These are optimized out when deployed so I should have used this method
2742 in the first place. These statements will eventually be replaced with some sort
2743 of notification in the browser.
2745 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2746 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2748 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2749 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2751 2011-09-27 Ben Konrath <ben@bagu.org>
2753 Put tableselector on the right, back to list link on right.
2755 The idea is that the table selector is acting like a label for the
2756 currently displayed table so it should be placed below the document title. This
2757 puts the table title in a similar position to where it is in Glom.
2759 * mockups/details-contacts.html:
2760 * mockups/details-projects.html:
2761 * mockups/listview-contacts.html:
2762 * mockups/listview-projects.html:
2763 * mockups/style.css:
2764 Update mockups to match how the interfaces currently look.
2765 * src/main/webapp/style.css: Swap positions of backlink with the table
2766 selector. Add some space on the left side of the table selector to
2767 line things up with the document title.
2769 2011-09-27 Ben Konrath <ben@bagu.org>
2771 Add field colouring to details view.
2773 This change re-works how field colouring works. The colour formatting
2774 information is now set to the client with the layout information instead of
2775 with the data. This eliminates the need to send the same colour strings for
2776 data in list view column when colour information is set.
2778 In order to set an alternate colour for negative numeric values, the
2779 number is now sent to client and formatted with the GWT NumberFormat class.
2781 This change also fixes:
2783 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2785 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2786 internationalization framework which is needed for client side numeric
2788 * src/main/java/org/glom/web/client/Utils.java: New file for some
2789 client static utility methods.
2790 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2791 the DataItem object to the Field class. Use a utility method to
2792 create the foreignKeyValue string.
2793 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2794 alignment and text colours in the constructor. Add setData(DataItem)
2795 method. Remove setText(String) method.
2796 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2797 colour information to GlomTextCell. Create and use GlomNumberCell for
2798 rendering numbers. Use utility method to get the string for the
2799 primary key of the key provider. Re-work how the horizontal alignment
2801 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2802 formatting to layout information. Methods for converting the libglom
2803 formatting information were moved from DBAccess.
2804 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2805 numeric formatting (it's now done on the client side). Don't set text
2806 colours in DataItem. Move libglom formatting conversion methods to
2808 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2809 getters/setters for text colour information.
2810 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2811 for transferring the libglom NumericFormat information to the client.
2812 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2813 and getters/setters for: GlomNumericFormat, background colour and
2814 foreground colour strings.
2816 2011-09-26 Ben Konrath <ben@bagu.org>
2818 Simplify code that iterates through the LayoutGroup.
2820 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2822 2011-09-26 Ben Konrath <ben@bagu.org>
2824 Accept Eclipse formatting for OnlineGlomServiceAsync.
2826 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2828 2011-09-26 Ben Konrath <ben@bagu.org>
2830 Don't use the ListDBAccess classes to get the primary key layout information.
2832 This was causing a bug where the wrong index for the hidden primary key
2833 was being sent to the client.
2835 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2836 primary key while creating the LayoutGroup DTO. Create a
2837 LayoutItemField DTO for hidden primary keys. Don't use the
2838 RelatedListDBAccess because it was only used for getting the primary
2840 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2841 access modifier from public to protected for getPrimaryKeyField() and
2842 getPrimaryKeyLayoutItemField().
2843 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2844 abstract method getExpectedResultSize() because RelatedListDBAccess
2845 doesn't have enough info to implement it.
2846 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2847 Remove @Override for getExpectedResultSize().
2848 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2849 Remove method getExpectedResultSize().
2851 2011-09-23 Ben Konrath <ben@bagu.org>
2853 Log which layout (list or details) the ignored item is from.
2855 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2857 2011-09-23 Ben Konrath <ben@bagu.org>
2859 Remove annotations that turn off code formatting in DataItem.
2861 * src/main/java/org/glom/web/shared/DataItem.java:
2863 2011-09-23 Ben Konrath <ben@bagu.org>
2865 Rename GlomField to DataItem and update associated methods.
2867 This is a rename-only refactor. No functionality has been added or
2870 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2871 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2873 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2874 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2875 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2876 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2877 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2878 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2879 * src/main/java/org/glom/web/server/database/DBAccess.java:
2880 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2881 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2882 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2883 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2884 * src/main/java/org/glom/web/shared/DataItem.java:
2885 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2886 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2888 2011-09-23 Ben Konrath <ben@bagu.org>
2890 Rename GlomDocument to DocumentInfo and update associated methods.
2892 This is a rename-only refactor. No functionality has been added or
2895 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2896 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2897 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2898 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2899 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2900 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2901 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2903 2011-09-20 Ben Konrath <ben@bagu.org>
2905 Require java-libglom 1.17.3.
2907 This picks up the fix for the seg fault problem with the Scenes table
2908 in the Openismus Film Manager example.
2912 2011-09-20 Ben Konrath <ben@bagu.org>
2914 Change the way sort clause is added for primary key when no sort clause is requested.
2916 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2917 before the sort clause is created. When a sort clause is not requested, the
2918 sort clause is created by finding the primary key in the LayoutFieldVector
2921 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2923 2011-09-20 Ben Konrath <ben@bagu.org>
2925 Log error message if no documents are found in the configured directory.
2927 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2928 Extract the glom file extension string to a private static final class
2929 variable (mostly as syntactic sugar). Accept a minor formatting change.
2930 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2931 the example glom.document.directory configuration property to make it
2932 more clear that it can any directory, not just the home directory.
2934 2011-09-18 Ben Konrath <ben@bagu.org>
2936 Add related lists to details view.
2938 The related list table has support for paging and sorting just like the
2939 table in the list view.
2941 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2942 SQL queries for the related list tables.
2943 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2944 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2945 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2946 Rename getList methods to getListView and add comments. Remove
2947 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2948 it being unused. Add methods: getDetailsLayoutAndData(),
2949 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2950 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2951 Create the layout and set the data for the fields in one async call
2952 instead of two. Create related lists where appropriate.
2953 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2954 for method name changes in OnlineGlomService.
2955 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2956 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2957 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2959 * src/main/java/org/glom/web/client/ui/ListView.java:
2960 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2961 tableName from setCellTable(). Create a ListViewTable instead of
2963 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2964 represent a data field in the details view.
2965 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2966 from addDetailsCell() to Field class. Keep track of the Fields and
2967 Portals in the details view.
2968 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2969 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2970 and add a method to get it. Add method to set the contents of the
2972 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2973 New class for related list tables. This class has the data provider
2974 for the related list table.
2975 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2976 abstract class which is the base class for the ListViewTable and the
2978 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2979 New class for list view tables. This class has the data provider for
2980 the list view table.
2981 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2982 methods for related list tables. Add more information to the
2983 LayoutItemField and LayoutItemPortal DTOs.
2984 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2985 Remove debugging print statement.
2986 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2987 Remove debugging print statements. Add primary key field to SQL count
2989 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2990 Remove unnecessary LayoutFieldVector parameter from
2991 getResultSizeOfSQLQuery() method.
2992 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2993 New class for related list table database access.
2994 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2995 class that is a wrapper DTO for details view layout and data.
2996 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2997 new 'fromField' string to this DTO.
2998 * src/main/webapp/style.css: Remove bottom margin and override top
3001 2011-09-15 Ben Konrath <ben@bagu.org>
3003 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3005 This sets things up to make it easier to add the data retrieval for
3006 related lists (portals). No user noticeable changes were made with
3009 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3010 class has the code to retrieve the layouts and access the
3011 database using the new database helper classes.
3012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3013 Most of the functionality has been removed from this class. This
3014 class now represents the public interface for the client side
3015 code. It also deals with configuring the servlet and cleaning
3016 things up when the servlet is stopped.
3017 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3018 of static methods into this utility class.
3019 * src/main/java/org/glom/web/server/database/DBAccess.java:
3020 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3021 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3022 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3023 These classes have the database retrieval code. The class hierarchy
3024 has been setup to make it easy to reuse code for similar
3027 2011-09-06 Ben Konrath <ben@bagu.org>
3029 Create separate classes for list table code and the data provider.
3031 As part of this refactor, I also split up the code a bit to make it
3034 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3035 table code to two new classes (below).
3036 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3037 with code from ListViewImpl.
3038 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3039 New file with code from ListViewImpl.
3041 2011-09-06 Ben Konrath <ben@bagu.org>
3043 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3045 This fixes the LayoutItemPortal DTO to match the libglom layout object
3048 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3050 2011-09-01 Ben Konrath <ben@bagu.org>
3052 Set title of Portals in the Details View.
3054 * pom.xml: Bump required version of java-libglom to 1.17.1.
3055 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3056 widget creation to its own class. Add comments to constructor.
3057 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3058 The code is mostly from the Group class with the title now set.
3059 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3060 title of Portal. Update some comments. Fix some code formatting.
3062 2011-09-01 Ben Konrath <ben@bagu.org>
3064 Remove TODO comment for the flow table column width.
3066 The flow table column width is working correctly and doesn't need to be
3067 changed. See this mailing list post for more info:
3069 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3071 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3073 2011-08-27 Ben Konrath <ben@bagu.org>
3075 Add document title (database name) to top of the browser page.
3077 I added the document title to the TableSelecitonView but that will
3078 change if / when we add a view that doesn't require table selection.
3080 * mockups/details-contacts.html:
3081 * mockups/details-projects.html:
3082 * mockups/listview-contacts.html:
3083 * mockups/listview-projects.html:
3084 * mockups/style.css: Add document title to mockups to keep things
3086 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3087 sizes to account for the document title.
3088 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3089 Set the document title when it has been retrieved from the server.
3090 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3091 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3092 and implement setDocumentTitle(String) method.
3093 * src/main/webapp/style.css: Add ID for document title style.
3095 2011-08-25 Ben Konrath <ben@bagu.org>
3097 Add NavigationType enum to LayoutItemPortal DTO.
3099 This is the start of adding support for Portals to the Details View.
3101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3102 LayoutItem_Portal.navigation_type enum from libglom to
3103 LayoutItemPortal.NavigationType enum.
3104 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3105 NavigationType enum, field for storing the NavigationType and getter
3108 2011-08-25 Ben Konrath <ben@bagu.org>
3110 Implement the flow table layout in the Details View.
3112 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3113 FlowTable to Group to account for the renamed class.
3114 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3115 File. This is a container widget that implements the Glom details view
3116 flow table behaviour.
3117 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3118 org/glom/web/client/ui/FlowTable.java.
3119 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3120 so that the size of the subgroups are a closer match to the size of
3121 the Glom subgroups. This makes the flowtable layout match the layout
3122 in Glom for the Music Collection example file.
3124 2011-08-16 Ben Konrath <ben@bagu.org>
3126 Create container element for LayoutItemPortal in Details View.
3128 This will help me develop the layout for the FlowTable.
3130 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3131 fieldPanel variable to detailsCell.
3133 2011-08-15 Ben Konrath <ben@bagu.org>
3135 Set the height of the data element in the Details View.
3137 I changed the InlineLabels (text in a span element) to Labels (text in
3138 a div element) so that I could set the height of the details-data
3139 elements instead of the details-cell parent elements. This allows the
3140 the details-data element to display the correct height if style is
3141 applied that shows the height.
3143 This change has the added benefit of allowing the order of the labels
3144 and data elements to be changed for right-to-left languages.
3146 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3147 InlineLabels to Labels.
3148 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3149 InlineLabels to Labels. Set the height of the data element.
3150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3151 multiline text height in the Formatting DTO.
3152 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3153 for multiline height along with getter and setter methods.
3154 * src/main/webapp/style.css: Adjust style to account for the change
3155 from span elements to div elements in the details cell.
3157 2011-08-15 Ben Konrath <ben@bagu.org>
3159 Make the List View appearance match the mockups.
3161 It doesn't match exactly but it's much better than it was.
3163 * mockups/listview-contacts.html: Remove unused css classes.
3164 * mockups/listview-projects.html: Remove unused css classes.
3165 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3166 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3167 for mainPanel instead of VerticalPanel (table). Set style name on
3168 CellTable. Set style name on Details column. Right-align Details
3170 * src/main/webapp/style.css: Adjust properties to match the mockups.
3172 2011-08-12 Ben Konrath <ben@bagu.org>
3174 Add better support for subgroups in the details view.
3176 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3177 changed FlowTable constructor.
3178 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3179 support for subgroups and subgroup-titles.
3180 * src/main/webapp/style.css: Add CSS class for subgroups and
3183 2011-08-12 Ben Konrath <ben@bagu.org>
3185 Return the top level LayoutGroup title.
3187 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3189 2011-08-11 Ben Konrath <ben@bagu.org>
3191 Make the TableSelector header match the mockup.
3193 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3194 the layout panel. Properly lineup the table selection header with
3195 the list and details view.
3196 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3197 margin around the details view.
3198 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3199 Rename listBox variable to tableSelector. Set id for the style sheet.
3200 Use a FlowPanel instead of a HorizontalPanel.
3201 * src/main/webapp/style.css: Add properties to make the TableSelector
3202 box match the mockups.
3204 2011-07-13 Ben Konrath <ben@bagu.org>
3206 Update install script for java-libglom version change.
3208 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3211 2011-07-13 Ben Konrath <ben@bagu.org>
3213 Add support sub-group in the details view.
3215 I also removed the code that special-cased the default details view
3218 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3220 I still have to make a proper flowtable.
3222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3223 Don't special-case default details view layout.
3224 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3225 addLayoutField() as I'm going to use it.
3226 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3227 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3229 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3230 extracted from DetailsViewImpl.GroupPanel. Add support for
3232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3233 column count when getting the details layout.
3235 2011-07-12 Ben Konrath <ben@bagu.org>
3237 Set browser title with database and table titles.
3239 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3240 Set the browser title when the table changes and when the activity
3242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3243 title when retrieving document info (the GlomDocument object).
3244 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3245 with getter and setter methods. Remove unused convenience constructor.
3246 Use default code formatting.
3248 2011-07-12 Ben Konrath <ben@bagu.org>
3250 Ignore LayoutItemPortals in the details view.
3252 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3255 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3256 LayoutItemPortal layout objects.
3257 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create