1 2012-02-24 Ben Konrath <ben@bagu.org>
3 Improve the tabs in the Notebook widget.
7 2012-02-15 Murray Cumming <murrayc@murrayc.com>
9 Depend on jasperreports.
11 * pom.xml: Add the dependency. My plan is to use this on the
14 2012-01-31 Murray Cumming <murrayc@murrayc.com>
16 Implement navigation to report places.
18 * src/main/java/org/glom/web/client/activity/ReportActivity.java
19 start(): Do not bother to handle all events here.
20 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
21 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
22 Added getSelectedReport().
23 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
24 .java: start(): When handling a change to the reports chooser,
25 call getSelectedReport() and goTo() its ReportPlace.
26 * src/main/java/org/glom/web/client/ui/ReportView.java
27 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
28 Added setReportHTML() which puts the html in a gwt HTML widget.
29 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
30 getReportHTML(): Return "TODO" just to show that this works.
32 2012-01-31 Murray Cumming <murrayc@murrayc.com>
34 Make ReportPlace usable.
36 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
38 * src/main/java/org/glom/web/client/place/ReportPlace.java:
39 Correct the @prefix annotation.
41 2012-01-31 Murray Cumming <murrayc@murrayc.com>
43 OnlineGlomService: Return report HTML rather than the LayoutGroup.
45 * src/main/java/org/glom/web/client/OnlineGlomService.java:
46 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
47 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
48 Change getReportLayout() to getReportHMTL() because we will not need to
49 parse or render the report layout on the client side.
50 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
51 getReportLayout(): Return the libglom LayoutGroup type because we will
52 not need to convert to a shared type, because this will not be used on
54 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
57 Note that there is still no implementation for this.
59 2012-01-30 Murray Cumming <murrayc@murrayc.com>
61 Translations: Try to translate the strings.
63 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
64 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
65 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
66 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
67 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
68 Take the Open translation from GTK+'s .po files.
69 Take the Details translation from Glom's po files.
70 I have added the other strings to Glom so we can get translations that way:
71 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
73 2012-01-27 Murray Cumming <murrayc@murrayc.com>
75 Add a (empty) Report Place, View, and Activity.
77 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
79 * src/main/java/org/glom/web/client/place/HasTablePlace.java
80 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
81 this into a superclass:
82 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
83 and also use it as the base of this new ReportPlace:
84 * src/main/java/org/glom/web/client/place/ReportPlace.java
86 * src/main/java/org/glom/web/client/ui/ReportView.java
87 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
88 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
89 Add these, containing mostly boiler-plate for now.
91 * src/main/java/org/glom/web/client/OnlineGlomService.java
92 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
93 * src/main/java/org/glom/web/server/ConfiguredDocument.java
94 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
95 Add API to get the LayoutGroup for the report.
97 2012-01-27 Murray Cumming <murrayc@murrayc.com>
99 TableSelectionViewImpl: Put the search label and entry in a div.
101 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
102 Put the search widgets in a FlowTable so that the CSS can be used to
103 style them while keeping them together.
104 * src/main/webapp/style.css: Mention the new div.
106 2012-01-27 Murray Cumming <murrayc@murrayc.com>
108 Translate more strings in more locales.
110 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
111 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
112 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
113 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
114 Translate the "Details" and "Open" string too.
116 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
117 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
118 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
119 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
120 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
121 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
122 Add these new locales as placeholders though they currently contain English.
124 2012-01-27 Murray Cumming <murrayc@murrayc.com>
126 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
128 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
129 Check the ConfiguredDocument* for null before using it.
131 2012-01-26 Murray Cumming <murrayc@murrayc.com>
133 Tell Eclipse about the generated java files.
135 * .classpath: This lets it find OnlineGlomConstants.java.
136 It would be nice if Eclipse just used the maven build files.
138 2012-01-26 Murray Cumming <murrayc@murrayc.com>
140 Prevent a crash when no locale is specified in the URL.
142 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
143 Avoid returning a null string, obtained from
144 Window.Location.getParameter(). This caused a crash when it was
145 later passed to libglom's API.
146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
147 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
148 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
149 guard against future null strings.
151 2012-01-26 Murray Cumming <murrayc@murrayc.com>
153 Use the ?locale= query param instead of the &lang= token param.
155 * src/main/java/org/glom/web/client/place/ListPlace.java
156 * src/main/java/org/glom/web/client/place/DetailsPlace.java
157 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
158 Remove the lang token key and value.
160 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
161 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
162 When the user selects a different locale from the chooser, use
163 Window.Location.assign() to change the URL, which then causes a reload.
165 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
166 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
167 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
168 * src/main/java/org/glom/web/client/activity/ListActivity.java
169 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
170 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
171 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
172 * src/main/java/org/glom/web/client/ui/ListView.java:
173 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
175 Remove localeID member variables and method/constructor parameters, instead
176 using Utils.getCurrentLocaleID() when we need a localID to pass to
179 2012-01-26 Murray Cumming <murrayc@murrayc.com>
181 Internationalize the UI strings.
183 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
184 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
185 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
186 because it is unused. Messages are apparently strings that can have
187 parameters, but we do not need that yet, so Contants will be enough for now.
188 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
189 to say that we support the en and de locales.
190 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
191 The original English strings.
192 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
193 Some German translations of the English strings.
194 The i18n goal then uses the .properties file to generate an
195 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
196 returns an implementation that returns the translated strings.
197 The documentation suggests putting these in src/java/*/client/, but it seems
198 best to put it in src/resources/*/client/.
199 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
200 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
201 instead of hard-coding them.
202 Note that we cannot import OnlineGlomConstants because it does not exist yet,
203 but that does not seem to stop the build, though it confuses Eclipse.
205 You can see the translated string by adding ?locale=de to the URL, like so:
206 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
208 2012-01-24 Murray Cumming <murrayc@murrayc.com>
210 Improve null/empty String checks.
212 * pom.xml: Add a dependency on commons-lang, to use
213 org.apache.commons.lang.StringUtils.
214 * src/main/java/org/glom/web/server/ConfiguredDocument.java
215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
216 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
217 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
218 Use StringUtils.isEmpty().
220 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
221 StringUtils class with a static isEmpty() function because we
222 cannot use org.apache.commons.lang.StringUtils in client-side
223 GWT code because it (apparently) cannot be compiled to javascript.
224 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
225 * src/main/java/org/glom/web/client/activity/ListActivity.java
226 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
227 * src/main/java/org/glom/web/client/place/DetailsPlace.java
228 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
229 * src/main/java/org/glom/web/client/place/ListPlace.java
230 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
231 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
232 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
233 * src/main/java/org/glom/web/client/ui/details/Group.java
234 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
235 our StringUtils.isEmpty() function.
237 2012-01-24 Murray Cumming <murrayc@murrayc.com>
239 Update to the latest java-libglom API.
241 * pom.xml: Require java-libglom 1.21.4.
242 * src/main/java/org/glom/web/server/ConfiguredDocument.java
243 getDocumentInfo(), getListViewLayoutGroup():
244 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
246 * src/main/java/org/glom/web/server/database/DBAccess.java
247 getFieldsToShowForSQLQueryAddGroup(),
248 getPrimaryKeyLayoutItemField(): Replace get_database_title()
249 with either get_database_title_original() or
250 get_database_title(localeID).
252 2012-01-24 Murray Cumming <murrayc@murrayc.com>
254 ConfiguredDocument: Avoid a null pointer exception.
256 * src/main/java/org/glom/web/server/ConfiguredDocument.java
257 Initialize localeID to "" to avoid returning a null String which
258 causes a crash in java-libglom's swing-generated code.
260 2012-01-23 Murray Cumming <murrayc@murrayc.com>
262 Some simple renaming.
264 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
265 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
266 for localeChooser. This seems more appropriate and is less ambiguous
267 particularly in the .css file.
269 2012-01-23 Murray Cumming <murrayc@murrayc.com>
271 ConfiguredDocument: Rename the localedID private member variable.
273 2012-01-23 Murray Cumming <murrayc@murrayc.com>
275 Adapt to the latest java-libglom API from git master.
277 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
278 libglom now uses only Vector instead of List, which uses add() instead of
281 2012-01-23 Murray Cumming <murrayc@murrayc.com>
283 Add and fill a Reports drop-down list box.
285 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
287 * src/main/java/org/glom/web/client/OnlineGlomService.java:
288 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
290 Added getReports(document, table, localeID), calling
291 ConfiguredDocument.getReports().
292 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
293 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
294 Added setReportsList() and a list widget.
295 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
296 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
298 2012-01-22 Murray Cumming <murrayc@murrayc.com>
300 ConfiguredDocument: Rename the localedID private member variable.
302 2012-01-20 Murray Cumming <murrayc@murrayc.com>
304 Build a source tarball with mvn assembly:single
306 * assembly.xml: Add this file.
307 * pom.xml: Use the maven-assembly-plugin and tell it to use
308 our assembly.xml file.
310 2012-01-19 Murray Cumming <murrayc@murrayc.com>
312 OnlineGlomServiceImpl: Get .glom files recursively.
314 * pom.xml: Depend on commons-io from org.apache.commons.
315 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
316 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
317 files recursively, and with the easier filter for the extension.
318 Use org.apache.commons.io.FilenameUtils.removeExtension() to
319 simplify that code too.
321 2012-01-19 Murray Cumming <murrayc@murrayc.com>
323 README: Mention that you must install java-libglom packages separately.
325 But then it works, because java-libglom is now in the central maven
328 2012-01-18 Murray Cumming <murrayc@murrayc.com>
330 locales drop-down: Show the correct selected locale when the URL changes.
332 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
333 .java: setPlace(): Move some code into fillView().
335 2012-01-18 Murray Cumming <murrayc@murrayc.com>
337 locales drop-down: Do not lose the primary key.
339 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
340 start(): onLocaleChange(): Pass the current primary key value,
341 instead of an empty value.
343 2012-01-18 Murray Cumming <murrayc@murrayc.com>
345 locales drop-down: Do not lose the drop-down selection.
347 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
348 .java (TableSelectionActivity.fillView): Set the selected locale
349 after changing the drop-down items (though we do not really need
350 to change them just because the locale changes.)
352 2012-01-18 Murray Cumming <murrayc@murrayc.com>
354 locales drop-down: Change the tables list when this changes.
356 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
357 .java: TableSelectionActivity.start(): Move the async table titles
358 retrieval into a private fillView() method and also call this when
359 the chosen locale changes.
360 Note that the document title is not actually translatable yet, but
361 that is a problem that I should fix soon in libglom.
363 2012-01-18 Murray Cumming <murrayc@murrayc.com>
365 Improve the placement of the locales drop-down.
367 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
368 Put the title and locales drop-down in a div (gwt.FlowTable).
369 * src/main/webapp/style.css: Add magic css properties to make this work.
370 Also remove the left margin from the title so that it lines up with the
373 2012-01-18 Murray Cumming <murrayc@murrayc.com>
375 locales selector: Show human-readable locale titles.
377 * src/main/java/org/glom/web/server/ConfiguredDocument.java
378 getDocumentInfo(): Use java.util.Locale to show a real title of
379 each locale, in the locale's own language.
381 2012-01-17 Murray Cumming <murrayc@murrayc.com>
383 Add a language/locale selector drop-down.
385 * src/main/java/org/glom/web/shared/DocumentInfo.java:
386 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
387 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
388 getDocumentInfo(): Store the available Locales in the DocumentInfo.
389 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
390 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
391 Add a ListBox to show the available locales. Add getLocaleSelector(),
392 setLocaleList(), getSelectedLocale(), setSelectedLocale().
393 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
394 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
395 java: Add these classes.
396 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
397 start(): Fill the locales ListBox. Handle its change event, firing a
399 setPlace(): Show the selected locale as specified by the URL token.
400 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
401 * src/main/java/org/glom/web/client/activity/ListActivity.java:
402 Handle LocaleChangeEvent, going to a new *Place with that locale.
404 The placement of the ListBox is not pretty, and it currently uses the ID
405 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
409 2012-01-17 Murray Cumming <murrayc@murrayc.com>
411 Search box: Show the search text from the URL token.
413 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
414 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
415 Add setQuickFindText().
416 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
417 .java: setPlace(): Store the queryText if the place is a ListPlace,
418 and call TableSelectionView.setQuickFindText().
420 2012-01-17 Murray Cumming <murrayc@murrayc.com>
422 Allow use of translations via, for instance, &lang=de in the URL.
424 * pom.xml: Use the unstable java-libglom 1.21 version.
426 * src/main/java/org/glom/web/client/OnlineGlomService.java:
427 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
428 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
429 init(): Instead of calling TranslatableItem.set_current_locale()
430 (now removed), call ConfiguredDocument.setDefaultLocaleID().
431 However, this is only for default locales, which are not needed to
432 change the locale in the URL.
433 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
434 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
435 getSortedRelatedListData(): Add a localeID parameter, so we can get the
436 layout for a particular locale.
437 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
438 Add get/setDefaultLocaleID().
439 getDocumentInfo(), getListViewData(), getRelatedListData(),
440 getDetailsLayoutGroup(), getListViewLayoutGroup(),
441 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
442 localeID parameter, so we can get the layout for a particular locale.
444 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
445 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
446 * src/main/java/org/glom/web/client/place/ListPlace.java:
447 Parse and construct a lang parameter too.
449 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
450 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
451 passed to subsequent methods and constructors.
452 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
453 * src/main/java/org/glom/web/client/activity/ListActivity.java:
454 Store the localeID from the *Place and pass it to other constructors
455 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
457 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
458 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
459 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
460 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
461 * src/main/java/org/glom/web/client/ui/ListView.java:
462 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
463 Take localeID parameters and pass them to subsequent constructors and
464 methods, so that the layout is always retrieved for that locale.
466 This is rather repetitive.
468 Note that "" means the original (default) locale of the Glom document,
469 which is usually English.
471 2012-01-17 Murray Cumming <murrayc@murrayc.com>
473 Documents: Remove final keyword to fix startup configuration.
475 * src/main/java/org/glom/web/shared/Documents.java: Remove the
476 final keywords on the private member variables because that breaks
477 the startup, apparently (there are warnings) because it stops them
478 from being serialized. I added these in the previous commit.
480 2012-01-13 Murray Cumming <murrayc@murrayc.com>
482 Documents: Add some final keywords.
484 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
487 2012-01-13 Murray Cumming <murrayc@murrayc.com>
489 OnlineGlomServiceImpl: Add to overview comments.
491 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
492 Note that this is where all the document are loaded. They are not
493 loaded freshly for each page.
495 2012-01-12 Murray Cumming <murrayc@murrayc.com>
499 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
500 Add a TextBox for the text of a quick find.
501 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
503 setBackLink(): Add a String quickFind parameter.
504 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
505 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
506 to the base interface, because that is how TableSelectionViewImpl is used.
507 * src/main/webapp/style.css: Add style for the search box and its label.
509 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
510 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
511 Add these files, based on the existing TableChangeEvent and
512 TableChangeEventHandlers.
513 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
514 start(): Handle QuickFindChangeEvent, passing its quickFind text to
515 a ListPlace() that the user should be taken to.
516 * src/main/java/org/glom/web/client/activity/ListActivity.java
517 start(): Handle it here too and adapt the TableChangeEvent handler to
518 pass the extra "" quickFind parameter to ListPlace.
519 * src/main/java/org/glom/web/client/place/ListPlace.java:
520 Constructor: Take an extra String quickFind parameter and store it,
521 returning it from a new getQuickFind() method.
522 getToken(): Put the quickFind text in the URL token.
523 getPlace(): Parse the quickFind text from the URL token.
524 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
525 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
526 ListPlace constructor.
527 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
528 .java: start(): Add a Change handler for the TableSelectionView's
529 TextBox (via its base HasChangeHandlers interface), firing the new
530 QuickFindChangeEvent.
531 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
532 pass the extra "" quickFind parameter.
534 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
535 setCellTable(): Add a String quickFind parameter and pass it to
536 the ListViewTable() constructor.
537 * src/main/java/org/glom/web/client/ui/ListView.java: Change
538 setCellTable() in the base interface, because that is how ListViewImpl
541 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
542 Add a String quickFind member variable.
543 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
544 Constructor: Add a String quickFind parameter, storing it in the
545 base ListTable's member variable.
546 onRangeChanged(): Pass quickFind to the
547 OnlineGlomServiceAsync.getSortedListViewData() and
548 OnlineGlomServiceAsync.getListViewData() methods.
550 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
551 getListViewData(), getSortedListViewData(): Add a String quickFind
552 parameter, passing it to ConfiguredDocument.getListViewData().
553 * src/main/java/org/glom/web/client/OnlineGlomService.java:
554 Change getListViewData(), getSortedListViewData() in the base interface,
555 because that is how OnlineGlomServiceImpl is used, via this:
556 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
557 Change getListViewData(), getSortedListViewData() here too.
558 This class can apparently be used to asynchronously call methods on
559 OnlineGlomService, and GWT seems to implement that after recognizing
560 just the *Async name convention and the extra AsyncCallback parameters.
562 * src/main/java/org/glom/web/server/ConfiguredDocument.java
563 getListViewData(): Add a String quickFind parameter, and pass it to
564 ListViewDBAccess.getData().
565 * src/main/java/org/glom/web/server/database/ListDBAccess.java
566 getListData(): Add a String quickFind parameter and pass it to
568 getSelectQuery(): Add a String quickFind parameter.
569 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
570 getSelectQuery(): Add a String quickFind parameter and use it with
571 Glom.get_find_where_clause_quick() to pass a where_clause to
572 Glom.build_sql_select_with_where_clause(), to actually filter the
574 getData(): Add a String quickFind parameter, passing it to getListData().
575 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
576 va: getData(): Pass an empty string to getListData() for the
579 2012-01-12 Murray Cumming <murrayc@murrayc.com>
581 ListTable: Minor change.
583 * src/main/java/org/glom/web/client/ui/list/ListTable.java
584 createCellTable(): Make this protected instead of public.
586 2012-01-12 Murray Cumming <murrayc@murrayc.com>
588 Many files: Use final for the parameters and use the @override attribute.
590 2012-01-22 Ben Konrath <ben@bagu.org>
592 Add anchor links for single line text that starts with http, ftp and www.
596 2012-01-22 Ben Konrath <ben@bagu.org>
598 Add ellipsis to single line text in details view.
602 2012-01-04 Murray Cumming <murrayc@murrayc.com>
604 Remove all javadoc author tags.
606 Because they are awkward and meaningless when many people touch
608 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
610 2012-01-04 Murray Cumming <murrayc@murrayc.com>
612 Revert the COPYING.LESSER to COPYING rename.
614 Apparently both should be there if it is LGPL.
616 2012-01-03 Murray Cumming <murrayc@murrayc.com>
618 *View: Remove unused imports.
620 * src/main/java/org/glom/web/client/ui/DetailsView.java:
621 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
622 * src/main/java/org/glom/web/client/ui/ListView.java:
623 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
624 Remove unused imports, as suggested by Eclipse.
626 2012-01-02 Murray Cumming <murrayc@murrayc.com>
628 Move the *View::Presenter types, and some API into one base View.
630 * src/main/java/org/glom/web/client/ui/DetailsView.java:
631 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
632 * src/main/java/org/glom/web/client/ui/ListView.java:
633 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
634 Presenter, setPresenter() and clear() into a shared base interface,
635 to avoid the unnecessary duplicate Presenter types and to more clearly
636 show how the *Views share the same structure, even if they are not
637 used polymorphically.
639 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
640 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
642 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
643 * src/main/java/org/glom/web/client/activity/ListActivity.java:
644 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
646 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
649 Feel free to revert this if there is a good reason for the duplicate
652 2012-01-02 Murray Cumming <murrayc@murrayc.com>
654 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
656 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
657 a class member instead of a local variable in the method.
658 This lets us use it to get the view instances, for use in tests.
659 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
660 beforeOnlineGlom(): Test some more details of the initial view.
661 Again, this is not very useful.
663 To really test gwt-glom we will need to start a local postgresql
664 instance with local data, like the Glom tests in C++.
666 2012-01-02 Murray Cumming <murrayc@murrayc.com>
668 pom.xml: Mention the LGPL license.
670 * pom.xml: Add a licenses section.
671 * COPYING.LESSER: Move this to COPYING, which
672 previously contained the GPL. But gwt-glom is all LGPL.
674 2012-01-02 Murray Cumming <murrayc@murrayc.com>
676 Add project information to README and pom.xml.
678 * README: Add a brief description and mention some mvn
680 * pom.xml: This extra information shows up in mvn site
683 2011-01-02 Murray Cumming <murrayc@murrayc.com>
685 Use the latest java-libglom version.
687 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
689 2012-01-01 Murray Cumming <murrayc@murrayc.com>
691 GwtTestOnlineGlom: Test a little more.
693 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
694 protected rather than private, as suggested by the gwt-test-utils
696 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
697 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
698 Test the initial visibility of the panels.
700 However, this is not a very useful test.
701 And I wonder how we should generally test using this idea for an
702 activity/places app like ours where the real changes happen implicitly
703 based on the history token/URL.
705 2012-01-01 Murray Cumming <murrayc@murrayc.com>
707 Slight modification to *Mapper comments.
709 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
711 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
713 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
715 Remove comments mentioning GIN because they are just copied from
716 the example code and are apparently not helpful:
717 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
718 Also change the mention of a class that is only in the example code.
720 2012-01-01 Murray Cumming <murrayc@murrayc.com>
722 GwtTestOnlineGlom test: Minor changes.
724 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
725 Avoid the long qualified class name and modify the comment
726 because it is now obvious to me that the mocked class is the only
727 custom one created via GWT.create().
729 2012-01-01 Murray Cumming <murrayc@murrayc.com>
731 Tests: Added the beginnings of a test using gwt-test-utils.
733 * pom.xml: Add dependencies on gwt-test-utils and easymock.
734 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
735 which tells gwt-test-utils what class will be tested.
736 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
737 Add a simple (but empty) test case. One class, used by the OnlineGlom
738 class, is mocked so that it can be created. However, I am not sure
739 why only this class needs to be mocked.
741 Note that mockito seems more popular, and clearer, than easymock,
742 but I have not got that working yet. It might be a matter of the
745 This test is run during mvn integration-test.
747 2011-12-31 Murray Cumming <murrayc@murrayc.com>
749 Tests: Use junit4-style syntax instead of junit3-style.
751 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
752 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
753 * src/test/java/org/glom/web/shared/DataItemTest.java:
754 Use the @Test annotation rather than relying on the test*() prefix.
755 Also no longer implement TestCase, to avoid triggering support for
756 the junit3-way, which stops the annotations from working.
757 Change the imports from import junit.framework.* to
758 import org.junit.*, which is apparently the new way.
760 2011-12-31 Murray Cumming <murrayc@murrayc.com>
762 Added a test for ListPlace token parsing and creation.
764 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
765 This is much the same as DetailsPlaceTest.
767 I wonder how we could test the other parts of the *Place API.
769 2011-12-30 Murray Cumming <murrayc@murrayc.com>
771 DetailsPlace test: Also test getToken() and recreation via getPlace().
773 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
774 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
775 recreate it, testing the recreated DetailsPlace for the same parameter
778 2011-12-30 Murray Cumming <murrayc@murrayc.com>
780 Use the surefire-report plugin.
782 * pom.xml: This generates a HTML report about the tests in
783 target/site/surefire-report.html
784 when you do mvn surefire-report:report. It seems to be popular/normal.
786 2011-12-30 Murray Cumming <murrayc@murrayc.com>
788 Added a test for DetailsPlace.
790 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
791 Test the getPlace() token parsing.
793 2011-12-30 Murray Cumming <murrayc@murrayc.com>
795 Added a first unit test.
797 * pom.xml: Add a test goal, and a dependency on junit in that scope.
798 * src/test/java/org/glom/web/shared/DataItemTest.java:
799 This is a silly test but it is just to get things started. Note that
800 maven/junit finds the test because it looks in src/test by default.
802 2011-12-22 Ben Konrath <ben@bagu.org>
804 Change charsetName to "UTF-8" when replacing line breaks.
806 JavaScript requires the charsetName to be "UTF-8". CharsetName values
807 that work in Java (such as "UTF8") will not work when compiled to
810 This fixes a problem with multi-line details view fields that have hard
811 line breaks. The "License Text" field on this page demonstrates the
814 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
816 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
818 2011-12-22 Ben Konrath <ben@bagu.org>
820 Fix another bug with related list navigation.
822 I've tested all the navigation buttons in all of the related lists
823 so things should be good now.
825 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
827 2011-12-22 Ben Konrath <ben@bagu.org>
829 Fix a crasher when refreshing the list view with the default table.
831 This crash will also happen when loading the list view with the default
832 table from a link or bookmark.
834 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
835 to the main document selection page when the document id hasn't been
837 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
838 the main document selection page when the document id hasn't been
840 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
841 values for the details place when the document id hasn't been set.
842 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
843 values for the list place when the document id hasn't been set.
845 2011-12-21 Ben Konrath <ben@bagu.org>
847 Protect against NPE when glom.document.locale is not in config.
849 This patch protects against an NPE when glom.document.locale is not in
850 the config file. This NPE will also happen if glom.document.locale is
853 The patch also updates the error message to display the class name when
854 the getMessage() returns null. This was happening when the NPE was
855 thrown and I had "Configuration Error: null". If an NPE is encountered
856 with this patch, "Configuration Error: NullPointerException " will be
859 This commit closes this bug:
861 https://bugzilla.gnome.org/show_bug.cgi?id=666669
863 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
865 2011-12-20 Murray Cumming <murrayc@murrayc.com>
867 Rename onlineglom.properties to onlineglom.properties.sample.
869 * src/main/resources/onlineglom.properties: Rename to:
870 * src/main/resources/onlineglom.properties.sample:
871 * src/main/resources/README: And add this file explaining that people
872 should rename it back when deploying.
874 2011-12-20 Murray Cumming <murrayc@murrayc.com>
876 Allow choosing the translation in the .properties file.
878 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
879 init(): Read a glom.document.locale value from the configuration file
880 and call Glom's TransatableItem::set_current_locale() method.
881 * src/main/resources/onlineglom.properties: Add a commented-out
882 example of this new setting.
884 It would be better to add &lang=de_DE to the URL, but the current
885 libglom API does not allow us to do this easily. I am working on that.
887 2011-12-19 Murray Cumming <murrayc@murrayc.com>
889 Avoid a crash in parsing of token parameters.
891 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
892 ava: getTokenParams(): Do not crash if a parameter has a key but no
893 value, and ignore parameters with neither.
895 2011-12-17 Murray Cumming <murrayc@murayc.com>
897 History token building/handling: Improve use of token parameters.
899 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
900 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
901 and buildParamsToken(HashMap), for use by derived classes.
902 Make the separator private because it is no longer be needed.
903 * src/main/java/org/glom/web/client/place/DetailsPlace.java
904 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
905 instead of manual string concatenation.
906 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
907 of hardcoded indices and awkward splitting code.
908 * src/main/java/org/glom/web/client/place/ListPlace.java
909 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
910 instead of manual string concatenation.
911 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
912 of hardcoded indices and awkward splitting code.
913 This should fix bug #666420
915 2011-12-16 Murray Cumming <murrayc@murrayc.com>
917 Fix a Navgiation->Navigation typo in the code.
919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
920 Rename processNavgiation() to processNavigation().
922 2011-12-16 Murray Cumming <murrayc@murrayc.com>
924 Fix a seperator->separator typo in the code.
926 * src/main/java/org/glom/web/client/place/DetailsPlace.java
927 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
928 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
931 2011-12-15 Ben Konrath <ben@bagu.org>
933 Cleanup some comments.
935 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
937 2011-12-14 Ben Konrath <ben@bagu.org>
939 Replace \n with <br/> for multiline text in the details view.
941 Vertical scrollbars are added when needed as well.
943 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
945 2011-12-14 Ben Konrath <ben@bagu.org>
947 Specify the font for document selection links.
949 * src/main/webapp/style.css:
951 2011-12-14 Ben Konrath <ben@bagu.org>
953 Fix bouncy CellTable while paging.
955 This doesn't currently work with related list tables in unselected
958 * src/main/java/org/glom/web/client/ui/list/ListTable.java
960 2011-12-14 Ben Konrath <ben@bagu.org>
962 Revamp the appearance of the document selection page.
964 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
965 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
966 * src/main/webapp/style.css:
968 2011-12-13 Ben Konrath <ben@bagu.org>
970 Set navigation button column to the smallest size possible.
972 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
974 2011-12-13 Ben Konrath <ben@bagu.org>
976 Change OpenButton nomenclature to NavigationButton.
978 Using NavigtionButton makes things more generic. Classes, methods and
979 variables have been changed.
981 This is a rename-only refactor.
983 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
984 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
985 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
986 Renamed from OpenButtonCell.
987 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
988 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
989 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
991 2011-12-12 Ben Konrath <ben@bagu.org>
993 Remove unnecessary String argument in RelatedListTable and ListViewTable.
995 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
996 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
997 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
998 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1000 2011-12-12 Ben Konrath <ben@bagu.org>
1002 Update variable names and comments.
1004 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1005 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1007 2011-12-12 Ben Konrath <ben@bagu.org>
1009 Properly initialize numNonEmptyRows variable to zero.
1011 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1012 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1014 2011-12-05 Ben Konrath <ben@bagu.org>
1016 Add latest mockup with HTML tables.
1018 Features of this mockup:
1020 -> HTML table for flowtable
1021 -> HTML table for flowtable column
1022 -> Example of how related lists would look
1023 -> Not using text entries for data items
1025 The current version of Online Glom doesn't use HTML tables for the
1028 This mockup has been sent to the glom-devel mailing list but it's good
1029 to have it here as well.
1031 * mockups/details-view-html-tables.html:
1033 2011-12-05 Ben Konrath <ben@bagu.org>
1035 Remove unnecessary getPrimaryKeyField() method.
1037 getPrimaryKeyFieldForTable(String) has been renamed to
1038 getPrimaryKeyField(String).
1040 * src/main/java/org/glom/web/server/database/DBAccess.java:
1041 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1042 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1044 2011-12-05 Ben Konrath <ben@bagu.org>
1046 Add string representation of TypedDataItem value to conversion error message.
1048 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1049 message was extracted into its own method to avoid duplication.
1051 2011-12-05 Ben Konrath <ben@bagu.org>
1053 Add type checking to navigation primary key value creation.
1055 Create navigation primary key only if the expected type from the Glom
1056 document matches the type returned by the SQL query.
1058 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1060 2011-12-05 Ben Konrath <ben@bagu.org>
1062 Rename a couple of variables in RelatedListNavigation.
1064 This is a rename-only refactor.
1066 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1068 2011-12-05 Ben Konrath <ben@bagu.org>
1070 Move getListLayoutGroup() into getListViewLayoutGroup().
1072 This removes getListLayoutGroup(). It was only being called by
1073 getListViewLayoutGroup().
1075 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1077 2011-12-05 Ben Konrath <ben@bagu.org>
1079 Remove check for LayoutItem_Portal in list table method.
1081 This check is no longer necessary because the method isn't being used
1082 to create the LayoutItemPortal DTO.
1084 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1086 2011-12-05 Ben Konrath <ben@bagu.org>
1088 Properly support related list navigation.
1090 Navigation from the "Repository Analyzer -> Package Scans ->
1091 Dependencies" related table wasn't working because the primary key for
1092 related tables wasn't being set properly. This commit fixes the
1095 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1096 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1097 doesn't set the primary key properly for related list tables.
1098 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1099 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1100 useful for getting the primary key for list view tables and for related
1102 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1103 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1104 Move code to set the primary key for the table from the abstract
1105 ListDBAccess class to ListViewDBAccess as it's only correct for list
1107 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1108 Properly add primary key to related list tables.
1110 2011-12-02 Ben Konrath <ben@bagu.org>
1112 Properly set the horizontal alignment of fields.
1114 This fix is for both the list tables and the details view.
1116 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1117 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1118 to set the horizontal alignment of fields.
1120 2011-12-02 Ben Konrath <ben@bagu.org>
1122 Display currency codes in the details view.
1124 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1126 2011-12-02 Ben Konrath <ben@bagu.org>
1128 Avoid duplicate JNI call.
1130 JNI is not as efficient as pure Java and this is an easy (and small)
1133 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1134 Use previously retrieved value for whereClauseToTableName instead of
1137 2011-12-02 Ben Konrath <ben@bagu.org>
1139 Rename a couple of variables in RelatedListNavigation.
1141 This is a rename-only refactor.
1143 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1145 2011-12-02 Ben Konrath <ben@bagu.org>
1147 Indicate clearly that a mismatched primary key type is a bug.
1149 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1150 warning to error. Add 'This is a bug.' to message.
1152 2011-12-02 Ben Konrath <ben@bagu.org>
1154 Update / fix some comments.
1156 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1158 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1160 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1161 Fix comments. Add some TODOs.
1163 2011-12-02 Ben Konrath <ben@bagu.org>
1165 Enable navigation to details view with string primary key from related list.
1167 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1168 Create a text primary key value when return type of result is
1169 java.sql.Types.VARCHAR.
1171 2011-12-02 Ben Konrath <ben@bagu.org>
1173 Use checkboxes for booleans in the details view.
1175 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1177 2011-12-01 Ben Konrath <ben@bagu.org>
1179 Improve performance of related list height calculation.
1181 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1182 Put code to calculate the expected height in a static initializer so
1183 that that it's only called once.
1185 2011-12-01 Ben Konrath <ben@bagu.org>
1187 Show related list tables in notebooks (again).
1189 Calculate the height of the related list tables so the Notebook can be
1190 set the correct height. The height of the related list table is also needed by
1191 FlowTable to be able decide how to create the layout.
1193 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1194 and set the Portal height based on the height of the related list
1195 table and the Portal container.
1196 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1197 Add method to calculate the height of the related list tables.
1198 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1199 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1200 calculate the height of the Pager widget.
1202 2011-12-01 Ben Konrath <ben@bagu.org>
1204 Use CellTable API for table property instead of setting style on Element.
1206 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1208 2011-12-01 Ben Konrath <ben@bagu.org>
1210 Make ListViewTable and RelatedListTable a consistent height.
1212 The tables are now a consistent height regardless of the contents of
1213 the table. A hidden button is added to empty rows to ensure that the
1214 height of these rows will match the height of rows with data.
1216 A navigation button column is now added to every table. The width of
1217 the navigation column is set to 0px when a RelatedListTable shouldn't
1218 have navigation buttons. This maintains the a consistent row height in
1219 tables that don't show the navigation buttons.
1221 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1222 navigation column when not needed.
1223 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1224 arguments for navigation button to constructor of ListViewTable.
1225 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1226 hidden button for empty data rows.
1227 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1228 arguments for navigation button to constructor.
1229 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1230 create navigation buttons. Add hideNavigationButtons() method.
1231 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1232 arguments for navigation button to constructor.
1234 2011-12-01 Ben Konrath <ben@bagu.org>
1236 Use 'visibility: hidden' in Utils.getWidgetHeight().
1238 This is better choice because hidden elements are invisible, don't
1239 respond to events and are not part of the tab order. They will,
1240 however, take up space which is required to be able to calculate the
1241 height of the widget.
1243 * src/main/java/org/glom/web/client/Utils.java:
1245 2011-12-01 Ben Konrath <ben@bagu.org>
1247 Use Utils.getWidgetHeight() in FlowTable.
1249 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1251 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1253 2011-12-01 Ben Konrath <ben@bagu.org>
1255 Put the details css class name on the correct table column.
1257 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1259 2011-11-30 Ben Konrath <ben@bagu.org>
1261 Update for java-libglom API change.
1263 The getters and setters on FieldFormatting and NumericFormat were
1264 changed to remove the 'M'.
1266 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1268 2011-11-29 Ben Konrath <ben@bagu.org>
1270 Only allow RelatedListTables in Portals.
1272 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1274 2011-11-29 Ben Konrath <ben@bagu.org>
1276 Only create a contents panel for Portals when title is being set.
1278 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1280 2011-11-29 Ben Konrath <ben@bagu.org>
1282 Set TabLayoutPanel height based on calculated height its widgets.
1284 This is a potential fix for this bug:
1286 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1288 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1290 2011-11-29 Ben Konrath <ben@bagu.org>
1292 Align details field labels and data with the Open buttons.
1294 * src/main/webapp/style.css:
1296 2011-11-29 Ben Konrath <ben@bagu.org>
1298 Remove unnecessary <div> in the Notebook widget.
1300 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1301 method to get container FlowPanel (<div>).
1302 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1303 initWidget() method directly on the TabLayoutPanel widget instead of
1304 Group's container widget.
1306 2011-11-29 Ben Konrath <ben@bagu.org>
1308 Don't add group titles for Portals in Notebooks.
1310 This reverts the previous patch and fixes a bug I introduced with
1311 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1313 * src/main/java/org/glom/web/client/ui/details/Group.java:
1314 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1316 2011-11-28 Ben Konrath <ben@bagu.org>
1318 Remove unused boolean argument in Portal constructor.
1320 Just a code cleanup.
1322 * src/main/java/org/glom/web/client/ui/details/Group.java:
1323 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1325 2011-11-28 Ben Konrath <ben@bagu.org>
1327 Remove hack for glom 1.18 style glom files.
1329 * src/main/java/org/glom/web/client/ui/details/Group.java:
1330 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1331 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1333 2011-11-28 Ben Konrath <ben@bagu.org>
1335 Use Gda Value version of primary key to log result too large error.
1337 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1339 2011-11-28 Ben Konrath <ben@bagu.org>
1341 Don't use TypedDataItem.getText() for Unknown types from the URL.
1343 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1344 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1345 instead of getText().
1346 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1347 String field and getUnknown() method.
1349 2011-11-28 Ben Konrath <ben@bagu.org>
1351 Log an error message when the java-libglom .so is not present.
1353 The error message was being set in the exception but not logged.
1355 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1357 2011-11-28 Ben Konrath <ben@bagu.org>
1359 Ignore LayoutItem_CalendarPortals.
1361 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1362 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1364 2011-11-28 Ben Konrath <ben@bagu.org>
1366 Extract method for creating the LayoutItemPortal DTO.
1368 Just breaking the code up into smaller chunks.
1370 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1372 2011-11-28 Ben Konrath <ben@bagu.org>
1376 This should have been added with the refactor. Oops!
1378 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1380 2011-11-28 Ben Konrath <ben@bagu.org>
1382 Create primary key value from URL string using type from Glom document.
1384 See this bug, comments 19 - 25:
1386 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1388 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1389 create a TypeDataItem for the primary key here when loading from a
1390 URL. Show the same string for the primary key value as was received
1391 from the URL string (when loading from a URL).
1392 * src/main/java/org/glom/web/server/Utils.java: Update method for
1393 creating the Gda Value from the TypeDataItem to properly deal with
1394 creating a Gda Value based on the Glom document type for the primary
1395 key value string when loading from a URL.
1396 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1397 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1398 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1399 Update for changed method name.
1401 2011-11-27 Ben Konrath <ben@bagu.org>
1403 Rename PrimaryKeyItem to TypedDataItem.
1405 The name PrimaryKeyItem suggests what the class should be used for.
1406 TypedDataItem is a neutral name that describes the class better.
1408 This is a rename-only refactor.
1410 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1411 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1412 * src/main/java/org/glom/web/client/Utils.java:
1413 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1414 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1415 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1416 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1417 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1418 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1419 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1420 * src/main/java/org/glom/web/server/Utils.java:
1421 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1422 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1423 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1424 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1426 2011-11-25 Ben Konrath <ben@bagu.org>
1428 Improve Gda Value conversion from PrimaryKeyItem.
1430 The value from the PrimaryKeyItem is only used if its type match the
1431 type from the glom document.
1433 * src/main/java/org/glom/web/server/Utils.java:
1435 2011-11-25 Ben Konrath <ben@bagu.org>
1437 Manually check if the java-liblgom .so is visible to the JVM.
1439 It seems that Tomcat has problems when a static initializer throws an
1440 exception. This check is done before the first method call into
1441 java-libglom so that execution doesn't continue if the .so is not
1444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1446 2011-11-25 Ben Konrath <ben@bagu.org>
1448 Improve browser configuration error messages.
1452 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1454 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1455 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1456 getConfigurationErrorMessage() method.
1457 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1458 Get and display a specific configuration error message when no Glom
1459 documents are found.
1460 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1461 Implement getConfigurationErrorMessage() method. Surround configuration
1462 code in the init() method with a try/catch block. This allows the
1463 errors to be caught while keeping the servlet available to retrieve the
1464 configuration error message.
1466 2011-11-25 Ben Konrath <ben@bagu.org>
1468 Don't use Strings to hold primary key values.
1470 The primary key values are now held in a new data object
1471 (PrimaryKeyItem) that holds type information and the primary key value
1472 using the correct type.
1474 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1475 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1476 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1477 PrimaryKeyItem instead of String to hold the primary key value.
1478 * src/main/java/org/glom/web/client/Utils.java: Remove
1479 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1480 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1481 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1482 PrimaryKeyItem instead of String to hold the primary key value. Load
1483 document selection page when the documentID has not been set correctly.
1484 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1485 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1487 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1488 Return empty string for URL instead of "null".
1489 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1490 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1491 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1492 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1493 PrimaryKeyItem instead of String to hold primary key values.
1494 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1495 PrimaryKeyValue to a Gda Value.
1496 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1497 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1498 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1499 Replace temporary database access code that uses the PrimaryKeyValue to
1500 Gda Value conversion.
1501 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1502 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1503 PrimaryKeyItem instead of String.
1504 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1505 hold primary key values.
1507 2011-11-24 Ben Konrath <ben@bagu.org>
1509 Use newly added java-libglom API to create queries.
1511 This isn't finished. I still need to stop using Strings for primary key
1512 values in the client code.
1514 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1515 libglom to use fake connections so that retrieving the query string will
1517 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1518 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1519 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1520 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1521 Use the newly added libglom sql methods and classes to create the
1522 query. Add temporary hack to convert primary value strings to Gda
1525 2011-11-23 Ben Konrath <ben@bagu.org>
1527 Don't explicitly set the height of Portals.
1529 See comments 6 - 10 of this bug for details:
1531 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1533 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1535 2011-11-23 Ben Konrath <ben@bagu.org>
1537 Use an HTML table instead of CSS for the FlowTable layout.
1539 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1540 GWT's FlexTable to implement the FlowTable.
1541 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1543 2011-11-18 Ben Konrath <ben@bagu.org>
1545 Add boolean example to HTML table mockup.
1547 * mockups/details-view-html-tables-text-entries.html:
1549 2011-11-17 Ben Konrath <ben@bagu.org>
1551 Ensure the pager buttons are always visible for related lists.
1553 To accomplish this, I've turned off text wrapping in the list view and
1554 related list tables for both the header and data text. The related list
1555 table now has a fixed layout so the it doesn't overflow its container.
1556 This is required to ensure that the cell text is clipped when it
1557 overflows the cell and an ellipsis is added to the right side of the
1558 cell when text is clipped.
1560 A fixed table layout for the related list table in the details view
1561 seems what we want for the details view anyway, so the side-effect is
1564 The ellipsis will only be displayed in Firefox >= 7.
1568 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1570 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1571 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1572 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1574 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1575 Set the 'table-layout: fixed' CSS property to the related list table.
1576 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1577 'white-space: nowrap;' CSS property on both the list view and the
1578 related list tables.
1580 2011-11-16 Ben Konrath <ben@bagu.org>
1582 Rework the fix for empty notebook tab labels.
1584 Setting the empty group titles with its name caused problems for the
1585 details layout. Instead of using libglom's
1586 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1587 to the client when the title is empty. This allows the Notebook to use
1588 the name when the title is empty without affecting anything else.
1590 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1591 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1593 2011-11-16 Ben Konrath <ben@bagu.org>
1595 Set group titles with name when title is empty.
1597 This fixes a problem with an empty notebook tab label in the Lesson
1598 Planner document. The forth tab in the notebook should be "Internet":
1600 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1602 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1603 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1606 2011-11-16 Ben Konrath <ben@bagu.org>
1608 Remove whitespace from the configured username properties.
1610 This assumes that usernames won't have whitespace at the beginning
1611 or end. But I think this is a reasonable assumption.
1613 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1614 String.trim() to remove the whitespace from the username properties.
1616 2011-11-15 Ben Konrath <ben@bagu.org>
1618 Add details view mockup with HTML tables and text entries.
1620 This is from the attachment on this bug:
1622 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1624 * mockups/details-view-html-tables-text-entries.html:
1626 2011-11-15 Ben Konrath <ben@bagu.org>
1628 Add space between the columns of the flow table.
1632 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1634 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1635 space between columns in the flow table.
1637 2011-11-15 Ben Konrath <ben@bagu.org>
1639 Add backup files to the .gitignore.
1641 * .gitignore: Ignore files that end with ~.
1643 2011-11-09 Ben Konrath <ben@bagu.org>
1645 Use latest release of gwt-log.
1647 Gwt-log releases are now being submitted to the maven central
1648 repository so manual installation of the jar is no longer required.
1650 * pom.xml: Update version and groupId of gwt-log dependency.
1652 2011-10-31 Ben Konrath <ben@bagu.org>
1654 Don't use GWT numeric formatting to override the glom currency formatting.
1656 Currencies are now displayed like they are in Glom. See this bug:
1658 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1660 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1662 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1663 currency code to constructor and set it when the cell is rendered.
1664 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1665 currency code to the constructor of the NumericCell.
1667 2011-10-27 Ben Konrath <ben@bagu.org>
1669 Require the latest release of java-libglom (1.17.4).
1673 2011-10-26 Ben Konrath <ben@bagu.org>
1675 Add style to Notebook that matches current theme.
1677 It's not the best style in the world but it's better than the default.
1679 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1680 padding at the bottom of the child widgets.
1681 * src/main/webapp/style.css: Add style for the Notebook.
1683 2011-10-26 Ben Konrath <ben@bagu.org>
1685 Move servlet initialization code to overridden init method.
1687 This is half of the solution to getting proper error messages
1688 displayed when configuration errors occur. Here's the relevant bug:
1690 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1692 The rest of the solution involves surrounding the init method with a
1693 try/catch block and setting a global variable with the error /
1694 exception. A new async method should be created to retrieve and display
1695 the error message / exception.
1697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1698 code from constructor to init method adding exceptions as needed.
1700 2011-10-26 Ben Konrath <ben@bagu.org>
1702 Add script to monitor and restart tomcat if required.
1704 * utils/check-and-recover-tomcat.py: New file.
1706 2011-10-26 Ben Konrath <ben@bagu.org>
1708 Display the correct number of data items in the pager.
1712 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1714 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1715 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1716 The implementation is the same for both tables: Keep track of the
1717 number of non-empty rows and fire and RowCountChangeEvent after the data has
1719 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1720 custom Pager class that subclasses SimplePager to handle displaying
1721 the correct number when empty rows have been added.
1723 2011-10-26 Ben Konrath <ben@bagu.org>
1725 Correct error in previous commit.
1727 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1728 eventBus parameter from listView.setCellTable().
1730 2011-10-26 Ben Konrath <ben@bagu.org>
1732 Fix error in TODO comment.
1734 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1736 2011-10-24 Ben Konrath <ben@bagu.org>
1738 Create Notebook widgets to the details view.
1740 This isn't finished just yet - I still need to create a reasonable
1741 style to match the current theme.
1743 * src/main/java/org/glom/web/client/Utils.java: Add method for
1744 calculating the height of a widget. This is used in the Notebook class.
1745 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1746 new constructor method in Group.
1747 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1748 method for creating child widget that can be used by subclasses
1749 like Notebook. New constructor that allows disabling the group
1750 titles - Notebooks don't set a group title for their child groups.
1751 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1752 to make Notebooks using GWT's TabLayoutPanel.
1753 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1754 constructor that allows disabling the group titles.
1755 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1756 LayoutItemNotebook DTO.
1757 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1758 DTO for Notebooks. It's just an empty class for now but we might need
1759 it to transfer some specific information in the future.
1761 2011-10-21 Ben Konrath <ben@bagu.org>
1763 Add navigation buttons to related list tables.
1765 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1766 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1768 method getSuitableRecordToViewDetails() for getting the table name
1769 and primary key value for related list navigation buttons.
1770 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1771 private cell renderer class to get the navigation information for
1772 related list tables from the server. Extract the navigation
1773 processing code from the details cell navigation and use it for the
1774 related list navigation as well.
1775 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1776 cell renderer class for the details open buttons. This was needed
1777 because the related list navigation buttons and the list view
1778 navigation buttons need to react differently when clicked.
1779 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1780 the onEnterKeyDown() method because it's now overriden in the
1781 subclasses that are specific to the related list tables and the list
1783 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1784 the vertical size a little because the buttons add a bit of vertical
1785 space to table. This is not a perfect solution because the vertical
1786 size of with table fewer than 5 rows will be a little smaller.
1787 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1788 changes in how navigation buttons are handled.
1789 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1790 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1791 database access object.
1792 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1793 to find the portal for a given relationship name from
1794 RelatedListDBAccess. Add method to find a primary key field for a
1796 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1797 Move code to find the portal for a given relationship name to
1799 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1800 New file: database access object for getting the related list
1801 navigation information (the table name and the primary key value).
1802 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1803 DTO for transferring a table name to navigate to and a primary key
1805 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1806 boolean and getter/setter to specifies if the related list should add
1809 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1811 Use the master branch of java-libglom
1813 * pom.xml: Depend on java-libglom 1.19 instead.
1815 This is the master branch. See also the libglom-1-18 branch.
1817 2011-10-11 Ben Konrath <ben@bagu.org>
1819 Enable the open navigation button when the data has been set.
1821 This avoids having active buttons that don't do anything when the data
1824 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1826 2011-10-11 Ben Konrath <ben@bagu.org>
1828 Use IsWidget interface for FlowTableItem.
1830 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1831 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1833 2011-10-11 Ben Konrath <ben@bagu.org>
1835 Remove GWT styling from open button in details view.
1837 There are still some issues with how the details cell is arranged but
1838 this should be made to match Glom 1.20. I'm going to leave fixing this
1839 until I have Glom 1.20 up and running.
1841 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1842 style name on open button.
1843 * src/main/webapp/style.css: Move and edit details-navigation class.
1844 Re-arrange some classes to make them appear in the same order as the
1847 2011-10-07 Ben Konrath <ben@bagu.org>
1849 Update to GWT 2.4.0.
1851 * .gitignore: Ignore new cache directory.
1852 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1853 * pom.xml: Change GWT and maven plugin to 2.4.0.
1854 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1856 * src/main/java/org/glom/web/client/ClientFactory.java:
1857 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1858 * src/main/java/org/glom/web/client/OnlineGlom.java:
1859 Update source for API changes.
1860 * utils/build-onlineglom-war.sh: Remove cache directory before the
1863 2011-10-07 Ben Konrath <ben@bagu.org>
1865 Add navigation buttons in the details view.
1867 This isn't finished but I thought I'd commit what I have as it's a
1868 pretty good start. I still need to:
1870 1. Change the style so that it fits better into the current theme
1871 2. Adjust the details cell to expand as much as possible.
1873 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1874 click handlers to navigation buttons in the DetailsCells. Create a
1875 refreshData() method to get just the data from the server without the
1877 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1878 Update the tableSelector and browser title when the table name
1879 changes without using the tableSelector.
1880 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1881 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1882 getDetailsCells() to getCells(). Update variable names.
1883 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1884 method to set click handler on navigation button. Rename a few
1885 variables. Add navigation buttons where needed.
1886 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1887 variables and methods.
1888 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1889 navigation boolean and navigation table as required in the
1890 LayoutItemField DTO.
1891 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1892 variables for navigation along with getter/setter methods.
1894 2011-10-07 Ben Konrath <ben@bagu.org>
1896 Rename Field to DetailsCell.
1898 This is a refactor-only commit. No functionality has been added or
1901 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1902 Update variable and method names.
1903 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1904 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1905 variable and method names.
1906 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1908 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1909 variable and method names.
1911 2011-10-07 Ben Konrath <ben@bagu.org>
1913 Create separate methods for layout and data the details view.
1915 This is a refactor-only commit. No functionality has been added or
1918 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1919 private methods: setData(), createLayout().
1921 2011-10-07 Ben Konrath <ben@bagu.org>
1923 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1925 This is part of a change to get navigation buttons in the details view
1926 but it should have been done this way from the start.
1928 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1929 for method name change in TableSelectionView.
1930 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1931 Create TableChangeEvent and set the browser title using the
1932 TableSelectionView API.
1933 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1934 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1935 Change getSelectedTable() to getSelectedTableName(). Add
1936 getSelectedTableTitle().
1938 2011-10-07 Ben Konrath <ben@bagu.org>
1940 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1942 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1944 2011-10-07 Ben Konrath <ben@bagu.org>
1946 Update TableChangeEvent to use newTableName naming convention.
1948 This makes the class more consistent with GWT naming conventions.
1950 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1951 Update for method name change in TableChangeEvent.
1952 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1953 for method name change in TableChangeEvent.
1954 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1955 newTableName variable and getter method. Make toDebugString()
1958 2011-09-30 Ben Konrath <ben@bagu.org>
1960 Disable the pager in the list tables when the data row count is less than the minimum.
1962 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1963 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1965 2011-09-30 Ben Konrath <ben@bagu.org>
1967 Add empty rows to the end of related list and list view tables.
1969 I also extracted the cell rendering classes from the ListTable because
1970 the code was becoming a little crazy with all the anonymous inner
1971 classes. My plan is to use these cell rendering classes in the details
1972 view as well so this refactor will be needed for that change.
1974 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1975 set the row count in related list tables if the data has more rows
1976 than the minimum number of rows visible.
1977 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1978 row count in list view tables if the data has more rows than the
1979 minimum number of rows visible.
1980 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1981 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1983 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1984 for rendering TYPE_NUMERIC cells. The code was extracted from the
1986 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1987 class for rendering cells with buttons in list views. The code was
1988 extracted from the ListTable class.
1989 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1990 for rendering TYPE_TEXT cells. The code was extracted from the
1992 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1993 Add empty rows to the end of the data if required. Implement
1994 ListTable.getMinNumVisibleRows().
1995 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1996 cell renderer code to public classes. Return null in
1997 Column.getValue() for empty rows. Add new abstract method:
1998 getMinNumVisibleRows(). Move code to set the row count of the list view
1999 table to ListViewImpl.
2000 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2001 empty rows to the end of the data if required. Implement
2002 ListTable.getMinNumVisibleRows().
2005 2011-09-27 Ben Konrath <ben@bagu.org>
2007 Use GWT.log for client-side debugging statements.
2009 These are optimized out when deployed so I should have used this method
2010 in the first place. These statements will eventually be replaced with some sort
2011 of notification in the browser.
2013 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2014 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2015 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2016 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2017 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2019 2011-09-27 Ben Konrath <ben@bagu.org>
2021 Put tableselector on the right, back to list link on right.
2023 The idea is that the table selector is acting like a label for the
2024 currently displayed table so it should be placed below the document title. This
2025 puts the table title in a similar position to where it is in Glom.
2027 * mockups/details-contacts.html:
2028 * mockups/details-projects.html:
2029 * mockups/listview-contacts.html:
2030 * mockups/listview-projects.html:
2031 * mockups/style.css:
2032 Update mockups to match how the interfaces currently look.
2033 * src/main/webapp/style.css: Swap positions of backlink with the table
2034 selector. Add some space on the left side of the table selector to
2035 line things up with the document title.
2037 2011-09-27 Ben Konrath <ben@bagu.org>
2039 Add field colouring to details view.
2041 This change re-works how field colouring works. The colour formatting
2042 information is now set to the client with the layout information instead of
2043 with the data. This eliminates the need to send the same colour strings for
2044 data in list view column when colour information is set.
2046 In order to set an alternate colour for negative numeric values, the
2047 number is now sent to client and formatted with the GWT NumberFormat class.
2049 This change also fixes:
2051 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2053 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2054 internationalization framework which is needed for client side numeric
2056 * src/main/java/org/glom/web/client/Utils.java: New file for some
2057 client static utility methods.
2058 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2059 the DataItem object to the Field class. Use a utility method to
2060 create the foreignKeyValue string.
2061 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2062 alignment and text colours in the constructor. Add setData(DataItem)
2063 method. Remove setText(String) method.
2064 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2065 colour information to GlomTextCell. Create and use GlomNumberCell for
2066 rendering numbers. Use utility method to get the string for the
2067 primary key of the key provider. Re-work how the horizontal alignment
2069 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2070 formatting to layout information. Methods for converting the libglom
2071 formatting information were moved from DBAccess.
2072 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2073 numeric formatting (it's now done on the client side). Don't set text
2074 colours in DataItem. Move libglom formatting conversion methods to
2076 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2077 getters/setters for text colour information.
2078 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2079 for transferring the libglom NumericFormat information to the client.
2080 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2081 and getters/setters for: GlomNumericFormat, background colour and
2082 foreground colour strings.
2084 2011-09-26 Ben Konrath <ben@bagu.org>
2086 Simplify code that iterates through the LayoutGroup.
2088 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2090 2011-09-26 Ben Konrath <ben@bagu.org>
2092 Accept Eclipse formatting for OnlineGlomServiceAsync.
2094 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2096 2011-09-26 Ben Konrath <ben@bagu.org>
2098 Don't use the ListDBAccess classes to get the primary key layout information.
2100 This was causing a bug where the wrong index for the hidden primary key
2101 was being sent to the client.
2103 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2104 primary key while creating the LayoutGroup DTO. Create a
2105 LayoutItemField DTO for hidden primary keys. Don't use the
2106 RelatedListDBAccess because it was only used for getting the primary
2108 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2109 access modifier from public to protected for getPrimaryKeyField() and
2110 getPrimaryKeyLayoutItemField().
2111 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2112 abstract method getExpectedResultSize() because RelatedListDBAccess
2113 doesn't have enough info to implement it.
2114 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2115 Remove @Override for getExpectedResultSize().
2116 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2117 Remove method getExpectedResultSize().
2119 2011-09-23 Ben Konrath <ben@bagu.org>
2121 Log which layout (list or details) the ignored item is from.
2123 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2125 2011-09-23 Ben Konrath <ben@bagu.org>
2127 Remove annotations that turn off code formatting in DataItem.
2129 * src/main/java/org/glom/web/shared/DataItem.java:
2131 2011-09-23 Ben Konrath <ben@bagu.org>
2133 Rename GlomField to DataItem and update associated methods.
2135 This is a rename-only refactor. No functionality has been added or
2138 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2139 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2140 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2141 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2142 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2143 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2144 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2145 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2147 * src/main/java/org/glom/web/server/database/DBAccess.java:
2148 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2149 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2150 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2151 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2152 * src/main/java/org/glom/web/shared/DataItem.java:
2153 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2154 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2156 2011-09-23 Ben Konrath <ben@bagu.org>
2158 Rename GlomDocument to DocumentInfo and update associated methods.
2160 This is a rename-only refactor. No functionality has been added or
2163 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2164 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2165 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2166 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2167 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2169 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2171 2011-09-20 Ben Konrath <ben@bagu.org>
2173 Require java-libglom 1.17.3.
2175 This picks up the fix for the seg fault problem with the Scenes table
2176 in the Openismus Film Manager example.
2180 2011-09-20 Ben Konrath <ben@bagu.org>
2182 Change the way sort clause is added for primary key when no sort clause is requested.
2184 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2185 before the sort clause is created. When a sort clause is not requested, the
2186 sort clause is created by finding the primary key in the LayoutFieldVector
2189 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2191 2011-09-20 Ben Konrath <ben@bagu.org>
2193 Log error message if no documents are found in the configured directory.
2195 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2196 Extract the glom file extension string to a private static final class
2197 variable (mostly as syntactic sugar). Accept a minor formatting change.
2198 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2199 the example glom.document.directory configuration property to make it
2200 more clear that it can any directory, not just the home directory.
2202 2011-09-18 Ben Konrath <ben@bagu.org>
2204 Add related lists to details view.
2206 The related list table has support for paging and sorting just like the
2207 table in the list view.
2209 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2210 SQL queries for the related list tables.
2211 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2212 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2214 Rename getList methods to getListView and add comments. Remove
2215 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2216 it being unused. Add methods: getDetailsLayoutAndData(),
2217 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2218 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2219 Create the layout and set the data for the fields in one async call
2220 instead of two. Create related lists where appropriate.
2221 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2222 for method name changes in OnlineGlomService.
2223 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2224 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2225 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2227 * src/main/java/org/glom/web/client/ui/ListView.java:
2228 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2229 tableName from setCellTable(). Create a ListViewTable instead of
2231 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2232 represent a data field in the details view.
2233 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2234 from addDetailsCell() to Field class. Keep track of the Fields and
2235 Portals in the details view.
2236 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2237 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2238 and add a method to get it. Add method to set the contents of the
2240 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2241 New class for related list tables. This class has the data provider
2242 for the related list table.
2243 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2244 abstract class which is the base class for the ListViewTable and the
2246 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2247 New class for list view tables. This class has the data provider for
2248 the list view table.
2249 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2250 methods for related list tables. Add more information to the
2251 LayoutItemField and LayoutItemPortal DTOs.
2252 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2253 Remove debugging print statement.
2254 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2255 Remove debugging print statements. Add primary key field to SQL count
2257 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2258 Remove unnecessary LayoutFieldVector parameter from
2259 getResultSizeOfSQLQuery() method.
2260 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2261 New class for related list table database access.
2262 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2263 class that is a wrapper DTO for details view layout and data.
2264 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2265 new 'fromField' string to this DTO.
2266 * src/main/webapp/style.css: Remove bottom margin and override top
2269 2011-09-15 Ben Konrath <ben@bagu.org>
2271 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2273 This sets things up to make it easier to add the data retrieval for
2274 related lists (portals). No user noticeable changes were made with
2277 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2278 class has the code to retrieve the layouts and access the
2279 database using the new database helper classes.
2280 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2281 Most of the functionality has been removed from this class. This
2282 class now represents the public interface for the client side
2283 code. It also deals with configuring the servlet and cleaning
2284 things up when the servlet is stopped.
2285 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2286 of static methods into this utility class.
2287 * src/main/java/org/glom/web/server/database/DBAccess.java:
2288 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2289 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2290 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2291 These classes have the database retrieval code. The class hierarchy
2292 has been setup to make it easy to reuse code for similar
2295 2011-09-06 Ben Konrath <ben@bagu.org>
2297 Create separate classes for list table code and the data provider.
2299 As part of this refactor, I also split up the code a bit to make it
2302 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2303 table code to two new classes (below).
2304 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2305 with code from ListViewImpl.
2306 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2307 New file with code from ListViewImpl.
2309 2011-09-06 Ben Konrath <ben@bagu.org>
2311 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2313 This fixes the LayoutItemPortal DTO to match the libglom layout object
2316 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2318 2011-09-01 Ben Konrath <ben@bagu.org>
2320 Set title of Portals in the Details View.
2322 * pom.xml: Bump required version of java-libglom to 1.17.1.
2323 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2324 widget creation to its own class. Add comments to constructor.
2325 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2326 The code is mostly from the Group class with the title now set.
2327 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2328 title of Portal. Update some comments. Fix some code formatting.
2330 2011-09-01 Ben Konrath <ben@bagu.org>
2332 Remove TODO comment for the flow table column width.
2334 The flow table column width is working correctly and doesn't need to be
2335 changed. See this mailing list post for more info:
2337 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2339 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2341 2011-08-27 Ben Konrath <ben@bagu.org>
2343 Add document title (database name) to top of the browser page.
2345 I added the document title to the TableSelecitonView but that will
2346 change if / when we add a view that doesn't require table selection.
2348 * mockups/details-contacts.html:
2349 * mockups/details-projects.html:
2350 * mockups/listview-contacts.html:
2351 * mockups/listview-projects.html:
2352 * mockups/style.css: Add document title to mockups to keep things
2354 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2355 sizes to account for the document title.
2356 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2357 Set the document title when it has been retrieved from the server.
2358 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2359 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2360 and implement setDocumentTitle(String) method.
2361 * src/main/webapp/style.css: Add ID for document title style.
2363 2011-08-25 Ben Konrath <ben@bagu.org>
2365 Add NavigationType enum to LayoutItemPortal DTO.
2367 This is the start of adding support for Portals to the Details View.
2369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2370 LayoutItem_Portal.navigation_type enum from libglom to
2371 LayoutItemPortal.NavigationType enum.
2372 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2373 NavigationType enum, field for storing the NavigationType and getter
2376 2011-08-25 Ben Konrath <ben@bagu.org>
2378 Implement the flow table layout in the Details View.
2380 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2381 FlowTable to Group to account for the renamed class.
2382 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2383 File. This is a container widget that implements the Glom details view
2384 flow table behaviour.
2385 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2386 org/glom/web/client/ui/FlowTable.java.
2387 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2388 so that the size of the subgroups are a closer match to the size of
2389 the Glom subgroups. This makes the flowtable layout match the layout
2390 in Glom for the Music Collection example file.
2392 2011-08-16 Ben Konrath <ben@bagu.org>
2394 Create container element for LayoutItemPortal in Details View.
2396 This will help me develop the layout for the FlowTable.
2398 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2399 fieldPanel variable to detailsCell.
2401 2011-08-15 Ben Konrath <ben@bagu.org>
2403 Set the height of the data element in the Details View.
2405 I changed the InlineLabels (text in a span element) to Labels (text in
2406 a div element) so that I could set the height of the details-data
2407 elements instead of the details-cell parent elements. This allows the
2408 the details-data element to display the correct height if style is
2409 applied that shows the height.
2411 This change has the added benefit of allowing the order of the labels
2412 and data elements to be changed for right-to-left languages.
2414 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2415 InlineLabels to Labels.
2416 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2417 InlineLabels to Labels. Set the height of the data element.
2418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2419 multiline text height in the Formatting DTO.
2420 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2421 for multiline height along with getter and setter methods.
2422 * src/main/webapp/style.css: Adjust style to account for the change
2423 from span elements to div elements in the details cell.
2425 2011-08-15 Ben Konrath <ben@bagu.org>
2427 Make the List View appearance match the mockups.
2429 It doesn't match exactly but it's much better than it was.
2431 * mockups/listview-contacts.html: Remove unused css classes.
2432 * mockups/listview-projects.html: Remove unused css classes.
2433 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2434 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2435 for mainPanel instead of VerticalPanel (table). Set style name on
2436 CellTable. Set style name on Details column. Right-align Details
2438 * src/main/webapp/style.css: Adjust properties to match the mockups.
2440 2011-08-12 Ben Konrath <ben@bagu.org>
2442 Add better support for subgroups in the details view.
2444 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2445 changed FlowTable constructor.
2446 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2447 support for subgroups and subgroup-titles.
2448 * src/main/webapp/style.css: Add CSS class for subgroups and
2451 2011-08-12 Ben Konrath <ben@bagu.org>
2453 Return the top level LayoutGroup title.
2455 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2457 2011-08-11 Ben Konrath <ben@bagu.org>
2459 Make the TableSelector header match the mockup.
2461 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2462 the layout panel. Properly lineup the table selection header with
2463 the list and details view.
2464 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2465 margin around the details view.
2466 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2467 Rename listBox variable to tableSelector. Set id for the style sheet.
2468 Use a FlowPanel instead of a HorizontalPanel.
2469 * src/main/webapp/style.css: Add properties to make the TableSelector
2470 box match the mockups.
2472 2011-07-13 Ben Konrath <ben@bagu.org>
2474 Update install script for java-libglom version change.
2476 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2479 2011-07-13 Ben Konrath <ben@bagu.org>
2481 Add support sub-group in the details view.
2483 I also removed the code that special-cased the default details view
2486 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2488 I still have to make a proper flowtable.
2490 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2491 Don't special-case default details view layout.
2492 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2493 addLayoutField() as I'm going to use it.
2494 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2495 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2497 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2498 extracted from DetailsViewImpl.GroupPanel. Add support for
2500 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2501 column count when getting the details layout.
2503 2011-07-12 Ben Konrath <ben@bagu.org>
2505 Set browser title with database and table titles.
2507 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2508 Set the browser title when the table changes and when the activity
2510 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2511 title when retrieving document info (the GlomDocument object).
2512 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2513 with getter and setter methods. Remove unused convenience constructor.
2514 Use default code formatting.
2516 2011-07-12 Ben Konrath <ben@bagu.org>
2518 Ignore LayoutItemPortals in the details view.
2520 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2523 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2524 LayoutItemPortal layout objects.
2525 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2526 LayoutItemPortal objects when retrieving the details layout.
2527 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2528 file. This is an empty class and just used to get type information for
2531 2011-07-12 Ben Konrath <ben@bagu.org>
2533 Use java-libglom 1.17.0.
2537 2011-07-11 Ben Konrath <ben@bagu.org>
2539 Remove "Table:" label from table selector.
2541 This matches a recent change in the Glom UI.
2543 * mockups/details-contacts.html:
2544 * mockups/details-projects.html:
2545 * mockups/listview-contacts.html:
2546 * mockups/listview-projects.html: Remove the "Table:" label from the
2548 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2550 2011-07-11 Ben Konrath <ben@bagu.org>
2552 Add main groups to the details view.
2554 This makes things look a little nicer in the details view. The next step
2555 is to implement the flowtable.
2557 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2558 resources from the standard gwt css theme. Standard.css is now
2559 included in OnlineGlom.html so that the online glom css rules have
2560 precedence over the gwt theme.
2561 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2562 the whole LayoutGroup to the DetailsView instead of just the titles.
2563 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2564 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2565 details layout with a helper class (GroupPanel). I might extract this
2566 class when I make the full flowtable.
2567 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2568 string as default so I don't have to worry about NPEs when processing
2570 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2571 note beside OnlineGlom.gwt.xml above).
2572 * src/main/webapp/style.css: Add default font-size to body to override
2573 the font-size set by the standard theme. Don't use h2 tags for
2574 group-title. Create new details-cell class.
2576 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2578 ConfiguredDocument: Set the port number too.
2580 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2581 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2582 Glom document. Presumably this worked sometimes so far because there is a
2583 default port number.
2585 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2587 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2589 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2590 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2591 correct, though we should throw an exception too.
2593 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2595 Fix a addDocuemnt typo.
2597 * src/main/java/org/glom/web/shared/Documents.java
2598 (Documents.addDocuemnt): Rename to addDocument().
2599 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2600 (OnlineGlomServiceImpl.getDocuments): Adapt.
2602 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2604 Slightly improved log output when connection fails.
2606 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2607 (ConfiguredDocument.setUsernameAndPassword):
2608 We don't know for sure if it' the username/password that's wrong, so
2609 rephrase the message.
2610 Also ouput the exception message, though it's generic in this case.
2612 2011-07-08 Ben Konrath <ben@bagu.org>
2616 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2617 added braces to a one line if statement because the Eclipse formatter
2618 was getting confused.
2620 2011-07-07 Ben Konrath <ben@bagu.org>
2622 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2624 These should really be two separate tasks but I counldn't get things to
2625 work with GWT 2.2.0 and Eclipse 3.7.
2629 * .settings/org.eclipse.jdt.core.prefs:
2630 * .settings/org.eclipse.jdt.ui.prefs:
2631 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2632 * .settings/org.eclipse.m2e.core.prefs:
2633 Add new config files. Update current files. Remove references to the
2634 webtools plugins as we're not using any of the webtools features.
2635 * .gitignore: Add logs directory which is created when running with
2637 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2638 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2639 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2641 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2643 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2645 onlineglom.properties: Add explanatory comments.
2647 * src/main/resources/onlineglom.properties: Also change the default user
2648 from ben to someuser, to avoid the risk of people thinking we just
2649 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2651 2011-06-28 Ben Konrath <ben@bagu.org>
2653 Use filename in Log for incorrect passwords.
2655 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2656 getFileName(String) method to get the filename from the URI.
2658 2011-06-28 Ben Konrath <ben@bagu.org>
2660 Add the table name to the URL token for the ListPlace.
2662 This makes things consistent between the DetailsPlace and the
2663 ListPlace. It also allows the the ListPlace to be bookmarked.
2665 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2666 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2668 Remove getDefaultListLayout(). The default layout is now returned
2669 by the getListLayout() method when the table name is an empty string.
2670 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2671 Add table name field. Change to a new ListPlace when the table
2672 has been changed. Use getListLayout() for getting the default
2674 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2675 Add table name field. Set the correct table name in the list box
2676 when loading from bookmark. This corrects a problem for the
2678 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2679 Move table name to super-class (HasSelectableTable). Move document
2680 and table URL keys to super-class in HasSelectableTable.
2681 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2682 Add table name field. Add Tokenizer class with URL key common to
2683 the subclasses (DetailsPlace and ListPlace).
2684 * src/main/java/org/glom/web/client/place/ListPlace.java:
2685 Add table name. Add code to parse the URL token.
2686 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2687 Update ListPlace construction with empty table name string.
2688 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2689 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2690 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2691 Update ListPlace construction with table name string.
2692 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2693 Change defaultTableName field to tableName to reflect how it's now
2694 used. Update the getter and setter methods.
2696 2011-06-28 Ben Konrath <ben@bagu.org>
2698 Enable the table selector in the DetailsView.
2700 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2701 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2702 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2703 Remove getDefaultDetailsLayout(). The default layout is now returned
2704 by the getDetailsLayout() method when the table name is an empty
2706 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2707 event handler for table change event. Change to using
2708 getDetailsLayout() for the default details layout.
2709 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2711 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2712 when navigating to the details place.
2714 2011-06-27 Ben Konrath <ben@bagu.org>
2716 Use filename based unique document ID in URL and for RPC.
2718 The document ID is the glom document name with spaces (' ') replaced
2719 with pluses ('+') and without the .glom extension.
2721 This change is mostly a string substitution of 'documentTitle' for
2722 'documentID'. The only code change is the addition of a Documents DTO to get the
2723 filename to document title mappings as indicated below.
2725 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2726 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2727 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2728 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2729 Use Documents DTO to create the document links in the document
2731 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2732 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2733 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2734 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2735 * src/main/java/org/glom/web/client/place/ListPlace.java:
2736 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2737 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2738 * src/main/java/org/glom/web/client/ui/ListView.java:
2739 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2740 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2741 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2742 * src/main/java/org/glom/web/server/Log.java:
2743 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2744 getDocumentTitles() to getDocuments() and return the Documents DTO.
2745 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2746 transferring the filename to document title mappings.
2748 2011-06-25 Ben Konrath <ben@bagu.org>
2750 Make the authentication popup work again.
2752 This bug was introduced when I extracted ConfiguredDocument to its own class.
2754 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2755 correct success / fail status in setUsernameAndPassword().
2757 2011-06-25 Ben Konrath <ben@bagu.org>
2759 Use filename as unique key for configuring database usernames and passwords.
2761 This replaces the use of the Glom document title which could change
2762 depending on the locale. Thanks to Murray Cumming for pointing out this
2765 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2766 * src/main/resources/onlineglom.properties:
2768 2011-06-24 Ben Konrath <ben@bagu.org>
2770 Pass primary key value to DetailsView.
2772 This enables the DetailsView to load the correct data.
2774 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2775 primary key value field and set in constructor. Pass primary key
2776 value to getDetailsData().
2777 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2778 variables for document title and primary key value.
2779 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2780 key value to the DetailsPlace.
2782 2011-06-24 Ben Konrath <ben@bagu.org>
2784 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2786 This allows the primary key to be retrieved by the Details button. This
2787 functionality has not been implemented yet but it's in the works.
2789 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2790 the LayoutGroup result to ListView.setCellTable instead of all of its
2791 fields individually.
2792 * src/main/java/org/glom/web/client/ui/ListView.java:
2793 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2794 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2795 get the primary key for the table.
2796 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2797 index of the primary key in the LayoutGroup accounting for hidden
2798 primary keys. Rename getJavaNumberFormat() to
2799 convertToJavaNumberFormat() for consistency. Cleanup / add some
2801 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2802 field for primary key index and a field to indicate whether the
2803 primary key is hidden or not.
2805 2011-06-23 Ben Konrath <ben@bagu.org>
2807 Rename getTableData methods to getListData.
2809 This is a rename refactor for consistency with other methods.
2811 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2812 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2813 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2816 2011-06-23 Ben Konrath <ben@bagu.org>
2818 Extract the ConfiguredDocument innerclass into its own class.
2820 This makes the servlet code more object oriented.
2822 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2823 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2825 new ConfiguredDocument class.
2827 2011-06-21 Ben Konrath <ben@bagu.org>
2829 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2831 This makes things more inline with how libglom works and reduces code
2832 duplication. This refactor lays the groundwork for adding the primary key to
2833 the LayoutGroup object.
2835 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2836 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2837 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2838 Change method names to getListLayout and getDefaultListLayout for
2839 consistency. Use LayoutGroup as the DTO for the list layout instead of
2840 ColumnInfo and LayoutListTable.
2841 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2842 new method names along with the LayoutGroup object for transferring the
2844 * src/main/java/org/glom/web/client/ui/ListView.java:
2845 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2846 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2847 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2849 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2850 Replaced with LayoutGroup.
2851 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2852 expectedResultSize and defaultTableName fields which are needed for
2854 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2855 type field which is needed for the list layout but will also be
2856 useful for the details layout as things progress.
2857 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2858 Make class abstract. Remove the unnecessary
2859 getFormattingHorizontalAlignment method. Add setFormatting method.
2861 2011-06-16 Ben Konrath <ben@bagu.org>
2863 Add scripts for building and installing war.
2865 These will help when updating OnlineGlom but they're also good
2866 supplemental documentation of the build and deployment proceeding.
2868 * utils/build-onlineglom-war.sh: New file.
2869 * utils/install-onlineglom-war.sh: New file.
2871 2011-06-16 Ben Konrath <ben@bagu.org>
2873 Create wrapper class to create consistent log messages.
2875 I wrapped methods in the Log class of gwt-log to add the method names
2876 from the servlet and create consistent formatting of the document title
2877 and table names in the log messages.
2879 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2880 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2881 log methods to use methods from wrapped Log class.
2883 2011-06-16 Ben Konrath <ben@bagu.org>
2885 Remove superfluous conditional return.
2887 Thanks to Murray Cumming for pointing this out!
2889 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2891 2011-06-15 Ben Konrath <ben@bagu.org>
2893 Return an ArrayList of LayoutGroups for the Details layout.
2895 This corrects a problem with the details layout as it can have more
2896 than one top level LayoutGroup.
2898 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2899 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2900 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2901 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2902 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2903 with ArrayList of LayoutGroups for the details view layout.
2904 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2905 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2906 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2907 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2908 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2909 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2911 2011-06-14 Ben Konrath <ben@bagu.org>
2913 Use cast_dynamic method to determine the libglom LayoutItem type.
2915 This is better than finding the LayoutItem type by using the string
2916 returned from the get_part_type_name() method.
2918 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2920 2011-06-14 Ben Konrath <ben@bagu.org>
2922 Add method names to log entries in the servlet.
2924 This helps when tracking down deployment problems.
2926 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2928 2011-06-14 Ben Konrath <ben@bagu.org>
2930 Add data to the DetailsView using a hard-coded primary key value.
2932 The layout and functionality of the DetailsView is not complete. This
2933 is just a checkpoint so the patch doesn't get too big.
2935 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2936 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2937 Add getDetailsData() servlet method.
2938 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2939 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2940 LayoutFields are added to the DetailsView.
2941 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2942 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2943 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2944 take the string for the title instead of the object.
2945 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2946 Add implementation getDetailsData() along with some private helper
2948 * src/main/webapp/style.css: Add padding to details-data class. Add a
2949 details-label class with the same padding as the details-data class.
2951 2011-06-03 Ben Konrath <ben@bagu.org>
2953 Use presenter.goTo() to change to the DetailsPlace.
2955 This will make things easier when we need to open the DetailsView with
2956 data specific to the row that was clicked.
2958 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2960 2011-06-02 Ben Konrath <ben@bagu.org>
2962 Add CSS file from mockups.
2964 I'm adding this now because it's going to be useful to have when
2965 developing the DetailsView. The TableSelectionView and ListView aren't
2968 * src/main/webapp/OnlineGlom.html:
2969 * src/main/webapp/style.css:
2971 2011-06-02 Ben Konrath <ben@bagu.org>
2973 Use String.isEmpty() to check for empty string.
2975 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2977 2011-06-02 Ben Konrath <ben@bagu.org>
2979 Display main layout group titles in the DetailsView.
2981 This is the start of the DetailsActivity/DetailsView implementation.
2983 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2984 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2985 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2986 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2987 Get the layout information for the details view from the server and set
2988 the main layout group titles.
2989 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2990 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2991 Add addLayoutGroup() and addLayoutField() methods. This are just
2992 temporary methods for creating the the details view that will change
2994 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2995 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2997 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2998 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2999 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
3000 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
3001 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3002 Data Transfer Objects that mimic the libglom object structure. These are
3003 used for transferring the details layout but could also be used for
3004 transferring the list layout.
3006 2011-05-27 Ben Konrath <ben@bagu.org>
3008 Reset the AuthenticationPopup when clearing the ListView.
3010 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3012 2011-05-27 Ben Konrath <ben@bagu.org>
3014 Fix problem with onlineglom.properties file loading.
3016 The old way worked in Eclipse but not on the server. Loading the
3017 onlineglom.properties file now works in Eclipse and on the server.
3019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3021 2011-05-24 Ben Konrath <ben@bagu.org>
3023 Update gwt-log from 3.1.0 to 3.1.2.
3025 Gwt-log 3.1.0 has been marked as depreciated.
3029 2011-05-24 Ben Konrath <ben@bagu.org>
3031 Add comment to ListActivity.goTo() method.
3033 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3035 2011-05-24 Ben Konrath <ben@bagu.org>
3037 Remove FIXME in convertGdkColorToHtmlColour()
3039 The Gdk::Color value returned by libglom is 16-bits per channel on both
3040 64 and 32-bit platforms.
3042 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3044 2011-05-19 Ben Konrath <ben@bagu.org>
3046 Improve performance of initial ListView load.
3048 I removed a round trip to the server for getting the default table name
3049 and then requesting information about that table. This also removes a potential
3050 problem with the table change handler not being setup in time to receive the
3051 table change event from the ListActivity.
3053 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3054 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3055 getDefaultLayoutListTable() method. Improve comments.
3056 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
3057 getDefaultLayoutListTable() method instead of firing a table change
3058 event to get the table to load.
3059 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3060 implementation of getDefaultLayoutListTable() method.
3061 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3064 2011-05-19 Ben Konrath <ben@bagu.org>
3066 Override toDebugString() in TableChangeEvent.
3068 This is useful to have for debugging.
3070 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3072 2011-05-19 Ben Konrath <ben@bagu.org>
3074 Add a "Back to List" link when at the DetailsPlace.
3076 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3077 Populate the CellTable based on the selected table of the ListBox if
3078 it's set otherwise use the default table. This allows the "Back to
3080 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3081 Remove Place from constructors. Add a setPlace() method. Add
3082 goToPlace() method. Set class as presenter for TableSelectionView.
3083 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3084 Use the same TableSelectionActivity when switching between the List and
3086 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3087 Subclass the new HasSelectableTablePlace. This removes some duplicate
3089 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3090 New class to represent Places that display the TableSelectionView.
3091 * src/main/java/org/glom/web/client/place/ListPlace.java:
3092 Subclass the new HasSelectableTablePlace. This removes some duplicate
3094 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3095 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3096 Add Presenter interface. Add setBackLinkVisible() method. Add
3097 setBackLink() method.
3099 2011-05-18 Ben Konrath <ben@bagu.org>
3101 Enable the "Details" buttons.
3103 Right now only an empty details view is displayed.
3105 * src/main/java/org/glom/web/client/ClientFactory.java:
3106 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3107 Add DetailsView to ClientFactory.
3108 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3109 A basic activity for the details view.
3110 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3111 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3113 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3114 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3116 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3117 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3118 unnecessary super() in constructor.
3119 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3120 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3121 really shouldn't create a new TableSelectionActivity for both the ListPlace
3122 and the DetailsPlace so this should be considered a temporary solution.
3123 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3124 New file. Represents a URL for the details view.
3125 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3126 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3127 A basic details view interface and implementation.
3128 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3129 Enable the "Details" buttons.
3131 2011-05-12 Ben Konrath <ben@bagu.org>
3133 Use a LayoutPanel with multiple display areas for main layout.
3135 This is mostly a refactor in that there are no changes from the user
3136 point of view. These changes are required so that we can swap out the list view
3137 with the details view when the user clicks the "Details" button.
3139 * src/main/java/org/glom/web/client/ClientFactory.java:
3140 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3141 OnlineGlomView. Add TableSelectionView, ListView and
3142 AuthenticationPopup.
3143 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3144 for main layout. Add display regions for main activities. Add
3145 activity manager for for main activities.
3146 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3147 file from parts of the deleted OnlineGlomActivity.
3148 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3149 New file from parts of the deleted OnlineGlomActivity.
3150 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3151 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3152 New files for app wide table change event.
3153 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3154 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3155 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3156 Activity mappers for the main activities replace the deleted app-wide
3158 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3159 Fix a spelling error in he comment.
3160 * src/main/java/org/glom/web/client/ui/ListView.java:
3161 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3162 Renamed from LayoutListView and modified for MVP. This still not a
3163 proper dumb view as prescribed by the MVP pattern but it works for now.
3164 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3165 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3166 New widget stripped out of the deleted OnlineGlomView.
3167 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3168 Remove hack that is fixed by this patch.
3170 2011-05-06 Ben Konrath <ben@bagu.org>
3172 Rename OnlineGlomPlace to ListPlace.
3174 The only change besides the rename is that url will now display #list
3175 instead of #Document.
3177 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3178 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3179 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3180 * src/main/java/org/glom/web/client/place/ListPlace.java:
3181 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3183 2011-05-06 Ben Konrath <ben@bagu.org>
3185 Use Presenter for app navigation.
3187 This is the proper way to deal with Place (URL) changes with the MVP
3190 * src/main/java/org/glom/web/client/ClientFactory.java:
3191 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3192 PlaceHistoryMapper and PlaceHistoryHandler.
3193 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3194 PlaceHistoryMapper and PlaceHistoryHandler.
3195 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3196 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3197 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3198 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3199 Add Presenter interface and setPresenter methods. Rename addHyperLink
3200 to addDocumentLink taking only the document title as a parameter.
3202 2011-04-14 Ben Konrath <ben@bagu.org>
3204 Prompt for db username/password if they haven't been set.
3206 This is implemented with a popup widget that is contained within the
3207 OnlineGlomView and managed by the OnlineGlomActivity.
3209 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3210 methods for checking and setting the database username and password.
3211 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3212 new methods for checking and setting the database username and
3214 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3215 Display authentication popup if the JDBC connection to the database
3216 has not been authenticated.
3217 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3219 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3220 for dealing with the authentication popup.
3221 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3222 Implement the methods for dealing with the authentication popup.
3223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3224 try to executed queries if the database connection hasn't been
3225 authenticated. Implement methods for checking and setting the
3226 database username and password.
3228 2011-04-12 Ben Konrath <ben@bagu.org>