1 2012-07-20 Murray Cumming <murrayc@murrayc.com>
3 Use slf4j-simple to see JDBC errors.
5 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
7 2012-07-19 Murray Cumming <murrayc@murrayc.com>
9 SelfHoster.discoverFirstFreePort(): Close the socket.
11 * src/test/java/org/glom/web/server/SelfHoster.java:
12 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
14 2012-07-19 Murray Cumming <murrayc@murrayc.com>
16 Avoid another code warning in Eclipse Juno.
18 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
19 Do instanceof checks on the FileUtils.listFiles() result and its
22 2012-07-13 Murray Cumming <murrayc@murrayc.com>
24 Avoid some code warnings in Eclipse Juno
26 * src/main/java/org/glom/web/server/libglom/Document.java:
27 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
28 * src/test/java/org/glom/web/server/SelfHoster.java
29 createTextFile(): Make sure that the FileOutputStream is closed.
31 2012-06-22 Murray Cumming <murrayc@murrayc.com>
33 Added OnlineGlomPropertiesTest.
35 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
36 Make sure we never return a null string.
37 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
38 Added tests of the OnlineGlomProperties API, using our sample file.
40 2012-06-20 Murray Cumming <murrayc@murrayc.com>
42 Make OnlineGlomProperties be a normal class.
44 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
45 Move OnlineGlomProperties into its own file to be a regular class:
46 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
47 This makes testing simpler.
49 2012-06-15 Murray Cumming <murrayc@murrayc.com>
51 OnlineGlomServiceImpl.init(): Move some code into a new method.
53 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
56 2012-06-15 Murray Cumming <murrayc@murrayc.com>
58 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
60 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
61 OnlineGlomProperties.getKey(): Make this more robust by moving the
62 check for *.*.filename to here.
64 2012-06-15 Murray Cumming <murrayc@murrayc.com>
66 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
68 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
69 init(): Move knowledge of the config file format into the
70 OnlineGlomProperties inner class.
72 2012-06-15 Murray Cumming <murrayc@murrayc.com>
74 SelfHostExampleTest: Make sure we cleanup on failure.
76 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
77 the use of cleanup() to a tearDown() JUnit method.
79 2012-06-12 Murray Cumming <murrayc@murrayc.com>
81 ConfiguredDocument: Add a primary key to portals at least once.
83 * src/main/java/org/glom/web/server/ConfiguredDocument.java
84 updatePortalsExtras): Fix a typo so that we add the primary key
86 This is a fix for the previous commit:
87 ConfiguredDocument: Do not add a primary key to portals each time.
89 2012-06-08 Murray Cumming <murrayc@murrayc.com>
91 SelfHoster: Avoid some compiler warnings.
93 * src/test/java/org/glom/web/server/SelfHoster.java
94 executeCommandLineAndWait():
95 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
96 the now-unused streams for stdout and stderr from the command Processes.
97 These are not used because readln() hangs while waiting for a new line,
98 where there may be no next line. The commented out code is still there
99 to help us figure out how to do this properly.
101 2012-06-08 Murray Cumming <murrayc@murrayc.com>
103 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
105 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
106 Make this actually test the cloning again, though it is not very useful
107 now that we do not use the part that had a problem with cloning before.
109 2012-06-08 Murray Cumming <murrayc@murrayc.com>
111 SelfHoster: Keep trying pg_ctl after starting postgres.
113 * src/test/java/org/glom/web/server/SelfHoster.java
114 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
115 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
116 regular Glom. This seems mad but it seems to work because the first
117 command would fail if pg_ctl would eventually fail.
119 2012-06-08 Murray Cumming <murrayc@murrayc.com>
121 SelfHoster: Wait until the server is really ready.
123 * src/test/java/org/glom/web/server/SelfHoster.java
124 selfHost(): Attempt the connection after starting the server, retrying
125 a few times if necessary, so that the server is really ready already when
126 we return from this method.
127 The regular Glom code does this too because pg_ctl reports success too soon.
129 2012-06-08 Murray Cumming <murrayc@murrayc.com>
131 ConfiguredDocument: Do not add a primary key to portals each time.
133 * src/main/java/org/glom/web/server/ConfiguredDocument.java
134 updatePortalsExtras(): Only add an extra primary key field if there is
135 none, to avoid adding one each time we retrieve the details layout from the
137 This should fix bug #676986 (Ben Konrath)
139 2012-05-25 Murray Cumming <murrayc@murrayc.com>
141 Document.load(): Support version 7 documents.
143 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
144 database_title attribute if the title attribute is not there.
147 2012-05-24 Ben Konrath <ben@bagu.org>
149 Add configuration for auto-generating mvn:i18n from with Eclipse.
151 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
153 2012-05-24 Murray Cumming <murrayc@murrayc.com>
155 Update translations, adding French.
157 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
158 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
159 Add a French translation, using the translation from Glom.
161 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
162 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
163 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
164 Update these based on the translations from Glom.
166 2012-05-24 Murray Cumming <murrayc@murrayc.com>
168 SelfHoster: Add some debug println messages to help when things fail.
170 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
171 System.out.println() lines.
173 2012-05-23 Murray Cumming <murrayc@murrayc.com>
175 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
177 * src/test/java/org/glom/web/server/SelfHoster.java:
178 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
179 instance) instead of just /usr/bin (as on Fedora). Check the result when
182 2012-05-23 Murray Cumming <murrayc@murrayc.com>
184 Remove LayoutItemPortal.get/setNavigationTable().
186 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
187 Remove get/setNavigationTable(), which is only a cache, because it is not
188 used, and does not need to be used, because that decision should be made on
190 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
191 updatePortalsExtras():
192 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
193 getNavigationRecord():
194 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
197 2012-05-21 Murray Cumming <murrayc@murrayc.com>
199 Initial self-hosting for tests.
201 * pom.xml: Change the scope for log4j, to hopefully make it
202 available to the test code which uses it indirectly via jOOQ.
203 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
204 self-hosting, though we only use it for testing.
206 * src/main/java/org/glom/web/server/libglom/Document.java:
207 example rows: Use a map instead of a list for each row of values,
208 so we know what field they are for, instead of relying on the sequence
209 being correct. This is not very efficient, but it does not really need
211 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
212 testReadTableExampleRows(): Adapted.
214 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
215 that returns an Object, for generic use. Note that Object seems to be
216 the implicit base even of double.
217 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
218 for use in CREATE TABLE SQL queries.
219 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
220 to do self-hosting of PostgreSQL databases via its command-line
221 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
222 backends/postgres_self.cc. This is incomplete - it needs more
223 warnings about failures and it needs to clean up properly when things
225 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
226 test of this new class.
228 2012-05-21 Murray Cumming <murrayc@murrayc.com>
230 Document: loading example data: Handle exceptions.
232 * src/main/java/org/glom/web/server/libglom/Document.java:
233 DateFormat.parse() and Double.valueOf() can throw exceptions, though
234 Eclipse did not warn about that.
236 2012-05-20 Murray Cumming <murrayc@murrayc.com>
238 Document: load(), save(): Handle the example rows.
240 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
242 * src/main/java/org/glom/web/server/libglom/Document.java:
243 load(), save(): Load and save the example rows, though the date, time
244 and image types are not handled properly yet.
245 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
246 Add testReadTableExampleRows() just to check that something is read.
248 2012-05-20 Murray Cumming <murrayc@murrayc.com>
250 Document: Add save().
252 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
253 Added getTranslationsMap() for use while saving.
254 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
255 Adedd getUseDefaultFormatting() for use while saving.
256 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
257 and several private methods that it uses.
259 This will be useful while testing via self-hosting.
260 It is not complete, but should be complete enough for testing.
262 2012-05-17 Murray Cumming <murrayc@murrayc.com>
264 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
266 * src/main/java/org/glom/web/client/OnlineGlomService.java
267 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
268 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
269 Remove getSortedListViewData() and getSortedRelatedListData(), adding
270 the sort column index and ascending bool to the regular method.
271 Instead, a sort column index of -1 now means no sort.
272 This is less explicit, but it's fairly simple, reduces the amount of
273 code, and makes the OnlineGlomService API slightly smaller.
274 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
275 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
277 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
278 getListViewData(), getRelatedListData():
279 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
280 getListViewData(), getRelatedListData():
281 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
283 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
285 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
290 2012-05-16 Murray Cumming <murrayc@murrayc.com>
292 Use translations for top-level groups too.
294 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
295 updateTitlesForLocale(): Use the translation for the group
296 as well as for child items.
300 Just recompiled to fix a problem in the released .tar.gz file.
304 2012-05-15 Murray Cumming <murrayc@murrayc.com>
306 Corrections to navigation to related records.
308 * src/main/java/org/glom/web/client/OnlineGlomService.java:
309 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
310 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
311 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
312 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
313 relationship name, because the relationship name is not necessarily unique
315 TOOD: This is inefficient, because it passes the whole list of
316 child field items back to the server, but it is more correct, and happens
317 to fix a bug with the primary key being lost after a few navigations.
318 There is probably a chance to make this more efficient anyway in some
321 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
322 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
323 * src/main/java/org/glom/web/server/ConfiguredDocument.java
324 * src/main/java/org/glom/web/server/database/DBAccess.java
325 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
326 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
329 2012-05-15 Murray Cumming <murrayc@murrayc.com>
331 Fix the use of translations.
333 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
334 Add updateTitlesForLocale().
335 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
336 Call it to discard unwanted translations and to make getTitle() return
337 the wanted translation wihout the need for the client code to specify a locale.
338 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
339 getTitle(): Fallback to the original title, as libglom does.
341 2012-05-15 Murray Cumming <murrayc@murrayc.com>
343 Document: Correctly report the number of available translation locales.
345 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
346 the available locale IDs list.
347 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
348 testLocales: Test this.
350 2012-05-15 Murray Cumming <murrayc@murrayc.com>
352 SqlUtils: Use camelCase.
354 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
355 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
356 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
357 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
358 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
359 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
361 2012-05-15 Murray Cumming <murrayc@murrayc.com>
363 Use jOOQ's tableByName() and fieldByName.
365 * pom.xml: Use jOOQ 2.3.1 to get the new API.
366 * src/main/java/org/glom/web/server/SqlUtils.java:
367 build_sql_select_step_with_where_clause(), .createField(),
368 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
369 so we can get correct quoting and escaping. Thanks to Lukas Eder for
370 adding this, and other things, to jOOQ.
372 2012-05-15 Murray Cumming <murrayc@murrayc.com>
374 SqlUtils: Remove the Connection parameters.
376 * src/main/java/org/glom/web/server/SqlUtils.java:
377 build_sql_select_with_key(), build_sql_select_with_where_clause(),
378 createSelect(), build_sql_select_step_with_where_clause(),
379 build_sql_count_select_with_where_clause(),
380 build_sql_select_count_rows(): Remove the Connection parameter because
381 jOOQ does not actually need a connectionwhen it is just used to build
383 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
385 * src/main/java/org/glom/web/server/ReportGenerator.java:
387 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
389 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
390 Constructor, getListData(), getResultSizeOfSQLQuery():
391 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
392 getSelectQuery(), getCountQuery():
393 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
394 getSelectQuery(), getCountQuery():
395 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
396 getNavigationRecord(): Adapted.
398 2012-05-14 Murray Cumming <murrayc@murrayc.com>
402 * src/main/java/org/glom/web/server/SqlUtils.java:
403 get_find_where_clause_quick(): Use a comparison of
404 lowercase values, instead of a simple equals. Regular Glom
405 uses the PostgreSQL ILIKE operator but jOOQ does not
406 support that just yet, though it will soon.
408 2012-05-14 Murray Cumming <murrayc@murrayc.com>
410 TableToViewDetails: Use a real serialization ID.
412 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
413 Though this does not fix the serialization problem.
415 2012-05-12 Murray Cumming <murrayc@murrayc.com>
417 Added LayoutItemPortalDeepCloneTest.
419 2012-05-11 Murray Cumming <murrayc@murrayc.com>
421 Make navigation work again.
423 * src/main/java/org/glom/web/server/libglom/Document.java:
424 Add getLayoutItemFieldShouldHaveNavigation().
425 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
426 Replace get/setAddNavigation() with the partly-existing
427 get/setNavigationTableName(), with an empty string being no navigation,
428 because this is simpler. Use the new
429 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
431 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
432 Add updateFieldsExtras() and call setNavigationTableName in it.
433 getDetailsLayoutGroup(),
434 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
435 createLayout(): Adapted.
436 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
437 Constructor: Adapted.
439 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
440 Replace get/setAddNavigation() with get/setNavigation(), returning a
441 TableToViewDetails class with both the table name and UsesRelationship,
442 because both are need. The previous code used java-libglom's output
443 variable (strangely, via sharedptr) to return both, but we cannot really
445 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
446 getNavigationRecord(): Adapt. However, we cannot actually use the cache
447 here because it somehow gets set to null during deepCopy(). I must test this.
448 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
449 testGetSuitableTableToViewDetails(): Adapted.
451 TODO: Find out why deepClone() is not quite working.
453 2012-05-11 Murray Cumming <murrayc@murrayc.com>
455 DBAccess: Simplify the retrievel of full field details.
457 * src/main/java/org/glom/web/server/database/DBAccess.java
458 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
459 because the Document loading should have done this.
461 2012-05-11 Murray Cumming <murrayc@murrayc.com>
463 Document: Correct loading of doubly-related layout fields.
465 * src/main/java/org/glom/web/server/libglom/Document.java:
466 loadUsesRelationship(): Actually set the related relationship, instead
467 of only setting it if it's not found.
469 2012-05-09 Murray Cumming <murrayc@murrayc.com>
471 Replace all appearances of Colour with color.
473 Because US English is dominant.
475 2012-05-09 Murray Cumming <murrayc@murrayc.com>
477 Use colors in HTML format, solving a warning about an unused function.
479 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
480 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
481 Add *asHTMLColor() versions of methods.
482 TODO: However, we should create and cache the results on the server.
483 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
484 * src/main/java/org/glom/web/client/ui/list/ListTable.java
485 * src/main/java/org/glom/web/server/ConfiguredDocument.java
486 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
487 Use the asHTMLcolor() versions.
489 2012-05-09 Murray Cumming <murrayc@murrayc.com>
491 ListViewTable: Constructor: Take the table name as a parameter.
493 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
494 Constructor: Take the tableName, and set the member variable, because
496 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
497 setCellTable(): Pass the table name.
498 This makes navigation to non-default tables work again. I don't know
499 why it worked before in the master branch.
501 2012-05-07 Murray Cumming <murrayc@murrayc.com>
503 ConfiguredDocument: Restore correct addition of hidden primary key items.
505 * src/main/java/org/glom/web/client/ui/list/ListTable.java
506 (ListTable.createCellTable): Uncomment out the check for the hidden
508 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
509 add primary key items for top-level lists and portals, as before,
510 instead of adding them to each group.
511 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
512 Actually implement the extra methods such as setHiddenPrimaryKey() and
513 comment that these are used only for top-level list groups and in portals.
514 This strangeness suggests even more that this should not be squeezed
515 into the LayoutGroup class.
517 2012-05-07 Murray Cumming <murrayc@murrayc.com>
519 Fix Formatting loading.
521 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
522 getFormattingUsed(): Remove the duplicate Formatting member variable
523 in favour of the one from the base class.
524 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
525 Initialize a new Formatting instead of using null by default, so we
526 have some defaults, instead of having to initialize one later just to
527 get the same defaults. This also makes loading of formatting from the
528 document work, because that expected a non-null.
530 2012-05-07 Murray Cumming <murrayc@murrayc.com>
532 RelatedListTable: Make sure that the tableName is set.
534 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
535 Constructor: Take the tableName so it is available later. Otherwise,
536 the server assumes that we mean the default table and cannot find the
538 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
539 setData(): Pass the tableName to the RelatedListTable constructor.
541 2012-05-07 Murray Cumming <murrayc@murrayc.com>
545 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
546 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
547 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
549 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
551 * src/main/java/org/glom/web/server/database/DBAccess.java:
552 convertResultSetToDTO(), getPortal():
553 * src/main/java/org/glom/web/server/database/ListDBAccess.java
555 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
556 Add checks for null objects and out of range access, with log messages to
557 give hints so we can fix these properly.
559 2012-05-07 Murray Cumming <murrayc@murrayc.com>
561 Portals: some corrections.
563 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
565 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
566 constructor: Use getRelationshipNameUsed() instead of getName(), because
567 that is what is meant.
568 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
569 getFromField(): Fix a typo, to get the field name, not the table name.
570 * src/main/java/org/glom/web/server/database/DBAccess.java:
571 getPortal(): Fix a typo that stopped this from working.
573 2012-05-07 Murray Cumming <murrayc@murrayc.com>
575 LayoutItemPortal: Also override getTitleOriginal().
577 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
578 This lets the base getTitle() with no parameters work.
579 TODO: Test this properly.
581 2012-05-06 Murray Cumming <murrayc@murrayc.com>
583 LayoutItemPortal: getTitle*(): Use the relationship title.
585 2012-05-06 Murray Cumming <murrayc@murrayc.com>
587 LayoutItemField: Fix loading of custom titles.
589 * src/main/java/org/glom/web/server/libglom/Document.java
590 loadDataLayoutItemField(): The title, if any, instead of the field
591 title, is stored in a title_custom node. Load it from there.
592 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
594 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
595 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
596 getTitle*() overrides.
597 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
600 2012-05-06 Murray Cumming <murrayc@murrayc.com>
602 LayoutItemField: Fall back to field titles, so some are really shown.
604 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
605 Override getTitleOriginal() and getTitle(), as in java-libglom.
606 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
609 2012-05-06 Murray Cumming <murrayc@murrayc.com>
611 Correct use of setExpectedResultSize().
613 * src/main/java/org/glom/web/server/ConfiguredDocument.java
614 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
615 Use setExpectedResultSize only on top-level groups (for instance, the
616 list layout) or on child portals (in details views).
617 Use the correct table name for portals to avoid SQL errors.
618 Update the expected counts when returning cached layouts.
620 2012-05-06 Murray Cumming <murrayc@murrayc.com>
622 Document: Interpret no group column count as 1.
624 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
625 default, though we now check for this in the UI code anyway.
627 2012-05-06 Murray Cumming <murrayc@murrayc.com>
631 2012-05-06 Murray Cumming <murrayc@murrayc.com>
633 Translatable: Use Hashmap instead of Treemap because GWT supports it.
635 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
636 The use of Treemap lead to this error from async methods, with no
638 "The response could not be deserialized"
640 2012-05-06 Murray Cumming <murrayc@murrayc.com>
642 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
644 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
645 when using the Google -> GWT Compile, or
646 g toolbar button -> GWT Compile Project... feature in Eclipse.
648 2012-05-06 Murray Cumming <murrayc@murrayc.com>
650 ListTable.addColumn(): Protect against a null Formatting.
652 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
653 Create a default Formatting if it is null, because that is the simplest
656 2012-05-06 Murray Cumming <murrayc@murrayc.com>
658 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
660 * src/main/java/org/glom/web/server/ConfiguredDocument.java
661 updateLayoutGroup(): Check that the field is not null.
663 2012-05-06 Murray Cumming <murrayc@murrayc.com>
665 ListViewImpl: Protected against a bad cast error.
667 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
668 onEnterKeyDown(): Do not cast without an instanceof check.
670 2012-05-06 Murray Cumming <murrayc@murrayc.com>
672 ListTable: Protect against an out of range error.
674 * src/main/java/org/glom/web/client/ui/list/ListTable.java
675 createCellTable(): This is unlikely, but can happen while debugging.
677 2012-05-06 Murray Cumming <murrayc@murrayc.com>
679 AsyncMessage onFailure() callbacks: Log the exception message.
681 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
682 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
683 * src/main/java/org/glom/web/client/activity/ListActivity.java:
684 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
685 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
686 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
687 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
688 These are useful clues when something is wrong.
690 2012-05-06 Murray Cumming <murrayc@murrayc.com>
692 ConfiguredDocument: Avoid a null dereference.
694 * src/main/java/org/glom/web/server/ConfiguredDocument.java
695 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
696 details maps are created.
698 2012-05-06 Murray Cumming <murrayc@murrayc.com>
700 Document: Correct the port number parsing.
702 * src/main/java/org/glom/web/server/libglom/Document.java:
703 This lets us actually connect to the database and show the document.
705 2012-05-05 Murray Cumming <murrayc@murrayc.com>
709 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
710 user-interaction, asking us to load a temporary URL in a browser.s
711 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
712 which is apparently necessary for testing the service. See the comment.
713 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
714 Show the exception, if any. This is how I saw the 404 in the HTML in
717 2012-05-05 Murray Cumming <murrayc@murrayc.com>
719 DocumentTest: Move the .glom files into the resources directory.
721 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
722 URI via getResource().
724 2012-05-05 Murray Cumming <murrayc@murrayc.com>
726 Document: Remove the FieldIdentifies inner class.
728 * src/main/java/org/glom/web/server/libglom/Document.java: We only
729 use the Relationship (though the same function in libglom is maybe
730 used in other ways) and so this removes a compiler warning.
732 2012-05-05 Murray Cumming <murrayc@murrayc.com>
734 Document.load() Remove the error code parameter.
736 * src/main/java/org/glom/web/server/libglom/Document.java: load():
737 Remove the parameter. We do not set it yet and it could never have
738 worked as an output parameter (though maybe it did in java-libglom).
739 We could use an exception if we really want the failure reason.
740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
742 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
743 setUp(), testGetSuitableTableToViewDetails(): Adapt.
745 2012-05-05 Murray Cumming <murrayc@murrayc.com>
747 Make some inner classes static.
749 * src/main/java/org/glom/web/server/ConfiguredDocument.java
750 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
751 * src/main/java/org/glom/web/server/ReportGenerator.java
752 * src/main/java/org/glom/web/server/libglom/Document.java
753 Make all inner classes static that can be static.
755 2012-05-05 Murray Cumming <murrayc@murrayc.com>
757 OnlineGlomServiceImpl: Do not load and check for java-libglom.
759 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
760 init(): We do not use java-libglom any more.
762 2012-05-05 Murray Cumming <murrayc@murrayc.com>
764 Remove mentions of java-libglom.
766 * README: Remove mention of java-libglom, because it no longer needed.
767 * utils/build-onlineglom-war.sh:
768 * utils/check-and-recover-tomcat.py:
769 * utils/install-onlineglom-war.sh: Remove these as they are no longer
770 useful. Building is now far easier, with no need for jhbuild.
772 2012-05-05 Murray Cumming <murrayc@murrayc.com>
774 Fix the build (mvn package)
776 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
777 (LayoutGroup): Make the LayoutItemList inner class static and protected.
778 Otherwise the GWT Java->Javascript compilation fails with just this
779 error, during mvn package or when attempting to view in a browser,
780 in the GWT developer mode in Eclipse.
782 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
783 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
784 [INFO] Compiling module org.glom.web.OnlineGlom
785 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
786 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
787 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
788 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
789 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
790 [INFO] [ERROR] Cannot proceed due to previous errors
792 It has taken me 2 days to find out what was causing that. After reducing
793 the code, the compiler eventually showed me the full error message.
795 2012-05-04 Murray Cumming <murrayc@murrayc.com>
797 ConfiguredDocument: Cache the cloned and stripped layouts.
799 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
800 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
801 layout in a map, so we can retrieve it again without rebuilding it.
803 2012-05-04 Murray Cumming <murrayc@murrayc.com>
805 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
807 2012-05-04 Murray Cumming <murrayc@murrayc.com>
809 libglom classes: Implement some auto-generated emthods.
811 2012-05-04 Murray Cumming <murrayc@murrayc.com>
813 Add GwtTestOnlineGlomService.
815 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
816 However, this (and the other GwtTest*) does not seem to run during
819 2012-05-04 Murray Cumming <murrayc@murrayc.com>
821 Remove use of unsupported features from client code.
823 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
824 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
825 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
826 Use our client version of StringUtils instead of the apache commons one.
828 However, the GWT Javascript compliation still fails.
830 2012-04-25 Murray Cumming <murrayc@murrayc.com>
832 Add a Field class and implement some loading of it in Document.
834 2012-04-25 Murray Cumming <murrayc@murrayc.com>
836 Initial Document loading implementation, instead of libglom.
838 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
839 and Translatable classes, and adapt the rest of the code to use them.
840 However, this is still missing Layout and Field classes and loading.
842 2012-04-24 Murray Cumming <murrayc@murrayc.com>
844 Use of jOOQ: Move Field creation into a utility method.
846 * src/main/java/org/glom/web/server/SqlUtils.java:
847 This lets us improve it more easily.
849 2012-04-24 Murray Cumming <murrayc@murrayc.com>
851 Use of jOOQ: Improve the code to COUNT a sub-select.
853 * src/main/java/org/glom/web/server/SqlUtils.java:
854 Move initial query creation into
855 build_sql_select_step_with_where_clause().
856 build_sql_select_count_rows(): Use the jOOQ API instead of
857 concatentating text, because a jOOQ Select*Step is a TableLike,
858 which is what from() takes.
860 2012-04-23 Murray Cumming <murrayc@murrayc.com>
862 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
864 * pom.xml: Depend on jooq.
865 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
866 methods with jOOQ, based on the C++ implementations in libglom,
867 with some changes to the logic required by jooQ.
868 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
870 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
871 * src/main/java/org/glom/web/server/ReportGenerator.java:
872 * src/main/java/org/glom/web/server/SqlUtils.java:
873 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
874 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
875 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
876 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
877 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
878 Adapt. In particular, the SqlUtils methods now need to take a Connection,
879 because jOOQ needs that, though it seems unnecessary.
881 This is not quite finished. Ideally jOOQ would help us to build
882 table_name.field_name names, quoting and escaping them properly.
883 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
885 2012-04-21 Murray Cumming <murrayc@murrayc.com>
887 Move use of Glom.build_sql*() into a new SqlUtils class.
889 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
890 to wrap Glom.build_sql*(). The parameter types are still Glom one,
891 but this will make it easier to start using something other than
892 libglom or SqlBuilder.
894 2012-04-21 Murray Cumming <murrayc@murrayc.com>
896 Update the project URL.
898 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
900 2012-04-21 Murray Cumming <murrayc@murrayc.com>
902 Main layout: Use a FlowTable instead of absolute positioning.
904 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
905 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
906 child panels/widgets must have an absolute position. But that is annoying, so
907 this adds a FlowTable and puts the child panels in there.
909 2012-04-21 Murray Cumming <murrayc@murrayc.com>
911 GwtTestOnlineGlom: Comment out unused code.
913 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
914 Eclipse has started to say that some code is unused.
916 2012-04-21 Murray Cumming <murrayc@murrayc.com>
918 Update to the latest versions of dependencies.
920 * pom.xml: Update version numbers of dependencies to the latest
922 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
923 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
924 * src/main/java/org/glom/web/server/ReportGenerator.java:
925 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
926 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
927 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
929 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
930 Modify the imports where necessary.
932 2012-04-17 Murray Cumming <murrayc@murrayc.com>
934 Style: Remove overflow:hidden from searchbox
936 * src/main/webapp/style.css: Because this pushes the Back To Link
937 label/link on to the next row, which is then hidden due to the
938 hard-coded (in ems) height.
940 2012-04-20 Murray Cumming <murrayc@murrayc.com>
942 Remove some duplicate code.
944 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
945 getDocumentInfo(): This must have been duplicated during the merge from the
950 2012-04-19 Murray Cumming <murrayc@murrayc.com>
952 Reports: Localize the waiting for report message.
954 * src/main/java/org/glom/web/client/activity/ReportActivity.java
955 start(): Get the message from the contants.
956 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
958 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
959 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
960 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
961 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
962 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
963 Update these files with the English text for newer strings for now.
965 2012-04-19 Murray Cumming <murrayc@murrayc.com>
967 Reports: Show a message while waiting for the report.
969 * src/main/java/org/glom/web/client/ui/ReportView.java
970 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
971 Add setWaitingText(), to show a message saying that we are
972 waiting for the report to be ready.
973 * src/main/java/org/glom/web/client/activity/ReportActivity.java
974 start(): Call setWaitingText() before calling the async
977 2012-04-19 Murray Cumming <murrayc@murrayc.com>
979 ReportGenerator: Specify date and time formats.
981 * src/main/java/org/glom/web/server/ReportGenerator.java:
982 createFieldValueElement(): Use the default (and localized)
983 short formats, though we still need a way to show 4-digit
984 years without providing the format for every locale.
985 * src/main/java/org/glom/web/server/database/DBAccess.java:
986 convertResultSetToDTO(): Use the short formats here too.
988 2012-04-18 Murray Cumming <murrayc@murrayc.com>
990 ReportGenerator: Use the correct numeric formatting.
992 * src/main/java/org/glom/web/server/ReportGenerator.java
993 createFieldExpression(), createFieldValueElement(): Take the
994 whole LayoutItem_Field instead of just the field name, so
995 we have access to the formatting.
996 createFieldValueElement(): Use JRTextField.setPattern() to
997 specify the numeric formatting, with the help of a
998 regular DecimalFormat.
1000 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1002 ReportGenerator: Avoid showing null for group by titles.
1004 * src/main/java/org/glom/web/server/ReportGenerator.java
1005 generateReport(): Use setBlankWhenNull() on the field title
1006 style too, because this is used for values in group by
1009 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1011 ReportGenerator: Add a colon to titles in vertical groups.
1013 * src/main/java/org/glom/web/server/ReportGenerator.java
1014 addFieldToDetailBandVertical(): Pass true for the withColon
1017 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1019 ReportGenerator: Simplify the code by using Position more.
1021 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1023 Reports: Support vertical groups, roughly.
1025 * src/main/java/org/glom/web/server/ReportGenerator.java:
1026 addToReport(): Rename to addGroupToReport() and, if necessary,
1027 call the new addVerticalGroupToReport() method.
1028 createFieldValueElement(): Let the caller specify the Y position
1031 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1033 Reports: Allow a second report to be shown.
1035 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1036 clear(): Do not remove the HTML widget, which broke the whole layout.
1038 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1040 Locales drop-down: Show that we use English by default.
1042 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1043 fillView(): When we use English, just because that is the default, when
1044 no locale is specified, show that in the Locales drop-down instead of
1045 just showing the first item.
1047 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1049 Unselect the Report/Locale/Table combo item when appropriate.
1051 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1052 setPlace(): clear reportName if this is not a ReportPlace.
1053 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1054 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1055 When the provided name is empty, unselect all items, so that none are
1056 indicated. This uses a for loop because I cannot find a single method
1059 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1061 Report: Give the user a way to get back to the list.
1063 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1064 start(), setPlace(): Show the Back To List link on reports, and also
1065 interpret selecting the empty report item as back to list.
1067 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1069 Really show the selected Report name.
1071 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1072 setPlace(): Store the reportName here, if it is that kind of Place.
1073 fillView(): Set the selected Report after filling the list of reports.
1074 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1075 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1076 null Strings, though we need some way to unselect all ListBox items
1079 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1081 ReportGenerator: Try to avoid some problems.
1083 * src/main/java/org/glom/web/server/ReportGenerator.java
1084 addField(): Try to avoid duplicates, and avoid using a null
1087 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1089 Reports: Use quickFind.
1091 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1092 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1094 getReportHTML(): Add a quickFind parameter.
1095 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1096 start(): Pass the quickFind parameter.
1097 * src/main/java/org/glom/web/server/ReportGenerator.java
1098 generateReport(): Take a quickFind parameter.
1100 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1102 ReportPlace: Actually use the report name.
1104 * src/main/java/org/glom/web/client/place/ReportPlace.java
1105 getPlace(): Do not assign the report name to the quickfind.
1107 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1109 Show java.library.path when complaining.
1111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1112 init(): When telling us to check java.library.path, show the
1115 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1117 ReportGenerator: Do not show nulls.
1119 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1121 ReportGenerator: Make the title font larger.
1123 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1125 ReportGenerator: Put field titles inside groups, if there are groups.
1127 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1129 ReportGenerator: Take the Report itself instead of the name and group.
1131 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1132 Remove getReportLayoutGroup().
1133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1134 getReportHTML(): Pass the report instead
1135 of its name and layout group.
1136 * src/main/java/org/glom/web/server/ReportGenerator.java
1137 generateReport(): Use the report object to use the title
1138 instead of the name.
1140 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1142 ReportGenerator: Remove designBand parameters.
1144 * src/main/java/org/glom/web/server/ReportGenerator.java:
1145 Make designBand a class member instead of passing it to all
1148 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1150 ReportGenerator: Add lines, a bit like in the desktop version.
1152 * src/main/java/org/glom/web/server/ReportGenerator.java
1153 addToReport(): Use JRDesignLine.
1155 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1157 ReportGenerator: Correct the title positions and use some bold style.
1159 * src/main/java/org/glom/web/server/ReportGenerator.java:
1160 Break the code up into reusable functions, correct the placement of
1161 titles, and use normal/bold styles as in the reports in the desktop
1164 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1166 ReportGenerator: Add a header band to show the field titles.
1168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1169 getReportHTML(): Pass the localeId to the ReportGenerator
1171 * src/main/java/org/glom/web/server/ReportGenerator.java
1172 constructor: Take the localeID so we can get translated field
1174 generateReport(), addToReport(), addFieldToBand(): Add field
1175 titles in a column header band.
1177 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1179 Reports drop-down list: Some improvement.
1181 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1182 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1183 Adedd setSelectedReport(),
1184 setReportList(): Add a blank line so that the user can select the
1186 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1187 start(): Show the current report by calling setSelectedReport().
1188 This does not seem to work yet.
1190 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1192 DetailsActivity, ListActivity: Move some variables into a base class.
1194 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1195 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1196 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1197 the clientFactory, documentID, tableName and authenticationPopup into
1198 a base class, to avoid duplication.
1200 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1202 Translate the Reports label.
1204 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1205 Get the "Reports" label string from the constants.
1206 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1207 perties: Add Reports to the constants.
1209 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1211 Reports: Implement grouping.
1213 * src/main/java/org/glom/web/server/ReportGenerator.java:
1214 Handle LayoutItem_GroupBy items and try to do the right thing
1215 with JRDesignGroup. It seems to work.
1217 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1219 Actually show some data with JasperReports.
1221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1222 getReportHTML(): Move most code into a ReportGenerator class.
1223 * src/main/java/org/glom/web/server/ReportGenerator.java:
1224 Recurse into sub-groups, adding fields to the JasperDesign's details
1225 band. Note that we must set an arbitrary width and height, or it just
1226 will not show any data.
1228 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1230 Reports Chooser: Show the titles, not the names.
1232 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1233 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1234 and the names as the values.
1235 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1236 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1237 group now that we provide the report name, so it should always
1240 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1242 Depend on jasperreports.
1244 * pom.xml: Add the dependency. My plan is to use this on the
1247 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1249 Implement navigation to report places.
1251 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1252 start(): Do not bother to handle all events here.
1253 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1254 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1255 Added getSelectedReport().
1256 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1257 .java: start(): When handling a change to the reports chooser,
1258 call getSelectedReport() and goTo() its ReportPlace.
1259 * src/main/java/org/glom/web/client/ui/ReportView.java
1260 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1261 Added setReportHTML() which puts the html in a gwt HTML widget.
1262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1263 getReportHTML(): Return "TODO" just to show that this works.
1265 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1267 Make ReportPlace usable.
1269 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1270 Mention ReportPlace.
1271 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1272 Correct the @prefix annotation.
1274 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1276 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1278 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1279 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1280 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1281 Change getReportLayout() to getReportHMTL() because we will not need to
1282 parse or render the report layout on the client side.
1283 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1284 getReportLayout(): Return the libglom LayoutGroup type because we will
1285 not need to convert to a shared type, because this will not be used on
1287 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1290 Note that there is still no implementation for this.
1293 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1295 Add a (empty) Report Place, View, and Activity.
1297 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1299 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1300 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1301 this into a superclass:
1302 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1303 and also use it as the base of this new ReportPlace:
1304 * src/main/java/org/glom/web/client/place/ReportPlace.java
1306 * src/main/java/org/glom/web/client/ui/ReportView.java
1307 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1308 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1309 Add these, containing mostly boiler-plate for now.
1311 * src/main/java/org/glom/web/client/OnlineGlomService.java
1312 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1313 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1314 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1315 Add API to get the LayoutGroup for the report.
1317 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1319 Add and fill a Reports drop-down list box.
1321 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1323 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1324 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1325 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1326 Added getReports(document, table, localeID), calling
1327 ConfiguredDocument.getReports().
1328 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1329 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1330 Added setReportsList() and a list widget.
1331 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1332 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1337 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1339 Translations: Add Esperanto.
1341 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1342 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1343 properties: Add this translation because someone took the time to make it.
1345 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1347 Adapt to the java-libglom 1.21.7 API.
1349 * src/main/java/org/glom/web/server/ReportGenerator.java:
1350 addToReport(): get_group_secondary_fields() is now
1351 get_secondary_fields().
1354 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1356 Use the latest java-libglom version.
1358 * pom.xml: Use java-libglom 1.21.7.
1360 2012-03-03 Ben Konrath <ben@bagu.org>
1362 Display date and time in details view.
1364 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1366 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1368 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1370 Require the latest java-libglom.
1372 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1374 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1376 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1378 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1379 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1380 an empty quickfind string. I also corrected libglom to create only
1381 empty where clauses for empty quickfind strings, but this avoids the
1384 2012-02-24 Ben Konrath <ben@bagu.org>
1386 Improve the tabs in the Notebook widget.
1390 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1392 Translations: Try to translate the strings.
1394 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1395 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1396 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1397 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1398 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1399 Take the Open translation from GTK+'s .po files.
1400 Take the Details translation from Glom's po files.
1401 I have added the other strings to Glom so we can get translations that way:
1402 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1404 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1406 TableSelectionViewImpl: Put the search label and entry in a div.
1408 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1409 Put the search widgets in a FlowTable so that the CSS can be used to
1410 style them while keeping them together.
1411 * src/main/webapp/style.css: Mention the new div.
1413 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1415 Translate more strings in more locales.
1417 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1418 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1419 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1420 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1421 Translate the "Details" and "Open" string too.
1423 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1424 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1425 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1426 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1427 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1428 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1429 Add these new locales as placeholders though they currently contain English.
1431 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1433 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1435 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1436 Check the ConfiguredDocument* for null before using it.
1438 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1440 Tell Eclipse about the generated java files.
1442 * .classpath: This lets it find OnlineGlomConstants.java.
1443 It would be nice if Eclipse just used the maven build files.
1445 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1447 Prevent a crash when no locale is specified in the URL.
1449 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1450 Avoid returning a null string, obtained from
1451 Window.Location.getParameter(). This caused a crash when it was
1452 later passed to libglom's API.
1453 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1454 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1455 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1456 guard against future null strings.
1458 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1460 Use the ?locale= query param instead of the &lang= token param.
1462 * src/main/java/org/glom/web/client/place/ListPlace.java
1463 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1464 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1465 Remove the lang token key and value.
1467 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1468 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1469 When the user selects a different locale from the chooser, use
1470 Window.Location.assign() to change the URL, which then causes a reload.
1472 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1473 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1474 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1475 * src/main/java/org/glom/web/client/activity/ListActivity.java
1476 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1477 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1478 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1479 * src/main/java/org/glom/web/client/ui/ListView.java:
1480 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1482 Remove localeID member variables and method/constructor parameters, instead
1483 using Utils.getCurrentLocaleID() when we need a localID to pass to
1486 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1488 Internationalize the UI strings.
1490 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1491 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1492 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1493 because it is unused. Messages are apparently strings that can have
1494 parameters, but we do not need that yet, so Contants will be enough for now.
1495 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1496 to say that we support the en and de locales.
1497 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1498 The original English strings.
1499 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1500 Some German translations of the English strings.
1501 The i18n goal then uses the .properties file to generate an
1502 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1503 returns an implementation that returns the translated strings.
1504 The documentation suggests putting these in src/java/*/client/, but it seems
1505 best to put it in src/resources/*/client/.
1506 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1507 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1508 instead of hard-coding them.
1509 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1510 but that does not seem to stop the build, though it confuses Eclipse.
1512 You can see the translated string by adding ?locale=de to the URL, like so:
1513 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1515 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1517 Improve null/empty String checks.
1519 * pom.xml: Add a dependency on commons-lang, to use
1520 org.apache.commons.lang.StringUtils.
1521 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1522 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1523 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1524 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1525 Use StringUtils.isEmpty().
1527 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1528 StringUtils class with a static isEmpty() function because we
1529 cannot use org.apache.commons.lang.StringUtils in client-side
1530 GWT code because it (apparently) cannot be compiled to javascript.
1531 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1532 * src/main/java/org/glom/web/client/activity/ListActivity.java
1533 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1534 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1535 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1536 * src/main/java/org/glom/web/client/place/ListPlace.java
1537 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1538 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1539 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1540 * src/main/java/org/glom/web/client/ui/details/Group.java
1541 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1542 our StringUtils.isEmpty() function.
1544 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1546 Update to the latest java-libglom API.
1548 * pom.xml: Require java-libglom 1.21.4.
1549 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1550 getDocumentInfo(), getListViewLayoutGroup():
1551 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1553 * src/main/java/org/glom/web/server/database/DBAccess.java
1554 getFieldsToShowForSQLQueryAddGroup(),
1555 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1556 with either get_database_title_original() or
1557 get_database_title(localeID).
1559 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1561 ConfiguredDocument: Avoid a null pointer exception.
1563 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1564 Initialize localeID to "" to avoid returning a null String which
1565 causes a crash in java-libglom's swing-generated code.
1567 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1569 Some simple renaming.
1571 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1572 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1573 for localeChooser. This seems more appropriate and is less ambiguous
1574 particularly in the .css file.
1576 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1578 ConfiguredDocument: Rename the localedID private member variable.
1580 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1582 Adapt to the latest java-libglom API from git master.
1584 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1585 libglom now uses only Vector instead of List, which uses add() instead of
1588 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1590 ConfiguredDocument: Rename the localedID private member variable.
1592 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1594 Build a source tarball with mvn assembly:single
1596 * assembly.xml: Add this file.
1597 * pom.xml: Use the maven-assembly-plugin and tell it to use
1598 our assembly.xml file.
1600 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1602 OnlineGlomServiceImpl: Get .glom files recursively.
1604 * pom.xml: Depend on commons-io from org.apache.commons.
1605 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1606 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1607 files recursively, and with the easier filter for the extension.
1608 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1609 simplify that code too.
1611 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1613 README: Mention that you must install java-libglom packages separately.
1615 But then it works, because java-libglom is now in the central maven
1618 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1620 locales drop-down: Show the correct selected locale when the URL changes.
1622 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1623 .java: setPlace(): Move some code into fillView().
1625 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1627 locales drop-down: Do not lose the primary key.
1629 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1630 start(): onLocaleChange(): Pass the current primary key value,
1631 instead of an empty value.
1633 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1635 locales drop-down: Do not lose the drop-down selection.
1637 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1638 .java (TableSelectionActivity.fillView): Set the selected locale
1639 after changing the drop-down items (though we do not really need
1640 to change them just because the locale changes.)
1642 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1644 locales drop-down: Change the tables list when this changes.
1646 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1647 .java: TableSelectionActivity.start(): Move the async table titles
1648 retrieval into a private fillView() method and also call this when
1649 the chosen locale changes.
1650 Note that the document title is not actually translatable yet, but
1651 that is a problem that I should fix soon in libglom.
1653 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1655 Improve the placement of the locales drop-down.
1657 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1658 Put the title and locales drop-down in a div (gwt.FlowTable).
1659 * src/main/webapp/style.css: Add magic css properties to make this work.
1660 Also remove the left margin from the title so that it lines up with the
1663 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1665 locales selector: Show human-readable locale titles.
1667 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1668 getDocumentInfo(): Use java.util.Locale to show a real title of
1669 each locale, in the locale's own language.
1671 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1673 Add a language/locale selector drop-down.
1675 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1676 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1677 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1678 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1679 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1680 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1681 Add a ListBox to show the available locales. Add getLocaleSelector(),
1682 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1683 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1684 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1685 java: Add these classes.
1686 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1687 start(): Fill the locales ListBox. Handle its change event, firing a
1689 setPlace(): Show the selected locale as specified by the URL token.
1690 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1691 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1692 Handle LocaleChangeEvent, going to a new *Place with that locale.
1694 The placement of the ListBox is not pretty, and it currently uses the ID
1695 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1699 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1701 Search box: Show the search text from the URL token.
1703 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1704 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1705 Add setQuickFindText().
1706 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1707 .java: setPlace(): Store the queryText if the place is a ListPlace,
1708 and call TableSelectionView.setQuickFindText().
1710 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1712 Allow use of translations via, for instance, &lang=de in the URL.
1714 * pom.xml: Use the unstable java-libglom 1.21 version.
1716 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1717 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1719 init(): Instead of calling TranslatableItem.set_current_locale()
1720 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1721 However, this is only for default locales, which are not needed to
1722 change the locale in the URL.
1723 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1724 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1725 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1726 layout for a particular locale.
1727 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1728 Add get/setDefaultLocaleID().
1729 getDocumentInfo(), getListViewData(), getRelatedListData(),
1730 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1731 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1732 localeID parameter, so we can get the layout for a particular locale.
1734 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1735 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1736 * src/main/java/org/glom/web/client/place/ListPlace.java:
1737 Parse and construct a lang parameter too.
1739 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1740 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1741 passed to subsequent methods and constructors.
1742 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1743 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1744 Store the localeID from the *Place and pass it to other constructors
1745 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1747 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1748 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1749 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1750 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1751 * src/main/java/org/glom/web/client/ui/ListView.java:
1752 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1753 Take localeID parameters and pass them to subsequent constructors and
1754 methods, so that the layout is always retrieved for that locale.
1756 This is rather repetitive.
1758 Note that "" means the original (default) locale of the Glom document,
1759 which is usually English.
1761 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1763 Documents: Remove final keyword to fix startup configuration.
1765 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1766 final keywords on the private member variables because that breaks
1767 the startup, apparently (there are warnings) because it stops them
1768 from being serialized. I added these in the previous commit.
1770 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1772 Documents: Add some final keywords.
1774 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1777 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1779 OnlineGlomServiceImpl: Add to overview comments.
1781 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1782 Note that this is where all the document are loaded. They are not
1783 loaded freshly for each page.
1785 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1789 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1790 Add a TextBox for the text of a quick find.
1791 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1793 setBackLink(): Add a String quickFind parameter.
1794 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1795 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1796 to the base interface, because that is how TableSelectionViewImpl is used.
1797 * src/main/webapp/style.css: Add style for the search box and its label.
1799 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1800 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1801 Add these files, based on the existing TableChangeEvent and
1802 TableChangeEventHandlers.
1803 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1804 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1805 a ListPlace() that the user should be taken to.
1806 * src/main/java/org/glom/web/client/activity/ListActivity.java
1807 start(): Handle it here too and adapt the TableChangeEvent handler to
1808 pass the extra "" quickFind parameter to ListPlace.
1809 * src/main/java/org/glom/web/client/place/ListPlace.java:
1810 Constructor: Take an extra String quickFind parameter and store it,
1811 returning it from a new getQuickFind() method.
1812 getToken(): Put the quickFind text in the URL token.
1813 getPlace(): Parse the quickFind text from the URL token.
1814 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1815 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1816 ListPlace constructor.
1817 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1818 .java: start(): Add a Change handler for the TableSelectionView's
1819 TextBox (via its base HasChangeHandlers interface), firing the new
1820 QuickFindChangeEvent.
1821 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1822 pass the extra "" quickFind parameter.
1824 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1825 setCellTable(): Add a String quickFind parameter and pass it to
1826 the ListViewTable() constructor.
1827 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1828 setCellTable() in the base interface, because that is how ListViewImpl
1831 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1832 Add a String quickFind member variable.
1833 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1834 Constructor: Add a String quickFind parameter, storing it in the
1835 base ListTable's member variable.
1836 onRangeChanged(): Pass quickFind to the
1837 OnlineGlomServiceAsync.getSortedListViewData() and
1838 OnlineGlomServiceAsync.getListViewData() methods.
1840 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1841 getListViewData(), getSortedListViewData(): Add a String quickFind
1842 parameter, passing it to ConfiguredDocument.getListViewData().
1843 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1844 Change getListViewData(), getSortedListViewData() in the base interface,
1845 because that is how OnlineGlomServiceImpl is used, via this:
1846 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1847 Change getListViewData(), getSortedListViewData() here too.
1848 This class can apparently be used to asynchronously call methods on
1849 OnlineGlomService, and GWT seems to implement that after recognizing
1850 just the *Async name convention and the extra AsyncCallback parameters.
1852 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1853 getListViewData(): Add a String quickFind parameter, and pass it to
1854 ListViewDBAccess.getData().
1855 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1856 getListData(): Add a String quickFind parameter and pass it to
1858 getSelectQuery(): Add a String quickFind parameter.
1859 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1860 getSelectQuery(): Add a String quickFind parameter and use it with
1861 Glom.get_find_where_clause_quick() to pass a where_clause to
1862 Glom.build_sql_select_with_where_clause(), to actually filter the
1864 getData(): Add a String quickFind parameter, passing it to getListData().
1865 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1866 va: getData(): Pass an empty string to getListData() for the
1867 quickFind parameter.
1869 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1871 ListTable: Minor change.
1873 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1874 createCellTable(): Make this protected instead of public.
1876 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1878 Many files: Use final for the parameters and use the @override attribute.
1880 2012-01-22 Ben Konrath <ben@bagu.org>
1882 Add anchor links for single line text that starts with http, ftp and www.
1886 2012-01-22 Ben Konrath <ben@bagu.org>
1888 Add ellipsis to single line text in details view.
1892 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1894 Remove all javadoc author tags.
1896 Because they are awkward and meaningless when many people touch
1898 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1900 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1902 Revert the COPYING.LESSER to COPYING rename.
1904 Apparently both should be there if it is LGPL.
1906 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1908 *View: Remove unused imports.
1910 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1911 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1912 * src/main/java/org/glom/web/client/ui/ListView.java:
1913 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1914 Remove unused imports, as suggested by Eclipse.
1916 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1918 Move the *View::Presenter types, and some API into one base View.
1920 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1921 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1922 * src/main/java/org/glom/web/client/ui/ListView.java:
1923 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1924 Presenter, setPresenter() and clear() into a shared base interface,
1925 to avoid the unnecessary duplicate Presenter types and to more clearly
1926 show how the *Views share the same structure, even if they are not
1927 used polymorphically.
1929 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1930 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1932 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1933 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1934 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1936 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1939 Feel free to revert this if there is a good reason for the duplicate
1942 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1944 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1946 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1947 a class member instead of a local variable in the method.
1948 This lets us use it to get the view instances, for use in tests.
1949 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1950 beforeOnlineGlom(): Test some more details of the initial view.
1951 Again, this is not very useful.
1953 To really test gwt-glom we will need to start a local postgresql
1954 instance with local data, like the Glom tests in C++.
1956 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1958 pom.xml: Mention the LGPL license.
1960 * pom.xml: Add a licenses section.
1961 * COPYING.LESSER: Move this to COPYING, which
1962 previously contained the GPL. But gwt-glom is all LGPL.
1964 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1966 Add project information to README and pom.xml.
1968 * README: Add a brief description and mention some mvn
1970 * pom.xml: This extra information shows up in mvn site
1973 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1975 Use the latest java-libglom version.
1977 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1979 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1981 GwtTestOnlineGlom: Test a little more.
1983 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1984 protected rather than private, as suggested by the gwt-test-utils
1986 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1987 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1988 Test the initial visibility of the panels.
1990 However, this is not a very useful test.
1991 And I wonder how we should generally test using this idea for an
1992 activity/places app like ours where the real changes happen implicitly
1993 based on the history token/URL.
1995 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1997 Slight modification to *Mapper comments.
1999 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2000 (DataActivityMapper)
2001 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2003 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2005 Remove comments mentioning GIN because they are just copied from
2006 the example code and are apparently not helpful:
2007 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2008 Also change the mention of a class that is only in the example code.
2010 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2012 GwtTestOnlineGlom test: Minor changes.
2014 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2015 Avoid the long qualified class name and modify the comment
2016 because it is now obvious to me that the mocked class is the only
2017 custom one created via GWT.create().
2019 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2021 Tests: Added the beginnings of a test using gwt-test-utils.
2023 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2024 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2025 which tells gwt-test-utils what class will be tested.
2026 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2027 Add a simple (but empty) test case. One class, used by the OnlineGlom
2028 class, is mocked so that it can be created. However, I am not sure
2029 why only this class needs to be mocked.
2031 Note that mockito seems more popular, and clearer, than easymock,
2032 but I have not got that working yet. It might be a matter of the
2035 This test is run during mvn integration-test.
2037 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2039 Tests: Use junit4-style syntax instead of junit3-style.
2041 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2042 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2043 * src/test/java/org/glom/web/shared/DataItemTest.java:
2044 Use the @Test annotation rather than relying on the test*() prefix.
2045 Also no longer implement TestCase, to avoid triggering support for
2046 the junit3-way, which stops the annotations from working.
2047 Change the imports from import junit.framework.* to
2048 import org.junit.*, which is apparently the new way.
2050 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2052 Added a test for ListPlace token parsing and creation.
2054 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2055 This is much the same as DetailsPlaceTest.
2057 I wonder how we could test the other parts of the *Place API.
2059 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2061 DetailsPlace test: Also test getToken() and recreation via getPlace().
2063 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2064 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2065 recreate it, testing the recreated DetailsPlace for the same parameter
2068 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2070 Use the surefire-report plugin.
2072 * pom.xml: This generates a HTML report about the tests in
2073 target/site/surefire-report.html
2074 when you do mvn surefire-report:report. It seems to be popular/normal.
2076 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2078 Added a test for DetailsPlace.
2080 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2081 Test the getPlace() token parsing.
2083 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2085 Added a first unit test.
2087 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2088 * src/test/java/org/glom/web/shared/DataItemTest.java:
2089 This is a silly test but it is just to get things started. Note that
2090 maven/junit finds the test because it looks in src/test by default.
2092 2011-12-22 Ben Konrath <ben@bagu.org>
2094 Change charsetName to "UTF-8" when replacing line breaks.
2096 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2097 that work in Java (such as "UTF8") will not work when compiled to
2100 This fixes a problem with multi-line details view fields that have hard
2101 line breaks. The "License Text" field on this page demonstrates the
2104 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2106 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2108 2011-12-22 Ben Konrath <ben@bagu.org>
2110 Fix another bug with related list navigation.
2112 I've tested all the navigation buttons in all of the related lists
2113 so things should be good now.
2115 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2117 2011-12-22 Ben Konrath <ben@bagu.org>
2119 Fix a crasher when refreshing the list view with the default table.
2121 This crash will also happen when loading the list view with the default
2122 table from a link or bookmark.
2124 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2125 to the main document selection page when the document id hasn't been
2127 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2128 the main document selection page when the document id hasn't been
2130 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2131 values for the details place when the document id hasn't been set.
2132 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2133 values for the list place when the document id hasn't been set.
2135 2011-12-21 Ben Konrath <ben@bagu.org>
2137 Protect against NPE when glom.document.locale is not in config.
2139 This patch protects against an NPE when glom.document.locale is not in
2140 the config file. This NPE will also happen if glom.document.locale is
2143 The patch also updates the error message to display the class name when
2144 the getMessage() returns null. This was happening when the NPE was
2145 thrown and I had "Configuration Error: null". If an NPE is encountered
2146 with this patch, "Configuration Error: NullPointerException " will be
2149 This commit closes this bug:
2151 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2155 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2157 Rename onlineglom.properties to onlineglom.properties.sample.
2159 * src/main/resources/onlineglom.properties: Rename to:
2160 * src/main/resources/onlineglom.properties.sample:
2161 * src/main/resources/README: And add this file explaining that people
2162 should rename it back when deploying.
2164 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2166 Allow choosing the translation in the .properties file.
2168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2169 init(): Read a glom.document.locale value from the configuration file
2170 and call Glom's TransatableItem::set_current_locale() method.
2171 * src/main/resources/onlineglom.properties: Add a commented-out
2172 example of this new setting.
2174 It would be better to add &lang=de_DE to the URL, but the current
2175 libglom API does not allow us to do this easily. I am working on that.
2177 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2179 Avoid a crash in parsing of token parameters.
2181 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2182 ava: getTokenParams(): Do not crash if a parameter has a key but no
2183 value, and ignore parameters with neither.
2185 2011-12-17 Murray Cumming <murrayc@murayc.com>
2187 History token building/handling: Improve use of token parameters.
2189 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2190 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2191 and buildParamsToken(HashMap), for use by derived classes.
2192 Make the separator private because it is no longer be needed.
2193 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2194 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2195 instead of manual string concatenation.
2196 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2197 of hardcoded indices and awkward splitting code.
2198 * src/main/java/org/glom/web/client/place/ListPlace.java
2199 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2200 instead of manual string concatenation.
2201 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2202 of hardcoded indices and awkward splitting code.
2203 This should fix bug #666420
2205 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2207 Fix a Navgiation->Navigation typo in the code.
2209 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2210 Rename processNavgiation() to processNavigation().
2212 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2214 Fix a seperator->separator typo in the code.
2216 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2217 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2218 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2221 2011-12-15 Ben Konrath <ben@bagu.org>
2223 Cleanup some comments.
2225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2227 2011-12-14 Ben Konrath <ben@bagu.org>
2229 Replace \n with <br/> for multiline text in the details view.
2231 Vertical scrollbars are added when needed as well.
2233 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2235 2011-12-14 Ben Konrath <ben@bagu.org>
2237 Specify the font for document selection links.
2239 * src/main/webapp/style.css:
2241 2011-12-14 Ben Konrath <ben@bagu.org>
2243 Fix bouncy CellTable while paging.
2245 This doesn't currently work with related list tables in unselected
2248 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2250 2011-12-14 Ben Konrath <ben@bagu.org>
2252 Revamp the appearance of the document selection page.
2254 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2255 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2256 * src/main/webapp/style.css:
2258 2011-12-13 Ben Konrath <ben@bagu.org>
2260 Set navigation button column to the smallest size possible.
2262 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2264 2011-12-13 Ben Konrath <ben@bagu.org>
2266 Change OpenButton nomenclature to NavigationButton.
2268 Using NavigtionButton makes things more generic. Classes, methods and
2269 variables have been changed.
2271 This is a rename-only refactor.
2273 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2274 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2275 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2276 Renamed from OpenButtonCell.
2277 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2278 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2279 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2281 2011-12-12 Ben Konrath <ben@bagu.org>
2283 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2285 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2286 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2287 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2288 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2290 2011-12-12 Ben Konrath <ben@bagu.org>
2292 Update variable names and comments.
2294 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2295 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2297 2011-12-12 Ben Konrath <ben@bagu.org>
2299 Properly initialize numNonEmptyRows variable to zero.
2301 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2302 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2304 2011-12-05 Ben Konrath <ben@bagu.org>
2306 Add latest mockup with HTML tables.
2308 Features of this mockup:
2310 -> HTML table for flowtable
2311 -> HTML table for flowtable column
2312 -> Example of how related lists would look
2313 -> Not using text entries for data items
2315 The current version of Online Glom doesn't use HTML tables for the
2318 This mockup has been sent to the glom-devel mailing list but it's good
2319 to have it here as well.
2321 * mockups/details-view-html-tables.html:
2323 2011-12-05 Ben Konrath <ben@bagu.org>
2325 Remove unnecessary getPrimaryKeyField() method.
2327 getPrimaryKeyFieldForTable(String) has been renamed to
2328 getPrimaryKeyField(String).
2330 * src/main/java/org/glom/web/server/database/DBAccess.java:
2331 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2332 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2334 2011-12-05 Ben Konrath <ben@bagu.org>
2336 Add string representation of TypedDataItem value to conversion error message.
2338 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2339 message was extracted into its own method to avoid duplication.
2341 2011-12-05 Ben Konrath <ben@bagu.org>
2343 Add type checking to navigation primary key value creation.
2345 Create navigation primary key only if the expected type from the Glom
2346 document matches the type returned by the SQL query.
2348 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2350 2011-12-05 Ben Konrath <ben@bagu.org>
2352 Rename a couple of variables in RelatedListNavigation.
2354 This is a rename-only refactor.
2356 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2358 2011-12-05 Ben Konrath <ben@bagu.org>
2360 Move getListLayoutGroup() into getListViewLayoutGroup().
2362 This removes getListLayoutGroup(). It was only being called by
2363 getListViewLayoutGroup().
2365 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2367 2011-12-05 Ben Konrath <ben@bagu.org>
2369 Remove check for LayoutItem_Portal in list table method.
2371 This check is no longer necessary because the method isn't being used
2372 to create the LayoutItemPortal DTO.
2374 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2376 2011-12-05 Ben Konrath <ben@bagu.org>
2378 Properly support related list navigation.
2380 Navigation from the "Repository Analyzer -> Package Scans ->
2381 Dependencies" related table wasn't working because the primary key for
2382 related tables wasn't being set properly. This commit fixes the
2385 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2386 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2387 doesn't set the primary key properly for related list tables.
2388 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2389 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2390 useful for getting the primary key for list view tables and for related
2392 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2393 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2394 Move code to set the primary key for the table from the abstract
2395 ListDBAccess class to ListViewDBAccess as it's only correct for list
2397 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2398 Properly add primary key to related list tables.
2400 2011-12-02 Ben Konrath <ben@bagu.org>
2402 Properly set the horizontal alignment of fields.
2404 This fix is for both the list tables and the details view.
2406 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2407 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2408 to set the horizontal alignment of fields.
2410 2011-12-02 Ben Konrath <ben@bagu.org>
2412 Display currency codes in the details view.
2414 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2416 2011-12-02 Ben Konrath <ben@bagu.org>
2418 Avoid duplicate JNI call.
2420 JNI is not as efficient as pure Java and this is an easy (and small)
2423 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2424 Use previously retrieved value for whereClauseToTableName instead of
2427 2011-12-02 Ben Konrath <ben@bagu.org>
2429 Rename a couple of variables in RelatedListNavigation.
2431 This is a rename-only refactor.
2433 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2435 2011-12-02 Ben Konrath <ben@bagu.org>
2437 Indicate clearly that a mismatched primary key type is a bug.
2439 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2440 warning to error. Add 'This is a bug.' to message.
2442 2011-12-02 Ben Konrath <ben@bagu.org>
2444 Update / fix some comments.
2446 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2448 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2450 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2451 Fix comments. Add some TODOs.
2453 2011-12-02 Ben Konrath <ben@bagu.org>
2455 Enable navigation to details view with string primary key from related list.
2457 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2458 Create a text primary key value when return type of result is
2459 java.sql.Types.VARCHAR.
2461 2011-12-02 Ben Konrath <ben@bagu.org>
2463 Use checkboxes for booleans in the details view.
2465 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2467 2011-12-01 Ben Konrath <ben@bagu.org>
2469 Improve performance of related list height calculation.
2471 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2472 Put code to calculate the expected height in a static initializer so
2473 that that it's only called once.
2475 2011-12-01 Ben Konrath <ben@bagu.org>
2477 Show related list tables in notebooks (again).
2479 Calculate the height of the related list tables so the Notebook can be
2480 set the correct height. The height of the related list table is also needed by
2481 FlowTable to be able decide how to create the layout.
2483 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2484 and set the Portal height based on the height of the related list
2485 table and the Portal container.
2486 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2487 Add method to calculate the height of the related list tables.
2488 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2489 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2490 calculate the height of the Pager widget.
2492 2011-12-01 Ben Konrath <ben@bagu.org>
2494 Use CellTable API for table property instead of setting style on Element.
2496 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2498 2011-12-01 Ben Konrath <ben@bagu.org>
2500 Make ListViewTable and RelatedListTable a consistent height.
2502 The tables are now a consistent height regardless of the contents of
2503 the table. A hidden button is added to empty rows to ensure that the
2504 height of these rows will match the height of rows with data.
2506 A navigation button column is now added to every table. The width of
2507 the navigation column is set to 0px when a RelatedListTable shouldn't
2508 have navigation buttons. This maintains the a consistent row height in
2509 tables that don't show the navigation buttons.
2511 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2512 navigation column when not needed.
2513 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2514 arguments for navigation button to constructor of ListViewTable.
2515 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2516 hidden button for empty data rows.
2517 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2518 arguments for navigation button to constructor.
2519 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2520 create navigation buttons. Add hideNavigationButtons() method.
2521 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2522 arguments for navigation button to constructor.
2524 2011-12-01 Ben Konrath <ben@bagu.org>
2526 Use 'visibility: hidden' in Utils.getWidgetHeight().
2528 This is better choice because hidden elements are invisible, don't
2529 respond to events and are not part of the tab order. They will,