1 2012-05-24 Murray Cumming <murrayc@murrayc.com>
3 SelfHoster: Add some debug println messages to help when things fail.
5 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
6 System.out.println() lines.
8 2012-05-23 Murray Cumming <murrayc@murrayc.com>
10 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
12 * src/test/java/org/glom/web/server/SelfHoster.java:
13 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
14 instance) instead of just /usr/bin (as on Fedora). Check the result when
17 2012-05-23 Murray Cumming <murrayc@murrayc.com>
19 Remove LayoutItemPortal.get/setNavigationTable().
21 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
22 Remove get/setNavigationTable(), which is only a cache, because it is not
23 used, and does not need to be used, because that decision should be made on
25 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
26 updatePortalsExtras():
27 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
28 getNavigationRecord():
29 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
32 2012-05-21 Murray Cumming <murrayc@murrayc.com>
34 Initial self-hosting for tests.
36 * pom.xml: Change the scope for log4j, to hopefully make it
37 available to the test code which uses it indirectly via jOOQ.
38 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
39 self-hosting, though we only use it for testing.
41 * src/main/java/org/glom/web/server/libglom/Document.java:
42 example rows: Use a map instead of a list for each row of values,
43 so we know what field they are for, instead of relying on the sequence
44 being correct. This is not very efficient, but it does not really need
46 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
47 testReadTableExampleRows(): Adapted.
49 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
50 that returns an Object, for generic use. Note that Object seems to be
51 the implicit base even of double.
52 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
53 for use in CREATE TABLE SQL queries.
54 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
55 to do self-hosting of PostgreSQL databases via its command-line
56 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
57 backends/postgres_self.cc. This is incomplete - it needs more
58 warnings about failures and it needs to clean up properly when things
60 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
61 test of this new class.
63 2012-05-21 Murray Cumming <murrayc@murrayc.com>
65 Document: loading example data: Handle exceptions.
67 * src/main/java/org/glom/web/server/libglom/Document.java:
68 DateFormat.parse() and Double.valueOf() can throw exceptions, though
69 Eclipse did not warn about that.
71 2012-05-20 Murray Cumming <murrayc@murrayc.com>
73 Document: load(), save(): Handle the example rows.
75 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
77 * src/main/java/org/glom/web/server/libglom/Document.java:
78 load(), save(): Load and save the example rows, though the date, time
79 and image types are not handled properly yet.
80 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
81 Add testReadTableExampleRows() just to check that something is read.
83 2012-05-20 Murray Cumming <murrayc@murrayc.com>
87 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
88 Added getTranslationsMap() for use while saving.
89 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
90 Adedd getUseDefaultFormatting() for use while saving.
91 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
92 and several private methods that it uses.
94 This will be useful while testing via self-hosting.
95 It is not complete, but should be complete enough for testing.
97 2012-05-17 Murray Cumming <murrayc@murrayc.com>
99 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
101 * src/main/java/org/glom/web/client/OnlineGlomService.java
102 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
104 Remove getSortedListViewData() and getSortedRelatedListData(), adding
105 the sort column index and ascending bool to the regular method.
106 Instead, a sort column index of -1 now means no sort.
107 This is less explicit, but it's fairly simple, reduces the amount of
108 code, and makes the OnlineGlomService API slightly smaller.
109 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
110 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
112 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
113 getListViewData(), getRelatedListData():
114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
115 getListViewData(), getRelatedListData():
116 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
118 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
120 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
125 2012-05-16 Murray Cumming <murrayc@murrayc.com>
127 Use translations for top-level groups too.
129 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
130 updateTitlesForLocale(): Use the translation for the group
131 as well as for child items.
135 Just recompiled to fix a problem in the released .tar.gz file.
139 2012-05-15 Murray Cumming <murrayc@murrayc.com>
141 Corrections to navigation to related records.
143 * src/main/java/org/glom/web/client/OnlineGlomService.java:
144 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
145 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
146 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
147 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
148 relationship name, because the relationship name is not necessarily unique
150 TOOD: This is inefficient, because it passes the whole list of
151 child field items back to the server, but it is more correct, and happens
152 to fix a bug with the primary key being lost after a few navigations.
153 There is probably a chance to make this more efficient anyway in some
156 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
157 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
158 * src/main/java/org/glom/web/server/ConfiguredDocument.java
159 * src/main/java/org/glom/web/server/database/DBAccess.java
160 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
161 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
164 2012-05-15 Murray Cumming <murrayc@murrayc.com>
166 Fix the use of translations.
168 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
169 Add updateTitlesForLocale().
170 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
171 Call it to discard unwanted translations and to make getTitle() return
172 the wanted translation wihout the need for the client code to specify a locale.
173 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
174 getTitle(): Fallback to the original title, as libglom does.
176 2012-05-15 Murray Cumming <murrayc@murrayc.com>
178 Document: Correctly report the number of available translation locales.
180 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
181 the available locale IDs list.
182 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
183 testLocales: Test this.
185 2012-05-15 Murray Cumming <murrayc@murrayc.com>
187 SqlUtils: Use camelCase.
189 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
190 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
191 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
192 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
193 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
194 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
196 2012-05-15 Murray Cumming <murrayc@murrayc.com>
198 Use jOOQ's tableByName() and fieldByName.
200 * pom.xml: Use jOOQ 2.3.1 to get the new API.
201 * src/main/java/org/glom/web/server/SqlUtils.java:
202 build_sql_select_step_with_where_clause(), .createField(),
203 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
204 so we can get correct quoting and escaping. Thanks to Lukas Eder for
205 adding this, and other things, to jOOQ.
207 2012-05-15 Murray Cumming <murrayc@murrayc.com>
209 SqlUtils: Remove the Connection parameters.
211 * src/main/java/org/glom/web/server/SqlUtils.java:
212 build_sql_select_with_key(), build_sql_select_with_where_clause(),
213 createSelect(), build_sql_select_step_with_where_clause(),
214 build_sql_count_select_with_where_clause(),
215 build_sql_select_count_rows(): Remove the Connection parameter because
216 jOOQ does not actually need a connectionwhen it is just used to build
218 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
220 * src/main/java/org/glom/web/server/ReportGenerator.java:
222 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
224 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
225 Constructor, getListData(), getResultSizeOfSQLQuery():
226 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
227 getSelectQuery(), getCountQuery():
228 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
229 getSelectQuery(), getCountQuery():
230 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
231 getNavigationRecord(): Adapted.
233 2012-05-14 Murray Cumming <murrayc@murrayc.com>
237 * src/main/java/org/glom/web/server/SqlUtils.java:
238 get_find_where_clause_quick(): Use a comparison of
239 lowercase values, instead of a simple equals. Regular Glom
240 uses the PostgreSQL ILIKE operator but jOOQ does not
241 support that just yet, though it will soon.
243 2012-05-14 Murray Cumming <murrayc@murrayc.com>
245 TableToViewDetails: Use a real serialization ID.
247 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
248 Though this does not fix the serialization problem.
250 2012-05-12 Murray Cumming <murrayc@murrayc.com>
252 Added LayoutItemPortalDeepCloneTest.
254 2012-05-11 Murray Cumming <murrayc@murrayc.com>
256 Make navigation work again.
258 * src/main/java/org/glom/web/server/libglom/Document.java:
259 Add getLayoutItemFieldShouldHaveNavigation().
260 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
261 Replace get/setAddNavigation() with the partly-existing
262 get/setNavigationTableName(), with an empty string being no navigation,
263 because this is simpler. Use the new
264 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
266 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
267 Add updateFieldsExtras() and call setNavigationTableName in it.
268 getDetailsLayoutGroup(),
269 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
270 createLayout(): Adapted.
271 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
272 Constructor: Adapted.
274 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
275 Replace get/setAddNavigation() with get/setNavigation(), returning a
276 TableToViewDetails class with both the table name and UsesRelationship,
277 because both are need. The previous code used java-libglom's output
278 variable (strangely, via sharedptr) to return both, but we cannot really
280 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
281 getNavigationRecord(): Adapt. However, we cannot actually use the cache
282 here because it somehow gets set to null during deepCopy(). I must test this.
283 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
284 testGetSuitableTableToViewDetails(): Adapted.
286 TODO: Find out why deepClone() is not quite working.
288 2012-05-11 Murray Cumming <murrayc@murrayc.com>
290 DBAccess: Simplify the retrievel of full field details.
292 * src/main/java/org/glom/web/server/database/DBAccess.java
293 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
294 because the Document loading should have done this.
296 2012-05-11 Murray Cumming <murrayc@murrayc.com>
298 Document: Correct loading of doubly-related layout fields.
300 * src/main/java/org/glom/web/server/libglom/Document.java:
301 loadUsesRelationship(): Actually set the related relationship, instead
302 of only setting it if it's not found.
304 2012-05-09 Murray Cumming <murrayc@murrayc.com>
306 Replace all appearances of Colour with color.
308 Because US English is dominant.
310 2012-05-09 Murray Cumming <murrayc@murrayc.com>
312 Use colors in HTML format, solving a warning about an unused function.
314 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
315 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
316 Add *asHTMLColor() versions of methods.
317 TODO: However, we should create and cache the results on the server.
318 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
319 * src/main/java/org/glom/web/client/ui/list/ListTable.java
320 * src/main/java/org/glom/web/server/ConfiguredDocument.java
321 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
322 Use the asHTMLcolor() versions.
324 2012-05-09 Murray Cumming <murrayc@murrayc.com>
326 ListViewTable: Constructor: Take the table name as a parameter.
328 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
329 Constructor: Take the tableName, and set the member variable, because
331 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
332 setCellTable(): Pass the table name.
333 This makes navigation to non-default tables work again. I don't know
334 why it worked before in the master branch.
336 2012-05-07 Murray Cumming <murrayc@murrayc.com>
338 ConfiguredDocument: Restore correct addition of hidden primary key items.
340 * src/main/java/org/glom/web/client/ui/list/ListTable.java
341 (ListTable.createCellTable): Uncomment out the check for the hidden
343 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
344 add primary key items for top-level lists and portals, as before,
345 instead of adding them to each group.
346 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
347 Actually implement the extra methods such as setHiddenPrimaryKey() and
348 comment that these are used only for top-level list groups and in portals.
349 This strangeness suggests even more that this should not be squeezed
350 into the LayoutGroup class.
352 2012-05-07 Murray Cumming <murrayc@murrayc.com>
354 Fix Formatting loading.
356 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
357 getFormattingUsed(): Remove the duplicate Formatting member variable
358 in favour of the one from the base class.
359 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
360 Initialize a new Formatting instead of using null by default, so we
361 have some defaults, instead of having to initialize one later just to
362 get the same defaults. This also makes loading of formatting from the
363 document work, because that expected a non-null.
365 2012-05-07 Murray Cumming <murrayc@murrayc.com>
367 RelatedListTable: Make sure that the tableName is set.
369 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
370 Constructor: Take the tableName so it is available later. Otherwise,
371 the server assumes that we mean the default table and cannot find the
373 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
374 setData(): Pass the tableName to the RelatedListTable constructor.
376 2012-05-07 Murray Cumming <murrayc@murrayc.com>
380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
381 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
382 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
384 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
386 * src/main/java/org/glom/web/server/database/DBAccess.java:
387 convertResultSetToDTO(), getPortal():
388 * src/main/java/org/glom/web/server/database/ListDBAccess.java
390 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
391 Add checks for null objects and out of range access, with log messages to
392 give hints so we can fix these properly.
394 2012-05-07 Murray Cumming <murrayc@murrayc.com>
396 Portals: some corrections.
398 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
400 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
401 constructor: Use getRelationshipNameUsed() instead of getName(), because
402 that is what is meant.
403 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
404 getFromField(): Fix a typo, to get the field name, not the table name.
405 * src/main/java/org/glom/web/server/database/DBAccess.java:
406 getPortal(): Fix a typo that stopped this from working.
408 2012-05-07 Murray Cumming <murrayc@murrayc.com>
410 LayoutItemPortal: Also override getTitleOriginal().
412 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
413 This lets the base getTitle() with no parameters work.
414 TODO: Test this properly.
416 2012-05-06 Murray Cumming <murrayc@murrayc.com>
418 LayoutItemPortal: getTitle*(): Use the relationship title.
420 2012-05-06 Murray Cumming <murrayc@murrayc.com>
422 LayoutItemField: Fix loading of custom titles.
424 * src/main/java/org/glom/web/server/libglom/Document.java
425 loadDataLayoutItemField(): The title, if any, instead of the field
426 title, is stored in a title_custom node. Load it from there.
427 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
429 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
430 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
431 getTitle*() overrides.
432 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
435 2012-05-06 Murray Cumming <murrayc@murrayc.com>
437 LayoutItemField: Fall back to field titles, so some are really shown.
439 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
440 Override getTitleOriginal() and getTitle(), as in java-libglom.
441 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
444 2012-05-06 Murray Cumming <murrayc@murrayc.com>
446 Correct use of setExpectedResultSize().
448 * src/main/java/org/glom/web/server/ConfiguredDocument.java
449 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
450 Use setExpectedResultSize only on top-level groups (for instance, the
451 list layout) or on child portals (in details views).
452 Use the correct table name for portals to avoid SQL errors.
453 Update the expected counts when returning cached layouts.
455 2012-05-06 Murray Cumming <murrayc@murrayc.com>
457 Document: Interpret no group column count as 1.
459 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
460 default, though we now check for this in the UI code anyway.
462 2012-05-06 Murray Cumming <murrayc@murrayc.com>
466 2012-05-06 Murray Cumming <murrayc@murrayc.com>
468 Translatable: Use Hashmap instead of Treemap because GWT supports it.
470 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
471 The use of Treemap lead to this error from async methods, with no
473 "The response could not be deserialized"
475 2012-05-06 Murray Cumming <murrayc@murrayc.com>
477 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
479 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
480 when using the Google -> GWT Compile, or
481 g toolbar button -> GWT Compile Project... feature in Eclipse.
483 2012-05-06 Murray Cumming <murrayc@murrayc.com>
485 ListTable.addColumn(): Protect against a null Formatting.
487 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
488 Create a default Formatting if it is null, because that is the simplest
491 2012-05-06 Murray Cumming <murrayc@murrayc.com>
493 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
495 * src/main/java/org/glom/web/server/ConfiguredDocument.java
496 updateLayoutGroup(): Check that the field is not null.
498 2012-05-06 Murray Cumming <murrayc@murrayc.com>
500 ListViewImpl: Protected against a bad cast error.
502 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
503 onEnterKeyDown(): Do not cast without an instanceof check.
505 2012-05-06 Murray Cumming <murrayc@murrayc.com>
507 ListTable: Protect against an out of range error.
509 * src/main/java/org/glom/web/client/ui/list/ListTable.java
510 createCellTable(): This is unlikely, but can happen while debugging.
512 2012-05-06 Murray Cumming <murrayc@murrayc.com>
514 AsyncMessage onFailure() callbacks: Log the exception message.
516 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
517 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
518 * src/main/java/org/glom/web/client/activity/ListActivity.java:
519 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
520 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
521 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
522 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
523 These are useful clues when something is wrong.
525 2012-05-06 Murray Cumming <murrayc@murrayc.com>
527 ConfiguredDocument: Avoid a null dereference.
529 * src/main/java/org/glom/web/server/ConfiguredDocument.java
530 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
531 details maps are created.
533 2012-05-06 Murray Cumming <murrayc@murrayc.com>
535 Document: Correct the port number parsing.
537 * src/main/java/org/glom/web/server/libglom/Document.java:
538 This lets us actually connect to the database and show the document.
540 2012-05-05 Murray Cumming <murrayc@murrayc.com>
544 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
545 user-interaction, asking us to load a temporary URL in a browser.s
546 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
547 which is apparently necessary for testing the service. See the comment.
548 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
549 Show the exception, if any. This is how I saw the 404 in the HTML in
552 2012-05-05 Murray Cumming <murrayc@murrayc.com>
554 DocumentTest: Move the .glom files into the resources directory.
556 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
557 URI via getResource().
559 2012-05-05 Murray Cumming <murrayc@murrayc.com>
561 Document: Remove the FieldIdentifies inner class.
563 * src/main/java/org/glom/web/server/libglom/Document.java: We only
564 use the Relationship (though the same function in libglom is maybe
565 used in other ways) and so this removes a compiler warning.
567 2012-05-05 Murray Cumming <murrayc@murrayc.com>
569 Document.load() Remove the error code parameter.
571 * src/main/java/org/glom/web/server/libglom/Document.java: load():
572 Remove the parameter. We do not set it yet and it could never have
573 worked as an output parameter (though maybe it did in java-libglom).
574 We could use an exception if we really want the failure reason.
575 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
577 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
578 setUp(), testGetSuitableTableToViewDetails(): Adapt.
580 2012-05-05 Murray Cumming <murrayc@murrayc.com>
582 Make some inner classes static.
584 * src/main/java/org/glom/web/server/ConfiguredDocument.java
585 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
586 * src/main/java/org/glom/web/server/ReportGenerator.java
587 * src/main/java/org/glom/web/server/libglom/Document.java
588 Make all inner classes static that can be static.
590 2012-05-05 Murray Cumming <murrayc@murrayc.com>
592 OnlineGlomServiceImpl: Do not load and check for java-libglom.
594 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
595 init(): We do not use java-libglom any more.
597 2012-05-05 Murray Cumming <murrayc@murrayc.com>
599 Remove mentions of java-libglom.
601 * README: Remove mention of java-libglom, because it no longer needed.
602 * utils/build-onlineglom-war.sh:
603 * utils/check-and-recover-tomcat.py:
604 * utils/install-onlineglom-war.sh: Remove these as they are no longer
605 useful. Building is now far easier, with no need for jhbuild.
607 2012-05-05 Murray Cumming <murrayc@murrayc.com>
609 Fix the build (mvn package)
611 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
612 (LayoutGroup): Make the LayoutItemList inner class static and protected.
613 Otherwise the GWT Java->Javascript compilation fails with just this
614 error, during mvn package or when attempting to view in a browser,
615 in the GWT developer mode in Eclipse.
617 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
618 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
619 [INFO] Compiling module org.glom.web.OnlineGlom
620 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
621 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
622 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
623 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
624 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
625 [INFO] [ERROR] Cannot proceed due to previous errors
627 It has taken me 2 days to find out what was causing that. After reducing
628 the code, the compiler eventually showed me the full error message.
630 2012-05-04 Murray Cumming <murrayc@murrayc.com>
632 ConfiguredDocument: Cache the cloned and stripped layouts.
634 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
635 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
636 layout in a map, so we can retrieve it again without rebuilding it.
638 2012-05-04 Murray Cumming <murrayc@murrayc.com>
640 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
642 2012-05-04 Murray Cumming <murrayc@murrayc.com>
644 libglom classes: Implement some auto-generated emthods.
646 2012-05-04 Murray Cumming <murrayc@murrayc.com>
648 Add GwtTestOnlineGlomService.
650 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
651 However, this (and the other GwtTest*) does not seem to run during
654 2012-05-04 Murray Cumming <murrayc@murrayc.com>
656 Remove use of unsupported features from client code.
658 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
659 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
660 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
661 Use our client version of StringUtils instead of the apache commons one.
663 However, the GWT Javascript compliation still fails.
665 2012-04-25 Murray Cumming <murrayc@murrayc.com>
667 Add a Field class and implement some loading of it in Document.
669 2012-04-25 Murray Cumming <murrayc@murrayc.com>
671 Initial Document loading implementation, instead of libglom.
673 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
674 and Translatable classes, and adapt the rest of the code to use them.
675 However, this is still missing Layout and Field classes and loading.
677 2012-04-24 Murray Cumming <murrayc@murrayc.com>
679 Use of jOOQ: Move Field creation into a utility method.
681 * src/main/java/org/glom/web/server/SqlUtils.java:
682 This lets us improve it more easily.
684 2012-04-24 Murray Cumming <murrayc@murrayc.com>
686 Use of jOOQ: Improve the code to COUNT a sub-select.
688 * src/main/java/org/glom/web/server/SqlUtils.java:
689 Move initial query creation into
690 build_sql_select_step_with_where_clause().
691 build_sql_select_count_rows(): Use the jOOQ API instead of
692 concatentating text, because a jOOQ Select*Step is a TableLike,
693 which is what from() takes.
695 2012-04-23 Murray Cumming <murrayc@murrayc.com>
697 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
699 * pom.xml: Depend on jooq.
700 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
701 methods with jOOQ, based on the C++ implementations in libglom,
702 with some changes to the logic required by jooQ.
703 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
705 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
706 * src/main/java/org/glom/web/server/ReportGenerator.java:
707 * src/main/java/org/glom/web/server/SqlUtils.java:
708 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
709 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
710 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
711 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
712 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
713 Adapt. In particular, the SqlUtils methods now need to take a Connection,
714 because jOOQ needs that, though it seems unnecessary.
716 This is not quite finished. Ideally jOOQ would help us to build
717 table_name.field_name names, quoting and escaping them properly.
718 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
720 2012-04-21 Murray Cumming <murrayc@murrayc.com>
722 Move use of Glom.build_sql*() into a new SqlUtils class.
724 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
725 to wrap Glom.build_sql*(). The parameter types are still Glom one,
726 but this will make it easier to start using something other than
727 libglom or SqlBuilder.
729 2012-04-21 Murray Cumming <murrayc@murrayc.com>
731 Update the project URL.
733 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
735 2012-04-21 Murray Cumming <murrayc@murrayc.com>
737 Main layout: Use a FlowTable instead of absolute positioning.
739 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
740 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
741 child panels/widgets must have an absolute position. But that is annoying, so
742 this adds a FlowTable and puts the child panels in there.
744 2012-04-21 Murray Cumming <murrayc@murrayc.com>
746 GwtTestOnlineGlom: Comment out unused code.
748 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
749 Eclipse has started to say that some code is unused.
751 2012-04-21 Murray Cumming <murrayc@murrayc.com>
753 Update to the latest versions of dependencies.
755 * pom.xml: Update version numbers of dependencies to the latest
757 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
758 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
759 * src/main/java/org/glom/web/server/ReportGenerator.java:
760 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
761 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
762 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
764 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
765 Modify the imports where necessary.
767 2012-04-17 Murray Cumming <murrayc@murrayc.com>
769 Style: Remove overflow:hidden from searchbox
771 * src/main/webapp/style.css: Because this pushes the Back To Link
772 label/link on to the next row, which is then hidden due to the
773 hard-coded (in ems) height.
775 2012-04-20 Murray Cumming <murrayc@murrayc.com>
777 Remove some duplicate code.
779 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
780 getDocumentInfo(): This must have been duplicated during the merge from the
785 2012-04-19 Murray Cumming <murrayc@murrayc.com>
787 Reports: Localize the waiting for report message.
789 * src/main/java/org/glom/web/client/activity/ReportActivity.java
790 start(): Get the message from the contants.
791 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
793 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
794 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
795 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
796 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
797 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
798 Update these files with the English text for newer strings for now.
800 2012-04-19 Murray Cumming <murrayc@murrayc.com>
802 Reports: Show a message while waiting for the report.
804 * src/main/java/org/glom/web/client/ui/ReportView.java
805 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
806 Add setWaitingText(), to show a message saying that we are
807 waiting for the report to be ready.
808 * src/main/java/org/glom/web/client/activity/ReportActivity.java
809 start(): Call setWaitingText() before calling the async
812 2012-04-19 Murray Cumming <murrayc@murrayc.com>
814 ReportGenerator: Specify date and time formats.
816 * src/main/java/org/glom/web/server/ReportGenerator.java:
817 createFieldValueElement(): Use the default (and localized)
818 short formats, though we still need a way to show 4-digit
819 years without providing the format for every locale.
820 * src/main/java/org/glom/web/server/database/DBAccess.java:
821 convertResultSetToDTO(): Use the short formats here too.
823 2012-04-18 Murray Cumming <murrayc@murrayc.com>
825 ReportGenerator: Use the correct numeric formatting.
827 * src/main/java/org/glom/web/server/ReportGenerator.java
828 createFieldExpression(), createFieldValueElement(): Take the
829 whole LayoutItem_Field instead of just the field name, so
830 we have access to the formatting.
831 createFieldValueElement(): Use JRTextField.setPattern() to
832 specify the numeric formatting, with the help of a
833 regular DecimalFormat.
835 2012-04-18 Murray Cumming <murrayc@murrayc.com>
837 ReportGenerator: Avoid showing null for group by titles.
839 * src/main/java/org/glom/web/server/ReportGenerator.java
840 generateReport(): Use setBlankWhenNull() on the field title
841 style too, because this is used for values in group by
844 2012-04-18 Murray Cumming <murrayc@murrayc.com>
846 ReportGenerator: Add a colon to titles in vertical groups.
848 * src/main/java/org/glom/web/server/ReportGenerator.java
849 addFieldToDetailBandVertical(): Pass true for the withColon
852 2012-04-18 Murray Cumming <murrayc@murrayc.com>
854 ReportGenerator: Simplify the code by using Position more.
856 2012-04-18 Murray Cumming <murrayc@murrayc.com>
858 Reports: Support vertical groups, roughly.
860 * src/main/java/org/glom/web/server/ReportGenerator.java:
861 addToReport(): Rename to addGroupToReport() and, if necessary,
862 call the new addVerticalGroupToReport() method.
863 createFieldValueElement(): Let the caller specify the Y position
866 2012-04-17 Murray Cumming <murrayc@murrayc.com>
868 Reports: Allow a second report to be shown.
870 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
871 clear(): Do not remove the HTML widget, which broke the whole layout.
873 2012-04-17 Murray Cumming <murrayc@murrayc.com>
875 Locales drop-down: Show that we use English by default.
877 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
878 fillView(): When we use English, just because that is the default, when
879 no locale is specified, show that in the Locales drop-down instead of
880 just showing the first item.
882 2012-04-17 Murray Cumming <murrayc@murrayc.com>
884 Unselect the Report/Locale/Table combo item when appropriate.
886 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
887 setPlace(): clear reportName if this is not a ReportPlace.
888 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
889 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
890 When the provided name is empty, unselect all items, so that none are
891 indicated. This uses a for loop because I cannot find a single method
894 2012-04-17 Murray Cumming <murrayc@murrayc.com>
896 Report: Give the user a way to get back to the list.
898 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
899 start(), setPlace(): Show the Back To List link on reports, and also
900 interpret selecting the empty report item as back to list.
902 2012-04-13 Murray Cumming <murrayc@murrayc.com>
904 Really show the selected Report name.
906 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
907 setPlace(): Store the reportName here, if it is that kind of Place.
908 fillView(): Set the selected Report after filling the list of reports.
909 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
910 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
911 null Strings, though we need some way to unselect all ListBox items
914 2012-04-13 Murray Cumming <murrayc@murrayc.com>
916 ReportGenerator: Try to avoid some problems.
918 * src/main/java/org/glom/web/server/ReportGenerator.java
919 addField(): Try to avoid duplicates, and avoid using a null
922 2012-04-13 Murray Cumming <murrayc@murrayc.com>
924 Reports: Use quickFind.
926 * src/main/java/org/glom/web/client/OnlineGlomService.java;
927 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
928 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
929 getReportHTML(): Add a quickFind parameter.
930 * src/main/java/org/glom/web/client/activity/ReportActivity.java
931 start(): Pass the quickFind parameter.
932 * src/main/java/org/glom/web/server/ReportGenerator.java
933 generateReport(): Take a quickFind parameter.
935 2012-04-13 Murray Cumming <murrayc@murrayc.com>
937 ReportPlace: Actually use the report name.
939 * src/main/java/org/glom/web/client/place/ReportPlace.java
940 getPlace(): Do not assign the report name to the quickfind.
942 2012-04-13 Murray Cumming <murrayc@murrayc.com>
944 Show java.library.path when complaining.
946 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
947 init(): When telling us to check java.library.path, show the
950 2012-03-06 Murray Cumming <murrayc@murrayc.com>
952 ReportGenerator: Do not show nulls.
954 2012-03-06 Murray Cumming <murrayc@murrayc.com>
956 ReportGenerator: Make the title font larger.
958 2012-03-06 Murray Cumming <murrayc@murrayc.com>
960 ReportGenerator: Put field titles inside groups, if there are groups.
962 2012-03-06 Murray Cumming <murrayc@murrayc.com>
964 ReportGenerator: Take the Report itself instead of the name and group.
966 * src/main/java/org/glom/web/server/ConfiguredDocument.java
967 Remove getReportLayoutGroup().
968 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
969 getReportHTML(): Pass the report instead
970 of its name and layout group.
971 * src/main/java/org/glom/web/server/ReportGenerator.java
972 generateReport(): Use the report object to use the title
975 2012-03-06 Murray Cumming <murrayc@murrayc.com>
977 ReportGenerator: Remove designBand parameters.
979 * src/main/java/org/glom/web/server/ReportGenerator.java:
980 Make designBand a class member instead of passing it to all
983 2012-03-06 Murray Cumming <murrayc@murrayc.com>
985 ReportGenerator: Add lines, a bit like in the desktop version.
987 * src/main/java/org/glom/web/server/ReportGenerator.java
988 addToReport(): Use JRDesignLine.
990 2012-03-06 Murray Cumming <murrayc@murrayc.com>
992 ReportGenerator: Correct the title positions and use some bold style.
994 * src/main/java/org/glom/web/server/ReportGenerator.java:
995 Break the code up into reusable functions, correct the placement of
996 titles, and use normal/bold styles as in the reports in the desktop
999 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1001 ReportGenerator: Add a header band to show the field titles.
1003 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1004 getReportHTML(): Pass the localeId to the ReportGenerator
1006 * src/main/java/org/glom/web/server/ReportGenerator.java
1007 constructor: Take the localeID so we can get translated field
1009 generateReport(), addToReport(), addFieldToBand(): Add field
1010 titles in a column header band.
1012 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1014 Reports drop-down list: Some improvement.
1016 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1017 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1018 Adedd setSelectedReport(),
1019 setReportList(): Add a blank line so that the user can select the
1021 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1022 start(): Show the current report by calling setSelectedReport().
1023 This does not seem to work yet.
1025 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1027 DetailsActivity, ListActivity: Move some variables into a base class.
1029 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1030 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1031 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1032 the clientFactory, documentID, tableName and authenticationPopup into
1033 a base class, to avoid duplication.
1035 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1037 Translate the Reports label.
1039 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1040 Get the "Reports" label string from the constants.
1041 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1042 perties: Add Reports to the constants.
1044 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1046 Reports: Implement grouping.
1048 * src/main/java/org/glom/web/server/ReportGenerator.java:
1049 Handle LayoutItem_GroupBy items and try to do the right thing
1050 with JRDesignGroup. It seems to work.
1052 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1054 Actually show some data with JasperReports.
1056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1057 getReportHTML(): Move most code into a ReportGenerator class.
1058 * src/main/java/org/glom/web/server/ReportGenerator.java:
1059 Recurse into sub-groups, adding fields to the JasperDesign's details
1060 band. Note that we must set an arbitrary width and height, or it just
1061 will not show any data.
1063 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1065 Reports Chooser: Show the titles, not the names.
1067 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1068 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1069 and the names as the values.
1070 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1071 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1072 group now that we provide the report name, so it should always
1075 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1077 Depend on jasperreports.
1079 * pom.xml: Add the dependency. My plan is to use this on the
1082 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1084 Implement navigation to report places.
1086 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1087 start(): Do not bother to handle all events here.
1088 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1089 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1090 Added getSelectedReport().
1091 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1092 .java: start(): When handling a change to the reports chooser,
1093 call getSelectedReport() and goTo() its ReportPlace.
1094 * src/main/java/org/glom/web/client/ui/ReportView.java
1095 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1096 Added setReportHTML() which puts the html in a gwt HTML widget.
1097 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1098 getReportHTML(): Return "TODO" just to show that this works.
1100 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1102 Make ReportPlace usable.
1104 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1105 Mention ReportPlace.
1106 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1107 Correct the @prefix annotation.
1109 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1111 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1113 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1114 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1115 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1116 Change getReportLayout() to getReportHMTL() because we will not need to
1117 parse or render the report layout on the client side.
1118 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1119 getReportLayout(): Return the libglom LayoutGroup type because we will
1120 not need to convert to a shared type, because this will not be used on
1122 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1125 Note that there is still no implementation for this.
1128 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1130 Add a (empty) Report Place, View, and Activity.
1132 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1134 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1135 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1136 this into a superclass:
1137 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1138 and also use it as the base of this new ReportPlace:
1139 * src/main/java/org/glom/web/client/place/ReportPlace.java
1141 * src/main/java/org/glom/web/client/ui/ReportView.java
1142 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1143 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1144 Add these, containing mostly boiler-plate for now.
1146 * src/main/java/org/glom/web/client/OnlineGlomService.java
1147 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1148 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1150 Add API to get the LayoutGroup for the report.
1152 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1154 Add and fill a Reports drop-down list box.
1156 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1158 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1159 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1161 Added getReports(document, table, localeID), calling
1162 ConfiguredDocument.getReports().
1163 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1164 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1165 Added setReportsList() and a list widget.
1166 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1167 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1172 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1174 Translations: Add Esperanto.
1176 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1177 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1178 properties: Add this translation because someone took the time to make it.
1180 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1182 Adapt to the java-libglom 1.21.7 API.
1184 * src/main/java/org/glom/web/server/ReportGenerator.java:
1185 addToReport(): get_group_secondary_fields() is now
1186 get_secondary_fields().
1189 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1191 Use the latest java-libglom version.
1193 * pom.xml: Use java-libglom 1.21.7.
1195 2012-03-03 Ben Konrath <ben@bagu.org>
1197 Display date and time in details view.
1199 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1201 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1203 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1205 Require the latest java-libglom.
1207 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1209 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1211 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1213 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1214 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1215 an empty quickfind string. I also corrected libglom to create only
1216 empty where clauses for empty quickfind strings, but this avoids the
1219 2012-02-24 Ben Konrath <ben@bagu.org>
1221 Improve the tabs in the Notebook widget.
1225 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1227 Translations: Try to translate the strings.
1229 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1230 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1231 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1232 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1233 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1234 Take the Open translation from GTK+'s .po files.
1235 Take the Details translation from Glom's po files.
1236 I have added the other strings to Glom so we can get translations that way:
1237 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1239 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1241 TableSelectionViewImpl: Put the search label and entry in a div.
1243 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1244 Put the search widgets in a FlowTable so that the CSS can be used to
1245 style them while keeping them together.
1246 * src/main/webapp/style.css: Mention the new div.
1248 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1250 Translate more strings in more locales.
1252 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1253 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1254 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1255 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1256 Translate the "Details" and "Open" string too.
1258 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1259 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1260 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1261 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1262 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1263 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1264 Add these new locales as placeholders though they currently contain English.
1266 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1268 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1270 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1271 Check the ConfiguredDocument* for null before using it.
1273 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1275 Tell Eclipse about the generated java files.
1277 * .classpath: This lets it find OnlineGlomConstants.java.
1278 It would be nice if Eclipse just used the maven build files.
1280 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1282 Prevent a crash when no locale is specified in the URL.
1284 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1285 Avoid returning a null string, obtained from
1286 Window.Location.getParameter(). This caused a crash when it was
1287 later passed to libglom's API.
1288 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1289 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1290 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1291 guard against future null strings.
1293 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1295 Use the ?locale= query param instead of the &lang= token param.
1297 * src/main/java/org/glom/web/client/place/ListPlace.java
1298 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1299 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1300 Remove the lang token key and value.
1302 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1303 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1304 When the user selects a different locale from the chooser, use
1305 Window.Location.assign() to change the URL, which then causes a reload.
1307 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1308 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1309 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1310 * src/main/java/org/glom/web/client/activity/ListActivity.java
1311 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1312 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1313 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1314 * src/main/java/org/glom/web/client/ui/ListView.java:
1315 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1317 Remove localeID member variables and method/constructor parameters, instead
1318 using Utils.getCurrentLocaleID() when we need a localID to pass to
1321 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1323 Internationalize the UI strings.
1325 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1326 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1327 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1328 because it is unused. Messages are apparently strings that can have
1329 parameters, but we do not need that yet, so Contants will be enough for now.
1330 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1331 to say that we support the en and de locales.
1332 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1333 The original English strings.
1334 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1335 Some German translations of the English strings.
1336 The i18n goal then uses the .properties file to generate an
1337 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1338 returns an implementation that returns the translated strings.
1339 The documentation suggests putting these in src/java/*/client/, but it seems
1340 best to put it in src/resources/*/client/.
1341 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1342 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1343 instead of hard-coding them.
1344 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1345 but that does not seem to stop the build, though it confuses Eclipse.
1347 You can see the translated string by adding ?locale=de to the URL, like so:
1348 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1350 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1352 Improve null/empty String checks.
1354 * pom.xml: Add a dependency on commons-lang, to use
1355 org.apache.commons.lang.StringUtils.
1356 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1357 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1358 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1359 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1360 Use StringUtils.isEmpty().
1362 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1363 StringUtils class with a static isEmpty() function because we
1364 cannot use org.apache.commons.lang.StringUtils in client-side
1365 GWT code because it (apparently) cannot be compiled to javascript.
1366 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1367 * src/main/java/org/glom/web/client/activity/ListActivity.java
1368 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1369 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1370 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1371 * src/main/java/org/glom/web/client/place/ListPlace.java
1372 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1373 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1374 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1375 * src/main/java/org/glom/web/client/ui/details/Group.java
1376 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1377 our StringUtils.isEmpty() function.
1379 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1381 Update to the latest java-libglom API.
1383 * pom.xml: Require java-libglom 1.21.4.
1384 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1385 getDocumentInfo(), getListViewLayoutGroup():
1386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1388 * src/main/java/org/glom/web/server/database/DBAccess.java
1389 getFieldsToShowForSQLQueryAddGroup(),
1390 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1391 with either get_database_title_original() or
1392 get_database_title(localeID).
1394 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1396 ConfiguredDocument: Avoid a null pointer exception.
1398 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1399 Initialize localeID to "" to avoid returning a null String which
1400 causes a crash in java-libglom's swing-generated code.
1402 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1404 Some simple renaming.
1406 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1407 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1408 for localeChooser. This seems more appropriate and is less ambiguous
1409 particularly in the .css file.
1411 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1413 ConfiguredDocument: Rename the localedID private member variable.
1415 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1417 Adapt to the latest java-libglom API from git master.
1419 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1420 libglom now uses only Vector instead of List, which uses add() instead of
1423 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1425 ConfiguredDocument: Rename the localedID private member variable.
1427 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1429 Build a source tarball with mvn assembly:single
1431 * assembly.xml: Add this file.
1432 * pom.xml: Use the maven-assembly-plugin and tell it to use
1433 our assembly.xml file.
1435 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1437 OnlineGlomServiceImpl: Get .glom files recursively.
1439 * pom.xml: Depend on commons-io from org.apache.commons.
1440 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1441 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1442 files recursively, and with the easier filter for the extension.
1443 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1444 simplify that code too.
1446 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1448 README: Mention that you must install java-libglom packages separately.
1450 But then it works, because java-libglom is now in the central maven
1453 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1455 locales drop-down: Show the correct selected locale when the URL changes.
1457 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1458 .java: setPlace(): Move some code into fillView().
1460 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1462 locales drop-down: Do not lose the primary key.
1464 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1465 start(): onLocaleChange(): Pass the current primary key value,
1466 instead of an empty value.
1468 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1470 locales drop-down: Do not lose the drop-down selection.
1472 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1473 .java (TableSelectionActivity.fillView): Set the selected locale
1474 after changing the drop-down items (though we do not really need
1475 to change them just because the locale changes.)
1477 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1479 locales drop-down: Change the tables list when this changes.
1481 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1482 .java: TableSelectionActivity.start(): Move the async table titles
1483 retrieval into a private fillView() method and also call this when
1484 the chosen locale changes.
1485 Note that the document title is not actually translatable yet, but
1486 that is a problem that I should fix soon in libglom.
1488 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1490 Improve the placement of the locales drop-down.
1492 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1493 Put the title and locales drop-down in a div (gwt.FlowTable).
1494 * src/main/webapp/style.css: Add magic css properties to make this work.
1495 Also remove the left margin from the title so that it lines up with the
1498 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1500 locales selector: Show human-readable locale titles.
1502 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1503 getDocumentInfo(): Use java.util.Locale to show a real title of
1504 each locale, in the locale's own language.
1506 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1508 Add a language/locale selector drop-down.
1510 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1511 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1512 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1513 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1514 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1515 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1516 Add a ListBox to show the available locales. Add getLocaleSelector(),
1517 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1518 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1519 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1520 java: Add these classes.
1521 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1522 start(): Fill the locales ListBox. Handle its change event, firing a
1524 setPlace(): Show the selected locale as specified by the URL token.
1525 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1526 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1527 Handle LocaleChangeEvent, going to a new *Place with that locale.
1529 The placement of the ListBox is not pretty, and it currently uses the ID
1530 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1534 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1536 Search box: Show the search text from the URL token.
1538 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1539 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1540 Add setQuickFindText().
1541 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1542 .java: setPlace(): Store the queryText if the place is a ListPlace,
1543 and call TableSelectionView.setQuickFindText().
1545 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1547 Allow use of translations via, for instance, &lang=de in the URL.
1549 * pom.xml: Use the unstable java-libglom 1.21 version.
1551 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1552 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1554 init(): Instead of calling TranslatableItem.set_current_locale()
1555 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1556 However, this is only for default locales, which are not needed to
1557 change the locale in the URL.
1558 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1559 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1560 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1561 layout for a particular locale.
1562 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1563 Add get/setDefaultLocaleID().
1564 getDocumentInfo(), getListViewData(), getRelatedListData(),
1565 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1566 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1567 localeID parameter, so we can get the layout for a particular locale.
1569 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1570 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1571 * src/main/java/org/glom/web/client/place/ListPlace.java:
1572 Parse and construct a lang parameter too.
1574 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1575 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1576 passed to subsequent methods and constructors.
1577 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1578 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1579 Store the localeID from the *Place and pass it to other constructors
1580 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1582 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1583 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1584 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1585 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1586 * src/main/java/org/glom/web/client/ui/ListView.java:
1587 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1588 Take localeID parameters and pass them to subsequent constructors and
1589 methods, so that the layout is always retrieved for that locale.
1591 This is rather repetitive.
1593 Note that "" means the original (default) locale of the Glom document,
1594 which is usually English.
1596 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1598 Documents: Remove final keyword to fix startup configuration.
1600 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1601 final keywords on the private member variables because that breaks
1602 the startup, apparently (there are warnings) because it stops them
1603 from being serialized. I added these in the previous commit.
1605 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1607 Documents: Add some final keywords.
1609 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1612 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1614 OnlineGlomServiceImpl: Add to overview comments.
1616 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1617 Note that this is where all the document are loaded. They are not
1618 loaded freshly for each page.
1620 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1624 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1625 Add a TextBox for the text of a quick find.
1626 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1628 setBackLink(): Add a String quickFind parameter.
1629 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1630 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1631 to the base interface, because that is how TableSelectionViewImpl is used.
1632 * src/main/webapp/style.css: Add style for the search box and its label.
1634 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1635 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1636 Add these files, based on the existing TableChangeEvent and
1637 TableChangeEventHandlers.
1638 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1639 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1640 a ListPlace() that the user should be taken to.
1641 * src/main/java/org/glom/web/client/activity/ListActivity.java
1642 start(): Handle it here too and adapt the TableChangeEvent handler to
1643 pass the extra "" quickFind parameter to ListPlace.
1644 * src/main/java/org/glom/web/client/place/ListPlace.java:
1645 Constructor: Take an extra String quickFind parameter and store it,
1646 returning it from a new getQuickFind() method.
1647 getToken(): Put the quickFind text in the URL token.
1648 getPlace(): Parse the quickFind text from the URL token.
1649 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1650 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1651 ListPlace constructor.
1652 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1653 .java: start(): Add a Change handler for the TableSelectionView's
1654 TextBox (via its base HasChangeHandlers interface), firing the new
1655 QuickFindChangeEvent.
1656 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1657 pass the extra "" quickFind parameter.
1659 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1660 setCellTable(): Add a String quickFind parameter and pass it to
1661 the ListViewTable() constructor.
1662 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1663 setCellTable() in the base interface, because that is how ListViewImpl
1666 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1667 Add a String quickFind member variable.
1668 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1669 Constructor: Add a String quickFind parameter, storing it in the
1670 base ListTable's member variable.
1671 onRangeChanged(): Pass quickFind to the
1672 OnlineGlomServiceAsync.getSortedListViewData() and
1673 OnlineGlomServiceAsync.getListViewData() methods.
1675 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1676 getListViewData(), getSortedListViewData(): Add a String quickFind
1677 parameter, passing it to ConfiguredDocument.getListViewData().
1678 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1679 Change getListViewData(), getSortedListViewData() in the base interface,
1680 because that is how OnlineGlomServiceImpl is used, via this:
1681 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1682 Change getListViewData(), getSortedListViewData() here too.
1683 This class can apparently be used to asynchronously call methods on
1684 OnlineGlomService, and GWT seems to implement that after recognizing
1685 just the *Async name convention and the extra AsyncCallback parameters.
1687 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1688 getListViewData(): Add a String quickFind parameter, and pass it to
1689 ListViewDBAccess.getData().
1690 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1691 getListData(): Add a String quickFind parameter and pass it to
1693 getSelectQuery(): Add a String quickFind parameter.
1694 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1695 getSelectQuery(): Add a String quickFind parameter and use it with
1696 Glom.get_find_where_clause_quick() to pass a where_clause to
1697 Glom.build_sql_select_with_where_clause(), to actually filter the
1699 getData(): Add a String quickFind parameter, passing it to getListData().
1700 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1701 va: getData(): Pass an empty string to getListData() for the
1702 quickFind parameter.
1704 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1706 ListTable: Minor change.
1708 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1709 createCellTable(): Make this protected instead of public.
1711 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1713 Many files: Use final for the parameters and use the @override attribute.
1715 2012-01-22 Ben Konrath <ben@bagu.org>
1717 Add anchor links for single line text that starts with http, ftp and www.
1721 2012-01-22 Ben Konrath <ben@bagu.org>
1723 Add ellipsis to single line text in details view.
1727 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1729 Remove all javadoc author tags.
1731 Because they are awkward and meaningless when many people touch
1733 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1735 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1737 Revert the COPYING.LESSER to COPYING rename.
1739 Apparently both should be there if it is LGPL.
1741 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1743 *View: Remove unused imports.
1745 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1746 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1747 * src/main/java/org/glom/web/client/ui/ListView.java:
1748 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1749 Remove unused imports, as suggested by Eclipse.
1751 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1753 Move the *View::Presenter types, and some API into one base View.
1755 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1756 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1757 * src/main/java/org/glom/web/client/ui/ListView.java:
1758 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1759 Presenter, setPresenter() and clear() into a shared base interface,
1760 to avoid the unnecessary duplicate Presenter types and to more clearly
1761 show how the *Views share the same structure, even if they are not
1762 used polymorphically.
1764 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1765 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1767 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1768 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1769 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1771 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1774 Feel free to revert this if there is a good reason for the duplicate
1777 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1779 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1781 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1782 a class member instead of a local variable in the method.
1783 This lets us use it to get the view instances, for use in tests.
1784 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1785 beforeOnlineGlom(): Test some more details of the initial view.
1786 Again, this is not very useful.
1788 To really test gwt-glom we will need to start a local postgresql
1789 instance with local data, like the Glom tests in C++.
1791 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1793 pom.xml: Mention the LGPL license.
1795 * pom.xml: Add a licenses section.
1796 * COPYING.LESSER: Move this to COPYING, which
1797 previously contained the GPL. But gwt-glom is all LGPL.
1799 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1801 Add project information to README and pom.xml.
1803 * README: Add a brief description and mention some mvn
1805 * pom.xml: This extra information shows up in mvn site
1808 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1810 Use the latest java-libglom version.
1812 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1814 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1816 GwtTestOnlineGlom: Test a little more.
1818 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1819 protected rather than private, as suggested by the gwt-test-utils
1821 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1822 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1823 Test the initial visibility of the panels.
1825 However, this is not a very useful test.
1826 And I wonder how we should generally test using this idea for an
1827 activity/places app like ours where the real changes happen implicitly
1828 based on the history token/URL.
1830 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1832 Slight modification to *Mapper comments.
1834 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1835 (DataActivityMapper)
1836 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1838 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1840 Remove comments mentioning GIN because they are just copied from
1841 the example code and are apparently not helpful:
1842 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1843 Also change the mention of a class that is only in the example code.
1845 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1847 GwtTestOnlineGlom test: Minor changes.
1849 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1850 Avoid the long qualified class name and modify the comment
1851 because it is now obvious to me that the mocked class is the only
1852 custom one created via GWT.create().
1854 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1856 Tests: Added the beginnings of a test using gwt-test-utils.
1858 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1859 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1860 which tells gwt-test-utils what class will be tested.
1861 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1862 Add a simple (but empty) test case. One class, used by the OnlineGlom
1863 class, is mocked so that it can be created. However, I am not sure
1864 why only this class needs to be mocked.
1866 Note that mockito seems more popular, and clearer, than easymock,
1867 but I have not got that working yet. It might be a matter of the
1870 This test is run during mvn integration-test.
1872 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1874 Tests: Use junit4-style syntax instead of junit3-style.
1876 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1877 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1878 * src/test/java/org/glom/web/shared/DataItemTest.java:
1879 Use the @Test annotation rather than relying on the test*() prefix.
1880 Also no longer implement TestCase, to avoid triggering support for
1881 the junit3-way, which stops the annotations from working.
1882 Change the imports from import junit.framework.* to
1883 import org.junit.*, which is apparently the new way.
1885 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1887 Added a test for ListPlace token parsing and creation.
1889 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1890 This is much the same as DetailsPlaceTest.
1892 I wonder how we could test the other parts of the *Place API.
1894 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1896 DetailsPlace test: Also test getToken() and recreation via getPlace().
1898 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1899 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1900 recreate it, testing the recreated DetailsPlace for the same parameter
1903 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1905 Use the surefire-report plugin.
1907 * pom.xml: This generates a HTML report about the tests in
1908 target/site/surefire-report.html
1909 when you do mvn surefire-report:report. It seems to be popular/normal.
1911 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1913 Added a test for DetailsPlace.
1915 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1916 Test the getPlace() token parsing.
1918 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1920 Added a first unit test.
1922 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1923 * src/test/java/org/glom/web/shared/DataItemTest.java:
1924 This is a silly test but it is just to get things started. Note that
1925 maven/junit finds the test because it looks in src/test by default.
1927 2011-12-22 Ben Konrath <ben@bagu.org>
1929 Change charsetName to "UTF-8" when replacing line breaks.
1931 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1932 that work in Java (such as "UTF8") will not work when compiled to
1935 This fixes a problem with multi-line details view fields that have hard
1936 line breaks. The "License Text" field on this page demonstrates the
1939 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1941 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1943 2011-12-22 Ben Konrath <ben@bagu.org>
1945 Fix another bug with related list navigation.
1947 I've tested all the navigation buttons in all of the related lists
1948 so things should be good now.
1950 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1952 2011-12-22 Ben Konrath <ben@bagu.org>
1954 Fix a crasher when refreshing the list view with the default table.
1956 This crash will also happen when loading the list view with the default
1957 table from a link or bookmark.
1959 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1960 to the main document selection page when the document id hasn't been
1962 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1963 the main document selection page when the document id hasn't been
1965 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1966 values for the details place when the document id hasn't been set.
1967 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1968 values for the list place when the document id hasn't been set.
1970 2011-12-21 Ben Konrath <ben@bagu.org>
1972 Protect against NPE when glom.document.locale is not in config.
1974 This patch protects against an NPE when glom.document.locale is not in
1975 the config file. This NPE will also happen if glom.document.locale is
1978 The patch also updates the error message to display the class name when
1979 the getMessage() returns null. This was happening when the NPE was
1980 thrown and I had "Configuration Error: null". If an NPE is encountered
1981 with this patch, "Configuration Error: NullPointerException " will be
1984 This commit closes this bug:
1986 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1988 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1990 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1992 Rename onlineglom.properties to onlineglom.properties.sample.
1994 * src/main/resources/onlineglom.properties: Rename to:
1995 * src/main/resources/onlineglom.properties.sample:
1996 * src/main/resources/README: And add this file explaining that people
1997 should rename it back when deploying.
1999 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2001 Allow choosing the translation in the .properties file.
2003 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2004 init(): Read a glom.document.locale value from the configuration file
2005 and call Glom's TransatableItem::set_current_locale() method.
2006 * src/main/resources/onlineglom.properties: Add a commented-out
2007 example of this new setting.
2009 It would be better to add &lang=de_DE to the URL, but the current
2010 libglom API does not allow us to do this easily. I am working on that.
2012 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2014 Avoid a crash in parsing of token parameters.
2016 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2017 ava: getTokenParams(): Do not crash if a parameter has a key but no
2018 value, and ignore parameters with neither.
2020 2011-12-17 Murray Cumming <murrayc@murayc.com>
2022 History token building/handling: Improve use of token parameters.
2024 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2025 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2026 and buildParamsToken(HashMap), for use by derived classes.
2027 Make the separator private because it is no longer be needed.
2028 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2029 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2030 instead of manual string concatenation.
2031 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2032 of hardcoded indices and awkward splitting code.
2033 * src/main/java/org/glom/web/client/place/ListPlace.java
2034 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2035 instead of manual string concatenation.
2036 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2037 of hardcoded indices and awkward splitting code.
2038 This should fix bug #666420
2040 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2042 Fix a Navgiation->Navigation typo in the code.
2044 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2045 Rename processNavgiation() to processNavigation().
2047 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2049 Fix a seperator->separator typo in the code.
2051 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2052 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2053 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2056 2011-12-15 Ben Konrath <ben@bagu.org>
2058 Cleanup some comments.
2060 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2062 2011-12-14 Ben Konrath <ben@bagu.org>
2064 Replace \n with <br/> for multiline text in the details view.
2066 Vertical scrollbars are added when needed as well.
2068 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2070 2011-12-14 Ben Konrath <ben@bagu.org>
2072 Specify the font for document selection links.
2074 * src/main/webapp/style.css:
2076 2011-12-14 Ben Konrath <ben@bagu.org>
2078 Fix bouncy CellTable while paging.
2080 This doesn't currently work with related list tables in unselected
2083 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2085 2011-12-14 Ben Konrath <ben@bagu.org>
2087 Revamp the appearance of the document selection page.
2089 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2090 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2091 * src/main/webapp/style.css:
2093 2011-12-13 Ben Konrath <ben@bagu.org>
2095 Set navigation button column to the smallest size possible.
2097 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2099 2011-12-13 Ben Konrath <ben@bagu.org>
2101 Change OpenButton nomenclature to NavigationButton.
2103 Using NavigtionButton makes things more generic. Classes, methods and
2104 variables have been changed.
2106 This is a rename-only refactor.
2108 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2109 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2110 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2111 Renamed from OpenButtonCell.
2112 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2113 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2114 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2116 2011-12-12 Ben Konrath <ben@bagu.org>
2118 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2120 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2121 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2122 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2123 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2125 2011-12-12 Ben Konrath <ben@bagu.org>
2127 Update variable names and comments.
2129 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2130 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2132 2011-12-12 Ben Konrath <ben@bagu.org>
2134 Properly initialize numNonEmptyRows variable to zero.
2136 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2137 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2139 2011-12-05 Ben Konrath <ben@bagu.org>
2141 Add latest mockup with HTML tables.
2143 Features of this mockup:
2145 -> HTML table for flowtable
2146 -> HTML table for flowtable column
2147 -> Example of how related lists would look
2148 -> Not using text entries for data items
2150 The current version of Online Glom doesn't use HTML tables for the
2153 This mockup has been sent to the glom-devel mailing list but it's good
2154 to have it here as well.
2156 * mockups/details-view-html-tables.html:
2158 2011-12-05 Ben Konrath <ben@bagu.org>
2160 Remove unnecessary getPrimaryKeyField() method.
2162 getPrimaryKeyFieldForTable(String) has been renamed to
2163 getPrimaryKeyField(String).
2165 * src/main/java/org/glom/web/server/database/DBAccess.java:
2166 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2167 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2169 2011-12-05 Ben Konrath <ben@bagu.org>
2171 Add string representation of TypedDataItem value to conversion error message.
2173 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2174 message was extracted into its own method to avoid duplication.
2176 2011-12-05 Ben Konrath <ben@bagu.org>
2178 Add type checking to navigation primary key value creation.
2180 Create navigation primary key only if the expected type from the Glom
2181 document matches the type returned by the SQL query.
2183 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2185 2011-12-05 Ben Konrath <ben@bagu.org>
2187 Rename a couple of variables in RelatedListNavigation.
2189 This is a rename-only refactor.
2191 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2193 2011-12-05 Ben Konrath <ben@bagu.org>
2195 Move getListLayoutGroup() into getListViewLayoutGroup().
2197 This removes getListLayoutGroup(). It was only being called by
2198 getListViewLayoutGroup().
2200 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2202 2011-12-05 Ben Konrath <ben@bagu.org>
2204 Remove check for LayoutItem_Portal in list table method.
2206 This check is no longer necessary because the method isn't being used
2207 to create the LayoutItemPortal DTO.
2209 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2211 2011-12-05 Ben Konrath <ben@bagu.org>
2213 Properly support related list navigation.
2215 Navigation from the "Repository Analyzer -> Package Scans ->
2216 Dependencies" related table wasn't working because the primary key for
2217 related tables wasn't being set properly. This commit fixes the
2220 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2221 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2222 doesn't set the primary key properly for related list tables.
2223 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2224 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2225 useful for getting the primary key for list view tables and for related
2227 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2228 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2229 Move code to set the primary key for the table from the abstract
2230 ListDBAccess class to ListViewDBAccess as it's only correct for list
2232 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2233 Properly add primary key to related list tables.
2235 2011-12-02 Ben Konrath <ben@bagu.org>
2237 Properly set the horizontal alignment of fields.
2239 This fix is for both the list tables and the details view.
2241 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2242 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2243 to set the horizontal alignment of fields.
2245 2011-12-02 Ben Konrath <ben@bagu.org>
2247 Display currency codes in the details view.
2249 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2251 2011-12-02 Ben Konrath <ben@bagu.org>
2253 Avoid duplicate JNI call.
2255 JNI is not as efficient as pure Java and this is an easy (and small)
2258 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2259 Use previously retrieved value for whereClauseToTableName instead of
2262 2011-12-02 Ben Konrath <ben@bagu.org>
2264 Rename a couple of variables in RelatedListNavigation.
2266 This is a rename-only refactor.
2268 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2270 2011-12-02 Ben Konrath <ben@bagu.org>
2272 Indicate clearly that a mismatched primary key type is a bug.
2274 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2275 warning to error. Add 'This is a bug.' to message.
2277 2011-12-02 Ben Konrath <ben@bagu.org>
2279 Update / fix some comments.
2281 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2283 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2285 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2286 Fix comments. Add some TODOs.
2288 2011-12-02 Ben Konrath <ben@bagu.org>
2290 Enable navigation to details view with string primary key from related list.
2292 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2293 Create a text primary key value when return type of result is
2294 java.sql.Types.VARCHAR.
2296 2011-12-02 Ben Konrath <ben@bagu.org>
2298 Use checkboxes for booleans in the details view.
2300 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2302 2011-12-01 Ben Konrath <ben@bagu.org>
2304 Improve performance of related list height calculation.
2306 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2307 Put code to calculate the expected height in a static initializer so
2308 that that it's only called once.
2310 2011-12-01 Ben Konrath <ben@bagu.org>
2312 Show related list tables in notebooks (again).
2314 Calculate the height of the related list tables so the Notebook can be
2315 set the correct height. The height of the related list table is also needed by
2316 FlowTable to be able decide how to create the layout.
2318 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2319 and set the Portal height based on the height of the related list
2320 table and the Portal container.
2321 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2322 Add method to calculate the height of the related list tables.
2323 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2324 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2325 calculate the height of the Pager widget.
2327 2011-12-01 Ben Konrath <ben@bagu.org>
2329 Use CellTable API for table property instead of setting style on Element.
2331 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2333 2011-12-01 Ben Konrath <ben@bagu.org>
2335 Make ListViewTable and RelatedListTable a consistent height.
2337 The tables are now a consistent height regardless of the contents of
2338 the table. A hidden button is added to empty rows to ensure that the
2339 height of these rows will match the height of rows with data.
2341 A navigation button column is now added to every table. The width of
2342 the navigation column is set to 0px when a RelatedListTable shouldn't
2343 have navigation buttons. This maintains the a consistent row height in
2344 tables that don't show the navigation buttons.
2346 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2347 navigation column when not needed.
2348 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2349 arguments for navigation button to constructor of ListViewTable.
2350 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2351 hidden button for empty data rows.
2352 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2353 arguments for navigation button to constructor.
2354 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2355 create navigation buttons. Add hideNavigationButtons() method.
2356 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2357 arguments for navigation button to constructor.
2359 2011-12-01 Ben Konrath <ben@bagu.org>
2361 Use 'visibility: hidden' in Utils.getWidgetHeight().
2363 This is better choice because hidden elements are invisible, don't
2364 respond to events and are not part of the tab order. They will,
2365 however, take up space which is required to be able to calculate the
2366 height of the widget.
2368 * src/main/java/org/glom/web/client/Utils.java:
2370 2011-12-01 Ben Konrath <ben@bagu.org>
2372 Use Utils.getWidgetHeight() in FlowTable.
2374 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2376 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2378 2011-12-01 Ben Konrath <ben@bagu.org>
2380 Put the details css class name on the correct table column.
2382 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2384 2011-11-30 Ben Konrath <ben@bagu.org>
2386 Update for java-libglom API change.
2388 The getters and setters on FieldFormatting and NumericFormat were
2389 changed to remove the 'M'.
2391 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2393 2011-11-29 Ben Konrath <ben@bagu.org>
2395 Only allow RelatedListTables in Portals.
2397 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2399 2011-11-29 Ben Konrath <ben@bagu.org>
2401 Only create a contents panel for Portals when title is being set.
2403 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2405 2011-11-29 Ben Konrath <ben@bagu.org>
2407 Set TabLayoutPanel height based on calculated height its widgets.
2409 This is a potential fix for this bug:
2411 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2413 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2415 2011-11-29 Ben Konrath <ben@bagu.org>
2417 Align details field labels and data with the Open buttons.
2419 * src/main/webapp/style.css:
2421 2011-11-29 Ben Konrath <ben@bagu.org>
2423 Remove unnecessary <div> in the Notebook widget.
2425 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2426 method to get container FlowPanel (<div>).
2427 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2428 initWidget() method directly on the TabLayoutPanel widget instead of
2429 Group's container widget.
2431 2011-11-29 Ben Konrath <ben@bagu.org>
2433 Don't add group titles for Portals in Notebooks.
2435 This reverts the previous patch and fixes a bug I introduced with
2436 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2438 * src/main/java/org/glom/web/client/ui/details/Group.java:
2439 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2441 2011-11-28 Ben Konrath <ben@bagu.org>
2443 Remove unused boolean argument in Portal constructor.
2445 Just a code cleanup.
2447 * src/main/java/org/glom/web/client/ui/details/Group.java:
2448 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2450 2011-11-28 Ben Konrath <ben@bagu.org>
2452 Remove hack for glom 1.18 style glom files.
2454 * src/main/java/org/glom/web/client/ui/details/Group.java:
2455 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2456 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2458 2011-11-28 Ben Konrath <ben@bagu.org>
2460 Use Gda Value version of primary key to log result too large error.
2462 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2464 2011-11-28 Ben Konrath <ben@bagu.org>
2466 Don't use TypedDataItem.getText() for Unknown types from the URL.
2468 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2469 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2470 instead of getText().
2471 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2472 String field and getUnknown() method.
2474 2011-11-28 Ben Konrath <ben@bagu.org>
2476 Log an error message when the java-libglom .so is not present.
2478 The error message was being set in the exception but not logged.
2480 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2482 2011-11-28 Ben Konrath <ben@bagu.org>
2484 Ignore LayoutItem_CalendarPortals.
2486 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2487 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2489 2011-11-28 Ben Konrath <ben@bagu.org>
2491 Extract method for creating the LayoutItemPortal DTO.
2493 Just breaking the code up into smaller chunks.
2495 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2497 2011-11-28 Ben Konrath <ben@bagu.org>
2501 This should have been added with the refactor. Oops!
2503 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2505 2011-11-28 Ben Konrath <ben@bagu.org>
2507 Create primary key value from URL string using type from Glom document.
2509 See this bug, comments 19 - 25:
2511 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2513 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2514 create a TypeDataItem for the primary key here when loading from a
2515 URL. Show the same string for the primary key value as was received
2516 from the URL string (when loading from a URL).
2517 * src/main/java/org/glom/web/server/Utils.java: Update method for
2518 creating the Gda Value from the TypeDataItem to properly deal with
2519 creating a Gda Value based on the Glom document type for the primary
2520 key value string when loading from a URL.
2521 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2522 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2523 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2524 Update for changed method name.
2526 2011-11-27 Ben Konrath <ben@bagu.org>
2528 Rename PrimaryKeyItem to TypedDataItem.
2530 The name PrimaryKeyItem suggests what the class should be used for.
2531 TypedDataItem is a neutral name that describes the class better.
2533 This is a rename-only refactor.
2535 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2536 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2537 * src/main/java/org/glom/web/client/Utils.java:
2538 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2539 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2540 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2541 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2542 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2543 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2545 * src/main/java/org/glom/web/server/Utils.java:
2546 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2547 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2548 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2549 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2551 2011-11-25 Ben Konrath <ben@bagu.org>
2553 Improve Gda Value conversion from PrimaryKeyItem.
2555 The value from the PrimaryKeyItem is only used if its type match the
2556 type from the glom document.
2558 * src/main/java/org/glom/web/server/Utils.java:
2560 2011-11-25 Ben Konrath <ben@bagu.org>
2562 Manually check if the java-liblgom .so is visible to the JVM.
2564 It seems that Tomcat has problems when a static initializer throws an
2565 exception. This check is done before the first method call into
2566 java-libglom so that execution doesn't continue if the .so is not
2569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2571 2011-11-25 Ben Konrath <ben@bagu.org>
2573 Improve browser configuration error messages.
2577 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2579 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2580 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2581 getConfigurationErrorMessage() method.
2582 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2583 Get and display a specific configuration error message when no Glom
2584 documents are found.
2585 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2586 Implement getConfigurationErrorMessage() method. Surround configuration
2587 code in the init() method with a try/catch block. This allows the
2588 errors to be caught while keeping the servlet available to retrieve the
2589 configuration error message.
2591 2011-11-25 Ben Konrath <ben@bagu.org>
2593 Don't use Strings to hold primary key values.
2595 The primary key values are now held in a new data object
2596 (PrimaryKeyItem) that holds type information and the primary key value
2597 using the correct type.
2599 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2600 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2602 PrimaryKeyItem instead of String to hold the primary key value.
2603 * src/main/java/org/glom/web/client/Utils.java: Remove
2604 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2605 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2606 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2607 PrimaryKeyItem instead of String to hold the primary key value. Load
2608 document selection page when the documentID has not been set correctly.
2609 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2610 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2612 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2613 Return empty string for URL instead of "null".
2614 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2615 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2616 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2617 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2618 PrimaryKeyItem instead of String to hold primary key values.
2619 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2620 PrimaryKeyValue to a Gda Value.
2621 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2622 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2623 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2624 Replace temporary database access code that uses the PrimaryKeyValue to
2625 Gda Value conversion.
2626 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2627 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2628 PrimaryKeyItem instead of String.
2629 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2630 hold primary key values.
2632 2011-11-24 Ben Konrath <ben@bagu.org>
2634 Use newly added java-libglom API to create queries.
2636 This isn't finished. I still need to stop using Strings for primary key
2637 values in the client code.
2639 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2640 libglom to use fake connections so that retrieving the query string will
2642 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2643 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2644 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2645 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2646 Use the newly added libglom sql methods and classes to create the
2647 query. Add temporary hack to convert primary value strings to Gda
2650 2011-11-23 Ben Konrath <ben@bagu.org>
2652 Don't explicitly set the height of Portals.
2654 See comments 6 - 10 of this bug for details:
2656 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2658 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2660 2011-11-23 Ben Konrath <ben@bagu.org>
2662 Use an HTML table instead of CSS for the FlowTable layout.
2664 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2665 GWT's FlexTable to implement the FlowTable.
2666 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2668 2011-11-18 Ben Konrath <ben@bagu.org>
2670 Add boolean example to HTML table mockup.
2672 * mockups/details-view-html-tables-text-entries.html:
2674 2011-11-17 Ben Konrath <ben@bagu.org>
2676 Ensure the pager buttons are always visible for related lists.
2678 To accomplish this, I've turned off text wrapping in the list view and
2679 related list tables for both the header and data text. The related list
2680 table now has a fixed layout so the it doesn't overflow its container.
2681 This is required to ensure that the cell text is clipped when it
2682 overflows the cell and an ellipsis is added to the right side of the
2683 cell when text is clipped.
2685 A fixed table layout for the related list table in the details view
2686 seems what we want for the details view anyway, so the side-effect is
2689 The ellipsis will only be displayed in Firefox >= 7.
2693 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2695 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2696 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2697 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2699 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2700 Set the 'table-layout: fixed' CSS property to the related list table.
2701 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2702 'white-space: nowrap;' CSS property on both the list view and the
2703 related list tables.
2705 2011-11-16 Ben Konrath <ben@bagu.org>
2707 Rework the fix for empty notebook tab labels.
2709 Setting the empty group titles with its name caused problems for the
2710 details layout. Instead of using libglom's
2711 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2712 to the client when the title is empty. This allows the Notebook to use
2713 the name when the title is empty without affecting anything else.
2715 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2716 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2718 2011-11-16 Ben Konrath <ben@bagu.org>
2720 Set group titles with name when title is empty.
2722 This fixes a problem with an empty notebook tab label in the Lesson
2723 Planner document. The forth tab in the notebook should be "Internet":
2725 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2727 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2728 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2731 2011-11-16 Ben Konrath <ben@bagu.org>
2733 Remove whitespace from the configured username properties.
2735 This assumes that usernames won't have whitespace at the beginning
2736 or end. But I think this is a reasonable assumption.
2738 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2739 String.trim() to remove the whitespace from the username properties.
2741 2011-11-15 Ben Konrath <ben@bagu.org>
2743 Add details view mockup with HTML tables and text entries.
2745 This is from the attachment on this bug:
2747 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2749 * mockups/details-view-html-tables-text-entries.html:
2751 2011-11-15 Ben Konrath <ben@bagu.org>
2753 Add space between the columns of the flow table.
2757 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2759 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2760 space between columns in the flow table.
2762 2011-11-15 Ben Konrath <ben@bagu.org>
2764 Add backup files to the .gitignore.
2766 * .gitignore: Ignore files that end with ~.
2768 2011-11-09 Ben Konrath <ben@bagu.org>
2770 Use latest release of gwt-log.
2772 Gwt-log releases are now being submitted to the maven central
2773 repository so manual installation of the jar is no longer required.
2775 * pom.xml: Update version and groupId of gwt-log dependency.
2777 2011-10-31 Ben Konrath <ben@bagu.org>
2779 Don't use GWT numeric formatting to override the glom currency formatting.
2781 Currencies are now displayed like they are in Glom. See this bug:
2783 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2785 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2787 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2788 currency code to constructor and set it when the cell is rendered.
2789 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2790 currency code to the constructor of the NumericCell.
2792 2011-10-27 Ben Konrath <ben@bagu.org>
2794 Require the latest release of java-libglom (1.17.4).
2798 2011-10-26 Ben Konrath <ben@bagu.org>
2800 Add style to Notebook that matches current theme.
2802 It's not the best style in the world but it's better than the default.
2804 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2805 padding at the bottom of the child widgets.
2806 * src/main/webapp/style.css: Add style for the Notebook.
2808 2011-10-26 Ben Konrath <ben@bagu.org>
2810 Move servlet initialization code to overridden init method.
2812 This is half of the solution to getting proper error messages
2813 displayed when configuration errors occur. Here's the relevant bug:
2815 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2817 The rest of the solution involves surrounding the init method with a
2818 try/catch block and setting a global variable with the error /
2819 exception. A new async method should be created to retrieve and display
2820 the error message / exception.
2822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2823 code from constructor to init method adding exceptions as needed.
2825 2011-10-26 Ben Konrath <ben@bagu.org>
2827 Add script to monitor and restart tomcat if required.
2829 * utils/check-and-recover-tomcat.py: New file.
2831 2011-10-26 Ben Konrath <ben@bagu.org>
2833 Display the correct number of data items in the pager.
2837 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2839 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2840 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2841 The implementation is the same for both tables: Keep track of the
2842 number of non-empty rows and fire and RowCountChangeEvent after the data has
2844 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2845 custom Pager class that subclasses SimplePager to handle displaying
2846 the correct number when empty rows have been added.
2848 2011-10-26 Ben Konrath <ben@bagu.org>
2850 Correct error in previous commit.
2852 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2853 eventBus parameter from listView.setCellTable().
2855 2011-10-26 Ben Konrath <ben@bagu.org>
2857 Fix error in TODO comment.
2859 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2861 2011-10-24 Ben Konrath <ben@bagu.org>
2863 Create Notebook widgets to the details view.
2865 This isn't finished just yet - I still need to create a reasonable
2866 style to match the current theme.
2868 * src/main/java/org/glom/web/client/Utils.java: Add method for
2869 calculating the height of a widget. This is used in the Notebook class.
2870 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2871 new constructor method in Group.
2872 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2873 method for creating child widget that can be used by subclasses
2874 like Notebook. New constructor that allows disabling the group
2875 titles - Notebooks don't set a group title for their child groups.
2876 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2877 to make Notebooks using GWT's TabLayoutPanel.
2878 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2879 constructor that allows disabling the group titles.
2880 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2881 LayoutItemNotebook DTO.
2882 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2883 DTO for Notebooks. It's just an empty class for now but we might need
2884 it to transfer some specific information in the future.
2886 2011-10-21 Ben Konrath <ben@bagu.org>
2888 Add navigation buttons to related list tables.
2890 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2891 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2892 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2893 method getSuitableRecordToViewDetails() for getting the table name
2894 and primary key value for related list navigation buttons.
2895 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2896 private cell renderer class to get the navigation information for
2897 related list tables from the server. Extract the navigation
2898 processing code from the details cell navigation and use it for the
2899 related list navigation as well.
2900 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2901 cell renderer class for the details open buttons. This was needed
2902 because the related list navigation buttons and the list view
2903 navigation buttons need to react differently when clicked.
2904 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2905 the onEnterKeyDown() method because it's now overriden in the
2906 subclasses that are specific to the related list tables and the list
2908 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2909 the vertical size a little because the buttons add a bit of vertical
2910 space to table. This is not a perfect solution because the vertical
2911 size of with table fewer than 5 rows will be a little smaller.
2912 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2913 changes in how navigation buttons are handled.
2914 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2915 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2916 database access object.
2917 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2918 to find the portal for a given relationship name from
2919 RelatedListDBAccess. Add method to find a primary key field for a
2921 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2922 Move code to find the portal for a given relationship name to
2924 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2925 New file: database access object for getting the related list
2926 navigation information (the table name and the primary key value).
2927 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2928 DTO for transferring a table name to navigate to and a primary key
2930 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2931 boolean and getter/setter to specifies if the related list should add
2934 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2936 Use the master branch of java-libglom
2938 * pom.xml: Depend on java-libglom 1.19 instead.
2940 This is the master branch. See also the libglom-1-18 branch.
2942 2011-10-11 Ben Konrath <ben@bagu.org>
2944 Enable the open navigation button when the data has been set.
2946 This avoids having active buttons that don't do anything when the data
2949 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2951 2011-10-11 Ben Konrath <ben@bagu.org>
2953 Use IsWidget interface for FlowTableItem.
2955 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2956 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2958 2011-10-11 Ben Konrath <ben@bagu.org>
2960 Remove GWT styling from open button in details view.
2962 There are still some issues with how the details cell is arranged but
2963 this should be made to match Glom 1.20. I'm going to leave fixing this
2964 until I have Glom 1.20 up and running.
2966 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2967 style name on open button.
2968 * src/main/webapp/style.css: Move and edit details-navigation class.
2969 Re-arrange some classes to make them appear in the same order as the
2972 2011-10-07 Ben Konrath <ben@bagu.org>
2974 Update to GWT 2.4.0.
2976 * .gitignore: Ignore new cache directory.
2977 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2978 * pom.xml: Change GWT and maven plugin to 2.4.0.
2979 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2981 * src/main/java/org/glom/web/client/ClientFactory.java:
2982 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2983 * src/main/java/org/glom/web/client/OnlineGlom.java:
2984 Update source for API changes.
2985 * utils/build-onlineglom-war.sh: Remove cache directory before the
2988 2011-10-07 Ben Konrath <ben@bagu.org>
2990 Add navigation buttons in the details view.
2992 This isn't finished but I thought I'd commit what I have as it's a
2993 pretty good start. I still need to:
2995 1. Change the style so that it fits better into the current theme
2996 2. Adjust the details cell to expand as much as possible.
2998 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2999 click handlers to navigation buttons in the DetailsCells. Create a
3000 refreshData() method to get just the data from the server without the
3002 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3003 Update the tableSelector and browser title when the table name
3004 changes without using the tableSelector.
3005 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3006 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3007 getDetailsCells() to getCells(). Update variable names.
3008 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3009 method to set click handler on navigation button. Rename a few
3010 variables. Add navigation buttons where needed.
3011 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3012 variables and methods.
3013 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3014 navigation boolean and navigation table as required in the
3015 LayoutItemField DTO.
3016 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3017 variables for navigation along with getter/setter methods.
3019 2011-10-07 Ben Konrath <ben@bagu.org>
3021 Rename Field to DetailsCell.
3023 This is a refactor-only commit. No functionality has been added or
3026 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3027 Update variable and method names.
3028 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3029 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3030 variable and method names.
3031 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3033 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3034 variable and method names.
3036 2011-10-07 Ben Konrath <ben@bagu.org>
3038 Create separate methods for layout and data the details view.
3040 This is a refactor-only commit. No functionality has been added or
3043 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3044 private methods: setData(), createLayout().
3046 2011-10-07 Ben Konrath <ben@bagu.org>
3048 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3050 This is part of a change to get navigation buttons in the details view
3051 but it should have been done this way from the start.
3053 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3054 for method name change in TableSelectionView.
3055 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3056 Create TableChangeEvent and set the browser title using the
3057 TableSelectionView API.
3058 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3059 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3060 Change getSelectedTable() to getSelectedTableName(). Add
3061 getSelectedTableTitle().
3063 2011-10-07 Ben Konrath <ben@bagu.org>
3065 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3067 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3069 2011-10-07 Ben Konrath <ben@bagu.org>
3071 Update TableChangeEvent to use newTableName naming convention.
3073 This makes the class more consistent with GWT naming conventions.
3075 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3076 Update for method name change in TableChangeEvent.
3077 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3078 for method name change in TableChangeEvent.
3079 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3080 newTableName variable and getter method. Make toDebugString()
3083 2011-09-30 Ben Konrath <ben@bagu.org>
3085 Disable the pager in the list tables when the data row count is less than the minimum.
3087 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3088 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3090 2011-09-30 Ben Konrath <ben@bagu.org>
3092 Add empty rows to the end of related list and list view tables.
3094 I also extracted the cell rendering classes from the ListTable because
3095 the code was becoming a little crazy with all the anonymous inner
3096 classes. My plan is to use these cell rendering classes in the details
3097 view as well so this refactor will be needed for that change.
3099 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3100 set the row count in related list tables if the data has more rows
3101 than the minimum number of rows visible.
3102 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3103 row count in list view tables if the data has more rows than the
3104 minimum number of rows visible.
3105 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3106 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3108 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3109 for rendering TYPE_NUMERIC cells. The code was extracted from the
3111 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3112 class for rendering cells with buttons in list views. The code was
3113 extracted from the ListTable class.
3114 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3115 for rendering TYPE_TEXT cells. The code was extracted from the
3117 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3118 Add empty rows to the end of the data if required. Implement
3119 ListTable.getMinNumVisibleRows().
3120 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3121 cell renderer code to public classes. Return null in
3122 Column.getValue() for empty rows. Add new abstract method:
3123 getMinNumVisibleRows(). Move code to set the row count of the list view
3124 table to ListViewImpl.
3125 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3126 empty rows to the end of the data if required. Implement
3127 ListTable.getMinNumVisibleRows().
3130 2011-09-27 Ben Konrath <ben@bagu.org>
3132 Use GWT.log for client-side debugging statements.
3134 These are optimized out when deployed so I should have used this method
3135 in the first place. These statements will eventually be replaced with some sort
3136 of notification in the browser.
3138 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3139 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3140 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3141 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3142 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3144 2011-09-27 Ben Konrath <ben@bagu.org>
3146 Put tableselector on the right, back to list link on right.
3148 The idea is that the table selector is acting like a label for the
3149 currently displayed table so it should be placed below the document title. This
3150 puts the table title in a similar position to where it is in Glom.
3152 * mockups/details-contacts.html:
3153 * mockups/details-projects.html:
3154 * mockups/listview-contacts.html:
3155 * mockups/listview-projects.html:
3156 * mockups/style.css:
3157 Update mockups to match how the interfaces currently look.
3158 * src/main/webapp/style.css: Swap positions of backlink with the table
3159 selector. Add some space on the left side of the table selector to
3160 line things up with the document title.
3162 2011-09-27 Ben Konrath <ben@bagu.org>
3164 Add field colouring to details view.
3166 This change re-works how field colouring works. The colour formatting
3167 information is now set to the client with the layout information instead of
3168 with the data. This eliminates the need to send the same colour strings for
3169 data in list view column when colour information is set.
3171 In order to set an alternate colour for negative numeric values, the
3172 number is now sent to client and formatted with the GWT NumberFormat class.
3174 This change also fixes:
3176 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3178 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3179 internationalization framework which is needed for client side numeric
3181 * src/main/java/org/glom/web/client/Utils.java: New file for some
3182 client static utility methods.
3183 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3184 the DataItem object to the Field class. Use a utility method to
3185 create the foreignKeyValue string.
3186 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3187 alignment and text colours in the constructor. Add setData(DataItem)
3188 method. Remove setText(String) method.
3189 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3190 colour information to GlomTextCell. Create and use GlomNumberCell for
3191 rendering numbers. Use utility method to get the string for the
3192 primary key of the key provider. Re-work how the horizontal alignment
3194 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3195 formatting to layout information. Methods for converting the libglom
3196 formatting information were moved from DBAccess.
3197 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3198 numeric formatting (it's now done on the client side). Don't set text
3199 colours in DataItem. Move libglom formatting conversion methods to
3201 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3202 getters/setters for text colour information.
3203 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3204 for transferring the libglom NumericFormat information to the client.
3205 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3206 and getters/setters for: GlomNumericFormat, background colour and
3207 foreground colour strings.
3209 2011-09-26 Ben Konrath <ben@bagu.org>
3211 Simplify code that iterates through the LayoutGroup.
3213 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3215 2011-09-26 Ben Konrath <ben@bagu.org>
3217 Accept Eclipse formatting for OnlineGlomServiceAsync.
3219 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3221 2011-09-26 Ben Konrath <ben@bagu.org>
3223 Don't use the ListDBAccess classes to get the primary key layout information.
3225 This was causing a bug where the wrong index for the hidden primary key
3226 was being sent to the client.
3228 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3229 primary key while creating the LayoutGroup DTO. Create a
3230 LayoutItemField DTO for hidden primary keys. Don't use the
3231 RelatedListDBAccess because it was only used for getting the primary
3233 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3234 access modifier from public to protected for getPrimaryKeyField() and
3235 getPrimaryKeyLayoutItemField().
3236 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3237 abstract method getExpectedResultSize() because RelatedListDBAccess
3238 doesn't have enough info to implement it.
3239 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3240 Remove @Override for getExpectedResultSize().
3241 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3242 Remove method getExpectedResultSize().
3244 2011-09-23 Ben Konrath <ben@bagu.org>
3246 Log which layout (list or details) the ignored item is from.
3248 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3250 2011-09-23 Ben Konrath <ben@bagu.org>
3252 Remove annotations that turn off code formatting in DataItem.
3254 * src/main/java/org/glom/web/shared/DataItem.java:
3256 2011-09-23 Ben Konrath <ben@bagu.org>
3258 Rename GlomField to DataItem and update associated methods.
3260 This is a rename-only refactor. No functionality has been added or
3263 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3264 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: