1 2012-04-21 Murray Cumming <murrayc@murrayc.com>
3 Update the project URL.
5 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
7 2012-04-21 Murray Cumming <murrayc@murrayc.com>
9 Main layout: Use a FlowTable instead of absolute positioning.
11 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
12 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
13 child panels/widgets must have an absolute position. But that is annoying, so
14 this adds a FlowTable and puts the child panels in there.
16 2012-04-21 Murray Cumming <murrayc@murrayc.com>
18 GwtTestOnlineGlom: Comment out unused code.
20 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
21 Eclipse has started to say that some code is unused.
23 2012-04-21 Murray Cumming <murrayc@murrayc.com>
25 Update to the latest versions of dependencies.
27 * pom.xml: Update version numbers of dependencies to the latest
29 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
30 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
31 * src/main/java/org/glom/web/server/ReportGenerator.java:
32 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
33 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
34 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
36 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
37 Modify the imports where necessary.
39 2012-04-17 Murray Cumming <murrayc@murrayc.com>
41 Style: Remove overflow:hidden from searchbox
43 * src/main/webapp/style.css: Because this pushes the Back To Link
44 label/link on to the next row, which is then hidden due to the
45 hard-coded (in ems) height.
47 2012-04-20 Murray Cumming <murrayc@murrayc.com>
49 Remove some duplicate code.
51 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
52 getDocumentInfo(): This must have been duplicated during the merge from the
57 2012-04-19 Murray Cumming <murrayc@murrayc.com>
59 Reports: Localize the waiting for report message.
61 * src/main/java/org/glom/web/client/activity/ReportActivity.java
62 start(): Get the message from the contants.
63 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
65 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
66 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
67 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
68 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
69 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
70 Update these files with the English text for newer strings for now.
72 2012-04-19 Murray Cumming <murrayc@murrayc.com>
74 Reports: Show a message while waiting for the report.
76 * src/main/java/org/glom/web/client/ui/ReportView.java
77 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
78 Add setWaitingText(), to show a message saying that we are
79 waiting for the report to be ready.
80 * src/main/java/org/glom/web/client/activity/ReportActivity.java
81 start(): Call setWaitingText() before calling the async
84 2012-04-19 Murray Cumming <murrayc@murrayc.com>
86 ReportGenerator: Specify date and time formats.
88 * src/main/java/org/glom/web/server/ReportGenerator.java:
89 createFieldValueElement(): Use the default (and localized)
90 short formats, though we still need a way to show 4-digit
91 years without providing the format for every locale.
92 * src/main/java/org/glom/web/server/database/DBAccess.java:
93 convertResultSetToDTO(): Use the short formats here too.
95 2012-04-18 Murray Cumming <murrayc@murrayc.com>
97 ReportGenerator: Use the correct numeric formatting.
99 * src/main/java/org/glom/web/server/ReportGenerator.java
100 createFieldExpression(), createFieldValueElement(): Take the
101 whole LayoutItem_Field instead of just the field name, so
102 we have access to the formatting.
103 createFieldValueElement(): Use JRTextField.setPattern() to
104 specify the numeric formatting, with the help of a
105 regular DecimalFormat.
107 2012-04-18 Murray Cumming <murrayc@murrayc.com>
109 ReportGenerator: Avoid showing null for group by titles.
111 * src/main/java/org/glom/web/server/ReportGenerator.java
112 generateReport(): Use setBlankWhenNull() on the field title
113 style too, because this is used for values in group by
116 2012-04-18 Murray Cumming <murrayc@murrayc.com>
118 ReportGenerator: Add a colon to titles in vertical groups.
120 * src/main/java/org/glom/web/server/ReportGenerator.java
121 addFieldToDetailBandVertical(): Pass true for the withColon
124 2012-04-18 Murray Cumming <murrayc@murrayc.com>
126 ReportGenerator: Simplify the code by using Position more.
128 2012-04-18 Murray Cumming <murrayc@murrayc.com>
130 Reports: Support vertical groups, roughly.
132 * src/main/java/org/glom/web/server/ReportGenerator.java:
133 addToReport(): Rename to addGroupToReport() and, if necessary,
134 call the new addVerticalGroupToReport() method.
135 createFieldValueElement(): Let the caller specify the Y position
138 2012-04-17 Murray Cumming <murrayc@murrayc.com>
140 Reports: Allow a second report to be shown.
142 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
143 clear(): Do not remove the HTML widget, which broke the whole layout.
145 2012-04-17 Murray Cumming <murrayc@murrayc.com>
147 Locales drop-down: Show that we use English by default.
149 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
150 fillView(): When we use English, just because that is the default, when
151 no locale is specified, show that in the Locales drop-down instead of
152 just showing the first item.
154 2012-04-17 Murray Cumming <murrayc@murrayc.com>
156 Unselect the Report/Locale/Table combo item when appropriate.
158 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
159 setPlace(): clear reportName if this is not a ReportPlace.
160 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
161 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
162 When the provided name is empty, unselect all items, so that none are
163 indicated. This uses a for loop because I cannot find a single method
166 2012-04-17 Murray Cumming <murrayc@murrayc.com>
168 Report: Give the user a way to get back to the list.
170 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
171 start(), setPlace(): Show the Back To List link on reports, and also
172 interpret selecting the empty report item as back to list.
174 2012-04-13 Murray Cumming <murrayc@murrayc.com>
176 Really show the selected Report name.
178 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
179 setPlace(): Store the reportName here, if it is that kind of Place.
180 fillView(): Set the selected Report after filling the list of reports.
181 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
182 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
183 null Strings, though we need some way to unselect all ListBox items
186 2012-04-13 Murray Cumming <murrayc@murrayc.com>
188 ReportGenerator: Try to avoid some problems.
190 * src/main/java/org/glom/web/server/ReportGenerator.java
191 addField(): Try to avoid duplicates, and avoid using a null
194 2012-04-13 Murray Cumming <murrayc@murrayc.com>
196 Reports: Use quickFind.
198 * src/main/java/org/glom/web/client/OnlineGlomService.java;
199 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
201 getReportHTML(): Add a quickFind parameter.
202 * src/main/java/org/glom/web/client/activity/ReportActivity.java
203 start(): Pass the quickFind parameter.
204 * src/main/java/org/glom/web/server/ReportGenerator.java
205 generateReport(): Take a quickFind parameter.
207 2012-04-13 Murray Cumming <murrayc@murrayc.com>
209 ReportPlace: Actually use the report name.
211 * src/main/java/org/glom/web/client/place/ReportPlace.java
212 getPlace(): Do not assign the report name to the quickfind.
214 2012-04-13 Murray Cumming <murrayc@murrayc.com>
216 Show java.library.path when complaining.
218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
219 init(): When telling us to check java.library.path, show the
222 2012-03-06 Murray Cumming <murrayc@murrayc.com>
224 ReportGenerator: Do not show nulls.
226 2012-03-06 Murray Cumming <murrayc@murrayc.com>
228 ReportGenerator: Make the title font larger.
230 2012-03-06 Murray Cumming <murrayc@murrayc.com>
232 ReportGenerator: Put field titles inside groups, if there are groups.
234 2012-03-06 Murray Cumming <murrayc@murrayc.com>
236 ReportGenerator: Take the Report itself instead of the name and group.
238 * src/main/java/org/glom/web/server/ConfiguredDocument.java
239 Remove getReportLayoutGroup().
240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
241 getReportHTML(): Pass the report instead
242 of its name and layout group.
243 * src/main/java/org/glom/web/server/ReportGenerator.java
244 generateReport(): Use the report object to use the title
247 2012-03-06 Murray Cumming <murrayc@murrayc.com>
249 ReportGenerator: Remove designBand parameters.
251 * src/main/java/org/glom/web/server/ReportGenerator.java:
252 Make designBand a class member instead of passing it to all
255 2012-03-06 Murray Cumming <murrayc@murrayc.com>
257 ReportGenerator: Add lines, a bit like in the desktop version.
259 * src/main/java/org/glom/web/server/ReportGenerator.java
260 addToReport(): Use JRDesignLine.
262 2012-03-06 Murray Cumming <murrayc@murrayc.com>
264 ReportGenerator: Correct the title positions and use some bold style.
266 * src/main/java/org/glom/web/server/ReportGenerator.java:
267 Break the code up into reusable functions, correct the placement of
268 titles, and use normal/bold styles as in the reports in the desktop
271 2012-03-06 Murray Cumming <murrayc@murrayc.com>
273 ReportGenerator: Add a header band to show the field titles.
275 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
276 getReportHTML(): Pass the localeId to the ReportGenerator
278 * src/main/java/org/glom/web/server/ReportGenerator.java
279 constructor: Take the localeID so we can get translated field
281 generateReport(), addToReport(), addFieldToBand(): Add field
282 titles in a column header band.
284 2012-03-05 Murray Cumming <murrayc@murrayc.com>
286 Reports drop-down list: Some improvement.
288 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
289 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
290 Adedd setSelectedReport(),
291 setReportList(): Add a blank line so that the user can select the
293 * src/main/java/org/glom/web/client/activity/ReportActivity.java
294 start(): Show the current report by calling setSelectedReport().
295 This does not seem to work yet.
297 2012-03-05 Murray Cumming <murrayc@murrayc.com>
299 DetailsActivity, ListActivity: Move some variables into a base class.
301 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
302 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
303 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
304 the clientFactory, documentID, tableName and authenticationPopup into
305 a base class, to avoid duplication.
307 2012-03-05 Murray Cumming <murrayc@murrayc.com>
309 Translate the Reports label.
311 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
312 Get the "Reports" label string from the constants.
313 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
314 perties: Add Reports to the constants.
316 2012-03-05 Murray Cumming <murrayc@murrayc.com>
318 Reports: Implement grouping.
320 * src/main/java/org/glom/web/server/ReportGenerator.java:
321 Handle LayoutItem_GroupBy items and try to do the right thing
322 with JRDesignGroup. It seems to work.
324 2012-03-04 Murray Cumming <murrayc@murrayc.com>
326 Actually show some data with JasperReports.
328 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
329 getReportHTML(): Move most code into a ReportGenerator class.
330 * src/main/java/org/glom/web/server/ReportGenerator.java:
331 Recurse into sub-groups, adding fields to the JasperDesign's details
332 band. Note that we must set an arbitrary width and height, or it just
333 will not show any data.
335 2012-03-04 Murray Cumming <murrayc@murrayc.com>
337 Reports Chooser: Show the titles, not the names.
339 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
340 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
341 and the names as the values.
342 * src/main/java/org/glom/web/server/ConfiguredDocument.java
343 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
344 group now that we provide the report name, so it should always
347 2012-02-15 Murray Cumming <murrayc@murrayc.com>
349 Depend on jasperreports.
351 * pom.xml: Add the dependency. My plan is to use this on the
354 2012-01-31 Murray Cumming <murrayc@murrayc.com>
356 Implement navigation to report places.
358 * src/main/java/org/glom/web/client/activity/ReportActivity.java
359 start(): Do not bother to handle all events here.
360 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
361 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
362 Added getSelectedReport().
363 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
364 .java: start(): When handling a change to the reports chooser,
365 call getSelectedReport() and goTo() its ReportPlace.
366 * src/main/java/org/glom/web/client/ui/ReportView.java
367 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
368 Added setReportHTML() which puts the html in a gwt HTML widget.
369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
370 getReportHTML(): Return "TODO" just to show that this works.
372 2012-01-31 Murray Cumming <murrayc@murrayc.com>
374 Make ReportPlace usable.
376 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
378 * src/main/java/org/glom/web/client/place/ReportPlace.java:
379 Correct the @prefix annotation.
381 2012-01-31 Murray Cumming <murrayc@murrayc.com>
383 OnlineGlomService: Return report HTML rather than the LayoutGroup.
385 * src/main/java/org/glom/web/client/OnlineGlomService.java:
386 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
387 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
388 Change getReportLayout() to getReportHMTL() because we will not need to
389 parse or render the report layout on the client side.
390 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
391 getReportLayout(): Return the libglom LayoutGroup type because we will
392 not need to convert to a shared type, because this will not be used on
394 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
397 Note that there is still no implementation for this.
400 2012-01-27 Murray Cumming <murrayc@murrayc.com>
402 Add a (empty) Report Place, View, and Activity.
404 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
406 * src/main/java/org/glom/web/client/place/HasTablePlace.java
407 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
408 this into a superclass:
409 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
410 and also use it as the base of this new ReportPlace:
411 * src/main/java/org/glom/web/client/place/ReportPlace.java
413 * src/main/java/org/glom/web/client/ui/ReportView.java
414 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
415 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
416 Add these, containing mostly boiler-plate for now.
418 * src/main/java/org/glom/web/client/OnlineGlomService.java
419 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
420 * src/main/java/org/glom/web/server/ConfiguredDocument.java
421 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
422 Add API to get the LayoutGroup for the report.
424 2012-01-23 Murray Cumming <murrayc@murrayc.com>
426 Add and fill a Reports drop-down list box.
428 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
430 * src/main/java/org/glom/web/client/OnlineGlomService.java:
431 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
432 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
433 Added getReports(document, table, localeID), calling
434 ConfiguredDocument.getReports().
435 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
436 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
437 Added setReportsList() and a list widget.
438 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
439 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
444 2012-04-12 Murray Cumming <murrayc@murrayc.com>
446 Translations: Add Esperanto.
448 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
449 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
450 properties: Add this translation because someone took the time to make it.
452 2012-03-15 Murray Cumming <murrayc@murrayc.com>
454 Adapt to the java-libglom 1.21.7 API.
456 * src/main/java/org/glom/web/server/ReportGenerator.java:
457 addToReport(): get_group_secondary_fields() is now
458 get_secondary_fields().
461 2012-03-15 Murray Cumming <murrayc@murrayc.com>
463 Use the latest java-libglom version.
465 * pom.xml: Use java-libglom 1.21.7.
467 2012-03-03 Ben Konrath <ben@bagu.org>
469 Display date and time in details view.
471 https://bugzilla.gnome.org/show_bug.cgi?id=671257
473 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
475 2012-03-05 Murray Cumming <murrayc@murrayc.com>
477 Require the latest java-libglom.
479 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
481 2012-03-04 Murray Cumming <murrayc@murrayc.com>
483 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
485 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
486 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
487 an empty quickfind string. I also corrected libglom to create only
488 empty where clauses for empty quickfind strings, but this avoids the
491 2012-02-24 Ben Konrath <ben@bagu.org>
493 Improve the tabs in the Notebook widget.
497 2012-01-30 Murray Cumming <murrayc@murrayc.com>
499 Translations: Try to translate the strings.
501 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
502 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
503 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
504 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
505 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
506 Take the Open translation from GTK+'s .po files.
507 Take the Details translation from Glom's po files.
508 I have added the other strings to Glom so we can get translations that way:
509 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
511 2012-01-27 Murray Cumming <murrayc@murrayc.com>
513 TableSelectionViewImpl: Put the search label and entry in a div.
515 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
516 Put the search widgets in a FlowTable so that the CSS can be used to
517 style them while keeping them together.
518 * src/main/webapp/style.css: Mention the new div.
520 2012-01-27 Murray Cumming <murrayc@murrayc.com>
522 Translate more strings in more locales.
524 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
525 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
526 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
527 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
528 Translate the "Details" and "Open" string too.
530 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
531 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
532 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
533 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
534 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
535 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
536 Add these new locales as placeholders though they currently contain English.
538 2012-01-27 Murray Cumming <murrayc@murrayc.com>
540 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
543 Check the ConfiguredDocument* for null before using it.
545 2012-01-26 Murray Cumming <murrayc@murrayc.com>
547 Tell Eclipse about the generated java files.
549 * .classpath: This lets it find OnlineGlomConstants.java.
550 It would be nice if Eclipse just used the maven build files.
552 2012-01-26 Murray Cumming <murrayc@murrayc.com>
554 Prevent a crash when no locale is specified in the URL.
556 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
557 Avoid returning a null string, obtained from
558 Window.Location.getParameter(). This caused a crash when it was
559 later passed to libglom's API.
560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
561 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
562 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
563 guard against future null strings.
565 2012-01-26 Murray Cumming <murrayc@murrayc.com>
567 Use the ?locale= query param instead of the &lang= token param.
569 * src/main/java/org/glom/web/client/place/ListPlace.java
570 * src/main/java/org/glom/web/client/place/DetailsPlace.java
571 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
572 Remove the lang token key and value.
574 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
575 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
576 When the user selects a different locale from the chooser, use
577 Window.Location.assign() to change the URL, which then causes a reload.
579 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
580 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
581 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
582 * src/main/java/org/glom/web/client/activity/ListActivity.java
583 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
584 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
585 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
586 * src/main/java/org/glom/web/client/ui/ListView.java:
587 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
589 Remove localeID member variables and method/constructor parameters, instead
590 using Utils.getCurrentLocaleID() when we need a localID to pass to
593 2012-01-26 Murray Cumming <murrayc@murrayc.com>
595 Internationalize the UI strings.
597 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
598 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
599 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
600 because it is unused. Messages are apparently strings that can have
601 parameters, but we do not need that yet, so Contants will be enough for now.
602 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
603 to say that we support the en and de locales.
604 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
605 The original English strings.
606 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
607 Some German translations of the English strings.
608 The i18n goal then uses the .properties file to generate an
609 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
610 returns an implementation that returns the translated strings.
611 The documentation suggests putting these in src/java/*/client/, but it seems
612 best to put it in src/resources/*/client/.
613 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
614 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
615 instead of hard-coding them.
616 Note that we cannot import OnlineGlomConstants because it does not exist yet,
617 but that does not seem to stop the build, though it confuses Eclipse.
619 You can see the translated string by adding ?locale=de to the URL, like so:
620 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
622 2012-01-24 Murray Cumming <murrayc@murrayc.com>
624 Improve null/empty String checks.
626 * pom.xml: Add a dependency on commons-lang, to use
627 org.apache.commons.lang.StringUtils.
628 * src/main/java/org/glom/web/server/ConfiguredDocument.java
629 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
630 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
631 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
632 Use StringUtils.isEmpty().
634 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
635 StringUtils class with a static isEmpty() function because we
636 cannot use org.apache.commons.lang.StringUtils in client-side
637 GWT code because it (apparently) cannot be compiled to javascript.
638 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
639 * src/main/java/org/glom/web/client/activity/ListActivity.java
640 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
641 * src/main/java/org/glom/web/client/place/DetailsPlace.java
642 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
643 * src/main/java/org/glom/web/client/place/ListPlace.java
644 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
645 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
646 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
647 * src/main/java/org/glom/web/client/ui/details/Group.java
648 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
649 our StringUtils.isEmpty() function.
651 2012-01-24 Murray Cumming <murrayc@murrayc.com>
653 Update to the latest java-libglom API.
655 * pom.xml: Require java-libglom 1.21.4.
656 * src/main/java/org/glom/web/server/ConfiguredDocument.java
657 getDocumentInfo(), getListViewLayoutGroup():
658 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
660 * src/main/java/org/glom/web/server/database/DBAccess.java
661 getFieldsToShowForSQLQueryAddGroup(),
662 getPrimaryKeyLayoutItemField(): Replace get_database_title()
663 with either get_database_title_original() or
664 get_database_title(localeID).
666 2012-01-24 Murray Cumming <murrayc@murrayc.com>
668 ConfiguredDocument: Avoid a null pointer exception.
670 * src/main/java/org/glom/web/server/ConfiguredDocument.java
671 Initialize localeID to "" to avoid returning a null String which
672 causes a crash in java-libglom's swing-generated code.
674 2012-01-23 Murray Cumming <murrayc@murrayc.com>
676 Some simple renaming.
678 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
679 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
680 for localeChooser. This seems more appropriate and is less ambiguous
681 particularly in the .css file.
683 2012-01-23 Murray Cumming <murrayc@murrayc.com>
685 ConfiguredDocument: Rename the localedID private member variable.
687 2012-01-23 Murray Cumming <murrayc@murrayc.com>
689 Adapt to the latest java-libglom API from git master.
691 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
692 libglom now uses only Vector instead of List, which uses add() instead of
695 2012-01-22 Murray Cumming <murrayc@murrayc.com>
697 ConfiguredDocument: Rename the localedID private member variable.
699 2012-01-20 Murray Cumming <murrayc@murrayc.com>
701 Build a source tarball with mvn assembly:single
703 * assembly.xml: Add this file.
704 * pom.xml: Use the maven-assembly-plugin and tell it to use
705 our assembly.xml file.
707 2012-01-19 Murray Cumming <murrayc@murrayc.com>
709 OnlineGlomServiceImpl: Get .glom files recursively.
711 * pom.xml: Depend on commons-io from org.apache.commons.
712 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
713 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
714 files recursively, and with the easier filter for the extension.
715 Use org.apache.commons.io.FilenameUtils.removeExtension() to
716 simplify that code too.
718 2012-01-19 Murray Cumming <murrayc@murrayc.com>
720 README: Mention that you must install java-libglom packages separately.
722 But then it works, because java-libglom is now in the central maven
725 2012-01-18 Murray Cumming <murrayc@murrayc.com>
727 locales drop-down: Show the correct selected locale when the URL changes.
729 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
730 .java: setPlace(): Move some code into fillView().
732 2012-01-18 Murray Cumming <murrayc@murrayc.com>
734 locales drop-down: Do not lose the primary key.
736 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
737 start(): onLocaleChange(): Pass the current primary key value,
738 instead of an empty value.
740 2012-01-18 Murray Cumming <murrayc@murrayc.com>
742 locales drop-down: Do not lose the drop-down selection.
744 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
745 .java (TableSelectionActivity.fillView): Set the selected locale
746 after changing the drop-down items (though we do not really need
747 to change them just because the locale changes.)
749 2012-01-18 Murray Cumming <murrayc@murrayc.com>
751 locales drop-down: Change the tables list when this changes.
753 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
754 .java: TableSelectionActivity.start(): Move the async table titles
755 retrieval into a private fillView() method and also call this when
756 the chosen locale changes.
757 Note that the document title is not actually translatable yet, but
758 that is a problem that I should fix soon in libglom.
760 2012-01-18 Murray Cumming <murrayc@murrayc.com>
762 Improve the placement of the locales drop-down.
764 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
765 Put the title and locales drop-down in a div (gwt.FlowTable).
766 * src/main/webapp/style.css: Add magic css properties to make this work.
767 Also remove the left margin from the title so that it lines up with the
770 2012-01-18 Murray Cumming <murrayc@murrayc.com>
772 locales selector: Show human-readable locale titles.
774 * src/main/java/org/glom/web/server/ConfiguredDocument.java
775 getDocumentInfo(): Use java.util.Locale to show a real title of
776 each locale, in the locale's own language.
778 2012-01-17 Murray Cumming <murrayc@murrayc.com>
780 Add a language/locale selector drop-down.
782 * src/main/java/org/glom/web/shared/DocumentInfo.java:
783 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
784 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
785 getDocumentInfo(): Store the available Locales in the DocumentInfo.
786 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
787 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
788 Add a ListBox to show the available locales. Add getLocaleSelector(),
789 setLocaleList(), getSelectedLocale(), setSelectedLocale().
790 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
791 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
792 java: Add these classes.
793 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
794 start(): Fill the locales ListBox. Handle its change event, firing a
796 setPlace(): Show the selected locale as specified by the URL token.
797 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
798 * src/main/java/org/glom/web/client/activity/ListActivity.java:
799 Handle LocaleChangeEvent, going to a new *Place with that locale.
801 The placement of the ListBox is not pretty, and it currently uses the ID
802 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
806 2012-01-17 Murray Cumming <murrayc@murrayc.com>
808 Search box: Show the search text from the URL token.
810 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
811 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
812 Add setQuickFindText().
813 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
814 .java: setPlace(): Store the queryText if the place is a ListPlace,
815 and call TableSelectionView.setQuickFindText().
817 2012-01-17 Murray Cumming <murrayc@murrayc.com>
819 Allow use of translations via, for instance, &lang=de in the URL.
821 * pom.xml: Use the unstable java-libglom 1.21 version.
823 * src/main/java/org/glom/web/client/OnlineGlomService.java:
824 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
826 init(): Instead of calling TranslatableItem.set_current_locale()
827 (now removed), call ConfiguredDocument.setDefaultLocaleID().
828 However, this is only for default locales, which are not needed to
829 change the locale in the URL.
830 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
831 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
832 getSortedRelatedListData(): Add a localeID parameter, so we can get the
833 layout for a particular locale.
834 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
835 Add get/setDefaultLocaleID().
836 getDocumentInfo(), getListViewData(), getRelatedListData(),
837 getDetailsLayoutGroup(), getListViewLayoutGroup(),
838 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
839 localeID parameter, so we can get the layout for a particular locale.
841 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
842 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
843 * src/main/java/org/glom/web/client/place/ListPlace.java:
844 Parse and construct a lang parameter too.
846 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
847 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
848 passed to subsequent methods and constructors.
849 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
850 * src/main/java/org/glom/web/client/activity/ListActivity.java:
851 Store the localeID from the *Place and pass it to other constructors
852 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
854 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
855 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
856 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
857 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
858 * src/main/java/org/glom/web/client/ui/ListView.java:
859 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
860 Take localeID parameters and pass them to subsequent constructors and
861 methods, so that the layout is always retrieved for that locale.
863 This is rather repetitive.
865 Note that "" means the original (default) locale of the Glom document,
866 which is usually English.
868 2012-01-17 Murray Cumming <murrayc@murrayc.com>
870 Documents: Remove final keyword to fix startup configuration.
872 * src/main/java/org/glom/web/shared/Documents.java: Remove the
873 final keywords on the private member variables because that breaks
874 the startup, apparently (there are warnings) because it stops them
875 from being serialized. I added these in the previous commit.
877 2012-01-13 Murray Cumming <murrayc@murrayc.com>
879 Documents: Add some final keywords.
881 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
884 2012-01-13 Murray Cumming <murrayc@murrayc.com>
886 OnlineGlomServiceImpl: Add to overview comments.
888 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
889 Note that this is where all the document are loaded. They are not
890 loaded freshly for each page.
892 2012-01-12 Murray Cumming <murrayc@murrayc.com>
896 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
897 Add a TextBox for the text of a quick find.
898 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
900 setBackLink(): Add a String quickFind parameter.
901 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
902 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
903 to the base interface, because that is how TableSelectionViewImpl is used.
904 * src/main/webapp/style.css: Add style for the search box and its label.
906 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
907 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
908 Add these files, based on the existing TableChangeEvent and
909 TableChangeEventHandlers.
910 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
911 start(): Handle QuickFindChangeEvent, passing its quickFind text to
912 a ListPlace() that the user should be taken to.
913 * src/main/java/org/glom/web/client/activity/ListActivity.java
914 start(): Handle it here too and adapt the TableChangeEvent handler to
915 pass the extra "" quickFind parameter to ListPlace.
916 * src/main/java/org/glom/web/client/place/ListPlace.java:
917 Constructor: Take an extra String quickFind parameter and store it,
918 returning it from a new getQuickFind() method.
919 getToken(): Put the quickFind text in the URL token.
920 getPlace(): Parse the quickFind text from the URL token.
921 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
922 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
923 ListPlace constructor.
924 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
925 .java: start(): Add a Change handler for the TableSelectionView's
926 TextBox (via its base HasChangeHandlers interface), firing the new
927 QuickFindChangeEvent.
928 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
929 pass the extra "" quickFind parameter.
931 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
932 setCellTable(): Add a String quickFind parameter and pass it to
933 the ListViewTable() constructor.
934 * src/main/java/org/glom/web/client/ui/ListView.java: Change
935 setCellTable() in the base interface, because that is how ListViewImpl
938 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
939 Add a String quickFind member variable.
940 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
941 Constructor: Add a String quickFind parameter, storing it in the
942 base ListTable's member variable.
943 onRangeChanged(): Pass quickFind to the
944 OnlineGlomServiceAsync.getSortedListViewData() and
945 OnlineGlomServiceAsync.getListViewData() methods.
947 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
948 getListViewData(), getSortedListViewData(): Add a String quickFind
949 parameter, passing it to ConfiguredDocument.getListViewData().
950 * src/main/java/org/glom/web/client/OnlineGlomService.java:
951 Change getListViewData(), getSortedListViewData() in the base interface,
952 because that is how OnlineGlomServiceImpl is used, via this:
953 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
954 Change getListViewData(), getSortedListViewData() here too.
955 This class can apparently be used to asynchronously call methods on
956 OnlineGlomService, and GWT seems to implement that after recognizing
957 just the *Async name convention and the extra AsyncCallback parameters.
959 * src/main/java/org/glom/web/server/ConfiguredDocument.java
960 getListViewData(): Add a String quickFind parameter, and pass it to
961 ListViewDBAccess.getData().
962 * src/main/java/org/glom/web/server/database/ListDBAccess.java
963 getListData(): Add a String quickFind parameter and pass it to
965 getSelectQuery(): Add a String quickFind parameter.
966 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
967 getSelectQuery(): Add a String quickFind parameter and use it with
968 Glom.get_find_where_clause_quick() to pass a where_clause to
969 Glom.build_sql_select_with_where_clause(), to actually filter the
971 getData(): Add a String quickFind parameter, passing it to getListData().
972 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
973 va: getData(): Pass an empty string to getListData() for the
976 2012-01-12 Murray Cumming <murrayc@murrayc.com>
978 ListTable: Minor change.
980 * src/main/java/org/glom/web/client/ui/list/ListTable.java
981 createCellTable(): Make this protected instead of public.
983 2012-01-12 Murray Cumming <murrayc@murrayc.com>
985 Many files: Use final for the parameters and use the @override attribute.
987 2012-01-22 Ben Konrath <ben@bagu.org>
989 Add anchor links for single line text that starts with http, ftp and www.
993 2012-01-22 Ben Konrath <ben@bagu.org>
995 Add ellipsis to single line text in details view.
999 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1001 Remove all javadoc author tags.
1003 Because they are awkward and meaningless when many people touch
1005 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1007 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1009 Revert the COPYING.LESSER to COPYING rename.
1011 Apparently both should be there if it is LGPL.
1013 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1015 *View: Remove unused imports.
1017 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1018 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1019 * src/main/java/org/glom/web/client/ui/ListView.java:
1020 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1021 Remove unused imports, as suggested by Eclipse.
1023 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1025 Move the *View::Presenter types, and some API into one base View.
1027 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1028 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1029 * src/main/java/org/glom/web/client/ui/ListView.java:
1030 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1031 Presenter, setPresenter() and clear() into a shared base interface,
1032 to avoid the unnecessary duplicate Presenter types and to more clearly
1033 show how the *Views share the same structure, even if they are not
1034 used polymorphically.
1036 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1037 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1039 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1040 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1041 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1043 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1046 Feel free to revert this if there is a good reason for the duplicate
1049 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1051 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1053 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1054 a class member instead of a local variable in the method.
1055 This lets us use it to get the view instances, for use in tests.
1056 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1057 beforeOnlineGlom(): Test some more details of the initial view.
1058 Again, this is not very useful.
1060 To really test gwt-glom we will need to start a local postgresql
1061 instance with local data, like the Glom tests in C++.
1063 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1065 pom.xml: Mention the LGPL license.
1067 * pom.xml: Add a licenses section.
1068 * COPYING.LESSER: Move this to COPYING, which
1069 previously contained the GPL. But gwt-glom is all LGPL.
1071 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1073 Add project information to README and pom.xml.
1075 * README: Add a brief description and mention some mvn
1077 * pom.xml: This extra information shows up in mvn site
1080 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1082 Use the latest java-libglom version.
1084 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1086 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1088 GwtTestOnlineGlom: Test a little more.
1090 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1091 protected rather than private, as suggested by the gwt-test-utils
1093 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1094 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1095 Test the initial visibility of the panels.
1097 However, this is not a very useful test.
1098 And I wonder how we should generally test using this idea for an
1099 activity/places app like ours where the real changes happen implicitly
1100 based on the history token/URL.
1102 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1104 Slight modification to *Mapper comments.
1106 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1107 (DataActivityMapper)
1108 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1110 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1112 Remove comments mentioning GIN because they are just copied from
1113 the example code and are apparently not helpful:
1114 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1115 Also change the mention of a class that is only in the example code.
1117 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1119 GwtTestOnlineGlom test: Minor changes.
1121 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1122 Avoid the long qualified class name and modify the comment
1123 because it is now obvious to me that the mocked class is the only
1124 custom one created via GWT.create().
1126 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1128 Tests: Added the beginnings of a test using gwt-test-utils.
1130 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1131 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1132 which tells gwt-test-utils what class will be tested.
1133 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1134 Add a simple (but empty) test case. One class, used by the OnlineGlom
1135 class, is mocked so that it can be created. However, I am not sure
1136 why only this class needs to be mocked.
1138 Note that mockito seems more popular, and clearer, than easymock,
1139 but I have not got that working yet. It might be a matter of the
1142 This test is run during mvn integration-test.
1144 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1146 Tests: Use junit4-style syntax instead of junit3-style.
1148 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1149 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1150 * src/test/java/org/glom/web/shared/DataItemTest.java:
1151 Use the @Test annotation rather than relying on the test*() prefix.
1152 Also no longer implement TestCase, to avoid triggering support for
1153 the junit3-way, which stops the annotations from working.
1154 Change the imports from import junit.framework.* to
1155 import org.junit.*, which is apparently the new way.
1157 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1159 Added a test for ListPlace token parsing and creation.
1161 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1162 This is much the same as DetailsPlaceTest.
1164 I wonder how we could test the other parts of the *Place API.
1166 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1168 DetailsPlace test: Also test getToken() and recreation via getPlace().
1170 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1171 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1172 recreate it, testing the recreated DetailsPlace for the same parameter
1175 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1177 Use the surefire-report plugin.
1179 * pom.xml: This generates a HTML report about the tests in
1180 target/site/surefire-report.html
1181 when you do mvn surefire-report:report. It seems to be popular/normal.
1183 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1185 Added a test for DetailsPlace.
1187 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1188 Test the getPlace() token parsing.
1190 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1192 Added a first unit test.
1194 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1195 * src/test/java/org/glom/web/shared/DataItemTest.java:
1196 This is a silly test but it is just to get things started. Note that
1197 maven/junit finds the test because it looks in src/test by default.
1199 2011-12-22 Ben Konrath <ben@bagu.org>
1201 Change charsetName to "UTF-8" when replacing line breaks.
1203 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1204 that work in Java (such as "UTF8") will not work when compiled to
1207 This fixes a problem with multi-line details view fields that have hard
1208 line breaks. The "License Text" field on this page demonstrates the
1211 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1213 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1215 2011-12-22 Ben Konrath <ben@bagu.org>
1217 Fix another bug with related list navigation.
1219 I've tested all the navigation buttons in all of the related lists
1220 so things should be good now.
1222 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1224 2011-12-22 Ben Konrath <ben@bagu.org>
1226 Fix a crasher when refreshing the list view with the default table.
1228 This crash will also happen when loading the list view with the default
1229 table from a link or bookmark.
1231 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1232 to the main document selection page when the document id hasn't been
1234 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1235 the main document selection page when the document id hasn't been
1237 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1238 values for the details place when the document id hasn't been set.
1239 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1240 values for the list place when the document id hasn't been set.
1242 2011-12-21 Ben Konrath <ben@bagu.org>
1244 Protect against NPE when glom.document.locale is not in config.
1246 This patch protects against an NPE when glom.document.locale is not in
1247 the config file. This NPE will also happen if glom.document.locale is
1250 The patch also updates the error message to display the class name when
1251 the getMessage() returns null. This was happening when the NPE was
1252 thrown and I had "Configuration Error: null". If an NPE is encountered
1253 with this patch, "Configuration Error: NullPointerException " will be
1256 This commit closes this bug:
1258 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1260 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1262 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1264 Rename onlineglom.properties to onlineglom.properties.sample.
1266 * src/main/resources/onlineglom.properties: Rename to:
1267 * src/main/resources/onlineglom.properties.sample:
1268 * src/main/resources/README: And add this file explaining that people
1269 should rename it back when deploying.
1271 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1273 Allow choosing the translation in the .properties file.
1275 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1276 init(): Read a glom.document.locale value from the configuration file
1277 and call Glom's TransatableItem::set_current_locale() method.
1278 * src/main/resources/onlineglom.properties: Add a commented-out
1279 example of this new setting.
1281 It would be better to add &lang=de_DE to the URL, but the current
1282 libglom API does not allow us to do this easily. I am working on that.
1284 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1286 Avoid a crash in parsing of token parameters.
1288 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1289 ava: getTokenParams(): Do not crash if a parameter has a key but no
1290 value, and ignore parameters with neither.
1292 2011-12-17 Murray Cumming <murrayc@murayc.com>
1294 History token building/handling: Improve use of token parameters.
1296 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1297 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1298 and buildParamsToken(HashMap), for use by derived classes.
1299 Make the separator private because it is no longer be needed.
1300 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1301 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1302 instead of manual string concatenation.
1303 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1304 of hardcoded indices and awkward splitting code.
1305 * src/main/java/org/glom/web/client/place/ListPlace.java
1306 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1307 instead of manual string concatenation.
1308 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1309 of hardcoded indices and awkward splitting code.
1310 This should fix bug #666420
1312 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1314 Fix a Navgiation->Navigation typo in the code.
1316 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1317 Rename processNavgiation() to processNavigation().
1319 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1321 Fix a seperator->separator typo in the code.
1323 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1324 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1325 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1328 2011-12-15 Ben Konrath <ben@bagu.org>
1330 Cleanup some comments.
1332 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1334 2011-12-14 Ben Konrath <ben@bagu.org>
1336 Replace \n with <br/> for multiline text in the details view.
1338 Vertical scrollbars are added when needed as well.
1340 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1342 2011-12-14 Ben Konrath <ben@bagu.org>
1344 Specify the font for document selection links.
1346 * src/main/webapp/style.css:
1348 2011-12-14 Ben Konrath <ben@bagu.org>
1350 Fix bouncy CellTable while paging.
1352 This doesn't currently work with related list tables in unselected
1355 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1357 2011-12-14 Ben Konrath <ben@bagu.org>
1359 Revamp the appearance of the document selection page.
1361 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1362 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1363 * src/main/webapp/style.css:
1365 2011-12-13 Ben Konrath <ben@bagu.org>
1367 Set navigation button column to the smallest size possible.
1369 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1371 2011-12-13 Ben Konrath <ben@bagu.org>
1373 Change OpenButton nomenclature to NavigationButton.
1375 Using NavigtionButton makes things more generic. Classes, methods and
1376 variables have been changed.
1378 This is a rename-only refactor.
1380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1381 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1382 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1383 Renamed from OpenButtonCell.
1384 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1385 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1386 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1388 2011-12-12 Ben Konrath <ben@bagu.org>
1390 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1393 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1394 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1395 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1397 2011-12-12 Ben Konrath <ben@bagu.org>
1399 Update variable names and comments.
1401 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1402 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1404 2011-12-12 Ben Konrath <ben@bagu.org>
1406 Properly initialize numNonEmptyRows variable to zero.
1408 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1409 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1411 2011-12-05 Ben Konrath <ben@bagu.org>
1413 Add latest mockup with HTML tables.
1415 Features of this mockup:
1417 -> HTML table for flowtable
1418 -> HTML table for flowtable column
1419 -> Example of how related lists would look
1420 -> Not using text entries for data items
1422 The current version of Online Glom doesn't use HTML tables for the
1425 This mockup has been sent to the glom-devel mailing list but it's good
1426 to have it here as well.
1428 * mockups/details-view-html-tables.html:
1430 2011-12-05 Ben Konrath <ben@bagu.org>
1432 Remove unnecessary getPrimaryKeyField() method.
1434 getPrimaryKeyFieldForTable(String) has been renamed to
1435 getPrimaryKeyField(String).
1437 * src/main/java/org/glom/web/server/database/DBAccess.java:
1438 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1439 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1441 2011-12-05 Ben Konrath <ben@bagu.org>
1443 Add string representation of TypedDataItem value to conversion error message.
1445 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1446 message was extracted into its own method to avoid duplication.
1448 2011-12-05 Ben Konrath <ben@bagu.org>
1450 Add type checking to navigation primary key value creation.
1452 Create navigation primary key only if the expected type from the Glom
1453 document matches the type returned by the SQL query.
1455 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1457 2011-12-05 Ben Konrath <ben@bagu.org>
1459 Rename a couple of variables in RelatedListNavigation.
1461 This is a rename-only refactor.
1463 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1465 2011-12-05 Ben Konrath <ben@bagu.org>
1467 Move getListLayoutGroup() into getListViewLayoutGroup().
1469 This removes getListLayoutGroup(). It was only being called by
1470 getListViewLayoutGroup().
1472 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1474 2011-12-05 Ben Konrath <ben@bagu.org>
1476 Remove check for LayoutItem_Portal in list table method.
1478 This check is no longer necessary because the method isn't being used
1479 to create the LayoutItemPortal DTO.
1481 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1483 2011-12-05 Ben Konrath <ben@bagu.org>
1485 Properly support related list navigation.
1487 Navigation from the "Repository Analyzer -> Package Scans ->
1488 Dependencies" related table wasn't working because the primary key for
1489 related tables wasn't being set properly. This commit fixes the
1492 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1493 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1494 doesn't set the primary key properly for related list tables.
1495 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1496 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1497 useful for getting the primary key for list view tables and for related
1499 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1500 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1501 Move code to set the primary key for the table from the abstract
1502 ListDBAccess class to ListViewDBAccess as it's only correct for list
1504 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1505 Properly add primary key to related list tables.
1507 2011-12-02 Ben Konrath <ben@bagu.org>
1509 Properly set the horizontal alignment of fields.
1511 This fix is for both the list tables and the details view.
1513 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1514 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1515 to set the horizontal alignment of fields.
1517 2011-12-02 Ben Konrath <ben@bagu.org>
1519 Display currency codes in the details view.
1521 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1523 2011-12-02 Ben Konrath <ben@bagu.org>
1525 Avoid duplicate JNI call.
1527 JNI is not as efficient as pure Java and this is an easy (and small)
1530 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1531 Use previously retrieved value for whereClauseToTableName instead of
1534 2011-12-02 Ben Konrath <ben@bagu.org>
1536 Rename a couple of variables in RelatedListNavigation.
1538 This is a rename-only refactor.
1540 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1542 2011-12-02 Ben Konrath <ben@bagu.org>
1544 Indicate clearly that a mismatched primary key type is a bug.
1546 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1547 warning to error. Add 'This is a bug.' to message.
1549 2011-12-02 Ben Konrath <ben@bagu.org>
1551 Update / fix some comments.
1553 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1555 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1557 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1558 Fix comments. Add some TODOs.
1560 2011-12-02 Ben Konrath <ben@bagu.org>
1562 Enable navigation to details view with string primary key from related list.
1564 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1565 Create a text primary key value when return type of result is
1566 java.sql.Types.VARCHAR.
1568 2011-12-02 Ben Konrath <ben@bagu.org>
1570 Use checkboxes for booleans in the details view.
1572 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1574 2011-12-01 Ben Konrath <ben@bagu.org>
1576 Improve performance of related list height calculation.
1578 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1579 Put code to calculate the expected height in a static initializer so
1580 that that it's only called once.
1582 2011-12-01 Ben Konrath <ben@bagu.org>
1584 Show related list tables in notebooks (again).
1586 Calculate the height of the related list tables so the Notebook can be
1587 set the correct height. The height of the related list table is also needed by
1588 FlowTable to be able decide how to create the layout.
1590 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1591 and set the Portal height based on the height of the related list
1592 table and the Portal container.
1593 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1594 Add method to calculate the height of the related list tables.
1595 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1596 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1597 calculate the height of the Pager widget.
1599 2011-12-01 Ben Konrath <ben@bagu.org>
1601 Use CellTable API for table property instead of setting style on Element.
1603 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1605 2011-12-01 Ben Konrath <ben@bagu.org>
1607 Make ListViewTable and RelatedListTable a consistent height.
1609 The tables are now a consistent height regardless of the contents of
1610 the table. A hidden button is added to empty rows to ensure that the
1611 height of these rows will match the height of rows with data.
1613 A navigation button column is now added to every table. The width of
1614 the navigation column is set to 0px when a RelatedListTable shouldn't
1615 have navigation buttons. This maintains the a consistent row height in
1616 tables that don't show the navigation buttons.
1618 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1619 navigation column when not needed.
1620 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1621 arguments for navigation button to constructor of ListViewTable.
1622 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1623 hidden button for empty data rows.
1624 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1625 arguments for navigation button to constructor.
1626 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1627 create navigation buttons. Add hideNavigationButtons() method.
1628 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1629 arguments for navigation button to constructor.
1631 2011-12-01 Ben Konrath <ben@bagu.org>
1633 Use 'visibility: hidden' in Utils.getWidgetHeight().
1635 This is better choice because hidden elements are invisible, don't
1636 respond to events and are not part of the tab order. They will,
1637 however, take up space which is required to be able to calculate the
1638 height of the widget.
1640 * src/main/java/org/glom/web/client/Utils.java:
1642 2011-12-01 Ben Konrath <ben@bagu.org>
1644 Use Utils.getWidgetHeight() in FlowTable.
1646 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1648 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1650 2011-12-01 Ben Konrath <ben@bagu.org>
1652 Put the details css class name on the correct table column.
1654 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1656 2011-11-30 Ben Konrath <ben@bagu.org>
1658 Update for java-libglom API change.
1660 The getters and setters on FieldFormatting and NumericFormat were
1661 changed to remove the 'M'.
1663 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1665 2011-11-29 Ben Konrath <ben@bagu.org>
1667 Only allow RelatedListTables in Portals.
1669 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1671 2011-11-29 Ben Konrath <ben@bagu.org>
1673 Only create a contents panel for Portals when title is being set.
1675 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1677 2011-11-29 Ben Konrath <ben@bagu.org>
1679 Set TabLayoutPanel height based on calculated height its widgets.
1681 This is a potential fix for this bug:
1683 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1685 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1687 2011-11-29 Ben Konrath <ben@bagu.org>
1689 Align details field labels and data with the Open buttons.
1691 * src/main/webapp/style.css:
1693 2011-11-29 Ben Konrath <ben@bagu.org>
1695 Remove unnecessary <div> in the Notebook widget.
1697 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1698 method to get container FlowPanel (<div>).
1699 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1700 initWidget() method directly on the TabLayoutPanel widget instead of
1701 Group's container widget.
1703 2011-11-29 Ben Konrath <ben@bagu.org>
1705 Don't add group titles for Portals in Notebooks.
1707 This reverts the previous patch and fixes a bug I introduced with
1708 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1710 * src/main/java/org/glom/web/client/ui/details/Group.java:
1711 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1713 2011-11-28 Ben Konrath <ben@bagu.org>
1715 Remove unused boolean argument in Portal constructor.
1717 Just a code cleanup.
1719 * src/main/java/org/glom/web/client/ui/details/Group.java:
1720 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1722 2011-11-28 Ben Konrath <ben@bagu.org>
1724 Remove hack for glom 1.18 style glom files.
1726 * src/main/java/org/glom/web/client/ui/details/Group.java:
1727 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1728 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1730 2011-11-28 Ben Konrath <ben@bagu.org>
1732 Use Gda Value version of primary key to log result too large error.
1734 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1736 2011-11-28 Ben Konrath <ben@bagu.org>
1738 Don't use TypedDataItem.getText() for Unknown types from the URL.
1740 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1741 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1742 instead of getText().
1743 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1744 String field and getUnknown() method.
1746 2011-11-28 Ben Konrath <ben@bagu.org>
1748 Log an error message when the java-libglom .so is not present.
1750 The error message was being set in the exception but not logged.
1752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1754 2011-11-28 Ben Konrath <ben@bagu.org>
1756 Ignore LayoutItem_CalendarPortals.
1758 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1759 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1761 2011-11-28 Ben Konrath <ben@bagu.org>
1763 Extract method for creating the LayoutItemPortal DTO.
1765 Just breaking the code up into smaller chunks.
1767 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1769 2011-11-28 Ben Konrath <ben@bagu.org>
1773 This should have been added with the refactor. Oops!
1775 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1777 2011-11-28 Ben Konrath <ben@bagu.org>
1779 Create primary key value from URL string using type from Glom document.
1781 See this bug, comments 19 - 25:
1783 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1785 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1786 create a TypeDataItem for the primary key here when loading from a
1787 URL. Show the same string for the primary key value as was received
1788 from the URL string (when loading from a URL).
1789 * src/main/java/org/glom/web/server/Utils.java: Update method for
1790 creating the Gda Value from the TypeDataItem to properly deal with
1791 creating a Gda Value based on the Glom document type for the primary
1792 key value string when loading from a URL.
1793 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1794 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1795 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1796 Update for changed method name.
1798 2011-11-27 Ben Konrath <ben@bagu.org>
1800 Rename PrimaryKeyItem to TypedDataItem.
1802 The name PrimaryKeyItem suggests what the class should be used for.
1803 TypedDataItem is a neutral name that describes the class better.
1805 This is a rename-only refactor.
1807 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1808 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1809 * src/main/java/org/glom/web/client/Utils.java:
1810 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1811 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1812 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1813 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1814 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1815 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1817 * src/main/java/org/glom/web/server/Utils.java:
1818 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1819 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1820 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1821 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1823 2011-11-25 Ben Konrath <ben@bagu.org>
1825 Improve Gda Value conversion from PrimaryKeyItem.
1827 The value from the PrimaryKeyItem is only used if its type match the
1828 type from the glom document.
1830 * src/main/java/org/glom/web/server/Utils.java:
1832 2011-11-25 Ben Konrath <ben@bagu.org>
1834 Manually check if the java-liblgom .so is visible to the JVM.
1836 It seems that Tomcat has problems when a static initializer throws an
1837 exception. This check is done before the first method call into
1838 java-libglom so that execution doesn't continue if the .so is not
1841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1843 2011-11-25 Ben Konrath <ben@bagu.org>
1845 Improve browser configuration error messages.
1849 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1851 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1852 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1853 getConfigurationErrorMessage() method.
1854 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1855 Get and display a specific configuration error message when no Glom
1856 documents are found.
1857 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1858 Implement getConfigurationErrorMessage() method. Surround configuration
1859 code in the init() method with a try/catch block. This allows the
1860 errors to be caught while keeping the servlet available to retrieve the
1861 configuration error message.
1863 2011-11-25 Ben Konrath <ben@bagu.org>
1865 Don't use Strings to hold primary key values.
1867 The primary key values are now held in a new data object
1868 (PrimaryKeyItem) that holds type information and the primary key value
1869 using the correct type.
1871 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1872 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1873 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1874 PrimaryKeyItem instead of String to hold the primary key value.
1875 * src/main/java/org/glom/web/client/Utils.java: Remove
1876 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1877 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1878 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1879 PrimaryKeyItem instead of String to hold the primary key value. Load
1880 document selection page when the documentID has not been set correctly.
1881 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1882 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1884 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1885 Return empty string for URL instead of "null".
1886 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1887 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1888 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1889 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1890 PrimaryKeyItem instead of String to hold primary key values.
1891 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1892 PrimaryKeyValue to a Gda Value.
1893 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1894 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1895 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1896 Replace temporary database access code that uses the PrimaryKeyValue to
1897 Gda Value conversion.
1898 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1899 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1900 PrimaryKeyItem instead of String.
1901 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1902 hold primary key values.
1904 2011-11-24 Ben Konrath <ben@bagu.org>
1906 Use newly added java-libglom API to create queries.
1908 This isn't finished. I still need to stop using Strings for primary key
1909 values in the client code.
1911 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1912 libglom to use fake connections so that retrieving the query string will
1914 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1915 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1916 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1917 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1918 Use the newly added libglom sql methods and classes to create the
1919 query. Add temporary hack to convert primary value strings to Gda
1922 2011-11-23 Ben Konrath <ben@bagu.org>
1924 Don't explicitly set the height of Portals.
1926 See comments 6 - 10 of this bug for details:
1928 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1930 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1932 2011-11-23 Ben Konrath <ben@bagu.org>
1934 Use an HTML table instead of CSS for the FlowTable layout.
1936 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1937 GWT's FlexTable to implement the FlowTable.
1938 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1940 2011-11-18 Ben Konrath <ben@bagu.org>
1942 Add boolean example to HTML table mockup.
1944 * mockups/details-view-html-tables-text-entries.html:
1946 2011-11-17 Ben Konrath <ben@bagu.org>
1948 Ensure the pager buttons are always visible for related lists.
1950 To accomplish this, I've turned off text wrapping in the list view and
1951 related list tables for both the header and data text. The related list
1952 table now has a fixed layout so the it doesn't overflow its container.
1953 This is required to ensure that the cell text is clipped when it
1954 overflows the cell and an ellipsis is added to the right side of the
1955 cell when text is clipped.
1957 A fixed table layout for the related list table in the details view
1958 seems what we want for the details view anyway, so the side-effect is
1961 The ellipsis will only be displayed in Firefox >= 7.
1965 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1967 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1968 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1969 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1971 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1972 Set the 'table-layout: fixed' CSS property to the related list table.
1973 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1974 'white-space: nowrap;' CSS property on both the list view and the
1975 related list tables.
1977 2011-11-16 Ben Konrath <ben@bagu.org>
1979 Rework the fix for empty notebook tab labels.
1981 Setting the empty group titles with its name caused problems for the
1982 details layout. Instead of using libglom's
1983 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1984 to the client when the title is empty. This allows the Notebook to use
1985 the name when the title is empty without affecting anything else.
1987 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1988 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1990 2011-11-16 Ben Konrath <ben@bagu.org>
1992 Set group titles with name when title is empty.
1994 This fixes a problem with an empty notebook tab label in the Lesson
1995 Planner document. The forth tab in the notebook should be "Internet":
1997 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1999 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2000 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2003 2011-11-16 Ben Konrath <ben@bagu.org>
2005 Remove whitespace from the configured username properties.
2007 This assumes that usernames won't have whitespace at the beginning
2008 or end. But I think this is a reasonable assumption.
2010 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2011 String.trim() to remove the whitespace from the username properties.
2013 2011-11-15 Ben Konrath <ben@bagu.org>
2015 Add details view mockup with HTML tables and text entries.
2017 This is from the attachment on this bug:
2019 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2021 * mockups/details-view-html-tables-text-entries.html:
2023 2011-11-15 Ben Konrath <ben@bagu.org>
2025 Add space between the columns of the flow table.
2029 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2031 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2032 space between columns in the flow table.
2034 2011-11-15 Ben Konrath <ben@bagu.org>
2036 Add backup files to the .gitignore.
2038 * .gitignore: Ignore files that end with ~.
2040 2011-11-09 Ben Konrath <ben@bagu.org>
2042 Use latest release of gwt-log.
2044 Gwt-log releases are now being submitted to the maven central
2045 repository so manual installation of the jar is no longer required.
2047 * pom.xml: Update version and groupId of gwt-log dependency.
2049 2011-10-31 Ben Konrath <ben@bagu.org>
2051 Don't use GWT numeric formatting to override the glom currency formatting.
2053 Currencies are now displayed like they are in Glom. See this bug:
2055 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2057 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2059 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2060 currency code to constructor and set it when the cell is rendered.
2061 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2062 currency code to the constructor of the NumericCell.
2064 2011-10-27 Ben Konrath <ben@bagu.org>
2066 Require the latest release of java-libglom (1.17.4).
2070 2011-10-26 Ben Konrath <ben@bagu.org>
2072 Add style to Notebook that matches current theme.
2074 It's not the best style in the world but it's better than the default.
2076 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2077 padding at the bottom of the child widgets.
2078 * src/main/webapp/style.css: Add style for the Notebook.
2080 2011-10-26 Ben Konrath <ben@bagu.org>
2082 Move servlet initialization code to overridden init method.
2084 This is half of the solution to getting proper error messages
2085 displayed when configuration errors occur. Here's the relevant bug:
2087 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2089 The rest of the solution involves surrounding the init method with a
2090 try/catch block and setting a global variable with the error /
2091 exception. A new async method should be created to retrieve and display
2092 the error message / exception.
2094 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2095 code from constructor to init method adding exceptions as needed.
2097 2011-10-26 Ben Konrath <ben@bagu.org>
2099 Add script to monitor and restart tomcat if required.
2101 * utils/check-and-recover-tomcat.py: New file.
2103 2011-10-26 Ben Konrath <ben@bagu.org>
2105 Display the correct number of data items in the pager.
2109 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2111 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2112 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2113 The implementation is the same for both tables: Keep track of the
2114 number of non-empty rows and fire and RowCountChangeEvent after the data has
2116 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2117 custom Pager class that subclasses SimplePager to handle displaying
2118 the correct number when empty rows have been added.
2120 2011-10-26 Ben Konrath <ben@bagu.org>
2122 Correct error in previous commit.
2124 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2125 eventBus parameter from listView.setCellTable().
2127 2011-10-26 Ben Konrath <ben@bagu.org>
2129 Fix error in TODO comment.
2131 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2133 2011-10-24 Ben Konrath <ben@bagu.org>
2135 Create Notebook widgets to the details view.
2137 This isn't finished just yet - I still need to create a reasonable
2138 style to match the current theme.
2140 * src/main/java/org/glom/web/client/Utils.java: Add method for
2141 calculating the height of a widget. This is used in the Notebook class.
2142 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2143 new constructor method in Group.
2144 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2145 method for creating child widget that can be used by subclasses
2146 like Notebook. New constructor that allows disabling the group
2147 titles - Notebooks don't set a group title for their child groups.
2148 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2149 to make Notebooks using GWT's TabLayoutPanel.
2150 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2151 constructor that allows disabling the group titles.
2152 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2153 LayoutItemNotebook DTO.
2154 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2155 DTO for Notebooks. It's just an empty class for now but we might need
2156 it to transfer some specific information in the future.
2158 2011-10-21 Ben Konrath <ben@bagu.org>
2160 Add navigation buttons to related list tables.
2162 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2163 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2164 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2165 method getSuitableRecordToViewDetails() for getting the table name
2166 and primary key value for related list navigation buttons.
2167 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2168 private cell renderer class to get the navigation information for
2169 related list tables from the server. Extract the navigation
2170 processing code from the details cell navigation and use it for the
2171 related list navigation as well.
2172 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2173 cell renderer class for the details open buttons. This was needed
2174 because the related list navigation buttons and the list view
2175 navigation buttons need to react differently when clicked.
2176 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2177 the onEnterKeyDown() method because it's now overriden in the
2178 subclasses that are specific to the related list tables and the list
2180 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2181 the vertical size a little because the buttons add a bit of vertical
2182 space to table. This is not a perfect solution because the vertical
2183 size of with table fewer than 5 rows will be a little smaller.
2184 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2185 changes in how navigation buttons are handled.
2186 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2187 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2188 database access object.
2189 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2190 to find the portal for a given relationship name from
2191 RelatedListDBAccess. Add method to find a primary key field for a
2193 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2194 Move code to find the portal for a given relationship name to
2196 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2197 New file: database access object for getting the related list
2198 navigation information (the table name and the primary key value).
2199 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2200 DTO for transferring a table name to navigate to and a primary key
2202 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2203 boolean and getter/setter to specifies if the related list should add
2206 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2208 Use the master branch of java-libglom
2210 * pom.xml: Depend on java-libglom 1.19 instead.
2212 This is the master branch. See also the libglom-1-18 branch.
2214 2011-10-11 Ben Konrath <ben@bagu.org>
2216 Enable the open navigation button when the data has been set.
2218 This avoids having active buttons that don't do anything when the data
2221 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2223 2011-10-11 Ben Konrath <ben@bagu.org>
2225 Use IsWidget interface for FlowTableItem.
2227 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2228 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2230 2011-10-11 Ben Konrath <ben@bagu.org>
2232 Remove GWT styling from open button in details view.
2234 There are still some issues with how the details cell is arranged but
2235 this should be made to match Glom 1.20. I'm going to leave fixing this
2236 until I have Glom 1.20 up and running.
2238 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2239 style name on open button.
2240 * src/main/webapp/style.css: Move and edit details-navigation class.
2241 Re-arrange some classes to make them appear in the same order as the
2244 2011-10-07 Ben Konrath <ben@bagu.org>
2246 Update to GWT 2.4.0.
2248 * .gitignore: Ignore new cache directory.
2249 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2250 * pom.xml: Change GWT and maven plugin to 2.4.0.
2251 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2253 * src/main/java/org/glom/web/client/ClientFactory.java:
2254 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2255 * src/main/java/org/glom/web/client/OnlineGlom.java:
2256 Update source for API changes.
2257 * utils/build-onlineglom-war.sh: Remove cache directory before the
2260 2011-10-07 Ben Konrath <ben@bagu.org>
2262 Add navigation buttons in the details view.
2264 This isn't finished but I thought I'd commit what I have as it's a
2265 pretty good start. I still need to:
2267 1. Change the style so that it fits better into the current theme
2268 2. Adjust the details cell to expand as much as possible.
2270 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2271 click handlers to navigation buttons in the DetailsCells. Create a
2272 refreshData() method to get just the data from the server without the
2274 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2275 Update the tableSelector and browser title when the table name
2276 changes without using the tableSelector.
2277 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2278 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2279 getDetailsCells() to getCells(). Update variable names.
2280 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2281 method to set click handler on navigation button. Rename a few
2282 variables. Add navigation buttons where needed.
2283 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2284 variables and methods.
2285 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2286 navigation boolean and navigation table as required in the
2287 LayoutItemField DTO.
2288 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2289 variables for navigation along with getter/setter methods.
2291 2011-10-07 Ben Konrath <ben@bagu.org>
2293 Rename Field to DetailsCell.
2295 This is a refactor-only commit. No functionality has been added or
2298 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2299 Update variable and method names.
2300 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2301 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2302 variable and method names.
2303 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2305 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2306 variable and method names.
2308 2011-10-07 Ben Konrath <ben@bagu.org>
2310 Create separate methods for layout and data the details view.
2312 This is a refactor-only commit. No functionality has been added or
2315 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2316 private methods: setData(), createLayout().
2318 2011-10-07 Ben Konrath <ben@bagu.org>
2320 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2322 This is part of a change to get navigation buttons in the details view
2323 but it should have been done this way from the start.
2325 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2326 for method name change in TableSelectionView.
2327 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2328 Create TableChangeEvent and set the browser title using the
2329 TableSelectionView API.
2330 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2331 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2332 Change getSelectedTable() to getSelectedTableName(). Add
2333 getSelectedTableTitle().
2335 2011-10-07 Ben Konrath <ben@bagu.org>
2337 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2339 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2341 2011-10-07 Ben Konrath <ben@bagu.org>
2343 Update TableChangeEvent to use newTableName naming convention.
2345 This makes the class more consistent with GWT naming conventions.
2347 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2348 Update for method name change in TableChangeEvent.
2349 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2350 for method name change in TableChangeEvent.
2351 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2352 newTableName variable and getter method. Make toDebugString()
2355 2011-09-30 Ben Konrath <ben@bagu.org>
2357 Disable the pager in the list tables when the data row count is less than the minimum.
2359 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2360 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2362 2011-09-30 Ben Konrath <ben@bagu.org>
2364 Add empty rows to the end of related list and list view tables.
2366 I also extracted the cell rendering classes from the ListTable because
2367 the code was becoming a little crazy with all the anonymous inner
2368 classes. My plan is to use these cell rendering classes in the details
2369 view as well so this refactor will be needed for that change.
2371 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2372 set the row count in related list tables if the data has more rows
2373 than the minimum number of rows visible.
2374 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2375 row count in list view tables if the data has more rows than the
2376 minimum number of rows visible.
2377 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2378 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2380 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2381 for rendering TYPE_NUMERIC cells. The code was extracted from the
2383 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2384 class for rendering cells with buttons in list views. The code was
2385 extracted from the ListTable class.
2386 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2387 for rendering TYPE_TEXT cells. The code was extracted from the
2389 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2390 Add empty rows to the end of the data if required. Implement
2391 ListTable.getMinNumVisibleRows().
2392 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2393 cell renderer code to public classes. Return null in
2394 Column.getValue() for empty rows. Add new abstract method:
2395 getMinNumVisibleRows(). Move code to set the row count of the list view
2396 table to ListViewImpl.
2397 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2398 empty rows to the end of the data if required. Implement
2399 ListTable.getMinNumVisibleRows().
2402 2011-09-27 Ben Konrath <ben@bagu.org>
2404 Use GWT.log for client-side debugging statements.
2406 These are optimized out when deployed so I should have used this method
2407 in the first place. These statements will eventually be replaced with some sort
2408 of notification in the browser.
2410 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2411 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2412 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2413 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2414 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2416 2011-09-27 Ben Konrath <ben@bagu.org>
2418 Put tableselector on the right, back to list link on right.
2420 The idea is that the table selector is acting like a label for the
2421 currently displayed table so it should be placed below the document title. This
2422 puts the table title in a similar position to where it is in Glom.
2424 * mockups/details-contacts.html:
2425 * mockups/details-projects.html:
2426 * mockups/listview-contacts.html:
2427 * mockups/listview-projects.html:
2428 * mockups/style.css:
2429 Update mockups to match how the interfaces currently look.
2430 * src/main/webapp/style.css: Swap positions of backlink with the table
2431 selector. Add some space on the left side of the table selector to
2432 line things up with the document title.
2434 2011-09-27 Ben Konrath <ben@bagu.org>
2436 Add field colouring to details view.
2438 This change re-works how field colouring works. The colour formatting
2439 information is now set to the client with the layout information instead of
2440 with the data. This eliminates the need to send the same colour strings for
2441 data in list view column when colour information is set.
2443 In order to set an alternate colour for negative numeric values, the
2444 number is now sent to client and formatted with the GWT NumberFormat class.
2446 This change also fixes:
2448 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2450 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2451 internationalization framework which is needed for client side numeric
2453 * src/main/java/org/glom/web/client/Utils.java: New file for some
2454 client static utility methods.
2455 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2456 the DataItem object to the Field class. Use a utility method to
2457 create the foreignKeyValue string.
2458 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2459 alignment and text colours in the constructor. Add setData(DataItem)
2460 method. Remove setText(String) method.
2461 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2462 colour information to GlomTextCell. Create and use GlomNumberCell for
2463 rendering numbers. Use utility method to get the string for the
2464 primary key of the key provider. Re-work how the horizontal alignment
2466 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2467 formatting to layout information. Methods for converting the libglom
2468 formatting information were moved from DBAccess.
2469 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2470 numeric formatting (it's now done on the client side). Don't set text
2471 colours in DataItem. Move libglom formatting conversion methods to
2473 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2474 getters/setters for text colour information.
2475 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2476 for transferring the libglom NumericFormat information to the client.
2477 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2478 and getters/setters for: GlomNumericFormat, background colour and
2479 foreground colour strings.
2481 2011-09-26 Ben Konrath <ben@bagu.org>
2483 Simplify code that iterates through the LayoutGroup.
2485 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2487 2011-09-26 Ben Konrath <ben@bagu.org>
2489 Accept Eclipse formatting for OnlineGlomServiceAsync.
2491 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2493 2011-09-26 Ben Konrath <ben@bagu.org>
2495 Don't use the ListDBAccess classes to get the primary key layout information.
2497 This was causing a bug where the wrong index for the hidden primary key
2498 was being sent to the client.
2500 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2501 primary key while creating the LayoutGroup DTO. Create a
2502 LayoutItemField DTO for hidden primary keys. Don't use the
2503 RelatedListDBAccess because it was only used for getting the primary
2505 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2506 access modifier from public to protected for getPrimaryKeyField() and
2507 getPrimaryKeyLayoutItemField().
2508 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2509 abstract method getExpectedResultSize() because RelatedListDBAccess
2510 doesn't have enough info to implement it.
2511 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2512 Remove @Override for getExpectedResultSize().
2513 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2514 Remove method getExpectedResultSize().
2516 2011-09-23 Ben Konrath <ben@bagu.org>
2518 Log which layout (list or details) the ignored item is from.
2520 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2522 2011-09-23 Ben Konrath <ben@bagu.org>
2524 Remove annotations that turn off code formatting in DataItem.
2526 * src/main/java/org/glom/web/shared/DataItem.java:
2528 2011-09-23 Ben Konrath <ben@bagu.org>
2530 Rename GlomField to DataItem and update associated methods.
2532 This is a rename-only refactor. No functionality has been added or
2535 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2536 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2537 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2538 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2539 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2540 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2541 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2542 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2544 * src/main/java/org/glom/web/server/database/DBAccess.java:
2545 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2546 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2547 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2548 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2549 * src/main/java/org/glom/web/shared/DataItem.java:
2550 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2551 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2553 2011-09-23 Ben Konrath <ben@bagu.org>
2555 Rename GlomDocument to DocumentInfo and update associated methods.
2557 This is a rename-only refactor. No functionality has been added or
2560 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2561 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2562 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2563 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2564 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2565 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2566 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2568 2011-09-20 Ben Konrath <ben@bagu.org>
2570 Require java-libglom 1.17.3.
2572 This picks up the fix for the seg fault problem with the Scenes table
2573 in the Openismus Film Manager example.
2577 2011-09-20 Ben Konrath <ben@bagu.org>
2579 Change the way sort clause is added for primary key when no sort clause is requested.
2581 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2582 before the sort clause is created. When a sort clause is not requested, the
2583 sort clause is created by finding the primary key in the LayoutFieldVector
2586 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2588 2011-09-20 Ben Konrath <ben@bagu.org>
2590 Log error message if no documents are found in the configured directory.
2592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2593 Extract the glom file extension string to a private static final class
2594 variable (mostly as syntactic sugar). Accept a minor formatting change.
2595 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2596 the example glom.document.directory configuration property to make it
2597 more clear that it can any directory, not just the home directory.
2599 2011-09-18 Ben Konrath <ben@bagu.org>
2601 Add related lists to details view.
2603 The related list table has support for paging and sorting just like the
2604 table in the list view.
2606 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2607 SQL queries for the related list tables.
2608 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2609 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2611 Rename getList methods to getListView and add comments. Remove
2612 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2613 it being unused. Add methods: getDetailsLayoutAndData(),
2614 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2615 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2616 Create the layout and set the data for the fields in one async call
2617 instead of two. Create related lists where appropriate.
2618 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2619 for method name changes in OnlineGlomService.
2620 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2621 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2622 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2624 * src/main/java/org/glom/web/client/ui/ListView.java:
2625 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2626 tableName from setCellTable(). Create a ListViewTable instead of
2628 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2629 represent a data field in the details view.
2630 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2631 from addDetailsCell() to Field class. Keep track of the Fields and
2632 Portals in the details view.
2633 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2634 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2635 and add a method to get it. Add method to set the contents of the
2637 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2638 New class for related list tables. This class has the data provider
2639 for the related list table.
2640 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2641 abstract class which is the base class for the ListViewTable and the
2643 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2644 New class for list view tables. This class has the data provider for
2645 the list view table.
2646 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2647 methods for related list tables. Add more information to the
2648 LayoutItemField and LayoutItemPortal DTOs.
2649 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2650 Remove debugging print statement.
2651 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2652 Remove debugging print statements. Add primary key field to SQL count
2654 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2655 Remove unnecessary LayoutFieldVector parameter from
2656 getResultSizeOfSQLQuery() method.
2657 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2658 New class for related list table database access.
2659 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2660 class that is a wrapper DTO for details view layout and data.
2661 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2662 new 'fromField' string to this DTO.
2663 * src/main/webapp/style.css: Remove bottom margin and override top
2666 2011-09-15 Ben Konrath <ben@bagu.org>
2668 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2670 This sets things up to make it easier to add the data retrieval for
2671 related lists (portals). No user noticeable changes were made with
2674 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2675 class has the code to retrieve the layouts and access the
2676 database using the new database helper classes.
2677 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2678 Most of the functionality has been removed from this class. This
2679 class now represents the public interface for the client side
2680 code. It also deals with configuring the servlet and cleaning
2681 things up when the servlet is stopped.
2682 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2683 of static methods into this utility class.
2684 * src/main/java/org/glom/web/server/database/DBAccess.java:
2685 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2686 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2687 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2688 These classes have the database retrieval code. The class hierarchy
2689 has been setup to make it easy to reuse code for similar
2692 2011-09-06 Ben Konrath <ben@bagu.org>
2694 Create separate classes for list table code and the data provider.
2696 As part of this refactor, I also split up the code a bit to make it
2699 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2700 table code to two new classes (below).
2701 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2702 with code from ListViewImpl.
2703 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2704 New file with code from ListViewImpl.
2706 2011-09-06 Ben Konrath <ben@bagu.org>
2708 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2710 This fixes the LayoutItemPortal DTO to match the libglom layout object
2713 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2715 2011-09-01 Ben Konrath <ben@bagu.org>
2717 Set title of Portals in the Details View.
2719 * pom.xml: Bump required version of java-libglom to 1.17.1.
2720 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2721 widget creation to its own class. Add comments to constructor.
2722 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2723 The code is mostly from the Group class with the title now set.
2724 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2725 title of Portal. Update some comments. Fix some code formatting.
2727 2011-09-01 Ben Konrath <ben@bagu.org>
2729 Remove TODO comment for the flow table column width.
2731 The flow table column width is working correctly and doesn't need to be
2732 changed. See this mailing list post for more info:
2734 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2736 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2738 2011-08-27 Ben Konrath <ben@bagu.org>
2740 Add document title (database name) to top of the browser page.
2742 I added the document title to the TableSelecitonView but that will
2743 change if / when we add a view that doesn't require table selection.
2745 * mockups/details-contacts.html:
2746 * mockups/details-projects.html:
2747 * mockups/listview-contacts.html:
2748 * mockups/listview-projects.html:
2749 * mockups/style.css: Add document title to mockups to keep things
2751 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2752 sizes to account for the document title.
2753 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2754 Set the document title when it has been retrieved from the server.
2755 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2756 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2757 and implement setDocumentTitle(String) method.
2758 * src/main/webapp/style.css: Add ID for document title style.
2760 2011-08-25 Ben Konrath <ben@bagu.org>
2762 Add NavigationType enum to LayoutItemPortal DTO.
2764 This is the start of adding support for Portals to the Details View.
2766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2767 LayoutItem_Portal.navigation_type enum from libglom to
2768 LayoutItemPortal.NavigationType enum.
2769 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2770 NavigationType enum, field for storing the NavigationType and getter
2773 2011-08-25 Ben Konrath <ben@bagu.org>
2775 Implement the flow table layout in the Details View.
2777 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2778 FlowTable to Group to account for the renamed class.
2779 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2780 File. This is a container widget that implements the Glom details view
2781 flow table behaviour.
2782 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2783 org/glom/web/client/ui/FlowTable.java.
2784 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2785 so that the size of the subgroups are a closer match to the size of
2786 the Glom subgroups. This makes the flowtable layout match the layout
2787 in Glom for the Music Collection example file.
2789 2011-08-16 Ben Konrath <ben@bagu.org>
2791 Create container element for LayoutItemPortal in Details View.
2793 This will help me develop the layout for the FlowTable.
2795 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2796 fieldPanel variable to detailsCell.
2798 2011-08-15 Ben Konrath <ben@bagu.org>
2800 Set the height of the data element in the Details View.
2802 I changed the InlineLabels (text in a span element) to Labels (text in
2803 a div element) so that I could set the height of the details-data
2804 elements instead of the details-cell parent elements. This allows the
2805 the details-data element to display the correct height if style is
2806 applied that shows the height.
2808 This change has the added benefit of allowing the order of the labels
2809 and data elements to be changed for right-to-left languages.
2811 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2812 InlineLabels to Labels.
2813 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2814 InlineLabels to Labels. Set the height of the data element.
2815 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2816 multiline text height in the Formatting DTO.
2817 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2818 for multiline height along with getter and setter methods.
2819 * src/main/webapp/style.css: Adjust style to account for the change
2820 from span elements to div elements in the details cell.
2822 2011-08-15 Ben Konrath <ben@bagu.org>
2824 Make the List View appearance match the mockups.
2826 It doesn't match exactly but it's much better than it was.
2828 * mockups/listview-contacts.html: Remove unused css classes.
2829 * mockups/listview-projects.html: Remove unused css classes.
2830 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2831 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2832 for mainPanel instead of VerticalPanel (table). Set style name on
2833 CellTable. Set style name on Details column. Right-align Details
2835 * src/main/webapp/style.css: Adjust properties to match the mockups.
2837 2011-08-12 Ben Konrath <ben@bagu.org>
2839 Add better support for subgroups in the details view.
2841 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2842 changed FlowTable constructor.
2843 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2844 support for subgroups and subgroup-titles.
2845 * src/main/webapp/style.css: Add CSS class for subgroups and
2848 2011-08-12 Ben Konrath <ben@bagu.org>
2850 Return the top level LayoutGroup title.
2852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2854 2011-08-11 Ben Konrath <ben@bagu.org>
2856 Make the TableSelector header match the mockup.
2858 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2859 the layout panel. Properly lineup the table selection header with
2860 the list and details view.
2861 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2862 margin around the details view.
2863 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2864 Rename listBox variable to tableSelector. Set id for the style sheet.
2865 Use a FlowPanel instead of a HorizontalPanel.
2866 * src/main/webapp/style.css: Add properties to make the TableSelector
2867 box match the mockups.
2869 2011-07-13 Ben Konrath <ben@bagu.org>
2871 Update install script for java-libglom version change.
2873 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2876 2011-07-13 Ben Konrath <ben@bagu.org>
2878 Add support sub-group in the details view.
2880 I also removed the code that special-cased the default details view
2883 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2885 I still have to make a proper flowtable.
2887 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2888 Don't special-case default details view layout.
2889 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2890 addLayoutField() as I'm going to use it.
2891 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2892 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2894 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2895 extracted from DetailsViewImpl.GroupPanel. Add support for
2897 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2898 column count when getting the details layout.
2900 2011-07-12 Ben Konrath <ben@bagu.org>
2902 Set browser title with database and table titles.
2904 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2905 Set the browser title when the table changes and when the activity
2907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2908 title when retrieving document info (the GlomDocument object).
2909 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2910 with getter and setter methods. Remove unused convenience constructor.
2911 Use default code formatting.
2913 2011-07-12 Ben Konrath <ben@bagu.org>
2915 Ignore LayoutItemPortals in the details view.
2917 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2920 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2921 LayoutItemPortal layout objects.
2922 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2923 LayoutItemPortal objects when retrieving the details layout.
2924 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2925 file. This is an empty class and just used to get type information for
2928 2011-07-12 Ben Konrath <ben@bagu.org>
2930 Use java-libglom 1.17.0.
2934 2011-07-11 Ben Konrath <ben@bagu.org>
2936 Remove "Table:" label from table selector.
2938 This matches a recent change in the Glom UI.
2940 * mockups/details-contacts.html:
2941 * mockups/details-projects.html:
2942 * mockups/listview-contacts.html:
2943 * mockups/listview-projects.html: Remove the "Table:" label from the
2945 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2947 2011-07-11 Ben Konrath <ben@bagu.org>
2949 Add main groups to the details view.
2951 This makes things look a little nicer in the details view. The next step
2952 is to implement the flowtable.
2954 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2955 resources from the standard gwt css theme. Standard.css is now
2956 included in OnlineGlom.html so that the online glom css rules have
2957 precedence over the gwt theme.
2958 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2959 the whole LayoutGroup to the DetailsView instead of just the titles.
2960 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2961 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2962 details layout with a helper class (GroupPanel). I might extract this
2963 class when I make the full flowtable.
2964 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2965 string as default so I don't have to worry about NPEs when processing
2967 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2968 note beside OnlineGlom.gwt.xml above).
2969 * src/main/webapp/style.css: Add default font-size to body to override
2970 the font-size set by the standard theme. Don't use h2 tags for
2971 group-title. Create new details-cell class.
2973 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2975 ConfiguredDocument: Set the port number too.
2977 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2978 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2979 Glom document. Presumably this worked sometimes so far because there is a
2980 default port number.
2982 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2984 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2986 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2987 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2988 correct, though we should throw an exception too.
2990 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2992 Fix a addDocuemnt typo.
2994 * src/main/java/org/glom/web/shared/Documents.java
2995 (Documents.addDocuemnt): Rename to addDocument().
2996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2997 (OnlineGlomServiceImpl.getDocuments): Adapt.
2999 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3001 Slightly improved log output when connection fails.
3003 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3004 (ConfiguredDocument.setUsernameAndPassword):
3005 We don't know for sure if it' the username/password that's wrong, so
3006 rephrase the message.
3007 Also ouput the exception message, though it's generic in this case.
3009 2011-07-08 Ben Konrath <ben@bagu.org>
3013 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3014 added braces to a one line if statement because the Eclipse formatter
3015 was getting confused.
3017 2011-07-07 Ben Konrath <ben@bagu.org>
3019 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3021 These should really be two separate tasks but I counldn't get things to
3022 work with GWT 2.2.0 and Eclipse 3.7.
3026 * .settings/org.eclipse.jdt.core.prefs:
3027 * .settings/org.eclipse.jdt.ui.prefs:
3028 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3029 * .settings/org.eclipse.m2e.core.prefs:
3030 Add new config files. Update current files. Remove references to the
3031 webtools plugins as we're not using any of the webtools features.
3032 * .gitignore: Add logs directory which is created when running with
3034 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
3035 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
3036 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3038 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3040 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3042 onlineglom.properties: Add explanatory comments.
3044 * src/main/resources/onlineglom.properties: Also change the default user
3045 from ben to someuser, to avoid the risk of people thinking we just
3046 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3048 2011-06-28 Ben Konrath <ben@bagu.org>
3050 Use filename in Log for incorrect passwords.
3052 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3053 getFileName(String) method to get the filename from the URI.
3055 2011-06-28 Ben Konrath <ben@bagu.org>
3057 Add the table name to the URL token for the ListPlace.
3059 This makes things consistent between the DetailsPlace and the
3060 ListPlace. It also allows the the ListPlace to be bookmarked.
3062 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3063 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3064 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3065 Remove getDefaultListLayout(). The default layout is now returned
3066 by the getListLayout() method when the table name is an empty string.
3067 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3068 Add table name field. Change to a new ListPlace when the table
3069 has been changed. Use getListLayout() for getting the default
3071 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3072 Add table name field. Set the correct table name in the list box
3073 when loading from bookmark. This corrects a problem for the
3075 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3076 Move table name to super-class (HasSelectableTable). Move document
3077 and table URL keys to super-class in HasSelectableTable.
3078 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3079 Add table name field. Add Tokenizer class with URL key common to
3080 the subclasses (DetailsPlace and ListPlace).
3081 * src/main/java/org/glom/web/client/place/ListPlace.java:
3082 Add table name. Add code to parse the URL token.
3083 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3084 Update ListPlace construction with empty table name string.
3085 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3086 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3087 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3088 Update ListPlace construction with table name string.
3089 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3090 Change defaultTableName field to tableName to reflect how it's now
3091 used. Update the getter and setter methods.
3093 2011-06-28 Ben Konrath <ben@bagu.org>
3095 Enable the table selector in the DetailsView.
3097 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3098 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3099 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3100 Remove getDefaultDetailsLayout(). The default layout is now returned
3101 by the getDetailsLayout() method when the table name is an empty
3103 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3104 event handler for table change event. Change to using
3105 getDetailsLayout() for the default details layout.
3106 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3108 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3109 when navigating to the details place.
3111 2011-06-27 Ben Konrath <ben@bagu.org>
3113 Use filename based unique document ID in URL and for RPC.
3115 The document ID is the glom document name with spaces (' ') replaced
3116 with pluses ('+') and without the .glom extension.
3118 This change is mostly a string substitution of 'documentTitle' for
3119 'documentID'. The only code change is the addition of a Documents DTO to get the
3120 filename to document title mappings as indicated below.
3122 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3123 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3124 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3125 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3126 Use Documents DTO to create the document links in the document
3128 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3129 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3130 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3131 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3132 * src/main/java/org/glom/web/client/place/ListPlace.java:
3133 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3134 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3135 * src/main/java/org/glom/web/client/ui/ListView.java:
3136 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3137 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3138 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3139 * src/main/java/org/glom/web/server/Log.java:
3140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3141 getDocumentTitles() to getDocuments() and return the Documents DTO.
3142 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3143 transferring the filename to document title mappings.
3145 2011-06-25 Ben Konrath <ben@bagu.org>
3147 Make the authentication popup work again.
3149 This bug was introduced when I extracted ConfiguredDocument to its own class.
3151 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3152 correct success / fail status in setUsernameAndPassword().
3154 2011-06-25 Ben Konrath <ben@bagu.org>
3156 Use filename as unique key for configuring database usernames and passwords.
3158 This replaces the use of the Glom document title which could change
3159 depending on the locale. Thanks to Murray Cumming for pointing out this
3162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3163 * src/main/resources/onlineglom.properties:
3165 2011-06-24 Ben Konrath <ben@bagu.org>
3167 Pass primary key value to DetailsView.
3169 This enables the DetailsView to load the correct data.
3171 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3172 primary key value field and set in constructor. Pass primary key
3173 value to getDetailsData().
3174 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3175 variables for document title and primary key value.
3176 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3177 key value to the DetailsPlace.
3179 2011-06-24 Ben Konrath <ben@bagu.org>
3181 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3183 This allows the primary key to be retrieved by the Details button. This
3184 functionality has not been implemented yet but it's in the works.
3186 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3187 the LayoutGroup result to ListView.setCellTable instead of all of its
3188 fields individually.
3189 * src/main/java/org/glom/web/client/ui/ListView.java:
3190 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3191 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3192 get the primary key for the table.
3193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3194 index of the primary key in the LayoutGroup accounting for hidden
3195 primary keys. Rename getJavaNumberFormat() to
3196 convertToJavaNumberFormat() for consistency. Cleanup / add some
3198 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3199 field for primary key index and a field to indicate whether the
3200 primary key is hidden or not.
3202 2011-06-23 Ben Konrath <ben@bagu.org>
3204 Rename getTableData methods to getListData.
3206 This is a rename refactor for consistency with other methods.
3208 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3209 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3210 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3213 2011-06-23 Ben Konrath <ben@bagu.org>
3215 Extract the ConfiguredDocument innerclass into its own class.
3217 This makes the servlet code more object oriented.
3219 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3220 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3222 new ConfiguredDocument class.
3224 2011-06-21 Ben Konrath <ben@bagu.org>
3226 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3228 This makes things more inline with how libglom works and reduces code
3229 duplication. This refactor lays the groundwork for adding the primary key to
3230 the LayoutGroup object.
3232 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3233 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3235 Change method names to getListLayout and getDefaultListLayout for
3236 consistency. Use LayoutGroup as the DTO for the list layout instead of
3237 ColumnInfo and LayoutListTable.
3238 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3239 new method names along with the LayoutGroup object for transferring the
3241 * src/main/java/org/glom/web/client/ui/ListView.java:
3242 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3243 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3244 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3246 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3247 Replaced with LayoutGroup.
3248 * src/main/java/org/glom/web/share