1 2012-04-17 Murray Cumming <murrayc@murrayc.com>
3 Reports: Allow a second report to be shown.
5 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
6 clear(): Do not remove the HTML widget, which broke the whole layout.
8 2012-04-17 Murray Cumming <murrayc@murrayc.com>
10 Locales drop-down: Show that we use English by default.
12 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
13 fillView(): When we use English, just because that is the default, when
14 no locale is specified, show that in the Locales drop-down instead of
15 just showing the first item.
17 2012-04-17 Murray Cumming <murrayc@murrayc.com>
19 Unselect the Report/Locale/Table combo item when appropriate.
21 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
22 setPlace(): clear reportName if this is not a ReportPlace.
23 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
24 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
25 When the provided name is empty, unselect all items, so that none are
26 indicated. This uses a for loop because I cannot find a single method
29 2012-04-17 Murray Cumming <murrayc@murrayc.com>
31 Report: Give the user a way to get back to the list.
33 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
34 start(), setPlace(): Show the Back To List link on reports, and also
35 interpret selecting the empty report item as back to list.
37 2012-04-17 Murray Cumming <murrayc@murrayc.com>
39 Style: Remove overflow:hidden from searchbox
41 * src/main/webapp/style.css: Because this pushes the Back To Link
42 label/link on to the next row, which is then hidden due to the
43 hard-coded (in ems) height.
45 2012-04-13 Murray Cumming <murrayc@murrayc.com>
47 Really show the selected Report name.
49 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
50 setPlace(): Store the reportName here, if it is that kind of Place.
51 fillView(): Set the selected Report after filling the list of reports.
52 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
53 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
54 null Strings, though we need some way to unselect all ListBox items
57 2012-04-13 Murray Cumming <murrayc@murrayc.com>
59 ReportGenerator: Try to avoid some problems.
61 * src/main/java/org/glom/web/server/ReportGenerator.java
62 addField(): Try to avoid duplicates, and avoid using a null
65 2012-04-13 Murray Cumming <murrayc@murrayc.com>
67 Reports: Use quickFind.
69 * src/main/java/org/glom/web/client/OnlineGlomService.java;
70 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
71 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
72 getReportHTML(): Add a quickFind parameter.
73 * src/main/java/org/glom/web/client/activity/ReportActivity.java
74 start(): Pass the quickFind parameter.
75 * src/main/java/org/glom/web/server/ReportGenerator.java
76 generateReport(): Take a quickFind parameter.
78 2012-04-13 Murray Cumming <murrayc@murrayc.com>
80 ReportPlace: Actually use the report name.
82 * src/main/java/org/glom/web/client/place/ReportPlace.java
83 getPlace(): Do not assign the report name to the quickfind.
85 2012-04-13 Murray Cumming <murrayc@murrayc.com>
87 Show java.library.path when complaining.
89 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
90 init(): When telling us to check java.library.path, show the
93 2012-04-12 Murray Cumming <murrayc@murrayc.com>
95 Adapt to the java-libglom 1.21.8 API.
97 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
98 java-libglom's FieldFormatting is now Formatting.
100 2012-04-12 Murray Cumming <murrayc@murrayc.com>
102 Use the latest java-libglom version.
104 * pom.xml: Use java-libglom 1.21.8.
106 2012-03-15 Murray Cumming <murrayc@murrayc.com>
108 Adapt to the java-libglom 1.21.7 API.
110 * src/main/java/org/glom/web/server/ReportGenerator.java:
111 addToReport(): get_group_secondary_fields() is now
112 get_secondary_fields().
114 2012-03-15 Murray Cumming <murrayc@murrayc.com>
116 Use the latest java-libglom version.
118 * pom.xml: Use java-libglom 1.21.7.
120 2012-03-06 Murray Cumming <murrayc@murrayc.com>
122 ReportGenerator: Do not show nulls.
124 2012-03-06 Murray Cumming <murrayc@murrayc.com>
126 ReportGenerator: Make the title font larger.
128 2012-03-06 Murray Cumming <murrayc@murrayc.com>
130 ReportGenerator: Put field titles inside groups, if there are groups.
132 2012-03-06 Murray Cumming <murrayc@murrayc.com>
134 ReportGenerator: Take the Report itself instead of the name and group.
136 * src/main/java/org/glom/web/server/ConfiguredDocument.java
137 Remove getReportLayoutGroup().
138 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
139 getReportHTML(): Pass the report instead
140 of its name and layout group.
141 * src/main/java/org/glom/web/server/ReportGenerator.java
142 generateReport(): Use the report object to use the title
145 2012-03-06 Murray Cumming <murrayc@murrayc.com>
147 ReportGenerator: Remove designBand parameters.
149 * src/main/java/org/glom/web/server/ReportGenerator.java:
150 Make designBand a class member instead of passing it to all
153 2012-03-06 Murray Cumming <murrayc@murrayc.com>
155 ReportGenerator: Add lines, a bit like in the desktop version.
157 * src/main/java/org/glom/web/server/ReportGenerator.java
158 addToReport(): Use JRDesignLine.
160 2012-03-06 Murray Cumming <murrayc@murrayc.com>
162 ReportGenerator: Correct the title positions and use some bold style.
164 * src/main/java/org/glom/web/server/ReportGenerator.java:
165 Break the code up into reusable functions, correct the placement of
166 titles, and use normal/bold styles as in the reports in the desktop
169 2012-03-06 Murray Cumming <murrayc@murrayc.com>
171 ReportGenerator: Add a header band to show the field titles.
173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
174 getReportHTML(): Pass the localeId to the ReportGenerator
176 * src/main/java/org/glom/web/server/ReportGenerator.java
177 constructor: Take the localeID so we can get translated field
179 generateReport(), addToReport(), addFieldToBand(): Add field
180 titles in a column header band.
182 2012-03-05 Murray Cumming <murrayc@murrayc.com>
184 Reports drop-down list: Some improvement.
186 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
187 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
188 Adedd setSelectedReport(),
189 setReportList(): Add a blank line so that the user can select the
191 * src/main/java/org/glom/web/client/activity/ReportActivity.java
192 start(): Show the current report by calling setSelectedReport().
193 This does not seem to work yet.
195 2012-03-05 Murray Cumming <murrayc@murrayc.com>
197 DetailsActivity, ListActivity: Move some variables into a base class.
199 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
200 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
201 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
202 the clientFactory, documentID, tableName and authenticationPopup into
203 a base class, to avoid duplication.
205 2012-03-05 Murray Cumming <murrayc@murrayc.com>
207 Translate the Reports label.
209 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
210 Get the "Reports" label string from the constants.
211 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
212 perties: Add Reports to the constants.
214 2012-03-03 Ben Konrath <ben@bagu.org>
216 Display date and time in details view.
218 https://bugzilla.gnome.org/show_bug.cgi?id=671257
220 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
222 2012-03-05 Murray Cumming <murrayc@murrayc.com>
224 Require the latest java-libglom.
226 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
228 2012-03-05 Murray Cumming <murrayc@murrayc.com>
230 Reports: Implement grouping.
232 * src/main/java/org/glom/web/server/ReportGenerator.java:
233 Handle LayoutItem_GroupBy items and try to do the right thing
234 with JRDesignGroup. It seems to work.
236 2012-03-04 Murray Cumming <murrayc@murrayc.com>
238 Actually show some data with JasperReports.
240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
241 getReportHTML(): Move most code into a ReportGenerator class.
242 * src/main/java/org/glom/web/server/ReportGenerator.java:
243 Recurse into sub-groups, adding fields to the JasperDesign's details
244 band. Note that we must set an arbitrary width and height, or it just
245 will not show any data.
247 2012-03-04 Murray Cumming <murrayc@murrayc.com>
249 Reports Chooser: Show the titles, not the names.
251 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
252 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
253 and the names as the values.
254 * src/main/java/org/glom/web/server/ConfiguredDocument.java
255 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
256 group now that we provide the report name, so it should always
259 2012-03-04 Murray Cumming <murrayc@murrayc.com>
261 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
263 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
264 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
265 an empty quickfind string. I also corrected libglom to create only
266 empty where clauses for empty quickfind strings, but this avoids the
269 2012-02-24 Ben Konrath <ben@bagu.org>
271 Improve the tabs in the Notebook widget.
275 2012-02-15 Murray Cumming <murrayc@murrayc.com>
277 Depend on jasperreports.
279 * pom.xml: Add the dependency. My plan is to use this on the
282 2012-01-31 Murray Cumming <murrayc@murrayc.com>
284 Implement navigation to report places.
286 * src/main/java/org/glom/web/client/activity/ReportActivity.java
287 start(): Do not bother to handle all events here.
288 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
289 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
290 Added getSelectedReport().
291 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
292 .java: start(): When handling a change to the reports chooser,
293 call getSelectedReport() and goTo() its ReportPlace.
294 * src/main/java/org/glom/web/client/ui/ReportView.java
295 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
296 Added setReportHTML() which puts the html in a gwt HTML widget.
297 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
298 getReportHTML(): Return "TODO" just to show that this works.
300 2012-01-31 Murray Cumming <murrayc@murrayc.com>
302 Make ReportPlace usable.
304 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
306 * src/main/java/org/glom/web/client/place/ReportPlace.java:
307 Correct the @prefix annotation.
309 2012-01-31 Murray Cumming <murrayc@murrayc.com>
311 OnlineGlomService: Return report HTML rather than the LayoutGroup.
313 * src/main/java/org/glom/web/client/OnlineGlomService.java:
314 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
315 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
316 Change getReportLayout() to getReportHMTL() because we will not need to
317 parse or render the report layout on the client side.
318 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
319 getReportLayout(): Return the libglom LayoutGroup type because we will
320 not need to convert to a shared type, because this will not be used on
322 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
325 Note that there is still no implementation for this.
327 2012-01-30 Murray Cumming <murrayc@murrayc.com>
329 Translations: Try to translate the strings.
331 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
332 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
333 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
334 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
335 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
336 Take the Open translation from GTK+'s .po files.
337 Take the Details translation from Glom's po files.
338 I have added the other strings to Glom so we can get translations that way:
339 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
341 2012-01-27 Murray Cumming <murrayc@murrayc.com>
343 Add a (empty) Report Place, View, and Activity.
345 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
347 * src/main/java/org/glom/web/client/place/HasTablePlace.java
348 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
349 this into a superclass:
350 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
351 and also use it as the base of this new ReportPlace:
352 * src/main/java/org/glom/web/client/place/ReportPlace.java
354 * src/main/java/org/glom/web/client/ui/ReportView.java
355 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
356 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
357 Add these, containing mostly boiler-plate for now.
359 * src/main/java/org/glom/web/client/OnlineGlomService.java
360 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
361 * src/main/java/org/glom/web/server/ConfiguredDocument.java
362 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
363 Add API to get the LayoutGroup for the report.
365 2012-01-27 Murray Cumming <murrayc@murrayc.com>
367 TableSelectionViewImpl: Put the search label and entry in a div.
369 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
370 Put the search widgets in a FlowTable so that the CSS can be used to
371 style them while keeping them together.
372 * src/main/webapp/style.css: Mention the new div.
374 2012-01-27 Murray Cumming <murrayc@murrayc.com>
376 Translate more strings in more locales.
378 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
379 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
380 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
381 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
382 Translate the "Details" and "Open" string too.
384 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
385 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
386 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
387 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
388 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
389 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
390 Add these new locales as placeholders though they currently contain English.
392 2012-01-27 Murray Cumming <murrayc@murrayc.com>
394 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
396 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
397 Check the ConfiguredDocument* for null before using it.
399 2012-01-26 Murray Cumming <murrayc@murrayc.com>
401 Tell Eclipse about the generated java files.
403 * .classpath: This lets it find OnlineGlomConstants.java.
404 It would be nice if Eclipse just used the maven build files.
406 2012-01-26 Murray Cumming <murrayc@murrayc.com>
408 Prevent a crash when no locale is specified in the URL.
410 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
411 Avoid returning a null string, obtained from
412 Window.Location.getParameter(). This caused a crash when it was
413 later passed to libglom's API.
414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
415 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
416 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
417 guard against future null strings.
419 2012-01-26 Murray Cumming <murrayc@murrayc.com>
421 Use the ?locale= query param instead of the &lang= token param.
423 * src/main/java/org/glom/web/client/place/ListPlace.java
424 * src/main/java/org/glom/web/client/place/DetailsPlace.java
425 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
426 Remove the lang token key and value.
428 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
429 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
430 When the user selects a different locale from the chooser, use
431 Window.Location.assign() to change the URL, which then causes a reload.
433 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
434 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
435 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
436 * src/main/java/org/glom/web/client/activity/ListActivity.java
437 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
438 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
439 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
440 * src/main/java/org/glom/web/client/ui/ListView.java:
441 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
443 Remove localeID member variables and method/constructor parameters, instead
444 using Utils.getCurrentLocaleID() when we need a localID to pass to
447 2012-01-26 Murray Cumming <murrayc@murrayc.com>
449 Internationalize the UI strings.
451 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
452 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
453 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
454 because it is unused. Messages are apparently strings that can have
455 parameters, but we do not need that yet, so Contants will be enough for now.
456 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
457 to say that we support the en and de locales.
458 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
459 The original English strings.
460 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
461 Some German translations of the English strings.
462 The i18n goal then uses the .properties file to generate an
463 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
464 returns an implementation that returns the translated strings.
465 The documentation suggests putting these in src/java/*/client/, but it seems
466 best to put it in src/resources/*/client/.
467 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
468 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
469 instead of hard-coding them.
470 Note that we cannot import OnlineGlomConstants because it does not exist yet,
471 but that does not seem to stop the build, though it confuses Eclipse.
473 You can see the translated string by adding ?locale=de to the URL, like so:
474 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
476 2012-01-24 Murray Cumming <murrayc@murrayc.com>
478 Improve null/empty String checks.
480 * pom.xml: Add a dependency on commons-lang, to use
481 org.apache.commons.lang.StringUtils.
482 * src/main/java/org/glom/web/server/ConfiguredDocument.java
483 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
484 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
485 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
486 Use StringUtils.isEmpty().
488 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
489 StringUtils class with a static isEmpty() function because we
490 cannot use org.apache.commons.lang.StringUtils in client-side
491 GWT code because it (apparently) cannot be compiled to javascript.
492 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
493 * src/main/java/org/glom/web/client/activity/ListActivity.java
494 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
495 * src/main/java/org/glom/web/client/place/DetailsPlace.java
496 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
497 * src/main/java/org/glom/web/client/place/ListPlace.java
498 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
499 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
500 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
501 * src/main/java/org/glom/web/client/ui/details/Group.java
502 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
503 our StringUtils.isEmpty() function.
505 2012-01-24 Murray Cumming <murrayc@murrayc.com>
507 Update to the latest java-libglom API.
509 * pom.xml: Require java-libglom 1.21.4.
510 * src/main/java/org/glom/web/server/ConfiguredDocument.java
511 getDocumentInfo(), getListViewLayoutGroup():
512 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
514 * src/main/java/org/glom/web/server/database/DBAccess.java
515 getFieldsToShowForSQLQueryAddGroup(),
516 getPrimaryKeyLayoutItemField(): Replace get_database_title()
517 with either get_database_title_original() or
518 get_database_title(localeID).
520 2012-01-24 Murray Cumming <murrayc@murrayc.com>
522 ConfiguredDocument: Avoid a null pointer exception.
524 * src/main/java/org/glom/web/server/ConfiguredDocument.java
525 Initialize localeID to "" to avoid returning a null String which
526 causes a crash in java-libglom's swing-generated code.
528 2012-01-23 Murray Cumming <murrayc@murrayc.com>
530 Some simple renaming.
532 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
533 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
534 for localeChooser. This seems more appropriate and is less ambiguous
535 particularly in the .css file.
537 2012-01-23 Murray Cumming <murrayc@murrayc.com>
539 ConfiguredDocument: Rename the localedID private member variable.
541 2012-01-23 Murray Cumming <murrayc@murrayc.com>
543 Adapt to the latest java-libglom API from git master.
545 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
546 libglom now uses only Vector instead of List, which uses add() instead of
549 2012-01-23 Murray Cumming <murrayc@murrayc.com>
551 Add and fill a Reports drop-down list box.
553 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
555 * src/main/java/org/glom/web/client/OnlineGlomService.java:
556 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
557 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
558 Added getReports(document, table, localeID), calling
559 ConfiguredDocument.getReports().
560 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
561 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
562 Added setReportsList() and a list widget.
563 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
564 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
566 2012-01-22 Murray Cumming <murrayc@murrayc.com>
568 ConfiguredDocument: Rename the localedID private member variable.
570 2012-01-20 Murray Cumming <murrayc@murrayc.com>
572 Build a source tarball with mvn assembly:single
574 * assembly.xml: Add this file.
575 * pom.xml: Use the maven-assembly-plugin and tell it to use
576 our assembly.xml file.
578 2012-01-19 Murray Cumming <murrayc@murrayc.com>
580 OnlineGlomServiceImpl: Get .glom files recursively.
582 * pom.xml: Depend on commons-io from org.apache.commons.
583 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
584 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
585 files recursively, and with the easier filter for the extension.
586 Use org.apache.commons.io.FilenameUtils.removeExtension() to
587 simplify that code too.
589 2012-01-19 Murray Cumming <murrayc@murrayc.com>
591 README: Mention that you must install java-libglom packages separately.
593 But then it works, because java-libglom is now in the central maven
596 2012-01-18 Murray Cumming <murrayc@murrayc.com>
598 locales drop-down: Show the correct selected locale when the URL changes.
600 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
601 .java: setPlace(): Move some code into fillView().
603 2012-01-18 Murray Cumming <murrayc@murrayc.com>
605 locales drop-down: Do not lose the primary key.
607 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
608 start(): onLocaleChange(): Pass the current primary key value,
609 instead of an empty value.
611 2012-01-18 Murray Cumming <murrayc@murrayc.com>
613 locales drop-down: Do not lose the drop-down selection.
615 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
616 .java (TableSelectionActivity.fillView): Set the selected locale
617 after changing the drop-down items (though we do not really need
618 to change them just because the locale changes.)
620 2012-01-18 Murray Cumming <murrayc@murrayc.com>
622 locales drop-down: Change the tables list when this changes.
624 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
625 .java: TableSelectionActivity.start(): Move the async table titles
626 retrieval into a private fillView() method and also call this when
627 the chosen locale changes.
628 Note that the document title is not actually translatable yet, but
629 that is a problem that I should fix soon in libglom.
631 2012-01-18 Murray Cumming <murrayc@murrayc.com>
633 Improve the placement of the locales drop-down.
635 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
636 Put the title and locales drop-down in a div (gwt.FlowTable).
637 * src/main/webapp/style.css: Add magic css properties to make this work.
638 Also remove the left margin from the title so that it lines up with the
641 2012-01-18 Murray Cumming <murrayc@murrayc.com>
643 locales selector: Show human-readable locale titles.
645 * src/main/java/org/glom/web/server/ConfiguredDocument.java
646 getDocumentInfo(): Use java.util.Locale to show a real title of
647 each locale, in the locale's own language.
649 2012-01-17 Murray Cumming <murrayc@murrayc.com>
651 Add a language/locale selector drop-down.
653 * src/main/java/org/glom/web/shared/DocumentInfo.java:
654 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
655 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
656 getDocumentInfo(): Store the available Locales in the DocumentInfo.
657 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
658 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
659 Add a ListBox to show the available locales. Add getLocaleSelector(),
660 setLocaleList(), getSelectedLocale(), setSelectedLocale().
661 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
662 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
663 java: Add these classes.
664 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
665 start(): Fill the locales ListBox. Handle its change event, firing a
667 setPlace(): Show the selected locale as specified by the URL token.
668 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
669 * src/main/java/org/glom/web/client/activity/ListActivity.java:
670 Handle LocaleChangeEvent, going to a new *Place with that locale.
672 The placement of the ListBox is not pretty, and it currently uses the ID
673 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
677 2012-01-17 Murray Cumming <murrayc@murrayc.com>
679 Search box: Show the search text from the URL token.
681 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
682 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
683 Add setQuickFindText().
684 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
685 .java: setPlace(): Store the queryText if the place is a ListPlace,
686 and call TableSelectionView.setQuickFindText().
688 2012-01-17 Murray Cumming <murrayc@murrayc.com>
690 Allow use of translations via, for instance, &lang=de in the URL.
692 * pom.xml: Use the unstable java-libglom 1.21 version.
694 * src/main/java/org/glom/web/client/OnlineGlomService.java:
695 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
697 init(): Instead of calling TranslatableItem.set_current_locale()
698 (now removed), call ConfiguredDocument.setDefaultLocaleID().
699 However, this is only for default locales, which are not needed to
700 change the locale in the URL.
701 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
702 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
703 getSortedRelatedListData(): Add a localeID parameter, so we can get the
704 layout for a particular locale.
705 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
706 Add get/setDefaultLocaleID().
707 getDocumentInfo(), getListViewData(), getRelatedListData(),
708 getDetailsLayoutGroup(), getListViewLayoutGroup(),
709 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
710 localeID parameter, so we can get the layout for a particular locale.
712 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
713 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
714 * src/main/java/org/glom/web/client/place/ListPlace.java:
715 Parse and construct a lang parameter too.
717 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
718 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
719 passed to subsequent methods and constructors.
720 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
721 * src/main/java/org/glom/web/client/activity/ListActivity.java:
722 Store the localeID from the *Place and pass it to other constructors
723 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
725 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
726 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
727 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
728 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
729 * src/main/java/org/glom/web/client/ui/ListView.java:
730 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
731 Take localeID parameters and pass them to subsequent constructors and
732 methods, so that the layout is always retrieved for that locale.
734 This is rather repetitive.
736 Note that "" means the original (default) locale of the Glom document,
737 which is usually English.
739 2012-01-17 Murray Cumming <murrayc@murrayc.com>
741 Documents: Remove final keyword to fix startup configuration.
743 * src/main/java/org/glom/web/shared/Documents.java: Remove the
744 final keywords on the private member variables because that breaks
745 the startup, apparently (there are warnings) because it stops them
746 from being serialized. I added these in the previous commit.
748 2012-01-13 Murray Cumming <murrayc@murrayc.com>
750 Documents: Add some final keywords.
752 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
755 2012-01-13 Murray Cumming <murrayc@murrayc.com>
757 OnlineGlomServiceImpl: Add to overview comments.
759 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
760 Note that this is where all the document are loaded. They are not
761 loaded freshly for each page.
763 2012-01-12 Murray Cumming <murrayc@murrayc.com>
767 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
768 Add a TextBox for the text of a quick find.
769 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
771 setBackLink(): Add a String quickFind parameter.
772 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
773 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
774 to the base interface, because that is how TableSelectionViewImpl is used.
775 * src/main/webapp/style.css: Add style for the search box and its label.
777 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
778 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
779 Add these files, based on the existing TableChangeEvent and
780 TableChangeEventHandlers.
781 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
782 start(): Handle QuickFindChangeEvent, passing its quickFind text to
783 a ListPlace() that the user should be taken to.
784 * src/main/java/org/glom/web/client/activity/ListActivity.java
785 start(): Handle it here too and adapt the TableChangeEvent handler to
786 pass the extra "" quickFind parameter to ListPlace.
787 * src/main/java/org/glom/web/client/place/ListPlace.java:
788 Constructor: Take an extra String quickFind parameter and store it,
789 returning it from a new getQuickFind() method.
790 getToken(): Put the quickFind text in the URL token.
791 getPlace(): Parse the quickFind text from the URL token.
792 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
793 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
794 ListPlace constructor.
795 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
796 .java: start(): Add a Change handler for the TableSelectionView's
797 TextBox (via its base HasChangeHandlers interface), firing the new
798 QuickFindChangeEvent.
799 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
800 pass the extra "" quickFind parameter.
802 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
803 setCellTable(): Add a String quickFind parameter and pass it to
804 the ListViewTable() constructor.
805 * src/main/java/org/glom/web/client/ui/ListView.java: Change
806 setCellTable() in the base interface, because that is how ListViewImpl
809 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
810 Add a String quickFind member variable.
811 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
812 Constructor: Add a String quickFind parameter, storing it in the
813 base ListTable's member variable.
814 onRangeChanged(): Pass quickFind to the
815 OnlineGlomServiceAsync.getSortedListViewData() and
816 OnlineGlomServiceAsync.getListViewData() methods.
818 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
819 getListViewData(), getSortedListViewData(): Add a String quickFind
820 parameter, passing it to ConfiguredDocument.getListViewData().
821 * src/main/java/org/glom/web/client/OnlineGlomService.java:
822 Change getListViewData(), getSortedListViewData() in the base interface,
823 because that is how OnlineGlomServiceImpl is used, via this:
824 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
825 Change getListViewData(), getSortedListViewData() here too.
826 This class can apparently be used to asynchronously call methods on
827 OnlineGlomService, and GWT seems to implement that after recognizing
828 just the *Async name convention and the extra AsyncCallback parameters.
830 * src/main/java/org/glom/web/server/ConfiguredDocument.java
831 getListViewData(): Add a String quickFind parameter, and pass it to
832 ListViewDBAccess.getData().
833 * src/main/java/org/glom/web/server/database/ListDBAccess.java
834 getListData(): Add a String quickFind parameter and pass it to
836 getSelectQuery(): Add a String quickFind parameter.
837 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
838 getSelectQuery(): Add a String quickFind parameter and use it with
839 Glom.get_find_where_clause_quick() to pass a where_clause to
840 Glom.build_sql_select_with_where_clause(), to actually filter the
842 getData(): Add a String quickFind parameter, passing it to getListData().
843 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
844 va: getData(): Pass an empty string to getListData() for the
847 2012-01-12 Murray Cumming <murrayc@murrayc.com>
849 ListTable: Minor change.
851 * src/main/java/org/glom/web/client/ui/list/ListTable.java
852 createCellTable(): Make this protected instead of public.
854 2012-01-12 Murray Cumming <murrayc@murrayc.com>
856 Many files: Use final for the parameters and use the @override attribute.
858 2012-01-22 Ben Konrath <ben@bagu.org>
860 Add anchor links for single line text that starts with http, ftp and www.
864 2012-01-22 Ben Konrath <ben@bagu.org>
866 Add ellipsis to single line text in details view.
870 2012-01-04 Murray Cumming <murrayc@murrayc.com>
872 Remove all javadoc author tags.
874 Because they are awkward and meaningless when many people touch
876 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
878 2012-01-04 Murray Cumming <murrayc@murrayc.com>
880 Revert the COPYING.LESSER to COPYING rename.
882 Apparently both should be there if it is LGPL.
884 2012-01-03 Murray Cumming <murrayc@murrayc.com>
886 *View: Remove unused imports.
888 * src/main/java/org/glom/web/client/ui/DetailsView.java:
889 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
890 * src/main/java/org/glom/web/client/ui/ListView.java:
891 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
892 Remove unused imports, as suggested by Eclipse.
894 2012-01-02 Murray Cumming <murrayc@murrayc.com>
896 Move the *View::Presenter types, and some API into one base View.
898 * src/main/java/org/glom/web/client/ui/DetailsView.java:
899 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
900 * src/main/java/org/glom/web/client/ui/ListView.java:
901 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
902 Presenter, setPresenter() and clear() into a shared base interface,
903 to avoid the unnecessary duplicate Presenter types and to more clearly
904 show how the *Views share the same structure, even if they are not
905 used polymorphically.
907 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
908 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
910 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
911 * src/main/java/org/glom/web/client/activity/ListActivity.java:
912 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
914 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
917 Feel free to revert this if there is a good reason for the duplicate
920 2012-01-02 Murray Cumming <murrayc@murrayc.com>
922 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
924 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
925 a class member instead of a local variable in the method.
926 This lets us use it to get the view instances, for use in tests.
927 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
928 beforeOnlineGlom(): Test some more details of the initial view.
929 Again, this is not very useful.
931 To really test gwt-glom we will need to start a local postgresql
932 instance with local data, like the Glom tests in C++.
934 2012-01-02 Murray Cumming <murrayc@murrayc.com>
936 pom.xml: Mention the LGPL license.
938 * pom.xml: Add a licenses section.
939 * COPYING.LESSER: Move this to COPYING, which
940 previously contained the GPL. But gwt-glom is all LGPL.
942 2012-01-02 Murray Cumming <murrayc@murrayc.com>
944 Add project information to README and pom.xml.
946 * README: Add a brief description and mention some mvn
948 * pom.xml: This extra information shows up in mvn site
951 2011-01-02 Murray Cumming <murrayc@murrayc.com>
953 Use the latest java-libglom version.
955 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
957 2012-01-01 Murray Cumming <murrayc@murrayc.com>
959 GwtTestOnlineGlom: Test a little more.
961 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
962 protected rather than private, as suggested by the gwt-test-utils
964 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
965 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
966 Test the initial visibility of the panels.
968 However, this is not a very useful test.
969 And I wonder how we should generally test using this idea for an
970 activity/places app like ours where the real changes happen implicitly
971 based on the history token/URL.
973 2012-01-01 Murray Cumming <murrayc@murrayc.com>
975 Slight modification to *Mapper comments.
977 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
979 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
981 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
983 Remove comments mentioning GIN because they are just copied from
984 the example code and are apparently not helpful:
985 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
986 Also change the mention of a class that is only in the example code.
988 2012-01-01 Murray Cumming <murrayc@murrayc.com>
990 GwtTestOnlineGlom test: Minor changes.
992 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
993 Avoid the long qualified class name and modify the comment
994 because it is now obvious to me that the mocked class is the only
995 custom one created via GWT.create().
997 2012-01-01 Murray Cumming <murrayc@murrayc.com>
999 Tests: Added the beginnings of a test using gwt-test-utils.
1001 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1002 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1003 which tells gwt-test-utils what class will be tested.
1004 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1005 Add a simple (but empty) test case. One class, used by the OnlineGlom
1006 class, is mocked so that it can be created. However, I am not sure
1007 why only this class needs to be mocked.
1009 Note that mockito seems more popular, and clearer, than easymock,
1010 but I have not got that working yet. It might be a matter of the
1013 This test is run during mvn integration-test.
1015 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1017 Tests: Use junit4-style syntax instead of junit3-style.
1019 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1020 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1021 * src/test/java/org/glom/web/shared/DataItemTest.java:
1022 Use the @Test annotation rather than relying on the test*() prefix.
1023 Also no longer implement TestCase, to avoid triggering support for
1024 the junit3-way, which stops the annotations from working.
1025 Change the imports from import junit.framework.* to
1026 import org.junit.*, which is apparently the new way.
1028 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1030 Added a test for ListPlace token parsing and creation.
1032 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1033 This is much the same as DetailsPlaceTest.
1035 I wonder how we could test the other parts of the *Place API.
1037 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1039 DetailsPlace test: Also test getToken() and recreation via getPlace().
1041 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1042 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1043 recreate it, testing the recreated DetailsPlace for the same parameter
1046 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1048 Use the surefire-report plugin.
1050 * pom.xml: This generates a HTML report about the tests in
1051 target/site/surefire-report.html
1052 when you do mvn surefire-report:report. It seems to be popular/normal.
1054 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1056 Added a test for DetailsPlace.
1058 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1059 Test the getPlace() token parsing.
1061 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1063 Added a first unit test.
1065 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1066 * src/test/java/org/glom/web/shared/DataItemTest.java:
1067 This is a silly test but it is just to get things started. Note that
1068 maven/junit finds the test because it looks in src/test by default.
1070 2011-12-22 Ben Konrath <ben@bagu.org>
1072 Change charsetName to "UTF-8" when replacing line breaks.
1074 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1075 that work in Java (such as "UTF8") will not work when compiled to
1078 This fixes a problem with multi-line details view fields that have hard
1079 line breaks. The "License Text" field on this page demonstrates the
1082 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1084 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1086 2011-12-22 Ben Konrath <ben@bagu.org>
1088 Fix another bug with related list navigation.
1090 I've tested all the navigation buttons in all of the related lists
1091 so things should be good now.
1093 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1095 2011-12-22 Ben Konrath <ben@bagu.org>
1097 Fix a crasher when refreshing the list view with the default table.
1099 This crash will also happen when loading the list view with the default
1100 table from a link or bookmark.
1102 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1103 to the main document selection page when the document id hasn't been
1105 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1106 the main document selection page when the document id hasn't been
1108 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1109 values for the details place when the document id hasn't been set.
1110 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1111 values for the list place when the document id hasn't been set.
1113 2011-12-21 Ben Konrath <ben@bagu.org>
1115 Protect against NPE when glom.document.locale is not in config.
1117 This patch protects against an NPE when glom.document.locale is not in
1118 the config file. This NPE will also happen if glom.document.locale is
1121 The patch also updates the error message to display the class name when
1122 the getMessage() returns null. This was happening when the NPE was
1123 thrown and I had "Configuration Error: null". If an NPE is encountered
1124 with this patch, "Configuration Error: NullPointerException " will be
1127 This commit closes this bug:
1129 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1133 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1135 Rename onlineglom.properties to onlineglom.properties.sample.
1137 * src/main/resources/onlineglom.properties: Rename to:
1138 * src/main/resources/onlineglom.properties.sample:
1139 * src/main/resources/README: And add this file explaining that people
1140 should rename it back when deploying.
1142 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1144 Allow choosing the translation in the .properties file.
1146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1147 init(): Read a glom.document.locale value from the configuration file
1148 and call Glom's TransatableItem::set_current_locale() method.
1149 * src/main/resources/onlineglom.properties: Add a commented-out
1150 example of this new setting.
1152 It would be better to add &lang=de_DE to the URL, but the current
1153 libglom API does not allow us to do this easily. I am working on that.
1155 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1157 Avoid a crash in parsing of token parameters.
1159 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1160 ava: getTokenParams(): Do not crash if a parameter has a key but no
1161 value, and ignore parameters with neither.
1163 2011-12-17 Murray Cumming <murrayc@murayc.com>
1165 History token building/handling: Improve use of token parameters.
1167 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1168 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1169 and buildParamsToken(HashMap), for use by derived classes.
1170 Make the separator private because it is no longer be needed.
1171 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1172 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1173 instead of manual string concatenation.
1174 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1175 of hardcoded indices and awkward splitting code.
1176 * src/main/java/org/glom/web/client/place/ListPlace.java
1177 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1178 instead of manual string concatenation.
1179 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1180 of hardcoded indices and awkward splitting code.
1181 This should fix bug #666420
1183 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1185 Fix a Navgiation->Navigation typo in the code.
1187 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1188 Rename processNavgiation() to processNavigation().
1190 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1192 Fix a seperator->separator typo in the code.
1194 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1195 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1196 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1199 2011-12-15 Ben Konrath <ben@bagu.org>
1201 Cleanup some comments.
1203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1205 2011-12-14 Ben Konrath <ben@bagu.org>
1207 Replace \n with <br/> for multiline text in the details view.
1209 Vertical scrollbars are added when needed as well.
1211 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1213 2011-12-14 Ben Konrath <ben@bagu.org>
1215 Specify the font for document selection links.
1217 * src/main/webapp/style.css:
1219 2011-12-14 Ben Konrath <ben@bagu.org>
1221 Fix bouncy CellTable while paging.
1223 This doesn't currently work with related list tables in unselected
1226 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1228 2011-12-14 Ben Konrath <ben@bagu.org>
1230 Revamp the appearance of the document selection page.
1232 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1233 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1234 * src/main/webapp/style.css:
1236 2011-12-13 Ben Konrath <ben@bagu.org>
1238 Set navigation button column to the smallest size possible.
1240 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1242 2011-12-13 Ben Konrath <ben@bagu.org>
1244 Change OpenButton nomenclature to NavigationButton.
1246 Using NavigtionButton makes things more generic. Classes, methods and
1247 variables have been changed.
1249 This is a rename-only refactor.
1251 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1252 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1253 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1254 Renamed from OpenButtonCell.
1255 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1256 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1257 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1259 2011-12-12 Ben Konrath <ben@bagu.org>
1261 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1263 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1264 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1265 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1266 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1268 2011-12-12 Ben Konrath <ben@bagu.org>
1270 Update variable names and comments.
1272 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1273 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1275 2011-12-12 Ben Konrath <ben@bagu.org>
1277 Properly initialize numNonEmptyRows variable to zero.
1279 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1280 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1282 2011-12-05 Ben Konrath <ben@bagu.org>
1284 Add latest mockup with HTML tables.
1286 Features of this mockup:
1288 -> HTML table for flowtable
1289 -> HTML table for flowtable column
1290 -> Example of how related lists would look
1291 -> Not using text entries for data items
1293 The current version of Online Glom doesn't use HTML tables for the
1296 This mockup has been sent to the glom-devel mailing list but it's good
1297 to have it here as well.
1299 * mockups/details-view-html-tables.html:
1301 2011-12-05 Ben Konrath <ben@bagu.org>
1303 Remove unnecessary getPrimaryKeyField() method.
1305 getPrimaryKeyFieldForTable(String) has been renamed to
1306 getPrimaryKeyField(String).
1308 * src/main/java/org/glom/web/server/database/DBAccess.java:
1309 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1310 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1312 2011-12-05 Ben Konrath <ben@bagu.org>
1314 Add string representation of TypedDataItem value to conversion error message.
1316 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1317 message was extracted into its own method to avoid duplication.
1319 2011-12-05 Ben Konrath <ben@bagu.org>
1321 Add type checking to navigation primary key value creation.
1323 Create navigation primary key only if the expected type from the Glom
1324 document matches the type returned by the SQL query.
1326 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1328 2011-12-05 Ben Konrath <ben@bagu.org>
1330 Rename a couple of variables in RelatedListNavigation.
1332 This is a rename-only refactor.
1334 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1336 2011-12-05 Ben Konrath <ben@bagu.org>
1338 Move getListLayoutGroup() into getListViewLayoutGroup().
1340 This removes getListLayoutGroup(). It was only being called by
1341 getListViewLayoutGroup().
1343 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1345 2011-12-05 Ben Konrath <ben@bagu.org>
1347 Remove check for LayoutItem_Portal in list table method.
1349 This check is no longer necessary because the method isn't being used
1350 to create the LayoutItemPortal DTO.
1352 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1354 2011-12-05 Ben Konrath <ben@bagu.org>
1356 Properly support related list navigation.
1358 Navigation from the "Repository Analyzer -> Package Scans ->
1359 Dependencies" related table wasn't working because the primary key for
1360 related tables wasn't being set properly. This commit fixes the
1363 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1364 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1365 doesn't set the primary key properly for related list tables.
1366 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1367 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1368 useful for getting the primary key for list view tables and for related
1370 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1371 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1372 Move code to set the primary key for the table from the abstract
1373 ListDBAccess class to ListViewDBAccess as it's only correct for list
1375 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1376 Properly add primary key to related list tables.
1378 2011-12-02 Ben Konrath <ben@bagu.org>
1380 Properly set the horizontal alignment of fields.
1382 This fix is for both the list tables and the details view.
1384 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1385 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1386 to set the horizontal alignment of fields.
1388 2011-12-02 Ben Konrath <ben@bagu.org>
1390 Display currency codes in the details view.
1392 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1394 2011-12-02 Ben Konrath <ben@bagu.org>
1396 Avoid duplicate JNI call.
1398 JNI is not as efficient as pure Java and this is an easy (and small)
1401 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1402 Use previously retrieved value for whereClauseToTableName instead of
1405 2011-12-02 Ben Konrath <ben@bagu.org>
1407 Rename a couple of variables in RelatedListNavigation.
1409 This is a rename-only refactor.
1411 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1413 2011-12-02 Ben Konrath <ben@bagu.org>
1415 Indicate clearly that a mismatched primary key type is a bug.
1417 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1418 warning to error. Add 'This is a bug.' to message.
1420 2011-12-02 Ben Konrath <ben@bagu.org>
1422 Update / fix some comments.
1424 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1426 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1428 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1429 Fix comments. Add some TODOs.
1431 2011-12-02 Ben Konrath <ben@bagu.org>
1433 Enable navigation to details view with string primary key from related list.
1435 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1436 Create a text primary key value when return type of result is
1437 java.sql.Types.VARCHAR.
1439 2011-12-02 Ben Konrath <ben@bagu.org>
1441 Use checkboxes for booleans in the details view.
1443 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1445 2011-12-01 Ben Konrath <ben@bagu.org>
1447 Improve performance of related list height calculation.
1449 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1450 Put code to calculate the expected height in a static initializer so
1451 that that it's only called once.
1453 2011-12-01 Ben Konrath <ben@bagu.org>
1455 Show related list tables in notebooks (again).
1457 Calculate the height of the related list tables so the Notebook can be
1458 set the correct height. The height of the related list table is also needed by
1459 FlowTable to be able decide how to create the layout.
1461 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1462 and set the Portal height based on the height of the related list
1463 table and the Portal container.
1464 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1465 Add method to calculate the height of the related list tables.
1466 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1467 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1468 calculate the height of the Pager widget.
1470 2011-12-01 Ben Konrath <ben@bagu.org>
1472 Use CellTable API for table property instead of setting style on Element.
1474 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1476 2011-12-01 Ben Konrath <ben@bagu.org>
1478 Make ListViewTable and RelatedListTable a consistent height.
1480 The tables are now a consistent height regardless of the contents of
1481 the table. A hidden button is added to empty rows to ensure that the
1482 height of these rows will match the height of rows with data.
1484 A navigation button column is now added to every table. The width of
1485 the navigation column is set to 0px when a RelatedListTable shouldn't
1486 have navigation buttons. This maintains the a consistent row height in
1487 tables that don't show the navigation buttons.
1489 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1490 navigation column when not needed.
1491 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1492 arguments for navigation button to constructor of ListViewTable.
1493 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1494 hidden button for empty data rows.
1495 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1496 arguments for navigation button to constructor.
1497 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1498 create navigation buttons. Add hideNavigationButtons() method.
1499 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1500 arguments for navigation button to constructor.
1502 2011-12-01 Ben Konrath <ben@bagu.org>
1504 Use 'visibility: hidden' in Utils.getWidgetHeight().
1506 This is better choice because hidden elements are invisible, don't
1507 respond to events and are not part of the tab order. They will,
1508 however, take up space which is required to be able to calculate the
1509 height of the widget.
1511 * src/main/java/org/glom/web/client/Utils.java:
1513 2011-12-01 Ben Konrath <ben@bagu.org>
1515 Use Utils.getWidgetHeight() in FlowTable.
1517 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1519 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1521 2011-12-01 Ben Konrath <ben@bagu.org>
1523 Put the details css class name on the correct table column.
1525 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1527 2011-11-30 Ben Konrath <ben@bagu.org>
1529 Update for java-libglom API change.
1531 The getters and setters on FieldFormatting and NumericFormat were
1532 changed to remove the 'M'.
1534 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1536 2011-11-29 Ben Konrath <ben@bagu.org>
1538 Only allow RelatedListTables in Portals.
1540 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1542 2011-11-29 Ben Konrath <ben@bagu.org>
1544 Only create a contents panel for Portals when title is being set.
1546 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1548 2011-11-29 Ben Konrath <ben@bagu.org>
1550 Set TabLayoutPanel height based on calculated height its widgets.
1552 This is a potential fix for this bug:
1554 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1556 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1558 2011-11-29 Ben Konrath <ben@bagu.org>
1560 Align details field labels and data with the Open buttons.
1562 * src/main/webapp/style.css:
1564 2011-11-29 Ben Konrath <ben@bagu.org>
1566 Remove unnecessary <div> in the Notebook widget.
1568 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1569 method to get container FlowPanel (<div>).
1570 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1571 initWidget() method directly on the TabLayoutPanel widget instead of
1572 Group's container widget.
1574 2011-11-29 Ben Konrath <ben@bagu.org>
1576 Don't add group titles for Portals in Notebooks.
1578 This reverts the previous patch and fixes a bug I introduced with
1579 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1581 * src/main/java/org/glom/web/client/ui/details/Group.java:
1582 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1584 2011-11-28 Ben Konrath <ben@bagu.org>
1586 Remove unused boolean argument in Portal constructor.
1588 Just a code cleanup.
1590 * src/main/java/org/glom/web/client/ui/details/Group.java:
1591 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1593 2011-11-28 Ben Konrath <ben@bagu.org>
1595 Remove hack for glom 1.18 style glom files.
1597 * src/main/java/org/glom/web/client/ui/details/Group.java:
1598 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1599 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1601 2011-11-28 Ben Konrath <ben@bagu.org>
1603 Use Gda Value version of primary key to log result too large error.
1605 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1607 2011-11-28 Ben Konrath <ben@bagu.org>
1609 Don't use TypedDataItem.getText() for Unknown types from the URL.
1611 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1612 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1613 instead of getText().
1614 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1615 String field and getUnknown() method.
1617 2011-11-28 Ben Konrath <ben@bagu.org>
1619 Log an error message when the java-libglom .so is not present.
1621 The error message was being set in the exception but not logged.
1623 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1625 2011-11-28 Ben Konrath <ben@bagu.org>
1627 Ignore LayoutItem_CalendarPortals.
1629 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1630 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1632 2011-11-28 Ben Konrath <ben@bagu.org>
1634 Extract method for creating the LayoutItemPortal DTO.
1636 Just breaking the code up into smaller chunks.
1638 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1640 2011-11-28 Ben Konrath <ben@bagu.org>
1644 This should have been added with the refactor. Oops!
1646 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1648 2011-11-28 Ben Konrath <ben@bagu.org>
1650 Create primary key value from URL string using type from Glom document.
1652 See this bug, comments 19 - 25:
1654 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1656 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1657 create a TypeDataItem for the primary key here when loading from a
1658 URL. Show the same string for the primary key value as was received
1659 from the URL string (when loading from a URL).
1660 * src/main/java/org/glom/web/server/Utils.java: Update method for
1661 creating the Gda Value from the TypeDataItem to properly deal with
1662 creating a Gda Value based on the Glom document type for the primary
1663 key value string when loading from a URL.
1664 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1665 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1666 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1667 Update for changed method name.
1669 2011-11-27 Ben Konrath <ben@bagu.org>
1671 Rename PrimaryKeyItem to TypedDataItem.
1673 The name PrimaryKeyItem suggests what the class should be used for.
1674 TypedDataItem is a neutral name that describes the class better.
1676 This is a rename-only refactor.
1678 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1679 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1680 * src/main/java/org/glom/web/client/Utils.java:
1681 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1682 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1683 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1684 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1685 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1686 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1687 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1688 * src/main/java/org/glom/web/server/Utils.java:
1689 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1690 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1691 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1692 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1694 2011-11-25 Ben Konrath <ben@bagu.org>
1696 Improve Gda Value conversion from PrimaryKeyItem.
1698 The value from the PrimaryKeyItem is only used if its type match the
1699 type from the glom document.
1701 * src/main/java/org/glom/web/server/Utils.java:
1703 2011-11-25 Ben Konrath <ben@bagu.org>
1705 Manually check if the java-liblgom .so is visible to the JVM.
1707 It seems that Tomcat has problems when a static initializer throws an
1708 exception. This check is done before the first method call into
1709 java-libglom so that execution doesn't continue if the .so is not
1712 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1714 2011-11-25 Ben Konrath <ben@bagu.org>
1716 Improve browser configuration error messages.
1720 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1722 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1723 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1724 getConfigurationErrorMessage() method.
1725 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1726 Get and display a specific configuration error message when no Glom
1727 documents are found.
1728 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1729 Implement getConfigurationErrorMessage() method. Surround configuration
1730 code in the init() method with a try/catch block. This allows the
1731 errors to be caught while keeping the servlet available to retrieve the
1732 configuration error message.
1734 2011-11-25 Ben Konrath <ben@bagu.org>
1736 Don't use Strings to hold primary key values.
1738 The primary key values are now held in a new data object
1739 (PrimaryKeyItem) that holds type information and the primary key value
1740 using the correct type.
1742 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1743 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1744 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1745 PrimaryKeyItem instead of String to hold the primary key value.
1746 * src/main/java/org/glom/web/client/Utils.java: Remove
1747 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1748 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1749 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1750 PrimaryKeyItem instead of String to hold the primary key value. Load
1751 document selection page when the documentID has not been set correctly.
1752 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1753 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1755 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1756 Return empty string for URL instead of "null".
1757 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1758 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1759 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1760 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1761 PrimaryKeyItem instead of String to hold primary key values.
1762 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1763 PrimaryKeyValue to a Gda Value.
1764 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1765 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1766 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1767 Replace temporary database access code that uses the PrimaryKeyValue to
1768 Gda Value conversion.
1769 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1770 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1771 PrimaryKeyItem instead of String.
1772 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1773 hold primary key values.
1775 2011-11-24 Ben Konrath <ben@bagu.org>
1777 Use newly added java-libglom API to create queries.
1779 This isn't finished. I still need to stop using Strings for primary key
1780 values in the client code.
1782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1783 libglom to use fake connections so that retrieving the query string will
1785 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1786 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1787 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1788 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1789 Use the newly added libglom sql methods and classes to create the
1790 query. Add temporary hack to convert primary value strings to Gda
1793 2011-11-23 Ben Konrath <ben@bagu.org>
1795 Don't explicitly set the height of Portals.
1797 See comments 6 - 10 of this bug for details:
1799 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1801 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1803 2011-11-23 Ben Konrath <ben@bagu.org>
1805 Use an HTML table instead of CSS for the FlowTable layout.
1807 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1808 GWT's FlexTable to implement the FlowTable.
1809 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1811 2011-11-18 Ben Konrath <ben@bagu.org>
1813 Add boolean example to HTML table mockup.
1815 * mockups/details-view-html-tables-text-entries.html:
1817 2011-11-17 Ben Konrath <ben@bagu.org>
1819 Ensure the pager buttons are always visible for related lists.
1821 To accomplish this, I've turned off text wrapping in the list view and
1822 related list tables for both the header and data text. The related list
1823 table now has a fixed layout so the it doesn't overflow its container.
1824 This is required to ensure that the cell text is clipped when it
1825 overflows the cell and an ellipsis is added to the right side of the
1826 cell when text is clipped.
1828 A fixed table layout for the related list table in the details view
1829 seems what we want for the details view anyway, so the side-effect is
1832 The ellipsis will only be displayed in Firefox >= 7.
1836 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1838 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1839 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1840 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1842 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1843 Set the 'table-layout: fixed' CSS property to the related list table.
1844 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1845 'white-space: nowrap;' CSS property on both the list view and the
1846 related list tables.
1848 2011-11-16 Ben Konrath <ben@bagu.org>
1850 Rework the fix for empty notebook tab labels.
1852 Setting the empty group titles with its name caused problems for the
1853 details layout. Instead of using libglom's
1854 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1855 to the client when the title is empty. This allows the Notebook to use
1856 the name when the title is empty without affecting anything else.
1858 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1859 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1861 2011-11-16 Ben Konrath <ben@bagu.org>
1863 Set group titles with name when title is empty.
1865 This fixes a problem with an empty notebook tab label in the Lesson
1866 Planner document. The forth tab in the notebook should be "Internet":
1868 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1870 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1871 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1874 2011-11-16 Ben Konrath <ben@bagu.org>
1876 Remove whitespace from the configured username properties.
1878 This assumes that usernames won't have whitespace at the beginning
1879 or end. But I think this is a reasonable assumption.
1881 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1882 String.trim() to remove the whitespace from the username properties.
1884 2011-11-15 Ben Konrath <ben@bagu.org>
1886 Add details view mockup with HTML tables and text entries.
1888 This is from the attachment on this bug:
1890 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1892 * mockups/details-view-html-tables-text-entries.html:
1894 2011-11-15 Ben Konrath <ben@bagu.org>
1896 Add space between the columns of the flow table.
1900 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1902 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1903 space between columns in the flow table.
1905 2011-11-15 Ben Konrath <ben@bagu.org>
1907 Add backup files to the .gitignore.
1909 * .gitignore: Ignore files that end with ~.
1911 2011-11-09 Ben Konrath <ben@bagu.org>
1913 Use latest release of gwt-log.
1915 Gwt-log releases are now being submitted to the maven central
1916 repository so manual installation of the jar is no longer required.
1918 * pom.xml: Update version and groupId of gwt-log dependency.
1920 2011-10-31 Ben Konrath <ben@bagu.org>
1922 Don't use GWT numeric formatting to override the glom currency formatting.
1924 Currencies are now displayed like they are in Glom. See this bug:
1926 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1928 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1930 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1931 currency code to constructor and set it when the cell is rendered.
1932 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1933 currency code to the constructor of the NumericCell.
1935 2011-10-27 Ben Konrath <ben@bagu.org>
1937 Require the latest release of java-libglom (1.17.4).
1941 2011-10-26 Ben Konrath <ben@bagu.org>
1943 Add style to Notebook that matches current theme.
1945 It's not the best style in the world but it's better than the default.
1947 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1948 padding at the bottom of the child widgets.
1949 * src/main/webapp/style.css: Add style for the Notebook.
1951 2011-10-26 Ben Konrath <ben@bagu.org>
1953 Move servlet initialization code to overridden init method.
1955 This is half of the solution to getting proper error messages
1956 displayed when configuration errors occur. Here's the relevant bug:
1958 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1960 The rest of the solution involves surrounding the init method with a
1961 try/catch block and setting a global variable with the error /
1962 exception. A new async method should be created to retrieve and display
1963 the error message / exception.
1965 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1966 code from constructor to init method adding exceptions as needed.
1968 2011-10-26 Ben Konrath <ben@bagu.org>
1970 Add script to monitor and restart tomcat if required.
1972 * utils/check-and-recover-tomcat.py: New file.
1974 2011-10-26 Ben Konrath <ben@bagu.org>
1976 Display the correct number of data items in the pager.
1980 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1982 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1983 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1984 The implementation is the same for both tables: Keep track of the
1985 number of non-empty rows and fire and RowCountChangeEvent after the data has
1987 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1988 custom Pager class that subclasses SimplePager to handle displaying
1989 the correct number when empty rows have been added.
1991 2011-10-26 Ben Konrath <ben@bagu.org>
1993 Correct error in previous commit.
1995 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1996 eventBus parameter from listView.setCellTable().
1998 2011-10-26 Ben Konrath <ben@bagu.org>
2000 Fix error in TODO comment.
2002 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2004 2011-10-24 Ben Konrath <ben@bagu.org>
2006 Create Notebook widgets to the details view.
2008 This isn't finished just yet - I still need to create a reasonable
2009 style to match the current theme.
2011 * src/main/java/org/glom/web/client/Utils.java: Add method for
2012 calculating the height of a widget. This is used in the Notebook class.
2013 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2014 new constructor method in Group.
2015 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2016 method for creating child widget that can be used by subclasses
2017 like Notebook. New constructor that allows disabling the group
2018 titles - Notebooks don't set a group title for their child groups.
2019 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2020 to make Notebooks using GWT's TabLayoutPanel.
2021 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2022 constructor that allows disabling the group titles.
2023 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2024 LayoutItemNotebook DTO.
2025 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2026 DTO for Notebooks. It's just an empty class for now but we might need
2027 it to transfer some specific information in the future.
2029 2011-10-21 Ben Konrath <ben@bagu.org>
2031 Add navigation buttons to related list tables.
2033 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2034 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2036 method getSuitableRecordToViewDetails() for getting the table name
2037 and primary key value for related list navigation buttons.
2038 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2039 private cell renderer class to get the navigation information for
2040 related list tables from the server. Extract the navigation
2041 processing code from the details cell navigation and use it for the
2042 related list navigation as well.
2043 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2044 cell renderer class for the details open buttons. This was needed
2045 because the related list navigation buttons and the list view
2046 navigation buttons need to react differently when clicked.
2047 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2048 the onEnterKeyDown() method because it's now overriden in the
2049 subclasses that are specific to the related list tables and the list
2051 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2052 the vertical size a little because the buttons add a bit of vertical
2053 space to table. This is not a perfect solution because the vertical
2054 size of with table fewer than 5 rows will be a little smaller.
2055 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2056 changes in how navigation buttons are handled.
2057 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2058 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2059 database access object.
2060 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2061 to find the portal for a given relationship name from
2062 RelatedListDBAccess. Add method to find a primary key field for a
2064 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2065 Move code to find the portal for a given relationship name to
2067 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2068 New file: database access object for getting the related list
2069 navigation information (the table name and the primary key value).
2070 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2071 DTO for transferring a table name to navigate to and a primary key
2073 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2074 boolean and getter/setter to specifies if the related list should add
2077 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2079 Use the master branch of java-libglom
2081 * pom.xml: Depend on java-libglom 1.19 instead.
2083 This is the master branch. See also the libglom-1-18 branch.
2085 2011-10-11 Ben Konrath <ben@bagu.org>
2087 Enable the open navigation button when the data has been set.
2089 This avoids having active buttons that don't do anything when the data
2092 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2094 2011-10-11 Ben Konrath <ben@bagu.org>
2096 Use IsWidget interface for FlowTableItem.
2098 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2099 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2101 2011-10-11 Ben Konrath <ben@bagu.org>
2103 Remove GWT styling from open button in details view.
2105 There are still some issues with how the details cell is arranged but
2106 this should be made to match Glom 1.20. I'm going to leave fixing this
2107 until I have Glom 1.20 up and running.
2109 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2110 style name on open button.
2111 * src/main/webapp/style.css: Move and edit details-navigation class.
2112 Re-arrange some classes to make them appear in the same order as the
2115 2011-10-07 Ben Konrath <ben@bagu.org>
2117 Update to GWT 2.4.0.
2119 * .gitignore: Ignore new cache directory.
2120 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2121 * pom.xml: Change GWT and maven plugin to 2.4.0.
2122 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2124 * src/main/java/org/glom/web/client/ClientFactory.java:
2125 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2126 * src/main/java/org/glom/web/client/OnlineGlom.java:
2127 Update source for API changes.
2128 * utils/build-onlineglom-war.sh: Remove cache directory before the
2131 2011-10-07 Ben Konrath <ben@bagu.org>
2133 Add navigation buttons in the details view.
2135 This isn't finished but I thought I'd commit what I have as it's a
2136 pretty good start. I still need to:
2138 1. Change the style so that it fits better into the current theme
2139 2. Adjust the details cell to expand as much as possible.
2141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2142 click handlers to navigation buttons in the DetailsCells. Create a
2143 refreshData() method to get just the data from the server without the
2145 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2146 Update the tableSelector and browser title when the table name
2147 changes without using the tableSelector.
2148 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2149 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2150 getDetailsCells() to getCells(). Update variable names.
2151 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2152 method to set click handler on navigation button. Rename a few
2153 variables. Add navigation buttons where needed.
2154 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2155 variables and methods.
2156 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2157 navigation boolean and navigation table as required in the
2158 LayoutItemField DTO.
2159 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2160 variables for navigation along with getter/setter methods.
2162 2011-10-07 Ben Konrath <ben@bagu.org>
2164 Rename Field to DetailsCell.
2166 This is a refactor-only commit. No functionality has been added or
2169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2170 Update variable and method names.
2171 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2172 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2173 variable and method names.
2174 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2176 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2177 variable and method names.
2179 2011-10-07 Ben Konrath <ben@bagu.org>
2181 Create separate methods for layout and data the details view.
2183 This is a refactor-only commit. No functionality has been added or
2186 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2187 private methods: setData(), createLayout().
2189 2011-10-07 Ben Konrath <ben@bagu.org>
2191 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2193 This is part of a change to get navigation buttons in the details view
2194 but it should have been done this way from the start.
2196 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2197 for method name change in TableSelectionView.
2198 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2199 Create TableChangeEvent and set the browser title using the
2200 TableSelectionView API.
2201 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2202 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2203 Change getSelectedTable() to getSelectedTableName(). Add
2204 getSelectedTableTitle().
2206 2011-10-07 Ben Konrath <ben@bagu.org>
2208 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2210 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2212 2011-10-07 Ben Konrath <ben@bagu.org>
2214 Update TableChangeEvent to use newTableName naming convention.
2216 This makes the class more consistent with GWT naming conventions.
2218 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2219 Update for method name change in TableChangeEvent.
2220 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2221 for method name change in TableChangeEvent.
2222 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2223 newTableName variable and getter method. Make toDebugString()
2226 2011-09-30 Ben Konrath <ben@bagu.org>
2228 Disable the pager in the list tables when the data row count is less than the minimum.
2230 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2231 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2233 2011-09-30 Ben Konrath <ben@bagu.org>
2235 Add empty rows to the end of related list and list view tables.
2237 I also extracted the cell rendering classes from the ListTable because
2238 the code was becoming a little crazy with all the anonymous inner
2239 classes. My plan is to use these cell rendering classes in the details
2240 view as well so this refactor will be needed for that change.
2242 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2243 set the row count in related list tables if the data has more rows
2244 than the minimum number of rows visible.
2245 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2246 row count in list view tables if the data has more rows than the
2247 minimum number of rows visible.
2248 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2249 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2251 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2252 for rendering TYPE_NUMERIC cells. The code was extracted from the
2254 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2255 class for rendering cells with buttons in list views. The code was
2256 extracted from the ListTable class.
2257 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2258 for rendering TYPE_TEXT cells. The code was extracted from the
2260 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2261 Add empty rows to the end of the data if required. Implement
2262 ListTable.getMinNumVisibleRows().
2263 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2264 cell renderer code to public classes. Return null in
2265 Column.getValue() for empty rows. Add new abstract method:
2266 getMinNumVisibleRows(). Move code to set the row count of the list view
2267 table to ListViewImpl.
2268 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2269 empty rows to the end of the data if required. Implement
2270 ListTable.getMinNumVisibleRows().
2273 2011-09-27 Ben Konrath <ben@bagu.org>
2275 Use GWT.log for client-side debugging statements.
2277 These are optimized out when deployed so I should have used this method
2278 in the first place. These statements will eventually be replaced with some sort
2279 of notification in the browser.
2281 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2282 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2283 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2284 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2285 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2287 2011-09-27 Ben Konrath <ben@bagu.org>
2289 Put tableselector on the right, back to list link on right.
2291 The idea is that the table selector is acting like a label for the
2292 currently displayed table so it should be placed below the document title. This
2293 puts the table title in a similar position to where it is in Glom.
2295 * mockups/details-contacts.html:
2296 * mockups/details-projects.html:
2297 * mockups/listview-contacts.html:
2298 * mockups/listview-projects.html:
2299 * mockups/style.css:
2300 Update mockups to match how the interfaces currently look.
2301 * src/main/webapp/style.css: Swap positions of backlink with the table
2302 selector. Add some space on the left side of the table selector to
2303 line things up with the document title.
2305 2011-09-27 Ben Konrath <ben@bagu.org>
2307 Add field colouring to details view.
2309 This change re-works how field colouring works. The colour formatting
2310 information is now set to the client with the layout information instead of
2311 with the data. This eliminates the need to send the same colour strings for
2312 data in list view column when colour information is set.
2314 In order to set an alternate colour for negative numeric values, the
2315 number is now sent to client and formatted with the GWT NumberFormat class.
2317 This change also fixes:
2319 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2321 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2322 internationalization framework which is needed for client side numeric
2324 * src/main/java/org/glom/web/client/Utils.java: New file for some
2325 client static utility methods.
2326 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2327 the DataItem object to the Field class. Use a utility method to
2328 create the foreignKeyValue string.
2329 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2330 alignment and text colours in the constructor. Add setData(DataItem)
2331 method. Remove setText(String) method.
2332 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2333 colour information to GlomTextCell. Create and use GlomNumberCell for
2334 rendering numbers. Use utility method to get the string for the
2335 primary key of the key provider. Re-work how the horizontal alignment
2337 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2338 formatting to layout information. Methods for converting the libglom
2339 formatting information were moved from DBAccess.
2340 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2341 numeric formatting (it's now done on the client side). Don't set text
2342 colours in DataItem. Move libglom formatting conversion methods to
2344 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2345 getters/setters for text colour information.
2346 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2347 for transferring the libglom NumericFormat information to the client.
2348 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2349 and getters/setters for: GlomNumericFormat, background colour and
2350 foreground colour strings.
2352 2011-09-26 Ben Konrath <ben@bagu.org>
2354 Simplify code that iterates through the LayoutGroup.
2356 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2358 2011-09-26 Ben Konrath <ben@bagu.org>
2360 Accept Eclipse formatting for OnlineGlomServiceAsync.
2362 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2364 2011-09-26 Ben Konrath <ben@bagu.org>
2366 Don't use the ListDBAccess classes to get the primary key layout information.
2368 This was causing a bug where the wrong index for the hidden primary key
2369 was being sent to the client.
2371 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2372 primary key while creating the LayoutGroup DTO. Create a
2373 LayoutItemField DTO for hidden primary keys. Don't use the
2374 RelatedListDBAccess because it was only used for getting the primary
2376 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2377 access modifier from public to protected for getPrimaryKeyField() and
2378 getPrimaryKeyLayoutItemField().
2379 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2380 abstract method getExpectedResultSize() because RelatedListDBAccess
2381 doesn't have enough info to implement it.
2382 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2383 Remove @Override for getExpectedResultSize().
2384 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2385 Remove method getExpectedResultSize().
2387 2011-09-23 Ben Konrath <ben@bagu.org>
2389 Log which layout (list or details) the ignored item is from.
2391 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2393 2011-09-23 Ben Konrath <ben@bagu.org>
2395 Remove annotations that turn off code formatting in DataItem.
2397 * src/main/java/org/glom/web/shared/DataItem.java:
2399 2011-09-23 Ben Konrath <ben@bagu.org>
2401 Rename GlomField to DataItem and update associated methods.
2403 This is a rename-only refactor. No functionality has been added or
2406 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2407 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2408 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2409 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2410 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2411 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2412 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2413 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2415 * src/main/java/org/glom/web/server/database/DBAccess.java:
2416 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2417 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2418 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2419 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2420 * src/main/java/org/glom/web/shared/DataItem.java:
2421 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2422 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2424 2011-09-23 Ben Konrath <ben@bagu.org>
2426 Rename GlomDocument to DocumentInfo and update associated methods.
2428 This is a rename-only refactor. No functionality has been added or
2431 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2432 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2433 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2434 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2435 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2436 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2437 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2439 2011-09-20 Ben Konrath <ben@bagu.org>
2441 Require java-libglom 1.17.3.
2443 This picks up the fix for the seg fault problem with the Scenes table
2444 in the Openismus Film Manager example.
2448 2011-09-20 Ben Konrath <ben@bagu.org>
2450 Change the way sort clause is added for primary key when no sort clause is requested.
2452 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2453 before the sort clause is created. When a sort clause is not requested, the
2454 sort clause is created by finding the primary key in the LayoutFieldVector
2457 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2459 2011-09-20 Ben Konrath <ben@bagu.org>
2461 Log error message if no documents are found in the configured directory.
2463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2464 Extract the glom file extension string to a private static final class
2465 variable (mostly as syntactic sugar). Accept a minor formatting change.
2466 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2467 the example glom.document.directory configuration property to make it
2468 more clear that it can any directory, not just the home directory.
2470 2011-09-18 Ben Konrath <ben@bagu.org>
2472 Add related lists to details view.
2474 The related list table has support for paging and sorting just like the
2475 table in the list view.
2477 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2478 SQL queries for the related list tables.
2479 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2480 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2481 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2482 Rename getList methods to getListView and add comments. Remove
2483 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2484 it being unused. Add methods: getDetailsLayoutAndData(),
2485 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2486 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2487 Create the layout and set the data for the fields in one async call
2488 instead of two. Create related lists where appropriate.
2489 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2490 for method name changes in OnlineGlomService.
2491 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2492 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2493 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2495 * src/main/java/org/glom/web/client/ui/ListView.java:
2496 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2497 tableName from setCellTable(). Create a ListViewTable instead of
2499 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2500 represent a data field in the details view.
2501 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2502 from addDetailsCell() to Field class. Keep track of the Fields and
2503 Portals in the details view.
2504 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2505 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2506 and add a method to get it. Add method to set the contents of the
2508 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2509 New class for related list tables. This class has the data provider
2510 for the related list table.
2511 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2512 abstract class which is the base class for the ListViewTable and the
2514 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2515 New class for list view tables. This class has the data provider for
2516 the list view table.
2517 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2518 methods for related list tables. Add more information to the
2519 LayoutItemField and LayoutItemPortal DTOs.
2520 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2521 Remove debugging print statement.
2522 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2523 Remove debugging print statements. Add primary key field to SQL count
2525 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2526 Remove unnecessary LayoutFieldVector parameter from
2527 getResultSizeOfSQLQuery() method.
2528 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2529 New class for related list table database access.
2530 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2531 class that is a wrapper DTO for details view layout and data.
2532 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2533 new 'fromField' string to this DTO.
2534 * src/main/webapp/style.css: Remove bottom margin and override top
2537 2011-09-15 Ben Konrath <ben@bagu.org>
2539 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2541 This sets things up to make it easier to add the data retrieval for
2542 related lists (portals). No user noticeable changes were made with
2545 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2546 class has the code to retrieve the layouts and access the
2547 database using the new database helper classes.
2548 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2549 Most of the functionality has been removed from this class. This
2550 class now represents the public interface for the client side
2551 code. It also deals with configuring the servlet and cleaning
2552 things up when the servlet is stopped.
2553 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2554 of static methods into this utility class.
2555 * src/main/java/org/glom/web/server/database/DBAccess.java:
2556 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2557 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2558 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2559 These classes have the database retrieval code. The class hierarchy
2560 has been setup to make it easy to reuse code for similar
2563 2011-09-06 Ben Konrath <ben@bagu.org>
2565 Create separate classes for list table code and the data provider.
2567 As part of this refactor, I also split up the code a bit to make it
2570 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2571 table code to two new classes (below).
2572 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2573 with code from ListViewImpl.
2574 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2575 New file with code from ListViewImpl.
2577 2011-09-06 Ben Konrath <ben@bagu.org>
2579 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2581 This fixes the LayoutItemPortal DTO to match the libglom layout object
2584 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2586 2011-09-01 Ben Konrath <ben@bagu.org>
2588 Set title of Portals in the Details View.
2590 * pom.xml: Bump required version of java-libglom to 1.17.1.
2591 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2592 widget creation to its own class. Add comments to constructor.
2593 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2594 The code is mostly from the Group class with the title now set.
2595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2596 title of Portal. Update some comments. Fix some code formatting.
2598 2011-09-01 Ben Konrath <ben@bagu.org>
2600 Remove TODO comment for the flow table column width.
2602 The flow table column width is working correctly and doesn't need to be
2603 changed. See this mailing list post for more info:
2605 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2607 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2609 2011-08-27 Ben Konrath <ben@bagu.org>
2611 Add document title (database name) to top of the browser page.
2613 I added the document title to the TableSelecitonView but that will
2614 change if / when we add a view that doesn't require table selection.
2616 * mockups/details-contacts.html:
2617 * mockups/details-projects.html:
2618 * mockups/listview-contacts.html:
2619 * mockups/listview-projects.html:
2620 * mockups/style.css: Add document title to mockups to keep things
2622 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2623 sizes to account for the document title.
2624 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2625 Set the document title when it has been retrieved from the server.
2626 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2627 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2628 and implement setDocumentTitle(String) method.
2629 * src/main/webapp/style.css: Add ID for document title style.
2631 2011-08-25 Ben Konrath <ben@bagu.org>
2633 Add NavigationType enum to LayoutItemPortal DTO.
2635 This is the start of adding support for Portals to the Details View.
2637 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2638 LayoutItem_Portal.navigation_type enum from libglom to
2639 LayoutItemPortal.NavigationType enum.
2640 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2641 NavigationType enum, field for storing the NavigationType and getter
2644 2011-08-25 Ben Konrath <ben@bagu.org>
2646 Implement the flow table layout in the Details View.
2648 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2649 FlowTable to Group to account for the renamed class.
2650 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2651 File. This is a container widget that implements the Glom details view
2652 flow table behaviour.
2653 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2654 org/glom/web/client/ui/FlowTable.java.
2655 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2656 so that the size of the subgroups are a closer match to the size of
2657 the Glom subgroups. This makes the flowtable layout match the layout
2658 in Glom for the Music Collection example file.
2660 2011-08-16 Ben Konrath <ben@bagu.org>
2662 Create container element for LayoutItemPortal in Details View.
2664 This will help me develop the layout for the FlowTable.
2666 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2667 fieldPanel variable to detailsCell.
2669 2011-08-15 Ben Konrath <ben@bagu.org>
2671 Set the height of the data element in the Details View.
2673 I changed the InlineLabels (text in a span element) to Labels (text in
2674 a div element) so that I could set the height of the details-data
2675 elements instead of the details-cell parent elements. This allows the
2676 the details-data element to display the correct height if style is
2677 applied that shows the height.
2679 This change has the added benefit of allowing the order of the labels
2680 and data elements to be changed for right-to-left languages.
2682 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2683 InlineLabels to Labels.
2684 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2685 InlineLabels to Labels. Set the height of the data element.
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2687 multiline text height in the Formatting DTO.
2688 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2689 for multiline height along with getter and setter methods.
2690 * src/main/webapp/style.css: Adjust style to account for the change
2691 from span elements to div elements in the details cell.
2693 2011-08-15 Ben Konrath <ben@bagu.org>
2695 Make the List View appearance match the mockups.
2697 It doesn't match exactly but it's much better than it was.
2699 * mockups/listview-contacts.html: Remove unused css classes.
2700 * mockups/listview-projects.html: Remove unused css classes.
2701 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2702 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2703 for mainPanel instead of VerticalPanel (table). Set style name on
2704 CellTable. Set style name on Details column. Right-align Details
2706 * src/main/webapp/style.css: Adjust properties to match the mockups.
2708 2011-08-12 Ben Konrath <ben@bagu.org>
2710 Add better support for subgroups in the details view.
2712 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2713 changed FlowTable constructor.
2714 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2715 support for subgroups and subgroup-titles.
2716 * src/main/webapp/style.css: Add CSS class for subgroups and
2719 2011-08-12 Ben Konrath <ben@bagu.org>
2721 Return the top level LayoutGroup title.
2723 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2725 2011-08-11 Ben Konrath <ben@bagu.org>
2727 Make the TableSelector header match the mockup.
2729 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2730 the layout panel. Properly lineup the table selection header with
2731 the list and details view.
2732 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2733 margin around the details view.
2734 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2735 Rename listBox variable to tableSelector. Set id for the style sheet.
2736 Use a FlowPanel instead of a HorizontalPanel.
2737 * src/main/webapp/style.css: Add properties to make the TableSelector
2738 box match the mockups.
2740 2011-07-13 Ben Konrath <ben@bagu.org>
2742 Update install script for java-libglom version change.
2744 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2747 2011-07-13 Ben Konrath <ben@bagu.org>
2749 Add support sub-group in the details view.
2751 I also removed the code that special-cased the default details view
2754 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2756 I still have to make a proper flowtable.
2758 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2759 Don't special-case default details view layout.
2760 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2761 addLayoutField() as I'm going to use it.
2762 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2763 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2765 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2766 extracted from DetailsViewImpl.GroupPanel. Add support for
2768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2769 column count when getting the details layout.
2771 2011-07-12 Ben Konrath <ben@bagu.org>
2773 Set browser title with database and table titles.
2775 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2776 Set the browser title when the table changes and when the activity
2778 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2779 title when retrieving document info (the GlomDocument object).
2780 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2781 with getter and setter methods. Remove unused convenience constructor.
2782 Use default code formatting.
2784 2011-07-12 Ben Konrath <ben@bagu.org>
2786 Ignore LayoutItemPortals in the details view.
2788 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2791 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2792 LayoutItemPortal layout objects.
2793 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2794 LayoutItemPortal objects when retrieving the details layout.
2795 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2796 file. This is an empty class and just used to get type information for
2799 2011-07-12 Ben Konrath <ben@bagu.org>
2801 Use java-libglom 1.17.0.
2805 2011-07-11 Ben Konrath <ben@bagu.org>
2807 Remove "Table:" label from table selector.
2809 This matches a recent change in the Glom UI.
2811 * mockups/details-contacts.html:
2812 * mockups/details-projects.html:
2813 * mockups/listview-contacts.html:
2814 * mockups/listview-projects.html: Remove the "Table:" label from the
2816 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2818 2011-07-11 Ben Konrath <ben@bagu.org>
2820 Add main groups to the details view.
2822 This makes things look a little nicer in the details view. The next step
2823 is to implement the flowtable.
2825 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2826 resources from the standard gwt css theme. Standard.css is now
2827 included in OnlineGlom.html so that the online glom css rules have
2828 precedence over the gwt theme.
2829 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2830 the whole LayoutGroup to the DetailsView instead of just the titles.
2831 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2832 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2833 details layout with a helper class (GroupPanel). I might extract this
2834 class when I make the full flowtable.
2835 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2836 string as default so I don't have to worry about NPEs when processing
2838 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2839 note beside OnlineGlom.gwt.xml above).
2840 * src/main/webapp/style.css: Add default font-size to body to override
2841 the font-size set by the standard theme. Don't use h2 tags for
2842 group-title. Create new details-cell class.
2844 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2846 ConfiguredDocument: Set the port number too.
2848 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2849 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2850 Glom document. Presumably this worked sometimes so far because there is a
2851 default port number.
2853 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2855 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2857 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2858 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2859 correct, though we should throw an exception too.
2861 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2863 Fix a addDocuemnt typo.
2865 * src/main/java/org/glom/web/shared/Documents.java
2866 (Documents.addDocuemnt): Rename to addDocument().
2867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2868 (OnlineGlomServiceImpl.getDocu