1 2012-11-09 Murray Cumming <murrayc@murrayc.com>
3 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
6 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
7 Java Compiler and Java Build path settings in the UI.
9 2012-11-09 Murray Cumming <murrayc@murrayc.com>
11 Use the latest (now stable) version of GWT.
13 * pom.xml: And the latest version of the gwt-maven-plugin.
15 2012-11-08 Murray Cumming <murrayc@murrayc.com>
17 Added an Indonesian translation.
19 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
20 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
21 This is from the new translation in Glom.
23 2012-07-23 Murray Cumming <murrayc@murrayc.com>
27 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
29 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
31 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
32 for serving image data.
33 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
35 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
36 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
37 setData(): For image field types, add a GWT Image widget,
38 with the URL that was set in the DataItem.
40 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
41 * src/main/java/org/glom/web/server/database/DBAccess.java:
42 convertResultSetToDTO(): Set the URL for image data, so the client browser
43 can retrieve the image from our new servlet. This uses UriBuilder.
44 Move getPrimaryKeyField to:
45 * src/main/java/org/glom/web/server/libglom/Document.java:
46 Added getTablePrimaryKeyField().
48 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
49 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
50 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
53 2012-07-22 Murray Cumming <murrayc@murrayc.com>
57 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
58 * src/main/java/org/glom/web/client/OnlineGlomService.java:
59 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
60 to gwtGlom, which is more appropriate.
61 This servlet name does not seem to be visible to the client side anyway.
63 2012-07-22 Murray Cumming <murrayc@murrayc.com>
65 Tests: Make the imports of assert*() consistent.
67 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
68 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
69 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
70 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
71 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
72 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
73 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
74 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
75 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
76 * src/test/java/org/glom/web/shared/DataItemTest.java:
78 import static org.junit.Assert.*;
79 which seems fairly common.
83 2012-07-21 Murray Cumming <murrayc@murrayc.com>
85 tests: Move a test that needs a database connection.
87 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
88 Move testGetListViewLayoutGroup() to
89 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
90 because it needs a database connection.
92 2012-07-21 Murray Cumming <murrayc@murrayc.com>
94 tests: Use @BeforeClass on tearDown().
96 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
97 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
98 This avoids leaking a postgres process in SelfHostExampleTest.
100 2012-07-21 Murray Cumming <murrayc@murrayc.com>
102 tests: Test translations more.
104 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
105 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
106 Test titles in the non-default locale.
108 2012-07-21 Murray Cumming <murrayc@murrayc.com>
110 tests: Add SelfHostConfiguredDocumentTest
112 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
113 username and password, for use by ConfiguredDocument.
114 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
115 This tests some of the ConfiguredDocument API that requires a database connection.
117 2012-07-21 Murray Cumming <murrayc@murrayc.com>
119 Document: Load title translations and test them.
121 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
122 of titles. I am surprised that we do not do this yet.
123 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
124 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
125 Test translations more.
127 2012-07-20 Murray Cumming <murrayc@murrayc.com>
131 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
132 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
133 Set the timeout here too.
135 2012-07-20 Murray Cumming <murrayc@murrayc.com>
137 tests: ConfiguredDocumentTest: Make this pass.
139 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
140 Disable tests that need a database connection.
142 2012-07-20 Murray Cumming <murrayc@murrayc.com>
144 Use Java 1.7 instead of Java 1.6.
146 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
147 to do this twice, at least for Eclipse.
148 This seems OK because it is the current version.
150 2012-07-20 Murray Cumming <murrayc@murrayc.com>
154 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
155 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
156 Avoid using a null Connection.
158 2012-07-20 Murray Cumming <murrayc@murrayc.com>
160 tests: Add a ConfiguredDocument test.
162 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
165 2012-07-20 Murray Cumming <murrayc@murrayc.com>
167 LayoutItemFIeld: getName(): Use the Field if it is set.
169 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
170 getName(): If the full field details have been set, return its name, so that
171 callers do not need to set the name separately.
172 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
173 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
174 so we can count the rows.
176 2012-07-20 Murray Cumming <murrayc@murrayc.com>
178 tests: SelfHoster: Test SqlUtils too.
180 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
181 Retrieve some data and check it too, as in the regular Glom
182 test_selfhosting_new_from_example.cc test.
183 * src/test/java/org/glom/web/server/SelfHoster.java:
184 createConnection(): Make this public.
186 2012-07-20 Murray Cumming <murrayc@murrayc.com>
188 tests: SelfHoster: createConnection(): Do not warn about expected failures.
190 Let the caller say if the connection is expected to fail, to avoid
191 irrelevant error output.
193 2012-07-20 Murray Cumming <murrayc@murrayc.com>
195 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
197 * src/test/java/org/glom/web/server/SelfHoster.java:
198 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
199 due to the inevitable need to retry the connection while the database server
202 2012-07-20 Murray Cumming <murrayc@murray.com>
204 tests: SelfHoster: createConnection(): Set a timeout.
206 * src/test/java/org/glom/web/server/SelfHoster.java:
207 createConnection(): Use setLoginTimeout() because it otherwise seems to take
208 ages to actually return when it fails.
210 2012-07-20 Murray Cumming <murrayc@murrayc.com>
212 tests: SelfHoster: selfHost(): Close the test connection.
214 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
215 When we check that the connection works, close the connection. This seems
216 to not be closed automatically otherwise.
218 2012-07-20 Murray Cumming <murrayc@murrayc.com>
220 Use slf4j-simple to see JDBC errors.
222 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
224 2012-07-19 Murray Cumming <murrayc@murrayc.com>
226 SelfHoster.discoverFirstFreePort(): Close the socket.
228 * src/test/java/org/glom/web/server/SelfHoster.java:
229 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
231 2012-07-19 Murray Cumming <murrayc@murrayc.com>
233 Avoid another code warning in Eclipse Juno.
235 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
236 Do instanceof checks on the FileUtils.listFiles() result and its
239 2012-07-13 Murray Cumming <murrayc@murrayc.com>
241 Avoid some code warnings in Eclipse Juno
243 * src/main/java/org/glom/web/server/libglom/Document.java:
244 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
245 * src/test/java/org/glom/web/server/SelfHoster.java
246 createTextFile(): Make sure that the FileOutputStream is closed.
248 2012-06-22 Murray Cumming <murrayc@murrayc.com>
250 Added OnlineGlomPropertiesTest.
252 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
253 Make sure we never return a null string.
254 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
255 Added tests of the OnlineGlomProperties API, using our sample file.
257 2012-06-20 Murray Cumming <murrayc@murrayc.com>
259 Make OnlineGlomProperties be a normal class.
261 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
262 Move OnlineGlomProperties into its own file to be a regular class:
263 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
264 This makes testing simpler.
266 2012-06-15 Murray Cumming <murrayc@murrayc.com>
268 OnlineGlomServiceImpl.init(): Move some code into a new method.
270 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
271 Create addDocument().
273 2012-06-15 Murray Cumming <murrayc@murrayc.com>
275 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
278 OnlineGlomProperties.getKey(): Make this more robust by moving the
279 check for *.*.filename to here.
281 2012-06-15 Murray Cumming <murrayc@murrayc.com>
283 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
285 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
286 init(): Move knowledge of the config file format into the
287 OnlineGlomProperties inner class.
289 2012-06-15 Murray Cumming <murrayc@murrayc.com>
291 SelfHostExampleTest: Make sure we cleanup on failure.
293 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
294 the use of cleanup() to a tearDown() JUnit method.
298 2012-06-12 Murray Cumming <murrayc@murrayc.com>
300 ConfiguredDocument: Add a primary key to portals at least once.
302 * src/main/java/org/glom/web/server/ConfiguredDocument.java
303 updatePortalsExtras): Fix a typo so that we add the primary key
304 column at least once.
305 This is a fix for the previous commit:
306 ConfiguredDocument: Do not add a primary key to portals each time.
308 2012-06-08 Murray Cumming <murrayc@murrayc.com>
310 SelfHoster: Avoid some compiler warnings.
312 * src/test/java/org/glom/web/server/SelfHoster.java
313 executeCommandLineAndWait():
314 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
315 the now-unused streams for stdout and stderr from the command Processes.
316 These are not used because readln() hangs while waiting for a new line,
317 where there may be no next line. The commented out code is still there
318 to help us figure out how to do this properly.
320 2012-06-08 Murray Cumming <murrayc@murrayc.com>
322 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
324 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
325 Make this actually test the cloning again, though it is not very useful
326 now that we do not use the part that had a problem with cloning before.
328 2012-06-08 Murray Cumming <murrayc@murrayc.com>
330 SelfHoster: Keep trying pg_ctl after starting postgres.
332 * src/test/java/org/glom/web/server/SelfHoster.java
333 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
334 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
335 regular Glom. This seems mad but it seems to work because the first
336 command would fail if pg_ctl would eventually fail.
338 2012-06-08 Murray Cumming <murrayc@murrayc.com>
340 SelfHoster: Wait until the server is really ready.
342 * src/test/java/org/glom/web/server/SelfHoster.java
343 selfHost(): Attempt the connection after starting the server, retrying
344 a few times if necessary, so that the server is really ready already when
345 we return from this method.
346 The regular Glom code does this too because pg_ctl reports success too soon.
348 2012-06-08 Murray Cumming <murrayc@murrayc.com>
350 ConfiguredDocument: Do not add a primary key to portals each time.
352 * src/main/java/org/glom/web/server/ConfiguredDocument.java
353 updatePortalsExtras(): Only add an extra primary key field if there is
354 none, to avoid adding one each time we retrieve the details layout from the
356 This should fix bug #676986 (Ben Konrath)
358 2012-05-25 Murray Cumming <murrayc@murrayc.com>
360 Document.load(): Support version 7 documents.
362 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
363 database_title attribute if the title attribute is not there.
366 2012-05-24 Ben Konrath <ben@bagu.org>
368 Add configuration for auto-generating mvn:i18n from with Eclipse.
370 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
372 2012-05-24 Murray Cumming <murrayc@murrayc.com>
374 Update translations, adding French.
376 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
377 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
378 Add a French translation, using the translation from Glom.
380 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
381 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
382 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
383 Update these based on the translations from Glom.
385 2012-05-24 Murray Cumming <murrayc@murrayc.com>
387 SelfHoster: Add some debug println messages to help when things fail.
389 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
390 System.out.println() lines.
392 2012-05-23 Murray Cumming <murrayc@murrayc.com>
394 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
396 * src/test/java/org/glom/web/server/SelfHoster.java:
397 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
398 instance) instead of just /usr/bin (as on Fedora). Check the result when
401 2012-05-23 Murray Cumming <murrayc@murrayc.com>
403 Remove LayoutItemPortal.get/setNavigationTable().
405 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
406 Remove get/setNavigationTable(), which is only a cache, because it is not
407 used, and does not need to be used, because that decision should be made on
409 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
410 updatePortalsExtras():
411 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
412 getNavigationRecord():
413 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
416 2012-05-21 Murray Cumming <murrayc@murrayc.com>
418 Initial self-hosting for tests.
420 * pom.xml: Change the scope for log4j, to hopefully make it
421 available to the test code which uses it indirectly via jOOQ.
422 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
423 self-hosting, though we only use it for testing.
425 * src/main/java/org/glom/web/server/libglom/Document.java:
426 example rows: Use a map instead of a list for each row of values,
427 so we know what field they are for, instead of relying on the sequence
428 being correct. This is not very efficient, but it does not really need
430 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
431 testReadTableExampleRows(): Adapted.
433 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
434 that returns an Object, for generic use. Note that Object seems to be
435 the implicit base even of double.
436 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
437 for use in CREATE TABLE SQL queries.
438 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
439 to do self-hosting of PostgreSQL databases via its command-line
440 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
441 backends/postgres_self.cc. This is incomplete - it needs more
442 warnings about failures and it needs to clean up properly when things
444 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
445 test of this new class.
447 2012-05-21 Murray Cumming <murrayc@murrayc.com>
449 Document: loading example data: Handle exceptions.
451 * src/main/java/org/glom/web/server/libglom/Document.java:
452 DateFormat.parse() and Double.valueOf() can throw exceptions, though
453 Eclipse did not warn about that.
455 2012-05-20 Murray Cumming <murrayc@murrayc.com>
457 Document: load(), save(): Handle the example rows.
459 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
461 * src/main/java/org/glom/web/server/libglom/Document.java:
462 load(), save(): Load and save the example rows, though the date, time
463 and image types are not handled properly yet.
464 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
465 Add testReadTableExampleRows() just to check that something is read.
467 2012-05-20 Murray Cumming <murrayc@murrayc.com>
469 Document: Add save().
471 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
472 Added getTranslationsMap() for use while saving.
473 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
474 Adedd getUseDefaultFormatting() for use while saving.
475 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
476 and several private methods that it uses.
478 This will be useful while testing via self-hosting.
479 It is not complete, but should be complete enough for testing.
481 2012-05-17 Murray Cumming <murrayc@murrayc.com>
483 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
485 * src/main/java/org/glom/web/client/OnlineGlomService.java
486 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
487 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
488 Remove getSortedListViewData() and getSortedRelatedListData(), adding
489 the sort column index and ascending bool to the regular method.
490 Instead, a sort column index of -1 now means no sort.
491 This is less explicit, but it's fairly simple, reduces the amount of
492 code, and makes the OnlineGlomService API slightly smaller.
493 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
494 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
496 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
497 getListViewData(), getRelatedListData():
498 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
499 getListViewData(), getRelatedListData():
500 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
502 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
504 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
509 2012-05-16 Murray Cumming <murrayc@murrayc.com>
511 Use translations for top-level groups too.
513 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
514 updateTitlesForLocale(): Use the translation for the group
515 as well as for child items.
519 Just recompiled to fix a problem in the released .tar.gz file.
523 2012-05-15 Murray Cumming <murrayc@murrayc.com>
525 Corrections to navigation to related records.
527 * src/main/java/org/glom/web/client/OnlineGlomService.java:
528 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
529 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
530 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
531 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
532 relationship name, because the relationship name is not necessarily unique
534 TOOD: This is inefficient, because it passes the whole list of
535 child field items back to the server, but it is more correct, and happens
536 to fix a bug with the primary key being lost after a few navigations.
537 There is probably a chance to make this more efficient anyway in some
540 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
541 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
542 * src/main/java/org/glom/web/server/ConfiguredDocument.java
543 * src/main/java/org/glom/web/server/database/DBAccess.java
544 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
545 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
548 2012-05-15 Murray Cumming <murrayc@murrayc.com>
550 Fix the use of translations.
552 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
553 Add updateTitlesForLocale().
554 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
555 Call it to discard unwanted translations and to make getTitle() return
556 the wanted translation wihout the need for the client code to specify a locale.
557 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
558 getTitle(): Fallback to the original title, as libglom does.
560 2012-05-15 Murray Cumming <murrayc@murrayc.com>
562 Document: Correctly report the number of available translation locales.
564 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
565 the available locale IDs list.
566 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
567 testLocales: Test this.
569 2012-05-15 Murray Cumming <murrayc@murrayc.com>
571 SqlUtils: Use camelCase.
573 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
574 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
575 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
576 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
577 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
578 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
580 2012-05-15 Murray Cumming <murrayc@murrayc.com>
582 Use jOOQ's tableByName() and fieldByName.
584 * pom.xml: Use jOOQ 2.3.1 to get the new API.
585 * src/main/java/org/glom/web/server/SqlUtils.java:
586 build_sql_select_step_with_where_clause(), .createField(),
587 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
588 so we can get correct quoting and escaping. Thanks to Lukas Eder for
589 adding this, and other things, to jOOQ.
591 2012-05-15 Murray Cumming <murrayc@murrayc.com>
593 SqlUtils: Remove the Connection parameters.
595 * src/main/java/org/glom/web/server/SqlUtils.java:
596 build_sql_select_with_key(), build_sql_select_with_where_clause(),
597 createSelect(), build_sql_select_step_with_where_clause(),
598 build_sql_count_select_with_where_clause(),
599 build_sql_select_count_rows(): Remove the Connection parameter because
600 jOOQ does not actually need a connectionwhen it is just used to build
602 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
604 * src/main/java/org/glom/web/server/ReportGenerator.java:
606 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
608 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
609 Constructor, getListData(), getResultSizeOfSQLQuery():
610 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
611 getSelectQuery(), getCountQuery():
612 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
613 getSelectQuery(), getCountQuery():
614 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
615 getNavigationRecord(): Adapted.
617 2012-05-14 Murray Cumming <murrayc@murrayc.com>
621 * src/main/java/org/glom/web/server/SqlUtils.java:
622 get_find_where_clause_quick(): Use a comparison of
623 lowercase values, instead of a simple equals. Regular Glom
624 uses the PostgreSQL ILIKE operator but jOOQ does not
625 support that just yet, though it will soon.
627 2012-05-14 Murray Cumming <murrayc@murrayc.com>
629 TableToViewDetails: Use a real serialization ID.
631 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
632 Though this does not fix the serialization problem.
634 2012-05-12 Murray Cumming <murrayc@murrayc.com>
636 Added LayoutItemPortalDeepCloneTest.
638 2012-05-11 Murray Cumming <murrayc@murrayc.com>
640 Make navigation work again.
642 * src/main/java/org/glom/web/server/libglom/Document.java:
643 Add getLayoutItemFieldShouldHaveNavigation().
644 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
645 Replace get/setAddNavigation() with the partly-existing
646 get/setNavigationTableName(), with an empty string being no navigation,
647 because this is simpler. Use the new
648 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
650 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
651 Add updateFieldsExtras() and call setNavigationTableName in it.
652 getDetailsLayoutGroup(),
653 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
654 createLayout(): Adapted.
655 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
656 Constructor: Adapted.
658 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
659 Replace get/setAddNavigation() with get/setNavigation(), returning a
660 TableToViewDetails class with both the table name and UsesRelationship,
661 because both are need. The previous code used java-libglom's output
662 variable (strangely, via sharedptr) to return both, but we cannot really
664 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
665 getNavigationRecord(): Adapt. However, we cannot actually use the cache
666 here because it somehow gets set to null during deepCopy(). I must test this.
667 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
668 testGetSuitableTableToViewDetails(): Adapted.
670 TODO: Find out why deepClone() is not quite working.
672 2012-05-11 Murray Cumming <murrayc@murrayc.com>
674 DBAccess: Simplify the retrievel of full field details.
676 * src/main/java/org/glom/web/server/database/DBAccess.java
677 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
678 because the Document loading should have done this.
680 2012-05-11 Murray Cumming <murrayc@murrayc.com>
682 Document: Correct loading of doubly-related layout fields.
684 * src/main/java/org/glom/web/server/libglom/Document.java:
685 loadUsesRelationship(): Actually set the related relationship, instead
686 of only setting it if it's not found.
688 2012-05-09 Murray Cumming <murrayc@murrayc.com>
690 Replace all appearances of Colour with color.
692 Because US English is dominant.
694 2012-05-09 Murray Cumming <murrayc@murrayc.com>
696 Use colors in HTML format, solving a warning about an unused function.
698 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
699 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
700 Add *asHTMLColor() versions of methods.
701 TODO: However, we should create and cache the results on the server.
702 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
703 * src/main/java/org/glom/web/client/ui/list/ListTable.java
704 * src/main/java/org/glom/web/server/ConfiguredDocument.java
705 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
706 Use the asHTMLcolor() versions.
708 2012-05-09 Murray Cumming <murrayc@murrayc.com>
710 ListViewTable: Constructor: Take the table name as a parameter.
712 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
713 Constructor: Take the tableName, and set the member variable, because
715 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
716 setCellTable(): Pass the table name.
717 This makes navigation to non-default tables work again. I don't know
718 why it worked before in the master branch.
720 2012-05-07 Murray Cumming <murrayc@murrayc.com>
722 ConfiguredDocument: Restore correct addition of hidden primary key items.
724 * src/main/java/org/glom/web/client/ui/list/ListTable.java
725 (ListTable.createCellTable): Uncomment out the check for the hidden
727 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
728 add primary key items for top-level lists and portals, as before,
729 instead of adding them to each group.
730 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
731 Actually implement the extra methods such as setHiddenPrimaryKey() and
732 comment that these are used only for top-level list groups and in portals.
733 This strangeness suggests even more that this should not be squeezed
734 into the LayoutGroup class.
736 2012-05-07 Murray Cumming <murrayc@murrayc.com>
738 Fix Formatting loading.
740 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
741 getFormattingUsed(): Remove the duplicate Formatting member variable
742 in favour of the one from the base class.
743 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
744 Initialize a new Formatting instead of using null by default, so we
745 have some defaults, instead of having to initialize one later just to
746 get the same defaults. This also makes loading of formatting from the
747 document work, because that expected a non-null.
749 2012-05-07 Murray Cumming <murrayc@murrayc.com>
751 RelatedListTable: Make sure that the tableName is set.
753 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
754 Constructor: Take the tableName so it is available later. Otherwise,
755 the server assumes that we mean the default table and cannot find the
757 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
758 setData(): Pass the tableName to the RelatedListTable constructor.
760 2012-05-07 Murray Cumming <murrayc@murrayc.com>
764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
765 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
766 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
768 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
770 * src/main/java/org/glom/web/server/database/DBAccess.java:
771 convertResultSetToDTO(), getPortal():
772 * src/main/java/org/glom/web/server/database/ListDBAccess.java
774 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
775 Add checks for null objects and out of range access, with log messages to
776 give hints so we can fix these properly.
778 2012-05-07 Murray Cumming <murrayc@murrayc.com>
780 Portals: some corrections.
782 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
784 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
785 constructor: Use getRelationshipNameUsed() instead of getName(), because
786 that is what is meant.
787 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
788 getFromField(): Fix a typo, to get the field name, not the table name.
789 * src/main/java/org/glom/web/server/database/DBAccess.java:
790 getPortal(): Fix a typo that stopped this from working.
792 2012-05-07 Murray Cumming <murrayc@murrayc.com>
794 LayoutItemPortal: Also override getTitleOriginal().
796 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
797 This lets the base getTitle() with no parameters work.
798 TODO: Test this properly.
800 2012-05-06 Murray Cumming <murrayc@murrayc.com>
802 LayoutItemPortal: getTitle*(): Use the relationship title.
804 2012-05-06 Murray Cumming <murrayc@murrayc.com>
806 LayoutItemField: Fix loading of custom titles.
808 * src/main/java/org/glom/web/server/libglom/Document.java
809 loadDataLayoutItemField(): The title, if any, instead of the field
810 title, is stored in a title_custom node. Load it from there.
811 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
813 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
814 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
815 getTitle*() overrides.
816 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
819 2012-05-06 Murray Cumming <murrayc@murrayc.com>
821 LayoutItemField: Fall back to field titles, so some are really shown.
823 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
824 Override getTitleOriginal() and getTitle(), as in java-libglom.
825 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
828 2012-05-06 Murray Cumming <murrayc@murrayc.com>
830 Correct use of setExpectedResultSize().
832 * src/main/java/org/glom/web/server/ConfiguredDocument.java
833 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
834 Use setExpectedResultSize only on top-level groups (for instance, the
835 list layout) or on child portals (in details views).
836 Use the correct table name for portals to avoid SQL errors.
837 Update the expected counts when returning cached layouts.
839 2012-05-06 Murray Cumming <murrayc@murrayc.com>
841 Document: Interpret no group column count as 1.
843 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
844 default, though we now check for this in the UI code anyway.
846 2012-05-06 Murray Cumming <murrayc@murrayc.com>
850 2012-05-06 Murray Cumming <murrayc@murrayc.com>
852 Translatable: Use Hashmap instead of Treemap because GWT supports it.
854 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
855 The use of Treemap lead to this error from async methods, with no
857 "The response could not be deserialized"
859 2012-05-06 Murray Cumming <murrayc@murrayc.com>
861 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
863 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
864 when using the Google -> GWT Compile, or
865 g toolbar button -> GWT Compile Project... feature in Eclipse.
867 2012-05-06 Murray Cumming <murrayc@murrayc.com>
869 ListTable.addColumn(): Protect against a null Formatting.
871 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
872 Create a default Formatting if it is null, because that is the simplest
875 2012-05-06 Murray Cumming <murrayc@murrayc.com>
877 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
879 * src/main/java/org/glom/web/server/ConfiguredDocument.java
880 updateLayoutGroup(): Check that the field is not null.
882 2012-05-06 Murray Cumming <murrayc@murrayc.com>
884 ListViewImpl: Protected against a bad cast error.
886 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
887 onEnterKeyDown(): Do not cast without an instanceof check.
889 2012-05-06 Murray Cumming <murrayc@murrayc.com>
891 ListTable: Protect against an out of range error.
893 * src/main/java/org/glom/web/client/ui/list/ListTable.java
894 createCellTable(): This is unlikely, but can happen while debugging.
896 2012-05-06 Murray Cumming <murrayc@murrayc.com>
898 AsyncMessage onFailure() callbacks: Log the exception message.
900 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
901 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
902 * src/main/java/org/glom/web/client/activity/ListActivity.java:
903 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
904 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
905 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
906 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
907 These are useful clues when something is wrong.
909 2012-05-06 Murray Cumming <murrayc@murrayc.com>
911 ConfiguredDocument: Avoid a null dereference.
913 * src/main/java/org/glom/web/server/ConfiguredDocument.java
914 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
915 details maps are created.
917 2012-05-06 Murray Cumming <murrayc@murrayc.com>
919 Document: Correct the port number parsing.
921 * src/main/java/org/glom/web/server/libglom/Document.java:
922 This lets us actually connect to the database and show the document.
924 2012-05-05 Murray Cumming <murrayc@murrayc.com>
928 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
929 user-interaction, asking us to load a temporary URL in a browser.s
930 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
931 which is apparently necessary for testing the service. See the comment.
932 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
933 Show the exception, if any. This is how I saw the 404 in the HTML in
936 2012-05-05 Murray Cumming <murrayc@murrayc.com>
938 DocumentTest: Move the .glom files into the resources directory.
940 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
941 URI via getResource().
943 2012-05-05 Murray Cumming <murrayc@murrayc.com>
945 Document: Remove the FieldIdentifies inner class.
947 * src/main/java/org/glom/web/server/libglom/Document.java: We only
948 use the Relationship (though the same function in libglom is maybe
949 used in other ways) and so this removes a compiler warning.
951 2012-05-05 Murray Cumming <murrayc@murrayc.com>
953 Document.load() Remove the error code parameter.
955 * src/main/java/org/glom/web/server/libglom/Document.java: load():
956 Remove the parameter. We do not set it yet and it could never have
957 worked as an output parameter (though maybe it did in java-libglom).
958 We could use an exception if we really want the failure reason.
959 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
961 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
962 setUp(), testGetSuitableTableToViewDetails(): Adapt.
964 2012-05-05 Murray Cumming <murrayc@murrayc.com>
966 Make some inner classes static.
968 * src/main/java/org/glom/web/server/ConfiguredDocument.java
969 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
970 * src/main/java/org/glom/web/server/ReportGenerator.java
971 * src/main/java/org/glom/web/server/libglom/Document.java
972 Make all inner classes static that can be static.
974 2012-05-05 Murray Cumming <murrayc@murrayc.com>
976 OnlineGlomServiceImpl: Do not load and check for java-libglom.
978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
979 init(): We do not use java-libglom any more.
981 2012-05-05 Murray Cumming <murrayc@murrayc.com>
983 Remove mentions of java-libglom.
985 * README: Remove mention of java-libglom, because it no longer needed.
986 * utils/build-onlineglom-war.sh:
987 * utils/check-and-recover-tomcat.py:
988 * utils/install-onlineglom-war.sh: Remove these as they are no longer
989 useful. Building is now far easier, with no need for jhbuild.
991 2012-05-05 Murray Cumming <murrayc@murrayc.com>
993 Fix the build (mvn package)
995 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
996 (LayoutGroup): Make the LayoutItemList inner class static and protected.
997 Otherwise the GWT Java->Javascript compilation fails with just this
998 error, during mvn package or when attempting to view in a browser,
999 in the GWT developer mode in Eclipse.
1001 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1002 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1003 [INFO] Compiling module org.glom.web.OnlineGlom
1004 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1005 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1006 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1007 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1008 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1009 [INFO] [ERROR] Cannot proceed due to previous errors
1011 It has taken me 2 days to find out what was causing that. After reducing
1012 the code, the compiler eventually showed me the full error message.
1014 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1016 ConfiguredDocument: Cache the cloned and stripped layouts.
1018 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1019 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1020 layout in a map, so we can retrieve it again without rebuilding it.
1022 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1024 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1026 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1028 libglom classes: Implement some auto-generated emthods.
1030 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1032 Add GwtTestOnlineGlomService.
1034 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1035 However, this (and the other GwtTest*) does not seem to run during
1038 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1040 Remove use of unsupported features from client code.
1042 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1043 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1044 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1045 Use our client version of StringUtils instead of the apache commons one.
1047 However, the GWT Javascript compliation still fails.
1049 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1051 Add a Field class and implement some loading of it in Document.
1053 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1055 Initial Document loading implementation, instead of libglom.
1057 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1058 and Translatable classes, and adapt the rest of the code to use them.
1059 However, this is still missing Layout and Field classes and loading.
1061 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1063 Use of jOOQ: Move Field creation into a utility method.
1065 * src/main/java/org/glom/web/server/SqlUtils.java:
1066 This lets us improve it more easily.
1068 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1070 Use of jOOQ: Improve the code to COUNT a sub-select.
1072 * src/main/java/org/glom/web/server/SqlUtils.java:
1073 Move initial query creation into
1074 build_sql_select_step_with_where_clause().
1075 build_sql_select_count_rows(): Use the jOOQ API instead of
1076 concatentating text, because a jOOQ Select*Step is a TableLike,
1077 which is what from() takes.
1079 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1081 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1083 * pom.xml: Depend on jooq.
1084 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1085 methods with jOOQ, based on the C++ implementations in libglom,
1086 with some changes to the logic required by jooQ.
1087 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1089 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1090 * src/main/java/org/glom/web/server/ReportGenerator.java:
1091 * src/main/java/org/glom/web/server/SqlUtils.java:
1092 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1093 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1094 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1095 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1096 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1097 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1098 because jOOQ needs that, though it seems unnecessary.
1100 This is not quite finished. Ideally jOOQ would help us to build
1101 table_name.field_name names, quoting and escaping them properly.
1102 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1104 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1106 Move use of Glom.build_sql*() into a new SqlUtils class.
1108 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1109 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1110 but this will make it easier to start using something other than
1111 libglom or SqlBuilder.
1113 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1115 Update the project URL.
1117 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1119 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1121 Main layout: Use a FlowTable instead of absolute positioning.
1123 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1124 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1125 child panels/widgets must have an absolute position. But that is annoying, so
1126 this adds a FlowTable and puts the child panels in there.
1128 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1130 GwtTestOnlineGlom: Comment out unused code.
1132 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1133 Eclipse has started to say that some code is unused.
1135 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1137 Update to the latest versions of dependencies.
1139 * pom.xml: Update version numbers of dependencies to the latest
1141 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1143 * src/main/java/org/glom/web/server/ReportGenerator.java:
1144 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1145 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1146 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1148 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1149 Modify the imports where necessary.
1151 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1153 Style: Remove overflow:hidden from searchbox
1155 * src/main/webapp/style.css: Because this pushes the Back To Link
1156 label/link on to the next row, which is then hidden due to the
1157 hard-coded (in ems) height.
1159 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1161 Remove some duplicate code.
1163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1164 getDocumentInfo(): This must have been duplicated during the merge from the
1169 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1171 Reports: Localize the waiting for report message.
1173 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1174 start(): Get the message from the contants.
1175 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1176 Add the string here.
1177 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1178 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1179 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1180 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1181 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1182 Update these files with the English text for newer strings for now.
1184 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1186 Reports: Show a message while waiting for the report.
1188 * src/main/java/org/glom/web/client/ui/ReportView.java
1189 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1190 Add setWaitingText(), to show a message saying that we are
1191 waiting for the report to be ready.
1192 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1193 start(): Call setWaitingText() before calling the async
1196 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1198 ReportGenerator: Specify date and time formats.
1200 * src/main/java/org/glom/web/server/ReportGenerator.java:
1201 createFieldValueElement(): Use the default (and localized)
1202 short formats, though we still need a way to show 4-digit
1203 years without providing the format for every locale.
1204 * src/main/java/org/glom/web/server/database/DBAccess.java:
1205 convertResultSetToDTO(): Use the short formats here too.
1207 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1209 ReportGenerator: Use the correct numeric formatting.
1211 * src/main/java/org/glom/web/server/ReportGenerator.java
1212 createFieldExpression(), createFieldValueElement(): Take the
1213 whole LayoutItem_Field instead of just the field name, so
1214 we have access to the formatting.
1215 createFieldValueElement(): Use JRTextField.setPattern() to
1216 specify the numeric formatting, with the help of a
1217 regular DecimalFormat.
1219 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1221 ReportGenerator: Avoid showing null for group by titles.
1223 * src/main/java/org/glom/web/server/ReportGenerator.java
1224 generateReport(): Use setBlankWhenNull() on the field title
1225 style too, because this is used for values in group by
1228 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1230 ReportGenerator: Add a colon to titles in vertical groups.
1232 * src/main/java/org/glom/web/server/ReportGenerator.java
1233 addFieldToDetailBandVertical(): Pass true for the withColon
1236 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1238 ReportGenerator: Simplify the code by using Position more.
1240 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1242 Reports: Support vertical groups, roughly.
1244 * src/main/java/org/glom/web/server/ReportGenerator.java:
1245 addToReport(): Rename to addGroupToReport() and, if necessary,
1246 call the new addVerticalGroupToReport() method.
1247 createFieldValueElement(): Let the caller specify the Y position
1250 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1252 Reports: Allow a second report to be shown.
1254 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1255 clear(): Do not remove the HTML widget, which broke the whole layout.
1257 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1259 Locales drop-down: Show that we use English by default.
1261 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1262 fillView(): When we use English, just because that is the default, when
1263 no locale is specified, show that in the Locales drop-down instead of
1264 just showing the first item.
1266 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1268 Unselect the Report/Locale/Table combo item when appropriate.
1270 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1271 setPlace(): clear reportName if this is not a ReportPlace.
1272 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1273 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1274 When the provided name is empty, unselect all items, so that none are
1275 indicated. This uses a for loop because I cannot find a single method
1278 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1280 Report: Give the user a way to get back to the list.
1282 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1283 start(), setPlace(): Show the Back To List link on reports, and also
1284 interpret selecting the empty report item as back to list.
1286 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1288 Really show the selected Report name.
1290 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1291 setPlace(): Store the reportName here, if it is that kind of Place.
1292 fillView(): Set the selected Report after filling the list of reports.
1293 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1294 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1295 null Strings, though we need some way to unselect all ListBox items
1298 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1300 ReportGenerator: Try to avoid some problems.
1302 * src/main/java/org/glom/web/server/ReportGenerator.java
1303 addField(): Try to avoid duplicates, and avoid using a null
1306 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1308 Reports: Use quickFind.
1310 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1311 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1313 getReportHTML(): Add a quickFind parameter.
1314 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1315 start(): Pass the quickFind parameter.
1316 * src/main/java/org/glom/web/server/ReportGenerator.java
1317 generateReport(): Take a quickFind parameter.
1319 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1321 ReportPlace: Actually use the report name.
1323 * src/main/java/org/glom/web/client/place/ReportPlace.java
1324 getPlace(): Do not assign the report name to the quickfind.
1326 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1328 Show java.library.path when complaining.
1330 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1331 init(): When telling us to check java.library.path, show the
1334 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1336 ReportGenerator: Do not show nulls.
1338 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1340 ReportGenerator: Make the title font larger.
1342 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1344 ReportGenerator: Put field titles inside groups, if there are groups.
1346 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1348 ReportGenerator: Take the Report itself instead of the name and group.
1350 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1351 Remove getReportLayoutGroup().
1352 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1353 getReportHTML(): Pass the report instead
1354 of its name and layout group.
1355 * src/main/java/org/glom/web/server/ReportGenerator.java
1356 generateReport(): Use the report object to use the title
1357 instead of the name.
1359 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1361 ReportGenerator: Remove designBand parameters.
1363 * src/main/java/org/glom/web/server/ReportGenerator.java:
1364 Make designBand a class member instead of passing it to all
1367 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1369 ReportGenerator: Add lines, a bit like in the desktop version.
1371 * src/main/java/org/glom/web/server/ReportGenerator.java
1372 addToReport(): Use JRDesignLine.
1374 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1376 ReportGenerator: Correct the title positions and use some bold style.
1378 * src/main/java/org/glom/web/server/ReportGenerator.java:
1379 Break the code up into reusable functions, correct the placement of
1380 titles, and use normal/bold styles as in the reports in the desktop
1383 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1385 ReportGenerator: Add a header band to show the field titles.
1387 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1388 getReportHTML(): Pass the localeId to the ReportGenerator
1390 * src/main/java/org/glom/web/server/ReportGenerator.java
1391 constructor: Take the localeID so we can get translated field
1393 generateReport(), addToReport(), addFieldToBand(): Add field
1394 titles in a column header band.
1396 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1398 Reports drop-down list: Some improvement.
1400 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1401 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1402 Adedd setSelectedReport(),
1403 setReportList(): Add a blank line so that the user can select the
1405 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1406 start(): Show the current report by calling setSelectedReport().
1407 This does not seem to work yet.
1409 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1411 DetailsActivity, ListActivity: Move some variables into a base class.
1413 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1414 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1415 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1416 the clientFactory, documentID, tableName and authenticationPopup into
1417 a base class, to avoid duplication.
1419 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1421 Translate the Reports label.
1423 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1424 Get the "Reports" label string from the constants.
1425 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1426 perties: Add Reports to the constants.
1428 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1430 Reports: Implement grouping.
1432 * src/main/java/org/glom/web/server/ReportGenerator.java:
1433 Handle LayoutItem_GroupBy items and try to do the right thing
1434 with JRDesignGroup. It seems to work.
1436 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1438 Actually show some data with JasperReports.
1440 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1441 getReportHTML(): Move most code into a ReportGenerator class.
1442 * src/main/java/org/glom/web/server/ReportGenerator.java:
1443 Recurse into sub-groups, adding fields to the JasperDesign's details
1444 band. Note that we must set an arbitrary width and height, or it just
1445 will not show any data.
1447 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1449 Reports Chooser: Show the titles, not the names.
1451 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1452 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1453 and the names as the values.
1454 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1455 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1456 group now that we provide the report name, so it should always
1459 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1461 Depend on jasperreports.
1463 * pom.xml: Add the dependency. My plan is to use this on the
1466 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1468 Implement navigation to report places.
1470 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1471 start(): Do not bother to handle all events here.
1472 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1473 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1474 Added getSelectedReport().
1475 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1476 .java: start(): When handling a change to the reports chooser,
1477 call getSelectedReport() and goTo() its ReportPlace.
1478 * src/main/java/org/glom/web/client/ui/ReportView.java
1479 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1480 Added setReportHTML() which puts the html in a gwt HTML widget.
1481 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1482 getReportHTML(): Return "TODO" just to show that this works.
1484 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1486 Make ReportPlace usable.
1488 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1489 Mention ReportPlace.
1490 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1491 Correct the @prefix annotation.
1493 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1495 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1497 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1498 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1500 Change getReportLayout() to getReportHMTL() because we will not need to
1501 parse or render the report layout on the client side.
1502 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1503 getReportLayout(): Return the libglom LayoutGroup type because we will
1504 not need to convert to a shared type, because this will not be used on
1506 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1509 Note that there is still no implementation for this.
1512 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1514 Add a (empty) Report Place, View, and Activity.
1516 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1518 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1519 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1520 this into a superclass:
1521 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1522 and also use it as the base of this new ReportPlace:
1523 * src/main/java/org/glom/web/client/place/ReportPlace.java
1525 * src/main/java/org/glom/web/client/ui/ReportView.java
1526 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1527 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1528 Add these, containing mostly boiler-plate for now.
1530 * src/main/java/org/glom/web/client/OnlineGlomService.java
1531 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1532 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1533 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1534 Add API to get the LayoutGroup for the report.
1536 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1538 Add and fill a Reports drop-down list box.
1540 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1542 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1543 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1545 Added getReports(document, table, localeID), calling
1546 ConfiguredDocument.getReports().
1547 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1548 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1549 Added setReportsList() and a list widget.
1550 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1551 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1556 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1558 Translations: Add Esperanto.
1560 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1561 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1562 properties: Add this translation because someone took the time to make it.
1564 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1566 Adapt to the java-libglom 1.21.7 API.
1568 * src/main/java/org/glom/web/server/ReportGenerator.java:
1569 addToReport(): get_group_secondary_fields() is now
1570 get_secondary_fields().
1573 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1575 Use the latest java-libglom version.
1577 * pom.xml: Use java-libglom 1.21.7.
1579 2012-03-03 Ben Konrath <ben@bagu.org>
1581 Display date and time in details view.
1583 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1585 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1587 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1589 Require the latest java-libglom.
1591 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1593 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1595 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1597 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1598 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1599 an empty quickfind string. I also corrected libglom to create only
1600 empty where clauses for empty quickfind strings, but this avoids the
1603 2012-02-24 Ben Konrath <ben@bagu.org>
1605 Improve the tabs in the Notebook widget.
1609 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1611 Translations: Try to translate the strings.
1613 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1614 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1615 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1616 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1617 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1618 Take the Open translation from GTK+'s .po files.
1619 Take the Details translation from Glom's po files.
1620 I have added the other strings to Glom so we can get translations that way:
1621 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1623 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1625 TableSelectionViewImpl: Put the search label and entry in a div.
1627 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1628 Put the search widgets in a FlowTable so that the CSS can be used to
1629 style them while keeping them together.
1630 * src/main/webapp/style.css: Mention the new div.
1632 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1634 Translate more strings in more locales.
1636 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1637 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1638 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1639 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1640 Translate the "Details" and "Open" string too.
1642 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1643 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1644 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1645 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1646 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1647 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1648 Add these new locales as placeholders though they currently contain English.
1650 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1652 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1655 Check the ConfiguredDocument* for null before using it.
1657 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1659 Tell Eclipse about the generated java files.
1661 * .classpath: This lets it find OnlineGlomConstants.java.
1662 It would be nice if Eclipse just used the maven build files.
1664 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1666 Prevent a crash when no locale is specified in the URL.
1668 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1669 Avoid returning a null string, obtained from
1670 Window.Location.getParameter(). This caused a crash when it was
1671 later passed to libglom's API.
1672 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1673 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1674 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1675 guard against future null strings.
1677 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1679 Use the ?locale= query param instead of the &lang= token param.
1681 * src/main/java/org/glom/web/client/place/ListPlace.java
1682 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1683 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1684 Remove the lang token key and value.
1686 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1687 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1688 When the user selects a different locale from the chooser, use
1689 Window.Location.assign() to change the URL, which then causes a reload.
1691 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1692 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1693 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1694 * src/main/java/org/glom/web/client/activity/ListActivity.java
1695 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1696 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1697 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1698 * src/main/java/org/glom/web/client/ui/ListView.java:
1699 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1701 Remove localeID member variables and method/constructor parameters, instead
1702 using Utils.getCurrentLocaleID() when we need a localID to pass to
1705 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1707 Internationalize the UI strings.
1709 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1710 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1711 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1712 because it is unused. Messages are apparently strings that can have
1713 parameters, but we do not need that yet, so Contants will be enough for now.
1714 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1715 to say that we support the en and de locales.
1716 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1717 The original English strings.
1718 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1719 Some German translations of the English strings.
1720 The i18n goal then uses the .properties file to generate an
1721 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1722 returns an implementation that returns the translated strings.
1723 The documentation suggests putting these in src/java/*/client/, but it seems
1724 best to put it in src/resources/*/client/.
1725 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1726 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1727 instead of hard-coding them.
1728 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1729 but that does not seem to stop the build, though it confuses Eclipse.
1731 You can see the translated string by adding ?locale=de to the URL, like so:
1732 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1734 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1736 Improve null/empty String checks.
1738 * pom.xml: Add a dependency on commons-lang, to use
1739 org.apache.commons.lang.StringUtils.
1740 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1741 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1742 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1743 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1744 Use StringUtils.isEmpty().
1746 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1747 StringUtils class with a static isEmpty() function because we
1748 cannot use org.apache.commons.lang.StringUtils in client-side
1749 GWT code because it (apparently) cannot be compiled to javascript.
1750 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1751 * src/main/java/org/glom/web/client/activity/ListActivity.java
1752 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1753 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1754 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1755 * src/main/java/org/glom/web/client/place/ListPlace.java
1756 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1757 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1758 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1759 * src/main/java/org/glom/web/client/ui/details/Group.java
1760 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1761 our StringUtils.isEmpty() function.
1763 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1765 Update to the latest java-libglom API.
1767 * pom.xml: Require java-libglom 1.21.4.
1768 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1769 getDocumentInfo(), getListViewLayoutGroup():
1770 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1772 * src/main/java/org/glom/web/server/database/DBAccess.java
1773 getFieldsToShowForSQLQueryAddGroup(),
1774 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1775 with either get_database_title_original() or
1776 get_database_title(localeID).
1778 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1780 ConfiguredDocument: Avoid a null pointer exception.
1782 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1783 Initialize localeID to "" to avoid returning a null String which
1784 causes a crash in java-libglom's swing-generated code.
1786 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1788 Some simple renaming.
1790 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1791 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1792 for localeChooser. This seems more appropriate and is less ambiguous
1793 particularly in the .css file.
1795 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1797 ConfiguredDocument: Rename the localedID private member variable.
1799 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1801 Adapt to the latest java-libglom API from git master.
1803 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1804 libglom now uses only Vector instead of List, which uses add() instead of
1807 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1809 ConfiguredDocument: Rename the localedID private member variable.
1811 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1813 Build a source tarball with mvn assembly:single
1815 * assembly.xml: Add this file.
1816 * pom.xml: Use the maven-assembly-plugin and tell it to use
1817 our assembly.xml file.
1819 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1821 OnlineGlomServiceImpl: Get .glom files recursively.
1823 * pom.xml: Depend on commons-io from org.apache.commons.
1824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1825 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1826 files recursively, and with the easier filter for the extension.
1827 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1828 simplify that code too.
1830 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1832 README: Mention that you must install java-libglom packages separately.
1834 But then it works, because java-libglom is now in the central maven
1837 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1839 locales drop-down: Show the correct selected locale when the URL changes.
1841 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1842 .java: setPlace(): Move some code into fillView().
1844 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1846 locales drop-down: Do not lose the primary key.
1848 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1849 start(): onLocaleChange(): Pass the current primary key value,
1850 instead of an empty value.
1852 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1854 locales drop-down: Do not lose the drop-down selection.
1856 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1857 .java (TableSelectionActivity.fillView): Set the selected locale
1858 after changing the drop-down items (though we do not really need
1859 to change them just because the locale changes.)
1861 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1863 locales drop-down: Change the tables list when this changes.
1865 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1866 .java: TableSelectionActivity.start(): Move the async table titles
1867 retrieval into a private fillView() method and also call this when
1868 the chosen locale changes.
1869 Note that the document title is not actually translatable yet, but
1870 that is a problem that I should fix soon in libglom.
1872 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1874 Improve the placement of the locales drop-down.
1876 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1877 Put the title and locales drop-down in a div (gwt.FlowTable).
1878 * src/main/webapp/style.css: Add magic css properties to make this work.
1879 Also remove the left margin from the title so that it lines up with the
1882 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1884 locales selector: Show human-readable locale titles.
1886 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1887 getDocumentInfo(): Use java.util.Locale to show a real title of
1888 each locale, in the locale's own language.
1890 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1892 Add a language/locale selector drop-down.
1894 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1895 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1896 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1897 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1898 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1899 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1900 Add a ListBox to show the available locales. Add getLocaleSelector(),
1901 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1902 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1903 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1904 java: Add these classes.
1905 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1906 start(): Fill the locales ListBox. Handle its change event, firing a
1908 setPlace(): Show the selected locale as specified by the URL token.
1909 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1910 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1911 Handle LocaleChangeEvent, going to a new *Place with that locale.
1913 The placement of the ListBox is not pretty, and it currently uses the ID
1914 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1918 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1920 Search box: Show the search text from the URL token.
1922 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1923 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1924 Add setQuickFindText().
1925 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1926 .java: setPlace(): Store the queryText if the place is a ListPlace,
1927 and call TableSelectionView.setQuickFindText().
1929 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1931 Allow use of translations via, for instance, &lang=de in the URL.
1933 * pom.xml: Use the unstable java-libglom 1.21 version.
1935 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1936 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1938 init(): Instead of calling TranslatableItem.set_current_locale()
1939 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1940 However, this is only for default locales, which are not needed to
1941 change the locale in the URL.
1942 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1943 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1944 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1945 layout for a particular locale.
1946 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1947 Add get/setDefaultLocaleID().
1948 getDocumentInfo(), getListViewData(), getRelatedListData(),
1949 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1950 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1951 localeID parameter, so we can get the layout for a particular locale.
1953 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1954 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1955 * src/main/java/org/glom/web/client/place/ListPlace.java:
1956 Parse and construct a lang parameter too.
1958 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1959 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1960 passed to subsequent methods and constructors.
1961 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1962 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1963 Store the localeID from the *Place and pass it to other constructors
1964 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1966 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1967 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1968 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1969 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1970 * src/main/java/org/glom/web/client/ui/ListView.java:
1971 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1972 Take localeID parameters and pass them to subsequent constructors and
1973 methods, so that the layout is always retrieved for that locale.
1975 This is rather repetitive.
1977 Note that "" means the original (default) locale of the Glom document,
1978 which is usually English.
1980 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1982 Documents: Remove final keyword to fix startup configuration.
1984 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1985 final keywords on the private member variables because that breaks
1986 the startup, apparently (there are warnings) because it stops them
1987 from being serialized. I added these in the previous commit.
1989 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1991 Documents: Add some final keywords.
1993 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1996 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1998 OnlineGlomServiceImpl: Add to overview comments.
2000 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2001 Note that this is where all the document are loaded. They are not
2002 loaded freshly for each page.
2004 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2008 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2009 Add a TextBox for the text of a quick find.
2010 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2012 setBackLink(): Add a String quickFind parameter.
2013 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2014 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2015 to the base interface, because that is how TableSelectionViewImpl is used.
2016 * src/main/webapp/style.css: Add style for the search box and its label.
2018 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2019 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2020 Add these files, based on the existing TableChangeEvent and
2021 TableChangeEventHandlers.
2022 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2023 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2024 a ListPlace() that the user should be taken to.
2025 * src/main/java/org/glom/web/client/activity/ListActivity.java
2026 start(): Handle it here too and adapt the TableChangeEvent handler to
2027 pass the extra "" quickFind parameter to ListPlace.
2028 * src/main/java/org/glom/web/client/place/ListPlace.java:
2029 Constructor: Take an extra String quickFind parameter and store it,
2030 returning it from a new getQuickFind() method.
2031 getToken(): Put the quickFind text in the URL token.
2032 getPlace(): Parse the quickFind text from the URL token.
2033 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2034 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2035 ListPlace constructor.
2036 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2037 .java: start(): Add a Change handler for the TableSelectionView's
2038 TextBox (via its base HasChangeHandlers interface), firing the new
2039 QuickFindChangeEvent.
2040 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2041 pass the extra "" quickFind parameter.
2043 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2044 setCellTable(): Add a String quickFind parameter and pass it to
2045 the ListViewTable() constructor.
2046 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2047 setCellTable() in the base interface, because that is how ListViewImpl
2050 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2051 Add a String quickFind member variable.
2052 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2053 Constructor: Add a String quickFind parameter, storing it in the
2054 base ListTable's member variable.
2055 onRangeChanged(): Pass quickFind to the
2056 OnlineGlomServiceAsync.getSortedListViewData() and
2057 OnlineGlomServiceAsync.getListViewData() methods.
2059 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2060 getListViewData(), getSortedListViewData(): Add a String quickFind
2061 parameter, passing it to ConfiguredDocument.getListViewData().
2062 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2063 Change getListViewData(), getSortedListViewData() in the base interface,
2064 because that is how OnlineGlomServiceImpl is used, via this:
2065 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2066 Change getListViewData(), getSortedListViewData() here too.
2067 This class can apparently be used to asynchronously call methods on
2068 OnlineGlomService, and GWT seems to implement that after recognizing
2069 just the *Async name convention and the extra AsyncCallback parameters.
2071 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2072 getListViewData(): Add a String quickFind parameter, and pass it to
2073 ListViewDBAccess.getData().
2074 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2075 getListData(): Add a String quickFind parameter and pass it to
2077 getSelectQuery(): Add a String quickFind parameter.
2078 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2079 getSelectQuery(): Add a String quickFind parameter and use it with
2080 Glom.get_find_where_clause_quick() to pass a where_clause to
2081 Glom.build_sql_select_with_where_clause(), to actually filter the
2083 getData(): Add a String quickFind parameter, passing it to getListData().
2084 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2085 va: getData(): Pass an empty string to getListData() for the
2086 quickFind parameter.
2088 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2090 ListTable: Minor change.
2092 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2093 createCellTable(): Make this protected instead of public.
2095 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2097 Many files: Use final for the parameters and use the @override attribute.
2099 2012-01-22 Ben Konrath <ben@bagu.org>
2101 Add anchor links for single line text that starts with http, ftp and www.
2105 2012-01-22 Ben Konrath <ben@bagu.org>
2107 Add ellipsis to single line text in details view.
2111 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2113 Remove all javadoc author tags.
2115 Because they are awkward and meaningless when many people touch
2117 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2119 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2121 Revert the COPYING.LESSER to COPYING rename.
2123 Apparently both should be there if it is LGPL.
2125 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2127 *View: Remove unused imports.
2129 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2130 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2131 * src/main/java/org/glom/web/client/ui/ListView.java:
2132 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2133 Remove unused imports, as suggested by Eclipse.
2135 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2137 Move the *View::Presenter types, and some API into one base View.
2139 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2140 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2141 * src/main/java/org/glom/web/client/ui/ListView.java:
2142 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2143 Presenter, setPresenter() and clear() into a shared base interface,
2144 to avoid the unnecessary duplicate Presenter types and to more clearly
2145 show how the *Views share the same structure, even if they are not
2146 used polymorphically.
2148 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2149 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2151 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2152 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2153 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2155 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2158 Feel free to revert this if there is a good reason for the duplicate
2161 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2163 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2165 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2166 a class member instead of a local variable in the method.
2167 This lets us use it to get the view instances, for use in tests.
2168 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2169 beforeOnlineGlom(): Test some more details of the initial view.
2170 Again, this is not very useful.
2172 To really test gwt-glom we will need to start a local postgresql
2173 instance with local data, like the Glom tests in C++.
2175 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2177 pom.xml: Mention the LGPL license.
2179 * pom.xml: Add a licenses section.
2180 * COPYING.LESSER: Move this to COPYING, which
2181 previously contained the GPL. But gwt-glom is all LGPL.
2183 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2185 Add project information to README and pom.xml.
2187 * README: Add a brief description and mention some mvn
2189 * pom.xml: This extra information shows up in mvn site
2192 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2194 Use the latest java-libglom version.
2196 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2198 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2200 GwtTestOnlineGlom: Test a little more.
2202 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2203 protected rather than private, as suggested by the gwt-test-utils
2205 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2206 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2207 Test the initial visibility of the panels.
2209 However, this is not a very useful test.
2210 And I wonder how we should generally test using this idea for an
2211 activity/places app like ours where the real changes happen implicitly
2212 based on the history token/URL.
2214 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2216 Slight modification to *Mapper comments.
2218 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2219 (DataActivityMapper)
2220 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2222 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2224 Remove comments mentioning GIN because they are just copied from
2225 the example code and are apparently not helpful:
2226 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2227 Also change the mention of a class that is only in the example code.
2229 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2231 GwtTestOnlineGlom test: Minor changes.
2233 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2234 Avoid the long qualified class name and modify the comment
2235 because it is now obvious to me that the mocked class is the only
2236 custom one created via GWT.create().
2238 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2240 Tests: Added the beginnings of a test using gwt-test-utils.
2242 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2243 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2244 which tells gwt-test-utils what class will be tested.
2245 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2246 Add a simple (but empty) test case. One class, used by the OnlineGlom
2247 class, is mocked so that it can be created. However, I am not sure
2248 why only this class needs to be mocked.
2250 Note that mockito seems more popular, and clearer, than easymock,
2251 but I have not got that working yet. It might be a matter of the
2254 This test is run during mvn integration-test.
2256 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2258 Tests: Use junit4-style syntax instead of junit3-style.
2260 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2261 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2262 * src/test/java/org/glom/web/shared/DataItemTest.java:
2263 Use the @Test annotation rather than relying on the test*() prefix.
2264 Also no longer implement TestCase, to avoid triggering support for
2265 the junit3-way, which stops the annotations from working.
2266 Change the imports from import junit.framework.* to
2267 import org.junit.*, which is apparently the new way.
2269 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2271 Added a test for ListPlace token parsing and creation.
2273 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2274 This is much the same as DetailsPlaceTest.
2276 I wonder how we could test the other parts of the *Place API.
2278 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2280 DetailsPlace test: Also test getToken() and recreation via getPlace().
2282 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2283 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2284 recreate it, testing the recreated DetailsPlace for the same parameter
2287 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2289 Use the surefire-report plugin.
2291 * pom.xml: This generates a HTML report about the tests in
2292 target/site/surefire-report.html
2293 when you do mvn surefire-report:report. It seems to be popular/normal.
2295 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2297 Added a test for DetailsPlace.
2299 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2300 Test the getPlace() token parsing.
2302 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2304 Added a first unit test.
2306 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2307 * src/test/java/org/glom/web/shared/DataItemTest.java:
2308 This is a silly test but it is just to get things started. Note that
2309 maven/junit finds the test because it looks in src/test by default.
2311 2011-12-22 Ben Konrath <ben@bagu.org>
2313 Change charsetName to "UTF-8" when replacing line breaks.
2315 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2316 that work in Java (such as "UTF8") will not work when compiled to
2319 This fixes a problem with multi-line details view fields that have hard
2320 line breaks. The "License Text" field on this page demonstrates the
2323 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2325 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2327 2011-12-22 Ben Konrath <ben@bagu.org>
2329 Fix another bug with related list navigation.
2331 I've tested all the navigation buttons in all of the related lists
2332 so things should be good now.
2334 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2336 2011-12-22 Ben Konrath <ben@bagu.org>
2338 Fix a crasher when refreshing the list view with the default table.
2340 This crash will also happen when loading the list view with the default
2341 table from a link or bookmark.
2343 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2344 to the main document selection page when the document id hasn't been
2346 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2347 the main document selection page when the document id hasn't been
2349 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2350 values for the details place when the document id hasn't been set.
2351 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2352 values for the list place when the document id hasn't been set.
2354 2011-12-21 Ben Konrath <ben@bagu.org>
2356 Protect against NPE when glom.document.locale is not in config.
2358 This patch protects against an NPE when glom.document.locale is not in
2359 the config file. This NPE will also happen if glom.document.locale is
2362 The patch also updates the error message to display the class name when
2363 the getMessage() returns null. This was happening when the NPE was
2364 thrown and I had "Configuration Error: null". If an NPE is encountered
2365 with this patch, "Configuration Error: NullPointerException " will be
2368 This commit closes this bug:
2370 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2372 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2374 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2376 Rename onlineglom.properties to onlineglom.properties.sample.
2378 * src/main/resources/onlineglom.properties: Rename to:
2379 * src/main/resources/onlineglom.properties.sample:
2380 * src/main/resources/README: And add this file explaining that people
2381 should rename it back when deploying.
2383 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2385 Allow choosing the translation in the .properties file.
2387 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2388 init(): Read a glom.document.locale value from the configuration file
2389 and call Glom's TransatableItem::set_current_locale() method.
2390 * src/main/resources/onlineglom.properties: Add a commented-out
2391 example of this new setting.
2393 It would be better to add &lang=de_DE to the URL, but the current
2394 libglom API does not allow us to do this easily. I am working on that.
2396 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2398 Avoid a crash in parsing of token parameters.
2400 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2401 ava: getTokenParams(): Do not crash if a parameter has a key but no
2402 value, and ignore parameters with neither.
2404 2011-12-17 Murray Cumming <murrayc@murayc.com>
2406 History token building/handling: Improve use of token parameters.
2408 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2409 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2410 and buildParamsToken(HashMap), for use by derived classes.
2411 Make the separator private because it is no longer be needed.
2412 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2413 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2414 instead of manual string concatenation.
2415 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2416 of hardcoded indices and awkward splitting code.
2417 * src/main/java/org/glom/web/client/place/ListPlace.java
2418 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2419 instead of manual string concatenation.
2420 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2421 of hardcoded indices and awkward splitting code.
2422 This should fix bug #666420
2424 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2426 Fix a Navgiation->Navigation typo in the code.
2428 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2429 Rename processNavgiation() to processNavigation().
2431 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2433 Fix a seperator->separator typo in the code.
2435 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2436 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2437 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2440 2011-12-15 Ben Konrath <ben@bagu.org>
2442 Cleanup some comments.
2444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2446 2011-12-14 Ben Konrath <ben@bagu.org>
2448 Replace \n with <br/> for multiline text in the details view.
2450 Vertical scrollbars are added when needed as well.
2452 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2454 2011-12-14 Ben Konrath <ben@bagu.org>
2456 Specify the font for document selection links.
2458 * src/main/webapp/style.css:
2460 2011-12-14 Ben Konrath <ben@bagu.org>
2462 Fix bouncy CellTable while paging.
2464 This doesn't currently work with related list tables in unselected
2467 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2469 2011-12-14 Ben Konrath <ben@bagu.org>
2471 Revamp the appearance of the document selection page.
2473 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2474 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2475 * src/main/webapp/style.css:
2477 2011-12-13 Ben Konrath <ben@bagu.org>
2479 Set navigation button column to the smallest size possible.
2481 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2483 2011-12-13 Ben Konrath <ben@bagu.org>
2485 Change OpenButton nomenclature to NavigationButton.
2487 Using NavigtionButton makes things more generic. Classes, methods and
2488 variables have been changed.
2490 This is a rename-only refactor.
2492 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2493 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2494 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2495 Renamed from OpenButtonCell.
2496 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2497 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2498 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2500 2011-12-12 Ben Konrath <ben@bagu.org>
2502 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2504 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2505 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2506 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2507 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2509 2011-12-12 Ben Konrath <ben@bagu.org>
2511 Update variable names and comments.
2513 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2514 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2516 2011-12-12 Ben Konrath <ben@bagu.org>
2518 Properly initialize numNonEmptyRows variable to zero.
2520 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2521 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2523 2011-12-05 Ben Konrath <ben@bagu.org>
2525 Add latest mockup with HTML tables.
2527 Features of this mockup:
2529 -> HTML table for flowtable
2530 -> HTML table for flowtable column
2531 -> Example of how related lists would look
2532 -> Not using text entries for data items
2534 The current version of Online Glom doesn't use HTML tables for the
2537 This mockup has been sent to the glom-devel mailing list but it's good
2538 to have it here as well.
2540 * mockups/details-view-html-tables.html:
2542 2011-12-05 Ben Konrath <ben@bagu.org>
2544 Remove unnecessary getPrimaryKeyField() method.
2546 getPrimaryKeyFieldForTable(String) has been renamed to
2547 getPrimaryKeyField(String).
2549 * src/main/java/org/glom/web/server/database/DBAccess.java:
2550 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2551 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2553 2011-12-05 Ben Konrath <ben@bagu.org>
2555 Add string representation of TypedDataItem value to conversion error message.
2557 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2558 message was extracted into its own method to avoid duplication.
2560 2011-12-05 Ben Konrath <ben@bagu.org>
2562 Add type checking to navigation primary key value creation.
2564 Create navigation primary key only if the expected type from the Glom
2565 document matches the type returned by the SQL query.
2567 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2569 2011-12-05 Ben Konrath <ben@bagu.org>
2571 Rename a couple of variables in RelatedListNavigation.
2573 This is a rename-only refactor.
2575 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2577 2011-12-05 Ben Konrath <ben@bagu.org>
2579 Move getListLayoutGroup() into getListViewLayoutGroup().
2581 This removes getListLayoutGroup(). It was only being called by
2582 getListViewLayoutGroup().
2584 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2586 2011-12-05 Ben Konrath <ben@bagu.org>
2588 Remove check for LayoutItem_Portal in list table method.
2590 This check is no longer necessary because the method isn't being used
2591 to create the LayoutItemPortal DTO.
2593 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2595 2011-12-05 Ben Konrath <ben@bagu.org>
2597 Properly support related list navigation.
2599 Navigation from the "Repository Analyzer -> Package Scans ->
2600 Dependencies" related table wasn't working because the primary key for
2601 related tables wasn't being set properly. This commit fixes the
2604 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2605 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2606 doesn't set the primary key properly for related list tables.
2607 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2608 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2609 useful for getting the primary key for list view tables and for related
2611 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2612 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2613 Move code to set the primary key for the table from the abstract
2614 ListDBAccess class to ListViewDBAccess as it's only correct for list
2616 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2617 Properly add primary key to related list tables.
2619 2011-12-02 Ben Konrath <ben@bagu.org>
2621 Properly set the horizontal alignment of fields.
2623 This fix is for both the list tables and the details view.
2625 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2626 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2627 to set the horizontal alignment of fields.
2629 2011-12-02 Ben Konrath <ben@bagu.org>
2631 Display currency codes in the details view.
2633 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2635 2011-12-02 Ben Konrath <ben@bagu.org>
2637 Avoid duplicate JNI call.
2639 JNI is not as efficient as pure Java and this is an easy (and small)
2642 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2643 Use previously retrieved value for whereClauseToTableName instead of
2646 2011-12-02 Ben Konrath <ben@bagu.org>
2648 Rename a couple of variables in RelatedListNavigation.
2650 This is a rename-only refactor.
2652 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2654 2011-12-02 Ben Konrath <ben@bagu.org>
2656 Indicate clearly that a mismatched primary key type is a bug.
2658 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2659 warning to error. Add 'This is a bug.' to message.
2661 2011-12-02 Ben Konrath <ben@bagu.org>
2663 Update / fix some comments.
2665 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2667 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2669 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2670 Fix comments. Add some TODOs.
2672 2011-12-02 Ben Konrath <ben@bagu.org>
2674 Enable navigation to details view with string primary key from related list.
2676 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2677 Create a text primary key value when return type of result is
2678 java.sql.Types.VARCHAR.
2680 2011-12-02 Ben Konrath <ben@bagu.org>
2682 Use checkboxes for booleans in the details view.
2684 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2686 2011-12-01 Ben Konrath <ben@bagu.org>
2688 Improve performance of related list height calculation.
2690 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2691 Put code to calculate the expected height in a static initializer so
2692 that that it's only called once.
2694 2011-12-01 Ben Konrath <ben@bagu.org>
2696 Show related list tables in notebooks (again).
2698 Calculate the height of the related list tables so the Notebook can be
2699 set the correct height. The height of the related list table is also needed by
2700 FlowTable to be able decide how to create the layout.
2702 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2703 and set the Portal height based on the height of the related list
2704 table and the Portal container.
2705 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2706 Add method to calculate the height of the related list tables.
2707 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2708 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2709 calculate the height of the Pager widget.
2711 2011-12-01 Ben Konrath <ben@bagu.org>
2713 Use CellTable API for table property instead of setting style on Element.
2715 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2717 2011-12-01 Ben Konrath <ben@bagu.org>
2719 Make ListViewTable and RelatedListTable a consistent height.
2721 The tables are now a consistent height regardless of the contents of
2722 the table. A hidden button is added to empty rows to ensure that the
2723 height of these rows will match the height of rows with data.
2725 A navigation button column is now added to every table. The width of
2726 the navigation column is set to 0px when a RelatedListTable shouldn't
2727 have navigation buttons. This maintains the a consistent row height in
2728 tables that don't show the navigation buttons.
2730 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2731 navigation column when not needed.
2732 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2733 arguments for navigation button to constructor of ListViewTable.
2734 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2735 hidden button for empty data rows.
2736 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2737 arguments for navigation button to constructor.
2738 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2739 create navigation buttons. Add hideNavigationButtons() method.
2740 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2741 arguments for navigation button to constructor.
2743 2011-12-01 Ben Konrath <ben@bagu.org>
2745 Use 'visibility: hidden' in Utils.getWidgetHeight().
2747 This is better choice because hidden elements are invisible, don't
2748 respond to events and are not part of the tab order. They will,