1 2012-04-25 Murray Cumming <murrayc@murrayc.com>
3 Add a Field class and implement some loading of it in Document.
5 2012-04-25 Murray Cumming <murrayc@murrayc.com>
7 Initial Document loading implementation, instead of libglom.
9 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
10 and Translatable classes, and adapt the rest of the code to use them.
11 However, this is still missing Layout and Field classes and loading.
13 2012-04-24 Murray Cumming <murrayc@murrayc.com>
15 Use of jOOQ: Move Field creation into a utility method.
17 * src/main/java/org/glom/web/server/SqlUtils.java:
18 This lets us improve it more easily.
20 2012-04-24 Murray Cumming <murrayc@murrayc.com>
22 Use of jOOQ: Improve the code to COUNT a sub-select.
24 * src/main/java/org/glom/web/server/SqlUtils.java:
25 Move initial query creation into
26 build_sql_select_step_with_where_clause().
27 build_sql_select_count_rows(): Use the jOOQ API instead of
28 concatentating text, because a jOOQ Select*Step is a TableLike,
29 which is what from() takes.
31 2012-04-23 Murray Cumming <murrayc@murrayc.com>
33 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
35 * pom.xml: Depend on jooq.
36 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
37 methods with jOOQ, based on the C++ implementations in libglom,
38 with some changes to the logic required by jooQ.
39 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
41 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
42 * src/main/java/org/glom/web/server/ReportGenerator.java:
43 * src/main/java/org/glom/web/server/SqlUtils.java:
44 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
45 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
46 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
47 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
48 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
49 Adapt. In particular, the SqlUtils methods now need to take a Connection,
50 because jOOQ needs that, though it seems unnecessary.
52 This is not quite finished. Ideally jOOQ would help us to build
53 table_name.field_name names, quoting and escaping them properly.
54 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
56 2012-04-21 Murray Cumming <murrayc@murrayc.com>
58 Move use of Glom.build_sql*() into a new SqlUtils class.
60 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
61 to wrap Glom.build_sql*(). The parameter types are still Glom one,
62 but this will make it easier to start using something other than
63 libglom or SqlBuilder.
65 2012-04-21 Murray Cumming <murrayc@murrayc.com>
67 Update the project URL.
69 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
71 2012-04-21 Murray Cumming <murrayc@murrayc.com>
73 Main layout: Use a FlowTable instead of absolute positioning.
75 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
76 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
77 child panels/widgets must have an absolute position. But that is annoying, so
78 this adds a FlowTable and puts the child panels in there.
80 2012-04-21 Murray Cumming <murrayc@murrayc.com>
82 GwtTestOnlineGlom: Comment out unused code.
84 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
85 Eclipse has started to say that some code is unused.
87 2012-04-21 Murray Cumming <murrayc@murrayc.com>
89 Update to the latest versions of dependencies.
91 * pom.xml: Update version numbers of dependencies to the latest
93 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
94 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
95 * src/main/java/org/glom/web/server/ReportGenerator.java:
96 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
97 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
98 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
100 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
101 Modify the imports where necessary.
103 2012-04-17 Murray Cumming <murrayc@murrayc.com>
105 Style: Remove overflow:hidden from searchbox
107 * src/main/webapp/style.css: Because this pushes the Back To Link
108 label/link on to the next row, which is then hidden due to the
109 hard-coded (in ems) height.
111 2012-04-20 Murray Cumming <murrayc@murrayc.com>
113 Remove some duplicate code.
115 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
116 getDocumentInfo(): This must have been duplicated during the merge from the
121 2012-04-19 Murray Cumming <murrayc@murrayc.com>
123 Reports: Localize the waiting for report message.
125 * src/main/java/org/glom/web/client/activity/ReportActivity.java
126 start(): Get the message from the contants.
127 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
129 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
130 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
131 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
132 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
133 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
134 Update these files with the English text for newer strings for now.
136 2012-04-19 Murray Cumming <murrayc@murrayc.com>
138 Reports: Show a message while waiting for the report.
140 * src/main/java/org/glom/web/client/ui/ReportView.java
141 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
142 Add setWaitingText(), to show a message saying that we are
143 waiting for the report to be ready.
144 * src/main/java/org/glom/web/client/activity/ReportActivity.java
145 start(): Call setWaitingText() before calling the async
148 2012-04-19 Murray Cumming <murrayc@murrayc.com>
150 ReportGenerator: Specify date and time formats.
152 * src/main/java/org/glom/web/server/ReportGenerator.java:
153 createFieldValueElement(): Use the default (and localized)
154 short formats, though we still need a way to show 4-digit
155 years without providing the format for every locale.
156 * src/main/java/org/glom/web/server/database/DBAccess.java:
157 convertResultSetToDTO(): Use the short formats here too.
159 2012-04-18 Murray Cumming <murrayc@murrayc.com>
161 ReportGenerator: Use the correct numeric formatting.
163 * src/main/java/org/glom/web/server/ReportGenerator.java
164 createFieldExpression(), createFieldValueElement(): Take the
165 whole LayoutItem_Field instead of just the field name, so
166 we have access to the formatting.
167 createFieldValueElement(): Use JRTextField.setPattern() to
168 specify the numeric formatting, with the help of a
169 regular DecimalFormat.
171 2012-04-18 Murray Cumming <murrayc@murrayc.com>
173 ReportGenerator: Avoid showing null for group by titles.
175 * src/main/java/org/glom/web/server/ReportGenerator.java
176 generateReport(): Use setBlankWhenNull() on the field title
177 style too, because this is used for values in group by
180 2012-04-18 Murray Cumming <murrayc@murrayc.com>
182 ReportGenerator: Add a colon to titles in vertical groups.
184 * src/main/java/org/glom/web/server/ReportGenerator.java
185 addFieldToDetailBandVertical(): Pass true for the withColon
188 2012-04-18 Murray Cumming <murrayc@murrayc.com>
190 ReportGenerator: Simplify the code by using Position more.
192 2012-04-18 Murray Cumming <murrayc@murrayc.com>
194 Reports: Support vertical groups, roughly.
196 * src/main/java/org/glom/web/server/ReportGenerator.java:
197 addToReport(): Rename to addGroupToReport() and, if necessary,
198 call the new addVerticalGroupToReport() method.
199 createFieldValueElement(): Let the caller specify the Y position
202 2012-04-17 Murray Cumming <murrayc@murrayc.com>
204 Reports: Allow a second report to be shown.
206 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
207 clear(): Do not remove the HTML widget, which broke the whole layout.
209 2012-04-17 Murray Cumming <murrayc@murrayc.com>
211 Locales drop-down: Show that we use English by default.
213 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
214 fillView(): When we use English, just because that is the default, when
215 no locale is specified, show that in the Locales drop-down instead of
216 just showing the first item.
218 2012-04-17 Murray Cumming <murrayc@murrayc.com>
220 Unselect the Report/Locale/Table combo item when appropriate.
222 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
223 setPlace(): clear reportName if this is not a ReportPlace.
224 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
225 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
226 When the provided name is empty, unselect all items, so that none are
227 indicated. This uses a for loop because I cannot find a single method
230 2012-04-17 Murray Cumming <murrayc@murrayc.com>
232 Report: Give the user a way to get back to the list.
234 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
235 start(), setPlace(): Show the Back To List link on reports, and also
236 interpret selecting the empty report item as back to list.
238 2012-04-13 Murray Cumming <murrayc@murrayc.com>
240 Really show the selected Report name.
242 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
243 setPlace(): Store the reportName here, if it is that kind of Place.
244 fillView(): Set the selected Report after filling the list of reports.
245 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
246 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
247 null Strings, though we need some way to unselect all ListBox items
250 2012-04-13 Murray Cumming <murrayc@murrayc.com>
252 ReportGenerator: Try to avoid some problems.
254 * src/main/java/org/glom/web/server/ReportGenerator.java
255 addField(): Try to avoid duplicates, and avoid using a null
258 2012-04-13 Murray Cumming <murrayc@murrayc.com>
260 Reports: Use quickFind.
262 * src/main/java/org/glom/web/client/OnlineGlomService.java;
263 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
264 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
265 getReportHTML(): Add a quickFind parameter.
266 * src/main/java/org/glom/web/client/activity/ReportActivity.java
267 start(): Pass the quickFind parameter.
268 * src/main/java/org/glom/web/server/ReportGenerator.java
269 generateReport(): Take a quickFind parameter.
271 2012-04-13 Murray Cumming <murrayc@murrayc.com>
273 ReportPlace: Actually use the report name.
275 * src/main/java/org/glom/web/client/place/ReportPlace.java
276 getPlace(): Do not assign the report name to the quickfind.
278 2012-04-13 Murray Cumming <murrayc@murrayc.com>
280 Show java.library.path when complaining.
282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
283 init(): When telling us to check java.library.path, show the
286 2012-03-06 Murray Cumming <murrayc@murrayc.com>
288 ReportGenerator: Do not show nulls.
290 2012-03-06 Murray Cumming <murrayc@murrayc.com>
292 ReportGenerator: Make the title font larger.
294 2012-03-06 Murray Cumming <murrayc@murrayc.com>
296 ReportGenerator: Put field titles inside groups, if there are groups.
298 2012-03-06 Murray Cumming <murrayc@murrayc.com>
300 ReportGenerator: Take the Report itself instead of the name and group.
302 * src/main/java/org/glom/web/server/ConfiguredDocument.java
303 Remove getReportLayoutGroup().
304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
305 getReportHTML(): Pass the report instead
306 of its name and layout group.
307 * src/main/java/org/glom/web/server/ReportGenerator.java
308 generateReport(): Use the report object to use the title
311 2012-03-06 Murray Cumming <murrayc@murrayc.com>
313 ReportGenerator: Remove designBand parameters.
315 * src/main/java/org/glom/web/server/ReportGenerator.java:
316 Make designBand a class member instead of passing it to all
319 2012-03-06 Murray Cumming <murrayc@murrayc.com>
321 ReportGenerator: Add lines, a bit like in the desktop version.
323 * src/main/java/org/glom/web/server/ReportGenerator.java
324 addToReport(): Use JRDesignLine.
326 2012-03-06 Murray Cumming <murrayc@murrayc.com>
328 ReportGenerator: Correct the title positions and use some bold style.
330 * src/main/java/org/glom/web/server/ReportGenerator.java:
331 Break the code up into reusable functions, correct the placement of
332 titles, and use normal/bold styles as in the reports in the desktop
335 2012-03-06 Murray Cumming <murrayc@murrayc.com>
337 ReportGenerator: Add a header band to show the field titles.
339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
340 getReportHTML(): Pass the localeId to the ReportGenerator
342 * src/main/java/org/glom/web/server/ReportGenerator.java
343 constructor: Take the localeID so we can get translated field
345 generateReport(), addToReport(), addFieldToBand(): Add field
346 titles in a column header band.
348 2012-03-05 Murray Cumming <murrayc@murrayc.com>
350 Reports drop-down list: Some improvement.
352 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
353 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
354 Adedd setSelectedReport(),
355 setReportList(): Add a blank line so that the user can select the
357 * src/main/java/org/glom/web/client/activity/ReportActivity.java
358 start(): Show the current report by calling setSelectedReport().
359 This does not seem to work yet.
361 2012-03-05 Murray Cumming <murrayc@murrayc.com>
363 DetailsActivity, ListActivity: Move some variables into a base class.
365 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
366 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
367 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
368 the clientFactory, documentID, tableName and authenticationPopup into
369 a base class, to avoid duplication.
371 2012-03-05 Murray Cumming <murrayc@murrayc.com>
373 Translate the Reports label.
375 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
376 Get the "Reports" label string from the constants.
377 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
378 perties: Add Reports to the constants.
380 2012-03-05 Murray Cumming <murrayc@murrayc.com>
382 Reports: Implement grouping.
384 * src/main/java/org/glom/web/server/ReportGenerator.java:
385 Handle LayoutItem_GroupBy items and try to do the right thing
386 with JRDesignGroup. It seems to work.
388 2012-03-04 Murray Cumming <murrayc@murrayc.com>
390 Actually show some data with JasperReports.
392 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
393 getReportHTML(): Move most code into a ReportGenerator class.
394 * src/main/java/org/glom/web/server/ReportGenerator.java:
395 Recurse into sub-groups, adding fields to the JasperDesign's details
396 band. Note that we must set an arbitrary width and height, or it just
397 will not show any data.
399 2012-03-04 Murray Cumming <murrayc@murrayc.com>
401 Reports Chooser: Show the titles, not the names.
403 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
404 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
405 and the names as the values.
406 * src/main/java/org/glom/web/server/ConfiguredDocument.java
407 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
408 group now that we provide the report name, so it should always
411 2012-02-15 Murray Cumming <murrayc@murrayc.com>
413 Depend on jasperreports.
415 * pom.xml: Add the dependency. My plan is to use this on the
418 2012-01-31 Murray Cumming <murrayc@murrayc.com>
420 Implement navigation to report places.
422 * src/main/java/org/glom/web/client/activity/ReportActivity.java
423 start(): Do not bother to handle all events here.
424 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
425 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
426 Added getSelectedReport().
427 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
428 .java: start(): When handling a change to the reports chooser,
429 call getSelectedReport() and goTo() its ReportPlace.
430 * src/main/java/org/glom/web/client/ui/ReportView.java
431 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
432 Added setReportHTML() which puts the html in a gwt HTML widget.
433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
434 getReportHTML(): Return "TODO" just to show that this works.
436 2012-01-31 Murray Cumming <murrayc@murrayc.com>
438 Make ReportPlace usable.
440 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
442 * src/main/java/org/glom/web/client/place/ReportPlace.java:
443 Correct the @prefix annotation.
445 2012-01-31 Murray Cumming <murrayc@murrayc.com>
447 OnlineGlomService: Return report HTML rather than the LayoutGroup.
449 * src/main/java/org/glom/web/client/OnlineGlomService.java:
450 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
451 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
452 Change getReportLayout() to getReportHMTL() because we will not need to
453 parse or render the report layout on the client side.
454 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
455 getReportLayout(): Return the libglom LayoutGroup type because we will
456 not need to convert to a shared type, because this will not be used on
458 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
461 Note that there is still no implementation for this.
464 2012-01-27 Murray Cumming <murrayc@murrayc.com>
466 Add a (empty) Report Place, View, and Activity.
468 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
470 * src/main/java/org/glom/web/client/place/HasTablePlace.java
471 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
472 this into a superclass:
473 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
474 and also use it as the base of this new ReportPlace:
475 * src/main/java/org/glom/web/client/place/ReportPlace.java
477 * src/main/java/org/glom/web/client/ui/ReportView.java
478 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
479 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
480 Add these, containing mostly boiler-plate for now.
482 * src/main/java/org/glom/web/client/OnlineGlomService.java
483 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
484 * src/main/java/org/glom/web/server/ConfiguredDocument.java
485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
486 Add API to get the LayoutGroup for the report.
488 2012-01-23 Murray Cumming <murrayc@murrayc.com>
490 Add and fill a Reports drop-down list box.
492 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
494 * src/main/java/org/glom/web/client/OnlineGlomService.java:
495 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
496 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
497 Added getReports(document, table, localeID), calling
498 ConfiguredDocument.getReports().
499 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
500 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
501 Added setReportsList() and a list widget.
502 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
503 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
508 2012-04-12 Murray Cumming <murrayc@murrayc.com>
510 Translations: Add Esperanto.
512 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
513 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
514 properties: Add this translation because someone took the time to make it.
516 2012-03-15 Murray Cumming <murrayc@murrayc.com>
518 Adapt to the java-libglom 1.21.7 API.
520 * src/main/java/org/glom/web/server/ReportGenerator.java:
521 addToReport(): get_group_secondary_fields() is now
522 get_secondary_fields().
525 2012-03-15 Murray Cumming <murrayc@murrayc.com>
527 Use the latest java-libglom version.
529 * pom.xml: Use java-libglom 1.21.7.
531 2012-03-03 Ben Konrath <ben@bagu.org>
533 Display date and time in details view.
535 https://bugzilla.gnome.org/show_bug.cgi?id=671257
537 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
539 2012-03-05 Murray Cumming <murrayc@murrayc.com>
541 Require the latest java-libglom.
543 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
545 2012-03-04 Murray Cumming <murrayc@murrayc.com>
547 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
549 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
550 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
551 an empty quickfind string. I also corrected libglom to create only
552 empty where clauses for empty quickfind strings, but this avoids the
555 2012-02-24 Ben Konrath <ben@bagu.org>
557 Improve the tabs in the Notebook widget.
561 2012-01-30 Murray Cumming <murrayc@murrayc.com>
563 Translations: Try to translate the strings.
565 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
566 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
567 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
568 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
569 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
570 Take the Open translation from GTK+'s .po files.
571 Take the Details translation from Glom's po files.
572 I have added the other strings to Glom so we can get translations that way:
573 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
575 2012-01-27 Murray Cumming <murrayc@murrayc.com>
577 TableSelectionViewImpl: Put the search label and entry in a div.
579 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
580 Put the search widgets in a FlowTable so that the CSS can be used to
581 style them while keeping them together.
582 * src/main/webapp/style.css: Mention the new div.
584 2012-01-27 Murray Cumming <murrayc@murrayc.com>
586 Translate more strings in more locales.
588 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
589 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
590 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
591 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
592 Translate the "Details" and "Open" string too.
594 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
595 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
596 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
597 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
598 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
599 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
600 Add these new locales as placeholders though they currently contain English.
602 2012-01-27 Murray Cumming <murrayc@murrayc.com>
604 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
606 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
607 Check the ConfiguredDocument* for null before using it.
609 2012-01-26 Murray Cumming <murrayc@murrayc.com>
611 Tell Eclipse about the generated java files.
613 * .classpath: This lets it find OnlineGlomConstants.java.
614 It would be nice if Eclipse just used the maven build files.
616 2012-01-26 Murray Cumming <murrayc@murrayc.com>
618 Prevent a crash when no locale is specified in the URL.
620 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
621 Avoid returning a null string, obtained from
622 Window.Location.getParameter(). This caused a crash when it was
623 later passed to libglom's API.
624 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
625 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
626 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
627 guard against future null strings.
629 2012-01-26 Murray Cumming <murrayc@murrayc.com>
631 Use the ?locale= query param instead of the &lang= token param.
633 * src/main/java/org/glom/web/client/place/ListPlace.java
634 * src/main/java/org/glom/web/client/place/DetailsPlace.java
635 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
636 Remove the lang token key and value.
638 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
639 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
640 When the user selects a different locale from the chooser, use
641 Window.Location.assign() to change the URL, which then causes a reload.
643 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
644 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
645 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
646 * src/main/java/org/glom/web/client/activity/ListActivity.java
647 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
648 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
649 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
650 * src/main/java/org/glom/web/client/ui/ListView.java:
651 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
653 Remove localeID member variables and method/constructor parameters, instead
654 using Utils.getCurrentLocaleID() when we need a localID to pass to
657 2012-01-26 Murray Cumming <murrayc@murrayc.com>
659 Internationalize the UI strings.
661 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
662 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
663 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
664 because it is unused. Messages are apparently strings that can have
665 parameters, but we do not need that yet, so Contants will be enough for now.
666 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
667 to say that we support the en and de locales.
668 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
669 The original English strings.
670 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
671 Some German translations of the English strings.
672 The i18n goal then uses the .properties file to generate an
673 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
674 returns an implementation that returns the translated strings.
675 The documentation suggests putting these in src/java/*/client/, but it seems
676 best to put it in src/resources/*/client/.
677 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
678 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
679 instead of hard-coding them.
680 Note that we cannot import OnlineGlomConstants because it does not exist yet,
681 but that does not seem to stop the build, though it confuses Eclipse.
683 You can see the translated string by adding ?locale=de to the URL, like so:
684 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
686 2012-01-24 Murray Cumming <murrayc@murrayc.com>
688 Improve null/empty String checks.
690 * pom.xml: Add a dependency on commons-lang, to use
691 org.apache.commons.lang.StringUtils.
692 * src/main/java/org/glom/web/server/ConfiguredDocument.java
693 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
694 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
695 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
696 Use StringUtils.isEmpty().
698 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
699 StringUtils class with a static isEmpty() function because we
700 cannot use org.apache.commons.lang.StringUtils in client-side
701 GWT code because it (apparently) cannot be compiled to javascript.
702 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
703 * src/main/java/org/glom/web/client/activity/ListActivity.java
704 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
705 * src/main/java/org/glom/web/client/place/DetailsPlace.java
706 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
707 * src/main/java/org/glom/web/client/place/ListPlace.java
708 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
709 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
710 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
711 * src/main/java/org/glom/web/client/ui/details/Group.java
712 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
713 our StringUtils.isEmpty() function.
715 2012-01-24 Murray Cumming <murrayc@murrayc.com>
717 Update to the latest java-libglom API.
719 * pom.xml: Require java-libglom 1.21.4.
720 * src/main/java/org/glom/web/server/ConfiguredDocument.java
721 getDocumentInfo(), getListViewLayoutGroup():
722 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
724 * src/main/java/org/glom/web/server/database/DBAccess.java
725 getFieldsToShowForSQLQueryAddGroup(),
726 getPrimaryKeyLayoutItemField(): Replace get_database_title()
727 with either get_database_title_original() or
728 get_database_title(localeID).
730 2012-01-24 Murray Cumming <murrayc@murrayc.com>
732 ConfiguredDocument: Avoid a null pointer exception.
734 * src/main/java/org/glom/web/server/ConfiguredDocument.java
735 Initialize localeID to "" to avoid returning a null String which
736 causes a crash in java-libglom's swing-generated code.
738 2012-01-23 Murray Cumming <murrayc@murrayc.com>
740 Some simple renaming.
742 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
743 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
744 for localeChooser. This seems more appropriate and is less ambiguous
745 particularly in the .css file.
747 2012-01-23 Murray Cumming <murrayc@murrayc.com>
749 ConfiguredDocument: Rename the localedID private member variable.
751 2012-01-23 Murray Cumming <murrayc@murrayc.com>
753 Adapt to the latest java-libglom API from git master.
755 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
756 libglom now uses only Vector instead of List, which uses add() instead of
759 2012-01-22 Murray Cumming <murrayc@murrayc.com>
761 ConfiguredDocument: Rename the localedID private member variable.
763 2012-01-20 Murray Cumming <murrayc@murrayc.com>
765 Build a source tarball with mvn assembly:single
767 * assembly.xml: Add this file.
768 * pom.xml: Use the maven-assembly-plugin and tell it to use
769 our assembly.xml file.
771 2012-01-19 Murray Cumming <murrayc@murrayc.com>
773 OnlineGlomServiceImpl: Get .glom files recursively.
775 * pom.xml: Depend on commons-io from org.apache.commons.
776 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
777 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
778 files recursively, and with the easier filter for the extension.
779 Use org.apache.commons.io.FilenameUtils.removeExtension() to
780 simplify that code too.
782 2012-01-19 Murray Cumming <murrayc@murrayc.com>
784 README: Mention that you must install java-libglom packages separately.
786 But then it works, because java-libglom is now in the central maven
789 2012-01-18 Murray Cumming <murrayc@murrayc.com>
791 locales drop-down: Show the correct selected locale when the URL changes.
793 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
794 .java: setPlace(): Move some code into fillView().
796 2012-01-18 Murray Cumming <murrayc@murrayc.com>
798 locales drop-down: Do not lose the primary key.
800 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
801 start(): onLocaleChange(): Pass the current primary key value,
802 instead of an empty value.
804 2012-01-18 Murray Cumming <murrayc@murrayc.com>
806 locales drop-down: Do not lose the drop-down selection.
808 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
809 .java (TableSelectionActivity.fillView): Set the selected locale
810 after changing the drop-down items (though we do not really need
811 to change them just because the locale changes.)
813 2012-01-18 Murray Cumming <murrayc@murrayc.com>
815 locales drop-down: Change the tables list when this changes.
817 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
818 .java: TableSelectionActivity.start(): Move the async table titles
819 retrieval into a private fillView() method and also call this when
820 the chosen locale changes.
821 Note that the document title is not actually translatable yet, but
822 that is a problem that I should fix soon in libglom.
824 2012-01-18 Murray Cumming <murrayc@murrayc.com>
826 Improve the placement of the locales drop-down.
828 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
829 Put the title and locales drop-down in a div (gwt.FlowTable).
830 * src/main/webapp/style.css: Add magic css properties to make this work.
831 Also remove the left margin from the title so that it lines up with the
834 2012-01-18 Murray Cumming <murrayc@murrayc.com>
836 locales selector: Show human-readable locale titles.
838 * src/main/java/org/glom/web/server/ConfiguredDocument.java
839 getDocumentInfo(): Use java.util.Locale to show a real title of
840 each locale, in the locale's own language.
842 2012-01-17 Murray Cumming <murrayc@murrayc.com>
844 Add a language/locale selector drop-down.
846 * src/main/java/org/glom/web/shared/DocumentInfo.java:
847 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
848 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
849 getDocumentInfo(): Store the available Locales in the DocumentInfo.
850 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
851 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
852 Add a ListBox to show the available locales. Add getLocaleSelector(),
853 setLocaleList(), getSelectedLocale(), setSelectedLocale().
854 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
855 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
856 java: Add these classes.
857 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
858 start(): Fill the locales ListBox. Handle its change event, firing a
860 setPlace(): Show the selected locale as specified by the URL token.
861 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
862 * src/main/java/org/glom/web/client/activity/ListActivity.java:
863 Handle LocaleChangeEvent, going to a new *Place with that locale.
865 The placement of the ListBox is not pretty, and it currently uses the ID
866 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
870 2012-01-17 Murray Cumming <murrayc@murrayc.com>
872 Search box: Show the search text from the URL token.
874 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
875 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
876 Add setQuickFindText().
877 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
878 .java: setPlace(): Store the queryText if the place is a ListPlace,
879 and call TableSelectionView.setQuickFindText().
881 2012-01-17 Murray Cumming <murrayc@murrayc.com>
883 Allow use of translations via, for instance, &lang=de in the URL.
885 * pom.xml: Use the unstable java-libglom 1.21 version.
887 * src/main/java/org/glom/web/client/OnlineGlomService.java:
888 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
889 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
890 init(): Instead of calling TranslatableItem.set_current_locale()
891 (now removed), call ConfiguredDocument.setDefaultLocaleID().
892 However, this is only for default locales, which are not needed to
893 change the locale in the URL.
894 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
895 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
896 getSortedRelatedListData(): Add a localeID parameter, so we can get the
897 layout for a particular locale.
898 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
899 Add get/setDefaultLocaleID().
900 getDocumentInfo(), getListViewData(), getRelatedListData(),
901 getDetailsLayoutGroup(), getListViewLayoutGroup(),
902 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
903 localeID parameter, so we can get the layout for a particular locale.
905 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
906 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
907 * src/main/java/org/glom/web/client/place/ListPlace.java:
908 Parse and construct a lang parameter too.
910 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
911 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
912 passed to subsequent methods and constructors.
913 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
914 * src/main/java/org/glom/web/client/activity/ListActivity.java:
915 Store the localeID from the *Place and pass it to other constructors
916 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
918 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
919 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
920 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
921 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
922 * src/main/java/org/glom/web/client/ui/ListView.java:
923 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
924 Take localeID parameters and pass them to subsequent constructors and
925 methods, so that the layout is always retrieved for that locale.
927 This is rather repetitive.
929 Note that "" means the original (default) locale of the Glom document,
930 which is usually English.
932 2012-01-17 Murray Cumming <murrayc@murrayc.com>
934 Documents: Remove final keyword to fix startup configuration.
936 * src/main/java/org/glom/web/shared/Documents.java: Remove the
937 final keywords on the private member variables because that breaks
938 the startup, apparently (there are warnings) because it stops them
939 from being serialized. I added these in the previous commit.
941 2012-01-13 Murray Cumming <murrayc@murrayc.com>
943 Documents: Add some final keywords.
945 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
948 2012-01-13 Murray Cumming <murrayc@murrayc.com>
950 OnlineGlomServiceImpl: Add to overview comments.
952 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
953 Note that this is where all the document are loaded. They are not
954 loaded freshly for each page.
956 2012-01-12 Murray Cumming <murrayc@murrayc.com>
960 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
961 Add a TextBox for the text of a quick find.
962 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
964 setBackLink(): Add a String quickFind parameter.
965 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
966 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
967 to the base interface, because that is how TableSelectionViewImpl is used.
968 * src/main/webapp/style.css: Add style for the search box and its label.
970 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
971 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
972 Add these files, based on the existing TableChangeEvent and
973 TableChangeEventHandlers.
974 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
975 start(): Handle QuickFindChangeEvent, passing its quickFind text to
976 a ListPlace() that the user should be taken to.
977 * src/main/java/org/glom/web/client/activity/ListActivity.java
978 start(): Handle it here too and adapt the TableChangeEvent handler to
979 pass the extra "" quickFind parameter to ListPlace.
980 * src/main/java/org/glom/web/client/place/ListPlace.java:
981 Constructor: Take an extra String quickFind parameter and store it,
982 returning it from a new getQuickFind() method.
983 getToken(): Put the quickFind text in the URL token.
984 getPlace(): Parse the quickFind text from the URL token.
985 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
986 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
987 ListPlace constructor.
988 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
989 .java: start(): Add a Change handler for the TableSelectionView's
990 TextBox (via its base HasChangeHandlers interface), firing the new
991 QuickFindChangeEvent.
992 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
993 pass the extra "" quickFind parameter.
995 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
996 setCellTable(): Add a String quickFind parameter and pass it to
997 the ListViewTable() constructor.
998 * src/main/java/org/glom/web/client/ui/ListView.java: Change
999 setCellTable() in the base interface, because that is how ListViewImpl
1002 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1003 Add a String quickFind member variable.
1004 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1005 Constructor: Add a String quickFind parameter, storing it in the
1006 base ListTable's member variable.
1007 onRangeChanged(): Pass quickFind to the
1008 OnlineGlomServiceAsync.getSortedListViewData() and
1009 OnlineGlomServiceAsync.getListViewData() methods.
1011 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1012 getListViewData(), getSortedListViewData(): Add a String quickFind
1013 parameter, passing it to ConfiguredDocument.getListViewData().
1014 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1015 Change getListViewData(), getSortedListViewData() in the base interface,
1016 because that is how OnlineGlomServiceImpl is used, via this:
1017 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1018 Change getListViewData(), getSortedListViewData() here too.
1019 This class can apparently be used to asynchronously call methods on
1020 OnlineGlomService, and GWT seems to implement that after recognizing
1021 just the *Async name convention and the extra AsyncCallback parameters.
1023 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1024 getListViewData(): Add a String quickFind parameter, and pass it to
1025 ListViewDBAccess.getData().
1026 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1027 getListData(): Add a String quickFind parameter and pass it to
1029 getSelectQuery(): Add a String quickFind parameter.
1030 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1031 getSelectQuery(): Add a String quickFind parameter and use it with
1032 Glom.get_find_where_clause_quick() to pass a where_clause to
1033 Glom.build_sql_select_with_where_clause(), to actually filter the
1035 getData(): Add a String quickFind parameter, passing it to getListData().
1036 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1037 va: getData(): Pass an empty string to getListData() for the
1038 quickFind parameter.
1040 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1042 ListTable: Minor change.
1044 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1045 createCellTable(): Make this protected instead of public.
1047 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1049 Many files: Use final for the parameters and use the @override attribute.
1051 2012-01-22 Ben Konrath <ben@bagu.org>
1053 Add anchor links for single line text that starts with http, ftp and www.
1057 2012-01-22 Ben Konrath <ben@bagu.org>
1059 Add ellipsis to single line text in details view.
1063 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1065 Remove all javadoc author tags.
1067 Because they are awkward and meaningless when many people touch
1069 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1071 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1073 Revert the COPYING.LESSER to COPYING rename.
1075 Apparently both should be there if it is LGPL.
1077 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1079 *View: Remove unused imports.
1081 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1082 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1083 * src/main/java/org/glom/web/client/ui/ListView.java:
1084 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1085 Remove unused imports, as suggested by Eclipse.
1087 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1089 Move the *View::Presenter types, and some API into one base View.
1091 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1092 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1093 * src/main/java/org/glom/web/client/ui/ListView.java:
1094 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1095 Presenter, setPresenter() and clear() into a shared base interface,
1096 to avoid the unnecessary duplicate Presenter types and to more clearly
1097 show how the *Views share the same structure, even if they are not
1098 used polymorphically.
1100 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1101 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1103 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1104 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1105 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1107 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1110 Feel free to revert this if there is a good reason for the duplicate
1113 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1115 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1117 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1118 a class member instead of a local variable in the method.
1119 This lets us use it to get the view instances, for use in tests.
1120 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1121 beforeOnlineGlom(): Test some more details of the initial view.
1122 Again, this is not very useful.
1124 To really test gwt-glom we will need to start a local postgresql
1125 instance with local data, like the Glom tests in C++.
1127 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1129 pom.xml: Mention the LGPL license.
1131 * pom.xml: Add a licenses section.
1132 * COPYING.LESSER: Move this to COPYING, which
1133 previously contained the GPL. But gwt-glom is all LGPL.
1135 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1137 Add project information to README and pom.xml.
1139 * README: Add a brief description and mention some mvn
1141 * pom.xml: This extra information shows up in mvn site
1144 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1146 Use the latest java-libglom version.
1148 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1150 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1152 GwtTestOnlineGlom: Test a little more.
1154 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1155 protected rather than private, as suggested by the gwt-test-utils
1157 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1158 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1159 Test the initial visibility of the panels.
1161 However, this is not a very useful test.
1162 And I wonder how we should generally test using this idea for an
1163 activity/places app like ours where the real changes happen implicitly
1164 based on the history token/URL.
1166 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1168 Slight modification to *Mapper comments.
1170 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1171 (DataActivityMapper)
1172 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1174 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1176 Remove comments mentioning GIN because they are just copied from
1177 the example code and are apparently not helpful:
1178 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1179 Also change the mention of a class that is only in the example code.
1181 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1183 GwtTestOnlineGlom test: Minor changes.
1185 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1186 Avoid the long qualified class name and modify the comment
1187 because it is now obvious to me that the mocked class is the only
1188 custom one created via GWT.create().
1190 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1192 Tests: Added the beginnings of a test using gwt-test-utils.
1194 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1195 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1196 which tells gwt-test-utils what class will be tested.
1197 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1198 Add a simple (but empty) test case. One class, used by the OnlineGlom
1199 class, is mocked so that it can be created. However, I am not sure
1200 why only this class needs to be mocked.
1202 Note that mockito seems more popular, and clearer, than easymock,
1203 but I have not got that working yet. It might be a matter of the
1206 This test is run during mvn integration-test.
1208 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1210 Tests: Use junit4-style syntax instead of junit3-style.
1212 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1213 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1214 * src/test/java/org/glom/web/shared/DataItemTest.java:
1215 Use the @Test annotation rather than relying on the test*() prefix.
1216 Also no longer implement TestCase, to avoid triggering support for
1217 the junit3-way, which stops the annotations from working.
1218 Change the imports from import junit.framework.* to
1219 import org.junit.*, which is apparently the new way.
1221 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1223 Added a test for ListPlace token parsing and creation.
1225 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1226 This is much the same as DetailsPlaceTest.
1228 I wonder how we could test the other parts of the *Place API.
1230 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1232 DetailsPlace test: Also test getToken() and recreation via getPlace().
1234 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1235 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1236 recreate it, testing the recreated DetailsPlace for the same parameter
1239 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1241 Use the surefire-report plugin.
1243 * pom.xml: This generates a HTML report about the tests in
1244 target/site/surefire-report.html
1245 when you do mvn surefire-report:report. It seems to be popular/normal.
1247 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1249 Added a test for DetailsPlace.
1251 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1252 Test the getPlace() token parsing.
1254 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1256 Added a first unit test.
1258 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1259 * src/test/java/org/glom/web/shared/DataItemTest.java:
1260 This is a silly test but it is just to get things started. Note that
1261 maven/junit finds the test because it looks in src/test by default.
1263 2011-12-22 Ben Konrath <ben@bagu.org>
1265 Change charsetName to "UTF-8" when replacing line breaks.
1267 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1268 that work in Java (such as "UTF8") will not work when compiled to
1271 This fixes a problem with multi-line details view fields that have hard
1272 line breaks. The "License Text" field on this page demonstrates the
1275 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1277 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1279 2011-12-22 Ben Konrath <ben@bagu.org>
1281 Fix another bug with related list navigation.
1283 I've tested all the navigation buttons in all of the related lists
1284 so things should be good now.
1286 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1288 2011-12-22 Ben Konrath <ben@bagu.org>
1290 Fix a crasher when refreshing the list view with the default table.
1292 This crash will also happen when loading the list view with the default
1293 table from a link or bookmark.
1295 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1296 to the main document selection page when the document id hasn't been
1298 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1299 the main document selection page when the document id hasn't been
1301 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1302 values for the details place when the document id hasn't been set.
1303 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1304 values for the list place when the document id hasn't been set.
1306 2011-12-21 Ben Konrath <ben@bagu.org>
1308 Protect against NPE when glom.document.locale is not in config.
1310 This patch protects against an NPE when glom.document.locale is not in
1311 the config file. This NPE will also happen if glom.document.locale is
1314 The patch also updates the error message to display the class name when
1315 the getMessage() returns null. This was happening when the NPE was
1316 thrown and I had "Configuration Error: null". If an NPE is encountered
1317 with this patch, "Configuration Error: NullPointerException " will be
1320 This commit closes this bug:
1322 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1324 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1326 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1328 Rename onlineglom.properties to onlineglom.properties.sample.
1330 * src/main/resources/onlineglom.properties: Rename to:
1331 * src/main/resources/onlineglom.properties.sample:
1332 * src/main/resources/README: And add this file explaining that people
1333 should rename it back when deploying.
1335 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1337 Allow choosing the translation in the .properties file.
1339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1340 init(): Read a glom.document.locale value from the configuration file
1341 and call Glom's TransatableItem::set_current_locale() method.
1342 * src/main/resources/onlineglom.properties: Add a commented-out
1343 example of this new setting.
1345 It would be better to add &lang=de_DE to the URL, but the current
1346 libglom API does not allow us to do this easily. I am working on that.
1348 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1350 Avoid a crash in parsing of token parameters.
1352 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1353 ava: getTokenParams(): Do not crash if a parameter has a key but no
1354 value, and ignore parameters with neither.
1356 2011-12-17 Murray Cumming <murrayc@murayc.com>
1358 History token building/handling: Improve use of token parameters.
1360 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1361 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1362 and buildParamsToken(HashMap), for use by derived classes.
1363 Make the separator private because it is no longer be needed.
1364 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1365 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1366 instead of manual string concatenation.
1367 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1368 of hardcoded indices and awkward splitting code.
1369 * src/main/java/org/glom/web/client/place/ListPlace.java
1370 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1371 instead of manual string concatenation.
1372 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1373 of hardcoded indices and awkward splitting code.
1374 This should fix bug #666420
1376 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1378 Fix a Navgiation->Navigation typo in the code.
1380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1381 Rename processNavgiation() to processNavigation().
1383 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1385 Fix a seperator->separator typo in the code.
1387 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1388 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1389 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1392 2011-12-15 Ben Konrath <ben@bagu.org>
1394 Cleanup some comments.
1396 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1398 2011-12-14 Ben Konrath <ben@bagu.org>
1400 Replace \n with <br/> for multiline text in the details view.
1402 Vertical scrollbars are added when needed as well.
1404 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1406 2011-12-14 Ben Konrath <ben@bagu.org>
1408 Specify the font for document selection links.
1410 * src/main/webapp/style.css:
1412 2011-12-14 Ben Konrath <ben@bagu.org>
1414 Fix bouncy CellTable while paging.
1416 This doesn't currently work with related list tables in unselected
1419 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1421 2011-12-14 Ben Konrath <ben@bagu.org>
1423 Revamp the appearance of the document selection page.
1425 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1426 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1427 * src/main/webapp/style.css:
1429 2011-12-13 Ben Konrath <ben@bagu.org>
1431 Set navigation button column to the smallest size possible.
1433 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1435 2011-12-13 Ben Konrath <ben@bagu.org>
1437 Change OpenButton nomenclature to NavigationButton.
1439 Using NavigtionButton makes things more generic. Classes, methods and
1440 variables have been changed.
1442 This is a rename-only refactor.
1444 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1445 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1446 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1447 Renamed from OpenButtonCell.
1448 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1449 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1450 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1452 2011-12-12 Ben Konrath <ben@bagu.org>
1454 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1456 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1457 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1458 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1459 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1461 2011-12-12 Ben Konrath <ben@bagu.org>
1463 Update variable names and comments.
1465 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1466 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1468 2011-12-12 Ben Konrath <ben@bagu.org>
1470 Properly initialize numNonEmptyRows variable to zero.
1472 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1473 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1475 2011-12-05 Ben Konrath <ben@bagu.org>
1477 Add latest mockup with HTML tables.
1479 Features of this mockup:
1481 -> HTML table for flowtable
1482 -> HTML table for flowtable column
1483 -> Example of how related lists would look
1484 -> Not using text entries for data items
1486 The current version of Online Glom doesn't use HTML tables for the
1489 This mockup has been sent to the glom-devel mailing list but it's good
1490 to have it here as well.
1492 * mockups/details-view-html-tables.html:
1494 2011-12-05 Ben Konrath <ben@bagu.org>
1496 Remove unnecessary getPrimaryKeyField() method.
1498 getPrimaryKeyFieldForTable(String) has been renamed to
1499 getPrimaryKeyField(String).
1501 * src/main/java/org/glom/web/server/database/DBAccess.java:
1502 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1503 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1505 2011-12-05 Ben Konrath <ben@bagu.org>
1507 Add string representation of TypedDataItem value to conversion error message.
1509 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1510 message was extracted into its own method to avoid duplication.
1512 2011-12-05 Ben Konrath <ben@bagu.org>
1514 Add type checking to navigation primary key value creation.
1516 Create navigation primary key only if the expected type from the Glom
1517 document matches the type returned by the SQL query.
1519 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1521 2011-12-05 Ben Konrath <ben@bagu.org>
1523 Rename a couple of variables in RelatedListNavigation.
1525 This is a rename-only refactor.
1527 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1529 2011-12-05 Ben Konrath <ben@bagu.org>
1531 Move getListLayoutGroup() into getListViewLayoutGroup().
1533 This removes getListLayoutGroup(). It was only being called by
1534 getListViewLayoutGroup().
1536 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1538 2011-12-05 Ben Konrath <ben@bagu.org>
1540 Remove check for LayoutItem_Portal in list table method.
1542 This check is no longer necessary because the method isn't being used
1543 to create the LayoutItemPortal DTO.
1545 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1547 2011-12-05 Ben Konrath <ben@bagu.org>
1549 Properly support related list navigation.
1551 Navigation from the "Repository Analyzer -> Package Scans ->
1552 Dependencies" related table wasn't working because the primary key for
1553 related tables wasn't being set properly. This commit fixes the
1556 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1557 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1558 doesn't set the primary key properly for related list tables.
1559 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1560 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1561 useful for getting the primary key for list view tables and for related
1563 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1564 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1565 Move code to set the primary key for the table from the abstract
1566 ListDBAccess class to ListViewDBAccess as it's only correct for list
1568 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1569 Properly add primary key to related list tables.
1571 2011-12-02 Ben Konrath <ben@bagu.org>
1573 Properly set the horizontal alignment of fields.
1575 This fix is for both the list tables and the details view.
1577 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1578 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1579 to set the horizontal alignment of fields.
1581 2011-12-02 Ben Konrath <ben@bagu.org>
1583 Display currency codes in the details view.
1585 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1587 2011-12-02 Ben Konrath <ben@bagu.org>
1589 Avoid duplicate JNI call.
1591 JNI is not as efficient as pure Java and this is an easy (and small)
1594 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1595 Use previously retrieved value for whereClauseToTableName instead of
1598 2011-12-02 Ben Konrath <ben@bagu.org>
1600 Rename a couple of variables in RelatedListNavigation.
1602 This is a rename-only refactor.
1604 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1606 2011-12-02 Ben Konrath <ben@bagu.org>
1608 Indicate clearly that a mismatched primary key type is a bug.
1610 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1611 warning to error. Add 'This is a bug.' to message.
1613 2011-12-02 Ben Konrath <ben@bagu.org>
1615 Update / fix some comments.
1617 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1619 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1621 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1622 Fix comments. Add some TODOs.
1624 2011-12-02 Ben Konrath <ben@bagu.org>
1626 Enable navigation to details view with string primary key from related list.
1628 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1629 Create a text primary key value when return type of result is
1630 java.sql.Types.VARCHAR.
1632 2011-12-02 Ben Konrath <ben@bagu.org>
1634 Use checkboxes for booleans in the details view.
1636 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1638 2011-12-01 Ben Konrath <ben@bagu.org>
1640 Improve performance of related list height calculation.
1642 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1643 Put code to calculate the expected height in a static initializer so
1644 that that it's only called once.
1646 2011-12-01 Ben Konrath <ben@bagu.org>
1648 Show related list tables in notebooks (again).
1650 Calculate the height of the related list tables so the Notebook can be
1651 set the correct height. The height of the related list table is also needed by
1652 FlowTable to be able decide how to create the layout.
1654 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1655 and set the Portal height based on the height of the related list
1656 table and the Portal container.
1657 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1658 Add method to calculate the height of the related list tables.
1659 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1660 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1661 calculate the height of the Pager widget.
1663 2011-12-01 Ben Konrath <ben@bagu.org>
1665 Use CellTable API for table property instead of setting style on Element.
1667 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1669 2011-12-01 Ben Konrath <ben@bagu.org>
1671 Make ListViewTable and RelatedListTable a consistent height.
1673 The tables are now a consistent height regardless of the contents of
1674 the table. A hidden button is added to empty rows to ensure that the
1675 height of these rows will match the height of rows with data.
1677 A navigation button column is now added to every table. The width of
1678 the navigation column is set to 0px when a RelatedListTable shouldn't
1679 have navigation buttons. This maintains the a consistent row height in
1680 tables that don't show the navigation buttons.
1682 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1683 navigation column when not needed.
1684 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1685 arguments for navigation button to constructor of ListViewTable.
1686 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1687 hidden button for empty data rows.
1688 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1689 arguments for navigation button to constructor.
1690 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1691 create navigation buttons. Add hideNavigationButtons() method.
1692 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1693 arguments for navigation button to constructor.
1695 2011-12-01 Ben Konrath <ben@bagu.org>
1697 Use 'visibility: hidden' in Utils.getWidgetHeight().
1699 This is better choice because hidden elements are invisible, don't
1700 respond to events and are not part of the tab order. They will,
1701 however, take up space which is required to be able to calculate the
1702 height of the widget.
1704 * src/main/java/org/glom/web/client/Utils.java:
1706 2011-12-01 Ben Konrath <ben@bagu.org>
1708 Use Utils.getWidgetHeight() in FlowTable.
1710 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1712 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1714 2011-12-01 Ben Konrath <ben@bagu.org>
1716 Put the details css class name on the correct table column.
1718 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1720 2011-11-30 Ben Konrath <ben@bagu.org>
1722 Update for java-libglom API change.
1724 The getters and setters on FieldFormatting and NumericFormat were
1725 changed to remove the 'M'.
1727 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1729 2011-11-29 Ben Konrath <ben@bagu.org>
1731 Only allow RelatedListTables in Portals.
1733 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1735 2011-11-29 Ben Konrath <ben@bagu.org>
1737 Only create a contents panel for Portals when title is being set.
1739 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1741 2011-11-29 Ben Konrath <ben@bagu.org>
1743 Set TabLayoutPanel height based on calculated height its widgets.
1745 This is a potential fix for this bug:
1747 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1749 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1751 2011-11-29 Ben Konrath <ben@bagu.org>
1753 Align details field labels and data with the Open buttons.
1755 * src/main/webapp/style.css:
1757 2011-11-29 Ben Konrath <ben@bagu.org>
1759 Remove unnecessary <div> in the Notebook widget.
1761 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1762 method to get container FlowPanel (<div>).
1763 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1764 initWidget() method directly on the TabLayoutPanel widget instead of
1765 Group's container widget.
1767 2011-11-29 Ben Konrath <ben@bagu.org>
1769 Don't add group titles for Portals in Notebooks.
1771 This reverts the previous patch and fixes a bug I introduced with
1772 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1774 * src/main/java/org/glom/web/client/ui/details/Group.java:
1775 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1777 2011-11-28 Ben Konrath <ben@bagu.org>
1779 Remove unused boolean argument in Portal constructor.
1781 Just a code cleanup.
1783 * src/main/java/org/glom/web/client/ui/details/Group.java:
1784 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1786 2011-11-28 Ben Konrath <ben@bagu.org>
1788 Remove hack for glom 1.18 style glom files.
1790 * src/main/java/org/glom/web/client/ui/details/Group.java:
1791 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1792 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1794 2011-11-28 Ben Konrath <ben@bagu.org>
1796 Use Gda Value version of primary key to log result too large error.
1798 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1800 2011-11-28 Ben Konrath <ben@bagu.org>
1802 Don't use TypedDataItem.getText() for Unknown types from the URL.
1804 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1805 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1806 instead of getText().
1807 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1808 String field and getUnknown() method.
1810 2011-11-28 Ben Konrath <ben@bagu.org>
1812 Log an error message when the java-libglom .so is not present.
1814 The error message was being set in the exception but not logged.
1816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1818 2011-11-28 Ben Konrath <ben@bagu.org>
1820 Ignore LayoutItem_CalendarPortals.
1822 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1823 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1825 2011-11-28 Ben Konrath <ben@bagu.org>
1827 Extract method for creating the LayoutItemPortal DTO.
1829 Just breaking the code up into smaller chunks.
1831 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1833 2011-11-28 Ben Konrath <ben@bagu.org>
1837 This should have been added with the refactor. Oops!
1839 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1841 2011-11-28 Ben Konrath <ben@bagu.org>
1843 Create primary key value from URL string using type from Glom document.
1845 See this bug, comments 19 - 25:
1847 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1849 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1850 create a TypeDataItem for the primary key here when loading from a
1851 URL. Show the same string for the primary key value as was received
1852 from the URL string (when loading from a URL).
1853 * src/main/java/org/glom/web/server/Utils.java: Update method for
1854 creating the Gda Value from the TypeDataItem to properly deal with
1855 creating a Gda Value based on the Glom document type for the primary
1856 key value string when loading from a URL.
1857 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1858 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1859 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1860 Update for changed method name.
1862 2011-11-27 Ben Konrath <ben@bagu.org>
1864 Rename PrimaryKeyItem to TypedDataItem.
1866 The name PrimaryKeyItem suggests what the class should be used for.
1867 TypedDataItem is a neutral name that describes the class better.
1869 This is a rename-only refactor.
1871 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1872 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1873 * src/main/java/org/glom/web/client/Utils.java:
1874 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1875 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1876 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1877 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1878 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1879 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1880 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1881 * src/main/java/org/glom/web/server/Utils.java:
1882 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1883 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1884 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1885 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1887 2011-11-25 Ben Konrath <ben@bagu.org>
1889 Improve Gda Value conversion from PrimaryKeyItem.
1891 The value from the PrimaryKeyItem is only used if its type match the
1892 type from the glom document.
1894 * src/main/java/org/glom/web/server/Utils.java:
1896 2011-11-25 Ben Konrath <ben@bagu.org>
1898 Manually check if the java-liblgom .so is visible to the JVM.
1900 It seems that Tomcat has problems when a static initializer throws an
1901 exception. This check is done before the first method call into
1902 java-libglom so that execution doesn't continue if the .so is not
1905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1907 2011-11-25 Ben Konrath <ben@bagu.org>
1909 Improve browser configuration error messages.
1913 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1915 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1916 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1917 getConfigurationErrorMessage() method.
1918 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1919 Get and display a specific configuration error message when no Glom
1920 documents are found.
1921 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1922 Implement getConfigurationErrorMessage() method. Surround configuration
1923 code in the init() method with a try/catch block. This allows the
1924 errors to be caught while keeping the servlet available to retrieve the
1925 configuration error message.
1927 2011-11-25 Ben Konrath <ben@bagu.org>
1929 Don't use Strings to hold primary key values.
1931 The primary key values are now held in a new data object
1932 (PrimaryKeyItem) that holds type information and the primary key value
1933 using the correct type.
1935 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1936 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1938 PrimaryKeyItem instead of String to hold the primary key value.
1939 * src/main/java/org/glom/web/client/Utils.java: Remove
1940 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1941 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1942 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1943 PrimaryKeyItem instead of String to hold the primary key value. Load
1944 document selection page when the documentID has not been set correctly.
1945 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1946 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1948 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1949 Return empty string for URL instead of "null".
1950 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1951 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1952 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1953 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1954 PrimaryKeyItem instead of String to hold primary key values.
1955 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1956 PrimaryKeyValue to a Gda Value.
1957 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1958 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1959 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1960 Replace temporary database access code that uses the PrimaryKeyValue to
1961 Gda Value conversion.
1962 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1963 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1964 PrimaryKeyItem instead of String.
1965 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1966 hold primary key values.
1968 2011-11-24 Ben Konrath <ben@bagu.org>
1970 Use newly added java-libglom API to create queries.
1972 This isn't finished. I still need to stop using Strings for primary key
1973 values in the client code.
1975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1976 libglom to use fake connections so that retrieving the query string will
1978 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1979 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1980 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1981 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1982 Use the newly added libglom sql methods and classes to create the
1983 query. Add temporary hack to convert primary value strings to Gda
1986 2011-11-23 Ben Konrath <ben@bagu.org>
1988 Don't explicitly set the height of Portals.
1990 See comments 6 - 10 of this bug for details:
1992 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1994 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1996 2011-11-23 Ben Konrath <ben@bagu.org>
1998 Use an HTML table instead of CSS for the FlowTable layout.
2000 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2001 GWT's FlexTable to implement the FlowTable.
2002 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2004 2011-11-18 Ben Konrath <ben@bagu.org>
2006 Add boolean example to HTML table mockup.
2008 * mockups/details-view-html-tables-text-entries.html:
2010 2011-11-17 Ben Konrath <ben@bagu.org>
2012 Ensure the pager buttons are always visible for related lists.
2014 To accomplish this, I've turned off text wrapping in the list view and
2015 related list tables for both the header and data text. The related list
2016 table now has a fixed layout so the it doesn't overflow its container.
2017 This is required to ensure that the cell text is clipped when it
2018 overflows the cell and an ellipsis is added to the right side of the
2019 cell when text is clipped.
2021 A fixed table layout for the related list table in the details view
2022 seems what we want for the details view anyway, so the side-effect is
2025 The ellipsis will only be displayed in Firefox >= 7.
2029 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2031 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2032 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2033 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2035 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2036 Set the 'table-layout: fixed' CSS property to the related list table.
2037 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2038 'white-space: nowrap;' CSS property on both the list view and the
2039 related list tables.
2041 2011-11-16 Ben Konrath <ben@bagu.org>
2043 Rework the fix for empty notebook tab labels.
2045 Setting the empty group titles with its name caused problems for the
2046 details layout. Instead of using libglom's
2047 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2048 to the client when the title is empty. This allows the Notebook to use
2049 the name when the title is empty without affecting anything else.
2051 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2052 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2054 2011-11-16 Ben Konrath <ben@bagu.org>
2056 Set group titles with name when title is empty.
2058 This fixes a problem with an empty notebook tab label in the Lesson
2059 Planner document. The forth tab in the notebook should be "Internet":
2061 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2063 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2064 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2067 2011-11-16 Ben Konrath <ben@bagu.org>
2069 Remove whitespace from the configured username properties.
2071 This assumes that usernames won't have whitespace at the beginning
2072 or end. But I think this is a reasonable assumption.
2074 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2075 String.trim() to remove the whitespace from the username properties.
2077 2011-11-15 Ben Konrath <ben@bagu.org>
2079 Add details view mockup with HTML tables and text entries.
2081 This is from the attachment on this bug:
2083 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2085 * mockups/details-view-html-tables-text-entries.html:
2087 2011-11-15 Ben Konrath <ben@bagu.org>
2089 Add space between the columns of the flow table.
2093 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2095 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2096 space between columns in the flow table.
2098 2011-11-15 Ben Konrath <ben@bagu.org>
2100 Add backup files to the .gitignore.
2102 * .gitignore: Ignore files that end with ~.
2104 2011-11-09 Ben Konrath <ben@bagu.org>
2106 Use latest release of gwt-log.
2108 Gwt-log releases are now being submitted to the maven central
2109 repository so manual installation of the jar is no longer required.
2111 * pom.xml: Update version and groupId of gwt-log dependency.
2113 2011-10-31 Ben Konrath <ben@bagu.org>
2115 Don't use GWT numeric formatting to override the glom currency formatting.
2117 Currencies are now displayed like they are in Glom. See this bug:
2119 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2121 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2123 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2124 currency code to constructor and set it when the cell is rendered.
2125 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2126 currency code to the constructor of the NumericCell.
2128 2011-10-27 Ben Konrath <ben@bagu.org>
2130 Require the latest release of java-libglom (1.17.4).
2134 2011-10-26 Ben Konrath <ben@bagu.org>
2136 Add style to Notebook that matches current theme.
2138 It's not the best style in the world but it's better than the default.
2140 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2141 padding at the bottom of the child widgets.
2142 * src/main/webapp/style.css: Add style for the Notebook.
2144 2011-10-26 Ben Konrath <ben@bagu.org>
2146 Move servlet initialization code to overridden init method.
2148 This is half of the solution to getting proper error messages
2149 displayed when configuration errors occur. Here's the relevant bug:
2151 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2153 The rest of the solution involves surrounding the init method with a
2154 try/catch block and setting a global variable with the error /
2155 exception. A new async method should be created to retrieve and display
2156 the error message / exception.
2158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2159 code from constructor to init method adding exceptions as needed.
2161 2011-10-26 Ben Konrath <ben@bagu.org>
2163 Add script to monitor and restart tomcat if required.
2165 * utils/check-and-recover-tomcat.py: New file.
2167 2011-10-26 Ben Konrath <ben@bagu.org>
2169 Display the correct number of data items in the pager.
2173 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2175 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2176 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2177 The implementation is the same for both tables: Keep track of the
2178 number of non-empty rows and fire and RowCountChangeEvent after the data has
2180 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2181 custom Pager class that subclasses SimplePager to handle displaying
2182 the correct number when empty rows have been added.
2184 2011-10-26 Ben Konrath <ben@bagu.org>
2186 Correct error in previous commit.
2188 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2189 eventBus parameter from listView.setCellTable().
2191 2011-10-26 Ben Konrath <ben@bagu.org>
2193 Fix error in TODO comment.
2195 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2197 2011-10-24 Ben Konrath <ben@bagu.org>
2199 Create Notebook widgets to the details view.
2201 This isn't finished just yet - I still need to create a reasonable
2202 style to match the current theme.
2204 * src/main/java/org/glom/web/client/Utils.java: Add method for
2205 calculating the height of a widget. This is used in the Notebook class.
2206 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2207 new constructor method in Group.
2208 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2209 method for creating child widget that can be used by subclasses
2210 like Notebook. New constructor that allows disabling the group
2211 titles - Notebooks don't set a group title for their child groups.
2212 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2213 to make Notebooks using GWT's TabLayoutPanel.
2214 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2215 constructor that allows disabling the group titles.
2216 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2217 LayoutItemNotebook DTO.
2218 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2219 DTO for Notebooks. It's just an empty class for now but we might need
2220 it to transfer some specific information in the future.
2222 2011-10-21 Ben Konrath <ben@bagu.org>
2224 Add navigation buttons to related list tables.
2226 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2227 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2228 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2229 method getSuitableRecordToViewDetails() for getting the table name
2230 and primary key value for related list navigation buttons.
2231 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2232 private cell renderer class to get the navigation information for
2233 related list tables from the server. Extract the navigation
2234 processing code from the details cell navigation and use it for the
2235 related list navigation as well.
2236 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2237 cell renderer class for the details open buttons. This was needed
2238 because the related list navigation buttons and the list view
2239 navigation buttons need to react differently when clicked.
2240 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2241 the onEnterKeyDown() method because it's now overriden in the
2242 subclasses that are specific to the related list tables and the list
2244 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2245 the vertical size a little because the buttons add a bit of vertical
2246 space to table. This is not a perfect solution because the vertical
2247 size of with table fewer than 5 rows will be a little smaller.
2248 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2249 changes in how navigation buttons are handled.
2250 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2251 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2252 database access object.
2253 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2254 to find the portal for a given relationship name from
2255 RelatedListDBAccess. Add method to find a primary key field for a
2257 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2258 Move code to find the portal for a given relationship name to
2260 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2261 New file: database access object for getting the related list
2262 navigation information (the table name and the primary key value).
2263 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2264 DTO for transferring a table name to navigate to and a primary key
2266 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2267 boolean and getter/setter to specifies if the related list should add
2270 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2272 Use the master branch of java-libglom
2274 * pom.xml: Depend on java-libglom 1.19 instead.
2276 This is the master branch. See also the libglom-1-18 branch.
2278 2011-10-11 Ben Konrath <ben@bagu.org>
2280 Enable the open navigation button when the data has been set.
2282 This avoids having active buttons that don't do anything when the data
2285 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2287 2011-10-11 Ben Konrath <ben@bagu.org>
2289 Use IsWidget interface for FlowTableItem.
2291 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2292 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2294 2011-10-11 Ben Konrath <ben@bagu.org>
2296 Remove GWT styling from open button in details view.
2298 There are still some issues with how the details cell is arranged but
2299 this should be made to match Glom 1.20. I'm going to leave fixing this
2300 until I have Glom 1.20 up and running.
2302 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2303 style name on open button.
2304 * src/main/webapp/style.css: Move and edit details-navigation class.
2305 Re-arrange some classes to make them appear in the same order as the
2308 2011-10-07 Ben Konrath <ben@bagu.org>
2310 Update to GWT 2.4.0.
2312 * .gitignore: Ignore new cache directory.
2313 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2314 * pom.xml: Change GWT and maven plugin to 2.4.0.
2315 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2317 * src/main/java/org/glom/web/client/ClientFactory.java:
2318 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2319 * src/main/java/org/glom/web/client/OnlineGlom.java:
2320 Update source for API changes.
2321 * utils/build-onlineglom-war.sh: Remove cache directory before the
2324 2011-10-07 Ben Konrath <ben@bagu.org>
2326 Add navigation buttons in the details view.
2328 This isn't finished but I thought I'd commit what I have as it's a
2329 pretty good start. I still need to:
2331 1. Change the style so that it fits better into the current theme
2332 2. Adjust the details cell to expand as much as possible.
2334 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2335 click handlers to navigation buttons in the DetailsCells. Create a
2336 refreshData() method to get just the data from the server without the
2338 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2339 Update the tableSelector and browser title when the table name
2340 changes without using the tableSelector.
2341 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2342 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2343 getDetailsCells() to getCells(). Update variable names.
2344 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2345 method to set click handler on navigation button. Rename a few
2346 variables. Add navigation buttons where needed.
2347 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2348 variables and methods.
2349 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2350 navigation boolean and navigation table as required in the
2351 LayoutItemField DTO.
2352 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2353 variables for navigation along with getter/setter methods.
2355 2011-10-07 Ben Konrath <ben@bagu.org>
2357 Rename Field to DetailsCell.
2359 This is a refactor-only commit. No functionality has been added or
2362 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2363 Update variable and method names.
2364 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2365 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2366 variable and method names.
2367 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2369 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2370 variable and method names.
2372 2011-10-07 Ben Konrath <ben@bagu.org>
2374 Create separate methods for layout and data the details view.
2376 This is a refactor-only commit. No functionality has been added or
2379 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2380 private methods: setData(), createLayout().
2382 2011-10-07 Ben Konrath <ben@bagu.org>
2384 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2386 This is part of a change to get navigation buttons in the details view
2387 but it should have been done this way from the start.
2389 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2390 for method name change in TableSelectionView.
2391 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2392 Create TableChangeEvent and set the browser title using the
2393 TableSelectionView API.
2394 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2395 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2396 Change getSelectedTable() to getSelectedTableName(). Add
2397 getSelectedTableTitle().
2399 2011-10-07 Ben Konrath <ben@bagu.org>
2401 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2403 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2405 2011-10-07 Ben Konrath <ben@bagu.org>
2407 Update TableChangeEvent to use newTableName naming convention.
2409 This makes the class more consistent with GWT naming conventions.
2411 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2412 Update for method name change in TableChangeEvent.
2413 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2414 for method name change in TableChangeEvent.
2415 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2416 newTableName variable and getter method. Make toDebugString()
2419 2011-09-30 Ben Konrath <ben@bagu.org>
2421 Disable the pager in the list tables when the data row count is less than the minimum.
2423 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2424 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2426 2011-09-30 Ben Konrath <ben@bagu.org>
2428 Add empty rows to the end of related list and list view tables.
2430 I also extracted the cell rendering classes from the ListTable because
2431 the code was becoming a little crazy with all the anonymous inner
2432 classes. My plan is to use these cell rendering classes in the details
2433 view as well so this refactor will be needed for that change.
2435 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2436 set the row count in related list tables if the data has more rows
2437 than the minimum number of rows visible.
2438 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2439 row count in list view tables if the data has more rows than the
2440 minimum number of rows visible.
2441 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2442 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2444 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2445 for rendering TYPE_NUMERIC cells. The code was extracted from the
2447 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2448 class for rendering cells with buttons in list views. The code was
2449 extracted from the ListTable class.
2450 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2451 for rendering TYPE_TEXT cells. The code was extracted from the
2453 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2454 Add empty rows to the end of the data if required. Implement
2455 ListTable.getMinNumVisibleRows().
2456 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2457 cell renderer code to public classes. Return null in
2458 Column.getValue() for empty rows. Add new abstract method:
2459 getMinNumVisibleRows(). Move code to set the row count of the list view
2460 table to ListViewImpl.
2461 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2462 empty rows to the end of the data if required. Implement
2463 ListTable.getMinNumVisibleRows().
2466 2011-09-27 Ben Konrath <ben@bagu.org>
2468 Use GWT.log for client-side debugging statements.
2470 These are optimized out when deployed so I should have used this method
2471 in the first place. These statements will eventually be replaced with some sort
2472 of notification in the browser.
2474 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2475 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2476 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2477 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2478 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2480 2011-09-27 Ben Konrath <ben@bagu.org>
2482 Put tableselector on the right, back to list link on right.
2484 The idea is that the table selector is acting like a label for the
2485 currently displayed table so it should be placed below the document title. This
2486 puts the table title in a similar position to where it is in Glom.
2488 * mockups/details-contacts.html:
2489 * mockups/details-projects.html:
2490 * mockups/listview-contacts.html:
2491 * mockups/listview-projects.html:
2492 * mockups/style.css:
2493 Update mockups to match how the interfaces currently look.
2494 * src/main/webapp/style.css: Swap positions of backlink with the table
2495 selector. Add some space on the left side of the table selector to
2496 line things up with the document title.
2498 2011-09-27 Ben Konrath <ben@bagu.org>
2500 Add field colouring to details view.
2502 This change re-works how field colouring works. The colour formatting
2503 information is now set to the client with the layout information instead of
2504 with the data. This eliminates the need to send the same colour strings for
2505 data in list view column when colour information is set.
2507 In order to set an alternate colour for negative numeric values, the
2508 number is now sent to client and formatted with the GWT NumberFormat class.
2510 This change also fixes:
2512 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2514 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2515 internationalization framework which is needed for client side numeric
2517 * src/main/java/org/glom/web/client/Utils.java: New file for some
2518 client static utility methods.
2519 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2520 the DataItem object to the Field class. Use a utility method to
2521 create the foreignKeyValue string.
2522 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2523 alignment and text colours in the constructor. Add setData(DataItem)
2524 method. Remove setText(String) method.
2525 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2526 colour information to GlomTextCell. Create and use GlomNumberCell for
2527 rendering numbers. Use utility method to get the string for the
2528 primary key of the key provider. Re-work how the horizontal alignment
2530 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2531 formatting to layout information. Methods for converting the libglom
2532 formatting information were moved from DBAccess.
2533 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2534 numeric formatting (it's now done on the client side). Don't set text
2535 colours in DataItem. Move libglom formatting conversion methods to
2537 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2538 getters/setters for text colour information.
2539 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2540 for transferring the libglom NumericFormat information to the client.
2541 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2542 and getters/setters for: GlomNumericFormat, background colour and
2543 foreground colour strings.
2545 2011-09-26 Ben Konrath <ben@bagu.org>
2547 Simplify code that iterates through the LayoutGroup.
2549 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2551 2011-09-26 Ben Konrath <ben@bagu.org>
2553 Accept Eclipse formatting for OnlineGlomServiceAsync.
2555 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2557 2011-09-26 Ben Konrath <ben@bagu.org>
2559 Don't use the ListDBAccess classes to get the primary key layout information.
2561 This was causing a bug where the wrong index for the hidden primary key
2562 was being sent to the client.
2564 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2565 primary key while creating the LayoutGroup DTO. Create a
2566 LayoutItemField DTO for hidden primary keys. Don't use the
2567 RelatedListDBAccess because it was only used for getting the primary
2569 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2570 access modifier from public to protected for getPrimaryKeyField() and
2571 getPrimaryKeyLayoutItemField().
2572 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2573 abstract method getExpectedResultSize() because RelatedListDBAccess
2574 doesn't have enough info to implement it.
2575 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2576 Remove @Override for getExpectedResultSize().
2577 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2578 Remove method getExpectedResultSize().
2580 2011-09-23 Ben Konrath <ben@bagu.org>
2582 Log which layout (list or details) the ignored item is from.
2584 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2586 2011-09-23 Ben Konrath <ben@bagu.org>
2588 Remove annotations that turn off code formatting in DataItem.
2590 * src/main/java/org/glom/web/shared/DataItem.java:
2592 2011-09-23 Ben Konrath <ben@bagu.org>
2594 Rename GlomField to DataItem and update associated methods.
2596 This is a rename-only refactor. No functionality has been added or
2599 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2600 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2601 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2602 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2603 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2604 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2605 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2606 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2608 * src/main/java/org/glom/web/server/database/DBAccess.java:
2609 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2610 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2611 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2612 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2613 * src/main/java/org/glom/web/shared/DataItem.java:
2614 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2615 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2617 2011-09-23 Ben Konrath <ben@bagu.org>
2619 Rename GlomDocument to DocumentInfo and update associated methods.
2621 This is a rename-only refactor. No functionality has been added or
2624 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2625 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2626 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2627 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2628 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2629 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2630 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2632 2011-09-20 Ben Konrath <ben@bagu.org>
2634 Require java-libglom 1.17.3.
2636 This picks up the fix for the seg fault problem with the Scenes table
2637 in the Openismus Film Manager example.
2641 2011-09-20 Ben Konrath <ben@bagu.org>
2643 Change the way sort clause is added for primary key when no sort clause is requested.
2645 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2646 before the sort clause is created. When a sort clause is not requested, the
2647 sort clause is created by finding the primary key in the LayoutFieldVector
2650 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2652 2011-09-20 Ben Konrath <ben@bagu.org>
2654 Log error message if no documents are found in the configured directory.
2656 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2657 Extract the glom file extension string to a private static final class
2658 variable (mostly as syntactic sugar). Accept a minor formatting change.
2659 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2660 the example glom.document.directory configuration property to make it
2661 more clear that it can any directory, not just the home directory.
2663 2011-09-18 Ben Konrath <ben@bagu.org>
2665 Add related lists to details view.
2667 The related list table has support for paging and sorting just like the
2668 table in the list view.
2670 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2671 SQL queries for the related list tables.
2672 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2673 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2675 Rename getList methods to getListView and add comments. Remove
2676 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2677 it being unused. Add methods: getDetailsLayoutAndData(),
2678 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2679 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2680 Create the layout and set the data for the fields in one async call
2681 instead of two. Create related lists where appropriate.
2682 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2683 for method name changes in OnlineGlomService.
2684 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2685 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2686 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2688 * src/main/java/org/glom/web/client/ui/ListView.java:
2689 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2690 tableName from setCellTable(). Create a ListViewTable instead of
2692 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2693 represent a data field in the details view.
2694 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2695 from addDetailsCell() to Field class. Keep track of the Fields and
2696 Portals in the details view.
2697 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2698 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2699 and add a method to get it. Add method to set the contents of the
2701 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2702 New class for related list tables. This class has the data provider
2703 for the related list table.
2704 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2705 abstract class which is the base class for the ListViewTable and the
2707 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2708 New class for list view tables. This class has the data provider for
2709 the list view table.
2710 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2711 methods for related list tables. Add more information to the
2712 LayoutItemField and LayoutItemPortal DTOs.
2713 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2714 Remove debugging print statement.
2715 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2716 Remove debugging print statements. Add primary key field to SQL count
2718 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2719 Remove unnecessary LayoutFieldVector parameter from
2720 getResultSizeOfSQLQuery() method.
2721 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2722 New class for related list table database access.
2723 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2724 class that is a wrapper DTO for details view layout and data.
2725 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2726 new 'fromField' string to this DTO.
2727 * src/main/webapp/style.css: Remove bottom margin and override top
2730 2011-09-15 Ben Konrath <ben@bagu.org>
2732 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2734 This sets things up to make it easier to add the data retrieval for
2735 related lists (portals). No user noticeable changes were made with
2738 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2739 class has the code to retrieve the layouts and access the
2740 database using the new database helper classes.
2741 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2742 Most of the functionality has been removed from this class. This
2743 class now represents the public interface for the client side
2744 code. It also deals with configuring the servlet and cleaning
2745 things up when the servlet is stopped.
2746 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2747 of static methods into this utility class.
2748 * src/main/java/org/glom/web/server/database/DBAccess.java:
2749 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2750 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2751 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2752 These classes have the database retrieval code. The class hierarchy
2753 has been setup to make it easy to reuse code for similar
2756 2011-09-06 Ben Konrath <ben@bagu.org>
2758 Create separate classes for list table code and the data provider.
2760 As part of this refactor, I also split up the code a bit to make it
2763 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2764 table code to two new classes (below).
2765 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2766 with code from ListViewImpl.
2767 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2768 New file with code from ListViewImpl.
2770 2011-09-06 Ben Konrath <ben@bagu.org>
2772 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2774 This fixes the LayoutItemPortal DTO to match the libglom layout object
2777 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2779 2011-09-01 Ben Konrath <ben@bagu.org>
2781 Set title of Portals in the Details View.
2783 * pom.xml: Bump required version of java-libglom to 1.17.1.
2784 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2785 widget creation to its own class. Add comments to constructor.
2786 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2787 The code is mostly from the Group class with the title now set.
2788 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2789 title of Portal. Update some comments. Fix some code formatting.
2791 2011-09-01 Ben Konrath <ben@bagu.org>
2793 Remove TODO comment for the flow table column width.
2795 The flow table column width is working correctly and doesn't need to be
2796 changed. See this mailing list post for more info:
2798 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2800 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2802 2011-08-27 Ben Konrath <ben@bagu.org>
2804 Add document title (database name) to top of the browser page.
2806 I added the document title to the TableSelecitonView but that will
2807 change if / when we add a view that doesn't require table selection.
2809 * mockups/details-contacts.html:
2810 * mockups/details-projects.html:
2811 * mockups/listview-contacts.html:
2812 * mockups/listview-projects.html:
2813 * mockups/style.css: Add document title to mockups to keep things
2815 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2816 sizes to account for the document title.
2817 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2818 Set the document title when it has been retrieved from the server.
2819 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2820 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2821 and implement setDocumentTitle(String) method.
2822 * src/main/webapp/style.css: Add ID for document title style.
2824 2011-08-25 Ben Konrath <ben@bagu.org>
2826 Add NavigationType enum to LayoutItemPortal DTO.
2828 This is the start of adding support for Portals to the Details View.
2830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2831 LayoutItem_Portal.navigation_type enum from libglom to
2832 LayoutItemPortal.NavigationType enum.
2833 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2834 NavigationType enum, field for storing the NavigationType and getter
2837 2011-08-25 Ben Konrath <ben@bagu.org>
2839 Implement the flow table layout in the Details View.
2841 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2842 FlowTable to Group to account for the renamed class.
2843 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2844 File. This is a container widget that implements the Glom details view
2845 flow table behaviour.
2846 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2847 org/glom/web/client/ui/FlowTable.java.
2848 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2849 so that the size of the subgroups are a closer match to the size of
2850 the Glom subgroups. This makes the flowtable layout match the layout
2851 in Glom for the Music Collection example file.
2853 2011-08-16 Ben Konrath <ben@bagu.org>
2855 Create container element for LayoutItemPortal in Details View.
2857 This will help me develop the layout for the FlowTable.
2859 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2860 fieldPanel variable to detailsCell.
2862 2011-08-15 Ben Konrath <ben@bagu.org>
2864 Set the height of the data element in the Details View.
2866 I changed the InlineLabels (text in a span element) to Labels (text in
2867 a div element) so that I could set the height of the details-data
2868 elements instead of the details-cell parent elements. This allows the
2869 the details-data element to display the correct height if style is
2870 applied that shows the height.