1 2012-11-09 Murray Cumming <murrayc@murrayc.com>
3 OnlineGlomImages: Detect the mime-type (content type).
5 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
6 doGet(): Instead of hard-coding image/png.
8 2012-11-09 Murray Cumming <murrayc@murrayc.com>
10 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
13 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
14 Java Compiler and Java Build path settings in the UI.
16 2012-11-09 Murray Cumming <murrayc@murrayc.com>
18 Use the latest (now stable) version of GWT.
20 * pom.xml: And the latest version of the gwt-maven-plugin.
22 2012-11-08 Murray Cumming <murrayc@murrayc.com>
24 Added an Indonesian translation.
26 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
27 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
28 This is from the new translation in Glom.
30 2012-07-23 Murray Cumming <murrayc@murrayc.com>
34 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
36 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
38 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
39 for serving image data.
40 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
42 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
43 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
44 setData(): For image field types, add a GWT Image widget,
45 with the URL that was set in the DataItem.
47 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
48 * src/main/java/org/glom/web/server/database/DBAccess.java:
49 convertResultSetToDTO(): Set the URL for image data, so the client browser
50 can retrieve the image from our new servlet. This uses UriBuilder.
51 Move getPrimaryKeyField to:
52 * src/main/java/org/glom/web/server/libglom/Document.java:
53 Added getTablePrimaryKeyField().
55 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
56 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
57 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
60 2012-07-22 Murray Cumming <murrayc@murrayc.com>
64 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
65 * src/main/java/org/glom/web/client/OnlineGlomService.java:
66 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
67 to gwtGlom, which is more appropriate.
68 This servlet name does not seem to be visible to the client side anyway.
70 2012-07-22 Murray Cumming <murrayc@murrayc.com>
72 Tests: Make the imports of assert*() consistent.
74 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
75 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
76 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
77 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
78 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
79 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
80 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
81 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
82 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
83 * src/test/java/org/glom/web/shared/DataItemTest.java:
85 import static org.junit.Assert.*;
86 which seems fairly common.
90 2012-07-21 Murray Cumming <murrayc@murrayc.com>
92 tests: Move a test that needs a database connection.
94 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
95 Move testGetListViewLayoutGroup() to
96 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
97 because it needs a database connection.
99 2012-07-21 Murray Cumming <murrayc@murrayc.com>
101 tests: Use @BeforeClass on tearDown().
103 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
104 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
105 This avoids leaking a postgres process in SelfHostExampleTest.
107 2012-07-21 Murray Cumming <murrayc@murrayc.com>
109 tests: Test translations more.
111 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
112 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
113 Test titles in the non-default locale.
115 2012-07-21 Murray Cumming <murrayc@murrayc.com>
117 tests: Add SelfHostConfiguredDocumentTest
119 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
120 username and password, for use by ConfiguredDocument.
121 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
122 This tests some of the ConfiguredDocument API that requires a database connection.
124 2012-07-21 Murray Cumming <murrayc@murrayc.com>
126 Document: Load title translations and test them.
128 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
129 of titles. I am surprised that we do not do this yet.
130 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
131 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
132 Test translations more.
134 2012-07-20 Murray Cumming <murrayc@murrayc.com>
138 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
139 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
140 Set the timeout here too.
142 2012-07-20 Murray Cumming <murrayc@murrayc.com>
144 tests: ConfiguredDocumentTest: Make this pass.
146 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
147 Disable tests that need a database connection.
149 2012-07-20 Murray Cumming <murrayc@murrayc.com>
151 Use Java 1.7 instead of Java 1.6.
153 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
154 to do this twice, at least for Eclipse.
155 This seems OK because it is the current version.
157 2012-07-20 Murray Cumming <murrayc@murrayc.com>
161 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
162 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
163 Avoid using a null Connection.
165 2012-07-20 Murray Cumming <murrayc@murrayc.com>
167 tests: Add a ConfiguredDocument test.
169 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
172 2012-07-20 Murray Cumming <murrayc@murrayc.com>
174 LayoutItemFIeld: getName(): Use the Field if it is set.
176 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
177 getName(): If the full field details have been set, return its name, so that
178 callers do not need to set the name separately.
179 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
180 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
181 so we can count the rows.
183 2012-07-20 Murray Cumming <murrayc@murrayc.com>
185 tests: SelfHoster: Test SqlUtils too.
187 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
188 Retrieve some data and check it too, as in the regular Glom
189 test_selfhosting_new_from_example.cc test.
190 * src/test/java/org/glom/web/server/SelfHoster.java:
191 createConnection(): Make this public.
193 2012-07-20 Murray Cumming <murrayc@murrayc.com>
195 tests: SelfHoster: createConnection(): Do not warn about expected failures.
197 Let the caller say if the connection is expected to fail, to avoid
198 irrelevant error output.
200 2012-07-20 Murray Cumming <murrayc@murrayc.com>
202 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
204 * src/test/java/org/glom/web/server/SelfHoster.java:
205 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
206 due to the inevitable need to retry the connection while the database server
209 2012-07-20 Murray Cumming <murrayc@murray.com>
211 tests: SelfHoster: createConnection(): Set a timeout.
213 * src/test/java/org/glom/web/server/SelfHoster.java:
214 createConnection(): Use setLoginTimeout() because it otherwise seems to take
215 ages to actually return when it fails.
217 2012-07-20 Murray Cumming <murrayc@murrayc.com>
219 tests: SelfHoster: selfHost(): Close the test connection.
221 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
222 When we check that the connection works, close the connection. This seems
223 to not be closed automatically otherwise.
225 2012-07-20 Murray Cumming <murrayc@murrayc.com>
227 Use slf4j-simple to see JDBC errors.
229 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
231 2012-07-19 Murray Cumming <murrayc@murrayc.com>
233 SelfHoster.discoverFirstFreePort(): Close the socket.
235 * src/test/java/org/glom/web/server/SelfHoster.java:
236 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
238 2012-07-19 Murray Cumming <murrayc@murrayc.com>
240 Avoid another code warning in Eclipse Juno.
242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
243 Do instanceof checks on the FileUtils.listFiles() result and its
246 2012-07-13 Murray Cumming <murrayc@murrayc.com>
248 Avoid some code warnings in Eclipse Juno
250 * src/main/java/org/glom/web/server/libglom/Document.java:
251 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
252 * src/test/java/org/glom/web/server/SelfHoster.java
253 createTextFile(): Make sure that the FileOutputStream is closed.
255 2012-06-22 Murray Cumming <murrayc@murrayc.com>
257 Added OnlineGlomPropertiesTest.
259 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
260 Make sure we never return a null string.
261 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
262 Added tests of the OnlineGlomProperties API, using our sample file.
264 2012-06-20 Murray Cumming <murrayc@murrayc.com>
266 Make OnlineGlomProperties be a normal class.
268 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
269 Move OnlineGlomProperties into its own file to be a regular class:
270 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
271 This makes testing simpler.
273 2012-06-15 Murray Cumming <murrayc@murrayc.com>
275 OnlineGlomServiceImpl.init(): Move some code into a new method.
277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
278 Create addDocument().
280 2012-06-15 Murray Cumming <murrayc@murrayc.com>
282 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
285 OnlineGlomProperties.getKey(): Make this more robust by moving the
286 check for *.*.filename to here.
288 2012-06-15 Murray Cumming <murrayc@murrayc.com>
290 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
292 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
293 init(): Move knowledge of the config file format into the
294 OnlineGlomProperties inner class.
296 2012-06-15 Murray Cumming <murrayc@murrayc.com>
298 SelfHostExampleTest: Make sure we cleanup on failure.
300 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
301 the use of cleanup() to a tearDown() JUnit method.
305 2012-06-12 Murray Cumming <murrayc@murrayc.com>
307 ConfiguredDocument: Add a primary key to portals at least once.
309 * src/main/java/org/glom/web/server/ConfiguredDocument.java
310 updatePortalsExtras): Fix a typo so that we add the primary key
311 column at least once.
312 This is a fix for the previous commit:
313 ConfiguredDocument: Do not add a primary key to portals each time.
315 2012-06-08 Murray Cumming <murrayc@murrayc.com>
317 SelfHoster: Avoid some compiler warnings.
319 * src/test/java/org/glom/web/server/SelfHoster.java
320 executeCommandLineAndWait():
321 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
322 the now-unused streams for stdout and stderr from the command Processes.
323 These are not used because readln() hangs while waiting for a new line,
324 where there may be no next line. The commented out code is still there
325 to help us figure out how to do this properly.
327 2012-06-08 Murray Cumming <murrayc@murrayc.com>
329 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
331 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
332 Make this actually test the cloning again, though it is not very useful
333 now that we do not use the part that had a problem with cloning before.
335 2012-06-08 Murray Cumming <murrayc@murrayc.com>
337 SelfHoster: Keep trying pg_ctl after starting postgres.
339 * src/test/java/org/glom/web/server/SelfHoster.java
340 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
341 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
342 regular Glom. This seems mad but it seems to work because the first
343 command would fail if pg_ctl would eventually fail.
345 2012-06-08 Murray Cumming <murrayc@murrayc.com>
347 SelfHoster: Wait until the server is really ready.
349 * src/test/java/org/glom/web/server/SelfHoster.java
350 selfHost(): Attempt the connection after starting the server, retrying
351 a few times if necessary, so that the server is really ready already when
352 we return from this method.
353 The regular Glom code does this too because pg_ctl reports success too soon.
355 2012-06-08 Murray Cumming <murrayc@murrayc.com>
357 ConfiguredDocument: Do not add a primary key to portals each time.
359 * src/main/java/org/glom/web/server/ConfiguredDocument.java
360 updatePortalsExtras(): Only add an extra primary key field if there is
361 none, to avoid adding one each time we retrieve the details layout from the
363 This should fix bug #676986 (Ben Konrath)
365 2012-05-25 Murray Cumming <murrayc@murrayc.com>
367 Document.load(): Support version 7 documents.
369 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
370 database_title attribute if the title attribute is not there.
373 2012-05-24 Ben Konrath <ben@bagu.org>
375 Add configuration for auto-generating mvn:i18n from with Eclipse.
377 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
379 2012-05-24 Murray Cumming <murrayc@murrayc.com>
381 Update translations, adding French.
383 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
384 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
385 Add a French translation, using the translation from Glom.
387 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
388 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
389 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
390 Update these based on the translations from Glom.
392 2012-05-24 Murray Cumming <murrayc@murrayc.com>
394 SelfHoster: Add some debug println messages to help when things fail.
396 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
397 System.out.println() lines.
399 2012-05-23 Murray Cumming <murrayc@murrayc.com>
401 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
403 * src/test/java/org/glom/web/server/SelfHoster.java:
404 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
405 instance) instead of just /usr/bin (as on Fedora). Check the result when
408 2012-05-23 Murray Cumming <murrayc@murrayc.com>
410 Remove LayoutItemPortal.get/setNavigationTable().
412 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
413 Remove get/setNavigationTable(), which is only a cache, because it is not
414 used, and does not need to be used, because that decision should be made on
416 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
417 updatePortalsExtras():
418 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
419 getNavigationRecord():
420 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
423 2012-05-21 Murray Cumming <murrayc@murrayc.com>
425 Initial self-hosting for tests.
427 * pom.xml: Change the scope for log4j, to hopefully make it
428 available to the test code which uses it indirectly via jOOQ.
429 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
430 self-hosting, though we only use it for testing.
432 * src/main/java/org/glom/web/server/libglom/Document.java:
433 example rows: Use a map instead of a list for each row of values,
434 so we know what field they are for, instead of relying on the sequence
435 being correct. This is not very efficient, but it does not really need
437 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
438 testReadTableExampleRows(): Adapted.
440 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
441 that returns an Object, for generic use. Note that Object seems to be
442 the implicit base even of double.
443 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
444 for use in CREATE TABLE SQL queries.
445 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
446 to do self-hosting of PostgreSQL databases via its command-line
447 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
448 backends/postgres_self.cc. This is incomplete - it needs more
449 warnings about failures and it needs to clean up properly when things
451 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
452 test of this new class.
454 2012-05-21 Murray Cumming <murrayc@murrayc.com>
456 Document: loading example data: Handle exceptions.
458 * src/main/java/org/glom/web/server/libglom/Document.java:
459 DateFormat.parse() and Double.valueOf() can throw exceptions, though
460 Eclipse did not warn about that.
462 2012-05-20 Murray Cumming <murrayc@murrayc.com>
464 Document: load(), save(): Handle the example rows.
466 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
468 * src/main/java/org/glom/web/server/libglom/Document.java:
469 load(), save(): Load and save the example rows, though the date, time
470 and image types are not handled properly yet.
471 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
472 Add testReadTableExampleRows() just to check that something is read.
474 2012-05-20 Murray Cumming <murrayc@murrayc.com>
476 Document: Add save().
478 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
479 Added getTranslationsMap() for use while saving.
480 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
481 Adedd getUseDefaultFormatting() for use while saving.
482 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
483 and several private methods that it uses.
485 This will be useful while testing via self-hosting.
486 It is not complete, but should be complete enough for testing.
488 2012-05-17 Murray Cumming <murrayc@murrayc.com>
490 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
492 * src/main/java/org/glom/web/client/OnlineGlomService.java
493 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
494 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
495 Remove getSortedListViewData() and getSortedRelatedListData(), adding
496 the sort column index and ascending bool to the regular method.
497 Instead, a sort column index of -1 now means no sort.
498 This is less explicit, but it's fairly simple, reduces the amount of
499 code, and makes the OnlineGlomService API slightly smaller.
500 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
501 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
503 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
504 getListViewData(), getRelatedListData():
505 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
506 getListViewData(), getRelatedListData():
507 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
509 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
511 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
516 2012-05-16 Murray Cumming <murrayc@murrayc.com>
518 Use translations for top-level groups too.
520 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
521 updateTitlesForLocale(): Use the translation for the group
522 as well as for child items.
526 Just recompiled to fix a problem in the released .tar.gz file.
530 2012-05-15 Murray Cumming <murrayc@murrayc.com>
532 Corrections to navigation to related records.
534 * src/main/java/org/glom/web/client/OnlineGlomService.java:
535 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
536 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
537 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
538 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
539 relationship name, because the relationship name is not necessarily unique
541 TOOD: This is inefficient, because it passes the whole list of
542 child field items back to the server, but it is more correct, and happens
543 to fix a bug with the primary key being lost after a few navigations.
544 There is probably a chance to make this more efficient anyway in some
547 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
548 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
549 * src/main/java/org/glom/web/server/ConfiguredDocument.java
550 * src/main/java/org/glom/web/server/database/DBAccess.java
551 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
552 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
555 2012-05-15 Murray Cumming <murrayc@murrayc.com>
557 Fix the use of translations.
559 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
560 Add updateTitlesForLocale().
561 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
562 Call it to discard unwanted translations and to make getTitle() return
563 the wanted translation wihout the need for the client code to specify a locale.
564 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
565 getTitle(): Fallback to the original title, as libglom does.
567 2012-05-15 Murray Cumming <murrayc@murrayc.com>
569 Document: Correctly report the number of available translation locales.
571 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
572 the available locale IDs list.
573 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
574 testLocales: Test this.
576 2012-05-15 Murray Cumming <murrayc@murrayc.com>
578 SqlUtils: Use camelCase.
580 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
581 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
582 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
583 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
584 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
585 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
587 2012-05-15 Murray Cumming <murrayc@murrayc.com>
589 Use jOOQ's tableByName() and fieldByName.
591 * pom.xml: Use jOOQ 2.3.1 to get the new API.
592 * src/main/java/org/glom/web/server/SqlUtils.java:
593 build_sql_select_step_with_where_clause(), .createField(),
594 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
595 so we can get correct quoting and escaping. Thanks to Lukas Eder for
596 adding this, and other things, to jOOQ.
598 2012-05-15 Murray Cumming <murrayc@murrayc.com>
600 SqlUtils: Remove the Connection parameters.
602 * src/main/java/org/glom/web/server/SqlUtils.java:
603 build_sql_select_with_key(), build_sql_select_with_where_clause(),
604 createSelect(), build_sql_select_step_with_where_clause(),
605 build_sql_count_select_with_where_clause(),
606 build_sql_select_count_rows(): Remove the Connection parameter because
607 jOOQ does not actually need a connectionwhen it is just used to build
609 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
611 * src/main/java/org/glom/web/server/ReportGenerator.java:
613 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
615 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
616 Constructor, getListData(), getResultSizeOfSQLQuery():
617 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
618 getSelectQuery(), getCountQuery():
619 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
620 getSelectQuery(), getCountQuery():
621 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
622 getNavigationRecord(): Adapted.
624 2012-05-14 Murray Cumming <murrayc@murrayc.com>
628 * src/main/java/org/glom/web/server/SqlUtils.java:
629 get_find_where_clause_quick(): Use a comparison of
630 lowercase values, instead of a simple equals. Regular Glom
631 uses the PostgreSQL ILIKE operator but jOOQ does not
632 support that just yet, though it will soon.
634 2012-05-14 Murray Cumming <murrayc@murrayc.com>
636 TableToViewDetails: Use a real serialization ID.
638 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
639 Though this does not fix the serialization problem.
641 2012-05-12 Murray Cumming <murrayc@murrayc.com>
643 Added LayoutItemPortalDeepCloneTest.
645 2012-05-11 Murray Cumming <murrayc@murrayc.com>
647 Make navigation work again.
649 * src/main/java/org/glom/web/server/libglom/Document.java:
650 Add getLayoutItemFieldShouldHaveNavigation().
651 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
652 Replace get/setAddNavigation() with the partly-existing
653 get/setNavigationTableName(), with an empty string being no navigation,
654 because this is simpler. Use the new
655 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
657 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
658 Add updateFieldsExtras() and call setNavigationTableName in it.
659 getDetailsLayoutGroup(),
660 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
661 createLayout(): Adapted.
662 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
663 Constructor: Adapted.
665 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
666 Replace get/setAddNavigation() with get/setNavigation(), returning a
667 TableToViewDetails class with both the table name and UsesRelationship,
668 because both are need. The previous code used java-libglom's output
669 variable (strangely, via sharedptr) to return both, but we cannot really
671 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
672 getNavigationRecord(): Adapt. However, we cannot actually use the cache
673 here because it somehow gets set to null during deepCopy(). I must test this.
674 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
675 testGetSuitableTableToViewDetails(): Adapted.
677 TODO: Find out why deepClone() is not quite working.
679 2012-05-11 Murray Cumming <murrayc@murrayc.com>
681 DBAccess: Simplify the retrievel of full field details.
683 * src/main/java/org/glom/web/server/database/DBAccess.java
684 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
685 because the Document loading should have done this.
687 2012-05-11 Murray Cumming <murrayc@murrayc.com>
689 Document: Correct loading of doubly-related layout fields.
691 * src/main/java/org/glom/web/server/libglom/Document.java:
692 loadUsesRelationship(): Actually set the related relationship, instead
693 of only setting it if it's not found.
695 2012-05-09 Murray Cumming <murrayc@murrayc.com>
697 Replace all appearances of Colour with color.
699 Because US English is dominant.
701 2012-05-09 Murray Cumming <murrayc@murrayc.com>
703 Use colors in HTML format, solving a warning about an unused function.
705 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
706 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
707 Add *asHTMLColor() versions of methods.
708 TODO: However, we should create and cache the results on the server.
709 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
710 * src/main/java/org/glom/web/client/ui/list/ListTable.java
711 * src/main/java/org/glom/web/server/ConfiguredDocument.java
712 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
713 Use the asHTMLcolor() versions.
715 2012-05-09 Murray Cumming <murrayc@murrayc.com>
717 ListViewTable: Constructor: Take the table name as a parameter.
719 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
720 Constructor: Take the tableName, and set the member variable, because
722 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
723 setCellTable(): Pass the table name.
724 This makes navigation to non-default tables work again. I don't know
725 why it worked before in the master branch.
727 2012-05-07 Murray Cumming <murrayc@murrayc.com>
729 ConfiguredDocument: Restore correct addition of hidden primary key items.
731 * src/main/java/org/glom/web/client/ui/list/ListTable.java
732 (ListTable.createCellTable): Uncomment out the check for the hidden
734 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
735 add primary key items for top-level lists and portals, as before,
736 instead of adding them to each group.
737 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
738 Actually implement the extra methods such as setHiddenPrimaryKey() and
739 comment that these are used only for top-level list groups and in portals.
740 This strangeness suggests even more that this should not be squeezed
741 into the LayoutGroup class.
743 2012-05-07 Murray Cumming <murrayc@murrayc.com>
745 Fix Formatting loading.
747 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
748 getFormattingUsed(): Remove the duplicate Formatting member variable
749 in favour of the one from the base class.
750 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
751 Initialize a new Formatting instead of using null by default, so we
752 have some defaults, instead of having to initialize one later just to
753 get the same defaults. This also makes loading of formatting from the
754 document work, because that expected a non-null.
756 2012-05-07 Murray Cumming <murrayc@murrayc.com>
758 RelatedListTable: Make sure that the tableName is set.
760 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
761 Constructor: Take the tableName so it is available later. Otherwise,
762 the server assumes that we mean the default table and cannot find the
764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
765 setData(): Pass the tableName to the RelatedListTable constructor.
767 2012-05-07 Murray Cumming <murrayc@murrayc.com>
771 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
772 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
773 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
775 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
777 * src/main/java/org/glom/web/server/database/DBAccess.java:
778 convertResultSetToDTO(), getPortal():
779 * src/main/java/org/glom/web/server/database/ListDBAccess.java
781 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
782 Add checks for null objects and out of range access, with log messages to
783 give hints so we can fix these properly.
785 2012-05-07 Murray Cumming <murrayc@murrayc.com>
787 Portals: some corrections.
789 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
791 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
792 constructor: Use getRelationshipNameUsed() instead of getName(), because
793 that is what is meant.
794 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
795 getFromField(): Fix a typo, to get the field name, not the table name.
796 * src/main/java/org/glom/web/server/database/DBAccess.java:
797 getPortal(): Fix a typo that stopped this from working.
799 2012-05-07 Murray Cumming <murrayc@murrayc.com>
801 LayoutItemPortal: Also override getTitleOriginal().
803 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
804 This lets the base getTitle() with no parameters work.
805 TODO: Test this properly.
807 2012-05-06 Murray Cumming <murrayc@murrayc.com>
809 LayoutItemPortal: getTitle*(): Use the relationship title.
811 2012-05-06 Murray Cumming <murrayc@murrayc.com>
813 LayoutItemField: Fix loading of custom titles.
815 * src/main/java/org/glom/web/server/libglom/Document.java
816 loadDataLayoutItemField(): The title, if any, instead of the field
817 title, is stored in a title_custom node. Load it from there.
818 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
820 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
821 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
822 getTitle*() overrides.
823 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
826 2012-05-06 Murray Cumming <murrayc@murrayc.com>
828 LayoutItemField: Fall back to field titles, so some are really shown.
830 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
831 Override getTitleOriginal() and getTitle(), as in java-libglom.
832 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
835 2012-05-06 Murray Cumming <murrayc@murrayc.com>
837 Correct use of setExpectedResultSize().
839 * src/main/java/org/glom/web/server/ConfiguredDocument.java
840 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
841 Use setExpectedResultSize only on top-level groups (for instance, the
842 list layout) or on child portals (in details views).
843 Use the correct table name for portals to avoid SQL errors.
844 Update the expected counts when returning cached layouts.
846 2012-05-06 Murray Cumming <murrayc@murrayc.com>
848 Document: Interpret no group column count as 1.
850 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
851 default, though we now check for this in the UI code anyway.
853 2012-05-06 Murray Cumming <murrayc@murrayc.com>
857 2012-05-06 Murray Cumming <murrayc@murrayc.com>
859 Translatable: Use Hashmap instead of Treemap because GWT supports it.
861 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
862 The use of Treemap lead to this error from async methods, with no
864 "The response could not be deserialized"
866 2012-05-06 Murray Cumming <murrayc@murrayc.com>
868 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
870 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
871 when using the Google -> GWT Compile, or
872 g toolbar button -> GWT Compile Project... feature in Eclipse.
874 2012-05-06 Murray Cumming <murrayc@murrayc.com>
876 ListTable.addColumn(): Protect against a null Formatting.
878 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
879 Create a default Formatting if it is null, because that is the simplest
882 2012-05-06 Murray Cumming <murrayc@murrayc.com>
884 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
886 * src/main/java/org/glom/web/server/ConfiguredDocument.java
887 updateLayoutGroup(): Check that the field is not null.
889 2012-05-06 Murray Cumming <murrayc@murrayc.com>
891 ListViewImpl: Protected against a bad cast error.
893 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
894 onEnterKeyDown(): Do not cast without an instanceof check.
896 2012-05-06 Murray Cumming <murrayc@murrayc.com>
898 ListTable: Protect against an out of range error.
900 * src/main/java/org/glom/web/client/ui/list/ListTable.java
901 createCellTable(): This is unlikely, but can happen while debugging.
903 2012-05-06 Murray Cumming <murrayc@murrayc.com>
905 AsyncMessage onFailure() callbacks: Log the exception message.
907 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
908 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
909 * src/main/java/org/glom/web/client/activity/ListActivity.java:
910 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
911 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
912 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
913 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
914 These are useful clues when something is wrong.
916 2012-05-06 Murray Cumming <murrayc@murrayc.com>
918 ConfiguredDocument: Avoid a null dereference.
920 * src/main/java/org/glom/web/server/ConfiguredDocument.java
921 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
922 details maps are created.
924 2012-05-06 Murray Cumming <murrayc@murrayc.com>
926 Document: Correct the port number parsing.
928 * src/main/java/org/glom/web/server/libglom/Document.java:
929 This lets us actually connect to the database and show the document.
931 2012-05-05 Murray Cumming <murrayc@murrayc.com>
935 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
936 user-interaction, asking us to load a temporary URL in a browser.s
937 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
938 which is apparently necessary for testing the service. See the comment.
939 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
940 Show the exception, if any. This is how I saw the 404 in the HTML in
943 2012-05-05 Murray Cumming <murrayc@murrayc.com>
945 DocumentTest: Move the .glom files into the resources directory.
947 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
948 URI via getResource().
950 2012-05-05 Murray Cumming <murrayc@murrayc.com>
952 Document: Remove the FieldIdentifies inner class.
954 * src/main/java/org/glom/web/server/libglom/Document.java: We only
955 use the Relationship (though the same function in libglom is maybe
956 used in other ways) and so this removes a compiler warning.
958 2012-05-05 Murray Cumming <murrayc@murrayc.com>
960 Document.load() Remove the error code parameter.
962 * src/main/java/org/glom/web/server/libglom/Document.java: load():
963 Remove the parameter. We do not set it yet and it could never have
964 worked as an output parameter (though maybe it did in java-libglom).
965 We could use an exception if we really want the failure reason.
966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
968 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
969 setUp(), testGetSuitableTableToViewDetails(): Adapt.
971 2012-05-05 Murray Cumming <murrayc@murrayc.com>
973 Make some inner classes static.
975 * src/main/java/org/glom/web/server/ConfiguredDocument.java
976 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
977 * src/main/java/org/glom/web/server/ReportGenerator.java
978 * src/main/java/org/glom/web/server/libglom/Document.java
979 Make all inner classes static that can be static.
981 2012-05-05 Murray Cumming <murrayc@murrayc.com>
983 OnlineGlomServiceImpl: Do not load and check for java-libglom.
985 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
986 init(): We do not use java-libglom any more.
988 2012-05-05 Murray Cumming <murrayc@murrayc.com>
990 Remove mentions of java-libglom.
992 * README: Remove mention of java-libglom, because it no longer needed.
993 * utils/build-onlineglom-war.sh:
994 * utils/check-and-recover-tomcat.py:
995 * utils/install-onlineglom-war.sh: Remove these as they are no longer
996 useful. Building is now far easier, with no need for jhbuild.
998 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1000 Fix the build (mvn package)
1002 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1003 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1004 Otherwise the GWT Java->Javascript compilation fails with just this
1005 error, during mvn package or when attempting to view in a browser,
1006 in the GWT developer mode in Eclipse.
1008 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1009 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1010 [INFO] Compiling module org.glom.web.OnlineGlom
1011 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1012 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1013 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1014 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1015 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1016 [INFO] [ERROR] Cannot proceed due to previous errors
1018 It has taken me 2 days to find out what was causing that. After reducing
1019 the code, the compiler eventually showed me the full error message.
1021 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1023 ConfiguredDocument: Cache the cloned and stripped layouts.
1025 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1026 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1027 layout in a map, so we can retrieve it again without rebuilding it.
1029 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1031 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1033 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1035 libglom classes: Implement some auto-generated emthods.
1037 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1039 Add GwtTestOnlineGlomService.
1041 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1042 However, this (and the other GwtTest*) does not seem to run during
1045 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1047 Remove use of unsupported features from client code.
1049 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1050 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1051 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1052 Use our client version of StringUtils instead of the apache commons one.
1054 However, the GWT Javascript compliation still fails.
1056 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1058 Add a Field class and implement some loading of it in Document.
1060 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1062 Initial Document loading implementation, instead of libglom.
1064 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1065 and Translatable classes, and adapt the rest of the code to use them.
1066 However, this is still missing Layout and Field classes and loading.
1068 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1070 Use of jOOQ: Move Field creation into a utility method.
1072 * src/main/java/org/glom/web/server/SqlUtils.java:
1073 This lets us improve it more easily.
1075 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1077 Use of jOOQ: Improve the code to COUNT a sub-select.
1079 * src/main/java/org/glom/web/server/SqlUtils.java:
1080 Move initial query creation into
1081 build_sql_select_step_with_where_clause().
1082 build_sql_select_count_rows(): Use the jOOQ API instead of
1083 concatentating text, because a jOOQ Select*Step is a TableLike,
1084 which is what from() takes.
1086 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1088 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1090 * pom.xml: Depend on jooq.
1091 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1092 methods with jOOQ, based on the C++ implementations in libglom,
1093 with some changes to the logic required by jooQ.
1094 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1096 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1097 * src/main/java/org/glom/web/server/ReportGenerator.java:
1098 * src/main/java/org/glom/web/server/SqlUtils.java:
1099 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1100 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1101 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1102 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1103 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1104 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1105 because jOOQ needs that, though it seems unnecessary.
1107 This is not quite finished. Ideally jOOQ would help us to build
1108 table_name.field_name names, quoting and escaping them properly.
1109 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1111 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1113 Move use of Glom.build_sql*() into a new SqlUtils class.
1115 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1116 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1117 but this will make it easier to start using something other than
1118 libglom or SqlBuilder.
1120 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1122 Update the project URL.
1124 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1126 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1128 Main layout: Use a FlowTable instead of absolute positioning.
1130 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1131 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1132 child panels/widgets must have an absolute position. But that is annoying, so
1133 this adds a FlowTable and puts the child panels in there.
1135 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1137 GwtTestOnlineGlom: Comment out unused code.
1139 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1140 Eclipse has started to say that some code is unused.
1142 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1144 Update to the latest versions of dependencies.
1146 * pom.xml: Update version numbers of dependencies to the latest
1148 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1150 * src/main/java/org/glom/web/server/ReportGenerator.java:
1151 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1152 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1153 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1155 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1156 Modify the imports where necessary.
1158 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1160 Style: Remove overflow:hidden from searchbox
1162 * src/main/webapp/style.css: Because this pushes the Back To Link
1163 label/link on to the next row, which is then hidden due to the
1164 hard-coded (in ems) height.
1166 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1168 Remove some duplicate code.
1170 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1171 getDocumentInfo(): This must have been duplicated during the merge from the
1176 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1178 Reports: Localize the waiting for report message.
1180 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1181 start(): Get the message from the contants.
1182 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1183 Add the string here.
1184 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1185 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1186 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1187 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1188 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1189 Update these files with the English text for newer strings for now.
1191 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1193 Reports: Show a message while waiting for the report.
1195 * src/main/java/org/glom/web/client/ui/ReportView.java
1196 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1197 Add setWaitingText(), to show a message saying that we are
1198 waiting for the report to be ready.
1199 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1200 start(): Call setWaitingText() before calling the async
1203 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1205 ReportGenerator: Specify date and time formats.
1207 * src/main/java/org/glom/web/server/ReportGenerator.java:
1208 createFieldValueElement(): Use the default (and localized)
1209 short formats, though we still need a way to show 4-digit
1210 years without providing the format for every locale.
1211 * src/main/java/org/glom/web/server/database/DBAccess.java:
1212 convertResultSetToDTO(): Use the short formats here too.
1214 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1216 ReportGenerator: Use the correct numeric formatting.
1218 * src/main/java/org/glom/web/server/ReportGenerator.java
1219 createFieldExpression(), createFieldValueElement(): Take the
1220 whole LayoutItem_Field instead of just the field name, so
1221 we have access to the formatting.
1222 createFieldValueElement(): Use JRTextField.setPattern() to
1223 specify the numeric formatting, with the help of a
1224 regular DecimalFormat.
1226 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1228 ReportGenerator: Avoid showing null for group by titles.
1230 * src/main/java/org/glom/web/server/ReportGenerator.java
1231 generateReport(): Use setBlankWhenNull() on the field title
1232 style too, because this is used for values in group by
1235 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1237 ReportGenerator: Add a colon to titles in vertical groups.
1239 * src/main/java/org/glom/web/server/ReportGenerator.java
1240 addFieldToDetailBandVertical(): Pass true for the withColon
1243 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1245 ReportGenerator: Simplify the code by using Position more.
1247 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1249 Reports: Support vertical groups, roughly.
1251 * src/main/java/org/glom/web/server/ReportGenerator.java:
1252 addToReport(): Rename to addGroupToReport() and, if necessary,
1253 call the new addVerticalGroupToReport() method.
1254 createFieldValueElement(): Let the caller specify the Y position
1257 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1259 Reports: Allow a second report to be shown.
1261 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1262 clear(): Do not remove the HTML widget, which broke the whole layout.
1264 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1266 Locales drop-down: Show that we use English by default.
1268 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1269 fillView(): When we use English, just because that is the default, when
1270 no locale is specified, show that in the Locales drop-down instead of
1271 just showing the first item.
1273 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1275 Unselect the Report/Locale/Table combo item when appropriate.
1277 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1278 setPlace(): clear reportName if this is not a ReportPlace.
1279 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1280 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1281 When the provided name is empty, unselect all items, so that none are
1282 indicated. This uses a for loop because I cannot find a single method
1285 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1287 Report: Give the user a way to get back to the list.
1289 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1290 start(), setPlace(): Show the Back To List link on reports, and also
1291 interpret selecting the empty report item as back to list.
1293 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1295 Really show the selected Report name.
1297 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1298 setPlace(): Store the reportName here, if it is that kind of Place.
1299 fillView(): Set the selected Report after filling the list of reports.
1300 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1301 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1302 null Strings, though we need some way to unselect all ListBox items
1305 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1307 ReportGenerator: Try to avoid some problems.
1309 * src/main/java/org/glom/web/server/ReportGenerator.java
1310 addField(): Try to avoid duplicates, and avoid using a null
1313 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1315 Reports: Use quickFind.
1317 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1318 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1319 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1320 getReportHTML(): Add a quickFind parameter.
1321 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1322 start(): Pass the quickFind parameter.
1323 * src/main/java/org/glom/web/server/ReportGenerator.java
1324 generateReport(): Take a quickFind parameter.
1326 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1328 ReportPlace: Actually use the report name.
1330 * src/main/java/org/glom/web/client/place/ReportPlace.java
1331 getPlace(): Do not assign the report name to the quickfind.
1333 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1335 Show java.library.path when complaining.
1337 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1338 init(): When telling us to check java.library.path, show the
1341 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1343 ReportGenerator: Do not show nulls.
1345 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1347 ReportGenerator: Make the title font larger.
1349 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1351 ReportGenerator: Put field titles inside groups, if there are groups.
1353 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1355 ReportGenerator: Take the Report itself instead of the name and group.
1357 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1358 Remove getReportLayoutGroup().
1359 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1360 getReportHTML(): Pass the report instead
1361 of its name and layout group.
1362 * src/main/java/org/glom/web/server/ReportGenerator.java
1363 generateReport(): Use the report object to use the title
1364 instead of the name.
1366 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1368 ReportGenerator: Remove designBand parameters.
1370 * src/main/java/org/glom/web/server/ReportGenerator.java:
1371 Make designBand a class member instead of passing it to all
1374 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1376 ReportGenerator: Add lines, a bit like in the desktop version.
1378 * src/main/java/org/glom/web/server/ReportGenerator.java
1379 addToReport(): Use JRDesignLine.
1381 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1383 ReportGenerator: Correct the title positions and use some bold style.
1385 * src/main/java/org/glom/web/server/ReportGenerator.java:
1386 Break the code up into reusable functions, correct the placement of
1387 titles, and use normal/bold styles as in the reports in the desktop
1390 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1392 ReportGenerator: Add a header band to show the field titles.
1394 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1395 getReportHTML(): Pass the localeId to the ReportGenerator
1397 * src/main/java/org/glom/web/server/ReportGenerator.java
1398 constructor: Take the localeID so we can get translated field
1400 generateReport(), addToReport(), addFieldToBand(): Add field
1401 titles in a column header band.
1403 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1405 Reports drop-down list: Some improvement.
1407 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1408 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1409 Adedd setSelectedReport(),
1410 setReportList(): Add a blank line so that the user can select the
1412 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1413 start(): Show the current report by calling setSelectedReport().
1414 This does not seem to work yet.
1416 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1418 DetailsActivity, ListActivity: Move some variables into a base class.
1420 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1421 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1422 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1423 the clientFactory, documentID, tableName and authenticationPopup into
1424 a base class, to avoid duplication.
1426 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1428 Translate the Reports label.
1430 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1431 Get the "Reports" label string from the constants.
1432 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1433 perties: Add Reports to the constants.
1435 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1437 Reports: Implement grouping.
1439 * src/main/java/org/glom/web/server/ReportGenerator.java:
1440 Handle LayoutItem_GroupBy items and try to do the right thing
1441 with JRDesignGroup. It seems to work.
1443 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1445 Actually show some data with JasperReports.
1447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1448 getReportHTML(): Move most code into a ReportGenerator class.
1449 * src/main/java/org/glom/web/server/ReportGenerator.java:
1450 Recurse into sub-groups, adding fields to the JasperDesign's details
1451 band. Note that we must set an arbitrary width and height, or it just
1452 will not show any data.
1454 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1456 Reports Chooser: Show the titles, not the names.
1458 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1459 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1460 and the names as the values.
1461 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1462 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1463 group now that we provide the report name, so it should always
1466 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1468 Depend on jasperreports.
1470 * pom.xml: Add the dependency. My plan is to use this on the
1473 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1475 Implement navigation to report places.
1477 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1478 start(): Do not bother to handle all events here.
1479 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1480 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1481 Added getSelectedReport().
1482 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1483 .java: start(): When handling a change to the reports chooser,
1484 call getSelectedReport() and goTo() its ReportPlace.
1485 * src/main/java/org/glom/web/client/ui/ReportView.java
1486 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1487 Added setReportHTML() which puts the html in a gwt HTML widget.
1488 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1489 getReportHTML(): Return "TODO" just to show that this works.
1491 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1493 Make ReportPlace usable.
1495 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1496 Mention ReportPlace.
1497 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1498 Correct the @prefix annotation.
1500 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1502 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1504 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1505 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1507 Change getReportLayout() to getReportHMTL() because we will not need to
1508 parse or render the report layout on the client side.
1509 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1510 getReportLayout(): Return the libglom LayoutGroup type because we will
1511 not need to convert to a shared type, because this will not be used on
1513 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1516 Note that there is still no implementation for this.
1519 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1521 Add a (empty) Report Place, View, and Activity.
1523 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1525 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1526 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1527 this into a superclass:
1528 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1529 and also use it as the base of this new ReportPlace:
1530 * src/main/java/org/glom/web/client/place/ReportPlace.java
1532 * src/main/java/org/glom/web/client/ui/ReportView.java
1533 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1534 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1535 Add these, containing mostly boiler-plate for now.
1537 * src/main/java/org/glom/web/client/OnlineGlomService.java
1538 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1539 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1540 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1541 Add API to get the LayoutGroup for the report.
1543 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1545 Add and fill a Reports drop-down list box.
1547 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1549 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1550 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1551 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1552 Added getReports(document, table, localeID), calling
1553 ConfiguredDocument.getReports().
1554 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1555 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1556 Added setReportsList() and a list widget.
1557 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1558 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1563 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1565 Translations: Add Esperanto.
1567 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1568 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1569 properties: Add this translation because someone took the time to make it.
1571 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1573 Adapt to the java-libglom 1.21.7 API.
1575 * src/main/java/org/glom/web/server/ReportGenerator.java:
1576 addToReport(): get_group_secondary_fields() is now
1577 get_secondary_fields().
1580 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1582 Use the latest java-libglom version.
1584 * pom.xml: Use java-libglom 1.21.7.
1586 2012-03-03 Ben Konrath <ben@bagu.org>
1588 Display date and time in details view.
1590 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1592 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1594 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1596 Require the latest java-libglom.
1598 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1600 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1602 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1604 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1605 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1606 an empty quickfind string. I also corrected libglom to create only
1607 empty where clauses for empty quickfind strings, but this avoids the
1610 2012-02-24 Ben Konrath <ben@bagu.org>
1612 Improve the tabs in the Notebook widget.
1616 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1618 Translations: Try to translate the strings.
1620 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1621 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1622 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1623 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1624 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1625 Take the Open translation from GTK+'s .po files.
1626 Take the Details translation from Glom's po files.
1627 I have added the other strings to Glom so we can get translations that way:
1628 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1630 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1632 TableSelectionViewImpl: Put the search label and entry in a div.
1634 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1635 Put the search widgets in a FlowTable so that the CSS can be used to
1636 style them while keeping them together.
1637 * src/main/webapp/style.css: Mention the new div.
1639 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1641 Translate more strings in more locales.
1643 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1644 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1645 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1646 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1647 Translate the "Details" and "Open" string too.
1649 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1650 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1651 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1652 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1653 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1654 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1655 Add these new locales as placeholders though they currently contain English.
1657 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1659 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1661 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1662 Check the ConfiguredDocument* for null before using it.
1664 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1666 Tell Eclipse about the generated java files.
1668 * .classpath: This lets it find OnlineGlomConstants.java.
1669 It would be nice if Eclipse just used the maven build files.
1671 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1673 Prevent a crash when no locale is specified in the URL.
1675 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1676 Avoid returning a null string, obtained from
1677 Window.Location.getParameter(). This caused a crash when it was
1678 later passed to libglom's API.
1679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1680 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1681 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1682 guard against future null strings.
1684 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1686 Use the ?locale= query param instead of the &lang= token param.
1688 * src/main/java/org/glom/web/client/place/ListPlace.java
1689 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1690 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1691 Remove the lang token key and value.
1693 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1694 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1695 When the user selects a different locale from the chooser, use
1696 Window.Location.assign() to change the URL, which then causes a reload.
1698 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1699 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1700 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1701 * src/main/java/org/glom/web/client/activity/ListActivity.java
1702 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1703 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1704 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1705 * src/main/java/org/glom/web/client/ui/ListView.java:
1706 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1708 Remove localeID member variables and method/constructor parameters, instead
1709 using Utils.getCurrentLocaleID() when we need a localID to pass to
1712 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1714 Internationalize the UI strings.
1716 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1717 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1718 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1719 because it is unused. Messages are apparently strings that can have
1720 parameters, but we do not need that yet, so Contants will be enough for now.
1721 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1722 to say that we support the en and de locales.
1723 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1724 The original English strings.
1725 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1726 Some German translations of the English strings.
1727 The i18n goal then uses the .properties file to generate an
1728 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1729 returns an implementation that returns the translated strings.
1730 The documentation suggests putting these in src/java/*/client/, but it seems
1731 best to put it in src/resources/*/client/.
1732 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1733 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1734 instead of hard-coding them.
1735 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1736 but that does not seem to stop the build, though it confuses Eclipse.
1738 You can see the translated string by adding ?locale=de to the URL, like so:
1739 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1741 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1743 Improve null/empty String checks.
1745 * pom.xml: Add a dependency on commons-lang, to use
1746 org.apache.commons.lang.StringUtils.
1747 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1748 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1749 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1750 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1751 Use StringUtils.isEmpty().
1753 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1754 StringUtils class with a static isEmpty() function because we
1755 cannot use org.apache.commons.lang.StringUtils in client-side
1756 GWT code because it (apparently) cannot be compiled to javascript.
1757 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1758 * src/main/java/org/glom/web/client/activity/ListActivity.java
1759 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1760 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1761 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1762 * src/main/java/org/glom/web/client/place/ListPlace.java
1763 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1764 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1765 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1766 * src/main/java/org/glom/web/client/ui/details/Group.java
1767 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1768 our StringUtils.isEmpty() function.
1770 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1772 Update to the latest java-libglom API.
1774 * pom.xml: Require java-libglom 1.21.4.
1775 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1776 getDocumentInfo(), getListViewLayoutGroup():
1777 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1779 * src/main/java/org/glom/web/server/database/DBAccess.java
1780 getFieldsToShowForSQLQueryAddGroup(),
1781 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1782 with either get_database_title_original() or
1783 get_database_title(localeID).
1785 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1787 ConfiguredDocument: Avoid a null pointer exception.
1789 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1790 Initialize localeID to "" to avoid returning a null String which
1791 causes a crash in java-libglom's swing-generated code.
1793 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1795 Some simple renaming.
1797 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1798 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1799 for localeChooser. This seems more appropriate and is less ambiguous
1800 particularly in the .css file.
1802 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1804 ConfiguredDocument: Rename the localedID private member variable.
1806 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1808 Adapt to the latest java-libglom API from git master.
1810 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1811 libglom now uses only Vector instead of List, which uses add() instead of
1814 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1816 ConfiguredDocument: Rename the localedID private member variable.
1818 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1820 Build a source tarball with mvn assembly:single
1822 * assembly.xml: Add this file.
1823 * pom.xml: Use the maven-assembly-plugin and tell it to use
1824 our assembly.xml file.
1826 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1828 OnlineGlomServiceImpl: Get .glom files recursively.
1830 * pom.xml: Depend on commons-io from org.apache.commons.
1831 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1832 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1833 files recursively, and with the easier filter for the extension.
1834 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1835 simplify that code too.
1837 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1839 README: Mention that you must install java-libglom packages separately.
1841 But then it works, because java-libglom is now in the central maven
1844 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1846 locales drop-down: Show the correct selected locale when the URL changes.
1848 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1849 .java: setPlace(): Move some code into fillView().
1851 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1853 locales drop-down: Do not lose the primary key.
1855 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1856 start(): onLocaleChange(): Pass the current primary key value,
1857 instead of an empty value.
1859 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1861 locales drop-down: Do not lose the drop-down selection.
1863 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1864 .java (TableSelectionActivity.fillView): Set the selected locale
1865 after changing the drop-down items (though we do not really need
1866 to change them just because the locale changes.)
1868 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1870 locales drop-down: Change the tables list when this changes.
1872 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1873 .java: TableSelectionActivity.start(): Move the async table titles
1874 retrieval into a private fillView() method and also call this when
1875 the chosen locale changes.
1876 Note that the document title is not actually translatable yet, but
1877 that is a problem that I should fix soon in libglom.
1879 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1881 Improve the placement of the locales drop-down.
1883 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1884 Put the title and locales drop-down in a div (gwt.FlowTable).
1885 * src/main/webapp/style.css: Add magic css properties to make this work.
1886 Also remove the left margin from the title so that it lines up with the
1889 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1891 locales selector: Show human-readable locale titles.
1893 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1894 getDocumentInfo(): Use java.util.Locale to show a real title of
1895 each locale, in the locale's own language.
1897 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1899 Add a language/locale selector drop-down.
1901 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1902 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1903 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1904 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1905 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1906 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1907 Add a ListBox to show the available locales. Add getLocaleSelector(),
1908 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1909 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1910 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1911 java: Add these classes.
1912 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1913 start(): Fill the locales ListBox. Handle its change event, firing a
1915 setPlace(): Show the selected locale as specified by the URL token.
1916 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1917 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1918 Handle LocaleChangeEvent, going to a new *Place with that locale.
1920 The placement of the ListBox is not pretty, and it currently uses the ID
1921 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1925 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1927 Search box: Show the search text from the URL token.
1929 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1930 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1931 Add setQuickFindText().
1932 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1933 .java: setPlace(): Store the queryText if the place is a ListPlace,
1934 and call TableSelectionView.setQuickFindText().
1936 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1938 Allow use of translations via, for instance, &lang=de in the URL.
1940 * pom.xml: Use the unstable java-libglom 1.21 version.
1942 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1943 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1944 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1945 init(): Instead of calling TranslatableItem.set_current_locale()
1946 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1947 However, this is only for default locales, which are not needed to
1948 change the locale in the URL.
1949 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1950 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1951 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1952 layout for a particular locale.
1953 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1954 Add get/setDefaultLocaleID().
1955 getDocumentInfo(), getListViewData(), getRelatedListData(),
1956 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1957 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1958 localeID parameter, so we can get the layout for a particular locale.
1960 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1961 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1962 * src/main/java/org/glom/web/client/place/ListPlace.java:
1963 Parse and construct a lang parameter too.
1965 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1966 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1967 passed to subsequent methods and constructors.
1968 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1969 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1970 Store the localeID from the *Place and pass it to other constructors
1971 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1973 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1974 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1975 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1976 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1977 * src/main/java/org/glom/web/client/ui/ListView.java:
1978 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1979 Take localeID parameters and pass them to subsequent constructors and
1980 methods, so that the layout is always retrieved for that locale.
1982 This is rather repetitive.
1984 Note that "" means the original (default) locale of the Glom document,
1985 which is usually English.
1987 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1989 Documents: Remove final keyword to fix startup configuration.
1991 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1992 final keywords on the private member variables because that breaks
1993 the startup, apparently (there are warnings) because it stops them
1994 from being serialized. I added these in the previous commit.
1996 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1998 Documents: Add some final keywords.
2000 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2003 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2005 OnlineGlomServiceImpl: Add to overview comments.
2007 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2008 Note that this is where all the document are loaded. They are not
2009 loaded freshly for each page.
2011 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2015 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2016 Add a TextBox for the text of a quick find.
2017 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2019 setBackLink(): Add a String quickFind parameter.
2020 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2021 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2022 to the base interface, because that is how TableSelectionViewImpl is used.
2023 * src/main/webapp/style.css: Add style for the search box and its label.
2025 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2026 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2027 Add these files, based on the existing TableChangeEvent and
2028 TableChangeEventHandlers.
2029 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2030 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2031 a ListPlace() that the user should be taken to.
2032 * src/main/java/org/glom/web/client/activity/ListActivity.java
2033 start(): Handle it here too and adapt the TableChangeEvent handler to
2034 pass the extra "" quickFind parameter to ListPlace.
2035 * src/main/java/org/glom/web/client/place/ListPlace.java:
2036 Constructor: Take an extra String quickFind parameter and store it,
2037 returning it from a new getQuickFind() method.
2038 getToken(): Put the quickFind text in the URL token.
2039 getPlace(): Parse the quickFind text from the URL token.
2040 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2041 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2042 ListPlace constructor.
2043 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2044 .java: start(): Add a Change handler for the TableSelectionView's
2045 TextBox (via its base HasChangeHandlers interface), firing the new
2046 QuickFindChangeEvent.
2047 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2048 pass the extra "" quickFind parameter.
2050 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2051 setCellTable(): Add a String quickFind parameter and pass it to
2052 the ListViewTable() constructor.
2053 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2054 setCellTable() in the base interface, because that is how ListViewImpl
2057 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2058 Add a String quickFind member variable.
2059 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2060 Constructor: Add a String quickFind parameter, storing it in the
2061 base ListTable's member variable.
2062 onRangeChanged(): Pass quickFind to the
2063 OnlineGlomServiceAsync.getSortedListViewData() and
2064 OnlineGlomServiceAsync.getListViewData() methods.
2066 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2067 getListViewData(), getSortedListViewData(): Add a String quickFind
2068 parameter, passing it to ConfiguredDocument.getListViewData().
2069 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2070 Change getListViewData(), getSortedListViewData() in the base interface,
2071 because that is how OnlineGlomServiceImpl is used, via this:
2072 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2073 Change getListViewData(), getSortedListViewData() here too.
2074 This class can apparently be used to asynchronously call methods on
2075 OnlineGlomService, and GWT seems to implement that after recognizing
2076 just the *Async name convention and the extra AsyncCallback parameters.
2078 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2079 getListViewData(): Add a String quickFind parameter, and pass it to
2080 ListViewDBAccess.getData().
2081 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2082 getListData(): Add a String quickFind parameter and pass it to
2084 getSelectQuery(): Add a String quickFind parameter.
2085 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2086 getSelectQuery(): Add a String quickFind parameter and use it with
2087 Glom.get_find_where_clause_quick() to pass a where_clause to
2088 Glom.build_sql_select_with_where_clause(), to actually filter the
2090 getData(): Add a String quickFind parameter, passing it to getListData().
2091 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2092 va: getData(): Pass an empty string to getListData() for the
2093 quickFind parameter.
2095 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2097 ListTable: Minor change.
2099 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2100 createCellTable(): Make this protected instead of public.
2102 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2104 Many files: Use final for the parameters and use the @override attribute.
2106 2012-01-22 Ben Konrath <ben@bagu.org>
2108 Add anchor links for single line text that starts with http, ftp and www.
2112 2012-01-22 Ben Konrath <ben@bagu.org>
2114 Add ellipsis to single line text in details view.
2118 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2120 Remove all javadoc author tags.
2122 Because they are awkward and meaningless when many people touch
2124 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2126 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2128 Revert the COPYING.LESSER to COPYING rename.
2130 Apparently both should be there if it is LGPL.
2132 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2134 *View: Remove unused imports.
2136 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2137 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2138 * src/main/java/org/glom/web/client/ui/ListView.java:
2139 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2140 Remove unused imports, as suggested by Eclipse.
2142 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2144 Move the *View::Presenter types, and some API into one base View.
2146 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2147 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2148 * src/main/java/org/glom/web/client/ui/ListView.java:
2149 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2150 Presenter, setPresenter() and clear() into a shared base interface,
2151 to avoid the unnecessary duplicate Presenter types and to more clearly
2152 show how the *Views share the same structure, even if they are not
2153 used polymorphically.
2155 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2156 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2158 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2159 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2160 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2162 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2165 Feel free to revert this if there is a good reason for the duplicate
2168 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2170 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2172 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2173 a class member instead of a local variable in the method.
2174 This lets us use it to get the view instances, for use in tests.
2175 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2176 beforeOnlineGlom(): Test some more details of the initial view.
2177 Again, this is not very useful.
2179 To really test gwt-glom we will need to start a local postgresql
2180 instance with local data, like the Glom tests in C++.
2182 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2184 pom.xml: Mention the LGPL license.
2186 * pom.xml: Add a licenses section.
2187 * COPYING.LESSER: Move this to COPYING, which
2188 previously contained the GPL. But gwt-glom is all LGPL.
2190 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2192 Add project information to README and pom.xml.
2194 * README: Add a brief description and mention some mvn
2196 * pom.xml: This extra information shows up in mvn site
2199 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2201 Use the latest java-libglom version.
2203 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2205 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2207 GwtTestOnlineGlom: Test a little more.
2209 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2210 protected rather than private, as suggested by the gwt-test-utils
2212 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2213 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2214 Test the initial visibility of the panels.
2216 However, this is not a very useful test.
2217 And I wonder how we should generally test using this idea for an
2218 activity/places app like ours where the real changes happen implicitly
2219 based on the history token/URL.
2221 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2223 Slight modification to *Mapper comments.
2225 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2226 (DataActivityMapper)
2227 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2229 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2231 Remove comments mentioning GIN because they are just copied from
2232 the example code and are apparently not helpful:
2233 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2234 Also change the mention of a class that is only in the example code.
2236 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2238 GwtTestOnlineGlom test: Minor changes.
2240 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2241 Avoid the long qualified class name and modify the comment
2242 because it is now obvious to me that the mocked class is the only
2243 custom one created via GWT.create().
2245 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2247 Tests: Added the beginnings of a test using gwt-test-utils.
2249 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2250 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2251 which tells gwt-test-utils what class will be tested.
2252 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2253 Add a simple (but empty) test case. One class, used by the OnlineGlom
2254 class, is mocked so that it can be created. However, I am not sure
2255 why only this class needs to be mocked.
2257 Note that mockito seems more popular, and clearer, than easymock,
2258 but I have not got that working yet. It might be a matter of the
2261 This test is run during mvn integration-test.
2263 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2265 Tests: Use junit4-style syntax instead of junit3-style.
2267 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2268 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2269 * src/test/java/org/glom/web/shared/DataItemTest.java:
2270 Use the @Test annotation rather than relying on the test*() prefix.
2271 Also no longer implement TestCase, to avoid triggering support for
2272 the junit3-way, which stops the annotations from working.
2273 Change the imports from import junit.framework.* to
2274 import org.junit.*, which is apparently the new way.
2276 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2278 Added a test for ListPlace token parsing and creation.
2280 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2281 This is much the same as DetailsPlaceTest.
2283 I wonder how we could test the other parts of the *Place API.
2285 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2287 DetailsPlace test: Also test getToken() and recreation via getPlace().
2289 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2290 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2291 recreate it, testing the recreated DetailsPlace for the same parameter
2294 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2296 Use the surefire-report plugin.
2298 * pom.xml: This generates a HTML report about the tests in
2299 target/site/surefire-report.html
2300 when you do mvn surefire-report:report. It seems to be popular/normal.
2302 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2304 Added a test for DetailsPlace.
2306 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2307 Test the getPlace() token parsing.
2309 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2311 Added a first unit test.
2313 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2314 * src/test/java/org/glom/web/shared/DataItemTest.java:
2315 This is a silly test but it is just to get things started. Note that
2316 maven/junit finds the test because it looks in src/test by default.
2318 2011-12-22 Ben Konrath <ben@bagu.org>
2320 Change charsetName to "UTF-8" when replacing line breaks.
2322 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2323 that work in Java (such as "UTF8") will not work when compiled to
2326 This fixes a problem with multi-line details view fields that have hard
2327 line breaks. The "License Text" field on this page demonstrates the
2330 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2332 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2334 2011-12-22 Ben Konrath <ben@bagu.org>
2336 Fix another bug with related list navigation.
2338 I've tested all the navigation buttons in all of the related lists
2339 so things should be good now.
2341 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2343 2011-12-22 Ben Konrath <ben@bagu.org>
2345 Fix a crasher when refreshing the list view with the default table.
2347 This crash will also happen when loading the list view with the default
2348 table from a link or bookmark.
2350 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2351 to the main document selection page when the document id hasn't been
2353 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2354 the main document selection page when the document id hasn't been
2356 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2357 values for the details place when the document id hasn't been set.
2358 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2359 values for the list place when the document id hasn't been set.
2361 2011-12-21 Ben Konrath <ben@bagu.org>
2363 Protect against NPE when glom.document.locale is not in config.
2365 This patch protects against an NPE when glom.document.locale is not in
2366 the config file. This NPE will also happen if glom.document.locale is
2369 The patch also updates the error message to display the class name when
2370 the getMessage() returns null. This was happening when the NPE was
2371 thrown and I had "Configuration Error: null". If an NPE is encountered
2372 with this patch, "Configuration Error: NullPointerException " will be
2375 This commit closes this bug:
2377 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2381 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2383 Rename onlineglom.properties to onlineglom.properties.sample.
2385 * src/main/resources/onlineglom.properties: Rename to:
2386 * src/main/resources/onlineglom.properties.sample:
2387 * src/main/resources/README: And add this file explaining that people
2388 should rename it back when deploying.
2390 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2392 Allow choosing the translation in the .properties file.
2394 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2395 init(): Read a glom.document.locale value from the configuration file
2396 and call Glom's TransatableItem::set_current_locale() method.
2397 * src/main/resources/onlineglom.properties: Add a commented-out
2398 example of this new setting.
2400 It would be better to add &lang=de_DE to the URL, but the current
2401 libglom API does not allow us to do this easily. I am working on that.
2403 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2405 Avoid a crash in parsing of token parameters.
2407 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2408 ava: getTokenParams(): Do not crash if a parameter has a key but no
2409 value, and ignore parameters with neither.
2411 2011-12-17 Murray Cumming <murrayc@murayc.com>
2413 History token building/handling: Improve use of token parameters.
2415 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2416 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2417 and buildParamsToken(HashMap), for use by derived classes.
2418 Make the separator private because it is no longer be needed.
2419 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2420 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2421 instead of manual string concatenation.
2422 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2423 of hardcoded indices and awkward splitting code.
2424 * src/main/java/org/glom/web/client/place/ListPlace.java
2425 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2426 instead of manual string concatenation.
2427 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2428 of hardcoded indices and awkward splitting code.
2429 This should fix bug #666420
2431 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2433 Fix a Navgiation->Navigation typo in the code.
2435 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2436 Rename processNavgiation() to processNavigation().
2438 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2440 Fix a seperator->separator typo in the code.
2442 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2443 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2444 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2447 2011-12-15 Ben Konrath <ben@bagu.org>
2449 Cleanup some comments.
2451 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2453 2011-12-14 Ben Konrath <ben@bagu.org>
2455 Replace \n with <br/> for multiline text in the details view.
2457 Vertical scrollbars are added when needed as well.
2459 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2461 2011-12-14 Ben Konrath <ben@bagu.org>
2463 Specify the font for document selection links.
2465 * src/main/webapp/style.css:
2467 2011-12-14 Ben Konrath <ben@bagu.org>
2469 Fix bouncy CellTable while paging.
2471 This doesn't currently work with related list tables in unselected
2474 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2476 2011-12-14 Ben Konrath <ben@bagu.org>
2478 Revamp the appearance of the document selection page.
2480 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2481 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2482 * src/main/webapp/style.css:
2484 2011-12-13 Ben Konrath <ben@bagu.org>
2486 Set navigation button column to the smallest size possible.
2488 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2490 2011-12-13 Ben Konrath <ben@bagu.org>
2492 Change OpenButton nomenclature to NavigationButton.
2494 Using NavigtionButton makes things more generic. Classes, methods and
2495 variables have been changed.
2497 This is a rename-only refactor.
2499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2500 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2501 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2502 Renamed from OpenButtonCell.
2503 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2504 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2505 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2507 2011-12-12 Ben Konrath <ben@bagu.org>
2509 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2511 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2512 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2513 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2514 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2516 2011-12-12 Ben Konrath <ben@bagu.org>
2518 Update variable names and comments.
2520 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2521 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2523 2011-12-12 Ben Konrath <ben@bagu.org>
2525 Properly initialize numNonEmptyRows variable to zero.
2527 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2528 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2530 2011-12-05 Ben Konrath <ben@bagu.org>
2532 Add latest mockup with HTML tables.
2534 Features of this mockup:
2536 -> HTML table for flowtable
2537 -> HTML table for flowtable column
2538 -> Example of how related lists would look
2539 -> Not using text entries for data items
2541 The current version of Online Glom doesn't use HTML tables for the
2544 This mockup has been sent to the glom-devel mailing list but it's good
2545 to have it here as well.
2547 * mockups/details-view-html-tables.html:
2549 2011-12-05 Ben Konrath <ben@bagu.org>
2551 Remove unnecessary getPrimaryKeyField() method.
2553 getPrimaryKeyFieldForTable(String) has been renamed to
2554 getPrimaryKeyField(String).
2556 * src/main/java/org/glom/web/server/database/DBAccess.java:
2557 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2558 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2560 2011-12-05 Ben Konrath <ben@bagu.org>
2562 Add string representation of TypedDataItem value to conversion error message.
2564 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2565 message was extracted into its own method to avoid duplication.
2567 2011-12-05 Ben Konrath <ben@bagu.org>
2569 Add type checking to navigation primary key value creation.
2571 Create navigation primary key only if the expected type from the Glom
2572 document matches the type returned by the SQL query.
2574 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2576 2011-12-05 Ben Konrath <ben@bagu.org>
2578 Rename a couple of variables in RelatedListNavigation.
2580 This is a rename-only refactor.
2582 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2584 2011-12-05 Ben Konrath <ben@bagu.org>
2586 Move getListLayoutGroup() into getListViewLayoutGroup().
2588 This removes getListLayoutGroup(). It was only being called by
2589 getListViewLayoutGroup().
2591 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2593 2011-12-05 Ben Konrath <ben@bagu.org>
2595 Remove check for LayoutItem_Portal in list table method.
2597 This check is no longer necessary because the method isn't being used
2598 to create the LayoutItemPortal DTO.
2600 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2602 2011-12-05 Ben Konrath <ben@bagu.org>
2604 Properly support related list navigation.
2606 Navigation from the "Repository Analyzer -> Package Scans ->
2607 Dependencies" related table wasn't working because the primary key for
2608 related tables wasn't being set properly. This commit fixes the
2611 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2612 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2613 doesn't set the primary key properly for related list tables.
2614 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2615 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2616 useful for getting the primary key for list view tables and for related
2618 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2619 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2620 Move code to set the primary key for the table from the abstract
2621 ListDBAccess class to ListViewDBAccess as it's only correct for list
2623 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2624 Properly add primary key to related list tables.
2626 2011-12-02 Ben Konrath <ben@bagu.org>
2628 Properly set the horizontal alignment of fields.
2630 This fix is for both the list tables and the details view.
2632 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2633 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2634 to set the horizontal alignment of fields.
2636 2011-12-02 Ben Konrath <ben@bagu.org>
2638 Display currency codes in the details view.
2640 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2642 2011-12-02 Ben Konrath <ben@bagu.org>
2644 Avoid duplicate JNI call.
2646 JNI is not as efficient as pure Java and this is an easy (and small)
2649 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2650 Use previously retrieved value for whereClauseToTableName instead of
2653 2011-12-02 Ben Konrath <ben@bagu.org>
2655 Rename a couple of variables in RelatedListNavigation.
2657 This is a rename-only refactor.
2659 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2661 2011-12-02 Ben Konrath <ben@bagu.org>
2663 Indicate clearly that a mismatched primary key type is a bug.
2665 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2666 warning to error. Add 'This is a bug.' to message.
2668 2011-12-02 Ben Konrath <ben@bagu.org>
2670 Update / fix some comments.
2672 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2674 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2676 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2677 Fix comments. Add some TODOs.
2679 2011-12-02 Ben Konrath <ben@bagu.org>
2681 Enable navigation to details view with string primary key from related list.
2683 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2684 Create a text primary key value when return type of result is
2685 java.sql.Types.VARCHAR.
2687 2011-12-02 Ben Konrath <ben@bagu.org>
2689 Use checkboxes for booleans in the details view.
2691 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2693 2011-12-01 Ben Konrath <ben@bagu.org>
2695 Improve performance of related list height calculation.
2697 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2698 Put code to calculate the expected height in a static initializer so
2699 that that it's only called once.
2701 2011-12-01 Ben Konrath <ben@bagu.org>
2703 Show related list tables in notebooks (again).
2705 Calculate the height of the related list tables so the Notebook can be
2706 set the correct height. The height of the related list table is also needed by
2707 FlowTable to be able decide how to create the layout.
2709 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2710 and set the Portal height based on the height of the related list
2711 table and the Portal container.
2712 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2713 Add method to calculate the height of the related list tables.
2714 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2715 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2716 calculate the height of the Pager widget.
2718 2011-12-01 Ben Konrath <ben@bagu.org>
2720 Use CellTable API for table property instead of setting style on Element.
2722 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2724 2011-12-01 Ben Konrath <ben@bagu.org>
2726 Make ListViewTable and RelatedListTable a consistent height.
2728 The tables are now a consistent height regardless of the contents of
2729 the table. A hidden button is added to empty rows to ensure that the
2730 height of these rows will match the height of rows with data.
2732 A navigation button column is now added to every table. The width of
2733 the navigation column is set to 0px when a RelatedListTable shouldn't
2734 have navigation buttons. This maintains the a consistent row height in
2735 tables that don't show the navigation buttons.
2737 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2738 navigation column when not needed.
2739 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2740 arguments for navigation button to constructor of ListViewTable.
2741 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2742 hidden button for empty data rows.
2743 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2744 arguments for navigation button to constructor.
2745 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2746 create navigation buttons. Add hideNavigationButtons() method.
2747 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2748 arguments for navigation button to constructor.
2750 2011-12-01 Ben Konrath <ben@bagu.org>
2752 Use 'visibility: hidden' in Utils.getWidgetHeight().
2754 This is better choice because hidden elements are invisible, don't
2755 respond to events and are not part of the tab order. They will,