From 8f011f6b3ef49ee70c9e4edc1966aef420d45cbc Mon Sep 17 00:00:00 2001 From: Murray Cumming Date: Thu, 19 Jul 2012 19:56:31 +0200 Subject: [PATCH] SelfHoster.discoverFirstFreePort(): Close the socket. * src/test/java/org/glom/web/server/SelfHoster.java: discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this. --- ChangeLog | 7 +++++++ src/test/java/org/glom/web/server/SelfHoster.java | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 46dc150..26bb795 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2012-07-19 Murray Cumming + SelfHoster.discoverFirstFreePort(): Close the socket. + + * src/test/java/org/glom/web/server/SelfHoster.java: + discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this. + +2012-07-19 Murray Cumming + Avoid another code warning in Eclipse Juno. * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: diff --git a/src/test/java/org/glom/web/server/SelfHoster.java b/src/test/java/org/glom/web/server/SelfHoster.java index 71b06d7..403c128 100644 --- a/src/test/java/org/glom/web/server/SelfHoster.java +++ b/src/test/java/org/glom/web/server/SelfHoster.java @@ -502,7 +502,9 @@ public class SelfHoster { final ServerSocket socket = new ServerSocket(port); // If the instantiation succeeded then the port was free: - return socket.getLocalPort(); // This must equal port. + final int result = socket.getLocalPort(); // This must equal port. + socket.close(); + return result; } catch (final IOException ex) { continue; // try next port } -- 2.1.4