online-glom:gwt-glom.git
11 years agoChange the way sort clause is added for primary key when no sort clause is requested.
Ben Konrath [Tue, 20 Sep 2011 14:24:34 +0000 (16:24 +0200)]
Change the way sort clause is added for primary key when no sort clause is requested.

The primary key is now added to the LayoutFieldVector (fieldsToGet)
before the sort clause is created. When a sort clause is not requested, the
sort clause is created by finding the primary key in the LayoutFieldVector
(fieldsToGet).

* src/main/java/org/glom/web/server/database/ListDBAccess.java:

11 years agoLog error message if no documents are found in the configured directory.
Ben Konrath [Tue, 20 Sep 2011 10:21:43 +0000 (12:21 +0200)]
Log error message if no documents are found in the configured directory.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
Extract the glom file extension string to a private static final class
variable (mostly as syntactic sugar). Accept a minor formatting change.
* src/main/resources/onlineglom.properties: Add '/glomfile' to end of
the example glom.document.directory configuration property to make it
more clear that it can any directory, not just the home directory.

11 years agoAdd related lists to details view.
Ben Konrath [Sun, 18 Sep 2011 15:52:34 +0000 (17:52 +0200)]
Add related lists to details view.

The related list table has support for paging and sorting just like the
table in the list view.

* pom.xml: Require java-libglom 1.17.2 for the new methods to build the
SQL queries for the related list tables.
* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Rename getList methods to getListView and add comments. Remove
getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
it being unused. Add methods: getDetailsLayoutAndData(),
getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
Create the layout and set the data for the fields in one async call
instead of two. Create related lists where appropriate.
* src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
for method name changes in OnlineGlomService.
* src/main/java/org/glom/web/client/ui/DetailsView.java:
* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
visible UI objects.
* src/main/java/org/glom/web/client/ui/ListView.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
tableName from setCellTable(). Create a ListViewTable instead of
ListTable.
* src/main/java/org/glom/web/client/ui/details/Field.java: New class to
represent a data field in the details view.
* src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
from addDetailsCell() to Field class. Keep track of the Fields and
Portals in the details view.
* src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
and add a method to get it. Add method to set the contents of the
portal.
* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
New class for related list tables. This class has the data provider
for the related list table.
* src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
abstract class which is the base class for the ListViewTable and the
RelatedListTable.
* src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
New class for list view tables. This class has the data provider for
the list view table.
* src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
methods for related list tables. Add more information to the
LayoutItemField and LayoutItemPortal DTOs.
* src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
Remove debugging print statement.
* src/main/java/org/glom/web/server/database/ListDBAccess.java:
Remove debugging print statements. Add primary key field to SQL count
query.
* src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
Remove unnecessary LayoutFieldVector parameter from
getResultSizeOfSQLQuery() method.
* src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
New class for related list table database access.
* src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
class that is a wrapper DTO for details view layout and data.
* src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
new 'fromField' string to this DTO.
* src/main/webapp/style.css: Remove bottom margin and override top
margin with 0em.

11 years agoBreakup the OnlineGlomServiceImpl class to make it more manageable.
Ben Konrath [Thu, 15 Sep 2011 12:13:21 +0000 (14:13 +0200)]
Breakup the OnlineGlomServiceImpl class to make it more manageable.

This sets things up to make it easier to add the data retrieval for
related lists (portals). No user noticeable changes were made with
this commit.

* src/main/java/org/glom/web/server/ConfiguredDocument.java: This
class has the code to retrieve the layouts and access the
database using the new database helper classes.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Most of the functionality has been removed from this class. This
class now represents the public interface for the client side
code. It also deals with configuring the servlet and cleaning
things up when the servlet is stopped.
* src/main/java/org/glom/web/server/Utils.java: Extract a couple
of static methods into this utility class.
* src/main/java/org/glom/web/server/database/DBAccess.java:
* src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
* src/main/java/org/glom/web/server/database/ListDBAccess.java:
* src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
These classes have the database retrieval code. The class hierarchy
has been setup to make it easy to reuse code for similar
functionality.

11 years agoCreate separate classes for list table code and the data provider.
Ben Konrath [Tue, 6 Sep 2011 11:12:55 +0000 (13:12 +0200)]
Create separate classes for list table code and the data provider.

As part of this refactor, I also split up the code a bit to make it
more manageable.

* src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
table code to two new classes (below).
* src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
with code from ListViewImpl.
* src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
New file with code from ListViewImpl.

11 years agoChange the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
Ben Konrath [Tue, 6 Sep 2011 10:13:52 +0000 (12:13 +0200)]
Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.

This fixes the LayoutItemPortal DTO to match the libglom layout object
hierarchy.

* src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:

11 years agoSet title of Portals in the Details View.
Ben Konrath [Thu, 1 Sep 2011 12:55:59 +0000 (14:55 +0200)]
Set title of Portals in the Details View.

* pom.xml: Bump required version of java-libglom to 1.17.1.
* src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
widget creation to its own class. Add comments to constructor.
* src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
The code is mostly from the Group class with the title now set.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
title of Portal. Update some comments. Fix some code formatting.

11 years agoRemove TODO comment for the flow table column width.
Ben Konrath [Thu, 1 Sep 2011 11:24:14 +0000 (13:24 +0200)]
Remove TODO comment for the flow table column width.

The flow table column width is working correctly and doesn't need to be
changed. See this mailing list post for more info:

https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html

* src/main/java/org/glom/web/client/ui/details/FlowTable.java:

11 years agoAdd document title (database name) to top of the browser page.
Ben Konrath [Sat, 27 Aug 2011 16:11:36 +0000 (18:11 +0200)]
Add document title (database name) to top of the browser page.

I added the document title to the TableSelecitonView but that will
change if / when we add a view that doesn't require table selection.

* mockups/details-contacts.html:
* mockups/details-projects.html:
* mockups/listview-contacts.html:
* mockups/listview-projects.html:
* mockups/style.css: Add document title to mockups to keep things
consistent.
* src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
sizes to account for the document title.
* src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
Set the document title when it has been retrieved from the server.
* src/main/java/org/glom/web/client/ui/TableSelectionView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
and implement setDocumentTitle(String) method.
* src/main/webapp/style.css: Add ID for document title style.

11 years agoAdd NavigationType enum to LayoutItemPortal DTO.
Ben Konrath [Thu, 25 Aug 2011 17:47:10 +0000 (19:47 +0200)]
Add NavigationType enum to LayoutItemPortal DTO.

This is the start of adding support for Portals to the Details View.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
LayoutItem_Portal.navigation_type enum from libglom to
LayoutItemPortal.NavigationType enum.
* src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
NavigationType enum, field for storing the NavigationType and getter
and setter methods.

11 years agoImplement the flow table layout in the Details View.
Ben Konrath [Thu, 25 Aug 2011 17:14:44 +0000 (19:14 +0200)]
Implement the flow table layout in the Details View.

* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
FlowTable to Group to account for the renamed class.
* src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
File. This is a container widget that implements the Glom details view
flow table behaviour.
* src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
org/glom/web/client/ui/FlowTable.java.
* src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
so that the size of the subgroups are a closer match to the size of
the Glom subgroups. This makes the flowtable layout match the layout
in Glom for the Music Collection example file.

11 years agoCreate container element for LayoutItemPortal in Details View.
Ben Konrath [Tue, 16 Aug 2011 15:24:38 +0000 (17:24 +0200)]
Create container element for LayoutItemPortal in Details View.

This will help me develop the layout for the FlowTable.

* src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
fieldPanel variable to detailsCell.

11 years agoSet the height of the data element in the Details View.
Ben Konrath [Mon, 15 Aug 2011 16:06:45 +0000 (18:06 +0200)]
Set the height of the data element in the Details View.

I changed the InlineLabels (text in a span element) to Labels (text in
a div element) so that I could set the height of the details-data
elements instead of the details-cell parent elements. This allows the
the details-data element to display the correct height if style is
applied that shows the height.

This change has the added benefit of allowing the order of the labels
and data elements to be changed for right-to-left languages.

* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
InlineLabels to Labels.
* src/main/java/org/glom/web/client/ui/FlowTable.java: Change
InlineLabels to Labels. Set the height of the data element.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
multiline text height in the Formatting DTO.
* src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
for multiline height along with getter and setter methods.
* src/main/webapp/style.css: Adjust style to account for the change
from span elements to div elements in the details cell.

11 years agoMake the List View appearance match the mockups.
Ben Konrath [Mon, 15 Aug 2011 10:56:31 +0000 (12:56 +0200)]
Make the List View appearance match the mockups.

It doesn't match exactly but it's much better than it was.

* mockups/listview-contacts.html: Remove unused css classes.
* mockups/listview-projects.html: Remove unused css classes.
* src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
for mainPanel instead of VerticalPanel (table). Set style name on
CellTable. Set style name on Details column. Right-align Details
buttons.
* src/main/webapp/style.css: Adjust properties to match the mockups.

11 years agoAdd better support for subgroups in the details view.
Ben Konrath [Fri, 12 Aug 2011 19:38:33 +0000 (21:38 +0200)]
Add better support for subgroups in the details view.

* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
changed FlowTable constructor.
* src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
support for subgroups and subgroup-titles.
* src/main/webapp/style.css: Add CSS class for subgroups and
subgroup-titles.

11 years agoReturn the top level LayoutGroup title.
Ben Konrath [Fri, 12 Aug 2011 19:26:24 +0000 (21:26 +0200)]
Return the top level LayoutGroup title.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoMake the TableSelector header match the mockup.
Ben Konrath [Thu, 11 Aug 2011 14:34:58 +0000 (16:34 +0200)]
Make the TableSelector header match the mockup.

* src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
the layout panel. Properly lineup the table selection header with
the list and details view.
* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
margin around the details view.
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
Rename listBox variable to tableSelector. Set id for the style sheet.
Use a FlowPanel instead of a HorizontalPanel.
* src/main/webapp/style.css: Add properties to make the TableSelector
box match the mockups.

11 years agoDetails: add a colon after the field title.
Murray Cumming [Wed, 27 Jul 2011 10:53:14 +0000 (12:53 +0200)]
Details: add a colon after the field title.

* src/main/java/org/glom/web/client/ui/FlowTable.java
(FlowTable.addDetailsCell):
Otherwise the title and the value seem to be part of one thing.
This matches the mockup and the desktop UI, though the desktop UI uses
a GtkEntry anyway.

11 years agoUpdate install script for java-libglom version change.
Ben Konrath [Wed, 13 Jul 2011 14:14:13 +0000 (16:14 +0200)]
Update install script for java-libglom version change.

* utils/install-onlineglom-war.sh: Also exit if 'make check' in
java-libglom fails.

11 years agoAdd support sub-group in the details view.
Ben Konrath [Wed, 13 Jul 2011 12:46:46 +0000 (14:46 +0200)]
Add support sub-group in the details view.

I also removed the code that special-cased the default details view
layout. See:

http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html

I still have to make a proper flowtable.

* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
Don't special-case default details view layout.
* src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
addLayoutField() as I'm going to use it.
* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
method.
* src/main/java/org/glom/web/client/ui/FlowTable.java: New class
extracted from DetailsViewImpl.GroupPanel. Add support for
sub-groups.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
column count when getting the details layout.

11 years agoSet browser title with database and table titles.
Ben Konrath [Tue, 12 Jul 2011 15:16:25 +0000 (17:16 +0200)]
Set browser title with database and table titles.

* src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
Set the browser title when the table changes and when the activity
first starts.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
title when retrieving document info (the GlomDocument object).
* src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
with getter and setter methods. Remove unused convenience constructor.
Use default code formatting.

11 years agoIgnore LayoutItemPortals in the details view.
Ben Konrath [Tue, 12 Jul 2011 13:46:28 +0000 (15:46 +0200)]
Ignore LayoutItemPortals in the details view.

I added a new DTO for the LayoutItemPortal so that I can ignore it in
the client code.

* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
LayoutItemPortal layout objects.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
LayoutItemPortal objects when retrieving the details layout.
* src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
file. This is an empty class and just used to get type information for
now.

11 years agoUse java-libglom 1.17.0.
Ben Konrath [Tue, 12 Jul 2011 12:37:33 +0000 (14:37 +0200)]
Use java-libglom 1.17.0.

* pom.xml:

11 years agoRemove "Table:" label from table selector.
Ben Konrath [Mon, 11 Jul 2011 14:12:17 +0000 (16:12 +0200)]
Remove "Table:" label from table selector.

This matches a recent change in the Glom UI.

* mockups/details-contacts.html:
* mockups/details-projects.html:
* mockups/listview-contacts.html:
* mockups/listview-projects.html: Remove the "Table:" label from the
mockups as well.
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:

11 years agoAdd main groups to the details view.
Ben Konrath [Mon, 11 Jul 2011 12:42:38 +0000 (14:42 +0200)]
Add main groups to the details view.

This makes things look a little nicer in the details view. The next step
is to implement the flowtable.

* src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
resources from the standard gwt css theme. Standard.css is now
included in OnlineGlom.html so that the online glom css rules have
precedence over the gwt theme.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
the whole LayoutGroup to the DetailsView instead of just the titles.
* src/main/java/org/glom/web/client/ui/DetailsView.java:
* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
details layout with a helper class (GroupPanel). I might extract this
class when I make the full flowtable.
* src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
string as default so I don't have to worry about NPEs when processing
the layout objects.
* src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
note beside OnlineGlom.gwt.xml above).
* src/main/webapp/style.css: Add default font-size to body to override
the font-size set by the standard theme. Don't use h2 tags for
group-title. Create new details-cell class.

11 years agoFix the ChangeLog
Murray Cumming [Sat, 9 Jul 2011 10:12:42 +0000 (12:12 +0200)]
Fix the ChangeLog

11 years agoConfiguredDocument: Set the port number too.
Murray Cumming [Fri, 8 Jul 2011 07:58:12 +0000 (09:58 +0200)]
ConfiguredDocument: Set the port number too.

* src/main/java/org/glom/web/server/ConfiguredDocument.java
(ConfiguredDocument.ConfiguredDocument): Get the port number from the
Glom document. Presumably this worked sometimes so far because there is a
default port number.

11 years agoConfiguredDocument: Warn that sqlite and self-hosting are not supported.
Murray Cumming [Fri, 8 Jul 2011 07:49:15 +0000 (09:49 +0200)]
ConfiguredDocument: Warn that sqlite and self-hosting are not supported.

* src/main/java/org/glom/web/server/ConfiguredDocument.java
(ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
correct, though we should throw an exception too.

11 years agoFix a addDocuemnt typo.
Murray Cumming [Fri, 8 Jul 2011 07:40:01 +0000 (09:40 +0200)]
Fix a addDocuemnt typo.

* src/main/java/org/glom/web/shared/Documents.java
(Documents.addDocuemnt): Rename to addDocument().
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
(OnlineGlomServiceImpl.getDocuments): Adapt.

11 years agoCleanup comments.
Ben Konrath [Fri, 8 Jul 2011 15:36:32 +0000 (17:36 +0200)]
Cleanup comments.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
added braces to a one line if statement because the Eclipse formatter
was getting confused.

11 years agoSlightly improved log output when connection fails.
Murray Cumming [Fri, 8 Jul 2011 07:25:47 +0000 (09:25 +0200)]
Slightly improved log output when connection fails.

* src/main/java/org/glom/web/server/ConfiguredDocument.java
(ConfiguredDocument.setUsernameAndPassword):
We don't know for sure if it' the username/password that's wrong, so
rephrase the message.
Also ouput the exception message, though it's generic in this case.

11 years agoUpdate project config files for Eclipse 3.7 and use GWT 2.3.0.
Ben Konrath [Thu, 7 Jul 2011 19:10:01 +0000 (21:10 +0200)]
Update project config files for Eclipse 3.7 and use GWT 2.3.0.

These should really be two separate tasks but I counldn't get things to
work with GWT 2.2.0 and Eclipse 3.7.

* .classpath:
* .project:
* .settings/org.eclipse.jdt.core.prefs:
* .settings/org.eclipse.jdt.ui.prefs:
* .settings/org.eclipse.ltk.core.refactoring.prefs:
* .settings/org.eclipse.m2e.core.prefs:
Add new config files. Update current files. Remove references to the
webtools plugins as we're not using any of the webtools features.
* .gitignore: Add logs directory which is created when running with
'mvn gwt:run'.
* pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
* src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
limitation:
http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations

11 years agoonlineglom.properties: Add explanatory comments.
Murray Cumming [Thu, 7 Jul 2011 08:51:26 +0000 (10:51 +0200)]
onlineglom.properties: Add explanatory comments.

* src/main/resources/onlineglom.properties: Also change the default user
from ben to someuser, to avoid the risk of people thinking we just
stupidly hard-coded a locale path, when they see that on stderr or in a log.

11 years agoUse filename in Log for incorrect passwords.
Ben Konrath [Tue, 28 Jun 2011 15:58:51 +0000 (17:58 +0200)]
Use filename in Log for incorrect passwords.

* src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
getFileName(String) method to get the filename from the URI.

11 years agoAdd the table name to the URL token for the ListPlace.
Ben Konrath [Tue, 28 Jun 2011 12:56:13 +0000 (14:56 +0200)]
Add the table name to the URL token for the ListPlace.

This makes things consistent between the DetailsPlace and the
This makes things consistent between the DetailsPlace and the
ListPlace. It also allows the the ListPlace to be bookmarked.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Remove getDefaultListLayout(). The default layout is now returned
by the getListLayout() method when the table name is an empty string.
* src/main/java/org/glom/web/client/activity/ListActivity.java:
Add table name field. Change to a new ListPlace when the table
has been changed. Use getListLayout() for getting the default
list layout.
* src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
Add table name field. Set the correct table name in the list box
when loading from bookmark. This corrects a problem for the
DetailsPlace too.
* src/main/java/org/glom/web/client/place/DetailsPlace.java:
Move table name to super-class (HasSelectableTable). Move document
and table URL keys to super-class in HasSelectableTable.
* src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
Add table name field. Add Tokenizer class with URL key common to
the subclasses (DetailsPlace and ListPlace).
* src/main/java/org/glom/web/client/place/ListPlace.java:
Add table name. Add code to parse the URL token.
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
Update ListPlace construction with empty table name string.
* src/main/java/org/glom/web/client/ui/TableSelectionView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
Change setTableSelectedIndex(int) to setSelectedTableName(String).
Update ListPlace construction with table name string.
* src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
Change defaultTableName field to tableName to reflect how it's now
used. Update the getter and setter methods.

11 years agoEnable the table selector in the DetailsView.
Ben Konrath [Tue, 28 Jun 2011 08:51:37 +0000 (10:51 +0200)]
Enable the table selector in the DetailsView.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Remove getDefaultDetailsLayout(). The default layout is now returned
by the getDetailsLayout() method when the table name is an empty
string.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
event handler for table change event. Change to using
getDetailsLayout() for the default details layout.
* src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
name to URL token.
* src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
when navigating to the details place.

11 years agoUse filename based unique document ID in URL and for RPC.
Ben Konrath [Mon, 27 Jun 2011 14:27:49 +0000 (16:27 +0200)]
Use filename based unique document ID in URL and for RPC.

The document ID is the glom document name with spaces (' ') replaced
with pluses ('+') and without the .glom extension.

This change is mostly a string substitution of 'documentTitle' for
'documentID'. The only code change is the addition of a Documents DTO to get the
filename to document title mappings as indicated below.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
* src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
Use Documents DTO to create the document links in the document
selection view.
* src/main/java/org/glom/web/client/activity/ListActivity.java:
* src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
* src/main/java/org/glom/web/client/place/DetailsPlace.java:
* src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
* src/main/java/org/glom/web/client/place/ListPlace.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
* src/main/java/org/glom/web/client/ui/ListView.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
* src/main/java/org/glom/web/client/ui/TableSelectionView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
* src/main/java/org/glom/web/server/Log.java:
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
getDocumentTitles() to getDocuments() and return the Documents DTO.
* src/main/java/org/glom/web/shared/Documents.java: New DTO for
transferring the filename to document title mappings.

11 years agoMake the authentication popup work again.
Ben Konrath [Sat, 25 Jun 2011 12:40:25 +0000 (14:40 +0200)]
Make the authentication popup work again.

This bug was introduced when I extracted ConfiguredDocument to its own class.

* src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
correct success / fail status in setUsernameAndPassword().

11 years agoUse filename as unique key for configuring database usernames and passwords.
Ben Konrath [Sat, 25 Jun 2011 12:06:27 +0000 (14:06 +0200)]
Use filename as unique key for configuring database usernames and passwords.

This replaces the use of the Glom document title which could change
depending on the locale. Thanks to Murray Cumming for pointing out this
problem.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
* src/main/resources/onlineglom.properties:

11 years agoPass primary key value to DetailsView.
Ben Konrath [Fri, 24 Jun 2011 14:35:09 +0000 (16:35 +0200)]
Pass primary key value to DetailsView.

This enables the DetailsView to load the correct data.

* src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
primary key value field and set in constructor. Pass primary key
value to getDetailsData().
* src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
variables for document title and primary key value.
* src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
key value to the DetailsPlace.

11 years agoAdd primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
Ben Konrath [Fri, 24 Jun 2011 09:31:09 +0000 (11:31 +0200)]
Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.

This allows the primary key to be retrieved by the Details button. This
functionality has not been implemented yet but it's in the works.

* src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
the LayoutGroup result to ListView.setCellTable instead of all of its
fields individually.
* src/main/java/org/glom/web/client/ui/ListView.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
get the primary key for the table.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
index of the primary key in the LayoutGroup accounting for hidden
primary keys. Rename getJavaNumberFormat() to
convertToJavaNumberFormat() for consistency. Cleanup / add some
comments.
* src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
field for primary key index and a field to indicate whether the
primary key is hidden or not.

11 years agoRename getTableData methods to getListData.
Ben Konrath [Thu, 23 Jun 2011 15:19:06 +0000 (17:19 +0200)]
Rename getTableData methods to getListData.

This is a rename refactor for consistency with other methods.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoExtract the ConfiguredDocument innerclass into its own class.
Ben Konrath [Thu, 23 Jun 2011 15:09:26 +0000 (17:09 +0200)]
Extract the ConfiguredDocument innerclass into its own class.

This makes the servlet code more object oriented.

* src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
from private ConfiguredDocument class in OnlineGlomServiceImpl.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
new ConfiguredDocument class.

11 years agoUse the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
Ben Konrath [Tue, 21 Jun 2011 13:27:58 +0000 (15:27 +0200)]
Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.

This makes things more inline with how libglom works and reduces code
duplication. This refactor lays the groundwork for adding the primary key to
the LayoutGroup object.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Change method names to getListLayout and getDefaultListLayout for
consistency. Use LayoutGroup as the DTO for the list layout instead of
ColumnInfo and LayoutListTable.
* src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
new method names along with the LayoutGroup object for transferring the
list layout.
* src/main/java/org/glom/web/client/ui/ListView.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
* src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
with LayoutGroup.
* src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
Replaced with LayoutGroup.
* src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
expectedResultSize and defaultTableName fields which are needed for
the list layout.
* src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
type field which is needed for the list layout but will also be
useful for the details layout as things progress.
* src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
Make class abstract. Remove the unnecessary
getFormattingHorizontalAlignment method. Add setFormatting method.

11 years agoAdd scripts for building and installing war.
Ben Konrath [Thu, 16 Jun 2011 18:36:14 +0000 (20:36 +0200)]
Add scripts for building and installing war.

These will help when updating OnlineGlom but they're also good
supplemental documentation of the build and deployment proceeding.

* utils/build-onlineglom-war.sh: New file.
* utils/install-onlineglom-war.sh: New file.

11 years agoCreate wrapper class to create consistent log messages.
Ben Konrath [Thu, 16 Jun 2011 16:17:42 +0000 (18:17 +0200)]
Create wrapper class to create consistent log messages.

I wrapped methods in the Log class of gwt-log to add the method names
from the servlet and create consistent formatting of the document title
and table names in the log messages.

* src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
log methods to use methods from wrapped Log class.

11 years agoRemove superfluous conditional return.
Ben Konrath [Thu, 16 Jun 2011 14:26:18 +0000 (16:26 +0200)]
Remove superfluous conditional return.

Thanks to Murray Cumming for pointing this out!

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoReturn an ArrayList of LayoutGroups for the Details layout.
Ben Konrath [Wed, 15 Jun 2011 11:55:14 +0000 (13:55 +0200)]
Return an ArrayList of LayoutGroups for the Details layout.

This corrects a problem with the details layout as it can have more
than one top level LayoutGroup.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
with ArrayList of LayoutGroups for the details view layout.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.

11 years agoUse cast_dynamic method to determine the libglom LayoutItem type.
Ben Konrath [Tue, 14 Jun 2011 18:52:32 +0000 (20:52 +0200)]
Use cast_dynamic method to determine the libglom LayoutItem type.

This is better than finding the LayoutItem type by using the string
returned from the get_part_type_name() method.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoAdd method names to log entries in the servlet.
Ben Konrath [Tue, 14 Jun 2011 18:22:02 +0000 (20:22 +0200)]
Add method names to log entries in the servlet.

This helps when tracking down deployment problems.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoAdd data to the DetailsView using a hard-coded primary key value.
Ben Konrath [Tue, 14 Jun 2011 18:21:11 +0000 (20:21 +0200)]
Add data to the DetailsView using a hard-coded primary key value.

The layout and functionality of the DetailsView is not complete. This
is just a checkpoint so the patch doesn't get too big.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
Add getDetailsData() servlet method.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
Add RPC to getDetailsData(). Change the way the LayoutGroups and
LayoutFields are added to the DetailsView.
* src/main/java/org/glom/web/client/ui/DetailsView.java:
* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
Add setData() method. Change addLayoutGroup() and addLayoutField() to
take the string for the title instead of the object.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Add implementation getDetailsData() along with some private helper
methods.
* src/main/webapp/style.css: Add padding to details-data class. Add a
details-label class with the same padding as the details-data class.

11 years agoUse presenter.goTo() to change to the DetailsPlace.
Ben Konrath [Fri, 3 Jun 2011 15:05:34 +0000 (17:05 +0200)]
Use presenter.goTo() to change to the DetailsPlace.

This will make things easier when we need to open the DetailsView with
data specific to the row that was clicked.

* src/main/java/org/glom/web/client/ui/ListViewImpl.java:

11 years agoAdd CSS file from mockups.
Ben Konrath [Thu, 2 Jun 2011 13:05:54 +0000 (15:05 +0200)]
Add CSS file from mockups.

I'm adding this now because it's going to be useful to have when
developing the DetailsView. The TableSelectionView and ListView aren't
setup properly yet.

* src/main/webapp/OnlineGlom.html:
* src/main/webapp/style.css:

11 years agoUse String.isEmpty() to check for empty string.
Ben Konrath [Thu, 2 Jun 2011 12:55:11 +0000 (14:55 +0200)]
Use String.isEmpty() to check for empty string.

* src/main/java/org/glom/web/client/activity/ListActivity.java:

11 years agoDisplay main layout group titles in the DetailsView.
Ben Konrath [Thu, 2 Jun 2011 12:47:07 +0000 (14:47 +0200)]
Display main layout group titles in the DetailsView.

This is the start of the DetailsActivity/DetailsView implementation.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
Get the layout information for the details view from the server and set
the main layout group titles.
* src/main/java/org/glom/web/client/ui/DetailsView.java:
* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
Add addLayoutGroup() and addLayoutField() methods. This are just
temporary methods for creating the the details view that will change
in the future.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
methods.
* src/main/java/org/glom/web/shared/layout/Formatting.java:
* src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
* src/main/java/org/glom/web/shared/layout/LayoutItem.java:
* src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
* src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
Data Transfer Objects that mimic the libglom object structure. These are
used for transferring the details layout but could also be used for
transferring the list layout.

11 years agoReset the AuthenticationPopup when clearing the ListView.
Ben Konrath [Fri, 27 May 2011 12:17:50 +0000 (14:17 +0200)]
Reset the AuthenticationPopup when clearing the ListView.

* src/main/java/org/glom/web/client/activity/ListActivity.java:

11 years agoFix problem with onlineglom.properties file loading.
Ben Konrath [Fri, 27 May 2011 12:09:55 +0000 (14:09 +0200)]
Fix problem with onlineglom.properties file loading.

The old way worked in Eclipse but not on the server. Loading the
onlineglom.properties file now works in Eclipse and on the server.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoUpdate gwt-log from 3.1.0 to 3.1.2.
Ben Konrath [Tue, 24 May 2011 10:24:39 +0000 (12:24 +0200)]
Update gwt-log from 3.1.0 to 3.1.2.

Gwt-log 3.1.0 has been marked as depreciated.

* pom.xml:

11 years agoAdd comment to ListActivity.goTo() method.
Ben Konrath [Tue, 24 May 2011 10:03:40 +0000 (12:03 +0200)]
Add comment to ListActivity.goTo() method.

* src/main/java/org/glom/web/client/activity/ListActivity.java:

11 years agoRemove FIXME in convertGdkColorToHtmlColour()
Ben Konrath [Tue, 24 May 2011 10:01:27 +0000 (12:01 +0200)]
Remove FIXME in convertGdkColorToHtmlColour()

The Gdk::Color value returned by libglom is 16-bits per channel on both
64 and 32-bit platforms.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoImprove performance of initial ListView load.
Ben Konrath [Thu, 19 May 2011 14:39:31 +0000 (16:39 +0200)]
Improve performance of initial ListView load.

I removed a round trip to the server for getting the default table name
and then requesting information about that table. This also removes a potential
problem with the table change handler not being setup in time to receive the
table change event from the ListActivity.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
getDefaultLayoutListTable() method. Improve comments.
* src/main/java/org/glom/web/client/activity/ListActivity.java: Use
getDefaultLayoutListTable() method instead of firing a table change
event to get the table to load.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
implementation of getDefaultLayoutListTable() method.
* src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
table name.

11 years agoOverride toDebugString() in TableChangeEvent.
Ben Konrath [Thu, 19 May 2011 13:53:35 +0000 (15:53 +0200)]
Override toDebugString() in TableChangeEvent.

This is useful to have for debugging.

* src/main/java/org/glom/web/client/event/TableChangeEvent.java:

11 years agoAdd a "Back to List" link when at the DetailsPlace.
Ben Konrath [Thu, 19 May 2011 13:49:43 +0000 (15:49 +0200)]
Add a "Back to List" link when at the DetailsPlace.

* src/main/java/org/glom/web/client/activity/ListActivity.java:
Populate the CellTable based on the selected table of the ListBox if
it's set otherwise use the default table. This allows the "Back to
List" link to work.
* src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
Remove Place from constructors. Add a setPlace() method. Add
goToPlace() method. Set class as presenter for TableSelectionView.
* src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
Use the same TableSelectionActivity when switching between the List and
Details Places.
* src/main/java/org/glom/web/client/place/DetailsPlace.java:
Subclass the new HasSelectableTablePlace. This removes some duplicate
code.
* src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
New class to represent Places that display the TableSelectionView.
* src/main/java/org/glom/web/client/place/ListPlace.java:
Subclass the new HasSelectableTablePlace. This removes some duplicate
code.
* src/main/java/org/glom/web/client/ui/TableSelectionView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
Add Presenter interface. Add setBackLinkVisible() method. Add
setBackLink() method.

11 years agoEnable the "Details" buttons.
Ben Konrath [Wed, 18 May 2011 10:45:48 +0000 (12:45 +0200)]
Enable the "Details" buttons.

Right now only an empty details view is displayed.

* src/main/java/org/glom/web/client/ClientFactory.java:
* src/main/java/org/glom/web/client/ClientFactoryImpl.java:
Add DetailsView to ClientFactory.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
A basic activity for the details view.
* src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
Add a new constructor that takes a DetailsPlace. Rename shutdown() to
clearView().
* src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
Add DetailsPlace.Tokenizer to the list of tokens that are generated by
GWT.
* src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
Create a new DetailsActivity when a DetailsPlace is requested. Remove
unnecessary super() in constructor.
* src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
Create a new TableSelectionActivity when a DetailsPlace is requested. We
really shouldn't create a new TableSelectionActivity for both the ListPlace
and the DetailsPlace so this should be considered a temporary solution.
* src/main/java/org/glom/web/client/place/DetailsPlace.java:
New file. Represents a URL for the details view.
* src/main/java/org/glom/web/client/ui/DetailsView.java:
* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
A basic details view interface and implementation.
* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
Enable the "Details" buttons.

11 years agoUse a LayoutPanel with multiple display areas for main layout.
Ben Konrath [Thu, 12 May 2011 16:06:20 +0000 (18:06 +0200)]
Use a LayoutPanel with multiple display areas for main layout.

This is mostly a refactor in that there are no changes from the user
point of view. These changes are required so that we can swap out the list view
with the details view when the user clicks the "Details" button.

* src/main/java/org/glom/web/client/ClientFactory.java:
* src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
OnlineGlomView. Add TableSelectionView, ListView and
AuthenticationPopup.
* src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
for main layout. Add display regions for main activities. Add
activity manager for for main activities.
* src/main/java/org/glom/web/client/activity/ListActivity.java: New
file from parts of the deleted OnlineGlomActivity.
* src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
New file from parts of the deleted OnlineGlomActivity.
* src/main/java/org/glom/web/client/event/TableChangeEvent.java:
* src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
New files for app wide table change event.
* src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
* src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
* src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
Activity mappers for the main activities replace the deleted app-wide
AppActivityMapper.
* src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
Fix a spelling error in he comment.
* src/main/java/org/glom/web/client/ui/ListView.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
Renamed from LayoutListView and modified for MVP. This still not a
proper dumb view as prescribed by the MVP pattern but it works for now.
* src/main/java/org/glom/web/client/ui/TableSelectionView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
New widget stripped out of the deleted OnlineGlomView.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Remove hack that is fixed by this patch.

11 years agoRename OnlineGlomPlace to ListPlace.
Ben Konrath [Fri, 6 May 2011 14:32:38 +0000 (16:32 +0200)]
Rename OnlineGlomPlace to ListPlace.

The only change besides the rename is that url will now display #list
instead of #Document.

* src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
* src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
* src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
* src/main/java/org/glom/web/client/place/ListPlace.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:

11 years agoUse Presenter for app navigation.
Ben Konrath [Fri, 6 May 2011 14:25:41 +0000 (16:25 +0200)]
Use Presenter for app navigation.

This is the proper way to deal with Place (URL) changes with the MVP
framework.

* src/main/java/org/glom/web/client/ClientFactory.java:
* src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
PlaceHistoryMapper and PlaceHistoryHandler.
* src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
PlaceHistoryMapper and PlaceHistoryHandler.
* src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
* src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
Add Presenter interface and setPresenter methods. Rename addHyperLink
to addDocumentLink taking only the document title as a parameter.

11 years agoPrompt for db username/password if they haven't been set.
Ben Konrath [Thu, 14 Apr 2011 15:44:42 +0000 (17:44 +0200)]
Prompt for db username/password if they haven't been set.

This is implemented with a popup widget that is contained within the
OnlineGlomView and managed by the OnlineGlomActivity.

* src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
methods for checking and setting the database username and password.
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
new methods for checking and setting the database username and
password.
* src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
Display authentication popup if the JDBC connection to the database
has not been authenticated.
* src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
file.
* src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
for dealing with the authentication popup.
* src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
Implement the methods for dealing with the authentication popup.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
try to executed queries if the database connection hasn't been
authenticated. Implement methods for checking and setting the
database username and password.

11 years agoMake log messages a little clearer.
Ben Konrath [Tue, 12 Apr 2011 15:32:25 +0000 (17:32 +0200)]
Make log messages a little clearer.

Add a dash betweeen the document title and the table name.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoProtect against NPEs when cleaning up database resources.
Ben Konrath [Tue, 12 Apr 2011 15:27:22 +0000 (17:27 +0200)]
Protect against NPEs when cleaning up database resources.

While this isn't strictly necessary because the exception is caught,
not protecting against the NPEs makes it harder to find the real error
in the log file.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoMove configuration of the servlet to the constructor.
Ben Konrath [Tue, 12 Apr 2011 12:55:54 +0000 (14:55 +0200)]
Move configuration of the servlet to the constructor.

The servlet will be initialized even if the database authentication
information is not set or correct. I still need to add the UI for prompting
the user for the authentication information when it's required.

* src/main/java/org/glom/web/client/OnlineGlomService.java: Add
javadocs for getDocumentTitles() method.
* src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
Set error message when RPC fails.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
glom files directory from the configuration file. Try to set the
database authentication information for the specific document if it's
set and works otherwise try to use the global authentication
information set for the directory.
* src/main/resources/onlineglom.properties: Moved from
src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
Added detailed comments for the new keys.

11 years agoRemove unnecessary @Override in DocumentSelectionViewImpl.
Ben Konrath [Mon, 11 Apr 2011 12:27:46 +0000 (14:27 +0200)]
Remove unnecessary @Override in DocumentSelectionViewImpl.

* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:

11 years agoRemove center alignment in DocumentSelectionView.
Ben Konrath [Mon, 11 Apr 2011 12:25:04 +0000 (14:25 +0200)]
Remove center alignment in DocumentSelectionView.

The title element is still centred but the document titles and bottom
sentence are both left-aligned.

* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:

11 years agoChange 'Demo' naming convention to 'Document'.
Ben Konrath [Mon, 11 Apr 2011 09:04:00 +0000 (11:04 +0200)]
Change 'Demo' naming convention to 'Document'.

This is just a rename refactor with no functional changes to the code.

* src/main/java/org/glom/web/client/ClientFactory.java:
* src/main/java/org/glom/web/client/ClientFactoryImpl.java:
* src/main/java/org/glom/web/client/OnlineGlom.java:
* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
* src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
* src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
* src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
* src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoRemove FIXME from safeLongToInt() method.
Ben Konrath [Fri, 8 Apr 2011 12:46:20 +0000 (14:46 +0200)]
Remove FIXME from safeLongToInt() method.

Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
this method.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoDisplay an error if no glom documents are found in the specified directory.
Ben Konrath [Fri, 8 Apr 2011 12:22:34 +0000 (14:22 +0200)]
Display an error if no glom documents are found in the specified directory.

* src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
* src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
* src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoAdd copyright header to one more file ... oops.
Ben Konrath [Fri, 8 Apr 2011 12:19:03 +0000 (14:19 +0200)]
Add copyright header to one more file ... oops.

* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:

11 years agoAdd copyright header to files without it.
Ben Konrath [Fri, 8 Apr 2011 10:53:06 +0000 (12:53 +0200)]
Add copyright header to files without it.

* src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
* src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
* src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
* src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
* src/main/java/org/glom/web/shared/ColumnInfo.java:
* src/main/java/org/glom/web/shared/GlomField.java:

11 years agoAdd support for accessing multiple glom documents in the servlet.
Ben Konrath [Fri, 8 Apr 2011 10:41:52 +0000 (12:41 +0200)]
Add support for accessing multiple glom documents in the servlet.

This completes the demo selection functionality.

* src/main/java/org/glom/web/client/OnlineGlomService.java: Add
document title to methods.
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
document title to methods.
* src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
Set browser window title when the activity starts. Correct name of
document title variable.
* src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
Set browser window title when the activity starts. Set the table
selector change handler after table selector has been set. Clear the
OnlineGlomView when the activity has been stopped.
* src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
document title as the place token. Use "#Document:" instead of
"#OnlineGlomPlace:" in the URL.
* src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
Change heading to "Online Glom"
* src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
document title in RPC methods.
* src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
setDocumentTitle() method. Add clear() method.
* src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
setDocumentTitle() method. Implement clear() method which removes the
change handler on the ListBox, clears the ListBox and clears the
DataPanel.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Implement methods with document title. Keep track for the configured
glom documents and their corresponding JDBC configurations in a hash
table. This information is retrieved using the document title as the
key in the hash table.
* src/main/java/org/glom/web/shared/GlomDocument.java: Remove
document title field as it's no longer needed.

11 years agoUpdate the Eclipse JDT configuration.
Ben Konrath [Fri, 8 Apr 2011 09:37:26 +0000 (11:37 +0200)]
Update the Eclipse JDT configuration.

* .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
methods. Automatically add the copyright header to new files.

11 years agoAdd new page for demo selection.
Ben Konrath [Tue, 5 Apr 2011 15:02:19 +0000 (17:02 +0200)]
Add new page for demo selection.

This patch adds all the components required to view and start an
OnlineGlom demo by clicking on the desired hyperlink. The user is
able to return to the demo selection page with the browser's back
button. I still need to modify the servlet to work with multiple
documents so all demo links will load the file defined in the
OnlineGlom.properties.

* .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
This is only useful during development so we don't need to save it.
* src/main/java/org/glom/web/client/ClientFactory.java: Add method to
get a reference to the DemoSelectionView.
* src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
method to get a reference to the DemoSelectionView.
* src/main/java/org/glom/web/client/OnlineGlom.java: Change the
default view to DemoSelectionView.
* src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
to get glom document titles for glom files in a hard-coded directory.
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
method to get glom document titles for glom files in a hard-coded
directory.
* src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
Presenter for DemoSelectionView.
* src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
for DemoSelectionView.
* src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
Update for DemoSelectionView.
* src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
Basic 'Place' implementation for the DemoSelectionView.
* src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
The interface for the DemoSelectionView.
* src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
The implementation of the DemoSelectionView.
* src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
The GWT UiBuilder xml file used in DemoSelectionViewImpl.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
implementation of method to get glom document titles for glom files
in a hard-coded directory.
* src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
on longer being used.
* src/main/webapp/glom.png: Glom logo.

11 years agoMove RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
Ben Konrath [Tue, 5 Apr 2011 11:01:23 +0000 (13:01 +0200)]
Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.

This is the forth and final commit of a refactor that will allow
OnlineGlom to be used with multiple documents.

* src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
Move RPC code from OnlineGlomViewImpl to this class.
* src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
to inferface.
* src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
RPC code to the presenter class (the P in MVP).

11 years agoStart moving the existing OnlineGlom code to MVP.
Ben Konrath [Mon, 4 Apr 2011 12:15:44 +0000 (14:15 +0200)]
Start moving the existing OnlineGlom code to MVP.

This work is based on the GWT MVP framework that is documented here:

https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html

This is the third commit of a refactor that will allow OnlineGlom to
be used with multiple documents.

* src/main/java/org/glom/web/client/ClientFactory.java: New file.
Interface for client factory which is used to get instances of various
classes throughout the app.
* src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
Implementation of client factory.
* src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
initialize the MVP framework.
* src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
New file. Activity manager for the main container widget. This is the
Presenter in MVP.
* src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
Maps place (URL) to its corresponding activity.
* src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
New file. This is just a place holder for a generated file.
* src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
New file. Represents the URL for the main Online Glom app.
* src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
for changes in LayoutListViewImpl.
* src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
interface for View. Move code to OnlineGlomViewImpl class.
* src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
file. Implementation of OnlineGlomView.
* src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
Place resources. Use ClientFactoryImpl by default.

11 years agoMove View classes to their own package.
Ben Konrath [Mon, 4 Apr 2011 06:25:53 +0000 (08:25 +0200)]
Move View classes to their own package.

This is the second commit of a refactor that will allow OnlineGlom to
be used with multiple documents.

11 years agoMove UI code from the main module to its own class.
Ben Konrath [Sat, 2 Apr 2011 10:15:33 +0000 (12:15 +0200)]
Move UI code from the main module to its own class.

This is the first commit of a refactor that will allow OnlineGlom to be
used with multiple documents.

* src/main/java/org/glom/web/client/LayoutListView.java: Update
references to OnlineGlom to OnlineGlomView.
* src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
OnlineGlomView and instantiate it here.
* src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
represents the main OnlineGlomView with one document.

11 years agoFix formatting of gwt.xml and add DTD.
Ben Konrath [Fri, 1 Apr 2011 11:59:08 +0000 (13:59 +0200)]
Fix formatting of gwt.xml and add DTD.

* src/main/resources/org/glom/web/OnlineGlom.gwt.xml:

11 years agoPropperly convert gdkColor string to html colour string.
Ben Konrath [Wed, 30 Mar 2011 12:17:03 +0000 (14:17 +0200)]
Propperly convert gdkColor string to html colour string.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoChange implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
Ben Konrath [Mon, 28 Mar 2011 15:50:26 +0000 (17:50 +0200)]
Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().

This implementation matches
OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
readable and is not tied to Swig.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoUse read-only checkboxes for boolean field types.
Ben Konrath [Mon, 28 Mar 2011 15:43:19 +0000 (17:43 +0200)]
Use read-only checkboxes for boolean field types.

* src/main/java/org/glom/web/client/LayoutListView.java: Create columns
in the CellTable based on the field type. It currently only
distinguishes between boolean and text columns but I'll need to add
support for more types.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
column type in the ColumnInfo object. Add method to convert between the
glom field type enum in ColumnInfo and the glom field type in libglom.
* src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
field type.
* src/main/java/org/glom/web/shared/GlomField.java: Add support for
getting and setting booleans.

11 years agoDon't get the Date twice from the ResultSet.
Ben Konrath [Fri, 25 Mar 2011 15:32:17 +0000 (16:32 +0100)]
Don't get the Date twice from the ResultSet.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoCleanup code in the servlet.
Ben Konrath [Fri, 25 Mar 2011 14:15:38 +0000 (15:15 +0100)]
Cleanup code in the servlet.

* TODO: Remove item about row count. Add item about testing row count
query with large number of rows.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
spelling mistakes, change method parameter to be consistent with
other methods.

11 years agoAdd server side logging with the gwt-log library.
Ben Konrath [Fri, 25 Mar 2011 14:04:54 +0000 (15:04 +0100)]
Add server side logging with the gwt-log library.

* .gitignore: Ignore the log file we're now producing.
* TODO: Add a couple TODO item for logging.
* pom.xml: Add gwt-log and log4j as a dependency.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
logging of errors, warnings and some important info.
* src/main/resources/log4j.properties: New file to configure log4j.

11 years agoAdd a disable button for the Details view.
Ben Konrath [Thu, 24 Mar 2011 09:52:36 +0000 (10:52 +0100)]
Add a disable button for the Details view.

* src/main/java/org/glom/web/client/LayoutListView.java:

11 years agoUse a count query to get the number of rows for the list view pager.
Ben Konrath [Tue, 22 Mar 2011 13:17:19 +0000 (14:17 +0100)]
Use a count query to get the number of rows for the list view pager.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

11 years agoAdd more TODO information about CellTable pager positioning.
Ben Konrath [Tue, 22 Mar 2011 10:30:45 +0000 (11:30 +0100)]
Add more TODO information about CellTable pager positioning.

* TODO:

11 years agoAdd TODO item about CellTable pager positioning.
Ben Konrath [Sat, 19 Mar 2011 12:17:53 +0000 (13:17 +0100)]
Add TODO item about CellTable pager positioning.

* TODO:

11 years agoRemove unneeded GlomFieldColumn class.
Ben Konrath [Fri, 18 Mar 2011 13:39:50 +0000 (14:39 +0100)]
Remove unneeded GlomFieldColumn class.

This is just a small code cleanup.

* src/main/java/org/glom/web/client/LayoutListView.java:

11 years agoUse cursor mode in the query that gets data for the list view.
Ben Konrath [Fri, 18 Mar 2011 09:55:27 +0000 (10:55 +0100)]
Use cursor mode in the query that gets data for the list view.

I still need to fix the potential memory problem when getting the row
count for the list view.

* TODO: Add note about testing memory usage with large data sets. Add
item about fixing row counting with large data sets.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
PostgreSQL JDBC driver into cursor mode when getting data for the
list view.

11 years agoRemove the GWT Container from the Eclipse build classpath.
Ben Konrath [Tue, 15 Mar 2011 14:02:09 +0000 (15:02 +0100)]
Remove the GWT Container from the Eclipse build classpath.

The GWT dependencies are set by Maven so this isn't needed.

* .classpath:

11 years agoAdded some earlier mockups to git, but not to the tarball dist.
Murray Cumming [Tue, 15 Mar 2011 09:25:59 +0000 (10:25 +0100)]
Added some earlier mockups to git, but not to the tarball dist.

* mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
Openismus. These hopefully show how we might structure the HTML so that
it can be styled easily with CSS. However, we probably need to adapt them
for the CSS structure that GWT dictates for common widgets.