online-glom:gwt-glom.git
10 years agoOnlineGlomServiceImpl: Get .glom files recursively.
Murray Cumming [Thu, 19 Jan 2012 21:24:12 +0000 (22:24 +0100)]
OnlineGlomServiceImpl: Get .glom files recursively.

* pom.xml: Depend on commons-io from org.apache.commons.
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
files recursively, and with the easier filter for the extension.
Use org.apache.commons.io.FilenameUtils.removeExtension() to
simplify that code too.

10 years agoFix a typo
Murray Cumming [Thu, 19 Jan 2012 20:32:52 +0000 (21:32 +0100)]
Fix a typo

10 years agoREADME: Mention that you must install java-libglom packages separately.
Murray Cumming [Thu, 19 Jan 2012 09:04:52 +0000 (10:04 +0100)]
README: Mention that you must install java-libglom packages separately.

But then it works, because java-libglom is now in the central maven
repository.

10 years agolocales drop-down: Show the correct selected locale when the URL changes.
Murray Cumming [Wed, 18 Jan 2012 22:05:26 +0000 (23:05 +0100)]
locales drop-down: Show the correct selected locale when the URL changes.

* src/main/java/org/glom/web/client/activity/TableSelectionActivity
.java: setPlace(): Move some code into fillView().

10 years agolocales drop-down: Do not lose the primary key.
Murray Cumming [Wed, 18 Jan 2012 21:49:46 +0000 (22:49 +0100)]
locales drop-down: Do not lose the primary key.

* src/main/java/org/glom/web/client/activity/DetailsActivity.java
start(): onLocaleChange(): Pass the current primary key value,
instead of an empty value.

10 years agolocales drop-down: Do not lose the drop-down selection.
Murray Cumming [Wed, 18 Jan 2012 21:48:39 +0000 (22:48 +0100)]
locales drop-down: Do not lose the drop-down selection.

* src/main/java/org/glom/web/client/activity/TableSelectionActivity
.java (TableSelectionActivity.fillView): Set the selected locale
after changing the drop-down items (though we do not really need
to change them just because the locale changes.)

10 years agolocales drop-down: Change the tables list when this changes.
Murray Cumming [Wed, 18 Jan 2012 21:38:32 +0000 (22:38 +0100)]
locales drop-down: Change the tables list when this changes.

* src/main/java/org/glom/web/client/activity/TableSelectionActivity
.java: TableSelectionActivity.start(): Move the async table titles
retrieval into a private fillView() method and also call this when
the chosen locale changes.
Note that the document title is not actually translatable yet, but
that is a problem that I should fix soon in libglom.

10 years agoImprove the placement of the locales drop-down.
Murray Cumming [Wed, 18 Jan 2012 10:37:40 +0000 (11:37 +0100)]
Improve the placement of the locales drop-down.

* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
Put the title and locales drop-down in a div (gwt.FlowTable).
* src/main/webapp/style.css: Add magic css properties to make this work.
Also remove the left margin from the title so that it lines up with the
headerbox below it.

10 years agolocales selector: Show human-readable locale titles.
Murray Cumming [Tue, 17 Jan 2012 23:13:33 +0000 (00:13 +0100)]
locales selector: Show human-readable locale titles.

* src/main/java/org/glom/web/server/ConfiguredDocument.java
getDocumentInfo(): Use java.util.Locale to show a real title of
each locale, in the locale's own language.

10 years agoAdd a language/locale selector drop-down.
Murray Cumming [Tue, 17 Jan 2012 22:50:35 +0000 (23:50 +0100)]
Add a language/locale selector drop-down.

* src/main/java/org/glom/web/shared/DocumentInfo.java:
Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
* /src/main/java/org/glom/web/server/ConfiguredDocument.java:
getDocumentInfo(): Store the available Locales in the DocumentInfo.
* src/main/java/org/glom/web/client/ui/TableSelectionView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
Add a ListBox to show the available locales. Add getLocaleSelector(),
setLocaleList(), getSelectedLocale(), setSelectedLocale().
* src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
* src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
java: Add these classes.
* src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
start(): Fill the locales ListBox. Handle its change event, firing a
LocaleChangeEvent.
setPlace(): Show the selected locale as specified by the URL token.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
* src/main/java/org/glom/web/client/activity/ListActivity.java:
Handle LocaleChangeEvent, going to a new *Place with that locale.

The placement of the ListBox is not pretty, and it currently uses the ID
as a title, instead of "English", "Deutsch", "Espanola", etc, but it
is a start.

10 years agoFix a typo.
Murray Cumming [Tue, 17 Jan 2012 22:27:04 +0000 (23:27 +0100)]
Fix a typo.

10 years agoSearch box: Show the search text from the URL token.
Murray Cumming [Tue, 17 Jan 2012 21:42:24 +0000 (22:42 +0100)]
Search box: Show the search text from the URL token.

* src/main/java/org/glom/web/client/ui/TableSelectionView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
Add setQuickFindText().
* src/main/java/org/glom/web/client/activity/TableSelectionActivity
.java: setPlace(): Store the queryText if the place is a ListPlace,
and call TableSelectionView.setQuickFindText().

10 years agoAllow use of translations via, for instance, &lang=de in the URL.
Murray Cumming [Mon, 16 Jan 2012 22:33:06 +0000 (23:33 +0100)]
Allow use of translations via, for instance, &lang=de in the URL.

* pom.xml: Use the unstable java-libglom 1.21 version.

* src/main/java/org/glom/web/client/OnlineGlomService.java:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
init(): Instead of calling TranslatableItem.set_current_locale()
(now removed), call ConfiguredDocument.setDefaultLocaleID().
However, this is only for default locales, which are not needed to
change the locale in the URL.
getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
getSortedRelatedListData(): Add a localeID parameter, so we can get the
layout for a particular locale.
* src/main/java/org/glom/web/server/ConfiguredDocument.java:
Add get/setDefaultLocaleID().
getDocumentInfo(), getListViewData(), getRelatedListData(),
getDetailsLayoutGroup(), getListViewLayoutGroup(),
createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
localeID parameter, so we can get the layout for a particular locale.

* src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
* src/main/java/org/glom/web/client/place/DetailsPlace.java:
* src/main/java/org/glom/web/client/place/ListPlace.java:
Parse and construct a lang parameter too.

* src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
start(): Pass the defaultLocaleID to addDocumentLink(). It is then
passed to subsequent methods and constructors.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
* src/main/java/org/glom/web/client/activity/ListActivity.java:
Store the localeID from the *Place and pass it to other constructors
and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().

* src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
* src/main/java/org/glom/web/client/ui/TableSelectionView.java
* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
* src/main/java/org/glom/web/client/ui/ListView.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
Take localeID parameters and pass them to subsequent constructors and
methods, so that the layout is always retrieved for that locale.

This is rather repetitive.

Note that "" means the original (default) locale of the Glom document,
which is usually English.

10 years agoDocuments: Remove final keyword to fix startup configuration. libglom-1-20
Murray Cumming [Tue, 17 Jan 2012 09:39:18 +0000 (10:39 +0100)]
Documents: Remove final keyword to fix startup configuration.

* src/main/java/org/glom/web/shared/Documents.java: Remove the
final keywords on the private member variables because that breaks
the startup, apparently (there are warnings) because it stops them
from being serialized. I added these in the previous commit.

10 years agoDocuments: Add some final keywords.
Murray Cumming [Fri, 13 Jan 2012 17:23:44 +0000 (18:23 +0100)]
Documents: Add some final keywords.

* src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
this.

10 years agoOnlineGlomServiceImpl: Add to overview comments.
Murray Cumming [Fri, 13 Jan 2012 17:20:43 +0000 (18:20 +0100)]
OnlineGlomServiceImpl: Add to overview comments.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
Note that this is where all the document are loaded. They are not
loaded freshly for each page.

10 years agoAdd a search box.
Murray Cumming [Thu, 12 Jan 2012 23:12:35 +0000 (00:12 +0100)]
Add a search box.

* src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
Add a TextBox for the text of a quick find.
Add getQuickFindBox(), to get the widget, and getQuickFindText() to
get the text.
setBackLink(): Add a String quickFind parameter.
* src/main/java/org/glom/web/client/ui/TableSelectionView.java
(TableSelectionView): Add getQuickFindBox() and getQuickFindText()
to the base interface, because that is how TableSelectionViewImpl is used.
* src/main/webapp/style.css: Add style for the search box and its label.

* src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
* src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
Add these files, based on the existing TableChangeEvent and
TableChangeEventHandlers.
* src/main/java/org/glom/web/client/activity/DetailsActivity.java
start(): Handle QuickFindChangeEvent, passing its quickFind text to
a ListPlace() that the user should be taken to.
* src/main/java/org/glom/web/client/activity/ListActivity.java
start(): Handle it here too and adapt the TableChangeEvent handler to
pass the extra  quickFind parameter to ListPlace.
* src/main/java/org/glom/web/client/place/ListPlace.java:
Constructor: Take an extra String quickFind parameter and store it,
returning it from a new  getQuickFind() method.
getToken(): Put the quickFind text in the URL token.
getPlace(): Parse the quickFind text from the URL token.
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
va: addDocumentLink(): Pass an extra  quickFind parameter to the
ListPlace constructor.
* src/main/java/org/glom/web/client/activity/TableSelectionActivity
.java: start(): Add a Change handler for the TableSelectionView's
TextBox (via its base HasChangeHandlers interface), firing the new
QuickFindChangeEvent.
setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
pass the extra  quickFind parameter.

* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
setCellTable(): Add a String quickFind parameter and pass it to
the ListViewTable() constructor.
* src/main/java/org/glom/web/client/ui/ListView.java: Change
setCellTable() in the base interface, because that is how ListViewImpl
is used.

* src/main/java/org/glom/web/client/ui/list/ListTable.java:
Add a String quickFind member variable.
* src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
Constructor: Add a String quickFind parameter, storing it in the
base ListTable's member variable.
onRangeChanged(): Pass quickFind to the
OnlineGlomServiceAsync.getSortedListViewData() and
OnlineGlomServiceAsync.getListViewData() methods.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
getListViewData(), getSortedListViewData(): Add a String quickFind
parameter, passing it to ConfiguredDocument.getListViewData().
* src/main/java/org/glom/web/client/OnlineGlomService.java:
Change getListViewData(), getSortedListViewData() in the base interface,
because that is how OnlineGlomServiceImpl is used, via this:
* src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
Change getListViewData(), getSortedListViewData() here too.
This class can apparently be used to asynchronously call methods on
OnlineGlomService, and GWT seems to implement that after recognizing
just the *Async name convention and the extra AsyncCallback parameters.

* src/main/java/org/glom/web/server/ConfiguredDocument.java
getListViewData(): Add a String quickFind parameter, and pass it to
ListViewDBAccess.getData().
* src/main/java/org/glom/web/server/database/ListDBAccess.java
getListData(): Add a String quickFind parameter and pass it to
getSelectQuery().
getSelectQuery(): Add a String quickFind parameter.
* src/main/java/org/glom/web/server/database/ListViewDBAccess.java
getSelectQuery(): Add a String quickFind parameter and use it with
Glom.get_find_where_clause_quick() to pass a where_clause to
Glom.build_sql_select_with_where_clause(), to actually filter the
list view results.
getData(): Add a String quickFind parameter, passing it to getListData().
* src/main/java/org/glom/web/server/database/Rela
va: getData(): Pass an empty string to getL
quickFind parameter.

10 years agoListTable: Minor change.
Murray Cumming [Thu, 12 Jan 2012 13:31:04 +0000 (14:31 +0100)]
ListTable: Minor change.

* src/main/java/org/glom/web/client/ui/list/ListTable.java
createCellTable(): Make this protected instead of public.

10 years agoSeveral files: Use final for the parameters and use the @override attribute.
Murray Cumming [Thu, 12 Jan 2012 09:33:10 +0000 (10:33 +0100)]
Several files: Use final for the parameters and use the @override attribute.

10 years agoMinor documentation/comment changes
Murray Cumming [Thu, 12 Jan 2012 09:24:03 +0000 (10:24 +0100)]
Minor documentation/comment changes

10 years agoCorrect the ChangeLog
Murray Cumming [Wed, 11 Jan 2012 21:12:32 +0000 (22:12 +0100)]
Correct the ChangeLog

10 years agoAdd anchor links for single line text that starts with http, ftp and www.
Ben Konrath [Sun, 25 Dec 2011 01:29:50 +0000 (02:29 +0100)]
Add anchor links for single line text that starts with http, ftp and 

10 years agoAdd ellipsis to single line text in details view.
Ben Konrath [Sun, 25 Dec 2011 00:00:33 +0000 (01:00 +0100)]
Add ellipsis to single line text in details view.

10 years agoUpdate a copyright year.
Murray Cumming [Wed, 4 Jan 2012 20:08:48 +0000 (21:08 +0100)]
Update a copyright year.

10 years agoRemove all javadoc author tags.
Murray Cumming [Wed, 4 Jan 2012 20:08:05 +0000 (21:08 +0100)]
Remove all javadoc author tags.

Because they are awkward and meaningless when many people touch
many files.
See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164

10 years agoCorrect the ChangeLog
Murray Cumming [Wed, 4 Jan 2012 19:59:49 +0000 (20:59 +0100)]
Correct the ChangeLog

10 years agoRevert the COPYING.LESSER to COPYING rename.
Murray Cumming [Wed, 4 Jan 2012 19:54:41 +0000 (20:54 +0100)]
Revert the COPYING.LESSER to COPYING rename.

Apparently both should be there if it is LGPL.

This partially reverts commit ed70963225640fd794cdb3e1a01043060ad3aff7.

10 years ago*View: Remove unused imports.
Murray Cumming [Tue, 3 Jan 2012 12:51:38 +0000 (13:51 +0100)]
*View: Remove unused imports.

* src/main/java/org/glom/web/client/ui/DetailsView.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
* src/main/java/org/glom/web/client/ui/ListView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionView.java:
Remove unused imports, as suggested by Eclipse.

10 years agoMove the *View::Presenter types, and some API into one base View.
Murray Cumming [Mon, 2 Jan 2012 20:40:11 +0000 (21:40 +0100)]
Move the *View::Presenter types, and some API into one base View.

* src/main/java/org/glom/web/client/ui/DetailsView.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
* src/main/java/org/glom/web/client/ui/ListView.java:
* src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
Presenter, setPresenter() and clear() into a shared base interface,
to avoid the unnecessary duplicate Presenter types and to more clearly
show how the *Views share the same structure, even if they are not
used polymorphically.

* src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
va:
* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
* src/main/java/org/glom/web/client/activity/ListActivity.java:
* src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
ity.java:
* src/main/java/org/glom/web/client/activity/TableSelectionActivity
.java: Adapt.

Feel free to revert this if there is a good reason for the duplicate
types.

10 years agoOnlineGlom: Make clientFactory a (protected) member, and test it a bit.
Murray Cumming [Mon, 2 Jan 2012 19:59:19 +0000 (20:59 +0100)]
OnlineGlom: Make clientFactory a (protected) member, and test it a bit.

* src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
a class member instead of a local variable in the method.
This lets us use it to get the view instances, for use in tests.
* src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
beforeOnlineGlom(): Test some more details of the initial view.
Again, this is not very useful.

To really test gwt-glom we will need to start a local postgresql
instance with local data, like the Glom tests in C++.

10 years agopom.xml: Mention the LGPL license.
Murray Cumming [Mon, 2 Jan 2012 13:48:44 +0000 (14:48 +0100)]
pom.xml: Mention the LGPL license.

* pom.xml: Add a licenses section.
* COPYING.LESSER: Move this to COPYING, which
previously contained the GPL. But gwt-glom is all LGPL.

10 years agoAdd project information to README and pom.xml.
Murray Cumming [Mon, 2 Jan 2012 13:40:04 +0000 (14:40 +0100)]
Add project information to README and pom.xml.

* README: Add a brief description and mention some mvn
commands.
* pom.xml: This extra information shows up in mvn site
generated pages.

10 years agoUse the latest java-libglom version.
Murray Cumming [Thu, 22 Dec 2011 12:06:08 +0000 (13:06 +0100)]
Use the latest java-libglom version.

* pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.

10 years agoGwtTestOnlineGlom: Test a little more.
Murray Cumming [Sun, 1 Jan 2012 22:49:26 +0000 (23:49 +0100)]
GwtTestOnlineGlom: Test a little more.

* src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
protected rather than private, as suggested by the gwt-test-utils
maintianer here:
http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
* src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
Test the initial visibility of the panels.

However, this is not a very useful test.
And I wonder how we should generally test using this idea for an
activity/places app like ours where the real changes happen implicitly
based on the history token/URL.

10 years agoSlight modification to *Mapper comments.
Murray Cumming [Sun, 1 Jan 2012 21:14:28 +0000 (22:14 +0100)]
Slight modification to *Mapper comments.

* src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
(DataActivityMapper)
* src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
pper.java
* src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
r.java
Remove comments mentioning GIN because they are just copied from
the example code and are apparently not helpful:
http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
Also change the mention of a class that is only in the example code.

10 years agoAdd comments with my understanding of the ClientFactory
Murray Cumming [Sun, 1 Jan 2012 21:02:23 +0000 (22:02 +0100)]
Add comments with my understanding of the ClientFactory

10 years agoGwtTestOnlineGlom test: Minor changes.
Murray Cumming [Sun, 1 Jan 2012 20:44:45 +0000 (21:44 +0100)]
GwtTestOnlineGlom test: Minor changes.

* src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
Avoid the long qualified class name and modify the comment
because it is now obvious to me that the mocked class is the only
custom one created via GWT.create().

10 years agoImprove the ChangeLog
Murray Cumming [Sun, 1 Jan 2012 00:58:56 +0000 (01:58 +0100)]
Improve the ChangeLog

10 years agoTests: Added the beginnings of a test using gwt-test-utils.
Murray Cumming [Sun, 1 Jan 2012 00:58:26 +0000 (01:58 +0100)]
Tests: Added the beginnings of a test using gwt-test-utils.

* pom.xml: Add dependencies on gwt-test-utils and easymock.
* src/test/resources/META-INF/gwt-test-utils.properties: Add this file
which tells gwt-test-utils what class will be tested.
* src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
Add a simple (but empty) test case. One class, used by the OnlineGlom
class, is mocked so that it can be created. However, I am not sure
why only this class needs to be mocked.

Note that mockito seems more popular, and clearer, than easymock,
but I have not got that working yet. It might be a matter of the
mockito version.

10 years agoTests: Use junit4-style syntax instead of junit3-style.
Murray Cumming [Sat, 31 Dec 2011 22:13:23 +0000 (23:13 +0100)]
Tests: Use junit4-style syntax instead of junit3-style.

* src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
* src/test/java/org/glom/web/client/place/ListPlaceTest.java:
* src/test/java/org/glom/web/shared/DataItemTest.java:
Use the @Test annotation rather than relying on the test*() prefix.
Also no longer implement TestCase, to avoid triggering support for
the junit3-way, which stops the annotations from working.
Change the imports from import junit.framework.* to
import org.junit.*, which is apparently the new way.

10 years agoAdded a test for ListPlace token parsing and creation.
Murray Cumming [Sat, 31 Dec 2011 20:28:49 +0000 (21:28 +0100)]
Added a test for ListPlace token parsing and creation.

* src/test/java/org/glom/web/client/place/ListPlaceTest.java:
This is much the same as DetailsPlaceTest.

I wonder how we could test the other parts of the *Place API

10 years agowhitespace cleanup
Murray Cumming [Fri, 30 Dec 2011 22:34:26 +0000 (23:34 +0100)]
whitespace cleanup

10 years agoDetailsPlace test: Also test getToken() and recreation via getPlace().
Murray Cumming [Fri, 30 Dec 2011 22:27:09 +0000 (23:27 +0100)]
DetailsPlace test: Also test getToken() and recreation via getPlace().

* src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
testGetPlaceParameters(): Get the tokens from the DetailsPlace and
recreate it, testing the recreated DetailsPlace for the same parameter
values.

10 years agoUse the surefire-report plugin.
Murray Cumming [Fri, 30 Dec 2011 22:13:50 +0000 (23:13 +0100)]
Use the surefire-report plugin.

* pom.xml: This generates a HTML report about the tests in
target/site/surefire-report.html
when you do mvn surefire-report:report. It seems to be popular/normal.

10 years agoAdded a test for DetailsPlace.
Murray Cumming [Fri, 30 Dec 2011 22:12:14 +0000 (23:12 +0100)]
Added a test for DetailsPlace.

* src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
Test the getPlace() token parsing.

10 years agoAdded a first unit test.
Murray Cumming [Fri, 30 Dec 2011 14:01:07 +0000 (15:01 +0100)]
Added a first unit test.

* pom.xml: Add a test goal, and a dependency on junit in that scope.
* src/test/java/org/glom/web/shared/DataItemTest.java:
This is a silly test but it is just to get things started. Note that
maven/junit finds the test because it looks in src/test by default.

10 years agoUpdate a URL in a comment
Murray Cumming [Fri, 30 Dec 2011 13:26:03 +0000 (14:26 +0100)]
Update a URL in a comment

10 years agoUpdate a URL in a comment
Murray Cumming [Fri, 30 Dec 2011 13:25:54 +0000 (14:25 +0100)]
Update a URL in a comment

10 years agoChange charsetName to "UTF-8" when replacing line breaks.
Ben Konrath [Thu, 22 Dec 2011 22:37:34 +0000 (23:37 +0100)]
Change charsetName to "UTF-8" when replacing line breaks.

JavaScript requires the charsetName to be "UTF-8". CharsetName values
that work in Java (such as "UTF8") will not work when compiled to
JavaScript.

This fixes a problem with multi-line details view fields that have hard
line breaks. The "License Text" field on this page demonstrates the
problem:

http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197

* src/main/java/org/glom/web/client/ui/details/DetailsCell.java:

10 years agoFix another bug with related list navigation.
Ben Konrath [Thu, 22 Dec 2011 22:20:27 +0000 (23:20 +0100)]
Fix another bug with related list navigation.

I've tested all the navigation buttons in all of the related lists
so things should be good now.

* src/main/java/org/glom/web/server/ConfiguredDocument.java:

10 years agoFix a crasher when refreshing the list view with the default table.
Ben Konrath [Thu, 22 Dec 2011 14:05:04 +0000 (15:05 +0100)]
Fix a crasher when refreshing the list view with the default table.

This crash will also happen when loading the list view with the default
table from a link or bookmark.

* src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
to the main document selection page when the document id hasn't been
set.
* src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
the main document selection page when the document id hasn't been
set.
* src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
values for the details place when the document id hasn't been set.
* src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
values for the list place when the document id hasn't been set.

10 years agoProtect against NPE when glom.document.locale is not in config.
Ben Konrath [Wed, 21 Dec 2011 17:23:07 +0000 (18:23 +0100)]
Protect against NPE when glom.document.locale is not in config.

This patch protects against an NPE when glom.document.locale is not in
the config file. This NPE will also happen if glom.document.locale is
commented out.

The patch also updates the error message to display the class name when
the getMessage() returns null. This was happening when the NPE was
thrown and I had "Configuration Error: null". If an NPE is encountered
with this patch, "Configuration Error: NullPointerException " will be
displayed.

This commit closes this bug:

https://bugzilla.gnome.org/show_bug.cgi?id=666669

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

10 years agoRename onlineglom.properties to onlineglom.properties.sample.
Murray Cumming [Tue, 20 Dec 2011 09:12:14 +0000 (10:12 +0100)]
Rename onlineglom.properties to onlineglom.properties.sample.

* src/main/resources/onlineglom.properties: Rename to:
* src/main/resources/onlineglom.properties.sample:
* src/main/resources/README: And add this file explaining that people
should rename it back when deploying.

10 years agoAllow choosing the translation in the .properties file.
Murray Cumming [Tue, 20 Dec 2011 08:56:21 +0000 (09:56 +0100)]
Allow choosing the translation in the .properties file.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
init(): Read a glom.document.locale value from the configuration file
and call Glom's TransatableItem::set_current_locale() method.
* src/main/resources/onlineglom.properties: Add a commented-out
example of this new setting.

It would be better to add &lang=de_DE to the URL, but the current
libglom API does not allow us to do this easily. I am working on that.

10 years agoRevert unwanted change.
Murray Cumming [Tue, 20 Dec 2011 08:11:25 +0000 (09:11 +0100)]
Revert unwanted change.

10 years agoAvoid a crash in parsing of token parameters.
Murray Cumming [Mon, 19 Dec 2011 18:20:26 +0000 (19:20 +0100)]
Avoid a crash in parsing of token parameters.

* src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
ava: getTokenParams(): Do not crash if a parameter has a key but no
value, and ignore parameters with neither.

10 years agoHistory token building/handling: Improve use of token parameters.
Murray Cumming [Sat, 17 Dec 2011 22:23:58 +0000 (23:23 +0100)]
History token building/handling: Improve use of token parameters.

* src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
(HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
and buildParamsToken(HashMap), for use by derived classes.
Make the separator private because it is no longer be needed.
* src/main/java/org/glom/web/client/place/DetailsPlace.java
(DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
instead of manual string concatenation.
(DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
of hardcoded indices and awkward splitting code.
* src/main/java/org/glom/web/client/place/ListPlace.java
(ListPlace.Tokenizer.getToken): Use buildParamsToken()
instead of manual string concatenation.
(ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
of hardcoded indices and awkward splitting code.
This should fix bug #666420

10 years agoUpdate a URL in a comment
Murray Cumming [Sat, 17 Dec 2011 12:40:32 +0000 (13:40 +0100)]
Update a URL in a comment

10 years agoFix a Navgiation->Navigation typo in the code.
Murray Cumming [Fri, 16 Dec 2011 20:39:42 +0000 (21:39 +0100)]
Fix a Navgiation->Navigation typo in the code.

* src/main/java/org/glom/web/client/activity/DetailsActivity.java
Rename processNavgiation() to processNavigation().

10 years agoFix a seperator->separator typo in the code.
Murray Cumming [Fri, 16 Dec 2011 19:41:28 +0000 (20:41 +0100)]
Fix a seperator->separator typo in the code.

* src/main/java/org/glom/web/client/place/DetailsPlace.java
* src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
* src/main/java/org/glom/web/client/place/ListPlace.java: Just a
misspelling.

10 years agoCleanup some comments.
Ben Konrath [Thu, 15 Dec 2011 13:50:32 +0000 (14:50 +0100)]
Cleanup some comments.

* src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:

10 years agoReplace \n with <br/> for multiline text in the details view.
Ben Konrath [Wed, 14 Dec 2011 16:28:03 +0000 (17:28 +0100)]
Replace \n with <br/> for multiline text in the details view.

Vertical scrollbars are added when needed as well.

* src/main/java/org/glom/web/client/ui/details/DetailsCell.java:

10 years agoSpecify the font for document selection links.
Ben Konrath [Wed, 14 Dec 2011 11:21:28 +0000 (12:21 +0100)]
Specify the font for document selection links.

* src/main/webapp/style.css:

10 years agoFix bouncy CellTable while paging.
Ben Konrath [Wed, 14 Dec 2011 10:45:31 +0000 (11:45 +0100)]
Fix bouncy CellTable while paging.

This doesn't currently work with related list tables in unselected
Notebook tabs.

* src/main/java/org/glom/web/client/ui/list/ListTable.java

10 years agoRevamp the appearance of the document selection page.
Ben Konrath [Wed, 14 Dec 2011 10:01:20 +0000 (11:01 +0100)]
Revamp the appearance of the document selection page.

* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
* src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
* src/main/webapp/style.css:

10 years agoSet navigation button column to the smallest size possible.
Ben Konrath [Tue, 13 Dec 2011 19:34:36 +0000 (20:34 +0100)]
Set navigation button column to the smallest size possible.

* src/main/java/org/glom/web/client/ui/list/ListTable.java:

10 years agoChange OpenButton nomenclature to NavigationButton.
Ben Konrath [Tue, 13 Dec 2011 09:22:43 +0000 (10:22 +0100)]
Change OpenButton nomenclature to NavigationButton.

Using NavigtionButton makes things more generic. Classes, methods and
variables have been changed.

This is a rename-only refactor.

* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
* src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
Renamed from OpenButtonCell.
* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
* src/main/java/org/glom/web/client/ui/list/ListTable.java:
* src/main/java/org/glom/web/client/ui/list/ListViewTable.java:

10 years agoRemove unnecessary String argument in RelatedListTable and ListViewTable.
Ben Konrath [Mon, 12 Dec 2011 20:08:40 +0000 (21:08 +0100)]
Remove unnecessary String argument in RelatedListTable and ListViewTable.

* src/main/java/org/glom/web/client/activity/DetailsActivity.java:
* src/main/java/org/glom/web/client/ui/ListViewImpl.java:
* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
* src/main/java/org/glom/web/client/ui/list/ListViewTable.java:

10 years agoUpdate variable names and comments.
Ben Konrath [Mon, 12 Dec 2011 15:15:13 +0000 (16:15 +0100)]
Update variable names and comments.

* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
* src/main/java/org/glom/web/client/ui/list/ListViewTable.java:

10 years agoProperly initialize numNonEmptyRows variable to zero.
Ben Konrath [Mon, 12 Dec 2011 11:44:53 +0000 (12:44 +0100)]
Properly initialize numNonEmptyRows variable to zero.

* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
* src/main/java/org/glom/web/client/ui/list/ListViewTable.java:

10 years agoAdd latest mockup with HTML tables.
Ben Konrath [Mon, 5 Dec 2011 13:42:02 +0000 (14:42 +0100)]
Add latest mockup with HTML tables.

Features of this mockup:

-> HTML table for flowtable
-> HTML table for flowtable column
-> Example of how related lists would look
-> Not using text entries for data items

The current version of Online Glom doesn't use HTML tables for the
flowtable columns.

This mockup has been sent to the glom-devel mailing list but it's good
to have it here as well.

* mockups/details-view-html-tables.html:

10 years agoRemove unnecessary getPrimaryKeyField() method.
Ben Konrath [Mon, 5 Dec 2011 13:23:55 +0000 (14:23 +0100)]
Remove unnecessary getPrimaryKeyField() method.

getPrimaryKeyFieldForTable(String) has been renamed to
getPrimaryKeyField(String).

* src/main/java/org/glom/web/server/database/DBAccess.java:
* src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
* src/main/java/org/glom/web/server/database/RelatedListNavigation.java:

10 years agoAdd string representation of TypedDataItem value to conversion error message.
Ben Konrath [Mon, 5 Dec 2011 13:14:47 +0000 (14:14 +0100)]
Add string representation of TypedDataItem value to conversion error message.

* src/main/java/org/glom/web/server/Utils.java: Logging the error
message was extracted into its own method to avoid duplication.

10 years agoAdd type checking to navigation primary key value creation.
Ben Konrath [Mon, 5 Dec 2011 12:59:03 +0000 (13:59 +0100)]
Add type checking to navigation primary key value creation.

Create navigation primary key only if the expected type from the Glom
document matches the type returned by the SQL query.

* src/main/java/org/glom/web/server/database/RelatedListNavigation.java:

10 years agoRename a couple of variables in RelatedListNavigation.
Ben Konrath [Mon, 5 Dec 2011 12:29:59 +0000 (13:29 +0100)]
Rename a couple of variables in RelatedListNavigation.

This is a rename-only refactor.

* src/main/java/org/glom/web/server/database/RelatedListNavigation.java:

10 years agoMove getListLayoutGroup() into getListViewLayoutGroup().
Ben Konrath [Mon, 5 Dec 2011 12:26:29 +0000 (13:26 +0100)]
Move getListLayoutGroup() into getListViewLayoutGroup().

This removes getListLayoutGroup(). It was only being called by
getListViewLayoutGroup().

* src/main/java/org/glom/web/server/ConfiguredDocument.java:

10 years agoRemove check for LayoutItem_Portal in list table method.
Ben Konrath [Mon, 5 Dec 2011 12:15:14 +0000 (13:15 +0100)]
Remove check for LayoutItem_Portal in list table method.

This check is no longer necessary because the method isn't being used
to create the LayoutItemPortal DTO.

* src/main/java/org/glom/web/server/ConfiguredDocument.java:

10 years agoProperly support related list navigation.
Ben Konrath [Mon, 5 Dec 2011 12:10:44 +0000 (13:10 +0100)]
Properly support related list navigation.

Navigation from the "Repository Analyzer -> Package Scans ->
Dependencies" related table wasn't working because the primary key for
related tables wasn't being set properly. This commit fixes the
problem.

* src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
getListLayoutGroup() to create the LayoutItemPortal DTO. This method
doesn't set the primary key properly for related list tables.
* src/main/java/org/glom/web/server/database/DBAccess.java: Add table
name parameter to getPrimaryKeyLayoutItemField(). This makes the method
useful for getting the primary key for list view tables and for related
list tables.
* src/main/java/org/glom/web/server/database/ListDBAccess.java:
* src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
Move code to set the primary key for the table from the abstract
ListDBAccess class to ListViewDBAccess as it's only correct for list
view tables.
* src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
Properly add primary key to related list tables.

10 years agoProperly set the horizontal alignment of fields.
Ben Konrath [Fri, 2 Dec 2011 13:35:30 +0000 (14:35 +0100)]
Properly set the horizontal alignment of fields.

This fix is for both the list tables and the details view.

* src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
to set the horizontal alignment of fields.

10 years agoRevert "Align TYPE_NUMERIC with AUTO alignment to the right in list tables."
Ben Konrath [Fri, 2 Dec 2011 12:51:16 +0000 (13:51 +0100)]
Revert "Align TYPE_NUMERIC with AUTO alignment to the right in list tables."

This reverts commit 551ec2a81ab5b7df0f4ce97262cdc3b64b360f05.

10 years agoAlign TYPE_NUMERIC with AUTO alignment to the right in list tables.
Ben Konrath [Fri, 2 Dec 2011 12:23:06 +0000 (13:23 +0100)]
Align TYPE_NUMERIC with AUTO alignment to the right in list tables.

* src/main/java/org/glom/web/client/ui/list/ListTable.java:

10 years agoDisplay currency codes in the details view.
Ben Konrath [Fri, 2 Dec 2011 12:04:27 +0000 (13:04 +0100)]
Display currency codes in the details view.

* src/main/java/org/glom/web/client/ui/details/DetailsCell.java:

10 years agoAvoid duplicate JNI call.
Ben Konrath [Fri, 2 Dec 2011 11:23:32 +0000 (12:23 +0100)]
Avoid duplicate JNI call.

JNI is not as efficient as pure Java and this is an easy (and small)
optimization.

* src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
Use previously retrieved value for whereClauseToTableName instead of
getting it again.

10 years agoRename a couple of variables in RelatedListNavigation.
Ben Konrath [Fri, 2 Dec 2011 11:16:53 +0000 (12:16 +0100)]
Rename a couple of variables in RelatedListNavigation.

This is a rename-only refactor.

* src/main/java/org/glom/web/server/database/RelatedListNavigation.java:

10 years agoIndicate clearly that a mismatched primary key type is a bug.
Ben Konrath [Fri, 2 Dec 2011 11:07:30 +0000 (12:07 +0100)]
Indicate clearly that a mismatched primary key type is a bug.

* src/main/java/org/glom/web/server/Utils.java: Change log level from
warning to error. Add 'This is a bug.' to message.

10 years agoUpdate / fix some comments.
Ben Konrath [Fri, 2 Dec 2011 11:01:30 +0000 (12:01 +0100)]
Update / fix some comments.

* src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
comments.
* src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
comment.
* src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
Fix comments. Add some TODOs.

10 years agoEnable navigation to details view with string primary key from related list.
Ben Konrath [Fri, 2 Dec 2011 10:54:06 +0000 (11:54 +0100)]
Enable navigation to details view with string primary key from related list.

* src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
Create a text primary key value when return type of result is
java.sql.Types.VARCHAR.

10 years agoUse checkboxes for booleans in the details view.
Ben Konrath [Fri, 2 Dec 2011 10:01:42 +0000 (11:01 +0100)]
Use checkboxes for booleans in the details view.

* src/main/java/org/glom/web/client/ui/details/DetailsCell.java:

10 years agoImprove performance of related list height calculation.
Ben Konrath [Thu, 1 Dec 2011 17:27:18 +0000 (18:27 +0100)]
Improve performance of related list height calculation.

* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
Put code to calculate the expected height in a static initializer so
that that it's only called once.

10 years agoShow related list tables in notebooks (again).
Ben Konrath [Thu, 1 Dec 2011 16:41:35 +0000 (17:41 +0100)]
Show related list tables in notebooks (again).

Calculate the height of the related list tables so the Notebook can be
set the correct height. The height of the related list table is also needed by
FlowTable to be able decide how to create the layout.

* src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
and set the Portal height based on the height of the related list
table and the Portal container.
* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
Add method to calculate the height of the related list tables.
* src/main/java/org/glom/web/client/ui/list/ListTable.java:
* src/main/webapp/style.css: Add css class for Pager. This is needed to
calculate the height of the Pager widget.

10 years agoUse CellTable API for table property instead of setting style on Element.
Ben Konrath [Thu, 1 Dec 2011 15:02:19 +0000 (16:02 +0100)]
Use CellTable API for table property instead of setting style on Element.

* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:

10 years agoMake ListViewTable and RelatedListTable a consistent height.
Ben Konrath [Thu, 1 Dec 2011 12:02:55 +0000 (13:02 +0100)]
Make ListViewTable and RelatedListTable a consistent height.

The tables are now a consistent height regardless of the contents of
the table. A hidden button is added to empty rows to ensure that the
height of these rows will match the height of rows with data.

A navigation button column is now added to every table. The width of
the navigation column is set to 0px when a RelatedListTable shouldn't
have navigation buttons. This maintains the a consistent row height in
tables that don't show the navigation buttons.

* src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
navigation column when not needed.
* src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
arguments for navigation button to constructor of ListViewTable.
* src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
hidden button for empty data rows.
* src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
arguments for navigation button to constructor.
* src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
create navigation buttons. Add hideNavigationButtons() method.
* src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
arguments for navigation button to constructor.

10 years agoUse 'visibility: hidden' in Utils.getWidgetHeight().
Ben Konrath [Thu, 1 Dec 2011 10:50:29 +0000 (11:50 +0100)]
Use 'visibility: hidden' in Utils.getWidgetHeight().

This is better choice because hidden elements are invisible, don't
respond to events and are not part of the tab order. They will,
however, take up space which is required to be able to calculate the
height of the widget.

* src/main/java/org/glom/web/client/Utils.java:

10 years agoUse Utils.getWidgetHeight() in FlowTable.
Ben Konrath [Thu, 1 Dec 2011 10:30:31 +0000 (11:30 +0100)]
Use Utils.getWidgetHeight() in FlowTable.

* src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
this.
* src/main/java/org/glom/web/client/ui/details/FlowTable.java:

10 years agoPut the details css class name on the correct table column.
Ben Konrath [Thu, 1 Dec 2011 02:02:18 +0000 (03:02 +0100)]
Put the details css class name on the correct table column.

* src/main/java/org/glom/web/client/ui/list/ListTable.java:

10 years agoUpdate for java-libglom API change.
Ben Konrath [Wed, 30 Nov 2011 13:38:56 +0000 (14:38 +0100)]
Update for java-libglom API change.

The getters and setters on FieldFormatting and NumericFormat were
changed to remove the 'M'.

* src/main/java/org/glom/web/server/ConfiguredDocument.java:

10 years agoOnly allow RelatedListTables in Portals.
Ben Konrath [Tue, 29 Nov 2011 19:42:01 +0000 (20:42 +0100)]
Only allow RelatedListTables in Portals.

* src/main/java/org/glom/web/client/ui/details/Portal.java:

10 years agoOnly create a contents panel for Portals when title is being set.
Ben Konrath [Tue, 29 Nov 2011 19:32:49 +0000 (20:32 +0100)]
Only create a contents panel for Portals when title is being set.

* src/main/java/org/glom/web/client/ui/details/Portal.java:

10 years agoSet TabLayoutPanel height based on calculated height its widgets.
Ben Konrath [Tue, 29 Nov 2011 14:29:20 +0000 (15:29 +0100)]
Set TabLayoutPanel height based on calculated height its widgets.

This is a potential fix for this bug:

https://bugzilla.gnome.org/show_bug.cgi?id=665133

* src/main/java/org/glom/web/client/ui/details/Notebook.java:

10 years agoAlign details field labels and data with the Open buttons.
Ben Konrath [Tue, 29 Nov 2011 14:10:02 +0000 (15:10 +0100)]
Align details field labels and data with the Open buttons.

* src/main/webapp/style.css: